Unreviewed, rolling out r241272 and r241276.
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r241272 and r241276.
4         https://bugs.webkit.org/show_bug.cgi?id=194514
5
6         Broke the Apple Internal build and the fix requires human
7         intervention :( (Requested by dydz on #webkit).
8
9         Reverted changesets:
10
11         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
12         https://bugs.webkit.org/show_bug.cgi?id=191446
13         https://trac.webkit.org/changeset/241272
14
15         "Fix internal iOS build after r241272"
16         https://bugs.webkit.org/show_bug.cgi?id=191446
17         https://trac.webkit.org/changeset/241276
18
19 2019-02-11  Truitt Savell  <tsavell@apple.com>
20
21         Unreviewed, rolling out r241269.
22
23         Caused 5 layout tests crashes on Mac WK1
24
25         Reverted changeset:
26
27         "DumpRenderTree should report unknown options"
28         https://bugs.webkit.org/show_bug.cgi?id=191303
29         https://trac.webkit.org/changeset/241269
30
31 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
32
33         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
34         https://bugs.webkit.org/show_bug.cgi?id=194313
35
36         Reviewed by Tim Horton.
37
38         Add a helper to determine whether the web view is presenting modal UI.
39
40         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
41         (WTR::UIScriptController::isPresentingModally const):
42         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
43         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
44         (WTR::UIScriptController::isPresentingModally const):
45         * TestRunnerShared/UIScriptContext/UIScriptController.h:
46         * WebKitTestRunner/UIScriptControllerCocoa.mm:
47         (WTR::UIScriptController::calendarType const): Deleted.
48         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
49         (WTR::UIScriptController::isPresentingModally const):
50         (WTR::UIScriptController::calendarType const):
51         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
52         (WTR::UIScriptController::calendarType const):
53
54 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
55
56         GCHeapInspector: Show the retained sizes in more places
57         https://bugs.webkit.org/show_bug.cgi?id=194464
58
59         Reviewed by Simon Fraser.
60
61         * GCHeapInspector/gc-heap-inspector.html:
62         * GCHeapInspector/script/interface.js:
63         (HeapInspectorUtils.humanReadableSize):
64         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
65         (HeapInspectorUtils.spanForNode.span.span):
66         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
67         (HeapSnapshotInspector.prototype.buildRoots):
68
69 2019-02-11  Daniel Bates  <dabates@apple.com>
70
71         [iOS] Mouse/Touch/Pointer events are missing modifier keys
72         https://bugs.webkit.org/show_bug.cgi?id=191446
73         <rdar://problem/45929460>
74
75         Reviewed by Tim Horton.
76
77         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
78
79         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
80         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
81         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
82         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
83         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
84         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
85         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
86         * TestRunnerShared/UIScriptContext/UIScriptController.h:
87         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
88         (WTR::arrayLength):
89         (WTR::parseModifierArray):
90         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
91         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
92         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
93         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
94
95 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
96
97         DumpRenderTree should report unknown options
98         https://bugs.webkit.org/show_bug.cgi?id=191303
99
100         Reviewed by Frédéric Wang.
101
102         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
103         to report unknown options.
104         Added and assigned test options which are currently used in tests.
105
106         * DumpRenderTree/TestOptions.cpp:
107         (TestOptions::TestOptions):
108
109 2019-02-11  Truitt Savell  <tsavell@apple.com>
110
111         Unreviewed, rolling out r241229.
112
113         Revision broke internal builds for watchOS.
114
115         Reverted changeset:
116
117         "[Cocoa] Ask platform for generic font family mappings"
118         https://bugs.webkit.org/show_bug.cgi?id=187723
119         https://trac.webkit.org/changeset/241229
120
121 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
122
123         [WinCairo][MiniBrowser] Basic authentication always fails.
124         https://bugs.webkit.org/show_bug.cgi?id=194496
125
126         Reviewed by Don Olmstead.
127
128         * MiniBrowser/win/DialogHelper.h:
129         (Dialog::getText):
130
131 2019-02-11  Philippe Normand  <pnormand@igalia.com>
132
133         [GStreamer] GstMappedBuffer testsuite build fails
134         https://bugs.webkit.org/show_bug.cgi?id=194495
135
136         Reviewed by Carlos Garcia Campos.
137
138         Fix the build by explicitely adding the gstreamer1.0-audio include
139         directories to the include path.
140
141         * TestWebKitAPI/PlatformGTK.cmake:
142         * TestWebKitAPI/PlatformWPE.cmake:
143
144 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
145
146         [GTK][WPE] Add enable-javascript-markup setting
147         https://bugs.webkit.org/show_bug.cgi?id=193439
148
149         Reviewed by Michael Catanzaro.
150
151         Add test cases to check the new setting.
152
153         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
154         (testWebKitSettings):
155         (testWebKitSettingsJavaScriptMarkup):
156         (beforeAll):
157
158 2019-02-10  Darin Adler  <darin@apple.com>
159
160         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
161         https://bugs.webkit.org/show_bug.cgi?id=194485
162
163         Reviewed by Daniel Bates.
164
165         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
166
167 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
168
169         Add more tests for clampTo<>()
170         https://bugs.webkit.org/show_bug.cgi?id=194462
171
172         Reviewed by Geoffrey Garen.
173
174         Darin suggested to test the very last floating point number
175         at the boundaries when truncating to integer.
176         I added test for max/min and max-1/min-1.
177
178         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
179         (TestWebKitAPI::TEST):
180
181 2019-02-09  Darin Adler  <darin@apple.com>
182
183         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
184         https://bugs.webkit.org/show_bug.cgi?id=194021
185
186         Reviewed by Geoffrey Garen.
187
188         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
189         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
190         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
191
192 2019-02-09  Zalan Bujtas  <zalan@apple.com>
193
194         [LFC][IFC] Add intrinsic width support for basic inline containers
195         https://bugs.webkit.org/show_bug.cgi?id=194473
196
197         Reviewed by Antti Koivisto.
198
199         Expand tests coverage (11 new tests -> 798)
200
201         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
202
203 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
204
205         Fix MiniBrowser's entitlements
206         https://bugs.webkit.org/show_bug.cgi?id=192431
207
208         Reviewed by Joseph Pecoraro.
209
210         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
211         files, making it impossible to load any extension.
212
213         * MiniBrowser/MiniBrowser.entitlements:
214
215 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
216
217         [Cocoa] Ask platform for generic font family mappings
218         https://bugs.webkit.org/show_bug.cgi?id=187723
219         <rdar://problem/41892438>
220
221         Reviewed by Brent Fulgham.
222
223         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
224
225         * DumpRenderTree/mac/DumpRenderTree.mm:
226         (allowedFontFamilySet):
227         * WebKitTestRunner/mac/TestControllerMac.mm:
228         (WTR::allowedFontFamilySet):
229
230 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
231
232         [GTK] Implement back/forward touchpad gesture
233         https://bugs.webkit.org/show_bug.cgi?id=193919
234
235         Reviewed by Michael Catanzaro.
236
237         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
238         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
239
240 2019-02-08  Alex Christensen  <achristensen@webkit.org>
241
242         Add SPI to use networking daemon instead of XPC service
243         https://bugs.webkit.org/show_bug.cgi?id=194427
244
245         Reviewed by Geoffrey Garen
246
247         * MiniBrowser/MiniBrowser.entitlements:
248
249 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
250
251         [ews-build] Ensure that every builder in config.json has short name
252         https://bugs.webkit.org/show_bug.cgi?id=194461
253
254         Reviewed by Lucas Forschler.
255
256         * BuildSlaveSupport/ews-build/loadConfig.py:
257         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
258
259 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
260
261         [ews-build] Add short name to config.json
262         https://bugs.webkit.org/show_bug.cgi?id=194456
263
264         Reviewed by Lucas Forschler.
265
266         * BuildSlaveSupport/ews-build/config.json: Added short name.
267         * BuildSlaveSupport/ews-build/loadConfig.py:
268         (loadBuilderConfig): Set the short name as the builder description.
269
270 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
271
272         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
273         https://bugs.webkit.org/show_bug.cgi?id=194418
274
275         Reviewed by Lucas Forschler.
276
277         Do not include errors trying when finding crashlogs at the end of
278         a run-webkit-tests run since we don't process those errors.
279
280         * Scripts/webkitpy/port/darwin.py:
281         (DarwinPort._look_for_all_crash_logs_in_log_dir):
282         * Scripts/webkitpy/port/ios_device.py:
283         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
284         * Scripts/webkitpy/port/watch_device.py:
285         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
286
287 2019-02-08  Beth Dakin  <bdakin@apple.com>
288
289         Add afterScreenUpdates to WKSnapshotConfiguration
290         https://bugs.webkit.org/show_bug.cgi?id=194362
291         -and corresponding-
292         <rdar://problem/40655528> Please add an "after screen updates" property to 
293         WKSnapshotConfiguration (to solve blank snapshots)
294
295         Reviewed by Tim Horton.
296
297         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
298         (TEST):
299
300 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
301
302         clampTo(): do not convert the input to double when dealing with integers
303         https://bugs.webkit.org/show_bug.cgi?id=194263
304         <rdar://problem/47692312>
305
306         Reviewed by Darin Adler.
307
308         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
309         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
310         (TestWebKitAPI::testClampFloatingPointToInteger):
311         (TestWebKitAPI::testClampSameSignIntegers):
312         (TestWebKitAPI::testClampUnsignedToSigned):
313         (TestWebKitAPI::testClampSignedToUnsigned):
314
315 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
316
317         webkitpy: Respect --dedicated-simulators flag
318         https://bugs.webkit.org/show_bug.cgi?id=194416
319         <rdar://problem/47894722>
320
321         Reviewed by Lucas Forschler.
322
323         * Scripts/webkitpy/port/device_port.py:
324         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
325         available devices can be safely ignored.
326
327 2019-02-07  Keith Rollin  <krollin@apple.com>
328
329         Remove extra copy of 100x100-red.tga
330         https://bugs.webkit.org/show_bug.cgi?id=194371
331         <rdar://problem/47873465>
332
333         Reviewed by Said Abou-Hallawa.
334
335         In order to help it pass its tests, Bug 194190 added a second copy of
336         the file 100x100-red.tga. However, it turns out that this additional
337         file wasn't actually needed, and that that sole previous copy was
338         sufficient. At the same time, this second copy -- which was copied to
339         the same location in the build output as the first copy -- now caused
340         XCBuild to complain because there were two production rules for the
341         same output file. Address this by removing the newly-added extra copy.
342
343         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
344         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
345
346 2019-02-07  Alex Christensen  <achristensen@webkit.org>
347
348         Deprecate WKBundlePageSetDefersLoading
349         https://bugs.webkit.org/show_bug.cgi?id=191394
350
351         Reviewed by Dean Jackson.
352
353         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
354         (WTR::TestRunner::setDefersLoading):
355
356 2019-02-07  Zalan Bujtas  <zalan@apple.com>
357
358         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
359         https://bugs.webkit.org/show_bug.cgi?id=194391
360
361         Reviewed by Antti Koivisto.
362
363         * LayoutReloaded/misc/LFC-passing-tests.txt:
364
365 2019-02-06  Keith Rollin  <krollin@apple.com>
366
367         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
368         https://bugs.webkit.org/show_bug.cgi?id=193975
369         <rdar://problem/47643306>
370
371         Reviewed by Tim Horton.
372
373         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
374         the Info.plist file into the bundle. This step is not necessary as the
375         implicit "bundle up all the build products into a framework" build
376         phase does this already. Having the Copy Bundle Resources phase do
377         this causes a conflict under XCBuild, which objects to two build
378         phases producing the same file (Info.plist). Address this by removing
379         Info.plist from the Copy Bundle Resources phase.
380
381         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
382
383 2019-02-06  Keith Rollin  <krollin@apple.com>
384
385         Really enable the automatic checking and regenerations of .xcfilelists during builds
386         https://bugs.webkit.org/show_bug.cgi?id=194357
387         <rdar://problem/47861231>
388
389         Reviewed by Chris Dumez.
390
391         Bug 194124 was supposed to enable the automatic checking and
392         regenerating of .xcfilelist files during the build. While related
393         changes were included in that patch, the change to actually enable the
394         operation somehow was omitted. This patch actually enables the
395         operation. The check-xcfilelist.sh scripts now check
396         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
397         from the checking.
398
399         * DumpRenderTree/Scripts/check-xcfilelists.sh:
400         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
401
402 2019-02-06  David Kilzer  <ddkilzer@apple.com>
403
404         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
405         <https://webkit.org/b/194286>
406         <rdar://problem/47815558>
407
408         Reviewed by Alexey Proskuryakov.
409
410         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
411         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
412         WKRetainPtr<> to avoid leaking the WKDataRef.
413
414 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
415
416         Unreviewed, fix a typo
417
418         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
419
420 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
421
422         [GTK][WPE] force libpsl build to use ICU in jhbuild
423         https://bugs.webkit.org/show_bug.cgi?id=194288
424
425         Reviewed by Carlos Garcia Campos.
426
427         * gtk/jhbuild.modules:
428         Require ICU for libpsl build in jhbuild, like done in WPE.
429
430 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
431
432         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
433         https://bugs.webkit.org/show_bug.cgi?id=194209
434
435         Reviewed by Carlos Garcia Campos.
436
437         Enhance TestCookieManager to ensure this doesn't happen again.
438
439         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
440         (testCookieManagerPersistentStorage):
441         (beforeAll):
442
443 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
444
445         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
446         https://bugs.webkit.org/show_bug.cgi?id=194324
447
448         Reviewed by Andy Estes.
449
450         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
451         part of the name is already implicit, since this is in testing code in TestOptions.
452
453         * WebKitTestRunner/TestController.cpp:
454         (WTR::TestController::generateContextConfiguration const):
455         (WTR::updateTestOptionsFromTestHeader):
456         * WebKitTestRunner/TestOptions.h:
457         (WTR::TestOptions::hasSameInitializationOptions const):
458
459 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
460
461         [ews-build] Allow * as platform for builders and workers
462         https://bugs.webkit.org/show_bug.cgi?id=188533
463
464         Reviewed by Lucas Forschler.
465
466         * BuildSlaveSupport/ews-build/loadConfig.py:
467         (checkWorkersAndBuildersForConsistency):
468
469 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
470
471         [ews-build] Add few bots to config.json
472         https://bugs.webkit.org/show_bug.cgi?id=194304
473
474         Reviewed by Lucas Forschler.
475
476         * BuildSlaveSupport/ews-build/config.json:
477
478 2019-02-05  Keith Rollin  <krollin@apple.com>
479
480         Enable the automatic checking and regenerations of .xcfilelists during builds
481         https://bugs.webkit.org/show_bug.cgi?id=194124
482         <rdar://problem/47721277>
483
484         Reviewed by Tim Horton.
485
486         Bug 193790 add a facility for checking -- during build time -- that
487         any needed .xcfilelist files are up-to-date and for updating them if
488         they are not. This facility was initially opt-in by setting
489         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
490         the process seemed robust. Its now time to enable this facility and
491         make it opt-out. If there is a need to disable this facility, set and
492         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
493         running `make` or `build-webkit`, or before running Xcode from the
494         command line.
495
496         Additionally, remove the step that generates a list of source files
497         going into the UnifiedSources build step. It's only necessarily to
498         specify Sources.txt and SourcesCocoa.txt as inputs.
499
500         * Scripts/generate-xcfilelists:
501
502 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
503
504         [GTK][WPE] force libpsl build to use ICU in jhbuild
505         https://bugs.webkit.org/show_bug.cgi?id=194288
506
507         Reviewed by Philippe Normand.
508
509         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
510         This can cause build failures if libidn is detected but libunistring is not available.
511
512         Make sure that ICU is used for runtime and builtin PSL data.
513
514         * gtk/jhbuild.modules:
515         * wpe/jhbuild.modules:
516
517 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
518
519         [ews-app] Modified timestamp should be updated on updating data
520         https://bugs.webkit.org/show_bug.cgi?id=194295
521
522         Reviewed by Lucas Forschler.
523
524         * BuildSlaveSupport/ews-app/ews/models/build.py:
525         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
526         * BuildSlaveSupport/ews-app/ews/models/step.py:
527
528 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
529
530         Unreviewed, rolling out r240742.
531
532         Causes crashes on iOS simulator.
533
534         Reverted changeset:
535
536         "[iOS] Keyups for non-modifier keys identified as "Dead" when
537         not focused in a content-editable element"
538         https://bugs.webkit.org/show_bug.cgi?id=192824
539         https://trac.webkit.org/changeset/240742
540
541 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
542
543         run-webkit-tests emits message "...running None" when running tests
544         https://bugs.webkit.org/show_bug.cgi?id=194133
545         <rdar://problem/47724738>
546
547         Reviewed by Lucas Forschler.
548
549         * Scripts/webkitpy/xcode/device_type.py:
550         (DeviceType.__str__): Use both version mapping tables and use just the variant
551         name if no version name is available.
552         * Scripts/webkitpy/xcode/device_type_unittest.py:
553         (DeviceTypeTest):
554         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
555         an associated named.
556
557 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
558
559         [WPE] require python3-setuptools for meson build in jhbuild
560         https://bugs.webkit.org/show_bug.cgi?id=194287
561
562         Reviewed by Philippe Normand.
563
564         python3-setuptools is needed to build meson in jhbuild.
565         It is already required by the GTK port.
566
567         * wpe/install-dependencies:
568
569 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
570
571         [ews-app] Add method to save BuilderMapping to database
572         https://bugs.webkit.org/show_bug.cgi?id=194264
573
574         Reviewed by Lucas Forschler.
575
576         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
577         (BuilderMapping.__str__):
578         (BuilderMapping):
579         (BuilderMapping.save_mapping):
580         (BuilderMapping.update_mapping):
581         (BuilderMapping.get_existing_mapping):
582         (BuilderMapping.is_valid_mapping):
583
584 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
585
586         [ews-app] Add timestamp fields for BuilderMappings
587         https://bugs.webkit.org/show_bug.cgi?id=194266
588
589         Reviewed by Lucas Forschler.
590
591         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
592         (BuilderMapping):
593
594 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
595
596         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
597         https://bugs.webkit.org/show_bug.cgi?id=174816
598
599         Reviewed by Michael Catanzaro.
600
601         Add tests for webkit_uri_for_display().
602
603         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
604         (testURIForDisplayUnaffected):
605         (testURIForDisplayAffected):
606         (beforeAll):
607         (afterAll):
608         * TestWebKitAPI/glib/CMakeLists.txt:
609
610 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
611
612         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
613         https://bugs.webkit.org/show_bug.cgi?id=194158
614         <rdar://problem/47737268>
615
616         Rubber-stamped by Aakash Jain.
617
618         * Scripts/webkitpy/port/device_port.py:
619         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
620
621 2019-02-04  Said Abou-Hallawa  <said@apple.com>
622
623         [CG] Enable setAdditionalSupportedImageTypes for WK1
624         https://bugs.webkit.org/show_bug.cgi?id=194190
625
626         Reviewed by Tim Horton.
627
628         Add a test similar to the one under WebKit Cocoa but make it create a
629         WebView instead of a WKWebView.
630
631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
632         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
633         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
634         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
635         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
636         (TestWebKitAPI::runTest):
637         (TestWebKitAPI::TEST):
638
639 2019-02-04  Zalan Bujtas  <zalan@apple.com>
640
641         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
642         https://bugs.webkit.org/show_bug.cgi?id=194168
643
644         Reviewed by Simon Fraser.
645
646         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
647
648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
649         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
650         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
651         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
652         (TEST):
653         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
654         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
655
656 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
657
658         REGRESSION (r237269): webkit-patch what-broke is broken 
659         https://bugs.webkit.org/show_bug.cgi?id=193025
660
661         Reviewed by Aakash Jain.
662
663         * Scripts/webkitpy/common/host.py:
664         (Host.buildbot):
665         (Host.bugzilla): Renamed to 'buildbot'.
666
667 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
668
669         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
670         https://bugs.webkit.org/show_bug.cgi?id=194207
671
672         Reviewed by Tim Horton.
673
674         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
675         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
676         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
677         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
678         start and delete forwards to remove the original attachment.
679
680         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
681         (TestWebKitAPI::TEST):
682
683 2019-02-04  Youenn Fablet  <youenn@apple.com>
684
685         Capture state should be managed consistently when doing process swapping
686         https://bugs.webkit.org/show_bug.cgi?id=194122
687         <rdar://problem/47609293>
688
689         Reviewed by Eric Carlson.
690
691         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
692         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
693         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
694         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
695         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
696         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
697         (WTR::TestRunner::isDoingMediaCapture const):
698         * WebKitTestRunner/InjectedBundle/TestRunner.h:
699         * WebKitTestRunner/TestController.cpp:
700         (WTR::TestController::isDoingMediaCapture const):
701         * WebKitTestRunner/TestController.h:
702         * WebKitTestRunner/TestInvocation.cpp:
703         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
704         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
705         (WTR::TestController::isDoingMediaCapture const):
706
707 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
708
709         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
710         https://bugs.webkit.org/show_bug.cgi?id=194142
711
712         Reviewed by Ross Kirsling.
713
714         There three 'separator' variables in TestController.cpp. Renamed
715         it 'pathSeparator', and unified them.
716
717         * WebKitTestRunner/TestController.cpp:
718         (WTR::TestController::generateContextConfiguration const):
719         (WTR::createTestURL):
720         (WTR::TestController::platformAdjustContext):
721
722 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
723
724         Make setNeedsLayout on the root more explicitly about triggering its side-effects
725         https://bugs.webkit.org/show_bug.cgi?id=194198
726
727         Reviewed by Antti Koivisto.
728
729         No need to set the banner heights on navigation now, since Page stores them.
730
731         * MiniBrowser/mac/WK2BrowserWindowController.m:
732         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
733
734 2019-02-03  John Wilander  <wilander@apple.com>
735
736         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
737         https://bugs.webkit.org/show_bug.cgi?id=194104
738         <rdar://problem/47649991>
739
740         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
741
742         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
743         (TestWebKitAPI::TEST):
744             Changed numeric types from unsigned short to uint32_t.
745
746 2019-02-02  David Kilzer  <ddkilzer@apple.com>
747
748         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
749         <https://webkit.org/b/194178>
750         <rdar://problem/47753473>
751
752         Reviewed by Alexey Proskuryakov.
753
754         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
755         (WTR::uninstallFakeHelvetica): Pass nullptr into
756         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
757
758 2019-02-02  Zalan Bujtas  <zalan@apple.com>
759
760         [LFC] Initialize ICB's style with fixed width/height.
761         https://bugs.webkit.org/show_bug.cgi?id=194188
762
763         Reviewed by Antti Koivisto.
764
765         * LayoutReloaded/misc/LFC-passing-tests.txt:
766
767 2019-02-02  Zalan Bujtas  <zalan@apple.com>
768
769         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
770         https://bugs.webkit.org/show_bug.cgi?id=194185
771
772         Reviewed by Antti Koivisto.
773
774         * LayoutReloaded/misc/LFC-passing-tests.txt:
775
776 2018-12-16  Darin Adler  <darin@apple.com>
777
778         Convert additional String::format clients to alternative approaches
779         https://bugs.webkit.org/show_bug.cgi?id=192746
780
781         Reviewed by Alexey Proskuryakov.
782
783         * WebKitTestRunner/TestController.cpp:
784         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
785         as an intermediate in code that ultimately constructs a WTF::String.
786         (WTR::userMediaOriginHash): Use makeString.
787         (WTR::TestController::didNavigateWithNavigationData): More of the same.
788         (WTR::TestController::didPerformClientRedirect): Ditto.
789         (WTR::TestController::didPerformServerRedirect): Ditto.
790         (WTR::TestController::didUpdateHistoryTitle): Ditto.
791
792 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
793
794         [ews-build] Add unit test to verify builder keys
795         https://bugs.webkit.org/show_bug.cgi?id=194152
796
797         Reviewed by Lucas Forschler.
798
799         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
800         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
801
802 2019-02-01  Zalan Bujtas  <zalan@apple.com>
803
804         [LFC] Expand tests coverage (12 new tests -> 787)
805
806         Unreviewed test gardening.
807
808         * LayoutReloaded/misc/LFC-passing-tests.txt:
809
810 2019-02-01  Zalan Bujtas  <zalan@apple.com>
811
812         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
813         https://bugs.webkit.org/show_bug.cgi?id=194163
814
815         Reviewed by Simon Fraser.
816
817         775
818
819         * LayoutReloaded/misc/LFC-passing-tests.txt:
820
821 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
822
823         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
824         https://bugs.webkit.org/show_bug.cgi?id=194140
825         <rdar://problem/47728098>
826
827         Reviewed by Tim Horton.
828
829         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
830         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
831         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
832
833         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
834         test to induce an IPC deadlock when presenting a modal alert during touch start.
835
836         * WebKitTestRunner/InjectedBundle/TestRunner.h:
837         * WebKitTestRunner/TestController.cpp:
838         (WTR::runJavaScriptAlert):
839
840         Add a client callback function for running JavaScript alerts.
841
842         (WTR::TestController::createOtherPage):
843         (WTR::TestController::generateContextConfiguration const):
844
845         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
846         the fix in this patch.
847
848         (WTR::TestController::createWebViewWithOptions):
849
850         Plumb TestOptions to generateContextConfiguration.
851
852         (WTR::TestController::resetPreferencesToConsistentValues):
853         (WTR::TestController::resetStateToConsistentValues):
854         (WTR::updateTestOptionsFromTestHeader):
855         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
856         (WTR::TestController::handleJavaScriptAlert):
857         * WebKitTestRunner/TestController.h:
858         * WebKitTestRunner/TestInvocation.cpp:
859         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
860         * WebKitTestRunner/TestOptions.h:
861         (WTR::TestOptions::hasSameInitializationOptions const):
862
863 2019-02-01  Chris Dumez  <cdumez@apple.com>
864
865         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
866         https://bugs.webkit.org/show_bug.cgi?id=193740
867         <rdar://problem/47527267>
868
869         Reviewed by Alex Christensen.
870
871         Add API test coverage.
872
873         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
874
875 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
876
877         [ews-app] Add display name field to BuilderMapping model
878         https://bugs.webkit.org/show_bug.cgi?id=194153
879
880         Reviewed by Lucas Forschler.
881
882         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
883         (BuilderMapping):
884
885 2019-02-01  Youenn Fablet  <youenn@apple.com>
886
887         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
888         https://bugs.webkit.org/show_bug.cgi?id=194155
889
890         Reviewed by Eric Carlson.
891
892         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
893         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
894         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
895
896 2019-02-01  Zalan Bujtas  <zalan@apple.com>
897
898         [LFC] Adjust replaced element's intrinsic ratio
899         https://bugs.webkit.org/show_bug.cgi?id=194154
900
901         Reviewed by Antti Koivisto.
902
903         761
904
905         * LayoutReloaded/misc/LFC-passing-tests.txt:
906
907 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
908
909         [WPE] Show test results in minibrowser
910         https://bugs.webkit.org/show_bug.cgi?id=194150
911
912         Reviewed by Žan Doberšek.
913
914         * Scripts/webkitpy/port/wpe.py:
915         (WPEPort.show_results_html_file):
916
917 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
918
919         [WPE] MiniBrowser: add ky bindings for back/forward navigation
920         https://bugs.webkit.org/show_bug.cgi?id=194151
921
922         Reviewed by Žan Doberšek.
923
924         ALT + <- go back
925         ALT + -> go forward
926
927         * MiniBrowser/wpe/main.cpp:
928         (main):
929
930 2019-02-01  Zalan Bujtas  <zalan@apple.com>
931
932         [LFC] Set intrinsic size on Layout::Replaced
933         https://bugs.webkit.org/show_bug.cgi?id=194139
934
935         Reviewed by Antti Koivisto.
936
937         744
938
939         * LayoutReloaded/misc/LFC-passing-tests.txt:
940
941 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
942
943         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
944         https://bugs.webkit.org/show_bug.cgi?id=194146
945
946         Reviewed by Xabier Rodriguez-Calvar.
947
948         It allows to open relative paths.
949
950         * MiniBrowser/wpe/main.cpp:
951         (main):
952
953 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
954
955         Update flakiness dashboard configuration after recent queue changes
956         https://bugs.webkit.org/show_bug.cgi?id=194127
957
958         Rubber-stamped by Aakash Jain.
959
960         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
961
962         * TestResultServer/static-dashboards/builders.jsonp:
963
964 2019-01-31  Youenn Fablet  <youenn@apple.com>
965
966         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
967         https://bugs.webkit.org/show_bug.cgi?id=194106
968         <rdar://problem/47676333>
969
970         Reviewed by Ryosuke Niwa.
971
972         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
973         (TestWebKitAPI::didFinishNavigation):
974         (TestWebKitAPI::TEST):
975         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
976
977 2019-01-31  Chris Dumez  <cdumez@apple.com>
978
979         Page zoom level is lost after a process swap or a crash
980         https://bugs.webkit.org/show_bug.cgi?id=194105
981         <rdar://problem/47610781>
982
983         Reviewed by Alex Christensen.
984
985         Add API test coverage.
986
987         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
988         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
989
990 2019-01-31  Alex Christensen  <achristensen@webkit.org>
991
992         Revert r238819 which is unneeded and caused a performance regression.
993         https://bugs.webkit.org/show_bug.cgi?id=192272
994         <rdar://problem/46664625>
995
996         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
997         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
998         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
999
1000 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1001
1002         Formalize WebKitAdditions mechanism of LoadOptimizer
1003         https://bugs.webkit.org/show_bug.cgi?id=193886
1004         <rdar://problem/47696809>
1005
1006         Reviewed by Brent Fulgham.
1007
1008         * MiniBrowser/MiniBrowser.entitlements:
1009         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1010
1011 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1012
1013         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1014         https://bugs.webkit.org/show_bug.cgi?id=194090
1015
1016         Reviewed by Antti Koivisto.
1017
1018         * LayoutReloaded/misc/LFC-passing-tests.txt:
1019
1020 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1021
1022         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1023         https://bugs.webkit.org/show_bug.cgi?id=194074
1024
1025         Reviewed by Antti Koivisto.
1026
1027         * LayoutReloaded/misc/LFC-passing-tests.txt:
1028
1029 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1030
1031         [LFC][BFC] Add support for block level replaced box.
1032         https://bugs.webkit.org/show_bug.cgi?id=194071
1033
1034         Reviewed by Antti Koivisto.
1035
1036         * LayoutReloaded/misc/LFC-passing-tests.txt:
1037
1038 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1039
1040         Fix WebKitTestRunner's testPath with Windows full paths
1041         https://bugs.webkit.org/show_bug.cgi?id=194012
1042
1043         Reviewed by Alex Christensen.
1044
1045         updateTestOptionsFromTestHeader failed to open test files because
1046         testPath returned wrong file paths. It returned a path "/C:/..."
1047         if a URL "file:///C:/..." was given.
1048
1049         * WebKitTestRunner/TestController.cpp:
1050         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1051
1052 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1053
1054         [WPE] Bump font related dependencies to match the GTK+ port
1055         https://bugs.webkit.org/show_bug.cgi?id=194017
1056
1057         Reviewed by Žan Doberšek.
1058
1059         * wpe/jhbuild.modules:
1060         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1061         * wpe/patches/icudata-stdlibs.patch: Added.
1062
1063 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1064
1065         Enable swipe tests on iOS
1066         https://bugs.webkit.org/show_bug.cgi?id=194076
1067
1068         Reviewed by Geoffrey Garen.
1069
1070         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1071         it causes a debug assertion failure in runUIScript.
1072
1073         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1074         (WTR::UIScriptController::beginBackSwipe):
1075         (WTR::UIScriptController::completeBackSwipe):
1076
1077 2019-01-30  Keith Rollin  <krollin@apple.com>
1078
1079         Use correct printf format specifier
1080         https://bugs.webkit.org/show_bug.cgi?id=194062
1081         <rdar://problem/47686167>
1082
1083         Reviewed by Alexey Proskuryakov.
1084
1085         LayoutTestSpellChecker.mm is trying to format a variable of type
1086         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1087         actually an unsigned long long. Fix this by formatting with %llu.
1088
1089         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1090         (-[LayoutTestTextCheckingResult description]):
1091
1092 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1093
1094         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1095         https://bugs.webkit.org/show_bug.cgi?id=193979
1096
1097         Reviewed by Wenson Hsieh.
1098
1099         Fix the test for iOS. Make the test work with iOS UA string.
1100
1101         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1102
1103 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1104
1105         Replace High Sierra LLINT CLoop bot due to hardware failure
1106         https://bugs.webkit.org/show_bug.cgi?id=194066
1107
1108         Reviewed by Aakash Jain.
1109
1110         * BuildSlaveSupport/build.webkit.org-config/config.json:
1111
1112 2019-01-30  Keith Rollin  <krollin@apple.com>
1113
1114         [NSDragItem init] is unavailable
1115         https://bugs.webkit.org/show_bug.cgi?id=194059
1116         <rdar://problem/47685715>
1117
1118         Reviewed by Wenson Hsieh.
1119
1120         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1121         DumpRenderTree and TestWebKitAPI, which both try to create an
1122         NSDragItem in a manner that invokes this method. Address this by using
1123         -initWithPasteboardWriter instead.
1124
1125         Note that the parameter passed to initWithPasteboardWriter is likely
1126         incorrect. In both cases, the object passed does not conform to
1127         NSPasteboardWriting. However, with this fix, we're no worse off than
1128         before, and can now perform builds with newer compilers and SDKs until
1129         a real fix can be crafted. That work is tracked in
1130         https://bugs.webkit.org/show_bug.cgi?id=194060
1131
1132         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1133         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1134         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1135         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1136
1137 2019-01-30  Daniel Bates  <dabates@apple.com>
1138
1139         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1140         https://bugs.webkit.org/show_bug.cgi?id=192824
1141         <rdar://problem/47100332>
1142
1143         Reviewed by Wenson Hsieh.
1144
1145         Fix a bug where the wrong usage code was used for F13 thru F24.
1146
1147         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1148         (keyCodeForDOMFunctionKey):
1149
1150 2019-01-30  Chris Dumez  <cdumez@apple.com>
1151
1152         Regression(PSON) Load hang can occur on history navigation
1153         https://bugs.webkit.org/show_bug.cgi?id=194030
1154         <rdar://problem/47656939>
1155
1156         Reviewed by Antti Koivisto.
1157
1158         Add API test coverage.
1159
1160         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1161
1162 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1163
1164         [LFC] Expand tests coverage.
1165
1166         Unreviewed test gardening.
1167
1168         * LayoutReloaded/misc/LFC-passing-tests.txt:
1169
1170 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1171
1172         [Flatpak] Add openjpeg support
1173         https://bugs.webkit.org/show_bug.cgi?id=194019
1174
1175         Reviewed by Michael Catanzaro.
1176
1177         * flatpak/org.webkit.CommonModules.yaml:
1178
1179 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1180
1181         Unreviewed, rolling out r240708.
1182         https://bugs.webkit.org/show_bug.cgi?id=194022
1183
1184         It broke WPE build (Requested by KaL on #webkit).
1185
1186         Reverted changeset:
1187
1188         "[WPE] Bump font related dependencies to match the GTK+ port"
1189         https://bugs.webkit.org/show_bug.cgi?id=194017
1190         https://trac.webkit.org/changeset/240708
1191
1192 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1193
1194         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1195         https://bugs.webkit.org/show_bug.cgi?id=194001
1196
1197         Reviewed by Antti Koivisto.
1198
1199         * LayoutReloaded/misc/LFC-passing-tests.txt:
1200
1201 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1202
1203         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1204         https://bugs.webkit.org/show_bug.cgi?id=194020
1205
1206         Reviewed by Antti Koivisto.
1207
1208         * LayoutReloaded/misc/LFC-passing-tests.txt:
1209
1210 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1211
1212         AX: Support color well on iOS
1213         https://bugs.webkit.org/show_bug.cgi?id=194010
1214
1215         Reviewed by Joanmarie Diggs.
1216
1217         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1218         (WTR::AccessibilityUIElement::stringAttributeValue):
1219
1220 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1221
1222         [WPE] Bump font related dependencies to match the GTK+ port
1223         https://bugs.webkit.org/show_bug.cgi?id=194017
1224
1225         Reviewed by Žan Doberšek.
1226
1227         * wpe/jhbuild.modules:
1228         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1229         * wpe/patches/icudata-stdlibs.patch: Added.
1230
1231 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1232
1233         [Mac] Update window scale API usage
1234         https://bugs.webkit.org/show_bug.cgi?id=193991
1235         rdar://problem/47614795
1236
1237         Reviewed by Tim Horton.
1238
1239         * DumpRenderTree/mac/DumpRenderTree.mm:
1240         (changeWindowScaleIfNeeded):
1241         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1242         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1243         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1244
1245 2019-01-29  Chris Dumez  <cdumez@apple.com>
1246
1247         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1248         https://bugs.webkit.org/show_bug.cgi?id=193977
1249         <rdar://problem/47643716>
1250
1251         Reviewed by Geoff Garen.
1252
1253         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1254         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1255         to the previous provisional committing *before* we make the last load. 
1256
1257         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1258
1259 2019-01-29  Youenn Fablet  <youenn@apple.com>
1260
1261         Adopt new SPI to evaluate server certificate trust
1262         https://bugs.webkit.org/show_bug.cgi?id=193355
1263
1264         Reviewed by Alex Christensen.
1265
1266         Add infrastructure to handle HTTPS server trust evaluation testing.
1267
1268         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1269         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1270         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1271         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1272         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1273         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1274         * WebKitTestRunner/TestController.cpp:
1275         (WTR::TestController::resetPreferencesToConsistentValues):
1276         (WTR::TestController::didReceiveAuthenticationChallenge):
1277         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1278         * WebKitTestRunner/TestController.h:
1279         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1280         * WebKitTestRunner/TestInvocation.cpp:
1281         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1282         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1283         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1284
1285 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1286
1287         [ews-build] Add build step to print bot Configuration
1288         https://bugs.webkit.org/show_bug.cgi?id=193887
1289
1290         Reviewed by Lucas Forschler.
1291
1292         * BuildSlaveSupport/ews-build/steps.py:
1293         (PrintConfiguration): Build step to print configuration.
1294         * BuildSlaveSupport/ews-build/factories.py:
1295
1296 2019-01-29  Chris Dumez  <cdumez@apple.com>
1297
1298         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1299         https://bugs.webkit.org/show_bug.cgi?id=193967
1300         <rdar://problem/47635348>
1301
1302         Reviewed by Alex Christensen.
1303
1304         Add API test coverage.
1305
1306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1307         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1308
1309 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1310
1311         [ews-app] Handle incoming results data
1312         https://bugs.webkit.org/show_bug.cgi?id=193973
1313
1314         Reviewed by Lucas Forschler.
1315
1316         * BuildSlaveSupport/ews-app/ews/views/results.py:
1317
1318 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1319
1320         [ews-app] Make the results url generic
1321         https://bugs.webkit.org/show_bug.cgi?id=193928
1322
1323         Reviewed by Lucas Forschler.
1324
1325         * BuildSlaveSupport/ews-app/ews/urls.py:
1326
1327 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1328
1329         [ews-build] Configure buildbot to send events to ews-app
1330         https://bugs.webkit.org/show_bug.cgi?id=193968
1331
1332         Reviewed by Lucas Forschler.
1333
1334         * BuildSlaveSupport/ews-build/events.py: Added.
1335         * BuildSlaveSupport/ews-build/master.cfg:
1336
1337 2019-01-29  Keith Rollin  <krollin@apple.com>
1338
1339         Add .xcfilelists to Run Script build phases
1340         https://bugs.webkit.org/show_bug.cgi?id=193792
1341         <rdar://problem/47201785>
1342
1343         Reviewed by Alex Christensen.
1344
1345         As part of supporting XCBuild, update the necessary Run Script build
1346         phases in their Xcode projects to refer to their associated
1347         .xcfilelist files.
1348
1349         Note that the addition of these files bumps the Xcode project version
1350         number to something that's Xcode 10 compatible. This change means that
1351         older versions of the Xcode IDE can't read these projects. Nor can it
1352         fully load workspaces that refer to these projects (the updated
1353         projects are shown as non-expandable placeholders). `xcodebuild` can
1354         still build these projects; it's just that the IDE can't open them.
1355
1356         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1357         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1358
1359 2019-01-29  John Wilander  <wilander@apple.com>
1360
1361         Add data abstraction and validation for Ad Click Attribution
1362         https://bugs.webkit.org/show_bug.cgi?id=193916
1363         <rdar://problem/47603481>
1364
1365         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1366
1367         Ad click attribution has two steps. First, the storage of an ad
1368         campaign ID for a click that takes the user to a destination
1369         site. Second, a conversion on the destination site that can be
1370         attributed to the ad click.
1371
1372         This patch adds a class that represents a request for ad click
1373         attribution. Validation makes sure that the bits of entropy
1374         reported through this mechanism is limited.
1375
1376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1377         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1378         (TestWebKitAPI::TEST):
1379
1380 2019-01-29  Chris Dumez  <cdumez@apple.com>
1381
1382         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1383         https://bugs.webkit.org/show_bug.cgi?id=193932
1384         <rdar://problem/47598947>
1385
1386         Reviewed by Brady Eidson.
1387
1388         Add API test coverage.
1389
1390         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1391
1392 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1393
1394         Adding new passing LFC tests.
1395
1396         Unreviewed test gardening.
1397
1398         * LayoutReloaded/misc/LFC-passing-tests.txt:
1399
1400 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1401
1402         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1403         https://bugs.webkit.org/show_bug.cgi?id=193964
1404
1405         Reviewed by Antti Koivisto.
1406
1407         * LayoutReloaded/misc/LFC-passing-tests.txt:
1408
1409 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1410
1411         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1412         https://bugs.webkit.org/show_bug.cgi?id=193954
1413
1414         Reviewed by Antti Koivisto.
1415
1416         * LayoutReloaded/misc/LFC-passing-tests.txt:
1417
1418 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1419
1420         WebDriver: add support for running subtests
1421         https://bugs.webkit.org/show_bug.cgi?id=193904
1422
1423         Reviewed by Michael Catanzaro.
1424
1425         pytest already supports it by passing test.py::subtest, so we can do the same.
1426
1427         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1428         (get_item_name): Made this global.
1429         (CollectRecorder.__init__): Receive the parameter to ignore.
1430         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1431         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1432         (collect): Add parameter to ignore.
1433         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1434         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1435         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1436         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1437         (WebDriverTestRunnerSelenium.run): Ditto.
1438         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1439         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1440         (WebDriverTestRunnerW3C.run): Ditto.
1441
1442 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1443
1444         User agent string override for navigator.userAgent should be site specific quirks
1445         https://bugs.webkit.org/show_bug.cgi?id=193950
1446
1447         Reviewed by Brent Fulgham.
1448
1449         Updated per the _WKWebsitePolicies rename.
1450
1451         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1452         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1453
1454 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1455
1456         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1457         https://bugs.webkit.org/show_bug.cgi?id=193941
1458
1459         Reviewed by Alex Christensen.
1460
1461         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1462         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1463         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1464         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1465         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1466         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1467         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1468         * TestWebKitAPI/Tests/WTF/Time.cpp:
1469         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1470         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1471         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1472         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1473
1474 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1475
1476         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1477
1478         * Scripts/webkitpy/common/config/contributors.json:
1479
1480 2019-01-28  Andy Estes  <aestes@apple.com>
1481
1482         [watchOS] Enable Parental Controls content filtering
1483         https://bugs.webkit.org/show_bug.cgi?id=193939
1484         <rdar://problem/46641912>
1485
1486         Reviewed by Ryosuke Niwa.
1487
1488         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1489
1490 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1491
1492         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1493         <https://webkit.org/b/193884>
1494
1495         Reviewed by Jiewen Tan.
1496
1497         * Scripts/webkitpy/style/checkers/cpp.py:
1498         (check_language): Add LocalAuthentication to
1499         `frameworks_with_soft_links`.
1500
1501 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1502
1503         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1504         https://bugs.webkit.org/show_bug.cgi?id=193891
1505
1506         Reviewed by Ross Kirsling.
1507
1508         There were three problems in window sizes of WebView and the host window.
1509         1. The sizes of pixel image output were incorrect.
1510         2. The host window is going to appear after window.resize was invoked.
1511         3. window.resize resized only the host window, not WebView.
1512
1513         This change solves them with a following approach.
1514         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1515         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1516            as well as DumpRenderTree in order to match the client area and the window area.
1517         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1518         d. PlatformWebView::setWindowFrame changes both window sizes.
1519         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1520
1521         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1522         (WTR::PlatformWebView::PlatformWebView): Create the host window
1523         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1524         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1525         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1526
1527 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1528
1529         [ews-app] Add method to save Step data to database
1530         https://bugs.webkit.org/show_bug.cgi?id=193890
1531
1532         Reviewed by Lucas Forschler.
1533
1534         * BuildSlaveSupport/ews-app/ews/models/step.py:
1535         (Step.save_step): Method to save step data.
1536         (Step.update_step): Method to update step data.
1537         (Step.get_existing_step): Method to fetch existing step from database.
1538         (Step.is_valid_result): Method to validate valid step result.
1539
1540 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1541
1542         [ews-app] Add method to save Build data to database
1543         https://bugs.webkit.org/show_bug.cgi?id=193735
1544
1545         Reviewed by Lucas Forschler.
1546
1547         * BuildSlaveSupport/ews-app/ews/models/build.py:
1548         (Build.save_build): Method to save build information to database.
1549         (Build.get_existing_build): Method to fetch existing build from database.
1550         (Build.is_valid_result): Method to validate build result.
1551         * BuildSlaveSupport/ews-app/ews/common/util.py:
1552         (is_valid_int_id): Method to validate valid id.
1553
1554 2019-01-28  Chris Dumez  <cdumez@apple.com>
1555
1556         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1557         https://bugs.webkit.org/show_bug.cgi?id=193915
1558         <rdar://problem/47560907>
1559
1560         Reviewed by Alex Christensen.
1561
1562         Add API test coverage.
1563
1564         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1565
1566 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1567
1568         [ews-app] Rename id variables
1569         https://bugs.webkit.org/show_bug.cgi?id=193883
1570
1571         Reviewed by Lucas Forschler.
1572
1573         * BuildSlaveSupport/ews-app/ews/models/build.py:
1574         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1575         * BuildSlaveSupport/ews-app/ews/models/step.py:
1576         * BuildSlaveSupport/ews-app/ews/urls.py:
1577         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1578         * BuildSlaveSupport/ews-app/ews/views/results.py:
1579         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1580
1581 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1582
1583         [ews-app] Allow certain fields to be empty
1584         https://bugs.webkit.org/show_bug.cgi?id=193892
1585
1586         Reviewed by Lucas Forschler.
1587
1588         * BuildSlaveSupport/ews-app/ews/models/build.py:
1589         * BuildSlaveSupport/ews-app/ews/models/step.py:
1590
1591 2019-01-28  Rob Buis  <rbuis@igalia.com>
1592
1593         Update MIME type parser
1594         https://bugs.webkit.org/show_bug.cgi?id=180526
1595
1596         Reviewed by Frédéric Wang.
1597
1598         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1599         (TestWebKitAPI::TEST):
1600
1601 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1602
1603         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1604         https://bugs.webkit.org/show_bug.cgi?id=193896
1605
1606         Reviewed by Antti Koivisto.
1607
1608         * LayoutReloaded/misc/LFC-passing-tests.txt:
1609
1610 2018-12-15  Darin Adler  <darin@apple.com>
1611
1612         Replace many uses of String::format with more type-safe alternatives
1613         https://bugs.webkit.org/show_bug.cgi?id=192742
1614
1615         Reviewed by Mark Lam.
1616
1617         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1618         (WTR::cacheTestRunnerCallback): Use makeString.
1619         * WebKitTestRunner/TestController.cpp:
1620         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1621         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1622
1623 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1624
1625         Use a load optimizer for some sites
1626         https://bugs.webkit.org/show_bug.cgi?id=193881
1627         <rdar://problem/46325455>
1628
1629         Reviewed by Brent Fulgham.
1630
1631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1632         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1633
1634 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1635
1636         AX: Introduce a static accessibility tree
1637         https://bugs.webkit.org/show_bug.cgi?id=193348
1638         <rdar://problem/47203295>
1639
1640         Reviewed by Ryosuke Niwa.
1641
1642         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1643
1644 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1645
1646         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1647         https://bugs.webkit.org/show_bug.cgi?id=193867
1648
1649         Reviewed by Antti Koivisto.
1650
1651         * LayoutReloaded/misc/LFC-passing-tests.txt:
1652
1653 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1654
1655         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1656         https://bugs.webkit.org/show_bug.cgi?id=193865
1657
1658         Reviewed by Antti Koivisto.
1659
1660         * LayoutReloaded/misc/LFC-passing-tests.txt:
1661
1662 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1663
1664         Need a mechanism to override navigator.userAgent
1665         https://bugs.webkit.org/show_bug.cgi?id=193762
1666         <rdar://problem/47504939>
1667
1668         Reviewed by Brent Fulgham.
1669
1670         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1671
1672         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1673         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1674         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1675
1676 2019-01-25  Dean Jackson  <dino@apple.com>
1677
1678         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1679         https://bugs.webkit.org/show_bug.cgi?id=193831
1680         <rdar://problem/47399263>
1681
1682         Reviewed by Chris Dumez.
1683
1684         Two new tests that exercise cross-origin and same-origin System
1685         Previews.
1686
1687         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1688
1689 2019-01-25  Keith Rollin  <krollin@apple.com>
1690
1691         Update Xcode projects with "Check .xcfilelists" build phase
1692         https://bugs.webkit.org/show_bug.cgi?id=193790
1693         <rdar://problem/47201374>
1694
1695         Reviewed by Alex Christensen.
1696
1697         Support for XCBuild includes specifying inputs and outputs to various
1698         Run Script build phases. These inputs and outputs are specified as
1699         .xcfilelist files. Once created, these .xcfilelist files need to be
1700         kept up-to-date. In order to check that they are up-to-date or not,
1701         add an Xcode build step that invokes an external script that performs
1702         the checking. If the .xcfilelists are found to be out-of-date, update
1703         them, halt the build, and instruct the developer to restart the build
1704         with up-to-date files.
1705
1706         At this time, the checking and regenerating is performed only if the
1707         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1708         who want to use this facility can set this variable and test out the
1709         checking/regenerating. Once it seems like there are no egregious
1710         issues that upset a developer's workflow, we'll unconditionally enable
1711         this facility.
1712
1713         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1714         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1715         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1716         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1717
1718 2019-01-25  Keith Rollin  <krollin@apple.com>
1719
1720         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1721         https://bugs.webkit.org/show_bug.cgi?id=193781
1722         <rdar://problem/47201153>
1723
1724         Reviewed by Alex Christensen.
1725
1726         Part of generating the .xcfilelists used as part of adopting XCBuild
1727         includes running `make DerivedSources.make` from a standalone script.
1728         It’s important for this invocation to have the same environment as
1729         when the actual build invokes `make DerivedSources.make`. If the
1730         environments are different, then the two invocations will provide
1731         different results. In order to get the same environment in the
1732         standalone script, have the script launch xcodebuild targeting the
1733         "Apply Configuration to XCFileLists" build target, which will then
1734         re-invoke our standalone script. The script is now running again, this
1735         time in an environment with all workspace, project, target, xcconfig
1736         and other environment variables established.
1737
1738         The "Apply Configuration to XCFileLists" build target accomplishes
1739         this task via a small embedded shell script that consists only of:
1740
1741             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1742
1743         The process that invokes "Apply Configuration to XCFileLists" first
1744         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1745         evaluated and exports it into the shell environment. When xcodebuild
1746         is invoked, it inherits the value of this variable and can `eval` the
1747         contents of that variable. Our external standalone script can then set
1748         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1749         of command-line parameters needed to restart itself in the appropriate
1750         state.
1751
1752         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1753         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1754
1755 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1756
1757         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1758         https://bugs.webkit.org/show_bug.cgi?id=193802
1759         <rdar://problem/46010580>
1760
1761         Reviewed by Andy Estes.
1762
1763         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1764         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1765         (TEST):
1766
1767 2019-01-25  Daniel Bates  <dabates@apple.com>
1768
1769         [iOS] uiController.keyDown() does not translate Control modified key
1770         https://bugs.webkit.org/show_bug.cgi?id=192898
1771
1772         Reviewed by Wenson Hsieh.
1773
1774         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1775         key translation, as applicable. Among other cases, key translation occurs when performing
1776         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1777         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1778         human pressing down and releasing key(s) using a hardware keyboard.
1779
1780         * WebKitTestRunner/ios/HIDEventGenerator.h:
1781         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1782         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1783
1784         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1785         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1786         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1787         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1788         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1789         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1790         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1791         (-[HIDEventGenerator longPress:completionBlock:]):
1792         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1793         Update code for above renaming.
1794
1795         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1796         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1797
1798         (-[HIDEventGenerator keyDown:]): Added.
1799         (-[HIDEventGenerator keyUp:]): Added.
1800         (-[HIDEventGenerator keyPress:completionBlock:]):
1801         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1802         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1803         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1804         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1805         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1806         (WTR::parseModifier): Deleted.
1807
1808 2019-01-25  Keith Rollin  <krollin@apple.com>
1809
1810         Complete the implementation of generate-xcfilelists
1811         https://bugs.webkit.org/show_bug.cgi?id=193782
1812
1813         Reviewed by Alex Christensen.
1814
1815         A preliminary version of generate-xcfilelists was added in r238008.
1816         This patch updates that script in order to:
1817
1818         - Support checking of .xcfilelists
1819         - Perform better execution of `make DerivedSources.make` by
1820           relaunching generate-xcfilelists under xcodebuild
1821         - Support incremental generation and checking of .xcfilelists
1822         - Support supplementary .xcfilelists files from WebKitAdditions
1823         - Support being wrapped by parallel version of generate-xcfilelists in
1824           Internal that adds support for (re)generating WebKit projects in
1825           that repo.
1826         - Support builds that have been performed in WebKitBuild as well as
1827           ~/Library/Developer/code/DerivedData
1828         - Increase robustness and debugging facilities.
1829
1830         * Scripts/generate-xcfilelists:
1831
1832 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1833
1834         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1835         https://bugs.webkit.org/show_bug.cgi?id=193297
1836         <rdar://problem/47158841>
1837
1838         Unreviewed test case fix.
1839
1840         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1841         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1842
1843         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1844         (TEST):
1845
1846 2019-01-25  Keith Rollin  <krollin@apple.com>
1847
1848         Update existing .xcfilelists
1849         https://bugs.webkit.org/show_bug.cgi?id=193791
1850         <rdar://problem/47201706>
1851
1852         Reviewed by Alex Christensen.
1853
1854         Many .xcfilelist files were added in r238824 in order to support
1855         XCBuild. Update these with recent changes to the set of build files
1856         and with the current generate-xcfilelist script.
1857
1858         * DumpRenderTree/DerivedSources-input.xcfilelist:
1859         * DumpRenderTree/DerivedSources-output.xcfilelist:
1860         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1861         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1862
1863 2019-01-25  Keith Rollin  <krollin@apple.com>
1864
1865         Fix missing dependencies in extract-dependencies-from-makefile
1866         https://bugs.webkit.org/show_bug.cgi?id=193783
1867         <rdar://problem/47201571>
1868
1869         Reviewed by Alex Christensen.
1870
1871         The extract-dependencies-from-makefile script generates .xcfilelists
1872         for XCBuild by invoking a makefile in --debug mode, parsing the
1873         dependency information in the output, and extracting information
1874         regarding targets and dependents. However, the way `make` emits this
1875         dependency information is not rigorous, and so we need to determine
1876         what lines to look for and parse by trial and error. This approach
1877         didn't coriginally atch all the information we needed to collect, so
1878         update the script to look for the additional lines we now know to look
1879         for.
1880
1881         * Scripts/extract-dependencies-from-makefile:
1882         (Parser):
1883         (Parser.addTarget):
1884         (Parser.addPrereq):
1885         (Parser.doParse):
1886
1887 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1888
1889         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1890         https://bugs.webkit.org/show_bug.cgi?id=193297
1891         <rdar://problem/47158841>
1892
1893         Reviewed by Alex Christensen.
1894
1895         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1896             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1897         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1898         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1899         activating the message used to trigger the callback when it is set.
1900
1901 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1902
1903         WKWebView.goBack should reload if there is a safe browsing warning
1904         https://bugs.webkit.org/show_bug.cgi?id=193805
1905         <rdar://problem/46908216>
1906
1907         Reviewed by Geoff Garen.
1908
1909         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1910         (+[Simple3LookupContext sharedLookupContext]):
1911         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1912         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1913         (TEST):
1914
1915 2019-01-25  Chris Dumez  <cdumez@apple.com>
1916
1917         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1918         https://bugs.webkit.org/show_bug.cgi?id=193788
1919         <rdar://problem/47531231>
1920
1921         Reviewed by Alex Christensen.
1922
1923         Add API test coverage.
1924
1925         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1926         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1927
1928 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1929
1930         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1931         https://bugs.webkit.org/show_bug.cgi?id=193771
1932
1933         Unreviewed infrastructure fix.
1934
1935         * Scripts/webkitpy/port/darwin.py:
1936         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1937
1938 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1939
1940         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1941
1942 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1943
1944         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1945
1946         * Scripts/webkitpy/common/config/contributors.json:
1947
1948 2019-01-25  Chris Dumez  <cdumez@apple.com>
1949
1950         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1951         https://bugs.webkit.org/show_bug.cgi?id=193779
1952         <rdar://problem/46170903>
1953
1954         Reviewed by Antti Koivisto.
1955
1956         Add API test that quickly navigates forward to a previous process without waiting for it to
1957         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1958         the process' previous page when reconnecting the it for the forward navigation.
1959
1960         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1961
1962 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1963
1964         Need a way for JavaScript (or bundle) code to participate in undo
1965         https://bugs.webkit.org/show_bug.cgi?id=190009
1966         <rdar://problem/44807048>
1967
1968         Reviewed by Ryosuke Niwa.
1969
1970         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1971         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1972
1973         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1974         (WTR::UIScriptController::lastUndoLabel const):
1975         (WTR::UIScriptController::firstRedoLabel const):
1976         (WTR::UIScriptController::platformUndoManager const):
1977         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1978         (WTR::UIScriptController::lastUndoLabel const):
1979         (WTR::UIScriptController::firstRedoLabel const):
1980         (WTR::UIScriptController::platformUndoManager const):
1981         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1982         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1983         (WTR::UIScriptController::lastUndoLabel const):
1984         (WTR::UIScriptController::firstRedoLabel const):
1985         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1986         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1987         (WTR::UIScriptController::lastUndoLabel const):
1988         (WTR::UIScriptController::firstRedoLabel const):
1989         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1990         (WTR::UIScriptController::platformUndoManager const):
1991         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1992         (WTR::UIScriptController::platformUndoManager const):
1993
1994 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1995
1996         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1997         https://bugs.webkit.org/show_bug.cgi?id=193824
1998
1999         Reviewed by Antti Koivisto.
2000
2001         * LayoutReloaded/misc/LFC-passing-tests.txt:
2002
2003 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2004
2005         Update macOS JSC bot configurations
2006         https://bugs.webkit.org/show_bug.cgi?id=193739
2007
2008         Reviewed by Alexey Proskuryakov.
2009
2010         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2011         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2012         (BubbleQueueServer): Move JSC EWS to Mojave section.
2013         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2014         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2015         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2016
2017 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2018
2019         [Win][WebKitTestRunner] Implement EventSenderProxy
2020         https://bugs.webkit.org/show_bug.cgi?id=193755
2021
2022         Reviewed by Don Olmstead.
2023
2024         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2025         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2026         (WTR::EventSenderProxy::dispatchMessage):
2027         (WTR::EventSenderProxy::EventSenderProxy):
2028         (WTR::EventSenderProxy::mouseDown):
2029         (WTR::EventSenderProxy::mouseUp):
2030         (WTR::EventSenderProxy::mouseMoveTo):
2031         (WTR::EventSenderProxy::mouseScrollBy):
2032         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2033
2034 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2035
2036         Unreviewed fix for API test failure after r240437.
2037
2038         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2039
2040         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2041
2042 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2043
2044         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2045         https://bugs.webkit.org/show_bug.cgi?id=193787
2046         <rdar://problem/47497634>
2047
2048         Reviewed by Alexey Proskuryakov.
2049
2050         * Scripts/webkitdirs.pm:
2051         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2052
2053 2019-01-24  Truitt Savell  <tsavell@apple.com>
2054
2055         Unreviewed, rolling out r240446.
2056
2057         Casued 5 API failures
2058
2059         Reverted changeset:
2060
2061         "Activate the WebResourceLoadStatisticsStore in the
2062         NetworkProcess and deactivate it in the UIProcess."
2063         https://bugs.webkit.org/show_bug.cgi?id=193297
2064         https://trac.webkit.org/changeset/240446
2065
2066 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2067
2068         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2069         https://bugs.webkit.org/show_bug.cgi?id=193741
2070         <rdar://problem/47135030>
2071
2072         Reviewed by Antti Koivisto and Simon Fraser.
2073
2074         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2075         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2076         (TestWebKitAPI::TEST):
2077
2078 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2079
2080         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2081         https://bugs.webkit.org/show_bug.cgi?id=193297
2082         <rdar://problem/47158841>
2083
2084         Reviewed by Alex Christensen.
2085
2086         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2087         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2088         activating the message used to trigger the callback when it is set.
2089
2090 2019-01-24  John Wilander  <wilander@apple.com>
2091
2092         Add Ad Click Attribution as an internal/experimental feature
2093         https://bugs.webkit.org/show_bug.cgi?id=193685
2094         <rdar://problem/47450399>
2095
2096         Reviewed by Brent Fulgham.
2097
2098         Added test option adClickAttributionEnabled.
2099
2100         * DumpRenderTree/TestOptions.cpp:
2101         (TestOptions::TestOptions):
2102         * DumpRenderTree/TestOptions.h:
2103         * DumpRenderTree/mac/DumpRenderTree.mm:
2104         (setWebPreferencesForTestOptions):
2105
2106 2019-01-24  Antti Koivisto  <antti@apple.com>
2107
2108         [PSON] Flash on back navigation on Mac
2109         https://bugs.webkit.org/show_bug.cgi?id=193716
2110         <rdar://problem/47148458>
2111
2112         Reviewed by Chris Dumez.
2113
2114         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2115
2116         Closing of the previous page is delayed so waiting for didFinishNavigation is
2117         not sufficient to guarantee we have received all the messages. Wait for them.
2118
2119 2019-01-24  Chris Dumez  <cdumez@apple.com>
2120
2121         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2122         https://bugs.webkit.org/show_bug.cgi?id=193761
2123         <rdar://problem/47456405>
2124
2125         Reviewed by Alex Christensen.
2126
2127         Add API test coverage.
2128
2129         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2130
2131 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2132
2133         webkitpy: Missing PID in crashlog name should not be fatal
2134         https://bugs.webkit.org/show_bug.cgi?id=193771
2135
2136         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2137         of raising an exception.
2138
2139         Reviewed by Lucas Forschler.
2140
2141         * Scripts/webkitpy/port/darwin.py:
2142         (DarwinPort._merge_crash_logs):
2143
2144 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2145
2146         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2147         https://bugs.webkit.org/show_bug.cgi?id=193746
2148
2149         Reviewed by Youenn Fablet.
2150
2151         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2152         so we'd best just not call it.
2153
2154         * Scripts/webkitpy/w3c/test_exporter.py:
2155         (WebPlatformTestExporter.create_branch_with_patch):
2156
2157 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2158
2159         Move FileSystem to WTF
2160         https://bugs.webkit.org/show_bug.cgi?id=193602
2161
2162         Reviewed by Yusuke Suzuki.
2163
2164         * DumpRenderTree/win/DumpRenderTree.cpp:
2165         * TestWebKitAPI/CMakeLists.txt:
2166         * TestWebKitAPI/PlatformGTK.cmake:
2167         * TestWebKitAPI/PlatformJSCOnly.cmake:
2168         * TestWebKitAPI/PlatformPlayStation.cmake:
2169         * TestWebKitAPI/PlatformWPE.cmake:
2170         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2171         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2172         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2173         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2174         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2175         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2176         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2177         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2178         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2179         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2180
2181 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2182
2183         [WPE] Remove hard dependency on subprocess32 for the API tests
2184
2185         Rubber-stamped by Carlos Garcia Campos.
2186
2187         * glib/api_test_runner.py:
2188         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2189         its presence only when running WPEQt tests.
2190
2191 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2192
2193         [GLIB] Expose JavaScriptCore options in GLib public API
2194         https://bugs.webkit.org/show_bug.cgi?id=188742
2195
2196         Reviewed by Michael Catanzaro.
2197
2198         Add a test for the new API.
2199
2200         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2201         (testsJSCOptions):
2202         (main):
2203
2204 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2205
2206         [GTK][WPE] Support JPEG 2000 images
2207         https://bugs.webkit.org/show_bug.cgi?id=186272
2208
2209         Reviewed by Žan Doberšek.
2210
2211         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2212
2213         * gtk/jhbuild.modules:
2214         * wpe/jhbuild.modules:
2215
2216 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2217
2218         check-webkit-style should warn when using soft-linking macros in a header
2219         <https://webkit.org/b/193750>
2220
2221         Reviewed by Darin Adler.
2222
2223         * Scripts/webkitpy/style/checkers/cpp.py:
2224         (check_language): Add softlink/header check by refactoring the
2225         softlink/framework check.
2226         (CppChecker): Enable softlink/header check by default.
2227         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2228         (CppStyleTest.test_softlink_framework): Rename from
2229         CppStyleTest.test_softlink() and change test framework name in
2230         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2231         files. Set file_name for macros that only appear in headers.
2232         (CppStyleTest.test_softlink_header): Add tests for using
2233         soft-link macros in headers.
2234
2235 2019-01-23  Chris Dumez  <cdumez@apple.com>
2236
2237         Deprecate API to limit the maximum number of WebProcesses
2238         https://bugs.webkit.org/show_bug.cgi?id=193725
2239         <rdar://problem/47464879>
2240
2241         Reviewed by Geoff Garen.
2242
2243         Update existing API tests to stop using deprecated API.
2244
2245         * MiniBrowser/mac/AppDelegate.m:
2246         (defaultConfiguration):
2247         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2248         (TestWebKitAPI::TEST):
2249         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2250         (TestWebKitAPI::TEST):
2251         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2252         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2253         (TEST):
2254         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2255         (TEST):
2256
2257 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2258
2259         [ews-app] Rename ews model buildermappings to buildermapping
2260         https://bugs.webkit.org/show_bug.cgi?id=193729
2261
2262         Reviewed by Lucas Forschler.
2263
2264         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2265         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2266         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2267
2268 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2269
2270         [ews-app] Rename ews model steps to step
2271         https://bugs.webkit.org/show_bug.cgi?id=193697
2272
2273         Reviewed by Lucas Forschler.
2274
2275         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2276         (Step): Renamed Steps to Step.
2277
2278 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2279
2280         Clean up IndexedDB files between tests
2281         https://bugs.webkit.org/show_bug.cgi?id=192796
2282         <rdar://problem/46824999>
2283
2284         Reviewed by Geoffrey Garen.
2285
2286         * DumpRenderTree/mac/DumpRenderTree.mm:
2287         (runTest):
2288         * WebKitTestRunner/TestController.cpp:
2289         (WTR::TestController::resetStateToConsistentValues):
2290         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2291         (WTR::RemoveAllIndexedDatabasesCallback):
2292         (WTR::TestController::ClearIndexedDatabases):
2293         * WebKitTestRunner/TestController.h:
2294         * WebKitTestRunner/TestInvocation.cpp:
2295         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2296
2297 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2298
2299         [ews-app] Rename ews model Builds to Build
2300         https://bugs.webkit.org/show_bug.cgi?id=193695
2301
2302         Reviewed by Lucas Forschler.
2303
2304         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2305         (Build): Renamed Builds to Build.
2306
2307 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2308
2309         webkitpy: Wait longer when launching WebKitTestRunner
2310         https://bugs.webkit.org/show_bug.cgi?id=193734
2311
2312         Reviewed by Aakash Jain.
2313
2314         * Scripts/webkitpy/port/simulator_process.py:
2315         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2316
2317 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2318
2319         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2320         https://bugs.webkit.org/show_bug.cgi?id=193182
2321         <rdar://problem/47452154>
2322
2323         Reviewed by Tim Horton.
2324
2325         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2326         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2327         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2328
2329         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2330         preventing later tests from recognizing gestures.
2331
2332         * WebKitTestRunner/ios/TestControllerIOS.mm:
2333         (WTR::TestController::platformResetStateToConsistentValues):
2334
2335         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2336
2337 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2338
2339         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2340         https://bugs.webkit.org/show_bug.cgi?id=193722
2341         <rdar://problem/47481475>
2342
2343         Reviewed by Lucas Forschler.
2344
2345         iPhone and iPad ports should both use the iOS config.
2346
2347         * Scripts/webkitpy/port/ios_simulator.py:
2348         (IPhoneSimulatorPort.__init__):
2349         (IPadSimulatorPort.__init__):
2350
2351 2019-01-23  Rob Buis  <rbuis@igalia.com>
2352
2353         Update MIME type parser
2354         https://bugs.webkit.org/show_bug.cgi?id=180526
2355
2356         Reviewed by Frédéric Wang.
2357
2358         Add unit tests for both parse modes of ParsedContentType.
2359
2360         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2361         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2362         (TestWebKitAPI::TEST):
2363
2364 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2365
2366         [ews-app] fetch loop should not stop on network issues
2367         https://bugs.webkit.org/show_bug.cgi?id=193666
2368
2369         Reviewed by Lucas Forschler.
2370
2371         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2372         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2373
2374 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2375
2376         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2377         https://bugs.webkit.org/show_bug.cgi?id=189165
2378         <rdar://problem/47433765>
2379
2380         Reviewed by Tim Horton.
2381
2382         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2383         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2384         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2385         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2386         would make its way to the UI process by the time the layer tree commit is finished.
2387
2388         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2389         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2390         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2391         will fail because it asks for -_autofillContext too early.
2392
2393         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2394         is handled in the UI process.
2395
2396         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2397
2398         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2399         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2400         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2401         input session.
2402
2403         (-[AutofillTestView textInputHasAutofillContext]):
2404
2405         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2406
2407         * TestWebKitAPI/cocoa/TestWKWebView.h:
2408         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2409         (nextInputSessionChangeCount):
2410
2411         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2412         This includes changing the focused element from one to another.
2413
2414         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2415         (-[TestWKWebView didStartFormControlInteraction]):
2416         (-[TestWKWebView didEndFormControlInteraction]):
2417         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2418
2419         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2420         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2421         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2422         that doesn't require an input session to one that doesn't.
2423
2424 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2425
2426         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2427         <https://webkit.org/b/193676>
2428
2429         Reviewed by Alexey Proskuryakov.
2430
2431         * Scripts/webkitpy/style/checkers/cpp.py:
2432         (check_member_initialization_list):
2433         - Don't report missing whitespace around colon if the colon at
2434           the start of the line is formatted correctly.
2435         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2436         (WebKitStyleTest.test_member_initialization_list):
2437         - Add a test for a missing permutation of existing tests.
2438         - Add a test this false-positive.
2439         - Add blank lines between subtests to make them easier to read.
2440
2441 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2442
2443         [build.webkit.org] Unit-test failure after r237113
2444         https://bugs.webkit.org/show_bug.cgi?id=193669
2445
2446         Reviewed by Michael Catanzaro.
2447
2448         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2449         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2450         multiple or zero flags.
2451
2452 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2453
2454         Cache bytecode to disk
2455         https://bugs.webkit.org/show_bug.cgi?id=192782
2456         <rdar://problem/46084932>
2457
2458         Reviewed by Keith Miller.
2459
2460         Add test helper to execute bytecode-cache tests: it executes each test
2461         twice, the first with JSC_diskCachePath set to a temporary directory
2462         and second with JSC_forceDiskCache=true (in addition to the cache path)
2463         to guarantee that only the disk cache is being used and no new
2464         UnlinkedCodeBlocks are being created.
2465
2466         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2467         * Scripts/run-jsc-stress-tests:
2468
2469 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2470
2471         [css-logical] Implement flow-relative margin, padding and border shorthands
2472         https://bugs.webkit.org/show_bug.cgi?id=188697
2473
2474         Reviewed by Simon Fraser and Antti Koivisto.
2475
2476         * DumpRenderTree/TestOptions.cpp:
2477         (TestOptions::TestOptions):
2478         * DumpRenderTree/TestOptions.h:
2479         * DumpRenderTree/mac/DumpRenderTree.mm:
2480         (setWebPreferencesForTestOptions):
2481         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2482
2483         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2484         (JSONCSSPropertiesChecker.check_codegen_properties):
2485         Allow CSS property definitions to have a 'runtime-flag' parameter which
2486         disables the property when the specified runtime flag is disabled.
2487
2488 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2489
2490         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2491         https://bugs.webkit.org/show_bug.cgi?id=193643
2492
2493         Reviewed by Michael Catanzaro.
2494
2495         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2496         * wpe/jhbuild.modules: Ditto.
2497
2498 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2499
2500         [LFC][Floats] Take float top position into account when computing containing block height.
2501         https://bugs.webkit.org/show_bug.cgi?id=193655
2502
2503         Reviewed by Antti Koivisto.
2504
2505         * LayoutReloaded/misc/LFC-passing-tests.txt:
2506
2507 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2508
2509         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2510         <https://webkit.org/b/193645>
2511         <rdar://problem/47421574>
2512
2513         Reviewed by Alex Christensen.
2514
2515         - Now checks for local soft-linking of all frameworks that have
2516           their own *SoftLinking.{cpp,h,mm} files.
2517         - Changes softlink/uikit warning to softlink/framework.
2518
2519         * Scripts/webkitpy/style/checkers/cpp.py:
2520         (check_language):
2521         (CppChecker):
2522         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2523         (CppStyleTest):
2524
2525 2019-01-20  Saam Barati  <sbarati@apple.com>
2526
2527         Rollout r240210: It broke tests on iOS
2528         https://bugs.webkit.org/show_bug.cgi?id=193640
2529
2530         Unreviewed.
2531
2532         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2533         * Scripts/run-jsc-stress-tests:
2534
2535 2019-01-20  chris fleizach  <cfleizach@apple.com>
2536
2537         AX: Support returning relative frames for accessibility
2538         https://bugs.webkit.org/show_bug.cgi?id=193414
2539         <rdar://problem/47268501>
2540
2541         Reviewed by Zalan Bujtas.
2542
2543         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2544         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2545         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2546         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2547         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2548         (WTR::attributesOfElement):
2549         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2550
2551 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2552
2553         Unreviewed, add my new email address
2554
2555         * Scripts/webkitpy/common/config/contributors.json:
2556
2557 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2558
2559         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2560         https://bugs.webkit.org/show_bug.cgi?id=193617
2561
2562         Reviewed by Antti Koivisto.
2563
2564         * LayoutReloaded/misc/LFC-passing-tests.txt:
2565
2566 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2567
2568         Unreviewed, rolling out r240209.
2569
2570         Broke GTK/WPE injected bundle
2571
2572         Reverted changeset:
2573
2574         "AX: Support returning relative frames for accessibility"
2575         https://bugs.webkit.org/show_bug.cgi?id=193414
2576         https://trac.webkit.org/changeset/240209
2577
2578 2019-01-12  Dan Bernstein  <mitz@apple.com>
2579
2580         [Cocoa] Avoid importing directly from subumbrella frameworks
2581         https://bugs.webkit.org/show_bug.cgi?id=186016
2582         <rdar://problem/40591038>
2583
2584         Reviewed by Sam Weinig.
2585
2586         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2587           LaunchServices header.
2588         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2589           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2590         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2591           when using SDKs earlier than 10.13.
2592         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2593           and OTHER_CPLUSPLUSFLAGS.
2594         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2595           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2596         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2597           LaunchServices header.
2598
2599 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2600
2601         Cache bytecode to disk
2602         https://bugs.webkit.org/show_bug.cgi?id=192782
2603         <rdar://problem/46084932>
2604
2605         Reviewed by Keith Miller.
2606
2607         Add test helper to execute bytecode-cache tests: it executes each test
2608         twice, the first with JSC_diskCachePath set to a temporary directory
2609         and second with JSC_forceDiskCache=true (in addition to the cache path)
2610         to guarantee that only the disk cache is being used and no new
2611         UnlinkedCodeBlocks are being created.
2612
2613         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2614         * Scripts/run-jsc-stress-tests:
2615
2616 2019-01-20  chris fleizach  <cfleizach@apple.com>
2617
2618         AX: Support returning relative frames for accessibility
2619         https://bugs.webkit.org/show_bug.cgi?id=193414
2620         <rdar://problem/47268501>
2621
2622         Reviewed by Zalan Bujtas.
2623
2624         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2625         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2626         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2627         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2628         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2629         (WTR::attributesOfElement):
2630         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2631
2632 2019-01-20  Antoine Quint  <graouts@apple.com>
2633
2634         Add a POINTER_EVENTS feature flag
2635         https://bugs.webkit.org/show_bug.cgi?id=193577
2636         <rdar://problem/47408511>
2637
2638         Unreviewed. Also enable Pointer Events for iosmac.
2639
2640         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2641
2642 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2643
2644         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2645         https://bugs.webkit.org/show_bug.cgi?id=193613
2646
2647         Reviewed by Antti Koivisto.
2648
2649         * LayoutReloaded/misc/LFC-passing-tests.txt:
2650
2651 2019-01-19  Antoine Quint  <graouts@apple.com>
2652
2653         Add a POINTER_EVENTS feature flag
2654         https://bugs.webkit.org/show_bug.cgi?id=193577
2655
2656         Reviewed by Dean Jackson.
2657
2658         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2659
2660 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2661
2662         Disable the run-jsc-stress-test remote host key check [second round].
2663         https://bugs.webkit.org/show_bug.cgi?id=192988
2664
2665         Reviewed by Dewei Zhu.
2666
2667         * Scripts/run-jsc-stress-tests:
2668
2669 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2670
2671         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2672         https://bugs.webkit.org/show_bug.cgi?id=193597
2673
2674         Reviewed by Lucas Forschler.
2675
2676         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2677
2678 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2679
2680         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2681         https://bugs.webkit.org/show_bug.cgi?id=193595
2682
2683         Reviewed by Lucas Forschler.
2684
2685         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2686         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2687         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2688
2689 2019-01-18  Chris Dumez  <cdumez@apple.com>
2690
2691         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2692         https://bugs.webkit.org/show_bug.cgi?id=193588
2693         <rdar://problem/47131566>
2694
2695         Reviewed by Alex Christensen.
2696
2697         Add layout test coverage.
2698
2699         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2700
2701 2019-01-18  Jer Noble  <jer.noble@apple.com>
2702
2703         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2704         https://bugs.webkit.org/show_bug.cgi?id=189553
2705
2706         Reviewed by Tim Horton.
2707
2708         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2709
2710         * ContentExtensionTester/Configurations/Base.xcconfig:
2711         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2712         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2713         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2714         * ImageDiff/cg/Configurations/Base.xcconfig:
2715         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2716         * MiniBrowser/Configurations/Base.xcconfig:
2717         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2718         * MobileMiniBrowser/Configurations/Base.xcconfig:
2719         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2720         * Scripts/webkitpy/style/checker.py:
2721         (_all_categories):
2722         (FileType):
2723         (CheckerDispatcher._file_type):
2724         (CheckerDispatcher._create_checker):
2725         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2726         (SDKVariantChecker):
2727         (SDKVariantChecker.__init__):
2728         (SDKVariantChecker.check):
2729         * TestWebKitAPI/Configurations/Base.xcconfig:
2730         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2731         * WebEditingTester/Configurations/Base.xcconfig:
2732         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2733         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2734         * WebKitTestRunner/Configurations/Base.xcconfig:
2735         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2736         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2737         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2738
2739 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2740
2741         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2742         <https://webkit.org/b/193568>
2743         <rdar://problem/47381130>
2744
2745         Reviewed by Alex Christensen.
2746
2747         Make sure no one re-introduces UIKit soft-linking by adding a
2748         style rule.
2749
2750         * Scripts/webkitpy/style/checkers/cpp.py:
2751         (check_language): Add softlink/uikit check.
2752         (CppChecker): Enable softlink/uikit check.
2753         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2754         (CppStyleTest): Add test for softlink/uikit.
2755
2756 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2757
2758         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2759         https://bugs.webkit.org/show_bug.cgi?id=193584
2760
2761         Change "-dev" to "-devel".
2762
2763         Reviewed by Michael Catanzaro.
2764
2765         * gtk/install-dependencies:
2766
2767 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2768
2769         webkitpy: Add iPhone and iPad ports
2770         https://bugs.webkit.org/show_bug.cgi?id=193537
2771         <rdar://problem/47353390>
2772
2773         Reviewed by Lucas Forschler.
2774
2775         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2776         ports. Note that this separation is optional, the --ios-simulator command remains.
2777
2778         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2779         (RunTest.test_device_type_test_division): Drive-by fix.
2780         (RunTest.test_device_type_specific_listing): Ditto.
2781         (RunTest.test_ipad_test_division):
2782         (RunTest):
2783         (RunTest.test_ipad_listing):
2784         * Scripts/webkitpy/port/factory.py:
2785         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2786         (PortFactory):
2787         * Scripts/webkitpy/port/ios_simulator.py:
2788         (IPhoneSimulatorPort):
2789         (IPadSimulatorPort):
2790
2791 2019-01-18  Chris Dumez  <cdumez@apple.com>
2792
2793         Regression(PSON) Scroll position is not always restored properly when navigating back
2794         https://bugs.webkit.org/show_bug.cgi?id=193578
2795         <rdar://problem/47386331>
2796
2797         Reviewed by Tim Horton.
2798
2799         Add API test coverage.
2800
2801         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2802
2803 2019-01-18  Youenn Fablet  <youenn@apple.com>
2804
2805         Add a new SPI to request for cache storage quota increase
2806         https://bugs.webkit.org/show_bug.cgi?id=193323
2807
2808         Reviewed by Alex Christensen.
2809
2810         Implement WebsiteDataStore quota delegate to handle quota requests.
2811         By default, do not update quota.
2812         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2813
2814         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2815         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2816         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2817         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2818         * WebKitTestRunner/TestController.cpp:
2819         (WTR::TestController::allowCacheStorageQuotaIncrease):
2820         * WebKitTestRunner/TestController.h:
2821         * WebKitTestRunner/TestInvocation.cpp:
2822         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2823         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2824         (-[CacheStorageQuotaManager init]):
2825         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2826         (WTR::initializeWebViewConfiguration):
2827         (WTR::TestController::cocoaResetStateToConsistentValues):
2828         (WTR::TestController::allowCacheStorageQuotaIncrease):
2829
2830 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2831
2832         [ews-build] Pass owner to the triggered builds
2833         https://bugs.webkit.org/show_bug.cgi?id=193574
2834
2835         Reviewed by Lucas Forschler.
2836
2837         * BuildSlaveSupport/ews-build/factories.py:
2838         (BuildFactory.propertiesToPassToTriggers):
2839
2840 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2841
2842         [ews-app] Send patch author as a build property
2843         https://bugs.webkit.org/show_bug.cgi?id=193560
2844
2845         Reviewed by Lucas Forschler.
2846
2847         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2848         (BugzillaPatchFetcher.fetch):
2849
2850 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2851
2852         webkitpy: Implement device type specific expected results (Follow-up fix)
2853         https://bugs.webkit.org/show_bug.cgi?id=192162
2854         <rdar://problem/46345449>
2855
2856         Unreviewed infrastructure fix.
2857
2858         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2859         (Manager.run): Don't boot a device if no tests are available to run on it.
2860
2861 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2862
2863         webkitpy: Implement device type specific expected results (Follow-up fix)
2864         https://bugs.webkit.org/show_bug.cgi?id=192162
2865         <rdar://problem/46345449>
2866
2867         Unreviewed infrastructure fix.
2868
2869         * Scripts/webkitpy/api_tests/manager.py:
2870         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2871
2872 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2873
2874         webkitpy: Implement device type specific expected results (Part 2)
2875         https://bugs.webkit.org/show_bug.cgi?id=192162
2876         <rdar://problem/46345449>
2877
2878         Rubber-stamped by Aakash Jain.
2879
2880         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2881         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2882         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2883
2884         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2885         (LayoutTestFinder.find_tests): Pass device_type through.
2886         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2887         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2888         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2889         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2890         (Manager._collect_tests): Pass device type to test finder.
2891         (Manager._needs_web_platform_test):
2892         (Manager._prepare_lists): Index _expectations by device type.
2893         (Manager._test_input_for_file):
2894         (Manager._test_is_slow): Ditto.
2895         (Manager._test_should_dump_jsconsolelog_in_stderr):
2896         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2897         (Manager._get_test_inputs):
2898         (Manager._update_worker_count):
2899         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2900         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2901         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2902         the one which runs the test.
2903         (Manager._run_test_subset):
2904         (Manager._run_tests): Index _expectations by current_device_type.
2905         (Manager._print_expectation_line_for_test): Ditto.
2906         (Manager._print_expectations_for_subset): Ditto.
2907         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2908         Unlike run, this function will behave the same regardless of what devices are available.
2909         (Manager._custom_device_for_test): Deleted.
2910         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2911         (ManagerTest.test_uses_custom_device): Deleted.
2912         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2913         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2914         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2915         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2916         all of the expectations.
2917         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2918         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2919         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2920         (TestExpectations.__init__): Allow device_type to be passed through.
2921         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2922         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2923         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2924         (summarize_results):
2925         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2926         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2927         a test ran with, one must check all expectations to find the first non-skip expectation.
2928         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2929         (RunTest.test_device_type_test_division):
2930         (RunTest):
2931         (RunTest.test_device_type_specific_listing):
2932         * Scripts/webkitpy/port/base.py:
2933         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2934         (Port.supported_device_types): The result of this function will change based on what devices are available.
2935         * Scripts/webkitpy/port/device_port.py:
2936         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2937         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2938         can be used.
2939         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2940         any, or the DEFAULT_DEVICE_TYPES of the port.
2941         * Scripts/webkitpy/port/ios.py:
2942         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2943         * Scripts/webkitpy/port/ios_simulator.py:
2944         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2945         * Scripts/webkitpy/port/watch.py:
2946         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2947         * Scripts/webkitpy/port/watch_simulator.py:
2948         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2949         * Scripts/webkitpy/xcode/device_type.py:
2950         (DeviceType):
2951         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2952
2953 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2954
2955         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2956         https://bugs.webkit.org/show_bug.cgi?id=193575
2957
2958         Reviewed by Michael Catanzaro.
2959
2960         Allow the script to run without explicit port argument because
2961         it's specific to the WPE port anyway.
2962
2963         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2964         and simplify the rest of the code accordingly.
2965
2966 2019-01-18  Charlie Turner  <cturner@igalia.com>
2967
2968         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2969         https://bugs.webkit.org/show_bug.cgi?id=192229
2970
2971         Reviewed by Xabier Rodriguez-Calvar.
2972
2973         * MiniBrowser/wpe/main.cpp:
2974         (main): Enable encrypted-media by default.
2975
2976 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2977
2978         [Flatpak] Missing KeyboardInterrupt exception handler
2979         https://bugs.webkit.org/show_bug.cgi?id=193570
2980
2981         Reviewed by Michael Catanzaro.
2982
2983         * flatpak/flatpakutils.py:
2984         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2985
2986 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2987
2988         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2989         https://bugs.webkit.org/show_bug.cgi?id=193564
2990
2991         Reviewed by Antti Koivisto.
2992
2993         * LayoutReloaded/misc/LFC-passing-tests.txt:
2994
2995 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2996
2997         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2998         https://bugs.webkit.org/show_bug.cgi?id=193562
2999
3000         Reviewed by Antti Koivisto.
3001
3002         * LayoutReloaded/misc/LFC-passing-tests.txt:
3003
3004 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3005
3006         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3007         https://bugs.webkit.org/show_bug.cgi?id=193555
3008
3009         Reviewed by Antti Koivisto.
3010
3011         * LayoutReloaded/misc/LFC-passing-tests.txt:
3012
3013 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3014
3015         [WPE] Add Qt extension
3016         https://bugs.webkit.org/show_bug.cgi?id=191464
3017
3018         Reviewed by Carlos Garcia Campos.
3019
3020         MiniBrowser and API tests for the WPE Qt API. To run the
3021         MiniBrowser a new script is introduced. Example invocation:
3022
3023         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3024
3025         Also note-worthy is the introduction of the python2-subprocess32
3026         dependency to run the GLib API tests.
3027
3028         * MiniBrowser/wpe/CMakeLists.txt:
3029         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3030         * MiniBrowser/wpe/qt/main.cpp: Added.
3031         (main):
3032         * MiniBrowser/wpe/qt/main.qml: Added.
3033         * MiniBrowser/wpe/qt/qml.qrc: Added.
3034         * Scripts/run-gtk-tests:
3035         (GtkTestRunner.is_google_test):
3036         (GtkTestRunner):
3037         (GtkTestRunner.is_qt_test):
3038         * Scripts/run-qt-wpe-minibrowser: Added.
3039         * Scripts/run-wpe-tests:
3040         (WPETestRunner):
3041         (WPETestRunner.is_google_test):
3042         (WPETestRunner.is_qt_test):
3043         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3044         (TestLoad::main):
3045         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3046         (TestLoadHtml::main):
3047         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3048         (TestLoadRequest::main):
3049         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3050         (TestRunJavaScript::main):
3051         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3052         (waitForSignal):
3053         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3054         (LoadSpy::LoadSpy):
3055         (LoadSpy::~LoadSpy):
3056         (LoadSpy::onLoadingChanged):
3057         (LoadStartedCatcher::LoadStartedCatcher):
3058         (LoadStartedCatcher::~LoadStartedCatcher):
3059         (LoadStartedCatcher::onLoadingChanged):
3060         (waitForLoadSucceeded):
3061         (waitForLoadFailed):
3062         * TestWebKitAPI/glib/CMakeLists.txt:
3063         * flatpak/flatpakutils.py:
3064         (WebkitFlatpak.load_from_args):
3065         (WebkitFlatpak.__init__):
3066         (WebkitFlatpak.clean_args):
3067         (WebkitFlatpak.run_in_sandbox):
3068         * flatpak/org.webkit.CommonModules.yaml:
3069         * flatpak/org.webkit.WPE.yaml:
3070         * flatpak/org.webkit.WPEModules.yaml:
3071         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3072         * flatpak/org.webkit.WebKit.yaml:
3073         * glib/api_test_runner.py:
3074         (TestRunner._run_test_qt):
3075         (TestRunner.is_qt_test):
3076         (TestRunner._run_test):
3077
3078 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3079
3080         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3081         https://bugs.webkit.org/show_bug.cgi?id=193494
3082         <rdar://problem/46859627>
3083
3084         Reviewed by Simon Fraser and Tim Horton.
3085
3086         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3087         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3088
3089         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3090         (WTR::UIScriptController::contentOffsetX const):
3091         (WTR::UIScriptController::contentOffsetY const):
3092         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3093         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3094         (WTR::UIScriptController::contentOffsetX const):
3095         (WTR::UIScriptController::contentOffsetY const):
3096         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3097
3098         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3099
3100         * WebKitTestRunner/TestController.cpp:
3101         (WTR::updateTestOptionsFromTestHeader):
3102         * WebKitTestRunner/TestOptions.h:
3103         (WTR::TestOptions::hasSameInitializationOptions const):
3104         * WebKitTestRunner/ios/TestControllerIOS.mm:
3105         (WTR::TestController::platformResetStateToConsistentValues):
3106         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3107         (WTR::UIScriptController::contentOffsetX const):
3108         (WTR::UIScriptController::contentOffsetY const):
3109
3110 2019-01-17  Truitt Savell  <tsavell@apple.com>
3111
3112         Unreviewed, rolling out r240124.
3113
3114         This commit broke an internal build.
3115
3116         Reverted changeset:
3117
3118         "SDK_VARIANT build destinations should be separate from non-
3119         SDK_VARIANT builds"
3120         https://bugs.webkit.org/show_bug.cgi?id=189553
3121         https://trac.webkit.org/changeset/240124
3122
3123 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3124
3125         Fix string concatenation API test after r239920
3126         https://bugs.webkit.org/show_bug.cgi?id=193551
3127         <rdar://problem/47359304>
3128
3129         Reviewed by Youenn Fablet.
3130
3131         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3132         (TestWebKitAPI::TEST):
3133         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3134         in WebKit's build configuration like it apparently is on Linux.
3135
3136 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3137
3138         [ews-build] validate-patch should handle the case when bug_id is None
3139         https://bugs.webkit.org/show_bug.cgi?id=193547
3140
3141         Reviewed by Lucas Forschler.
3142
3143         * BuildSlaveSupport/ews-build/steps.py:
3144         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3145         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3146
3147 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3148
3149         [ews-build] Add patch author information in build
3150         https://bugs.webkit.org/show_bug.cgi?id=193465
3151
3152         Reviewed by Lucas Forschler.
3153
3154         * BuildSlaveSupport/ews-build/steps.py:
3155         (ValidatePatch._is_patch_obsolete):
3156
3157 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3158
3159         [ews-build] Pass bug_id to the triggered builds
3160         https://bugs.webkit.org/show_bug.cgi?id=193548
3161
3162         Reviewed by Lucas Forschler.
3163
3164         * BuildSlaveSupport/ews-build/factories.py:
3165         (BuildFactory.propertiesToPassToTriggers):
3166
3167 2019-01-17  Jer Noble  <jer.noble@apple.com>
3168
3169         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3170         https://bugs.webkit.org/show_bug.cgi?id=189553
3171
3172         Reviewed by Tim Horton.
3173
3174         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3175
3176         * ContentExtensionTester/Configurations/Base.xcconfig:
3177         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3178         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3179         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3180         * ImageDiff/cg/Configurations/Base.xcconfig:
3181         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3182         * MiniBrowser/Configurations/Base.xcconfig:
3183         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3184         * MobileMiniBrowser/Configurations/Base.xcconfig:
3185         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3186         * Scripts/webkitpy/style/checker.py:
3187         (_all_categories):
3188         (FileType):
3189         (CheckerDispatcher._file_type):
3190         (CheckerDispatcher._create_checker):
3191         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3192         (SDKVariantChecker):
3193         (SDKVariantChecker.__init__):
3194         (SDKVariantChecker.check):
3195         * TestWebKitAPI/Configurations/Base.xcconfig:
3196         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3197         * WebEditingTester/Configurations/Base.xcconfig:
3198         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3199         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3200         * WebKitTestRunner/Configurations/Base.xcconfig:
3201         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3202         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3203         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3204
3205 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3206
3207         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3208         https://bugs.webkit.org/show_bug.cgi?id=193534
3209
3210         Reviewed by Antti Koivisto.
3211
3212         * LayoutReloaded/misc/LFC-passing-tests.txt:
3213
3214 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3215
3216         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3217         https://bugs.webkit.org/show_bug.cgi?id=193528
3218
3219         Reviewed by Antti Koivisto.
3220
3221         * LayoutReloaded/misc/LFC-passing-tests.txt:
3222
3223 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3224
3225         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3226         https://bugs.webkit.org/show_bug.cgi?id=193520
3227
3228         Reviewed by Antti Koivisto.
3229
3230         * LayoutReloaded/misc/LFC-passing-tests.txt:
3231
3232 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3233
3234         [ews-build] unapply-patch step should not update source
3235         https://bugs.webkit.org/show_bug.cgi?id=193234
3236
3237         Reviewed by Lucas Forschler.
3238
3239         * BuildSlaveSupport/ews-build/steps.py:
3240         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3241         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3242
3243 2019-01-16  Youenn Fablet  <youenn@apple.com>
3244
3245         Add a new SPI for controlling getUserMedia
3246         https://bugs.webkit.org/show_bug.cgi?id=192793
3247
3248         Reviewed by Eric Carlson.
3249
3250         * MiniBrowser/mac/WK2BrowserWindowController.m:
3251         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3252         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3253         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3254         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3255         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3256         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3257         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3258         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3259         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3260         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3261         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3262         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3263         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3264         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3265
3266 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3267
3268         [LFC][BFC] Inflow non-replaced used width should not be negative.
3269         https://bugs.webkit.org/show_bug.cgi?id=193495
3270
3271         Reviewed by Antti Koivisto.
3272
3273         * LayoutReloaded/misc/LFC-passing-tests.txt:
3274
3275 2019-01-16  Chris Dumez  <cdumez@apple.com>
3276
3277         Regression(PSON) View becomes blank after click a cross-site download link
3278         https://bugs.webkit.org/show_bug.cgi?id=193361
3279         <rdar://problem/47099573>
3280
3281         Reviewed by Geoffrey Garen.
3282
3283         Add API test coverage.
3284
3285         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3286         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3287
3288 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3289
3290         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3291         https://bugs.webkit.org/show_bug.cgi?id=193470
3292
3293         Reviewed by Antti Koivisto.
3294
3295         * LayoutReloaded/misc/LFC-passing-tests.txt:
3296
3297 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3298
3299         [LFC] Adjust margin box verification.
3300         https://bugs.webkit.org/show_bug.cgi?id=193482
3301
3302         Reviewed by Antti Koivisto.
3303
3304         * LayoutReloaded/misc/LFC-passing-tests.txt:
3305
3306 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3307
3308         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3309         https://bugs.webkit.org/show_bug.cgi?id=193451
3310
3311         Reviewed by Geoffrey Garen.
3312
3313         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3314         (TEST):
3315         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3316         (runWebsiteDataStoreCustomPaths):
3317
3318 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3319
3320         webkitpy: Support boolean simctl isAvailable
3321         https://bugs.webkit.org/show_bug.cgi?id=193472
3322         <rdar://problem/47296150>
3323
3324         Reviewed by Ryosuke Niwa.
3325
3326         * Scripts/webkitpy/xcode/simulated_device.py:
3327         (SimulatedDeviceManager._create_runtimes):
3328         (SimulatedDeviceManager._create_device_with_runtime):
3329
3330 2019-01-15  Chris Dumez  <cdumez@apple.com>
3331
3332         Unreviewed, rolling out r239993, r239995, r239997, and
3333         r239999.
3334
3335         Caused assertions under
3336         ViewGestureController::disconnectFromProcess()
3337
3338         Reverted changesets:
3339
3340         "Regression(PSON) View becomes blank after click a cross-site
3341         download link"
3342         https://bugs.webkit.org/show_bug.cgi?id=193361
3343         https://trac.webkit.org/changeset/239993
3344
3345         "Unreviewed iOS build fix after r239993."
3346         https://trac.webkit.org/changeset/239995
3347
3348         "Fix iOS build after r239993"
3349         https://bugs.webkit.org/show_bug.cgi?id=193361
3350         https://trac.webkit.org/changeset/239997
3351
3352         "Unreviewed, revert part of r239997 as it is not needed to fix
3353         the build."
3354         https://trac.webkit.org/changeset/239999
3355
3356 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3357
3358         Cannot tab out of WKWebView on macOS
3359         https://bugs.webkit.org/show_bug.cgi?id=161448
3360         <rdar://problem/28100085>
3361
3362         Reviewed by Dean Jackson.
3363
3364         Add a test that tabbing into and out of WKWebView works correctly.
3365
3366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3367         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3368         (WebKit2_CommandBackForwardTest::SetUp):
3369         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3370         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3371         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3372         (-[FocusableView canBecomeKeyView]):
3373         (TEST):
3374         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3375         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3376         (-[OffscreenWindow initWithSize:]):
3377         (-[OffscreenWindow isKeyWindow]):
3378         (-[OffscreenWindow isVisible]):
3379         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3380         (TestWebKitAPI::PlatformWebView::initialize):
3381         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3382         (-[ActiveOffscreenWindow isVisible]): Deleted.
3383         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3384
3385 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3386
3387         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3388         https://bugs.webkit.org/show_bug.cgi?id=193459
3389
3390         Reviewed by Mark Lam.
3391
3392         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3393         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3394
3395 2019-01-15  Chris Dumez  <cdumez@apple.com>
3396
3397         Regression(PSON) View becomes blank after click a cross-site download link
3398         https://bugs.webkit.org/show_bug.cgi?id=193361
3399         <rdar://problem/47099573>
3400
3401         Reviewed by Geoff Garen.
3402
3403         Add API test coverage.
3404
3405         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3406         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3407
3408 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3409
3410         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3411         https://bugs.webkit.org/show_bug.cgi?id=193448
3412
3413         Reviewed by Antti Koivisto.
3414
3415         * LayoutReloaded/misc/LFC-passing-tests.txt:
3416
3417 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3418
3419         webkitpy: Implement device type specific expected results (Part 1)
3420         https://bugs.webkit.org/show_bug.cgi?id=192162
3421
3422         Reviewed by Lucas Forschler.
3423
3424         Device type specific expected results covers two related ideas. The first (covered by this change)
3425         is where to search for -expected.* files. The second is which tests to run based on the
3426         TestExpectations.txt file.
3427
3428         After this change, the baseline search path will be determined by the type of device running a
3429         test. Device type will be passed into any function which picks a file based on the baseline search
3430         path.
3431
3432         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3433         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3434         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3435         (Manager.run): Print baseline search path for each round of devices.
3436         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3437         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3438         (SingleTestRunner._expected_driver_output): Ditto.
3439         (SingleTestRunner._driver_input): Ditto.
3440         * Scripts/webkitpy/layout_tests/views/printing.py:
3441         (Printer.print_config): Move printing of baseline search path to a separate function.
3442         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3443         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3444         (Testprinter.test_print_config):
3445         (Testprinter.test_print_baseline_search_path):
3446         * Scripts/webkitpy/port/base.py:
3447         (Port.baseline_search_path): Pass device_type through.
3448         (Port._expected_baselines_for_suffixes): Ditto.
3449         (Port.expected_baselines): Ditto.
3450         (Port.expected_filename): Ditto.
3451         (Port.expected_checksum): Ditto.
3452         (Port.expected_image): Ditto.
3453         (Port.expected_audio): Ditto.
3454         (Port.expected_text): Ditto.
3455         (Port.reference_files): Ditto.
3456         (Port.tests): Ditto.
3457         (Port._expanded_paths): Ditto.
3458         (Port.skipped_layout_tests): Ditto.
3459         (Port.expectations_dict): Ditto.
3460         (Port._port_specific_expectations_files): Ditto.
3461         (Port.expectations_files): Ditto.
3462         (Port.test_search_path): Ditto.
3463         (Port._tests_for_other_platforms): Ditto.
3464         * Scripts/webkitpy/port/base_unittest.py:
3465         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3466         (PortTest.test_nonexistant_expectations): Ditto.
3467         (test_ref_tests_platform_directory): Ditto.
3468         * Scripts/webkitpy/port/darwin.py:
3469         (DarwinPort._port_specific_expectations_files): Accept device_type.
3470         * Scripts/webkitpy/port/driver.py:
3471         (DriverProxy):
3472         (DriverProxy.host): Expose _target_host for device_type information.
3473         * Scripts/webkitpy/port/gtk.py:
3474         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3475         * Scripts/webkitpy/port/ios.py:
3476         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3477         * Scripts/webkitpy/port/mac.py:
3478         (MacPort. default_baseline_search_path): Ditto.
3479         * Scripts/webkitpy/port/port_testcase.py:
3480         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3481         * Scripts/webkitpy/port/test.py:
3482         * Scripts/webkitpy/port/watch.py:
3483         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3484         * Scripts/webkitpy/port/win.py:
3485         (WinPort.test_search_path): Accept, but do not use, device_type.
3486         * Scripts/webkitpy/port/wpe.py:
3487         (WPEPort._port_specific_expectations_files): Ditto.
3488         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3489         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3490
3491 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3492
3493         [LFC] Use the containing block's padding box to position out-of-flow elements.
3494         https://bugs.webkit.org/show_bug.cgi?id=193431
3495
3496         Reviewed by Antti Koivisto.
3497
3498         * LayoutReloaded/misc/LFC-passing-tests.txt:
3499
3500 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3501
3502         Move a test implementation file that got misplaced in the Xcode project
3503
3504         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3505
3506 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3507
3508         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3509         r239913, and r239914.
3510         https://bugs.webkit.org/show_bug.cgi?id=193407
3511
3512         These revisions caused an internal failure (Requested by
3513         Truitt on #webkit).
3514
3515         Reverted changesets:
3516
3517         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3518         https://bugs.webkit.org/show_bug.cgi?id=186016
3519         https://trac.webkit.org/changeset/239901
3520
3521         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3522         https://trac.webkit.org/changeset/239909
3523
3524         "Tried to fix the build."
3525         https://trac.webkit.org/changeset/239910
3526
3527         "Fixed iOS builds after r239910."
3528         https://trac.webkit.org/changeset/239912
3529
3530         "More build fixing."
3531         https://trac.webkit.org/changeset/239913
3532
3533         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3534         https://trac.webkit.org/changeset/239914
3535
3536 2019-01-14  Mark Lam  <mark.lam@apple.com>
3537
3538         Re-enable ability to build --cloop builds.
3539         https://bugs.webkit.org/show_bug.cgi?id=192955
3540         <rdar://problem/46882363>
3541
3542         Reviewed by Saam barati and Keith Miller.
3543
3544         The --cloop build option was being ignored this whole time since r236381.
3545         This patch makes it possible to build CLoop builds again.
3546
3547         * Scripts/build-jsc:
3548         * Scripts/webkitperl/FeatureList.pm:
3549         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3550
3551 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3552
3553         webkitpy: Expose device_type from host-like objects
3554         https://bugs.webkit.org/show_bug.cgi?id=193406
3555         <rdar://problem/47262305>
3556
3557         Reviewed by Lucas Forschler.
3558
3559         Devices should expose device_type. As a result, all host objects should
3560         provide a device_type property, even if they do not yet define a device_type.
3561
3562         * Scripts/webkitpy/common/system/systemhost.py:
3563         (SystemHost):
3564         (SystemHost.device_type):
3565         * Scripts/webkitpy/common/system/systemhost_mock.py:
3566         (MockSystemHost):
3567         (MockSystemHost.device_type):
3568         * Scripts/webkitpy/port/device.py:
3569         (Device):
3570         (Device.device_type):
3571         * Scripts/webkitpy/xcode/simulated_device.py:
3572         (SimulatedDeviceManager._find_exisiting_device_for_request):
3573         (SimulatedDeviceManager._disambiguate_device_type):
3574         (SimulatedDeviceManager._does_fulfill_request):
3575         (SimulatedDeviceManager.device_count_for_type):
3576         (SimulatedDeviceManager.initialize_devices):
3577         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3578         (test_available_devices):
3579         (test_swapping_devices):
3580
3581 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3582
3583         webkitpy: Support alternate simctl device list output (Follow-up fix)
3584         https://bugs.webkit.org/show_bug.cgi?id=193362
3585         <rdar://problem/47122965>
3586
3587         Rubber-stamped by Lucas Forschler.
3588
3589         * Scripts/webkitpy/xcode/simulated_device.py:
3590         (SimulatedDeviceManager.populate_available_devices):
3591
3592 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3593
3594         [iOS] Expose SPI to access the current sentence boundary and selection state
3595         https://bugs.webkit.org/show_bug.cgi?id=193398
3596         <rdar://problem/45893108>
3597
3598         Reviewed by Dean Jackson.
3599
3600         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3601         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3602         expected.
3603
3604         * TestWebKitAPI/EditingTestHarness.h:
3605         * TestWebKitAPI/EditingTestHarness.mm:
3606         (-[EditingTestHarness moveBackward]):
3607         (-[EditingTestHarness moveForward]):
3608         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3609
3610         Add a couple of new helper methods on EditingTestHarness.
3611
3612         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3613         (-[SelectionChangeObserver initWithWebView:]):
3614         (-[SelectionChangeObserver webView]):
3615         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3616         (-[SelectionChangeObserver currentSelectionAttributes]):
3617
3618 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3619
3620         [LFC][BFC] Add basic box-sizing support.
3621         https://bugs.webkit.org/show_bug.cgi?id=193392
3622
3623         Reviewed by Antti Koivisto.
3624
3625         * LayoutReloaded/misc/LFC-passing-tests.txt:
3626
3627 2019-01-14  Charlie Turner  <cturner@igalia.com>
3628
3629         [WPE] API test gardening
3630         https://bugs.webkit.org/show_bug.cgi?id=193319
3631
3632         Reviewed by Michael Catanzaro.
3633
3634         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3635         passing tests.
3636
3637 2019-01-14  Charlie Turner  <cturner@igalia.com>
3638
3639         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3640         https://bugs.webkit.org/show_bug.cgi?id=192977
3641
3642         Reviewed by Carlos Garcia Campos.
3643
3644         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3645         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3646         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3647         (TestWebKitAPI::GStreamerTest::SetUp):
3648         (TestWebKitAPI::GStreamerTest::TearDown):
3649         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3650         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3651         (TestWebKitAPI::TEST_F):
3652
3653 2019-01-14  Charlie Turner  <cturner@igalia.com>
3654
3655         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3656         https://bugs.webkit.org/show_bug.cgi?id=193332
3657
3658         Reviewed by Michael Catanzaro.
3659
3660         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3661         defined as a char16_t, which changed in ICU 59, the
3662         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3663         unsigned short. This test is relying on the behaviour that
3664         UChar=unsigned short, which doesn't hold across platforms and ICU
3665         library versions. The full fix would be a special syntax for
3666         literal characters so that these ambiguities do not arise. That
3667         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3668         (TestWebKitAPI::TEST):
3669
3670 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3671
3672         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3673
3674         * Scripts/make-dist:
3675         (Distcheck.configure):
3676
3677 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3678
3679         [ews-build] Update macOS queue configurations
3680         https://bugs.webkit.org/show_bug.cgi?id=193365
3681         <rdar://problem/47221073>
3682
3683         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3684
3685         * BuildSlaveSupport/ews-build/config.json:
3686
3687 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3688
3689         [LFC] Adjust assert for statically positioned fixed elements
3690         https://bugs.webkit.org/show_bug.cgi?id=193385
3691
3692         Reviewed by Antti Koivisto.
3693
3694         * LayoutReloaded/misc/LFC-passing-tests.txt:
3695
3696 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3697
3698         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3699         https://bugs.webkit.org/show_bug.cgi?id=193387
3700
3701         Reviewed by Carlos Garcia Campos.
3702
3703         * MiniBrowser/wpe/main.cpp:
3704         (main):
3705
3706 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3707
3708         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3709         https://bugs.webkit.org/show_bug.cgi?id=191655
3710         rdar://problem/46074680
3711
3712         Reviewed by Megan Gardner.
3713
3714         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3715         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3716
3717 2019-01-12  Dan Bernstein  <mitz@apple.com>
3718
3719         [Cocoa] Avoid importing directly from subumbrella frameworks
3720         https://bugs.webkit.org/show_bug.cgi?id=186016
3721         <rdar://problem/40591038>
3722
3723         Reviewed by Sam Weinig.
3724
3725         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3726           LaunchServices header.
3727         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3728           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3729         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3730           when using SDKs earlier than 10.13.
3731         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3732           and OTHER_CPLUSPLUSFLAGS.
3733         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3734           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3735         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3736           LaunchServices header.
3737
3738 2019-01-11  John Wilander  <wilander@apple.com>
3739
3740         Compile out Web API Statistics Collection
3741         https://bugs.webkit.org/show_bug.cgi?id=193370
3742         <rdar://problem/45388584>
3743
3744         Reviewed by Brent Fulgham.
3745
3746         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3747             Defined ENABLE_WEB_API_STATISTICS, off by default.
3748
3749 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3750
3751         [WPE] Add gtk-doc
3752         https://bugs.webkit.org/show_bug.cgi?id=178900
3753
3754         Reviewed by Michael Catanzaro.
3755
3756         Add Tools/gtkdoc to manifest.txt.in files.
3757         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3758
3759         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3760         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3761
3762 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3763
3764         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3765         https://bugs.webkit.org/show_bug.cgi?id=193364
3766         <rdar://problem/47214117>
3767
3768         Reviewed by Tim Horton.
3769
3770         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3771         precise, whereas dragging near the middle of the textarea does.
3772
3773         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3774         (TestWebKitAPI::TEST):
3775
3776 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3777
3778         webkitpy: Support alternate simctl device list output
3779         https://bugs.webkit.org/show_bug.cgi?id=193362
3780         <rdar://problem/47122965>
3781
3782         Reviewed by Lucas Forschler.
3783
3784         * Scripts/webkitpy/xcode/simulated_device.py:
3785         (SimulatedDeviceManager.populate_available_devices):
3786
3787 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3788
3789         [ews-build] Update macOS queue configurations
3790         https://bugs.webkit.org/show_bug.cgi?id=193365
3791
3792         Reviewed by Lucas Forschler.
3793
3794         * BuildSlaveSupport/ews-build/config.json:
3795
3796 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3797
3798         webkitpy: Incorporate device type into baseline search path
3799         https://bugs.webkit.org/show_bug.cgi?id=193356
3800         <rdar://problem/47215515>
3801
3802         Reviewed by Lucas Forschler.
3803
3804         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3805
3806         * Scripts/webkitpy/port/base.py:
3807         (Port.default_baseline_search_path): Allow device type to be passed in.
3808         * Scripts/webkitpy/port/gtk.py:
3809         (GtkPort.default_baseline_search_path): Ignore device type.
3810         * Scripts/webkitpy/port/ios.py:
3811         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3812         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3813         * Scripts/webkitpy/port/ios_device_unittest.py:
3814         (IOSDeviceTest):
3815         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3816         (IOSSimulatorTest):
3817         * Scripts/webkitpy/port/mac.py:
3818         (MacPort.default_baseline_search_path): Ignore device type.
3819         * Scripts/webkitpy/port/watch.py:
3820         (WatchPort.default_baseline_search_path): Ditto.
3821         * Scripts/webkitpy/port/win.py:
3822         (WinPort.default_baseline_search_path): Ditto.
3823         (WinCairoPort.default_baseline_search_path): Ditto.
3824         * Scripts/webkitpy/port/wpe.py:
3825         (WPEPort.default_baseline_search_path): Ditto.
3826
3827 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3828
3829         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3830         https://bugs.webkit.org/show_bug.cgi?id=193352
3831         <rdar://problem/47210736>
3832
3833         Reviewed by Lucas Forschler.
3834
3835         * Scripts/webkitpy/layout_tests/views/printing.py:
3836         (Printer.print_config): Print list on only baseline search paths which exist. 
3837         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3838         (Testprinter.test_print_config):
3839
3840 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3841
3842         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3843         https://bugs.webkit.org/show_bug.cgi?id=193340
3844
3845         Reviewed by David Kilzer.
3846
3847         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3848         (WTR::InjectedBundle::didReceiveMessageToPage):
3849         Pull the strings out into a WKRetainPtr.
3850
3851         * WebKitTestRunner/WebNotificationProvider.cpp:
3852         (WTR::WebNotificationProvider::closeWebNotification):
3853         Adopt the created value into the WKRetainPtr.
3854
3855         * WebKitTestRunner/mac/TestControllerMac.mm:
3856         (WTR::generateWhitelist):
3857         Immediately adopt a created value to avoid potential mistakes.
3858
3859 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3860
3861         Enable DFG on ARM/Linux again
3862         https://bugs.webkit.org/show_bug.cgi?id=192496
3863
3864         Reviewed by Yusuke Suzuki.
3865
3866         After changing the bytecode format DFG was disabled on all 32-bit
3867         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3868         on ARM by default.
3869
3870         * Scripts/run-jsc-stress-tests:
3871
3872 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3873
3874         Unreviewed, fix #ifdef in API test added in r239851.
3875         https://bugs.webkit.org/show_bug.cgi?id=193327
3876         rdar://problem/47093222
3877
3878         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3879
3880 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3881
3882         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3883         https://bugs.webkit.org/show_bug.cgi?id=193109
3884         <rdar://problem/44807048>
3885
3886         Reviewed by Ryosuke Niwa.
3887
3888         Introduce and respect a test option to enable the UndoManager API.
3889
3890         * WebKitTestRunner/TestController.cpp:
3891         (WTR::updateTestOptionsFromTestHeader):
3892         * WebKitTestRunner/TestOptions.h:
3893         (WTR::TestOptions::hasSameInitializationOptions const):
3894         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3895         (WTR::TestController::platformCreateWebView):
3896
3897 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3898
3899         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3900         https://bugs.webkit.org/show_bug.cgi?id=193346
3901
3902         Reviewed by Antti Koivisto.
3903
3904         * LayoutReloaded/misc/LFC-passing-tests.txt:
3905
3906 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3907
3908         Unreviewed, fix typo that breaks dashboard link.
3909
3910         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3911         (WebKitBuildbot):
3912
3913 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3914
3915         Update macOS queue configurations
3916         https://bugs.webkit.org/show_bug.cgi?id=193329
3917
3918         Reviewed by Alexey Proskuryakov.
3919
3920         * BuildSlaveSupport/build.webkit.org-config/config.json:
3921         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3922         (BubbleQueueServer):
3923         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3924         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3925         (WebKitBuildbot):
3926         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3927         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3928         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3929
3930 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3931
3932         MiniBrowser should be able to navigate to about:blank
3933         https://bugs.webkit.org/show_bug.cgi?id=193345
3934
3935         Reviewed by Simon Fraser.
3936
3937         * MiniBrowser/mac/BrowserWindowController.m:
3938         (-[BrowserWindowController addProtocolIfNecessary:]):
3939         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3940
3941         * MiniBrowser/mac/WK1BrowserWindowController.m:
3942         (-[WK1BrowserWindowController fetch:]):
3943         * MiniBrowser/mac/WK2BrowserWindowController.m:
3944         (-[WK2BrowserWindowController fetch:]):
3945         Clean up the code that uses this to match style.
3946
3947 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3948
3949         Remove MiniBrowser custom "Process Swap" menu item which does not work
3950         https://bugs.webkit.org/show_bug.cgi?id=193344
3951
3952         Reviewed by Simon Fraser.
3953
3954         There is a menu item under the Experimental menu that does work.
3955
3956         * MiniBrowser/mac/AppDelegate.m:
3957         (defaultConfiguration):
3958         * MiniBrowser/mac/SettingsController.h:
3959         * MiniBrowser/mac/SettingsController.m:
3960         (-[SettingsController _populateMenu]):
3961         (-[SettingsController validateMenuItem:]):
3962         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3963         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3964
3965 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3966
3967         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3968         https://bugs.webkit.org/show_bug.cgi?id=193327
3969         rdar://problem/47093222
3970
3971         Reviewed by Tim Horton.
3972
3973         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3974         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3975         (TestWebKitAPI::didFinishNavigation):
3976         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3977         (TestWebKitAPI::TEST):
3978         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3979         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3980         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3981         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3982         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3983
3984 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3985
3986         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3987         https://bugs.webkit.org/show_bug.cgi?id=193338
3988         <rdar://problem/46664774>
3989
3990         Reviewed by David Kilzer.
3991
3992         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3993         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3994
3995 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3996
3997         Unreviewed, rolling out r239825.
3998         https://bugs.webkit.org/show_bug.cgi?id=193330
3999
4000         Broke tests on armv7/linux bots (Requested by guijemont on
4001         #webkit).
4002
4003         Reverted changeset:
4004
4005         "Enable DFG on ARM/Linux again"
4006         https://bugs.webkit.org/show_bug.cgi?id=192496
4007         https://trac.webkit.org/changeset/239825
4008
4009 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
4010
4011         Disable the run-jsc-stress-test remote host key check.
4012         https://bugs.webkit.org/show_bug.cgi?id=192988
4013
4014         Reviewed by Alexey Proskuryakov.
4015
4016         * Scripts/run-jsc-stress-tests:
4017
4018 2019-01-10  John Wilander  <wilander@apple.com>
4019
4020         Override the session configuration for cookieAcceptPolicy
4021         https://bugs.webkit.org/show_bug.cgi?id=190925
4022         <rdar://problem/45497382>
4023
4024         Reviewed by Alexey Proskuryakov and Alex Christensen.
4025
4026         Test infrastructure for setting a first-party-only cookie policy.
4027
4028         * DumpRenderTree/TestRunner.cpp:
4029         (setOnlyAcceptFirstPartyCookiesCallback):
4030         (TestRunner::staticFunctions):
4031         * DumpRenderTree/TestRunner.h:
4032         * DumpRenderTree/mac/TestRunnerMac.mm:
4033         (TestRunner::setOnlyAcceptFirstPartyCookies):
4034         * DumpRenderTree/win/TestRunnerWin.cpp:
4035         (TestRunner::setOnlyAcceptFirstPartyCookies):
4036         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4037         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4038         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
4039         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4040         * WebKitTestRunner/TestInvocation.cpp:
4041         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4042
4043 2019-01-09  Matt Rajca  <mrajca@apple.com>
4044
4045         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
4046         https://bugs.webkit.org/show_bug.cgi?id=193301
4047
4048         Reviewed by Jer Noble.
4049         
4050         Added API tests.
4051
4052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4053         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4054         (TEST):
4055         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
4056
4057 2019-01-10  Zalan Bujtas  <zalan@apple.com>
4058
4059         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
4060         https://bugs.webkit.org/show_bug.cgi?id=193310
4061
4062         Reviewed by Antti Koivisto.
4063
4064         * LayoutReloaded/misc/LFC-passing-tests.txt:
4065
4066 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
4067
4068         Enable DFG on ARM/Linux again
4069         https://bugs.webkit.org/show_bug.cgi?id=192496
4070
4071         Reviewed by Yusuke Suzuki.
4072
4073         After changing the bytecode format DFG was disabled on all 32-bit
4074         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
4075         on ARM by default.
4076
4077         * Scripts/run-jsc-stress-tests:
4078
4079 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
4080
4081         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
4082         https://bugs.webkit.org/show_bug.cgi?id=193271
4083
4084         Reviewed by Brent Fulgham.
4085
4086         BSTR is a special data structure created by SysAllocString, not a
4087         wchar_t null-terminated string.
4088
4089         * DumpRenderTree/win/TestRunnerWin.cpp:
4090         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
4091         * MiniBrowser/win/MiniBrowserWebHost.cpp:
4092         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
4093         BSTR from wide string literals.
4094
4095 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
4096
4097         Tweak wording for build/version_check style checker error
4098         https://bugs.webkit.org/show_bug.cgi?id=193256
4099
4100         Reviewed by Tim Horton.
4101
4102         * Scripts/webkitpy/style/checkers/cpp.py:
4103         (check_os_version_checks):
4104         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4105         (WebKitStyleTest.test_os_version_checks):
4106
4107 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4108
4109         [ews-build] Add link to bug along with bug title
4110         https://bugs.webkit.org/show_bug.cgi?id=193293
4111
4112         Reviewed by Lucas Forschler.
4113
4114         * BuildSlaveSupport/ews-build/steps.py:
4115         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
4116         (ConfigureBuild.add_bug_id_url): Deleted.
4117         (ConfigureBuild.getBugURL): Deleted.
4118
4119 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4120
4121         [ews-build] Use https for ews-build server
4122         https://bugs.webkit.org/show_bug.cgi?id=193193
4123
4124         Reviewed by Lucas Forschler.
4125
4126         * BuildSlaveSupport/ews-build/steps.py:
4127
4128 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4129
4130         [ews-build] Parse and display number of style failures
4131         https://bugs.webkit.org/show_bug.cgi?id=193280
4132
4133         Reviewed by Lucas Forschler.
4134
4135         * BuildSlaveSupport/ews-build/steps.py:
4136         (CheckStyle): Use TestWithFailureCount as base class.
4137         (CheckStyle.countFailures): Count the number of style failures.
4138
4139 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4140
4141         [ews-build] use patch_id instead of ewspatchid
4142         https://bugs.webkit.org/show_bug.cgi?id=193235
4143
4144         Reviewed by Lucas Forschler.
4145
4146         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
4147         * BuildSlaveSupport/ews-build/steps.py: Ditto.
4148         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
4149
4150 2019-01-09  Zalan Bujtas  <zalan@apple.com>
4151
4152         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
4153         https://bugs.webkit.org/show_bug.cgi?id=192625
4154
4155         Reviewed by Antti Koivisto.
4156
4157         * LayoutReloaded/misc/LFC-passing-tests.txt:
4158
4159 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
4160
4161         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
4162         https://bugs.webkit.org/show_bug.cgi?id=192841
4163
4164         Reviewed by Carlos Garcia Campos.
4165
4166         There are separate g_assert_*() macros for use in tests, which we use inconsistently
4167         currently. Use them always. We'll get nicer error messages now when tests fail, and the
4168         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
4169
4170         Note that the documentation of g_assert() says that it is not to be used when writing tests.
4171
4172         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4173         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
4174         (WebKitWebEditorTest::testSelectionChanged):
4175         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
4176         (WebKitFrameTest::testMainFrame):
4177         (WebKitFrameTest::testURI):
4178         (WebKitFrameTest::testJavaScriptContext):
4179         (WebKitFrameTest::testJavaScriptValues):
4180         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
4181         (testWebViewAuthenticationRequest):
4182         (testWebViewAuthenticationLoadCancelled):
4183         (testWebViewAuthenticationFailure):
4184         (testWebViewAuthenticationStorage):
4185         (ProxyAuthenticationTest::ProxyAuthenticationTest):
4186         (testWebViewAuthenticationProxy):
4187         (testWebViewAuthenticationProxyHTTPS):
4188         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4189         (testAutomationSessionRequestSession):
4190         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
4191         (testBackForwardListNavigation):
4192         (testWebKitWebViewSessionState):
4193         (testWebKitWebViewSessionStateWithFormData):
4194         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
4195         (ConsoleMessageTest::consoleMessageReceivedCallback):
4196         (testWebKitConsoleMessageConsoleAPI):
4197         (testWebKitConsoleMessageJavaScriptException):
4198         (testWebKitConsoleMessageNetworkError):
4199         (testWebKitConsoleMessageSecurityError):
4200         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
4201         (testCookieManagerAcceptPolicy):
4202         (testCookieManagerCookiesChanged):
4203         (testCookieManagerPersistentStorage):
4204         (testCookieManagerPersistentStorageDeleteAll):
4205         (testCookieManagerEphemeral):
4206         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
4207         (testWebKitDOMElementAutoFill):
4208         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
4209         (downloadLocalFileSuccessfully):
4210         (createFileAtDestination):
4211         (testDownloadOverwriteDestinationDisallowed):
4212         (testDownloadLocalFileError):
4213         (testDownloadRemoteFile):
4214         (testDownloadRemoteFileError):
4215         (testWebViewDownloadURI):
4216         (testPolicyResponseDownload):
4217         (testPolicyResponseDownloadCancel):
4218         (testDownloadMIMEType):
4219         (contextMenuCallback):
4220         (testContextMenuDownloadActions):
4221         (testBlobDownload):
4222         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
4223         (testWebKitWebEditorSelectionChanged):
4224         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
4225         (testWebKitFrameMainFrame):
4226         (testWebKitFrameURI):
4227         (testWebKitFrameJavaScriptContext):
4228         (testWebKitFrameJavaScriptValues):
4229         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4230         (LoadStopTrackingTest::loadFailed):
4231         (testWebViewTitle):
4232         (testURIRequestHTTPHeaders):
4233         (testURIRequestHTTPMethod):
4234         (testURIResponseHTTPHeaders):
4235         (testRedirectToDataURI):
4236         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
4237         (testProcessPerWebView):
4238         (testWebProcessLimit):
4239         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
4240         (testWebViewResources):
4241         (testWebResourceLoading):
4242         (testWebResourceSuggestedFilename):
4243         (testWebResourceGetData):
4244         (testWebResourceGetDataError):
4245         (testWebViewResourcesHistoryCache):
4246         (testWebResourceSendRequest):
4247         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
4248         (testSSL):
4249         (testInsecureContent):
4250         (testTLSErrorsPolicy):
4251         (testTLSErrorsRedirect):
4252         (testTLSErrorsHTTPAuth):
4253         (testLoadFailedWithTLSErrors):
4254         (testSubresourceLoadFailedWithTLSErrors):
4255         (httpsServerCallback):
4256         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
4257         (testWebViewCreateNavigationData):
4258         (testWebViewJavaScriptDialogs):
4259         (testWebViewWindowProperties):
4260         (testWebViewMouseTarget):
4261         (testWebViewFileChooserRequest):
4262         (testWebViewColorChooserRequest):
4263         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
4264         (testWebExtensionGetTitle):
4265         (testDocumentLoadedSignal):
4266         (testWebKitWebViewProcessCrashed):
4267         (testWebExtensionWindowObjectCleared):
4268         (testWebExtensionIsolatedWorld):
4269         (permissionRequestCallback):
4270         (didAssociateFormControlsCallback):
4271         (testWebExtensionFormControlsAssociated):
4272         (FormSubmissionTest::FormSubmissionTest):
4273         (FormSubmissionTest::testFormSubmissionResult):
4274         (testWebExtensionFormSubmissionSteps):
4275         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
4276         (testNotInitialized):
4277         (testClearDatabase):
4278         (testPrivateBrowsing):
4279         (testGetFavicon):
4280         (testWebViewFavicon):
4281         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
4282         (testFindControllerTextFound):
4283         (testFindControllerTextNotFound):
4284         (testFindControllerMatchCount):
4285         (testFindControllerMaxMatchCount):
4286         (testFindControllerNext):
4287         (testFindControllerPrevious):
4288         (testFindControllerCountedMatches):
4289         (testFindControllerOptions):
4290         (testFindControllerHide):
4291         (testFindControllerInstance):
4292         (testFindControllerGetters):
4293         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
4294         (testNavigationPolicy):
4295         (testResponsePolicy):
4296         (testNewWindowPolicy):
4297         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
4298         (testSecurityOriginBasicConstructor):
4299         (testSecurityOriginURIConstructor):
4300         (testSecurityOriginDefaultPort):
4301         (testSecurityOriginFileURI):
4302         (testOpaqueSecurityOrigin):
4303         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
4304         (testWebKitSettings):
4305         (testWebKitSettingsNewWithSettings):
4306         (testWebKitSettingsUserAgent):
4307         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4308         (testWebViewNewWithUserContentManager):
4309         (isStyleSheetInjectedForURLAtPath):
4310         (isScriptInjectedForURLAtPath):
4311         (testUserContentManagerInjectedStyleSheet):
4312         (testUserContentManagerInjectedScript):
4313         (UserScriptMessageTest::scriptMessageReceived):
4314         (UserScriptMessageTest::waitUntilMessageReceived):
4315         (UserScriptMessageTest::runJavaScriptFinished):
4316         (testUserContentManagerScriptMessageReceived):
4317         (testUserContentManagerScriptMessageInWorldReceived):
4318         (testUserContentManagerScriptMessageFromDOMBindings):
4319         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
4320         (testWebContextDefault):
4321         (testWebContextEphemeral):
4322         (testWebContextGetPlugins):
4323         (testWebContextURIScheme):
4324         (testWebContextSpellChecker):
4325         (testWebContextLanguages):
4326         (consoleMessageReceivedCallback):
4327         (testWebContextSecurityFileXHR):
4328         (ProxyTest::ProxyTest):
4329         (testWebContextProxySettings):
4330         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4331         (testWebViewWebContext):
4332         (testWebViewWebBackend):
4333         (testWebViewEphemeral):
4334         (testWebViewCustomCharset):
4335         (testWebViewSettings):
4336         (testWebViewRunJavaScript):
4337         (testWebViewCanShowMIMEType):
4338         (testWebViewSubmitForm):