Update the way generate-xcfilelists returns strings from functions
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-26  Keith Rollin  <krollin@apple.com>
2
3         Update the way generate-xcfilelists returns strings from functions
4         https://bugs.webkit.org/show_bug.cgi?id=195975
5         <rdar://problem/49040807>
6
7         Reviewed by Dean Jackson.
8
9         There are places where generate-xcfilelists executes assignments with
10         statements like:
11
12             FOO=$(some_function)
13
14         where "some_function" return a string by echoing it. E.g.
15
16             some_function()
17             {
18                 echo "Hello, World"
19             }
20
21         This is a common idiom, but it has a problem if "some_function" needs
22         to call "exit" in an attempt to halt the entire script right then and
23         there. Since "some_function" is called inside of $(), it's being
24         executed in a sub-shell. Calling exit in that sub-shell simply exits
25         that shell; it doesn't not exit the outer shell in which the main part
26         of the script is still running. As such, the main script keeps
27         executing when the intent was for the script to halt.
28
29         The solution to this is to use a different idiom for returning
30         strings. The one we now is to pass in the name of the variable to
31         receive the string result:
32
33             some_function()
34             {
35                 variable_name=$1
36                 eval $variable_name ="Hello, World"
37             }
38
39         The call site now looks like
40
41             some_function FOO
42
43         Because there's no invocation of a sub-shell, some_function can now
44         call "exit" if it wants to, and the entire script will exit at that
45         point.
46
47         * Scripts/generate-xcfilelists:
48
49 2019-03-26  Chris Dumez  <cdumez@apple.com>
50
51         Add basic layout test coverage for File Picker on iOS
52         https://bugs.webkit.org/show_bug.cgi?id=196265
53
54         Reviewed by Wenson Hsieh.
55
56         Add layout test infrastructure to test the file picker on iOS.
57
58         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
59         (WTR::UIScriptController::dismissFilePicker):
60         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
61         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
62         (WTR::UIScriptController::dismissFilePicker):
63         * TestRunnerShared/UIScriptContext/UIScriptController.h:
64         * WebKitTestRunner/TestController.cpp:
65         (WTR::TestController::createWebViewWithOptions):
66         (WTR::updateTestOptionsFromTestHeader):
67         * WebKitTestRunner/TestOptions.h:
68         (WTR::TestOptions::hasSameInitializationOptions const):
69         * WebKitTestRunner/ios/TestControllerIOS.mm:
70         (overridePresentViewController):
71         (WTR::TestController::platformInitialize):
72         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
73         (WTR::UIScriptController::dismissFilePicker):
74
75 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
76
77         Implement async paste method on UIWKInteractionViewProtocol
78         https://bugs.webkit.org/show_bug.cgi?id=196267
79         <rdar://problem/49236346>
80
81         Reviewed by Tim Horton.
82
83         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
84         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
85         are now a part of all iOS 12 internal SDKs.
86
87         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
88
89         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
90         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
91
92         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
93         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
94         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
95         * TestWebKitAPI/ios/UIKitSPI.h:
96
97 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
98
99         [ews-build] Use PostgreSQL for ews.webkit.org database
100         https://bugs.webkit.org/show_bug.cgi?id=196270
101
102         Reviewed by Lucas Forschler.
103
104         * BuildSlaveSupport/ews-app/ews-app/settings.py:
105
106 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
107
108         [ews] Reset simctl states on reboot
109         https://bugs.webkit.org/show_bug.cgi?id=196260
110
111         Rubber-stamped by Aakash Jain.
112
113         * EWSTools/start-queue-mac.sh:
114
115 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
116
117         [ews-build] Use PostgreSQL for ews-build database
118         https://bugs.webkit.org/show_bug.cgi?id=196229
119
120         Reviewed by Lucas Forschler.
121
122         * BuildSlaveSupport/ews-build/master.cfg:
123
124 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
125
126         [ews-build] Get master_hostname dynamically in master.cfg
127         https://bugs.webkit.org/show_bug.cgi?id=196255
128
129         Reviewed by Lucas Forschler.
130
131         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
132         send events data in test mode.
133
134 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
135
136         [ews-app] Set db_constraint to False for Foreign Keys
137         https://bugs.webkit.org/show_bug.cgi?id=196252
138
139         Reviewed by Lucas Forschler.
140
141         * BuildSlaveSupport/ews-app/ews/models/build.py:
142         * BuildSlaveSupport/ews-app/ews/models/step.py:
143
144 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
145
146         [ews-build] is_test_mode_enabled should default to True
147         https://bugs.webkit.org/show_bug.cgi?id=196248
148
149         Reviewed by Lucas Forschler.
150
151         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
152
153 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
154
155         [ews-app] Add webkitperl to ENABLED_QUEUES
156         https://bugs.webkit.org/show_bug.cgi?id=196253
157
158         Reviewed by Lucas Forschler.
159
160         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
161
162 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
163
164         Address NSWindow sometimes using WebKitTestRunnerEvent too early
165         https://bugs.webkit.org/show_bug.cgi?id=196211
166         rdar://problem/49110552
167
168         Reviewed by Tim Horton.
169
170         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
171         Make sure that EventSenderProxy always exists when running tests. We used to create
172         it when resetting before the first test, which is a bit too late.
173
174         * WebKitTestRunner/TestController.h:
175         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
176         (WTR::TestController::platformCreateWebView):
177         (WTR::TestController::platformCreateOtherPage):
178         (WTR::TestController::finishCreatingPlatformWebView):
179         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
180         (WTR::PlatformWebView::PlatformWebView):
181         Moved some code that made NSWindow use NSEvent during web view creation. We may
182         need to move more if some other case us found, but this is enough for now.
183
184 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
185
186         Unreviewed. Fix typo in GLib geolocation API after r243285.
187
188         gelocation -> geolocation.
189
190         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
191         (testGeolocationManagerWatchPosition):
192
193 2019-03-25  Alex Christensen  <achristensen@webkit.org>
194
195         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
196         https://bugs.webkit.org/show_bug.cgi?id=196213
197
198         Reviewed by Geoff Garen.
199
200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
201         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
202         (credentialWithIdentityAndKeychainPath):
203         (-[ChallengeDelegate webView:didFinishNavigation:]):
204         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
205         (TestWebKitAPI::TEST):
206
207 2019-03-25  Alex Christensen  <achristensen@webkit.org>
208
209         Expected shouldn't assume its contained types are copyable
210         https://bugs.webkit.org/show_bug.cgi?id=195986
211
212         Reviewed by JF Bastien.
213
214         * TestWebKitAPI/Tests/WTF/Expected.cpp:
215         (TestWebKitAPI::NonCopyable::operator== const):
216         (TestWebKitAPI::NonCopyable::operator!= const):
217         (TestWebKitAPI::TEST):
218
219 2019-03-25  Tim Horton  <timothy_horton@apple.com>
220
221         Remove some now-unnecessary dynamic class lookup
222         https://bugs.webkit.org/show_bug.cgi?id=196237
223
224         Reviewed by Simon Fraser.
225
226         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
227         (makeRequest):
228         (TEST):
229
230 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
231
232         Unreviewed, rolling out r243450.
233
234         AppleWin and WinCairo port builds get broken.
235
236         Reverted changeset:
237
238         "Add test for fix of #196095"
239         https://bugs.webkit.org/show_bug.cgi?id=196097
240         https://trac.webkit.org/changeset/243450
241
242 2019-03-25  Commit Queue  <commit-queue@webkit.org>
243
244         Unreviewed, rolling out r243465.
245         https://bugs.webkit.org/show_bug.cgi?id=196226
246
247         the test doesn't build (Requested by thorton on #webkit).
248
249         Reverted changeset:
250
251         "Do not terminate the NetworkProcess if a third party
252         application sends a NSCredential with a SecIdentityRef"
253         https://bugs.webkit.org/show_bug.cgi?id=196213
254         https://trac.webkit.org/changeset/243465
255
256 2019-03-25  Alex Christensen  <achristensen@webkit.org>
257
258         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
259         https://bugs.webkit.org/show_bug.cgi?id=196213
260
261         Reviewed by Geoff Garen.
262
263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
264         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
265         (credentialWithIdentityAndKeychainPath):
266         (-[ChallengeDelegate webView:didFinishNavigation:]):
267         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
268         (TestWebKitAPI::TEST):
269
270 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
271
272         [ews-build] Gracefully handle missing patch_id in events
273         https://bugs.webkit.org/show_bug.cgi?id=196216
274
275         Reviewed by Lucas Forschler.
276
277         * BuildSlaveSupport/ews-build/events.py:
278
279 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
280
281         [ews-build] use lz4 compression for improving buildbot performance
282         https://bugs.webkit.org/show_bug.cgi?id=196155
283
284         Reviewed by Lucas Forschler.
285
286         * BuildSlaveSupport/ews-build/master.cfg:
287
288 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
289
290         Pull some API testing helper methods out of TestWKWebView
291         https://bugs.webkit.org/show_bug.cgi?id=196212
292
293         Reviewed by Tim Horton.
294
295         Refactor some more API testing utility methods, so that they can be used in
296         tests that do not use TestWKWebView.
297
298         * TestWebKitAPI/cocoa/TestWKWebView.h:
299         * TestWebKitAPI/cocoa/TestWKWebView.mm:
300         (-[WKWebView loadTestPageNamed:]):
301         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
302         (-[WKWebView synchronouslyLoadHTMLString:]):
303         (-[WKWebView synchronouslyLoadTestPageNamed:]):
304         (-[TestWKWebView loadTestPageNamed:]): Deleted.
305         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
306         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
307         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
308
309 2019-03-25  Jer Noble  <jer.noble@apple.com>
310
311         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
312         https://bugs.webkit.org/show_bug.cgi?id=196097
313
314         Reviewed by Eric Carlson.
315
316         Drive-by bug fix: allow tests to play audio without a user gesture by default.
317
318         * DumpRenderTree/mac/DumpRenderTree.mm:
319         (resetWebPreferencesToConsistentValues):
320         * WebKitTestRunner/TestController.cpp:
321         (WTR::TestController::resetPreferencesToConsistentValues):
322
323 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
324
325         Pull IPadUserInterfaceSwizzler out into a separate header file
326         https://bugs.webkit.org/show_bug.cgi?id=196193
327
328         Reviewed by Anders Carlsson.
329
330         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
331         be used in other API tests.
332
333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
334         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
335         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
336         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
337         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
338         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
339         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
340
341 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
342
343         Remove NavigatorContentUtils in WebCore/Modules
344         https://bugs.webkit.org/show_bug.cgi?id=196070
345
346         Reviewed by Alex Christensen.
347
348         NavigatorContentUtils was to support the custom scheme spec [1].
349         However, in WebKit side, no port has supported the feature in
350         WebKit layer after EFL port was removed. So there has been the
351         only IDL implementation of the NavigatorContentUtils in WebCore.
352         So we don't need to keep the implementation in WebCore anymore.
353
354         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
355
356         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
357
358 2019-03-24  Andy Estes  <aestes@apple.com>
359
360         [watchOS] Remove unused Proximity Networking code
361         https://bugs.webkit.org/show_bug.cgi?id=196188
362
363         Reviewed by Tim Horton.
364
365         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
366         (TEST):
367
368 2019-03-23  Keith Miller  <keith_miller@apple.com>
369
370         Refactor clz/ctz and fix getLSBSet.
371         https://bugs.webkit.org/show_bug.cgi?id=196162
372
373         Reviewed by Saam Barati.
374
375         Add tests for clz, ctz, getLSBSet, and getMSBSet.
376
377         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
378         (TestWebKitAPI::TEST):
379
380 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
381
382         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
383         https://bugs.webkit.org/show_bug.cgi?id=196143
384
385         Reviewed by Michael Catanzaro.
386
387         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
388         directories.
389
390         * Scripts/webkitpy/style/checkers/cpp.py:
391         (check_identifier_name_in_declaration):
392         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
393         (WebKitStyleTest.test_names):
394
395 2019-03-22  Philippe Normand  <pnormand@igalia.com>
396
397         [Flatpak] Manifest expanding fails for qt WPE extension
398         https://bugs.webkit.org/show_bug.cgi?id=196148
399
400         Reviewed by Alex Christensen.
401
402         * flatpak/flatpakutils.py:
403         (expand_submodules_recurse): The last recurse manifest expand
404         iteration might lead to a single module so take it into account
405         and don't try to recurse further.
406
407 2019-03-22  Chris Dumez  <cdumez@apple.com>
408
409         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
410         https://bugs.webkit.org/show_bug.cgi?id=195348
411         <rdar://problem/48622090>
412
413         Reviewed by Alex Christensen.
414
415         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
416         to NO when test.options().shouldIgnoreMetaViewport is false.
417
418         * WebKitTestRunner/ios/TestControllerIOS.mm:
419         (WTR::TestController::platformConfigureViewForTest):
420
421 2019-03-22  Chris Dumez  <cdumez@apple.com>
422
423         Prewarmed processes should be usable with any website data store
424         https://bugs.webkit.org/show_bug.cgi?id=196104
425
426         Reviewed by Alex Christensen.
427
428         Add API test coverage.
429
430         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
431         (runInitialWarmedProcessUsedTest):
432         (TEST):
433
434 2019-03-22  David Kilzer  <ddkilzer@apple.com>
435
436         Back out local changes to Alex's Subversion working directory
437
438         They were accidentally committed.
439
440         * Scripts/webkitpy/common/system/abstractexecutive.py:
441         (AbstractExecutive.wait_newest):
442         * Scripts/webkitpy/common/system/executive.py:
443         (Executive.running_pids):
444         * Scripts/webkitpy/common/system/executive_mock.py:
445         (MockExecutive.running_pids):
446         * Scripts/webkitpy/common/system/executive_unittest.py:
447         (ExecutiveTest.serial_test_running_pids):
448         * Scripts/webkitpy/port/darwin.py:
449         (DarwinPort.check_for_leaks):
450         * Scripts/webkitpy/port/leakdetector.py:
451         (LeakDetector.check_for_leaks):
452         - This was the hack attached to Bug 193772.
453
454         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
455         (+[WebKitTestRunnerEvent mouseLocation]):
456         - This works around a crash on an internal build.
457
458 2019-03-22  Tim Horton  <timothy_horton@apple.com>
459
460         Fix the build after r243354
461         https://bugs.webkit.org/show_bug.cgi?id=196138
462         <rdar://problem/49145951>
463
464         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
465         (TEST):
466         * TestWebKitAPI/ios/UIKitSPI.h:
467
468 2019-03-21  Tim Horton  <timothy_horton@apple.com>
469
470         Adopt UIWKDocumentContext
471         https://bugs.webkit.org/show_bug.cgi?id=196040
472         <rdar://problem/48642440>
473
474         Reviewed by Ryosuke Niwa.
475
476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
477         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
478         (makeRequest):
479         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
480         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
481         (applyStyle):
482         (TEST):
483         Add tests for UIWKDocumentContext.
484
485         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
486         (TEST):
487         (recursiveFindWKContentView): Deleted.
488         * TestWebKitAPI/cocoa/TestWKWebView.h:
489         * TestWebKitAPI/cocoa/TestWKWebView.mm:
490         (recursiveFindWKContentView):
491         (-[TestWKWebView wkContentView]):
492         * TestWebKitAPI/ios/UIKitSPI.h:
493         Share the WKContentView finding code between tests.
494
495 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
496
497         [iOS WK2] Turn on async overflow scrolling by default
498         https://bugs.webkit.org/show_bug.cgi?id=196011
499         rdar://problem/48453859
500
501         Reviewed by Antti Koivisto.
502         
503         Explicitly turn off the async overflow scrolling internal feature for tests by default,
504         since so many basic layout tests have different results when compositing is triggered for
505         overflow.
506         
507         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
508
509         * WebKitTestRunner/TestController.cpp:
510         (WTR::TestController::resetPreferencesToConsistentValues):
511
512 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
513
514         [ews-build] Retry API test in case of failures
515         https://bugs.webkit.org/show_bug.cgi?id=196004
516
517         Reviewed by Lucas Forschler.
518
519         * BuildSlaveSupport/ews-build/steps.py:
520         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
521         (CompileWebKitToT.doStepIf): Ditto.
522         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
523         (ReRunAPITests): Re-run API tests.
524         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
525         (RunAPITestsWithoutPatch): Run API tests without patch.
526         (RunAPITestsWithoutPatch.doStepIf):
527         (RunAPITestsWithoutPatch.hideStepIf):
528         (RunAPITestsWithoutPatch.evaluateCommand):
529         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
530         (AnalyzeAPITestsResults.start):
531         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
532         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
533         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
534         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
535
536 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
537
538         [ews-build] Update queues configurations
539         https://bugs.webkit.org/show_bug.cgi?id=196074
540
541         Reviewed by Dewei Zhu.
542
543         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
544         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
545
546 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
547
548         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
549         https://bugs.webkit.org/show_bug.cgi?id=195680
550         <rdar://problem/48903534>
551
552         Unreviewed infrastructure fix.
553
554         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
555         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
556
557 2019-03-21  Andy Estes  <aestes@apple.com>
558
559         [iOS] Apple Pay should be available in documents with no user agent scripts
560         https://bugs.webkit.org/show_bug.cgi?id=196061
561         <rdar://problem/48649391>
562
563         Reviewed by Brady Eidson.
564
565         Added API tests and related infrastructure.
566
567         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
568         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
569         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
570         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
571         (TestWebKitAPI::TEST):
572         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
573         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
574         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
575         * TestWebKitAPI/cocoa/TestProtocol.mm:
576         (-[TestProtocol startLoading]):
577         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
578         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
579         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
580         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
581
582 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
583
584         REGRESSSION (r243297): webkitpy tests broken
585         https://bugs.webkit.org/show_bug.cgi?id=196108
586
587         Reviewed by Aakash Jain.
588
589         r243297 updated contributors.json, which broke a few unit tests.
590
591         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
592         (IRCCommandTest.test_whois):
593         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
594
595 2019-03-21  Chris Dumez  <cdumez@apple.com>
596
597         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
598         https://bugs.webkit.org/show_bug.cgi?id=196041
599         <rdar://problem/49083230>
600
601         Reviewed by Alex Christensen.
602
603         Add API test coverage.
604
605         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
606         (TEST):
607
608 2019-03-21  Alex Christensen  <achristensen@webkit.org>
609
610         Add SPI to inform applications of WKContentRuleList actions
611         https://bugs.webkit.org/show_bug.cgi?id=195965
612         <rdar://problem/42664365>
613
614         Reviewed by Geoff Garen.
615
616         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
617         (TestWebKitAPI::allActionsForResourceLoad):
618         (TestWebKitAPI::testRequest):
619         (TestWebKitAPI::TEST_F):
620         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
621         (Notification::description):
622         (Notification::operator== const):
623         (toVector):
624         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
625         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
626         (makeContentRuleList):
627         (TEST):
628         (makeWarnContentRuleList): Deleted.
629
630 2019-03-21  Timothy Hatcher  <timothy@apple.com>
631
632         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
633         https://bugs.webkit.org/show_bug.cgi?id=196088
634
635         Reviewed by Brian Burg.
636
637         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
638         Support checks when only one platform is specified. Also deprecate macosx() and
639         force the use of macos() instead.
640
641         * Scripts/webkitpy/style/checkers/cpp.py:
642         (check_min_versions_of_wk_api_available):
643         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
644         (WebKitStyleTest.test_min_versions_of_wk_api_available):
645
646 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
647
648         Update status inactive committers' status to 'contributor'.
649
650         * Scripts/webkitpy/common/config/contributors.json:
651
652 2019-03-21  Xan Lopez  <xan@igalia.com>
653
654         [JSC][x86] Drop support for x87 floating point
655         https://bugs.webkit.org/show_bug.cgi?id=194853
656
657         Reviewed by Don Olmstead.
658
659         Force SSE2 on x86/32bit builds.
660
661         * Scripts/webkitdirs.pm:
662         (generateBuildSystemFromCMakeProject):
663
664 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
665
666         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
667         https://bugs.webkit.org/show_bug.cgi?id=196073
668
669         Reviewed by Michael Catanzaro.
670
671         Add test cases to check functions and constructors with no arguments but receiving user data.
672
673         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
674         (checkUserData):
675         (testJSCFunction):
676         (fooCreateWithUserData):
677         (testJSCClass):
678
679 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
680
681         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
682
683         Add g_assert_cmpfloat_with_epsilon macro if not defined.
684
685         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
686
687 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
688
689         [GTK][WPE] Add API to provide geolocation information
690         https://bugs.webkit.org/show_bug.cgi?id=195940
691
692         Reviewed by Michael Catanzaro.
693
694         Add a new test to check the new API.
695
696         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
697         (testGeolocationManagerCurrentPosition):
698         (testGeolocationManagerWatchPosition):
699         (beforeAll):
700         (afterAll):
701         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
702         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
703         (beforeAll): Ditto.
704         * TestWebKitAPI/glib/CMakeLists.txt:
705
706 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
707
708         [GLib] Returning G_TYPE_OBJECT from a method does not work
709         https://bugs.webkit.org/show_bug.cgi?id=195574
710
711         Reviewed by Michael Catanzaro.
712
713         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
714
715         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
716         (getGFile):
717         (getParent):
718         (createGString):
719         (getGString):
720         (getGStringCopyWillRaise):
721         (getGStringCopy):
722         (getGStringStr):
723         (getGStringLen):
724         (freeGString):
725         (testJSCClass):
726
727 2019-03-20  Saam Barati  <sbarati@apple.com>
728
729         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
730         https://bugs.webkit.org/show_bug.cgi?id=195721
731
732         Reviewed by Filip Pizlo.
733
734         * Scripts/run-javascriptcore-tests:
735
736 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
737
738         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
739         https://bugs.webkit.org/show_bug.cgi?id=196049
740
741         Reviewed by Tim Horton.
742
743         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
744         overflow scrolling in general, so rename it.
745
746         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
747
748 2019-03-20  Daniel Bates  <dabates@apple.com>
749
750         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
751         https://bugs.webkit.org/show_bug.cgi?id=196031
752         <rdar://problem/49078172>
753
754         Reviewed by Tim Horton.
755
756         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
757         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
758         same code path used when the Done button is pressed to dismiss the <select> picker.
759
760         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
761         (TestWebKitAPI::TEST):
762
763 2019-03-20  Chris Dumez  <cdumez@apple.com>
764
765         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
766         https://bugs.webkit.org/show_bug.cgi?id=196029
767         <rdar://problem/48954651>
768
769         Reviewed by Tim Horton.
770
771         Add API test coverage.
772
773         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
774
775 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
776
777         [ews-build] Improve failure summary string for ApplyPatch step
778         https://bugs.webkit.org/show_bug.cgi?id=195995
779
780         Reviewed by Alexey Proskuryakov.
781
782         * BuildSlaveSupport/ews-build/steps.py:
783         (ApplyPatch.getResultSummary): Override getResultSummary.
784
785 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
786
787         AX: Implement support for new meter ARIA role
788         https://bugs.webkit.org/show_bug.cgi?id=195966
789
790         Reviewed by Chris Fleizach.
791
792         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
793         to AXLevelIndicator.
794
795         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
796
797 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
798
799         [WebAuthN] Implement FIDO AppID extension
800         https://bugs.webkit.org/show_bug.cgi?id=143491
801         <rdar://problem/48298273>
802
803         Reviewed by Brent Fulgham.
804
805         Add a test that covers the new flag of convertToU2fSignCommand.
806
807         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
808         (TestWebKitAPI::TEST):
809         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
810         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
811         (TestWebKitAPI::TEST):
812
813 2019-03-19  Keith Rollin  <krollin@apple.com>
814
815         Add support for more platforms to generate-xcfilelists
816         https://bugs.webkit.org/show_bug.cgi?id=195977
817
818         Reviewed by Alexey Proskuryakov.
819
820         generate-xcfilelists incorrectly complains when involved with building
821         WebKit for iphonesimulator:
822
823             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
824             …
825             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
826
827         Address this by teaching generate-xcfilelists about more platforms.
828
829         * Scripts/generate-xcfilelists:
830
831 2019-03-19  John Wilander  <wilander@apple.com>
832
833         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
834         https://bugs.webkit.org/show_bug.cgi?id=195923
835         <rdar://problem/49001272>
836
837         Reviewed by Alex Christensen.
838
839         This patch does the following to the TestRunner:
840         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
841         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
842         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
843
844         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
845         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
846         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
847         * WebKitTestRunner/InjectedBundle/TestRunner.h:
848         * WebKitTestRunner/TestController.cpp:
849         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
850         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
851         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
852         * WebKitTestRunner/TestController.h:
853         * WebKitTestRunner/TestInvocation.cpp:
854         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
855
856 2019-03-19  Christopher Reid  <chris.reid@sony.com>
857
858         [CMake] Support more clang and gcc sanitizers
859         https://bugs.webkit.org/show_bug.cgi?id=195956
860
861         Reviewed by Michael Catanzaro.
862
863         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
864
865 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
866
867         [ews-build] Improve summary for PrintConfiguration step
868         https://bugs.webkit.org/show_bug.cgi?id=195945
869
870         Reviewed by Lucas Forschler.
871
872         * BuildSlaveSupport/ews-build/steps.py:
873         (PrintConfiguration.getResultSummary): Override getResultSummary.
874
875 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
876
877         [ews-build] Improve summary for CheckOutSource step
878         https://bugs.webkit.org/show_bug.cgi?id=195963
879
880         Reviewed by Lucas Forschler.
881
882         * BuildSlaveSupport/ews-build/steps.py:
883         (CheckOutSource.getResultSummary):
884
885 2019-03-19  Daniel Bates  <dabates@apple.com>
886
887         [iOS] Focus not preserved when switching between tabs
888         https://bugs.webkit.org/show_bug.cgi?id=195820
889         <rdar://problem/43614450>
890
891         Reviewed by Brent Fulgham.
892
893         Add tests to ensure that we restore focus when resigning and becoming first responder.
894
895         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
896         (TestWebKitAPI::TEST):
897
898 2019-03-19  Alex Christensen  <achristensen@webkit.org>
899
900         Make WTFLogChannelState and WTFLogLevel enum classes
901         https://bugs.webkit.org/show_bug.cgi?id=195904
902
903         Reviewed by Eric Carlson.
904
905         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
906         (TestWebKitAPI::TEST_F):
907
908 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
909
910         [GStreamer][EME] Backported mssdemux protection data crash fix
911         https://bugs.webkit.org/show_bug.cgi?id=195918
912
913         Reviewed by Philippe Normand.
914
915         * gstreamer/jhbuild.modules:
916         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
917
918 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
919
920         Unreviewed, rolling out r243132.
921
922         Broke GTK build
923
924         Reverted changeset:
925
926         "Make WTFLogChannelState and WTFLogLevel enum classes"
927         https://bugs.webkit.org/show_bug.cgi?id=195904
928         https://trac.webkit.org/changeset/243132
929
930 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
931
932         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
933
934         * Scripts/webkitdirs.pm:
935         (builtDylibPathForName): Adjust the shared library name that's changed
936         with the API version bump in r243073.
937
938 2019-03-18  Alex Christensen  <achristensen@webkit.org>
939
940         Make WTFLogChannelState and WTFLogLevel enum classes
941         https://bugs.webkit.org/show_bug.cgi?id=195904
942
943         Reviewed by Eric Carlson.
944
945         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
946         (TestWebKitAPI::TEST_F):
947
948 2019-03-18  Alex Christensen  <achristensen@webkit.org>
949
950         Disable flaky test added in r2431100
951         https://webkit.org/b/195785
952
953         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
954         (TestWebKitAPI::TEST):
955         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
956
957 2019-03-18  Timothy Hatcher  <timothy@apple.com>
958
959         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
960         https://bugs.webkit.org/show_bug.cgi?id=195916
961
962         Reviewed by Tim Horton.
963
964         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
965         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
966
967 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
968
969         Add a secondary e-mail address for Fujii Hironori to make tools happier.
970
971         * Scripts/webkitpy/common/config/contributors.json:
972
973 2019-03-18  Alex Christensen  <achristensen@webkit.org>
974
975         Implement DownloadMonitor to prevent long-running slow downloads from background apps
976         https://bugs.webkit.org/show_bug.cgi?id=195785
977
978         Reviewed by Geoffrey Garen.
979
980         * TestWebKitAPI/TCPServer.cpp: Added.
981         (TestWebKitAPI::TCPServer::TCPServer):
982         (TestWebKitAPI::TCPServer::~TCPServer):
983         (TestWebKitAPI::TCPServer::socketBindListen):
984         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
985         * TestWebKitAPI/TCPServer.h: Added.
986         (TestWebKitAPI::TCPServer::port const):
987         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
988         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
989         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
990         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
991         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
992         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
993         (TestWebKitAPI::respondSlowly):
994         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
995         (TestWebKitAPI::downloadAtRate):
996         (TestWebKitAPI::TEST):
997
998 2019-03-18  Saam Barati  <sbarati@apple.com>
999
1000         Add a plan file for JetStream 2
1001         https://bugs.webkit.org/show_bug.cgi?id=190734
1002
1003         Reviewed by Mark Lam.
1004
1005         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1006
1007 2019-03-18  Chris Dumez  <cdumez@apple.com>
1008
1009         Delay WebProcess launch until a load is triggered in a Web view
1010         https://bugs.webkit.org/show_bug.cgi?id=195758
1011         <rdar://problem/48126013>
1012
1013         Reviewed by Geoff Garen.
1014
1015         Add API test coverage. Also update some existing API tests to not expect
1016         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1017
1018         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1019         (TestWebKitAPI::TEST):
1020         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1021         (TestWebKitAPI::TEST):
1022         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1023         (TEST):
1024         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1025         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1026         (TEST):
1027         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1028         (TEST):
1029         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1030
1031 2019-03-18  Xan Lopez  <xan@igalia.com>
1032
1033         [CMake] Prevent potential warning when determining $architecture
1034         https://bugs.webkit.org/show_bug.cgi?id=195891
1035
1036         Reviewed by Michael Catanzaro.
1037
1038         It's possible for generateBuildSystemForCMakeProject to be called
1039         before determineArchitecture() is ever called. This will make the
1040         first eq check with $architecture to be bogus (and print a
1041         warning). Change that to an eq check with architecture(), which
1042         implicitly calls determineArchitecture() if needed, and change all
1043         the other similar cases in the method in the same way to prevent
1044         future bugs like this one.
1045
1046         * Scripts/webkitdirs.pm:
1047         (generateBuildSystemFromCMakeProject):
1048
1049 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1050
1051         [WPE] Tarballs generated with “make dist” cannot build documentation
1052         https://bugs.webkit.org/show_bug.cgi?id=195885
1053
1054         Reviewed by Carlos Garcia Campos.
1055
1056         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1057
1058 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1059
1060         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1061         https://bugs.webkit.org/show_bug.cgi?id=195883
1062
1063         Reviewed by Carlos Garcia Campos.
1064
1065         * gtkdoc/gtkdoc.py:
1066         (GTKDoc._run_command): When commands fail to run, include the full command line for
1067         the program invocation and the output it has generated on the standard error stream.
1068
1069 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1070
1071         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1072         https://bugs.webkit.org/show_bug.cgi?id=195786
1073
1074         Reviewed by Philippe Normand.
1075
1076         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1077         * wpe/jhbuild.modules: Ditto.
1078
1079 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1080
1081         [ews-build] Don't run clean builds on EWS builders
1082         https://bugs.webkit.org/show_bug.cgi?id=195851
1083
1084         Reviewed by Geoffrey Garen.
1085
1086         * BuildSlaveSupport/ews-build/factories.py:
1087
1088 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1089
1090         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1091         https://bugs.webkit.org/show_bug.cgi?id=195849
1092
1093         Reviewed by Chris Dumez.
1094
1095         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1096
1097         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1098         (runWebsiteDataStoreCustomPaths):
1099
1100 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1101
1102         webkitpy: Upload test results
1103         https://bugs.webkit.org/show_bug.cgi?id=195755
1104         <rdar://problem/48896182>
1105
1106         Reviewed by Aakash Jain.
1107
1108         Establish a new format for uploading results that is not tied to layout tests, apply
1109         that format to webkitpy tests.
1110
1111         * Scripts/webkitpy/common/checkout/scm/git.py:
1112         (Git.native_branch): Return what branch the current checkout is on.
1113         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1114         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1115         * Scripts/webkitpy/common/checkout/scm/svn.py:
1116         (SVN.native_branch): Ditto.
1117         * Scripts/webkitpy/common/system/platforminfo.py:
1118         (PlatformInfo.build_version): Return a build version for Mac.
1119         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1120         (MockPlatformInfo.__init__):
1121         (MockPlatformInfo.build_version):
1122         * Scripts/webkitpy/results: Added.
1123         * Scripts/webkitpy/results/__init__.py: Added.
1124         * Scripts/webkitpy/results/options.py: Added.
1125         (upload_options): OptParse list for upload options.
1126         * Scripts/webkitpy/results/upload.py: Added.
1127         (Upload): Class which enforces the upload format expected by the results server.
1128         (Upload.Expectations):
1129         (Upload.create_configuration):
1130         (Upload.create_commit):
1131         (Upload.create_details):
1132         (Upload.create_run_stats):
1133         (Upload.create_test_result):
1134         (Upload.__init__):
1135         (Upload.Encoder): Encode Upload object as json.
1136         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1137         * Scripts/webkitpy/results/upload_unittest.py: Added.
1138         * Scripts/webkitpy/test/main.py:
1139         (Tester._parse_args): Add upload arguments.
1140         (Tester._run_tests): Allow results to be uploaded.
1141         * Scripts/webkitpy/test/runner.py:
1142         (Runner.__init__): Record which tests were run, rather than just counting them.
1143         (Runner.handle):
1144         * Scripts/webkitpy/test/runner_unittest.py:
1145         (RunnerTest.test_run):
1146         * Scripts/webkitpy/thirdparty/__init__.py:
1147         (AutoinstallImportHook.find_module): Add requests auto-install.
1148         (AutoinstallImportHook._install_requests):
1149         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1150         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1151
1152 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1153
1154         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1155         https://bugs.webkit.org/show_bug.cgi?id=195810
1156
1157         Reviewed by Tim Horton.
1158
1159         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1160         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1161         ending certain layout tests.
1162
1163         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1164         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1165         (-[TestRunnerWKWebView dealloc]):
1166         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1167
1168         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1169         helper method when destroying the web view, and when resetting state between tests.
1170
1171         * WebKitTestRunner/ios/TestControllerIOS.mm:
1172         (WTR::TestController::platformResetStateToConsistentValues):
1173
1174         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1175
1176 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1177
1178         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1179         https://bugs.webkit.org/show_bug.cgi?id=190350
1180         <rdar://problem/45089503>
1181
1182         Reviewed by Geoffrey Garen.
1183
1184         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1185         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1186         (TEST):
1187         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1188         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1189         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1190         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1191         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1192         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1193         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1194         (runTest):
1195         (createDirectories):
1196         (TEST):
1197         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1198         (TEST):
1199         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1200         (TEST):
1201
1202 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1203
1204         Add support to WebPage for getting the contents as an attributed string.
1205         https://bugs.webkit.org/show_bug.cgi?id=195636
1206         rdar://problem/45055697
1207
1208         Reviewed by Tim Horton.
1209
1210         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1211         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1212
1213 2019-03-15  Chris Dumez  <cdumez@apple.com>
1214
1215         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1216         https://bugs.webkit.org/show_bug.cgi?id=195747
1217
1218         Reviewed by Geoff Garen.
1219
1220         Add API test coverage.
1221
1222         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1223
1224 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1225
1226         Unreviewed, rolling out r242952.
1227
1228         Causing API failures on iOS Simulator
1229
1230         Reverted changeset:
1231
1232         "[PSON] Make sure the WebProcessCache is leverage when
1233         relaunching a process after termination"
1234         https://bugs.webkit.org/show_bug.cgi?id=195747
1235         https://trac.webkit.org/changeset/242952
1236
1237 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1238
1239         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1240         https://bugs.webkit.org/show_bug.cgi?id=195740
1241
1242         Reviewed by Ross Kirsling.
1243
1244         window.open doesn't work for WebKitBrowserWindow because it is not
1245         implemented yet.
1246
1247         1. Implemented createNewPage callback of WKPageUIClient.
1248         2. Changed MainWindow to take a BrowserWindow factory function
1249           instead of BrowserWindowType to be flexible to create
1250           BrowserWindow with extra settings.
1251         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1252           because it is not relevant with MainWindow anymore.
1253
1254         * MiniBrowser/win/Common.cpp:
1255         (parseCommandLine):
1256         * MiniBrowser/win/Common.h:
1257         (CommandLineOptions::CommandLineOptions):
1258         * MiniBrowser/win/MainWindow.cpp:
1259         (MainWindow::MainWindow):
1260         (MainWindow::create):
1261         (MainWindow::init):
1262         (MainWindow::WndProc):
1263         * MiniBrowser/win/MainWindow.h:
1264         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1265         (PrintWebUIDelegate::createWebViewWithRequest):
1266         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1267         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1268         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1269         (WebKitBrowserWindow::updateProxySettings):
1270         (WebKitBrowserWindow::createNewPage):
1271         * MiniBrowser/win/WebKitBrowserWindow.h:
1272         * MiniBrowser/win/WinMain.cpp:
1273         (wWinMain):
1274
1275 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1276
1277         Make it possible to test scrolling tree layer manipulation more easily
1278         https://bugs.webkit.org/show_bug.cgi?id=195780
1279
1280         Reviewed by Tim Horton.
1281         
1282         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1283         cuts off communication of scrolling tree scrolls back to the web process
1284         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1285         allows tests to trigger scrolls which run the scrolling tree layer positioning
1286         logic, but never get another commit from the web process that might mask
1287         scrolling tree bugs.
1288         
1289         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1290         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1291         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1292
1293         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1294         (WTR::UIScriptController::scrollUpdatesDisabled const):
1295         (WTR::UIScriptController::setScrollUpdatesDisabled):
1296         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1297         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1298         (WTR::UIScriptController::scrollUpdatesDisabled const):
1299         (WTR::UIScriptController::setScrollUpdatesDisabled):
1300         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1301         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1302         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1303         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1304         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1305         * WebKitTestRunner/ios/TestControllerIOS.mm:
1306         (WTR::TestController::platformResetStateToConsistentValues):
1307         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1308         (WTR::UIScriptController::scrollUpdatesDisabled const):
1309         (WTR::UIScriptController::setScrollUpdatesDisabled):
1310
1311 2019-03-14  Youenn Fablet  <youenn@apple.com>
1312
1313         Move IDB storage in private browsing mode to NetworkProcess
1314         https://bugs.webkit.org/show_bug.cgi?id=195602
1315
1316         Reviewed by Brady Eidson.
1317
1318         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1319         (TEST):
1320
1321 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1322
1323         [ews-build] Make descriptionDone messages more readable
1324         https://bugs.webkit.org/show_bug.cgi?id=195760
1325
1326         Reviewed by Lucas Forschler.
1327
1328         * BuildSlaveSupport/ews-build/steps.py:
1329         * BuildSlaveSupport/ews-build/steps_unittest.py:
1330
1331 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1332
1333         [ews-build] Generate status-bubble hover-over messages
1334         https://bugs.webkit.org/show_bug.cgi?id=195680
1335
1336         Reviewed by Lucas Forschler.
1337
1338         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1339         (StatusBubble):
1340         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1341         on hover-over.
1342         (StatusBubble._iso_time):
1343         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1344         hover-over message.
1345         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1346
1347 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1348
1349         [ews-app] Gracefully handle the case when state_string is None
1350         https://bugs.webkit.org/show_bug.cgi?id=195753
1351
1352         Reviewed by Lucas Forschler.
1353
1354         * BuildSlaveSupport/ews-app/ews/models/build.py:
1355         * BuildSlaveSupport/ews-app/ews/models/step.py:
1356
1357 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1358
1359         [ews-app] Status bubble display pending for currently running build step
1360         https://bugs.webkit.org/show_bug.cgi?id=195744
1361
1362         Reviewed by Lucas Forschler.
1363
1364         * BuildSlaveSupport/ews-build/events.py:
1365         (Events.stepStarted): If state_string is pending, replace it with step name.
1366
1367 2019-03-14  Chris Dumez  <cdumez@apple.com>
1368
1369         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1370         https://bugs.webkit.org/show_bug.cgi?id=195750
1371
1372         Reviewed by Geoffrey Garen.
1373
1374         Add API test coverage.
1375
1376         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1377         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1378         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1379         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1380
1381 2019-03-14  Chris Dumez  <cdumez@apple.com>
1382
1383         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1384         https://bugs.webkit.org/show_bug.cgi?id=195747
1385
1386         Reviewed by Geoff Garen.
1387
1388         Add API test coverage.
1389
1390         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1391
1392 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1393
1394         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1395         https://bugs.webkit.org/show_bug.cgi?id=195725
1396         <rdar://problem/48545062>
1397
1398         Reviewed by Tim Horton.
1399
1400         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1401         handler is nil.
1402
1403         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1404         (TestWebKitAPI::TEST):
1405
1406 2019-03-13  Sam Weinig  <sam@webkit.org>
1407
1408         Add utility function to allow easy reverse range-based iteration of a container
1409         https://bugs.webkit.org/show_bug.cgi?id=195542
1410
1411         Reviewed by Antti Koivisto.
1412
1413         * TestWebKitAPI/CMakeLists.txt:
1414         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1415         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1416         (TestWebKitAPI::TEST):
1417         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1418
1419 2019-03-13  Chris Dumez  <cdumez@apple.com>
1420
1421         Use a ServiceWorker process per registrable domain
1422         https://bugs.webkit.org/show_bug.cgi?id=195649
1423
1424         Reviewed by Youenn Fablet.
1425
1426         Update API test coverage.
1427
1428         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1429
1430 2019-03-13  Chris Dumez  <cdumez@apple.com>
1431
1432         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1433         https://bugs.webkit.org/show_bug.cgi?id=195684
1434         <rdar://problem/48294714>
1435
1436         Reviewed by Antti Koivisto.
1437
1438         Add API test coverage.
1439
1440         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1441
1442 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1443
1444         [ews-app] Remove unused patch view
1445         https://bugs.webkit.org/show_bug.cgi?id=195669
1446
1447         Reviewed by Lucas Forschler.
1448
1449         * BuildSlaveSupport/ews-app/ews/urls.py:
1450         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1451
1452 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1453
1454         [ews-app] Use Buildbot result code variables
1455         https://bugs.webkit.org/show_bug.cgi?id=195668
1456
1457         Reviewed by Alexey Proskuryakov.
1458
1459         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1460         (Buildbot): Added Buildbot result code variables.
1461         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1462         (StatusBubble._build_bubble): Used Buildbot result code variables.
1463
1464 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
1465
1466         [Flatpak] Expand submodule recursively
1467         https://bugs.webkit.org/show_bug.cgi?id=195672
1468
1469         Building WPE with flatpak was impossible without that as it was raising an exception.
1470         Also update wpebackend-fdo to match what is built in jhbuild
1471
1472         Reviewed by Philippe Normand.
1473
1474         * flatpak/flatpakutils.py:
1475         (expand_submodules_recurse):
1476         (expand_manifest):
1477         * flatpak/org.webkit.WPEModules.yaml:
1478
1479 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1480
1481         [ews-app] status bubble should be hidden for certain builds
1482         https://bugs.webkit.org/show_bug.cgi?id=194597
1483
1484         Reviewed by Dewei Zhu.
1485
1486         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1487         (StatusBubble._build_bubble):
1488         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
1489         because the patch didn't have relevant changes.
1490         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
1491         in production yet.
1492
1493 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
1494
1495         [Win] Fix a slew of simple clang-cl warnings.
1496         https://bugs.webkit.org/show_bug.cgi?id=195652
1497
1498         Reviewed by Don Olmstead.
1499
1500         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1501         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
1502
1503 2019-03-12  Justin Fan  <justin_fan@apple.com>
1504
1505         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
1506         https://bugs.webkit.org/show_bug.cgi?id=195518
1507         <rdar://problem/46322356>
1508
1509         Reviewed by Myles C. Maxfield.
1510
1511         * DumpRenderTree/DerivedSources-input.xcfilelist:
1512         * DumpRenderTree/DerivedSources-output.xcfilelist:
1513
1514 2019-03-12  Commit Queue  <commit-queue@webkit.org>
1515
1516         Unreviewed, rolling out r242825.
1517         https://bugs.webkit.org/show_bug.cgi?id=195648
1518
1519         "Broke webkitpy tests with my change to
1520         lldb_dump_class_layout.py" (Requested by rmorisset on
1521         #webkit).
1522
1523         Reverted changeset:
1524
1525         "Alter Tools/Scripts/dump-class-layout to be able to dump all
1526         classes with suspicious padding"
1527         https://bugs.webkit.org/show_bug.cgi?id=195573
1528         https://trac.webkit.org/changeset/242825
1529
1530 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1531
1532         [ews-build] Show status bubbles while the patch is waiting in queue
1533         https://bugs.webkit.org/show_bug.cgi?id=195618
1534
1535         Reviewed by Lucas Forschler.
1536
1537         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1538         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
1539         enabled in initial deployment.
1540         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
1541         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
1542         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
1543         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
1544         (StatusBubble._build_bubbles_for_patch):
1545
1546 2019-03-12  Robin Morisset  <rmorisset@apple.com>
1547
1548         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
1549         https://bugs.webkit.org/show_bug.cgi?id=195573
1550
1551         Reviewed by Simon Fraser.
1552
1553         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
1554
1555         * Scripts/dump-class-layout:
1556         (main):
1557         * lldb/lldb_dump_class_layout.py:
1558         (ClassLayout.__init__):
1559         (ClassLayout._compute_padding_recursive):
1560         (LLDBDebuggerInstance.dump_layout_for_classname):
1561         (LLDBDebuggerInstance):
1562         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
1563         (LLDBDebuggerInstance.layout_for_classname): Deleted.
1564
1565 2019-03-12  Chris Dumez  <cdumez@apple.com>
1566
1567         Device Orientation access permission should be denied unless explicitly granted by the client
1568         https://bugs.webkit.org/show_bug.cgi?id=195625
1569
1570         Reviewed by Youenn Fablet.
1571
1572         add API test coverage.
1573
1574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1575         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
1576         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
1577         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
1578         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1579         (runDeviceOrientationTest):
1580         (TEST):
1581         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1582         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1583
1584 2019-03-12  Jer Noble  <jer.noble@apple.com>
1585
1586         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
1587         https://bugs.webkit.org/show_bug.cgi?id=195137
1588         <rdar://problem/48810307>
1589
1590         Reviewed by Eric Carlson.
1591
1592         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
1593         (TestWebKitAPI::TEST):
1594
1595 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1596
1597         [ews-build] Change urls from uat to production
1598         https://bugs.webkit.org/show_bug.cgi?id=195566
1599
1600         Reviewed by Lucas Forschler.
1601
1602         * BuildSlaveSupport/ews-app/ews/config.py:
1603         * BuildSlaveSupport/ews-build/events.py:
1604         * BuildSlaveSupport/ews-build/steps.py:
1605
1606 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1607
1608         [ews-build] change max_builds for local-worker to 1
1609         https://bugs.webkit.org/show_bug.cgi?id=195568
1610
1611         Reviewed by Lucas Forschler.
1612
1613         * BuildSlaveSupport/ews-build/loadConfig.py:
1614
1615 2019-03-12  Tim Horton  <timothy_horton@apple.com>
1616
1617         Fix the build
1618
1619         * TestRunnerShared/spi/PencilKitTestSPI.h:
1620         * TestWebKitAPI/ios/PencilKitTestSPI.h:
1621
1622 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1623
1624         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
1625         https://bugs.webkit.org/show_bug.cgi?id=194131
1626
1627         Reviewed by Michael Catanzaro.
1628
1629         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1630         (uriChanged):
1631         (testUnfinishedSubresourceLoad):
1632         (serverCallback):
1633         (beforeAll):
1634
1635 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1636
1637         WTF::Expected should use std::addressof instead of operator&
1638         https://bugs.webkit.org/show_bug.cgi?id=195604
1639
1640         Reviewed by Myles Maxfield.
1641
1642         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1643         (TestWebKitAPI::Unique::Unique):
1644         (TestWebKitAPI::Unique::operator&):
1645         (TestWebKitAPI::TEST):
1646
1647 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
1648
1649         Add Optional to Forward.h.
1650         https://bugs.webkit.org/show_bug.cgi?id=195586
1651
1652         Reviewed by Darin Adler.
1653
1654         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
1655         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
1656         Remove unnecessary includes from headers.
1657
1658 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
1659
1660         Add testing API to hit-test and scroll overflow scrollers
1661         https://bugs.webkit.org/show_bug.cgi?id=195278
1662
1663         Reviewed by Antti Koivisto.
1664         
1665         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
1666         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
1667         
1668         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
1669
1670         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1671         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1672         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1673         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1674         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1675         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1676         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1677         (WTR::enclosingScrollViewIncludingSelf):
1678         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1679
1680 2019-03-11  Tim Horton  <timothy_horton@apple.com>
1681
1682         API test WebKit.RequestTextInputContext fails on iOS
1683         https://bugs.webkit.org/show_bug.cgi?id=195585
1684
1685         Reviewed by Wenson Hsieh and Simon Fraser.
1686
1687         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1688         (applyStyle):
1689         (TEST):
1690         Add a viewport, so that the coordinates match up on iOS.
1691         Scroll by moving the UIScrollView's contentOffset.
1692
1693 2019-03-11  Chris Dumez  <cdumez@apple.com>
1694
1695         Assert in WebPageProxy::suspendCurrentPageIfPossible()
1696         https://bugs.webkit.org/show_bug.cgi?id=195506
1697         <rdar://problem/48733477>
1698
1699         Reviewed by Alex Christensen.
1700
1701         Add API test coverage.
1702
1703         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1704
1705 2019-03-11  Shawn Roberts  <sroberts@apple.com>
1706
1707         Adding myself to contributors.json
1708
1709         Unreviewed, addming myself to contributors.json .
1710
1711         * Scripts/webkitpy/common/config/contributors.json:
1712
1713 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1714
1715         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1716         https://bugs.webkit.org/show_bug.cgi?id=195511
1717         <rdar://problem/44873269>
1718
1719         Reviewed by Darin Adler.
1720
1721         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1722         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1723         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1724         (TEST_F):
1725
1726 2019-03-11  Chris Dumez  <cdumez@apple.com>
1727
1728         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
1729         https://bugs.webkit.org/show_bug.cgi?id=195561
1730
1731         Reviewed by Youenn Fablet.
1732
1733         Make sure the JS in the test requests for permission to receive device orientation events.
1734
1735         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1736
1737 2019-03-11  Youenn Fablet  <youenn@apple.com>
1738
1739         Allow storage quota increase by default in WTR
1740         https://bugs.webkit.org/show_bug.cgi?id=195541
1741
1742         Reviewed by Geoffrey Garen.
1743
1744         Allow storage quota increase by default in WTR.
1745         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
1746         Use this for tests that explicitly need cache increase.
1747
1748         Instead of increasing quota by 2, make sure the next request is
1749         granted by adding all given parameters.
1750
1751         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1752         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1753         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1754         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
1755         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1756         * WebKitTestRunner/TestController.cpp:
1757         (WTR::TestController::setAllowStorageQuotaIncrease):
1758         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1759         * WebKitTestRunner/TestController.h:
1760         * WebKitTestRunner/TestInvocation.cpp:
1761         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1762         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1763         (WTR::TestController::cocoaResetStateToConsistentValues):
1764         (WTR::TestController::setAllowStorageQuotaIncrease):
1765         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1766         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1767         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1768
1769 2019-03-11  Xan Lopez  <xan@igalia.com>
1770
1771         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
1772         https://bugs.webkit.org/show_bug.cgi?id=194147
1773
1774         Reviewed by Michael Saboff.
1775
1776         To make --32-bit work correctly on Linux/64bit we need to:
1777
1778         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
1779         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
1780         unfortunately CMake only allows us to do this during
1781         crosscompilation, which is overkill here.
1782         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
1783         pkg-config detection module uses the x86 .pc files instead of the
1784         x86_64 ones.
1785         - Set the -m32 flags for the compiler.
1786
1787         * Scripts/webkitdirs.pm:
1788         (generateBuildSystemFromCMakeProject):
1789
1790 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
1791
1792         Add MotionMark-1.1 plan file for run-benchmark script.
1793         https://bugs.webkit.org/show_bug.cgi?id=195481
1794
1795         Rubber-stamped by Darin Adler.
1796
1797         Run-benchmark script should support MontionMark-1.1.
1798
1799         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
1800
1801 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1802
1803         [ews-app] Add support for submit-to-ews url
1804         https://bugs.webkit.org/show_bug.cgi?id=195477
1805
1806         Reviewed by Lucas Forschler.
1807
1808         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1809         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1810         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
1811         * BuildSlaveSupport/ews-app/ews/urls.py:
1812         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
1813
1814 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
1815
1816         Unreviewed, rolling out r242688, r242643, r242624.
1817
1818         Caused multiple layout test failures and crashes on iOS and macOS.
1819
1820         Reverted changeset:
1821
1822         "requestAnimationFrame should execute before the next frame"
1823         https://bugs.webkit.org/show_bug.cgi?id=177484
1824         https://trac.webkit.org/changeset/242624/webkit
1825
1826         * Tracing/SystemTracePoints.plist:
1827
1828 2019-03-11  John Wilander  <wilander@apple.com>
1829
1830         Resource Load Statistics: Make it possible exclude localhost from classification
1831         https://bugs.webkit.org/show_bug.cgi?id=195474
1832         <rdar://problem/47520577>
1833
1834         Reviewed by Brent Fulgham.
1835
1836         This patch allows for localhost to be excluded from classification and
1837         treatment as a prevalent resource.
1838
1839         The WebKit Tools change adds a new function called
1840         testRunner.setStatisticsIsRunningTest() which can be used to control this
1841         behavior.
1842
1843         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1844         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1845         (WTR::TestRunner::setStatisticsIsRunningTest):
1846         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1847         * WebKitTestRunner/TestController.cpp:
1848         (WTR::TestController::setStatisticsIsRunningTest):
1849         * WebKitTestRunner/TestController.h:
1850         * WebKitTestRunner/TestInvocation.cpp:
1851         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1852
1853 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1854
1855         [ews-build] Disable waterfall and console view for ews-build.webkit.org
1856         https://bugs.webkit.org/show_bug.cgi?id=195560
1857
1858         Reviewed by Lucas Forschler.
1859
1860         * BuildSlaveSupport/ews-build/master.cfg:
1861
1862 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1863
1864         Unreviewed, rolling out r242698.
1865
1866         API test crashes on bots.
1867
1868         Reverted changeset:
1869
1870         "Add a WKContentRuleList variant that uses copied memory
1871         instead of mmap'd shared memory for class A containerized
1872         apps"
1873         https://bugs.webkit.org/show_bug.cgi?id=195511
1874         https://trac.webkit.org/changeset/242698
1875
1876 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1877
1878         [WPE] Enable web process sandbox
1879         https://bugs.webkit.org/show_bug.cgi?id=195169
1880
1881         Reviewed by Daniel Bates.
1882
1883         * wpe/install-dependencies:
1884         * wpe/jhbuild.modules:
1885
1886 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1887
1888         [ews-app] Use port 17000 for worker communication
1889         https://bugs.webkit.org/show_bug.cgi?id=195558
1890
1891         Reviewed by Lucas Forschler.
1892
1893         * BuildSlaveSupport/ews-build/master.cfg:
1894
1895 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1896
1897         [ews-build] unit-tests fail when passwords.json is missing
1898         https://bugs.webkit.org/show_bug.cgi?id=195557
1899
1900         Reviewed by Lucas Forschler.
1901
1902         * BuildSlaveSupport/ews-build/loadConfig.py:
1903         (loadBuilderConfig):
1904         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1905         (ConfigDotJSONTest.test_configuration):
1906         * BuildSlaveSupport/ews-build/master.cfg:
1907
1908 2019-03-11  Truitt Savell  <tsavell@apple.com>
1909
1910         Unreviewed, rolling out r242702.
1911
1912         Broke High Sierra builders.
1913
1914         Reverted changeset:
1915
1916         "Add utility function to allow easy reverse range-based
1917         iteration of a container"
1918         https://bugs.webkit.org/show_bug.cgi?id=195542
1919         https://trac.webkit.org/changeset/242702
1920
1921 2019-03-11  Sam Weinig  <sam@webkit.org>
1922
1923         Add utility function to allow easy reverse range-based iteration of a container
1924         https://bugs.webkit.org/show_bug.cgi?id=195542
1925
1926         Reviewed by Antti Koivisto.
1927
1928         * TestWebKitAPI/CMakeLists.txt:
1929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1930         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1931         (TestWebKitAPI::TEST):
1932         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1933
1934 2019-03-10  Alex Christensen  <achristensen@webkit.org>
1935
1936         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1937         https://bugs.webkit.org/show_bug.cgi?id=195511
1938         <rdar://problem/44873269>
1939
1940         Reviewed by Darin Adler.
1941
1942         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1943         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1944         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1945         (TEST_F):
1946
1947 2019-03-10  Tim Horton  <timothy_horton@apple.com>
1948
1949         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
1950         https://bugs.webkit.org/show_bug.cgi?id=195499
1951
1952         Reviewed by Darin Adler.
1953
1954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1955         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
1956         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
1957         (-[WKWebView synchronouslyFocusTextInputContext:]):
1958         (applyStyle):
1959         (applyIframe):
1960         (TEST):
1961         Add some tests for this SPI.
1962
1963 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
1964
1965         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
1966         https://bugs.webkit.org/show_bug.cgi?id=181151
1967
1968         Reviewed by Don Olmstead.
1969
1970         * TestWebKitAPI/CMakeLists.txt:
1971         * TestWebKitAPI/PlatformWin.cmake:
1972         Enable TestWTF RunLoop tests in all platforms.
1973
1974         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1975         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
1976         (TestWebKitAPI::DerivedOneShotTimer::fired):
1977         (TestWebKitAPI::TEST):
1978         Only a few platforms support nested RunLoop.
1979
1980         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
1981         (TestWebKitAPI::DerivedRepeatingTimer::fired):
1982
1983 2019-03-10  David Quesada  <david_quesada@apple.com>
1984
1985         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
1986         https://bugs.webkit.org/show_bug.cgi?id=152480
1987
1988         Reviewed by Chris Dumez.
1989
1990         Add a unit test based on Daniel Bates's test case that starts a download, ensures
1991         there are no additional references to the process pool besides the one held by
1992         the download, waits for the download to finish (in the sense that the
1993         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
1994         measure, also check that the process pool has been deallocated at the end of the
1995         test. The test wouldn't be meaningful if the process pool were still alive.
1996
1997         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1998         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1999         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2000             The download will be canceled because the delegate does not implement the
2001             method to decide the download's destination, so this is where we know the
2002             DownloadProxyMap is done with the DownloadProxy.
2003         (TEST):
2004
2005 2019-03-08  Chris Dumez  <cdumez@apple.com>
2006
2007         Add support for Device Orientation / Motion permission API
2008         https://bugs.webkit.org/show_bug.cgi?id=195329
2009         <rdar://problem/47645367>
2010
2011         Reviewed by Geoffrey Garen.
2012
2013         Add test infrastructure to help test the Device Orientation / Motion permission API.
2014
2015         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2016         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2017         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2018         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2019         * WebKitTestRunner/TestController.cpp:
2020         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2021         (WTR::TestController::createWebViewWithOptions):
2022         (WTR::TestController::resetStateToConsistentValues):
2023         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2024         * WebKitTestRunner/TestController.h:
2025         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2026         * WebKitTestRunner/TestInvocation.cpp:
2027         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2028
2029 2019-03-08  Saam barati  <sbarati@apple.com>
2030
2031         Add a compare-results script to compare benchmark results
2032         https://bugs.webkit.org/show_bug.cgi?id=195486
2033         <rdar://problem/48723397>
2034
2035         Reviewed by Geoffrey Garen.
2036
2037         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2038         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2039         to extend it to learn about our other benchmarks.
2040
2041         * Scripts/compare-results: Added.
2042         (readJSONFile):
2043         (detectJetStream2):
2044         (JetStream2Results):
2045         (detectSpeedometer2):
2046         (Speedometer2Results):
2047         (detectPLT5):
2048         (PLT5Results):
2049         (detectBenchmark):
2050         (biggerIsBetter):
2051         (ttest):
2052         (getOptions):
2053         (main):
2054
2055 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2056
2057         Ensure old tab state is cleared between iterations of run-benchmark
2058         https://bugs.webkit.org/show_bug.cgi?id=195393
2059         <rdar://problem/46885583>
2060
2061         Reviewed by Dewei Zhu.
2062
2063         a) ensure the default to restore state is not set
2064         b) terminate Safari correctly
2065         c) Set the system default to ignore Persistent State in Safari
2066
2067         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2068         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2069         (OSXBrowserDriver.prepare_env): 
2070         (OSXBrowserDriver.restore_env):
2071         (OSXBrowserDriver.close_browsers):
2072         (OSXBrowserDriver._terminate_processes):
2073         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2074         (OSXChromeDriver):
2075         (OSXChromeCanaryDriver):
2076         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2077         (OSXFirefoxDriver):
2078         (OSXFirefoxNightlyDriver):
2079         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2080         (OSXSafariDriver):
2081         (OSXSafariDriver.prepare_env):
2082
2083 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2084
2085         [GTK] Several InputMethodFilter tests are failing
2086         https://bugs.webkit.org/show_bug.cgi?id=195408
2087
2088         Reviewed by Carlos Garcia Campos.
2089
2090         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2091         Regressed in r241751.
2092         Hexadecimal values of keycodes are expressed now in upper letters.
2093         Composited characters should be cast to UTF8 strings.
2094
2095         (TestWebKitAPI::TEST):
2096
2097 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2098
2099         [GTK] Make Tools/gtkdoc python3 compatible
2100         https://bugs.webkit.org/show_bug.cgi?id=195359
2101
2102         Reviewed by Carlos Garcia Campos.
2103
2104         * gtkdoc/generate-gtkdoc:
2105         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2106         work with Python 2 and 3.
2107         (get_gtkdoc_module_paths):
2108         The iteritems() was removed in Python 3, so let's use items() that's
2109         available in Python 2 and 3.
2110         (get_generator_for_config):
2111         * gtkdoc/gtkdoc.py:
2112         (GTKDoc._run_command):
2113         The sys.stdout.write() is expecting str in Python 3 and not bytes
2114         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2115         for passing the bytes there.
2116
2117 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2118
2119         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2120         https://bugs.webkit.org/show_bug.cgi?id=195346
2121         <rdar://problem/48667048>
2122
2123         Unreviewed build fix for clang-cl.
2124
2125         * DumpRenderTree/win/DumpRenderTree.cpp:
2126         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2127
2128 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2129
2130         requestAnimationFrame should execute before the next frame
2131         https://bugs.webkit.org/show_bug.cgi?id=177484
2132
2133         Reviewed by Simon Fraser.
2134
2135         Add trace points for the page RenderingUpdate.
2136
2137         * Tracing/SystemTracePoints.plist:
2138
2139 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2140
2141         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2142         https://bugs.webkit.org/show_bug.cgi?id=195353
2143         <rdar://problem/48626394>
2144
2145         Reviewed by Simon Fraser.
2146
2147         * WebKitTestRunner/ios/TestControllerIOS.mm:
2148         (WTR::TestController::platformResetPreferencesToConsistentValues):
2149
2150 2019-03-07  John Wilander  <wilander@apple.com>
2151
2152         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2153         https://bugs.webkit.org/show_bug.cgi?id=195383
2154         <rdar://problem/48570136>
2155
2156         Reviewed by Brent Fulgham.
2157
2158         This patch adds test infrastructure to purge only script-accessible cookies,
2159         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2160
2161         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2162         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2163         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2164         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2165         * WebKitTestRunner/TestController.cpp:
2166         (WTR::TestController::statisticsDeleteCookiesForHost):
2167         * WebKitTestRunner/TestController.h:
2168         * WebKitTestRunner/TestInvocation.cpp:
2169         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2170
2171 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2172
2173         Unreviewed, rolling out r242354.
2174         https://bugs.webkit.org/show_bug.cgi?id=195402
2175
2176         breaks layout tests in all configurations (Requested by
2177         zdobersek on #webkit).
2178
2179         Reverted changeset:
2180
2181         "[WPE] Enable web process sandbox"
2182         https://bugs.webkit.org/show_bug.cgi?id=195169
2183         https://trac.webkit.org/changeset/242354
2184
2185 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2186
2187         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2188         https://bugs.webkit.org/show_bug.cgi?id=195346
2189
2190         Reviewed by Fujii Hironori.
2191
2192         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2193         (TestWebKitAPI::TEST):
2194         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2195
2196         * DumpRenderTree/win/DumpRenderTree.cpp:
2197         (findFontFallback):
2198         (addFontFallbackIfPresent):
2199         (removeFontFallbackIfPresent):
2200         (main):
2201         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2202         (TestWebKitAPI::Util::moduleDirectory):
2203         (TestWebKitAPI::Util::createInjectedBundlePath):
2204         Use wchar helpers as needed.
2205
2206 2019-03-06  Rob Buis  <rbuis@igalia.com>
2207
2208         Consider supporting the `referrerpolicy` attribute.
2209         https://bugs.webkit.org/show_bug.cgi?id=179053
2210
2211         Reviewed by Darin Adler.
2212
2213         Add a runtime flag for referrerpolicy attribute.
2214
2215         * DumpRenderTree/mac/DumpRenderTree.mm:
2216         (enableExperimentalFeatures):
2217
2218 2019-03-05  Daniel Bates  <dabates@apple.com>
2219
2220         Update expected API test result following r242379
2221         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2222
2223         Update expected x-coordinate of selection rect now that the left padding of
2224         a textarea is sized in ems (so dependent on the font size) just like the left
2225         padding of a text field.
2226
2227         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2228         (TestWebKitAPI::TEST):
2229
2230 2019-03-05  David Quesada  <david_quesada@apple.com>
2231
2232         [WK2] It should be possible to follow links with 'download' attributes
2233         https://bugs.webkit.org/show_bug.cgi?id=195145
2234         rdar://problem/48462642
2235
2236         Reviewed by Alex Christensen.
2237
2238         Add a unit test to verify that activating links with 'download' attributes now
2239         navigates to the linked resource, rather than starts downloading it. Add another
2240         to verify that it is still possible to explicitly download the link via the
2241         'Download' navigation action policy.
2242
2243         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2244         (-[DownloadAttributeTestDelegate init]):
2245         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2246         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2247         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2248         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2249         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2250         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2251         (TEST):
2252         * WebKitTestRunner/TestController.cpp:
2253         (WTR::TestController::decidePolicyForNavigationAction):
2254         * WebKitTestRunner/TestController.h:
2255
2256 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2257
2258         [Curl] Implement Cookie Accept Policy.
2259         https://bugs.webkit.org/show_bug.cgi?id=191645
2260
2261         Reviewed by Fujii Hironori.
2262
2263         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2264         (TestWebKitAPI::Curl::TEST_F):
2265
2266 2019-03-05  Youenn Fablet  <youenn@apple.com>
2267
2268         Rename requestCacheStorageSpace to requestStorageSpace
2269         https://bugs.webkit.org/show_bug.cgi?id=195282
2270
2271         Reviewed by Chris Dumez.
2272
2273         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2274         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2275         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2276
2277 2019-03-05  Brady Eidson  <beidson@apple.com>
2278
2279         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2280         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2281
2282         Reviewed by Tim Horton.
2283
2284         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2285         different directory into that same WKWebView should work.
2286
2287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2288         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2289
2290 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2291
2292         Add WeakHashSet
2293         https://bugs.webkit.org/show_bug.cgi?id=195152
2294
2295         Reviewed by Antti Koivisto.
2296
2297         Added tests for WeakHashSet.
2298
2299         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2300         (TestWebKitAPI::Base::Base): Moved.
2301         (TestWebKitAPI::Derived::foo): Moved.
2302         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2303         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2304         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2305         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2306
2307 2019-03-04  Chris Dumez  <cdumez@apple.com>
2308
2309         Do not share WebProcesses between private and regular sessions
2310         https://bugs.webkit.org/show_bug.cgi?id=195189
2311         <rdar://problem/48421064>
2312
2313         Reviewed by Alex Christensen.
2314
2315         Add API test coverage.
2316
2317         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2318         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2319
2320 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2321
2322         [WPE] Enable web process sandbox
2323         https://bugs.webkit.org/show_bug.cgi?id=195169
2324
2325         Reviewed by Daniel Bates.
2326
2327         * wpe/install-dependencies:
2328         * wpe/jhbuild.modules:
2329
2330 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2331
2332         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2333         https://bugs.webkit.org/show_bug.cgi?id=195206
2334
2335         Reviewed by Žan Doberšek.
2336
2337         Add a new test case.
2338
2339         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2340         (testJSCClass):
2341
2342 2019-03-04  Charlie Turner  <cturner@igalia.com>
2343
2344         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2345         https://bugs.webkit.org/show_bug.cgi?id=194898
2346
2347         Reviewed by Žan Doberšek.
2348
2349         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2350         a GCC extension that permits arithmetic on void* pointer. Inline
2351         the macro until this issue is fixed upstream.
2352
2353 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2354
2355         Rid the world of WK_API_ENABLED
2356         https://bugs.webkit.org/show_bug.cgi?id=195263
2357
2358         Reviewed by Dan Bernstein.
2359
2360         List of changed files elided because it's useless.
2361
2362 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2363
2364         Unreviewed follow-up to r242292.
2365
2366         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2367
2368         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2369         (TestWebKitAPI::testStrip): Renamed from strip.
2370         (TestWebKitAPI::TEST):
2371
2372 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2373
2374         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2375
2376         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2377         and bug #194272 for details.
2378
2379         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2380
2381 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2382
2383         Remove some more unused 32-bit code
2384         https://bugs.webkit.org/show_bug.cgi?id=195255
2385
2386         Reviewed by Darin Adler.
2387
2388         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2389         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2390         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2391         (NPP_New):
2392         (NPP_HandleEvent):
2393         (handleEventCarbon): Deleted.
2394
2395 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2396
2397         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2398
2399         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2400         (TestWebKitAPI::TEST):
2401
2402 2019-03-01  Darin Adler  <darin@apple.com>
2403
2404         Finish removing String::format
2405         https://bugs.webkit.org/show_bug.cgi?id=194893
2406
2407         Reviewed by Daniel Bates.
2408 '
2409         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2410
2411 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2412
2413         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2414         https://bugs.webkit.org/show_bug.cgi?id=195229
2415         <rdar://problem/48520362>
2416
2417         Reviewed by Chris Dumez.
2418
2419         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2420         (TEST):
2421
2422 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2423
2424         Add a system trace scope for event region building
2425         https://bugs.webkit.org/show_bug.cgi?id=195226
2426
2427         Reviewed by Jon Lee.
2428
2429         This trace scope measures the time spend converting element rects into Region objects,
2430         which can be large on some pages.
2431
2432         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2433
2434         * Tracing/SystemTracePoints.plist:
2435
2436 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2437
2438         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2439         https://bugs.webkit.org/show_bug.cgi?id=194612
2440
2441         Reviewed by Alex Christensen.
2442
2443         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2444         Just test the new string-processing function and don't touch the actual environment.
2445         (Test cases are all as before, but based on operator== instead of strcmp.)
2446
2447 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2448
2449         [ews-app] Update primary keys for handling multiple Buildbot instances
2450         https://bugs.webkit.org/show_bug.cgi?id=195120
2451
2452         Reviewed by Stephanie Lewis.
2453
2454         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2455         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
2456         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
2457
2458         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
2459         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
2460         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
2461         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
2462         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
2463         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
2464
2465 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
2466
2467         [WinCairo] Enable service worker
2468         https://bugs.webkit.org/show_bug.cgi?id=188318
2469
2470         Reviewed by Youenn Fablet.
2471
2472         * DumpRenderTree/DumpRenderTreePrefix.h:
2473         * TestWebKitAPI/PlatformWin.cmake:
2474         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
2475         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
2476         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2477
2478 2019-03-01  Justin Fan  <justin_fan@apple.com>
2479
2480         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
2481         https://bugs.webkit.org/show_bug.cgi?id=195191
2482
2483         Rubber-stamped by Dean Jackson.
2484
2485         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
2486
2487         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2488
2489 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
2490
2491         Unreviewed, fix lldb webkitpy tests
2492         https://bugs.webkit.org/show_bug.cgi?id=194375
2493
2494         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
2495
2496         * lldb/lldb_webkit.py:
2497         (WTFStringImplProvider.is_8bit):
2498
2499 2019-02-28  David Quesada  <david_quesada@apple.com>
2500
2501         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
2502         https://bugs.webkit.org/show_bug.cgi?id=195121
2503         rdar://problem/48450302
2504
2505         Reviewed by Alex Christensen.
2506
2507         Add API tests for -WKNavigationAction._shouldPerformDownload in various
2508         configurations where the 'download' attribute is absent, blank, or populated
2509         with a filename, and where the anchor element is same-origin or cross-origin
2510         (meaning the 'download' attribute shouldn't be honored).
2511
2512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2513         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
2514         (-[NavigationActionTestDelegate init]):
2515         (-[NavigationActionTestDelegate navigationAction]):
2516         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
2517         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
2518         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2519         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
2520         (TEST):
2521
2522 2019-02-28  Antoine Quint  <graouts@apple.com>
2523
2524         Enable the Pointer Events runtime flag by default
2525         https://bugs.webkit.org/show_bug.cgi?id=195156
2526
2527         Reviewed by Dean Jackson.
2528
2529         * DumpRenderTree/mac/DumpRenderTree.mm:
2530         (enableExperimentalFeatures):
2531
2532 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2533
2534         Several PasteImage API tests are flaky
2535         https://bugs.webkit.org/show_bug.cgi?id=195160
2536
2537         Reviewed by Tim Horton.
2538
2539         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
2540         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
2541         listening for a "load" event after image load is already complete.
2542
2543         To address this, make these tests first register a "load" event handler, then run script to insert an image
2544         element into the document, and finally wait until the load event is observed before checking image size.
2545
2546         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2547
2548 2019-02-28  Chris Dumez  <cdumez@apple.com>
2549
2550         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
2551         https://bugs.webkit.org/show_bug.cgi?id=195107
2552
2553         Reviewed by Alex Christensen.
2554
2555         Give some time for the zoom level to get restored.
2556
2557         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2558
2559 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
2560
2561         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
2562         https://bugs.webkit.org/show_bug.cgi?id=194958
2563
2564         Reviewed by Geoffrey Garen.
2565
2566         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
2567         (TEST):
2568
2569 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
2570
2571         [ews-app] Update method to save build to handle builder_display_name
2572         https://bugs.webkit.org/show_bug.cgi?id=195047
2573
2574         Reviewed by Dewei Zhu.
2575
2576         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
2577         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
2578
2579 2019-02-28  Justin Fan  <justin_fan@apple.com>
2580
2581         [Web GPU] Enable Web GPU only on 64-bit
2582         https://bugs.webkit.org/show_bug.cgi?id=195139
2583
2584         Because Metal is only supported on 64 bit apps.
2585
2586         Unreviewed build fix.
2587
2588         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2589
2590 2019-02-27  Youenn Fablet  <youenn@apple.com>
2591
2592         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
2593         https://bugs.webkit.org/show_bug.cgi?id=194959
2594
2595         Reviewed by Chris Dumez.
2596
2597         Spin loop until getting the condition to remove flakiness.
2598
2599         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2600
2601 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
2602
2603         [ews-build] Buildbot should include builder_display_name in the build events
2604         https://bugs.webkit.org/show_bug.cgi?id=195045
2605
2606         Reviewed by Dewei Zhu.
2607
2608         * BuildSlaveSupport/ews-build/events.py:
2609         (Events.buildStarted): Included builder_display_name in event data. Also renamed
2610         buildername to builder_name to be consistent in naming style.
2611         (Events.buildFinished): Ditto.
2612
2613 2019-02-27  Chris Dumez  <cdumez@apple.com>
2614
2615         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
2616         https://bugs.webkit.org/show_bug.cgi?id=194480
2617
2618         Reviewed by Brady Eidson.
2619
2620         Update existing API test to make it more likely to reproduce the issue.
2621
2622         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2623
2624 2019-02-27  Brady Eidson  <beidson@apple.com>
2625
2626         Universal links from Google search results pages don't open the app.
2627         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
2628
2629         Reviewed by Geoffrey Garen.
2630
2631         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2632         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2633         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2634         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2635
2636 2019-02-27  Chris Dumez  <cdumez@apple.com>
2637
2638         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
2639         https://bugs.webkit.org/show_bug.cgi?id=195102
2640
2641         Reviewed by Geoffrey Garen.
2642
2643         If the number of processes is not yet what we expect, wait a bit and check again to give
2644         processes some time to exit.
2645
2646         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2647
2648 2019-02-27  Chris Dumez  <cdumez@apple.com>
2649
2650         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
2651         https://bugs.webkit.org/show_bug.cgi?id=194545
2652
2653         Reviewed by Brady Eidson.
2654
2655         Make sure the test navigates forward and then back only once. Previously, navigating
2656         back would trigger a navigation again in a timer.
2657
2658         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2659
2660 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
2661
2662         High Sierra Debug JSC test queue should use faster hardware
2663         https://bugs.webkit.org/show_bug.cgi?id=194603
2664
2665         Rubber-stamped by Alexey Proskuryakov.
2666
2667         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
2668
2669         * BuildSlaveSupport/build.webkit.org-config/config.json:
2670         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2671         (BubbleQueueServer):
2672         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2673         (WebKitBuildbot):
2674         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2675         * QueueStatusServer/config/queues.py:
2676         * Scripts/webkitpy/common/config/ews.json:
2677         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2678         (test_ews_name):
2679
2680 2019-02-27  John Wilander  <wilander@apple.com>
2681
2682         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
2683         https://bugs.webkit.org/show_bug.cgi?id=195071
2684         <rdar://problem/48417690>
2685
2686         Reviewed by Alex Christensen and Brent Fulgham.
2687
2688         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2689         (TestWebKitAPI::createURL):
2690             Convenience function.
2691         (TestWebKitAPI::TEST):
2692             WebCore::AdClickAttribution now takes a URL when creating Source and
2693             Destination.
2694         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
2695         (TestWebKitAPI::TEST):
2696             WebCore::AdClickAttribution now takes a URL when creating Source and
2697             Destination.
2698
2699 2019-02-27  Antoine Quint  <graouts@apple.com>
2700
2701         Support Pointer Events on macOS
2702         https://bugs.webkit.org/show_bug.cgi?id=195008
2703         <rdar://problem/47454419>
2704
2705         Reviewed by Dean Jackson.
2706
2707         * DumpRenderTree/mac/DumpRenderTree.mm:
2708         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
2709         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2710
2711 2019-02-26  Mark Lam  <mark.lam@apple.com>
2712
2713         Remove remaining poisoning code.
2714         https://bugs.webkit.org/show_bug.cgi?id=194138
2715
2716         Reviewed by Saam Barati.
2717
2718         * TestWebKitAPI/CMakeLists.txt:
2719         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2720         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
2721         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
2722         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
2723         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
2724         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
2725         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
2726
2727 2019-02-26  Alex Christensen  <achristensen@webkit.org>
2728
2729         Move ephemeral local storage from WebProcess to UIProcess
2730         https://bugs.webkit.org/show_bug.cgi?id=195074
2731         <rdar://problem/47937975>
2732
2733         Reviewed by Geoff Garen.
2734
2735         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2736
2737 2019-02-20  Jer Noble  <jer.noble@apple.com>
2738
2739         [Cocoa] Media elements will restart network buffering just before suspending
2740         https://bugs.webkit.org/show_bug.cgi?id=193691
2741
2742         Reviewed by Eric Carlson.
2743
2744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2745         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2746         (TEST):
2747
2748 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
2749
2750         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
2751         https://bugs.webkit.org/show_bug.cgi?id=191652
2752
2753         Reviewed by Alex Christensen.
2754
2755         Fix WinCairo MiniBrowser behavior of authentication dialog.
2756
2757         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2758         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2759
2760 2019-02-26  Youenn Fablet  <youenn@apple.com>
2761
2762         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
2763         https://bugs.webkit.org/show_bug.cgi?id=195028
2764         <rdar://problem/48243733>
2765
2766         Reviewed by Eric Carlson.
2767
2768         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2769
2770 2019-02-26  Philippe Normand  <pnormand@igalia.com>
2771
2772         [WPE] Add API for webview background color configuration
2773         https://bugs.webkit.org/show_bug.cgi?id=192305
2774
2775         Reviewed by Michael Catanzaro.
2776
2777         * MiniBrowser/wpe/main.cpp:
2778         (main): Add a new option to configure the webview background
2779         color. Example: --bg-color=transparent.
2780         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2781         (testWebViewBackgroundColor): Enable background color API tests for WPE.
2782         (beforeAll): Ditto.
2783
2784 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
2785
2786         scalableNativeWebpageParameters() is not preserved on new page navigation.
2787         https://bugs.webkit.org/show_bug.cgi?id=194892
2788         <rdar://problem/47538280>
2789
2790         Reviewed by Wenson Hsieh.
2791         
2792         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
2793
2794         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2795         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2796         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2797         (WTR::UIScriptController::allowsViewportShrinkToFit):
2798         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2799         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2800         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2801         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2802         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2803         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2804
2805 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2806
2807         [ews-app] Add model for handling multiple Buildbot instances
2808         https://bugs.webkit.org/show_bug.cgi?id=194863
2809
2810         Reviewed by Stephanie Lewis.
2811
2812         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
2813
2814 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2815
2816         [ews-app] Remove BuilderMapping table
2817         https://bugs.webkit.org/show_bug.cgi?id=194961
2818
2819         Reviewed by Stephanie Lewis.
2820
2821         Store builder name directly in build table, instead of having a separate
2822         table for it.
2823
2824         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
2825         * BuildSlaveSupport/ews-app/ews/models/build.py:
2826         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
2827         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2828
2829 2019-02-25  John Wilander  <wilander@apple.com>
2830
2831         Introduce and adopt new class RegistrableDomain for eTLD+1
2832         https://bugs.webkit.org/show_bug.cgi?id=194791
2833         <rdar://problem/48179240>
2834
2835         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
2836
2837         This patch adds an API test and replaces two instances of
2838         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
2839
2840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2841         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2842         (TestWebKitAPI::TEST):
2843             Changed two strings to make sure the registrable domains are still considered
2844             invalid and pass the test.
2845         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
2846         (TestWebKitAPI::TEST):
2847         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2848         (WTR::InjectedBundle::didReceiveMessageToPage):
2849
2850 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
2851
2852         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
2853         https://bugs.webkit.org/show_bug.cgi?id=195001
2854
2855         Reviewed by Carlos Garcia Campos.
2856
2857         API version 1.0 always includes the functionality previously guarded with
2858         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
2859         unconditionally.
2860
2861         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2862         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
2863         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
2864         (WebViewTest::showInWindow): Ditto.
2865         (WebViewTest::hideView): Ditto.
2866         * wpe/backends/HeadlessViewBackend.cpp:
2867         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
2868         * wpe/backends/ViewBackend.cpp:
2869         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
2870         * wpe/backends/WindowViewBackend.cpp:
2871         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
2872         WPE_BACKEND_CHECK_VERSION().
2873         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
2874
2875 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
2876
2877         [Flatpak] Add support for flatpak > 1.1.2
2878         https://bugs.webkit.org/show_bug.cgi?id=194088
2879
2880         Flatpak 1.2 is now out so we need to support that
2881         version now.
2882
2883         Reviewed by Michael Catanzaro.
2884
2885         * flatpak/flatpakutils.py:
2886         (check_flatpak):
2887         (FlatpakPackages.__init__):
2888         (FlatpakPackages.__detect_packages):
2889         (FlatpakPackages.__detect_packages.in):
2890         (FlatpakRepos.update):
2891
2892 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
2893
2894         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
2895         https://bugs.webkit.org/show_bug.cgi?id=194998
2896
2897         Reviewed by Carlos Garcia Campos.
2898
2899         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
2900         to a Git checkout and using the latest commit containing various fixes
2901         and improvements.
2902
2903 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2904
2905         [WPE][GTK] Remove user agent quirk for washingtonpost.com
2906         https://bugs.webkit.org/show_bug.cgi?id=194981
2907
2908         Reviewed by Žan Doberšek.
2909
2910         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2911         (TestWebKitAPI::TEST):
2912
2913 2019-02-23  Keith Miller  <keith_miller@apple.com>
2914
2915         Add new mac target numbers
2916         https://bugs.webkit.org/show_bug.cgi?id=194955
2917
2918         Reviewed by Tim Horton.
2919
2920         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2921         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2922         * MiniBrowser/Configurations/Base.xcconfig:
2923         * TestWebKitAPI/Configurations/Base.xcconfig:
2924         * WebKitTestRunner/Configurations/Base.xcconfig:
2925
2926 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
2927
2928         [WinCairo] Enable wk1/wk2 suffix for platform search path.
2929         https://bugs.webkit.org/show_bug.cgi?id=194846
2930
2931         Reviewed by Don Olmstead.
2932
2933         Added _search_paths() and _port_specific_expectations_files() for
2934         WinCairoPort.
2935
2936         * Scripts/webkitpy/port/win.py:
2937         (WinCairoPort.default_baseline_search_path):
2938         (WinCairoPort):
2939         (WinCairoPort._port_specific_expectations_files):
2940         (WinCairoPort._search_paths):
2941
2942 2019-02-22  Tim Horton  <timothy_horton@apple.com>
2943
2944         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
2945         https://bugs.webkit.org/show_bug.cgi?id=194963
2946
2947         Reviewed by Dean Jackson.
2948
2949         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2950         Do a `contains` check instead of `equals`, because in debug builds we
2951         put the GraphicsLayer pointer in a prefix.
2952
2953 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2954
2955         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
2956         https://bugs.webkit.org/show_bug.cgi?id=194873
2957         <rdar://problem/46701974>
2958
2959         Reviewed by Tim Horton.
2960
2961         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
2962
2963         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2964         (WTR::UIScriptController::menuRect const):
2965         (WTR::UIScriptController::isShowingMenu const):
2966         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2967         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2968         (WTR::UIScriptController::menuRect const):
2969
2970         Add a function to query the bounds of the callout menu in content coordinates.
2971
2972         (WTR::UIScriptController::isShowingMenu const):
2973
2974         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
2975
2976         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2977         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2978         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2979         (WTR::UIScriptController::rectForMenuAction const):
2980         (WTR::UIScriptController::menuRect const):
2981         (WTR::UIScriptController::isShowingMenu const):
2982         (WTR::findViewInHierarchyOfType): Deleted.
2983
2984 2019-02-22  Chris Dumez  <cdumez@apple.com>
2985
2986         Regression(PSON) Unable to preview password-protected documents on iCloud.com
2987         https://bugs.webkit.org/show_bug.cgi?id=194954
2988         <rdar://problem/48127957>
2989
2990         Reviewed by Alex Christensen.
2991
2992         Add API test coverage.
2993
2994         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2995         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2996         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2997         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2998
2999 2019-02-22  Chris Dumez  <cdumez@apple.com>
3000
3001         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3002         https://bugs.webkit.org/show_bug.cgi?id=194924
3003         <rdar://problem/48216125>
3004
3005         Reviewed by Geoffrey Garen.
3006
3007         Add API test coverage.
3008
3009         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3010
3011 2019-02-22  Chris Dumez  <cdumez@apple.com>
3012
3013         Unreviewed, disable API test added in r241928 on iOS.
3014
3015         The cache is not enabled on devices with less than 3GB of RAM.
3016
3017         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3018
3019 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3020
3021         Hardcode Visual Viewports on everywhere except iOS WK1
3022         https://bugs.webkit.org/show_bug.cgi?id=194928
3023
3024         Reviewed by Zalan Bujtas.
3025
3026         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3027         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3028         set it to false. The setting has shipped for several years and there's no need to turn
3029         it off now.
3030
3031         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3032         Visual Viewports are not enabled.
3033         
3034         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3035         that only runs in WK2
3036
3037         * MiniBrowser/mac/SettingsController.h:
3038         * MiniBrowser/mac/SettingsController.m:
3039         (-[SettingsController init]):
3040         (-[SettingsController _populateMenu]):
3041         (-[SettingsController validateMenuItem:]):
3042         (-[SettingsController visualViewportEnabled]): Deleted.
3043         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3044         * MiniBrowser/mac/WK1BrowserWindowController.m:
3045         (-[WK1BrowserWindowController didChangeSettings]):
3046         * MiniBrowser/mac/WK2BrowserWindowController.m:
3047         (-[WK2BrowserWindowController didChangeSettings]):
3048
3049 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3050
3051         Discard cached processes when clearing website data store
3052         https://bugs.webkit.org/show_bug.cgi?id=194894
3053
3054         Reviewed by Chris Dumez.
3055
3056         Added a test case.
3057
3058         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3059         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3060
3061 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3062
3063         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3064         https://bugs.webkit.org/show_bug.cgi?id=194914
3065         <rdar://problem/47586889>
3066
3067         Reviewed by Geoffrey Garen.
3068
3069         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3070         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3071         (TEST):
3072         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3073
3074 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3075
3076         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3077         <https://webkit.org/b/194761>
3078
3079         Reviewed by Myles Maxfield.
3080
3081         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3082         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3083         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3084         to use ARC-compliant cast.
3085         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3086         ARC-compliant cast.
3087         (WTR::installFakeHelvetica): Log `error` to console if
3088         CTFontManagerRegisterFontsForURL() fails, but only on supported
3089         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3090         Call CFRelease() on `error` to fix the leak.  Update to use
3091         ARC-compliant cast.
3092         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3093         cast.
3094
3095 2019-02-21  Chris Dumez  <cdumez@apple.com>
3096
3097         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3098         https://bugs.webkit.org/show_bug.cgi?id=194481
3099
3100         Reviewed by Alex Christensen.
3101
3102         Give the processes a chance to shutdown and wait until we reached the expected number
3103         of processes.
3104
3105         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3106
3107 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3108
3109         Fix the macOS build
3110
3111         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3112
3113 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3114
3115         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3116
3117         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3118         I am a backwards.
3119
3120 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3121
3122         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3123
3124         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3125         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3126         We could force on UI-side compositing, but I feel like the test might be more
3127         valuable exercising the normal path on each platform (though the original
3128         bug was also UI-side specific). Though we can't validate that the overlay
3129         layer was installed successfully, there are layout tests that do that.
3130
3131 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3132
3133         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3134         https://bugs.webkit.org/show_bug.cgi?id=194845
3135         <rdar://problem/47944579>
3136
3137         Reviewed by Antti Koivisto.
3138
3139         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3140         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3141
3142 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3143
3144         [LFC][Floats] Add support for placing formatting roots in-between floats.
3145         https://bugs.webkit.org/show_bug.cgi?id=194902
3146
3147         Reviewed by Antti Koivisto.
3148
3149         * LayoutReloaded/misc/LFC-passing-tests.txt:
3150
3151 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3152
3153         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3154         https://bugs.webkit.org/show_bug.cgi?id=194901
3155
3156         Unreviewed build fix.
3157
3158         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3159         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3160         WPEBackend-fdo-0.1 as library name.
3161
3162 2019-02-21  Rob Buis  <rbuis@igalia.com>
3163
3164         Update MIME type parser
3165         https://bugs.webkit.org/show_bug.cgi?id=180526
3166
3167         Reviewed by Darin Adler.
3168
3169         Add tests involving leading and trailing whitespace, non-token
3170         characters and quoted strings.
3171
3172         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3173         (TestWebKitAPI::TEST):
3174
3175 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3176
3177         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3178         https://bugs.webkit.org/show_bug.cgi?id=194884
3179
3180         Reviewed by Michael Catanzaro.
3181
3182         * PlatformWin.cmake:
3183
3184 2019-02-20  Chris Dumez  <cdumez@apple.com>
3185
3186         Add API test for <rdar://problem/47471222>
3187         https://bugs.webkit.org/show_bug.cgi?id=194847
3188
3189         Reviewed by Alex Christensen.
3190
3191         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3192
3193 2019-02-20  Chris Dumez  <cdumez@apple.com>
3194
3195         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3196         https://bugs.webkit.org/show_bug.cgi?id=194872
3197         <rdar://problem/47924500>
3198
3199         Reviewed by Alex Christensen.
3200
3201         Add API test coverage.
3202
3203         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3204
3205 2019-02-20  Jer Noble  <jer.noble@apple.com>
3206
3207         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3208         https://bugs.webkit.org/show_bug.cgi?id=191332
3209
3210         Reviewed by Dean Jackson.
3211
3212         * Scripts/git-is-in-range: Added.
3213
3214 2019-02-20  Andy Estes  <aestes@apple.com>
3215
3216         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3217         https://bugs.webkit.org/show_bug.cgi?id=194869
3218
3219         Rubber-stamped by Jer Noble.
3220
3221         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3222         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3223         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3224         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3226         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3227
3228 2019-02-20  Chris Dumez  <cdumez@apple.com>
3229
3230         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3231         https://bugs.webkit.org/show_bug.cgi?id=194857
3232         <rdar://problem/47759323>
3233
3234         Reviewed by Alex Christensen.
3235
3236         Add API test coverage.
3237
3238         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3239
3240 2019-02-20  Chris Dumez  <cdumez@apple.com>
3241
3242         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3243         https://bugs.webkit.org/show_bug.cgi?id=194829
3244         <rdar://problem/47889906>
3245
3246         Reviewed by Alexey Proskuryakov.
3247
3248         Every time the TestOptions were changing we were creating both a new Web view and
3249         a new WKContext, which would start a new Network process. In most cases, we only
3250         need to contruct a new Web view and we do can keep reusing the same WKContext.
3251         This patch implements this optimization and thus avoids spinning a lot of new
3252         Network processes while running the layout tests.
3253
3254         * WebKitTestRunner/TestController.cpp:
3255         (WTR::TestController::generateContextConfiguration const):
3256         (WTR::TestController::generatePageConfiguration):
3257         (WTR::TestController::createWebViewWithOptions):
3258         (WTR::TestController::resetPreferencesToConsistentValues):
3259         (WTR::updateTestOptionsFromTestHeader):
3260         * WebKitTestRunner/TestController.h:
3261         * WebKitTestRunner/TestOptions.h:
3262         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3263         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3264         (WTR::TestOptions::hasSameInitializationOptions const):
3265         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3266         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3267         (WTR::TestController::platformAddTestOptions const):
3268
3269 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3270
3271         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3272         https://bugs.webkit.org/show_bug.cgi?id=167941
3273
3274         Reviewed by Carlos Garcia Campos.
3275
3276         * MiniBrowser/gtk/main.c:
3277         (filterSavedCallback): Added.
3278         (main): Support loading a JSON rule set file for content filtering.
3279         * MiniBrowser/wpe/main.cpp:
3280         (filterSavedCallback): Added.
3281         (main): Support loading a JSON rule set file for content filtering.
3282         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3283         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3284         (WTF::derefGPtr): Ditto.
3285         (testEmptyStore):
3286         (testSaveInvalidFilter):
3287         (testSaveLoadFilter):
3288         (testSavedFilterIdentifierMatch):
3289         (testRemoveFilter):
3290         (testSaveMultipleFilters):
3291         (testSaveFilterFromFile):
3292         (testFilterPersistence):
3293         (beforeAll):
3294         (afterAll):
3295         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3296         (removeOldInjectedContentAndResetLists): Also reset content filters.
3297         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3298         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3299         the element affected by the style sheet.
3300         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3301         and returns it to be used by tests.
3302         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3303         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3304         (serverCallback): Add support for serving a CSS style sheet for testing.
3305         (beforeAll): Add call to testUserContentManagerContentFilter().
3306         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3307
3308 2019-02-19  Keith Rollin  <krollin@apple.com>
3309
3310         Add timing information to build output
3311         https://bugs.webkit.org/show_bug.cgi?id=194839
3312         <rdar://problem/48219609>
3313
3314         Reviewed by Alexey Proskuryakov.
3315
3316         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3317         emit each project's build time to its output. E.g.,
3318
3319             ** BUILD SUCCEEDED ** [0.132 sec]
3320
3321         * Scripts/webkitdirs.pm:
3322         (XcodeOptions):
3323
3324 2019-02-19  Truitt Savell  <tsavell@apple.com>
3325
3326         Unreviewed, rolling out r241784.
3327
3328         Broke all OpenSource builds.
3329
3330         Reverted changeset:
3331
3332         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3333         instances view"
3334         https://bugs.webkit.org/show_bug.cgi?id=172848
3335         https://trac.webkit.org/changeset/241784
3336
3337 2019-02-19  Zalan Bujtas  <zalan@apple.com>
3338
3339         [LFC][Floats] Remove redundant intersecting logic
3340         https://bugs.webkit.org/show_bug.cgi?id=194804
3341
3342         Reviewed by Antti Koivisto.
3343
3344         * LayoutReloaded/misc/LFC-passing-tests.txt:
3345
3346 2019-02-19  Dean Jackson  <dino@apple.com>
3347
3348         Clean-up output from generate-xcfilelists so it can be filtered
3349         https://bugs.webkit.org/show_bug.cgi?id=194795
3350
3351         Reviewed by Joseph Pecoraro (and Keith Rollin).
3352
3353         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
3354         make a slight tweak to filter-build-webkit so such lines are marked
3355         as plain.
3356
3357         * Scripts/filter-build-webkit:
3358         * Scripts/generate-xcfilelists:
3359
3360 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3361
3362         pytest is not correctly auto-installed
3363         https://bugs.webkit.org/show_bug.cgi?id=194707
3364
3365         Reviewed by Carlos Garcia Campos.
3366
3367         * Scripts/webkitpy/thirdparty/__init__.py:
3368         (AutoinstallImportHook._install_pytest):
3369
3370 2019-02-18  Chris Dumez  <cdumez@apple.com>
3371
3372         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
3373         https://bugs.webkit.org/show_bug.cgi?id=194797
3374         <rdar://problem/48055151>
3375
3376         Reviewed by Geoffrey Garen.
3377
3378         Add API test coverage.
3379
3380         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3381
3382 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3383
3384         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
3385         https://bugs.webkit.org/show_bug.cgi?id=194670
3386         <rdar://problem/39066529>
3387
3388         Reviewed by Tim Horton.
3389
3390         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
3391         pasted in an editable area as attachment elements.
3392
3393         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3394         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3395         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
3396         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3397         (TestWebKitAPI::TEST):
3398         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3399         (WTR::InjectedBundlePage::InjectedBundlePage):
3400
3401 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3402
3403         Fix API test after r241728
3404        ​https://bugs.webkit.org/show_bug.cgi?id=194723
3405
3406         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3407         (TEST):
3408         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
3409
3410 2019-02-18  Daniel Bates  <dabates@apple.com>
3411
3412         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3413         https://bugs.webkit.org/show_bug.cgi?id=192824
3414         <rdar://problem/47100332>
3415
3416         Reviewed by Wenson Hsieh.
3417
3418         Fix a bug where the wrong usage code was used for F13 thru F24.
3419
3420         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3421         (keyCodeForDOMFunctionKey):
3422
3423 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
3424
3425         Bytecode cache should a have a boot-specific validation
3426         https://bugs.webkit.org/show_bug.cgi?id=194769
3427         <rdar://problem/48149509>
3428
3429         Reviewed by Keith Miller.
3430
3431         Add test for WTF::bootSessionUUIDString()
3432
3433         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3434         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
3435         (TEST):
3436
3437 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3438
3439         Disable safe browsing in WKWebView and remove its WKPreferences API
3440         https://bugs.webkit.org/show_bug.cgi?id=194723
3441         <rdar://problem/48122993>
3442
3443         Reviewed by Geoffrey Garen.
3444
3445         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3446         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3447         (TEST):
3448         (safeBrowsingView):
3449         Make tests use SPI instead of API.
3450
3451 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3452
3453         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
3454         https://bugs.webkit.org/show_bug.cgi?id=194586
3455
3456         Reviewed by Ross Kirsling.
3457
3458         * DumpRenderTree/win/DumpRenderTree.cpp:
3459         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
3460         * Scripts/webkitpy/port/driver.py:
3461         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
3462
3463 2019-02-17  David Kilzer  <ddkilzer@apple.com>
3464
3465         Unreviewed, rolling out r241620.
3466
3467         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
3468         (Requested by ddkilzer on #webkit.)
3469
3470         Reverted changeset:
3471
3472         "[WTF] Add environment variable helpers"
3473         https://bugs.webkit.org/show_bug.cgi?id=192405
3474         https://trac.webkit.org/changeset/241620
3475
3476 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3477
3478         [LFC] RenderImage's default intrinsic size is 0.
3479         https://bugs.webkit.org/show_bug.cgi?id=194745
3480
3481         Reviewed by Antti Koivisto.
3482
3483         * LayoutReloaded/misc/LFC-passing-tests.txt:
3484
3485 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3486
3487         [LFC][BFC] Add support for block replaced intrinsic width.
3488         https://bugs.webkit.org/show_bug.cgi?id=194705
3489
3490         Reviewed by Simon Fraser.
3491
3492         * LayoutReloaded/misc/LFC-passing-tests.txt:
3493
3494 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3495
3496         [LFC] Apply min/max width constraints to preferred width computation
3497         https://bugs.webkit.org/show_bug.cgi?id=194739
3498
3499         Reviewed by Simon Fraser.
3500
3501         * LayoutReloaded/misc/LFC-passing-tests.txt:
3502
3503 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
3504
3505         [WTF] Add environment variable helpers
3506         https://bugs.webkit.org/show_bug.cgi?id=192405
3507
3508         Reviewed by Michael Catanzaro.
3509
3510         * DumpRenderTree/mac/DumpRenderTree.mm:
3511         (libraryPathForDumpRenderTree):
3512         * DumpRenderTree/win/DumpRenderTree.cpp:
3513         (libraryPathForDumpRenderTree):
3514         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3515         (setUpIOSLayoutTestCommunication):
3516         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3517         (beforeAll):
3518         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3519         (main):
3520         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3521         (WebKitTestBus::run):
3522         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3523         (WTR::getOutputDir):
3524         (WTR::initializeFontConfigSetting):
3525         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3526         (WTR::InjectedBundle::platformInitialize):
3527         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3528         (WTR::topLevelPath):
3529         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3530         (WTR::topLevelPath):
3531         (WTR::getOutputDir):
3532         (WTR::activateFonts):
3533         * WebKitTestRunner/TestController.cpp:
3534         (WTR::TestController::libraryPathForTesting):
3535         (WTR::TestController::generateContextConfiguration const):
3536         (WTR::TestController::generatePageConfiguration):
3537         (WTR::TestController::decideDestinationWithSuggestedFilename):
3538         (WTR::TestController::platformAdjustContext):
3539         * WebKitTestRunner/TestController.h:
3540         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3541         (WTR::TestController::cocoaPlatformInitialize):
3542         (WTR::TestController::platformAdjustContext):
3543         * WebKitTestRunner/gtk/main.cpp:
3544         (main):
3545         * WebKitTestRunner/mac/TestControllerMac.mm:
3546         (WTR::TestController::configureContentExtensionForTest):
3547         * WebKitTestRunner/wpe/main.cpp:
3548         (main):
3549         Utilize WTF::Environment where possible.
3550
3551 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3552
3553         [iOS] WKWebView callout bar is missing Change Writing Direction item
3554         https://bugs.webkit.org/show_bug.cgi?id=190015
3555         <rdar://problem/44810366>
3556
3557         Reviewed by Tim Horton.
3558
3559         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
3560         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
3561
3562         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
3563         (TestWebKitAPI::TEST):
3564
3565 2019-02-15  Chris Dumez  <cdumez@apple.com>
3566
3567         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
3568         https://bugs.webkit.org/show_bug.cgi?id=194717
3569         <rdar://problem/47884404>
3570
3571         Reviewed by Brady Eidson.
3572
3573         Add API test coverage.
3574
3575         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3576
3577 2019-02-15  Youenn Fablet  <youenn@apple.com>
3578
3579         Make navigator.mediaDevices SecureContext
3580         https://bugs.webkit.org/show_bug.cgi?id=194666
3581
3582         Reviewed by Eric Carlson.
3583
3584         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3585         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
3586         (TEST_F):
3587
3588 2019-02-15  Brian Burg  <bburg@apple.com>
3589
3590         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3591         https://bugs.webkit.org/show_bug.cgi?id=194411
3592         <rdar://problem/47787614>
3593
3594         Reviewed by Joseph Pecoraro.
3595
3596         Remove unnecessary soft linking macro usage.
3597
3598         * DumpRenderTree/mac/TestRunnerMac.mm:
3599         (TestRunner::inspectorTestStubURL):
3600         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3601         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3602         (WTR::TestRunner::inspectorTestStubURL):
3603
3604 2019-02-15  Commit Queue  <commit-queue@webkit.org>
3605
3606         Unreviewed, rolling out r241559 and r241566.
3607         https://bugs.webkit.org/show_bug.cgi?id=194710
3608
3609         Causes layout test crashes under GuardMalloc (Requested by
3610         ryanhaddad on #webkit).
3611
3612         Reverted changesets:
3613
3614         "[WTF] Add environment variable helpers"
3615         https://bugs.webkit.org/show_bug.cgi?id=192405
3616         https://trac.webkit.org/changeset/241559
3617
3618         "Unreviewed build fix for WinCairo Debug after r241559."
3619         https://trac.webkit.org/changeset/241566
3620
3621 2019-02-15  Zalan Bujtas  <zalan@apple.com>
3622
3623         [LFC] Out-of-flow box is never a float box
3624         https://bugs.webkit.org/show_bug.cgi?id=194704
3625
3626         Reviewed by Antti Koivisto.
3627
3628         * LayoutReloaded/misc/LFC-passing-tests.txt:
3629
3630 2019-02-10  Darin Adler  <darin@apple.com>
3631
3632         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
3633         https://bugs.webkit.org/show_bug.cgi?id=194487
3634
3635         Reviewed by Daniel Bates.
3636
3637         * DumpRenderTree/win/DumpRenderTree.cpp:
3638         (applicationId): Use makeString instead of String::format.
3639         (main): Ditto.
3640         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3641         (TestWebKitAPI::Util::createURLForResource): Ditto.
3642         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3643         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
3644
3645         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3646         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
3647         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
3648         (WTR::createStringWithAttributes): Use appendLiteral.
3649         (WTR::AccessibilityUIElement::helpText const): Ditto.
3650         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
3651         directly instead of using String::format.
3652         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
3653         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
3654
3655 2019-02-15  Truitt Savell  <tsavell@apple.com>
3656
3657         Unreviewed, rolling out r241564.
3658
3659         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
3660
3661         Reverted changeset:
3662
3663         "[Mac] WebInspectorUI.framework does not need to be soft-
3664         linked anymore"
3665         https://bugs.webkit.org/show_bug.cgi?id=194411
3666         https://trac.webkit.org/changeset/241564
3667
3668 2019-02-15  Saam barati  <sbarati@apple.com>
3669
3670         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
3671         https://bugs.webkit.org/show_bug.cgi?id=194036
3672
3673         Reviewed by Yusuke Suzuki.
3674
3675         * Scripts/run-jsc-stress-tests:
3676
3677 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3678
3679         Fix the build.
3680
3681         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3682         (WTR::UIScriptController::drawSquareInEditableImage):
3683         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3684         (TestWebKitAPI::drawSquareInEditableImage):
3685
3686 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3687
3688         Fix the build.
3689
3690         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3691         (WTR::UIScriptController::drawSquareInEditableImage):
3692         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3693         (TestWebKitAPI::drawSquareInEditableImage):
3694
3695 2019-02-14  Brian Burg  <bburg@apple.com>
3696
3697         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3698         https://bugs.webkit.org/show_bug.cgi?id=194411
3699         <rdar://problem/47787614>
3700
3701         Reviewed by Joseph Pecoraro.
3702
3703         Remove unnecessary soft linking macro usage.
3704
3705         * DumpRenderTree/mac/TestRunnerMac.mm:
3706         (TestRunner::inspectorTestStubURL):
3707         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3708         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3709         (WTR::TestRunner::inspectorTestStubURL):
3710
3711 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3712
3713         [ews-app] status bubble should fetch builder name info from BuilderMapping table
3714         https://bugs.webkit.org/show_bug.cgi?id=194599
3715
3716         Reviewed by Lucas Forschler.
3717
3718         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3719         (StatusBubble._build_bubble):
3720
3721 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3722
3723         [ews-app] Set Foreign Key in Django build model
3724         https://bugs.webkit.org/show_bug.cgi?id=194667
3725
3726         Reviewed by Lucas Forschler.
3727
3728         * BuildSlaveSupport/ews-app/ews/models/build.py:
3729         (Build):
3730
3731 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
3732
3733         [WTF] Add environment variable helpers
3734         https://bugs.webkit.org/show_bug.cgi?id=192405
3735
3736         Reviewed by Michael Catanzaro.
3737
3738         * DumpRenderTree/mac/DumpRenderTree.mm:
3739         (libraryPathForDumpRenderTree):
3740         * DumpRenderTree/win/DumpRenderTree.cpp:
3741         (libraryPathForDumpRenderTree):
3742         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3743         (setUpIOSLayoutTestCommunication):
3744         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3745         (TestWebKitAPI::strip):
3746         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3747         (beforeAll):
3748         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3749         (main):
3750         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3751         (WebKitTestBus::run):
3752         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3753         (WTR::getOutputDir):
3754         (WTR::initializeFontConfigSetting):
3755         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3756         (WTR::InjectedBundle::platformInitialize):
3757         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3758         (WTR::topLevelPath):
3759         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3760         (WTR::topLevelPath):
3761         (WTR::getOutputDir):
3762         (WTR::activateFonts):
3763         * WebKitTestRunner/TestController.cpp:
3764         (WTR::TestController::libraryPathForTesting):
3765         (WTR::TestController::generateContextConfiguration const):
3766         (WTR::TestController::generatePageConfiguration):
3767         (WTR::TestController::decideDestinationWithSuggestedFilename):
3768         (WTR::TestController::platformAdjustContext):
3769         * WebKitTestRunner/TestController.h:
3770         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3771         (WTR::TestController::cocoaPlatformInitialize):
3772         (WTR::TestController::platformAdjustContext):
3773         * WebKitTestRunner/gtk/main.cpp:
3774         (main):
3775         * WebKitTestRunner/mac/TestControllerMac.mm:
3776         (WTR::TestController::configureContentExtensionForTest):
3777         * WebKitTestRunner/wpe/main.cpp:
3778         (main):
3779         Utilize WTF::Environment where possible.
3780
3781 2019-02-14  Chris Dumez  <cdumez@apple.com>
3782
3783         [PSON] Introduce a WebContent Process cache
3784         https://bugs.webkit.org/show_bug.cgi?id=194594
3785         <rdar://problem/46793397>
3786
3787         Reviewed by Geoff Garen.
3788
3789         Update API tests to turn on the WebContent Process cache.
3790
3791         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3792
3793 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
3794
3795         Unreviewed, build fix after r241480
3796
3797         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3798         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3799         (-[DragAndDropSimulator initWithWebView:]):
3800
3801 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
3802
3803         AX: ARIA Reflection was disabled in error
3804         https://bugs.webkit.org/show_bug.cgi?id=194647
3805         <rdar://problem/48068336>
3806
3807         Reviewed by Ryosuke Niwa.
3808
3809         Remove test override now that this feature should be enabled by default.
3810
3811         * WebKitTestRunner/TestController.cpp:
3812         (WTR::TestController::resetPreferencesToConsistentValues):
3813
3814 2019-02-14  Commit Queue  <commit-queue@webkit.org>
3815
3816         Unreviewed, rolling out r241486.
3817         https://bugs.webkit.org/show_bug.cgi?id=194655
3818
3819         causing API failures in builds (Requested by ShawnRoberts on
3820         #webkit).
3821
3822         Reverted changeset:
3823
3824         "[Cocoa] Media elements will restart network buffering just
3825         before suspending"
3826         https://bugs.webkit.org/show_bug.cgi?id=193691
3827         https://trac.webkit.org/changeset/241486
3828
3829 2019-02-14  Zalan Bujtas  <zalan@apple.com>
3830
3831         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
3832         https://bugs.webkit.org/show_bug.cgi?id=194622
3833
3834         Reviewed by Antti Koivisto.
3835
3836         * LayoutReloaded/misc/LFC-passing-tests.txt:
3837
3838 2019-02-14  Zalan Bujtas  <zalan@apple.com>
3839
3840         [LFC] Shrink-to-fit-width should be constrained by min/max width
3841         https://bugs.webkit.org/show_bug.cgi?id=194653
3842
3843         Reviewed by Antti Koivisto.
3844
3845         * LayoutReloaded/misc/LFC-passing-tests.txt:
3846
3847 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
3848
3849         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
3850         https://bugs.webkit.org/show_bug.cgi?id=194641
3851
3852         Reviewed by Geoffrey Garen.
3853
3854         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
3855         so that the test would fail without this fix.
3856
3857         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
3858         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
3859
3860 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3861
3862         [ews-app] Change log level for a log statement
3863
3864         Unreviewed minor fix.
3865
3866         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3867         (Patch.save_patch):
3868
3869 2019-02-13  Jer Noble  <jer.noble@apple.com>
3870
3871         [Cocoa] Media elements will restart network buffering just before suspending
3872         https://bugs.webkit.org/show_bug.cgi?id=193691
3873
3874         Reviewed by Eric Carlson.
3875
3876         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3877         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3878         (TEST):
3879
3880 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3881
3882         [ews-app] Fetch builder id to name mapping
3883         https://bugs.webkit.org/show_bug.cgi?id=194355
3884
3885         Reviewed by Lucas Forschler.
3886
3887         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3888         (Buildbot.get_builder_id_to_name_mapping):
3889         (Buildbot._get_display_name_from_builder_name):
3890
3891 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
3892
3893         Further restricting webarchive loads
3894         https://bugs.webkit.org/show_bug.cgi?id=194567
3895         <rdar://problem/47610130>
3896
3897         Reviewed by Youenn Fablet.
3898
3899         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
3900         navigations on drop.
3901
3902         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3903         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
3904         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
3905         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3906         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3907         (TestWebKitAPI::TEST):
3908         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
3909         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
3910         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
3911         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3912         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3913         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3914         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
3915
3916 2019-02-13  John Wilander  <wilander@apple.com>
3917
3918         Store Ad Click Attribution requests in the network process
3919         https://bugs.webkit.org/show_bug.cgi?id=194510
3920         <rdar://problem/47650118>
3921
3922         Reviewed by Alex Christensen and Daniel Bates.
3923
3924         This patch adds two TestRunner functions:
3925         - dumpAdClickAttribution()
3926         - clearAdClickAttribution()
3927
3928         They call into the network process to dump and clear Ad Click
3929         Attribution state, respectively.
3930
3931         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3932         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3933         (WTR::TestRunner::dumpAdClickAttribution):
3934         (WTR::TestRunner::clearAdClickAttribution):
3935         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3936         * WebKitTestRunner/TestController.cpp:
3937         (WTR::TestController::resetStateToConsistentValues):
3938         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
3939         (WTR::adClickAttributionStringResultCallback):
3940         (WTR::TestController::dumpAdClickAttribution):
3941         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
3942         (WTR::adClickAttributionVoidCallback):
3943         (WTR::TestController::clearAdClickAttribution):
3944         * WebKitTestRunner/TestController.h:
3945         * WebKitTestRunner/TestInvocation.cpp:
3946         (WTR::TestInvocation::dumpResults):
3947         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3948         (WTR::TestInvocation::dumpAdClickAttribution):
3949         * WebKitTestRunner/TestInvocation.h:
3950
3951 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3952
3953         [ews-app] Generate status-bubble
3954         https://bugs.webkit.org/show_bug.cgi?id=194572
3955
3956         Reviewed by Lucas Forschler.
3957
3958         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3959         (StatusBubble._build_bubble):
3960         (StatusBubble._should_show_bubble_for):
3961         (StatusBubble._build_bubbles_for_patch):
3962
3963 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3964
3965         [ews-app] Add status bubble html template
3966         https://bugs.webkit.org/show_bug.cgi?id=194571
3967
3968         Reviewed by Lucas Forschler.
3969
3970         * BuildSlaveSupport/ews-app/ews/templates: Added.
3971         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
3972
3973 2019-02-12  Chris Dumez  <cdumez@apple.com>
3974
3975         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
3976         https://bugs.webkit.org/show_bug.cgi?id=194568
3977         <rdar://problem/47944490>
3978
3979         Reviewed by Ryosuke Niwa.
3980
3981         Add API test coverage.
3982
3983         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3984         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3985
3986 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
3987
3988         webkitpy: Remove bug_dummy from parsed test expectations
3989         https://bugs.webkit.org/show_bug.cgi?id=194562
3990         <rdar://problem/47853999>
3991
3992         Reviewed by Lucas Forschler.
3993
3994         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3995         (TestExpectationParser):
3996         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
3997         skipped tests.
3998         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3999
4000 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
4001
4002         [ews-app] Add method to fetch patch
4003         https://bugs.webkit.org/show_bug.cgi?id=194518
4004
4005         Reviewed by Lucas Forschler.
4006
4007         * BuildSlaveSupport/ews-app/ews/models/patch.py:
4008         (Patch.get_patch):
4009
4010 2019-02-12  Zalan Bujtas  <zalan@apple.com>
4011
4012         [LFC] Expand tests coverage (60 new tests -> 860)
4013
4014         Unreviewed test gardening (run-singly, --child-processes=1).
4015
4016         * LayoutReloaded/misc/LFC-passing-tests.txt:
4017
4018 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
4019
4020         Allow pages to trigger programmatic paste from script on iOS
4021         https://bugs.webkit.org/show_bug.cgi?id=194271
4022         <rdar://problem/47808810>
4023
4024         Reviewed by Tim Horton.
4025
4026         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
4027
4028         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4029         (WTR::UIScriptController::platformSetDidShowMenuCallback):
4030         (WTR::UIScriptController::platformSetDidHideMenuCallback):
4031         (WTR::UIScriptController::rectForMenuAction const):
4032
4033         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
4034         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
4035         for when the menu is shown or hidden.
4036
4037         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4038         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
4039         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4040         (WTR::UIScriptController::setDidShowMenuCallback):
4041         (WTR::UIScriptController::didShowMenuCallback const):
4042         (WTR::UIScriptController::setDidHideMenuCallback):
4043         (WTR::UIScriptController::didHideMenuCallback const):
4044         (WTR::UIScriptController::platformSetDidShowMenuCallback):
4045         (WTR::UIScriptController::platformSetDidHideMenuCallback):
4046         (WTR::UIScriptController::rectForMenuAction const):
4047         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4048         * WebKitTestRunner/TestController.cpp:
4049         (WTR::TestController::resetPreferencesToConsistentValues):
4050         (WTR::updateTestOptionsFromTestHeader):
4051         * WebKitTestRunner/TestOptions.h:
4052
4053         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
4054         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
4055
4056         (WTR::TestOptions::hasSameInitializationOptions const):
4057         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4058         (WTR::UIScriptController::calendarType const):
4059         (WTR::UIScriptController::platformUndoManager const):
4060         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4061         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4062         (-[TestRunnerWKWebView initWithFrame:configuration:]):
4063         (-[TestRunnerWKWebView dealloc]):
4064         (-[TestRunnerWKWebView _didShowMenu]):
4065         (-[TestRunnerWKWebView _didHideMenu]):
4066
4067         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
4068
4069         * WebKitTestRunner/ios/TestControllerIOS.mm:
4070         (WTR::handleMenuWillHideNotification):
4071         (WTR::handleMenuDidHideNotification):
4072         (WTR::TestController::platformInitialize):
4073         (WTR::TestController::platformDestroy):
4074         (WTR::TestController::platformResetStateToConsistentValues):
4075
4076         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
4077         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
4078
4079         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4080         (WTR::forEachViewInHierarchy):
4081         (WTR::findViewInHierarchyOfType):
4082
4083         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
4084         functions that dig through a given view's hierarchy in search of a view of a given class.
4085
4086         (WTR::UIScriptController::selectionStartGrabberViewRect const):
4087         (WTR::UIScriptController::selectionEndGrabberViewRect const):
4088         (WTR::UIScriptController::selectionCaretViewRect const):
4089         (WTR::UIScriptController::selectionRangeViewRects const):
4090         (WTR::UIScriptController::platformSetDidShowMenuCallback):
4091         (WTR::UIScriptController::platformSetDidHideMenuCallback):
4092
4093         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
4094
4095         (WTR::UIScriptController::rectForMenuAction const):
4096
4097         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
4098         callout bar) whose label matches the given string.
4099
4100         (WTR::UIScriptController::platformContentView const):
4101
4102         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
4103         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
4104         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
4105
4106         (WTR::UIScriptController::platformUndoManager const): Deleted.
4107         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4108         (WTR::UIScriptController::platformContentView const):
4109         (WTR::UIScriptController::platformUndoManager const): Deleted.
4110
4111 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
4112
4113         webkitpy: No option to only show unexpected failures in results.html for iPad
4114         https://bugs.webkit.org/show_bug.cgi?id=194554
4115         <rdar://problem/47922442>
4116
4117         Rubber-stamped by Aakash Jain.
4118
4119         Just because a TestExpecations file does not exist for a specific platform does not mean that
4120         TestExpecations are not being used, given that platforms inherit test expectations.
4121
4122         * Scripts/webkitpy/port/base.py:
4123         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
4124         * Scripts/webkitpy/port/base_unittest.py:
4125         (PortTest.test_uses_test_expectations_file):
4126
4127 2019-02-12  Alex Christensen  <achristensen@webkit.org>
4128
4129         Remove setDefersLoading infrastructure from WebKit2
4130         https://bugs.webkit.org/show_bug.cgi?id=194506
4131
4132         Reviewed by Brady Eidson.
4133
4134         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4135         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4136         (WTR::TestRunner::setDefersLoading): Deleted.
4137         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4138
4139 2019-02-12  Alex Christensen  <achristensen@webkit.org>
4140
4141         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
4142         https://bugs.webkit.org/show_bug.cgi?id=194522
4143         <rdar://problem/47789393>
4144
4145         Reviewed by Chris Dumez.
4146
4147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4148         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
4149         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4150         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4151
4152 2019-02-12  Andy Estes  <aestes@apple.com>
4153
4154         [iOSMac] Enable Parental Controls Content Filtering
4155         https://bugs.webkit.org/show_bug.cgi?id=194521
4156         <rdar://39732376>
4157
4158         Reviewed by Tim Horton.
4159
4160         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4161
4162 2019-02-12  Zalan Bujtas  <zalan@apple.com>
4163
4164         [LFC][IFC] Add intrinsic width support for float boxes.
4165         https://bugs.webkit.org/show_bug.cgi?id=194528
4166
4167         Reviewed by Antti Koivisto.
4168
4169         Expand tests coverage (2 new tests -> 800).
4170         (This is the correct test ordering --runs-singly --child-processes=1)
4171
4172         * LayoutReloaded/misc/LFC-passing-tests.txt:
4173
4174 2019-02-12  Rob Buis  <rbuis@igalia.com>
4175
4176         Implement serializing in MIME type parser
4177         https://bugs.webkit.org/show_bug.cgi?id=193909
4178
4179         Reviewed by Darin Adler.
4180
4181         Add various tests involving upper case, non-ASCII, control/null characters,
4182         various HTTP whitespace, single quotes and an unpaired surrogate.
4183
4184         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4185         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
4186         (TestWebKitAPI::serializeIfValid):
4187         (TestWebKitAPI::TEST):
4188
4189 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
4190
4191         [Cocoa] Ask platform for generic font family mappings
4192         https://bugs.webkit.org/show_bug.cgi?id=187723
4193         <rdar://problem/41892438>
4194
4195         Reviewed by Brent Fulgham.
4196
4197         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
4198
4199         * DumpRenderTree/mac/DumpRenderTree.mm:
4200         (allowedFontFamilySet):
4201         * WebKitTestRunner/mac/TestControllerMac.mm:
4202         (WTR::allowedFontFamilySet):
4203
4204 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
4205
4206         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
4207         https://bugs.webkit.org/show_bug.cgi?id=193622
4208
4209         Reviewed by Michael Catanzaro.
4210
4211         This adds support for loading content extension rule sets from the JSON files which
4212         accompany the corresponding layout test, using the C API. The Cocoa specific parts
4213         of WKTR for this could be removed, but that is left for a follow-up patch with
4214         cleanups.
4215
4216         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
4217         * WebKitTestRunner/TestController.cpp:
4218         (WTR::testPath): Subtract one from the length when constructing the result std::string to
4219         avoid having the null-terminator copied into the result.
4220         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
4221         part of the preparations to run a test.
4222         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
4223         (WTR::contentExtensionStoreCallback): Added.
4224         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
4225         used for content extensions test.
4226         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
4227         extensions and compiling the JSON rule set for tests involving content extensions.
4228         (WTR::TestController::resetContentExtensions): Removes the content extension built for
4229         testing and disables content extensions.
4230         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
4231         resetContentExtensions().
4232         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
4233         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
4234         configureContentExtensionForTest(), and userContentController().
4235
4236 2019-02-11  Daniel Bates  <dabates@apple.com>
4237
4238         [iOS] Mouse/Touch/Pointer events are missing modifier keys
4239         https://bugs.webkit.org/show_bug.cgi?id=191446
4240         <rdar://problem/45929460>
4241
4242         Reviewed by Tim Horton.
4243
4244         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
4245
4246         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4247         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4248         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4249         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4250         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4251         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4252         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4253         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4254         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4255         (WTR::arrayLength):
4256         (WTR::parseModifierArray):
4257         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
4258         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4259         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
4260         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4261
4262 2019-02-11  Commit Queue  <commit-queue@webkit.org>
4263
4264         Unreviewed, rolling out r241272 and r241276.
4265         https://bugs.webkit.org/show_bug.cgi?id=194514
4266
4267         Broke the Apple Internal build and the fix requires human
4268         intervention :( (Requested by dydz on #webkit).
4269
4270         Reverted changesets:
4271
4272         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
4273         https://bugs.webkit.org/show_bug.cgi?id=191446
4274         https://trac.webkit.org/changeset/241272
4275
4276         "Fix internal iOS build after r241272"
4277         https://bugs.webkit.org/show_bug.cgi?id=191446
4278         https://trac.webkit.org/changeset/241276
4279
4280 2019-02-11  Truitt Savell  <tsavell@apple.com>
4281
4282         Unreviewed, rolling out r241269.
4283
4284         Caused 5 layout tests crashes on Mac WK1
4285
4286         Reverted changeset:
4287
4288         "DumpRenderTree should report unknown options"
4289         https://bugs.webkit.org/show_bug.cgi?id=191303
4290         https://trac.webkit.org/changeset/241269
4291
4292 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4293
4294         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
4295         https://bugs.webkit.org/show_bug.cgi?id=194313
4296
4297         Reviewed by Tim Horton.
4298
4299         Add a helper to determine whether the web view is presenting modal UI.
4300
4301         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4302         (WTR::UIScriptController::isPresentingModally const):
4303         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4304         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4305         (WTR::UIScriptController::isPresentingModally const):
4306         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4307         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4308         (WTR::UIScriptController::calendarType const): Deleted.
4309         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4310         (WTR::UIScriptController::isPresentingModally const):
4311         (WTR::UIScriptController::calendarType const):
4312         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4313         (WTR::UIScriptController::calendarType const):
4314
4315 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
4316
4317         GCHeapInspector: Show the retained sizes in more places
4318         https://bugs.webkit.org/show_bug.cgi?id=194464
4319
4320         Reviewed by Simon Fraser.
4321
4322         * GCHeapInspector/gc-heap-inspector.html:
4323         * GCHeapInspector/script/interface.js:
4324         (HeapInspectorUtils.humanReadableSize):
4325         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
4326         (HeapInspectorUtils.spanForNode.span.span):
4327         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
4328         (HeapSnapshotInspector.prototype.buildRoots):
4329
4330 2019-02-11  Daniel Bates  <dabates@apple.com>
4331
4332         [iOS] Mouse/Touch/Pointer events are missing modifier keys
4333         https://bugs.webkit.org/show_bug.cgi?id=191446
4334         <rdar://problem/45929460>
4335
4336         Reviewed by Tim Horton.
4337
4338         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
4339
4340         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4341         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4342         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4343         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4344         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4345         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4346         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4347         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4348         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4349         (WTR::arrayLength):
4350         (WTR::parseModifierArray):
4351         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
4352         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4353         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
4354         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4355
4356 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
4357
4358         DumpRenderTree should report unknown options
4359         https://bugs.webkit.org/show_bug.cgi?id=191303
4360
4361         Reviewed by Frédéric Wang.
4362
4363         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
4364         to report unknown options.
4365         Added and assigned test options which are&n