[GTK] Several InputMethodFilter tests are failing
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2
3         [GTK] Several InputMethodFilter tests are failing
4         https://bugs.webkit.org/show_bug.cgi?id=195408
5
6         Reviewed by Carlos Garcia Campos.
7
8         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
9         Regressed in r241751.
10         Hexadecimal values of keycodes are expressed now in upper letters.
11         Composited characters should be cast to UTF8 strings.
12
13         (TestWebKitAPI::TEST):
14
15 2019-03-07  Tomas Popela  <tpopela@redhat.com>
16
17         [GTK] Make Tools/gtkdoc python3 compatible
18         https://bugs.webkit.org/show_bug.cgi?id=195359
19
20         Reviewed by Carlos Garcia Campos.
21
22         * gtkdoc/generate-gtkdoc:
23         ConfigParser was reworked in Python 3.2 so we have adapt the code to
24         work with Python 2 and 3.
25         (get_gtkdoc_module_paths):
26         The iteritems() was removed in Python 3, so let's use items() that's
27         available in Python 2 and 3.
28         (get_generator_for_config):
29         * gtkdoc/gtkdoc.py:
30         (GTKDoc._run_command):
31         The sys.stdout.write() is expecting str in Python 3 and not bytes
32         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
33         for passing the bytes there.
34
35 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
36
37         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
38         https://bugs.webkit.org/show_bug.cgi?id=195346
39         <rdar://problem/48667048>
40
41         Unreviewed build fix for clang-cl.
42
43         * DumpRenderTree/win/DumpRenderTree.cpp:
44         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
45
46 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
47
48         requestAnimationFrame should execute before the next frame
49         https://bugs.webkit.org/show_bug.cgi?id=177484
50
51         Reviewed by Simon Fraser.
52
53         Add trace points for the page RenderingUpdate.
54
55         * Tracing/SystemTracePoints.plist:
56
57 2019-03-07  Zalan Bujtas  <zalan@apple.com>
58
59         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
60         https://bugs.webkit.org/show_bug.cgi?id=195353
61         <rdar://problem/48626394>
62
63         Reviewed by Simon Fraser.
64
65         * WebKitTestRunner/ios/TestControllerIOS.mm:
66         (WTR::TestController::platformResetPreferencesToConsistentValues):
67
68 2019-03-07  John Wilander  <wilander@apple.com>
69
70         Resource Load Statistics: Make it possible to purge only script-accessible cookies
71         https://bugs.webkit.org/show_bug.cgi?id=195383
72         <rdar://problem/48570136>
73
74         Reviewed by Brent Fulgham.
75
76         This patch adds test infrastructure to purge only script-accessible cookies,
77         including a new testRunner function called statisticsDeleteCookiesForHost().git a
78
79         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
80         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
81         (WTR::TestRunner::statisticsDeleteCookiesForHost):
82         * WebKitTestRunner/InjectedBundle/TestRunner.h:
83         * WebKitTestRunner/TestController.cpp:
84         (WTR::TestController::statisticsDeleteCookiesForHost):
85         * WebKitTestRunner/TestController.h:
86         * WebKitTestRunner/TestInvocation.cpp:
87         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
88
89 2019-03-07  Commit Queue  <commit-queue@webkit.org>
90
91         Unreviewed, rolling out r242354.
92         https://bugs.webkit.org/show_bug.cgi?id=195402
93
94         breaks layout tests in all configurations (Requested by
95         zdobersek on #webkit).
96
97         Reverted changeset:
98
99         "[WPE] Enable web process sandbox"
100         https://bugs.webkit.org/show_bug.cgi?id=195169
101         https://trac.webkit.org/changeset/242354
102
103 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
104
105         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
106         https://bugs.webkit.org/show_bug.cgi?id=195346
107
108         Reviewed by Fujii Hironori.
109
110         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
111         (TestWebKitAPI::TEST):
112         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
113
114         * DumpRenderTree/win/DumpRenderTree.cpp:
115         (findFontFallback):
116         (addFontFallbackIfPresent):
117         (removeFontFallbackIfPresent):
118         (main):
119         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
120         (TestWebKitAPI::Util::moduleDirectory):
121         (TestWebKitAPI::Util::createInjectedBundlePath):
122         Use wchar helpers as needed.
123
124 2019-03-06  Rob Buis  <rbuis@igalia.com>
125
126         Consider supporting the `referrerpolicy` attribute.
127         https://bugs.webkit.org/show_bug.cgi?id=179053
128
129         Reviewed by Darin Adler.
130
131         Add a runtime flag for referrerpolicy attribute.
132
133         * DumpRenderTree/mac/DumpRenderTree.mm:
134         (enableExperimentalFeatures):
135
136 2019-03-05  Daniel Bates  <dabates@apple.com>
137
138         Update expected API test result following r242379
139         (https://bugs.webkit.org/show_bug.cgi?id=195125)
140
141         Update expected x-coordinate of selection rect now that the left padding of
142         a textarea is sized in ems (so dependent on the font size) just like the left
143         padding of a text field.
144
145         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
146         (TestWebKitAPI::TEST):
147
148 2019-03-05  David Quesada  <david_quesada@apple.com>
149
150         [WK2] It should be possible to follow links with 'download' attributes
151         https://bugs.webkit.org/show_bug.cgi?id=195145
152         rdar://problem/48462642
153
154         Reviewed by Alex Christensen.
155
156         Add a unit test to verify that activating links with 'download' attributes now
157         navigates to the linked resource, rather than starts downloading it. Add another
158         to verify that it is still possible to explicitly download the link via the
159         'Download' navigation action policy.
160
161         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
162         (-[DownloadAttributeTestDelegate init]):
163         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
164         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
165         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
166         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
167         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
168         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
169         (TEST):
170         * WebKitTestRunner/TestController.cpp:
171         (WTR::TestController::decidePolicyForNavigationAction):
172         * WebKitTestRunner/TestController.h:
173
174 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
175
176         [Curl] Implement Cookie Accept Policy.
177         https://bugs.webkit.org/show_bug.cgi?id=191645
178
179         Reviewed by Fujii Hironori.
180
181         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
182         (TestWebKitAPI::Curl::TEST_F):
183
184 2019-03-05  Youenn Fablet  <youenn@apple.com>
185
186         Rename requestCacheStorageSpace to requestStorageSpace
187         https://bugs.webkit.org/show_bug.cgi?id=195282
188
189         Reviewed by Chris Dumez.
190
191         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
192         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
193         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
194
195 2019-03-05  Brady Eidson  <beidson@apple.com>
196
197         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
198         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
199
200         Reviewed by Tim Horton.
201
202         Loading a file: URL into a WKWebView and then loading another file: url from a completely
203         different directory into that same WKWebView should work.
204
205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
206         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
207
208 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
209
210         Add WeakHashSet
211         https://bugs.webkit.org/show_bug.cgi?id=195152
212
213         Reviewed by Antti Koivisto.
214
215         Added tests for WeakHashSet.
216
217         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
218         (TestWebKitAPI::Base::Base): Moved.
219         (TestWebKitAPI::Derived::foo): Moved.
220         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
221         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
222         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
223         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
224
225 2019-03-04  Chris Dumez  <cdumez@apple.com>
226
227         Do not share WebProcesses between private and regular sessions
228         https://bugs.webkit.org/show_bug.cgi?id=195189
229         <rdar://problem/48421064>
230
231         Reviewed by Alex Christensen.
232
233         Add API test coverage.
234
235         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
236         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
237
238 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
239
240         [WPE] Enable web process sandbox
241         https://bugs.webkit.org/show_bug.cgi?id=195169
242
243         Reviewed by Daniel Bates.
244
245         * wpe/install-dependencies:
246         * wpe/jhbuild.modules:
247
248 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
249
250         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
251         https://bugs.webkit.org/show_bug.cgi?id=195206
252
253         Reviewed by Žan Doberšek.
254
255         Add a new test case.
256
257         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
258         (testJSCClass):
259
260 2019-03-04  Charlie Turner  <cturner@igalia.com>
261
262         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
263         https://bugs.webkit.org/show_bug.cgi?id=194898
264
265         Reviewed by Žan Doberšek.
266
267         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
268         a GCC extension that permits arithmetic on void* pointer. Inline
269         the macro until this issue is fixed upstream.
270
271 2019-03-03  Tim Horton  <timothy_horton@apple.com>
272
273         Rid the world of WK_API_ENABLED
274         https://bugs.webkit.org/show_bug.cgi?id=195263
275
276         Reviewed by Dan Bernstein.
277
278         List of changed files elided because it's useless.
279
280 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
281
282         Unreviewed follow-up to r242292.
283
284         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
285
286         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
287         (TestWebKitAPI::testStrip): Renamed from strip.
288         (TestWebKitAPI::TEST):
289
290 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
291
292         Unreviewed, remove accidentally-committed URLHelpers.cpp test
293
294         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
295         and bug #194272 for details.
296
297         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
298
299 2019-03-03  Tim Horton  <timothy_horton@apple.com>
300
301         Remove some more unused 32-bit code
302         https://bugs.webkit.org/show_bug.cgi?id=195255
303
304         Reviewed by Darin Adler.
305
306         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
307         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
308         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
309         (NPP_New):
310         (NPP_HandleEvent):
311         (handleEventCarbon): Deleted.
312
313 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
314
315         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
316
317         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
318         (TestWebKitAPI::TEST):
319
320 2019-03-01  Darin Adler  <darin@apple.com>
321
322         Finish removing String::format
323         https://bugs.webkit.org/show_bug.cgi?id=194893
324
325         Reviewed by Daniel Bates.
326 '
327         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
328
329 2019-03-01  Alex Christensen  <achristensen@webkit.org>
330
331         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
332         https://bugs.webkit.org/show_bug.cgi?id=195229
333         <rdar://problem/48520362>
334
335         Reviewed by Chris Dumez.
336
337         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
338         (TEST):
339
340 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
341
342         Add a system trace scope for event region building
343         https://bugs.webkit.org/show_bug.cgi?id=195226
344
345         Reviewed by Jon Lee.
346
347         This trace scope measures the time spend converting element rects into Region objects,
348         which can be large on some pages.
349
350         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
351
352         * Tracing/SystemTracePoints.plist:
353
354 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
355
356         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
357         https://bugs.webkit.org/show_bug.cgi?id=194612
358
359         Reviewed by Alex Christensen.
360
361         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
362         Just test the new string-processing function and don't touch the actual environment.
363         (Test cases are all as before, but based on operator== instead of strcmp.)
364
365 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
366
367         [ews-app] Update primary keys for handling multiple Buildbot instances
368         https://bugs.webkit.org/show_bug.cgi?id=195120
369
370         Reviewed by Stephanie Lewis.
371
372         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
373         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
374         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
375
376         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
377         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
378         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
379         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
380         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
381         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
382
383 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
384
385         [WinCairo] Enable service worker
386         https://bugs.webkit.org/show_bug.cgi?id=188318
387
388         Reviewed by Youenn Fablet.
389
390         * DumpRenderTree/DumpRenderTreePrefix.h:
391         * TestWebKitAPI/PlatformWin.cmake:
392         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
393         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
394         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
395
396 2019-03-01  Justin Fan  <justin_fan@apple.com>
397
398         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
399         https://bugs.webkit.org/show_bug.cgi?id=195191
400
401         Rubber-stamped by Dean Jackson.
402
403         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
404
405         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
406
407 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
408
409         Unreviewed, fix lldb webkitpy tests
410         https://bugs.webkit.org/show_bug.cgi?id=194375
411
412         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
413
414         * lldb/lldb_webkit.py:
415         (WTFStringImplProvider.is_8bit):
416
417 2019-02-28  David Quesada  <david_quesada@apple.com>
418
419         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
420         https://bugs.webkit.org/show_bug.cgi?id=195121
421         rdar://problem/48450302
422
423         Reviewed by Alex Christensen.
424
425         Add API tests for -WKNavigationAction._shouldPerformDownload in various
426         configurations where the 'download' attribute is absent, blank, or populated
427         with a filename, and where the anchor element is same-origin or cross-origin
428         (meaning the 'download' attribute shouldn't be honored).
429
430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
431         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
432         (-[NavigationActionTestDelegate init]):
433         (-[NavigationActionTestDelegate navigationAction]):
434         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
435         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
436         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
437         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
438         (TEST):
439
440 2019-02-28  Antoine Quint  <graouts@apple.com>
441
442         Enable the Pointer Events runtime flag by default
443         https://bugs.webkit.org/show_bug.cgi?id=195156
444
445         Reviewed by Dean Jackson.
446
447         * DumpRenderTree/mac/DumpRenderTree.mm:
448         (enableExperimentalFeatures):
449
450 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
451
452         Several PasteImage API tests are flaky
453         https://bugs.webkit.org/show_bug.cgi?id=195160
454
455         Reviewed by Tim Horton.
456
457         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
458         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
459         listening for a "load" event after image load is already complete.
460
461         To address this, make these tests first register a "load" event handler, then run script to insert an image
462         element into the document, and finally wait until the load event is observed before checking image size.
463
464         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
465
466 2019-02-28  Chris Dumez  <cdumez@apple.com>
467
468         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
469         https://bugs.webkit.org/show_bug.cgi?id=195107
470
471         Reviewed by Alex Christensen.
472
473         Give some time for the zoom level to get restored.
474
475         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
476
477 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
478
479         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
480         https://bugs.webkit.org/show_bug.cgi?id=194958
481
482         Reviewed by Geoffrey Garen.
483
484         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
485         (TEST):
486
487 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
488
489         [ews-app] Update method to save build to handle builder_display_name
490         https://bugs.webkit.org/show_bug.cgi?id=195047
491
492         Reviewed by Dewei Zhu.
493
494         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
495         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
496
497 2019-02-28  Justin Fan  <justin_fan@apple.com>
498
499         [Web GPU] Enable Web GPU only on 64-bit
500         https://bugs.webkit.org/show_bug.cgi?id=195139
501
502         Because Metal is only supported on 64 bit apps.
503
504         Unreviewed build fix.
505
506         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
507
508 2019-02-27  Youenn Fablet  <youenn@apple.com>
509
510         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
511         https://bugs.webkit.org/show_bug.cgi?id=194959
512
513         Reviewed by Chris Dumez.
514
515         Spin loop until getting the condition to remove flakiness.
516
517         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
518
519 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
520
521         [ews-build] Buildbot should include builder_display_name in the build events
522         https://bugs.webkit.org/show_bug.cgi?id=195045
523
524         Reviewed by Dewei Zhu.
525
526         * BuildSlaveSupport/ews-build/events.py:
527         (Events.buildStarted): Included builder_display_name in event data. Also renamed
528         buildername to builder_name to be consistent in naming style.
529         (Events.buildFinished): Ditto.
530
531 2019-02-27  Chris Dumez  <cdumez@apple.com>
532
533         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
534         https://bugs.webkit.org/show_bug.cgi?id=194480
535
536         Reviewed by Brady Eidson.
537
538         Update existing API test to make it more likely to reproduce the issue.
539
540         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
541
542 2019-02-27  Brady Eidson  <beidson@apple.com>
543
544         Universal links from Google search results pages don't open the app.
545         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
546
547         Reviewed by Geoffrey Garen.
548
549         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
550         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
551         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
552         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
553
554 2019-02-27  Chris Dumez  <cdumez@apple.com>
555
556         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
557         https://bugs.webkit.org/show_bug.cgi?id=195102
558
559         Reviewed by Geoffrey Garen.
560
561         If the number of processes is not yet what we expect, wait a bit and check again to give
562         processes some time to exit.
563
564         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
565
566 2019-02-27  Chris Dumez  <cdumez@apple.com>
567
568         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
569         https://bugs.webkit.org/show_bug.cgi?id=194545
570
571         Reviewed by Brady Eidson.
572
573         Make sure the test navigates forward and then back only once. Previously, navigating
574         back would trigger a navigation again in a timer.
575
576         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
577
578 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
579
580         High Sierra Debug JSC test queue should use faster hardware
581         https://bugs.webkit.org/show_bug.cgi?id=194603
582
583         Rubber-stamped by Alexey Proskuryakov.
584
585         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
586
587         * BuildSlaveSupport/build.webkit.org-config/config.json:
588         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
589         (BubbleQueueServer):
590         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
591         (WebKitBuildbot):
592         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
593         * QueueStatusServer/config/queues.py:
594         * Scripts/webkitpy/common/config/ews.json:
595         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
596         (test_ews_name):
597
598 2019-02-27  John Wilander  <wilander@apple.com>
599
600         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
601         https://bugs.webkit.org/show_bug.cgi?id=195071
602         <rdar://problem/48417690>
603
604         Reviewed by Alex Christensen and Brent Fulgham.
605
606         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
607         (TestWebKitAPI::createURL):
608             Convenience function.
609         (TestWebKitAPI::TEST):
610             WebCore::AdClickAttribution now takes a URL when creating Source and
611             Destination.
612         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
613         (TestWebKitAPI::TEST):
614             WebCore::AdClickAttribution now takes a URL when creating Source and
615             Destination.
616
617 2019-02-27  Antoine Quint  <graouts@apple.com>
618
619         Support Pointer Events on macOS
620         https://bugs.webkit.org/show_bug.cgi?id=195008
621         <rdar://problem/47454419>
622
623         Reviewed by Dean Jackson.
624
625         * DumpRenderTree/mac/DumpRenderTree.mm:
626         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
627         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
628
629 2019-02-26  Mark Lam  <mark.lam@apple.com>
630
631         Remove remaining poisoning code.
632         https://bugs.webkit.org/show_bug.cgi?id=194138
633
634         Reviewed by Saam Barati.
635
636         * TestWebKitAPI/CMakeLists.txt:
637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
638         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
639         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
640         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
641         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
642         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
643         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
644
645 2019-02-26  Alex Christensen  <achristensen@webkit.org>
646
647         Move ephemeral local storage from WebProcess to UIProcess
648         https://bugs.webkit.org/show_bug.cgi?id=195074
649         <rdar://problem/47937975>
650
651         Reviewed by Geoff Garen.
652
653         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
654
655 2019-02-20  Jer Noble  <jer.noble@apple.com>
656
657         [Cocoa] Media elements will restart network buffering just before suspending
658         https://bugs.webkit.org/show_bug.cgi?id=193691
659
660         Reviewed by Eric Carlson.
661
662         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
663         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
664         (TEST):
665
666 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
667
668         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
669         https://bugs.webkit.org/show_bug.cgi?id=191652
670
671         Reviewed by Alex Christensen.
672
673         Fix WinCairo MiniBrowser behavior of authentication dialog.
674
675         * MiniBrowser/win/WebKitBrowserWindow.cpp:
676         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
677
678 2019-02-26  Youenn Fablet  <youenn@apple.com>
679
680         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
681         https://bugs.webkit.org/show_bug.cgi?id=195028
682         <rdar://problem/48243733>
683
684         Reviewed by Eric Carlson.
685
686         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
687
688 2019-02-26  Philippe Normand  <pnormand@igalia.com>
689
690         [WPE] Add API for webview background color configuration
691         https://bugs.webkit.org/show_bug.cgi?id=192305
692
693         Reviewed by Michael Catanzaro.
694
695         * MiniBrowser/wpe/main.cpp:
696         (main): Add a new option to configure the webview background
697         color. Example: --bg-color=transparent.
698         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
699         (testWebViewBackgroundColor): Enable background color API tests for WPE.
700         (beforeAll): Ditto.
701
702 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
703
704         scalableNativeWebpageParameters() is not preserved on new page navigation.
705         https://bugs.webkit.org/show_bug.cgi?id=194892
706         <rdar://problem/47538280>
707
708         Reviewed by Wenson Hsieh.
709         
710         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
711
712         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
713         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
714         * DumpRenderTree/mac/UIScriptControllerMac.mm:
715         (WTR::UIScriptController::allowsViewportShrinkToFit):
716         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
717         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
718         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
719         * TestRunnerShared/UIScriptContext/UIScriptController.h:
720         * WebKitTestRunner/UIScriptControllerCocoa.mm:
721         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
722
723 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
724
725         [ews-app] Add model for handling multiple Buildbot instances
726         https://bugs.webkit.org/show_bug.cgi?id=194863
727
728         Reviewed by Stephanie Lewis.
729
730         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
731
732 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
733
734         [ews-app] Remove BuilderMapping table
735         https://bugs.webkit.org/show_bug.cgi?id=194961
736
737         Reviewed by Stephanie Lewis.
738
739         Store builder name directly in build table, instead of having a separate
740         table for it.
741
742         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
743         * BuildSlaveSupport/ews-app/ews/models/build.py:
744         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
745         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
746
747 2019-02-25  John Wilander  <wilander@apple.com>
748
749         Introduce and adopt new class RegistrableDomain for eTLD+1
750         https://bugs.webkit.org/show_bug.cgi?id=194791
751         <rdar://problem/48179240>
752
753         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
754
755         This patch adds an API test and replaces two instances of
756         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
757
758         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
759         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
760         (TestWebKitAPI::TEST):
761             Changed two strings to make sure the registrable domains are still considered
762             invalid and pass the test.
763         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
764         (TestWebKitAPI::TEST):
765         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
766         (WTR::InjectedBundle::didReceiveMessageToPage):
767
768 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
769
770         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
771         https://bugs.webkit.org/show_bug.cgi?id=195001
772
773         Reviewed by Carlos Garcia Campos.
774
775         API version 1.0 always includes the functionality previously guarded with
776         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
777         unconditionally.
778
779         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
780         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
781         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
782         (WebViewTest::showInWindow): Ditto.
783         (WebViewTest::hideView): Ditto.
784         * wpe/backends/HeadlessViewBackend.cpp:
785         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
786         * wpe/backends/ViewBackend.cpp:
787         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
788         * wpe/backends/WindowViewBackend.cpp:
789         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
790         WPE_BACKEND_CHECK_VERSION().
791         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
792
793 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
794
795         [Flatpak] Add support for flatpak > 1.1.2
796         https://bugs.webkit.org/show_bug.cgi?id=194088
797
798         Flatpak 1.2 is now out so we need to support that
799         version now.
800
801         Reviewed by Michael Catanzaro.
802
803         * flatpak/flatpakutils.py:
804         (check_flatpak):
805         (FlatpakPackages.__init__):
806         (FlatpakPackages.__detect_packages):
807         (FlatpakPackages.__detect_packages.in):
808         (FlatpakRepos.update):
809
810 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
811
812         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
813         https://bugs.webkit.org/show_bug.cgi?id=194998
814
815         Reviewed by Carlos Garcia Campos.
816
817         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
818         to a Git checkout and using the latest commit containing various fixes
819         and improvements.
820
821 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
822
823         [WPE][GTK] Remove user agent quirk for washingtonpost.com
824         https://bugs.webkit.org/show_bug.cgi?id=194981
825
826         Reviewed by Žan Doberšek.
827
828         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
829         (TestWebKitAPI::TEST):
830
831 2019-02-23  Keith Miller  <keith_miller@apple.com>
832
833         Add new mac target numbers
834         https://bugs.webkit.org/show_bug.cgi?id=194955
835
836         Reviewed by Tim Horton.
837
838         * DumpRenderTree/mac/Configurations/Base.xcconfig:
839         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
840         * MiniBrowser/Configurations/Base.xcconfig:
841         * TestWebKitAPI/Configurations/Base.xcconfig:
842         * WebKitTestRunner/Configurations/Base.xcconfig:
843
844 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
845
846         [WinCairo] Enable wk1/wk2 suffix for platform search path.
847         https://bugs.webkit.org/show_bug.cgi?id=194846
848
849         Reviewed by Don Olmstead.
850
851         Added _search_paths() and _port_specific_expectations_files() for
852         WinCairoPort.
853
854         * Scripts/webkitpy/port/win.py:
855         (WinCairoPort.default_baseline_search_path):
856         (WinCairoPort):
857         (WinCairoPort._port_specific_expectations_files):
858         (WinCairoPort._search_paths):
859
860 2019-02-22  Tim Horton  <timothy_horton@apple.com>
861
862         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
863         https://bugs.webkit.org/show_bug.cgi?id=194963
864
865         Reviewed by Dean Jackson.
866
867         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
868         Do a `contains` check instead of `equals`, because in debug builds we
869         put the GraphicsLayer pointer in a prefix.
870
871 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
872
873         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
874         https://bugs.webkit.org/show_bug.cgi?id=194873
875         <rdar://problem/46701974>
876
877         Reviewed by Tim Horton.
878
879         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
880
881         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
882         (WTR::UIScriptController::menuRect const):
883         (WTR::UIScriptController::isShowingMenu const):
884         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
885         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
886         (WTR::UIScriptController::menuRect const):
887
888         Add a function to query the bounds of the callout menu in content coordinates.
889
890         (WTR::UIScriptController::isShowingMenu const):
891
892         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
893
894         * TestRunnerShared/UIScriptContext/UIScriptController.h:
895         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
896         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
897         (WTR::UIScriptController::rectForMenuAction const):
898         (WTR::UIScriptController::menuRect const):
899         (WTR::UIScriptController::isShowingMenu const):
900         (WTR::findViewInHierarchyOfType): Deleted.
901
902 2019-02-22  Chris Dumez  <cdumez@apple.com>
903
904         Regression(PSON) Unable to preview password-protected documents on iCloud.com
905         https://bugs.webkit.org/show_bug.cgi?id=194954
906         <rdar://problem/48127957>
907
908         Reviewed by Alex Christensen.
909
910         Add API test coverage.
911
912         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
913         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
914         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
915         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
916
917 2019-02-22  Chris Dumez  <cdumez@apple.com>
918
919         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
920         https://bugs.webkit.org/show_bug.cgi?id=194924
921         <rdar://problem/48216125>
922
923         Reviewed by Geoffrey Garen.
924
925         Add API test coverage.
926
927         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
928
929 2019-02-22  Chris Dumez  <cdumez@apple.com>
930
931         Unreviewed, disable API test added in r241928 on iOS.
932
933         The cache is not enabled on devices with less than 3GB of RAM.
934
935         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
936
937 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
938
939         Hardcode Visual Viewports on everywhere except iOS WK1
940         https://bugs.webkit.org/show_bug.cgi?id=194928
941
942         Reviewed by Zalan Bujtas.
943
944         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
945         change the default value of the Setting to 'true', and hardcode WebView on iOS to
946         set it to false. The setting has shipped for several years and there's no need to turn
947         it off now.
948
949         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
950         Visual Viewports are not enabled.
951         
952         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
953         that only runs in WK2
954
955         * MiniBrowser/mac/SettingsController.h:
956         * MiniBrowser/mac/SettingsController.m:
957         (-[SettingsController init]):
958         (-[SettingsController _populateMenu]):
959         (-[SettingsController validateMenuItem:]):
960         (-[SettingsController visualViewportEnabled]): Deleted.
961         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
962         * MiniBrowser/mac/WK1BrowserWindowController.m:
963         (-[WK1BrowserWindowController didChangeSettings]):
964         * MiniBrowser/mac/WK2BrowserWindowController.m:
965         (-[WK2BrowserWindowController didChangeSettings]):
966
967 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
968
969         Discard cached processes when clearing website data store
970         https://bugs.webkit.org/show_bug.cgi?id=194894
971
972         Reviewed by Chris Dumez.
973
974         Added a test case.
975
976         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
977         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
978
979 2019-02-21  Alex Christensen  <achristensen@webkit.org>
980
981         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
982         https://bugs.webkit.org/show_bug.cgi?id=194914
983         <rdar://problem/47586889>
984
985         Reviewed by Geoffrey Garen.
986
987         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
988         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
989         (TEST):
990         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
991
992 2019-02-21  David Kilzer  <ddkilzer@apple.com>
993
994         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
995         <https://webkit.org/b/194761>
996
997         Reviewed by Myles Maxfield.
998
999         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1000         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1001         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1002         to use ARC-compliant cast.
1003         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1004         ARC-compliant cast.
1005         (WTR::installFakeHelvetica): Log `error` to console if
1006         CTFontManagerRegisterFontsForURL() fails, but only on supported
1007         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1008         Call CFRelease() on `error` to fix the leak.  Update to use
1009         ARC-compliant cast.
1010         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1011         cast.
1012
1013 2019-02-21  Chris Dumez  <cdumez@apple.com>
1014
1015         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1016         https://bugs.webkit.org/show_bug.cgi?id=194481
1017
1018         Reviewed by Alex Christensen.
1019
1020         Give the processes a chance to shutdown and wait until we reached the expected number
1021         of processes.
1022
1023         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1024
1025 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1026
1027         Fix the macOS build
1028
1029         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1030
1031 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1032
1033         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1034
1035         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1036         I am a backwards.
1037
1038 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1039
1040         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1041
1042         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1043         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1044         We could force on UI-side compositing, but I feel like the test might be more
1045         valuable exercising the normal path on each platform (though the original
1046         bug was also UI-side specific). Though we can't validate that the overlay
1047         layer was installed successfully, there are layout tests that do that.
1048
1049 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1050
1051         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1052         https://bugs.webkit.org/show_bug.cgi?id=194845
1053         <rdar://problem/47944579>
1054
1055         Reviewed by Antti Koivisto.
1056
1057         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1058         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1059
1060 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1061
1062         [LFC][Floats] Add support for placing formatting roots in-between floats.
1063         https://bugs.webkit.org/show_bug.cgi?id=194902
1064
1065         Reviewed by Antti Koivisto.
1066
1067         * LayoutReloaded/misc/LFC-passing-tests.txt:
1068
1069 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1070
1071         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1072         https://bugs.webkit.org/show_bug.cgi?id=194901
1073
1074         Unreviewed build fix.
1075
1076         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1077         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1078         WPEBackend-fdo-0.1 as library name.
1079
1080 2019-02-21  Rob Buis  <rbuis@igalia.com>
1081
1082         Update MIME type parser
1083         https://bugs.webkit.org/show_bug.cgi?id=180526
1084
1085         Reviewed by Darin Adler.
1086
1087         Add tests involving leading and trailing whitespace, non-token
1088         characters and quoted strings.
1089
1090         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1091         (TestWebKitAPI::TEST):
1092
1093 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1094
1095         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1096         https://bugs.webkit.org/show_bug.cgi?id=194884
1097
1098         Reviewed by Michael Catanzaro.
1099
1100         * PlatformWin.cmake:
1101
1102 2019-02-20  Chris Dumez  <cdumez@apple.com>
1103
1104         Add API test for <rdar://problem/47471222>
1105         https://bugs.webkit.org/show_bug.cgi?id=194847
1106
1107         Reviewed by Alex Christensen.
1108
1109         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1110
1111 2019-02-20  Chris Dumez  <cdumez@apple.com>
1112
1113         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1114         https://bugs.webkit.org/show_bug.cgi?id=194872
1115         <rdar://problem/47924500>
1116
1117         Reviewed by Alex Christensen.
1118
1119         Add API test coverage.
1120
1121         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1122
1123 2019-02-20  Jer Noble  <jer.noble@apple.com>
1124
1125         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1126         https://bugs.webkit.org/show_bug.cgi?id=191332
1127
1128         Reviewed by Dean Jackson.
1129
1130         * Scripts/git-is-in-range: Added.
1131
1132 2019-02-20  Andy Estes  <aestes@apple.com>
1133
1134         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1135         https://bugs.webkit.org/show_bug.cgi?id=194869
1136
1137         Rubber-stamped by Jer Noble.
1138
1139         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1140         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1141         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1142         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1143         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1144         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1145
1146 2019-02-20  Chris Dumez  <cdumez@apple.com>
1147
1148         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1149         https://bugs.webkit.org/show_bug.cgi?id=194857
1150         <rdar://problem/47759323>
1151
1152         Reviewed by Alex Christensen.
1153
1154         Add API test coverage.
1155
1156         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1157
1158 2019-02-20  Chris Dumez  <cdumez@apple.com>
1159
1160         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1161         https://bugs.webkit.org/show_bug.cgi?id=194829
1162         <rdar://problem/47889906>
1163
1164         Reviewed by Alexey Proskuryakov.
1165
1166         Every time the TestOptions were changing we were creating both a new Web view and
1167         a new WKContext, which would start a new Network process. In most cases, we only
1168         need to contruct a new Web view and we do can keep reusing the same WKContext.
1169         This patch implements this optimization and thus avoids spinning a lot of new
1170         Network processes while running the layout tests.
1171
1172         * WebKitTestRunner/TestController.cpp:
1173         (WTR::TestController::generateContextConfiguration const):
1174         (WTR::TestController::generatePageConfiguration):
1175         (WTR::TestController::createWebViewWithOptions):
1176         (WTR::TestController::resetPreferencesToConsistentValues):
1177         (WTR::updateTestOptionsFromTestHeader):
1178         * WebKitTestRunner/TestController.h:
1179         * WebKitTestRunner/TestOptions.h:
1180         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1181         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1182         (WTR::TestOptions::hasSameInitializationOptions const):
1183         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1184         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1185         (WTR::TestController::platformAddTestOptions const):
1186
1187 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1188
1189         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1190         https://bugs.webkit.org/show_bug.cgi?id=167941
1191
1192         Reviewed by Carlos Garcia Campos.
1193
1194         * MiniBrowser/gtk/main.c:
1195         (filterSavedCallback): Added.
1196         (main): Support loading a JSON rule set file for content filtering.
1197         * MiniBrowser/wpe/main.cpp:
1198         (filterSavedCallback): Added.
1199         (main): Support loading a JSON rule set file for content filtering.
1200         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1201         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1202         (WTF::derefGPtr): Ditto.
1203         (testEmptyStore):
1204         (testSaveInvalidFilter):
1205         (testSaveLoadFilter):
1206         (testSavedFilterIdentifierMatch):
1207         (testRemoveFilter):
1208         (testSaveMultipleFilters):
1209         (testSaveFilterFromFile):
1210         (testFilterPersistence):
1211         (beforeAll):
1212         (afterAll):
1213         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1214         (removeOldInjectedContentAndResetLists): Also reset content filters.
1215         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1216         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1217         the element affected by the style sheet.
1218         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1219         and returns it to be used by tests.
1220         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1221         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1222         (serverCallback): Add support for serving a CSS style sheet for testing.
1223         (beforeAll): Add call to testUserContentManagerContentFilter().
1224         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1225
1226 2019-02-19  Keith Rollin  <krollin@apple.com>
1227
1228         Add timing information to build output
1229         https://bugs.webkit.org/show_bug.cgi?id=194839
1230         <rdar://problem/48219609>
1231
1232         Reviewed by Alexey Proskuryakov.
1233
1234         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1235         emit each project's build time to its output. E.g.,
1236
1237             ** BUILD SUCCEEDED ** [0.132 sec]
1238
1239         * Scripts/webkitdirs.pm:
1240         (XcodeOptions):
1241
1242 2019-02-19  Truitt Savell  <tsavell@apple.com>
1243
1244         Unreviewed, rolling out r241784.
1245
1246         Broke all OpenSource builds.
1247
1248         Reverted changeset:
1249
1250         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1251         instances view"
1252         https://bugs.webkit.org/show_bug.cgi?id=172848
1253         https://trac.webkit.org/changeset/241784
1254
1255 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1256
1257         [LFC][Floats] Remove redundant intersecting logic
1258         https://bugs.webkit.org/show_bug.cgi?id=194804
1259
1260         Reviewed by Antti Koivisto.
1261
1262         * LayoutReloaded/misc/LFC-passing-tests.txt:
1263
1264 2019-02-19  Dean Jackson  <dino@apple.com>
1265
1266         Clean-up output from generate-xcfilelists so it can be filtered
1267         https://bugs.webkit.org/show_bug.cgi?id=194795
1268
1269         Reviewed by Joseph Pecoraro (and Keith Rollin).
1270
1271         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1272         make a slight tweak to filter-build-webkit so such lines are marked
1273         as plain.
1274
1275         * Scripts/filter-build-webkit:
1276         * Scripts/generate-xcfilelists:
1277
1278 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1279
1280         pytest is not correctly auto-installed
1281         https://bugs.webkit.org/show_bug.cgi?id=194707
1282
1283         Reviewed by Carlos Garcia Campos.
1284
1285         * Scripts/webkitpy/thirdparty/__init__.py:
1286         (AutoinstallImportHook._install_pytest):
1287
1288 2019-02-18  Chris Dumez  <cdumez@apple.com>
1289
1290         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1291         https://bugs.webkit.org/show_bug.cgi?id=194797
1292         <rdar://problem/48055151>
1293
1294         Reviewed by Geoffrey Garen.
1295
1296         Add API test coverage.
1297
1298         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1299
1300 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1301
1302         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1303         https://bugs.webkit.org/show_bug.cgi?id=194670
1304         <rdar://problem/39066529>
1305
1306         Reviewed by Tim Horton.
1307
1308         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1309         pasted in an editable area as attachment elements.
1310
1311         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1312         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1313         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1314         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1315         (TestWebKitAPI::TEST):
1316         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1317         (WTR::InjectedBundlePage::InjectedBundlePage):
1318
1319 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1320
1321         Fix API test after r241728
1322        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1323
1324         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1325         (TEST):
1326         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1327
1328 2019-02-18  Daniel Bates  <dabates@apple.com>
1329
1330         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1331         https://bugs.webkit.org/show_bug.cgi?id=192824
1332         <rdar://problem/47100332>
1333
1334         Reviewed by Wenson Hsieh.
1335
1336         Fix a bug where the wrong usage code was used for F13 thru F24.
1337
1338         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1339         (keyCodeForDOMFunctionKey):
1340
1341 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1342
1343         Bytecode cache should a have a boot-specific validation
1344         https://bugs.webkit.org/show_bug.cgi?id=194769
1345         <rdar://problem/48149509>
1346
1347         Reviewed by Keith Miller.
1348
1349         Add test for WTF::bootSessionUUIDString()
1350
1351         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1352         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1353         (TEST):
1354
1355 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1356
1357         Disable safe browsing in WKWebView and remove its WKPreferences API
1358         https://bugs.webkit.org/show_bug.cgi?id=194723
1359         <rdar://problem/48122993>
1360
1361         Reviewed by Geoffrey Garen.
1362
1363         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1364         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1365         (TEST):
1366         (safeBrowsingView):
1367         Make tests use SPI instead of API.
1368
1369 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1370
1371         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1372         https://bugs.webkit.org/show_bug.cgi?id=194586
1373
1374         Reviewed by Ross Kirsling.
1375
1376         * DumpRenderTree/win/DumpRenderTree.cpp:
1377         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1378         * Scripts/webkitpy/port/driver.py:
1379         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1380
1381 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1382
1383         Unreviewed, rolling out r241620.
1384
1385         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1386         (Requested by ddkilzer on #webkit.)
1387
1388         Reverted changeset:
1389
1390         "[WTF] Add environment variable helpers"
1391         https://bugs.webkit.org/show_bug.cgi?id=192405
1392         https://trac.webkit.org/changeset/241620
1393
1394 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1395
1396         [LFC] RenderImage's default intrinsic size is 0.
1397         https://bugs.webkit.org/show_bug.cgi?id=194745
1398
1399         Reviewed by Antti Koivisto.
1400
1401         * LayoutReloaded/misc/LFC-passing-tests.txt:
1402
1403 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1404
1405         [LFC][BFC] Add support for block replaced intrinsic width.
1406         https://bugs.webkit.org/show_bug.cgi?id=194705
1407
1408         Reviewed by Simon Fraser.
1409
1410         * LayoutReloaded/misc/LFC-passing-tests.txt:
1411
1412 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1413
1414         [LFC] Apply min/max width constraints to preferred width computation
1415         https://bugs.webkit.org/show_bug.cgi?id=194739
1416
1417         Reviewed by Simon Fraser.
1418
1419         * LayoutReloaded/misc/LFC-passing-tests.txt:
1420
1421 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1422
1423         [WTF] Add environment variable helpers
1424         https://bugs.webkit.org/show_bug.cgi?id=192405
1425
1426         Reviewed by Michael Catanzaro.
1427
1428         * DumpRenderTree/mac/DumpRenderTree.mm:
1429         (libraryPathForDumpRenderTree):
1430         * DumpRenderTree/win/DumpRenderTree.cpp:
1431         (libraryPathForDumpRenderTree):
1432         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1433         (setUpIOSLayoutTestCommunication):
1434         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1435         (beforeAll):
1436         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1437         (main):
1438         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1439         (WebKitTestBus::run):
1440         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1441         (WTR::getOutputDir):
1442         (WTR::initializeFontConfigSetting):
1443         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1444         (WTR::InjectedBundle::platformInitialize):
1445         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1446         (WTR::topLevelPath):
1447         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1448         (WTR::topLevelPath):
1449         (WTR::getOutputDir):
1450         (WTR::activateFonts):
1451         * WebKitTestRunner/TestController.cpp:
1452         (WTR::TestController::libraryPathForTesting):
1453         (WTR::TestController::generateContextConfiguration const):
1454         (WTR::TestController::generatePageConfiguration):
1455         (WTR::TestController::decideDestinationWithSuggestedFilename):
1456         (WTR::TestController::platformAdjustContext):
1457         * WebKitTestRunner/TestController.h:
1458         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1459         (WTR::TestController::cocoaPlatformInitialize):
1460         (WTR::TestController::platformAdjustContext):
1461         * WebKitTestRunner/gtk/main.cpp:
1462         (main):
1463         * WebKitTestRunner/mac/TestControllerMac.mm:
1464         (WTR::TestController::configureContentExtensionForTest):
1465         * WebKitTestRunner/wpe/main.cpp:
1466         (main):
1467         Utilize WTF::Environment where possible.
1468
1469 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1470
1471         [iOS] WKWebView callout bar is missing Change Writing Direction item
1472         https://bugs.webkit.org/show_bug.cgi?id=190015
1473         <rdar://problem/44810366>
1474
1475         Reviewed by Tim Horton.
1476
1477         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1478         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1479
1480         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1481         (TestWebKitAPI::TEST):
1482
1483 2019-02-15  Chris Dumez  <cdumez@apple.com>
1484
1485         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1486         https://bugs.webkit.org/show_bug.cgi?id=194717
1487         <rdar://problem/47884404>
1488
1489         Reviewed by Brady Eidson.
1490
1491         Add API test coverage.
1492
1493         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1494
1495 2019-02-15  Youenn Fablet  <youenn@apple.com>
1496
1497         Make navigator.mediaDevices SecureContext
1498         https://bugs.webkit.org/show_bug.cgi?id=194666
1499
1500         Reviewed by Eric Carlson.
1501
1502         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1503         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1504         (TEST_F):
1505
1506 2019-02-15  Brian Burg  <bburg@apple.com>
1507
1508         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1509         https://bugs.webkit.org/show_bug.cgi?id=194411
1510         <rdar://problem/47787614>
1511
1512         Reviewed by Joseph Pecoraro.
1513
1514         Remove unnecessary soft linking macro usage.
1515
1516         * DumpRenderTree/mac/TestRunnerMac.mm:
1517         (TestRunner::inspectorTestStubURL):
1518         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1519         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1520         (WTR::TestRunner::inspectorTestStubURL):
1521
1522 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1523
1524         Unreviewed, rolling out r241559 and r241566.
1525         https://bugs.webkit.org/show_bug.cgi?id=194710
1526
1527         Causes layout test crashes under GuardMalloc (Requested by
1528         ryanhaddad on #webkit).
1529
1530         Reverted changesets:
1531
1532         "[WTF] Add environment variable helpers"
1533         https://bugs.webkit.org/show_bug.cgi?id=192405
1534         https://trac.webkit.org/changeset/241559
1535
1536         "Unreviewed build fix for WinCairo Debug after r241559."
1537         https://trac.webkit.org/changeset/241566
1538
1539 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1540
1541         [LFC] Out-of-flow box is never a float box
1542         https://bugs.webkit.org/show_bug.cgi?id=194704
1543
1544         Reviewed by Antti Koivisto.
1545
1546         * LayoutReloaded/misc/LFC-passing-tests.txt:
1547
1548 2019-02-10  Darin Adler  <darin@apple.com>
1549
1550         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1551         https://bugs.webkit.org/show_bug.cgi?id=194487
1552
1553         Reviewed by Daniel Bates.
1554
1555         * DumpRenderTree/win/DumpRenderTree.cpp:
1556         (applicationId): Use makeString instead of String::format.
1557         (main): Ditto.
1558         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1559         (TestWebKitAPI::Util::createURLForResource): Ditto.
1560         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1561         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1562
1563         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1564         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1565         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1566         (WTR::createStringWithAttributes): Use appendLiteral.
1567         (WTR::AccessibilityUIElement::helpText const): Ditto.
1568         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1569         directly instead of using String::format.
1570         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1571         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1572
1573 2019-02-15  Truitt Savell  <tsavell@apple.com>
1574
1575         Unreviewed, rolling out r241564.
1576
1577         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1578
1579         Reverted changeset:
1580
1581         "[Mac] WebInspectorUI.framework does not need to be soft-
1582         linked anymore"
1583         https://bugs.webkit.org/show_bug.cgi?id=194411
1584         https://trac.webkit.org/changeset/241564
1585
1586 2019-02-15  Saam barati  <sbarati@apple.com>
1587
1588         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1589         https://bugs.webkit.org/show_bug.cgi?id=194036
1590
1591         Reviewed by Yusuke Suzuki.
1592
1593         * Scripts/run-jsc-stress-tests:
1594
1595 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1596
1597         Fix the build.
1598
1599         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1600         (WTR::UIScriptController::drawSquareInEditableImage):
1601         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1602         (TestWebKitAPI::drawSquareInEditableImage):
1603
1604 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1605
1606         Fix the build.
1607
1608         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1609         (WTR::UIScriptController::drawSquareInEditableImage):
1610         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1611         (TestWebKitAPI::drawSquareInEditableImage):
1612
1613 2019-02-14  Brian Burg  <bburg@apple.com>
1614
1615         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1616         https://bugs.webkit.org/show_bug.cgi?id=194411
1617         <rdar://problem/47787614>
1618
1619         Reviewed by Joseph Pecoraro.
1620
1621         Remove unnecessary soft linking macro usage.
1622
1623         * DumpRenderTree/mac/TestRunnerMac.mm:
1624         (TestRunner::inspectorTestStubURL):
1625         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1626         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1627         (WTR::TestRunner::inspectorTestStubURL):
1628
1629 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1630
1631         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1632         https://bugs.webkit.org/show_bug.cgi?id=194599
1633
1634         Reviewed by Lucas Forschler.
1635
1636         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1637         (StatusBubble._build_bubble):
1638
1639 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1640
1641         [ews-app] Set Foreign Key in Django build model
1642         https://bugs.webkit.org/show_bug.cgi?id=194667
1643
1644         Reviewed by Lucas Forschler.
1645
1646         * BuildSlaveSupport/ews-app/ews/models/build.py:
1647         (Build):
1648
1649 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1650
1651         [WTF] Add environment variable helpers
1652         https://bugs.webkit.org/show_bug.cgi?id=192405
1653
1654         Reviewed by Michael Catanzaro.
1655
1656         * DumpRenderTree/mac/DumpRenderTree.mm:
1657         (libraryPathForDumpRenderTree):
1658         * DumpRenderTree/win/DumpRenderTree.cpp:
1659         (libraryPathForDumpRenderTree):
1660         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1661         (setUpIOSLayoutTestCommunication):
1662         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1663         (TestWebKitAPI::strip):
1664         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1665         (beforeAll):
1666         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1667         (main):
1668         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1669         (WebKitTestBus::run):
1670         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1671         (WTR::getOutputDir):
1672         (WTR::initializeFontConfigSetting):
1673         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1674         (WTR::InjectedBundle::platformInitialize):
1675         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1676         (WTR::topLevelPath):
1677         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1678         (WTR::topLevelPath):
1679         (WTR::getOutputDir):
1680         (WTR::activateFonts):
1681         * WebKitTestRunner/TestController.cpp:
1682         (WTR::TestController::libraryPathForTesting):
1683         (WTR::TestController::generateContextConfiguration const):
1684         (WTR::TestController::generatePageConfiguration):
1685         (WTR::TestController::decideDestinationWithSuggestedFilename):
1686         (WTR::TestController::platformAdjustContext):
1687         * WebKitTestRunner/TestController.h:
1688         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1689         (WTR::TestController::cocoaPlatformInitialize):
1690         (WTR::TestController::platformAdjustContext):
1691         * WebKitTestRunner/gtk/main.cpp:
1692         (main):
1693         * WebKitTestRunner/mac/TestControllerMac.mm:
1694         (WTR::TestController::configureContentExtensionForTest):
1695         * WebKitTestRunner/wpe/main.cpp:
1696         (main):
1697         Utilize WTF::Environment where possible.
1698
1699 2019-02-14  Chris Dumez  <cdumez@apple.com>
1700
1701         [PSON] Introduce a WebContent Process cache
1702         https://bugs.webkit.org/show_bug.cgi?id=194594
1703         <rdar://problem/46793397>
1704
1705         Reviewed by Geoff Garen.
1706
1707         Update API tests to turn on the WebContent Process cache.
1708
1709         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1710
1711 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1712
1713         Unreviewed, build fix after r241480
1714
1715         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1716         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1717         (-[DragAndDropSimulator initWithWebView:]):
1718
1719 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1720
1721         AX: ARIA Reflection was disabled in error
1722         https://bugs.webkit.org/show_bug.cgi?id=194647
1723         <rdar://problem/48068336>
1724
1725         Reviewed by Ryosuke Niwa.
1726
1727         Remove test override now that this feature should be enabled by default.
1728
1729         * WebKitTestRunner/TestController.cpp:
1730         (WTR::TestController::resetPreferencesToConsistentValues):
1731
1732 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1733
1734         Unreviewed, rolling out r241486.
1735         https://bugs.webkit.org/show_bug.cgi?id=194655
1736
1737         causing API failures in builds (Requested by ShawnRoberts on
1738         #webkit).
1739
1740         Reverted changeset:
1741
1742         "[Cocoa] Media elements will restart network buffering just
1743         before suspending"
1744         https://bugs.webkit.org/show_bug.cgi?id=193691
1745         https://trac.webkit.org/changeset/241486
1746
1747 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1748
1749         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1750         https://bugs.webkit.org/show_bug.cgi?id=194622
1751
1752         Reviewed by Antti Koivisto.
1753
1754         * LayoutReloaded/misc/LFC-passing-tests.txt:
1755
1756 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1757
1758         [LFC] Shrink-to-fit-width should be constrained by min/max width
1759         https://bugs.webkit.org/show_bug.cgi?id=194653
1760
1761         Reviewed by Antti Koivisto.
1762
1763         * LayoutReloaded/misc/LFC-passing-tests.txt:
1764
1765 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1766
1767         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1768         https://bugs.webkit.org/show_bug.cgi?id=194641
1769
1770         Reviewed by Geoffrey Garen.
1771
1772         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1773         so that the test would fail without this fix.
1774
1775         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1776         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1777
1778 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1779
1780         [ews-app] Change log level for a log statement
1781
1782         Unreviewed minor fix.
1783
1784         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1785         (Patch.save_patch):
1786
1787 2019-02-13  Jer Noble  <jer.noble@apple.com>
1788
1789         [Cocoa] Media elements will restart network buffering just before suspending
1790         https://bugs.webkit.org/show_bug.cgi?id=193691
1791
1792         Reviewed by Eric Carlson.
1793
1794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1795         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1796         (TEST):
1797
1798 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1799
1800         [ews-app] Fetch builder id to name mapping
1801         https://bugs.webkit.org/show_bug.cgi?id=194355
1802
1803         Reviewed by Lucas Forschler.
1804
1805         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1806         (Buildbot.get_builder_id_to_name_mapping):
1807         (Buildbot._get_display_name_from_builder_name):
1808
1809 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1810
1811         Further restricting webarchive loads
1812         https://bugs.webkit.org/show_bug.cgi?id=194567
1813         <rdar://problem/47610130>
1814
1815         Reviewed by Youenn Fablet.
1816
1817         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1818         navigations on drop.
1819
1820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1821         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1822         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1823         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1824         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1825         (TestWebKitAPI::TEST):
1826         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1827         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1828         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1829         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1830         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1831         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1832         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1833
1834 2019-02-13  John Wilander  <wilander@apple.com>
1835
1836         Store Ad Click Attribution requests in the network process
1837         https://bugs.webkit.org/show_bug.cgi?id=194510
1838         <rdar://problem/47650118>
1839
1840         Reviewed by Alex Christensen and Daniel Bates.
1841
1842         This patch adds two TestRunner functions:
1843         - dumpAdClickAttribution()
1844         - clearAdClickAttribution()
1845
1846         They call into the network process to dump and clear Ad Click
1847         Attribution state, respectively.
1848
1849         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1850         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1851         (WTR::TestRunner::dumpAdClickAttribution):
1852         (WTR::TestRunner::clearAdClickAttribution):
1853         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1854         * WebKitTestRunner/TestController.cpp:
1855         (WTR::TestController::resetStateToConsistentValues):
1856         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1857         (WTR::adClickAttributionStringResultCallback):
1858         (WTR::TestController::dumpAdClickAttribution):
1859         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1860         (WTR::adClickAttributionVoidCallback):
1861         (WTR::TestController::clearAdClickAttribution):
1862         * WebKitTestRunner/TestController.h:
1863         * WebKitTestRunner/TestInvocation.cpp:
1864         (WTR::TestInvocation::dumpResults):
1865         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1866         (WTR::TestInvocation::dumpAdClickAttribution):
1867         * WebKitTestRunner/TestInvocation.h:
1868
1869 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1870
1871         [ews-app] Generate status-bubble
1872         https://bugs.webkit.org/show_bug.cgi?id=194572
1873
1874         Reviewed by Lucas Forschler.
1875
1876         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1877         (StatusBubble._build_bubble):
1878         (StatusBubble._should_show_bubble_for):
1879         (StatusBubble._build_bubbles_for_patch):
1880
1881 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1882
1883         [ews-app] Add status bubble html template
1884         https://bugs.webkit.org/show_bug.cgi?id=194571
1885
1886         Reviewed by Lucas Forschler.
1887
1888         * BuildSlaveSupport/ews-app/ews/templates: Added.
1889         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1890
1891 2019-02-12  Chris Dumez  <cdumez@apple.com>
1892
1893         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1894         https://bugs.webkit.org/show_bug.cgi?id=194568
1895         <rdar://problem/47944490>
1896
1897         Reviewed by Ryosuke Niwa.
1898
1899         Add API test coverage.
1900
1901         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1902         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1903
1904 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1905
1906         webkitpy: Remove bug_dummy from parsed test expectations
1907         https://bugs.webkit.org/show_bug.cgi?id=194562
1908         <rdar://problem/47853999>
1909
1910         Reviewed by Lucas Forschler.
1911
1912         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1913         (TestExpectationParser):
1914         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1915         skipped tests.
1916         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1917
1918 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1919
1920         [ews-app] Add method to fetch patch
1921         https://bugs.webkit.org/show_bug.cgi?id=194518
1922
1923         Reviewed by Lucas Forschler.
1924
1925         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1926         (Patch.get_patch):
1927
1928 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1929
1930         [LFC] Expand tests coverage (60 new tests -> 860)
1931
1932         Unreviewed test gardening (run-singly, --child-processes=1).
1933
1934         * LayoutReloaded/misc/LFC-passing-tests.txt:
1935
1936 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1937
1938         Allow pages to trigger programmatic paste from script on iOS
1939         https://bugs.webkit.org/show_bug.cgi?id=194271
1940         <rdar://problem/47808810>
1941
1942         Reviewed by Tim Horton.
1943
1944         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1945
1946         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1947         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1948         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1949         (WTR::UIScriptController::rectForMenuAction const):
1950
1951         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1952         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1953         for when the menu is shown or hidden.
1954
1955         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1956         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1957         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1958         (WTR::UIScriptController::setDidShowMenuCallback):
1959         (WTR::UIScriptController::didShowMenuCallback const):
1960         (WTR::UIScriptController::setDidHideMenuCallback):
1961         (WTR::UIScriptController::didHideMenuCallback const):
1962         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1963         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1964         (WTR::UIScriptController::rectForMenuAction const):
1965         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1966         * WebKitTestRunner/TestController.cpp:
1967         (WTR::TestController::resetPreferencesToConsistentValues):
1968         (WTR::updateTestOptionsFromTestHeader):
1969         * WebKitTestRunner/TestOptions.h:
1970
1971         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1972         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1973
1974         (WTR::TestOptions::hasSameInitializationOptions const):
1975         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1976         (WTR::UIScriptController::calendarType const):
1977         (WTR::UIScriptController::platformUndoManager const):
1978         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1979         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1980         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1981         (-[TestRunnerWKWebView dealloc]):
1982         (-[TestRunnerWKWebView _didShowMenu]):
1983         (-[TestRunnerWKWebView _didHideMenu]):
1984
1985         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1986
1987         * WebKitTestRunner/ios/TestControllerIOS.mm:
1988         (WTR::handleMenuWillHideNotification):
1989         (WTR::handleMenuDidHideNotification):
1990         (WTR::TestController::platformInitialize):
1991         (WTR::TestController::platformDestroy):
1992         (WTR::TestController::platformResetStateToConsistentValues):
1993
1994         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1995         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1996
1997         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1998         (WTR::forEachViewInHierarchy):
1999         (WTR::findViewInHierarchyOfType):
2000
2001         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2002         functions that dig through a given view's hierarchy in search of a view of a given class.
2003
2004         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2005         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2006         (WTR::UIScriptController::selectionCaretViewRect const):
2007         (WTR::UIScriptController::selectionRangeViewRects const):
2008         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2009         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2010
2011         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2012
2013         (WTR::UIScriptController::rectForMenuAction const):
2014
2015         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2016         callout bar) whose label matches the given string.
2017
2018         (WTR::UIScriptController::platformContentView const):
2019
2020         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2021         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2022         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2023
2024         (WTR::UIScriptController::platformUndoManager const): Deleted.
2025         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2026         (WTR::UIScriptController::platformContentView const):
2027         (WTR::UIScriptController::platformUndoManager const): Deleted.
2028
2029 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2030
2031         webkitpy: No option to only show unexpected failures in results.html for iPad
2032         https://bugs.webkit.org/show_bug.cgi?id=194554
2033         <rdar://problem/47922442>
2034
2035         Rubber-stamped by Aakash Jain.
2036
2037         Just because a TestExpecations file does not exist for a specific platform does not mean that
2038         TestExpecations are not being used, given that platforms inherit test expectations.
2039
2040         * Scripts/webkitpy/port/base.py:
2041         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2042         * Scripts/webkitpy/port/base_unittest.py:
2043         (PortTest.test_uses_test_expectations_file):
2044
2045 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2046
2047         Remove setDefersLoading infrastructure from WebKit2
2048         https://bugs.webkit.org/show_bug.cgi?id=194506
2049
2050         Reviewed by Brady Eidson.
2051
2052         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2053         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2054         (WTR::TestRunner::setDefersLoading): Deleted.
2055         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2056
2057 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2058
2059         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2060         https://bugs.webkit.org/show_bug.cgi?id=194522
2061         <rdar://problem/47789393>
2062
2063         Reviewed by Chris Dumez.
2064
2065         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2066         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2067         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2068         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2069
2070 2019-02-12  Andy Estes  <aestes@apple.com>
2071
2072         [iOSMac] Enable Parental Controls Content Filtering
2073         https://bugs.webkit.org/show_bug.cgi?id=194521
2074         <rdar://39732376>
2075
2076         Reviewed by Tim Horton.
2077
2078         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2079
2080 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2081
2082         [LFC][IFC] Add intrinsic width support for float boxes.
2083         https://bugs.webkit.org/show_bug.cgi?id=194528
2084
2085         Reviewed by Antti Koivisto.
2086
2087         Expand tests coverage (2 new tests -> 800).
2088         (This is the correct test ordering --runs-singly --child-processes=1)
2089
2090         * LayoutReloaded/misc/LFC-passing-tests.txt:
2091
2092 2019-02-12  Rob Buis  <rbuis@igalia.com>
2093
2094         Implement serializing in MIME type parser
2095         https://bugs.webkit.org/show_bug.cgi?id=193909
2096
2097         Reviewed by Darin Adler.
2098
2099         Add various tests involving upper case, non-ASCII, control/null characters,
2100         various HTTP whitespace, single quotes and an unpaired surrogate.
2101
2102         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2103         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2104         (TestWebKitAPI::serializeIfValid):
2105         (TestWebKitAPI::TEST):
2106
2107 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2108
2109         [Cocoa] Ask platform for generic font family mappings
2110         https://bugs.webkit.org/show_bug.cgi?id=187723
2111         <rdar://problem/41892438>
2112
2113         Reviewed by Brent Fulgham.
2114
2115         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2116
2117         * DumpRenderTree/mac/DumpRenderTree.mm:
2118         (allowedFontFamilySet):
2119         * WebKitTestRunner/mac/TestControllerMac.mm:
2120         (WTR::allowedFontFamilySet):
2121
2122 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2123
2124         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2125         https://bugs.webkit.org/show_bug.cgi?id=193622
2126
2127         Reviewed by Michael Catanzaro.
2128
2129         This adds support for loading content extension rule sets from the JSON files which
2130         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2131         of WKTR for this could be removed, but that is left for a follow-up patch with
2132         cleanups.
2133
2134         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2135         * WebKitTestRunner/TestController.cpp:
2136         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2137         avoid having the null-terminator copied into the result.
2138         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2139         part of the preparations to run a test.
2140         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2141         (WTR::contentExtensionStoreCallback): Added.
2142         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2143         used for content extensions test.
2144         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2145         extensions and compiling the JSON rule set for tests involving content extensions.
2146         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2147         testing and disables content extensions.
2148         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2149         resetContentExtensions().
2150         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2151         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2152         configureContentExtensionForTest(), and userContentController().
2153
2154 2019-02-11  Daniel Bates  <dabates@apple.com>
2155
2156         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2157         https://bugs.webkit.org/show_bug.cgi?id=191446
2158         <rdar://problem/45929460>
2159
2160         Reviewed by Tim Horton.
2161
2162         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2163
2164         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2165         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2166         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2167         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2168         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2169         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2170         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2171         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2172         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2173         (WTR::arrayLength):
2174         (WTR::parseModifierArray):
2175         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2176         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2177         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2178         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2179
2180 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2181
2182         Unreviewed, rolling out r241272 and r241276.
2183         https://bugs.webkit.org/show_bug.cgi?id=194514
2184
2185         Broke the Apple Internal build and the fix requires human
2186         intervention :( (Requested by dydz on #webkit).
2187
2188         Reverted changesets:
2189
2190         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2191         https://bugs.webkit.org/show_bug.cgi?id=191446
2192         https://trac.webkit.org/changeset/241272
2193
2194         "Fix internal iOS build after r241272"
2195         https://bugs.webkit.org/show_bug.cgi?id=191446
2196         https://trac.webkit.org/changeset/241276
2197
2198 2019-02-11  Truitt Savell  <tsavell@apple.com>
2199
2200         Unreviewed, rolling out r241269.
2201
2202         Caused 5 layout tests crashes on Mac WK1
2203
2204         Reverted changeset:
2205
2206         "DumpRenderTree should report unknown options"
2207         https://bugs.webkit.org/show_bug.cgi?id=191303
2208         https://trac.webkit.org/changeset/241269
2209
2210 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2211
2212         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2213         https://bugs.webkit.org/show_bug.cgi?id=194313
2214
2215         Reviewed by Tim Horton.
2216
2217         Add a helper to determine whether the web view is presenting modal UI.
2218
2219         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2220         (WTR::UIScriptController::isPresentingModally const):
2221         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2222         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2223         (WTR::UIScriptController::isPresentingModally const):
2224         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2225         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2226         (WTR::UIScriptController::calendarType const): Deleted.
2227         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2228         (WTR::UIScriptController::isPresentingModally const):
2229         (WTR::UIScriptController::calendarType const):
2230         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2231         (WTR::UIScriptController::calendarType const):
2232
2233 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2234
2235         GCHeapInspector: Show the retained sizes in more places
2236         https://bugs.webkit.org/show_bug.cgi?id=194464
2237
2238         Reviewed by Simon Fraser.
2239
2240         * GCHeapInspector/gc-heap-inspector.html:
2241         * GCHeapInspector/script/interface.js:
2242         (HeapInspectorUtils.humanReadableSize):
2243         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2244         (HeapInspectorUtils.spanForNode.span.span):
2245         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2246         (HeapSnapshotInspector.prototype.buildRoots):
2247
2248 2019-02-11  Daniel Bates  <dabates@apple.com>
2249
2250         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2251         https://bugs.webkit.org/show_bug.cgi?id=191446
2252         <rdar://problem/45929460>
2253
2254         Reviewed by Tim Horton.
2255
2256         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2257
2258         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2259         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2260         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2261         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2262         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2263         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2264         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2265         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2266         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2267         (WTR::arrayLength):
2268         (WTR::parseModifierArray):
2269         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2270         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2271         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2272         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2273
2274 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2275
2276         DumpRenderTree should report unknown options
2277         https://bugs.webkit.org/show_bug.cgi?id=191303
2278
2279         Reviewed by Frédéric Wang.
2280
2281         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2282         to report unknown options.
2283         Added and assigned test options which are currently used in tests.
2284
2285         * DumpRenderTree/TestOptions.cpp:
2286         (TestOptions::TestOptions):
2287
2288 2019-02-11  Truitt Savell  <tsavell@apple.com>
2289
2290         Unreviewed, rolling out r241229.
2291
2292         Revision broke internal builds for watchOS.
2293
2294         Reverted changeset:
2295
2296         "[Cocoa] Ask platform for generic font family mappings"
2297         https://bugs.webkit.org/show_bug.cgi?id=187723
2298         https://trac.webkit.org/changeset/241229
2299
2300 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2301
2302         [WinCairo][MiniBrowser] Basic authentication always fails.
2303         https://bugs.webkit.org/show_bug.cgi?id=194496
2304
2305         Reviewed by Don Olmstead.
2306
2307         * MiniBrowser/win/DialogHelper.h:
2308         (Dialog::getText):
2309
2310 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2311
2312         [GStreamer] GstMappedBuffer testsuite build fails
2313         https://bugs.webkit.org/show_bug.cgi?id=194495
2314
2315         Reviewed by Carlos Garcia Campos.
2316
2317         Fix the build by explicitely adding the gstreamer1.0-audio include
2318         directories to the include path.
2319
2320         * TestWebKitAPI/PlatformGTK.cmake:
2321         * TestWebKitAPI/PlatformWPE.cmake:
2322
2323 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2324
2325         [GTK][WPE] Add enable-javascript-markup setting
2326         https://bugs.webkit.org/show_bug.cgi?id=193439
2327
2328         Reviewed by Michael Catanzaro.
2329
2330         Add test cases to check the new setting.
2331
2332         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2333         (testWebKitSettings):
2334         (testWebKitSettingsJavaScriptMarkup):
2335         (beforeAll):
2336
2337 2019-02-10  Darin Adler  <darin@apple.com>
2338
2339         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2340         https://bugs.webkit.org/show_bug.cgi?id=194485
2341
2342         Reviewed by Daniel Bates.
2343
2344         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2345
2346 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2347
2348         Add more tests for clampTo<>()
2349         https://bugs.webkit.org/show_bug.cgi?id=194462
2350
2351         Reviewed by Geoffrey Garen.
2352
2353         Darin suggested to test the very last floating point number
2354         at the boundaries when truncating to integer.
2355         I added test for max/min and max-1/min-1.
2356
2357         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2358         (TestWebKitAPI::TEST):
2359
2360 2019-02-09  Darin Adler  <darin@apple.com>
2361
2362         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2363         https://bugs.webkit.org/show_bug.cgi?id=194021
2364
2365         Reviewed by Geoffrey Garen.
2366
2367         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2368         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2369         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2370
2371 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2372
2373         [LFC][IFC] Add intrinsic width support for basic inline containers
2374         https://bugs.webkit.org/show_bug.cgi?id=194473
2375
2376         Reviewed by Antti Koivisto.
2377
2378         Expand tests coverage (11 new tests -> 798)
2379
2380         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2381
2382 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2383
2384         Fix MiniBrowser's entitlements
2385         https://bugs.webkit.org/show_bug.cgi?id=192431
2386
2387         Reviewed by Joseph Pecoraro.
2388
2389         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2390         files, making it impossible to load any extension.
2391
2392         * MiniBrowser/MiniBrowser.entitlements:
2393
2394 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2395
2396         [Cocoa] Ask platform for generic font family mappings
2397         https://bugs.webkit.org/show_bug.cgi?id=187723
2398         <rdar://problem/41892438>
2399
2400         Reviewed by Brent Fulgham.
2401
2402         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2403
2404         * DumpRenderTree/mac/DumpRenderTree.mm:
2405         (allowedFontFamilySet):
2406         * WebKitTestRunner/mac/TestControllerMac.mm:
2407         (WTR::allowedFontFamilySet):
2408
2409 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2410
2411         [GTK] Implement back/forward touchpad gesture
2412         https://bugs.webkit.org/show_bug.cgi?id=193919
2413
2414         Reviewed by Michael Catanzaro.
2415
2416         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2417         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2418
2419 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2420
2421         Add SPI to use networking daemon instead of XPC service
2422         https://bugs.webkit.org/show_bug.cgi?id=194427
2423
2424         Reviewed by Geoffrey Garen
2425
2426         * MiniBrowser/MiniBrowser.entitlements:
2427
2428 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2429
2430         [ews-build] Ensure that every builder in config.json has short name
2431         https://bugs.webkit.org/show_bug.cgi?id=194461
2432
2433         Reviewed by Lucas Forschler.
2434
2435         * BuildSlaveSupport/ews-build/loadConfig.py:
2436         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2437
2438 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2439
2440         [ews-build] Add short name to config.json
2441         https://bugs.webkit.org/show_bug.cgi?id=194456
2442
2443         Reviewed by Lucas Forschler.
2444
2445         * BuildSlaveSupport/ews-build/config.json: Added short name.
2446         * BuildSlaveSupport/ews-build/loadConfig.py:
2447         (loadBuilderConfig): Set the short name as the builder description.
2448
2449 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2450
2451         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2452         https://bugs.webkit.org/show_bug.cgi?id=194418
2453
2454         Reviewed by Lucas Forschler.
2455
2456         Do not include errors trying when finding crashlogs at the end of
2457         a run-webkit-tests run since we don't process those errors.
2458
2459         * Scripts/webkitpy/port/darwin.py:
2460         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2461         * Scripts/webkitpy/port/ios_device.py:
2462         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2463         * Scripts/webkitpy/port/watch_device.py:
2464         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2465
2466 2019-02-08  Beth Dakin  <bdakin@apple.com>
2467
2468         Add afterScreenUpdates to WKSnapshotConfiguration
2469         https://bugs.webkit.org/show_bug.cgi?id=194362
2470         -and corresponding-
2471         <rdar://problem/40655528> Please add an "after screen updates" property to 
2472         WKSnapshotConfiguration (to solve blank snapshots)
2473
2474         Reviewed by Tim Horton.
2475
2476         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2477         (TEST):
2478
2479 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2480
2481         clampTo(): do not convert the input to double when dealing with integers
2482         https://bugs.webkit.org/show_bug.cgi?id=194263
2483         <rdar://problem/47692312>
2484
2485         Reviewed by Darin Adler.
2486
2487         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2488         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2489         (TestWebKitAPI::testClampFloatingPointToInteger):
2490         (TestWebKitAPI::testClampSameSignIntegers):
2491         (TestWebKitAPI::testClampUnsignedToSigned):
2492         (TestWebKitAPI::testClampSignedToUnsigned):
2493
2494 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2495
2496         webkitpy: Respect --dedicated-simulators flag
2497         https://bugs.webkit.org/show_bug.cgi?id=194416
2498         <rdar://problem/47894722>
2499
2500         Reviewed by Lucas Forschler.
2501
2502         * Scripts/webkitpy/port/device_port.py:
2503         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2504         available devices can be safely ignored.
2505
2506 2019-02-07  Keith Rollin  <krollin@apple.com>
2507
2508         Remove extra copy of 100x100-red.tga
2509         https://bugs.webkit.org/show_bug.cgi?id=194371
2510         <rdar://problem/47873465>
2511
2512         Reviewed by Said Abou-Hallawa.
2513
2514         In order to help it pass its tests, Bug 194190 added a second copy of
2515         the file 100x100-red.tga. However, it turns out that this additional
2516         file wasn't actually needed, and that that sole previous copy was
2517         sufficient. At the same time, this second copy -- which was copied to
2518         the same location in the build output as the first copy -- now caused
2519         XCBuild to complain because there were two production rules for the
2520         same output file. Address this by removing the newly-added extra copy.
2521
2522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2523         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2524
2525 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2526
2527         Deprecate WKBundlePageSetDefersLoading
2528         https://bugs.webkit.org/show_bug.cgi?id=191394
2529
2530         Reviewed by Dean Jackson.
2531
2532         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2533         (WTR::TestRunner::setDefersLoading):
2534
2535 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2536
2537         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2538         https://bugs.webkit.org/show_bug.cgi?id=194391
2539
2540         Reviewed by Antti Koivisto.
2541
2542         * LayoutReloaded/misc/LFC-passing-tests.txt:
2543
2544 2019-02-06  Keith Rollin  <krollin@apple.com>
2545
2546         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2547         https://bugs.webkit.org/show_bug.cgi?id=193975
2548         <rdar://problem/47643306>
2549
2550         Reviewed by Tim Horton.
2551
2552         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2553         the Info.plist file into the bundle. This step is not necessary as the
2554         implicit "bundle up all the build products into a framework" build
2555         phase does this already. Having the Copy Bundle Resources phase do
2556         this causes a conflict under XCBuild, which objects to two build
2557         phases producing the same file (Info.plist). Address this by removing
2558         Info.plist from the Copy Bundle Resources phase.
2559
2560         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2561
2562 2019-02-06  Keith Rollin  <krollin@apple.com>
2563
2564         Really enable the automatic checking and regenerations of .xcfilelists during builds
2565         https://bugs.webkit.org/show_bug.cgi?id=194357
2566         <rdar://problem/47861231>
2567
2568         Reviewed by Chris Dumez.
2569
2570         Bug 194124 was supposed to enable the automatic checking and
2571         regenerating of .xcfilelist files during the build. While related
2572         changes were included in that patch, the change to actually enable the
2573         operation somehow was omitted. This patch actually enables the
2574         operation. The check-xcfilelist.sh scripts now check
2575         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2576         from the checking.
2577
2578         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2579         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2580
2581 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2582
2583         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2584         <https://webkit.org/b/194286>
2585         <rdar://problem/47815558>
2586
2587         Reviewed by Alexey Proskuryakov.
2588
2589         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2590         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2591         WKRetainPtr<> to avoid leaking the WKDataRef.
2592
2593 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2594
2595         Unreviewed, fix a typo
2596
2597         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2598
2599 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2600
2601         [GTK][WPE] force libpsl build to use ICU in jhbuild
2602         https://bugs.webkit.org/show_bug.cgi?id=194288
2603
2604         Reviewed by Carlos Garcia Campos.
2605
2606         * gtk/jhbuild.modules:
2607         Require ICU for libpsl build in jhbuild, like done in WPE.
2608
2609 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2610
2611         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2612         https://bugs.webkit.org/show_bug.cgi?id=194209
2613
2614         Reviewed by Carlos Garcia Campos.
2615
2616         Enhance TestCookieManager to ensure this doesn't happen again.
2617
2618         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2619         (testCookieManagerPersistentStorage):
2620         (beforeAll):
2621
2622 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2623
2624         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2625         https://bugs.webkit.org/show_bug.cgi?id=194324
2626
2627         Reviewed by Andy Estes.
2628
2629         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2630         part of the name is already implicit, since this is in testing code in TestOptions.
2631
2632         * WebKitTestRunner/TestController.cpp:
2633         (WTR::TestController::generateContextConfiguration const):
2634         (WTR::updateTestOptionsFromTestHeader):
2635         * WebKitTestRunner/TestOptions.h:
2636         (WTR::TestOptions::hasSameInitializationOptions const):
2637
2638 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2639
2640         [ews-build] Allow * as platform for builders and workers
2641         https://bugs.webkit.org/show_bug.cgi?id=188533
2642
2643         Reviewed by Lucas Forschler.
2644
2645         * BuildSlaveSupport/ews-build/loadConfig.py:
2646         (checkWorkersAndBuildersForConsistency):
2647
2648 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2649
2650         [ews-build] Add few bots to config.json
2651         https://bugs.webkit.org/show_bug.cgi?id=194304
2652
2653         Reviewed by Lucas Forschler.
2654
2655         * BuildSlaveSupport/ews-build/config.json:
2656
2657 2019-02-05  Keith Rollin  <krollin@apple.com>
2658
2659         Enable the automatic checking and regenerations of .xcfilelists during builds
2660         https://bugs.webkit.org/show_bug.cgi?id=194124
2661         <rdar://problem/47721277>
2662
2663         Reviewed by Tim Horton.
2664
2665         Bug 193790 add a facility for checking -- during build time -- that
2666         any needed .xcfilelist files are up-to-date and for updating them if
2667         they are not. This facility was initially opt-in by setting
2668         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2669         the process seemed robust. Its now time to enable this facility and
2670         make it opt-out. If there is a need to disable this facility, set and
2671         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2672         running `make` or `build-webkit`, or before running Xcode from the
2673         command line.
2674
2675         Additionally, remove the step that generates a list of source files
2676         going into the UnifiedSources build step. It's only necessarily to
2677         specify Sources.txt and SourcesCocoa.txt as inputs.
2678
2679         * Scripts/generate-xcfilelists:
2680
2681 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2682
2683         [GTK][WPE] force libpsl build to use ICU in jhbuild
2684         https://bugs.webkit.org/show_bug.cgi?id=194288
2685
2686         Reviewed by Philippe Normand.
2687
2688         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2689         This can cause build failures if libidn is detected but libunistring is not available.
2690
2691         Make sure that ICU is used for runtime and builtin PSL data.
2692
2693         * gtk/jhbuild.modules:
2694         * wpe/jhbuild.modules:
2695
2696 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2697
2698         [ews-app] Modified timestamp should be updated on updating data
2699         https://bugs.webkit.org/show_bug.cgi?id=194295
2700
2701         Reviewed by Lucas Forschler.
2702
2703         * BuildSlaveSupport/ews-app/ews/models/build.py:
2704         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2705         * BuildSlaveSupport/ews-app/ews/models/step.py:
2706
2707 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2708
2709         Unreviewed, rolling out r240742.
2710
2711         Causes crashes on iOS simulator.
2712
2713         Reverted changeset:
2714
2715         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2716         not focused in a content-editable element"
2717         https://bugs.webkit.org/show_bug.cgi?id=192824
2718         https://trac.webkit.org/changeset/240742
2719
2720 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2721
2722         run-webkit-tests emits message "...running None" when running tests
2723         https://bugs.webkit.org/show_bug.cgi?id=194133
2724         <rdar://problem/47724738>
2725
2726         Reviewed by Lucas Forschler.
2727
2728         * Scripts/webkitpy/xcode/device_type.py:
2729         (DeviceType.__str__): Use both version mapping tables and use just the variant
2730         name if no version name is available.
2731         * Scripts/webkitpy/xcode/device_type_unittest.py:
2732         (DeviceTypeTest):
2733         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2734         an associated named.
2735
2736 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2737
2738         [WPE] require python3-setuptools for meson build in jhbuild
2739         https://bugs.webkit.org/show_bug.cgi?id=194287
2740
2741         Reviewed by Philippe Normand.
2742
2743         python3-setuptools is needed to build meson in jhbuild.
2744         It is already required by the GTK port.
2745
2746         * wpe/install-dependencies:
2747
2748 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2749
2750         [ews-app] Add method to save BuilderMapping to database
2751         https://bugs.webkit.org/show_bug.cgi?id=194264
2752
2753         Reviewed by Lucas Forschler.
2754
2755         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2756         (BuilderMapping.__str__):
2757         (BuilderMapping):
2758         (BuilderMapping.save_mapping):
2759         (BuilderMapping.update_mapping):
2760         (BuilderMapping.get_existing_mapping):
2761         (BuilderMapping.is_valid_mapping):
2762
2763 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2764
2765         [ews-app] Add timestamp fields for BuilderMappings
2766         https://bugs.webkit.org/show_bug.cgi?id=194266
2767
2768         Reviewed by Lucas Forschler.
2769
2770         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2771         (BuilderMapping):
2772
2773 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2774
2775         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2776         https://bugs.webkit.org/show_bug.cgi?id=174816
2777
2778         Reviewed by Michael Catanzaro.
2779
2780         Add tests for webkit_uri_for_display().
2781
2782         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2783         (testURIForDisplayUnaffected):
2784         (testURIForDisplayAffected):
2785         (beforeAll):
2786         (afterAll):
2787         * TestWebKitAPI/glib/CMakeLists.txt:
2788
2789 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2790
2791         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2792         https://bugs.webkit.org/show_bug.cgi?id=194158
2793         <rdar://problem/47737268>
2794
2795         Rubber-stamped by Aakash Jain.
2796
2797         * Scripts/webkitpy/port/device_port.py:
2798         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2799
2800 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2801
2802         [CG] Enable setAdditionalSupportedImageTypes for WK1
2803         https://bugs.webkit.org/show_bug.cgi?id=194190
2804
2805         Reviewed by Tim Horton.
2806
2807         Add a test similar to the one under WebKit Cocoa but make it create a
2808         WebView instead of a WKWebView.
2809
2810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2811         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2812         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2813         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2814         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2815         (TestWebKitAPI::runTest):
2816         (TestWebKitAPI::TEST):
2817
2818 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2819
2820         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2821         https://bugs.webkit.org/show_bug.cgi?id=194168
2822
2823         Reviewed by Simon Fraser.
2824
2825         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2826
2827         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2828         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2829         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2830         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2831         (TEST):
2832         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2833         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2834
2835 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2836
2837         REGRESSION (r237269): webkit-patch what-broke is broken 
2838         https://bugs.webkit.org/show_bug.cgi?id=193025
2839
2840         Reviewed by Aakash Jain.
2841
2842         * Scripts/webkitpy/common/host.py:
2843         (Host.buildbot):
2844         (Host.bugzilla): Renamed to 'buildbot'.
2845
2846 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2847
2848         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2849         https://bugs.webkit.org/show_bug.cgi?id=194207
2850
2851         Reviewed by Tim Horton.
2852
2853         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2854         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2855         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2856         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2857         start and delete forwards to remove the original attachment.
2858
2859         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2860         (TestWebKitAPI::TEST):
2861
2862 2019-02-04  Youenn Fablet  <youenn@apple.com>
2863
2864         Capture state should be managed consistently when doing process swapping
2865         https://bugs.webkit.org/show_bug.cgi?id=194122
2866         <rdar://problem/47609293>
2867
2868         Reviewed by Eric Carlson.
2869
2870         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2871         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2872         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2873         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2874         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2875         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2876         (WTR::TestRunner::isDoingMediaCapture const):
2877         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2878         * WebKitTestRunner/TestController.cpp:
2879         (WTR::TestController::isDoingMediaCapture const):
2880         * WebKitTestRunner/TestController.h:
2881         * WebKitTestRunner/TestInvocation.cpp:
2882         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2883         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2884         (WTR::TestController::isDoingMediaCapture const):
2885
2886 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2887
2888         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2889         https://bugs.webkit.org/show_bug.cgi?id=194142
2890
2891         Reviewed by Ross Kirsling.
2892
2893         There three 'separator' variables in TestController.cpp. Renamed
2894         it 'pathSeparator', and unified them.
2895
2896         * WebKitTestRunner/TestController.cpp:
2897         (WTR::TestController::generateContextConfiguration const):
2898         (WTR::createTestURL):
2899         (WTR::TestController::platformAdjustContext):
2900
2901 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2902
2903         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2904         https://bugs.webkit.org/show_bug.cgi?id=194198
2905
2906         Reviewed by Antti Koivisto.
2907
2908         No need to set the banner heights on navigation now, since Page stores them.
2909
2910         * MiniBrowser/mac/WK2BrowserWindowController.m:
2911         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2912
2913 2019-02-03  John Wilander  <wilander@apple.com>
2914
2915         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2916         https://bugs.webkit.org/show_bug.cgi?id=194104
2917         <rdar://problem/47649991>
2918
2919         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2920
2921         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2922         (TestWebKitAPI::TEST):
2923             Changed numeric types from unsigned short to uint32_t.
2924
2925 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2926
2927         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2928         <https://webkit.org/b/194178>
2929         <rdar://problem/47753473>
2930
2931         Reviewed by Alexey Proskuryakov.
2932
2933         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2934         (WTR::uninstallFakeHelvetica): Pass nullptr into
2935         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2936
2937 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2938
2939         [LFC] Initialize ICB's style with fixed width/height.
2940         https://bugs.webkit.org/show_bug.cgi?id=194188
2941
2942         Reviewed by Antti Koivisto.
2943
2944         * LayoutReloaded/misc/LFC-passing-tests.txt:
2945
2946 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2947
2948         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2949         https://bugs.webkit.org/show_bug.cgi?id=194185
2950
2951         Reviewed by Antti Koivisto.
2952
2953         * LayoutReloaded/misc/LFC-passing-tests.txt:
2954
2955 2018-12-16  Darin Adler  <darin@apple.com>
2956
2957         Convert additional String::format clients to alternative approaches
2958         https://bugs.webkit.org/show_bug.cgi?id=192746
2959
2960         Reviewed by Alexey Proskuryakov.
2961
2962         * WebKitTestRunner/TestController.cpp:
2963         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2964         as an intermediate in code that ultimately constructs a WTF::String.
2965         (WTR::userMediaOriginHash): Use makeString.
2966         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2967         (WTR::TestController::didPerformClientRedirect): Ditto.
2968         (WTR::TestController::didPerformServerRedirect): Ditto.
2969         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2970
2971 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2972
2973         [ews-build] Add unit test to verify builder keys
2974         https://bugs.webkit.org/show_bug.cgi?id=194152
2975
2976         Reviewed by Lucas Forschler.
2977
2978         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2979         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2980
2981 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2982
2983         [LFC] Expand tests coverage (12 new tests -> 787)
2984
2985         Unreviewed test gardening.
2986
2987         * LayoutReloaded/misc/LFC-passing-tests.txt:
2988
2989 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2990
2991         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2992         https://bugs.webkit.org/show_bug.cgi?id=194163
2993
2994         Reviewed by Simon Fraser.
2995
2996         775
2997
2998         * LayoutReloaded/misc/LFC-passing-tests.txt:
2999
3000 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3001
3002         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3003         https://bugs.webkit.org/show_bug.cgi?id=194140
3004         <rdar://problem/47728098>
3005
3006         Reviewed by Tim Horton.
3007
3008         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3009         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3010         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3011
3012         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3013         test to induce an IPC deadlock when presenting a modal alert during touch start.
3014
3015         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3016         * WebKitTestRunner/TestController.cpp:
3017         (WTR::runJavaScriptAlert):
3018
3019         Add a client callback function for running JavaScript alerts.
3020
3021         (WTR::TestController::createOtherPage):
3022         (WTR::TestController::generateContextConfiguration const):
3023
3024         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3025         the fix in this patch.
3026
3027         (WTR::TestController::createWebViewWithOptions):
3028
3029         Plumb TestOptions to generateContextConfiguration.
3030
3031         (WTR::TestController::resetPreferencesToConsistentValues):
3032         (WTR::TestController::resetStateToConsistentValues):
3033         (WTR::updateTestOptionsFromTestHeader):
3034         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3035         (WTR::TestController::handleJavaScriptAlert):
3036         * WebKitTestRunner/TestController.h:
3037         * WebKitTestRunner/TestInvocation.cpp:
3038         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3039         * WebKitTestRunner/TestOptions.h:
3040         (WTR::TestOptions::hasSameInitializationOptions const):
3041
3042 2019-02-01  Chris Dumez  <cdumez@apple.com>
3043
3044         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3045         https://bugs.webkit.org/show_bug.cgi?id=193740
3046         <rdar://problem/47527267>
3047
3048         Reviewed by Alex Christensen.
3049
3050         Add API test coverage.
3051
3052         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3053
3054 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3055
3056         [ews-app] Add display name field to BuilderMapping model
3057         https://bugs.webkit.org/show_bug.cgi?id=194153
3058
3059         Reviewed by Lucas Forschler.
3060
3061         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3062         (BuilderMapping):
3063
3064 2019-02-01  Youenn Fablet  <youenn@apple.com>
3065
3066         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3067         https://bugs.webkit.org/show_bug.cgi?id=194155
3068
3069         Reviewed by Eric Carlson.
3070
3071         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3072         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3073         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3074
3075 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3076
3077         [LFC] Adjust replaced element's intrinsic ratio
3078         https://bugs.webkit.org/show_bug.cgi?id=194154
3079
3080         Reviewed by Antti Koivisto.
3081
3082         761
3083
3084         * LayoutReloaded/misc/LFC-passing-tests.txt:
3085
3086 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3087
3088         [WPE] Show test results in minibrowser
3089         https://bugs.webkit.org/show_bug.cgi?id=194150
3090
3091         Reviewed by Žan Doberšek.
3092
3093         * Scripts/webkitpy/port/wpe.py:
3094         (WPEPort.show_results_html_file):
3095
3096 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3097
3098         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3099         https://bugs.webkit.org/show_bug.cgi?id=194151
3100
3101         Reviewed by Žan Doberšek.
3102
3103         ALT + <- go back
3104         ALT + -> go forward
3105
3106         * MiniBrowser/wpe/main.cpp:
3107         (main):
3108
3109 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3110
3111         [LFC] Set intrinsic size on Layout::Replaced
3112         https://bugs.webkit.org/show_bug.cgi?id=194139
3113
3114         Reviewed by Antti Koivisto.
3115
3116         744
3117
3118         * LayoutReloaded/misc/LFC-passing-tests.txt:
3119
3120 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3121
3122         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3123         https://bugs.webkit.org/show_bug.cgi?id=194146
3124
3125         Reviewed by Xabier Rodriguez-Calvar.
3126
3127         It allows to open relative paths.
3128
3129         * MiniBrowser/wpe/main.cpp:
3130         (main):
3131
3132 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3133
3134         Update flakiness dashboard configuration after recent queue changes
3135         https://bugs.webkit.org/show_bug.cgi?id=194127
3136
3137         Rubber-stamped by Aakash Jain.
3138
3139         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3140
3141         * TestResultServer/static-dashboards/builders.jsonp:
3142
3143 2019-01-31  Youenn Fablet  <youenn@apple.com>
3144
3145         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3146         https://bugs.webkit.org/show_bug.cgi?id=194106
3147         <rdar://problem/47676333>
3148
3149         Reviewed by Ryosuke Niwa.
3150
3151         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3152         (TestWebKitAPI::didFinishNavigation):
3153         (TestWebKitAPI::TEST):
3154         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3155
3156 2019-01-31  Chris Dumez  <cdumez@apple.com>
3157
3158         Page zoom level is lost after a process swap or a crash
3159         https://bugs.webkit.org/show_bug.cgi?id=194105
3160         <rdar://problem/47610781>
3161
3162         Reviewed by Alex Christensen.
3163
3164         Add API test coverage.
3165
3166         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3167         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3168
3169 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3170
3171         Revert r238819 which is unneeded and caused a performance regression.
3172         https://bugs.webkit.org/show_bug.cgi?id=192272
3173         <rdar://problem/46664625>
3174
3175         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3176         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3177         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3178
3179 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3180
3181         Formalize WebKitAdditions mechanism of LoadOptimizer
3182         https://bugs.webkit.org/show_bug.cgi?id=193886
3183         <rdar://problem/47696809>
3184
3185         Reviewed by Brent Fulgham.
3186
3187         * MiniBrowser/MiniBrowser.entitlements:
3188         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3189
3190 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3191
3192         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3193         https://bugs.webkit.org/show_bug.cgi?id=194090
3194
3195         Reviewed by Antti Koivisto.
3196
3197         * LayoutReloaded/misc/LFC-passing-tests.txt:
3198
3199 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3200
3201         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3202         https://bugs.webkit.org/show_bug.cgi?id=194074
3203
3204         Reviewed by Antti Koivisto.
3205
3206         * LayoutReloaded/misc/LFC-passing-tests.txt:
3207
3208 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3209
3210         [LFC][BFC] Add support for block level replaced box.
3211         https://bugs.webkit.org/show_bug.cgi?id=194071
3212
3213         Reviewed by Antti Koivisto.
3214
3215         * LayoutReloaded/misc/LFC-passing-tests.txt:
3216
3217 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3218
3219         Fix WebKitTestRunner's testPath with Windows full paths
3220         https://bugs.webkit.org/show_bug.cgi?id=194012
3221
3222         Reviewed by Alex Christensen.
3223
3224         updateTestOptionsFromTestHeader failed to open test files because
3225         testPath returned wrong file paths. It returned a path "/C:/..."
3226         if a URL "file:///C:/..." was given.
3227
3228         * WebKitTestRunner/TestController.cpp:
3229         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3230
3231 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3232
3233         [WPE] Bump font related dependencies to match the GTK+ port
3234         https://bugs.webkit.org/show_bug.cgi?id=194017
3235
3236         Reviewed by Žan Doberšek.
3237
3238         * wpe/jhbuild.modules:
3239         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3240         * wpe/patches/icudata-stdlibs.patch: Added.
3241
3242 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3243
3244         Enable swipe tests on iOS
3245         https://bugs.webkit.org/show_bug.cgi?id=194076
3246
3247         Reviewed by Geoffrey Garen.
3248
3249         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3250         it causes a debug assertion failure in runUIScript.
3251
3252         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3253         (WTR::UIScriptController::beginBackSwipe):
3254         (WTR::UIScriptController::completeBackSwipe):
3255
3256 2019-01-30  Keith Rollin  <krollin@apple.com>
3257
3258         Use correct printf format specifier
3259         https://bugs.webkit.org/show_bug.cgi?id=194062
3260         <rdar://problem/47686167>
3261
3262         Reviewed by Alexey Proskuryakov.
3263
3264         LayoutTestSpellChecker.mm is trying to format a variable of type
3265         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3266         actually an unsigned long long. Fix this by formatting with %llu.
3267
3268         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3269         (-[LayoutTestTextCheckingResult description]):
3270
3271 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3272
3273         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3274         https://bugs.webkit.org/show_bug.cgi?id=193979
3275
3276         Reviewed by Wenson Hsieh.
3277
3278         Fix the test for iOS. Make the test work with iOS UA string.
3279
3280         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3281
3282 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3283
3284         Replace High Sierra LLINT CLoop bot due to hardware failure
3285         https://bugs.webkit.org/show_bug.cgi?id=194066
3286
3287         Reviewed by Aakash Jain.
3288
3289         * BuildSlaveSupport/build.webkit.org-config/config.json:
3290
3291 2019-01-30  Keith Rollin  <krollin@apple.com>
3292
3293         [NSDragItem init] is unavailable
3294         https://bugs.webkit.org/show_bug.cgi?id=194059
3295         <rdar://problem/47685715>
3296
3297         Reviewed by Wenson Hsieh.
3298
3299         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3300         DumpRenderTree and TestWebKitAPI, which both try to create an
3301         NSDragItem in a manner that invokes this method. Address this by using
3302         -initWithPasteboardWriter instead.
3303
3304         Note that the parameter passed to initWithPasteboardWriter is likely
3305         incorrect. In both cases, the object passed does not conform to
3306         NSPasteboardWriting. However, with this fix, we're no worse off than
3307         before, and can now perform builds with newer compilers and SDKs until
3308         a real fix can be crafted. That work is tracked in
3309         https://bugs.webkit.org/show_bug.cgi?id=194060
3310
3311         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3312         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3313         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3314         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3315
3316 2019-01-30  Daniel Bates  <dabates@apple.com>
3317
3318         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3319         https://bugs.webkit.org/show_bug.cgi?id=192824
3320         <rdar://problem/47100332>
3321
3322         Reviewed by Wenson Hsieh.
3323
3324         Fix a bug where the wrong usage code was used for F13 thru F24.
3325
3326         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3327         (keyCodeForDOMFunctionKey):
3328
3329 2019-01-30  Chris Dumez  <cdumez@apple.com>
3330
3331         Regression(PSON) Load hang can occur on history navigation
3332         https://bugs.webkit.org/show_bug.cgi?id=194030
3333         <rdar://problem/47656939>
3334
3335         Reviewed by Antti Koivisto.
3336
3337         Add API test coverage.
3338
3339         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3340
3341 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3342
3343         [LFC] Expand tests coverage.
3344
3345         Unreviewed test gardening.
3346
3347         * LayoutReloaded/misc/LFC-passing-tests.txt:
3348
3349 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3350
3351         [Flatpak] Add openjpeg support
3352         https://bugs.webkit.org/show_bug.cgi?id=194019
3353
3354         Reviewed by Michael Catanzaro.
3355
3356         * flatpak/org.webkit.CommonModules.yaml:
3357
3358 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3359
3360         Unreviewed, rolling out r240708.
3361         https://bugs.webkit.org/show_bug.cgi?id=194022
3362
3363         It broke WPE build (Requested by KaL on #webkit).
3364
3365         Reverted changeset:
3366
3367         "[WPE] Bump font related dependencies to match the GTK+ port"
3368         https://bugs.webkit.org/show_bug.cgi?id=194017
3369         https://trac.webkit.org/changeset/240708
3370
3371 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3372
3373         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3374         https://bugs.webkit.org/show_bug.cgi?id=194001
3375
3376         Reviewed by Antti Koivisto.
3377
3378         * LayoutReloaded/misc/LFC-passing-tests.txt:
3379
3380 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3381
3382         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3383         https://bugs.webkit.org/show_bug.cgi?id=194020
3384
3385         Reviewed by Antti Koivisto.
3386
3387         * LayoutReloaded/misc/LFC-passing-tests.txt:
3388
3389 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3390
3391         AX: Support color well on iOS
3392         https://bugs.webkit.org/show_bug.cgi?id=194010
3393
3394         Reviewed by Joanmarie Diggs.
3395
3396         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3397         (WTR::AccessibilityUIElement::stringAttributeValue):
3398
3399 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3400
3401         [WPE] Bump font related dependencies to match the GTK+ port
3402         https://bugs.webkit.org/show_bug.cgi?id=194017
3403
3404         Reviewed by Žan Doberšek.
3405
3406         * wpe/jhbuild.modules:
3407         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3408         * wpe/patches/icudata-stdlibs.patch: Added.
3409
3410 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3411
3412         [Mac] Update window scale API usage
3413         https://bugs.webkit.org/show_bug.cgi?id=193991
3414         rdar://problem/47614795
3415
3416         Reviewed by Tim Horton.
3417
3418         * DumpRenderTree/mac/DumpRenderTree.mm:
3419         (changeWindowScaleIfNeeded):
3420         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3421         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3422         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3423
3424 2019-01-29  Chris Dumez  <cdumez@apple.com>
3425
3426         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3427         https://bugs.webkit.org/show_bug.cgi?id=193977
3428         <rdar://problem/47643716>
3429
3430         Reviewed by Geoff Garen.
3431
3432         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3433         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3434         to the previous provisional committing *before* we make the last load. 
3435
3436         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3437
3438 2019-01-29  Youenn Fablet  <youenn@apple.com>
3439
3440         Adopt new SPI to evaluate server certificate trust
3441         https://bugs.webkit.org/show_bug.cgi?id=193355
3442
3443         Reviewed by Alex Christensen.
3444
3445         Add infrastructure to handle HTTPS server trust evaluation testing.
3446
3447         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3448         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3449         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3450         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3451         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3452         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3453         * WebKitTestRunner/TestController.cpp:
3454         (WTR::TestController::resetPreferencesToConsistentValues):
3455         (WTR::TestController::didReceiveAuthenticationChallenge):
3456         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3457         * WebKitTestRunner/TestController.h:
3458         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3459         * WebKitTestRunner/TestInvocation.cpp:
3460         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3461         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3462         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3463
3464 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3465
3466         [ews-build] Add build step to print bot Configuration
3467         https://bugs.webkit.org/show_bug.cgi?id=193887
3468
3469         Reviewed by Lucas Forschler.
3470
3471         * BuildSlaveSupport/ews-build/steps.py:
3472         (PrintConfiguration): Build step to print configuration.
3473         * BuildSlaveSupport/ews-build/factories.py:
3474
3475 2019-01-29  Chris Dumez  <cdumez@apple.com>
3476
3477         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3478         https://bugs.webkit.org/show_bug.cgi?id=193967
3479         <rdar://problem/47635348>
3480
3481         Reviewed by Alex Christensen.
3482
3483         Add API test coverage.
3484
3485         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3486         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3487
3488 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3489
3490         [ews-app] Handle incoming results data
3491         https://bugs.webkit.org/show_bug.cgi?id=193973
3492
3493         Reviewed by Lucas Forschler.
3494
3495         * BuildSlaveSupport/ews-app/ews/views/results.py:
3496
3497 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3498
3499         [ews-app] Make the results url generic
3500         https://bugs.webkit.org/show_bug.cgi?id=193928
3501
3502         Reviewed by Lucas Forschler.
3503
3504         * BuildSlaveSupport/ews-app/ews/urls.py:
3505
3506 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3507
3508         [ews-build] Configure buildbot to send events to ews-app
3509         https://bugs.webkit.org/show_bug.cgi?id=193968
3510
3511         Reviewed by Lucas Forschler.
3512
3513         * BuildSlaveSupport/ews-build/events.py: Added.
3514         * BuildSlaveSupport/ews-build/master.cfg:
3515
3516 2019-01-29  Keith Rollin  <krollin@apple.com>
3517
3518         Add .xcfilelists to Run Script build phases
3519         https://bugs.webkit.org/show_bug.cgi?id=193792
3520         <rdar://problem/47201785>
3521
3522         Reviewed by Alex Christensen.
3523
3524         As part of supporting XCBuild, update the necessary Run Script build
3525         phases in their Xcode projects to refer to their associated
3526         .xcfilelist files.
3527
3528         Note that the addition of these files bumps the Xcode project version
3529         number to something that's Xcode 10 compatible. This change means that
3530         older versions of the Xcode IDE can't read these projects. Nor can it
3531         fully load workspaces that refer to these projects (the updated
3532         projects are shown as non-expandable placeholders). `xcodebuild` can
3533         still build these projects; it's just that the IDE can't open them.
3534
3535         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3536         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3537
3538 2019-01-29  John Wilander  <wilander@apple.com>
3539
3540         Add data abstraction and validation for Ad Click Attribution
3541         https://bugs.webkit.org/show_bug.cgi?id=193916
3542         <rdar://problem/47603481>
3543
3544         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3545
3546         Ad click attribution has two steps. First, the storage of an ad
3547         campaign ID for a click that takes the user to a destination
3548         site. Second, a conversion on the destination site that can be
3549         attributed to the ad click.
3550
3551         This patch adds a class that represents a request for ad click
3552         attribution. Validation makes sure that the bits of entropy
3553         reported through this mechanism is limited.
3554
3555         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3556         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3557         (TestWebKitAPI::TEST):
3558
3559 2019-01-29  Chris Dumez  <cdumez@apple.com>
3560
3561         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3562         https://bugs.webkit.org/show_bug.cgi?id=193932
3563         <rdar://problem/47598947>
3564
3565         Reviewed by Brady Eidson.
3566
3567         Add API test coverage.
3568
3569         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3570
3571 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3572
3573         Adding new passing LFC tests.
3574
3575         Unreviewed test gardening.
3576
3577         * LayoutReloaded/misc/LFC-passing-tests.txt:
3578
3579 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3580
3581         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3582         https://bugs.webkit.org/show_bug.cgi?id=193964
3583
3584         Reviewed by Antti Koivisto.
3585
3586         * LayoutReloaded/misc/LFC-passing-tests.txt:
3587
3588 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3589
3590         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3591         https://bugs.webkit.org/show_bug.cgi?id=193954
3592
3593         Reviewed by Antti Koivisto.
3594
3595         * LayoutReloaded/misc/LFC-passing-tests.txt:
3596
3597 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3598
3599         WebDriver: add support for running subtests
3600         https://bugs.webkit.org/show_bug.cgi?id=193904
3601
3602         Reviewed by Michael Catanzaro.
3603
3604         pytest already supports it by passing test.py::subtest, so we can do the same.
3605
3606         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3607         (get_item_name): Made this global.
3608         (CollectRecorder.__init__): Receive the parameter to ignore.
3609         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3610         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3611         (collect): Add parameter to ignore.
3612         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3613         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3614         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3615         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3616         (WebDriverTestRunnerSelenium.run): Ditto.
3617         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3618         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3619         (WebDriverTestRunnerW3C.run): Ditto.
3620
3621 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3622
3623         User agent string override for navigator.userAgent should be site specific quirks
3624         https://bugs.webkit.org/show_bug.cgi?id=193950
3625
3626         Reviewed by Brent Fulgham.
3627
3628         Updated per the _WKWebsitePolicies rename.
3629
3630         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3631         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3632
3633 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3634
3635         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3636         https://bugs.webkit.org/show_bug.cgi?id=193941
3637
3638         Reviewed by Alex Christensen.
3639
3640         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3641         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3642         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3643         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3644         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3645         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3646         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3647         * TestWebKitAPI/Tests/WTF/Time.cpp:
3648         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3649         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3650         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3651         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3652
3653 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3654
3655         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3656
3657         * Scripts/webkitpy/common/config/contributors.json:
3658
3659 2019-01-28  Andy Estes  <aestes@apple.com>
3660
3661         [watchOS] Enable Parental Controls content filtering
3662         https://bugs.webkit.org/show_bug.cgi?id=193939
3663         <rdar://problem/46641912>
3664
3665         Reviewed by Ryosuke Niwa.
3666
3667         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3668
3669 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3670
3671         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3672         <https://webkit.org/b/193884>
3673
3674         Reviewed by Jiewen Tan.
3675
3676         * Scripts/webkitpy/style/checkers/cpp.py:
3677         (check_language): Add LocalAuthentication to
3678         `frameworks_with_soft_links`.
3679
3680 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3681
3682         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3683         https://bugs.webkit.org/show_bug.cgi?id=193891
3684
3685         Reviewed by Ross Kirsling.
3686
3687         There were three problems in window sizes of WebView and the host window.
3688         1. The sizes of pixel image output were incorrect.
3689         2. The host window is going to appear after window.resize was invoked.
3690         3. window.resize resized only the host window, not WebView.
3691
3692         This change solves them with a following approach.
3693         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3694         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3695            as well as DumpRenderTree in order to match the client area and the window area.
3696         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3697         d. PlatformWebView::setWindowFrame changes both window sizes.
3698         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3699
3700         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3701         (WTR::PlatformWebView::PlatformWebView): Create the host window
3702         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3703         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3704         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3705
3706 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3707
3708         [ews-app] Add method to save Step data to database
3709         https://bugs.webkit.org/show_bug.cgi?id=193890
3710
3711         Reviewed by Lucas Forschler.
3712
3713         * BuildSlaveSupport/ews-app/ews/models/step.py:
3714         (Step.save_step): Method to save step data.
3715         (Step.update_step): Method to update step data.
3716         (Step.get_existing_step): Method to fetch existing step from database.
3717         (Step.is_valid_result): Method to validate valid step result.
3718
3719 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3720
3721         [ews-app] Add method to save Build data to database
3722         https://bugs.webkit.org/show_bug.cgi?id=193735
3723
3724         Reviewed by Lucas Forschler.
3725
3726         * BuildSlaveSupport/ews-app/ews/models/build.py:
3727         (Build.save_build): Method to save build information to database.
3728         (Build.get_existing_build): Method to fetch existing build from database.
3729         (Build.is_valid_result): Method to validate build result.
3730         * BuildSlaveSupport/ews-app/ews/common/util.py:
3731         (is_valid_int_id): Method to validate valid id.
3732
3733 2019-01-28  Chris Dumez  <cdumez@apple.com>
3734
3735         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3736         https://bugs.webkit.org/show_bug.cgi?id=193915
3737         <rdar://problem/47560907>
3738
3739         Reviewed by Alex Christensen.
3740
3741         Add API test coverage.
3742
3743         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3744
3745 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3746
3747         [ews-app] Rename id variables
3748         https://bugs.webkit.org/show_bug.cgi?id=193883
3749
3750         Reviewed by Lucas Forschler.
3751
3752         * BuildSlaveSupport/ews-app/ews/models/build.py:
3753         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3754         * BuildSlaveSupport/ews-app/ews/models/step.py:
3755         * BuildSlaveSupport/ews-app/ews/urls.py:
3756         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3757         * BuildSlaveSupport/ews-app/ews/views/results.py:
3758         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3759
3760 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3761
3762         [ews-app] Allow certain fields to be empty
3763         https://bugs.webkit.org/show_bug.cgi?id=193892
3764
3765         Reviewed by Lucas Forschler.
3766
3767         * BuildSlaveSupport/ews-app/ews/models/build.py:
3768         * BuildSlaveSupport/ews-app/ews/models/step.py:
3769
3770 2019-01-28  Rob Buis  <rbuis@igalia.com>
3771
3772         Update MIME type parser
3773         https://bugs.webkit.org/show_bug.cgi?id=180526
3774
3775         Reviewed by Frédéric Wang.
3776
3777         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3778         (TestWebKitAPI::TEST):
3779
3780 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3781
3782         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3783         https://bugs.webkit.org/show_bug.cgi?id=193896
3784
3785         Reviewed by Antti Koivisto.
3786
3787         * LayoutReloaded/misc/LFC-passing-tests.txt:
3788
3789 2018-12-15  Darin Adler  <darin@apple.com>
3790
3791         Replace many uses of String::format with more type-safe alternatives
3792         https://bugs.webkit.org/show_bug.cgi?id=192742
3793
3794         Reviewed by Mark Lam.
3795
3796         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3797         (WTR::cacheTestRunnerCallback): Use makeString.
3798         * WebKitTestRunner/TestController.cpp:
3799         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3800         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3801
3802 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3803
3804         Use a load optimizer for some sites
3805         https://bugs.webkit.org/show_bug.cgi?id=193881
3806         <rdar://problem/46325455>
3807
3808         Reviewed by Brent Fulgham.
3809
3810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3811         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3812
3813 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3814
3815         AX: Introduce a static accessibility tree
3816         https://bugs.webkit.org/show_bug.cgi?id=193348
3817         <rdar://problem/47203295>
3818
3819         Reviewed by Ryosuke Niwa.
3820
3821         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3822
3823 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3824
3825         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3826         https://bugs.webkit.org/show_bug.cgi?id=193867
3827
3828         Reviewed by Antti Koivisto.
3829
3830         * LayoutReloaded/misc/LFC-passing-tests.txt:
3831
3832 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3833
3834         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3835         https://bugs.webkit.org/show_bug.cgi?id=193865
3836
3837         Reviewed by Antti Koivisto.
3838
3839         * LayoutReloaded/misc/LFC-passing-tests.txt:
3840
3841 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3842
3843         Need a mechanism to override navigator.userAgent
3844         https://bugs.webkit.org/show_bug.cgi?id=193762
3845         <rdar://problem/47504939>
3846
3847         Reviewed by Brent Fulgham.
3848
3849         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3850
3851         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3852         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3853         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3854
3855 2019-01-25  Dean Jackson  <dino@apple.com>
3856
3857         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3858         https://bugs.webkit.org/show_bug.cgi?id=193831
3859         <rdar://problem/47399263>
3860
3861         Reviewed by Chris Dumez.
3862
3863         Two new tests that exercise cross-origin and same-origin System
3864         Previews.
3865
3866         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3867
3868 2019-01-25  Keith Rollin  <krollin@apple.com>
3869
3870         Update Xcode projects with "Check .xcfilelists" build phase
3871         https://bugs.webkit.org/show_bug.cgi?id=193790
3872         <rdar://problem/47201374>
3873
3874         Reviewed by Alex Christensen.
3875
3876         Support for XCBuild includes specifying inputs and outputs to various
3877         Run Script build phases. These inputs and outputs are specified as
3878         .xcfilelist files. Once created, these .xcfilelist files need to be
3879         kept up-to-date. In order to check that they are up-to-date or not,
3880         add an Xcode build step that invokes an external script that performs
3881         the checking. If the .xcfilelists are found to be out-of-date, update
3882         them, halt the build, and instruct the developer to restart the build
3883         with up-to-date files.
3884
3885         At this time, the checking and regenerating is performed only if the
3886         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3887         who want to use this facility can set this variable and test out the
3888         checking/regenerating. Once it seems like there are no egregious
3889         issues that upset a developer's workflow, we'll unconditionally enable
3890         this facility.
3891
3892         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3893         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3894         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3895         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3896
3897 2019-01-25  Keith Rollin  <krollin@apple.com>
3898
3899         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3900         https://bugs.webkit.org/show_bug.cgi?id=193781
3901         <rdar://problem/47201153>
3902
3903         Reviewed by Alex Christensen.
3904
3905         Part of generating the .xcfilelists used as part of adopting XCBuild
3906         includes running `make DerivedSources.make` from a standalone script.
3907         It’s important for this invocation to have the same environment as
3908         when the actual build invokes `make DerivedSources.make`. If the
3909         environments are different, then the two invocations will provide
3910         different results. In order to get the same environment in the
3911         standalone script, have the script launch xcodebuild targeting the
3912         "Apply Configuration to XCFileLists" build target, which will then
3913         re-invoke our standalone script. The script is now running again, this
3914         time in an environment with all workspace, project, target, xcconfig
3915         and other environment variables established.
3916
3917         The "Apply Configuration to XCFileLists" build target accomplishes
3918         this task via a small embedded shell script that consists only of:
3919
3920             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3921
3922         The process that invokes "Apply Configuration to XCFileLists" first
3923         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3924         evaluated and exports it into the shell environment. When xcodebuild
3925         is invoked, it inherits the value of this variable and can `eval` the
3926         contents of that variable. Our external standalone script can then set
3927         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3928         of command-line parameters needed to restart itself in the appropriate
3929         state.
3930
3931         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3932         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3933
3934 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3935
3936         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3937         https://bugs.webkit.org/show_bug.cgi?id=193802
3938         <rdar://problem/46010580>
3939
3940         Reviewed by Andy Estes.
3941
3942         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3943         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3944         (TEST):
3945
3946 2019-01-25  Daniel Bates  <dabates@apple.com>
3947
3948         [iOS] uiController.keyDown() does not translate Control modified key
3949         https://bugs.webkit.org/show_bug.cgi?id=192898
3950
3951         Reviewed by Wenson Hsieh.
3952
3953         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3954         key translation, as applicable. Among other cases, key translation occurs when performing
3955         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3956         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3957         human pressing down and releasing key(s) using a hardware keyboard.
3958
3959         * WebKitTestRunner/ios/HIDEventGenerator.h:
3960         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3961         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3962
3963         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3964         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3965         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3966         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3967         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3968         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3969         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3970         (-[HIDEventGenerator longPress:completionBlock:]):
3971         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3972         Update code for above renaming.
3973
3974         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3975         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3976
3977         (-[HIDEventGenerator keyDown:]): Added.
3978         (-[HIDEventGenerator keyUp:]): Added.
3979         (-[HIDEventGenerator keyPress:completionBlock:]):
3980         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3981         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3982         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3983         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3984         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3985         (WTR::parseModifier): Deleted.
3986
3987 2019-01-25  Keith Rollin  <krollin@apple.com>
3988
3989         Complete the implementation of generate-xcfilelists
3990         https://bugs.webkit.org/show_bug.cgi?id=193782
3991
3992         Reviewed by Alex Christensen.
3993
3994         A preliminary version of generate-xcfilelists was added in r238008.
3995         This patch updates that script in order to:
3996
3997         - Support checking of .xcfilelists
3998         - Perform better execution of `make DerivedSources.make` by
3999           relaunching generate-xcfilelists under xcodebuild
4000         - Support incremental generation and checking of .xcfilelists
4001         - Support supplementary .xcfilelists files from WebKitAdditions
4002         - Support being wrapped by parallel version of generate-xcfilelists in
4003           Internal that adds support for (re)generating WebKit projects in
4004           that repo.
4005         - Support builds that have been performed in WebKitBuild as well as
4006           ~/Library/Developer/code/DerivedData
4007         - Increase robustness and debugging facilities.
4008
4009         * Scripts/generate-xcfilelists:
4010
4011 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
4012
4013         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4014         https://bugs.webkit.org/show_bug.cgi?id=193297
4015         <rdar://problem/47158841>
4016
4017         Unreviewed test case fix.
4018
4019         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
4020         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
4021
4022         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
4023         (TEST):
4024
4025 2019-01-25  Keith Rollin  <krollin@apple.com>
4026
4027         Update existing .xcfilelists
4028         https://bugs.webkit.org/show_bug.cgi?id=193791
4029         <rdar://problem/47201706>
4030
4031         Reviewed by Alex Christensen.
4032
4033         Many .xcfilelist files were added in r238824 in order to support
4034         XCBuild. Update these with recent changes to the set of build files
4035         and with the current generate-xcfilelist script.
4036
4037         * DumpRenderTree/DerivedSources-input.xcfilelist:
4038         * DumpRenderTree/DerivedSources-output.xcfilelist:
4039         * WebKitTestRunner/DerivedSources-input.xcfilelist:
4040         * WebKitTestRunner/DerivedSources-output.xcfilelist:
4041
4042 2019-01-25  Keith Rollin  <krollin@apple.com>
4043
4044         Fix missing dependencies in extract-dependencies-from-makefile
4045         https://bugs.webkit.org/show_bug.cgi?id=193783
4046         <rdar://problem/47201571>
4047
4048         Reviewed by Alex Christensen.
4049
4050         The extract-dependencies-from-makefile script generates .xcfilelists
4051         for XCBuild by invoking a makefile in --debug mode, parsing the
4052         dependency information in the output, and extracting information
4053         regarding targets and dependents. However, the way `make` emits this
4054         dependency information is not rigorous, and so we need to determine
4055         what lines to look for and parse by trial and error. This approach
4056         didn't coriginally atch all the information we needed to collect, so
4057         update the script to look for the additional lines we now know to look
4058         for.
4059
4060         * Scripts/extract-dependencies-from-makefile:
4061         (Parser):
4062         (Parser.addTarget):
4063         (Parser.addPrereq):
4064         (Parser.doParse):
4065
4066 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
4067
4068         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4069         https://bugs.webkit.org/show_bug.cgi?id=193297
4070         <rdar://problem/47158841>
4071
4072         Reviewed by Alex Christensen.
4073
4074         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
4075             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
4076         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4077         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4078         activating the message used to trigger the callback when it is set.
4079
4080 2019-01-25  Alex Christensen  <achristensen@webkit.org>
4081
4082         WKWebView.goBack should reload if there is a safe browsing warning
4083         https://bugs.webkit.org/show_bug.cgi?id=193805
4084         <rdar://problem/46908216>
4085
4086         Reviewed by Geoff Garen.
4087
4088         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4089         (+[Simple3LookupContext sharedLookupContext]):
4090         (-[Simple3LookupContext lookUpURL:completionHandler:]):
4091         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
4092         (TEST):
4093
4094 2019-01-25  Chris Dumez  <cdumez@apple.com>
4095
4096         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
4097         https://bugs.webkit.org/show_bug.cgi?id=193788
4098         <rdar://problem/47531231>
4099
4100         Reviewed by Alex Christensen.
4101
4102         Add API test coverage.
4103
4104         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4105         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
4106
4107 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
4108
4109         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
4110         https://bugs.webkit.org/show_bug.cgi?id=193771
4111
4112         Unreviewed infrastructure fix.
4113
4114         * Scripts/webkitpy/port/darwin.py:
4115         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
4116
4117 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
4118
4119         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
4120
4121 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
4122
4123         Add contributors.json entries for Ling Ho and for a new bot watchers group.
4124
4125         * Scripts/webkitpy/common/config/contributors.json:
4126
4127 2019-01-25  Chris Dumez  <cdumez@apple.com>
4128
4129         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
4130         https://bugs.webkit.org/show_bug.cgi?id=193779
4131         <rdar://problem/46170903>
4132
4133         Reviewed by Antti Koivisto.
4134
4135         Add API test that quickly navigates forward to a previous process without waiting for it to
4136         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
4137         the process' previous page when reconnecting the it for the forward navigation.
4138
4139         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4140
4141 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4142
4143         Need a way for JavaScript (or bundle) code to participate in undo
4144         https://bugs.webkit.org/show_bug.cgi?id=190009
4145         <rdar://problem/44807048>
4146
4147         Reviewed by Ryosuke Niwa.
4148
4149         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
4150         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
4151
4152         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4153         (WTR::UIScriptController::lastUndoLabel const):
4154         (WTR::UIScriptController::firstRedoLabel const):
4155         (WTR::UIScriptController::platformUndoManager const):
4156         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4157         (WTR::UIScriptController::lastUndoLabel const):
4158         (WTR::UIScriptController::firstRedoLabel const):
4159         (WTR::UIScriptController::platformUndoManager const):
4160         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4161         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4162         (WTR::UIScriptController::lastUndoLabel const):
4163         (WTR::UIScriptController::firstRedoLabel const):
4164         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4165         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4166         (WTR::UIScriptController::lastUndoLabel const):
4167         (WTR::UIScriptController::firstRedoLabel const):
4168         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4169         (WTR::UIScriptController::platformUndoManager const):
4170         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4171         (WTR::UIScriptController::platformUndoManager const):
4172
4173 2019-01-25  Zalan Bujtas  <zalan@apple.com>
4174
4175         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
4176         https://bugs.webkit.org/show_bug.cgi?id=193824
4177
4178         Reviewed by Antti Koivisto.
4179
4180         * LayoutReloaded/misc/LFC-passing-tests.txt:
4181
4182 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
4183
4184         Update macOS JSC bot configurations
4185         https://bugs.webkit.org/show_bug.cgi?id=193739
4186
4187         Reviewed by Alexey Proskuryakov.
4188
4189         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
4190         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4191         (BubbleQueueServer): Move JSC EWS to Mojave section.
4192         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4193         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
4194         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
4195
4196 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
4197
4198         [Win][WebKitTestRunner] Implement EventSenderProxy
4199         https://bugs.webkit.org/show_bug.cgi?id=193755
4200
4201         Reviewed by Don Olmstead.
4202
4203         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
4204         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
4205         (WTR::EventSenderProxy::dispatchMessage):
4206         (WTR::EventSenderProxy::EventSenderProxy):
4207         (WTR::EventSenderProxy::mouseDown):
4208         (WTR::EventSenderProxy::mouseUp):
4209         (WTR::EventSenderProxy::mouseMoveTo):
4210         (WTR::EventSenderProxy::mouseScrollBy):
4211         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
4212
4213 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4214
4215         Unreviewed fix for API test failure after r240437.
4216
4217         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
4218
4219         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
4220
4221 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4222
4223         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
4224         https://bugs.webkit.org/show_bug.cgi?id=193787
4225         <rdar://problem/47497634>
4226
4227         Reviewed by Alexey Proskuryakov.
4228
4229         * Scripts/webkitdirs.pm:
4230         (iosSimulatorApplicationsPath): Pick from available runtime directories.
4231
4232 2019-01-24  Truitt Savell  <tsavell@apple.com>
4233
4234         Unreviewed, rolling out r240446.
4235
4236         Casued 5 API failures
4237
4238         Reverted changeset:
4239
4240         "Activate the WebResourceLoadStatisticsStore in the
4241         NetworkProcess and deactivate it in the UIProcess."
4242         https://bugs.webkit.org/show_bug.cgi?id=193297
4243         https://trac.webkit.org/changeset/240446
4244
4245 2019-01-24  Zalan Bujtas  <zalan@apple.com>
4246
4247         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
4248         https://bugs.webkit.org/show_bug.cgi?id=193741
4249         <rdar://problem/47135030>
4250
4251         Reviewed by Antti Koivisto and Simon Fraser.
4252
4253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4254         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
4255         (TestWebKitAPI::TEST):
4256
4257 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
4258
4259         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4260         https://bugs.webkit.org/show_bug.cgi?id=193297
4261         <rdar://problem/47158841>
4262
4263         Reviewed by Alex Christensen.
4264
4265         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4266         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4267         activating the message used to trigger the callback when it is set.
4268
4269 2019-01-24  John Wilander  <wilander@apple.com>
4270
4271         Add Ad Click Attribution as an internal/experimental feature
4272         https://bugs.webkit.org/show_bug.cgi?id=193685
4273         <rdar://problem/47450399>
4274
4275         Reviewed by Brent Fulgham.
4276
4277         Added test option adClickAttributionEnabled.
4278
4279         * DumpRenderTree/TestOptions.cpp:
4280         (TestOptions::TestOptions):
4281         * DumpRenderTree/TestOptions.h:
4282         * DumpRenderTree/mac/DumpRenderTree.mm:
4283         (setWebPreferencesForTestOptions):
4284
4285 2019-01-24  Antti Koivisto  <antti@apple.com>
4286
4287         [PSON] Flash on back navigation on Mac
4288         https://bugs.webkit.org/show_bug.cgi?id=193716
4289         <rdar://problem/47148458>
4290
4291         Reviewed by Chris Dumez.
4292
4293         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4294
4295         Closing of the previous page is delayed so waiting for didFinishNavigation is
4296         not sufficient to guarantee we have received all the messages. Wait for them.
4297
4298 2019-01-24  Chris Dumez  <cdumez@apple.com>
4299
4300         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
4301         https://bugs.webkit.org/show_bug.cgi?id=193761
4302         <rdar://problem/47456405>
4303
4304         Reviewed by Alex Christensen.
4305
4306         Add API test coverage.
4307
4308         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4309
4310 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4311
4312         webkitpy: Missing PID in crashlog name should not be fatal
4313         https://bugs.webkit.org/show_bug.cgi?id=193771
4314
4315         If we can't determine the PID of a crashlog, just ignore the crashlog instead
4316         of raising an exception.
4317
4318         Reviewed by Lucas Forschler.
4319
4320         * Scripts/webkitpy/port/darwin.py:
4321         (DarwinPort._merge_crash_logs):
4322
4323 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4324
4325         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
4326         https://bugs.webkit.org/show_bug.cgi?id=193746
4327
4328         Reviewed by Youenn Fablet.
4329
4330         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
4331         so we'd best just not call it.
4332
4333         * Scripts/webkitpy/w3c/test_exporter.py:
4334         (WebPlatformTestExporter.create_branch_with_patch):
4335
4336 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4337
4338         Move FileSystem to WTF
4339         https://bugs.webkit.org/show_bug.cgi?id=193602
4340
4341         Reviewed by Yusuke Suzuki.
4342
4343         * DumpRenderTree/win/DumpRenderTree.cpp:
4344         * TestWebKitAPI/CMakeLists.txt:
4345         * TestWebKitAPI/PlatformGTK.cmake:
4346         * TestWebKitAPI/PlatformJSCOnly.cmake:
4347         * TestWebKitAPI/PlatformPlayStation.cmake:
4348         * TestWebKitAPI/PlatformWPE.cmake:
4349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4350         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
4351         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
4352         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
4353         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
4354         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
4355         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4356         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4357         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4358         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4359
4360 2019-01-24  Philippe Normand  <pnormand@igalia.com>
4361
4362         [WPE] Remove hard dependency on subprocess32 for the API tests
4363
4364         Rubber-stamped by Carlos Garcia Campos.
4365
4366         * glib/api_test_runner.py:
4367         (TestRunner._run_test_qt): Lazily import subprocess32 and check
4368         its presence only when running WPEQt tests.