[Cocoa] Media elements will restart network buffering just before suspending
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-13  Jer Noble  <jer.noble@apple.com>
2
3         [Cocoa] Media elements will restart network buffering just before suspending
4         https://bugs.webkit.org/show_bug.cgi?id=193691
5
6         Reviewed by Eric Carlson.
7
8         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
10         (TEST):
11
12 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
13
14         [ews-app] Fetch builder id to name mapping
15         https://bugs.webkit.org/show_bug.cgi?id=194355
16
17         Reviewed by Lucas Forschler.
18
19         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
20         (Buildbot.get_builder_id_to_name_mapping):
21         (Buildbot._get_display_name_from_builder_name):
22
23 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
24
25         Further restricting webarchive loads
26         https://bugs.webkit.org/show_bug.cgi?id=194567
27         <rdar://problem/47610130>
28
29         Reviewed by Youenn Fablet.
30
31         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
32         navigations on drop.
33
34         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
35         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
36         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
37         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
38         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
39         (TestWebKitAPI::TEST):
40         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
41         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
42         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
43         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
44         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
45         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
46         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
47
48 2019-02-13  John Wilander  <wilander@apple.com>
49
50         Store Ad Click Attribution requests in the network process
51         https://bugs.webkit.org/show_bug.cgi?id=194510
52         <rdar://problem/47650118>
53
54         Reviewed by Alex Christensen and Daniel Bates.
55
56         This patch adds two TestRunner functions:
57         - dumpAdClickAttribution()
58         - clearAdClickAttribution()
59
60         They call into the network process to dump and clear Ad Click
61         Attribution state, respectively.
62
63         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
64         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
65         (WTR::TestRunner::dumpAdClickAttribution):
66         (WTR::TestRunner::clearAdClickAttribution):
67         * WebKitTestRunner/InjectedBundle/TestRunner.h:
68         * WebKitTestRunner/TestController.cpp:
69         (WTR::TestController::resetStateToConsistentValues):
70         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
71         (WTR::adClickAttributionStringResultCallback):
72         (WTR::TestController::dumpAdClickAttribution):
73         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
74         (WTR::adClickAttributionVoidCallback):
75         (WTR::TestController::clearAdClickAttribution):
76         * WebKitTestRunner/TestController.h:
77         * WebKitTestRunner/TestInvocation.cpp:
78         (WTR::TestInvocation::dumpResults):
79         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
80         (WTR::TestInvocation::dumpAdClickAttribution):
81         * WebKitTestRunner/TestInvocation.h:
82
83 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
84
85         [ews-app] Generate status-bubble
86         https://bugs.webkit.org/show_bug.cgi?id=194572
87
88         Reviewed by Lucas Forschler.
89
90         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
91         (StatusBubble._build_bubble):
92         (StatusBubble._should_show_bubble_for):
93         (StatusBubble._build_bubbles_for_patch):
94
95 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
96
97         [ews-app] Add status bubble html template
98         https://bugs.webkit.org/show_bug.cgi?id=194571
99
100         Reviewed by Lucas Forschler.
101
102         * BuildSlaveSupport/ews-app/ews/templates: Added.
103         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
104
105 2019-02-12  Chris Dumez  <cdumez@apple.com>
106
107         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
108         https://bugs.webkit.org/show_bug.cgi?id=194568
109         <rdar://problem/47944490>
110
111         Reviewed by Ryosuke Niwa.
112
113         Add API test coverage.
114
115         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
116         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
117
118 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
119
120         webkitpy: Remove bug_dummy from parsed test expectations
121         https://bugs.webkit.org/show_bug.cgi?id=194562
122         <rdar://problem/47853999>
123
124         Reviewed by Lucas Forschler.
125
126         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
127         (TestExpectationParser):
128         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
129         skipped tests.
130         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
131
132 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
133
134         [ews-app] Add method to fetch patch
135         https://bugs.webkit.org/show_bug.cgi?id=194518
136
137         Reviewed by Lucas Forschler.
138
139         * BuildSlaveSupport/ews-app/ews/models/patch.py:
140         (Patch.get_patch):
141
142 2019-02-12  Zalan Bujtas  <zalan@apple.com>
143
144         [LFC] Expand tests coverage (60 new tests -> 860)
145
146         Unreviewed test gardening (run-singly, --child-processes=1).
147
148         * LayoutReloaded/misc/LFC-passing-tests.txt:
149
150 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
151
152         Allow pages to trigger programmatic paste from script on iOS
153         https://bugs.webkit.org/show_bug.cgi?id=194271
154         <rdar://problem/47808810>
155
156         Reviewed by Tim Horton.
157
158         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
159
160         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
161         (WTR::UIScriptController::platformSetDidShowMenuCallback):
162         (WTR::UIScriptController::platformSetDidHideMenuCallback):
163         (WTR::UIScriptController::rectForMenuAction const):
164
165         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
166         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
167         for when the menu is shown or hidden.
168
169         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
170         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
171         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
172         (WTR::UIScriptController::setDidShowMenuCallback):
173         (WTR::UIScriptController::didShowMenuCallback const):
174         (WTR::UIScriptController::setDidHideMenuCallback):
175         (WTR::UIScriptController::didHideMenuCallback const):
176         (WTR::UIScriptController::platformSetDidShowMenuCallback):
177         (WTR::UIScriptController::platformSetDidHideMenuCallback):
178         (WTR::UIScriptController::rectForMenuAction const):
179         * TestRunnerShared/UIScriptContext/UIScriptController.h:
180         * WebKitTestRunner/TestController.cpp:
181         (WTR::TestController::resetPreferencesToConsistentValues):
182         (WTR::updateTestOptionsFromTestHeader):
183         * WebKitTestRunner/TestOptions.h:
184
185         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
186         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
187
188         (WTR::TestOptions::hasSameInitializationOptions const):
189         * WebKitTestRunner/UIScriptControllerCocoa.mm:
190         (WTR::UIScriptController::calendarType const):
191         (WTR::UIScriptController::platformUndoManager const):
192         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
193         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
194         (-[TestRunnerWKWebView initWithFrame:configuration:]):
195         (-[TestRunnerWKWebView dealloc]):
196         (-[TestRunnerWKWebView _didShowMenu]):
197         (-[TestRunnerWKWebView _didHideMenu]):
198
199         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
200
201         * WebKitTestRunner/ios/TestControllerIOS.mm:
202         (WTR::handleMenuWillHideNotification):
203         (WTR::handleMenuDidHideNotification):
204         (WTR::TestController::platformInitialize):
205         (WTR::TestController::platformDestroy):
206         (WTR::TestController::platformResetStateToConsistentValues):
207
208         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
209         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
210
211         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
212         (WTR::forEachViewInHierarchy):
213         (WTR::findViewInHierarchyOfType):
214
215         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
216         functions that dig through a given view's hierarchy in search of a view of a given class.
217
218         (WTR::UIScriptController::selectionStartGrabberViewRect const):
219         (WTR::UIScriptController::selectionEndGrabberViewRect const):
220         (WTR::UIScriptController::selectionCaretViewRect const):
221         (WTR::UIScriptController::selectionRangeViewRects const):
222         (WTR::UIScriptController::platformSetDidShowMenuCallback):
223         (WTR::UIScriptController::platformSetDidHideMenuCallback):
224
225         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
226
227         (WTR::UIScriptController::rectForMenuAction const):
228
229         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
230         callout bar) whose label matches the given string.
231
232         (WTR::UIScriptController::platformContentView const):
233
234         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
235         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
236         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
237
238         (WTR::UIScriptController::platformUndoManager const): Deleted.
239         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
240         (WTR::UIScriptController::platformContentView const):
241         (WTR::UIScriptController::platformUndoManager const): Deleted.
242
243 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
244
245         webkitpy: No option to only show unexpected failures in results.html for iPad
246         https://bugs.webkit.org/show_bug.cgi?id=194554
247         <rdar://problem/47922442>
248
249         Rubber-stamped by Aakash Jain.
250
251         Just because a TestExpecations file does not exist for a specific platform does not mean that
252         TestExpecations are not being used, given that platforms inherit test expectations.
253
254         * Scripts/webkitpy/port/base.py:
255         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
256         * Scripts/webkitpy/port/base_unittest.py:
257         (PortTest.test_uses_test_expectations_file):
258
259 2019-02-12  Alex Christensen  <achristensen@webkit.org>
260
261         Remove setDefersLoading infrastructure from WebKit2
262         https://bugs.webkit.org/show_bug.cgi?id=194506
263
264         Reviewed by Brady Eidson.
265
266         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
267         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
268         (WTR::TestRunner::setDefersLoading): Deleted.
269         * WebKitTestRunner/InjectedBundle/TestRunner.h:
270
271 2019-02-12  Alex Christensen  <achristensen@webkit.org>
272
273         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
274         https://bugs.webkit.org/show_bug.cgi?id=194522
275         <rdar://problem/47789393>
276
277         Reviewed by Chris Dumez.
278
279         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
280         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
281         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
282         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
283
284 2019-02-12  Andy Estes  <aestes@apple.com>
285
286         [iOSMac] Enable Parental Controls Content Filtering
287         https://bugs.webkit.org/show_bug.cgi?id=194521
288         <rdar://39732376>
289
290         Reviewed by Tim Horton.
291
292         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
293
294 2019-02-12  Zalan Bujtas  <zalan@apple.com>
295
296         [LFC][IFC] Add intrinsic width support for float boxes.
297         https://bugs.webkit.org/show_bug.cgi?id=194528
298
299         Reviewed by Antti Koivisto.
300
301         Expand tests coverage (2 new tests -> 800).
302         (This is the correct test ordering --runs-singly --child-processes=1)
303
304         * LayoutReloaded/misc/LFC-passing-tests.txt:
305
306 2019-02-12  Rob Buis  <rbuis@igalia.com>
307
308         Implement serializing in MIME type parser
309         https://bugs.webkit.org/show_bug.cgi?id=193909
310
311         Reviewed by Darin Adler.
312
313         Add various tests involving upper case, non-ASCII, control/null characters,
314         various HTTP whitespace, single quotes and an unpaired surrogate.
315
316         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
317         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
318         (TestWebKitAPI::serializeIfValid):
319         (TestWebKitAPI::TEST):
320
321 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
322
323         [Cocoa] Ask platform for generic font family mappings
324         https://bugs.webkit.org/show_bug.cgi?id=187723
325         <rdar://problem/41892438>
326
327         Reviewed by Brent Fulgham.
328
329         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
330
331         * DumpRenderTree/mac/DumpRenderTree.mm:
332         (allowedFontFamilySet):
333         * WebKitTestRunner/mac/TestControllerMac.mm:
334         (WTR::allowedFontFamilySet):
335
336 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
337
338         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
339         https://bugs.webkit.org/show_bug.cgi?id=193622
340
341         Reviewed by Michael Catanzaro.
342
343         This adds support for loading content extension rule sets from the JSON files which
344         accompany the corresponding layout test, using the C API. The Cocoa specific parts
345         of WKTR for this could be removed, but that is left for a follow-up patch with
346         cleanups.
347
348         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
349         * WebKitTestRunner/TestController.cpp:
350         (WTR::testPath): Subtract one from the length when constructing the result std::string to
351         avoid having the null-terminator copied into the result.
352         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
353         part of the preparations to run a test.
354         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
355         (WTR::contentExtensionStoreCallback): Added.
356         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
357         used for content extensions test.
358         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
359         extensions and compiling the JSON rule set for tests involving content extensions.
360         (WTR::TestController::resetContentExtensions): Removes the content extension built for
361         testing and disables content extensions.
362         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
363         resetContentExtensions().
364         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
365         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
366         configureContentExtensionForTest(), and userContentController().
367
368 2019-02-11  Daniel Bates  <dabates@apple.com>
369
370         [iOS] Mouse/Touch/Pointer events are missing modifier keys
371         https://bugs.webkit.org/show_bug.cgi?id=191446
372         <rdar://problem/45929460>
373
374         Reviewed by Tim Horton.
375
376         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
377
378         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
379         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
380         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
381         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
382         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
383         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
384         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
385         * TestRunnerShared/UIScriptContext/UIScriptController.h:
386         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
387         (WTR::arrayLength):
388         (WTR::parseModifierArray):
389         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
390         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
391         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
392         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
393
394 2019-02-11  Commit Queue  <commit-queue@webkit.org>
395
396         Unreviewed, rolling out r241272 and r241276.
397         https://bugs.webkit.org/show_bug.cgi?id=194514
398
399         Broke the Apple Internal build and the fix requires human
400         intervention :( (Requested by dydz on #webkit).
401
402         Reverted changesets:
403
404         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
405         https://bugs.webkit.org/show_bug.cgi?id=191446
406         https://trac.webkit.org/changeset/241272
407
408         "Fix internal iOS build after r241272"
409         https://bugs.webkit.org/show_bug.cgi?id=191446
410         https://trac.webkit.org/changeset/241276
411
412 2019-02-11  Truitt Savell  <tsavell@apple.com>
413
414         Unreviewed, rolling out r241269.
415
416         Caused 5 layout tests crashes on Mac WK1
417
418         Reverted changeset:
419
420         "DumpRenderTree should report unknown options"
421         https://bugs.webkit.org/show_bug.cgi?id=191303
422         https://trac.webkit.org/changeset/241269
423
424 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
425
426         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
427         https://bugs.webkit.org/show_bug.cgi?id=194313
428
429         Reviewed by Tim Horton.
430
431         Add a helper to determine whether the web view is presenting modal UI.
432
433         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
434         (WTR::UIScriptController::isPresentingModally const):
435         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
436         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
437         (WTR::UIScriptController::isPresentingModally const):
438         * TestRunnerShared/UIScriptContext/UIScriptController.h:
439         * WebKitTestRunner/UIScriptControllerCocoa.mm:
440         (WTR::UIScriptController::calendarType const): Deleted.
441         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
442         (WTR::UIScriptController::isPresentingModally const):
443         (WTR::UIScriptController::calendarType const):
444         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
445         (WTR::UIScriptController::calendarType const):
446
447 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
448
449         GCHeapInspector: Show the retained sizes in more places
450         https://bugs.webkit.org/show_bug.cgi?id=194464
451
452         Reviewed by Simon Fraser.
453
454         * GCHeapInspector/gc-heap-inspector.html:
455         * GCHeapInspector/script/interface.js:
456         (HeapInspectorUtils.humanReadableSize):
457         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
458         (HeapInspectorUtils.spanForNode.span.span):
459         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
460         (HeapSnapshotInspector.prototype.buildRoots):
461
462 2019-02-11  Daniel Bates  <dabates@apple.com>
463
464         [iOS] Mouse/Touch/Pointer events are missing modifier keys
465         https://bugs.webkit.org/show_bug.cgi?id=191446
466         <rdar://problem/45929460>
467
468         Reviewed by Tim Horton.
469
470         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
471
472         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
473         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
474         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
475         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
476         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
477         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
478         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
479         * TestRunnerShared/UIScriptContext/UIScriptController.h:
480         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
481         (WTR::arrayLength):
482         (WTR::parseModifierArray):
483         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
484         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
485         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
486         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
487
488 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
489
490         DumpRenderTree should report unknown options
491         https://bugs.webkit.org/show_bug.cgi?id=191303
492
493         Reviewed by Frédéric Wang.
494
495         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
496         to report unknown options.
497         Added and assigned test options which are currently used in tests.
498
499         * DumpRenderTree/TestOptions.cpp:
500         (TestOptions::TestOptions):
501
502 2019-02-11  Truitt Savell  <tsavell@apple.com>
503
504         Unreviewed, rolling out r241229.
505
506         Revision broke internal builds for watchOS.
507
508         Reverted changeset:
509
510         "[Cocoa] Ask platform for generic font family mappings"
511         https://bugs.webkit.org/show_bug.cgi?id=187723
512         https://trac.webkit.org/changeset/241229
513
514 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
515
516         [WinCairo][MiniBrowser] Basic authentication always fails.
517         https://bugs.webkit.org/show_bug.cgi?id=194496
518
519         Reviewed by Don Olmstead.
520
521         * MiniBrowser/win/DialogHelper.h:
522         (Dialog::getText):
523
524 2019-02-11  Philippe Normand  <pnormand@igalia.com>
525
526         [GStreamer] GstMappedBuffer testsuite build fails
527         https://bugs.webkit.org/show_bug.cgi?id=194495
528
529         Reviewed by Carlos Garcia Campos.
530
531         Fix the build by explicitely adding the gstreamer1.0-audio include
532         directories to the include path.
533
534         * TestWebKitAPI/PlatformGTK.cmake:
535         * TestWebKitAPI/PlatformWPE.cmake:
536
537 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
538
539         [GTK][WPE] Add enable-javascript-markup setting
540         https://bugs.webkit.org/show_bug.cgi?id=193439
541
542         Reviewed by Michael Catanzaro.
543
544         Add test cases to check the new setting.
545
546         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
547         (testWebKitSettings):
548         (testWebKitSettingsJavaScriptMarkup):
549         (beforeAll):
550
551 2019-02-10  Darin Adler  <darin@apple.com>
552
553         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
554         https://bugs.webkit.org/show_bug.cgi?id=194485
555
556         Reviewed by Daniel Bates.
557
558         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
559
560 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
561
562         Add more tests for clampTo<>()
563         https://bugs.webkit.org/show_bug.cgi?id=194462
564
565         Reviewed by Geoffrey Garen.
566
567         Darin suggested to test the very last floating point number
568         at the boundaries when truncating to integer.
569         I added test for max/min and max-1/min-1.
570
571         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
572         (TestWebKitAPI::TEST):
573
574 2019-02-09  Darin Adler  <darin@apple.com>
575
576         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
577         https://bugs.webkit.org/show_bug.cgi?id=194021
578
579         Reviewed by Geoffrey Garen.
580
581         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
582         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
583         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
584
585 2019-02-09  Zalan Bujtas  <zalan@apple.com>
586
587         [LFC][IFC] Add intrinsic width support for basic inline containers
588         https://bugs.webkit.org/show_bug.cgi?id=194473
589
590         Reviewed by Antti Koivisto.
591
592         Expand tests coverage (11 new tests -> 798)
593
594         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
595
596 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
597
598         Fix MiniBrowser's entitlements
599         https://bugs.webkit.org/show_bug.cgi?id=192431
600
601         Reviewed by Joseph Pecoraro.
602
603         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
604         files, making it impossible to load any extension.
605
606         * MiniBrowser/MiniBrowser.entitlements:
607
608 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
609
610         [Cocoa] Ask platform for generic font family mappings
611         https://bugs.webkit.org/show_bug.cgi?id=187723
612         <rdar://problem/41892438>
613
614         Reviewed by Brent Fulgham.
615
616         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
617
618         * DumpRenderTree/mac/DumpRenderTree.mm:
619         (allowedFontFamilySet):
620         * WebKitTestRunner/mac/TestControllerMac.mm:
621         (WTR::allowedFontFamilySet):
622
623 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
624
625         [GTK] Implement back/forward touchpad gesture
626         https://bugs.webkit.org/show_bug.cgi?id=193919
627
628         Reviewed by Michael Catanzaro.
629
630         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
631         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
632
633 2019-02-08  Alex Christensen  <achristensen@webkit.org>
634
635         Add SPI to use networking daemon instead of XPC service
636         https://bugs.webkit.org/show_bug.cgi?id=194427
637
638         Reviewed by Geoffrey Garen
639
640         * MiniBrowser/MiniBrowser.entitlements:
641
642 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
643
644         [ews-build] Ensure that every builder in config.json has short name
645         https://bugs.webkit.org/show_bug.cgi?id=194461
646
647         Reviewed by Lucas Forschler.
648
649         * BuildSlaveSupport/ews-build/loadConfig.py:
650         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
651
652 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
653
654         [ews-build] Add short name to config.json
655         https://bugs.webkit.org/show_bug.cgi?id=194456
656
657         Reviewed by Lucas Forschler.
658
659         * BuildSlaveSupport/ews-build/config.json: Added short name.
660         * BuildSlaveSupport/ews-build/loadConfig.py:
661         (loadBuilderConfig): Set the short name as the builder description.
662
663 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
664
665         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
666         https://bugs.webkit.org/show_bug.cgi?id=194418
667
668         Reviewed by Lucas Forschler.
669
670         Do not include errors trying when finding crashlogs at the end of
671         a run-webkit-tests run since we don't process those errors.
672
673         * Scripts/webkitpy/port/darwin.py:
674         (DarwinPort._look_for_all_crash_logs_in_log_dir):
675         * Scripts/webkitpy/port/ios_device.py:
676         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
677         * Scripts/webkitpy/port/watch_device.py:
678         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
679
680 2019-02-08  Beth Dakin  <bdakin@apple.com>
681
682         Add afterScreenUpdates to WKSnapshotConfiguration
683         https://bugs.webkit.org/show_bug.cgi?id=194362
684         -and corresponding-
685         <rdar://problem/40655528> Please add an "after screen updates" property to 
686         WKSnapshotConfiguration (to solve blank snapshots)
687
688         Reviewed by Tim Horton.
689
690         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
691         (TEST):
692
693 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
694
695         clampTo(): do not convert the input to double when dealing with integers
696         https://bugs.webkit.org/show_bug.cgi?id=194263
697         <rdar://problem/47692312>
698
699         Reviewed by Darin Adler.
700
701         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
702         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
703         (TestWebKitAPI::testClampFloatingPointToInteger):
704         (TestWebKitAPI::testClampSameSignIntegers):
705         (TestWebKitAPI::testClampUnsignedToSigned):
706         (TestWebKitAPI::testClampSignedToUnsigned):
707
708 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
709
710         webkitpy: Respect --dedicated-simulators flag
711         https://bugs.webkit.org/show_bug.cgi?id=194416
712         <rdar://problem/47894722>
713
714         Reviewed by Lucas Forschler.
715
716         * Scripts/webkitpy/port/device_port.py:
717         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
718         available devices can be safely ignored.
719
720 2019-02-07  Keith Rollin  <krollin@apple.com>
721
722         Remove extra copy of 100x100-red.tga
723         https://bugs.webkit.org/show_bug.cgi?id=194371
724         <rdar://problem/47873465>
725
726         Reviewed by Said Abou-Hallawa.
727
728         In order to help it pass its tests, Bug 194190 added a second copy of
729         the file 100x100-red.tga. However, it turns out that this additional
730         file wasn't actually needed, and that that sole previous copy was
731         sufficient. At the same time, this second copy -- which was copied to
732         the same location in the build output as the first copy -- now caused
733         XCBuild to complain because there were two production rules for the
734         same output file. Address this by removing the newly-added extra copy.
735
736         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
737         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
738
739 2019-02-07  Alex Christensen  <achristensen@webkit.org>
740
741         Deprecate WKBundlePageSetDefersLoading
742         https://bugs.webkit.org/show_bug.cgi?id=191394
743
744         Reviewed by Dean Jackson.
745
746         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
747         (WTR::TestRunner::setDefersLoading):
748
749 2019-02-07  Zalan Bujtas  <zalan@apple.com>
750
751         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
752         https://bugs.webkit.org/show_bug.cgi?id=194391
753
754         Reviewed by Antti Koivisto.
755
756         * LayoutReloaded/misc/LFC-passing-tests.txt:
757
758 2019-02-06  Keith Rollin  <krollin@apple.com>
759
760         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
761         https://bugs.webkit.org/show_bug.cgi?id=193975
762         <rdar://problem/47643306>
763
764         Reviewed by Tim Horton.
765
766         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
767         the Info.plist file into the bundle. This step is not necessary as the
768         implicit "bundle up all the build products into a framework" build
769         phase does this already. Having the Copy Bundle Resources phase do
770         this causes a conflict under XCBuild, which objects to two build
771         phases producing the same file (Info.plist). Address this by removing
772         Info.plist from the Copy Bundle Resources phase.
773
774         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
775
776 2019-02-06  Keith Rollin  <krollin@apple.com>
777
778         Really enable the automatic checking and regenerations of .xcfilelists during builds
779         https://bugs.webkit.org/show_bug.cgi?id=194357
780         <rdar://problem/47861231>
781
782         Reviewed by Chris Dumez.
783
784         Bug 194124 was supposed to enable the automatic checking and
785         regenerating of .xcfilelist files during the build. While related
786         changes were included in that patch, the change to actually enable the
787         operation somehow was omitted. This patch actually enables the
788         operation. The check-xcfilelist.sh scripts now check
789         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
790         from the checking.
791
792         * DumpRenderTree/Scripts/check-xcfilelists.sh:
793         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
794
795 2019-02-06  David Kilzer  <ddkilzer@apple.com>
796
797         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
798         <https://webkit.org/b/194286>
799         <rdar://problem/47815558>
800
801         Reviewed by Alexey Proskuryakov.
802
803         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
804         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
805         WKRetainPtr<> to avoid leaking the WKDataRef.
806
807 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
808
809         Unreviewed, fix a typo
810
811         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
812
813 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
814
815         [GTK][WPE] force libpsl build to use ICU in jhbuild
816         https://bugs.webkit.org/show_bug.cgi?id=194288
817
818         Reviewed by Carlos Garcia Campos.
819
820         * gtk/jhbuild.modules:
821         Require ICU for libpsl build in jhbuild, like done in WPE.
822
823 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
824
825         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
826         https://bugs.webkit.org/show_bug.cgi?id=194209
827
828         Reviewed by Carlos Garcia Campos.
829
830         Enhance TestCookieManager to ensure this doesn't happen again.
831
832         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
833         (testCookieManagerPersistentStorage):
834         (beforeAll):
835
836 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
837
838         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
839         https://bugs.webkit.org/show_bug.cgi?id=194324
840
841         Reviewed by Andy Estes.
842
843         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
844         part of the name is already implicit, since this is in testing code in TestOptions.
845
846         * WebKitTestRunner/TestController.cpp:
847         (WTR::TestController::generateContextConfiguration const):
848         (WTR::updateTestOptionsFromTestHeader):
849         * WebKitTestRunner/TestOptions.h:
850         (WTR::TestOptions::hasSameInitializationOptions const):
851
852 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
853
854         [ews-build] Allow * as platform for builders and workers
855         https://bugs.webkit.org/show_bug.cgi?id=188533
856
857         Reviewed by Lucas Forschler.
858
859         * BuildSlaveSupport/ews-build/loadConfig.py:
860         (checkWorkersAndBuildersForConsistency):
861
862 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
863
864         [ews-build] Add few bots to config.json
865         https://bugs.webkit.org/show_bug.cgi?id=194304
866
867         Reviewed by Lucas Forschler.
868
869         * BuildSlaveSupport/ews-build/config.json:
870
871 2019-02-05  Keith Rollin  <krollin@apple.com>
872
873         Enable the automatic checking and regenerations of .xcfilelists during builds
874         https://bugs.webkit.org/show_bug.cgi?id=194124
875         <rdar://problem/47721277>
876
877         Reviewed by Tim Horton.
878
879         Bug 193790 add a facility for checking -- during build time -- that
880         any needed .xcfilelist files are up-to-date and for updating them if
881         they are not. This facility was initially opt-in by setting
882         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
883         the process seemed robust. Its now time to enable this facility and
884         make it opt-out. If there is a need to disable this facility, set and
885         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
886         running `make` or `build-webkit`, or before running Xcode from the
887         command line.
888
889         Additionally, remove the step that generates a list of source files
890         going into the UnifiedSources build step. It's only necessarily to
891         specify Sources.txt and SourcesCocoa.txt as inputs.
892
893         * Scripts/generate-xcfilelists:
894
895 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
896
897         [GTK][WPE] force libpsl build to use ICU in jhbuild
898         https://bugs.webkit.org/show_bug.cgi?id=194288
899
900         Reviewed by Philippe Normand.
901
902         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
903         This can cause build failures if libidn is detected but libunistring is not available.
904
905         Make sure that ICU is used for runtime and builtin PSL data.
906
907         * gtk/jhbuild.modules:
908         * wpe/jhbuild.modules:
909
910 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
911
912         [ews-app] Modified timestamp should be updated on updating data
913         https://bugs.webkit.org/show_bug.cgi?id=194295
914
915         Reviewed by Lucas Forschler.
916
917         * BuildSlaveSupport/ews-app/ews/models/build.py:
918         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
919         * BuildSlaveSupport/ews-app/ews/models/step.py:
920
921 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
922
923         Unreviewed, rolling out r240742.
924
925         Causes crashes on iOS simulator.
926
927         Reverted changeset:
928
929         "[iOS] Keyups for non-modifier keys identified as "Dead" when
930         not focused in a content-editable element"
931         https://bugs.webkit.org/show_bug.cgi?id=192824
932         https://trac.webkit.org/changeset/240742
933
934 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
935
936         run-webkit-tests emits message "...running None" when running tests
937         https://bugs.webkit.org/show_bug.cgi?id=194133
938         <rdar://problem/47724738>
939
940         Reviewed by Lucas Forschler.
941
942         * Scripts/webkitpy/xcode/device_type.py:
943         (DeviceType.__str__): Use both version mapping tables and use just the variant
944         name if no version name is available.
945         * Scripts/webkitpy/xcode/device_type_unittest.py:
946         (DeviceTypeTest):
947         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
948         an associated named.
949
950 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
951
952         [WPE] require python3-setuptools for meson build in jhbuild
953         https://bugs.webkit.org/show_bug.cgi?id=194287
954
955         Reviewed by Philippe Normand.
956
957         python3-setuptools is needed to build meson in jhbuild.
958         It is already required by the GTK port.
959
960         * wpe/install-dependencies:
961
962 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
963
964         [ews-app] Add method to save BuilderMapping to database
965         https://bugs.webkit.org/show_bug.cgi?id=194264
966
967         Reviewed by Lucas Forschler.
968
969         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
970         (BuilderMapping.__str__):
971         (BuilderMapping):
972         (BuilderMapping.save_mapping):
973         (BuilderMapping.update_mapping):
974         (BuilderMapping.get_existing_mapping):
975         (BuilderMapping.is_valid_mapping):
976
977 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
978
979         [ews-app] Add timestamp fields for BuilderMappings
980         https://bugs.webkit.org/show_bug.cgi?id=194266
981
982         Reviewed by Lucas Forschler.
983
984         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
985         (BuilderMapping):
986
987 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
988
989         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
990         https://bugs.webkit.org/show_bug.cgi?id=174816
991
992         Reviewed by Michael Catanzaro.
993
994         Add tests for webkit_uri_for_display().
995
996         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
997         (testURIForDisplayUnaffected):
998         (testURIForDisplayAffected):
999         (beforeAll):
1000         (afterAll):
1001         * TestWebKitAPI/glib/CMakeLists.txt:
1002
1003 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1004
1005         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1006         https://bugs.webkit.org/show_bug.cgi?id=194158
1007         <rdar://problem/47737268>
1008
1009         Rubber-stamped by Aakash Jain.
1010
1011         * Scripts/webkitpy/port/device_port.py:
1012         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1013
1014 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1015
1016         [CG] Enable setAdditionalSupportedImageTypes for WK1
1017         https://bugs.webkit.org/show_bug.cgi?id=194190
1018
1019         Reviewed by Tim Horton.
1020
1021         Add a test similar to the one under WebKit Cocoa but make it create a
1022         WebView instead of a WKWebView.
1023
1024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1025         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1026         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1027         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1028         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1029         (TestWebKitAPI::runTest):
1030         (TestWebKitAPI::TEST):
1031
1032 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1033
1034         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1035         https://bugs.webkit.org/show_bug.cgi?id=194168
1036
1037         Reviewed by Simon Fraser.
1038
1039         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1040
1041         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1042         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1043         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1044         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1045         (TEST):
1046         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1047         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1048
1049 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1050
1051         REGRESSION (r237269): webkit-patch what-broke is broken 
1052         https://bugs.webkit.org/show_bug.cgi?id=193025
1053
1054         Reviewed by Aakash Jain.
1055
1056         * Scripts/webkitpy/common/host.py:
1057         (Host.buildbot):
1058         (Host.bugzilla): Renamed to 'buildbot'.
1059
1060 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1061
1062         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1063         https://bugs.webkit.org/show_bug.cgi?id=194207
1064
1065         Reviewed by Tim Horton.
1066
1067         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1068         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1069         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1070         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1071         start and delete forwards to remove the original attachment.
1072
1073         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1074         (TestWebKitAPI::TEST):
1075
1076 2019-02-04  Youenn Fablet  <youenn@apple.com>
1077
1078         Capture state should be managed consistently when doing process swapping
1079         https://bugs.webkit.org/show_bug.cgi?id=194122
1080         <rdar://problem/47609293>
1081
1082         Reviewed by Eric Carlson.
1083
1084         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1085         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1086         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1087         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1088         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1089         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1090         (WTR::TestRunner::isDoingMediaCapture const):
1091         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1092         * WebKitTestRunner/TestController.cpp:
1093         (WTR::TestController::isDoingMediaCapture const):
1094         * WebKitTestRunner/TestController.h:
1095         * WebKitTestRunner/TestInvocation.cpp:
1096         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1097         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1098         (WTR::TestController::isDoingMediaCapture const):
1099
1100 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1101
1102         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1103         https://bugs.webkit.org/show_bug.cgi?id=194142
1104
1105         Reviewed by Ross Kirsling.
1106
1107         There three 'separator' variables in TestController.cpp. Renamed
1108         it 'pathSeparator', and unified them.
1109
1110         * WebKitTestRunner/TestController.cpp:
1111         (WTR::TestController::generateContextConfiguration const):
1112         (WTR::createTestURL):
1113         (WTR::TestController::platformAdjustContext):
1114
1115 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1116
1117         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1118         https://bugs.webkit.org/show_bug.cgi?id=194198
1119
1120         Reviewed by Antti Koivisto.
1121
1122         No need to set the banner heights on navigation now, since Page stores them.
1123
1124         * MiniBrowser/mac/WK2BrowserWindowController.m:
1125         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1126
1127 2019-02-03  John Wilander  <wilander@apple.com>
1128
1129         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1130         https://bugs.webkit.org/show_bug.cgi?id=194104
1131         <rdar://problem/47649991>
1132
1133         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1134
1135         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1136         (TestWebKitAPI::TEST):
1137             Changed numeric types from unsigned short to uint32_t.
1138
1139 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1140
1141         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1142         <https://webkit.org/b/194178>
1143         <rdar://problem/47753473>
1144
1145         Reviewed by Alexey Proskuryakov.
1146
1147         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1148         (WTR::uninstallFakeHelvetica): Pass nullptr into
1149         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1150
1151 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1152
1153         [LFC] Initialize ICB's style with fixed width/height.
1154         https://bugs.webkit.org/show_bug.cgi?id=194188
1155
1156         Reviewed by Antti Koivisto.
1157
1158         * LayoutReloaded/misc/LFC-passing-tests.txt:
1159
1160 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1161
1162         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1163         https://bugs.webkit.org/show_bug.cgi?id=194185
1164
1165         Reviewed by Antti Koivisto.
1166
1167         * LayoutReloaded/misc/LFC-passing-tests.txt:
1168
1169 2018-12-16  Darin Adler  <darin@apple.com>
1170
1171         Convert additional String::format clients to alternative approaches
1172         https://bugs.webkit.org/show_bug.cgi?id=192746
1173
1174         Reviewed by Alexey Proskuryakov.
1175
1176         * WebKitTestRunner/TestController.cpp:
1177         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1178         as an intermediate in code that ultimately constructs a WTF::String.
1179         (WTR::userMediaOriginHash): Use makeString.
1180         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1181         (WTR::TestController::didPerformClientRedirect): Ditto.
1182         (WTR::TestController::didPerformServerRedirect): Ditto.
1183         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1184
1185 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1186
1187         [ews-build] Add unit test to verify builder keys
1188         https://bugs.webkit.org/show_bug.cgi?id=194152
1189
1190         Reviewed by Lucas Forschler.
1191
1192         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1193         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1194
1195 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1196
1197         [LFC] Expand tests coverage (12 new tests -> 787)
1198
1199         Unreviewed test gardening.
1200
1201         * LayoutReloaded/misc/LFC-passing-tests.txt:
1202
1203 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1204
1205         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1206         https://bugs.webkit.org/show_bug.cgi?id=194163
1207
1208         Reviewed by Simon Fraser.
1209
1210         775
1211
1212         * LayoutReloaded/misc/LFC-passing-tests.txt:
1213
1214 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1215
1216         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1217         https://bugs.webkit.org/show_bug.cgi?id=194140
1218         <rdar://problem/47728098>
1219
1220         Reviewed by Tim Horton.
1221
1222         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1223         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1224         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1225
1226         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1227         test to induce an IPC deadlock when presenting a modal alert during touch start.
1228
1229         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1230         * WebKitTestRunner/TestController.cpp:
1231         (WTR::runJavaScriptAlert):
1232
1233         Add a client callback function for running JavaScript alerts.
1234
1235         (WTR::TestController::createOtherPage):
1236         (WTR::TestController::generateContextConfiguration const):
1237
1238         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1239         the fix in this patch.
1240
1241         (WTR::TestController::createWebViewWithOptions):
1242
1243         Plumb TestOptions to generateContextConfiguration.
1244
1245         (WTR::TestController::resetPreferencesToConsistentValues):
1246         (WTR::TestController::resetStateToConsistentValues):
1247         (WTR::updateTestOptionsFromTestHeader):
1248         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1249         (WTR::TestController::handleJavaScriptAlert):
1250         * WebKitTestRunner/TestController.h:
1251         * WebKitTestRunner/TestInvocation.cpp:
1252         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1253         * WebKitTestRunner/TestOptions.h:
1254         (WTR::TestOptions::hasSameInitializationOptions const):
1255
1256 2019-02-01  Chris Dumez  <cdumez@apple.com>
1257
1258         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1259         https://bugs.webkit.org/show_bug.cgi?id=193740
1260         <rdar://problem/47527267>
1261
1262         Reviewed by Alex Christensen.
1263
1264         Add API test coverage.
1265
1266         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1267
1268 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1269
1270         [ews-app] Add display name field to BuilderMapping model
1271         https://bugs.webkit.org/show_bug.cgi?id=194153
1272
1273         Reviewed by Lucas Forschler.
1274
1275         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1276         (BuilderMapping):
1277
1278 2019-02-01  Youenn Fablet  <youenn@apple.com>
1279
1280         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1281         https://bugs.webkit.org/show_bug.cgi?id=194155
1282
1283         Reviewed by Eric Carlson.
1284
1285         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1286         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1287         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1288
1289 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1290
1291         [LFC] Adjust replaced element's intrinsic ratio
1292         https://bugs.webkit.org/show_bug.cgi?id=194154
1293
1294         Reviewed by Antti Koivisto.
1295
1296         761
1297
1298         * LayoutReloaded/misc/LFC-passing-tests.txt:
1299
1300 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1301
1302         [WPE] Show test results in minibrowser
1303         https://bugs.webkit.org/show_bug.cgi?id=194150
1304
1305         Reviewed by Žan Doberšek.
1306
1307         * Scripts/webkitpy/port/wpe.py:
1308         (WPEPort.show_results_html_file):
1309
1310 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1311
1312         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1313         https://bugs.webkit.org/show_bug.cgi?id=194151
1314
1315         Reviewed by Žan Doberšek.
1316
1317         ALT + <- go back
1318         ALT + -> go forward
1319
1320         * MiniBrowser/wpe/main.cpp:
1321         (main):
1322
1323 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1324
1325         [LFC] Set intrinsic size on Layout::Replaced
1326         https://bugs.webkit.org/show_bug.cgi?id=194139
1327
1328         Reviewed by Antti Koivisto.
1329
1330         744
1331
1332         * LayoutReloaded/misc/LFC-passing-tests.txt:
1333
1334 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1335
1336         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1337         https://bugs.webkit.org/show_bug.cgi?id=194146
1338
1339         Reviewed by Xabier Rodriguez-Calvar.
1340
1341         It allows to open relative paths.
1342
1343         * MiniBrowser/wpe/main.cpp:
1344         (main):
1345
1346 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1347
1348         Update flakiness dashboard configuration after recent queue changes
1349         https://bugs.webkit.org/show_bug.cgi?id=194127
1350
1351         Rubber-stamped by Aakash Jain.
1352
1353         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1354
1355         * TestResultServer/static-dashboards/builders.jsonp:
1356
1357 2019-01-31  Youenn Fablet  <youenn@apple.com>
1358
1359         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1360         https://bugs.webkit.org/show_bug.cgi?id=194106
1361         <rdar://problem/47676333>
1362
1363         Reviewed by Ryosuke Niwa.
1364
1365         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1366         (TestWebKitAPI::didFinishNavigation):
1367         (TestWebKitAPI::TEST):
1368         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1369
1370 2019-01-31  Chris Dumez  <cdumez@apple.com>
1371
1372         Page zoom level is lost after a process swap or a crash
1373         https://bugs.webkit.org/show_bug.cgi?id=194105
1374         <rdar://problem/47610781>
1375
1376         Reviewed by Alex Christensen.
1377
1378         Add API test coverage.
1379
1380         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1381         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1382
1383 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1384
1385         Revert r238819 which is unneeded and caused a performance regression.
1386         https://bugs.webkit.org/show_bug.cgi?id=192272
1387         <rdar://problem/46664625>
1388
1389         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1390         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1391         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1392
1393 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1394
1395         Formalize WebKitAdditions mechanism of LoadOptimizer
1396         https://bugs.webkit.org/show_bug.cgi?id=193886
1397         <rdar://problem/47696809>
1398
1399         Reviewed by Brent Fulgham.
1400
1401         * MiniBrowser/MiniBrowser.entitlements:
1402         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1403
1404 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1405
1406         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1407         https://bugs.webkit.org/show_bug.cgi?id=194090
1408
1409         Reviewed by Antti Koivisto.
1410
1411         * LayoutReloaded/misc/LFC-passing-tests.txt:
1412
1413 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1414
1415         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1416         https://bugs.webkit.org/show_bug.cgi?id=194074
1417
1418         Reviewed by Antti Koivisto.
1419
1420         * LayoutReloaded/misc/LFC-passing-tests.txt:
1421
1422 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1423
1424         [LFC][BFC] Add support for block level replaced box.
1425         https://bugs.webkit.org/show_bug.cgi?id=194071
1426
1427         Reviewed by Antti Koivisto.
1428
1429         * LayoutReloaded/misc/LFC-passing-tests.txt:
1430
1431 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1432
1433         Fix WebKitTestRunner's testPath with Windows full paths
1434         https://bugs.webkit.org/show_bug.cgi?id=194012
1435
1436         Reviewed by Alex Christensen.
1437
1438         updateTestOptionsFromTestHeader failed to open test files because
1439         testPath returned wrong file paths. It returned a path "/C:/..."
1440         if a URL "file:///C:/..." was given.
1441
1442         * WebKitTestRunner/TestController.cpp:
1443         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1444
1445 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1446
1447         [WPE] Bump font related dependencies to match the GTK+ port
1448         https://bugs.webkit.org/show_bug.cgi?id=194017
1449
1450         Reviewed by Žan Doberšek.
1451
1452         * wpe/jhbuild.modules:
1453         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1454         * wpe/patches/icudata-stdlibs.patch: Added.
1455
1456 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1457
1458         Enable swipe tests on iOS
1459         https://bugs.webkit.org/show_bug.cgi?id=194076
1460
1461         Reviewed by Geoffrey Garen.
1462
1463         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1464         it causes a debug assertion failure in runUIScript.
1465
1466         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1467         (WTR::UIScriptController::beginBackSwipe):
1468         (WTR::UIScriptController::completeBackSwipe):
1469
1470 2019-01-30  Keith Rollin  <krollin@apple.com>
1471
1472         Use correct printf format specifier
1473         https://bugs.webkit.org/show_bug.cgi?id=194062
1474         <rdar://problem/47686167>
1475
1476         Reviewed by Alexey Proskuryakov.
1477
1478         LayoutTestSpellChecker.mm is trying to format a variable of type
1479         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1480         actually an unsigned long long. Fix this by formatting with %llu.
1481
1482         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1483         (-[LayoutTestTextCheckingResult description]):
1484
1485 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1486
1487         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1488         https://bugs.webkit.org/show_bug.cgi?id=193979
1489
1490         Reviewed by Wenson Hsieh.
1491
1492         Fix the test for iOS. Make the test work with iOS UA string.
1493
1494         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1495
1496 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1497
1498         Replace High Sierra LLINT CLoop bot due to hardware failure
1499         https://bugs.webkit.org/show_bug.cgi?id=194066
1500
1501         Reviewed by Aakash Jain.
1502
1503         * BuildSlaveSupport/build.webkit.org-config/config.json:
1504
1505 2019-01-30  Keith Rollin  <krollin@apple.com>
1506
1507         [NSDragItem init] is unavailable
1508         https://bugs.webkit.org/show_bug.cgi?id=194059
1509         <rdar://problem/47685715>
1510
1511         Reviewed by Wenson Hsieh.
1512
1513         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1514         DumpRenderTree and TestWebKitAPI, which both try to create an
1515         NSDragItem in a manner that invokes this method. Address this by using
1516         -initWithPasteboardWriter instead.
1517
1518         Note that the parameter passed to initWithPasteboardWriter is likely
1519         incorrect. In both cases, the object passed does not conform to
1520         NSPasteboardWriting. However, with this fix, we're no worse off than
1521         before, and can now perform builds with newer compilers and SDKs until
1522         a real fix can be crafted. That work is tracked in
1523         https://bugs.webkit.org/show_bug.cgi?id=194060
1524
1525         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1526         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1527         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1528         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1529
1530 2019-01-30  Daniel Bates  <dabates@apple.com>
1531
1532         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1533         https://bugs.webkit.org/show_bug.cgi?id=192824
1534         <rdar://problem/47100332>
1535
1536         Reviewed by Wenson Hsieh.
1537
1538         Fix a bug where the wrong usage code was used for F13 thru F24.
1539
1540         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1541         (keyCodeForDOMFunctionKey):
1542
1543 2019-01-30  Chris Dumez  <cdumez@apple.com>
1544
1545         Regression(PSON) Load hang can occur on history navigation
1546         https://bugs.webkit.org/show_bug.cgi?id=194030
1547         <rdar://problem/47656939>
1548
1549         Reviewed by Antti Koivisto.
1550
1551         Add API test coverage.
1552
1553         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1554
1555 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1556
1557         [LFC] Expand tests coverage.
1558
1559         Unreviewed test gardening.
1560
1561         * LayoutReloaded/misc/LFC-passing-tests.txt:
1562
1563 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1564
1565         [Flatpak] Add openjpeg support
1566         https://bugs.webkit.org/show_bug.cgi?id=194019
1567
1568         Reviewed by Michael Catanzaro.
1569
1570         * flatpak/org.webkit.CommonModules.yaml:
1571
1572 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1573
1574         Unreviewed, rolling out r240708.
1575         https://bugs.webkit.org/show_bug.cgi?id=194022
1576
1577         It broke WPE build (Requested by KaL on #webkit).
1578
1579         Reverted changeset:
1580
1581         "[WPE] Bump font related dependencies to match the GTK+ port"
1582         https://bugs.webkit.org/show_bug.cgi?id=194017
1583         https://trac.webkit.org/changeset/240708
1584
1585 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1586
1587         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1588         https://bugs.webkit.org/show_bug.cgi?id=194001
1589
1590         Reviewed by Antti Koivisto.
1591
1592         * LayoutReloaded/misc/LFC-passing-tests.txt:
1593
1594 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1595
1596         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1597         https://bugs.webkit.org/show_bug.cgi?id=194020
1598
1599         Reviewed by Antti Koivisto.
1600
1601         * LayoutReloaded/misc/LFC-passing-tests.txt:
1602
1603 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1604
1605         AX: Support color well on iOS
1606         https://bugs.webkit.org/show_bug.cgi?id=194010
1607
1608         Reviewed by Joanmarie Diggs.
1609
1610         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1611         (WTR::AccessibilityUIElement::stringAttributeValue):
1612
1613 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1614
1615         [WPE] Bump font related dependencies to match the GTK+ port
1616         https://bugs.webkit.org/show_bug.cgi?id=194017
1617
1618         Reviewed by Žan Doberšek.
1619
1620         * wpe/jhbuild.modules:
1621         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1622         * wpe/patches/icudata-stdlibs.patch: Added.
1623
1624 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1625
1626         [Mac] Update window scale API usage
1627         https://bugs.webkit.org/show_bug.cgi?id=193991
1628         rdar://problem/47614795
1629
1630         Reviewed by Tim Horton.
1631
1632         * DumpRenderTree/mac/DumpRenderTree.mm:
1633         (changeWindowScaleIfNeeded):
1634         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1635         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1636         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1637
1638 2019-01-29  Chris Dumez  <cdumez@apple.com>
1639
1640         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1641         https://bugs.webkit.org/show_bug.cgi?id=193977
1642         <rdar://problem/47643716>
1643
1644         Reviewed by Geoff Garen.
1645
1646         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1647         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1648         to the previous provisional committing *before* we make the last load. 
1649
1650         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1651
1652 2019-01-29  Youenn Fablet  <youenn@apple.com>
1653
1654         Adopt new SPI to evaluate server certificate trust
1655         https://bugs.webkit.org/show_bug.cgi?id=193355
1656
1657         Reviewed by Alex Christensen.
1658
1659         Add infrastructure to handle HTTPS server trust evaluation testing.
1660
1661         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1662         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1663         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1664         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1665         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1666         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1667         * WebKitTestRunner/TestController.cpp:
1668         (WTR::TestController::resetPreferencesToConsistentValues):
1669         (WTR::TestController::didReceiveAuthenticationChallenge):
1670         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1671         * WebKitTestRunner/TestController.h:
1672         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1673         * WebKitTestRunner/TestInvocation.cpp:
1674         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1675         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1676         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1677
1678 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1679
1680         [ews-build] Add build step to print bot Configuration
1681         https://bugs.webkit.org/show_bug.cgi?id=193887
1682
1683         Reviewed by Lucas Forschler.
1684
1685         * BuildSlaveSupport/ews-build/steps.py:
1686         (PrintConfiguration): Build step to print configuration.
1687         * BuildSlaveSupport/ews-build/factories.py:
1688
1689 2019-01-29  Chris Dumez  <cdumez@apple.com>
1690
1691         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1692         https://bugs.webkit.org/show_bug.cgi?id=193967
1693         <rdar://problem/47635348>
1694
1695         Reviewed by Alex Christensen.
1696
1697         Add API test coverage.
1698
1699         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1700         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1701
1702 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1703
1704         [ews-app] Handle incoming results data
1705         https://bugs.webkit.org/show_bug.cgi?id=193973
1706
1707         Reviewed by Lucas Forschler.
1708
1709         * BuildSlaveSupport/ews-app/ews/views/results.py:
1710
1711 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1712
1713         [ews-app] Make the results url generic
1714         https://bugs.webkit.org/show_bug.cgi?id=193928
1715
1716         Reviewed by Lucas Forschler.
1717
1718         * BuildSlaveSupport/ews-app/ews/urls.py:
1719
1720 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1721
1722         [ews-build] Configure buildbot to send events to ews-app
1723         https://bugs.webkit.org/show_bug.cgi?id=193968
1724
1725         Reviewed by Lucas Forschler.
1726
1727         * BuildSlaveSupport/ews-build/events.py: Added.
1728         * BuildSlaveSupport/ews-build/master.cfg:
1729
1730 2019-01-29  Keith Rollin  <krollin@apple.com>
1731
1732         Add .xcfilelists to Run Script build phases
1733         https://bugs.webkit.org/show_bug.cgi?id=193792
1734         <rdar://problem/47201785>
1735
1736         Reviewed by Alex Christensen.
1737
1738         As part of supporting XCBuild, update the necessary Run Script build
1739         phases in their Xcode projects to refer to their associated
1740         .xcfilelist files.
1741
1742         Note that the addition of these files bumps the Xcode project version
1743         number to something that's Xcode 10 compatible. This change means that
1744         older versions of the Xcode IDE can't read these projects. Nor can it
1745         fully load workspaces that refer to these projects (the updated
1746         projects are shown as non-expandable placeholders). `xcodebuild` can
1747         still build these projects; it's just that the IDE can't open them.
1748
1749         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1750         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1751
1752 2019-01-29  John Wilander  <wilander@apple.com>
1753
1754         Add data abstraction and validation for Ad Click Attribution
1755         https://bugs.webkit.org/show_bug.cgi?id=193916
1756         <rdar://problem/47603481>
1757
1758         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1759
1760         Ad click attribution has two steps. First, the storage of an ad
1761         campaign ID for a click that takes the user to a destination
1762         site. Second, a conversion on the destination site that can be
1763         attributed to the ad click.
1764
1765         This patch adds a class that represents a request for ad click
1766         attribution. Validation makes sure that the bits of entropy
1767         reported through this mechanism is limited.
1768
1769         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1770         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1771         (TestWebKitAPI::TEST):
1772
1773 2019-01-29  Chris Dumez  <cdumez@apple.com>
1774
1775         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1776         https://bugs.webkit.org/show_bug.cgi?id=193932
1777         <rdar://problem/47598947>
1778
1779         Reviewed by Brady Eidson.
1780
1781         Add API test coverage.
1782
1783         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1784
1785 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1786
1787         Adding new passing LFC tests.
1788
1789         Unreviewed test gardening.
1790
1791         * LayoutReloaded/misc/LFC-passing-tests.txt:
1792
1793 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1794
1795         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1796         https://bugs.webkit.org/show_bug.cgi?id=193964
1797
1798         Reviewed by Antti Koivisto.
1799
1800         * LayoutReloaded/misc/LFC-passing-tests.txt:
1801
1802 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1803
1804         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1805         https://bugs.webkit.org/show_bug.cgi?id=193954
1806
1807         Reviewed by Antti Koivisto.
1808
1809         * LayoutReloaded/misc/LFC-passing-tests.txt:
1810
1811 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1812
1813         WebDriver: add support for running subtests
1814         https://bugs.webkit.org/show_bug.cgi?id=193904
1815
1816         Reviewed by Michael Catanzaro.
1817
1818         pytest already supports it by passing test.py::subtest, so we can do the same.
1819
1820         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1821         (get_item_name): Made this global.
1822         (CollectRecorder.__init__): Receive the parameter to ignore.
1823         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1824         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1825         (collect): Add parameter to ignore.
1826         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1827         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1828         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1829         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1830         (WebDriverTestRunnerSelenium.run): Ditto.
1831         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1832         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1833         (WebDriverTestRunnerW3C.run): Ditto.
1834
1835 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1836
1837         User agent string override for navigator.userAgent should be site specific quirks
1838         https://bugs.webkit.org/show_bug.cgi?id=193950
1839
1840         Reviewed by Brent Fulgham.
1841
1842         Updated per the _WKWebsitePolicies rename.
1843
1844         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1845         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1846
1847 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1848
1849         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1850         https://bugs.webkit.org/show_bug.cgi?id=193941
1851
1852         Reviewed by Alex Christensen.
1853
1854         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1855         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1856         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1857         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1858         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1859         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1860         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1861         * TestWebKitAPI/Tests/WTF/Time.cpp:
1862         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1863         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1864         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1865         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1866
1867 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1868
1869         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1870
1871         * Scripts/webkitpy/common/config/contributors.json:
1872
1873 2019-01-28  Andy Estes  <aestes@apple.com>
1874
1875         [watchOS] Enable Parental Controls content filtering
1876         https://bugs.webkit.org/show_bug.cgi?id=193939
1877         <rdar://problem/46641912>
1878
1879         Reviewed by Ryosuke Niwa.
1880
1881         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1882
1883 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1884
1885         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1886         <https://webkit.org/b/193884>
1887
1888         Reviewed by Jiewen Tan.
1889
1890         * Scripts/webkitpy/style/checkers/cpp.py:
1891         (check_language): Add LocalAuthentication to
1892         `frameworks_with_soft_links`.
1893
1894 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1895
1896         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1897         https://bugs.webkit.org/show_bug.cgi?id=193891
1898
1899         Reviewed by Ross Kirsling.
1900
1901         There were three problems in window sizes of WebView and the host window.
1902         1. The sizes of pixel image output were incorrect.
1903         2. The host window is going to appear after window.resize was invoked.
1904         3. window.resize resized only the host window, not WebView.
1905
1906         This change solves them with a following approach.
1907         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1908         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1909            as well as DumpRenderTree in order to match the client area and the window area.
1910         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1911         d. PlatformWebView::setWindowFrame changes both window sizes.
1912         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1913
1914         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1915         (WTR::PlatformWebView::PlatformWebView): Create the host window
1916         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1917         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1918         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1919
1920 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1921
1922         [ews-app] Add method to save Step data to database
1923         https://bugs.webkit.org/show_bug.cgi?id=193890
1924
1925         Reviewed by Lucas Forschler.
1926
1927         * BuildSlaveSupport/ews-app/ews/models/step.py:
1928         (Step.save_step): Method to save step data.
1929         (Step.update_step): Method to update step data.
1930         (Step.get_existing_step): Method to fetch existing step from database.
1931         (Step.is_valid_result): Method to validate valid step result.
1932
1933 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1934
1935         [ews-app] Add method to save Build data to database
1936         https://bugs.webkit.org/show_bug.cgi?id=193735
1937
1938         Reviewed by Lucas Forschler.
1939
1940         * BuildSlaveSupport/ews-app/ews/models/build.py:
1941         (Build.save_build): Method to save build information to database.
1942         (Build.get_existing_build): Method to fetch existing build from database.
1943         (Build.is_valid_result): Method to validate build result.
1944         * BuildSlaveSupport/ews-app/ews/common/util.py:
1945         (is_valid_int_id): Method to validate valid id.
1946
1947 2019-01-28  Chris Dumez  <cdumez@apple.com>
1948
1949         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1950         https://bugs.webkit.org/show_bug.cgi?id=193915
1951         <rdar://problem/47560907>
1952
1953         Reviewed by Alex Christensen.
1954
1955         Add API test coverage.
1956
1957         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1958
1959 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1960
1961         [ews-app] Rename id variables
1962         https://bugs.webkit.org/show_bug.cgi?id=193883
1963
1964         Reviewed by Lucas Forschler.
1965
1966         * BuildSlaveSupport/ews-app/ews/models/build.py:
1967         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1968         * BuildSlaveSupport/ews-app/ews/models/step.py:
1969         * BuildSlaveSupport/ews-app/ews/urls.py:
1970         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1971         * BuildSlaveSupport/ews-app/ews/views/results.py:
1972         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1973
1974 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1975
1976         [ews-app] Allow certain fields to be empty
1977         https://bugs.webkit.org/show_bug.cgi?id=193892
1978
1979         Reviewed by Lucas Forschler.
1980
1981         * BuildSlaveSupport/ews-app/ews/models/build.py:
1982         * BuildSlaveSupport/ews-app/ews/models/step.py:
1983
1984 2019-01-28  Rob Buis  <rbuis@igalia.com>
1985
1986         Update MIME type parser
1987         https://bugs.webkit.org/show_bug.cgi?id=180526
1988
1989         Reviewed by Frédéric Wang.
1990
1991         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1992         (TestWebKitAPI::TEST):
1993
1994 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1995
1996         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1997         https://bugs.webkit.org/show_bug.cgi?id=193896
1998
1999         Reviewed by Antti Koivisto.
2000
2001         * LayoutReloaded/misc/LFC-passing-tests.txt:
2002
2003 2018-12-15  Darin Adler  <darin@apple.com>
2004
2005         Replace many uses of String::format with more type-safe alternatives
2006         https://bugs.webkit.org/show_bug.cgi?id=192742
2007
2008         Reviewed by Mark Lam.
2009
2010         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2011         (WTR::cacheTestRunnerCallback): Use makeString.
2012         * WebKitTestRunner/TestController.cpp:
2013         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2014         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2015
2016 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2017
2018         Use a load optimizer for some sites
2019         https://bugs.webkit.org/show_bug.cgi?id=193881
2020         <rdar://problem/46325455>
2021
2022         Reviewed by Brent Fulgham.
2023
2024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2025         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2026
2027 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2028
2029         AX: Introduce a static accessibility tree
2030         https://bugs.webkit.org/show_bug.cgi?id=193348
2031         <rdar://problem/47203295>
2032
2033         Reviewed by Ryosuke Niwa.
2034
2035         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2036
2037 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2038
2039         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2040         https://bugs.webkit.org/show_bug.cgi?id=193867
2041
2042         Reviewed by Antti Koivisto.
2043
2044         * LayoutReloaded/misc/LFC-passing-tests.txt:
2045
2046 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2047
2048         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2049         https://bugs.webkit.org/show_bug.cgi?id=193865
2050
2051         Reviewed by Antti Koivisto.
2052
2053         * LayoutReloaded/misc/LFC-passing-tests.txt:
2054
2055 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2056
2057         Need a mechanism to override navigator.userAgent
2058         https://bugs.webkit.org/show_bug.cgi?id=193762
2059         <rdar://problem/47504939>
2060
2061         Reviewed by Brent Fulgham.
2062
2063         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2064
2065         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2066         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2067         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2068
2069 2019-01-25  Dean Jackson  <dino@apple.com>
2070
2071         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2072         https://bugs.webkit.org/show_bug.cgi?id=193831
2073         <rdar://problem/47399263>
2074
2075         Reviewed by Chris Dumez.
2076
2077         Two new tests that exercise cross-origin and same-origin System
2078         Previews.
2079
2080         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2081
2082 2019-01-25  Keith Rollin  <krollin@apple.com>
2083
2084         Update Xcode projects with "Check .xcfilelists" build phase
2085         https://bugs.webkit.org/show_bug.cgi?id=193790
2086         <rdar://problem/47201374>
2087
2088         Reviewed by Alex Christensen.
2089
2090         Support for XCBuild includes specifying inputs and outputs to various
2091         Run Script build phases. These inputs and outputs are specified as
2092         .xcfilelist files. Once created, these .xcfilelist files need to be
2093         kept up-to-date. In order to check that they are up-to-date or not,
2094         add an Xcode build step that invokes an external script that performs
2095         the checking. If the .xcfilelists are found to be out-of-date, update
2096         them, halt the build, and instruct the developer to restart the build
2097         with up-to-date files.
2098
2099         At this time, the checking and regenerating is performed only if the
2100         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2101         who want to use this facility can set this variable and test out the
2102         checking/regenerating. Once it seems like there are no egregious
2103         issues that upset a developer's workflow, we'll unconditionally enable
2104         this facility.
2105
2106         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2107         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2108         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2109         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2110
2111 2019-01-25  Keith Rollin  <krollin@apple.com>
2112
2113         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2114         https://bugs.webkit.org/show_bug.cgi?id=193781
2115         <rdar://problem/47201153>
2116
2117         Reviewed by Alex Christensen.
2118
2119         Part of generating the .xcfilelists used as part of adopting XCBuild
2120         includes running `make DerivedSources.make` from a standalone script.
2121         It’s important for this invocation to have the same environment as
2122         when the actual build invokes `make DerivedSources.make`. If the
2123         environments are different, then the two invocations will provide
2124         different results. In order to get the same environment in the
2125         standalone script, have the script launch xcodebuild targeting the
2126         "Apply Configuration to XCFileLists" build target, which will then
2127         re-invoke our standalone script. The script is now running again, this
2128         time in an environment with all workspace, project, target, xcconfig
2129         and other environment variables established.
2130
2131         The "Apply Configuration to XCFileLists" build target accomplishes
2132         this task via a small embedded shell script that consists only of:
2133
2134             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2135
2136         The process that invokes "Apply Configuration to XCFileLists" first
2137         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2138         evaluated and exports it into the shell environment. When xcodebuild
2139         is invoked, it inherits the value of this variable and can `eval` the
2140         contents of that variable. Our external standalone script can then set
2141         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2142         of command-line parameters needed to restart itself in the appropriate
2143         state.
2144
2145         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2146         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2147
2148 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2149
2150         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2151         https://bugs.webkit.org/show_bug.cgi?id=193802
2152         <rdar://problem/46010580>
2153
2154         Reviewed by Andy Estes.
2155
2156         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2157         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2158         (TEST):
2159
2160 2019-01-25  Daniel Bates  <dabates@apple.com>
2161
2162         [iOS] uiController.keyDown() does not translate Control modified key
2163         https://bugs.webkit.org/show_bug.cgi?id=192898
2164
2165         Reviewed by Wenson Hsieh.
2166
2167         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2168         key translation, as applicable. Among other cases, key translation occurs when performing
2169         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2170         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2171         human pressing down and releasing key(s) using a hardware keyboard.
2172
2173         * WebKitTestRunner/ios/HIDEventGenerator.h:
2174         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2175         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2176
2177         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2178         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2179         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2180         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2181         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2182         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2183         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2184         (-[HIDEventGenerator longPress:completionBlock:]):
2185         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2186         Update code for above renaming.
2187
2188         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2189         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2190
2191         (-[HIDEventGenerator keyDown:]): Added.
2192         (-[HIDEventGenerator keyUp:]): Added.
2193         (-[HIDEventGenerator keyPress:completionBlock:]):
2194         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2195         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2196         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2197         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2198         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2199         (WTR::parseModifier): Deleted.
2200
2201 2019-01-25  Keith Rollin  <krollin@apple.com>
2202
2203         Complete the implementation of generate-xcfilelists
2204         https://bugs.webkit.org/show_bug.cgi?id=193782
2205
2206         Reviewed by Alex Christensen.
2207
2208         A preliminary version of generate-xcfilelists was added in r238008.
2209         This patch updates that script in order to:
2210
2211         - Support checking of .xcfilelists
2212         - Perform better execution of `make DerivedSources.make` by
2213           relaunching generate-xcfilelists under xcodebuild
2214         - Support incremental generation and checking of .xcfilelists
2215         - Support supplementary .xcfilelists files from WebKitAdditions
2216         - Support being wrapped by parallel version of generate-xcfilelists in
2217           Internal that adds support for (re)generating WebKit projects in
2218           that repo.
2219         - Support builds that have been performed in WebKitBuild as well as
2220           ~/Library/Developer/code/DerivedData
2221         - Increase robustness and debugging facilities.
2222
2223         * Scripts/generate-xcfilelists:
2224
2225 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2226
2227         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2228         https://bugs.webkit.org/show_bug.cgi?id=193297
2229         <rdar://problem/47158841>
2230
2231         Unreviewed test case fix.
2232
2233         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2234         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2235
2236         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2237         (TEST):
2238
2239 2019-01-25  Keith Rollin  <krollin@apple.com>
2240
2241         Update existing .xcfilelists
2242         https://bugs.webkit.org/show_bug.cgi?id=193791
2243         <rdar://problem/47201706>
2244
2245         Reviewed by Alex Christensen.
2246
2247         Many .xcfilelist files were added in r238824 in order to support
2248         XCBuild. Update these with recent changes to the set of build files
2249         and with the current generate-xcfilelist script.
2250
2251         * DumpRenderTree/DerivedSources-input.xcfilelist:
2252         * DumpRenderTree/DerivedSources-output.xcfilelist:
2253         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2254         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2255
2256 2019-01-25  Keith Rollin  <krollin@apple.com>
2257
2258         Fix missing dependencies in extract-dependencies-from-makefile
2259         https://bugs.webkit.org/show_bug.cgi?id=193783
2260         <rdar://problem/47201571>
2261
2262         Reviewed by Alex Christensen.
2263
2264         The extract-dependencies-from-makefile script generates .xcfilelists
2265         for XCBuild by invoking a makefile in --debug mode, parsing the
2266         dependency information in the output, and extracting information
2267         regarding targets and dependents. However, the way `make` emits this
2268         dependency information is not rigorous, and so we need to determine
2269         what lines to look for and parse by trial and error. This approach
2270         didn't coriginally atch all the information we needed to collect, so
2271         update the script to look for the additional lines we now know to look
2272         for.
2273
2274         * Scripts/extract-dependencies-from-makefile:
2275         (Parser):
2276         (Parser.addTarget):
2277         (Parser.addPrereq):
2278         (Parser.doParse):
2279
2280 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2281
2282         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2283         https://bugs.webkit.org/show_bug.cgi?id=193297
2284         <rdar://problem/47158841>
2285
2286         Reviewed by Alex Christensen.
2287
2288         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2289             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2290         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2291         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2292         activating the message used to trigger the callback when it is set.
2293
2294 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2295
2296         WKWebView.goBack should reload if there is a safe browsing warning
2297         https://bugs.webkit.org/show_bug.cgi?id=193805
2298         <rdar://problem/46908216>
2299
2300         Reviewed by Geoff Garen.
2301
2302         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2303         (+[Simple3LookupContext sharedLookupContext]):
2304         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2305         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2306         (TEST):
2307
2308 2019-01-25  Chris Dumez  <cdumez@apple.com>
2309
2310         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2311         https://bugs.webkit.org/show_bug.cgi?id=193788
2312         <rdar://problem/47531231>
2313
2314         Reviewed by Alex Christensen.
2315
2316         Add API test coverage.
2317
2318         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2319         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2320
2321 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2322
2323         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2324         https://bugs.webkit.org/show_bug.cgi?id=193771
2325
2326         Unreviewed infrastructure fix.
2327
2328         * Scripts/webkitpy/port/darwin.py:
2329         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2330
2331 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2332
2333         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2334
2335 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2336
2337         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2338
2339         * Scripts/webkitpy/common/config/contributors.json:
2340
2341 2019-01-25  Chris Dumez  <cdumez@apple.com>
2342
2343         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2344         https://bugs.webkit.org/show_bug.cgi?id=193779
2345         <rdar://problem/46170903>
2346
2347         Reviewed by Antti Koivisto.
2348
2349         Add API test that quickly navigates forward to a previous process without waiting for it to
2350         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2351         the process' previous page when reconnecting the it for the forward navigation.
2352
2353         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2354
2355 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2356
2357         Need a way for JavaScript (or bundle) code to participate in undo
2358         https://bugs.webkit.org/show_bug.cgi?id=190009
2359         <rdar://problem/44807048>
2360
2361         Reviewed by Ryosuke Niwa.
2362
2363         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2364         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2365
2366         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2367         (WTR::UIScriptController::lastUndoLabel const):
2368         (WTR::UIScriptController::firstRedoLabel const):
2369         (WTR::UIScriptController::platformUndoManager const):
2370         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2371         (WTR::UIScriptController::lastUndoLabel const):
2372         (WTR::UIScriptController::firstRedoLabel const):
2373         (WTR::UIScriptController::platformUndoManager const):
2374         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2375         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2376         (WTR::UIScriptController::lastUndoLabel const):
2377         (WTR::UIScriptController::firstRedoLabel const):
2378         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2379         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2380         (WTR::UIScriptController::lastUndoLabel const):
2381         (WTR::UIScriptController::firstRedoLabel const):
2382         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2383         (WTR::UIScriptController::platformUndoManager const):
2384         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2385         (WTR::UIScriptController::platformUndoManager const):
2386
2387 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2388
2389         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2390         https://bugs.webkit.org/show_bug.cgi?id=193824
2391
2392         Reviewed by Antti Koivisto.
2393
2394         * LayoutReloaded/misc/LFC-passing-tests.txt:
2395
2396 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2397
2398         Update macOS JSC bot configurations
2399         https://bugs.webkit.org/show_bug.cgi?id=193739
2400
2401         Reviewed by Alexey Proskuryakov.
2402
2403         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2404         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2405         (BubbleQueueServer): Move JSC EWS to Mojave section.
2406         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2407         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2408         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2409
2410 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2411
2412         [Win][WebKitTestRunner] Implement EventSenderProxy
2413         https://bugs.webkit.org/show_bug.cgi?id=193755
2414
2415         Reviewed by Don Olmstead.
2416
2417         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2418         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2419         (WTR::EventSenderProxy::dispatchMessage):
2420         (WTR::EventSenderProxy::EventSenderProxy):
2421         (WTR::EventSenderProxy::mouseDown):
2422         (WTR::EventSenderProxy::mouseUp):
2423         (WTR::EventSenderProxy::mouseMoveTo):
2424         (WTR::EventSenderProxy::mouseScrollBy):
2425         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2426
2427 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2428
2429         Unreviewed fix for API test failure after r240437.
2430
2431         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2432
2433         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2434
2435 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2436
2437         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2438         https://bugs.webkit.org/show_bug.cgi?id=193787
2439         <rdar://problem/47497634>
2440
2441         Reviewed by Alexey Proskuryakov.
2442
2443         * Scripts/webkitdirs.pm:
2444         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2445
2446 2019-01-24  Truitt Savell  <tsavell@apple.com>
2447
2448         Unreviewed, rolling out r240446.
2449
2450         Casued 5 API failures
2451
2452         Reverted changeset:
2453
2454         "Activate the WebResourceLoadStatisticsStore in the
2455         NetworkProcess and deactivate it in the UIProcess."
2456         https://bugs.webkit.org/show_bug.cgi?id=193297
2457         https://trac.webkit.org/changeset/240446
2458
2459 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2460
2461         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2462         https://bugs.webkit.org/show_bug.cgi?id=193741
2463         <rdar://problem/47135030>
2464
2465         Reviewed by Antti Koivisto and Simon Fraser.
2466
2467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2468         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2469         (TestWebKitAPI::TEST):
2470
2471 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2472
2473         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2474         https://bugs.webkit.org/show_bug.cgi?id=193297
2475         <rdar://problem/47158841>
2476
2477         Reviewed by Alex Christensen.
2478
2479         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2480         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2481         activating the message used to trigger the callback when it is set.
2482
2483 2019-01-24  John Wilander  <wilander@apple.com>
2484
2485         Add Ad Click Attribution as an internal/experimental feature
2486         https://bugs.webkit.org/show_bug.cgi?id=193685
2487         <rdar://problem/47450399>
2488
2489         Reviewed by Brent Fulgham.
2490
2491         Added test option adClickAttributionEnabled.
2492
2493         * DumpRenderTree/TestOptions.cpp:
2494         (TestOptions::TestOptions):
2495         * DumpRenderTree/TestOptions.h:
2496         * DumpRenderTree/mac/DumpRenderTree.mm:
2497         (setWebPreferencesForTestOptions):
2498
2499 2019-01-24  Antti Koivisto  <antti@apple.com>
2500
2501         [PSON] Flash on back navigation on Mac
2502         https://bugs.webkit.org/show_bug.cgi?id=193716
2503         <rdar://problem/47148458>
2504
2505         Reviewed by Chris Dumez.
2506
2507         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2508
2509         Closing of the previous page is delayed so waiting for didFinishNavigation is
2510         not sufficient to guarantee we have received all the messages. Wait for them.
2511
2512 2019-01-24  Chris Dumez  <cdumez@apple.com>
2513
2514         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2515         https://bugs.webkit.org/show_bug.cgi?id=193761
2516         <rdar://problem/47456405>
2517
2518         Reviewed by Alex Christensen.
2519
2520         Add API test coverage.
2521
2522         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2523
2524 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2525
2526         webkitpy: Missing PID in crashlog name should not be fatal
2527         https://bugs.webkit.org/show_bug.cgi?id=193771
2528
2529         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2530         of raising an exception.
2531
2532         Reviewed by Lucas Forschler.
2533
2534         * Scripts/webkitpy/port/darwin.py:
2535         (DarwinPort._merge_crash_logs):
2536
2537 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2538
2539         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2540         https://bugs.webkit.org/show_bug.cgi?id=193746
2541
2542         Reviewed by Youenn Fablet.
2543
2544         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2545         so we'd best just not call it.
2546
2547         * Scripts/webkitpy/w3c/test_exporter.py:
2548         (WebPlatformTestExporter.create_branch_with_patch):
2549
2550 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2551
2552         Move FileSystem to WTF
2553         https://bugs.webkit.org/show_bug.cgi?id=193602
2554
2555         Reviewed by Yusuke Suzuki.
2556
2557         * DumpRenderTree/win/DumpRenderTree.cpp:
2558         * TestWebKitAPI/CMakeLists.txt:
2559         * TestWebKitAPI/PlatformGTK.cmake:
2560         * TestWebKitAPI/PlatformJSCOnly.cmake:
2561         * TestWebKitAPI/PlatformPlayStation.cmake:
2562         * TestWebKitAPI/PlatformWPE.cmake:
2563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2564         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2565         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2566         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2567         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2568         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2569         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2570         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2571         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2572         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2573
2574 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2575
2576         [WPE] Remove hard dependency on subprocess32 for the API tests
2577
2578         Rubber-stamped by Carlos Garcia Campos.
2579
2580         * glib/api_test_runner.py:
2581         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2582         its presence only when running WPEQt tests.
2583
2584 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2585
2586         [GLIB] Expose JavaScriptCore options in GLib public API
2587         https://bugs.webkit.org/show_bug.cgi?id=188742
2588
2589         Reviewed by Michael Catanzaro.
2590
2591         Add a test for the new API.
2592
2593         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2594         (testsJSCOptions):
2595         (main):
2596
2597 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2598
2599         [GTK][WPE] Support JPEG 2000 images
2600         https://bugs.webkit.org/show_bug.cgi?id=186272
2601
2602         Reviewed by Žan Doberšek.
2603
2604         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2605
2606         * gtk/jhbuild.modules:
2607         * wpe/jhbuild.modules:
2608
2609 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2610
2611         check-webkit-style should warn when using soft-linking macros in a header
2612         <https://webkit.org/b/193750>
2613
2614         Reviewed by Darin Adler.
2615
2616         * Scripts/webkitpy/style/checkers/cpp.py:
2617         (check_language): Add softlink/header check by refactoring the
2618         softlink/framework check.
2619         (CppChecker): Enable softlink/header check by default.
2620         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2621         (CppStyleTest.test_softlink_framework): Rename from
2622         CppStyleTest.test_softlink() and change test framework name in
2623         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2624         files. Set file_name for macros that only appear in headers.
2625         (CppStyleTest.test_softlink_header): Add tests for using
2626         soft-link macros in headers.
2627
2628 2019-01-23  Chris Dumez  <cdumez@apple.com>
2629
2630         Deprecate API to limit the maximum number of WebProcesses
2631         https://bugs.webkit.org/show_bug.cgi?id=193725
2632         <rdar://problem/47464879>
2633
2634         Reviewed by Geoff Garen.
2635
2636         Update existing API tests to stop using deprecated API.
2637
2638         * MiniBrowser/mac/AppDelegate.m:
2639         (defaultConfiguration):
2640         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2641         (TestWebKitAPI::TEST):
2642         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2643         (TestWebKitAPI::TEST):
2644         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2645         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2646         (TEST):
2647         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2648         (TEST):
2649
2650 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2651
2652         [ews-app] Rename ews model buildermappings to buildermapping
2653         https://bugs.webkit.org/show_bug.cgi?id=193729
2654
2655         Reviewed by Lucas Forschler.
2656
2657         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2658         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2659         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2660
2661 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2662
2663         [ews-app] Rename ews model steps to step
2664         https://bugs.webkit.org/show_bug.cgi?id=193697
2665
2666         Reviewed by Lucas Forschler.
2667
2668         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2669         (Step): Renamed Steps to Step.
2670
2671 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2672
2673         Clean up IndexedDB files between tests
2674         https://bugs.webkit.org/show_bug.cgi?id=192796
2675         <rdar://problem/46824999>
2676
2677         Reviewed by Geoffrey Garen.
2678
2679         * DumpRenderTree/mac/DumpRenderTree.mm:
2680         (runTest):
2681         * WebKitTestRunner/TestController.cpp:
2682         (WTR::TestController::resetStateToConsistentValues):
2683         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2684         (WTR::RemoveAllIndexedDatabasesCallback):
2685         (WTR::TestController::ClearIndexedDatabases):
2686         * WebKitTestRunner/TestController.h:
2687         * WebKitTestRunner/TestInvocation.cpp:
2688         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2689
2690 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2691
2692         [ews-app] Rename ews model Builds to Build
2693         https://bugs.webkit.org/show_bug.cgi?id=193695
2694
2695         Reviewed by Lucas Forschler.
2696
2697         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2698         (Build): Renamed Builds to Build.
2699
2700 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2701
2702         webkitpy: Wait longer when launching WebKitTestRunner
2703         https://bugs.webkit.org/show_bug.cgi?id=193734
2704
2705         Reviewed by Aakash Jain.
2706
2707         * Scripts/webkitpy/port/simulator_process.py:
2708         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2709
2710 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2711
2712         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2713         https://bugs.webkit.org/show_bug.cgi?id=193182
2714         <rdar://problem/47452154>
2715
2716         Reviewed by Tim Horton.
2717
2718         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2719         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2720         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2721
2722         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2723         preventing later tests from recognizing gestures.
2724
2725         * WebKitTestRunner/ios/TestControllerIOS.mm:
2726         (WTR::TestController::platformResetStateToConsistentValues):
2727
2728         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2729
2730 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2731
2732         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2733         https://bugs.webkit.org/show_bug.cgi?id=193722
2734         <rdar://problem/47481475>
2735
2736         Reviewed by Lucas Forschler.
2737
2738         iPhone and iPad ports should both use the iOS config.
2739
2740         * Scripts/webkitpy/port/ios_simulator.py:
2741         (IPhoneSimulatorPort.__init__):
2742         (IPadSimulatorPort.__init__):
2743
2744 2019-01-23  Rob Buis  <rbuis@igalia.com>
2745
2746         Update MIME type parser
2747         https://bugs.webkit.org/show_bug.cgi?id=180526
2748
2749         Reviewed by Frédéric Wang.
2750
2751         Add unit tests for both parse modes of ParsedContentType.
2752
2753         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2754         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2755         (TestWebKitAPI::TEST):
2756
2757 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2758
2759         [ews-app] fetch loop should not stop on network issues
2760         https://bugs.webkit.org/show_bug.cgi?id=193666
2761
2762         Reviewed by Lucas Forschler.
2763
2764         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2765         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2766
2767 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2768
2769         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2770         https://bugs.webkit.org/show_bug.cgi?id=189165
2771         <rdar://problem/47433765>
2772
2773         Reviewed by Tim Horton.
2774
2775         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2776         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2777         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2778         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2779         would make its way to the UI process by the time the layer tree commit is finished.
2780
2781         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2782         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2783         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2784         will fail because it asks for -_autofillContext too early.
2785
2786         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2787         is handled in the UI process.
2788
2789         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2790
2791         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2792         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2793         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2794         input session.
2795
2796         (-[AutofillTestView textInputHasAutofillContext]):
2797
2798         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2799
2800         * TestWebKitAPI/cocoa/TestWKWebView.h:
2801         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2802         (nextInputSessionChangeCount):
2803
2804         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2805         This includes changing the focused element from one to another.
2806
2807         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2808         (-[TestWKWebView didStartFormControlInteraction]):
2809         (-[TestWKWebView didEndFormControlInteraction]):
2810         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2811
2812         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2813         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2814         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2815         that doesn't require an input session to one that doesn't.
2816
2817 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2818
2819         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2820         <https://webkit.org/b/193676>
2821
2822         Reviewed by Alexey Proskuryakov.
2823
2824         * Scripts/webkitpy/style/checkers/cpp.py:
2825         (check_member_initialization_list):
2826         - Don't report missing whitespace around colon if the colon at
2827           the start of the line is formatted correctly.
2828         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2829         (WebKitStyleTest.test_member_initialization_list):
2830         - Add a test for a missing permutation of existing tests.
2831         - Add a test this false-positive.
2832         - Add blank lines between subtests to make them easier to read.
2833
2834 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2835
2836         [build.webkit.org] Unit-test failure after r237113
2837         https://bugs.webkit.org/show_bug.cgi?id=193669
2838
2839         Reviewed by Michael Catanzaro.
2840
2841         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2842         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2843         multiple or zero flags.
2844
2845 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2846
2847         Cache bytecode to disk
2848         https://bugs.webkit.org/show_bug.cgi?id=192782
2849         <rdar://problem/46084932>
2850
2851         Reviewed by Keith Miller.
2852
2853         Add test helper to execute bytecode-cache tests: it executes each test
2854         twice, the first with JSC_diskCachePath set to a temporary directory
2855         and second with JSC_forceDiskCache=true (in addition to the cache path)
2856         to guarantee that only the disk cache is being used and no new
2857         UnlinkedCodeBlocks are being created.
2858
2859         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2860         * Scripts/run-jsc-stress-tests:
2861
2862 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2863
2864         [css-logical] Implement flow-relative margin, padding and border shorthands
2865         https://bugs.webkit.org/show_bug.cgi?id=188697
2866
2867         Reviewed by Simon Fraser and Antti Koivisto.
2868
2869         * DumpRenderTree/TestOptions.cpp:
2870         (TestOptions::TestOptions):
2871         * DumpRenderTree/TestOptions.h:
2872         * DumpRenderTree/mac/DumpRenderTree.mm:
2873         (setWebPreferencesForTestOptions):
2874         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2875
2876         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2877         (JSONCSSPropertiesChecker.check_codegen_properties):
2878         Allow CSS property definitions to have a 'runtime-flag' parameter which
2879         disables the property when the specified runtime flag is disabled.
2880
2881 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2882
2883         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2884         https://bugs.webkit.org/show_bug.cgi?id=193643
2885
2886         Reviewed by Michael Catanzaro.
2887
2888         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2889         * wpe/jhbuild.modules: Ditto.
2890
2891 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2892
2893         [LFC][Floats] Take float top position into account when computing containing block height.
2894         https://bugs.webkit.org/show_bug.cgi?id=193655
2895
2896         Reviewed by Antti Koivisto.
2897
2898         * LayoutReloaded/misc/LFC-passing-tests.txt:
2899
2900 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2901
2902         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2903         <https://webkit.org/b/193645>
2904         <rdar://problem/47421574>
2905
2906         Reviewed by Alex Christensen.
2907
2908         - Now checks for local soft-linking of all frameworks that have
2909           their own *SoftLinking.{cpp,h,mm} files.
2910         - Changes softlink/uikit warning to softlink/framework.
2911
2912         * Scripts/webkitpy/style/checkers/cpp.py:
2913         (check_language):
2914         (CppChecker):
2915         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2916         (CppStyleTest):
2917
2918 2019-01-20  Saam Barati  <sbarati@apple.com>
2919
2920         Rollout r240210: It broke tests on iOS
2921         https://bugs.webkit.org/show_bug.cgi?id=193640
2922
2923         Unreviewed.
2924
2925         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2926         * Scripts/run-jsc-stress-tests:
2927
2928 2019-01-20  chris fleizach  <cfleizach@apple.com>
2929
2930         AX: Support returning relative frames for accessibility
2931         https://bugs.webkit.org/show_bug.cgi?id=193414
2932         <rdar://problem/47268501>
2933
2934         Reviewed by Zalan Bujtas.
2935
2936         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2937         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2938         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2939         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2940         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2941         (WTR::attributesOfElement):
2942         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2943
2944 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2945
2946         Unreviewed, add my new email address
2947
2948         * Scripts/webkitpy/common/config/contributors.json:
2949
2950 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2951
2952         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2953         https://bugs.webkit.org/show_bug.cgi?id=193617
2954
2955         Reviewed by Antti Koivisto.
2956
2957         * LayoutReloaded/misc/LFC-passing-tests.txt:
2958
2959 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2960
2961         Unreviewed, rolling out r240209.
2962
2963         Broke GTK/WPE injected bundle
2964
2965         Reverted changeset:
2966
2967         "AX: Support returning relative frames for accessibility"
2968         https://bugs.webkit.org/show_bug.cgi?id=193414
2969         https://trac.webkit.org/changeset/240209
2970
2971 2019-01-12  Dan Bernstein  <mitz@apple.com>
2972
2973         [Cocoa] Avoid importing directly from subumbrella frameworks
2974         https://bugs.webkit.org/show_bug.cgi?id=186016
2975         <rdar://problem/40591038>
2976
2977         Reviewed by Sam Weinig.
2978
2979         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2980           LaunchServices header.
2981         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2982           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2983         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2984           when using SDKs earlier than 10.13.
2985         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2986           and OTHER_CPLUSPLUSFLAGS.
2987         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2988           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2989         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2990           LaunchServices header.
2991
2992 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2993
2994         Cache bytecode to disk
2995         https://bugs.webkit.org/show_bug.cgi?id=192782
2996         <rdar://problem/46084932>
2997
2998         Reviewed by Keith Miller.
2999
3000         Add test helper to execute bytecode-cache tests: it executes each test
3001         twice, the first with JSC_diskCachePath set to a temporary directory
3002         and second with JSC_forceDiskCache=true (in addition to the cache path)
3003         to guarantee that only the disk cache is being used and no new
3004         UnlinkedCodeBlocks are being created.
3005
3006         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3007         * Scripts/run-jsc-stress-tests:
3008
3009 2019-01-20  chris fleizach  <cfleizach@apple.com>
3010
3011         AX: Support returning relative frames for accessibility
3012         https://bugs.webkit.org/show_bug.cgi?id=193414
3013         <rdar://problem/47268501>
3014
3015         Reviewed by Zalan Bujtas.
3016
3017         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3018         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3019         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3020         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3021         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3022         (WTR::attributesOfElement):
3023         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3024
3025 2019-01-20  Antoine Quint  <graouts@apple.com>
3026
3027         Add a POINTER_EVENTS feature flag
3028         https://bugs.webkit.org/show_bug.cgi?id=193577
3029         <rdar://problem/47408511>
3030
3031         Unreviewed. Also enable Pointer Events for iosmac.
3032
3033         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3034
3035 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3036
3037         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3038         https://bugs.webkit.org/show_bug.cgi?id=193613
3039
3040         Reviewed by Antti Koivisto.
3041
3042         * LayoutReloaded/misc/LFC-passing-tests.txt:
3043
3044 2019-01-19  Antoine Quint  <graouts@apple.com>
3045
3046         Add a POINTER_EVENTS feature flag
3047         https://bugs.webkit.org/show_bug.cgi?id=193577
3048
3049         Reviewed by Dean Jackson.
3050
3051         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3052
3053 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3054
3055         Disable the run-jsc-stress-test remote host key check [second round].
3056         https://bugs.webkit.org/show_bug.cgi?id=192988
3057
3058         Reviewed by Dewei Zhu.
3059
3060         * Scripts/run-jsc-stress-tests:
3061
3062 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3063
3064         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3065         https://bugs.webkit.org/show_bug.cgi?id=193597
3066
3067         Reviewed by Lucas Forschler.
3068
3069         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3070
3071 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3072
3073         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3074         https://bugs.webkit.org/show_bug.cgi?id=193595
3075
3076         Reviewed by Lucas Forschler.
3077
3078         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3079         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3080         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3081
3082 2019-01-18  Chris Dumez  <cdumez@apple.com>
3083
3084         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3085         https://bugs.webkit.org/show_bug.cgi?id=193588
3086         <rdar://problem/47131566>
3087
3088         Reviewed by Alex Christensen.
3089
3090         Add layout test coverage.
3091
3092         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3093
3094 2019-01-18  Jer Noble  <jer.noble@apple.com>
3095
3096         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3097         https://bugs.webkit.org/show_bug.cgi?id=189553
3098
3099         Reviewed by Tim Horton.
3100
3101         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3102
3103         * ContentExtensionTester/Configurations/Base.xcconfig:
3104         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3105         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3106         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3107         * ImageDiff/cg/Configurations/Base.xcconfig:
3108         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3109         * MiniBrowser/Configurations/Base.xcconfig:
3110         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3111         * MobileMiniBrowser/Configurations/Base.xcconfig:
3112         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3113         * Scripts/webkitpy/style/checker.py:
3114         (_all_categories):
3115         (FileType):
3116         (CheckerDispatcher._file_type):
3117         (CheckerDispatcher._create_checker):
3118         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3119         (SDKVariantChecker):
3120         (SDKVariantChecker.__init__):
3121         (SDKVariantChecker.check):
3122         * TestWebKitAPI/Configurations/Base.xcconfig:
3123         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3124         * WebEditingTester/Configurations/Base.xcconfig:
3125         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3126         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3127         * WebKitTestRunner/Configurations/Base.xcconfig:
3128         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3129         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3130         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3131
3132 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3133
3134         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3135         <https://webkit.org/b/193568>
3136         <rdar://problem/47381130>
3137
3138         Reviewed by Alex Christensen.
3139
3140         Make sure no one re-introduces UIKit soft-linking by adding a
3141         style rule.
3142
3143         * Scripts/webkitpy/style/checkers/cpp.py:
3144         (check_language): Add softlink/uikit check.
3145         (CppChecker): Enable softlink/uikit check.
3146         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3147         (CppStyleTest): Add test for softlink/uikit.
3148
3149 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3150
3151         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3152         https://bugs.webkit.org/show_bug.cgi?id=193584
3153
3154         Change "-dev" to "-devel".
3155
3156         Reviewed by Michael Catanzaro.
3157
3158         * gtk/install-dependencies:
3159
3160 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3161
3162         webkitpy: Add iPhone and iPad ports
3163         https://bugs.webkit.org/show_bug.cgi?id=193537
3164         <rdar://problem/47353390>
3165
3166         Reviewed by Lucas Forschler.
3167
3168         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3169         ports. Note that this separation is optional, the --ios-simulator command remains.
3170
3171         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3172         (RunTest.test_device_type_test_division): Drive-by fix.
3173         (RunTest.test_device_type_specific_listing): Ditto.
3174         (RunTest.test_ipad_test_division):
3175         (RunTest):
3176         (RunTest.test_ipad_listing):
3177         * Scripts/webkitpy/port/factory.py:
3178         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3179         (PortFactory):
3180         * Scripts/webkitpy/port/ios_simulator.py:
3181         (IPhoneSimulatorPort):
3182         (IPadSimulatorPort):
3183
3184 2019-01-18  Chris Dumez  <cdumez@apple.com>
3185
3186         Regression(PSON) Scroll position is not always restored properly when navigating back
3187         https://bugs.webkit.org/show_bug.cgi?id=193578
3188         <rdar://problem/47386331>
3189
3190         Reviewed by Tim Horton.
3191
3192         Add API test coverage.
3193
3194         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3195
3196 2019-01-18  Youenn Fablet  <youenn@apple.com>
3197
3198         Add a new SPI to request for cache storage quota increase
3199         https://bugs.webkit.org/show_bug.cgi?id=193323
3200
3201         Reviewed by Alex Christensen.
3202
3203         Implement WebsiteDataStore quota delegate to handle quota requests.
3204         By default, do not update quota.
3205         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3206
3207         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3208         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3209         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3210         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3211         * WebKitTestRunner/TestController.cpp:
3212         (WTR::TestController::allowCacheStorageQuotaIncrease):
3213         * WebKitTestRunner/TestController.h:
3214         * WebKitTestRunner/TestInvocation.cpp:
3215         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3216         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3217         (-[CacheStorageQuotaManager init]):
3218         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3219         (WTR::initializeWebViewConfiguration):
3220         (WTR::TestController::cocoaResetStateToConsistentValues):
3221         (WTR::TestController::allowCacheStorageQuotaIncrease):
3222
3223 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3224
3225         [ews-build] Pass owner to the triggered builds
3226         https://bugs.webkit.org/show_bug.cgi?id=193574
3227
3228         Reviewed by Lucas Forschler.
3229
3230         * BuildSlaveSupport/ews-build/factories.py:
3231         (BuildFactory.propertiesToPassToTriggers):
3232
3233 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3234
3235         [ews-app] Send patch author as a build property
3236         https://bugs.webkit.org/show_bug.cgi?id=193560
3237
3238         Reviewed by Lucas Forschler.
3239
3240         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3241         (BugzillaPatchFetcher.fetch):
3242
3243 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3244
3245         webkitpy: Implement device type specific expected results (Follow-up fix)
3246         https://bugs.webkit.org/show_bug.cgi?id=192162
3247         <rdar://problem/46345449>
3248
3249         Unreviewed infrastructure fix.
3250
3251         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3252         (Manager.run): Don't boot a device if no tests are available to run on it.
3253
3254 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3255
3256         webkitpy: Implement device type specific expected results (Follow-up fix)
3257         https://bugs.webkit.org/show_bug.cgi?id=192162
3258         <rdar://problem/46345449>
3259
3260         Unreviewed infrastructure fix.
3261
3262         * Scripts/webkitpy/api_tests/manager.py:
3263         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3264
3265 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3266
3267         webkitpy: Implement device type specific expected results (Part 2)
3268         https://bugs.webkit.org/show_bug.cgi?id=192162
3269         <rdar://problem/46345449>
3270
3271         Rubber-stamped by Aakash Jain.
3272
3273         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3274         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3275         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3276
3277         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3278         (LayoutTestFinder.find_tests): Pass device_type through.
3279         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3280         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3281         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3282         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3283         (Manager._collect_tests): Pass device type to test finder.
3284         (Manager._needs_web_platform_test):
3285         (Manager._prepare_lists): Index _expectations by device type.
3286         (Manager._test_input_for_file):
3287         (Manager._test_is_slow): Ditto.
3288         (Manager._test_should_dump_jsconsolelog_in_stderr):
3289         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3290         (Manager._get_test_inputs):
3291         (Manager._update_worker_count):
3292         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3293         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3294         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3295         the one which runs the test.
3296         (Manager._run_test_subset):
3297         (Manager._run_tests): Index _expectations by current_device_type.
3298         (Manager._print_expectation_line_for_test): Ditto.
3299         (Manager._print_expectations_for_subset): Ditto.
3300         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3301         Unlike run, this function will behave the same regardless of what devices are available.
3302         (Manager._custom_device_for_test): Deleted.
3303         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3304         (ManagerTest.test_uses_custom_device): Deleted.
3305         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3306         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3307         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3308         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3309         all of the expectations.
3310         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3311         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3312         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3313         (TestExpectations.__init__): Allow device_type to be passed through.
3314         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3315         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3316         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3317         (summarize_results):
3318         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3319         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3320         a test ran with, one must check all expectations to find the first non-skip expectation.
3321         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3322         (RunTest.test_device_type_test_division):
3323         (RunTest):
3324         (RunTest.test_device_type_specific_listing):
3325         * Scripts/webkitpy/port/base.py:
3326         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3327         (Port.supported_device_types): The result of this function will change based on what devices are available.
3328         * Scripts/webkitpy/port/device_port.py:
3329         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3330         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3331         can be used.
3332         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3333         any, or the DEFAULT_DEVICE_TYPES of the port.
3334         * Scripts/webkitpy/port/ios.py:
3335         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3336         * Scripts/webkitpy/port/ios_simulator.py:
3337         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3338         * Scripts/webkitpy/port/watch.py:
3339         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3340         * Scripts/webkitpy/port/watch_simulator.py:
3341         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3342         * Scripts/webkitpy/xcode/device_type.py:
3343         (DeviceType):
3344         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3345
3346 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3347
3348         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3349         https://bugs.webkit.org/show_bug.cgi?id=193575
3350
3351         Reviewed by Michael Catanzaro.
3352
3353         Allow the script to run without explicit port argument because
3354         it's specific to the WPE port anyway.
3355
3356         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3357         and simplify the rest of the code accordingly.
3358
3359 2019-01-18  Charlie Turner  <cturner@igalia.com>
3360
3361         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3362         https://bugs.webkit.org/show_bug.cgi?id=192229
3363
3364         Reviewed by Xabier Rodriguez-Calvar.
3365
3366         * MiniBrowser/wpe/main.cpp:
3367         (main): Enable encrypted-media by default.
3368
3369 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3370
3371         [Flatpak] Missing KeyboardInterrupt exception handler
3372         https://bugs.webkit.org/show_bug.cgi?id=193570
3373
3374         Reviewed by Michael Catanzaro.
3375
3376         * flatpak/flatpakutils.py:
3377         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3378
3379 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3380
3381         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3382         https://bugs.webkit.org/show_bug.cgi?id=193564
3383
3384         Reviewed by Antti Koivisto.
3385
3386         * LayoutReloaded/misc/LFC-passing-tests.txt:
3387
3388 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3389
3390         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3391         https://bugs.webkit.org/show_bug.cgi?id=193562
3392
3393         Reviewed by Antti Koivisto.
3394
3395         * LayoutReloaded/misc/LFC-passing-tests.txt:
3396
3397 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3398
3399         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3400         https://bugs.webkit.org/show_bug.cgi?id=193555
3401
3402         Reviewed by Antti Koivisto.
3403
3404         * LayoutReloaded/misc/LFC-passing-tests.txt:
3405
3406 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3407
3408         [WPE] Add Qt extension
3409         https://bugs.webkit.org/show_bug.cgi?id=191464
3410
3411         Reviewed by Carlos Garcia Campos.
3412
3413         MiniBrowser and API tests for the WPE Qt API. To run the
3414         MiniBrowser a new script is introduced. Example invocation:
3415
3416         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3417
3418         Also note-worthy is the introduction of the python2-subprocess32
3419         dependency to run the GLib API tests.
3420
3421         * MiniBrowser/wpe/CMakeLists.txt:
3422         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3423         * MiniBrowser/wpe/qt/main.cpp: Added.
3424         (main):
3425         * MiniBrowser/wpe/qt/main.qml: Added.
3426         * MiniBrowser/wpe/qt/qml.qrc: Added.
3427         * Scripts/run-gtk-tests:
3428         (GtkTestRunner.is_google_test):
3429         (GtkTestRunner):
3430         (GtkTestRunner.is_qt_test):
3431         * Scripts/run-qt-wpe-minibrowser: Added.
3432         * Scripts/run-wpe-tests:
3433         (WPETestRunner):
3434         (WPETestRunner.is_google_test):
3435         (WPETestRunner.is_qt_test):
3436         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3437         (TestLoad::main):
3438         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3439         (TestLoadHtml::main):
3440         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3441         (TestLoadRequest::main):
3442         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3443         (TestRunJavaScript::main):
3444         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3445         (waitForSignal):
3446         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3447         (LoadSpy::LoadSpy):
3448         (LoadSpy::~LoadSpy):
3449         (LoadSpy::onLoadingChanged):
3450         (LoadStartedCatcher::LoadStartedCatcher):
3451         (LoadStartedCatcher::~LoadStartedCatcher):
3452         (LoadStartedCatcher::onLoadingChanged):
3453         (waitForLoadSucceeded):
3454         (waitForLoadFailed):
3455         * TestWebKitAPI/glib/CMakeLists.txt:
3456         * flatpak/flatpakutils.py:
3457         (WebkitFlatpak.load_from_args):
3458         (WebkitFlatpak.__init__):
3459         (WebkitFlatpak.clean_args):
3460         (WebkitFlatpak.run_in_sandbox):
3461         * flatpak/org.webkit.CommonModules.yaml:
3462         * flatpak/org.webkit.WPE.yaml:
3463         * flatpak/org.webkit.WPEModules.yaml:
3464         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3465         * flatpak/org.webkit.WebKit.yaml:
3466         * glib/api_test_runner.py:
3467         (TestRunner._run_test_qt):
3468         (TestRunner.is_qt_test):
3469         (TestRunner._run_test):
3470
3471 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3472
3473         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3474         https://bugs.webkit.org/show_bug.cgi?id=193494
3475         <rdar://problem/46859627>
3476
3477         Reviewed by Simon Fraser and Tim Horton.
3478
3479         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3480         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3481
3482         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3483         (WTR::UIScriptController::contentOffsetX const):
3484         (WTR::UIScriptController::contentOffsetY const):
3485         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3486         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3487         (WTR::UIScriptController::contentOffsetX const):
3488         (WTR::UIScriptController::contentOffsetY const):
3489         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3490
3491         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3492
3493         * WebKitTestRunner/TestController.cpp:
3494         (WTR::updateTestOptionsFromTestHeader):
3495         * WebKitTestRunner/TestOptions.h:
3496         (WTR::TestOptions::hasSameInitializationOptions const):
3497         * WebKitTestRunner/ios/TestControllerIOS.mm:
3498         (WTR::TestController::platformResetStateToConsistentValues):
3499         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3500         (WTR::UIScriptController::contentOffsetX const):
3501         (WTR::UIScriptController::contentOffsetY const):
3502
3503 2019-01-17  Truitt Savell  <tsavell@apple.com>
3504
3505         Unreviewed, rolling out r240124.
3506
3507         This commit broke an internal build.
3508
3509         Reverted changeset:
3510
3511         "SDK_VARIANT build destinations should be separate from non-
3512         SDK_VARIANT builds"
3513         https://bugs.webkit.org/show_bug.cgi?id=189553
3514         https://trac.webkit.org/changeset/240124
3515
3516 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3517
3518         Fix string concatenation API test after r239920
3519         https://bugs.webkit.org/show_bug.cgi?id=193551
3520         <rdar://problem/47359304>
3521
3522         Reviewed by Youenn Fablet.
3523
3524         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3525         (TestWebKitAPI::TEST):
3526         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3527         in WebKit's build configuration like it apparently is on Linux.
3528
3529 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3530
3531         [ews-build] validate-patch should handle the case when bug_id is None
3532         https://bugs.webkit.org/show_bug.cgi?id=193547
3533
3534         Reviewed by Lucas Forschler.
3535
3536         * BuildSlaveSupport/ews-build/steps.py:
3537         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3538         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3539
3540 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3541
3542         [ews-build] Add patch author information in build
3543         https://bugs.webkit.org/show_bug.cgi?id=193465
3544
3545         Reviewed by Lucas Forschler.
3546
3547         * BuildSlaveSupport/ews-build/steps.py:
3548         (ValidatePatch._is_patch_obsolete):
3549
3550 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3551
3552         [ews-build] Pass bug_id to the triggered builds
3553         https://bugs.webkit.org/show_bug.cgi?id=193548
3554
3555         Reviewed by Lucas Forschler.
3556
3557         * BuildSlaveSupport/ews-build/factories.py:
3558         (BuildFactory.propertiesToPassToTriggers):
3559
3560 2019-01-17  Jer Noble  <jer.noble@apple.com>
3561
3562         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3563         https://bugs.webkit.org/show_bug.cgi?id=189553
3564
3565         Reviewed by Tim Horton.
3566
3567         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3568
3569         * ContentExtensionTester/Configurations/Base.xcconfig:
3570         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3571         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3572         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3573         * ImageDiff/cg/Configurations/Base.xcconfig:
3574         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3575         * MiniBrowser/Configurations/Base.xcconfig:
3576         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3577         * MobileMiniBrowser/Configurations/Base.xcconfig:
3578         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3579         * Scripts/webkitpy/style/checker.py:
3580         (_all_categories):
3581         (FileType):
3582         (CheckerDispatcher._file_type):
3583         (CheckerDispatcher._create_checker):
3584         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3585         (SDKVariantChecker):
3586         (SDKVariantChecker.__init__):
3587         (SDKVariantChecker.check):
3588         * TestWebKitAPI/Configurations/Base.xcconfig:
3589         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3590         * WebEditingTester/Configurations/Base.xcconfig:
3591         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3592         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3593         * WebKitTestRunner/Configurations/Base.xcconfig:
3594         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3595         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3596         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3597
3598 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3599
3600         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3601         https://bugs.webkit.org/show_bug.cgi?id=193534
3602
3603         Reviewed by Antti Koivisto.
3604
3605         * LayoutReloaded/misc/LFC-passing-tests.txt:
3606
3607 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3608
3609         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3610         https://bugs.webkit.org/show_bug.cgi?id=193528
3611
3612         Reviewed by Antti Koivisto.
3613
3614         * LayoutReloaded/misc/LFC-passing-tests.txt:
3615
3616 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3617
3618         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3619         https://bugs.webkit.org/show_bug.cgi?id=193520
3620
3621         Reviewed by Antti Koivisto.
3622
3623         * LayoutReloaded/misc/LFC-passing-tests.txt:
3624
3625 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3626
3627         [ews-build] unapply-patch step should not update source
3628         https://bugs.webkit.org/show_bug.cgi?id=193234
3629
3630         Reviewed by Lucas Forschler.
3631
3632         * BuildSlaveSupport/ews-build/steps.py:
3633         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3634         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3635
3636 2019-01-16  Youenn Fablet  <youenn@apple.com>
3637
3638         Add a new SPI for controlling getUserMedia
3639         https://bugs.webkit.org/show_bug.cgi?id=192793
3640
3641         Reviewed by Eric Carlson.
3642
3643         * MiniBrowser/mac/WK2BrowserWindowController.m:
3644         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3645         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3646         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3647         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3648         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3649         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3650         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3651         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3652         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3653         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3654         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3655         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3656         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3657         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3658
3659 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3660
3661         [LFC][BFC] Inflow non-replaced used width should not be negative.
3662         https://bugs.webkit.org/show_bug.cgi?id=193495
3663
3664         Reviewed by Antti Koivisto.
3665
3666         * LayoutReloaded/misc/LFC-passing-tests.txt:
3667
3668 2019-01-16  Chris Dumez  <cdumez@apple.com>
3669
3670         Regression(PSON) View becomes blank after click a cross-site download link
3671         https://bugs.webkit.org/show_bug.cgi?id=193361
3672         <rdar://problem/47099573>
3673
3674         Reviewed by Geoffrey Garen.
3675
3676         Add API test coverage.
3677
3678         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3679         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3680
3681 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3682
3683         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3684         https://bugs.webkit.org/show_bug.cgi?id=193470
3685
3686         Reviewed by Antti Koivisto.
3687
3688         * LayoutReloaded/misc/LFC-passing-tests.txt:
3689
3690 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3691
3692         [LFC] Adjust margin box verification.
3693         https://bugs.webkit.org/show_bug.cgi?id=193482
3694
3695         Reviewed by Antti Koivisto.
3696
3697         * LayoutReloaded/misc/LFC-passing-tests.txt:
3698
3699 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3700
3701         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3702         https://bugs.webkit.org/show_bug.cgi?id=193451
3703
3704         Reviewed by Geoffrey Garen.
3705
3706         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3707         (TEST):
3708         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3709         (runWebsiteDataStoreCustomPaths):
3710
3711 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3712
3713         webkitpy: Support boolean simctl isAvailable
3714         https://bugs.webkit.org/show_bug.cgi?id=193472
3715         <rdar://problem/47296150>
3716
3717         Reviewed by Ryosuke Niwa.
3718
3719         * Scripts/webkitpy/xcode/simulated_device.py:
3720         (SimulatedDeviceManager._create_runtimes):
3721         (SimulatedDeviceManager._create_device_with_runtime):
3722
3723 2019-01-15  Chris Dumez  <cdumez@apple.com>
3724
3725         Unreviewed, rolling out r239993, r239995, r239997, and
3726         r239999.
3727
3728         Caused assertions under
3729         ViewGestureController::disconnectFromProcess()
3730
3731         Reverted changesets:
3732
3733         "Regression(PSON) View becomes blank after click a cross-site
3734         download link"
3735         https://bugs.webkit.org/show_bug.cgi?id=193361
3736         https://trac.webkit.org/changeset/239993
3737
3738         "Unreviewed iOS build fix after r239993."
3739         https://trac.webkit.org/changeset/239995
3740
3741         "Fix iOS build after r239993"
3742         https://bugs.webkit.org/show_bug.cgi?id=193361
3743         https://trac.webkit.org/changeset/239997
3744
3745         "Unreviewed, revert part of r239997 as it is not needed to fix
3746         the build."
3747         https://trac.webkit.org/changeset/239999
3748
3749 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3750
3751         Cannot tab out of WKWebView on macOS
3752         https://bugs.webkit.org/show_bug.cgi?id=161448
3753         <rdar://problem/28100085>
3754
3755         Reviewed by Dean Jackson.
3756
3757         Add a test that tabbing into and out of WKWebView works correctly.
3758
3759         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3760         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3761         (WebKit2_CommandBackForwardTest::SetUp):
3762         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3763         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3764         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3765         (-[FocusableView canBecomeKeyView]):
3766         (TEST):
3767         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3768         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3769         (-[OffscreenWindow initWithSize:]):
3770         (-[OffscreenWindow isKeyWindow]):
3771         (-[OffscreenWindow isVisible]):
3772         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3773         (TestWebKitAPI::PlatformWebView::initialize):
3774         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3775         (-[ActiveOffscreenWindow isVisible]): Deleted.
3776         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3777
3778 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3779
3780         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3781         https://bugs.webkit.org/show_bug.cgi?id=193459
3782
3783         Reviewed by Mark Lam.
3784
3785         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3786         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3787
3788 2019-01-15  Chris Dumez  <cdumez@apple.com>
3789
3790         Regression(PSON) View becomes blank after click a cross-site download link
3791         https://bugs.webkit.org/show_bug.cgi?id=193361
3792         <rdar://problem/47099573>
3793
3794         Reviewed by Geoff Garen.
3795
3796         Add API test coverage.
3797
3798         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3799         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3800
3801 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3802
3803         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3804         https://bugs.webkit.org/show_bug.cgi?id=193448
3805
3806         Reviewed by Antti Koivisto.
3807
3808         * LayoutReloaded/misc/LFC-passing-tests.txt:
3809
3810 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3811
3812         webkitpy: Implement device type specific expected results (Part 1)
3813         https://bugs.webkit.org/show_bug.cgi?id=192162
3814
3815         Reviewed by Lucas Forschler.
3816
3817         Device type specific expected results covers two related ideas. The first (covered by this change)
3818         is where to search for -expected.* files. The second is which tests to run based on the
3819         TestExpectations.txt file.
3820
3821         After this change, the baseline search path will be determined by the type of device running a
3822         test. Device type will be passed into any function which picks a file based on the baseline search
3823         path.
3824
3825         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3826         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3827         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3828         (Manager.run): Print baseline search path for each round of devices.
3829         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3830         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3831         (SingleTestRunner._expected_driver_output): Ditto.
3832         (SingleTestRunner._driver_input): Ditto.
3833         * Scripts/webkitpy/layout_tests/views/printing.py:
3834         (Printer.print_config): Move printing of baseline search path to a separate function.
3835         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3836         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3837         (Testprinter.test_print_config):
3838         (Testprinter.test_print_baseline_search_path):
3839         * Scripts/webkitpy/port/base.py:
3840         (Port.baseline_search_path): Pass device_type through.
3841         (Port._expected_baselines_for_suffixes): Ditto.
3842         (Port.expected_baselines): Ditto.
3843         (Port.expected_filename): Ditto.
3844         (Port.expected_checksum): Ditto.
3845         (Port.expected_image): Ditto.
3846         (Port.expected_audio): Ditto.
3847         (Port.expected_text): Ditto.
3848         (Port.reference_files): Ditto.
3849         (Port.tests): Ditto.
3850         (Port._expanded_paths): Ditto.
3851         (Port.skipped_layout_tests): Ditto.
3852         (Port.expectations_dict): Ditto.
3853         (Port._port_specific_expectations_files): Ditto.
3854         (Port.expectations_files): Ditto.
3855         (Port.test_search_path): Ditto.
3856         (Port._tests_for_other_platforms): Ditto.
3857         * Scripts/webkitpy/port/base_unittest.py:
3858         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3859         (PortTest.test_nonexistant_expectations): Ditto.
3860         (test_ref_tests_platform_directory): Ditto.
3861         * Scripts/webkitpy/port/darwin.py:
3862         (DarwinPort._port_specific_expectations_files): Accept device_type.
3863         * Scripts/webkitpy/port/driver.py:
3864         (DriverProxy):
3865         (DriverProxy.host): Expose _target_host for device_type information.
3866         * Scripts/webkitpy/port/gtk.py:
3867         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3868         * Scripts/webkitpy/port/ios.py:
3869         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3870         * Scripts/webkitpy/port/mac.py:
3871         (MacPort. default_baseline_search_path): Ditto.
3872         * Scripts/webkitpy/port/port_testcase.py:
3873         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3874         * Scripts/webkitpy/port/test.py:
3875         * Scripts/webkitpy/port/watch.py:
3876         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3877         * Scripts/webkitpy/port/win.py:
3878         (WinPort.test_search_path): Accept, but do not use, device_type.
3879         * Scripts/webkitpy/port/wpe.py:
3880         (WPEPort._port_specific_expectations_files): Ditto.
3881         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3882         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3883
3884 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3885
3886         [LFC] Use the containing block's padding box to position out-of-flow elements.
3887         https://bugs.webkit.org/show_bug.cgi?id=193431
3888
3889         Reviewed by Antti Koivisto.
3890
3891         * LayoutReloaded/misc/LFC-passing-tests.txt:
3892
3893 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3894
3895         Move a test implementation file that got misplaced in the Xcode project
3896
3897         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3898
3899 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3900
3901         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3902         r239913, and r239914.
3903         https://bugs.webkit.org/show_bug.cgi?id=193407
3904
3905         These revisions caused an internal failure (Requested by
3906         Truitt on #webkit).
3907
3908         Reverted changesets:
3909
3910         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3911         https://bugs.webkit.org/show_bug.cgi?id=186016
3912         https://trac.webkit.org/changeset/239901
3913
3914         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3915         https://trac.webkit.org/changeset/239909
3916
3917         "Tried to fix the build."
3918         https://trac.webkit.org/changeset/239910
3919
3920         "Fixed iOS builds after r239910."
3921         https://trac.webkit.org/changeset/239912
3922
3923         "More build fixing."
3924         https://trac.webkit.org/changeset/239913
3925
3926         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3927         https://trac.webkit.org/changeset/239914
3928
3929 2019-01-14  Mark Lam  <mark.lam@apple.com>
3930
3931         Re-enable ability to build --cloop builds.
3932         https://bugs.webkit.org/show_bug.cgi?id=192955
3933         <rdar://problem/46882363>
3934
3935         Reviewed by Saam barati and Keith Miller.
3936
3937         The --cloop build option was being ignored this whole time since r236381.
3938         This patch makes it possible to build CLoop builds again.
3939
3940         * Scripts/build-jsc:
3941         * Scripts/webkitperl/FeatureList.pm:
3942         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3943
3944 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3945
3946         webkitpy: Expose device_type from host-like objects
3947         https://bugs.webkit.org/show_bug.cgi?id=193406
3948         <rdar://problem/47262305>
3949
3950         Reviewed by Lucas Forschler.
3951
3952         Devices should expose device_type. As a result, all host objects should
3953         provide a device_type property, even if they do not yet define a device_type.
3954
3955         * Scripts/webkitpy/common/system/systemhost.py:
3956         (SystemHost):
3957         (SystemHost.device_type):
3958         * Scripts/webkitpy/common/system/systemhost_mock.py:
3959         (MockSystemHost):
3960         (MockSystemHost.device_type):
3961         * Scripts/webkitpy/port/device.py:
3962         (Device):
3963         (Device.device_type):
3964         * Scripts/webkitpy/xcode/simulated_device.py:
3965         (SimulatedDeviceManager._find_exisiting_device_for_request):
3966         (SimulatedDeviceManager._disambiguate_device_type):
3967         (SimulatedDeviceManager._does_fulfill_request):
3968         (SimulatedDeviceManager.device_count_for_type):
3969         (SimulatedDeviceManager.initialize_devices):
3970         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3971         (test_available_devices):
3972         (test_swapping_devices):
3973
3974 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3975
3976         webkitpy: Support alternate simctl device list output (Follow-up fix)
3977         https://bugs.webkit.org/show_bug.cgi?id=193362
3978         <rdar://problem/47122965>
3979
3980         Rubber-stamped by Lucas Forschler.
3981
3982         * Scripts/webkitpy/xcode/simulated_device.py:
3983         (SimulatedDeviceManager.populate_available_devices):
3984
3985 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3986
3987         [iOS] Expose SPI to access the current sentence boundary and selection state
3988         https://bugs.webkit.org/show_bug.cgi?id=193398
3989         <rdar://problem/45893108>
3990
3991         Reviewed by Dean Jackson.
3992
3993         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3994         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3995         expected.
3996
3997         * TestWebKitAPI/EditingTestHarness.h:
3998         * TestWebKitAPI/EditingTestHarness.mm:
3999         (-[EditingTestHarness moveBackward]):
4000         (-[EditingTestHarness moveForward]):
4001         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
4002
4003         Add a couple of new helper methods on EditingTestHarness.
4004
4005         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
4006         (-[SelectionChangeObserver initWithWebView:]):
4007         (-[SelectionChangeObserver webView]):
4008         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
4009         (-[SelectionChangeObserver currentSelectionAttributes]):
4010
4011 2019-01-14  Zalan Bujtas  <zalan@apple.com>
4012
4013         [LFC][BFC] Add basic box-sizing support.
4014         https://bugs.webkit.org/show_bug.cgi?id=193392
4015
4016         Reviewed by Antti Koivisto.
4017
4018         * LayoutReloaded/misc/LFC-passing-tests.txt:
4019
4020 2019-01-14  Charlie Turner  <cturner@igalia.com>
4021
4022         [WPE] API test gardening
4023         https://bugs.webkit.org/show_bug.cgi?id=193319
4024
4025         Reviewed by Michael Catanzaro.
4026
4027         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
4028         passing tests.
4029
4030 2019-01-14  Charlie Turner  <cturner@igalia.com>
4031
4032         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
4033         https://bugs.webkit.org/show_bug.cgi?id=192977
4034
4035         Reviewed by Carlos Garcia Campos.
4036
4037         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
4038         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
4039         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
4040         (TestWebKitAPI::GStreamerTest::SetUp):
4041         (TestWebKitAPI::GStreamerTest::TearDown):
4042         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
4043         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
4044         (TestWebKitAPI::TEST_F):
4045
4046 2019-01-14  Charlie Turner  <cturner@igalia.com>
4047
4048         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
4049         https://bugs.webkit.org/show_bug.cgi?id=193332
4050
4051         Reviewed by Michael Catanzaro.
4052
4053         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
4054         defined as a char16_t, which changed in ICU 59, the
4055         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
4056         unsigned short. This test is relying on the behaviour that
4057         UChar=unsigned short, which doesn't hold across platforms and ICU
4058         library versions. The full fix would be a special syntax for
4059         literal characters so that these ambiguities do not arise. That
4060         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
4061         (TestWebKitAPI::TEST):
4062
4063 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4064
4065         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
4066
4067         * Scripts/make-dist:
4068         (Distcheck.configure):
4069
4070 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
4071
4072         [ews-build] Update macOS queue configurations
4073         https://bugs.webkit.org/show_bug.cgi?id=193365
4074         <rdar://problem/47221073>
4075
4076         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
4077
4078         * BuildSlaveSupport/ews-build/config.json:
4079
4080 2019-01-13  Zalan Bujtas  <zalan@apple.com>
4081
4082         [LFC] Adjust assert for statically positioned fixed elements
4083         https://bugs.webkit.org/show_bug.cgi?id=193385
4084
4085         Reviewed by Antti Koivisto.
4086
4087         * LayoutReloaded/misc/LFC-passing-tests.txt:
4088
4089 2019-01-13  Philippe Normand  <pnormand@igalia.com>
4090
4091         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
4092         https://bugs.webkit.org/show_bug.cgi?id=193387
4093
4094         Reviewed by Carlos Garcia Campos.
4095
4096         * MiniBrowser/wpe/main.cpp:
4097         (main):
4098
4099 2019-01-12  Timothy Hatcher  <timothy@apple.com>
4100
4101         Have prefers-color-scheme: light always match on macOS versions before Mojave.
4102         https://bugs.webkit.org/show_bug.cgi?id=191655
4103         rdar://problem/46074680
4104
4105         Reviewed by Megan Gardner.
4106
4107         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
4108         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
4109
4110 2019-01-12  Dan Bernstein  <mitz@apple.com>
4111
4112         [Cocoa] Avoid importing directly from subumbrella frameworks
4113         https://bugs.webkit.org/show_bug.cgi?id=186016
4114         <rdar://problem/40591038>
4115
4116         Reviewed by Sam Weinig.
4117
4118         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4119           LaunchServices header.
4120         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4121           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4122         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4123           when using SDKs earlier than 10.13.
4124         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4125           and OTHER_CPLUSPLUSFLAGS.
4126         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4127           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4128         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4129           LaunchServices header.
4130
4131 2019-01-11  John Wilander  <wilander@apple.com>
4132
4133         Compile out Web API Statistics Collection
4134         https://bugs.webkit.org/show_bug.cgi?id=193370
4135         <rdar://problem/45388584>
4136
4137         Reviewed by Brent Fulgham.
4138
4139         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4140             Defined ENABLE_WEB_API_STATISTICS, off by default.
4141
4142 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4143
4144         [WPE] Add gtk-doc
4145         https://bugs.webkit.org/show_bug.cgi?id=178900
4146
4147         Reviewed by Michael Catanzaro.
4148
4149         Add Tools/gtkdoc to manifest.txt.in files.
4150         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
4151
4152         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
4153         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
4154
4155 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4156
4157         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
4158         https://bugs.webkit.org/show_bug.cgi?id=193364
4159         <rdar://problem/47214117>
4160
4161         Reviewed by Tim Horton.
4162
4163         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
4164         precise, whereas dragging near the middle of the textarea does.
4165
4166         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4167         (TestWebKitAPI::TEST):
4168
4169 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4170
4171         webkitpy: Support alternate simctl device list output
4172         https://bugs.webkit.org/show_bug.cgi?id=193362
4173         <rdar://problem/47122965>
4174
4175         Reviewed by Lucas Forschler.
4176
4177         * Scripts/webkitpy/xcode/simulated_device.py:
4178         (SimulatedDeviceManager.populate_available_devices):
4179
4180 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
4181
4182         [ews-build] Update macOS queue configurations
4183         https://bugs.webkit.org/show_bug.cgi?id=193365
4184
4185         Reviewed by Lucas Forschler.
4186
4187         * BuildSlaveSupport/ews-build/config.json:
4188
4189 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4190
4191         webkitpy: Incorporate device type into baseline search path
4192         https://bugs.webkit.org/show_bug.cgi?id=193356
4193         <rdar://problem/47215515>
4194
4195         Reviewed by Lucas Forschler.
4196
4197         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
4198
4199         * Scripts/webkitpy/port/base.py:
4200         (Port.default_baseline_search_path): Allow device type to be passed in.
4201         * Scripts/webkitpy/port/gtk.py:
4202         (GtkPort.default_baseline_search_path): Ignore device type.
4203         * Scripts/webkitpy/port/ios.py:
4204         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
4205         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
4206         * Scripts/webkitpy/port/ios_device_unittest.py:
4207         (IOSDeviceTest):
4208         * Scripts/webkitpy/port/ios_simulator_unittest.py:
4209         (IOSSimulatorTest):
4210         * Scripts/webkitpy/port/mac.py:
4211         (MacPort.default_baseline_search_path): Ignore device type.
4212         * Scripts/webkitpy/port/watch.py:
4213         (WatchPort.default_baseline_search_path): Ditto.
4214         * Scripts/webkitpy/port/win.py:
4215         (WinPort.default_baseline_search_path): Ditto.
4216         (WinCairoPort.default_baseline_search_path): Ditto.
4217         * Scripts/webkitpy/port/wpe.py:
4218         (WPEPort.default_baseline_search_path): Ditto.
4219
4220 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4221
4222         webkitpy: Print abbreviated baseline search path that includes only folders that exist
4223         https://bugs.webkit.org/show_bug.cgi?id=193352
4224         <rdar://problem/47210736>
4225
4226         Reviewed by Lucas Forschler.
4227
4228         * Scripts/webkitpy/layout_tests/views/printing.py:
4229         (Printer.print_config): Print list on only baseline search paths which exist. 
4230         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4231         (Testprinter.test_print_config):
4232
4233 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
4234
4235         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
4236         https://bugs.webkit.org/show_bug.cgi?id=193340
4237
4238         Reviewed by David Kilzer.
4239
4240         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4241         (WTR::InjectedBundle::didReceiveMessageToPage):
4242         Pull the strings out into a WKRetainPtr.
4243
4244         * WebKitTestRunner/WebNotificationProvider.cpp:
4245         (WTR::WebNotificationProvider::closeWebNotification):
4246         Adopt the created value into the WKRetainPtr.
4247
4248         * WebKitTestRunner/mac/TestControllerMac.mm:
4249         (WTR::generateWhitelist):
4250         Immediately adopt a created value to avoid potential mistakes.
4251
4252 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
4253
4254         Enable DFG on ARM/Linux again
4255         https://bugs.webkit.org/show_bug.cgi?id=192496
4256
4257         Reviewed by Yusuke Suzuki.
4258
4259         After changing the bytecode format DFG was disabled on all 32-bit
4260         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
4261         on ARM by default.
4262
4263         * Scripts/run-jsc-stress-tests:
4264
4265 2019-01-11  Timothy Hatcher  <timothy@apple.com>
4266
4267         Unreviewed, fix #ifdef in API test added in r239851.
4268         https://bugs.webkit.org/show_bug.cgi?id=193327
4269         rdar://problem/47093222
4270
4271         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
4272
4273 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4274
4275         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
4276         https://bugs.webkit.org/show_bug.cgi?id=193109
4277         <rdar://problem/44807048>
4278
4279         Reviewed by Ryosuke Niwa.
4280
4281         Introduce and respect a test option to enable the UndoManager API.
4282
4283         * WebKitTestRunner/TestController.cpp:
4284         (WTR::updateTestOptionsFromTestHeader):
4285         * WebKitTestRunner/TestOptions.h:
4286         (WTR::TestOptions::hasSameInitializationOptions const):
4287         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4288         (WTR::TestController::platformCreateWebView):
4289
4290 2019-01-11  Zalan Bujtas  <zalan@apple.com>
4291
4292         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
4293         https://bugs.webkit.org/show_bug.cgi?id=193346
4294
4295         Reviewed by Antti Koivisto.
4296
4297         * LayoutReloaded/misc/LFC-passing-tests.txt:
4298
4299 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
4300
4301         Unreviewed, fix typo that breaks dashboard link.
4302
4303         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4304         (WebKitBuildbot):
4305
4306 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
4307
4308         Update macOS queue configurations
4309         https://bugs.webkit.org/show_bug.cgi?id=193329
4310
4311         Reviewed by Alexey Proskuryakov.
4312
4313         * BuildSlaveSupport/build.webkit.org-config/config.json:
4314         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4315         (BubbleQueueServer):
4316         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4317         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4318         (WebKitBuildbot):
4319         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4320         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
4321         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4322
4323 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
4324
4325         MiniBrowser should be able to navigate to about:blank
4326         https://bugs.webkit.org/show_bug.cgi?id=193345
4327