Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
4         https://bugs.webkit.org/show_bug.cgi?id=196669
5
6         Reviewed by Geoffrey Garen.
7
8         Added three new unit tests for WeakHashSet.
9
10         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
11         (WTF_WeakPtr.WeakHashSetConstObjects):
12         (WTF_WeakPtr.WeakHashSetComputesEmpty):
13         (WTF_WeakPtr.WeakHashSetComputeSize):
14
15 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
16
17         Hide next and previous form control buttons when WKWebView is editable
18         https://bugs.webkit.org/show_bug.cgi?id=196672
19         <rdar://problem/35625321>
20
21         Reviewed by Tim Horton.
22
23         Add a new API test.
24
25         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
26         (-[TestWKWebView lastTrailingBarButtonGroup]):
27         (TestWebKitAPI::TEST):
28         * TestWebKitAPI/ios/UIKitSPI.h:
29
30 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
31
32         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
33         https://bugs.webkit.org/show_bug.cgi?id=196077
34         <rdar://problem/49108202>
35
36         Reviewed by Chris Dumez.
37
38         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
39         on new web view.
40
41         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
42
43 2019-04-05  Saam Barati  <sbarati@apple.com>
44
45         Make compare-results understand MotionMark
46         https://bugs.webkit.org/show_bug.cgi?id=196666
47
48         Reviewed by Yusuke Suzuki.
49
50         * Scripts/compare-results:
51         (PLT5Results):
52         (detectMotionMark):
53         (detectMotionMark1_1):
54         (motionMarkResults):
55         (motionMark1_1Results):
56         (detectBenchmark):
57         (biggerIsBetter):
58         (main):
59
60 2019-04-05  Alex Christensen  <achristensen@webkit.org>
61
62         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
63         https://bugs.webkit.org/show_bug.cgi?id=196665
64         <rdar://45115669>
65
66         Reviewed by Geoff Garen.
67
68         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
69         (goBack):
70         (+[SimpleLookupContext sharedLookupContext]):
71         (-[SimpleLookupContext lookUpURL:completionHandler:]):
72         (TEST):
73         (+[Simple3LookupContext sharedLookupContext]): Deleted.
74         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
75
76 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
77
78         [ews-build] Add configuration and architecture for windows builders
79         https://bugs.webkit.org/show_bug.cgi?id=196660
80
81         Reviewed by Lucas Forschler.
82
83         * BuildSlaveSupport/ews-build/config.json:
84
85 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
86
87         webkitpy: Don't run subsequent rounds if interrupted
88         https://bugs.webkit.org/show_bug.cgi?id=196646
89
90         Reviewed by Aakash Jain.
91
92         * Scripts/webkitpy/layout_tests/controllers/manager.py:
93         (Manager.run): Bail out if interrupted.
94
95 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
96
97         Test sessionStorage in PSON private browsing mode
98         https://bugs.webkit.org/show_bug.cgi?id=196561
99
100         Reviewed by Alex Christensen.
101
102         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
103
104 2019-04-05  Commit Queue  <commit-queue@webkit.org>
105
106         Unreviewed, rolling out r243833.
107         https://bugs.webkit.org/show_bug.cgi?id=196645
108
109         This change breaks build of WPE and GTK ports (Requested by
110         annulen on #webkit).
111
112         Reverted changeset:
113
114         "[CMake][WTF] Mirror XCode header directories"
115         https://bugs.webkit.org/show_bug.cgi?id=191662
116         https://trac.webkit.org/changeset/243833
117
118 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
119
120         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
121         https://bugs.webkit.org/show_bug.cgi?id=196635
122
123         Reviewed by Antti Koivisto.
124         
125         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
126         for a test to enable async frame scrolling via:
127             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
128         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
129         
130         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
131
132         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
133         (WTR::InjectedBundle::beginTesting):
134         * WebKitTestRunner/TestController.cpp:
135         (WTR::TestController::resetPreferencesToConsistentValues):
136
137 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
138
139         Use a correct LC_RPATH when building with ASan
140         https://bugs.webkit.org/show_bug.cgi?id=196576
141
142         Reviewed by David Kilzer.
143
144         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
145         so that ../Frameworks is checked. This is simpler and more reliable than updating
146         each SPC service xcconfig.
147
148 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
149
150         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
151         https://bugs.webkit.org/show_bug.cgi?id=196629
152
153         Reviewed by Lucas Forschler.
154
155         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
156
157 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
158
159         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
160         https://bugs.webkit.org/show_bug.cgi?id=196618
161
162         Reviewed by Lucas Forschler.
163
164         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
165         (StatusBubble): Added QUEUE_TRIGGERS.
166         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
167         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
168         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
169         its parent(builder).
170
171 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
172
173         [ews-app] Status-bubble steps are sometimes displayed in reverse order
174         https://bugs.webkit.org/show_bug.cgi?id=196625
175
176         Reviewed by Lucas Forschler.
177
178         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
179         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
180
181 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
182
183         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
184         https://bugs.webkit.org/show_bug.cgi?id=196630
185
186         Reviewed by Wenson Hsieh.
187
188         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
189
190 2019-04-04  Youenn Fablet  <youenn@apple.com>
191
192         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
193         https://bugs.webkit.org/show_bug.cgi?id=196543
194
195         Reviewed by Alex Christensen.
196
197         * WebKitTestRunner/TestController.cpp:
198         (WTR::TestController::generatePageConfiguration):
199
200 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
201
202         [ews-app] Status bubble should not display skipped buildbot steps
203         https://bugs.webkit.org/show_bug.cgi?id=196584
204
205         Reviewed by Lucas Forschler.
206
207         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
208
209 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
210
211         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
212         https://bugs.webkit.org/show_bug.cgi?id=196620
213
214         Reviewed by Lucas Forschler.
215
216         * BuildSlaveSupport/ews-app/ews/config.py:
217
218 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
219
220         [Win] DumpRenderTreeWatchDog.py is not checked into source
221         https://bugs.webkit.org/show_bug.cgi?id=196567
222         <rdar://problem/49525901>
223
224         Reviewed by Lucas Forschler.
225
226         This script is used on Win EWS bots to terminate hanging DRT processes.
227
228         * EWSTools/dumprendertreewatchdog.py: Added.
229
230 2019-04-04  Chris Dumez  <cdumez@apple.com>
231
232         Unreviewed, roll out r243858 which made tests time out.
233
234         Disable new API tests on Windows instead.
235
236         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
237         (TestWebKitAPI::TEST):
238
239 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
240
241         [ATK] Cleanup WebPageAccessibilityObjectAtk
242         https://bugs.webkit.org/show_bug.cgi?id=196537
243
244         Reviewed by Michael Catanzaro.
245
246         Also consider files under atk directories as exceptions for GObject conventions.
247
248         * Scripts/webkitpy/style/checkers/cpp.py:
249         (check_identifier_name_in_declaration):
250
251 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
252
253         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
254         https://bugs.webkit.org/show_bug.cgi?id=196588
255         <rdar://problem/49365787>
256
257         Unreviewed build fix for Windows port.
258
259         error C3861: 'kill': identifier not found
260
261         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
262         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
263
264 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
265
266         [ews-build] Cancel build and similar operations should have authentication
267         https://bugs.webkit.org/show_bug.cgi?id=196520
268
269         Reviewed by Dewei Zhu.
270
271         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
272         environment variables.
273
274 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
275
276         [ews-build] Do not trigger queues which are not in production yet
277         https://bugs.webkit.org/show_bug.cgi?id=196581
278
279         Reviewed by Dewei Zhu.
280
281         * BuildSlaveSupport/ews-build/config.json:
282
283 2019-04-03  Chris Dumez  <cdumez@apple.com>
284
285         Unreviewed, fix typo in the name of API test added in r243848.
286
287         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
288         (TestWebKitAPI::TEST):
289
290 2019-04-03  Chris Dumez  <cdumez@apple.com>
291
292         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
293         https://bugs.webkit.org/show_bug.cgi?id=196588
294         <rdar://problem/49365787>
295
296         Reviewed by Ryosuke Niwa.
297
298         Add API test coverage.
299
300         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
301         (TestWebKitAPI::nullJavaScriptCallback):
302         (TestWebKitAPI::didCrashCheckFrames):
303         (TestWebKitAPI::TEST):
304
305 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
306
307         run-webkit-tests: Upload test results (new results database)
308         https://bugs.webkit.org/show_bug.cgi?id=196577
309         <rdar://problem/34841155>
310
311         Reviewed by Lucas Forschler.
312
313         * Scripts/webkitpy/layout_tests/controllers/manager.py:
314         (Manager.run): Upload results after each device shard, since the configuration will be
315         different for each device.
316         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
317         uploaded to a results database.
318         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
319         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
320
321 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
322
323         -apple-trailing-word is needed for browser detection
324         https://bugs.webkit.org/show_bug.cgi?id=196575
325
326         Unreviewed.
327
328         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
329
330 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
331
332         [CMake][WTF] Mirror XCode header directories
333         https://bugs.webkit.org/show_bug.cgi?id=191662
334
335         Reviewed by Konstantin Tokarev.
336
337         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
338         builds.
339
340         * CMakeLists.txt:
341         * DumpRenderTree/CMakeLists.txt:
342         * DumpRenderTree/PlatformWin.cmake:
343         * MiniBrowser/win/CMakeLists.txt:
344         * TestWebKitAPI/CMakeLists.txt:
345         * TestWebKitAPI/PlatformWin.cmake:
346         * WebKitTestRunner/PlatformGTK.cmake:
347         * WebKitTestRunner/PlatformWin.cmake:
348
349 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
350
351         [ews-app] Status bubble should not display certain infrastructure status messages
352         https://bugs.webkit.org/show_bug.cgi?id=196550
353
354         Reviewed by Lucas Forschler.
355
356         Do not display the steps which are un-needed for end-user. This information is still avaiable
357         if the user click on the bubble and look at the Buildbot build.
358         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
359         (StatusBubble._steps_messages):
360         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
361
362 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
363
364         [ews-build] Use https for sending data to ews-app
365         https://bugs.webkit.org/show_bug.cgi?id=196492
366
367         Reviewed by Lucas Forschler.
368
369         * BuildSlaveSupport/ews-build/events.py:
370
371 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
372
373         Remove support for -apple-trailing-word
374         https://bugs.webkit.org/show_bug.cgi?id=196525
375
376         Reviewed by Zalan Bujtas.
377
378         This CSS property is nonstandard and not used.
379
380         * Scripts/webkitperl/FeatureList.pm:
381         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
382
383 2019-04-03  Youenn Fablet  <youenn@apple.com>
384
385         Add a test for DOMCache on multiple browsing in case of private browsing
386         https://bugs.webkit.org/show_bug.cgi?id=196524
387
388         Reviewed by Alex Christensen.
389
390         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
391         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
392
393 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
394
395         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
396         https://bugs.webkit.org/show_bug.cgi?id=196540
397
398         Reviewed by Aakash Jain.
399
400         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
401
402 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
403
404         Add plumbing for a compatibility mode preference in WebKit
405         https://bugs.webkit.org/show_bug.cgi?id=196005
406
407         Reviewed by Tim Horton.
408
409         Add new API tests.
410
411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
412         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
413
414 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
415
416         [WPE][GTK] Update libsrtp dependency package for Debian
417         https://bugs.webkit.org/show_bug.cgi?id=196528
418
419         Reviewed by Frédéric Wang.
420
421         * gtk/install-dependencies:
422         * wpe/install-dependencies:
423
424 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
425
426         [WK2] Add support for Window's beforeprint / afterprint events
427         https://bugs.webkit.org/show_bug.cgi?id=196478
428         <rdar://problem/49535124>
429
430         Unreviewed build fix for MSVC.
431
432         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
433
434         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
435
436         * WebKitTestRunner/TestController.cpp:
437         (WTR::printFrame): Use int and float literals.
438
439 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
440
441         [ews-build] Reassign bots to queues
442
443         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
444
445 2019-04-02  Chris Dumez  <cdumez@apple.com>
446
447         [WK2] Add support for Window's beforeprint / afterprint events
448         https://bugs.webkit.org/show_bug.cgi?id=196478
449
450         Reviewed by Alex Christensen.
451
452         Add minimal implementation for printFrame in WebKitTestRunner.
453
454         * WebKitTestRunner/TestController.cpp:
455         (WTR::printFrame):
456         (WTR::TestController::createOtherPage):
457         (WTR::TestController::createWebViewWithOptions):
458
459 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
460
461         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
462         https://bugs.webkit.org/show_bug.cgi?id=196491
463
464         Reviewed by Lucas Forschler.
465
466         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
467
468 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
469
470         [ews-build] Configure buildbot try credentials in environment variables
471         https://bugs.webkit.org/show_bug.cgi?id=196501
472
473         Reviewed by Lucas Forschler.
474
475         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
476         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
477         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
478
479 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
480
481         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
482         https://bugs.webkit.org/show_bug.cgi?id=196496
483         <rdar://problem/49521634>
484
485         Reviewed by Chris Dumez.
486
487         Add new API tests (see WebKit ChangeLog for more detail).
488
489         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
490         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
491         (TEST):
492
493 2019-04-02  David Kilzer  <ddkilzer@apple.com>
494
495         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
496         <https://webkit.org/b/196499>
497
498         Reviewed by Alexey Proskuryakov.
499
500         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
501         ENABLE_ADDRESS_SANITIZER.
502
503 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
504
505         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
506         https://bugs.webkit.org/show_bug.cgi?id=182757
507
508         Reviewed by Don Olmstead.
509
510         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
511         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
512
513 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
514
515         run-api-tests: Upload test results
516         https://bugs.webkit.org/show_bug.cgi?id=196323
517         <rdar://problem/49356714>
518
519         Reviewed by Lucas Forschler.
520
521         * Scripts/webkitpy/api_tests/manager.py:
522         (Manager):
523         (Manager.run): Upload results to a results database.
524         * Scripts/webkitpy/api_tests/run_api_tests.py:
525         (parse_args): Add upload arguments.
526         * Scripts/webkitpy/port/base.py:
527         (Port):
528         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
529         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
530         with commits from any other associated repositories.
531         * Scripts/webkitpy/port/device.py:
532         (Device):
533         (Device.build_version): Access build_versoin of underlying platform device.
534         * Scripts/webkitpy/port/ios_simulator_unittest.py:
535         (IOSSimulatorTest):
536         (IOSSimulatorTest.test_configuration_for_upload):
537         * Scripts/webkitpy/port/device_port.py:
538         (DevicePort):
539         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
540         the same as the machine uploading results.
541         * Scripts/webkitpy/port/mac.py:
542         (MacPort):
543         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
544         * Scripts/webkitpy/port/mac_unittest.py:
545         (MacTest):
546         (MacTest.test_configuration_for_upload):
547         * Scripts/webkitpy/xcode/simulated_device.py:
548         (SimulatedDeviceManager._create_device_with_runtime):
549         (SimulatedDevice.__init__): Create simulated device with a build_version.
550         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
551         (test_existing_simulator):
552
553 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
554
555         Remove extra newline characters (Follow-up fix to r243707)
556
557         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
558
559 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
560
561         [ews-app] Use API_KEY to accept results data
562         https://bugs.webkit.org/show_bug.cgi?id=196461
563
564         Reviewed by Dewei Zhu.
565
566         * BuildSlaveSupport/ews-app/ews/views/results.py:
567         (Results.post): Validate EWS_API_KEY before accepting any data.
568         * BuildSlaveSupport/ews-build/events.py:
569         (Events.sendData): Send EWS_API_KEY if available along with event data.
570
571 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
572
573         Unable to copy and paste a PDF from Notes into Mail compose body
574         https://bugs.webkit.org/show_bug.cgi?id=196442
575         <rdar://problem/48573098>
576
577         Reviewed by Tim Horton.
578
579         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
580         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
581         to be specified on the item providers.
582
583         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
584         (TestWebKitAPI::mapItemForTesting):
585         (TestWebKitAPI::contactItemForTesting):
586
587 2019-04-01  Tim Horton  <timothy_horton@apple.com>
588
589         Make UIWKDocumentContext rects per-character instead of per-word
590         https://bugs.webkit.org/show_bug.cgi?id=196459
591
592         Reviewed by Wenson Hsieh.
593
594         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
595         (TEST):
596         Adjust test results due to switching to per-character rects.
597
598 2019-04-01  Chris Dumez  <cdumez@apple.com>
599
600         UIProcess crash when a prewarmed process is terminated
601         https://bugs.webkit.org/show_bug.cgi?id=196451
602         <rdar://problem/49245471>
603
604         Reviewed by Geoffrey Garen.
605
606         Add API test coverage.
607
608         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
609         (TEST):
610
611 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
612
613         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
614         https://bugs.webkit.org/show_bug.cgi?id=196449
615
616         Reviewed by Lucas Forschler.
617
618         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
619         (StatusBubble.get_os_details): Method to get OS and Xcode details.
620         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
621         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
622
623 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
624
625         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
626         https://bugs.webkit.org/show_bug.cgi?id=196444
627
628         Reviewed by Lucas Forschler.
629
630         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
631
632 2019-04-01  Alex Christensen  <achristensen@webkit.org>
633
634         Add SPI to canonicalize NSURLs with WTF::URL
635         https://bugs.webkit.org/show_bug.cgi?id=196415
636         <rdar://problem/44980271>
637
638         Reviewed by Darin Adler.
639
640         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
641         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
642         (TestWebKitAPI::TEST):
643
644 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
645
646         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
647         https://bugs.webkit.org/show_bug.cgi?id=196441
648
649         Reviewed by Carlos Garcia Campos.
650
651         Don't cache the wpe_view_backend object that might not exist yet at the
652         time of EventSenderProxy constructor invocation, but instead retrieve
653         that object whenever it's required for event dispatching. This should
654         avoid crashes in this constructor now that it's invoked before any
655         PlatformWindow has been set up (as changed in r243496).
656
657         * WebKitTestRunner/EventSenderProxy.h:
658         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
659         (WTR::viewBackend):
660         (WTR::EventSenderProxy::EventSenderProxy):
661         (WTR::EventSenderProxy::mouseDown):
662         (WTR::EventSenderProxy::mouseUp):
663         (WTR::EventSenderProxy::mouseMoveTo):
664         (WTR::EventSenderProxy::mouseScrollBy):
665         (WTR::EventSenderProxy::keyDown):
666         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
667
668 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
669
670         [Win][WebKit] MiniBrowser should support high DPI display
671         https://bugs.webkit.org/show_bug.cgi?id=196391
672
673         Reviewed by Alex Christensen.
674
675         * MiniBrowser/win/WebKitBrowserWindow.cpp:
676         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
677         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
678         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
679
680 2019-03-31  Sam Weinig  <weinig@apple.com>
681
682         Remove more i386 specific configurations
683         https://bugs.webkit.org/show_bug.cgi?id=196430
684
685         Reviewed by Alexey Proskuryakov.
686
687         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
688         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
689
690 2019-03-31  Andy Estes  <aestes@apple.com>
691
692         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
693         https://bugs.webkit.org/show_bug.cgi?id=196433
694         <rdar://problem/49293305>
695
696         Reviewed by Tim Horton.
697
698         Enhanced API test coverage to include all navigation response policy decisions in both
699         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
700
701         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
702         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
703         (TestWebKitAPI::TEST):
704         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
705         (readFile):
706         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
707         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
708         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
709         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
710         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
711         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
712         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
713         (-[QuickLookDelegate _downloadDidStart:]):
714         (-[QuickLookDelegate _download:didReceiveResponse:]):
715         (-[QuickLookDelegate _download:didReceiveData:]):
716         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
717         (-[QuickLookDelegate _downloadDidFinish:]):
718         (-[QuickLookDelegate _download:didFailWithError:]):
719         (-[QuickLookDelegate _downloadDidCancel:]):
720         (-[QuickLookDelegate verifyDownload]):
721         (runTest):
722         (runTestDecideBeforeLoading):
723         (runTestDecideAfterLoading):
724         (TEST):
725         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
726         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
727         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
728         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
729         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
730         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
731         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
732         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
733         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
734         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
735         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
736         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
737         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
738         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
739
740 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
741
742         [CMake] add testdfg as target with build-jsc
743         https://bugs.webkit.org/show_bug.cgi?id=196393
744
745         Reviewed by Saam Barati.
746
747         Added testdfg as one of the targets to build when
748         using CMake.
749
750         * Scripts/build-jsc:
751
752 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
753
754         Delete WebMetal implementation in favor of WebGPU
755         https://bugs.webkit.org/show_bug.cgi?id=195418
756
757         Reviewed by Dean Jackson.
758
759         * DumpRenderTree/mac/DumpRenderTree.mm:
760         (enableExperimentalFeatures):
761         (resetWebPreferencesToConsistentValues):
762         * Scripts/webkitperl/FeatureList.pm:
763         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
764         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
765         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
766         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
767         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
768         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
769         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
770         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
771         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
772         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
773         (WTR::InjectedBundle::beginTesting):
774         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
775         (WTR::TestRunner::setWebMetalEnabled): Deleted.
776         * WebKitTestRunner/InjectedBundle/TestRunner.h:
777
778 2019-03-29  Chris Dumez  <cdumez@apple.com>
779
780         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
781         https://bugs.webkit.org/show_bug.cgi?id=196405
782         <rdar://problem/49428130>
783
784         Reviewed by Wenson Hsieh.
785
786         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
787         the popover presentation methods to be no-ops. Use this in the new test added in
788         r243523 so that we do not swizzle those methods for all tests. This is needed because
789         those WatchOS tests rely on the popover getting presented and interactive.
790
791         * WebKitTestRunner/TestController.cpp:
792         (WTR::updateTestOptionsFromTestHeader):
793         * WebKitTestRunner/TestController.h:
794         * WebKitTestRunner/TestOptions.h:
795         (WTR::TestOptions::hasSameInitializationOptions const):
796         * WebKitTestRunner/ios/TestControllerIOS.mm:
797         (WTR::TestController::platformInitialize):
798         (WTR::TestController::platformResetStateToConsistentValues):
799
800 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
801
802         [Curl] Add Server Trust Evaluation Support.
803         https://bugs.webkit.org/show_bug.cgi?id=191646
804
805         Reviewed by Fujii Hironori.
806
807         Implemented MiniBrowser UI for asking if user trusts the server.
808
809         * MiniBrowser/win/Common.cpp:
810         (askServerTrustEvaluation):
811         (replaceString):
812         * MiniBrowser/win/Common.h:
813         * MiniBrowser/win/MiniBrowserLib.rc:
814         * MiniBrowser/win/MiniBrowserLibResource.h:
815         * MiniBrowser/win/WebKitBrowserWindow.cpp:
816         (createPEMString):
817         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
818         (WebKitBrowserWindow::canTrustServerCertificate):
819         * MiniBrowser/win/WebKitBrowserWindow.h:
820
821 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
822
823         Implement ResizeObserver.
824         https://bugs.webkit.org/show_bug.cgi?id=157743
825
826         Reviewed by Simon Fraser.
827
828         Support resizeObserverEnabled webPreferences.
829
830         * DumpRenderTree/TestOptions.cpp:
831         (TestOptions::TestOptions):
832         * DumpRenderTree/TestOptions.h:
833         * DumpRenderTree/mac/DumpRenderTree.mm:
834         (setWebPreferencesForTestOptions):
835         * DumpRenderTree/win/DumpRenderTree.cpp:
836         (enableExperimentalFeatures):
837         * Scripts/webkitperl/FeatureList.pm:
838         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
839
840 2019-03-28  John Wilander  <wilander@apple.com>
841
842         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
843         https://bugs.webkit.org/show_bug.cgi?id=196281
844         <rdar://problem/48938748>
845
846         Reviewed by Alex Christensen.
847
848         This patch adds the function isStatisticsHasLocalStorage() to the
849         TestRunner. With it, the page can query the WebsiteDataStore in the
850         UI process to make sure that it sees LocalStorage.
851
852         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
853         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
854         (WTR::TestRunner::isStatisticsHasLocalStorage):
855         * WebKitTestRunner/InjectedBundle/TestRunner.h:
856         * WebKitTestRunner/TestController.cpp:
857         (WTR::TestController::isStatisticsHasLocalStorage):
858         * WebKitTestRunner/TestController.h:
859         * WebKitTestRunner/TestInvocation.cpp:
860         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
861
862 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
863
864         API::Data::createWithoutCopying should do a null check before calling CFRelease
865         https://bugs.webkit.org/show_bug.cgi?id=196276
866         <rdar://problem/48059859>
867
868         Reviewed by Alex Christensen.
869
870         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
871
872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
873         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
874         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
875         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
876         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
877         (TestWebKitAPI::TEST):
878
879 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
880
881         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
882         https://bugs.webkit.org/show_bug.cgi?id=186276
883
884         Reviewed by Carlos Garcia Campos.
885
886         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
887         (webViewLoadChanged):
888         (testWebResourceGetDataError):
889         (testWebResourceGetDataEmpty):
890         (beforeAll):
891         (webViewloadChanged): Deleted.
892
893 2019-03-27  Andy Estes  <aestes@apple.com>
894
895         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
896         https://bugs.webkit.org/show_bug.cgi?id=196317
897
898         Reviewed by Dan Bernstein.
899
900         package-root copies built products into a staging directory using ditto(1), which does not
901         follow symbolic links as it traverses a directory. Now that the files in
902         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
903         itself, these become broken links when ditto'd into the staging directory.
904
905         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
906
907         * Scripts/package-root:
908
909 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
910
911         [ews-app] Update display text of Submit for ews analysis
912         https://bugs.webkit.org/show_bug.cgi?id=196309
913
914         Reviewed by Dewei Zhu.
915
916         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
917
918 2019-03-27  David Kilzer  <ddkilzer@apple.com>
919
920         run-webkit-tests should check for leaks in WebKit processes
921         <https://webkit.org/b/193772>
922         <rdar://problem/46526680>
923
924         Reviewed by Ryosuke Niwa.
925
926         This works by doing the following:
927         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
928           The list of child processes are returned one per line:
929           process.name: pid
930         - Run the "#LIST CHILD PROCESSES" command just before the
931           "#CHECK FOR WORLD LEAKS" command, and store the list of child
932           processes on the ServerProcess object.
933         - When the `--leaks` switch is handled, run check_for_leaks() on
934           each child process after the main test harness.
935
936         * DumpRenderTree/mac/DumpRenderTree.mm:
937         (handleControlCommand):
938         - Use strncmp() instead of strcmp().
939         - Add support for handling "#LIST CHILD PROCESSES" command.
940
941         * Scripts/webkitpy/port/base.py:
942         (Port.check_for_leaks):
943         * Scripts/webkitpy/port/darwin.py:
944         (DarwinPort.check_for_leaks):
945         - Rename redundant 'process_pid' argument to 'process_id'.
946
947         * Scripts/webkitpy/port/driver.py:
948         (Driver.do_post_tests_work):
949         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
950           longer the only command this sends to WebKitTestRunner.
951         - If the `--leaks` switch is present, send the
952           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
953           result using Port.set_webkit_processes().
954         (Driver._parse_child_processes_output):
955         - Add helper method to parse list of child process names and
956           process IDs returned from WebKitTestRunner.
957
958         * Scripts/webkitpy/port/ios_device.py:
959         (IOSDevicePort.check_for_leaks):
960         - Rename redundant 'process_pid' argument to 'process_id'.
961
962         * Scripts/webkitpy/port/leakdetector.py:
963         (LeakDetector._parse_leaks_output):
964         - Return early if there is no leaks_output.
965         (LeakDetector.check_for_leaks):
966         - Rename redundant 'process_pid' argument to 'process_id'.
967
968         * Scripts/webkitpy/port/server_process.py:
969         (ServerProcess.__init__):
970         (ServerProcess.child_processes):
971         (ServerProcess.set_child_processes):
972         - Add instance variable to Port to store list of child process
973           names and process IDs returned from WebKitTestRunner.
974         (ServerProcess._start):
975         - Clear self._child_processes.
976         (ServerProcess.stop):
977         - If self._child_processes is set, call
978           self._port.check_for_leaks() for each child process.
979
980         * Scripts/webkitpy/port/server_process_unittest.py:
981         (TrivialMockPort.check_for_leaks):
982         - Rename redundant 'process_pid' argument to 'process_id'.
983
984         * Scripts/webkitpy/port/simulator_process.py:
985         (SimulatorProcess.stop):
986         - If self._child_processes is set, call
987           self._port.check_for_leaks() for each child process.
988
989         * Scripts/webkitpy/port/watch_device.py:
990         (WatchDevicePort.check_for_leaks):
991         - Rename redundant 'process_pid' argument to 'process_id'.
992
993         * WebKitTestRunner/TestController.cpp:
994         (WTR::TestController::dumpResponse):
995         - Extract method from findAndDumpWorldLeaks() so that it may be
996           reused by findAndDumpWebKitProcessIdentifiers().
997         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
998         - Add method to output process name and process ID of both the
999           WebContent and Networking processes.
1000         (WTR::TestController::findAndDumpWorldLeaks):
1001         - Fix missing newline in output when there were no abandoned
1002           documents.
1003         - Call dumpResponse() for extracted code.
1004         (WTR::TestController::handleControlCommand):
1005         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1006         - Use strncmp() instead of strcmp().
1007         - Call findAndDumpWebKitProcessIdentifiers() when
1008           "#LIST CHILD PROCESSES" command is sent.
1009         * WebKitTestRunner/TestController.h:
1010         (WTR::TestController::dumpResponse):
1011         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1012         - Declare methods.
1013
1014 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1015
1016         Unreviewed. Add GLib API test cases after r243434.
1017
1018         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1019         (testWebViewActiveURI):
1020         (serverCallback):
1021         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1022         (sendRequestCallback):
1023
1024 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1025
1026         Geolocation request not complete when watch request was started in a different web process
1027         https://bugs.webkit.org/show_bug.cgi?id=195996
1028
1029         Reviewed by Alex Christensen.
1030
1031         Add a test case.
1032
1033         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1034         (TestWebKitAPI::runJavaScriptAlert):
1035         (TestWebKitAPI::TEST):
1036
1037 2019-03-26  Keith Rollin  <krollin@apple.com>
1038
1039         Update the way generate-xcfilelists returns strings from functions
1040         https://bugs.webkit.org/show_bug.cgi?id=195975
1041         <rdar://problem/49040807>
1042
1043         Reviewed by Dean Jackson.
1044
1045         There are places where generate-xcfilelists executes assignments with
1046         statements like:
1047
1048             FOO=$(some_function)
1049
1050         where "some_function" return a string by echoing it. E.g.
1051
1052             some_function()
1053             {
1054                 echo "Hello, World"
1055             }
1056
1057         This is a common idiom, but it has a problem if "some_function" needs
1058         to call "exit" in an attempt to halt the entire script right then and
1059         there. Since "some_function" is called inside of $(), it's being
1060         executed in a sub-shell. Calling exit in that sub-shell simply exits
1061         that shell; it doesn't not exit the outer shell in which the main part
1062         of the script is still running. As such, the main script keeps
1063         executing when the intent was for the script to halt.
1064
1065         The solution to this is to use a different idiom for returning
1066         strings. The one we now is to pass in the name of the variable to
1067         receive the string result:
1068
1069             some_function()
1070             {
1071                 variable_name=$1
1072                 eval $variable_name ="Hello, World"
1073             }
1074
1075         The call site now looks like
1076
1077             some_function FOO
1078
1079         Because there's no invocation of a sub-shell, some_function can now
1080         call "exit" if it wants to, and the entire script will exit at that
1081         point.
1082
1083         * Scripts/generate-xcfilelists:
1084
1085 2019-03-26  Chris Dumez  <cdumez@apple.com>
1086
1087         Add basic layout test coverage for File Picker on iOS
1088         https://bugs.webkit.org/show_bug.cgi?id=196265
1089
1090         Reviewed by Wenson Hsieh.
1091
1092         Add layout test infrastructure to test the file picker on iOS.
1093
1094         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1095         (WTR::UIScriptController::dismissFilePicker):
1096         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1097         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1098         (WTR::UIScriptController::dismissFilePicker):
1099         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1100         * WebKitTestRunner/TestController.cpp:
1101         (WTR::TestController::createWebViewWithOptions):
1102         (WTR::updateTestOptionsFromTestHeader):
1103         * WebKitTestRunner/TestOptions.h:
1104         (WTR::TestOptions::hasSameInitializationOptions const):
1105         * WebKitTestRunner/ios/TestControllerIOS.mm:
1106         (overridePresentViewController):
1107         (WTR::TestController::platformInitialize):
1108         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1109         (WTR::UIScriptController::dismissFilePicker):
1110
1111 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1112
1113         Implement async paste method on UIWKInteractionViewProtocol
1114         https://bugs.webkit.org/show_bug.cgi?id=196267
1115         <rdar://problem/49236346>
1116
1117         Reviewed by Tim Horton.
1118
1119         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1120         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1121         are now a part of all iOS 12 internal SDKs.
1122
1123         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1124
1125         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1126         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1127
1128         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1129         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1130         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1131         * TestWebKitAPI/ios/UIKitSPI.h:
1132
1133 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1134
1135         [ews-build] Use PostgreSQL for ews.webkit.org database
1136         https://bugs.webkit.org/show_bug.cgi?id=196270
1137
1138         Reviewed by Lucas Forschler.
1139
1140         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1141
1142 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1143
1144         [ews] Reset simctl states on reboot
1145         https://bugs.webkit.org/show_bug.cgi?id=196260
1146
1147         Rubber-stamped by Aakash Jain.
1148
1149         * EWSTools/start-queue-mac.sh:
1150
1151 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1152
1153         [ews-build] Use PostgreSQL for ews-build database
1154         https://bugs.webkit.org/show_bug.cgi?id=196229
1155
1156         Reviewed by Lucas Forschler.
1157
1158         * BuildSlaveSupport/ews-build/master.cfg:
1159
1160 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1161
1162         [ews-build] Get master_hostname dynamically in master.cfg
1163         https://bugs.webkit.org/show_bug.cgi?id=196255
1164
1165         Reviewed by Lucas Forschler.
1166
1167         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1168         send events data in test mode.
1169
1170 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1171
1172         [ews-app] Set db_constraint to False for Foreign Keys
1173         https://bugs.webkit.org/show_bug.cgi?id=196252
1174
1175         Reviewed by Lucas Forschler.
1176
1177         * BuildSlaveSupport/ews-app/ews/models/build.py:
1178         * BuildSlaveSupport/ews-app/ews/models/step.py:
1179
1180 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1181
1182         [ews-build] is_test_mode_enabled should default to True
1183         https://bugs.webkit.org/show_bug.cgi?id=196248
1184
1185         Reviewed by Lucas Forschler.
1186
1187         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1188
1189 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1190
1191         [ews-app] Add webkitperl to ENABLED_QUEUES
1192         https://bugs.webkit.org/show_bug.cgi?id=196253
1193
1194         Reviewed by Lucas Forschler.
1195
1196         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1197
1198 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1199
1200         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1201         https://bugs.webkit.org/show_bug.cgi?id=196211
1202         rdar://problem/49110552
1203
1204         Reviewed by Tim Horton.
1205
1206         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1207         Make sure that EventSenderProxy always exists when running tests. We used to create
1208         it when resetting before the first test, which is a bit too late.
1209
1210         * WebKitTestRunner/TestController.h:
1211         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1212         (WTR::TestController::platformCreateWebView):
1213         (WTR::TestController::platformCreateOtherPage):
1214         (WTR::TestController::finishCreatingPlatformWebView):
1215         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1216         (WTR::PlatformWebView::PlatformWebView):
1217         Moved some code that made NSWindow use NSEvent during web view creation. We may
1218         need to move more if some other case us found, but this is enough for now.
1219
1220 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1221
1222         Unreviewed. Fix typo in GLib geolocation API after r243285.
1223
1224         gelocation -> geolocation.
1225
1226         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1227         (testGeolocationManagerWatchPosition):
1228
1229 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1230
1231         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1232         https://bugs.webkit.org/show_bug.cgi?id=196213
1233
1234         Reviewed by Geoff Garen.
1235
1236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1237         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1238         (credentialWithIdentityAndKeychainPath):
1239         (-[ChallengeDelegate webView:didFinishNavigation:]):
1240         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1241         (TestWebKitAPI::TEST):
1242
1243 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1244
1245         Expected shouldn't assume its contained types are copyable
1246         https://bugs.webkit.org/show_bug.cgi?id=195986
1247
1248         Reviewed by JF Bastien.
1249
1250         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1251         (TestWebKitAPI::NonCopyable::operator== const):
1252         (TestWebKitAPI::NonCopyable::operator!= const):
1253         (TestWebKitAPI::TEST):
1254
1255 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1256
1257         Remove some now-unnecessary dynamic class lookup
1258         https://bugs.webkit.org/show_bug.cgi?id=196237
1259
1260         Reviewed by Simon Fraser.
1261
1262         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1263         (makeRequest):
1264         (TEST):
1265
1266 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1267
1268         Unreviewed, rolling out r243450.
1269
1270         AppleWin and WinCairo port builds get broken.
1271
1272         Reverted changeset:
1273
1274         "Add test for fix of #196095"
1275         https://bugs.webkit.org/show_bug.cgi?id=196097
1276         https://trac.webkit.org/changeset/243450
1277
1278 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1279
1280         Unreviewed, rolling out r243465.
1281         https://bugs.webkit.org/show_bug.cgi?id=196226
1282
1283         the test doesn't build (Requested by thorton on #webkit).
1284
1285         Reverted changeset:
1286
1287         "Do not terminate the NetworkProcess if a third party
1288         application sends a NSCredential with a SecIdentityRef"
1289         https://bugs.webkit.org/show_bug.cgi?id=196213
1290         https://trac.webkit.org/changeset/243465
1291
1292 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1293
1294         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1295         https://bugs.webkit.org/show_bug.cgi?id=196213
1296
1297         Reviewed by Geoff Garen.
1298
1299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1300         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1301         (credentialWithIdentityAndKeychainPath):
1302         (-[ChallengeDelegate webView:didFinishNavigation:]):
1303         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1304         (TestWebKitAPI::TEST):
1305
1306 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1307
1308         [ews-build] Gracefully handle missing patch_id in events
1309         https://bugs.webkit.org/show_bug.cgi?id=196216
1310
1311         Reviewed by Lucas Forschler.
1312
1313         * BuildSlaveSupport/ews-build/events.py:
1314
1315 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1316
1317         [ews-build] use lz4 compression for improving buildbot performance
1318         https://bugs.webkit.org/show_bug.cgi?id=196155
1319
1320         Reviewed by Lucas Forschler.
1321
1322         * BuildSlaveSupport/ews-build/master.cfg:
1323
1324 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1325
1326         Pull some API testing helper methods out of TestWKWebView
1327         https://bugs.webkit.org/show_bug.cgi?id=196212
1328
1329         Reviewed by Tim Horton.
1330
1331         Refactor some more API testing utility methods, so that they can be used in
1332         tests that do not use TestWKWebView.
1333
1334         * TestWebKitAPI/cocoa/TestWKWebView.h:
1335         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1336         (-[WKWebView loadTestPageNamed:]):
1337         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1338         (-[WKWebView synchronouslyLoadHTMLString:]):
1339         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1340         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1341         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1342         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1343         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1344
1345 2019-03-25  Jer Noble  <jer.noble@apple.com>
1346
1347         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1348         https://bugs.webkit.org/show_bug.cgi?id=196097
1349
1350         Reviewed by Eric Carlson.
1351
1352         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1353
1354         * DumpRenderTree/mac/DumpRenderTree.mm:
1355         (resetWebPreferencesToConsistentValues):
1356         * WebKitTestRunner/TestController.cpp:
1357         (WTR::TestController::resetPreferencesToConsistentValues):
1358
1359 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1360
1361         Pull IPadUserInterfaceSwizzler out into a separate header file
1362         https://bugs.webkit.org/show_bug.cgi?id=196193
1363
1364         Reviewed by Anders Carlsson.
1365
1366         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1367         be used in other API tests.
1368
1369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1370         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1371         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1372         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1373         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1374         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1375         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1376
1377 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1378
1379         Remove NavigatorContentUtils in WebCore/Modules
1380         https://bugs.webkit.org/show_bug.cgi?id=196070
1381
1382         Reviewed by Alex Christensen.
1383
1384         NavigatorContentUtils was to support the custom scheme spec [1].
1385         However, in WebKit side, no port has supported the feature in
1386         WebKit layer after EFL port was removed. So there has been the
1387         only IDL implementation of the NavigatorContentUtils in WebCore.
1388         So we don't need to keep the implementation in WebCore anymore.
1389
1390         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1391
1392         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1393
1394 2019-03-24  Andy Estes  <aestes@apple.com>
1395
1396         [watchOS] Remove unused Proximity Networking code
1397         https://bugs.webkit.org/show_bug.cgi?id=196188
1398
1399         Reviewed by Tim Horton.
1400
1401         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1402         (TEST):
1403
1404 2019-03-23  Keith Miller  <keith_miller@apple.com>
1405
1406         Refactor clz/ctz and fix getLSBSet.
1407         https://bugs.webkit.org/show_bug.cgi?id=196162
1408
1409         Reviewed by Saam Barati.
1410
1411         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1412
1413         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1414         (TestWebKitAPI::TEST):
1415
1416 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1417
1418         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1419         https://bugs.webkit.org/show_bug.cgi?id=196143
1420
1421         Reviewed by Michael Catanzaro.
1422
1423         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1424         directories.
1425
1426         * Scripts/webkitpy/style/checkers/cpp.py:
1427         (check_identifier_name_in_declaration):
1428         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1429         (WebKitStyleTest.test_names):
1430
1431 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1432
1433         [Flatpak] Manifest expanding fails for qt WPE extension
1434         https://bugs.webkit.org/show_bug.cgi?id=196148
1435
1436         Reviewed by Alex Christensen.
1437
1438         * flatpak/flatpakutils.py:
1439         (expand_submodules_recurse): The last recurse manifest expand
1440         iteration might lead to a single module so take it into account
1441         and don't try to recurse further.
1442
1443 2019-03-22  Chris Dumez  <cdumez@apple.com>
1444
1445         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1446         https://bugs.webkit.org/show_bug.cgi?id=195348
1447         <rdar://problem/48622090>
1448
1449         Reviewed by Alex Christensen.
1450
1451         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1452         to NO when test.options().shouldIgnoreMetaViewport is false.
1453
1454         * WebKitTestRunner/ios/TestControllerIOS.mm:
1455         (WTR::TestController::platformConfigureViewForTest):
1456
1457 2019-03-22  Chris Dumez  <cdumez@apple.com>
1458
1459         Prewarmed processes should be usable with any website data store
1460         https://bugs.webkit.org/show_bug.cgi?id=196104
1461
1462         Reviewed by Alex Christensen.
1463
1464         Add API test coverage.
1465
1466         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1467         (runInitialWarmedProcessUsedTest):
1468         (TEST):
1469
1470 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1471
1472         Back out local changes to Alex's Subversion working directory
1473
1474         They were accidentally committed.
1475
1476         * Scripts/webkitpy/common/system/abstractexecutive.py:
1477         (AbstractExecutive.wait_newest):
1478         * Scripts/webkitpy/common/system/executive.py:
1479         (Executive.running_pids):
1480         * Scripts/webkitpy/common/system/executive_mock.py:
1481         (MockExecutive.running_pids):
1482         * Scripts/webkitpy/common/system/executive_unittest.py:
1483         (ExecutiveTest.serial_test_running_pids):
1484         * Scripts/webkitpy/port/darwin.py:
1485         (DarwinPort.check_for_leaks):
1486         * Scripts/webkitpy/port/leakdetector.py:
1487         (LeakDetector.check_for_leaks):
1488         - This was the hack attached to Bug 193772.
1489
1490         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1491         (+[WebKitTestRunnerEvent mouseLocation]):
1492         - This works around a crash on an internal build.
1493
1494 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1495
1496         Fix the build after r243354
1497         https://bugs.webkit.org/show_bug.cgi?id=196138
1498         <rdar://problem/49145951>
1499
1500         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1501         (TEST):
1502         * TestWebKitAPI/ios/UIKitSPI.h:
1503
1504 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1505
1506         Adopt UIWKDocumentContext
1507         https://bugs.webkit.org/show_bug.cgi?id=196040
1508         <rdar://problem/48642440>
1509
1510         Reviewed by Ryosuke Niwa.
1511
1512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1513         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1514         (makeRequest):
1515         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1516         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1517         (applyStyle):
1518         (TEST):
1519         Add tests for UIWKDocumentContext.
1520
1521         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1522         (TEST):
1523         (recursiveFindWKContentView): Deleted.
1524         * TestWebKitAPI/cocoa/TestWKWebView.h:
1525         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1526         (recursiveFindWKContentView):
1527         (-[TestWKWebView wkContentView]):
1528         * TestWebKitAPI/ios/UIKitSPI.h:
1529         Share the WKContentView finding code between tests.
1530
1531 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1532
1533         [iOS WK2] Turn on async overflow scrolling by default
1534         https://bugs.webkit.org/show_bug.cgi?id=196011
1535         rdar://problem/48453859
1536
1537         Reviewed by Antti Koivisto.
1538         
1539         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1540         since so many basic layout tests have different results when compositing is triggered for
1541         overflow.
1542         
1543         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1544
1545         * WebKitTestRunner/TestController.cpp:
1546         (WTR::TestController::resetPreferencesToConsistentValues):
1547
1548 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1549
1550         [ews-build] Retry API test in case of failures
1551         https://bugs.webkit.org/show_bug.cgi?id=196004
1552
1553         Reviewed by Lucas Forschler.
1554
1555         * BuildSlaveSupport/ews-build/steps.py:
1556         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1557         (CompileWebKitToT.doStepIf): Ditto.
1558         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1559         (ReRunAPITests): Re-run API tests.
1560         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1561         (RunAPITestsWithoutPatch): Run API tests without patch.
1562         (RunAPITestsWithoutPatch.doStepIf):
1563         (RunAPITestsWithoutPatch.hideStepIf):
1564         (RunAPITestsWithoutPatch.evaluateCommand):
1565         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1566         (AnalyzeAPITestsResults.start):
1567         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1568         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1569         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1570         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1571
1572 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1573
1574         [ews-build] Update queues configurations
1575         https://bugs.webkit.org/show_bug.cgi?id=196074
1576
1577         Reviewed by Dewei Zhu.
1578
1579         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1580         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1581
1582 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1583
1584         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1585         https://bugs.webkit.org/show_bug.cgi?id=195680
1586         <rdar://problem/48903534>
1587
1588         Unreviewed infrastructure fix.
1589
1590         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1591         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1592
1593 2019-03-21  Andy Estes  <aestes@apple.com>
1594
1595         [iOS] Apple Pay should be available in documents with no user agent scripts
1596         https://bugs.webkit.org/show_bug.cgi?id=196061
1597         <rdar://problem/48649391>
1598
1599         Reviewed by Brady Eidson.
1600
1601         Added API tests and related infrastructure.
1602
1603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1604         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1605         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1606         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1607         (TestWebKitAPI::TEST):
1608         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1609         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1610         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1611         * TestWebKitAPI/cocoa/TestProtocol.mm:
1612         (-[TestProtocol startLoading]):
1613         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1614         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1615         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1616         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1617
1618 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1619
1620         REGRESSSION (r243297): webkitpy tests broken
1621         https://bugs.webkit.org/show_bug.cgi?id=196108
1622
1623         Reviewed by Aakash Jain.
1624
1625         r243297 updated contributors.json, which broke a few unit tests.
1626
1627         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1628         (IRCCommandTest.test_whois):
1629         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1630
1631 2019-03-21  Chris Dumez  <cdumez@apple.com>
1632
1633         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1634         https://bugs.webkit.org/show_bug.cgi?id=196041
1635         <rdar://problem/49083230>
1636
1637         Reviewed by Alex Christensen.
1638
1639         Add API test coverage.
1640
1641         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1642         (TEST):
1643
1644 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1645
1646         Add SPI to inform applications of WKContentRuleList actions
1647         https://bugs.webkit.org/show_bug.cgi?id=195965
1648         <rdar://problem/42664365>
1649
1650         Reviewed by Geoff Garen.
1651
1652         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1653         (TestWebKitAPI::allActionsForResourceLoad):
1654         (TestWebKitAPI::testRequest):
1655         (TestWebKitAPI::TEST_F):
1656         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1657         (Notification::description):
1658         (Notification::operator== const):
1659         (toVector):
1660         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1661         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1662         (makeContentRuleList):
1663         (TEST):
1664         (makeWarnContentRuleList): Deleted.
1665
1666 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1667
1668         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1669         https://bugs.webkit.org/show_bug.cgi?id=196088
1670
1671         Reviewed by Brian Burg.
1672
1673         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1674         Support checks when only one platform is specified. Also deprecate macosx() and
1675         force the use of macos() instead.
1676
1677         * Scripts/webkitpy/style/checkers/cpp.py:
1678         (check_min_versions_of_wk_api_available):
1679         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1680         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1681
1682 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1683
1684         Update status inactive committers' status to 'contributor'.
1685
1686         * Scripts/webkitpy/common/config/contributors.json:
1687
1688 2019-03-21  Xan Lopez  <xan@igalia.com>
1689
1690         [JSC][x86] Drop support for x87 floating point
1691         https://bugs.webkit.org/show_bug.cgi?id=194853
1692
1693         Reviewed by Don Olmstead.
1694
1695         Force SSE2 on x86/32bit builds.
1696
1697         * Scripts/webkitdirs.pm:
1698         (generateBuildSystemFromCMakeProject):
1699
1700 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1701
1702         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1703         https://bugs.webkit.org/show_bug.cgi?id=196073
1704
1705         Reviewed by Michael Catanzaro.
1706
1707         Add test cases to check functions and constructors with no arguments but receiving user data.
1708
1709         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1710         (checkUserData):
1711         (testJSCFunction):
1712         (fooCreateWithUserData):
1713         (testJSCClass):
1714
1715 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1716
1717         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1718
1719         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1720
1721         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1722
1723 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1724
1725         [GTK][WPE] Add API to provide geolocation information
1726         https://bugs.webkit.org/show_bug.cgi?id=195940
1727
1728         Reviewed by Michael Catanzaro.
1729
1730         Add a new test to check the new API.
1731
1732         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1733         (testGeolocationManagerCurrentPosition):
1734         (testGeolocationManagerWatchPosition):
1735         (beforeAll):
1736         (afterAll):
1737         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1738         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1739         (beforeAll): Ditto.
1740         * TestWebKitAPI/glib/CMakeLists.txt:
1741
1742 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1743
1744         [GLib] Returning G_TYPE_OBJECT from a method does not work
1745         https://bugs.webkit.org/show_bug.cgi?id=195574
1746
1747         Reviewed by Michael Catanzaro.
1748
1749         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1750
1751         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1752         (getGFile):
1753         (getParent):
1754         (createGString):
1755         (getGString):
1756         (getGStringCopyWillRaise):
1757         (getGStringCopy):
1758         (getGStringStr):
1759         (getGStringLen):
1760         (freeGString):
1761         (testJSCClass):
1762
1763 2019-03-20  Saam Barati  <sbarati@apple.com>
1764
1765         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1766         https://bugs.webkit.org/show_bug.cgi?id=195721
1767
1768         Reviewed by Filip Pizlo.
1769
1770         * Scripts/run-javascriptcore-tests:
1771
1772 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1773
1774         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1775         https://bugs.webkit.org/show_bug.cgi?id=196049
1776
1777         Reviewed by Tim Horton.
1778
1779         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1780         overflow scrolling in general, so rename it.
1781
1782         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1783
1784 2019-03-20  Daniel Bates  <dabates@apple.com>
1785
1786         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1787         https://bugs.webkit.org/show_bug.cgi?id=196031
1788         <rdar://problem/49078172>
1789
1790         Reviewed by Tim Horton.
1791
1792         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1793         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1794         same code path used when the Done button is pressed to dismiss the <select> picker.
1795
1796         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1797         (TestWebKitAPI::TEST):
1798
1799 2019-03-20  Chris Dumez  <cdumez@apple.com>
1800
1801         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1802         https://bugs.webkit.org/show_bug.cgi?id=196029
1803         <rdar://problem/48954651>
1804
1805         Reviewed by Tim Horton.
1806
1807         Add API test coverage.
1808
1809         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1810
1811 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1812
1813         [ews-build] Improve failure summary string for ApplyPatch step
1814         https://bugs.webkit.org/show_bug.cgi?id=195995
1815
1816         Reviewed by Alexey Proskuryakov.
1817
1818         * BuildSlaveSupport/ews-build/steps.py:
1819         (ApplyPatch.getResultSummary): Override getResultSummary.
1820
1821 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1822
1823         AX: Implement support for new meter ARIA role
1824         https://bugs.webkit.org/show_bug.cgi?id=195966
1825
1826         Reviewed by Chris Fleizach.
1827
1828         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1829         to AXLevelIndicator.
1830
1831         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1832
1833 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1834
1835         [WebAuthN] Implement FIDO AppID extension
1836         https://bugs.webkit.org/show_bug.cgi?id=143491
1837         <rdar://problem/48298273>
1838
1839         Reviewed by Brent Fulgham.
1840
1841         Add a test that covers the new flag of convertToU2fSignCommand.
1842
1843         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1844         (TestWebKitAPI::TEST):
1845         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1846         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1847         (TestWebKitAPI::TEST):
1848
1849 2019-03-19  Keith Rollin  <krollin@apple.com>
1850
1851         Add support for more platforms to generate-xcfilelists
1852         https://bugs.webkit.org/show_bug.cgi?id=195977
1853
1854         Reviewed by Alexey Proskuryakov.
1855
1856         generate-xcfilelists incorrectly complains when involved with building
1857         WebKit for iphonesimulator:
1858
1859             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1860             …
1861             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1862
1863         Address this by teaching generate-xcfilelists about more platforms.
1864
1865         * Scripts/generate-xcfilelists:
1866
1867 2019-03-19  John Wilander  <wilander@apple.com>
1868
1869         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1870         https://bugs.webkit.org/show_bug.cgi?id=195923
1871         <rdar://problem/49001272>
1872
1873         Reviewed by Alex Christensen.
1874
1875         This patch does the following to the TestRunner:
1876         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1877         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1878         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1879
1880         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1881         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1882         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1883         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1884         * WebKitTestRunner/TestController.cpp:
1885         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1886         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1887         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1888         * WebKitTestRunner/TestController.h:
1889         * WebKitTestRunner/TestInvocation.cpp:
1890         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1891
1892 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1893
1894         [CMake] Support more clang and gcc sanitizers
1895         https://bugs.webkit.org/show_bug.cgi?id=195956
1896
1897         Reviewed by Michael Catanzaro.
1898
1899         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1900
1901 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1902
1903         [ews-build] Improve summary for PrintConfiguration step
1904         https://bugs.webkit.org/show_bug.cgi?id=195945
1905
1906         Reviewed by Lucas Forschler.
1907
1908         * BuildSlaveSupport/ews-build/steps.py:
1909         (PrintConfiguration.getResultSummary): Override getResultSummary.
1910
1911 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1912
1913         [ews-build] Improve summary for CheckOutSource step
1914         https://bugs.webkit.org/show_bug.cgi?id=195963
1915
1916         Reviewed by Lucas Forschler.
1917
1918         * BuildSlaveSupport/ews-build/steps.py:
1919         (CheckOutSource.getResultSummary):
1920
1921 2019-03-19  Daniel Bates  <dabates@apple.com>
1922
1923         [iOS] Focus not preserved when switching between tabs
1924         https://bugs.webkit.org/show_bug.cgi?id=195820
1925         <rdar://problem/43614450>
1926
1927         Reviewed by Brent Fulgham.
1928
1929         Add tests to ensure that we restore focus when resigning and becoming first responder.
1930
1931         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1932         (TestWebKitAPI::TEST):
1933
1934 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1935
1936         Make WTFLogChannelState and WTFLogLevel enum classes
1937         https://bugs.webkit.org/show_bug.cgi?id=195904
1938
1939         Reviewed by Eric Carlson.
1940
1941         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1942         (TestWebKitAPI::TEST_F):
1943
1944 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1945
1946         [GStreamer][EME] Backported mssdemux protection data crash fix
1947         https://bugs.webkit.org/show_bug.cgi?id=195918
1948
1949         Reviewed by Philippe Normand.
1950
1951         * gstreamer/jhbuild.modules:
1952         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1953
1954 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1955
1956         Unreviewed, rolling out r243132.
1957
1958         Broke GTK build
1959
1960         Reverted changeset:
1961
1962         "Make WTFLogChannelState and WTFLogLevel enum classes"
1963         https://bugs.webkit.org/show_bug.cgi?id=195904
1964         https://trac.webkit.org/changeset/243132
1965
1966 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1967
1968         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1969
1970         * Scripts/webkitdirs.pm:
1971         (builtDylibPathForName): Adjust the shared library name that's changed
1972         with the API version bump in r243073.
1973
1974 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1975
1976         Make WTFLogChannelState and WTFLogLevel enum classes
1977         https://bugs.webkit.org/show_bug.cgi?id=195904
1978
1979         Reviewed by Eric Carlson.
1980
1981         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1982         (TestWebKitAPI::TEST_F):
1983
1984 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1985
1986         Disable flaky test added in r2431100
1987         https://webkit.org/b/195785
1988
1989         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1990         (TestWebKitAPI::TEST):
1991         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1992
1993 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1994
1995         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1996         https://bugs.webkit.org/show_bug.cgi?id=195916
1997
1998         Reviewed by Tim Horton.
1999
2000         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2001         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2002
2003 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2004
2005         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2006
2007         * Scripts/webkitpy/common/config/contributors.json:
2008
2009 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2010
2011         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2012         https://bugs.webkit.org/show_bug.cgi?id=195785
2013
2014         Reviewed by Geoffrey Garen.
2015
2016         * TestWebKitAPI/TCPServer.cpp: Added.
2017         (TestWebKitAPI::TCPServer::TCPServer):
2018         (TestWebKitAPI::TCPServer::~TCPServer):
2019         (TestWebKitAPI::TCPServer::socketBindListen):
2020         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2021         * TestWebKitAPI/TCPServer.h: Added.
2022         (TestWebKitAPI::TCPServer::port const):
2023         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2024         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2025         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2026         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2027         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2028         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2029         (TestWebKitAPI::respondSlowly):
2030         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2031         (TestWebKitAPI::downloadAtRate):
2032         (TestWebKitAPI::TEST):
2033
2034 2019-03-18  Saam Barati  <sbarati@apple.com>
2035
2036         Add a plan file for JetStream 2
2037         https://bugs.webkit.org/show_bug.cgi?id=190734
2038
2039         Reviewed by Mark Lam.
2040
2041         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2042
2043 2019-03-18  Chris Dumez  <cdumez@apple.com>
2044
2045         Delay WebProcess launch until a load is triggered in a Web view
2046         https://bugs.webkit.org/show_bug.cgi?id=195758
2047         <rdar://problem/48126013>
2048
2049         Reviewed by Geoff Garen.
2050
2051         Add API test coverage. Also update some existing API tests to not expect
2052         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2053
2054         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2055         (TestWebKitAPI::TEST):
2056         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2057         (TestWebKitAPI::TEST):
2058         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2059         (TEST):
2060         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2061         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2062         (TEST):
2063         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2064         (TEST):
2065         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2066
2067 2019-03-18  Xan Lopez  <xan@igalia.com>
2068
2069         [CMake] Prevent potential warning when determining $architecture
2070         https://bugs.webkit.org/show_bug.cgi?id=195891
2071
2072         Reviewed by Michael Catanzaro.
2073
2074         It's possible for generateBuildSystemForCMakeProject to be called
2075         before determineArchitecture() is ever called. This will make the
2076         first eq check with $architecture to be bogus (and print a
2077         warning). Change that to an eq check with architecture(), which
2078         implicitly calls determineArchitecture() if needed, and change all
2079         the other similar cases in the method in the same way to prevent
2080         future bugs like this one.
2081
2082         * Scripts/webkitdirs.pm:
2083         (generateBuildSystemFromCMakeProject):
2084
2085 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2086
2087         [WPE] Tarballs generated with “make dist” cannot build documentation
2088         https://bugs.webkit.org/show_bug.cgi?id=195885
2089
2090         Reviewed by Carlos Garcia Campos.
2091
2092         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2093
2094 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2095
2096         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2097         https://bugs.webkit.org/show_bug.cgi?id=195883
2098
2099         Reviewed by Carlos Garcia Campos.
2100
2101         * gtkdoc/gtkdoc.py:
2102         (GTKDoc._run_command): When commands fail to run, include the full command line for
2103         the program invocation and the output it has generated on the standard error stream.
2104
2105 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2106
2107         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2108         https://bugs.webkit.org/show_bug.cgi?id=195786
2109
2110         Reviewed by Philippe Normand.
2111
2112         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2113         * wpe/jhbuild.modules: Ditto.
2114
2115 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2116
2117         [ews-build] Don't run clean builds on EWS builders
2118         https://bugs.webkit.org/show_bug.cgi?id=195851
2119
2120         Reviewed by Geoffrey Garen.
2121
2122         * BuildSlaveSupport/ews-build/factories.py:
2123
2124 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2125
2126         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2127         https://bugs.webkit.org/show_bug.cgi?id=195849
2128
2129         Reviewed by Chris Dumez.
2130
2131         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2132
2133         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2134         (runWebsiteDataStoreCustomPaths):
2135
2136 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2137
2138         webkitpy: Upload test results
2139         https://bugs.webkit.org/show_bug.cgi?id=195755
2140         <rdar://problem/48896182>
2141
2142         Reviewed by Aakash Jain.
2143
2144         Establish a new format for uploading results that is not tied to layout tests, apply
2145         that format to webkitpy tests.
2146
2147         * Scripts/webkitpy/common/checkout/scm/git.py:
2148         (Git.native_branch): Return what branch the current checkout is on.
2149         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2150         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2151         * Scripts/webkitpy/common/checkout/scm/svn.py:
2152         (SVN.native_branch): Ditto.
2153         * Scripts/webkitpy/common/system/platforminfo.py:
2154         (PlatformInfo.build_version): Return a build version for Mac.
2155         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2156         (MockPlatformInfo.__init__):
2157         (MockPlatformInfo.build_version):
2158         * Scripts/webkitpy/results: Added.
2159         * Scripts/webkitpy/results/__init__.py: Added.
2160         * Scripts/webkitpy/results/options.py: Added.
2161         (upload_options): OptParse list for upload options.
2162         * Scripts/webkitpy/results/upload.py: Added.
2163         (Upload): Class which enforces the upload format expected by the results server.
2164         (Upload.Expectations):
2165         (Upload.create_configuration):
2166         (Upload.create_commit):
2167         (Upload.create_details):
2168         (Upload.create_run_stats):
2169         (Upload.create_test_result):
2170         (Upload.__init__):
2171         (Upload.Encoder): Encode Upload object as json.
2172         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2173         * Scripts/webkitpy/results/upload_unittest.py: Added.
2174         * Scripts/webkitpy/test/main.py:
2175         (Tester._parse_args): Add upload arguments.
2176         (Tester._run_tests): Allow results to be uploaded.
2177         * Scripts/webkitpy/test/runner.py:
2178         (Runner.__init__): Record which tests were run, rather than just counting them.
2179         (Runner.handle):
2180         * Scripts/webkitpy/test/runner_unittest.py:
2181         (RunnerTest.test_run):
2182         * Scripts/webkitpy/thirdparty/__init__.py:
2183         (AutoinstallImportHook.find_module): Add requests auto-install.
2184         (AutoinstallImportHook._install_requests):
2185         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2186         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2187
2188 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2189
2190         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2191         https://bugs.webkit.org/show_bug.cgi?id=195810
2192
2193         Reviewed by Tim Horton.
2194
2195         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2196         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2197         ending certain layout tests.
2198
2199         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2200         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2201         (-[TestRunnerWKWebView dealloc]):
2202         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2203
2204         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2205         helper method when destroying the web view, and when resetting state between tests.
2206
2207         * WebKitTestRunner/ios/TestControllerIOS.mm:
2208         (WTR::TestController::platformResetStateToConsistentValues):
2209
2210         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2211
2212 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2213
2214         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2215         https://bugs.webkit.org/show_bug.cgi?id=190350
2216         <rdar://problem/45089503>
2217
2218         Reviewed by Geoffrey Garen.
2219
2220         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2221         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2222         (TEST):
2223         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2224         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2225         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2226         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2227         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2228         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2229         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2230         (runTest):
2231         (createDirectories):
2232         (TEST):
2233         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2234         (TEST):
2235         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2236         (TEST):
2237
2238 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2239
2240         Add support to WebPage for getting the contents as an attributed string.
2241         https://bugs.webkit.org/show_bug.cgi?id=195636
2242         rdar://problem/45055697
2243
2244         Reviewed by Tim Horton.
2245
2246         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2247         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2248
2249 2019-03-15  Chris Dumez  <cdumez@apple.com>
2250
2251         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2252         https://bugs.webkit.org/show_bug.cgi?id=195747
2253
2254         Reviewed by Geoff Garen.
2255
2256         Add API test coverage.
2257
2258         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2259
2260 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2261
2262         Unreviewed, rolling out r242952.
2263
2264         Causing API failures on iOS Simulator
2265
2266         Reverted changeset:
2267
2268         "[PSON] Make sure the WebProcessCache is leverage when
2269         relaunching a process after termination"
2270         https://bugs.webkit.org/show_bug.cgi?id=195747
2271         https://trac.webkit.org/changeset/242952
2272
2273 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2274
2275         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2276         https://bugs.webkit.org/show_bug.cgi?id=195740
2277
2278         Reviewed by Ross Kirsling.
2279
2280         window.open doesn't work for WebKitBrowserWindow because it is not
2281         implemented yet.
2282
2283         1. Implemented createNewPage callback of WKPageUIClient.
2284         2. Changed MainWindow to take a BrowserWindow factory function
2285           instead of BrowserWindowType to be flexible to create
2286           BrowserWindow with extra settings.
2287         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2288           because it is not relevant with MainWindow anymore.
2289
2290         * MiniBrowser/win/Common.cpp:
2291         (parseCommandLine):
2292         * MiniBrowser/win/Common.h:
2293         (CommandLineOptions::CommandLineOptions):
2294         * MiniBrowser/win/MainWindow.cpp:
2295         (MainWindow::MainWindow):
2296         (MainWindow::create):
2297         (MainWindow::init):
2298         (MainWindow::WndProc):
2299         * MiniBrowser/win/MainWindow.h:
2300         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2301         (PrintWebUIDelegate::createWebViewWithRequest):
2302         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2303         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2304         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2305         (WebKitBrowserWindow::updateProxySettings):
2306         (WebKitBrowserWindow::createNewPage):
2307         * MiniBrowser/win/WebKitBrowserWindow.h:
2308         * MiniBrowser/win/WinMain.cpp:
2309         (wWinMain):
2310
2311 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2312
2313         Make it possible to test scrolling tree layer manipulation more easily
2314         https://bugs.webkit.org/show_bug.cgi?id=195780
2315
2316         Reviewed by Tim Horton.
2317         
2318         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2319         cuts off communication of scrolling tree scrolls back to the web process
2320         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2321         allows tests to trigger scrolls which run the scrolling tree layer positioning
2322         logic, but never get another commit from the web process that might mask
2323         scrolling tree bugs.
2324         
2325         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2326         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2327         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2328
2329         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2330         (WTR::UIScriptController::scrollUpdatesDisabled const):
2331         (WTR::UIScriptController::setScrollUpdatesDisabled):
2332         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2333         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2334         (WTR::UIScriptController::scrollUpdatesDisabled const):
2335         (WTR::UIScriptController::setScrollUpdatesDisabled):
2336         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2337         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2338         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2339         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2340         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2341         * WebKitTestRunner/ios/TestControllerIOS.mm:
2342         (WTR::TestController::platformResetStateToConsistentValues):
2343         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2344         (WTR::UIScriptController::scrollUpdatesDisabled const):
2345         (WTR::UIScriptController::setScrollUpdatesDisabled):
2346
2347 2019-03-14  Youenn Fablet  <youenn@apple.com>
2348
2349         Move IDB storage in private browsing mode to NetworkProcess
2350         https://bugs.webkit.org/show_bug.cgi?id=195602
2351
2352         Reviewed by Brady Eidson.
2353
2354         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2355         (TEST):
2356
2357 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2358
2359         [ews-build] Make descriptionDone messages more readable
2360         https://bugs.webkit.org/show_bug.cgi?id=195760
2361
2362         Reviewed by Lucas Forschler.
2363
2364         * BuildSlaveSupport/ews-build/steps.py:
2365         * BuildSlaveSupport/ews-build/steps_unittest.py:
2366
2367 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2368
2369         [ews-build] Generate status-bubble hover-over messages
2370         https://bugs.webkit.org/show_bug.cgi?id=195680
2371
2372         Reviewed by Lucas Forschler.
2373
2374         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2375         (StatusBubble):
2376         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2377         on hover-over.
2378         (StatusBubble._iso_time):
2379         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2380         hover-over message.
2381         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2382
2383 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2384
2385         [ews-app] Gracefully handle the case when state_string is None
2386         https://bugs.webkit.org/show_bug.cgi?id=195753
2387
2388         Reviewed by Lucas Forschler.
2389
2390         * BuildSlaveSupport/ews-app/ews/models/build.py:
2391         * BuildSlaveSupport/ews-app/ews/models/step.py:
2392
2393 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2394
2395         [ews-app] Status bubble display pending for currently running build step
2396         https://bugs.webkit.org/show_bug.cgi?id=195744
2397
2398         Reviewed by Lucas Forschler.
2399
2400         * BuildSlaveSupport/ews-build/events.py:
2401         (Events.stepStarted): If state_string is pending, replace it with step name.
2402
2403 2019-03-14  Chris Dumez  <cdumez@apple.com>
2404
2405         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2406         https://bugs.webkit.org/show_bug.cgi?id=195750
2407
2408         Reviewed by Geoffrey Garen.
2409
2410         Add API test coverage.
2411
2412         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2413         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2414         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2415         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2416
2417 2019-03-14  Chris Dumez  <cdumez@apple.com>
2418
2419         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2420         https://bugs.webkit.org/show_bug.cgi?id=195747
2421
2422         Reviewed by Geoff Garen.
2423
2424         Add API test coverage.
2425
2426         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2427
2428 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2429
2430         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2431         https://bugs.webkit.org/show_bug.cgi?id=195725
2432         <rdar://problem/48545062>
2433
2434         Reviewed by Tim Horton.
2435
2436         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2437         handler is nil.
2438
2439         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2440         (TestWebKitAPI::TEST):
2441
2442 2019-03-13  Sam Weinig  <sam@webkit.org>
2443
2444         Add utility function to allow easy reverse range-based iteration of a container
2445         https://bugs.webkit.org/show_bug.cgi?id=195542
2446
2447         Reviewed by Antti Koivisto.
2448
2449         * TestWebKitAPI/CMakeLists.txt:
2450         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2451         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2452         (TestWebKitAPI::TEST):
2453         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2454
2455 2019-03-13  Chris Dumez  <cdumez@apple.com>
2456
2457         Use a ServiceWorker process per registrable domain
2458         https://bugs.webkit.org/show_bug.cgi?id=195649
2459
2460         Reviewed by Youenn Fablet.
2461
2462         Update API test coverage.
2463
2464         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2465
2466 2019-03-13  Chris Dumez  <cdumez@apple.com>
2467
2468         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2469         https://bugs.webkit.org/show_bug.cgi?id=195684
2470         <rdar://problem/48294714>
2471
2472         Reviewed by Antti Koivisto.
2473
2474         Add API test coverage.
2475
2476         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2477
2478 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2479
2480         [ews-app] Remove unused patch view
2481         https://bugs.webkit.org/show_bug.cgi?id=195669
2482
2483         Reviewed by Lucas Forschler.
2484
2485         * BuildSlaveSupport/ews-app/ews/urls.py:
2486         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2487
2488 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2489
2490         [ews-app] Use Buildbot result code variables
2491         https://bugs.webkit.org/show_bug.cgi?id=195668
2492
2493         Reviewed by Alexey Proskuryakov.
2494
2495         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2496         (Buildbot): Added Buildbot result code variables.
2497         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2498         (StatusBubble._build_bubble): Used Buildbot result code variables.
2499
2500 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2501
2502         [Flatpak] Expand submodule recursively
2503         https://bugs.webkit.org/show_bug.cgi?id=195672
2504
2505         Building WPE with flatpak was impossible without that as it was raising an exception.
2506         Also update wpebackend-fdo to match what is built in jhbuild
2507
2508         Reviewed by Philippe Normand.
2509
2510         * flatpak/flatpakutils.py:
2511         (expand_submodules_recurse):
2512         (expand_manifest):
2513         * flatpak/org.webkit.WPEModules.yaml:
2514
2515 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2516
2517         [ews-app] status bubble should be hidden for certain builds
2518         https://bugs.webkit.org/show_bug.cgi?id=194597
2519
2520         Reviewed by Dewei Zhu.
2521
2522         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2523         (StatusBubble._build_bubble):
2524         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2525         because the patch didn't have relevant changes.
2526         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2527         in production yet.
2528
2529 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2530
2531         [Win] Fix a slew of simple clang-cl warnings.
2532         https://bugs.webkit.org/show_bug.cgi?id=195652
2533
2534         Reviewed by Don Olmstead.
2535
2536         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2537         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2538
2539 2019-03-12  Justin Fan  <justin_fan@apple.com>
2540
2541         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2542         https://bugs.webkit.org/show_bug.cgi?id=195518
2543         <rdar://problem/46322356>
2544
2545         Reviewed by Myles C. Maxfield.
2546
2547         * DumpRenderTree/DerivedSources-input.xcfilelist:
2548         * DumpRenderTree/DerivedSources-output.xcfilelist:
2549
2550 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2551
2552         Unreviewed, rolling out r242825.
2553         https://bugs.webkit.org/show_bug.cgi?id=195648
2554
2555         "Broke webkitpy tests with my change to
2556         lldb_dump_class_layout.py" (Requested by rmorisset on
2557         #webkit).
2558
2559         Reverted changeset:
2560
2561         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2562         classes with suspicious padding"
2563         https://bugs.webkit.org/show_bug.cgi?id=195573
2564         https://trac.webkit.org/changeset/242825
2565
2566 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2567
2568         [ews-build] Show status bubbles while the patch is waiting in queue
2569         https://bugs.webkit.org/show_bug.cgi?id=195618
2570
2571         Reviewed by Lucas Forschler.
2572
2573         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2574         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2575         enabled in initial deployment.
2576         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2577         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2578         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2579         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2580         (StatusBubble._build_bubbles_for_patch):
2581
2582 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2583
2584         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2585         https://bugs.webkit.org/show_bug.cgi?id=195573
2586
2587         Reviewed by Simon Fraser.
2588
2589         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2590
2591         * Scripts/dump-class-layout:
2592         (main):
2593         * lldb/lldb_dump_class_layout.py:
2594         (ClassLayout.__init__):
2595         (ClassLayout._compute_padding_recursive):
2596         (LLDBDebuggerInstance.dump_layout_for_classname):
2597         (LLDBDebuggerInstance):
2598         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2599         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2600
2601 2019-03-12  Chris Dumez  <cdumez@apple.com>
2602
2603         Device Orientation access permission should be denied unless explicitly granted by the client
2604         https://bugs.webkit.org/show_bug.cgi?id=195625
2605
2606         Reviewed by Youenn Fablet.
2607
2608         add API test coverage.
2609
2610         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2611         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2612         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2613         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2614         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2615         (runDeviceOrientationTest):
2616         (TEST):
2617         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2618         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2619
2620 2019-03-12  Jer Noble  <jer.noble@apple.com>
2621
2622         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2623         https://bugs.webkit.org/show_bug.cgi?id=195137
2624         <rdar://problem/48810307>
2625
2626         Reviewed by Eric Carlson.
2627
2628         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2629         (TestWebKitAPI::TEST):
2630
2631 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2632
2633         [ews-build] Change urls from uat to production
2634         https://bugs.webkit.org/show_bug.cgi?id=195566
2635
2636         Reviewed by Lucas Forschler.
2637
2638         * BuildSlaveSupport/ews-app/ews/config.py:
2639         * BuildSlaveSupport/ews-build/events.py:
2640         * BuildSlaveSupport/ews-build/steps.py:
2641
2642 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2643
2644         [ews-build] change max_builds for local-worker to 1
2645         https://bugs.webkit.org/show_bug.cgi?id=195568
2646
2647         Reviewed by Lucas Forschler.
2648
2649         * BuildSlaveSupport/ews-build/loadConfig.py:
2650
2651 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2652
2653         Fix the build
2654
2655         * TestRunnerShared/spi/PencilKitTestSPI.h:
2656         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2657
2658 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2659
2660         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2661         https://bugs.webkit.org/show_bug.cgi?id=194131
2662
2663         Reviewed by Michael Catanzaro.
2664
2665         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2666         (uriChanged):
2667         (testUnfinishedSubresourceLoad):
2668         (serverCallback):
2669         (beforeAll):
2670
2671 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2672
2673         WTF::Expected should use std::addressof instead of operator&
2674         https://bugs.webkit.org/show_bug.cgi?id=195604
2675
2676         Reviewed by Myles Maxfield.
2677
2678         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2679         (TestWebKitAPI::Unique::Unique):
2680         (TestWebKitAPI::Unique::operator&):
2681         (TestWebKitAPI::TEST):
2682
2683 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2684
2685         Add Optional to Forward.h.
2686         https://bugs.webkit.org/show_bug.cgi?id=195586
2687
2688         Reviewed by Darin Adler.
2689
2690         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2691         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2692         Remove unnecessary includes from headers.
2693
2694 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2695
2696         Add testing API to hit-test and scroll overflow scrollers
2697         https://bugs.webkit.org/show_bug.cgi?id=195278
2698
2699         Reviewed by Antti Koivisto.
2700         
2701         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2702         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2703         
2704         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2705
2706         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2707         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2708         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2709         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2710         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2711         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2712         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2713         (WTR::enclosingScrollViewIncludingSelf):
2714         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2715
2716 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2717
2718         API test WebKit.RequestTextInputContext fails on iOS
2719         https://bugs.webkit.org/show_bug.cgi?id=195585
2720
2721         Reviewed by Wenson Hsieh and Simon Fraser.
2722
2723         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2724         (applyStyle):
2725         (TEST):
2726         Add a viewport, so that the coordinates match up on iOS.
2727         Scroll by moving the UIScrollView's contentOffset.
2728
2729 2019-03-11  Chris Dumez  <cdumez@apple.com>
2730
2731         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2732         https://bugs.webkit.org/show_bug.cgi?id=195506
2733         <rdar://problem/48733477>
2734
2735         Reviewed by Alex Christensen.
2736
2737         Add API test coverage.
2738
2739         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2740
2741 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2742
2743         Adding myself to contributors.json
2744
2745         Unreviewed, addming myself to contributors.json .
2746
2747         * Scripts/webkitpy/common/config/contributors.json:
2748
2749 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2750
2751         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2752         https://bugs.webkit.org/show_bug.cgi?id=195511
2753         <rdar://problem/44873269>
2754
2755         Reviewed by Darin Adler.
2756
2757         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2758         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2759         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2760         (TEST_F):
2761
2762 2019-03-11  Chris Dumez  <cdumez@apple.com>
2763
2764         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2765         https://bugs.webkit.org/show_bug.cgi?id=195561
2766
2767         Reviewed by Youenn Fablet.
2768
2769         Make sure the JS in the test requests for permission to receive device orientation events.
2770
2771         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2772
2773 2019-03-11  Youenn Fablet  <youenn@apple.com>
2774
2775         Allow storage quota increase by default in WTR
2776         https://bugs.webkit.org/show_bug.cgi?id=195541
2777
2778         Reviewed by Geoffrey Garen.
2779
2780         Allow storage quota increase by default in WTR.
2781         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2782         Use this for tests that explicitly need cache increase.
2783
2784         Instead of increasing quota by 2, make sure the next request is
2785         granted by adding all given parameters.
2786
2787         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2788         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2789         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2790         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2791         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2792         * WebKitTestRunner/TestController.cpp:
2793         (WTR::TestController::setAllowStorageQuotaIncrease):
2794         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2795         * WebKitTestRunner/TestController.h:
2796         * WebKitTestRunner/TestInvocation.cpp:
2797         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2798         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2799         (WTR::TestController::cocoaResetStateToConsistentValues):
2800         (WTR::TestController::setAllowStorageQuotaIncrease):
2801         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2802         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2803         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2804
2805 2019-03-11  Xan Lopez  <xan@igalia.com>
2806
2807         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2808         https://bugs.webkit.org/show_bug.cgi?id=194147
2809
2810         Reviewed by Michael Saboff.
2811
2812         To make --32-bit work correctly on Linux/64bit we need to:
2813
2814         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2815         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2816         unfortunately CMake only allows us to do this during
2817         crosscompilation, which is overkill here.
2818         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2819         pkg-config detection module uses the x86 .pc files instead of the
2820         x86_64 ones.
2821         - Set the -m32 flags for the compiler.
2822
2823         * Scripts/webkitdirs.pm:
2824         (generateBuildSystemFromCMakeProject):
2825
2826 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2827
2828         Add MotionMark-1.1 plan file for run-benchmark script.
2829         https://bugs.webkit.org/show_bug.cgi?id=195481
2830
2831         Rubber-stamped by Darin Adler.
2832
2833         Run-benchmark script should support MontionMark-1.1.
2834
2835         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2836
2837 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2838
2839         [ews-app] Add support for submit-to-ews url
2840         https://bugs.webkit.org/show_bug.cgi?id=195477
2841
2842         Reviewed by Lucas Forschler.
2843
2844         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2845         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2846         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2847         * BuildSlaveSupport/ews-app/ews/urls.py:
2848         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2849
2850 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2851
2852         Unreviewed, rolling out r242688, r242643, r242624.
2853
2854         Caused multiple layout test failures and crashes on iOS and macOS.
2855
2856         Reverted changeset:
2857
2858         "requestAnimationFrame should execute before the next frame"
2859         https://bugs.webkit.org/show_bug.cgi?id=177484
2860         https://trac.webkit.org/changeset/242624/webkit
2861
2862         * Tracing/SystemTracePoints.plist:
2863
2864 2019-03-11  John Wilander  <wilander@apple.com>
2865
2866         Resource Load Statistics: Make it possible exclude localhost from classification
2867         https://bugs.webkit.org/show_bug.cgi?id=195474
2868         <rdar://problem/47520577>
2869
2870         Reviewed by Brent Fulgham.
2871
2872         This patch allows for localhost to be excluded from classification and
2873         treatment as a prevalent resource.
2874
2875         The WebKit Tools change adds a new function called
2876         testRunner.setStatisticsIsRunningTest() which can be used to control this
2877         behavior.
2878
2879         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2880         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2881         (WTR::TestRunner::setStatisticsIsRunningTest):
2882         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2883         * WebKitTestRunner/TestController.cpp:
2884         (WTR::TestController::setStatisticsIsRunningTest):
2885         * WebKitTestRunner/TestController.h:
2886         * WebKitTestRunner/TestInvocation.cpp:
2887         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2888
2889 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2890
2891         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2892         https://bugs.webkit.org/show_bug.cgi?id=195560
2893
2894         Reviewed by Lucas Forschler.
2895
2896         * BuildSlaveSupport/ews-build/master.cfg:
2897
2898 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2899
2900         Unreviewed, rolling out r242698.
2901
2902         API test crashes on bots.
2903
2904         Reverted changeset:
2905
2906         "Add a WKContentRuleList variant that uses copied memory
2907         instead of mmap'd shared memory for class A containerized
2908         apps"
2909         https://bugs.webkit.org/show_bug.cgi?id=195511
2910         https://trac.webkit.org/changeset/242698
2911
2912 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2913
2914         [WPE] Enable web process sandbox
2915         https://bugs.webkit.org/show_bug.cgi?id=195169
2916
2917         Reviewed by Daniel Bates.
2918
2919         * wpe/install-dependencies:
2920         * wpe/jhbuild.modules:
2921
2922 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2923
2924         [ews-app] Use port 17000 for worker communication
2925         https://bugs.webkit.org/show_bug.cgi?id=195558
2926
2927         Reviewed by Lucas Forschler.
2928
2929         * BuildSlaveSupport/ews-build/master.cfg:
2930
2931 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2932
2933         [ews-build] unit-tests fail when passwords.json is missing
2934         https://bugs.webkit.org/show_bug.cgi?id=195557
2935
2936         Reviewed by Lucas Forschler.
2937
2938         * BuildSlaveSupport/ews-build/loadConfig.py:
2939         (loadBuilderConfig):
2940         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2941         (ConfigDotJSONTest.test_configuration):
2942         * BuildSlaveSupport/ews-build/master.cfg:
2943
2944 2019-03-11  Truitt Savell  <tsavell@apple.com>
2945
2946         Unreviewed, rolling out r242702.
2947
2948         Broke High Sierra builders.
2949
2950         Reverted changeset:
2951
2952         "Add utility function to allow easy reverse range-based
2953         iteration of a container"
2954         https://bugs.webkit.org/show_bug.cgi?id=195542
2955         https://trac.webkit.org/changeset/242702
2956
2957 2019-03-11  Sam Weinig  <sam@webkit.org>
2958
2959         Add utility function to allow easy reverse range-based iteration of a container
2960         https://bugs.webkit.org/show_bug.cgi?id=195542
2961
2962         Reviewed by Antti Koivisto.
2963
2964         * TestWebKitAPI/CMakeLists.txt:
2965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2966         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2967         (TestWebKitAPI::TEST):
2968         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2969
2970 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2971
2972         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2973         https://bugs.webkit.org/show_bug.cgi?id=195511
2974         <rdar://problem/44873269>
2975
2976         Reviewed by Darin Adler.
2977
2978         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2979         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2980         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2981         (TEST_F):
2982
2983 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2984
2985         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2986         https://bugs.webkit.org/show_bug.cgi?id=195499
2987
2988         Reviewed by Darin Adler.
2989
2990         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2991         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2992         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2993         (-[WKWebView synchronouslyFocusTextInputContext:]):
2994         (applyStyle):
2995         (applyIframe):
2996         (TEST):
2997         Add some tests for this SPI.
2998
2999 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3000
3001         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3002         https://bugs.webkit.org/show_bug.cgi?id=181151
3003
3004         Reviewed by Don Olmstead.
3005
3006         * TestWebKitAPI/CMakeLists.txt:
3007         * TestWebKitAPI/PlatformWin.cmake:
3008         Enable TestWTF RunLoop tests in all platforms.
3009
3010         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3011         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3012         (TestWebKitAPI::DerivedOneShotTimer::fired):
3013         (TestWebKitAPI::TEST):
3014         Only a few platforms support nested RunLoop.
3015
3016         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3017         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3018
3019 2019-03-10  David Quesada  <david_quesada@apple.com>
3020
3021         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3022         https://bugs.webkit.org/show_bug.cgi?id=152480
3023
3024         Reviewed by Chris Dumez.
3025
3026         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3027         there are no additional references to the process pool besides the one held by
3028         the download, waits for the download to finish (in the sense that the
3029         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3030         measure, also check that the process pool has been deallocated at the end of the
3031         test. The test wouldn't be meaningful if the process pool were still alive.
3032
3033         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3034         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3035         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3036             The download will be canceled because the delegate does not implement the
3037             method to decide the download's destination, so this is where we know the
3038             DownloadProxyMap is done with the DownloadProxy.
3039         (TEST):
3040
3041 2019-03-08  Chris Dumez  <cdumez@apple.com>
3042
3043         Add support for Device Orientation / Motion permission API
3044         https://bugs.webkit.org/show_bug.cgi?id=195329
3045         <rdar://problem/47645367>
3046
3047         Reviewed by Geoffrey Garen.
3048
3049         Add test infrastructure to help test the Device Orientation / Motion permission API.
3050
3051         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3052         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3053         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3054         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3055         * WebKitTestRunner/TestController.cpp:
3056         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3057         (WTR::TestController::createWebViewWithOptions):
3058         (WTR::TestController::resetStateToConsistentValues):
3059         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3060         * WebKitTestRunner/TestController.h:
3061         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3062         * WebKitTestRunner/TestInvocation.cpp:
3063         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3064
3065 2019-03-08  Saam barati  <sbarati@apple.com>
3066
3067         Add a compare-results script to compare benchmark results
3068         https://bugs.webkit.org/show_bug.cgi?id=195486
3069         <rdar://problem/48723397>
3070
3071         Reviewed by Geoffrey Garen.
3072
3073         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3074         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3075         to extend it to learn about our other benchmarks.
3076
3077         * Scripts/compare-results: Added.
3078         (readJSONFile):
3079         (detectJetStream2):
3080         (JetStream2Results):
3081         (detectSpeedometer2):
3082         (Speedometer2Results):
3083         (detectPLT5):
3084         (PLT5Results):
3085         (detectBenchmark):
3086         (biggerIsBetter):
3087         (ttest):
3088         (getOptions):
3089         (main):
3090
3091 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3092
3093         Ensure old tab state is cleared between iterations of run-benchmark
3094         https://bugs.webkit.org/show_bug.cgi?id=195393
3095         <rdar://problem/46885583>
3096
3097         Reviewed by Dewei Zhu.
3098
3099         a) ensure the default to restore state is not set
3100         b) terminate Safari correctly
3101         c) Set the system default to ignore Persistent State in Safari
3102
3103         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3104         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3105         (OSXBrowserDriver.prepare_env): 
3106         (OSXBrowserDriver.restore_env):
3107         (OSXBrowserDriver.close_browsers):
3108         (OSXBrowserDriver._terminate_processes):
3109         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3110         (OSXChromeDriver):
3111         (OSXChromeCanaryDriver):
3112         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3113         (OSXFirefoxDriver):
3114         (OSXFirefoxNightlyDriver):
3115         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3116         (OSXSafariDriver):
3117         (OSXSafariDriver.prepare_env):
3118
3119 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3120
3121         [GTK] Several InputMethodFilter tests are failing
3122         https://bugs.webkit.org/show_bug.cgi?id=195408
3123
3124         Reviewed by Carlos Garcia Campos.
3125
3126         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3127         Regressed in r241751.
3128         Hexadecimal values of keycodes are expressed now in upper letters.
3129         Composited characters should be cast to UTF8 strings.
3130
3131         (TestWebKitAPI::TEST):
3132
3133 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3134
3135         [GTK] Make Tools/gtkdoc python3 compatible
3136         https://bugs.webkit.org/show_bug.cgi?id=195359
3137
3138         Reviewed by Carlos Garcia Campos.
3139
3140         * gtkdoc/generate-gtkdoc:
3141         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3142         work with Python 2 and 3.
3143         (get_gtkdoc_module_paths):
3144         The iteritems() was removed in Python 3, so let's use items() that's
3145         available in Python 2 and 3.
3146         (get_generator_for_config):
3147         * gtkdoc/gtkdoc.py:
3148         (GTKDoc._run_command):
3149         The sys.stdout.write() is expecting str in Python 3 and not bytes
3150         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3151         for passing the bytes there.
3152
3153 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3154
3155         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3156         https://bugs.webkit.org/show_bug.cgi?id=195346
3157         <rdar://problem/48667048>
3158
3159         Unreviewed build fix for clang-cl.
3160
3161         * DumpRenderTree/win/DumpRenderTree.cpp:
3162         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3163
3164 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3165
3166         requestAnimationFrame should execute before the next frame
3167         https://bugs.webkit.org/show_bug.cgi?id=177484
3168
3169         Reviewed by Simon Fraser.
3170
3171         Add trace points for the page RenderingUpdate.
3172
3173         * Tracing/SystemTracePoints.plist:
3174
3175 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3176
3177         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3178         https://bugs.webkit.org/show_bug.cgi?id=195353
3179         <rdar://problem/48626394>
3180
3181         Reviewed by Simon Fraser.
3182
3183         * WebKitTestRunner/ios/TestControllerIOS.mm:
3184         (WTR::TestController::platformResetPreferencesToConsistentValues):
3185
3186 2019-03-07  John Wilander  <wilander@apple.com>
3187
3188         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3189         https://bugs.webkit.org/show_bug.cgi?id=195383
3190         <rdar://problem/48570136>
3191
3192         Reviewed by Brent Fulgham.
3193
3194         This patch adds test infrastructure to purge only script-accessible cookies,
3195         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3196
3197         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3198         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3199         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3200         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3201         * WebKitTestRunner/TestController.cpp:
3202         (WTR::TestController::statisticsDeleteCookiesForHost):
3203         * WebKitTestRunner/TestController.h:
3204         * WebKitTestRunner/TestInvocation.cpp:
3205         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3206
3207 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3208
3209         Unreviewed, rolling out r242354.
3210         https://bugs.webkit.org/show_bug.cgi?id=195402
3211
3212         breaks layout tests in all configurations (Requested by
3213         zdobersek on #webkit).
3214
3215         Reverted changeset:
3216
3217         "[WPE] Enable web process sandbox"
3218         https://bugs.webkit.org/show_bug.cgi?id=195169
3219         https://trac.webkit.org/changeset/242354
3220
3221 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3222
3223         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3224         https://bugs.webkit.org/show_bug.cgi?id=195346
3225
3226         Reviewed by Fujii Hironori.
3227
3228         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3229         (TestWebKitAPI::TEST):
3230         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3231
3232         * DumpRenderTree/win/DumpRenderTree.cpp:
3233         (findFontFallback):
3234         (addFontFallbackIfPresent):
3235         (removeFontFallbackIfPresent):
3236         (main):
3237         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3238         (TestWebKitAPI::Util::moduleDirectory):
3239         (TestWebKitAPI::Util::createInjectedBundlePath):
3240         Use wchar helpers as needed.
3241
3242 2019-03-06  Rob Buis  <rbuis@igalia.com>
3243
3244         Consider supporting the `referrerpolicy` attribute.
3245         https://bugs.webkit.org/show_bug.cgi?id=179053
3246
3247         Reviewed by Darin Adler.
3248
3249         Add a runtime flag for referrerpolicy attribute.
3250
3251         * DumpRenderTree/mac/DumpRenderTree.mm:
3252         (enableExperimentalFeatures):
3253
3254 2019-03-05  Daniel Bates  <dabates@apple.com>
3255
3256         Update expected API test result following r242379
3257         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3258
3259         Update expected x-coordinate of selection rect now that the left padding of
3260         a textarea is sized in ems (so dependent on the font size) just like the left
3261         padding of a text field.
3262
3263         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3264         (TestWebKitAPI::TEST):
3265
3266 2019-03-05  David Quesada  <david_quesada@apple.com>
3267
3268         [WK2] It should be possible to follow links with 'download' attributes
3269         https://bugs.webkit.org/show_bug.cgi?id=195145
3270         rdar://problem/48462642
3271
3272         Reviewed by Alex Christensen.
3273
3274         Add a unit test to verify that activating links with 'download' attributes now
3275         navigates to the linked resource, rather than starts downloading it. Add another
3276         to verify that it is still possible to explicitly download the link via the
3277         'Download' navigation action policy.
3278
3279         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3280         (-[DownloadAttributeTestDelegate init]):
3281         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3282         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3283         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3284         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3285         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3286         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3287         (TEST):
3288         * WebKitTestRunner/TestController.cpp:
3289         (WTR::TestController::decidePolicyForNavigationAction):
3290         * WebKitTestRunner/TestController.h:
3291
3292 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3293
3294         [Curl] Implement Cookie Accept Policy.
3295         https://bugs.webkit.org/show_bug.cgi?id=191645
3296
3297         Reviewed by Fujii Hironori.
3298
3299         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3300         (TestWebKitAPI::Curl::TEST_F):
3301
3302 2019-03-05  Youenn Fablet  <youenn@apple.com>
3303
3304         Rename requestCacheStorageSpace to requestStorageSpace
3305         https://bugs.webkit.org/show_bug.cgi?id=195282
3306
3307         Reviewed by Chris Dumez.
3308
3309         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3310         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3311         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3312
3313 2019-03-05  Brady Eidson  <beidson@apple.com>
3314
3315         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3316         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3317
3318         Reviewed by Tim Horton.
3319
3320         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3321         different directory into that same WKWebView should work.
3322
3323         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3324         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3325
3326 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3327
3328         Add WeakHashSet
3329         https://bugs.webkit.org/show_bug.cgi?id=195152
3330
3331         Reviewed by Antti Koivisto.
3332
3333         Added tests for WeakHashSet.
3334
3335         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3336         (TestWebKitAPI::Base::Base): Moved.
3337         (TestWebKitAPI::Derived::foo): Moved.
3338         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3339         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3340         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3341         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3342
3343 2019-03-04  Chris Dumez  <cdumez@apple.com>
3344
3345         Do not share WebProcesses between private and regular sessions
3346         https://bugs.webkit.org/show_bug.cgi?id=195189
3347         <rdar://problem/48421064>
3348
3349         Reviewed by Alex Christensen.
3350
3351         Add API test coverage.
3352
3353         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3354         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3355
3356 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3357
3358         [WPE] Enable web process sandbox
3359         https://bugs.webkit.org/show_bug.cgi?id=195169
3360
3361         Reviewed by Daniel Bates.
3362
3363         * wpe/install-dependencies:
3364         * wpe/jhbuild.modules:
3365
3366 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3367
3368         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3369         https://bugs.webkit.org/show_bug.cgi?id=195206
3370
3371         Reviewed by Žan Doberšek.
3372
3373         Add a new test case.
3374
3375         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3376         (testJSCClass):
3377
3378 2019-03-04  Charlie Turner  <cturner@igalia.com>
3379
3380         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3381         https://bugs.webkit.org/show_bug.cgi?id=194898
3382
3383         Reviewed by Žan Doberšek.
3384
3385         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3386         a GCC extension that permits arithmetic on void* pointer. Inline
3387         the macro until this issue is fixed upstream.
3388
3389 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3390
3391         Rid the world of WK_API_ENABLED
3392         https://bugs.webkit.org/show_bug.cgi?id=195263
3393
3394         Reviewed by Dan Bernstein.
3395
3396         List of changed files elided because it's useless.
3397
3398 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3399
3400         Unreviewed follow-up to r242292.
3401
3402         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3403
3404         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3405         (TestWebKitAPI::testStrip): Renamed from strip.
3406         (TestWebKitAPI::TEST):
3407
3408 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3409
3410         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3411
3412         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3413         and bug #194272 for details.
3414
3415         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3416
3417 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3418
3419         Remove some more unused 32-bit code
3420         https://bugs.webkit.org/show_bug.cgi?id=195255
3421
3422         Reviewed by Darin Adler.
3423
3424         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3425         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3426         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3427         (NPP_New):
3428         (NPP_HandleEvent):
3429         (handleEventCarbon): Deleted.
3430
3431 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3432
3433         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3434
3435         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3436         (TestWebKitAPI::TEST):
3437
3438 2019-03-01  Darin Adler  <darin@apple.com>
3439
3440         Finish removing String::format
3441         https://bugs.webkit.org/show_bug.cgi?id=194893
3442
3443         Reviewed by Daniel Bates.
3444 '
3445         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3446
3447 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3448
3449         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3450         https://bugs.webkit.org/show_bug.cgi?id=195229
3451         <rdar://problem/48520362>
3452
3453         Reviewed by Chris Dumez.
3454
3455         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3456         (TEST):
3457
3458 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3459
3460         Add a system trace scope for event region building
3461         https://bugs.webkit.org/show_bug.cgi?id=195226
3462
3463         Reviewed by Jon Lee.
3464
3465         This trace scope measures the time spend converting element rects into Region objects,
3466         which can be large on some pages.
3467
3468         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3469
3470         * Tracing/SystemTracePoints.plist:
3471
3472 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3473
3474         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3475         https://bugs.webkit.org/show_bug.cgi?id=194612
3476
3477         Reviewed by Alex Christensen.
3478
3479         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3480         Just test the new string-processing function and don't touch the actual environment.
3481         (Test cases are all as before, but based on operator== instead of strcmp.)
3482
3483 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3484
3485         [ews-app] Update primary keys for handling multiple Buildbot instances
3486         https://bugs.webkit.org/show_bug.cgi?id=195120
3487
3488         Reviewed by Stephanie Lewis.
3489
3490         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3491         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3492         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3493
3494         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3495         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3496         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3497         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3498         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3499         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3500
3501 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3502
3503         [WinCairo] Enable service worker
3504         https://bugs.webkit.org/show_bug.cgi?id=188318
3505
3506         Reviewed by Youenn Fablet.
3507
3508         * DumpRenderTree/DumpRenderTreePrefix.h:
3509         * TestWebKitAPI/PlatformWin.cmake:
3510         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3511         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3512         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3513
3514 2019-03-01  Justin Fan  <justin_fan@apple.com>
3515
3516         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3517         https://bugs.webkit.org/show_bug.cgi?id=195191
3518
3519         Rubber-stamped by Dean Jackson.
3520
3521         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3522
3523         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3524
3525 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3526
3527         Unreviewed, fix lldb webkitpy tests
3528         https://bugs.webkit.org/show_bug.cgi?id=194375
3529
3530         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3531
3532         * lldb/lldb_webkit.py:
3533         (WTFStringImplProvider.is_8bit):
3534
3535 2019-02-28  David Quesada  <david_quesada@apple.com>
3536
3537         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3538         https://bugs.webkit.org/show_bug.cgi?id=195121
3539         rdar://problem/48450302
3540
3541         Reviewed by Alex Christensen.
3542
3543         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3544         configurations where the 'download' attribute is absent, blank, or populated
3545         with a filename, and where the anchor element is same-origin or cross-origin
3546         (meaning the 'download' attribute shouldn't be honored).
3547
3548         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3549         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3550         (-[NavigationActionTestDelegate init]):
3551         (-[NavigationActionTestDelegate navigationAction]):
3552         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3553         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3554         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3555         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3556         (TEST):
3557
3558 2019-02-28  Antoine Quint  <graouts@apple.com>
3559
3560         Enable the Pointer Events runtime flag by default
3561         https://bugs.webkit.org/show_bug.cgi?id=195156
3562
3563         Reviewed by Dean Jackson.
3564
3565         * DumpRenderTree/mac/DumpRenderTree.mm:
3566         (enableExperimentalFeatures):
3567
3568 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3569
3570         Several PasteImage API tests are flaky
3571         https://bugs.webkit.org/show_bug.cgi?id=195160
3572
3573         Reviewed by Tim Horton.
3574
3575         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3576         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3577         listening for a "load" event after image load is already complete.
3578
3579         To address this, make these tests first register a "load" event handler, then run script to insert an image
3580         element into the document, and finally wait until the load event is observed before checking image size.
3581
3582         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3583
3584 2019-02-28  Chris Dumez  <cdumez@apple.com>
3585
3586         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3587         https://bugs.webkit.org/show_bug.cgi?id=195107
3588
3589         Reviewed by Alex Christensen.
3590
3591         Give some time for the zoom level to get restored.
3592
3593         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3594
3595 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3596
3597         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3598         https://bugs.webkit.org/show_bug.cgi?id=194958
3599
3600         Reviewed by Geoffrey Garen.
3601
3602         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3603         (TEST):
3604
3605 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3606
3607         [ews-app] Update method to save build to handle builder_display_name
3608         https://bugs.webkit.org/show_bug.cgi?id=195047
3609
3610         Reviewed by Dewei Zhu.
3611
3612         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3613         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3614
3615 2019-02-28  Justin Fan  <justin_fan@apple.com>
3616
3617         [Web GPU] Enable Web GPU only on 64-bit
3618         https://bugs.webkit.org/show_bug.cgi?id=195139
3619
3620         Because Metal is only supported on 64 bit apps.
3621
3622         Unreviewed build fix.
3623
3624         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3625
3626 2019-02-27  Youenn Fablet  <youenn@apple.com>
3627
3628         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3629         https://bugs.webkit.org/show_bug.cgi?id=194959
3630
3631         Reviewed by Chris Dumez.
3632
3633         Spin loop until getting the condition to remove flakiness.
3634
3635         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3636
3637 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3638
3639         [ews-build] Buildbot should include builder_display_name in the build events
3640         https://bugs.webkit.org/show_bug.cgi?id=195045
3641
3642         Reviewed by Dewei Zhu.
3643
3644         * BuildSlaveSupport/ews-build/events.py:
3645         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3646         buildername to builder_name to be consistent in naming style.
3647         (Events.buildFinished): Ditto.
3648
3649 2019-02-27  Chris Dumez  <cdumez@apple.com>
3650
3651         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3652         https://bugs.webkit.org/show_bug.cgi?id=194480
3653
3654         Reviewed by Brady Eidson.
3655
3656         Update existing API test to make it more likely to reproduce the issue.
3657
3658         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3659
3660 2019-02-27  Brady Eidson  <beidson@apple.com>
3661
3662         Universal links from Google search results pages don't open the app.
3663         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3664
3665         Reviewed by Geoffrey Garen.
3666
3667         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3668         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3669         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3670         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3671
3672 2019-02-27  Chris Dumez  <cdumez@apple.com>
3673
3674         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3675         https://bugs.webkit.org/show_bug.cgi?id=195102
3676
3677         Reviewed by Geoffrey Garen.
3678
3679         If the number of processes is not yet what we expect, wait a bit and check again to give
3680         processes some time to exit.
3681
3682         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3683
3684 2019-02-27  Chris Dumez  <cdumez@apple.com>
3685
3686         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3687         https://bugs.webkit.org/show_bug.cgi?id=194545
3688
3689         Reviewed by Brady Eidson.
3690
3691         Make sure the test navigates forward and then back only once. Previously, navigating
3692         back would trigger a navigation again in a timer.
3693
3694         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3695
3696 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3697
3698         High Sierra Debug JSC test queue should use faster hardware
3699         https://bugs.webkit.org/show_bug.cgi?id=194603
3700
3701         Rubber-stamped by Alexey Proskuryakov.
3702
3703         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3704
3705         * BuildSlaveSupport/build.webkit.org-config/config.json:
3706         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3707         (BubbleQueueServer):
3708         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3709         (WebKitBuildbot):
3710         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3711         * QueueStatusServer/config/queues.py:
3712         * Scripts/webkitpy/common/config/ews.json:
3713         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3714         (test_ews_name):
3715
3716 2019-02-27  John Wilander  <wilander@apple.com>
3717
3718         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3719         https://bugs.webkit.org/show_bug.cgi?id=195071
3720         <rdar://problem/48417690>
3721
3722         Reviewed by Alex Christensen and Brent Fulgham.
3723
3724         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3725         (TestWebKitAPI::createURL):
3726             Convenience function.
3727         (TestWebKitAPI::TEST):
3728             WebCore::AdClickAttribution now takes a URL when creating Source and
3729             Destination.
3730         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3731         (TestWebKitAPI::TEST):
3732             WebCore::AdClickAttribution now takes a URL when creating Source and
3733             Destination.
3734
3735 2019-02-27  Antoine Quint  <graouts@apple.com>
3736
3737         Support Pointer Events on macOS
3738         https://bugs.webkit.org/show_bug.cgi?id=195008
3739         <rdar://problem/47454419>
3740
3741         Reviewed by Dean Jackson.
3742
3743         * DumpRenderTree/mac/DumpRenderTree.mm:
3744         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3745         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3746
3747 2019-02-26  Mark Lam  <mark.lam@apple.com>
3748
3749         Remove remaining poisoning code.
3750         https://bugs.webkit.org/show_bug.cgi?id=194138
3751
3752         Reviewed by Saam Barati.
3753
3754         * TestWebKitAPI/CMakeLists.txt:
3755         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3756         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3757         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3758         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3759         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3760         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3761         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3762
3763 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3764
3765         Move ephemeral local storage from WebProcess to UIProcess
3766         https://bugs.webkit.org/show_bug.cgi?id=195074
3767         <rdar://problem/47937975>
3768
3769         Reviewed by Geoff Garen.
3770
3771         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3772
3773 2019-02-20  Jer Noble  <jer.noble@apple.com>
3774
3775         [Cocoa] Media elements will restart network buffering just before suspending
3776         https://bugs.webkit.org/show_bug.cgi?id=193691
3777
3778         Reviewed by Eric Carlson.
3779
3780         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3781         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3782         (TEST):
3783
3784 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3785
3786         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3787         https://bugs.webkit.org/show_bug.cgi?id=191652
3788
3789         Reviewed by Alex Christensen.
3790
3791         Fix WinCairo MiniBrowser behavior of authentication dialog.
3792
3793         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3794         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3795
3796 2019-02-26  Youenn Fablet  <youenn@apple.com>
3797
3798         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3799         https://bugs.webkit.org/show_bug.cgi?id=195028
3800         <rdar://problem/48243733>
3801
3802         Reviewed by Eric Carlson.
3803
3804         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3805
3806 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3807
3808         [WPE] Add API for webview background color configuration
3809         https://bugs.webkit.org/show_bug.cgi?id=192305
3810
3811         Reviewed by Michael Catanzaro.
3812
3813         * MiniBrowser/wpe/main.cpp:
3814         (main): Add a new option to configure the webview background
3815         color. Example: --bg-color=transparent.
3816         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3817         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3818         (beforeAll): Ditto.
3819
3820 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3821
3822         scalableNativeWebpageParameters() is not preserved on new page navigation.
3823         https://bugs.webkit.org/show_bug.cgi?id=194892
3824         <rdar://problem/47538280>
3825
3826         Reviewed by Wenson Hsieh.
3827         
3828         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3829
3830         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3831         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3832         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3833         (WTR::UIScriptController::allowsViewportShrinkToFit):
3834         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3835         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3836         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3837         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3838         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3839         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3840
3841 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3842
3843         [ews-app] Add model for handling multiple Buildbot instances
3844         https://bugs.webkit.org/show_bug.cgi?id=194863
3845
3846         Reviewed by Stephanie Lewis.
3847
3848         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3849
3850 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3851
3852         [ews-app] Remove BuilderMapping table
3853         https://bugs.webkit.org/show_bug.cgi?id=194961
3854
3855         Reviewed by Stephanie Lewis.
3856
3857         Store builder name directly in build table, instead of having a separate
3858         table for it.
3859
3860         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3861         * BuildSlaveSupport/ews-app/ews/models/build.py:
3862         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3863         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3864
3865 2019-02-25  John Wilander  <wilander@apple.com>
3866
3867         Introduce and adopt new class RegistrableDomain for eTLD+1
3868         https://bugs.webkit.org/show_bug.cgi?id=194791
3869         <rdar://problem/48179240>
3870
3871         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3872
3873         This patch adds an API test and replaces two instances of
3874         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3875
3876         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3877         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3878         (TestWebKitAPI::TEST):
3879             Changed two strings to make sure the registrable domains are still considered
3880             invalid and pass the test.
3881         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3882         (TestWebKitAPI::TEST):
3883         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3884         (WTR::InjectedBundle::didReceiveMessageToPage):
3885
3886 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3887
3888         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3889         https://bugs.webkit.org/show_bug.cgi?id=195001
3890
3891         Reviewed by Carlos Garcia Campos.
3892
3893         API version 1.0 always includes the functionality previously guarded with
3894         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3895         unconditionally.
3896
3897         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3898         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3899         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3900         (WebViewTest::showInWindow): Ditto.
3901         (WebViewTest::hideView): Ditto.
3902         * wpe/backends/HeadlessViewBackend.cpp:
3903         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3904         * wpe/backends/ViewBackend.cpp:
3905         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3906         * wpe/backends/WindowViewBackend.cpp:
3907         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3908         WPE_BACKEND_CHECK_VERSION().
3909         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3910
3911 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3912
3913         [Flatpak] Add support for flatpak > 1.1.2
3914         https://bugs.webkit.org/show_bug.cgi?id=194088
3915
3916         Flatpak 1.2 is now out so we need to support that
3917         version now.
3918
3919         Reviewed by Michael Catanzaro.
3920
3921         * flatpak/flatpakutils.py:
3922         (check_flatpak):
3923         (FlatpakPackages.__init__):
3924         (FlatpakPackages.__detect_packages):
3925         (FlatpakPackages.__detect_packages.in):
3926         (FlatpakRepos.update):
3927
3928 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3929
3930         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3931         https://bugs.webkit.org/show_bug.cgi?id=194998
3932
3933         Reviewed by Carlos Garcia Campos.
3934
3935         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3936         to a Git checkout and using the latest commit containing various fixes
3937         and improvements.
3938
3939 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3940
3941         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3942         https://bugs.webkit.org/show_bug.cgi?id=194981
3943
3944         Reviewed by Žan Doberšek.
3945
3946         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3947         (TestWebKitAPI::TEST):
3948
3949 2019-02-23  Keith Miller  <keith_miller@apple.com>
3950
3951         Add new mac target numbers
3952         https://bugs.webkit.org/show_bug.cgi?id=194955
3953
3954         Reviewed by Tim Horton.
3955
3956         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3957         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3958         * MiniBrowser/Configurations/Base.xcconfig:
3959         * TestWebKitAPI/Configurations/Base.xcconfig:
3960         * WebKitTestRunner/Configurations/Base.xcconfig:
3961
3962 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3963
3964         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3965         https://bugs.webkit.org/show_bug.cgi?id=194846
3966
3967         Reviewed by Don Olmstead.
3968
3969         Added _search_paths() and _port_specific_expectations_files() for
3970         WinCairoPort.
3971
3972         * Scripts/webkitpy/port/win.py:
3973         (WinCairoPort.default_baseline_search_path):
3974         (WinCairoPort):
3975         (WinCairoPort._port_specific_expectations_files):
3976         (WinCairoPort._search_paths):
3977
3978 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3979
3980         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3981         https://bugs.webkit.org/show_bug.cgi?id=194963
3982
3983         Reviewed by Dean Jackson.
3984
3985         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3986         Do a `contains` check instead of `equals`, because in debug builds we
3987         put the GraphicsLayer pointer in a prefix.
3988
3989 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3990
3991         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3992         https://bugs.webkit.org/show_bug.cgi?id=194873
3993         <rdar://problem/46701974>
3994
3995         Reviewed by Tim Horton.
3996
3997         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3998
3999         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4000         (WTR::UIScriptController::menuRect const):
4001         (WTR::UIScriptController::isShowingMenu const):
4002         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4003         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4004         (WTR::UIScriptController::menuRect const):
4005
4006         Add a function to query the bounds of the callout menu in content coordinates.
4007
4008         (WTR::UIScriptController::isShowingMenu const):
4009
4010         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4011
4012         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4013         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4014         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4015         (WTR::UIScriptController::rectForMenuAction const):
4016         (WTR::UIScriptController::menuRect const):
4017         (WTR::UIScriptController::isShowingMenu const):
4018         (WTR::findViewInHierarchyOfType): Deleted.
4019
4020 2019-02-22  Chris Dumez  <cdumez@apple.com>
4021
4022         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4023         https://bugs.webkit.org/show_bug.cgi?id=194954
4024         <rdar://problem/48127957>
4025
4026         Reviewed by Alex Christensen.
4027
4028         Add API test coverage.
4029
4030         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4031         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4032         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4033         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4034
4035 2019-02-22  Chris Dumez  <cdumez@apple.com>
4036
4037         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4038         https://bugs.webkit.org/show_bug.cgi?id=194924
4039         <rdar://problem/48216125>
4040
4041         Reviewed by Geoffrey Garen.
4042
4043         Add API test coverage.
4044
4045         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4046
4047 2019-02-22  Chris Dumez  <cdumez@apple.com>
4048
4049         Unreviewed, disable API test added in r241928 on iOS.
4050
4051         The cache is not enabled on devices with less than 3GB of RAM.
4052
4053         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4054
4055 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4056
4057         Hardcode Visual Viewports on everywhere except iOS WK1
4058         https://bugs.webkit.org/show_bug.cgi?id=194928
4059
4060         Reviewed by Zalan Bujtas.
4061
4062         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4063         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4064         set it to false. The setting has shipped for several years and there's no need to turn
4065         it off now.
4066
4067         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4068         Visual Viewports are not enabled.
4069         
4070         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4071         that only runs in WK2
4072
4073         * MiniBrowser/mac/SettingsController.h:
4074         * MiniBrowser/mac/SettingsController.m:
4075         (-[SettingsController init]):
4076         (-[SettingsController _populateMenu]):
4077         (-[SettingsController validateMenuItem:]):
4078         (-[SettingsController visualViewportEnabled]): Deleted.
4079         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4080         * MiniBrowser/mac/WK1BrowserWindowController.m:
4081         (-[WK1BrowserWindowController didChangeSettings]):
4082         * MiniBrowser/mac/WK2BrowserWindowController.m:
4083         (-[WK2BrowserWindowController didChangeSettings]):
4084
4085 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4086
4087         Discard cached processes when clearing website data store
4088         https://bugs.webkit.org/show_bug.cgi?id=194894
4089
4090         Reviewed by Chris Dumez.
4091
4092         Added a test case.
4093
4094         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4095         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4096
4097 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4098
4099         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4100         https://bugs.webkit.org/show_bug.cgi?id=194914
4101         <rdar://problem/47586889>
4102
4103         Reviewed by Geoffrey Garen.
4104
4105         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4106         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4107         (TEST):
4108         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4109
4110 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4111
4112         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4113         <https://webkit.org/b/194761>
4114
4115         Reviewed by Myles Maxfield.
4116
4117         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4118         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4119         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4120         to use ARC-compliant cast.
4121         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4122         ARC-compliant cast.
4123         (WTR::installFakeHelvetica): Log `error` to console if
4124         CTFontManagerRegisterFontsForURL() fails, but only on supported
4125         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4126         Call CFRelease() on `error` to fix the leak.  Update to use
4127         ARC-compliant cast.
4128         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4129         cast.
4130
4131 2019-02-21  Chris Dumez  <cdumez@apple.com>
4132
4133         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4134         https://bugs.webkit.org/show_bug.cgi?id=194481
4135
4136         Reviewed by Alex Christensen.
4137
4138         Give the processes a chance to shutdown and wait until we reached the expected number
4139         of processes.
4140
4141         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4142
4143 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4144
4145         Fix the macOS build
4146
4147         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4148
4149 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4150
4151         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4152
4153         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4154         I am a backwards.
4155
4156 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4157
4158         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4159
4160         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4161         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4162         We could force on UI-side compositing, but I feel like the test might be more
4163         valuable exercising the normal path on each platform (though the original
4164         bug was also UI-side specific). Though we can't validate that the overlay
4165         layer was installed successfully, there are layout tests that do that.
4166
4167 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4168
4169         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4170         https://bugs.webkit.org/show_bug.cgi?id=194845
4171         <rdar://problem/47944579>
4172
4173         Reviewed by Antti Koivisto.
4174
4175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4176         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4177
4178 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4179
4180         [LFC][Floats] Add support for placing formatting roots in-between floats.
4181         https://bugs.webkit.org/show_bug.cgi?id=194902
4182
4183         Reviewed by Antti Koivisto.
4184
4185         * LayoutReloaded/misc/LFC-passing-tests.txt:
4186
4187 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4188
4189         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4190         https://bugs.webkit.org/show_bug.cgi?id=194901
4191
4192         Unreviewed build fix.
4193
4194         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4195         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4196         WPEBackend-fdo-0.1 as library name.
4197
4198 2019-02-21  Rob Buis  <rbuis@igalia.com>
4199
4200         Update MIME type parser
4201         https://bugs.webkit.org/show_bug.cgi?id=180526
4202
4203         Reviewed by Darin Adler.
4204
4205         Add tests involving leading and trailing whitespace, non-token
4206         characters and quoted strings.
4207
4208         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4209         (TestWebKitAPI::TEST):
4210
4211 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4212
4213         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4214         https://bugs.webkit.org/show_bug.cgi?id=194884
4215
4216         Reviewed by Michael Catanzaro.
4217
4218         * PlatformWin.cmake:
4219
4220 2019-02-20  Chris Dumez  <cdumez@apple.com>
4221
4222         Add API test for <rdar://problem/47471222>
4223         https://bugs.webkit.org/show_bug.cgi?id=194847
4224
4225         Reviewed by Alex Christensen.
4226
4227         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4228
4229 2019-02-20  Chris Dumez  <cdumez@apple.com>
4230
4231         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4232         https://bugs.webkit.org/show_bug.cgi?id=194872
4233         <rdar://problem/47924500>
4234
4235         Reviewed by Alex Christensen.
4236
4237         Add API test coverage.
4238
4239         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4240
4241 2019-02-20  Jer Noble  <jer.noble@apple.com>
4242
4243         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4244         https://bugs.webkit.org/show_bug.cgi?id=191332
4245
4246         Reviewed by Dean Jackson.
4247
4248         * Scripts/git-is-in-range: Added.
4249
4250 2019-02-20  Andy Estes  <aestes@apple.com>
4251
4252         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4253         https://bugs.webkit.org/show_bug.cgi?id=194869
4254
4255         Rubber-stamped by Jer Noble.
4256
4257         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4258         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4259         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4260         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4262         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4263
4264 2019-02-20  Chris Dumez  <cdumez@apple.com>
4265
4266         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4267         https://bugs.webkit.org/show_bug.cgi?id=194857
4268         <rdar://problem/47759323>
4269
4270         Reviewed by Alex Christensen.
4271
4272         Add API test coverage.
4273
4274         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4275
4276 2019-02-20  Chris Dumez  <cdumez@apple.com>
4277
4278         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4279         https://bugs.webkit.org/show_bug.cgi?id=194829
4280         <rdar://problem/47889906>
4281
4282         Reviewed by Alexey Proskuryakov.
4283
4284         Every time the TestOptions were changing we were creating both a new Web view and
4285         a new WKContext, which would start a new Network process. In most cases, we only
4286         need to contruct a new Web view and we do can keep reusing the same WKContext.
4287         This patch implements this optimization and thus avoids spinning a lot of new
4288         Network processes while running the layout tests.
4289
4290         * WebKitTestRunner/TestController.cpp:
4291         (WTR::TestController::generateContextConfiguration const):
4292         (WTR::TestController::generatePageConfiguration):
4293         (WTR::TestController::createWebViewWithOptions):
4294         (WTR::TestController::resetPreferencesToConsistentValues):
4295         (WTR::updateTestOptionsFromTestHeader):
4296         * WebKitTestRunner/TestController.h:
4297         * WebKitTestRunner/TestOptions.h:
4298         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4299         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4300         (WTR::TestOptions::hasSameInitializationOptions const):
4301         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4302         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4303         (WTR::TestController::platformAddTestOptions const):
4304
4305 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4306
4307         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4308         https://bugs.webkit.org/show_bug.cgi?id=167941
4309
4310         Reviewed by Carlos Garcia Campos.
4311
4312         * MiniBrowser/gtk/main.c:
4313         (filterSavedCallback): Added.
4314         (main): Support loading a JSON rule set file for content filtering.
4315         * MiniBrowser/wpe/main.cpp:
4316         (filterSavedCallback): Added.
4317         (main): Support loading a JSON rule set file for content filtering.
4318         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4319         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4320         (WTF::derefGPtr): Ditto.
4321         (testEmptyStore):
4322         (testSaveInvalidFilter):
4323         (testSaveLoadFilter):
4324         (testSavedFilterIdentifierMatch):
4325         (testRemoveFilter):
4326         (testSaveMultipleFilters):
4327         (testSaveFilterFromFile):
4328         (testFilterPersistence):
4329         (beforeAll):
4330         (afterAll):
4331         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4332         (removeOldInjectedContentAndResetLists): Also reset content filters.
4333         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4334         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4335         the element affected by the style sheet.
4336         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4337         and returns it to be used by tests.
4338         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4339         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4340         (serverCallback): Add support for serving a CSS style sheet for testing.
4341         (beforeAll): Add call to testUserContentManagerContentFilter().
4342         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4343
4344 2019-02-19  Keith Rollin  <krollin@apple.com>
4345
4346         Add timing information to build output
4347         https://bugs.webkit.org/show_bug.cgi?id=194839
4348         <rdar://problem/48219609>
4349
4350         Reviewed by Alexey Proskuryakov.
4351
4352         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4353         emit each project's build time to its output. E.g.,
4354
4355             ** BUILD SUCCEEDED ** [0.132 sec]
4356
4357         * Scripts/webkitdirs.pm:
4358         (XcodeOptions):
4359
4360 2019-02-19  Truitt Savell  <tsavell@apple.com>
4361
4362         Unreviewed, rolling out r241784.
4363
4364         Broke all OpenSource builds.
4365
4