Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
4         https://bugs.webkit.org/show_bug.cgi?id=197079
5
6         Reviewed by Darin Adler.
7
8         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
9
10         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
12
13 2019-04-18  Commit Queue  <commit-queue@webkit.org>
14
15         Unreviewed, rolling out r244434.
16         https://bugs.webkit.org/show_bug.cgi?id=197089
17
18         caused 1 API test failure (Requested by zalan on #webkit).
19
20         Reverted changeset:
21
22         "Regression (r244291): Broken API Test
23         AutoLayoutRenderingProgressRelativeOrdering"
24         https://bugs.webkit.org/show_bug.cgi?id=196948
25         https://trac.webkit.org/changeset/244434
26
27 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
28
29         Add new compatibility mode API on WKNavigation
30         https://bugs.webkit.org/show_bug.cgi?id=197069
31         <rdar://problem/50025800>
32
33         Reviewed by Tim Horton.
34
35         Add a block property for -didCommitNavigation to TestNavigationDelegate.
36
37         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
38         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
39         (-[TestNavigationDelegate webView:didCommitNavigation:]):
40
41 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
42
43         [CMake] Make WebCore headers copies
44         https://bugs.webkit.org/show_bug.cgi?id=182512
45         <rdar://problem/37510435>
46
47         Reviewed by Alex Christensen.
48
49         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
50         ports.
51
52         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
53         of WebCore headers using "*.h" were modified to <WebCore/*.h>
54
55         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
56         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
57         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
58         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
59         * TestWebKitAPI/CMakeLists.txt:
60         * TestWebKitAPI/PlatformWin.cmake:
61         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
62         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
63         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
64
65 2019-04-18  Jer Noble  <jer.noble@apple.com>
66
67         Add support for parsing FairPlayStreaming PSSH boxes.
68         https://bugs.webkit.org/show_bug.cgi?id=197064
69
70         Reviewed by Eric Carlson.
71
72         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
73         (TestWebKitAPI::TEST):
74
75 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
76
77         InjectedBundle parameters often need initialization function called before unarchiving
78         https://bugs.webkit.org/show_bug.cgi?id=189709
79         <rdar://problem/44573653>
80
81         Reviewed by Ryosuke Niwa.
82
83         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
84         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
85
86 2019-04-18  Zalan Bujtas  <zalan@apple.com>
87
88         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
89         https://bugs.webkit.org/show_bug.cgi?id=196948
90         <rdar://problem/49927131>
91
92         Reviewed by Tim Horton.
93
94         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
95         (TEST): 
96         The expected order of incoming events is
97         1. didInvalidateIntrinsicContentSize
98         2. didFirstLayout
99         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
100         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
101         (and remember, all we care about is ordering).
102
103 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
104
105         Unreviewed, rolling out r244299.
106
107         Breaks internal tests.
108
109         Reverted changeset:
110
111         "InjectedBundle parameters often need initialization function
112         called before unarchiving"
113         https://bugs.webkit.org/show_bug.cgi?id=189709
114         https://trac.webkit.org/changeset/244299
115
116 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
117
118         [WTF] StringBuilder should set correct m_is8Bit flag when merging
119         https://bugs.webkit.org/show_bug.cgi?id=197053
120
121         Reviewed by Saam Barati.
122
123         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
124         (TestWebKitAPI::TEST):
125
126 2019-04-17  Tim Horton  <timothy_horton@apple.com>
127
128         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
129         https://bugs.webkit.org/show_bug.cgi?id=197028
130         <rdar://problem/49985290>
131
132         Reviewed by Wenson Hsieh.
133
134         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
135         (TEST):
136         Liberal application of waitForNextPresentationUpdate works around a race
137         where if the page rapidly changes its viewport arguments (or an API client
138         rapidly changes its viewport arguments), we'd get stuck thinking that the
139         user had intentionally zoomed the page, and stop resetting the initial scale.
140         This deserves a separate bug, but no need to keep the test failing while
141         we think about it.
142
143 2019-04-17  Tim Horton  <timothy_horton@apple.com>
144
145         REGRESSION (r241988): Switching tabs is slow
146         https://bugs.webkit.org/show_bug.cgi?id=197037
147         <rdar://problem/49951473>
148
149         Reviewed by Simon Fraser.
150
151         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
152         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
153         (TEST):
154         * TestWebKitAPI/cocoa/TestWKWebView.h:
155         * TestWebKitAPI/cocoa/TestWKWebView.mm:
156         (-[TestWKWebView addToTestWindow]):
157         Add a test that hangs without this fix.
158
159 2019-04-17  Truitt Savell  <tsavell@apple.com>
160
161         Unreviewed, rolling out r244400.
162
163         Caused testing to exit early with assertionon Debug WK2
164
165         Reverted changeset:
166
167         "UI↔Web deadlock when printing with a JavaScript alert
168         visible"
169         https://bugs.webkit.org/show_bug.cgi?id=196839
170         https://trac.webkit.org/changeset/244400
171
172 2019-04-17  Brady Eidson  <beidson@apple.com>
173
174         Link clicks in PDFs shouldn't send referrer headers.
175         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
176
177         Reviewed by Tim Horton.
178
179         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
180         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
181         (putPDFBytesCallback):
182         (emptyReleaseInfoCallback):
183         (createPDFWithLinkToURL):
184         (TEST):
185
186 2019-04-17  Tim Horton  <timothy_horton@apple.com>
187
188         UI↔Web deadlock when printing with a JavaScript alert visible
189         https://bugs.webkit.org/show_bug.cgi?id=196839
190         <rdar://problem/49157642>
191
192         Reviewed by Andy Estes.
193
194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
195         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
196         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
197         (TEST):
198
199 2019-04-17  Alex Christensen  <achristensen@webkit.org>
200
201         WKRetainPtr's adoption constructor should be private
202         https://bugs.webkit.org/show_bug.cgi?id=197019
203
204         Reviewed by Tim Horton.
205
206         * DumpRenderTree/mac/DumpRenderTree.mm:
207         (dumpFramesAsText):
208         * TestWebKitAPI/InjectedBundleController.cpp:
209         (TestWebKitAPI::InjectedBundleController::initialize):
210         * TestWebKitAPI/PlatformUtilities.cpp:
211         (TestWebKitAPI::Util::createContextWithInjectedBundle):
212         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
213         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
214         (TestWebKitAPI::Util::toWK):
215         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
216         (TestWebKitAPI::TEST):
217         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
218         (TestWebKitAPI::TEST):
219         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
220         (TestWebKitAPI::TEST):
221         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
222         (TestWebKitAPI::TEST):
223         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
224         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
225         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
226         (TestWebKitAPI::TEST):
227         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
228         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
229         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
230         (TestWebKitAPI::TEST):
231         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
232         (TestWebKitAPI::TEST):
233         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
234         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
235         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
236         (TestWebKitAPI::TEST):
237         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
238         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
239         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
240         (TestWebKitAPI::TEST):
241         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
242         (TestWebKitAPI::TEST):
243         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
244         (TestWebKitAPI::TEST):
245         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
246         (TestWebKitAPI::TEST):
247         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
248         (TestWebKitAPI::TEST):
249         * TestWebKitAPI/Tests/WebKit/Find.cpp:
250         (TestWebKitAPI::TEST):
251         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
252         (TestWebKitAPI::TEST):
253         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
254         (TestWebKitAPI::TEST):
255         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
256         (TestWebKitAPI::TEST):
257         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
258         (TestWebKitAPI::TEST):
259         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
260         (TestWebKitAPI::TEST):
261         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
262         (TestWebKitAPI::TEST):
263         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
264         (TestWebKitAPI::TEST):
265         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
266         (TestWebKitAPI::TEST):
267         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
268         (TestWebKitAPI::TEST):
269         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
270         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
271         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
272         (TestWebKitAPI::TEST):
273         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
274         (TestWebKitAPI::TEST):
275         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
276         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
277         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
278         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
279         (TestWebKitAPI::TEST):
280         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
281         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
282         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
283         (TestWebKitAPI::TEST):
284         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
285         (TestWebKitAPI::TEST):
286         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
287         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
288         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
289         (TestWebKitAPI::TEST):
290         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
291         (TestWebKitAPI::loadAlternateHTMLString):
292         (TestWebKitAPI::TEST):
293         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
294         (TestWebKitAPI::TEST):
295         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
296         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
297         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
298         (TestWebKitAPI::buildAndPerformTest):
299         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
300         (TestWebKitAPI::TEST):
301         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
302         (TestWebKitAPI::TEST):
303         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
304         (TestWebKitAPI::TEST):
305         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
306         (TestWebKitAPI::TEST):
307         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
308         (TestWebKitAPI::TEST):
309         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
310         (TestWebKitAPI::TEST):
311         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
312         (TestWebKitAPI::TEST):
313         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
314         (TestWebKitAPI::TEST):
315         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
316         (TestWebKitAPI::TEST):
317         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
318         (TestWebKitAPI::TEST):
319         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
320         (TestWebKitAPI::TEST):
321         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
322         (TestWebKitAPI::TEST):
323         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
324         (TestWebKitAPI::TEST):
325         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
326         (TestWebKitAPI::TEST):
327         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
328         (TestWebKitAPI::TEST):
329         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
330         (TestWebKitAPI::TEST):
331         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
332         (TestWebKitAPI::TEST):
333         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
334         (TestWebKitAPI::TEST):
335         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
336         (TestWebKitAPI::TEST):
337         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
338         (TestWebKitAPI::TEST):
339         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
340         (TestWebKitAPI::TEST):
341         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
342         (TestWebKitAPI::TEST):
343         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
344         (TestWebKitAPI::TEST):
345         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
346         (TestWebKitAPI::TEST):
347         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
348         (TestWebKitAPI::TEST):
349         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
350         (TestWebKitAPI::TEST):
351         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
352         (TestWebKitAPI::TEST):
353         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
354         (TestWebKitAPI::TEST):
355         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
356         (TestWebKitAPI::TEST):
357         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
358         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
359         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
360         (TestWebKitAPI::TEST):
361         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
362         (TestWebKitAPI::TEST):
363         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
364         (TestWebKitAPI::TEST):
365         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
366         (TestWebKitAPI::TEST):
367         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
368         (TestWebKitAPI::TEST):
369         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
370         (TestWebKitAPI::TEST):
371         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
372         (TestWebKitAPI::TEST):
373         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
374         (TestWebKitAPI::TEST):
375         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
376         (TestWebKitAPI::TEST):
377         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
378         (TestWebKitAPI::TEST):
379         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
380         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
381         (TEST):
382         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
383         (TEST):
384         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
385         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
386         (TEST):
387         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
388         (TestWebKitAPI::TEST):
389         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
390         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
391         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
392         (WTR::getMenuItemTitleCallback):
393         (WTR::createMouseMessageBody):
394         (WTR::EventSendingController::mouseDown):
395         (WTR::EventSendingController::mouseUp):
396         (WTR::EventSendingController::mouseMoveTo):
397         (WTR::EventSendingController::mouseForceClick):
398         (WTR::EventSendingController::startAndCancelMouseForceClick):
399         (WTR::EventSendingController::mouseForceDown):
400         (WTR::EventSendingController::mouseForceUp):
401         (WTR::EventSendingController::mouseForceChanged):
402         (WTR::EventSendingController::leapForward):
403         (WTR::EventSendingController::scheduleAsynchronousClick):
404         (WTR::createKeyDownMessageBody):
405         (WTR::EventSendingController::keyDown):
406         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
407         (WTR::EventSendingController::mouseScrollBy):
408         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
409         (WTR::EventSendingController::continuousMouseScrollBy):
410         (WTR::EventSendingController::addTouchPoint):
411         (WTR::EventSendingController::updateTouchPoint):
412         (WTR::EventSendingController::setTouchModifier):
413         (WTR::EventSendingController::setTouchPointRadius):
414         (WTR::EventSendingController::touchStart):
415         (WTR::EventSendingController::touchMove):
416         (WTR::EventSendingController::touchEnd):
417         (WTR::EventSendingController::touchCancel):
418         (WTR::EventSendingController::clearTouchPoints):
419         (WTR::EventSendingController::releaseTouchPoint):
420         (WTR::EventSendingController::cancelTouchPoint):
421         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
422         (WTR::InjectedBundle::didCreatePage):
423         (WTR::InjectedBundle::didReceiveMessage):
424         (WTR::InjectedBundle::didReceiveMessageToPage):
425         (WTR::InjectedBundle::booleanForKey):
426         (WTR::InjectedBundle::done):
427         (WTR::InjectedBundle::dumpToStdErr):
428         (WTR::InjectedBundle::outputText):
429         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
430         (WTR::InjectedBundle::postAddChromeInputField):
431         (WTR::InjectedBundle::postRemoveChromeInputField):
432         (WTR::InjectedBundle::postFocusWebView):
433         (WTR::InjectedBundle::postSetBackingScaleFactor):
434         (WTR::InjectedBundle::postSetWindowIsKey):
435         (WTR::InjectedBundle::postSetViewSize):
436         (WTR::InjectedBundle::postSimulateWebNotificationClick):
437         (WTR::InjectedBundle::postSetAddsVisitedLinks):
438         (WTR::InjectedBundle::setGeolocationPermission):
439         (WTR::InjectedBundle::setMockGeolocationPosition):
440         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
441         (WTR::InjectedBundle::isGeolocationProviderActive const):
442         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
443         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
444         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
445         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
446         (WTR::InjectedBundle::setCustomPolicyDelegate):
447         (WTR::InjectedBundle::setHidden):
448         (WTR::InjectedBundle::setCacheModel):
449         (WTR::InjectedBundle::shouldProcessWorkQueue const):
450         (WTR::InjectedBundle::processWorkQueue):
451         (WTR::InjectedBundle::queueBackNavigation):
452         (WTR::InjectedBundle::queueForwardNavigation):
453         (WTR::InjectedBundle::queueLoad):
454         (WTR::InjectedBundle::queueLoadHTMLString):
455         (WTR::InjectedBundle::queueReload):
456         (WTR::InjectedBundle::queueLoadingScript):
457         (WTR::InjectedBundle::queueNonLoadingScript):
458         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
459         (WTR::frameToStr):
460         (WTR::InjectedBundlePage::InjectedBundlePage):
461         (WTR::dumpFrameDescriptionSuitableForTestResult):
462         (WTR::dumpFrameScrollPosition):
463         (WTR::dumpDescendantFrameScrollPositions):
464         (WTR::dumpFrameText):
465         (WTR::dumpDescendantFramesText):
466         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
467         (WTR::TestRunner::shouldDumpPixels const):
468         (WTR::TestRunner::setDumpPixels):
469         (WTR::TestRunner::whatToDump const):
470         (WTR::TestRunner::setWhatToDump):
471         (WTR::TestRunner::setWaitUntilDone):
472         (WTR::TestRunner::shouldWaitUntilDone const):
473         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
474         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
475         (WTR::TestRunner::clearAllDatabases):
476         (WTR::TestRunner::setIDBPerOriginQuota):
477         (WTR::TestRunner::originsWithApplicationCache):
478         (WTR::TestRunner::setCanOpenWindows):
479         (WTR::TestRunner::setXSSAuditorEnabled):
480         (WTR::TestRunner::setMediaDevicesEnabled):
481         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
482         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
483         (WTR::TestRunner::setCustomUserAgent):
484         (WTR::TestRunner::setWebAPIStatisticsEnabled):
485         (WTR::TestRunner::setModernMediaControlsEnabled):
486         (WTR::TestRunner::setWebGL2Enabled):
487         (WTR::TestRunner::setWritableStreamAPIEnabled):
488         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
489         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
490         (WTR::TestRunner::setAllowsAnySSLCertificate):
491         (WTR::TestRunner::setPluginsEnabled):
492         (WTR::TestRunner::setValueForUser):
493         (WTR::TestRunner::setAudioResult):
494         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
495         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
496         (WTR::TestRunner::setAlwaysAcceptCookies):
497         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
498         (WTR::TestRunner::isDoingMediaCapture const):
499         (WTR::TestRunner::queueLoad):
500         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
501         (WTR::TestRunner::setHandlesAuthenticationChallenges):
502         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
503         (WTR::TestRunner::setShouldLogDownloadCallbacks):
504         (WTR::TestRunner::setAuthenticationUsername):
505         (WTR::TestRunner::setAuthenticationPassword):
506         (WTR::TestRunner::secureEventInputIsEnabled const):
507         (WTR::TestRunner::setBlockAllPlugins):
508         (WTR::TestRunner::setPluginSupportedMode):
509         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
510         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
511         (WTR::TestRunner::setNavigationGesturesEnabled):
512         (WTR::TestRunner::setIgnoresViewportScaleLimits):
513         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
514         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
515         (WTR::TestRunner::terminateNetworkProcess):
516         (WTR::TestRunner::terminateServiceWorkerProcess):
517         (WTR::TestRunner::runUIScript):
518         (WTR::TestRunner::setStatisticsDebugMode):
519         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
520         (WTR::TestRunner::setStatisticsLastSeen):
521         (WTR::TestRunner::setStatisticsPrevalentResource):
522         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
523         (WTR::TestRunner::dumpResourceLoadStatistics):
524         (WTR::TestRunner::isStatisticsPrevalentResource):
525         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
526         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
527         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
528         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
529         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
530         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
531         (WTR::TestRunner::setStatisticsGrandfathered):
532         (WTR::TestRunner::isStatisticsGrandfathered):
533         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
534         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
535         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
536         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
537         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
538         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
539         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
540         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
541         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
542         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
543         (WTR::TestRunner::statisticsUpdateCookieBlocking):
544         (WTR::TestRunner::statisticsSubmitTelemetry):
545         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
546         (WTR::TestRunner::setStatisticsIsRunningTest):
547         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
548         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
549         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
550         (WTR::TestRunner::setStatisticsGrandfatheringTime):
551         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
552         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
553         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
554         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
555         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
556         (WTR::TestRunner::statisticsDeleteCookiesForHost):
557         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
558         (WTR::TestRunner::statisticsResetToConsistentState):
559         (WTR::TestRunner::setStorageAccessAPIEnabled):
560         (WTR::TestRunner::getAllStorageAccessEntries):
561         (WTR::TestRunner::addMockMediaDevice):
562         (WTR::TestRunner::clearMockMediaDevices):
563         (WTR::TestRunner::removeMockMediaDevice):
564         (WTR::TestRunner::resetMockMediaDevices):
565         (WTR::TestRunner::connectMockGamepad):
566         (WTR::TestRunner::disconnectMockGamepad):
567         (WTR::TestRunner::setMockGamepadDetails):
568         (WTR::TestRunner::setMockGamepadAxisValue):
569         (WTR::TestRunner::setMockGamepadButtonValue):
570         (WTR::TestRunner::removeAllSessionCredentials):
571         (WTR::TestRunner::clearDOMCache):
572         (WTR::TestRunner::clearDOMCaches):
573         (WTR::TestRunner::hasDOMCache):
574         (WTR::TestRunner::domCacheSize):
575         (WTR::TestRunner::setAllowStorageQuotaIncrease):
576         (WTR::TestRunner::getApplicationManifestThen):
577         (WTR::TestRunner::injectUserScript):
578         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
579         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
580         (WTR::TestRunner::addTestKeyToKeychain):
581         (WTR::TestRunner::cleanUpKeychain):
582         (WTR::TestRunner::keyExistsInKeychain):
583         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
584         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
585         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
586         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
587         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
588         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
589         * WebKitTestRunner/TestController.cpp:
590         (WTR::TestController::initialize):
591         (WTR::parseStringTestHeaderValueAsRelativePath):
592         (WTR::updateTestOptionsFromTestHeader):
593         (WTR::TestController::runTest):
594         (WTR::TestController::didReceiveLiveDocumentsList):
595         (WTR::TestController::didReceiveMessageFromInjectedBundle):
596         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
597         (WTR::TestController::didFinishNavigation):
598         (WTR::TestController::didReceiveAuthenticationChallenge):
599         * WebKitTestRunner/TestInvocation.cpp:
600         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
601         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
602         (WTR::TestInvocation::uiScriptDidComplete):
603         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
604         * WebKitTestRunner/WebNotificationProvider.cpp:
605         (WTR::WebNotificationProvider::closeWebNotification):
606         * WebKitTestRunner/WorkQueueManager.cpp:
607         (WTR::ScriptItem::ScriptItem):
608         (WTR::WorkQueueManager::queueLoad):
609         (WTR::WorkQueueManager::queueLoadHTMLString):
610
611 2019-04-17  Alex Christensen  <achristensen@webkit.org>
612
613         Add a comment to make my test from r244139 less mysterious.
614         https://bugs.webkit.org/show_bug.cgi?id=196744
615
616         As suggested by Darin Adler.
617
618         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
619         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
620
621 2019-04-17  Chris Dumez  <cdumez@apple.com>
622
623         Remember device orientation permission for the duration of the browsing session
624         https://bugs.webkit.org/show_bug.cgi?id=196992
625         <rdar://problem/49946067>
626
627         Reviewed by Alex Christensen.
628
629         Add API test coverage.
630
631         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
632         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
633         (TEST):
634
635 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
636
637         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
638         https://bugs.webkit.org/show_bug.cgi?id=196675
639
640         Reviewed by Lucas Forschler.
641
642         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
643         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
644
645 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
646
647         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
648         https://bugs.webkit.org/show_bug.cgi?id=196919
649         <rdar://problem/41630459>
650
651         Reviewed by Tim Horton.
652
653         Add iOS support for several new testing hooks. See below for more detail.
654
655         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
656         (WTR::UIScriptController::isDismissingMenu const):
657
658         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
659         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
660         by UIKit when dismissing the callout bar (i.e. UIMenuController).
661
662         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
663         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
664         (WTR::UIScriptController::isDismissingMenu const):
665         * TestRunnerShared/UIScriptContext/UIScriptController.h:
666         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
667         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
668         (WTR::InjectedBundle::didReceiveMessageToPage):
669         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
670         (WTR::TestRunner::setAllowedMenuActions):
671
672         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
673         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
674         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
675         against the name of the custom action.
676
677         (WTR::TestRunner::installCustomMenuAction):
678
679         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
680         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
681         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
682         triggered.
683
684         (WTR::TestRunner::performCustomMenuAction):
685
686         Invoked when the custom menu action is triggered.
687
688         * WebKitTestRunner/InjectedBundle/TestRunner.h:
689         * WebKitTestRunner/TestController.cpp:
690         (WTR::TestController::installCustomMenuAction):
691         (WTR::TestController::setAllowedMenuActions):
692         * WebKitTestRunner/TestController.h:
693         * WebKitTestRunner/TestInvocation.cpp:
694         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
695         (WTR::TestInvocation::performCustomMenuAction):
696
697         Add plumbing to call back into the injected bundle when performing the custom action.
698
699         * WebKitTestRunner/TestInvocation.h:
700         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
701         (WTR::TestController::installCustomMenuAction):
702         (WTR::TestController::setAllowedMenuActions):
703         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
704         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
705         (-[TestRunnerWKWebView initWithFrame:configuration:]):
706         (-[TestRunnerWKWebView becomeFirstResponder]):
707         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
708
709         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
710         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
711         in the Mail app on iOS.
712
713         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
714         (-[TestRunnerWKWebView setAllowedMenuActions:]):
715         (-[TestRunnerWKWebView resetCustomMenuAction]):
716         (-[TestRunnerWKWebView performCustomAction:]):
717         (-[TestRunnerWKWebView canPerformAction:withSender:]):
718         (-[TestRunnerWKWebView _willHideMenu]):
719         (-[TestRunnerWKWebView _didHideMenu]):
720         * WebKitTestRunner/ios/TestControllerIOS.mm:
721         (WTR::TestController::platformResetStateToConsistentValues):
722
723         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
724         if specified.
725
726         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
727         (WTR::UIScriptController::isDismissingMenu const):
728
729 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
730
731         Allow sharing from imageSheet on an image document
732         https://bugs.webkit.org/show_bug.cgi?id=196891
733         <rdar://problem/25377386>
734
735         Reviewed by Tim Horton.
736
737         Test to make sure that the correct imageURL is extracted from an image element.
738
739         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
740         (TestWebKitAPI::TEST):
741
742 2019-04-16  Alex Christensen  <achristensen@webkit.org>
743
744         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
745         https://bugs.webkit.org/show_bug.cgi?id=196995
746
747         Reviewed by Brady Eidson.
748
749         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
750         (TEST):
751
752 2019-04-16  Chris Dumez  <cdumez@apple.com>
753
754         URL set by document.open() is not communicated to the UIProcess
755         https://bugs.webkit.org/show_bug.cgi?id=196941
756         <rdar://problem/49237544>
757
758         Reviewed by Geoff Garen.
759
760         Add API test coverage.
761
762         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
763         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
764         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
765         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
766         (TEST):
767
768 2019-04-16  Commit Queue  <commit-queue@webkit.org>
769
770         Unreviewed, rolling out r244321.
771         https://bugs.webkit.org/show_bug.cgi?id=196968
772
773         Causing all WK2 Debug builds to exit early after Assertion
774         failures. (Requested by ShawnRoberts on #webkit).
775
776         Reverted changeset:
777
778         "URL set by document.open() is not communicated to the
779         UIProcess"
780         https://bugs.webkit.org/show_bug.cgi?id=196941
781         https://trac.webkit.org/changeset/244321
782
783 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
784
785         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
786         https://bugs.webkit.org/show_bug.cgi?id=196948
787
788         Reviewed by Zalan Bujtas.
789
790         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
791         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
792
793 2019-04-15  Chris Dumez  <cdumez@apple.com>
794
795         URL set by document.open() is not communicated to the UIProcess
796         https://bugs.webkit.org/show_bug.cgi?id=196941
797         <rdar://problem/49237544>
798
799         Reviewed by Geoffrey Garen.
800
801         Add API test coverage.
802
803         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
804         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
805         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
806         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
807         (TEST):
808
809 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
810
811         Using Tools/Scripts/clean-webkit should not install requests
812         https://bugs.webkit.org/show_bug.cgi?id=196940
813
814         Reviewed by Lucas Forschler.
815
816         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
817         existing, depending on the path autoinstalled is run through.
818         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
819         needed.
820         (Port.configuration_for_upload):
821         (Port.commits_for_upload):
822
823 2019-04-15  Alex Christensen  <achristensen@webkit.org>
824
825         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
826         https://bugs.webkit.org/show_bug.cgi?id=196773
827
828         Reviewed by Jer Noble.
829
830         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
831         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
832         (TEST):
833
834 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
835
836         ews-build should clearly indicate flaky test failures
837         https://bugs.webkit.org/show_bug.cgi?id=196947
838
839         Reviewed by Lucas Forschler.
840
841         * BuildSlaveSupport/ews-build/steps.py:
842         (AnalyzeAPITestsResults.analyzeResults):
843
844 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
845
846         InjectedBundle parameters often need initialization function called before unarchiving
847         https://bugs.webkit.org/show_bug.cgi?id=189709
848         <rdar://problem/44573653>
849
850         Reviewed by Ryosuke Niwa.
851
852         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
853         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
854
855 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
856
857         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
858         https://bugs.webkit.org/show_bug.cgi?id=196681
859
860         Reviewed by Darin Adler.
861
862         Added tests.
863
864         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
865         (WTF_HashSet.RemoveIf):
866         (WTF_HashSet.RemoveIfShrinkToBestSize):
867
868 2019-04-15  John Wilander  <wilander@apple.com>
869
870         Send delayed Ad Click Attribution conversion requests to the click source
871         https://bugs.webkit.org/show_bug.cgi?id=196838
872         <rdar://problem/47650157>
873
874         Reviewed by Chris Dumez and Youenn Fablet.
875
876         This patch adds test infrastructure to override the default behavior in
877         WebKit::NetworkAdClickAttribution.
878
879         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
880         (TestWebKitAPI::TEST):
881         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
882         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
883         (WTR::TestRunner::dumpAdClickAttribution):
884         (WTR::TestRunner::clearAdClickAttribution):
885         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
886         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
887         * WebKitTestRunner/InjectedBundle/TestRunner.h:
888         * WebKitTestRunner/TestController.cpp:
889         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
890         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
891         * WebKitTestRunner/TestController.h:
892         * WebKitTestRunner/TestInvocation.cpp:
893         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
894
895 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
896
897         [ews-app] status-bubble should display position in queue
898         https://bugs.webkit.org/show_bug.cgi?id=196607
899
900         Reviewed by Lucas Forschler.
901
902         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
903         (StatusBubble._build_bubble):
904         (StatusBubble._queue_position): Method to calculate patch's position in queue.
905
906 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
907
908         [ews-build] Do not run clean build by default on EWS builders
909         https://bugs.webkit.org/show_bug.cgi?id=196897
910
911         Reviewed by Lucas Forschler.
912
913         * BuildSlaveSupport/ews-build/steps.py:
914         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
915         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
916         untracked directories like WebKitBuild).
917         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
918         untracked files/directories (like WebKitBuild).
919
920 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
921
922         TestRunner::notifyDone() should be safely reentrant
923         https://bugs.webkit.org/show_bug.cgi?id=196898
924
925         Reviewed by Darin Adler.
926
927         It is currently possible that TestRunner::notifyDone() will call itself, since
928         notifyDone() will force a repaint, which can start executing JavaScript, which
929         may call notifyDone() again. This can lead to test failures and flakiness.
930         Fix this by setting the m_waitToDump flag before calling the dump() method.
931
932         * DumpRenderTree/mac/TestRunnerMac.mm:
933         (TestRunner::notifyDone):
934         (TestRunner::forceImmediateCompletion):
935         * DumpRenderTree/win/TestRunnerWin.cpp:
936         (TestRunner::notifyDone):
937         (TestRunner::forceImmediateCompletion):
938
939 2019-04-15  Philippe Normand  <pnormand@igalia.com>
940
941         [GTK][WPE] Add enable-media websetting
942         https://bugs.webkit.org/show_bug.cgi?id=196863
943
944         Reviewed by Michael Catanzaro.
945
946         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
947         (testWebKitSettings): Add test for the enable-media web-setting.
948
949 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
950
951         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
952         https://bugs.webkit.org/show_bug.cgi?id=196905
953         <rdar://problem/49886096>
954
955         Reviewed by Tim Horton.
956
957         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
958         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
959         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
960         delay timer, we end up with this sequence of events in the problematic (failure) case:
961
962         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
963             ...IPC from UI to web process...
964         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
965             ...IPC from web to UI process...
966         (c) [UI]    Invoke completion handler for script #1
967         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
968             ...IPC from UI to web process...
969         (e) [Web]   Evaluate script #2 in the web process
970         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
971
972         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
973         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
974         #2 is run in step (e).
975
976         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
977         the UI process by waiting on a script message posted by the web process, after attachment updates are
978         dispatched.
979
980         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
981         (TestWebKitAPI::TEST):
982
983 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
984
985         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
986         https://bugs.webkit.org/show_bug.cgi?id=196909
987
988         Reviewed by Wenson Hsieh.
989
990         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
991         (TestWebKitAPI::TEST):
992
993 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
994
995         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
996         https://bugs.webkit.org/show_bug.cgi?id=196880
997
998         Reviewed by Yusuke Suzuki.
999
1000         Add a new function for bytecode cache tests that does not forceDiskCache
1001         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1002         test added in this patch, since the code is invalid and therefore won't be
1003         cached. It should also be useful for tests that evaluate dynamically
1004         generated code.
1005
1006         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1007         * Scripts/run-jsc-stress-tests:
1008
1009 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1010
1011         Update AudioSession route sharing policy
1012         https://bugs.webkit.org/show_bug.cgi?id=196776
1013         <rdar://problem/46501611>
1014
1015         Reviewed by Jer Noble.
1016
1017         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1018         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1019         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1020         (TestWebKitAPI::TEST):
1021
1022 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1023
1024         [iOS] Software keyboard is shown too frequently on some websites
1025         https://bugs.webkit.org/show_bug.cgi?id=195856
1026         <rdar://problem/49191395>
1027
1028         Reviewed by Darin Adler.
1029
1030         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1031
1032         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1033         (WTR::UIScriptController::setHardwareKeyboardAttached):
1034         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1035         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1036         (WTR::UIScriptController::setHardwareKeyboardAttached):
1037         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1038         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1039
1040         Additionally link against GraphicsServices in WebKitTestRunner.
1041
1042         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1043         (WTR::TestController::platformResetStateToConsistentValues):
1044         (WTR::UIScriptController::setHardwareKeyboardAttached):
1045
1046 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1047
1048         [GTK][WPE] Fix pacman install-dependencies packages
1049         https://bugs.webkit.org/show_bug.cgi?id=196817
1050
1051         Reviewed by Žan Doberšek.
1052         
1053         python3-setuptools is called python-setuptools
1054         ruby-highline is only available on AUR
1055         libv4l-devel is incorporated in v4l-utils
1056
1057         * gtk/install-dependencies:
1058         * wpe/install-dependencies:
1059
1060 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1061
1062         [GTK] REGRESSION(r243860): Many tests failing
1063         https://bugs.webkit.org/show_bug.cgi?id=196791
1064
1065         Reviewed by Joanmarie Diggs.
1066
1067         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1068         multiple documents and check that accessibility hierarchy is updated after a navigation.
1069
1070         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1071         (loadChangedCallback):
1072         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1073         (AccessibilityTest::AccessibilityTest):
1074         (AccessibilityTest::~AccessibilityTest):
1075         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1076         (AccessibilityTest::findTestServerApplication):
1077         (AccessibilityTest::findDocumentWeb):
1078         (AccessibilityTest::findRootObject):
1079         (AccessibilityTest::waitUntilChildrenRemoved):
1080         (AccessibilityTest::ensureProxy):
1081         (testAtspiBasicHierarchy):
1082         (beforeAll):
1083         (afterAll):
1084
1085 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1086
1087         [ews-build] Handle bug titles with unicode characters
1088         https://bugs.webkit.org/show_bug.cgi?id=196802
1089
1090         Reviewed by Dewei Zhu.
1091
1092         * BuildSlaveSupport/ews-build/steps.py:
1093         (ValidatePatch._is_bug_closed):
1094
1095 2019-04-11  Michael Saboff  <msaboff@apple.com>
1096
1097         Improve the Inline Cache Stats code
1098         https://bugs.webkit.org/show_bug.cgi?id=196836
1099
1100         Reviewed by Saam Barati.
1101
1102         Added a new script to consolidate and arrange the output of --useICStats option.
1103
1104         This script merges the output from every group into one large table and sorts it from most common to
1105         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1106         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1107         Put together, this is useful to see what property accesses are not getting cached.
1108
1109         * Scripts/ic-stats.py: Added.
1110         (ICStats):
1111         (ICStats.__init__):
1112         (ICStats.parse):
1113         (ICStats.dumpStats):
1114         (usage):
1115
1116 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1117
1118         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1119         https://bugs.webkit.org/show_bug.cgi?id=196809
1120         <rdar://49800762>
1121
1122         Reviewed by Brady Eidson.
1123
1124         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1125         (TEST):
1126
1127 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1128
1129         requestAnimationFrame should execute before the next frame
1130         https://bugs.webkit.org/show_bug.cgi?id=177484
1131
1132         Reviewed by Simon Fraser.
1133
1134         Add trace points for the page RenderingUpdate.
1135
1136         * Tracing/SystemTracePoints.plist:
1137
1138 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1139
1140         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1141         https://bugs.webkit.org/show_bug.cgi?id=196760
1142
1143         Reviewed by Don Olmstead.
1144
1145         vswhere.exe has been bundled since Visual Studio 2017 version
1146         15.2. We shouldn't download vswhere.exe.
1147
1148         * Scripts/build-jsc: Do not call update-vswhere.py.
1149         * Scripts/build-webkit: Ditto.
1150         * Scripts/update-vswhere.py: Removed.
1151         * Scripts/webkitdirs.pm:
1152         (requireModulesForVSWhere): Deleted.
1153         (pickCurrentVisualStudioInstallation): Deleted.
1154         (visualStudioInstallDirVSWhere): Return the latest installed VS
1155         installation path by using the bundled vswhere.exe.
1156         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1157         (visualStudioInstallDirFallback): Removed.
1158
1159 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1160
1161         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1162         https://bugs.webkit.org/show_bug.cgi?id=196780
1163
1164         Reviewed by Alexey Proskuryakov.
1165
1166         * BuildSlaveSupport/ews-build/steps.py:
1167         * BuildSlaveSupport/ews-build/steps_unittest.py:
1168
1169 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1170
1171         Add SPI WKNavigationResponse._downloadAttribute
1172         https://bugs.webkit.org/show_bug.cgi?id=196755
1173         <rdar://49587365>
1174
1175         Reviewed by Brady Eidson.
1176
1177         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1178         (-[NavigationResponseTestDelegate navigationResponse]):
1179         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1180         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1181         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1182         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1183         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1184         (readRequest):
1185         (writeResponse):
1186         (TEST):
1187
1188 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1189
1190         Add modern API for overriding the page's specified viewport configuration
1191         https://bugs.webkit.org/show_bug.cgi?id=167734
1192         <rdar://problem/30331795>
1193
1194         Reviewed by Simon Fraser.
1195
1196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1197         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1198
1199 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1200
1201         Add support for incremental bytecode cache updates
1202         https://bugs.webkit.org/show_bug.cgi?id=195000
1203
1204         Reviewed by Filip Pizlo.
1205
1206         Exit when the initial run to generate bytecode fails.
1207
1208         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1209
1210 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1211
1212         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1213         https://bugs.webkit.org/show_bug.cgi?id=196744
1214         <rdar://49415309>
1215
1216         Reviewed by Chris Dumez.
1217
1218         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1219         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1220
1221 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1222
1223         Add a way to opt into modern compatibility mode in layout tests
1224         https://bugs.webkit.org/show_bug.cgi?id=196770
1225         <rdar://problem/49777550>
1226
1227         Reviewed by Antoine Quint.
1228
1229         Add a new test option to enable modern compatibility mode in layout tests.
1230
1231         * WebKitTestRunner/TestController.cpp:
1232         (WTR::updateTestOptionsFromTestHeader):
1233         * WebKitTestRunner/TestController.h:
1234         * WebKitTestRunner/TestOptions.h:
1235         (WTR::TestOptions::hasSameInitializationOptions const):
1236         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1237         (WTR::TestController::platformCreateWebView):
1238         (WTR::TestController::enableModernCompatibilityMode):
1239
1240 2019-04-10  Andy Estes  <aestes@apple.com>
1241
1242         Try to fix the 32-bit watchOS build.
1243
1244         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1245         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1246
1247 2019-04-10  Antoine Quint  <graouts@apple.com>
1248
1249         Enable Pointer Events on watchOS
1250         https://bugs.webkit.org/show_bug.cgi?id=196771
1251         <rdar://problem/49040909>
1252
1253         Reviewed by Dean Jackson.
1254
1255         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1256
1257 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1258
1259         Unreviewed. Fix WPE accessibility tests after r244059.
1260
1261         We are failing to load the injected bundle due to undefined symbol
1262         AccessibilityUIElement::replaceTextInRange().
1263
1264         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1265         (WTR::AccessibilityUIElement::replaceTextInRange):
1266
1267 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1268
1269         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1270         https://bugs.webkit.org/show_bug.cgi?id=196727
1271
1272         Reviewed by Fujii Hironori.
1273
1274         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1275         (WebKitBrowserWindow::create):
1276
1277 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1278
1279         [ews-build] Add unit tests for PrintConfiguration
1280         https://bugs.webkit.org/show_bug.cgi?id=196752
1281
1282         Reviewed by Dewei Zhu.
1283
1284         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1285
1286 2019-04-09  Keith Rollin  <krollin@apple.com>
1287
1288         Unreviewed build maintenance -- update .xcfilelists.
1289
1290         * DumpRenderTree/DerivedSources-input.xcfilelist:
1291         * DumpRenderTree/DerivedSources-output.xcfilelist:
1292
1293 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1294
1295         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1296         https://bugs.webkit.org/show_bug.cgi?id=196743
1297         <rdar://problem/43897551>
1298
1299         Reviewed by Tim Horton.
1300
1301         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1302         (TEST):
1303
1304 2019-04-09  Youenn Fablet  <youenn@apple.com>
1305
1306         Close service worker database on network process suspension
1307         https://bugs.webkit.org/show_bug.cgi?id=196623
1308         <rdar://problem/48930869>
1309
1310         Reviewed by Alex Christensen.
1311
1312         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1313
1314 2019-04-09  Daniel Bates  <dabates@apple.com>
1315
1316         [iPad] Should open popover when the spacebar is pressed
1317         https://bugs.webkit.org/show_bug.cgi?id=196360
1318         <rdar://problem/49389129>
1319
1320         Reviewed by Brent Fulgham.
1321
1322         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1323
1324         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1325         (WTR::UIScriptController::isShowingPopover const): Added.
1326         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1327         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1328         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1329         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1330         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1331         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1332         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1333         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1334         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1335         (WTR::UIScriptController::isShowingPopover const): Added.
1336         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1337         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1338         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1339         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1340         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1341         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1342         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1343         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1344         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1345         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1346         (WTR::UIScriptController::isShowingPopover const): Added.
1347         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1348         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1349
1350 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1351
1352         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1353         https://bugs.webkit.org/show_bug.cgi?id=196665
1354         <rdar://45115669>
1355
1356         Reviewed by Geoff Garen.
1357
1358         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1359         (goBack):
1360         (+[SimpleLookupContext sharedLookupContext]):
1361         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1362         (TEST):
1363         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1364         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1365
1366 2019-04-09  John Wilander  <wilander@apple.com>
1367
1368         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1369         https://bugs.webkit.org/show_bug.cgi?id=196558
1370         <rdar://problem/47650245>
1371
1372         Reviewed by Youenn Fablet.
1373
1374         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1375         (TestWebKitAPI::TEST):
1376             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1377
1378 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1379
1380         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1381         https://bugs.webkit.org/show_bug.cgi?id=196720
1382
1383         Reviewed by Konstantin Tokarev.
1384
1385         * TestWebKitAPI/PlatformMac.cmake:
1386
1387 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1388
1389         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1390         https://bugs.webkit.org/show_bug.cgi?id=196694
1391         <rdar://problem/48388734>
1392
1393         Rubber-stamped by Aakash Jain.
1394
1395         * Scripts/webkitpy/port/image_diff.py:
1396         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1397         * Scripts/webkitpy/port/server_process.py:
1398         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1399         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1400         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1401         * Scripts/webkitpy/port/server_process_mock.py:
1402         (MockServerProcess.has_available_stdout):
1403         * Scripts/webkitpy/port/server_process_unittest.py:
1404         (TestServerProcess.serial_test_basic):
1405
1406 2019-04-09  Jer Noble  <jer.noble@apple.com>
1407
1408         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1409         https://bugs.webkit.org/show_bug.cgi?id=196097
1410
1411         Reviewed by Eric Carlson.
1412
1413         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1414
1415         * DumpRenderTree/mac/DumpRenderTree.mm:
1416         (resetWebPreferencesToConsistentValues):
1417         * WebKitTestRunner/TestController.cpp:
1418         (WTR::TestController::resetPreferencesToConsistentValues):
1419
1420 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1421
1422         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1423         https://bugs.webkit.org/show_bug.cgi?id=196690
1424
1425         Reviewed by Michael Catanzaro.
1426
1427         * QueueStatusServer/config/queues.py:
1428         * Scripts/webkitpy/common/config/ews.json:
1429         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1430         (test_ews_name):
1431
1432 2019-04-09  Chris Dumez  <cdumez@apple.com>
1433
1434         Loads using loadHTMLString() cause flashing when process-swapping
1435         https://bugs.webkit.org/show_bug.cgi?id=196714
1436         <rdar://problem/49637354>
1437
1438         Reviewed by Antti Koivisto.
1439
1440         Add API test coverage.
1441
1442         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1443
1444 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1445
1446         Unreviewed. Fix ATK accessibility tests after r244059.
1447
1448         We are failing to load the injected bundle due to undefined symbol
1449         AccessibilityUIElement::replaceTextInRange().
1450
1451         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1452         (WTR::AccessibilityUIElement::replaceTextInRange):
1453
1454 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1455
1456         AX: Support API: accessibilityReplaceRange:withText
1457         https://bugs.webkit.org/show_bug.cgi?id=196636
1458
1459         Unreviewed build fix for Windows port.
1460
1461         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1462         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1463
1464 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1465
1466         [CMake][WinCairo] Separate copied headers into different directories
1467         https://bugs.webkit.org/show_bug.cgi?id=196655
1468
1469         Reviewed by Michael Catanzaro.
1470
1471         * DumpRenderTree/CMakeLists.txt:
1472         * MiniBrowser/win/CMakeLists.txt:
1473         * TestWebKitAPI/CMakeLists.txt:
1474         * TestWebKitAPI/PlatformWin.cmake:
1475
1476 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1477
1478         Log stack-trace for run-webkit-tests when interrupted
1479         https://bugs.webkit.org/show_bug.cgi?id=176393
1480         <rdar://problem/34262310>
1481
1482         Reviewed by Lucas Forschler.
1483
1484         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1485         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1486         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1487         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1488         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1489         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1490         (main): Set handlers to log stack trace on interruption.
1491
1492 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1493
1494         AX: Support API: accessibilityReplaceRange:withText
1495         https://bugs.webkit.org/show_bug.cgi?id=196636
1496
1497         Unreviewed build fix for Windows port.
1498
1499         * DumpRenderTree/AccessibilityUIElement.cpp:
1500         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1501
1502 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1503
1504         [ews-build] Scripts using Buildbot API have CORS error
1505         https://bugs.webkit.org/show_bug.cgi?id=196709
1506
1507         Reviewed by Alexey Proskuryakov.
1508
1509         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1510
1511 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1512
1513         AX: Support API: accessibilityReplaceRange:withText
1514         https://bugs.webkit.org/show_bug.cgi?id=196636
1515
1516         Reviewed by Daniel Bates.
1517
1518         * DumpRenderTree/AccessibilityUIElement.cpp:
1519         (replaceTextInRangeCallback):
1520         (AccessibilityUIElement::replaceTextInRange):
1521         (AccessibilityUIElement::getJSClass):
1522         * DumpRenderTree/AccessibilityUIElement.h:
1523         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1524         (AccessibilityUIElement::replaceTextInRange):
1525         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1526         (AccessibilityUIElement::replaceTextInRange):
1527         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1528         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1529         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1530         (WTR::AccessibilityUIElement::replaceTextInRange):
1531         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1532         (WTR::AccessibilityUIElement::replaceTextInRange):
1533
1534 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1535
1536         [iOS] Do not allow starting selection drags when selection views are not visible
1537         https://bugs.webkit.org/show_bug.cgi?id=196686
1538         <rdar://problem/49399192>
1539
1540         Reviewed by Tim Horton.
1541
1542         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1543         also add some new API tests to cover scenarios where the web view is not first responder.
1544
1545         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1546         (TestWebKitAPI::TEST):
1547         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1548
1549         Add a switch to optionally make the web view first responder when starting the simulated drag.
1550
1551         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1552         (-[DragAndDropSimulator initWithWebView:]):
1553         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1554
1555 2019-04-08  Justin Fan  <justin_fan@apple.com>
1556
1557         [Web GPU] Fix Web GPU experimental feature on iOS
1558         https://bugs.webkit.org/show_bug.cgi?id=196632
1559
1560         Reviewed by Myles C. Maxfield.
1561
1562         Properly make Web GPU available on iOS 11+.
1563
1564         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1565
1566 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1567
1568         [ews-build] Do not upload archive when Compile Fails
1569         https://bugs.webkit.org/show_bug.cgi?id=196674
1570
1571         Reviewed by Alexey Proskuryakov.
1572
1573         * BuildSlaveSupport/ews-build/factories.py:
1574         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1575         * BuildSlaveSupport/ews-build/steps.py:
1576         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1577         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1578         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1579
1580 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1581
1582         Enable DFG on MIPS
1583         https://bugs.webkit.org/show_bug.cgi?id=196689
1584
1585         Reviewed by Žan Doberšek.
1586
1587         Since the bytecode change, we enabled the baseline JIT on mips in
1588         r240432, but DFG is still missing. With this change, all tests are
1589         passing on a ci20 board.
1590
1591         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1592
1593 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1594
1595         [Flatpak] Second run update-webkitwpe-flatpak fails
1596         https://bugs.webkit.org/show_bug.cgi?id=192702
1597
1598         Reviewed by Carlos Garcia Campos.
1599
1600         * flatpak/flatpakutils.py:
1601         (FlatpakObject.flatpak): Fix typo.
1602         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1603         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1604
1605 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1606
1607         [GTK][WPE] outlook.live.com displays old-fashioned UI
1608         https://bugs.webkit.org/show_bug.cgi?id=196642
1609
1610         Reviewed by Carlos Garcia Campos.
1611
1612         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1613         (TestWebKitAPI::TEST): New Mac platform quirk test.
1614
1615 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1616
1617         Unreviewed, rolling out r243956.
1618         https://bugs.webkit.org/show_bug.cgi?id=196688
1619
1620         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1621         by aakashjain on #webkit).
1622
1623         Reverted changeset:
1624
1625         "Clicking "Go Back" from a safe browsing warning from an
1626         iframe should navigate the WKWebView back to the previous
1627         page"
1628         https://bugs.webkit.org/show_bug.cgi?id=196665
1629         https://trac.webkit.org/changeset/243956
1630
1631 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1632
1633         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1634         https://bugs.webkit.org/show_bug.cgi?id=196669
1635
1636         Reviewed by Geoffrey Garen.
1637
1638         Added three new unit tests for WeakHashSet.
1639
1640         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1641         (WTF_WeakPtr.WeakHashSetConstObjects):
1642         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1643         (WTF_WeakPtr.WeakHashSetComputeSize):
1644
1645 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1646
1647         Hide next and previous form control buttons when WKWebView is editable
1648         https://bugs.webkit.org/show_bug.cgi?id=196672
1649         <rdar://problem/35625321>
1650
1651         Reviewed by Tim Horton.
1652
1653         Add a new API test.
1654
1655         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1656         (-[TestWKWebView lastTrailingBarButtonGroup]):
1657         (TestWebKitAPI::TEST):
1658         * TestWebKitAPI/ios/UIKitSPI.h:
1659
1660 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1661
1662         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1663         https://bugs.webkit.org/show_bug.cgi?id=196077
1664         <rdar://problem/49108202>
1665
1666         Reviewed by Chris Dumez.
1667
1668         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1669         on new web view.
1670
1671         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1672
1673 2019-04-05  Saam Barati  <sbarati@apple.com>
1674
1675         Make compare-results understand MotionMark
1676         https://bugs.webkit.org/show_bug.cgi?id=196666
1677
1678         Reviewed by Yusuke Suzuki.
1679
1680         * Scripts/compare-results:
1681         (PLT5Results):
1682         (detectMotionMark):
1683         (detectMotionMark1_1):
1684         (motionMarkResults):
1685         (motionMark1_1Results):
1686         (detectBenchmark):
1687         (biggerIsBetter):
1688         (main):
1689
1690 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1691
1692         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1693         https://bugs.webkit.org/show_bug.cgi?id=196665
1694         <rdar://45115669>
1695
1696         Reviewed by Geoff Garen.
1697
1698         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1699         (goBack):
1700         (+[SimpleLookupContext sharedLookupContext]):
1701         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1702         (TEST):
1703         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1704         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1705
1706 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1707
1708         [ews-build] Add configuration and architecture for windows builders
1709         https://bugs.webkit.org/show_bug.cgi?id=196660
1710
1711         Reviewed by Lucas Forschler.
1712
1713         * BuildSlaveSupport/ews-build/config.json:
1714
1715 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1716
1717         webkitpy: Don't run subsequent rounds if interrupted
1718         https://bugs.webkit.org/show_bug.cgi?id=196646
1719
1720         Reviewed by Aakash Jain.
1721
1722         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1723         (Manager.run): Bail out if interrupted.
1724
1725 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1726
1727         Test sessionStorage in PSON private browsing mode
1728         https://bugs.webkit.org/show_bug.cgi?id=196561
1729
1730         Reviewed by Alex Christensen.
1731
1732         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1733
1734 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1735
1736         Unreviewed, rolling out r243833.
1737         https://bugs.webkit.org/show_bug.cgi?id=196645
1738
1739         This change breaks build of WPE and GTK ports (Requested by
1740         annulen on #webkit).
1741
1742         Reverted changeset:
1743
1744         "[CMake][WTF] Mirror XCode header directories"
1745         https://bugs.webkit.org/show_bug.cgi?id=191662
1746         https://trac.webkit.org/changeset/243833
1747
1748 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1749
1750         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1751         https://bugs.webkit.org/show_bug.cgi?id=196635
1752
1753         Reviewed by Antti Koivisto.
1754         
1755         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1756         for a test to enable async frame scrolling via:
1757             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1758         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1759         
1760         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1761
1762         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1763         (WTR::InjectedBundle::beginTesting):
1764         * WebKitTestRunner/TestController.cpp:
1765         (WTR::TestController::resetPreferencesToConsistentValues):
1766
1767 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1768
1769         Use a correct LC_RPATH when building with ASan
1770         https://bugs.webkit.org/show_bug.cgi?id=196576
1771
1772         Reviewed by David Kilzer.
1773
1774         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1775         so that ../Frameworks is checked. This is simpler and more reliable than updating
1776         each SPC service xcconfig.
1777
1778 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1779
1780         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1781         https://bugs.webkit.org/show_bug.cgi?id=196629
1782
1783         Reviewed by Lucas Forschler.
1784
1785         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1786
1787 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1788
1789         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1790         https://bugs.webkit.org/show_bug.cgi?id=196618
1791
1792         Reviewed by Lucas Forschler.
1793
1794         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1795         (StatusBubble): Added QUEUE_TRIGGERS.
1796         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1797         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1798         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1799         its parent(builder).
1800
1801 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1802
1803         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1804         https://bugs.webkit.org/show_bug.cgi?id=196625
1805
1806         Reviewed by Lucas Forschler.
1807
1808         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1809         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1810
1811 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1812
1813         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1814         https://bugs.webkit.org/show_bug.cgi?id=196630
1815
1816         Reviewed by Wenson Hsieh.
1817
1818         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1819
1820 2019-04-04  Youenn Fablet  <youenn@apple.com>
1821
1822         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1823         https://bugs.webkit.org/show_bug.cgi?id=196543
1824
1825         Reviewed by Alex Christensen.
1826
1827         * WebKitTestRunner/TestController.cpp:
1828         (WTR::TestController::generatePageConfiguration):
1829
1830 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1831
1832         [ews-app] Status bubble should not display skipped buildbot steps
1833         https://bugs.webkit.org/show_bug.cgi?id=196584
1834
1835         Reviewed by Lucas Forschler.
1836
1837         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1838
1839 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1840
1841         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1842         https://bugs.webkit.org/show_bug.cgi?id=196620
1843
1844         Reviewed by Lucas Forschler.
1845
1846         * BuildSlaveSupport/ews-app/ews/config.py:
1847
1848 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1849
1850         [Win] DumpRenderTreeWatchDog.py is not checked into source
1851         https://bugs.webkit.org/show_bug.cgi?id=196567
1852         <rdar://problem/49525901>
1853
1854         Reviewed by Lucas Forschler.
1855
1856         This script is used on Win EWS bots to terminate hanging DRT processes.
1857
1858         * EWSTools/dumprendertreewatchdog.py: Added.
1859
1860 2019-04-04  Chris Dumez  <cdumez@apple.com>
1861
1862         Unreviewed, roll out r243858 which made tests time out.
1863
1864         Disable new API tests on Windows instead.
1865
1866         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1867         (TestWebKitAPI::TEST):
1868
1869 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1870
1871         [ATK] Cleanup WebPageAccessibilityObjectAtk
1872         https://bugs.webkit.org/show_bug.cgi?id=196537
1873
1874         Reviewed by Michael Catanzaro.
1875
1876         Also consider files under atk directories as exceptions for GObject conventions.
1877
1878         * Scripts/webkitpy/style/checkers/cpp.py:
1879         (check_identifier_name_in_declaration):
1880
1881 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1882
1883         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1884         https://bugs.webkit.org/show_bug.cgi?id=196588
1885         <rdar://problem/49365787>
1886
1887         Unreviewed build fix for Windows port.
1888
1889         error C3861: 'kill': identifier not found
1890
1891         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1892         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1893
1894 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1895
1896         [ews-build] Cancel build and similar operations should have authentication
1897         https://bugs.webkit.org/show_bug.cgi?id=196520
1898
1899         Reviewed by Dewei Zhu.
1900
1901         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1902         environment variables.
1903
1904 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1905
1906         [ews-build] Do not trigger queues which are not in production yet
1907         https://bugs.webkit.org/show_bug.cgi?id=196581
1908
1909         Reviewed by Dewei Zhu.
1910
1911         * BuildSlaveSupport/ews-build/config.json:
1912
1913 2019-04-03  Chris Dumez  <cdumez@apple.com>
1914
1915         Unreviewed, fix typo in the name of API test added in r243848.
1916
1917         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1918         (TestWebKitAPI::TEST):
1919
1920 2019-04-03  Chris Dumez  <cdumez@apple.com>
1921
1922         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1923         https://bugs.webkit.org/show_bug.cgi?id=196588
1924         <rdar://problem/49365787>
1925
1926         Reviewed by Ryosuke Niwa.
1927
1928         Add API test coverage.
1929
1930         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1931         (TestWebKitAPI::nullJavaScriptCallback):
1932         (TestWebKitAPI::didCrashCheckFrames):
1933         (TestWebKitAPI::TEST):
1934
1935 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1936
1937         run-webkit-tests: Upload test results (new results database)
1938         https://bugs.webkit.org/show_bug.cgi?id=196577
1939         <rdar://problem/34841155>
1940
1941         Reviewed by Lucas Forschler.
1942
1943         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1944         (Manager.run): Upload results after each device shard, since the configuration will be
1945         different for each device.
1946         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1947         uploaded to a results database.
1948         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1949         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1950
1951 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1952
1953         -apple-trailing-word is needed for browser detection
1954         https://bugs.webkit.org/show_bug.cgi?id=196575
1955
1956         Unreviewed.
1957
1958         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1959
1960 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1961
1962         [CMake][WTF] Mirror XCode header directories
1963         https://bugs.webkit.org/show_bug.cgi?id=191662
1964
1965         Reviewed by Konstantin Tokarev.
1966
1967         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1968         builds.
1969
1970         * CMakeLists.txt:
1971         * DumpRenderTree/CMakeLists.txt:
1972         * DumpRenderTree/PlatformWin.cmake:
1973         * MiniBrowser/win/CMakeLists.txt:
1974         * TestWebKitAPI/CMakeLists.txt:
1975         * TestWebKitAPI/PlatformWin.cmake:
1976         * WebKitTestRunner/PlatformGTK.cmake:
1977         * WebKitTestRunner/PlatformWin.cmake:
1978
1979 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1980
1981         [ews-app] Status bubble should not display certain infrastructure status messages
1982         https://bugs.webkit.org/show_bug.cgi?id=196550
1983
1984         Reviewed by Lucas Forschler.
1985
1986         Do not display the steps which are un-needed for end-user. This information is still avaiable
1987         if the user click on the bubble and look at the Buildbot build.
1988         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1989         (StatusBubble._steps_messages):
1990         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1991
1992 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1993
1994         [ews-build] Use https for sending data to ews-app
1995         https://bugs.webkit.org/show_bug.cgi?id=196492
1996
1997         Reviewed by Lucas Forschler.
1998
1999         * BuildSlaveSupport/ews-build/events.py:
2000
2001 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2002
2003         Remove support for -apple-trailing-word
2004         https://bugs.webkit.org/show_bug.cgi?id=196525
2005
2006         Reviewed by Zalan Bujtas.
2007
2008         This CSS property is nonstandard and not used.
2009
2010         * Scripts/webkitperl/FeatureList.pm:
2011         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2012
2013 2019-04-03  Youenn Fablet  <youenn@apple.com>
2014
2015         Add a test for DOMCache on multiple browsing in case of private browsing
2016         https://bugs.webkit.org/show_bug.cgi?id=196524
2017
2018         Reviewed by Alex Christensen.
2019
2020         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2021         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2022
2023 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2024
2025         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2026         https://bugs.webkit.org/show_bug.cgi?id=196540
2027
2028         Reviewed by Aakash Jain.
2029
2030         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2031
2032 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2033
2034         Add plumbing for a compatibility mode preference in WebKit
2035         https://bugs.webkit.org/show_bug.cgi?id=196005
2036
2037         Reviewed by Tim Horton.
2038
2039         Add new API tests.
2040
2041         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2042         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2043
2044 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2045
2046         [WPE][GTK] Update libsrtp dependency package for Debian
2047         https://bugs.webkit.org/show_bug.cgi?id=196528
2048
2049         Reviewed by Frédéric Wang.
2050
2051         * gtk/install-dependencies:
2052         * wpe/install-dependencies:
2053
2054 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2055
2056         [WK2] Add support for Window's beforeprint / afterprint events
2057         https://bugs.webkit.org/show_bug.cgi?id=196478
2058         <rdar://problem/49535124>
2059
2060         Unreviewed build fix for MSVC.
2061
2062         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2063
2064         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2065
2066         * WebKitTestRunner/TestController.cpp:
2067         (WTR::printFrame): Use int and float literals.
2068
2069 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2070
2071         [ews-build] Reassign bots to queues
2072
2073         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2074
2075 2019-04-02  Chris Dumez  <cdumez@apple.com>
2076
2077         [WK2] Add support for Window's beforeprint / afterprint events
2078         https://bugs.webkit.org/show_bug.cgi?id=196478
2079
2080         Reviewed by Alex Christensen.
2081
2082         Add minimal implementation for printFrame in WebKitTestRunner.
2083
2084         * WebKitTestRunner/TestController.cpp:
2085         (WTR::printFrame):
2086         (WTR::TestController::createOtherPage):
2087         (WTR::TestController::createWebViewWithOptions):
2088
2089 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2090
2091         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2092         https://bugs.webkit.org/show_bug.cgi?id=196491
2093
2094         Reviewed by Lucas Forschler.
2095
2096         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2097
2098 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2099
2100         [ews-build] Configure buildbot try credentials in environment variables
2101         https://bugs.webkit.org/show_bug.cgi?id=196501
2102
2103         Reviewed by Lucas Forschler.
2104
2105         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2106         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2107         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2108
2109 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2110
2111         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2112         https://bugs.webkit.org/show_bug.cgi?id=196496
2113         <rdar://problem/49521634>
2114
2115         Reviewed by Chris Dumez.
2116
2117         Add new API tests (see WebKit ChangeLog for more detail).
2118
2119         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2120         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2121         (TEST):
2122
2123 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2124
2125         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2126         <https://webkit.org/b/196499>
2127
2128         Reviewed by Alexey Proskuryakov.
2129
2130         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2131         ENABLE_ADDRESS_SANITIZER.
2132
2133 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2134
2135         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2136         https://bugs.webkit.org/show_bug.cgi?id=182757
2137
2138         Reviewed by Don Olmstead.
2139
2140         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2141         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2142
2143 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2144
2145         run-api-tests: Upload test results
2146         https://bugs.webkit.org/show_bug.cgi?id=196323
2147         <rdar://problem/49356714>
2148
2149         Reviewed by Lucas Forschler.
2150
2151         * Scripts/webkitpy/api_tests/manager.py:
2152         (Manager):
2153         (Manager.run): Upload results to a results database.
2154         * Scripts/webkitpy/api_tests/run_api_tests.py:
2155         (parse_args): Add upload arguments.
2156         * Scripts/webkitpy/port/base.py:
2157         (Port):
2158         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2159         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2160         with commits from any other associated repositories.
2161         * Scripts/webkitpy/port/device.py:
2162         (Device):
2163         (Device.build_version): Access build_versoin of underlying platform device.
2164         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2165         (IOSSimulatorTest):
2166         (IOSSimulatorTest.test_configuration_for_upload):
2167         * Scripts/webkitpy/port/device_port.py:
2168         (DevicePort):
2169         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2170         the same as the machine uploading results.
2171         * Scripts/webkitpy/port/mac.py:
2172         (MacPort):
2173         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2174         * Scripts/webkitpy/port/mac_unittest.py:
2175         (MacTest):
2176         (MacTest.test_configuration_for_upload):
2177         * Scripts/webkitpy/xcode/simulated_device.py:
2178         (SimulatedDeviceManager._create_device_with_runtime):
2179         (SimulatedDevice.__init__): Create simulated device with a build_version.
2180         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2181         (test_existing_simulator):
2182
2183 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2184
2185         Remove extra newline characters (Follow-up fix to r243707)
2186
2187         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2188
2189 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2190
2191         [ews-app] Use API_KEY to accept results data
2192         https://bugs.webkit.org/show_bug.cgi?id=196461
2193
2194         Reviewed by Dewei Zhu.
2195
2196         * BuildSlaveSupport/ews-app/ews/views/results.py:
2197         (Results.post): Validate EWS_API_KEY before accepting any data.
2198         * BuildSlaveSupport/ews-build/events.py:
2199         (Events.sendData): Send EWS_API_KEY if available along with event data.
2200
2201 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2202
2203         Unable to copy and paste a PDF from Notes into Mail compose body
2204         https://bugs.webkit.org/show_bug.cgi?id=196442
2205         <rdar://problem/48573098>
2206
2207         Reviewed by Tim Horton.
2208
2209         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2210         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2211         to be specified on the item providers.
2212
2213         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2214         (TestWebKitAPI::mapItemForTesting):
2215         (TestWebKitAPI::contactItemForTesting):
2216
2217 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2218
2219         Make UIWKDocumentContext rects per-character instead of per-word
2220         https://bugs.webkit.org/show_bug.cgi?id=196459
2221
2222         Reviewed by Wenson Hsieh.
2223
2224         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2225         (TEST):
2226         Adjust test results due to switching to per-character rects.
2227
2228 2019-04-01  Chris Dumez  <cdumez@apple.com>
2229
2230         UIProcess crash when a prewarmed process is terminated
2231         https://bugs.webkit.org/show_bug.cgi?id=196451
2232         <rdar://problem/49245471>
2233
2234         Reviewed by Geoffrey Garen.
2235
2236         Add API test coverage.
2237
2238         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2239         (TEST):
2240
2241 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2242
2243         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2244         https://bugs.webkit.org/show_bug.cgi?id=196449
2245
2246         Reviewed by Lucas Forschler.
2247
2248         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2249         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2250         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2251         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2252
2253 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2254
2255         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2256         https://bugs.webkit.org/show_bug.cgi?id=196444
2257
2258         Reviewed by Lucas Forschler.
2259
2260         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2261
2262 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2263
2264         Add SPI to canonicalize NSURLs with WTF::URL
2265         https://bugs.webkit.org/show_bug.cgi?id=196415
2266         <rdar://problem/44980271>
2267
2268         Reviewed by Darin Adler.
2269
2270         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2271         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2272         (TestWebKitAPI::TEST):
2273
2274 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2275
2276         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2277         https://bugs.webkit.org/show_bug.cgi?id=196441
2278
2279         Reviewed by Carlos Garcia Campos.
2280
2281         Don't cache the wpe_view_backend object that might not exist yet at the
2282         time of EventSenderProxy constructor invocation, but instead retrieve
2283         that object whenever it's required for event dispatching. This should
2284         avoid crashes in this constructor now that it's invoked before any
2285         PlatformWindow has been set up (as changed in r243496).
2286
2287         * WebKitTestRunner/EventSenderProxy.h:
2288         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2289         (WTR::viewBackend):
2290         (WTR::EventSenderProxy::EventSenderProxy):
2291         (WTR::EventSenderProxy::mouseDown):
2292         (WTR::EventSenderProxy::mouseUp):
2293         (WTR::EventSenderProxy::mouseMoveTo):
2294         (WTR::EventSenderProxy::mouseScrollBy):
2295         (WTR::EventSenderProxy::keyDown):
2296         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2297
2298 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2299
2300         [Win][WebKit] MiniBrowser should support high DPI display
2301         https://bugs.webkit.org/show_bug.cgi?id=196391
2302
2303         Reviewed by Alex Christensen.
2304
2305         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2306         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2307         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2308         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2309
2310 2019-03-31  Sam Weinig  <weinig@apple.com>
2311
2312         Remove more i386 specific configurations
2313         https://bugs.webkit.org/show_bug.cgi?id=196430
2314
2315         Reviewed by Alexey Proskuryakov.
2316
2317         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2318         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2319
2320 2019-03-31  Andy Estes  <aestes@apple.com>
2321
2322         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2323         https://bugs.webkit.org/show_bug.cgi?id=196433
2324         <rdar://problem/49293305>
2325
2326         Reviewed by Tim Horton.
2327
2328         Enhanced API test coverage to include all navigation response policy decisions in both
2329         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2330
2331         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2332         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2333         (TestWebKitAPI::TEST):
2334         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2335         (readFile):
2336         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2337         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2338         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2339         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2340         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2341         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2342         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2343         (-[QuickLookDelegate _downloadDidStart:]):
2344         (-[QuickLookDelegate _download:didReceiveResponse:]):
2345         (-[QuickLookDelegate _download:didReceiveData:]):
2346         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2347         (-[QuickLookDelegate _downloadDidFinish:]):
2348         (-[QuickLookDelegate _download:didFailWithError:]):
2349         (-[QuickLookDelegate _downloadDidCancel:]):
2350         (-[QuickLookDelegate verifyDownload]):
2351         (runTest):
2352         (runTestDecideBeforeLoading):
2353         (runTestDecideAfterLoading):
2354         (TEST):
2355         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2356         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2357         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2358         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2359         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2360         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2361         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2362         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2363         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2364         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2365         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2366         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2367         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2368         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2369
2370 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2371
2372         [CMake] add testdfg as target with build-jsc
2373         https://bugs.webkit.org/show_bug.cgi?id=196393
2374
2375         Reviewed by Saam Barati.
2376
2377         Added testdfg as one of the targets to build when
2378         using CMake.
2379
2380         * Scripts/build-jsc:
2381
2382 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2383
2384         Delete WebMetal implementation in favor of WebGPU
2385         https://bugs.webkit.org/show_bug.cgi?id=195418
2386
2387         Reviewed by Dean Jackson.
2388
2389         * DumpRenderTree/mac/DumpRenderTree.mm:
2390         (enableExperimentalFeatures):
2391         (resetWebPreferencesToConsistentValues):
2392         * Scripts/webkitperl/FeatureList.pm:
2393         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2394         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2395         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2396         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2397         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2398         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2399         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2400         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2401         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2402         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2403         (WTR::InjectedBundle::beginTesting):
2404         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2405         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2406         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2407
2408 2019-03-29  Chris Dumez  <cdumez@apple.com>
2409
2410         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2411         https://bugs.webkit.org/show_bug.cgi?id=196405
2412         <rdar://problem/49428130>
2413
2414         Reviewed by Wenson Hsieh.
2415
2416         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2417         the popover presentation methods to be no-ops. Use this in the new test added in
2418         r243523 so that we do not swizzle those methods for all tests. This is needed because
2419         those WatchOS tests rely on the popover getting presented and interactive.
2420
2421         * WebKitTestRunner/TestController.cpp:
2422         (WTR::updateTestOptionsFromTestHeader):
2423         * WebKitTestRunner/TestController.h:
2424         * WebKitTestRunner/TestOptions.h:
2425         (WTR::TestOptions::hasSameInitializationOptions const):
2426         * WebKitTestRunner/ios/TestControllerIOS.mm:
2427         (WTR::TestController::platformInitialize):
2428         (WTR::TestController::platformResetStateToConsistentValues):
2429
2430 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2431
2432         [Curl] Add Server Trust Evaluation Support.
2433         https://bugs.webkit.org/show_bug.cgi?id=191646
2434
2435         Reviewed by Fujii Hironori.
2436
2437         Implemented MiniBrowser UI for asking if user trusts the server.
2438
2439         * MiniBrowser/win/Common.cpp:
2440         (askServerTrustEvaluation):
2441         (replaceString):
2442         * MiniBrowser/win/Common.h:
2443         * MiniBrowser/win/MiniBrowserLib.rc:
2444         * MiniBrowser/win/MiniBrowserLibResource.h:
2445         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2446         (createPEMString):
2447         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2448         (WebKitBrowserWindow::canTrustServerCertificate):
2449         * MiniBrowser/win/WebKitBrowserWindow.h:
2450
2451 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2452
2453         Implement ResizeObserver.
2454         https://bugs.webkit.org/show_bug.cgi?id=157743
2455
2456         Reviewed by Simon Fraser.
2457
2458         Support resizeObserverEnabled webPreferences.
2459
2460         * DumpRenderTree/TestOptions.cpp:
2461         (TestOptions::TestOptions):
2462         * DumpRenderTree/TestOptions.h:
2463         * DumpRenderTree/mac/DumpRenderTree.mm:
2464         (setWebPreferencesForTestOptions):
2465         * DumpRenderTree/win/DumpRenderTree.cpp:
2466         (enableExperimentalFeatures):
2467         * Scripts/webkitperl/FeatureList.pm:
2468         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2469
2470 2019-03-28  John Wilander  <wilander@apple.com>
2471
2472         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2473         https://bugs.webkit.org/show_bug.cgi?id=196281
2474         <rdar://problem/48938748>
2475
2476         Reviewed by Alex Christensen.
2477
2478         This patch adds the function isStatisticsHasLocalStorage() to the
2479         TestRunner. With it, the page can query the WebsiteDataStore in the
2480         UI process to make sure that it sees LocalStorage.
2481
2482         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2483         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2484         (WTR::TestRunner::isStatisticsHasLocalStorage):
2485         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2486         * WebKitTestRunner/TestController.cpp:
2487         (WTR::TestController::isStatisticsHasLocalStorage):
2488         * WebKitTestRunner/TestController.h:
2489         * WebKitTestRunner/TestInvocation.cpp:
2490         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2491
2492 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2493
2494         API::Data::createWithoutCopying should do a null check before calling CFRelease
2495         https://bugs.webkit.org/show_bug.cgi?id=196276
2496         <rdar://problem/48059859>
2497
2498         Reviewed by Alex Christensen.
2499
2500         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2501
2502         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2503         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2504         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2505         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2506         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2507         (TestWebKitAPI::TEST):
2508
2509 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2510
2511         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2512         https://bugs.webkit.org/show_bug.cgi?id=186276
2513
2514         Reviewed by Carlos Garcia Campos.
2515
2516         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2517         (webViewLoadChanged):
2518         (testWebResourceGetDataError):
2519         (testWebResourceGetDataEmpty):
2520         (beforeAll):
2521         (webViewloadChanged): Deleted.
2522
2523 2019-03-27  Andy Estes  <aestes@apple.com>
2524
2525         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2526         https://bugs.webkit.org/show_bug.cgi?id=196317
2527
2528         Reviewed by Dan Bernstein.
2529
2530         package-root copies built products into a staging directory using ditto(1), which does not
2531         follow symbolic links as it traverses a directory. Now that the files in
2532         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2533         itself, these become broken links when ditto'd into the staging directory.
2534
2535         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2536
2537         * Scripts/package-root:
2538
2539 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2540
2541         [ews-app] Update display text of Submit for ews analysis
2542         https://bugs.webkit.org/show_bug.cgi?id=196309
2543
2544         Reviewed by Dewei Zhu.
2545
2546         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2547
2548 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2549
2550         run-webkit-tests should check for leaks in WebKit processes
2551         <https://webkit.org/b/193772>
2552         <rdar://problem/46526680>
2553
2554         Reviewed by Ryosuke Niwa.
2555
2556         This works by doing the following:
2557         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2558           The list of child processes are returned one per line:
2559           process.name: pid
2560         - Run the "#LIST CHILD PROCESSES" command just before the
2561           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2562           processes on the ServerProcess object.
2563         - When the `--leaks` switch is handled, run check_for_leaks() on
2564           each child process after the main test harness.
2565
2566         * DumpRenderTree/mac/DumpRenderTree.mm:
2567         (handleControlCommand):
2568         - Use strncmp() instead of strcmp().
2569         - Add support for handling "#LIST CHILD PROCESSES" command.
2570
2571         * Scripts/webkitpy/port/base.py:
2572         (Port.check_for_leaks):
2573         * Scripts/webkitpy/port/darwin.py:
2574         (DarwinPort.check_for_leaks):
2575         - Rename redundant 'process_pid' argument to 'process_id'.
2576
2577         * Scripts/webkitpy/port/driver.py:
2578         (Driver.do_post_tests_work):
2579         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2580           longer the only command this sends to WebKitTestRunner.
2581         - If the `--leaks` switch is present, send the
2582           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2583           result using Port.set_webkit_processes().
2584         (Driver._parse_child_processes_output):
2585         - Add helper method to parse list of child process names and
2586           process IDs returned from WebKitTestRunner.
2587
2588         * Scripts/webkitpy/port/ios_device.py:
2589         (IOSDevicePort.check_for_leaks):
2590         - Rename redundant 'process_pid' argument to 'process_id'.
2591
2592         * Scripts/webkitpy/port/leakdetector.py:
2593         (LeakDetector._parse_leaks_output):
2594         - Return early if there is no leaks_output.
2595         (LeakDetector.check_for_leaks):
2596         - Rename redundant 'process_pid' argument to 'process_id'.
2597
2598         * Scripts/webkitpy/port/server_process.py:
2599         (ServerProcess.__init__):
2600         (ServerProcess.child_processes):
2601         (ServerProcess.set_child_processes):
2602         - Add instance variable to Port to store list of child process
2603           names and process IDs returned from WebKitTestRunner.
2604         (ServerProcess._start):
2605         - Clear self._child_processes.
2606         (ServerProcess.stop):
2607         - If self._child_processes is set, call
2608           self._port.check_for_leaks() for each child process.
2609
2610         * Scripts/webkitpy/port/server_process_unittest.py:
2611         (TrivialMockPort.check_for_leaks):
2612         - Rename redundant 'process_pid' argument to 'process_id'.
2613
2614         * Scripts/webkitpy/port/simulator_process.py:
2615         (SimulatorProcess.stop):
2616         - If self._child_processes is set, call
2617           self._port.check_for_leaks() for each child process.
2618
2619         * Scripts/webkitpy/port/watch_device.py:
2620         (WatchDevicePort.check_for_leaks):
2621         - Rename redundant 'process_pid' argument to 'process_id'.
2622
2623         * WebKitTestRunner/TestController.cpp:
2624         (WTR::TestController::dumpResponse):
2625         - Extract method from findAndDumpWorldLeaks() so that it may be
2626           reused by findAndDumpWebKitProcessIdentifiers().
2627         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2628         - Add method to output process name and process ID of both the
2629           WebContent and Networking processes.
2630         (WTR::TestController::findAndDumpWorldLeaks):
2631         - Fix missing newline in output when there were no abandoned
2632           documents.
2633         - Call dumpResponse() for extracted code.
2634         (WTR::TestController::handleControlCommand):
2635         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2636         - Use strncmp() instead of strcmp().
2637         - Call findAndDumpWebKitProcessIdentifiers() when
2638           "#LIST CHILD PROCESSES" command is sent.
2639         * WebKitTestRunner/TestController.h:
2640         (WTR::TestController::dumpResponse):
2641         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2642         - Declare methods.
2643
2644 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2645
2646         Unreviewed. Add GLib API test cases after r243434.
2647
2648         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2649         (testWebViewActiveURI):
2650         (serverCallback):
2651         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2652         (sendRequestCallback):
2653
2654 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2655
2656         Geolocation request not complete when watch request was started in a different web process
2657         https://bugs.webkit.org/show_bug.cgi?id=195996
2658
2659         Reviewed by Alex Christensen.
2660
2661         Add a test case.
2662
2663         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2664         (TestWebKitAPI::runJavaScriptAlert):
2665         (TestWebKitAPI::TEST):
2666
2667 2019-03-26  Keith Rollin  <krollin@apple.com>
2668
2669         Update the way generate-xcfilelists returns strings from functions
2670         https://bugs.webkit.org/show_bug.cgi?id=195975
2671         <rdar://problem/49040807>
2672
2673         Reviewed by Dean Jackson.
2674
2675         There are places where generate-xcfilelists executes assignments with
2676         statements like:
2677
2678             FOO=$(some_function)
2679
2680         where "some_function" return a string by echoing it. E.g.
2681
2682             some_function()
2683             {
2684                 echo "Hello, World"
2685             }
2686
2687         This is a common idiom, but it has a problem if "some_function" needs
2688         to call "exit" in an attempt to halt the entire script right then and
2689         there. Since "some_function" is called inside of $(), it's being
2690         executed in a sub-shell. Calling exit in that sub-shell simply exits
2691         that shell; it doesn't not exit the outer shell in which the main part
2692         of the script is still running. As such, the main script keeps
2693         executing when the intent was for the script to halt.
2694
2695         The solution to this is to use a different idiom for returning
2696         strings. The one we now is to pass in the name of the variable to
2697         receive the string result:
2698
2699             some_function()
2700             {
2701                 variable_name=$1
2702                 eval $variable_name ="Hello, World"
2703             }
2704
2705         The call site now looks like
2706
2707             some_function FOO
2708
2709         Because there's no invocation of a sub-shell, some_function can now
2710         call "exit" if it wants to, and the entire script will exit at that
2711         point.
2712
2713         * Scripts/generate-xcfilelists:
2714
2715 2019-03-26  Chris Dumez  <cdumez@apple.com>
2716
2717         Add basic layout test coverage for File Picker on iOS
2718         https://bugs.webkit.org/show_bug.cgi?id=196265
2719
2720         Reviewed by Wenson Hsieh.
2721
2722         Add layout test infrastructure to test the file picker on iOS.
2723
2724         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2725         (WTR::UIScriptController::dismissFilePicker):
2726         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2727         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2728         (WTR::UIScriptController::dismissFilePicker):
2729         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2730         * WebKitTestRunner/TestController.cpp:
2731         (WTR::TestController::createWebViewWithOptions):
2732         (WTR::updateTestOptionsFromTestHeader):
2733         * WebKitTestRunner/TestOptions.h:
2734         (WTR::TestOptions::hasSameInitializationOptions const):
2735         * WebKitTestRunner/ios/TestControllerIOS.mm:
2736         (overridePresentViewController):
2737         (WTR::TestController::platformInitialize):
2738         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2739         (WTR::UIScriptController::dismissFilePicker):
2740
2741 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2742
2743         Implement async paste method on UIWKInteractionViewProtocol
2744         https://bugs.webkit.org/show_bug.cgi?id=196267
2745         <rdar://problem/49236346>
2746
2747         Reviewed by Tim Horton.
2748
2749         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2750         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2751         are now a part of all iOS 12 internal SDKs.
2752
2753         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2754
2755         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2756         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2757
2758         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2759         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2760         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2761         * TestWebKitAPI/ios/UIKitSPI.h:
2762
2763 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2764
2765         [ews-build] Use PostgreSQL for ews.webkit.org database
2766         https://bugs.webkit.org/show_bug.cgi?id=196270
2767
2768         Reviewed by Lucas Forschler.
2769
2770         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2771
2772 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2773
2774         [ews] Reset simctl states on reboot
2775         https://bugs.webkit.org/show_bug.cgi?id=196260
2776
2777         Rubber-stamped by Aakash Jain.
2778
2779         * EWSTools/start-queue-mac.sh:
2780
2781 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2782
2783         [ews-build] Use PostgreSQL for ews-build database
2784         https://bugs.webkit.org/show_bug.cgi?id=196229
2785
2786         Reviewed by Lucas Forschler.
2787
2788         * BuildSlaveSupport/ews-build/master.cfg:
2789
2790 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2791
2792         [ews-build] Get master_hostname dynamically in master.cfg
2793         https://bugs.webkit.org/show_bug.cgi?id=196255
2794
2795         Reviewed by Lucas Forschler.
2796
2797         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2798         send events data in test mode.
2799
2800 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2801
2802         [ews-app] Set db_constraint to False for Foreign Keys
2803         https://bugs.webkit.org/show_bug.cgi?id=196252
2804
2805         Reviewed by Lucas Forschler.
2806
2807         * BuildSlaveSupport/ews-app/ews/models/build.py:
2808         * BuildSlaveSupport/ews-app/ews/models/step.py:
2809
2810 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2811
2812         [ews-build] is_test_mode_enabled should default to True
2813         https://bugs.webkit.org/show_bug.cgi?id=196248
2814
2815         Reviewed by Lucas Forschler.
2816
2817         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2818
2819 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2820
2821         [ews-app] Add webkitperl to ENABLED_QUEUES
2822         https://bugs.webkit.org/show_bug.cgi?id=196253
2823
2824         Reviewed by Lucas Forschler.
2825
2826         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2827
2828 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2829
2830         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2831         https://bugs.webkit.org/show_bug.cgi?id=196211
2832         rdar://problem/49110552
2833
2834         Reviewed by Tim Horton.
2835
2836         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2837         Make sure that EventSenderProxy always exists when running tests. We used to create
2838         it when resetting before the first test, which is a bit too late.
2839
2840         * WebKitTestRunner/TestController.h:
2841         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2842         (WTR::TestController::platformCreateWebView):
2843         (WTR::TestController::platformCreateOtherPage):
2844         (WTR::TestController::finishCreatingPlatformWebView):
2845         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2846         (WTR::PlatformWebView::PlatformWebView):
2847         Moved some code that made NSWindow use NSEvent during web view creation. We may
2848         need to move more if some other case us found, but this is enough for now.
2849
2850 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2851
2852         Unreviewed. Fix typo in GLib geolocation API after r243285.
2853
2854         gelocation -> geolocation.
2855
2856         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2857         (testGeolocationManagerWatchPosition):
2858
2859 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2860
2861         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2862         https://bugs.webkit.org/show_bug.cgi?id=196213
2863
2864         Reviewed by Geoff Garen.
2865
2866         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2867         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2868         (credentialWithIdentityAndKeychainPath):
2869         (-[ChallengeDelegate webView:didFinishNavigation:]):
2870         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2871         (TestWebKitAPI::TEST):
2872
2873 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2874
2875         Expected shouldn't assume its contained types are copyable
2876         https://bugs.webkit.org/show_bug.cgi?id=195986
2877
2878         Reviewed by JF Bastien.
2879
2880         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2881         (TestWebKitAPI::NonCopyable::operator== const):
2882         (TestWebKitAPI::NonCopyable::operator!= const):
2883         (TestWebKitAPI::TEST):
2884
2885 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2886
2887         Remove some now-unnecessary dynamic class lookup
2888         https://bugs.webkit.org/show_bug.cgi?id=196237
2889
2890         Reviewed by Simon Fraser.
2891
2892         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2893         (makeRequest):
2894         (TEST):
2895
2896 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2897
2898         Unreviewed, rolling out r243450.
2899
2900         AppleWin and WinCairo port builds get broken.
2901
2902         Reverted changeset:
2903
2904         "Add test for fix of #196095"
2905         https://bugs.webkit.org/show_bug.cgi?id=196097
2906         https://trac.webkit.org/changeset/243450
2907
2908 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2909
2910         Unreviewed, rolling out r243465.
2911         https://bugs.webkit.org/show_bug.cgi?id=196226
2912
2913         the test doesn't build (Requested by thorton on #webkit).
2914
2915         Reverted changeset:
2916
2917         "Do not terminate the NetworkProcess if a third party
2918         application sends a NSCredential with a SecIdentityRef"
2919         https://bugs.webkit.org/show_bug.cgi?id=196213
2920         https://trac.webkit.org/changeset/243465
2921
2922 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2923
2924         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2925         https://bugs.webkit.org/show_bug.cgi?id=196213
2926
2927         Reviewed by Geoff Garen.
2928
2929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2930         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2931         (credentialWithIdentityAndKeychainPath):
2932         (-[ChallengeDelegate webView:didFinishNavigation:]):
2933         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2934         (TestWebKitAPI::TEST):
2935
2936 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2937
2938         [ews-build] Gracefully handle missing patch_id in events
2939         https://bugs.webkit.org/show_bug.cgi?id=196216
2940
2941         Reviewed by Lucas Forschler.
2942
2943         * BuildSlaveSupport/ews-build/events.py:
2944
2945 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2946
2947         [ews-build] use lz4 compression for improving buildbot performance
2948         https://bugs.webkit.org/show_bug.cgi?id=196155
2949
2950         Reviewed by Lucas Forschler.
2951
2952         * BuildSlaveSupport/ews-build/master.cfg:
2953
2954 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2955
2956         Pull some API testing helper methods out of TestWKWebView
2957         https://bugs.webkit.org/show_bug.cgi?id=196212
2958
2959         Reviewed by Tim Horton.
2960
2961         Refactor some more API testing utility methods, so that they can be used in
2962         tests that do not use TestWKWebView.
2963
2964         * TestWebKitAPI/cocoa/TestWKWebView.h:
2965         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2966         (-[WKWebView loadTestPageNamed:]):
2967         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2968         (-[WKWebView synchronouslyLoadHTMLString:]):
2969         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2970         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2971         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2972         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2973         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2974
2975 2019-03-25  Jer Noble  <jer.noble@apple.com>
2976
2977         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2978         https://bugs.webkit.org/show_bug.cgi?id=196097
2979
2980         Reviewed by Eric Carlson.
2981
2982         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2983
2984         * DumpRenderTree/mac/DumpRenderTree.mm:
2985         (resetWebPreferencesToConsistentValues):
2986         * WebKitTestRunner/TestController.cpp:
2987         (WTR::TestController::resetPreferencesToConsistentValues):
2988
2989 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2990
2991         Pull IPadUserInterfaceSwizzler out into a separate header file
2992         https://bugs.webkit.org/show_bug.cgi?id=196193
2993
2994         Reviewed by Anders Carlsson.
2995
2996         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2997         be used in other API tests.
2998
2999         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3000         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3001         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
3002         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
3003         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
3004         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3005         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3006
3007 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3008
3009         Remove NavigatorContentUtils in WebCore/Modules
3010         https://bugs.webkit.org/show_bug.cgi?id=196070
3011
3012         Reviewed by Alex Christensen.
3013
3014         NavigatorContentUtils was to support the custom scheme spec [1].
3015         However, in WebKit side, no port has supported the feature in
3016         WebKit layer after EFL port was removed. So there has been the
3017         only IDL implementation of the NavigatorContentUtils in WebCore.
3018         So we don't need to keep the implementation in WebCore anymore.
3019
3020         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
3021
3022         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3023
3024 2019-03-24  Andy Estes  <aestes@apple.com>
3025
3026         [watchOS] Remove unused Proximity Networking code
3027         https://bugs.webkit.org/show_bug.cgi?id=196188
3028
3029         Reviewed by Tim Horton.
3030
3031         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3032         (TEST):
3033
3034 2019-03-23  Keith Miller  <keith_miller@apple.com>
3035
3036         Refactor clz/ctz and fix getLSBSet.
3037         https://bugs.webkit.org/show_bug.cgi?id=196162
3038
3039         Reviewed by Saam Barati.
3040
3041         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3042
3043         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3044         (TestWebKitAPI::TEST):
3045
3046 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3047
3048         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3049         https://bugs.webkit.org/show_bug.cgi?id=196143
3050
3051         Reviewed by Michael Catanzaro.
3052
3053         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3054         directories.
3055
3056         * Scripts/webkitpy/style/checkers/cpp.py:
3057         (check_identifier_name_in_declaration):
3058         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3059         (WebKitStyleTest.test_names):
3060
3061 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3062
3063         [Flatpak] Manifest expanding fails for qt WPE extension
3064         https://bugs.webkit.org/show_bug.cgi?id=196148
3065
3066         Reviewed by Alex Christensen.
3067
3068         * flatpak/flatpakutils.py:
3069         (expand_submodules_recurse): The last recurse manifest expand
3070         iteration might lead to a single module so take it into account
3071         and don't try to recurse further.
3072
3073 2019-03-22  Chris Dumez  <cdumez@apple.com>
3074
3075         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3076         https://bugs.webkit.org/show_bug.cgi?id=195348
3077         <rdar://problem/48622090>
3078
3079         Reviewed by Alex Christensen.
3080
3081         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3082         to NO when test.options().shouldIgnoreMetaViewport is false.
3083
3084         * WebKitTestRunner/ios/TestControllerIOS.mm:
3085         (WTR::TestController::platformConfigureViewForTest):
3086
3087 2019-03-22  Chris Dumez  <cdumez@apple.com>
3088
3089         Prewarmed processes should be usable with any website data store
3090         https://bugs.webkit.org/show_bug.cgi?id=196104
3091
3092         Reviewed by Alex Christensen.
3093
3094         Add API test coverage.
3095
3096         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3097         (runInitialWarmedProcessUsedTest):
3098         (TEST):
3099
3100 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3101
3102         Back out local changes to Alex's Subversion working directory
3103
3104         They were accidentally committed.
3105
3106         * Scripts/webkitpy/common/system/abstractexecutive.py:
3107         (AbstractExecutive.wait_newest):
3108         * Scripts/webkitpy/common/system/executive.py:
3109         (Executive.running_pids):
3110         * Scripts/webkitpy/common/system/executive_mock.py:
3111         (MockExecutive.running_pids):
3112         * Scripts/webkitpy/common/system/executive_unittest.py:
3113         (ExecutiveTest.serial_test_running_pids):
3114         * Scripts/webkitpy/port/darwin.py:
3115         (DarwinPort.check_for_leaks):
3116         * Scripts/webkitpy/port/leakdetector.py:
3117         (LeakDetector.check_for_leaks):
3118         - This was the hack attached to Bug 193772.
3119
3120         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3121         (+[WebKitTestRunnerEvent mouseLocation]):
3122         - This works around a crash on an internal build.
3123
3124 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3125
3126         Fix the build after r243354
3127         https://bugs.webkit.org/show_bug.cgi?id=196138
3128         <rdar://problem/49145951>
3129
3130         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3131         (TEST):
3132         * TestWebKitAPI/ios/UIKitSPI.h:
3133
3134 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3135
3136         Adopt UIWKDocumentContext
3137         https://bugs.webkit.org/show_bug.cgi?id=196040
3138         <rdar://problem/48642440>
3139
3140         Reviewed by Ryosuke Niwa.
3141
3142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3143         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3144         (makeRequest):
3145         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3146         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3147         (applyStyle):
3148         (TEST):
3149         Add tests for UIWKDocumentContext.
3150
3151         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3152         (TEST):
3153         (recursiveFindWKContentView): Deleted.
3154         * TestWebKitAPI/cocoa/TestWKWebView.h:
3155         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3156         (recursiveFindWKContentView):
3157         (-[TestWKWebView wkContentView]):
3158         * TestWebKitAPI/ios/UIKitSPI.h:
3159         Share the WKContentView finding code between tests.
3160
3161 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3162
3163         [iOS WK2] Turn on async overflow scrolling by default
3164         https://bugs.webkit.org/show_bug.cgi?id=196011
3165         rdar://problem/48453859
3166
3167         Reviewed by Antti Koivisto.
3168         
3169         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3170         since so many basic layout tests have different results when compositing is triggered for
3171         overflow.
3172         
3173         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3174
3175         * WebKitTestRunner/TestController.cpp:
3176         (WTR::TestController::resetPreferencesToConsistentValues):
3177
3178 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3179
3180         [ews-build] Retry API test in case of failures
3181         https://bugs.webkit.org/show_bug.cgi?id=196004
3182
3183         Reviewed by Lucas Forschler.
3184
3185         * BuildSlaveSupport/ews-build/steps.py:
3186         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3187         (CompileWebKitToT.doStepIf): Ditto.
3188         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3189         (ReRunAPITests): Re-run API tests.
3190         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3191         (RunAPITestsWithoutPatch): Run API tests without patch.
3192         (RunAPITestsWithoutPatch.doStepIf):
3193         (RunAPITestsWithoutPatch.hideStepIf):
3194         (RunAPITestsWithoutPatch.evaluateCommand):
3195         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3196         (AnalyzeAPITestsResults.start):
3197         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3198         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3199         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3200         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3201
3202 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3203
3204         [ews-build] Update queues configurations
3205         https://bugs.webkit.org/show_bug.cgi?id=196074
3206
3207         Reviewed by Dewei Zhu.
3208
3209         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3210         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3211
3212 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3213
3214         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3215         https://bugs.webkit.org/show_bug.cgi?id=195680
3216         <rdar://problem/48903534>
3217
3218         Unreviewed infrastructure fix.
3219
3220         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3221         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3222
3223 2019-03-21  Andy Estes  <aestes@apple.com>
3224
3225         [iOS] Apple Pay should be available in documents with no user agent scripts
3226         https://bugs.webkit.org/show_bug.cgi?id=196061
3227         <rdar://problem/48649391>
3228
3229         Reviewed by Brady Eidson.
3230
3231         Added API tests and related infrastructure.
3232
3233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3234         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3235         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3236         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3237         (TestWebKitAPI::TEST):
3238         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3239         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3240         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3241         * TestWebKitAPI/cocoa/TestProtocol.mm:
3242         (-[TestProtocol startLoading]):
3243         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3244         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3245         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3246         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3247
3248 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3249
3250         REGRESSSION (r243297): webkitpy tests broken
3251         https://bugs.webkit.org/show_bug.cgi?id=196108
3252
3253         Reviewed by Aakash Jain.
3254
3255         r243297 updated contributors.json, which broke a few unit tests.
3256
3257         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3258         (IRCCommandTest.test_whois):
3259         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3260
3261 2019-03-21  Chris Dumez  <cdumez@apple.com>
3262
3263         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3264         https://bugs.webkit.org/show_bug.cgi?id=196041
3265         <rdar://problem/49083230>
3266
3267         Reviewed by Alex Christensen.
3268
3269         Add API test coverage.
3270
3271         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3272         (TEST):
3273
3274 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3275
3276         Add SPI to inform applications of WKContentRuleList actions
3277         https://bugs.webkit.org/show_bug.cgi?id=195965
3278         <rdar://problem/42664365>
3279
3280         Reviewed by Geoff Garen.
3281
3282         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3283         (TestWebKitAPI::allActionsForResourceLoad):
3284         (TestWebKitAPI::testRequest):
3285         (TestWebKitAPI::TEST_F):
3286         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3287         (Notification::description):
3288         (Notification::operator== const):
3289         (toVector):
3290         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3291         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3292         (makeContentRuleList):
3293         (TEST):
3294         (makeWarnContentRuleList): Deleted.
3295
3296 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3297
3298         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3299         https://bugs.webkit.org/show_bug.cgi?id=196088
3300
3301         Reviewed by Brian Burg.
3302
3303         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3304         Support checks when only one platform is specified. Also deprecate macosx() and
3305         force the use of macos() instead.
3306
3307         * Scripts/webkitpy/style/checkers/cpp.py:
3308         (check_min_versions_of_wk_api_available):
3309         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3310         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3311
3312 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3313
3314         Update status inactive committers' status to 'contributor'.
3315
3316         * Scripts/webkitpy/common/config/contributors.json:
3317
3318 2019-03-21  Xan Lopez  <xan@igalia.com>
3319
3320         [JSC][x86] Drop support for x87 floating point
3321         https://bugs.webkit.org/show_bug.cgi?id=194853
3322
3323         Reviewed by Don Olmstead.
3324
3325         Force SSE2 on x86/32bit builds.
3326
3327         * Scripts/webkitdirs.pm:
3328         (generateBuildSystemFromCMakeProject):
3329
3330 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3331
3332         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3333         https://bugs.webkit.org/show_bug.cgi?id=196073
3334
3335         Reviewed by Michael Catanzaro.
3336
3337         Add test cases to check functions and constructors with no arguments but receiving user data.
3338
3339         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3340         (checkUserData):
3341         (testJSCFunction):
3342         (fooCreateWithUserData):
3343         (testJSCClass):
3344
3345 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3346
3347         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3348
3349         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3350
3351         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3352
3353 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3354
3355         [GTK][WPE] Add API to provide geolocation information
3356         https://bugs.webkit.org/show_bug.cgi?id=195940
3357
3358         Reviewed by Michael Catanzaro.
3359
3360         Add a new test to check the new API.
3361
3362         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3363         (testGeolocationManagerCurrentPosition):
3364         (testGeolocationManagerWatchPosition):
3365         (beforeAll):
3366         (afterAll):
3367         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3368         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3369         (beforeAll): Ditto.
3370         * TestWebKitAPI/glib/CMakeLists.txt:
3371
3372 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3373
3374         [GLib] Returning G_TYPE_OBJECT from a method does not work
3375         https://bugs.webkit.org/show_bug.cgi?id=195574
3376
3377         Reviewed by Michael Catanzaro.
3378
3379         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3380
3381         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3382         (getGFile):
3383         (getParent):
3384         (createGString):
3385         (getGString):
3386         (getGStringCopyWillRaise):
3387         (getGStringCopy):
3388         (getGStringStr):
3389         (getGStringLen):
3390         (freeGString):
3391         (testJSCClass):
3392
3393 2019-03-20  Saam Barati  <sbarati@apple.com>
3394
3395         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3396         https://bugs.webkit.org/show_bug.cgi?id=195721
3397
3398         Reviewed by Filip Pizlo.
3399
3400         * Scripts/run-javascriptcore-tests:
3401
3402 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3403
3404         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3405         https://bugs.webkit.org/show_bug.cgi?id=196049
3406
3407         Reviewed by Tim Horton.
3408
3409         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3410         overflow scrolling in general, so rename it.
3411
3412         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3413
3414 2019-03-20  Daniel Bates  <dabates@apple.com>
3415
3416         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3417         https://bugs.webkit.org/show_bug.cgi?id=196031
3418         <rdar://problem/49078172>
3419
3420         Reviewed by Tim Horton.
3421
3422         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3423         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3424         same code path used when the Done button is pressed to dismiss the <select> picker.
3425
3426         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3427         (TestWebKitAPI::TEST):
3428
3429 2019-03-20  Chris Dumez  <cdumez@apple.com>
3430
3431         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3432         https://bugs.webkit.org/show_bug.cgi?id=196029
3433         <rdar://problem/48954651>
3434
3435         Reviewed by Tim Horton.
3436
3437         Add API test coverage.
3438
3439         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3440
3441 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3442
3443         [ews-build] Improve failure summary string for ApplyPatch step
3444         https://bugs.webkit.org/show_bug.cgi?id=195995
3445
3446         Reviewed by Alexey Proskuryakov.
3447
3448         * BuildSlaveSupport/ews-build/steps.py:
3449         (ApplyPatch.getResultSummary): Override getResultSummary.
3450
3451 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3452
3453         AX: Implement support for new meter ARIA role
3454         https://bugs.webkit.org/show_bug.cgi?id=195966
3455
3456         Reviewed by Chris Fleizach.
3457
3458         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3459         to AXLevelIndicator.
3460
3461         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3462
3463 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3464
3465         [WebAuthN] Implement FIDO AppID extension
3466         https://bugs.webkit.org/show_bug.cgi?id=143491
3467         <rdar://problem/48298273>
3468
3469         Reviewed by Brent Fulgham.
3470
3471         Add a test that covers the new flag of convertToU2fSignCommand.
3472
3473         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3474         (TestWebKitAPI::TEST):
3475         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3476         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3477         (TestWebKitAPI::TEST):
3478
3479 2019-03-19  Keith Rollin  <krollin@apple.com>
3480
3481         Add support for more platforms to generate-xcfilelists
3482         https://bugs.webkit.org/show_bug.cgi?id=195977
3483
3484         Reviewed by Alexey Proskuryakov.
3485
3486         generate-xcfilelists incorrectly complains when involved with building
3487         WebKit for iphonesimulator:
3488
3489             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3490             …
3491             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3492
3493         Address this by teaching generate-xcfilelists about more platforms.
3494
3495         * Scripts/generate-xcfilelists:
3496
3497 2019-03-19  John Wilander  <wilander@apple.com>
3498
3499         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3500         https://bugs.webkit.org/show_bug.cgi?id=195923
3501         <rdar://problem/49001272>
3502
3503         Reviewed by Alex Christensen.
3504
3505         This patch does the following to the TestRunner:
3506         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3507         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3508         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3509
3510         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3511         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3512         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3513         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3514         * WebKitTestRunner/TestController.cpp:
3515         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3516         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3517         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3518         * WebKitTestRunner/TestController.h:
3519         * WebKitTestRunner/TestInvocation.cpp:
3520         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3521
3522 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3523
3524         [CMake] Support more clang and gcc sanitizers
3525         https://bugs.webkit.org/show_bug.cgi?id=195956
3526
3527         Reviewed by Michael Catanzaro.
3528
3529         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3530
3531 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3532
3533         [ews-build] Improve summary for PrintConfiguration step
3534         https://bugs.webkit.org/show_bug.cgi?id=195945
3535
3536         Reviewed by Lucas Forschler.
3537
3538         * BuildSlaveSupport/ews-build/steps.py:
3539         (PrintConfiguration.getResultSummary): Override getResultSummary.
3540
3541 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3542
3543         [ews-build] Improve summary for CheckOutSource step
3544         https://bugs.webkit.org/show_bug.cgi?id=195963
3545
3546         Reviewed by Lucas Forschler.
3547
3548         * BuildSlaveSupport/ews-build/steps.py:
3549         (CheckOutSource.getResultSummary):
3550
3551 2019-03-19  Daniel Bates  <dabates@apple.com>
3552
3553         [iOS] Focus not preserved when switching between tabs
3554         https://bugs.webkit.org/show_bug.cgi?id=195820
3555         <rdar://problem/43614450>
3556
3557         Reviewed by Brent Fulgham.
3558
3559         Add tests to ensure that we restore focus when resigning and becoming first responder.
3560
3561         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3562         (TestWebKitAPI::TEST):
3563
3564 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3565
3566         Make WTFLogChannelState and WTFLogLevel enum classes
3567         https://bugs.webkit.org/show_bug.cgi?id=195904
3568
3569         Reviewed by Eric Carlson.
3570
3571         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3572         (TestWebKitAPI::TEST_F):
3573
3574 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3575
3576         [GStreamer][EME] Backported mssdemux protection data crash fix
3577         https://bugs.webkit.org/show_bug.cgi?id=195918
3578
3579         Reviewed by Philippe Normand.
3580
3581         * gstreamer/jhbuild.modules:
3582         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3583
3584 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3585
3586         Unreviewed, rolling out r243132.
3587
3588         Broke GTK build
3589
3590         Reverted changeset:
3591
3592         "Make WTFLogChannelState and WTFLogLevel enum classes"
3593         https://bugs.webkit.org/show_bug.cgi?id=195904
3594         https://trac.webkit.org/changeset/243132
3595
3596 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3597
3598         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3599
3600         * Scripts/webkitdirs.pm:
3601         (builtDylibPathForName): Adjust the shared library name that's changed
3602         with the API version bump in r243073.
3603
3604 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3605
3606         Make WTFLogChannelState and WTFLogLevel enum classes
3607         https://bugs.webkit.org/show_bug.cgi?id=195904
3608
3609         Reviewed by Eric Carlson.
3610
3611         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3612         (TestWebKitAPI::TEST_F):
3613
3614 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3615
3616         Disable flaky test added in r2431100
3617         https://webkit.org/b/195785
3618
3619         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3620         (TestWebKitAPI::TEST):
3621         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3622
3623 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3624
3625         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3626         https://bugs.webkit.org/show_bug.cgi?id=195916
3627
3628         Reviewed by Tim Horton.
3629
3630         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3631         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3632
3633 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3634
3635         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3636
3637         * Scripts/webkitpy/common/config/contributors.json:
3638
3639 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3640
3641         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3642         https://bugs.webkit.org/show_bug.cgi?id=195785
3643
3644         Reviewed by Geoffrey Garen.
3645
3646         * TestWebKitAPI/TCPServer.cpp: Added.
3647         (TestWebKitAPI::TCPServer::TCPServer):
3648         (TestWebKitAPI::TCPServer::~TCPServer):
3649         (TestWebKitAPI::TCPServer::socketBindListen):
3650         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3651         * TestWebKitAPI/TCPServer.h: Added.
3652         (TestWebKitAPI::TCPServer::port const):
3653         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3654         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3655         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3656         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3657         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3658         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3659         (TestWebKitAPI::respondSlowly):
3660         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3661         (TestWebKitAPI::downloadAtRate):
3662         (TestWebKitAPI::TEST):
3663
3664 2019-03-18  Saam Barati  <sbarati@apple.com>
3665
3666         Add a plan file for JetStream 2
3667         https://bugs.webkit.org/show_bug.cgi?id=190734
3668
3669         Reviewed by Mark Lam.
3670
3671         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3672
3673 2019-03-18  Chris Dumez  <cdumez@apple.com>
3674
3675         Delay WebProcess launch until a load is triggered in a Web view
3676         https://bugs.webkit.org/show_bug.cgi?id=195758
3677         <rdar://problem/48126013>
3678
3679         Reviewed by Geoff Garen.
3680
3681         Add API test coverage. Also update some existing API tests to not expect
3682         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3683
3684         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3685         (TestWebKitAPI::TEST):
3686         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3687         (TestWebKitAPI::TEST):
3688         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3689         (TEST):
3690         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3691         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3692         (TEST):
3693         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3694         (TEST):
3695         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3696
3697 2019-03-18  Xan Lopez  <xan@igalia.com>
3698
3699         [CMake] Prevent potential warning when determining $architecture
3700         https://bugs.webkit.org/show_bug.cgi?id=195891
3701
3702         Reviewed by Michael Catanzaro.
3703
3704         It's possible for generateBuildSystemForCMakeProject to be called
3705         before determineArchitecture() is ever called. This will make the
3706         first eq check with $architecture to be bogus (and print a
3707         warning). Change that to an eq check with architecture(), which
3708         implicitly calls determineArchitecture() if needed, and change all
3709         the other similar cases in the method in the same way to prevent
3710         future bugs like this one.
3711
3712         * Scripts/webkitdirs.pm:
3713         (generateBuildSystemFromCMakeProject):
3714
3715 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3716
3717         [WPE] Tarballs generated with “make dist” cannot build documentation
3718         https://bugs.webkit.org/show_bug.cgi?id=195885
3719
3720         Reviewed by Carlos Garcia Campos.
3721
3722         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3723
3724 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3725
3726         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3727         https://bugs.webkit.org/show_bug.cgi?id=195883
3728
3729         Reviewed by Carlos Garcia Campos.
3730
3731         * gtkdoc/gtkdoc.py:
3732         (GTKDoc._run_command): When commands fail to run, include the full command line for
3733         the program invocation and the output it has generated on the standard error stream.
3734
3735 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3736
3737         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3738         https://bugs.webkit.org/show_bug.cgi?id=195786
3739
3740         Reviewed by Philippe Normand.
3741
3742         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3743         * wpe/jhbuild.modules: Ditto.
3744
3745 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3746
3747         [ews-build] Don't run clean builds on EWS builders
3748         https://bugs.webkit.org/show_bug.cgi?id=195851
3749
3750         Reviewed by Geoffrey Garen.
3751
3752         * BuildSlaveSupport/ews-build/factories.py:
3753
3754 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3755
3756         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3757         https://bugs.webkit.org/show_bug.cgi?id=195849
3758
3759         Reviewed by Chris Dumez.
3760
3761         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3762
3763         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3764         (runWebsiteDataStoreCustomPaths):
3765
3766 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3767
3768         webkitpy: Upload test results
3769         https://bugs.webkit.org/show_bug.cgi?id=195755
3770         <rdar://problem/48896182>
3771
3772         Reviewed by Aakash Jain.
3773
3774         Establish a new format for uploading results that is not tied to layout tests, apply
3775         that format to webkitpy tests.
3776
3777         * Scripts/webkitpy/common/checkout/scm/git.py:
3778         (Git.native_branch): Return what branch the current checkout is on.
3779         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3780         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3781         * Scripts/webkitpy/common/checkout/scm/svn.py:
3782         (SVN.native_branch): Ditto.
3783         * Scripts/webkitpy/common/system/platforminfo.py:
3784         (PlatformInfo.build_version): Return a build version for Mac.
3785         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3786         (MockPlatformInfo.__init__):
3787         (MockPlatformInfo.build_version):
3788         * Scripts/webkitpy/results: Added.
3789         * Scripts/webkitpy/results/__init__.py: Added.
3790         * Scripts/webkitpy/results/options.py: Added.
3791         (upload_options): OptParse list for upload options.
3792         * Scripts/webkitpy/results/upload.py: Added.
3793         (Upload): Class which enforces the upload format expected by the results server.
3794         (Upload.Expectations):
3795         (Upload.create_configuration):
3796         (Upload.create_commit):
3797         (Upload.create_details):
3798         (Upload.create_run_stats):
3799         (Upload.create_test_result):
3800         (Upload.__init__):
3801         (Upload.Encoder): Encode Upload object as json.
3802         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3803         * Scripts/webkitpy/results/upload_unittest.py: Added.
3804         * Scripts/webkitpy/test/main.py:
3805         (Tester._parse_args): Add upload arguments.
3806         (Tester._run_tests): Allow results to be uploaded.
3807         * Scripts/webkitpy/test/runner.py:
3808         (Runner.__init__): Record which tests were run, rather than just counting them.
3809         (Runner.handle):
3810         * Scripts/webkitpy/test/runner_unittest.py:
3811         (RunnerTest.test_run):
3812         * Scripts/webkitpy/thirdparty/__init__.py:
3813         (AutoinstallImportHook.find_module): Add requests auto-install.
3814         (AutoinstallImportHook._install_requests):
3815         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3816         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3817
3818 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3819
3820         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3821         https://bugs.webkit.org/show_bug.cgi?id=195810
3822
3823         Reviewed by Tim Horton.
3824
3825         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3826         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3827         ending certain layout tests.
3828
3829         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3830         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3831         (-[TestRunnerWKWebView dealloc]):
3832         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3833
3834         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3835         helper method when destroying the web view, and when resetting state between tests.
3836
3837         * WebKitTestRunner/ios/TestControllerIOS.mm:
3838         (WTR::TestController::platformResetStateToConsistentValues):
3839
3840         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3841
3842 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3843
3844         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3845         https://bugs.webkit.org/show_bug.cgi?id=190350
3846         <rdar://problem/45089503>
3847
3848         Reviewed by Geoffrey Garen.
3849
3850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3851         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3852         (TEST):
3853         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3854         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3855         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3856         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3857         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3858         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3859         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3860         (runTest):
3861         (createDirectories):
3862         (TEST):
3863         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3864         (TEST):
3865         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3866         (TEST):
3867
3868 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3869
3870         Add support to WebPage for getting the contents as an attributed string.
3871         https://bugs.webkit.org/show_bug.cgi?id=195636
3872         rdar://problem/45055697
3873
3874         Reviewed by Tim Horton.
3875
3876         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3877         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3878
3879 2019-03-15  Chris Dumez  <cdumez@apple.com>
3880
3881         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3882         https://bugs.webkit.org/show_bug.cgi?id=195747
3883
3884         Reviewed by Geoff Garen.
3885
3886         Add API test coverage.
3887
3888         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3889
3890 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3891
3892         Unreviewed, rolling out r242952.
3893
3894         Causing API failures on iOS Simulator
3895
3896         Reverted changeset:
3897
3898         "[PSON] Make sure the WebProcessCache is leverage when
3899         relaunching a process after termination"
3900         https://bugs.webkit.org/show_bug.cgi?id=195747
3901         https://trac.webkit.org/changeset/242952
3902
3903 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3904
3905         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3906         https://bugs.webkit.org/show_bug.cgi?id=195740
3907
3908         Reviewed by Ross Kirsling.
3909
3910         window.open doesn't work for WebKitBrowserWindow because it is not
3911         implemented yet.
3912
3913         1. Implemented createNewPage callback of WKPageUIClient.
3914         2. Changed MainWindow to take a BrowserWindow factory function
3915           instead of BrowserWindowType to be flexible to create
3916           BrowserWindow with extra settings.
3917         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3918           because it is not relevant with MainWindow anymore.
3919
3920         * MiniBrowser/win/Common.cpp:
3921         (parseCommandLine):
3922         * MiniBrowser/win/Common.h:
3923         (CommandLineOptions::CommandLineOptions):
3924         * MiniBrowser/win/MainWindow.cpp:
3925         (MainWindow::MainWindow):
3926         (MainWindow::create):
3927         (MainWindow::init):
3928         (MainWindow::WndProc):
3929         * MiniBrowser/win/MainWindow.h:
3930         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3931         (PrintWebUIDelegate::createWebViewWithRequest):
3932         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3933         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3934         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3935         (WebKitBrowserWindow::updateProxySettings):
3936         (WebKitBrowserWindow::createNewPage):
3937         * MiniBrowser/win/WebKitBrowserWindow.h:
3938         * MiniBrowser/win/WinMain.cpp:
3939         (wWinMain):
3940
3941 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3942
3943         Make it possible to test scrolling tree layer manipulation more easily
3944         https://bugs.webkit.org/show_bug.cgi?id=195780
3945
3946         Reviewed by Tim Horton.
3947         
3948         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3949         cuts off communication of scrolling tree scrolls back to the web process
3950         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3951         allows tests to trigger scrolls which run the scrolling tree layer positioning
3952         logic, but never get another commit from the web process that might mask
3953         scrolling tree bugs.
3954         
3955         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3956         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3957         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3958
3959         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3960         (WTR::UIScriptController::scrollUpdatesDisabled const):
3961         (WTR::UIScriptController::setScrollUpdatesDisabled):
3962         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3963         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3964         (WTR::UIScriptController::scrollUpdatesDisabled const):
3965         (WTR::UIScriptController::setScrollUpdatesDisabled):
3966         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3967         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3968         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3969         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3970         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3971         * WebKitTestRunner/ios/TestControllerIOS.mm:
3972         (WTR::TestController::platformResetStateToConsistentValues):
3973         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3974         (WTR::UIScriptController::scrollUpdatesDisabled const):
3975         (WTR::UIScriptController::setScrollUpdatesDisabled):
3976
3977 2019-03-14  Youenn Fablet  <youenn@apple.com>
3978
3979         Move IDB storage in private browsing mode to NetworkProcess
3980         https://bugs.webkit.org/show_bug.cgi?id=195602
3981
3982         Reviewed by Brady Eidson.
3983
3984         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3985         (TEST):
3986
3987 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3988
3989         [ews-build] Make descriptionDone messages more readable
3990         https://bugs.webkit.org/show_bug.cgi?id=195760
3991
3992         Reviewed by Lucas Forschler.
3993
3994         * BuildSlaveSupport/ews-build/steps.py:
3995         * BuildSlaveSupport/ews-build/steps_unittest.py:
3996
3997 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3998
3999         [ews-build] Generate status-bubble hover-over messages
4000         https://bugs.webkit.org/show_bug.cgi?id=195680
4001
4002         Reviewed by Lucas Forschler.
4003
4004         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4005         (StatusBubble):
4006         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
4007         on hover-over.
4008         (StatusBubble._iso_time):
4009         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
4010         hover-over message.
4011         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
4012
4013 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4014
4015         [ews-app] Gracefully handle the case when state_string is None
4016         https://bugs.webkit.org/show_bug.cgi?id=195753
4017
4018         Reviewed by Lucas Forschler.
4019
4020         * BuildSlaveSupport/ews-app/ews/models/build.py:
4021         * BuildSlaveSupport/ews-app/ews/models/step.py:
4022
4023 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4024
4025         [ews-app] Status bubble display pending for currently running build step
4026         https://bugs.webkit.org/show_bug.cgi?id=195744
4027
4028         Reviewed by Lucas Forschler.
4029
4030         * BuildSlaveSupport/ews-build/events.py:
4031         (Events.stepStarted): If state_string is pending, replace it with step name.
4032
4033 2019-03-14  Chris Dumez  <cdumez@apple.com>
4034
4035         Add WebsitePolicy for the client to specify the device orientation & motion access policy
4036         https://bugs.webkit.org/show_bug.cgi?id=195750
4037
4038         Reviewed by Geoffrey Garen.
4039
4040         Add API test coverage.
4041
4042         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4043         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
4044         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4045         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4046
4047 2019-03-14  Chris Dumez  <cdumez@apple.com>
4048
4049         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
4050         https://bugs.webkit.org/show_bug.cgi?id=195747
4051
4052         Reviewed by Geoff Garen.
4053
4054         Add API test coverage.
4055
4056         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4057
4058 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4059
4060         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
4061         https://bugs.webkit.org/show_bug.cgi?id=195725
4062         <rdar://problem/48545062>
4063
4064         Reviewed by Tim Horton.
4065
4066         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
4067         handler is nil.
4068
4069         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4070         (TestWebKitAPI::TEST):
4071
4072 2019-03-13  Sam Weinig  <sam@webkit.org>
4073
4074         Add utility function to allow easy reverse range-based iteration of a container
4075         https://bugs.webkit.org/show_bug.cgi?id=195542
4076
4077         Reviewed by Antti Koivisto.
4078
4079         * TestWebKitAPI/CMakeLists.txt:
4080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4081         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
4082         (TestWebKitAPI::TEST):
4083         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
4084
4085 2019-03-13  Chris Dumez  <cdumez@apple.com>
4086
4087         Use a ServiceWorker process per registrable domain
4088         https://bugs.webkit.org/show_bug.cgi?id=195649
4089
4090         Reviewed by Youenn Fablet.
4091
4092         Update API test coverage.
4093
4094         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4095
4096 2019-03-13  Chris Dumez  <cdumez@apple.com>
4097
4098         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
4099         https://bugs.webkit.org/show_bug.cgi?id=195684
4100         <rdar://problem/48294714>
4101
4102         Reviewed by Antti Koivisto.
4103
4104         Add API test coverage.
4105
4106         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4107
4108 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4109
4110         [ews-app] Remove unused patch view
4111         https://bugs.webkit.org/show_bug.cgi?id=195669
4112
4113         Reviewed by Lucas Forschler.
4114
4115         * BuildSlaveSupport/ews-app/ews/urls.py:
4116         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
4117
4118 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4119
4120         [ews-app] Use Buildbot result code variables
4121         https://bugs.webkit.org/show_bug.cgi?id=195668
4122
4123         Reviewed by Alexey Proskuryakov.
4124
4125         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
4126         (Buildbot): Added Buildbot result code variables.
4127         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4128         (StatusBubble._build_bubble): Used Buildbot result code variables.
4129
4130 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
4131
4132         [Flatpak] Expand submodule recursively
4133         https://bugs.webkit.org/show_bug.cgi?id=195672
4134
4135         Building WPE with flatpak was impossible without that as it was raising an exception.
4136         Also update wpebackend-fdo to match what is built in jhbuild
4137
4138         Reviewed by Philippe Normand.
4139
4140         * flatpak/flatpakutils.py:
4141         (expand_submodules_recurse):
4142         (expand_manifest):
4143         * flatpak/org.webkit.WPEModules.yaml:
4144
4145 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4146
4147         [ews-app] status bubble should be hidden for certain builds
4148         https://bugs.webkit.org/show_bug.cgi?id=194597
4149
4150         Reviewed by Dewei Zhu.
4151
4152         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4153         (StatusBubble._build_bubble):
4154         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
4155         because the patch didn't have relevant changes.
4156         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
4157         in production yet.
4158
4159 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
4160
4161         [Win] Fix a slew of simple clang-cl warnings.
4162         https://bugs.webkit.org/show_bug.cgi?id=195652
4163
4164         Reviewed by Don Olmstead.
4165
4166         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4167         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
4168
4169 2019-03-12  Justin Fan  <justin_fan@apple.com>
4170
4171         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
4172         https://bugs.webkit.org/show_bug.cgi?id=195518
4173         <rdar://problem/46322356>
4174
4175         Reviewed by Myles C. Maxfield.
4176
4177         * DumpRenderTree/DerivedSources-input.xcfilelist:
4178         * DumpRenderTree/DerivedSources-output.xcfilelist:
4179
4180 2019-03-12  Commit Queue  <commit-queue@webkit.org>
4181
4182         Unreviewed, rolling out r242825.
4183         https://bugs.webkit.org/show_bug.cgi?id=195648
4184
4185         "Broke webkitpy tests with my change to
4186         lldb_dump_class_layout.py" (Requested by rmorisset on
4187         #webkit).
4188
4189         Reverted changeset:
4190
4191         "Alter Tools/Scripts/dump-class-layout to be able to dump all
4192         classes with suspicious padding"
4193         https://bugs.webkit.org/show_bug.cgi?id=195573
4194         https://trac.webkit.org/changeset/242825
4195
4196 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4197
4198         [ews-build] Show status bubbles while the patch is waiting in queue
4199         https://bugs.webkit.org/show_bug.cgi?id=195618
4200
4201         Reviewed by Lucas Forschler.
4202
4203         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4204         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
4205         enabled in initial deployment.
4206         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
4207         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
4208         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
4209         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
4210         (StatusBubble._build_bubbles_for_patch):
4211
4212 2019-03-12  Robin Morisset  <rmorisset@apple.com>
4213
4214         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
4215         https://bugs.webkit.org/show_bug.cgi?id=195573
4216
4217         Reviewed by Simon Fraser.
4218
4219         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
4220
4221         * Scripts/dump-class-layout:
4222         (main):
4223         * lldb/lldb_dump_class_layout.py:
4224         (ClassLayout.__init__):
4225         (ClassLayout._compute_padding_recursive):
4226         (LLDBDebuggerInstance.dump_layout_for_classname):
4227         (LLDBDebuggerInstance):
4228         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
4229         (LLDBDebuggerInstance.layout_for_classname): Deleted.
4230
4231 2019-03-12  Chris Dumez  <cdumez@apple.com>
4232
4233         Device Orientation access permission should be denied unless explicitly granted by the client
4234         https://bugs.webkit.org/show_bug.cgi?id=195625
4235
4236         Reviewed by Youenn Fablet.
4237
4238         add API test coverage.
4239
4240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4241         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
4242         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
4243         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
4244         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4245         (runDeviceOrientationTest):
4246         (TEST):
4247         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4248         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4249
4250 2019-03-12  Jer Noble  <jer.noble@apple.com>
4251
4252         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
4253         https://bugs.webkit.org/show_bug.cgi?id=195137
4254         <rdar://problem/48810307>
4255
4256         Reviewed by Eric Carlson.
4257
4258         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
4259         (TestWebKitAPI::TEST):
4260
4261 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4262
4263         [ews-build] Change urls from uat to production
4264         https://bugs.webkit.org/show_bug.cgi?id=195566
4265
4266         Reviewed by Lucas Forschler.
4267
4268         * BuildSlaveSupport/ews-app/ews/config.py:
4269         * BuildSlaveSupport/ews-build/events.py:
4270         * BuildSlaveSupport/ews-build/steps.py:
4271
4272 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4273
4274         [ews-build] change max_builds for local-worker to 1
4275         https://bugs.webkit.org/show_bug.cgi?id=195568
4276
4277         Reviewed by Lucas Forschler.
4278
4279         * BuildSlaveSupport/ews-build/loadConfig.py:
4280
4281 2019-03-12  Tim Horton  <timothy_horton@apple.com>
4282
4283         Fix the build
4284
4285         * TestRunnerShared/spi/PencilKitTestSPI.h:
4286         * TestWebKitAPI/ios/PencilKitTestSPI.h:
4287
4288 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
4289
4290         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
4291         https://bugs.webkit.org/show_bug.cgi?id=194131
4292
4293         Reviewed by Michael Catanzaro.
4294
4295         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4296         (uriChanged):
4297         (testUnfinishedSubresourceLoad):
4298         (serverCallback):
4299         (beforeAll):
4300
4301 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4302
4303         WTF::Expected should use std::addressof instead of operator&
4304         https://bugs.webkit.org/show_bug.cgi?id=195604
4305
4306         Reviewed by Myles Maxfield.
4307
4308         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4309         (TestWebKitAPI::Unique::Unique):
4310         (TestWebKitAPI::Unique::operator&):
4311         (TestWebKitAPI::TEST):
4312
4313 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
4314
4315         Add Optional to Forward.h.
4316         https://bugs.webkit.org/show_bug.cgi?id=195586
4317
4318         Reviewed by Darin Adler.
4319
4320         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
4321         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
4322         Remove unnecessary includes from headers.