Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-05  Ojan Vafai  <ojan@chromium.org>
2
3         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
4         https://bugs.webkit.org/show_bug.cgi?id=114080
5
6         Reviewed by Ryosuke Niwa.
7
8         This way, the WebKit and Blink dashboard code can change as appropriate without
9         needing to consider the other project's needs. This still doesn't update the
10         buildbots to upload to the new location, or the dashboard code to pull the
11         results.json files from the new location, but it at least allows for changing the
12         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
13
14         * TestResultServer/app.yaml:
15
16 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
17
18         Re-enable testing on the commit queue
19         https://bugs.webkit.org/show_bug.cgi?id=114078
20
21         Reviewed by Darin Adler.
22
23         Re-enabled the feature and the associated tests.
24
25         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
26         (CommitQueueTask.run):
27         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
28         (CommitQueueTaskTest._run_through_task):
29         * Scripts/webkitpy/tool/commands/queues_unittest.py:
30         (CommitQueueTest._mock_test_result):
31
32 2013-04-05  Oliver Hunt  <oliver@apple.com>
33
34         Unify the many and varied stack trace mechanisms, and make the result sane.
35         https://bugs.webkit.org/show_bug.cgi?id=114072
36
37         Reviewed by Filip Pizlo.
38
39         The commandline jsc executable no longer requires arguments, so
40         I've made run-jsc work without them.
41
42         * Scripts/run-jsc:
43
44 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
45
46         AX: Make SVG Group containers accessible elements
47         https://bugs.webkit.org/show_bug.cgi?id=113939
48
49         Reviewed by Simon Fraser.
50
51         Implement axController.elementAtPoint for iOS.
52         Implement a correct version of clickPoint for iOS.
53
54         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
55         (AccessibilityController::elementAtPoint):
56         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
57         (AccessibilityUIElement::clickPointX):
58         (AccessibilityUIElement::clickPointY):
59
60 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
61
62         Unreviewed, rolling out r147773 and r147774.
63         http://trac.webkit.org/changeset/147773
64         http://trac.webkit.org/changeset/147774
65         https://bugs.webkit.org/show_bug.cgi?id=114056
66
67         Causing some exceptions on AppEngine I don't understand
68         (Requested by rniwa on #webkit).
69
70         * QueueStatusServer/config/queues.py:
71         * QueueStatusServer/model/queues.py:
72         (Queue.short_name):
73         (Queue.display_name):
74         * QueueStatusServer/model/queues_unittest.py:
75         (QueueTest.test_short_name):
76         (QueueTest.test_display_name):
77         (QueueTest.test_name_with_underscores):
78
79 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
80
81         Fixed run-bindings-tests by removing V8
82         https://bugs.webkit.org/show_bug.cgi?id=114053
83
84         Reviewed by Benjamin Poulain.
85
86         * Scripts/run-bindings-tests:
87         (main):
88
89 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
90
91         Build fix.
92
93         * QueueStatusServer/model/queues.py:
94         (Queue.short_name):
95         (Queue.display_name):
96
97 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
98
99         Remove Chromium EWS bots from the queue status server
100         https://bugs.webkit.org/show_bug.cgi?id=113988
101
102         Reviewed by Benjamin Poulain.
103
104         Removed Chromium EWS bots.
105
106         * QueueStatusServer/config/queues.py:
107         * QueueStatusServer/model/queues.py:
108         (Queue.short_name):
109         (Queue.display_name):
110         * QueueStatusServer/model/queues_unittest.py:
111         (QueueTest.test_short_name):
112         (QueueTest.test_display_name):
113         (QueueTest.test_name_with_underscores):
114
115 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
116
117         [EFL] Enable indexed database
118         https://bugs.webkit.org/show_bug.cgi?id=107248
119
120         Reviewed by Alexis Menard.
121
122         * Scripts/webkitperl/FeatureList.pm:
123
124 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
125
126         Remove vestiges of Chromium bits from watchlists.
127         https://bugs.webkit.org/show_bug.cgi?id=114047
128
129         Reviewed by Ryosuke Niwa.
130
131         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
132
133 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
134
135         Add James Craig to the contributors list.
136
137         * Scripts/webkitpy/common/config/committers.py:
138
139 2013-04-04  Kent Tamura  <tkent@chromium.org>
140
141         Remove ChromiumPublicApi pattern, and cc/message rules for it.
142
143         * Scripts/webkitpy/common/config/watchlist:
144
145 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
146
147         Temporarily disable the Python unittests broken by the commit queue not running layout tests
148         https://bugs.webkit.org/show_bug.cgi?id=113997
149
150         Reviewed by Ryosuke Niwa.
151
152         Disable the tests until Ryosuke gets the time and hardware to have
153         a testing commit-queue.
154
155         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
156         (CommitQueueTaskTest):
157         * Scripts/webkitpy/tool/commands/queues_unittest.py:
158         (CommitQueueTest):
159
160 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
161
162         Remove Chromium builders from build.webkit.org
163         https://bugs.webkit.org/show_bug.cgi?id=113990
164
165         Reviewed by Benjamin Poulain.
166
167         Land the part to disable triggering of Chromium builders first so that we may start
168         deleting more Chromium code that breaks the update step.
169
170         * BuildSlaveSupport/build.webkit.org-config/config.json:
171
172 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
173
174         Remove Chromium's DumpRenderTree
175         https://bugs.webkit.org/show_bug.cgi?id=113989
176
177         Reviewed by Kent Tamura.
178
179         On second thought, let's not go to Camelot. It is a silly place.
180
181         * DumpRenderTree/mac/DumpRenderTree.mm:
182         (resetDefaultsToConsistentValues):
183
184 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
185
186         Nixed the defunct chromium folder from DumpRenderTree
187         https://bugs.webkit.org/show_bug.cgi?id=113993
188
189         Reviewed by Ryosuke Niwa.
190
191         * DumpRenderTree/chromium: Removed.
192         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
193         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
194         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
195         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
196         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
197         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
198         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
199         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
200         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
201         * DumpRenderTree/chromium/MockPlatform.h: Removed.
202         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
203         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
204         * DumpRenderTree/chromium/Task.cpp: Removed.
205         * DumpRenderTree/chromium/Task.h: Removed.
206         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
207         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
208         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
209         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
210         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
211         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
212         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
213         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
214         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
215         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
216         * DumpRenderTree/chromium/TestRunner: Removed.
217         * DumpRenderTree/chromium/TestRunner/public: Removed.
218         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
219         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
220         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
221         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
222         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
223         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
224         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
225         * DumpRenderTree/chromium/TestRunner/src: Removed.
226         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
227         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
228         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
229         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
230         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
231         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
232         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
233         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
234         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
235         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
236         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
237         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
238         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
239         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
240         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
241         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
242         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
243         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
244         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
245         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
246         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
247         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
248         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
249         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
250         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
251         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
252         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
253         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
254         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
255         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
256         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
257         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
258         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
259         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
260         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
261         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
262         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
263         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
264         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
265         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
266         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
267         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
268         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
269         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
270         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
271         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
272         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
273         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
274         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
275         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
276         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
277         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
278         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
279         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
280         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
281         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
282         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
283         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
284         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
285         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
286         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
287         * DumpRenderTree/chromium/TestShell.cpp: Removed.
288         * DumpRenderTree/chromium/TestShell.h: Removed.
289         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
290         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
291         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
292         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
293         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
294         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
295         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
296         * DumpRenderTree/chromium/WebViewHost.h: Removed.
297         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
298         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
299         * DumpRenderTree/chromium/config.h: Removed.
300         * DumpRenderTree/chromium/fonts.conf: Removed.
301
302 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
303
304         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
305
306         Rubber stamped by Benjamin Poulain.
307
308         * RebaselineQueueServer: Removed.
309         * RebaselineQueueServer/app.yaml: Removed.
310         * RebaselineQueueServer/handlers: Removed.
311         * RebaselineQueueServer/handlers/__init__.py: Removed.
312         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
313         * RebaselineQueueServer/handlers/pages.py: Removed.
314         * RebaselineQueueServer/index.yaml: Removed.
315         * RebaselineQueueServer/main.py: Removed.
316         * RebaselineQueueServer/model: Removed.
317         * RebaselineQueueServer/model/__init__.py: Removed.
318         * RebaselineQueueServer/model/queueentry.py: Removed.
319         * RebaselineQueueServer/static: Removed.
320         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
321         * RebaselineQueueServer/static/styles.css: Removed.
322         * RebaselineQueueServer/templates: Removed.
323         * RebaselineQueueServer/templates/builder-picker.html: Removed.
324         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
325         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
326         * RebaselineQueueServer/templates/home.html: Removed.
327
328 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
329
330         Fix setup-commit-queue and temporarily disable testing on commit-queue
331         https://bugs.webkit.org/show_bug.cgi?id=113979
332
333         Reviewed by Benjamin Poulain.
334
335         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
336         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
337
338         * EWSTools/setup-commit-queue.sh:
339         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
340         (CommitQueueTask.run):
341
342 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
343
344         temporarily make flakiness dashboard work again webkit.org bots
345         https://bugs.webkit.org/show_bug.cgi?id=113972
346
347         Reviewed by Ojan Vafai.
348
349         This patch disables the chromium.org layout test bots TestExpectations
350         parsing temporarily until we can work out the right way to split into
351         two instances for webkit.org and chromium.org and figure out which
352         code to delete where :).
353
354         * TestResultServer/static-dashboards/flakiness_dashboard.js:
355
356 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
357
358         Fix webkitpy tests after r147678.
359
360         * Scripts/webkitpy/tool/commands/queues_unittest.py:
361         (CommitQueueTest.test_commit_queue):
362         (test_manual_reject_during_processing):
363
364 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
365
366         The commit queue should use Mac MountainLion port
367         https://bugs.webkit.org/show_bug.cgi?id=113971
368
369         Reviewed by Lucas Forschler.
370
371         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
372         * Scripts/webkitpy/tool/commands/queues.py:
373         (CommitQueue):
374
375 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
376
377         turn off running tests on chromium linux EWS bots
378         https://bugs.webkit.org/show_bug.cgi?id=113959
379
380         Reviewed by Geoffrey Garen.
381
382         Now that the Chromium port is no longer being maintained
383         there's little point in running the tests. Soon we should
384         just shut this bot off altogether.
385
386         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
387         (ChromiumLinuxEWS):
388
389 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
390
391         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
392
393         * Scripts/webkitpy/common/config/watchlist:
394
395 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
396
397         Indentation fix to get webkit-patch working again after r147625
398
399         Unreviewed.
400
401         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
402         (MacEWS):
403         (MacWK2EWS):
404
405 2013-04-04  Lucas Forschler  <lforschler@apple.com>
406
407         Turn tests back on for Mac WK1/WK2 EWS.
408         
409         Unreviewed.
410         
411         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
412         (MacEWS):
413         (MacWK2EWS):
414
415 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
416
417         [GTK][WK2] MiniBrowser custom URI scheme support
418         https://bugs.webkit.org/show_bug.cgi?id=112419
419
420         Reviewed by Carlos Garcia Campos.
421
422         Add support for about URIs in MiniBrowser. An example about page is show
423         with URI "about:minibrowser", the rest of the cases it will show a
424         proper message explaining that the about page didn't exist.
425
426         Internally it uses "minibrowser-about" prefix instead of "about", but
427         from the user point of view it works with "about" prefix.
428
429         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
430         (getInternalURI): Method to convert URIs from "about" prefix to
431         "minibrowser-about".
432         (getExternalURI): Opposite method.
433         (webViewURIChanged): Use "about" prefix to show the URI to users.
434         (webViewEnterFullScreen): Ditto.
435         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
436         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
437         (aboutURISchemeRequestCallback): Callback to manage about calls.
438         (main): Register the URI scheme to manage about URIs.
439
440 2013-04-03  Roger Fong  <roger_fong@apple.com>
441
442         Re-enable WinEWS tests.
443
444         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
445         (WinEWS):
446
447 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
448
449         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
450         https://bugs.webkit.org/show_bug.cgi?id=113883
451
452         Reviewed by Martin Robinson.
453
454         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
455         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
456         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
457
458 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
459
460         [GTK] Include Pango in jhbuild-optional.modules
461         https://bugs.webkit.org/show_bug.cgi?id=113878
462
463         Reviewed by Martin Robinson.
464
465         Since r147547 Pango 1.32.0 is required. Including the module in the
466         JHBuild optional moduleset.
467
468         * gtk/jhbuild-optional.modules: Add Pango module.
469
470 2013-04-03  Zeno Albisser  <zeno@webkit.org>
471
472         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
473         https://bugs.webkit.org/show_bug.cgi?id=113864
474
475         Moving setDefersLoading from TestRunnerQt to TestRunner
476         requires access to the non-Qt TestRunner.
477         As long as we instantiate both TestRunner and TestRunnerQt,
478         we need a separate getter for the non-Qt TestRunner instance.
479
480         Reviewed by Simon Hausmann.
481
482         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
483         (WebPage::resetSettings):
484         * DumpRenderTree/qt/DumpRenderTreeQt.h:
485         (DumpRenderTree::jscTestRunner):
486         * DumpRenderTree/qt/TestRunnerQt.cpp:
487         (TestRunner::setDefersLoading):
488             Moving setDefersLoading from TestRunnerQt
489             to TestRunner.
490         * DumpRenderTree/qt/TestRunnerQt.h:
491         (TestRunnerQt):
492
493 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
494
495         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
496         https://bugs.webkit.org/show_bug.cgi?id=104779
497
498         Reviewed by Carlos Garcia Campos.
499
500         * Scripts/run-gtk-tests:
501         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
502         passing in current trunk.
503
504 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
505
506         Fix HAVE(QTTESTSUPPORT) logic
507
508         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
509         resulting in HAVE(QTTESTSUPPORT) never being true.
510         Move that logic down in sanitizeFeatures.
511
512         Rubber-stamped by Tor Arne Vestbø.
513
514         * qmake/mkspecs/features/features.prf:
515
516 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
517
518         [GTK] Bump required versions of some dependencies
519         https://bugs.webkit.org/show_bug.cgi?id=113282
520
521         Reviewed by Martin Robinson.
522
523         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
524
525 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
526
527         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
528         https://bugs.webkit.org/show_bug.cgi?id=113809
529
530         Reviewed by Philippe Normand.
531
532         Newer Linux kernels have removed some deprecated macros from v4l2
533         headers, causing gst-plugins-good's build to break. We don't need it
534         right now, so just disable it.
535
536         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
537
538 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
539
540         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
541         https://bugs.webkit.org/show_bug.cgi?id=113535
542
543         Reviewed by Simon Hausmann.
544
545         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
546
547         * qmake/mkspecs/features/features.prf:
548
549 2013-04-03  Zeno Albisser  <zeno@webkit.org>
550
551         [Qt] Move logic of simple forwarding functions to TestRunner.
552         https://bugs.webkit.org/show_bug.cgi?id=113863
553
554         Reviewed by Simon Hausmann.
555
556         * DumpRenderTree/qt/TestRunnerQt.cpp:
557         (TestRunner::setTextDirection):
558         (TestRunner::goBack):
559         (TestRunner::evaluateScriptInIsolatedWorld):
560         (TestRunner::addUserStyleSheet):
561         * DumpRenderTree/qt/TestRunnerQt.h:
562         (TestRunnerQt):
563
564 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
565
566         [Qt] Disable media support using QuickTime if deployment target != SDK
567
568         We link to a single libWebKitSystemInterface static lib, so unless the
569         deployment target matches the SDK let's not pretend like we'll be able
570         to run on anything lower than the SDK version.
571
572         Reviewed by Simon Hausmann.
573
574         * qmake/mkspecs/features/features.prf:
575
576 2013-04-02  James Craig  <james@cookiecrook.com>
577
578         AXRoleDescripton for DL is "list"; should be "description list"
579         https://bugs.webkit.org/show_bug.cgi?id=111665
580
581         Reviewed by Chris Fleizach.
582
583         Defining the role and description strings.
584
585         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
586
587 2013-04-02  Roger Fong  <roger_fong@apple.com>
588
589         Unreviewed. Disable running tests on Win EWS queue.
590
591         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
592         (WinEWS):
593
594 2013-04-02  Lucas Forschler  <lforschler@apple.com>
595
596         Disable running tests on the MAC WK2 EWS queue.
597         
598         Unreviewed.
599         
600         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
601         (MacWK2EWS):
602
603 2013-04-02  Julie Parent  <jparent@chromium.org>
604
605         Dashboard refactor: Move dashboard specific history related features to History.
606         https://bugs.webkit.org/show_bug.cgi?id=113717
607
608         Reviewed by Ojan Vafai.
609         
610         Each dashboard now creates its own History object, with a custom
611         configuration. This changes from just overriding global functions
612         to passing in callbacks for generatePage, handleValidHashParameter,
613         and handleQueryParameterChange. Same with passing in defaultStateValues
614         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
615         variables.
616         
617         All functions related to these features are now (mostly) private
618         function on History. 
619         
620         Loader no longer needs a loadingComplete callback, since it can just
621         initialize the history object itself.
622
623         * TestResultServer/static-dashboards/aggregate_results.js:
624         (handleValidHashParameter):
625         * TestResultServer/static-dashboards/dashboard_base.js:
626         * TestResultServer/static-dashboards/flakiness_dashboard.js:
627         (generatePage):
628         (.switch.return):
629         (handleQueryParameterChange):
630         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
631         (resetGlobals):
632         * TestResultServer/static-dashboards/history.js:
633         (.):
634         * TestResultServer/static-dashboards/loader.js:
635         (.):
636         * TestResultServer/static-dashboards/loader_unittests.js:
637         * TestResultServer/static-dashboards/timeline_explorer.js:
638         (generatePage):
639         (initCurrentBuilderTestResults):
640         * TestResultServer/static-dashboards/treemap.js:
641         (generatePage):
642         (.switch.return):
643         (handleQueryParameterChange):
644
645 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
646
647         Unreviewed, rolling out r147401.
648         http://trac.webkit.org/changeset/147401
649         https://bugs.webkit.org/show_bug.cgi?id=113767
650
651         The patch makes it extremely hard to set up the dependencies
652         properly on the GTK builders (Requested by zdobersek on
653         #webkit).
654
655         * gtk/jhbuild.modules:
656
657 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
658
659         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
660         https://bugs.webkit.org/show_bug.cgi?id=113382
661
662         Reviewed by Gyuyoung Kim.
663
664         Do not show the empty tooltip box if the text is null.
665
666         * MiniBrowser/efl/main.c:
667         (popup_menu_populate):
668
669 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
670
671         [GTK] Bump required versions of some dependencies
672         https://bugs.webkit.org/show_bug.cgi?id=113282
673
674         Reviewed by Martin Robinson.
675
676         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
677
678 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
679
680         Unreviewed, rolling out r147319.
681         http://trac.webkit.org/changeset/147319
682         https://bugs.webkit.org/show_bug.cgi?id=113707
683
684         The unit test is still failing on the buildbot (Requested by
685         zdobersek on #webkit).
686
687         * Scripts/run-gtk-tests:
688         (TestRunner):
689
690 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
691
692         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
693         https://bugs.webkit.org/show_bug.cgi?id=104779
694
695         Reviewed by Carlos Garcia Campos.
696
697         * Scripts/run-gtk-tests:
698         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
699         passing in current trunk.
700
701 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
702
703         Unreviewed, rolling out r147289.
704         http://trac.webkit.org/changeset/147289
705         https://bugs.webkit.org/show_bug.cgi?id=113678
706
707         broke Win7 (dbg) build (Requested by shinyak|gardener on
708         #webkit).
709
710         * DumpRenderTree/DumpRenderTree.gypi:
711         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
712         (WebTestRunner):
713         (WebUserMediaClientMock):
714         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
715         (WebTestRunner::WebUserMediaClientMock::taskList):
716         * Scripts/webkitpy/style/checkers/cpp.py:
717         (check_function_definition):
718
719 2013-03-31  Adam Barth  <abarth@webkit.org>
720
721         configure-svn-config.sh fails
722         https://codereview.chromium.org/13392007/
723
724         Reviewed by Eric Seidel.
725
726         This script was trying to use "svn checkout" to dowload a file from
727         svn.webkit.org, but "svn checkout" only works with directories.
728         Instead, we should use "svn export".
729
730         * EWSTools/configure-svn-config.sh:
731
732 2013-03-31  Wei Jia  <wjia@chromium.org>
733
734         Allow WebUserMediaClientMock to be used by client
735         https://bugs.webkit.org/show_bug.cgi?id=113633
736
737         Reviewed by Adam Barth.
738
739         Export WebUserMediaClientMock.
740         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
741
742         * DumpRenderTree/DumpRenderTree.gypi:
743         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
744         (WebUserMediaClientMock):
745         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
746         * Scripts/webkitpy/style/checkers/cpp.py:
747         (check_function_definition):
748
749 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
750
751         Expose FeatureObserver data to WebKit clients
752         https://bugs.webkit.org/show_bug.cgi?id=113613
753
754         Reviewed by Sam Weinig.
755
756         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
757         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
758
759 2013-03-29  Greg Hughes  <ghughes@apple.com>
760
761         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
762         https://bugs.webkit.org/show_bug.cgi?id=112276
763
764         Reviewed by Chris Fleizach.
765
766         Added support to test accessibility search predicates with multiple keys.  
767
768         * DumpRenderTree/AccessibilityUIElement.cpp:
769         (uiElementForSearchPredicateCallback):
770         * DumpRenderTree/AccessibilityUIElement.h:
771         (AccessibilityUIElement):
772         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
773         (AccessibilityUIElement::uiElementForSearchPredicate):
774         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
775         (AccessibilityUIElement::uiElementForSearchPredicate):
776         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
777         (AccessibilityUIElement::uiElementForSearchPredicate):
778         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
779         (AccessibilityUIElement::uiElementForSearchPredicate):
780         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
781         (AccessibilityUIElement::uiElementForSearchPredicate):
782         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
783         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
784         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
785         (AccessibilityUIElement):
786         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
787         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
788         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
789         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
790         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
791
792 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
793
794         Fix a typo in r147147 to fix Mac EWS.
795
796         * Scripts/webkitpy/tool/commands/queues.py:
797         (PatchProcessingQueue._new_port_name_from_old):
798
799 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
800
801         [EFL] Build break with latest EFL libraries after r146265
802         https://bugs.webkit.org/show_bug.cgi?id=113558
803
804         Unreviewed build fix.
805
806         * TestWebKitAPI/PlatformWebView.h:
807         * WebKitTestRunner/PlatformWebView.h:
808
809 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
810
811         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
812
813         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
814         in libgcrypt build.
815
816 2013-03-28  Lucas Forschler  <lforschler@apple.com>
817
818         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
819
820         Unreviewed.
821
822         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
823         (MacEWS):
824
825 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
826
827         Use the right OS name on Mac EWS instead of mac-future.
828
829         Rubber-stamped by Dirk Pranke.
830
831         * Scripts/webkitpy/tool/commands/queues.py:
832         (PatchProcessingQueue._new_port_name_from_old):
833         (PatchProcessingQueue.begin_work_queue):
834         (PatchProcessingQueue._upload_results_archive_for_patch):
835
836 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
837
838         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
839         https://bugs.webkit.org/show_bug.cgi?id=112546
840
841         Reviewed by Martin Robinson.
842
843         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
844         moved back to Source/WebCore/platform. Fix an indentation issue as well.
845
846 2013-03-28  Ming Xie  <mxie@blackberry.com>
847
848         [BlackBerry] Committer Email Updates
849         https://bugs.webkit.org/show_bug.cgi?id=113435
850
851         Reviewed by Rob Buis.
852
853         Add the @blackberry.com email address for all our BlackBerry
854         WebKit committers. This is the first step for our email address
855         migration.
856
857         * Scripts/webkitpy/common/config/committers.py:
858
859 2013-03-28  Philippe Normand  <pnormand@igalia.com>
860
861         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
862         https://bugs.webkit.org/show_bug.cgi?id=113508
863
864         Reviewed by Martin Robinson.
865
866         Prevent the GStreamer plugin scanner to load system-wide
867         plugins. Only the ones built in JHBuild should be loaded and used
868         at runtime.
869
870         * efl/jhbuildrc:
871         * gtk/jhbuildrc:
872
873 2013-03-27  Philippe Normand  <pnormand@igalia.com>
874
875         [GTK] run-launcher --gtk -2 fails on a WK2-only build
876         https://bugs.webkit.org/show_bug.cgi?id=113386
877
878         Reviewed by Carlos Garcia Campos.
879
880         * Scripts/webkitdirs.pm:
881         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
882         version to 3.0. Reflect this change so the builtDylibPathForName
883         function doesn't fail to report the library as found.
884
885 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
886
887         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
888         https://bugs.webkit.org/show_bug.cgi?id=113484
889
890         Unreviewed build fix.
891
892         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
893
894         * TestWebKitAPI/CMakeLists.txt:
895         * WebKitTestRunner/CMakeLists.txt:
896
897 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
898
899         Revision for the internal jhbuild is too old
900         https://bugs.webkit.org/show_bug.cgi?id=113324
901
902         Reviewed by Martin Robinson.
903
904         Update the minimum required version to a point where jhbuild won't
905         fail installing packages when trying to remove a symlink to a directory.
906
907         * jhbuild/jhbuild-wrapper: Updated revision.
908
909 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
910
911         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
912         https://bugs.webkit.org/show_bug.cgi?id=113203
913
914         Reviewed by Philippe Normand.
915
916         We build our libsoup without GNOME support. gst-plugins-good does separate
917         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
918         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
919         build failures as the headers of those diverge. We do not use souphttpsrc, so
920         disable it when building gst-plugins-good.
921
922         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
923
924 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
925
926         Build fix after r146852. Please another reference to the Lion leaks builder.
927
928         * BuildSlaveSupport/build.webkit.org-config/config.json:
929
930 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
931
932         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
933         https://bugs.webkit.org/show_bug.cgi?id=113421
934
935         Reviewed by Dirk Pranke.
936
937         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
938         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
939         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
940         in the GTK-specific TestExpectations files.
941
942         To avoid this only enable the warnings only when not using WKTR.
943
944         * Scripts/webkitpy/layout_tests/port/gtk.py:
945         (GtkPort.warn_if_bug_missing_in_test_expectations):
946
947 2013-03-27  Antti Koivisto  <antti@apple.com>
948
949         Fix Zalan's email.
950
951         * Scripts/webkitpy/common/config/committers.py:
952
953 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
954
955         master.cfg cleanup
956         https://bugs.webkit.org/show_bug.cgi?id=113195
957
958         Reviewed by Ryosuke Niwa.
959
960         * BuildSlaveSupport/build.webkit.org-config/config.json:
961         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
962
963 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
964
965         master.cfg fine-tuning for Qt Mountain Lion Release bot
966         https://bugs.webkit.org/show_bug.cgi?id=113191
967
968         Reviewed by Ryosuke Niwa.
969
970         * BuildSlaveSupport/build.webkit.org-config/config.json:
971           - Rename the slave due to its location change.
972           - Update the platform of the slave.
973         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
974         (RunQtAPITests): Enable running WK2 API tests on Qt.
975         (RunQtAPITests.start):
976         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
977         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
978
979 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
980
981         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
982         https://bugs.webkit.org/show_bug.cgi?id=113403
983
984         Reviewed by Kenneth Rohde Christiansen.
985
986         As of Evas 1.7.5, when Wayland is detected on the system, support for
987         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
988         The code, however, seems to depend on a few other flags which must be
989         explicitly enabled.
990
991         If those additional GL-related options are passed, we end up
992         having issues on the WebKit side, so disable Wayland support for
993         now.
994
995         * efl/jhbuild.modules:
996
997 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
998
999         Unreviewed, rolling out r146864.
1000         http://trac.webkit.org/changeset/146864
1001         https://bugs.webkit.org/show_bug.cgi?id=113391
1002
1003         causes crashes on Wk2 EFL release bot (Requested by drott on
1004         #webkit).
1005
1006         * Scripts/webkitperl/FeatureList.pm:
1007
1008 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1009
1010         [jhbuild] Correctly specify an alternate number of make jobs.
1011         https://bugs.webkit.org/show_bug.cgi?id=113396
1012
1013         Reviewed by Philippe Normand.
1014
1015         So far, we were using the `MAKEFLAGS' environment variable to pass the
1016         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1017         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1018
1019         We now behave more closely to the rest of the WebKit tools by first
1020         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1021         not set, just letting jhbuild itself figure out how many jobs to use.
1022
1023         * efl/jhbuildrc:
1024         * gtk/jhbuildrc:
1025
1026 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1027
1028         [Qt] Remove Qt specific WorkQueueItem definitions.
1029         https://bugs.webkit.org/show_bug.cgi?id=112891
1030
1031         This patch is preparation work for removing
1032         WorkQueue related code from TestRunnerQt and
1033         replacing it with generic TestRunner code.
1034
1035         Reviewed by Benjamin Poulain.
1036
1037         * DumpRenderTree/qt/TestRunnerQt.cpp:
1038         (TestRunnerQt::queueBackNavigation):
1039         (TestRunnerQt::queueForwardNavigation):
1040         (TestRunnerQt::queueLoadHTMLString):
1041         (TestRunnerQt::queueReload):
1042         (TestRunnerQt::queueLoadingScript):
1043         (TestRunnerQt::queueNonLoadingScript):
1044         (TestRunner::queueLoad):
1045         * DumpRenderTree/qt/TestRunnerQt.h:
1046         (TestRunnerQt):
1047         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1048         (LoadItem::invoke):
1049         (LoadHTMLStringItem::invoke):
1050         (LoadAlternateHTMLStringItem::invoke):
1051         (ReloadItem::invoke):
1052         (ScriptItem::invoke):
1053         (BackForwardItem::invoke):
1054         * DumpRenderTree/qt/WorkQueueItemQt.h:
1055         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1056         (LoadAlternateHTMLStringItem):
1057
1058 2013-03-26  Julie Parent  <jparent@chromium.org>
1059
1060         Flakiness dashboard: simplify logic around which tests to show.
1061         https://bugs.webkit.org/show_bug.cgi?id=113250
1062
1063         Reviewed by Ojan Vafai.
1064         
1065         The different filters for showing results are only used for layout
1066         tests, otherwise, we show everything.
1067         
1068         Change the defaults to false (what layout tests used), and only
1069         look at the values when viewing layout tests.
1070
1071         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1072         (htmlForTestsWithExpectationsButNoFailures):
1073         (shouldHideTest):
1074
1075 2013-03-26  Isaac Levy  <ilevy@google.com>
1076
1077         Update bots on test-results.appspot
1078         https://bugs.webkit.org/show_bug.cgi?id=113333
1079
1080         Reviewed by Ojan Vafai.
1081
1082         * TestResultServer/static-dashboards/builders.jsonp:
1083
1084 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1085
1086         Unreviewed GTK gardening.
1087
1088         * Scripts/run-gtk-tests:
1089         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1090
1091 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1092
1093         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1094         https://bugs.webkit.org/show_bug.cgi?id=113287
1095
1096         Reviewed by Jocelyn Turcotte.
1097
1098         * Scripts/run-qtwebkit-tests:
1099         (Options.__init__):
1100
1101 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1102
1103         [EFL] Enable IndexedDB by default
1104         https://bugs.webkit.org/show_bug.cgi?id=107248
1105
1106         Reviewed by Laszlo Gombos.
1107
1108         * Scripts/webkitperl/FeatureList.pm:
1109         Enable IndexedDB by default on EFL.
1110
1111 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1112
1113         Sheriffbot should explain rollout failures in a human readable form.
1114         https://bugs.webkit.org/show_bug.cgi?id=107092
1115
1116         Reviewed by Ryosuke Niwa.
1117
1118         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1119
1120         * Scripts/webkitpy/tool/bot/irc_command.py:
1121         (Rollout._check_diff_failure):
1122         (Rollout.execute):
1123         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1124         (IRCCommandTest.test_rollout):
1125
1126 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1127
1128         Unreviewed GTK gardening.
1129
1130         * Scripts/run-gtk-tests:
1131         (TestRunner): Skipping a failing unit test after r146518.
1132
1133 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1134
1135         Remove Lion leaks builder
1136         https://bugs.webkit.org/show_bug.cgi?id=113252
1137
1138         Reviewed by Andreas Kling.
1139
1140         Removed.
1141
1142         * BuildSlaveSupport/build.webkit.org-config/config.json:
1143
1144 2013-03-25  Kent Tamura  <tkent@chromium.org>
1145
1146         Rename ENABLE_INPUT_TYPE_DATETIME
1147         https://bugs.webkit.org/show_bug.cgi?id=113254
1148
1149         Reviewed by Kentaro Hara.
1150
1151         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1152         Actually I'd like to remove the code, but we shouldn't remove it yet
1153         because we shipped products with it on some platforms.
1154
1155         * Scripts/webkitperl/FeatureList.pm:
1156         * qmake/mkspecs/features/features.pri:
1157
1158 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1159
1160         Remove one more line that was intended to be removed in r146657.
1161
1162         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1163         (summarize_results):
1164
1165 2013-03-25  Roger Fong  <roger_fong@apple.com>
1166
1167         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1168         Re-enable WinEWS tests.
1169
1170         * Scripts/webkitpy/common/config/ports.py:
1171         (WinPort.run_bindings_tests_command):
1172         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1173         (WinEWS):
1174
1175 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1176
1177         Unreviewed, rolling out r146793.
1178         http://trac.webkit.org/changeset/146793
1179         https://bugs.webkit.org/show_bug.cgi?id=113248
1180
1181         Fix did not work (Requested by rfong on #webkit).
1182
1183         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1184         (WinEWS):
1185
1186 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1187
1188         REGRESSION(r146657): Test failures reported incorrectly
1189         https://bugs.webkit.org/show_bug.cgi?id=113223
1190
1191         Reviewed by Dirk Pranke.
1192
1193         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1194
1195         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1196         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1197
1198         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1199         (Manager.run):
1200
1201         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1202         (RunDetails.__init__):
1203         (summarize_results): Remove the line I intended to remove in r146657.
1204
1205         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1206         (logging_run): Return details instead of the exit code.
1207         (run_and_capture): Ditto.
1208
1209         (RunTest.test_full_results_html):
1210         (RunTest.test_hung_thread):
1211         (RunTest.test_no_tests_found):
1212         (RunTest.test_no_tests_found_2):
1213         (RunTest.test_repeat_each_iterations_num_tests):
1214         (RunTest.test_run_singly_actually_runs_tests):
1215         (RunTest.test_test_list):
1216         (RunTest.test_missing_and_unexpected_results):
1217         (RunTest.test_pixel_test_directories):
1218         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1219         (RunTest.test_crash_with_stderr):
1220         (RunTest.test_no_image_failure_with_image_diff):
1221         (RunTest.test_crash_log):
1222         (RunTest.test_exit_after_n_failures_upload):
1223         (RunTest.test_results_directory_absolute):
1224         (RunTest.test_results_directory_relative):
1225         (RunTest.test_retrying_and_flaky_tests):
1226         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1227         (RunTest.test_retrying_uses_retries_directory):
1228         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1229         (RunTest.test_output_diffs):
1230         (EndToEndTest.test_reftest_with_two_notrefs):
1231         (RebaselineTest.test_reset_results):
1232         (RebaselineTest.test_missing_results):
1233         (RebaselineTest.test_new_baseline):
1234
1235         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1236         (BuildBotPrinter.print_results):
1237         (BuildBotPrinter.print_unexpected_results):
1238         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1239         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1240
1241 2013-03-25  Julie Parent  <jparent@chromium.org>
1242
1243         Dashboard refactor: Move cross dashboard history related code into history.js.
1244         https://bugs.webkit.org/show_bug.cgi?id=113104
1245
1246         Reviewed by Ojan Vafai.
1247
1248         All functions relating to cross dashboard behavior move from being
1249         globals to methods on the history.History object. Names stay the same,
1250         except many are made private, ones that should have been constants now
1251         are, and the long standing TODO to change "currentState" to 
1252         dashboardSpecificState is done.
1253         
1254         We now create a global history object in dashboard_base, as an 
1255         intermediate measure.  Once the dashboard specific code is
1256         added to history, each DB will need to create its own, and this
1257         global will be eliminated.
1258         
1259         * TestResultServer/static-dashboards/aggregate_results.js:
1260         (handleValidHashParameter):
1261         (htmlForBuilder):
1262         (rawValuesHTML):
1263         * TestResultServer/static-dashboards/dashboard_base.js:
1264         (parseDashboardSpecificParameters):
1265         (defaultValue):
1266         (currentBuilderGroupCategory):
1267         (currentBuilderGroupName):
1268         (handleLocationChange):
1269         (expectationsMap):
1270         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1271         (generatePage):
1272         (.switch.return):
1273         (platformAndBuildType):
1274         (individualTests):
1275         (substringList):
1276         (processMissingAndExtraExpectations):
1277         (pathToFailureLog):
1278         (showPopupForBuild):
1279         (htmlForTestsWithExpectationsButNoFailures):
1280         (shouldHideTest):
1281         (isCrossBuilderView):
1282         (tableHeaders):
1283         (htmlForSingleTestRow):
1284         (htmlForTableColumnHeader):
1285         (generatePageForExpectationsUpdate):
1286         (handleUpdate):
1287         (nextUpdate):
1288         (setUpdateIndex):
1289         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1290         (.appendExpectationsItem):
1291         (loadExpectations):
1292         (.dummyNode.onload):
1293         (loadExpectationsLayoutTests):
1294         (appendExpectations):
1295         (htmlForNavBar):
1296         (checkBoxToToggleState):
1297         (linkHTMLToToggleState):
1298         (generatePageForBuilder):
1299         (isInvalidKeyForCrossBuilderView):
1300         (handleQueryParameterChange):
1301         (showLegend):
1302         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1303         (resetGlobals):
1304         (test):
1305         * TestResultServer/static-dashboards/history.js:
1306         (.):
1307         * TestResultServer/static-dashboards/history_unittests.js:
1308         * TestResultServer/static-dashboards/loader.js:
1309         (.):
1310         * TestResultServer/static-dashboards/loader_unittests.js:
1311         * TestResultServer/static-dashboards/timeline_explorer.js:
1312         (generatePage):
1313         (initCurrentBuilderTestResults):
1314         (selectBuild):
1315         (showResultsDelta):
1316         * TestResultServer/static-dashboards/treemap.js:
1317         (generatePage):
1318         (.switch.return):
1319         (handleFocus):
1320         * TestResultServer/static-dashboards/ui.js:
1321
1322 2013-03-25  Roger Fong  <roger_fong@apple.com>
1323
1324         Unreviewed. Enable WinEWS tests again.
1325
1326         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1327         (WinEWS):
1328
1329 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1330
1331         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1332         https://bugs.webkit.org/show_bug.cgi?id=112166
1333
1334         HarfBuzz 0.9.14 merged my patch for icu detection without
1335         pkg-config files, as needed by for example Ubuntu 12.04.
1336         This obsoletes our local workaround. Removed it for GTK and EFL.
1337
1338         Reviewed by Martin Robinson.
1339
1340         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1341         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1342         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1343         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1344
1345 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1346
1347         Unreviewed.  Move self from contributor to committer list.
1348
1349         * Scripts/webkitpy/common/config/committers.py:
1350
1351 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1352
1353         EWS should use a human readable port name when uploading layout test archives
1354         https://bugs.webkit.org/show_bug.cgi?id=113099
1355
1356         Reviewed by Dirk Pranke.
1357
1358         Use new port's object's name() method to report human readable port names.
1359         This will also help us resolving the bug to apply layout test results posted by EWS.
1360
1361         * Scripts/webkitpy/tool/bot/botinfo.py:
1362         (BotInfo.__init__): Take port's name.
1363         (BotInfo.summary_text):
1364
1365         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1366         (BotInfoTest.test_summary_text):
1367
1368         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1369         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1370
1371         * Scripts/webkitpy/tool/commands/queues.py:
1372         (PatchProcessingQueue.__init__): Initialize self._port.
1373         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1374         and use that for the attachment filename and the comment posted.
1375
1376         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1377         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1378         "mac-snowleopard" as expected for TestPort.
1379
1380 2013-03-22  Roger Fong  <roger_fong@apple.com>
1381
1382         Unreviewed. Turn off EWS test on Win again.
1383         The battle continues.
1384
1385         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1386         (WinEWS):
1387
1388 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1389
1390         NRWT: Enable pixel tests when retrying tests
1391         https://bugs.webkit.org/show_bug.cgi?id=112898
1392
1393         Reviewed by Dirk Pranke.
1394
1395         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1396         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1397         if we've forced pixel tests in the retry.
1398         (Manager._run_tests):
1399         (Manager._clean_up_run): Fixed the capitalizations.
1400         (Manager._force_pixel_tests_if_needed): Added.
1401
1402         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1403         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1404         'image_diff_percent' if it doesn't already exist.
1405
1406         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1407         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1408         treat this as a regular regression instead of a flakiness.
1409
1410         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1411         run had image diffs.
1412
1413         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1414         (summarized_results):
1415
1416         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1417         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1418         Also removed some dead code.
1419
1420         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1421         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1422         is set and pixel_tests_enabled is set to false.
1423         (EndToEndTest.test_reftest_with_two_notrefs):
1424
1425 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1426
1427         Make it possible to run layout tests on Retina MBP
1428         https://bugs.webkit.org/show_bug.cgi?id=93673
1429
1430         Reviewed by Ryosuke Niwa.
1431
1432         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1433         windows on 2x machines still run at 1x.
1434
1435         * DumpRenderTree/mac/DumpRenderTree.mm:
1436         (createWebViewAndOffscreenWindow):
1437         Reset the window resolution to 1x on creation.
1438         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
1439         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1440         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
1441         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1442         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
1443         (WTR::PlatformWebView::PlatformWebView):
1444         Add NSWindow details, reset the window resolution to 1x on creation.
1445
1446 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1447
1448         Leak bots shouldn't build
1449         https://bugs.webkit.org/show_bug.cgi?id=112774
1450
1451         Reviewed by Simon Fraser.
1452
1453         Since leak bots use regular debug builds, there is no need to build on these bots.
1454         Simply downloading builds will dramatically improve the cycle time of these bots.
1455
1456         * BuildSlaveSupport/build.webkit.org-config/config.json:
1457         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1458         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
1459         TestFactory instead of BuildAndTestFactory.
1460
1461 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1462
1463         [Qt] Fix the TestWebKitAPI build
1464         https://bugs.webkit.org/show_bug.cgi?id=113044
1465
1466         Reviewed by Tor Arne Vestbø.
1467
1468         The generate-forwarding-headers script would only be run
1469         after the targets in InjectedBundle.pri since the second
1470         addStrictSubdirOrderBetween call in
1471         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
1472         the derived_sources -> injected_bundle order in SUBDIRS.
1473
1474         Fix it by only moving the dependent target at the end of
1475         SUBDIRS, don't touch its dependency.
1476
1477         * qmake/mkspecs/features/functions.prf:
1478
1479 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1480
1481         [EFL][WK2] View is not focused when fullscreen mode toggled
1482         https://bugs.webkit.org/show_bug.cgi?id=113009
1483
1484         Reviewed by Laszlo Gombos.
1485
1486         Set focus on view when fullscreen mode enabled/disabled
1487         by FullScreen API.
1488
1489         * MiniBrowser/efl/main.c:
1490         (on_fullscreen_accept):
1491         (on_fullscreen_deny):
1492
1493 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1494
1495         nrwt is no longer saving retry results in the retries/ subdirectory
1496         https://bugs.webkit.org/show_bug.cgi?id=112995
1497
1498         Reviewed by Ojan Vafai.
1499
1500         I think this has been broken a long time, unfortunately. This
1501         patch should fix that.
1502
1503         In order to do so, I had to pass the directory to use from
1504         the Worker object through the SingleTestWriter to the
1505         TestResultWriter. While I was plumbing that through, I rationalized
1506         the order of the parameter arguments a bit ...
1507
1508         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1509         (Worker._run_single_test):
1510         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1511         (run_single_test):
1512         (SingleTestRunner.__init__):
1513         (SingleTestRunner._run_compare_test):
1514         (SingleTestRunner._run_rebaseline):
1515         (SingleTestRunner._run_reftest):
1516         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1517         (write_test_result):
1518         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1519         (TestResultWriterTest.test_reftest_diff_image):
1520         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1521         (RunTest.test_retrying_uses_retries_directory):
1522
1523 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
1524
1525         JSC profiler should have an at-a-glance report of the success of DFG optimization
1526         https://bugs.webkit.org/show_bug.cgi?id=112988
1527
1528         Reviewed by Geoffrey Garen.
1529
1530         * Scripts/display-profiler-output:
1531
1532 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1533
1534         [chromium] Linux ASAN WebKit canary is running out of memory
1535         https://bugs.webkit.org/show_bug.cgi?id=112978
1536
1537         Reviewed by Tony Chang.
1538
1539         Running the AddressSanitizer on a crash takes a lot of
1540         memory, so we should serialize access to it to avoid running
1541         out of memory on a machine.
1542
1543         * Scripts/webkitpy/layout_tests/port/chromium.py:
1544         (ChromiumPort._get_crash_log):
1545         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1546         (HttpLock.__init__):
1547         (HttpLock.wait_for_httpd_lock):
1548
1549 2013-03-21  Min Qin  <qinmin@chromium.org>
1550
1551         Cleanup android media layout test code
1552         https://bugs.webkit.org/show_bug.cgi?id=112944
1553
1554         Reviewed by Adam Barth.
1555
1556         Chromium change: https://codereview.chromium.org/12892010/
1557         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
1558         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
1559         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
1560         Instead, we should switch to use content shell for layout tests.
1561
1562         * DumpRenderTree/chromium/TestShell.cpp:
1563         (TestShell::resetTestController):
1564
1565 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1566
1567         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
1568         https://bugs.webkit.org/show_bug.cgi?id=112953
1569
1570         Reviewed by Tony Chang.
1571
1572         When I created the DumpRenderTree_resources target in r144863 I
1573         forgot to declare the needed dependencies on the other resource
1574         targets. Due to a quirk of ordering, this appears to have been fine
1575         w/ ninja but not w/ Xcode (which is still being used on the chromium
1576         mac valgrind bots). Declaring the dependencies fixes the build
1577         failures.
1578
1579         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1580
1581 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
1582
1583         [WinCairo] Correct assert in Empty BitmapImage Test.
1584         https://bugs.webkit.org/show_bug.cgi?id=112934
1585
1586         Reviewed by Tim Horton.
1587
1588         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1589         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
1590         to avoid ref counting assertion when leaving test scope.
1591
1592 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
1593
1594         [GTK] generate-feature-defines-files is incompatible with Python3
1595         https://bugs.webkit.org/show_bug.cgi?id=112956
1596
1597         Reviewed by Martin Robinson.
1598
1599         Make the generate-feature-defines-files compatible with Python3 by calling the items()
1600         method on the dictionary objects when iterating through said dictionaries.
1601
1602         * gtk/generate-feature-defines-files:
1603         (write_feature_defines_header):
1604         (write_flattened_feature_defines_file):
1605
1606 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1607
1608         kill-old-processes spits out error messages on Mac
1609         https://bugs.webkit.org/show_bug.cgi?id=112878
1610
1611         Reviewed by Jessie Berlin.
1612
1613         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
1614         included in the list of options grep --help shows.
1615
1616         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
1617
1618         * BuildSlaveSupport/kill-old-processes:
1619         (main):
1620
1621 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
1622
1623         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
1624         https://bugs.webkit.org/show_bug.cgi?id=112597
1625
1626         Reviewed by Xan Lopez.
1627
1628         These were introduced for the Chromium port in r105295. We need
1629         dummy implementations in order to compile the BlackBerry port.
1630
1631         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1632         (AccessibilityUIElement::scrollToMakeVisible):
1633         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1634         (AccessibilityUIElement::scrollToGlobalPoint):
1635
1636 2013-03-21  Roger Fong  <roger_fong@apple.com>
1637
1638         Re-enable WinEWS tests following r146376.
1639
1640         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1641         (WinEWS):
1642
1643 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
1644
1645         Unreviewed. Add Bem Jones-Bey to the list of contributors.
1646
1647         * Scripts/webkitpy/common/config/committers.py:
1648
1649 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1650
1651         [GTK] Missing atk in install-dependencies script
1652         https://bugs.webkit.org/show_bug.cgi?id=112272
1653
1654         Reviewed by Gustavo Noronha Silva.
1655
1656         * gtk/install-dependencies: Add missing atk dependency.
1657
1658 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1659
1660         [GTK] Missing backslash in install-dependencies script
1661         https://bugs.webkit.org/show_bug.cgi?id=112907
1662
1663         Reviewed by Philippe Normand.
1664
1665         * gtk/install-dependencies: Add missing backslash to dependencies
1666         list.
1667
1668 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1669
1670         EWS bots have stopped uploading results to bugzilla
1671         https://bugs.webkit.org/show_bug.cgi?id=101091
1672
1673         Reviewed by Adam Barth.
1674
1675         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
1676         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
1677         this relative file path resoled to a file inside a non-existent directory for "zip".
1678
1679         Fixed the bug by resolving both test results directory and zip archive paths in
1680         LayoutTestResultsReader.archive.
1681
1682         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
1683         in the future.
1684
1685         * Scripts/webkitpy/common/system/filesystem_mock.py:
1686         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
1687
1688         * Scripts/webkitpy/common/system/workspace.py:
1689         (Workspace.create_zip): Log the source path when "zip" failed.
1690
1691         * Scripts/webkitpy/common/system/workspace_mock.py:
1692         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
1693
1694         * Scripts/webkitpy/common/system/workspace_unittest.py:
1695         (WorkspaceTest.test_create_zip_exception): Test that.
1696
1697         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1698         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
1699         This is the actual bug fix.
1700
1701         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1702         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
1703
1704 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
1705
1706         [chromium] move WebThemeEngine implementations to TestRunner library
1707         https://bugs.webkit.org/show_bug.cgi?id=112751
1708
1709         Reviewed by Adam Barth.
1710
1711         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1712         * DumpRenderTree/DumpRenderTree.gypi:
1713         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1714         (WebKit):
1715         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1716         (WebTestRunner::TestInterfaces::themeEngine):
1717         (WebTestRunner):
1718         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1719         (WebKit):
1720         (TestInterfaces):
1721         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1722         (WebTestRunner::WebTestInterfaces::themeEngine):
1723         (WebTestRunner):
1724         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1725         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1726         (WebTestRunner):
1727         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1728         (WebTestRunner::WebTestThemeControlWin::box):
1729         (WebTestRunner::WebTestThemeControlWin::line):
1730         (WebTestRunner::WebTestThemeControlWin::triangle):
1731         (WebTestRunner::WebTestThemeControlWin::roundRect):
1732         (WebTestRunner::WebTestThemeControlWin::oval):
1733         (WebTestRunner::WebTestThemeControlWin::circle):
1734         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1735         (WebTestRunner::WebTestThemeControlWin::markState):
1736         (WebTestRunner::WebTestThemeControlWin::draw):
1737         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1738         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1739         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1740         (WebTestRunner):
1741         (WebTestThemeControlWin):
1742         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1743         (WebTestRunner):
1744         (WebTestThemeEngineMac):
1745         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1746         (+[FakeActiveWindow alwaysActiveWindow]):
1747         (+[FakeActiveWindow alwaysInactiveWindow]):
1748         (-[FakeActiveWindow initWithActiveControls:]):
1749         (-[FakeActiveWindow _hasActiveControls]):
1750         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1751         (WebTestRunner):
1752         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1753         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1754         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1755         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1756         (WebTestRunner):
1757         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1758         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1759         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1760         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1761         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1762         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1763         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1764         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1765         (WebTestRunner::WebTestThemeEngineWin::getSize):
1766         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1767         (WebTestRunner):
1768         (WebTestThemeEngineWin):
1769         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1770         * DumpRenderTree/chromium/TestShell.cpp:
1771         (TestShell::initialize):
1772         * DumpRenderTree/chromium/TestShell.h:
1773         (WebKit):
1774         * DumpRenderTree/chromium/TestShellMac.mm:
1775         (platformInit):
1776         * DumpRenderTree/chromium/TestShellWin.cpp:
1777         (platformInit):
1778         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1779
1780 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1781
1782         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
1783
1784         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
1785         New property sheet that does not link against CoreFoundation and
1786         CFNetwork.
1787         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1788         Use new TestWebKitAPICommonWinCairo property sheet.
1789         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1790         Ditto.
1791
1792 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1793
1794         [WinCairo] Unreviewed build fix for VS2010.
1795
1796         Had to add WinCairo-specific property sheets to deal with some
1797         library and path differences with the main Apple port.
1798
1799         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1800         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1801         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1802         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
1803         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
1804         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
1805
1806 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
1807
1808         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
1809         https://bugs.webkit.org/show_bug.cgi?id=112849
1810
1811         Reviewed by Sam Weinig.
1812
1813         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1814         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1815         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1816
1817 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1818
1819         [WinCairo] Build WebKit Tools under VS2010
1820         https://bugs.webkit.org/show_bug.cgi?id=112821
1821
1822         Reviewed by Tim Horton.
1823
1824         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1825         Add WinCairo-specific build target.
1826         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
1827         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
1828         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
1829         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
1830         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1831         Add WinCairo-specific build target.
1832         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1833         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1834         Add WinCairo-specific build target.
1835         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
1836         WinCairo-specific build target.
1837         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
1838         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
1839         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
1840         specific build target.
1841         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
1842         WinCairo-specific build target.
1843         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
1844         * win/record-memory/record-memoryDebugWinCairo.props: Added.
1845         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
1846
1847 2013-03-20  Roger Fong  <roger_fong@apple.com>
1848
1849         API test gardening AppleWin port.
1850
1851         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
1852
1853         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1854         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1855
1856 2013-03-20  Roger Fong  <roger_fong@apple.com>
1857
1858         Test fix for Win EWS bots, catch various errors and restart script if necessary.
1859
1860         * EWSTools/start-queue-win.sh:
1861
1862 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
1863
1864         Unreviewed, add myself to committers.py.
1865
1866 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1867
1868         Unreviewed. Adding another email for me.
1869
1870         * Scripts/webkitpy/common/config/committers.py:
1871
1872 2013-03-20  Justin Novosad  <junov@google.com>
1873
1874         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
1875         https://bugs.webkit.org/show_bug.cgi?id=112605
1876
1877         Reviewed by James Robinson.
1878
1879         Deleting all the code that was used for propagating and supporting
1880         the Chromium setting for disabling deferred 2d canvas rendering.
1881
1882         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1883         (main):
1884         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1885         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1886         (WebTestRunner::WebPreferences::reset):
1887         (WebTestRunner::WebPreferences::applyTo):
1888         * DumpRenderTree/chromium/TestShell.cpp:
1889         (TestShell::TestShell):
1890         (TestShell::resetWebSettings):
1891         (TestShell::runFileTest):
1892         * DumpRenderTree/chromium/TestShell.h:
1893         (TestShell):
1894
1895 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
1896
1897         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
1898         https://bugs.webkit.org/show_bug.cgi?id=112699.
1899
1900         Reviewed by Adam Barth.
1901
1902         * Scripts/webkitpy/layout_tests/port/qt.py:
1903         (QtPort._search_paths):
1904         (QtPort._port_specific_expectations_files):
1905         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1906         (QtPortTest):
1907         (QtPortTest._assert_search_path):
1908         (QtPortTest._assert_expectations_files):
1909
1910 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1911
1912         [Qt] Enable kerning by default
1913         https://bugs.webkit.org/show_bug.cgi?id=112704
1914
1915         Reviewed by Jocelyn Turcotte.
1916
1917         Disable kerning by default, since some reference test expectations
1918         expect kerning to be default off.
1919
1920         * DumpRenderTree/qt/TestRunnerQt.cpp:
1921         (TestRunnerQt::reset):
1922         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1923         (WTR::activateFonts):
1924
1925 2013-03-20  Zeno Albisser  <zeno@webkit.org>
1926
1927         [Qt] Remove empty function stubs from TestRunnerQt.
1928         https://bugs.webkit.org/show_bug.cgi?id=112799
1929
1930         We are reducing the code in TestRunnerQt step by step,
1931         in order to finally replace all of it with the generic
1932         TestRunner implementation.
1933         This patch removes several simple function stubs that
1934         currently do not implement any actual functionality.
1935
1936         Reviewed by Kenneth Rohde Christiansen.
1937
1938         * DumpRenderTree/qt/TestRunnerQt.cpp:
1939         * DumpRenderTree/qt/TestRunnerQt.h:
1940         (TestRunnerQt):
1941
1942 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1943
1944         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
1945         https://bugs.webkit.org/show_bug.cgi?id=112687
1946
1947         Reviewed by Kenneth Rohde Christiansen.
1948
1949         Hide the SearchBar by default on window creation.
1950
1951         * MiniBrowser/efl/main.c:
1952         (window_create):
1953
1954 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1955
1956         Unreviewed, rolling out r146304.
1957         http://trac.webkit.org/changeset/146304
1958         https://bugs.webkit.org/show_bug.cgi?id=112788
1959
1960         to many expectations to update (Requested by antonm on
1961         #webkit).
1962
1963         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1964         * DumpRenderTree/DumpRenderTree.gypi:
1965         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1966         (WebKit):
1967         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1968         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1969         (TestInterfaces):
1970         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1971         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1972         * DumpRenderTree/chromium/TestShell.cpp:
1973         (TestShell::initialize):
1974         * DumpRenderTree/chromium/TestShell.h:
1975         (WebKit):
1976         * DumpRenderTree/chromium/TestShellMac.mm:
1977         (platformInit):
1978         * DumpRenderTree/chromium/TestShellWin.cpp:
1979         (platformInit):
1980         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1981         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1982         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1983         (WebThemeControlDRTWin::box):
1984         (WebThemeControlDRTWin::line):
1985         (WebThemeControlDRTWin::triangle):
1986         (WebThemeControlDRTWin::roundRect):
1987         (WebThemeControlDRTWin::oval):
1988         (WebThemeControlDRTWin::circle):
1989         (WebThemeControlDRTWin::nestedBoxes):
1990         (WebThemeControlDRTWin::markState):
1991         (WebThemeControlDRTWin::draw):
1992         (WebThemeControlDRTWin::drawTextField):
1993         (WebThemeControlDRTWin::drawProgressBar):
1994         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1995         (WebThemeControlDRTWin):
1996         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1997         (WebThemeEngineDRTMac):
1998         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1999         (+[FakeActiveWindow alwaysActiveWindow]):
2000         (+[FakeActiveWindow alwaysInactiveWindow]):
2001         (-[FakeActiveWindow initWithActiveControls:]):
2002         (-[FakeActiveWindow _hasActiveControls]):
2003         (WebThemeEngineDRTMac::paintScrollbarThumb):
2004         (stateToHIEnableState):
2005         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2006         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2007         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2008         (webRectToSkIRect):
2009         (drawControl):
2010         (drawTextField):
2011         (drawProgressBar):
2012         (WebThemeEngineDRTWin::paintButton):
2013         (WebThemeEngineDRTWin::paintMenuList):
2014         (WebThemeEngineDRTWin::paintScrollbarArrow):
2015         (WebThemeEngineDRTWin::paintScrollbarThumb):
2016         (WebThemeEngineDRTWin::paintScrollbarTrack):
2017         (WebThemeEngineDRTWin::paintSpinButton):
2018         (WebThemeEngineDRTWin::paintTextField):
2019         (WebThemeEngineDRTWin::paintTrackbar):
2020         (WebThemeEngineDRTWin::paintProgressBar):
2021         (WebThemeEngineDRTWin::getSize):
2022         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2023         (WebThemeEngineDRTWin):
2024         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2025
2026 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2027
2028         [Qt] Support -webkit-font-smoothing
2029         https://bugs.webkit.org/show_bug.cgi?id=106009
2030
2031         Reviewed by Jocelyn Turcotte.
2032
2033         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2034
2035         * DumpRenderTree/qt/TestRunnerQt.cpp:
2036         (TestRunnerQt::reset):
2037
2038 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2039
2040         [GTK] accessibility/aria-scrollbar-role.html is failing
2041         https://bugs.webkit.org/show_bug.cgi?id=98358
2042
2043         Reviewed by Martin Robinson.
2044
2045         Adds support for checking accessibility object's orientation.
2046         Orientation is checked by retrieving proper state of accessibility object.
2047
2048         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2049         (checkElementState):
2050         (AccessibilityUIElement::orientation):
2051         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2052         (WTR::AccessibilityUIElement::orientation):
2053
2054 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2055
2056         [chromium] move WebThemeEngine implementations to TestRunner library
2057         https://bugs.webkit.org/show_bug.cgi?id=112751
2058
2059         Reviewed by Adam Barth.
2060
2061         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2062         * DumpRenderTree/DumpRenderTree.gypi:
2063         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2064         (WebKit):
2065         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2066         (WebTestRunner::TestInterfaces::themeEngine):
2067         (WebTestRunner):
2068         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2069         (WebKit):
2070         (TestInterfaces):
2071         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2072         (WebTestRunner::WebTestInterfaces::themeEngine):
2073         (WebTestRunner):
2074         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2075         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2076         (WebTestRunner):
2077         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2078         (WebTestRunner::WebTestThemeControlWin::box):
2079         (WebTestRunner::WebTestThemeControlWin::line):
2080         (WebTestRunner::WebTestThemeControlWin::triangle):
2081         (WebTestRunner::WebTestThemeControlWin::roundRect):
2082         (WebTestRunner::WebTestThemeControlWin::oval):
2083         (WebTestRunner::WebTestThemeControlWin::circle):
2084         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2085         (WebTestRunner::WebTestThemeControlWin::markState):
2086         (WebTestRunner::WebTestThemeControlWin::draw):
2087         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2088         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2089         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2090         (WebTestRunner):
2091         (WebTestThemeControlWin):
2092         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2093         (WebTestRunner):
2094         (WebTestThemeEngineMac):
2095         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2096         (+[FakeActiveWindow alwaysActiveWindow]):
2097         (+[FakeActiveWindow alwaysInactiveWindow]):
2098         (-[FakeActiveWindow initWithActiveControls:]):
2099         (-[FakeActiveWindow _hasActiveControls]):
2100         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2101         (WebTestRunner):
2102         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2103         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2104         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2105         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2106         (WebTestRunner):
2107         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2108         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2109         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2110         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2111         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2112         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2113         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2114         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2115         (WebTestRunner::WebTestThemeEngineWin::getSize):
2116         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2117         (WebTestRunner):
2118         (WebTestThemeEngineWin):
2119         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2120         * DumpRenderTree/chromium/TestShell.cpp:
2121         (TestShell::initialize):
2122         * DumpRenderTree/chromium/TestShell.h:
2123         (WebKit):
2124         * DumpRenderTree/chromium/TestShellMac.mm:
2125         (platformInit):
2126         * DumpRenderTree/chromium/TestShellWin.cpp:
2127         (platformInit):
2128         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2129
2130 2013-03-19  Tony Chang  <tony@chromium.org>
2131
2132         Move testRunner.setTouchDragDropEnabled to internals.settings
2133         https://bugs.webkit.org/show_bug.cgi?id=112739
2134
2135         Reviewed by Adam Barth.
2136
2137         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2138         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2139         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2140         (TestRunner): Remove unnecessary code.
2141         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2142         (WebTestRunner::WebPreferences::reset):
2143         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2144
2145 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2146
2147         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2148         https://bugs.webkit.org/show_bug.cgi?id=112754
2149
2150         Reviewed by Darin Fisher.
2151
2152         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2153         now that it's always defined.
2154
2155         * DumpRenderTree/chromium/WebViewHost.cpp:
2156         * DumpRenderTree/chromium/WebViewHost.h:
2157         (WebViewHost):
2158
2159 2013-03-19  Kenneth Russell  <kbr@google.com>
2160
2161         Unreviewed, rolling out r146290.
2162         http://trac.webkit.org/changeset/146290
2163         https://bugs.webkit.org/show_bug.cgi?id=112751
2164
2165         Broke Chromium Mac build.
2166
2167         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2168         * DumpRenderTree/DumpRenderTree.gypi:
2169         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2170         (WebKit):
2171         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2172         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2173         (TestInterfaces):
2174         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2175         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2176         * DumpRenderTree/chromium/TestShell.cpp:
2177         (TestShell::initialize):
2178         * DumpRenderTree/chromium/TestShell.h:
2179         (WebKit):
2180         * DumpRenderTree/chromium/TestShellMac.mm:
2181         (platformInit):
2182         * DumpRenderTree/chromium/TestShellWin.cpp:
2183         (platformInit):
2184         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2185         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2186         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2187         (WebThemeControlDRTWin::box):
2188         (WebThemeControlDRTWin::line):
2189         (WebThemeControlDRTWin::triangle):
2190         (WebThemeControlDRTWin::roundRect):
2191         (WebThemeControlDRTWin::oval):
2192         (WebThemeControlDRTWin::circle):
2193         (WebThemeControlDRTWin::nestedBoxes):
2194         (WebThemeControlDRTWin::markState):
2195         (WebThemeControlDRTWin::draw):
2196         (WebThemeControlDRTWin::drawTextField):
2197         (WebThemeControlDRTWin::drawProgressBar):
2198         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2199         (WebThemeControlDRTWin):
2200         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2201         (WebThemeEngineDRTMac):
2202         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2203         (+[FakeActiveWindow alwaysActiveWindow]):
2204         (+[FakeActiveWindow alwaysInactiveWindow]):
2205         (-[FakeActiveWindow initWithActiveControls:]):
2206         (-[FakeActiveWindow _hasActiveControls]):
2207         (WebThemeEngineDRTMac::paintScrollbarThumb):
2208         (stateToHIEnableState):
2209         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2210         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2211         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2212         (webRectToSkIRect):
2213         (drawControl):
2214         (drawTextField):
2215         (drawProgressBar):
2216         (WebThemeEngineDRTWin::paintButton):
2217         (WebThemeEngineDRTWin::paintMenuList):
2218         (WebThemeEngineDRTWin::paintScrollbarArrow):
2219         (WebThemeEngineDRTWin::paintScrollbarThumb):
2220         (WebThemeEngineDRTWin::paintScrollbarTrack):
2221         (WebThemeEngineDRTWin::paintSpinButton):
2222         (WebThemeEngineDRTWin::paintTextField):
2223         (WebThemeEngineDRTWin::paintTrackbar):
2224         (WebThemeEngineDRTWin::paintProgressBar):
2225         (WebThemeEngineDRTWin::getSize):
2226         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2227         (WebThemeEngineDRTWin):
2228         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2229
2230 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2231
2232         [EFL] canvas-fallback-content.html is failing
2233         https://bugs.webkit.org/show_bug.cgi?id=111998
2234
2235         Reviewed by Chris Fleizach.
2236
2237         Adds support for getting platform name.
2238
2239         * DumpRenderTree/TestRunner.cpp:
2240         (TestRunner::staticValues):
2241         * DumpRenderTree/TestRunner.h:
2242         (TestRunner):
2243         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2244         (TestRunner::platformName):
2245
2246 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2247
2248         [chromium] move WebThemeEngine implementations to TestRunner library
2249         https://bugs.webkit.org/show_bug.cgi?id=112751
2250
2251         Reviewed by Adam Barth.
2252
2253         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2254         * DumpRenderTree/DumpRenderTree.gypi:
2255         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2256         (WebKit):
2257         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2258         (WebTestRunner::TestInterfaces::themeEngine):
2259         (WebTestRunner):
2260         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2261         (WebKit):
2262         (TestInterfaces):
2263         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2264         (WebTestRunner::WebTestInterfaces::themeEngine):
2265         (WebTestRunner):
2266         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2267         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2268         (WebTestRunner):
2269         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2270         (WebTestRunner::WebTestThemeControlWin::box):
2271         (WebTestRunner::WebTestThemeControlWin::line):
2272         (WebTestRunner::WebTestThemeControlWin::triangle):
2273         (WebTestRunner::WebTestThemeControlWin::roundRect):
2274         (WebTestRunner::WebTestThemeControlWin::oval):
2275         (WebTestRunner::WebTestThemeControlWin::circle):
2276         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2277         (WebTestRunner::WebTestThemeControlWin::markState):
2278         (WebTestRunner::WebTestThemeControlWin::draw):
2279         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2280         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2281         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2282         (WebTestRunner):
2283         (WebTestThemeControlWin):
2284         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2285         (WebTestRunner):
2286         (WebTestThemeEngineMac):
2287         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2288         (+[FakeActiveWindow alwaysActiveWindow]):
2289         (+[FakeActiveWindow alwaysInactiveWindow]):
2290         (-[FakeActiveWindow initWithActiveControls:]):
2291         (-[FakeActiveWindow _hasActiveControls]):
2292         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2293         (WebTestRunner):
2294         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2295         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2296         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2297         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2298         (WebTestRunner):
2299         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2300         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2301         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2302         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2303         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2304         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2305         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2306         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2307         (WebTestRunner::WebTestThemeEngineWin::getSize):
2308         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2309         (WebTestRunner):
2310         (WebTestThemeEngineWin):
2311         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2312         * DumpRenderTree/chromium/TestShell.cpp:
2313         (TestShell::initialize):
2314         * DumpRenderTree/chromium/TestShell.h:
2315         (WebKit):
2316         * DumpRenderTree/chromium/TestShellMac.mm:
2317         (platformInit):
2318         * DumpRenderTree/chromium/TestShellWin.cpp:
2319         (platformInit):
2320         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2321
2322 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2323
2324         [EFL][WK2] Separate WebView further from EwkView
2325         https://bugs.webkit.org/show_bug.cgi?id=111591
2326
2327         Reviewed by Caio Marcelo de Oliveira Filho.
2328
2329         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2330         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2331         since we can afford it having EWKViewGetWKView() private API to access WKView.
2332
2333         * TestWebKitAPI/PlatformWebView.h:
2334         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2335         (TestWebKitAPI::TEST):
2336         * TestWebKitAPI/efl/PlatformWebView.cpp:
2337         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2338         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2339         (TestWebKitAPI::PlatformWebView::resizeTo):
2340         (TestWebKitAPI::PlatformWebView::page):
2341         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2342         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2343         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2344         * WebKitTestRunner/PlatformWebView.h:
2345         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2346         (WTR::EventSenderProxy::dispatchEvent):
2347         (WTR::EventSenderProxy::keyDown):
2348         (WTR::EventSenderProxy::sendTouchEvent):
2349         (WTR::EventSenderProxy::setTouchModifier):
2350         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2351         (WTR::PlatformWebView::PlatformWebView):
2352         (WTR::PlatformWebView::~PlatformWebView):
2353         (WTR::PlatformWebView::resizeTo):
2354         (WTR::PlatformWebView::page):
2355         (WTR::PlatformWebView::focus):
2356         (WTR::PlatformWebView::windowSnapshotImage):
2357
2358 2013-03-19  Roger Fong  <roger_fong@apple.com>
2359
2360         Changes to VS2010 project files should only trigger builds on Windows bots.
2361         https://bugs.webkit.org/show_bug.cgi?id=112731
2362
2363         Reviewed by Timothy Horton.
2364
2365         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2366         (_should_file_trigger_build):
2367
2368 2013-03-19  Roger Fong  <roger_fong@apple.com>
2369
2370         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2371
2372         * Scripts/webkitpy/tool/steps/runtests.py:
2373         (RunTests.run):
2374         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2375         (RunTestsTest.test_webkit_run_unit_tests):
2376
2377 2013-03-19  Julie Parent  <jparent@chromium.org>
2378
2379         Dashboards: Introduce history namespace and unit tests.
2380         https://bugs.webkit.org/show_bug.cgi?id=112645
2381
2382         Reviewed by Ojan Vafai.
2383         
2384         Laying the framework for introducing the new history object and
2385         namespace.  This moves only static functions into the history
2386         namespace, and moves corresponding unit tests into seperate
2387         unit test file.
2388
2389         * TestResultServer/static-dashboards/aggregate_results.html:
2390         * TestResultServer/static-dashboards/dashboard_base.js:
2391         (parseCrossDashboardParameters):
2392         (parseDashboardSpecificParameters):
2393         (parseParameters):
2394         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2395         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2396         (.switch.return):
2397         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2398         * TestResultServer/static-dashboards/history.js: Added.
2399         * TestResultServer/static-dashboards/history_unittests.js: Added.
2400         * TestResultServer/static-dashboards/loader.js:
2401         (.):
2402         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2403         * TestResultServer/static-dashboards/run-unittests.html:
2404         * TestResultServer/static-dashboards/timeline_explorer.html:
2405         * TestResultServer/static-dashboards/timeline_explorer.js:
2406         * TestResultServer/static-dashboards/treemap.html:
2407         * TestResultServer/static-dashboards/treemap.js:
2408         (.switch.return):
2409         * TestResultServer/static-dashboards/ui.js:
2410
2411 2013-03-19  Daniel Bates  <dbates@webkit.org>
2412
2413         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2414         https://bugs.webkit.org/show_bug.cgi?id=112732
2415
2416         Reviewed by Eric Seidel.
2417
2418         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2419         of an existing file cannot be applied.
2420
2421         In particular, svn-{apply, unapply} compensate for differences in line endings
2422         by converting the line endings in a diff to match the line endings in the target
2423         file. The diff(1) command precedes the last line of a diff that adds a newline
2424         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2425         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2426         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2427         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2428         the newline characters in this special character sequence to match the line endings
2429         in the target file.
2430
2431         * Scripts/VCSUtils.pm:
2432         (parseDiff):
2433         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2434         Added tests:
2435             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2436             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2437             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2438             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2439         (escapeNewLineCharacters): Added.
2440         (toMacLineEndings): Added.
2441
2442 2013-03-19  James Robinson  <jamesr@chromium.org>
2443
2444         [chromium] Remove compositor settings that don't go through WebKit
2445         https://bugs.webkit.org/show_bug.cgi?id=112718
2446
2447         Reviewed by Adam Barth.
2448
2449         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2450         (main):
2451         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2452         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2453         (WebTestRunner::WebPreferences::reset):
2454         (WebTestRunner::WebPreferences::applyTo):
2455         * DumpRenderTree/chromium/TestShell.cpp:
2456         (TestShell::TestShell):
2457         (TestShell::resetWebSettings):
2458         * DumpRenderTree/chromium/TestShell.h:
2459         (TestShell):
2460
2461 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
2462
2463         Unreviewed, rolling out r146101.
2464         https://bugs.webkit.org/show_bug.cgi?id=111884
2465
2466         re-enable custom freetype on asan; this needs to be on
2467         now that the bot is running lucid.
2468
2469         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2470
2471 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
2472
2473         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
2474         https://bugs.webkit.org/show_bug.cgi?id=112365
2475
2476         Reviewed by Benjamin Poulain.
2477
2478         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
2479         harcoding it in wtf/Platform.h
2480
2481         * Scripts/webkitperl/FeatureList.pm:
2482
2483 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2484
2485         [Qt] Make ImageDiff similar to Chromium's ImageDiff
2486         https://bugs.webkit.org/show_bug.cgi?id=94782
2487
2488         Based on patch by Csaba Osztrogonác.
2489         Reviewed by Jocelyn Turcotte.
2490
2491         The diff image is generated with bright red indicating errors, but letting the base image
2492         shine through so the context of the error-pixel can be identified.
2493
2494         * DumpRenderTree/qt/ImageDiff.cpp:
2495         (main):
2496
2497 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
2498
2499         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
2500
2501         Rubber-stamped by Csaba Osztrogonác.
2502
2503         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
2504         since the latter might not cover the former.
2505
2506         * QtTestBrowser/launcherwindow.cpp:
2507         (LauncherWindow::print):
2508
2509 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2510
2511         Style tweeks to default.css.
2512         
2513         Rubber-stamped by David Kilzer.
2514         
2515         Give visited links a different color to other links, so you can
2516         see which builds you've viewed.
2517         
2518         Make the <small> text less tiny.
2519
2520         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2521         (small):
2522         (a:link,a:visited,a:active):
2523         (a:visited):
2524
2525 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2526
2527         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
2528         https://bugs.webkit.org/show_bug.cgi?id=112494
2529
2530         Reviewed by Dirk Pranke.
2531
2532         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
2533         Also merged two pairs of methods to cleanup the code.
2534
2535         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2536         (PerfTestsRunner.run): Merged _upload_and_show_results.
2537         (PerfTestsRunner._generate_results): Merged _generate_output_files.
2538
2539 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2540
2541         [chromium] build xdisplaycheck when building DRT
2542         https://bugs.webkit.org/show_bug.cgi?id=112636
2543
2544         Reviewed by Tony Chang.
2545
2546         It appears that we need xdisplaycheck to be built in order for
2547         Xvfb to be started correctly on the bots, and DRT was missing
2548         a dependency on it. This may be the cause of the ASAN bot not
2549         starting up properly (it only builds DRT).
2550
2551         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2552
2553 2013-03-18  David Levin  <levin@chromium.org>
2554
2555         Implement icon change notification dump for Chromium's test shell.
2556         https://bugs.webkit.org/show_bug.cgi?id=112614
2557
2558         This was previously implemented for some other platforms in r58111
2559         and r116547.
2560
2561         In r122806, fast/dom/icon-url-property.html stopped using it, but
2562         it is useful for tests, so I plan to re-add it to that test again.
2563
2564         Reviewed by Jochen Eisinger.
2565
2566         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2567         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
2568          icon change notifications from WebKit may be logged in test output.
2569         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2570         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
2571         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
2572         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
2573         (WebTestRunner):
2574         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
2575         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2576         (TestRunner):
2577         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2578         (WebTestRunner::WebTestProxyBase::didChangeIcon):
2579         (WebTestRunner):
2580         * DumpRenderTree/chromium/WebViewHost.cpp:
2581         (WebViewHost::didChangeIcon): Add the output about changing the icon.
2582         * DumpRenderTree/chromium/WebViewHost.h:
2583         (WebViewHost):
2584
2585 2013-03-18  Julie Parent  <jparent@chromium.org>
2586
2587         Cleanup: Move js for treemap and aggregate_results into own js files.
2588         https://bugs.webkit.org/show_bug.cgi?id=112618
2589
2590         Reviewed by Dirk Pranke.
2591         
2592         No functional changes, just moving the code into separate js file
2593         rather than inlined in the html, so we can test it, make it more
2594         modular, etc.  Other dashboard types are already done this way.
2595
2596         * TestResultServer/static-dashboards/aggregate_results.html:
2597         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
2598         (generatePage):
2599         (handleValidHashParameter):
2600         (htmlForBuilder):
2601         (rawValuesHTML):
2602         (chartHTML):
2603         (filteredValues):
2604         (chart):
2605         (htmlForRevisionRows):
2606         (wrapHTMLInTable):
2607         (htmlForSummaryTable):
2608         (valuesPerExpectation):
2609         (htmlForTestType):
2610         (htmlForTableRow):
2611         (extendedEncode):
2612         * TestResultServer/static-dashboards/treemap.html:
2613         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
2614         (humanReadableTime):
2615         (convertToWebTreemapFormat):
2616         (reverseSortByAverage):
2617         (generatePage):
2618         (focusPath):
2619         (.switch.return):
2620         (handleQueryParameterChange):
2621         (extractName):
2622         (fullName):
2623         (handleFocus.):
2624         (handleFocus):
2625
2626 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2627
2628         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
2629         https://bugs.webkit.org/show_bug.cgi?id=112622
2630
2631         Reviewed by Dirk Pranke.
2632
2633         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2634         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
2635
2636 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2637
2638         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
2639         https://bugs.webkit.org/show_bug.cgi?id=112619
2640
2641         Reviewed by Dirk Pranke.
2642
2643         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
2644         directory and then fall back to the generic LayoutTests/platform/gtk directory.
2645
2646         * Scripts/webkitpy/layout_tests/port/gtk.py:
2647         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
2648         Port._webkit_baseline_path method.
2649         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2650         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
2651         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
2652         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2653         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
2654         that are expected based on the builder name.
2655
2656 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
2657
2658         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
2659         https://bugs.webkit.org/show_bug.cgi?id=112571
2660
2661         Reviewed by Adam Barth.
2662
2663         Update function declarations for new WebFileSystemType enum. (All
2664         changes are behind an #ifdef so we can sync required changes in embedders.)
2665
2666         * DumpRenderTree/chromium/WebViewHost.cpp:
2667         (WebViewHost::openFileSystem):
2668         (WebViewHost::deleteFileSystem):
2669         * DumpRenderTree/chromium/WebViewHost.h:
2670         (WebViewHost):
2671
2672 2013-03-18  Julie Parent  <jparent@chromium.org>
2673
2674         Cleanup: Move timeline_exporer js out of html file into js.
2675         https://bugs.webkit.org/show_bug.cgi?id=112188
2676
2677         Reviewed by Dirk Pranke.
2678         
2679         Moves the javascript out of the html file and into a new js file.
2680         This follows the format of flakiness_dashboard.{html|js}.
2681         
2682         Also moves code from dashboard_base that is used only by this one
2683         dashboard, and makes it private to the dashboard.
2684
2685         * TestResultServer/static-dashboards/dashboard_base.js:
2686         * TestResultServer/static-dashboards/timeline_explorer.html:
2687         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
2688         (generatePage):
2689         (initCurrentBuilderTestResults):
2690         (shouldShowWebKitRevisionsOnly):
2691         (updateTimelineForBuilder.):
2692         (updateTimelineForBuilder):
2693         (selectBuild):
2694         (updateBuildIndicator):
2695         (.addRow):
2696         (.addNumberRow):
2697         (.inspectorNode.getElementsByTagName.0.onclick):
2698         (.inspectorNode.getElementsByTagName.1.onclick):
2699         (.inspectorNode.getElementsByTagName.2.onclick):
2700         (updateBuildInspector):
2701         (showResultsDelta):
2702         (decompressResults.addFlakyDelta):
2703         (decompressResults):
2704
2705 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2706
2707         Unreviewed, rolling out r145272.
2708         http://trac.webkit.org/changeset/145272
2709         https://bugs.webkit.org/show_bug.cgi?id=111884
2710
2711         Turns out the ASAN build is still broken; possibly there's
2712         something still setting LD_LIBRARY_PATH, or possibly there's
2713         something else wrong. In the meantime, we need it to work again.
2714
2715         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2716
2717 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2718
2719         delete-stale-build-files is too aggressive
2720         https://bugs.webkit.org/show_bug.cgi?id=112595
2721
2722         Reviewed by Tim Horton.
2723
2724         It appears that whitelisting file extensions to keep is not a good idea.
2725         Blacklist files to delete instead, and only delete .o files for now.
2726         We can add more file extensions as needed.
2727
2728         * BuildSlaveSupport/delete-stale-build-files:
2729
2730 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2731
2732         Disable accessibility notifications after each test
2733         https://bugs.webkit.org/show_bug.cgi?id=112579
2734
2735         Reviewed by Tim Horton.
2736         
2737         In WebKitTestRunner, if any tests triggered accessibility notifications,
2738         the global notification handler would thereafter be active, and fire
2739         notifications for all subsequent tests.
2740         
2741         Fix by implementing AccessibilityController::resetToConsistentState() for
2742         Mac, and using it to clear the global notification handler.
2743
2744         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2745         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2746         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
2747         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
2748         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
2749         (e.g. because of -autorelease).
2750         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
2751         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
2752         if there is one.
2753         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
2754         Add -stopObserving
2755         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2756         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
2757         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
2758         center.
2759
2760 2013-03-18  Dana Jansens  <danakj@chromium.org>
2761
2762         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
2763         https://bugs.webkit.org/show_bug.cgi?id=112392
2764
2765         Reviewed by James Robinson.
2766
2767         Removes the command line flag option from DRT.
2768
2769         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2770         (main):
2771
2772 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2773
2774         [GTK] plugins/plugin-clip-subframe.html is failing
2775         https://bugs.webkit.org/show_bug.cgi?id=112570
2776
2777         Reviewed by Martin Robinson.
2778
2779         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
2780
2781 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
2782
2783         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
2784         https://bugs.webkit.org/show_bug.cgi?id=112442
2785
2786         Reviewed by Gustavo Noronha Silva.
2787
2788         * GtkLauncher/main.c:
2789         (reloadCb):
2790         (createToolbar):
2791         (createWindow):
2792
2793 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2794
2795         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
2796         https://bugs.webkit.org/show_bug.cgi?id=112205
2797
2798         Disable this API test until Geoff can fix it.
2799
2800         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2801         (TestWebKitAPI::TEST):
2802
2803 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
2804
2805         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2806         https://bugs.webkit.org/show_bug.cgi?id=112478
2807
2808         Reviewed by Tony Chang.
2809
2810         There is nothing that ensures that the log messages from the plugin
2811         come in before the layout test finished loading.
2812
2813         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2814         (PassDifferentNPPStruct::NPP_SetWindow):
2815         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2816         (NPP_SetWindow):
2817
2818 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2819
2820         Have the mac port support per_test_timeout in webkitpy
2821         https://bugs.webkit.org/show_bug.cgi?id=112466
2822
2823         Reviewed by Dirk Pranke.
2824         
2825         Both WTR and DRT handle --timeout arguments, so we can
2826         have the scripts pass the timeout values down to the tools.
2827
2828         * Scripts/webkitpy/layout_tests/port/mac.py:
2829         (MacPort.supports_per_test_timeout):
2830
2831 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
2832
2833         Remove setAsynchronousSpellCheckingEnabled from test runners
2834         https://bugs.webkit.org/show_bug.cgi?id=112362
2835
2836         Reviewed by Tony Chang.
2837
2838         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
2839         in internals.settings, so all ports can share it.
2840
2841         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2842         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2843         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2844         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2845         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2846         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2847         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2848         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
2849         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2850         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
2851         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2852         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2853
2854 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2855
2856         Fix the stupid unit tests.
2857
2858         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2859         (test_sample_process):
2860
2861 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
2862
2863         Collect samples for unresponsive web processes
2864         https://bugs.webkit.org/show_bug.cgi?id=112409
2865
2866         Reviewed by Tim Horton.
2867         
2868         When we detect that a subprocess was unresponsive, run the 'sample'
2869         tool on that process, for the Mac port.
2870         
2871         The sample will be linked to from the results.html page, next
2872         to the crash log link.
2873
2874         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2875         (Manager._look_for_new_crash_logs): Before looking for crash logs,
2876         look for samples on disk.
2877         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2878         (TestResultWriter):
2879         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
2880         -sample.txt files, and have it copy their contents to a new file
2881         next to the test that spawned them (as we do for crash logs).
2882         * Scripts/webkitpy/layout_tests/port/base.py:
2883         (Port.look_for_new_samples): Base class does nothing for sampling.
2884         * Scripts/webkitpy/layout_tests/port/driver.py:
2885         (Driver._check_for_driver_crash): Kick off a sample if we detected
2886         that the subprocess was unresponsive.
2887         * Scripts/webkitpy/layout_tests/port/mac.py:
2888         (MacPort.sample_file_path): Utility to generate the file path
2889         to the generated sample files at the top level of layout-test-results.
2890         (MacPort.look_for_new_crash_logs): Fix typo
2891         (MacPort.look_for_new_samples): New function to find sample files.
2892         (MacPort.sample_process): Use the utility function to get the file path.
2893
2894 2013-03-15  Zeno Albisser  <zeno@webkit.org>
2895
2896         [Qt] Remove simple getters and setters from TestRunnerQt
2897         https://bugs.webkit.org/show_bug.cgi?id=112343
2898
2899         Reviewed by Benjamin Poulain.
2900
2901         The removed functions and boolean members
2902         are being replaced by the implementations in the
2903         generic TestRunner.h.
2904
2905         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2906         (DumpRenderTree::dumpFrameScrollPosition):
2907         (DumpRenderTree::dumpFramesAsText):
2908         (DumpRenderTree::dump):
2909         (DumpRenderTree::titleChanged):
2910         (DumpRenderTree::dumpDatabaseQuota):
2911         (DumpRenderTree::dumpApplicationCacheQuota):
2912         (DumpRenderTree::statusBarMessage):
2913         (DumpRenderTree::createWindow):
2914         * DumpRenderTree/qt/TestRunnerQt.cpp:
2915         (TestRunnerQt::reset):
2916         * DumpRenderTree/qt/TestRunnerQt.h:
2917         (TestRunnerQt):
2918
2919 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
2920
2921         Update the link on build.webkit.org to refer to perf.webkit.org
2922         https://bugs.webkit.org/show_bug.cgi?id=112416
2923
2924         Reviewed by Philip Rogers.
2925
2926         Updated the link. Also updated the template to use HTML5 DOCTYPE.
2927
2928         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2929
2930 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
2931
2932         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
2933         https://bugs.webkit.org/show_bug.cgi?id=112394
2934
2935         Reviewed by Philippe Normand.
2936
2937         * GtkLauncher/main.c:
2938         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
2939
2940 2013-03-14  Andreas Kling  <akling@apple.com>
2941
2942         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
2943         <http://webkit.org/b/111815>
2944         <rdar://problem/13380145>
2945
2946         Reviewed by Anders Carlsson.
2947
2948         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
2949         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
2950         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
2951
2952         * WebKitTestRunner/PlatformWebView.h:
2953         (PlatformWebView):
2954         * WebKitTestRunner/TestController.cpp:
2955         (WTR::TestController::createOtherPage):
2956         (WTR::TestController::createWebViewWithOptions):
2957         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2958         (WTR::PlatformWebView::didInitializeClients):
2959
2960 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2961
2962         [EFL][MiniBrowser] Add a search field to the MiniBrowser
2963         https://bugs.webkit.org/show_bug.cgi?id=112122
2964
2965         Reviewed by Kenneth Rohde Christiansen.
2966
2967         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
2968
2969         * MiniBrowser/efl/main.c:
2970         (_Browser_Window):
2971         (search_box_show):
2972         (search_box_hide):
2973         (on_key_down):
2974         (on_url_changed):
2975         (on_search_field_aborted):
2976         (on_search_field_activated):
2977         (on_search_field_clicked):
2978         (on_search_backward_button_clicked):
2979         (on_search_forward_button_clicked):
2980         (window_create):
2981
2982 2013-03-14  Julie Parent  <jparent@chromium.org>
2983
2984         Cleanup: Remove g_resourceLoader.
2985         https://bugs.webkit.org/show_bug.cgi?id=112305
2986
2987         Reviewed by Dirk Pranke.
2988         
2989         Removing another global.
2990         
2991         Now, each dashboard creates its own loader, rather than having
2992         a general global one.
2993         
2994         Remove usage of g_resourceLoader.isLoadingComplete from 
2995         handleLocationChange by ensuring that handleLocationChange is
2996         never called before the loader is done.  It was called in two
2997         places before: 1 was from the callback when the loader is done,
2998         so that was obviously true, and the other was from onhashchange,
2999         where it would just return rather than running.  Instead, lets
3000         only register the onhashchange handler once the loader is
3001         setup, so the check is no longer necessary.
3002         
3003         Remove isLoadingComplete since it is now unused.
3004         
3005         Callback for loader is now initializeHistory, rather than just
3006         handleLocationChange which will set up the hashchange handler now.
3007         This will all eventually be moving to a new History object.
3008
3009         * TestResultServer/static-dashboards/aggregate_results.html:
3010         * TestResultServer/static-dashboards/dashboard_base.js:
3011         (handleLocationChange):
3012         (intializeHistory):
3013         (decompressResults):
3014         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3015         (generatePage):
3016         * TestResultServer/static-dashboards/loader.js:
3017         (.):
3018         * TestResultServer/static-dashboards/loader_unittests.js:
3019         * TestResultServer/static-dashboards/timeline_explorer.html:
3020         * TestResultServer/static-dashboards/treemap.html:
3021
3022 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3023
3024         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3025         https://bugs.webkit.org/show_bug.cgi?id=109404
3026
3027         Reviewed by Tony Chang.
3028
3029         Removes all the code related to smartInsertDeleteEnabled and
3030         selectTrailingWhitespaceEnabled settings as they will be managed from
3031         internals from now on.
3032
3033         * DumpRenderTree/TestRunner.cpp:
3034         (TestRunner::staticFunctions):
3035         * DumpRenderTree/TestRunner.h:
3036         (TestRunner):
3037         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3038         (WebKit):
3039         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3040         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3041         (DumpRenderTree):
3042         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3043         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3044         (WebTestRunner::WebTestProxy::didStopLoading):
3045         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3046         (WebTestRunner::TestRunner::TestRunner):
3047         (WebTestRunner::TestRunner::reset):
3048         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3049         (TestRunner):
3050         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3051         (WebTestRunner::WebPreferences::applyTo): Set default values for
3052         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3053         Chromium DRT default values are different from Chromium browser.
3054         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3055         * DumpRenderTree/chromium/WebViewHost.cpp:
3056         * DumpRenderTree/chromium/WebViewHost.h:
3057         (WebViewHost):
3058         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3059         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3060         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3061         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3062         (resetDefaultsToConsistentValues):
3063         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3064         * DumpRenderTree/mac/DumpRenderTree.mm:
3065         (resetWebViewToConsistentStateBeforeTesting):
3066         * DumpRenderTree/mac/TestRunnerMac.mm:
3067         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3068         (WebCore::WebPage::resetSettings):
3069         * DumpRenderTree/qt/TestRunnerQt.cpp:
3070         * DumpRenderTree/qt/TestRunnerQt.h:
3071         (TestRunnerQt):
3072         * DumpRenderTree/win/DumpRenderTree.cpp:
3073         (resetWebViewToConsistentStateBeforeTesting):
3074         * DumpRenderTree/win/TestRunnerWin.cpp:
3075         * DumpRenderTree/wx/TestRunnerWx.cpp:
3076
3077 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3078
3079         [Qt] Disable DRT on Windows
3080
3081         Reviewed by Jocelyn Turcotte.
3082
3083         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3084
3085         * qmake/mkspecs/features/configure.prf:
3086
3087 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3088
3089         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
3090         https://bugs.webkit.org/show_bug.cgi?id=110728
3091
3092         Reviewed by Gyuyoung Kim.
3093
3094         Use the page group to create the view object.
3095
3096         * MiniBrowser/efl/main.c:
3097         (window_create):
3098
3099 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3100
3101         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
3102
3103         Reviewed by Tor Arne Vestbø.
3104
3105         The mock versions of these web facing features should be instantiated when
3106         running in DumpRenderTree only. In order for them to work, no extra Qt modules
3107         such as QtLocation are actually needed.
3108
3109         This patch decouples enabling device orientation/motion and geolocation from
3110         the underlying Qt modules and makes them available in developer builds
3111         (!production_build) and backed by mock backends when running in drt.
3112
3113         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
3114         developers the web facing features are always enabled (although requests will
3115         time out) and the mock backends are enabled inside DRT, allowing for the layout
3116         tests to run with less dependencies.
3117
3118         In addition this also enables the mock device motion client, which was
3119         previously never instantiated.
3120
3121         * qmake/mkspecs/features/features.prf:
3122
3123 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3124
3125         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
3126         https://bugs.webkit.org/show_bug.cgi?id=112340
3127
3128         Reviewed by Simon Hausmann.
3129
3130         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3131         (DumpRenderTree::dump):
3132             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
3133         (DumpRenderTree::dumpApplicationCacheQuota):
3134         * DumpRenderTree/qt/TestRunnerQt.cpp:
3135         (TestRunnerQt::reset):
3136         * DumpRenderTree/qt/TestRunnerQt.h:
3137         (TestRunnerQt):
3138
3139 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3140
3141         [Qt] Port DRT to use TestRunner::dumpAsText()
3142         https://bugs.webkit.org/show_bug.cgi?id=112260
3143
3144         Reviewed by Benjamin Poulain.
3145
3146         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3147         (WebCore::DumpRenderTree::open):
3148         (WebCore::methodNameStringForFailedTest):
3149             Change parameter from type TestRunnerQt* to TestRunner*.
3150         (WebCore::DumpRenderTree::dump):
3151             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3152             Instead we should rely on TestRunner::generatePixelResults().
3153         * DumpRenderTree/qt/TestRunnerQt.cpp:
3154         (TestRunnerQt::reset):
3155         * DumpRenderTree/qt/TestRunnerQt.h:
3156         (TestRunnerQt):
3157
3158 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3159
3160         Implement FontLoader interface
3161         https://bugs.webkit.org/show_bug.cgi?id=98395
3162
3163         Reviewed by Eric Seidel.
3164
3165         Enable FontLoadEvents runtime flag for TestShell.
3166
3167         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3168         (WebTestRunner::TestInterfaces::TestInterfaces):
3169
3170 2013-03-13  Julie Parent  <jparent@chromium.org>
3171
3172         CLeanup: remove unnecessary call to parseParameters.
3173         https://bugs.webkit.org/show_bug.cgi?id=112309
3174
3175         Reviewed by Ojan Vafai.
3176         
3177         We call parseCrossDashboardParameters when the dashboard initially
3178         loads to set the state required for loadBuildersList, and then we
3179         call it again once we are fully done with loading, so there is no
3180         reason to call it in the middle of the loading process here.
3181
3182         * TestResultServer/static-dashboards/loader.js:
3183         (.):
3184
3185 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3186
3187         Unreviewed. Now I'm a reviewer :)
3188
3189         * Scripts/webkitpy/common/config/committers.py:
3190
3191 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3192
3193         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3194         https://bugs.webkit.org/show_bug.cgi?id=112277
3195
3196         Reviewed by Adam Barth.
3197
3198         * Scripts/webkitperl/FeatureList.pm:
3199         * qmake/mkspecs/features/features.pri:
3200
3201 2013-03-13  Adam Barth  <abarth@webkit.org>
3202
3203         run-perf-tests should support content_shell
3204         https://bugs.webkit.org/show_bug.cgi?id=112291
3205
3206         Reviewed by Eric Seidel.
3207
3208         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3209         (PerfTestsRunner._parse_args):
3210
3211 2013-03-13  Oliver Hunt  <oliver@apple.com>
3212
3213         Simplify Checked<> multiplication
3214         https://bugs.webkit.org/show_bug.cgi?id=112286
3215
3216         Reviewed by James Robinson.
3217
3218         Add tests for multiplication by zero and max to ensure we don't
3219         mess them up should we ever make changes to Checked<> in future.
3220
3221         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3222         (TestWebKitAPI):
3223
3224 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3225
3226         [Qt] Unreviewed prospective Windows build fix
3227
3228         Do the usual thing, include the moc generated code in the .cpp file instead
3229         of compiling it standalone, to ensure that config.h is included, too, and
3230         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3231
3232         * DumpRenderTree/qt/EventSenderQt.cpp:
3233
3234 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3235
3236         [Qt] Port TestRunner::findString to shared interface
3237         https://bugs.webkit.org/show_bug.cgi?id=112147
3238
3239         Reviewed by Jocelyn Turcotte.
3240
3241         This patch also removes DumpRenderTree and some other helper classes from
3242         the WebCore namespace, to which they do not really belong.
3243
3244         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3245         (main):
3246         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3247         (DumpRenderTree::DumpRenderTree):
3248         (DumpRenderTree::~DumpRenderTree):
3249         (DumpRenderTree::instance):
3250         (DumpRenderTree::setShouldTimeout):
3251         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3252         (DumpRenderTree):
3253         * DumpRenderTree/qt/EventSenderQt.cpp:
3254         (EventSender::contextClick):
3255         (EventSender::sendEvent):
3256         (EventSender::postEvent):
3257         * DumpRenderTree/qt/EventSenderQt.h:
3258         (EventSender::isGraphicsBased):
3259         * DumpRenderTree/qt/TestRunnerQt.cpp:
3260         (TestRunnerQt::TestRunnerQt):
3261         (TestRunner::findString):
3262         (TestRunnerQt::setMockDeviceOrientation):
3263         (TestRunnerQt::setGeolocationPermission):
3264         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3265         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3266         (TestRunnerQt::setMockGeolocationPosition):
3267         * DumpRenderTree/qt/TestRunnerQt.h:
3268         (TestRunnerQt):
3269
3270 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3271
3272         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3273         https://bugs.webkit.org/show_bug.cgi?id=112129
3274
3275         Reviewed by Adam Barth.
3276
3277         Following Chromium
3278         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3279         this is being renamed to better explain what it does.
3280
3281         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3282
3283 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3284
3285         [Qt] Unreviewed trivial typo fix
3286
3287         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3288         TextRunner.h. Thanks Zeno :)
3289
3290 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3291
3292         [Qt] Prepare DRT for transition to shared TestRunner interface
3293         https://bugs.webkit.org/show_bug.cgi?id=112144
3294
3295         Reviewed by Benjamin Poulain.
3296
3297         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3298         the JSC C API based one.
3299
3300         This is impplemented by instantiating the QObject based testRunner in
3301         the global object, then instantiating the JSC C based TestRunner
3302         separately and placing it "behind" the QObject based testRunner through
3303         injection of the individual functions through proxies. (prototype
3304         chaining doesn't work due to the this object and Function.prototype.bind
3305         doesn't work due to the native function)
3306
3307         This allows for porting over method by method by removing the method
3308         from the QObject TestRunnerQt and implementing it in the JSC C based
3309         TestRunner.
3310
3311         In order for this to link and run dummy implementations of all the
3312         necessary TestRunner functions are provided.
3313
3314         * DumpRenderTree/qt/DumpRenderTree.pro:
3315         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3316         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3317         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3318         (WebCore::DumpRenderTree::initJSObjects):
3319         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3320         (DumpRenderTree):
3321         * DumpRenderTree/qt/TestRunnerQt.cpp:
3322         (TestRunner::~TestRunner):
3323         (TestRunner::addDisallowedURL):
3324         (TestRunner::queueLoad):
3325         (TestRunner::removeAllVisitedLinks):
3326         (TestRunner::setAcceptsEditing):
3327         (TestRunner::simulateLegacyWebNotificationClick):
3328         (TestRunner::setWindowIsKey):
3329         (TestRunner::setAlwaysAcceptCookies):
3330         (TestRunner::addOriginAccessWhitelistEntry):
3331         (TestRunner::setWebViewEditable):
3332         (TestRunner::clearAllApplicationCaches):
3333         (TestRunner::setTextDirection):
3334         (TestRunner::notifyDone):
3335         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3336         (TestRunner::overridePreference):
3337         (TestRunner::pathToLocalResource):
3338         (TestRunner::removeAllWebNotificationPermissions):
3339         (TestRunner::simulateWebNotificationClick):
3340         (TestRunner::closeIdleLocalStorageDatabases):
3341         (TestRunner::focusWebView):
3342         (TestRunner::setBackingScaleFactor):
3343         (TestRunner::removeChromeInputField):
3344         (TestRunner::addChromeInputField):
3345         (TestRunner::originsWithLocalStorage):
3346         (TestRunner::deleteAllLocalStorage):
3347         (TestRunner::deleteLocalStorageForOrigin):
3348         (TestRunner::observeStorageTrackerNotifications):
3349         (TestRunner::syncLocalStorage):
3350         (TestRunner::windowCount):
3351         (TestRunner::setWaitToDump):
3352         (TestRunner::waitForPolicyDelegate):
3353         (TestRunner::webHistoryItemCount):
3354         (TestRunner::showWebInspector):
3355         (TestRunner::closeWebInspector):
3356         (TestRunner::evaluateInWebInspector):
3357         (TestRunner::setSerializeHTTPLoads):
3358         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3359         (TestRunner::setCustomPolicyDelegate):
3360         (TestRunner::setDatabaseQuota):
3361         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3362         (TestRunner::resetPageVisibility):
3363         (TestRunner::keepWebHistory):
3364         (TestRunner::goBack):
3365         (TestRunner::originsWithApplicationCache):
3366         (TestRunner::applicationCacheDiskUsageForOrigin):
3367         (TestRunner::display):
3368         (TestRunner::dispatchPendingLoadRequests):
3369         (TestRunner::clearPersistentUserStyleSheet):
3370         (TestRunner::callShouldCloseOnWebView):
3371         (TestRunner::copyDecodedHostName):
3372         (TestRunner::clearBackForwardList):
3373         (TestRunner::clearAllDatabases):
3374         (TestRunner::clearApplicationCacheForOrigin):
3375         (TestRunner::apiTestGoToCurrentBackForwardItem):
3376         (TestRunner::authenticateSession):
3377         (TestRunner::abortModal):
3378         (TestRunner::setStorageDatabaseIdleInterval):
3379         (TestRunner::setAsynchronousSpellCheckingEnabled):
3380         (TestRunner::setXSSAuditorEnabled):
3381         (TestRunner::setSpatialNavigationEnabled):
3382         (TestRunner::setScrollbarPolicy):
3383         (TestRunner::setJavaScriptCanAccessClipboard):
3384         (TestRunner::setAutomaticLinkDetectionEnabled):
3385         (TestRunner::setUserStyleSheetEnabled):
3386         (TestRunner::setUserStyleSheetLocation):
3387         (TestRunner::setUseDashboardCompatibilityMode):
3388         (TestRunner::setTabKeyCyclesThroughElements):
3389         (TestRunner::setSmartInsertDeleteEnabled):
3390         (TestRunner::setSelectTrailingWhitespaceEnabled):
3391         (TestRunner::setPrivateBrowsingEnabled):
3392         (TestRunner::setPluginsEnabled):
3393         (TestRunner::setPopupBlockingEnabled):
3394         (TestRunner::setMockSpeechInputDumpRect):
3395         (TestRunner::setPersistentUserStyleSheetLocation):
3396         (TestRunner::setMockGeolocationPosition):
3397         (TestRunner::setMockGeolocationPositionUnavailableError):
3398         (TestRunner::setMockDeviceOrientation):
3399         (TestRunner::setMainFrameIsFirstResponder):
3400         (TestRunner::setIconDatabaseEnabled):
3401         (TestRunner::setGeolocationPermission):
3402         (TestRunner::setDefersLoading):
3403         (TestRunner::setCacheModel):
3404         (TestRunner::setAuthorAndUserStylesEnabled):
3405         (TestRunner::setAllowFileAccessFromFileURLs):
3406         (TestRunner::setAppCacheMaximumSize):
3407         (TestRunner::setAllowUniversalAccessFromFileURLs):
3408         (TestRunner::setApplicationCacheOriginQuota):
3409         (TestRunner::denyWebNotificationPermission):
3410         (TestRunner::grantWebNotificationPermission):
3411         (TestRunner::setValueForUser):
3412         (TestRunner::setViewModeMediaFeature):
3413         (TestRunner::setPageVisibility):
3414         (TestRunner::addMockSpeechInputResult):
3415         (TestRunner::removeOriginAccessWhitelistEntry):
3416         (TestRunner::addUserScript):
3417         (TestRunner::isCommandEnabled):
3418         (TestRunner::evaluateScriptInIsolatedWorld):
3419         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3420         (TestRunner::copyEncodedHostName):
3421         (TestRunner::addUserStyleSheet):
3422         (TestRunner::findString):
3423         (TestRunner::execCommand):
3424         (TestRunner::localStorageDiskUsageForOrigin):
3425
3426 2013-03-12  Julie Parent  <jparent@chromium.org>
3427
3428         Cleanup: Move flatten-trie to loader.
3429         https://bugs.webkit.org/show_bug.cgi?id=112196
3430
3431         Reviewed by Dirk Pranke.
3432
3433         flatten-trie is used only by the loader, so move it there and make it
3434         private, rather than global in dashbaord_base. Moved the corresponding
3435         unit test from flakiness_dashboard_unittests to loader_unittests.
3436         
3437         * TestResultServer/static-dashboards/dashboard_base.js:
3438         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3439         * TestResultServer/static-dashboards/loader.js:
3440         (.):
3441         * TestResultServer/static-dashboards/loader_unittests.js:
3442
3443 2013-03-12  Oliver Hunt  <oliver@apple.com>
3444
3445         Unbreak api tests
3446
3447         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3448         (TestWebKitAPI):
3449
3450 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3451
3452         Unreviewed, disabling tests for Win EWS.
3453
3454         win-ews obviously cannot keep up with running tests, it's >300 behind.
3455         Probably doesn't help that its (likely) running tests serially.
3456
3457         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3458         (WinEWS):
3459
3460 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3461
3462         Add a --build-directory argument to delete-stale-build-files
3463         https://bugs.webkit.org/show_bug.cgi?id=112198
3464
3465         Reviewed by Ryosuke Niwa.
3466
3467         * BuildSlaveSupport/delete-stale-build-files:
3468         (main): Add --build-directory argument.
3469
3470 2013-03-12  Oliver Hunt  <oliver@apple.com>
3471
3472         Appease MSVC
3473
3474         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3475         (TestWebKitAPI):
3476
3477 2013-03-12  Oliver Hunt  <oliver@apple.com>
3478
3479         Add more Checked<> tests
3480         https://bugs.webkit.org/show_bug.cgi?id=112190
3481
3482         Reviewed by Geoffrey Garen.
3483
3484         Tests!
3485
3486         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3487         (TestWebKitAPI):
3488
3489 2013-03-12  Julie Parent  <jparent@chromium.org>
3490
3491         Cleanup: Move loading complete function into callback, rather than global.
3492         https://bugs.webkit.org/show_bug.cgi?id=112167
3493
3494         Reviewed by Dirk Pranke.
3495         
3496         Stop calling global functions, pass in proper handler to Loader
3497         constructor. Note that the callback is optional, as tests, and
3498         some potential dashboards, do not need one.
3499
3500         * TestResultServer/static-dashboards/dashboard_base.js:
3501         * TestResultServer/static-dashboards/loader.js:
3502         (.):
3503         * TestResultServer/static-dashboards/loader_unittests.js:
3504
3505 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3506
3507         [EFL][WK2] Add popup menu support to MiniBrowser
3508         https://bugs.webkit.org/show_bug.cgi?id=108934
3509
3510         Reviewed by Kenneth Rohde Christiansen.
3511
3512         Implement popup menu support in MiniBrowser by handling popup_menu_show
3513         and popup_menu_hide smart functions on the view and using the Ewk popup
3514         menu API.
3515
3516         * MiniBrowser/efl/main.c:
3517         (_Browser_Window):
3518         (on_popup_menu_discarded):
3519         (on_popup_menu_item_clicked):
3520         (popup_menu_populate):
3521         (on_popup_menu_show):
3522         (on_popup_menu_hide):
3523         (window_create): Use calloc() instead of malloc() to allocate memory for
3524         Browser_Window. This makes sure all the structs members are initialized
3525         to 0 (such as the new elm_popup_menu pointer).
3526
3527 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3528
3529         [GTK] Set up the libPlatformGtk.la library
3530         https://bugs.webkit.org/show_bug.cgi?id=111738
3531
3532         Reviewed by Martin Robinson.
3533
3534         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3535         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
3536         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3537
3538 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3539
3540         [GTK] Enable Web Audio in development builds
3541         https://bugs.webkit.org/show_bug.cgi?id=111831
3542
3543         Reviewed by Philippe Normand.
3544
3545         Web Audio is already quite well supported on the GTK port but still has a few issues
3546         that must be addressed before it is enabled by default. Despite that it should be enabled
3547         in development builds just so we are up-to-date with future feature infrastructure changes.
3548         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3549         that's an obvious goal before enabling the feature in release builds.
3550
3551         * Scripts/webkitperl/FeatureList.pm:
3552
3553 2013-03-11  Andreas Kling  <akling@apple.com>
3554
3555         [Mac][WK1] Add support for alert() in MiniBrowser.
3556         <http://webkit.org/b/112090>
3557
3558         Reviewed by Anders Carlsson.
3559
3560         * MiniBrowser/mac/WK1BrowserWindowController.m:
3561         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3562
3563 2013-03-11  Julie Parent  <jparent@chromium.org>
3564
3565         Dashboard cleanup: Create ui.Errors
3566         https://bugs.webkit.org/show_bug.cgi?id=111785
3567
3568         Reviewed by Ojan Vafai.
3569         
3570         Create ui.Errors for handling errors the dashboards
3571         encounter. Loader now has a Error object that it can add to,
3572         and individual dashboards can show errors when desired.
3573         Currently, only flakiness_db shows errors, but this is 
3574         generic and there is no reason why other dbs wouldn't want to
3575         show errors.
3576
3577         * TestResultServer/static-dashboards/dashboard_base.js:
3578         (resourceLoadingComplete):
3579         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3580         (generatePage):
3581         * TestResultServer/static-dashboards/loader.js:
3582         (.):
3583         * TestResultServer/static-dashboards/ui.js:
3584         (.):
3585
3586 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
3587
3588         Some StringHasher tests are broken because of missing null termination
3589         https://bugs.webkit.org/show_bug.cgi?id=111284
3590
3591         Reviewed by Darin Adler.
3592
3593         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3594         (TestWebKitAPI): Added null termination since C strings are null-terminated.
3595         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
3596         the bug caught by it is now fixed.
3597
3598 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3599
3600         Unreviewed, rolling out r145200.
3601         http://trac.webkit.org/changeset/145200
3602         https://bugs.webkit.org/show_bug.cgi?id=112063
3603
3604         Broke a couple of unit tests (Requested by zdobersek on
3605         #webkit).
3606
3607         * Scripts/webkitperl/FeatureList.pm:
3608
3609 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
3610
3611         [GTK] WebKit2-only build fails
3612         https://bugs.webkit.org/show_bug.cgi?id=112033
3613
3614         Reviewed by Gustavo Noronha Silva.
3615
3616         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
3617         generic part, WebKit1-specific part and WebKit2-specific part.
3618         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
3619         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
3620         directly.
3621
3622 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
3623
3624         Adding myself to the committers list.
3625
3626         Unreviewed.
3627
3628         * Scripts/webkitpy/common/config/committers.py:
3629
3630 2013-03-11  Jeff Rogers  <jrogers@rim.com>
3631
3632         [BlackBerry] Disable MathML support
3633         https://bugs.webkit.org/show_bug.cgi?id=111929
3634
3635         Reviewed by Rob Buis.
3636
3637         * Scripts/webkitperl/FeatureList.pm:
3638
3639 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3640
3641         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
3642         https://bugs.webkit.org/show_bug.cgi?id=111970
3643
3644         Reviewed by Chris Fleizach.
3645
3646         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
3647         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
3648         undefined symbol.
3649
3650         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3651         (WTR::AccessibilityUIElement::supportedActions):
3652         (WTR):
3653
3654 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
3655
3656         [chromium] Android apk targets should depend directly on Java library targets
3657         https://bugs.webkit.org/show_bug.cgi?id=111746
3658
3659         Reviewed by Eric Seidel.
3660
3661         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3662         Make DumpRenderTree_apk depend directly on base_java and net_java.
3663         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3664         Make TestWebKitAPI_apk depend directly on base_java.
3665
3666 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
3667
3668         [chromium] remove obsolete user gesture methods from WebFrame
3669         https://bugs.webkit.org/show_bug.cgi?id=111696
3670
3671         Reviewed by Adam Barth.
3672
3673         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3674         (WebTestRunner::TestPlugin::handleInputEvent):
3675         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3676
3677 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
3678
3679         Unreviewed, add myself to commiters.py.
3680
3681         * Scripts/webkitpy/common/config/committers.py:
3682
3683 2013-03-08  Julie Parent  <jparent@chromium.org>
3684
3685         Cleanup: Remove dead code.
3686         https://bugs.webkit.org/show_bug.cgi?id=111900
3687
3688         Reviewed by Dirk Pranke.
3689         
3690         Treemap overrides a global function that used to be in 
3691         dashboard_base, but was removed months ago in
3692         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
3693         no caller. 
3694
3695         * TestResultServer/static-dashboards/treemap.html:
3696
3697 2013-03-08  Harald Alvestrand  <hta@chromium.org>
3698
3699         Implemented new API for RTCStatsReport object.
3700         https://bugs.webkit.org/show_bug.cgi?id=110333
3701
3702         Reviewed by Adam Barth.
3703
3704         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3705         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
3706
3707 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
3708
3709         [chromium] use custom freetype on linux asan builds again
3710         https://bugs.webkit.org/show_bug.cgi?id=111884
3711
3712         Reviewed by Tony Chang.
3713
3714         We no longer need the workaround after chromium r186540.
3715
3716         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3717
3718 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
3719
3720         Warning about the user not having edit rights on Bugzilla is confusing new contributors
3721         https://bugs.webkit.org/show_bug.cgi?id=111798
3722
3723         Reviewed by Dirk Pranke.
3724
3725         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
3726
3727         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3728
3729 2013-03-08  James Robinson  <jamesr@chromium.org>
3730
3731         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
3732         https://bugs.webkit.org/show_bug.cgi?id=111632
3733
3734         Reviewed by Adrienne Walker.
3735
3736         * DumpRenderTree/chromium/WebViewHost.cpp:
3737         (WebViewHost::initializeLayerTreeView):
3738         * DumpRenderTree/chromium/WebViewHost.h:
3739         (WebViewHost):
3740
3741 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
3742
3743         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
3744         https://bugs.webkit.org/show_bug.cgi?id=111297
3745
3746         Reviewed by Kenneth Rohde Christiansen.
3747
3748         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3749         (WTR::TestRunner::setViewModeMediaFeature):
3750
3751 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
3752
3753         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
3754         https://bugs.webkit.org/show_bug.cgi?id=111814
3755
3756         Reviewed by Ryosuke Niwa.
3757
3758         Add the needed supportedActions() attribute to WKTestRunner.
3759
3760         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3761         (WTR::AccessibilityUIElement::supportedActions):
3762         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3763         (AccessibilityUIElement):
3764         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3765         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3766         (WTR::AccessibilityUIElement::supportedActions):
3767
3768 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3769
3770         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
3771         https://bugs.webkit.org/show_bug.cgi?id=111851
3772
3773         Reviewed by Kenneth Rohde Christiansen.
3774
3775         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3776         (TestWebKitAPI::TEST):
3777
3778             Fixed WKURLRef instance leaking.
3779
3780 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3781
3782         [EFL] [WK2] Some authentication tests fail in WebKit2
3783         https://bugs.webkit.org/show_bug.cgi?id=106407
3784
3785         Reviewed by Kenneth Rohde Christiansen.
3786
3787         Add patch from upstream for libsoup 2.40 to fix several authentication
3788         test cases.
3789
3790         * efl/jhbuild.modules:
3791         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
3792
3793 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
3794
3795         [GTK] Enable Web Audio in development builds
3796         https://bugs.webkit.org/show_bug.cgi?id=111831
3797
3798         Reviewed by Philippe Normand.
3799
3800         Web Audio is already quite well supported on the GTK port but still has a few issues
3801         that must be addressed before it is enabled by default. Despite that it should be enabled
3802         in development builds just so we are up-to-date with future feature infrastructure changes.
3803         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3804         that's an obvious goal before enabling the feature in release builds.
3805
3806         * Scripts/webkitperl/FeatureList.pm:
3807
3808 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3809
3810         [chromium] delay clearing the TestRunners until the main view was deleted
3811         https://bugs.webkit.org/show_bug.cgi?id=111823
3812
3813         Reviewed by Eric Seidel.
3814
3815         During WebViewHost::shutdown, we navigate the WebView to about:blank.
3816         This may call into the test runners which assume that the delegate is
3817         always non-NULL.
3818
3819         * DumpRenderTree/chromium/TestShell.cpp:
3820         (TestShell::~TestShell):
3821
3822 2013-03-07  Alan Cutter  <alancutter@chromium.org>
3823
3824         Sheriffbot whois command can't search by full name
3825         https://bugs.webkit.org/show_bug.cgi?id=111825
3826
3827         Reviewed by Eric Seidel.
3828
3829         Allowed multiple arguments to Sheriffbot's whois command.
3830         Updated test expectations.
3831
3832         * Scripts/webkitpy/tool/bot/irc_command.py:
3833         (Whois.execute):
3834         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3835         (IRCCommandTest.test_whois):
3836
3837 2013-03-07  Nils Barth  <nbarth@chromium.org>
3838
3839         Add Nils Barth and Koji Hara to committers.py
3840         https://bugs.webkit.org/show_bug.cgi?id=111806
3841
3842         Reviewed by Eric Seidel.
3843
3844         * Scripts/webkitpy/common/config/committers.py:
3845
3846 2013-03-07  Glenn Adams  <glenn@skynav.com>
3847
3848         run-pert-tests should have a --test-runner-count option
3849         https://bugs.webkit.org/show_bug.cgi?id=111726
3850
3851         Reviewed by Ryosuke Niwa.
3852
3853         Add --test-runner-count option to run-perf-tests, with default value of 4.
3854         This option allows command line configuration of the number of times to invoke
3855         the test runner (serially, not in parallel) when running a specific test in
3856         a test set.
3857
3858         * Scripts/webkitpy/performance_tests/perftest.py:
3859         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
3860         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
3861         (PerfTest.run): Rename process_run_count to test_runner_count.
3862         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
3863         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
3864         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
3865         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
3866         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3867         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
3868         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
3869         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3870         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
3871         (MainTest.test_run_with_repeat):
3872         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
3873         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3874         (MainTest.test_default_args): Add test for default option argument values.
3875         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
3876
3877 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
3878
3879         Add myself to reviewers.py
3880         https://bugs.webkit.org/show_bug.cgi?id=111757
3881
3882         Reviewed by Eric Seidel.
3883
3884         * Scripts/webkitpy/common/config/committers.py:
3885
3886 2013-03-07  Glenn Adams  <glenn@skynav.com>
3887
3888         run-perf-tests should have a --repeat option
3889         https://bugs.webkit.org/show_bug.cgi?id=100030
3890
3891         Reviewed by Ryosuke Niwa.
3892
3893         Add --repeat option to run-perf-tests, with default value of 1. When greater
3894         than 1, runs test set specified number of times. Note that multiple runs are
3895         not aggregated for statistical purposes.
3896
3897         Incidentally fixed typo: s/suceeds/succeeds/.
3898
3899         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3900         (PerfTestsRunner._parse_args): Add repeat option.
3901         (PerfTestsRunner.run): Add outer repeat loop.
3902         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
3903         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
3904         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3905         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
3906         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
3907         (MainTest.test_run_with_json_output): Fix typo.
3908         (MainTest.test_run_with_description): Fix typo.
3909         (MainTest.test_run_respects_no_results): Fix typo.
3910         (MainTest.test_run_with_slave_config_json): Fix typo.
3911         (MainTest.test_run_with_multiple_repositories): Fix typo.
3912         (MainTest.test_run_with_upload_json): Fix typo.
3913         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
3914         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
3915         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3916         (MainTest.test_parse_args): Add test for repeat option parsing.
3917
3918 2013-03-07  Julie Parent  <jparent@chromium.org>
3919
3920         showAllRuns checkbox no longer works on the stats dashboard
3921         https://bugs.webkit.org/show_bug.cgi?id=111673
3922
3923         Reviewed by Ojan Vafai.
3924
3925         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
3926         so we were trying to index into an undefined object.
3927         
3928         * TestResultServer/static-dashboards/dashboard_base.js:
3929         (invalidateQueryParameters):
3930
3931 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
3932
3933         [Chromium] Update #include for WebStorageNamespace.h
3934         https://bugs.webkit.org/show_bug.cgi?id=111748
3935
3936         Reviewed by Adam Barth.
3937
3938         In anticipation of removing
3939         WK/chromium/public/WebStorageNamespace.h (once downstream
3940         references have been updated)
3941
3942         * DumpRenderTree/chromium/WebViewHost.cpp:
3943
3944 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3945
3946         run-perf-tests fails due to svn_revision not working on a pure git clone
3947         https://bugs.webkit.org/show_bug.cgi?id=110839
3948
3949         Reviewed by Ryosuke Niwa.
3950
3951         Previously we would call git svn find-rev to look up the commit for
3952         a given revision, and that'll hang in a pure git checkout.
3953
3954         This patch changes the way we look up svn revisions in a git
3955         repository to use git log --grep 'git-svn-id', which is much faster
3956         than grepping ourselves. It also renames timestamp_of_latest_commit()
3957         to timestamp_of_revision() in order to accurately reflect what
3958         the method is doing. Note that this patch only changes the logic
3959         inside latest_revision() and svn_revision(). I'll file a separate
3960         bug to change git_commit_from_svn_revision().
3961
3962         This patch also contains some fixes to unit tests that had bit-rotted
3963         or were otherwise fragile, so that test-webkitpy --all would pass
3964         cleanly, and a fix to outputcapture so that
3965         test-webkitpy -p would work correctly again.
3966
3967         * Scripts/webkitpy/common/checkout/scm/git.py:
3968         (Git.svn_revision):
3969         (Git.timestamp_of_revision):
3970         * Scripts/webkitpy/common/checkout/scm/scm.py:
3971         (SCM.svn_revision):
3972         (SCM.timestamp_of_revision):
3973         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3974         (MockSCM.timestamp_of_revision):
3975         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3976         (_shared_test_commit_with_message):
3977         (test_commit_without_authorization):
3978         (test_timestamp_of_revision):
3979         * Scripts/webkitpy/common/checkout/scm/svn.py:
3980         (SVN.timestamp_of_revision):
3981         * Scripts/webkitpy/common/system/outputcapture.py:
3982           Importing unittest2 directly may not be safe if this module is
3983           imported before the autoinstaller gets a chance to set things up
3984           properly. We don't actually need unittest2 here.
3985         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3986         (PerfTestsRunner._generate_results_dict):
3987
3988 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3989
3990         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
3991         https://bugs.webkit.org/show_bug.cgi?id=111756
3992
3993         Reviewed by Kenneth Rohde Christiansen.
3994
3995         Bump libsoup to v2.40.3 to fix the regressions introduced by
3996         previous v2.40.0 bump.
3997
3998         * efl/jhbuild.modules:
3999
4000 2013-03-07  Roger Fong  <roger_fong@apple.com>
4001
4002         Re-enable Win EWS tests.
4003
4004         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4005         (WinEWS):
4006
4007 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
4008
4009         [nrwt] handle corrupt http server pid files cleanly
4010         https://bugs.webkit.org/show_bug.cgi?id=111628
4011
4012         Reviewed by Eric Seidel.
4013
4014         If the pid file from a previous http server is corrupt for some
4015         reason, NRWT will just raise errors and not clean it up or recover.
4016         This patch fixes that to at least delete the pid file and
4017         not throw; not that we may still have stale http servers left on
4018         the system, since there's no way to know which pid to kill if
4019         the file was corrupted.
4020
4021         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
4022         (HttpServerBase.start):
4023         (HttpServerBase.stop):
4024         (HttpServerBase._remove_pid_file):
4025         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
4026         (TestHttpServerBase):
4027         (TestHttpServerBase.test_corrupt_pid_file):
4028
4029 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
4030
4031         AX: Can't activate links with VoiceOver in Safari
4032         https://bugs.webkit.org/show_bug.cgi?id=111755
4033
4034         Reviewed by Tim Horton.
4035
4036         * DumpRenderTree/AccessibilityUIElement.cpp:
4037         (supportedActionsCallback):
4038         (AccessibilityUIElement::getJSClass):
4039         * DumpRenderTree/AccessibilityUIElement.h:
4040         (AccessibilityUIElement):
4041         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4042         (AccessibilityUIElement::supportedActions):
4043
4044 2013-03-07  Roger Fong  <roger_fong@apple.com>
4045
4046         Windows debug layout tests are crashing like crazy again.
4047         Disable tests on Win EWS bots temporarily.
4048
4049         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4050         (WinEWS):
4051
4052 2013-03-07  Roger Fong  <roger_fong@apple.com>
4053
4054         Make EWS bots build and test in release.
4055
4056         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4057         (WinEWS):
4058         * Scripts/webkitpy/tool/steps/runtests.py:
4059         (RunTests.run):
4060
4061 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
4062
4063         [chromium] don't track the top loading frame if no layout test is currently running
4064         https://bugs.webkit.org/show_bug.cgi?id=111716
4065
4066         Reviewed by Kentaro Hara.
4067
4068         In DRT, we synchronously stop the test and start loading the next test
4069         URL. However, in content_shell, this happens asynchronously. It's
4070         important that the top loading frame is not changed due to stray
4071         navigation events before the next test starts.
4072
4073         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4074         (WebTestRunner::TestRunner::setTopLoadingFrame):
4075
4076 2013-03-06  Julie Parent  <jparent@chromium.org>
4077
4078         Dashboard cleanup: Move all dashboard ui related code into ui.js.
4079         https://bugs.webkit.org/show_bug.cgi?id=111621
4080
4081         Reviewed by Ojan Vafai.
4082         
4083         Creates ui.js, a package for the common UI code the various
4084         dashboards use. HTML generation is now in the ui.html namespace
4085         and popup handling is in ui.popup.
4086         Also moves the event listening for popups to ui.popup.show and
4087         removes it on ui.popup.hid rather than having listener always
4088         around.
4089
4090         * TestResultServer/static-dashboards/aggregate_results.html:
4091         * TestResultServer/static-dashboards/dashboard_base.js:
4092         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4093         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4094         (showPopupForBuild):
4095         (htmlForNavBar):
4096         (generatePageForIndividualTests.if):
4097         (generatePageForIndividualTests):
4098         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
4099         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4100         * TestResultServer/static-dashboards/run-embedded-unittests.html:
4101         * TestResultServer/static-dashboards/run-unittests.html:
4102         * TestResultServer/static-dashboards/timeline_explorer.html:
4103         * TestResultServer/static-dashboards/treemap.html:
4104         * TestResultServer/static-dashboards/ui.js: Added.
4105         (.):
4106
4107 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
4108
4109         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
4110         https://bugs.webkit.org/show_bug.cgi?id=110584
4111
4112         Reviewed by Gyuyoung Kim.
4113
4114         Adds missing implementation of AccessibilityControllerEfl
4115         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
4116         so that it can make accessibilityController as a js object.
4117
4118         * DumpRenderTree/AccessibilityController.h:
4119         (AccessibilityController):
4120         * DumpRenderTree/AccessibilityUIElement.h:
4121         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
4122         (AccessibilityController::childElementById): Moved declaration to base class.
4123         Implementation can be shared among other ports.
4124         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
4125         (AccessibilityController::focusedElement):
4126         (AccessibilityController::rootElement):
4127         (AccessibilityController::accessibleElementById):
4128         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
4129         (AccessibilityUIElement::helpText):
4130         * DumpRenderTree/efl/CMakeLists.txt:
4131         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4132         (DumpRenderTreeChrome::DumpRenderTreeChrome):
4133         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4134         (DumpRenderTreeChrome::onWindowObjectCleared):
4135         (DumpRenderTreeChrome::accessibilityController):
4136         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
4137         (DumpRenderTreeChrome):
4138         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
4139
4140 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
4141
4142         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
4143         https://bugs.webkit.org/show_bug.cgi?id=42696
4144
4145         Reviewed by Andreas Kling.
4146
4147         * DumpRenderTree/TestRunner.cpp:
4148         (TestRunner::staticFunctions):
4149         * DumpRenderTree/TestRunner.h:
4150         (TestRunner):
4151         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4152         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4153         (WebTestRunner::TestRunner::TestRunner):
4154         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4155         (TestRunner):
4156         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4157         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4158         * DumpRenderTree/mac/TestRunnerMac.mm:
4159         * DumpRenderTree/qt/TestRunnerQt.cpp:
4160         * DumpRenderTree/qt/TestRunnerQt.h:
4161         (TestRunnerQt):
4162         * DumpRenderTree/win/TestRunnerWin.cpp:
4163         * DumpRenderTree/wx/TestRunnerWx.cpp:
4164
4165 2013-03-06  Roger Fong  <roger_fong@apple.com>
4166
4167         Re-enable WinEWS test and decrease iterations before clean build back to 10.
4168
4169         * EWSTools/start-queue-win.sh:
4170         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4171         (WinEWS):
4172
4173 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
4174
4175         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
4176         https://bugs.webkit.org/show_bug.cgi?id=82866
4177
4178         Reviewed by Martin Robinson.
4179
4180         * Scripts/run-gtk-tests:
4181         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
4182         it is passing now.
4183
4184 2013-03-06  Julie Parent  <jparent@chromium.org>
4185
4186         Dashboard cleanup: remove dashboard time logging.
4187         https://bugs.webkit.org/show_bug.cgi?id=111608
4188
4189         Reviewed by Dirk Pranke.
4190
4191         Remove logTime.  It was never accurate, and the dev tools
4192         have better ways to measure this if anyone cares to look
4193         into dashboard perf.
4194         
4195         * TestResultServer/static-dashboards/dashboard_base.js:
4196         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4197         (processTestRunsForBuilder):
4198         (appendHTML):
4199
4200 2013-03-06  Tony Chang  <tony@chromium.org>
4201
4202         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
4203         https://bugs.webkit.org/show_bug.cgi?id=111509
4204
4205         Reviewed by Dirk Pranke.
4206
4207         Add DumpRenderTree.pak to DumpRenderTree.app again.
4208
4209         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4210
4211 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
4212
4213         [chromium] introduce WebUserGestureIndicator
4214         https://bugs.webkit.org/show_bug.cgi?id=111531
4215
4216         Reviewed by Adam Barth.
4217
4218         * DumpRenderTree/chromium/WebViewHost.cpp:
4219         (WebViewHost::createView):
4220
4221 2013-03-06  Alan Cutter  <alancutter@chromium.org>
4222
4223         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
4224         https://bugs.webkit.org/show_bug.cgi?id=73482
4225
4226         Reviewed by Ryosuke Niwa.
4227
4228         Added input checking to the UpdateChromiumDEPS step.
4229         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
4230
4231         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
4232         (RollChromiumDEPS):
4233         (RollChromiumDEPS._parse_args):
4234         (RollChromiumDEPS.execute):
4235         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
4236         (IRCCommandTest.test_roll_chromium_deps):
4237         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
4238         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
4239         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
4240         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
4241         (UpdateChromiumDEPS._fetch_last_known_good_revision):
4242         (UpdateChromiumDEPS):
4243         (UpdateChromiumDEPS._parse_revision_number):
4244         (UpdateChromiumDEPS._validate_revisions):
4245         (UpdateChromiumDEPS.run):
4246         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
4247         (UpdateChromiumDEPSTest):
4248         (UpdateChromiumDEPSTest.test_parse_revision_number):
4249         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
4250         (RollChromiumDEPS):
4251         (PostChromiumDEPSRoll):
4252
4253 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
4254
4255         [Qt][MiniBrowser] Touch mocking broken for chained getures
4256         https://bugs.webkit.org/show_bug.cgi?id=111430
4257
4258         Reviewed by Jocelyn Turcotte.
4259
4260         Make it possible again to use touch mocking to test gesture chains
4261         like pan->pinch->pan->pinch without lifting the primary "finger".
4262         For this to work we need to track the pressed mouse buttons and
4263         only synthesize touch release events when the ctrl key is released
4264         if no mouse button is pressed. Else the pressed mouse button(s)
4265         should result in a stationary touch point in a touch update event.
4266         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
4267         to check for the state of the ctrl key modifier instead of getting
4268         it from the mouse events.
4269
4270         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4271         (MiniBrowserApplication::MiniBrowserApplication):
4272         (MiniBrowserApplication::notify):
4273
4274 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4275
4276         [chromium] don't use custom freetype on linux asan for now
4277         https://bugs.webkit.org/show_bug.cgi?id=111516