[Curl] Implement Cookie Accept Policy.
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2
3         [Curl] Implement Cookie Accept Policy.
4         https://bugs.webkit.org/show_bug.cgi?id=191645
5
6         Reviewed by Fujii Hironori.
7
8         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
9         (TestWebKitAPI::Curl::TEST_F):
10
11 2019-03-05  Youenn Fablet  <youenn@apple.com>
12
13         Rename requestCacheStorageSpace to requestStorageSpace
14         https://bugs.webkit.org/show_bug.cgi?id=195282
15
16         Reviewed by Chris Dumez.
17
18         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
19         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
20         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
21
22 2019-03-05  Brady Eidson  <beidson@apple.com>
23
24         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
25         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
26
27         Reviewed by Tim Horton.
28
29         Loading a file: URL into a WKWebView and then loading another file: url from a completely
30         different directory into that same WKWebView should work.
31
32         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
33         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
34
35 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
36
37         Add WeakHashSet
38         https://bugs.webkit.org/show_bug.cgi?id=195152
39
40         Reviewed by Antti Koivisto.
41
42         Added tests for WeakHashSet.
43
44         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
45         (TestWebKitAPI::Base::Base): Moved.
46         (TestWebKitAPI::Derived::foo): Moved.
47         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
48         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
49         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
50         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
51
52 2019-03-04  Chris Dumez  <cdumez@apple.com>
53
54         Do not share WebProcesses between private and regular sessions
55         https://bugs.webkit.org/show_bug.cgi?id=195189
56         <rdar://problem/48421064>
57
58         Reviewed by Alex Christensen.
59
60         Add API test coverage.
61
62         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
63         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
64
65 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
66
67         [WPE] Enable web process sandbox
68         https://bugs.webkit.org/show_bug.cgi?id=195169
69
70         Reviewed by Daniel Bates.
71
72         * wpe/install-dependencies:
73         * wpe/jhbuild.modules:
74
75 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
76
77         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
78         https://bugs.webkit.org/show_bug.cgi?id=195206
79
80         Reviewed by Žan Doberšek.
81
82         Add a new test case.
83
84         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
85         (testJSCClass):
86
87 2019-03-04  Charlie Turner  <cturner@igalia.com>
88
89         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
90         https://bugs.webkit.org/show_bug.cgi?id=194898
91
92         Reviewed by Žan Doberšek.
93
94         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
95         a GCC extension that permits arithmetic on void* pointer. Inline
96         the macro until this issue is fixed upstream.
97
98 2019-03-03  Tim Horton  <timothy_horton@apple.com>
99
100         Rid the world of WK_API_ENABLED
101         https://bugs.webkit.org/show_bug.cgi?id=195263
102
103         Reviewed by Dan Bernstein.
104
105         List of changed files elided because it's useless.
106
107 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
108
109         Unreviewed follow-up to r242292.
110
111         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
112
113         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
114         (TestWebKitAPI::testStrip): Renamed from strip.
115         (TestWebKitAPI::TEST):
116
117 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
118
119         Unreviewed, remove accidentally-committed URLHelpers.cpp test
120
121         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
122         and bug #194272 for details.
123
124         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
125
126 2019-03-03  Tim Horton  <timothy_horton@apple.com>
127
128         Remove some more unused 32-bit code
129         https://bugs.webkit.org/show_bug.cgi?id=195255
130
131         Reviewed by Darin Adler.
132
133         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
134         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
135         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
136         (NPP_New):
137         (NPP_HandleEvent):
138         (handleEventCarbon): Deleted.
139
140 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
141
142         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
143
144         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
145         (TestWebKitAPI::TEST):
146
147 2019-03-01  Darin Adler  <darin@apple.com>
148
149         Finish removing String::format
150         https://bugs.webkit.org/show_bug.cgi?id=194893
151
152         Reviewed by Daniel Bates.
153 '
154         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
155
156 2019-03-01  Alex Christensen  <achristensen@webkit.org>
157
158         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
159         https://bugs.webkit.org/show_bug.cgi?id=195229
160         <rdar://problem/48520362>
161
162         Reviewed by Chris Dumez.
163
164         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
165         (TEST):
166
167 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
168
169         Add a system trace scope for event region building
170         https://bugs.webkit.org/show_bug.cgi?id=195226
171
172         Reviewed by Jon Lee.
173
174         This trace scope measures the time spend converting element rects into Region objects,
175         which can be large on some pages.
176
177         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
178
179         * Tracing/SystemTracePoints.plist:
180
181 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
182
183         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
184         https://bugs.webkit.org/show_bug.cgi?id=194612
185
186         Reviewed by Alex Christensen.
187
188         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
189         Just test the new string-processing function and don't touch the actual environment.
190         (Test cases are all as before, but based on operator== instead of strcmp.)
191
192 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
193
194         [ews-app] Update primary keys for handling multiple Buildbot instances
195         https://bugs.webkit.org/show_bug.cgi?id=195120
196
197         Reviewed by Stephanie Lewis.
198
199         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
200         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
201         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
202
203         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
204         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
205         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
206         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
207         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
208         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
209
210 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
211
212         [WinCairo] Enable service worker
213         https://bugs.webkit.org/show_bug.cgi?id=188318
214
215         Reviewed by Youenn Fablet.
216
217         * DumpRenderTree/DumpRenderTreePrefix.h:
218         * TestWebKitAPI/PlatformWin.cmake:
219         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
220         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
221         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
222
223 2019-03-01  Justin Fan  <justin_fan@apple.com>
224
225         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
226         https://bugs.webkit.org/show_bug.cgi?id=195191
227
228         Rubber-stamped by Dean Jackson.
229
230         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
231
232         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
233
234 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
235
236         Unreviewed, fix lldb webkitpy tests
237         https://bugs.webkit.org/show_bug.cgi?id=194375
238
239         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
240
241         * lldb/lldb_webkit.py:
242         (WTFStringImplProvider.is_8bit):
243
244 2019-02-28  David Quesada  <david_quesada@apple.com>
245
246         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
247         https://bugs.webkit.org/show_bug.cgi?id=195121
248         rdar://problem/48450302
249
250         Reviewed by Alex Christensen.
251
252         Add API tests for -WKNavigationAction._shouldPerformDownload in various
253         configurations where the 'download' attribute is absent, blank, or populated
254         with a filename, and where the anchor element is same-origin or cross-origin
255         (meaning the 'download' attribute shouldn't be honored).
256
257         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
258         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
259         (-[NavigationActionTestDelegate init]):
260         (-[NavigationActionTestDelegate navigationAction]):
261         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
262         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
263         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
264         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
265         (TEST):
266
267 2019-02-28  Antoine Quint  <graouts@apple.com>
268
269         Enable the Pointer Events runtime flag by default
270         https://bugs.webkit.org/show_bug.cgi?id=195156
271
272         Reviewed by Dean Jackson.
273
274         * DumpRenderTree/mac/DumpRenderTree.mm:
275         (enableExperimentalFeatures):
276
277 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
278
279         Several PasteImage API tests are flaky
280         https://bugs.webkit.org/show_bug.cgi?id=195160
281
282         Reviewed by Tim Horton.
283
284         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
285         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
286         listening for a "load" event after image load is already complete.
287
288         To address this, make these tests first register a "load" event handler, then run script to insert an image
289         element into the document, and finally wait until the load event is observed before checking image size.
290
291         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
292
293 2019-02-28  Chris Dumez  <cdumez@apple.com>
294
295         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
296         https://bugs.webkit.org/show_bug.cgi?id=195107
297
298         Reviewed by Alex Christensen.
299
300         Give some time for the zoom level to get restored.
301
302         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
303
304 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
305
306         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
307         https://bugs.webkit.org/show_bug.cgi?id=194958
308
309         Reviewed by Geoffrey Garen.
310
311         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
312         (TEST):
313
314 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
315
316         [ews-app] Update method to save build to handle builder_display_name
317         https://bugs.webkit.org/show_bug.cgi?id=195047
318
319         Reviewed by Dewei Zhu.
320
321         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
322         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
323
324 2019-02-28  Justin Fan  <justin_fan@apple.com>
325
326         [Web GPU] Enable Web GPU only on 64-bit
327         https://bugs.webkit.org/show_bug.cgi?id=195139
328
329         Because Metal is only supported on 64 bit apps.
330
331         Unreviewed build fix.
332
333         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
334
335 2019-02-27  Youenn Fablet  <youenn@apple.com>
336
337         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
338         https://bugs.webkit.org/show_bug.cgi?id=194959
339
340         Reviewed by Chris Dumez.
341
342         Spin loop until getting the condition to remove flakiness.
343
344         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
345
346 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
347
348         [ews-build] Buildbot should include builder_display_name in the build events
349         https://bugs.webkit.org/show_bug.cgi?id=195045
350
351         Reviewed by Dewei Zhu.
352
353         * BuildSlaveSupport/ews-build/events.py:
354         (Events.buildStarted): Included builder_display_name in event data. Also renamed
355         buildername to builder_name to be consistent in naming style.
356         (Events.buildFinished): Ditto.
357
358 2019-02-27  Chris Dumez  <cdumez@apple.com>
359
360         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
361         https://bugs.webkit.org/show_bug.cgi?id=194480
362
363         Reviewed by Brady Eidson.
364
365         Update existing API test to make it more likely to reproduce the issue.
366
367         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
368
369 2019-02-27  Brady Eidson  <beidson@apple.com>
370
371         Universal links from Google search results pages don't open the app.
372         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
373
374         Reviewed by Geoffrey Garen.
375
376         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
377         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
378         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
379         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
380
381 2019-02-27  Chris Dumez  <cdumez@apple.com>
382
383         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
384         https://bugs.webkit.org/show_bug.cgi?id=195102
385
386         Reviewed by Geoffrey Garen.
387
388         If the number of processes is not yet what we expect, wait a bit and check again to give
389         processes some time to exit.
390
391         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
392
393 2019-02-27  Chris Dumez  <cdumez@apple.com>
394
395         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
396         https://bugs.webkit.org/show_bug.cgi?id=194545
397
398         Reviewed by Brady Eidson.
399
400         Make sure the test navigates forward and then back only once. Previously, navigating
401         back would trigger a navigation again in a timer.
402
403         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
404
405 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
406
407         High Sierra Debug JSC test queue should use faster hardware
408         https://bugs.webkit.org/show_bug.cgi?id=194603
409
410         Rubber-stamped by Alexey Proskuryakov.
411
412         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
413
414         * BuildSlaveSupport/build.webkit.org-config/config.json:
415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
416         (BubbleQueueServer):
417         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
418         (WebKitBuildbot):
419         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
420         * QueueStatusServer/config/queues.py:
421         * Scripts/webkitpy/common/config/ews.json:
422         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
423         (test_ews_name):
424
425 2019-02-27  John Wilander  <wilander@apple.com>
426
427         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
428         https://bugs.webkit.org/show_bug.cgi?id=195071
429         <rdar://problem/48417690>
430
431         Reviewed by Alex Christensen and Brent Fulgham.
432
433         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
434         (TestWebKitAPI::createURL):
435             Convenience function.
436         (TestWebKitAPI::TEST):
437             WebCore::AdClickAttribution now takes a URL when creating Source and
438             Destination.
439         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
440         (TestWebKitAPI::TEST):
441             WebCore::AdClickAttribution now takes a URL when creating Source and
442             Destination.
443
444 2019-02-27  Antoine Quint  <graouts@apple.com>
445
446         Support Pointer Events on macOS
447         https://bugs.webkit.org/show_bug.cgi?id=195008
448         <rdar://problem/47454419>
449
450         Reviewed by Dean Jackson.
451
452         * DumpRenderTree/mac/DumpRenderTree.mm:
453         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
454         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
455
456 2019-02-26  Mark Lam  <mark.lam@apple.com>
457
458         Remove remaining poisoning code.
459         https://bugs.webkit.org/show_bug.cgi?id=194138
460
461         Reviewed by Saam Barati.
462
463         * TestWebKitAPI/CMakeLists.txt:
464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
465         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
466         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
467         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
468         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
469         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
470         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
471
472 2019-02-26  Alex Christensen  <achristensen@webkit.org>
473
474         Move ephemeral local storage from WebProcess to UIProcess
475         https://bugs.webkit.org/show_bug.cgi?id=195074
476         <rdar://problem/47937975>
477
478         Reviewed by Geoff Garen.
479
480         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
481
482 2019-02-20  Jer Noble  <jer.noble@apple.com>
483
484         [Cocoa] Media elements will restart network buffering just before suspending
485         https://bugs.webkit.org/show_bug.cgi?id=193691
486
487         Reviewed by Eric Carlson.
488
489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
490         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
491         (TEST):
492
493 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
494
495         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
496         https://bugs.webkit.org/show_bug.cgi?id=191652
497
498         Reviewed by Alex Christensen.
499
500         Fix WinCairo MiniBrowser behavior of authentication dialog.
501
502         * MiniBrowser/win/WebKitBrowserWindow.cpp:
503         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
504
505 2019-02-26  Youenn Fablet  <youenn@apple.com>
506
507         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
508         https://bugs.webkit.org/show_bug.cgi?id=195028
509         <rdar://problem/48243733>
510
511         Reviewed by Eric Carlson.
512
513         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
514
515 2019-02-26  Philippe Normand  <pnormand@igalia.com>
516
517         [WPE] Add API for webview background color configuration
518         https://bugs.webkit.org/show_bug.cgi?id=192305
519
520         Reviewed by Michael Catanzaro.
521
522         * MiniBrowser/wpe/main.cpp:
523         (main): Add a new option to configure the webview background
524         color. Example: --bg-color=transparent.
525         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
526         (testWebViewBackgroundColor): Enable background color API tests for WPE.
527         (beforeAll): Ditto.
528
529 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
530
531         scalableNativeWebpageParameters() is not preserved on new page navigation.
532         https://bugs.webkit.org/show_bug.cgi?id=194892
533         <rdar://problem/47538280>
534
535         Reviewed by Wenson Hsieh.
536         
537         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
538
539         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
540         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
541         * DumpRenderTree/mac/UIScriptControllerMac.mm:
542         (WTR::UIScriptController::allowsViewportShrinkToFit):
543         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
544         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
545         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
546         * TestRunnerShared/UIScriptContext/UIScriptController.h:
547         * WebKitTestRunner/UIScriptControllerCocoa.mm:
548         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
549
550 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
551
552         [ews-app] Add model for handling multiple Buildbot instances
553         https://bugs.webkit.org/show_bug.cgi?id=194863
554
555         Reviewed by Stephanie Lewis.
556
557         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
558
559 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
560
561         [ews-app] Remove BuilderMapping table
562         https://bugs.webkit.org/show_bug.cgi?id=194961
563
564         Reviewed by Stephanie Lewis.
565
566         Store builder name directly in build table, instead of having a separate
567         table for it.
568
569         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
570         * BuildSlaveSupport/ews-app/ews/models/build.py:
571         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
572         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
573
574 2019-02-25  John Wilander  <wilander@apple.com>
575
576         Introduce and adopt new class RegistrableDomain for eTLD+1
577         https://bugs.webkit.org/show_bug.cgi?id=194791
578         <rdar://problem/48179240>
579
580         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
581
582         This patch adds an API test and replaces two instances of
583         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
584
585         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
586         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
587         (TestWebKitAPI::TEST):
588             Changed two strings to make sure the registrable domains are still considered
589             invalid and pass the test.
590         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
591         (TestWebKitAPI::TEST):
592         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
593         (WTR::InjectedBundle::didReceiveMessageToPage):
594
595 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
596
597         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
598         https://bugs.webkit.org/show_bug.cgi?id=195001
599
600         Reviewed by Carlos Garcia Campos.
601
602         API version 1.0 always includes the functionality previously guarded with
603         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
604         unconditionally.
605
606         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
607         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
608         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
609         (WebViewTest::showInWindow): Ditto.
610         (WebViewTest::hideView): Ditto.
611         * wpe/backends/HeadlessViewBackend.cpp:
612         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
613         * wpe/backends/ViewBackend.cpp:
614         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
615         * wpe/backends/WindowViewBackend.cpp:
616         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
617         WPE_BACKEND_CHECK_VERSION().
618         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
619
620 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
621
622         [Flatpak] Add support for flatpak > 1.1.2
623         https://bugs.webkit.org/show_bug.cgi?id=194088
624
625         Flatpak 1.2 is now out so we need to support that
626         version now.
627
628         Reviewed by Michael Catanzaro.
629
630         * flatpak/flatpakutils.py:
631         (check_flatpak):
632         (FlatpakPackages.__init__):
633         (FlatpakPackages.__detect_packages):
634         (FlatpakPackages.__detect_packages.in):
635         (FlatpakRepos.update):
636
637 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
638
639         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
640         https://bugs.webkit.org/show_bug.cgi?id=194998
641
642         Reviewed by Carlos Garcia Campos.
643
644         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
645         to a Git checkout and using the latest commit containing various fixes
646         and improvements.
647
648 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
649
650         [WPE][GTK] Remove user agent quirk for washingtonpost.com
651         https://bugs.webkit.org/show_bug.cgi?id=194981
652
653         Reviewed by Žan Doberšek.
654
655         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
656         (TestWebKitAPI::TEST):
657
658 2019-02-23  Keith Miller  <keith_miller@apple.com>
659
660         Add new mac target numbers
661         https://bugs.webkit.org/show_bug.cgi?id=194955
662
663         Reviewed by Tim Horton.
664
665         * DumpRenderTree/mac/Configurations/Base.xcconfig:
666         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
667         * MiniBrowser/Configurations/Base.xcconfig:
668         * TestWebKitAPI/Configurations/Base.xcconfig:
669         * WebKitTestRunner/Configurations/Base.xcconfig:
670
671 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
672
673         [WinCairo] Enable wk1/wk2 suffix for platform search path.
674         https://bugs.webkit.org/show_bug.cgi?id=194846
675
676         Reviewed by Don Olmstead.
677
678         Added _search_paths() and _port_specific_expectations_files() for
679         WinCairoPort.
680
681         * Scripts/webkitpy/port/win.py:
682         (WinCairoPort.default_baseline_search_path):
683         (WinCairoPort):
684         (WinCairoPort._port_specific_expectations_files):
685         (WinCairoPort._search_paths):
686
687 2019-02-22  Tim Horton  <timothy_horton@apple.com>
688
689         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
690         https://bugs.webkit.org/show_bug.cgi?id=194963
691
692         Reviewed by Dean Jackson.
693
694         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
695         Do a `contains` check instead of `equals`, because in debug builds we
696         put the GraphicsLayer pointer in a prefix.
697
698 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
699
700         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
701         https://bugs.webkit.org/show_bug.cgi?id=194873
702         <rdar://problem/46701974>
703
704         Reviewed by Tim Horton.
705
706         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
707
708         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
709         (WTR::UIScriptController::menuRect const):
710         (WTR::UIScriptController::isShowingMenu const):
711         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
712         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
713         (WTR::UIScriptController::menuRect const):
714
715         Add a function to query the bounds of the callout menu in content coordinates.
716
717         (WTR::UIScriptController::isShowingMenu const):
718
719         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
720
721         * TestRunnerShared/UIScriptContext/UIScriptController.h:
722         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
723         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
724         (WTR::UIScriptController::rectForMenuAction const):
725         (WTR::UIScriptController::menuRect const):
726         (WTR::UIScriptController::isShowingMenu const):
727         (WTR::findViewInHierarchyOfType): Deleted.
728
729 2019-02-22  Chris Dumez  <cdumez@apple.com>
730
731         Regression(PSON) Unable to preview password-protected documents on iCloud.com
732         https://bugs.webkit.org/show_bug.cgi?id=194954
733         <rdar://problem/48127957>
734
735         Reviewed by Alex Christensen.
736
737         Add API test coverage.
738
739         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
740         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
741         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
742         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
743
744 2019-02-22  Chris Dumez  <cdumez@apple.com>
745
746         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
747         https://bugs.webkit.org/show_bug.cgi?id=194924
748         <rdar://problem/48216125>
749
750         Reviewed by Geoffrey Garen.
751
752         Add API test coverage.
753
754         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
755
756 2019-02-22  Chris Dumez  <cdumez@apple.com>
757
758         Unreviewed, disable API test added in r241928 on iOS.
759
760         The cache is not enabled on devices with less than 3GB of RAM.
761
762         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
763
764 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
765
766         Hardcode Visual Viewports on everywhere except iOS WK1
767         https://bugs.webkit.org/show_bug.cgi?id=194928
768
769         Reviewed by Zalan Bujtas.
770
771         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
772         change the default value of the Setting to 'true', and hardcode WebView on iOS to
773         set it to false. The setting has shipped for several years and there's no need to turn
774         it off now.
775
776         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
777         Visual Viewports are not enabled.
778         
779         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
780         that only runs in WK2
781
782         * MiniBrowser/mac/SettingsController.h:
783         * MiniBrowser/mac/SettingsController.m:
784         (-[SettingsController init]):
785         (-[SettingsController _populateMenu]):
786         (-[SettingsController validateMenuItem:]):
787         (-[SettingsController visualViewportEnabled]): Deleted.
788         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
789         * MiniBrowser/mac/WK1BrowserWindowController.m:
790         (-[WK1BrowserWindowController didChangeSettings]):
791         * MiniBrowser/mac/WK2BrowserWindowController.m:
792         (-[WK2BrowserWindowController didChangeSettings]):
793
794 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
795
796         Discard cached processes when clearing website data store
797         https://bugs.webkit.org/show_bug.cgi?id=194894
798
799         Reviewed by Chris Dumez.
800
801         Added a test case.
802
803         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
804         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
805
806 2019-02-21  Alex Christensen  <achristensen@webkit.org>
807
808         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
809         https://bugs.webkit.org/show_bug.cgi?id=194914
810         <rdar://problem/47586889>
811
812         Reviewed by Geoffrey Garen.
813
814         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
815         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
816         (TEST):
817         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
818
819 2019-02-21  David Kilzer  <ddkilzer@apple.com>
820
821         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
822         <https://webkit.org/b/194761>
823
824         Reviewed by Myles Maxfield.
825
826         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
827         (WTR::activateSystemCoreWebFonts): Log `error` to console if
828         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
829         to use ARC-compliant cast.
830         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
831         ARC-compliant cast.
832         (WTR::installFakeHelvetica): Log `error` to console if
833         CTFontManagerRegisterFontsForURL() fails, but only on supported
834         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
835         Call CFRelease() on `error` to fix the leak.  Update to use
836         ARC-compliant cast.
837         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
838         cast.
839
840 2019-02-21  Chris Dumez  <cdumez@apple.com>
841
842         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
843         https://bugs.webkit.org/show_bug.cgi?id=194481
844
845         Reviewed by Alex Christensen.
846
847         Give the processes a chance to shutdown and wait until we reached the expected number
848         of processes.
849
850         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
851
852 2019-02-21  Tim Horton  <timothy_horton@apple.com>
853
854         Fix the macOS build
855
856         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
857
858 2019-02-21  Tim Horton  <timothy_horton@apple.com>
859
860         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
861
862         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
863         I am a backwards.
864
865 2019-02-21  Tim Horton  <timothy_horton@apple.com>
866
867         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
868
869         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
870         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
871         We could force on UI-side compositing, but I feel like the test might be more
872         valuable exercising the normal path on each platform (though the original
873         bug was also UI-side specific). Though we can't validate that the overlay
874         layer was installed successfully, there are layout tests that do that.
875
876 2019-02-21  Tim Horton  <timothy_horton@apple.com>
877
878         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
879         https://bugs.webkit.org/show_bug.cgi?id=194845
880         <rdar://problem/47944579>
881
882         Reviewed by Antti Koivisto.
883
884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
885         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
886
887 2019-02-21  Zalan Bujtas  <zalan@apple.com>
888
889         [LFC][Floats] Add support for placing formatting roots in-between floats.
890         https://bugs.webkit.org/show_bug.cgi?id=194902
891
892         Reviewed by Antti Koivisto.
893
894         * LayoutReloaded/misc/LFC-passing-tests.txt:
895
896 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
897
898         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
899         https://bugs.webkit.org/show_bug.cgi?id=194901
900
901         Unreviewed build fix.
902
903         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
904         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
905         WPEBackend-fdo-0.1 as library name.
906
907 2019-02-21  Rob Buis  <rbuis@igalia.com>
908
909         Update MIME type parser
910         https://bugs.webkit.org/show_bug.cgi?id=180526
911
912         Reviewed by Darin Adler.
913
914         Add tests involving leading and trailing whitespace, non-token
915         characters and quoted strings.
916
917         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
918         (TestWebKitAPI::TEST):
919
920 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
921
922         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
923         https://bugs.webkit.org/show_bug.cgi?id=194884
924
925         Reviewed by Michael Catanzaro.
926
927         * PlatformWin.cmake:
928
929 2019-02-20  Chris Dumez  <cdumez@apple.com>
930
931         Add API test for <rdar://problem/47471222>
932         https://bugs.webkit.org/show_bug.cgi?id=194847
933
934         Reviewed by Alex Christensen.
935
936         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
937
938 2019-02-20  Chris Dumez  <cdumez@apple.com>
939
940         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
941         https://bugs.webkit.org/show_bug.cgi?id=194872
942         <rdar://problem/47924500>
943
944         Reviewed by Alex Christensen.
945
946         Add API test coverage.
947
948         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
949
950 2019-02-20  Jer Noble  <jer.noble@apple.com>
951
952         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
953         https://bugs.webkit.org/show_bug.cgi?id=191332
954
955         Reviewed by Dean Jackson.
956
957         * Scripts/git-is-in-range: Added.
958
959 2019-02-20  Andy Estes  <aestes@apple.com>
960
961         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
962         https://bugs.webkit.org/show_bug.cgi?id=194869
963
964         Rubber-stamped by Jer Noble.
965
966         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
967         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
968         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
969         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
970         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
971         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
972
973 2019-02-20  Chris Dumez  <cdumez@apple.com>
974
975         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
976         https://bugs.webkit.org/show_bug.cgi?id=194857
977         <rdar://problem/47759323>
978
979         Reviewed by Alex Christensen.
980
981         Add API test coverage.
982
983         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
984
985 2019-02-20  Chris Dumez  <cdumez@apple.com>
986
987         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
988         https://bugs.webkit.org/show_bug.cgi?id=194829
989         <rdar://problem/47889906>
990
991         Reviewed by Alexey Proskuryakov.
992
993         Every time the TestOptions were changing we were creating both a new Web view and
994         a new WKContext, which would start a new Network process. In most cases, we only
995         need to contruct a new Web view and we do can keep reusing the same WKContext.
996         This patch implements this optimization and thus avoids spinning a lot of new
997         Network processes while running the layout tests.
998
999         * WebKitTestRunner/TestController.cpp:
1000         (WTR::TestController::generateContextConfiguration const):
1001         (WTR::TestController::generatePageConfiguration):
1002         (WTR::TestController::createWebViewWithOptions):
1003         (WTR::TestController::resetPreferencesToConsistentValues):
1004         (WTR::updateTestOptionsFromTestHeader):
1005         * WebKitTestRunner/TestController.h:
1006         * WebKitTestRunner/TestOptions.h:
1007         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1008         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1009         (WTR::TestOptions::hasSameInitializationOptions const):
1010         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1011         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1012         (WTR::TestController::platformAddTestOptions const):
1013
1014 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1015
1016         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1017         https://bugs.webkit.org/show_bug.cgi?id=167941
1018
1019         Reviewed by Carlos Garcia Campos.
1020
1021         * MiniBrowser/gtk/main.c:
1022         (filterSavedCallback): Added.
1023         (main): Support loading a JSON rule set file for content filtering.
1024         * MiniBrowser/wpe/main.cpp:
1025         (filterSavedCallback): Added.
1026         (main): Support loading a JSON rule set file for content filtering.
1027         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1028         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1029         (WTF::derefGPtr): Ditto.
1030         (testEmptyStore):
1031         (testSaveInvalidFilter):
1032         (testSaveLoadFilter):
1033         (testSavedFilterIdentifierMatch):
1034         (testRemoveFilter):
1035         (testSaveMultipleFilters):
1036         (testSaveFilterFromFile):
1037         (testFilterPersistence):
1038         (beforeAll):
1039         (afterAll):
1040         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1041         (removeOldInjectedContentAndResetLists): Also reset content filters.
1042         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1043         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1044         the element affected by the style sheet.
1045         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1046         and returns it to be used by tests.
1047         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1048         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1049         (serverCallback): Add support for serving a CSS style sheet for testing.
1050         (beforeAll): Add call to testUserContentManagerContentFilter().
1051         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1052
1053 2019-02-19  Keith Rollin  <krollin@apple.com>
1054
1055         Add timing information to build output
1056         https://bugs.webkit.org/show_bug.cgi?id=194839
1057         <rdar://problem/48219609>
1058
1059         Reviewed by Alexey Proskuryakov.
1060
1061         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1062         emit each project's build time to its output. E.g.,
1063
1064             ** BUILD SUCCEEDED ** [0.132 sec]
1065
1066         * Scripts/webkitdirs.pm:
1067         (XcodeOptions):
1068
1069 2019-02-19  Truitt Savell  <tsavell@apple.com>
1070
1071         Unreviewed, rolling out r241784.
1072
1073         Broke all OpenSource builds.
1074
1075         Reverted changeset:
1076
1077         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1078         instances view"
1079         https://bugs.webkit.org/show_bug.cgi?id=172848
1080         https://trac.webkit.org/changeset/241784
1081
1082 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1083
1084         [LFC][Floats] Remove redundant intersecting logic
1085         https://bugs.webkit.org/show_bug.cgi?id=194804
1086
1087         Reviewed by Antti Koivisto.
1088
1089         * LayoutReloaded/misc/LFC-passing-tests.txt:
1090
1091 2019-02-19  Dean Jackson  <dino@apple.com>
1092
1093         Clean-up output from generate-xcfilelists so it can be filtered
1094         https://bugs.webkit.org/show_bug.cgi?id=194795
1095
1096         Reviewed by Joseph Pecoraro (and Keith Rollin).
1097
1098         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1099         make a slight tweak to filter-build-webkit so such lines are marked
1100         as plain.
1101
1102         * Scripts/filter-build-webkit:
1103         * Scripts/generate-xcfilelists:
1104
1105 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1106
1107         pytest is not correctly auto-installed
1108         https://bugs.webkit.org/show_bug.cgi?id=194707
1109
1110         Reviewed by Carlos Garcia Campos.
1111
1112         * Scripts/webkitpy/thirdparty/__init__.py:
1113         (AutoinstallImportHook._install_pytest):
1114
1115 2019-02-18  Chris Dumez  <cdumez@apple.com>
1116
1117         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1118         https://bugs.webkit.org/show_bug.cgi?id=194797
1119         <rdar://problem/48055151>
1120
1121         Reviewed by Geoffrey Garen.
1122
1123         Add API test coverage.
1124
1125         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1126
1127 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1128
1129         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1130         https://bugs.webkit.org/show_bug.cgi?id=194670
1131         <rdar://problem/39066529>
1132
1133         Reviewed by Tim Horton.
1134
1135         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1136         pasted in an editable area as attachment elements.
1137
1138         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1139         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1140         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1141         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1142         (TestWebKitAPI::TEST):
1143         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1144         (WTR::InjectedBundlePage::InjectedBundlePage):
1145
1146 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1147
1148         Fix API test after r241728
1149        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1150
1151         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1152         (TEST):
1153         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1154
1155 2019-02-18  Daniel Bates  <dabates@apple.com>
1156
1157         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1158         https://bugs.webkit.org/show_bug.cgi?id=192824
1159         <rdar://problem/47100332>
1160
1161         Reviewed by Wenson Hsieh.
1162
1163         Fix a bug where the wrong usage code was used for F13 thru F24.
1164
1165         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1166         (keyCodeForDOMFunctionKey):
1167
1168 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1169
1170         Bytecode cache should a have a boot-specific validation
1171         https://bugs.webkit.org/show_bug.cgi?id=194769
1172         <rdar://problem/48149509>
1173
1174         Reviewed by Keith Miller.
1175
1176         Add test for WTF::bootSessionUUIDString()
1177
1178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1179         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1180         (TEST):
1181
1182 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1183
1184         Disable safe browsing in WKWebView and remove its WKPreferences API
1185         https://bugs.webkit.org/show_bug.cgi?id=194723
1186         <rdar://problem/48122993>
1187
1188         Reviewed by Geoffrey Garen.
1189
1190         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1191         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1192         (TEST):
1193         (safeBrowsingView):
1194         Make tests use SPI instead of API.
1195
1196 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1197
1198         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1199         https://bugs.webkit.org/show_bug.cgi?id=194586
1200
1201         Reviewed by Ross Kirsling.
1202
1203         * DumpRenderTree/win/DumpRenderTree.cpp:
1204         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1205         * Scripts/webkitpy/port/driver.py:
1206         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1207
1208 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1209
1210         Unreviewed, rolling out r241620.
1211
1212         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1213         (Requested by ddkilzer on #webkit.)
1214
1215         Reverted changeset:
1216
1217         "[WTF] Add environment variable helpers"
1218         https://bugs.webkit.org/show_bug.cgi?id=192405
1219         https://trac.webkit.org/changeset/241620
1220
1221 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1222
1223         [LFC] RenderImage's default intrinsic size is 0.
1224         https://bugs.webkit.org/show_bug.cgi?id=194745
1225
1226         Reviewed by Antti Koivisto.
1227
1228         * LayoutReloaded/misc/LFC-passing-tests.txt:
1229
1230 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1231
1232         [LFC][BFC] Add support for block replaced intrinsic width.
1233         https://bugs.webkit.org/show_bug.cgi?id=194705
1234
1235         Reviewed by Simon Fraser.
1236
1237         * LayoutReloaded/misc/LFC-passing-tests.txt:
1238
1239 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1240
1241         [LFC] Apply min/max width constraints to preferred width computation
1242         https://bugs.webkit.org/show_bug.cgi?id=194739
1243
1244         Reviewed by Simon Fraser.
1245
1246         * LayoutReloaded/misc/LFC-passing-tests.txt:
1247
1248 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1249
1250         [WTF] Add environment variable helpers
1251         https://bugs.webkit.org/show_bug.cgi?id=192405
1252
1253         Reviewed by Michael Catanzaro.
1254
1255         * DumpRenderTree/mac/DumpRenderTree.mm:
1256         (libraryPathForDumpRenderTree):
1257         * DumpRenderTree/win/DumpRenderTree.cpp:
1258         (libraryPathForDumpRenderTree):
1259         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1260         (setUpIOSLayoutTestCommunication):
1261         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1262         (beforeAll):
1263         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1264         (main):
1265         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1266         (WebKitTestBus::run):
1267         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1268         (WTR::getOutputDir):
1269         (WTR::initializeFontConfigSetting):
1270         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1271         (WTR::InjectedBundle::platformInitialize):
1272         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1273         (WTR::topLevelPath):
1274         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1275         (WTR::topLevelPath):
1276         (WTR::getOutputDir):
1277         (WTR::activateFonts):
1278         * WebKitTestRunner/TestController.cpp:
1279         (WTR::TestController::libraryPathForTesting):
1280         (WTR::TestController::generateContextConfiguration const):
1281         (WTR::TestController::generatePageConfiguration):
1282         (WTR::TestController::decideDestinationWithSuggestedFilename):
1283         (WTR::TestController::platformAdjustContext):
1284         * WebKitTestRunner/TestController.h:
1285         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1286         (WTR::TestController::cocoaPlatformInitialize):
1287         (WTR::TestController::platformAdjustContext):
1288         * WebKitTestRunner/gtk/main.cpp:
1289         (main):
1290         * WebKitTestRunner/mac/TestControllerMac.mm:
1291         (WTR::TestController::configureContentExtensionForTest):
1292         * WebKitTestRunner/wpe/main.cpp:
1293         (main):
1294         Utilize WTF::Environment where possible.
1295
1296 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1297
1298         [iOS] WKWebView callout bar is missing Change Writing Direction item
1299         https://bugs.webkit.org/show_bug.cgi?id=190015
1300         <rdar://problem/44810366>
1301
1302         Reviewed by Tim Horton.
1303
1304         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1305         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1306
1307         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1308         (TestWebKitAPI::TEST):
1309
1310 2019-02-15  Chris Dumez  <cdumez@apple.com>
1311
1312         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1313         https://bugs.webkit.org/show_bug.cgi?id=194717
1314         <rdar://problem/47884404>
1315
1316         Reviewed by Brady Eidson.
1317
1318         Add API test coverage.
1319
1320         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1321
1322 2019-02-15  Youenn Fablet  <youenn@apple.com>
1323
1324         Make navigator.mediaDevices SecureContext
1325         https://bugs.webkit.org/show_bug.cgi?id=194666
1326
1327         Reviewed by Eric Carlson.
1328
1329         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1330         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1331         (TEST_F):
1332
1333 2019-02-15  Brian Burg  <bburg@apple.com>
1334
1335         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1336         https://bugs.webkit.org/show_bug.cgi?id=194411
1337         <rdar://problem/47787614>
1338
1339         Reviewed by Joseph Pecoraro.
1340
1341         Remove unnecessary soft linking macro usage.
1342
1343         * DumpRenderTree/mac/TestRunnerMac.mm:
1344         (TestRunner::inspectorTestStubURL):
1345         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1346         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1347         (WTR::TestRunner::inspectorTestStubURL):
1348
1349 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1350
1351         Unreviewed, rolling out r241559 and r241566.
1352         https://bugs.webkit.org/show_bug.cgi?id=194710
1353
1354         Causes layout test crashes under GuardMalloc (Requested by
1355         ryanhaddad on #webkit).
1356
1357         Reverted changesets:
1358
1359         "[WTF] Add environment variable helpers"
1360         https://bugs.webkit.org/show_bug.cgi?id=192405
1361         https://trac.webkit.org/changeset/241559
1362
1363         "Unreviewed build fix for WinCairo Debug after r241559."
1364         https://trac.webkit.org/changeset/241566
1365
1366 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1367
1368         [LFC] Out-of-flow box is never a float box
1369         https://bugs.webkit.org/show_bug.cgi?id=194704
1370
1371         Reviewed by Antti Koivisto.
1372
1373         * LayoutReloaded/misc/LFC-passing-tests.txt:
1374
1375 2019-02-10  Darin Adler  <darin@apple.com>
1376
1377         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1378         https://bugs.webkit.org/show_bug.cgi?id=194487
1379
1380         Reviewed by Daniel Bates.
1381
1382         * DumpRenderTree/win/DumpRenderTree.cpp:
1383         (applicationId): Use makeString instead of String::format.
1384         (main): Ditto.
1385         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1386         (TestWebKitAPI::Util::createURLForResource): Ditto.
1387         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1388         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1389
1390         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1391         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1392         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1393         (WTR::createStringWithAttributes): Use appendLiteral.
1394         (WTR::AccessibilityUIElement::helpText const): Ditto.
1395         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1396         directly instead of using String::format.
1397         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1398         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1399
1400 2019-02-15  Truitt Savell  <tsavell@apple.com>
1401
1402         Unreviewed, rolling out r241564.
1403
1404         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1405
1406         Reverted changeset:
1407
1408         "[Mac] WebInspectorUI.framework does not need to be soft-
1409         linked anymore"
1410         https://bugs.webkit.org/show_bug.cgi?id=194411
1411         https://trac.webkit.org/changeset/241564
1412
1413 2019-02-15  Saam barati  <sbarati@apple.com>
1414
1415         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1416         https://bugs.webkit.org/show_bug.cgi?id=194036
1417
1418         Reviewed by Yusuke Suzuki.
1419
1420         * Scripts/run-jsc-stress-tests:
1421
1422 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1423
1424         Fix the build.
1425
1426         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1427         (WTR::UIScriptController::drawSquareInEditableImage):
1428         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1429         (TestWebKitAPI::drawSquareInEditableImage):
1430
1431 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1432
1433         Fix the build.
1434
1435         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1436         (WTR::UIScriptController::drawSquareInEditableImage):
1437         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1438         (TestWebKitAPI::drawSquareInEditableImage):
1439
1440 2019-02-14  Brian Burg  <bburg@apple.com>
1441
1442         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1443         https://bugs.webkit.org/show_bug.cgi?id=194411
1444         <rdar://problem/47787614>
1445
1446         Reviewed by Joseph Pecoraro.
1447
1448         Remove unnecessary soft linking macro usage.
1449
1450         * DumpRenderTree/mac/TestRunnerMac.mm:
1451         (TestRunner::inspectorTestStubURL):
1452         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1453         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1454         (WTR::TestRunner::inspectorTestStubURL):
1455
1456 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1457
1458         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1459         https://bugs.webkit.org/show_bug.cgi?id=194599
1460
1461         Reviewed by Lucas Forschler.
1462
1463         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1464         (StatusBubble._build_bubble):
1465
1466 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1467
1468         [ews-app] Set Foreign Key in Django build model
1469         https://bugs.webkit.org/show_bug.cgi?id=194667
1470
1471         Reviewed by Lucas Forschler.
1472
1473         * BuildSlaveSupport/ews-app/ews/models/build.py:
1474         (Build):
1475
1476 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1477
1478         [WTF] Add environment variable helpers
1479         https://bugs.webkit.org/show_bug.cgi?id=192405
1480
1481         Reviewed by Michael Catanzaro.
1482
1483         * DumpRenderTree/mac/DumpRenderTree.mm:
1484         (libraryPathForDumpRenderTree):
1485         * DumpRenderTree/win/DumpRenderTree.cpp:
1486         (libraryPathForDumpRenderTree):
1487         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1488         (setUpIOSLayoutTestCommunication):
1489         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1490         (TestWebKitAPI::strip):
1491         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1492         (beforeAll):
1493         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1494         (main):
1495         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1496         (WebKitTestBus::run):
1497         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1498         (WTR::getOutputDir):
1499         (WTR::initializeFontConfigSetting):
1500         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1501         (WTR::InjectedBundle::platformInitialize):
1502         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1503         (WTR::topLevelPath):
1504         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1505         (WTR::topLevelPath):
1506         (WTR::getOutputDir):
1507         (WTR::activateFonts):
1508         * WebKitTestRunner/TestController.cpp:
1509         (WTR::TestController::libraryPathForTesting):
1510         (WTR::TestController::generateContextConfiguration const):
1511         (WTR::TestController::generatePageConfiguration):
1512         (WTR::TestController::decideDestinationWithSuggestedFilename):
1513         (WTR::TestController::platformAdjustContext):
1514         * WebKitTestRunner/TestController.h:
1515         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1516         (WTR::TestController::cocoaPlatformInitialize):
1517         (WTR::TestController::platformAdjustContext):
1518         * WebKitTestRunner/gtk/main.cpp:
1519         (main):
1520         * WebKitTestRunner/mac/TestControllerMac.mm:
1521         (WTR::TestController::configureContentExtensionForTest):
1522         * WebKitTestRunner/wpe/main.cpp:
1523         (main):
1524         Utilize WTF::Environment where possible.
1525
1526 2019-02-14  Chris Dumez  <cdumez@apple.com>
1527
1528         [PSON] Introduce a WebContent Process cache
1529         https://bugs.webkit.org/show_bug.cgi?id=194594
1530         <rdar://problem/46793397>
1531
1532         Reviewed by Geoff Garen.
1533
1534         Update API tests to turn on the WebContent Process cache.
1535
1536         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1537
1538 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1539
1540         Unreviewed, build fix after r241480
1541
1542         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1543         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1544         (-[DragAndDropSimulator initWithWebView:]):
1545
1546 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1547
1548         AX: ARIA Reflection was disabled in error
1549         https://bugs.webkit.org/show_bug.cgi?id=194647
1550         <rdar://problem/48068336>
1551
1552         Reviewed by Ryosuke Niwa.
1553
1554         Remove test override now that this feature should be enabled by default.
1555
1556         * WebKitTestRunner/TestController.cpp:
1557         (WTR::TestController::resetPreferencesToConsistentValues):
1558
1559 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1560
1561         Unreviewed, rolling out r241486.
1562         https://bugs.webkit.org/show_bug.cgi?id=194655
1563
1564         causing API failures in builds (Requested by ShawnRoberts on
1565         #webkit).
1566
1567         Reverted changeset:
1568
1569         "[Cocoa] Media elements will restart network buffering just
1570         before suspending"
1571         https://bugs.webkit.org/show_bug.cgi?id=193691
1572         https://trac.webkit.org/changeset/241486
1573
1574 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1575
1576         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1577         https://bugs.webkit.org/show_bug.cgi?id=194622
1578
1579         Reviewed by Antti Koivisto.
1580
1581         * LayoutReloaded/misc/LFC-passing-tests.txt:
1582
1583 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1584
1585         [LFC] Shrink-to-fit-width should be constrained by min/max width
1586         https://bugs.webkit.org/show_bug.cgi?id=194653
1587
1588         Reviewed by Antti Koivisto.
1589
1590         * LayoutReloaded/misc/LFC-passing-tests.txt:
1591
1592 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1593
1594         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1595         https://bugs.webkit.org/show_bug.cgi?id=194641
1596
1597         Reviewed by Geoffrey Garen.
1598
1599         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1600         so that the test would fail without this fix.
1601
1602         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1603         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1604
1605 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1606
1607         [ews-app] Change log level for a log statement
1608
1609         Unreviewed minor fix.
1610
1611         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1612         (Patch.save_patch):
1613
1614 2019-02-13  Jer Noble  <jer.noble@apple.com>
1615
1616         [Cocoa] Media elements will restart network buffering just before suspending
1617         https://bugs.webkit.org/show_bug.cgi?id=193691
1618
1619         Reviewed by Eric Carlson.
1620
1621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1622         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1623         (TEST):
1624
1625 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1626
1627         [ews-app] Fetch builder id to name mapping
1628         https://bugs.webkit.org/show_bug.cgi?id=194355
1629
1630         Reviewed by Lucas Forschler.
1631
1632         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1633         (Buildbot.get_builder_id_to_name_mapping):
1634         (Buildbot._get_display_name_from_builder_name):
1635
1636 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1637
1638         Further restricting webarchive loads
1639         https://bugs.webkit.org/show_bug.cgi?id=194567
1640         <rdar://problem/47610130>
1641
1642         Reviewed by Youenn Fablet.
1643
1644         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1645         navigations on drop.
1646
1647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1648         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1649         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1650         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1651         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1652         (TestWebKitAPI::TEST):
1653         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1654         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1655         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1656         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1657         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1658         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1659         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1660
1661 2019-02-13  John Wilander  <wilander@apple.com>
1662
1663         Store Ad Click Attribution requests in the network process
1664         https://bugs.webkit.org/show_bug.cgi?id=194510
1665         <rdar://problem/47650118>
1666
1667         Reviewed by Alex Christensen and Daniel Bates.
1668
1669         This patch adds two TestRunner functions:
1670         - dumpAdClickAttribution()
1671         - clearAdClickAttribution()
1672
1673         They call into the network process to dump and clear Ad Click
1674         Attribution state, respectively.
1675
1676         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1677         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1678         (WTR::TestRunner::dumpAdClickAttribution):
1679         (WTR::TestRunner::clearAdClickAttribution):
1680         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1681         * WebKitTestRunner/TestController.cpp:
1682         (WTR::TestController::resetStateToConsistentValues):
1683         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1684         (WTR::adClickAttributionStringResultCallback):
1685         (WTR::TestController::dumpAdClickAttribution):
1686         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1687         (WTR::adClickAttributionVoidCallback):
1688         (WTR::TestController::clearAdClickAttribution):
1689         * WebKitTestRunner/TestController.h:
1690         * WebKitTestRunner/TestInvocation.cpp:
1691         (WTR::TestInvocation::dumpResults):
1692         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1693         (WTR::TestInvocation::dumpAdClickAttribution):
1694         * WebKitTestRunner/TestInvocation.h:
1695
1696 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1697
1698         [ews-app] Generate status-bubble
1699         https://bugs.webkit.org/show_bug.cgi?id=194572
1700
1701         Reviewed by Lucas Forschler.
1702
1703         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1704         (StatusBubble._build_bubble):
1705         (StatusBubble._should_show_bubble_for):
1706         (StatusBubble._build_bubbles_for_patch):
1707
1708 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1709
1710         [ews-app] Add status bubble html template
1711         https://bugs.webkit.org/show_bug.cgi?id=194571
1712
1713         Reviewed by Lucas Forschler.
1714
1715         * BuildSlaveSupport/ews-app/ews/templates: Added.
1716         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1717
1718 2019-02-12  Chris Dumez  <cdumez@apple.com>
1719
1720         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1721         https://bugs.webkit.org/show_bug.cgi?id=194568
1722         <rdar://problem/47944490>
1723
1724         Reviewed by Ryosuke Niwa.
1725
1726         Add API test coverage.
1727
1728         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1729         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1730
1731 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1732
1733         webkitpy: Remove bug_dummy from parsed test expectations
1734         https://bugs.webkit.org/show_bug.cgi?id=194562
1735         <rdar://problem/47853999>
1736
1737         Reviewed by Lucas Forschler.
1738
1739         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1740         (TestExpectationParser):
1741         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1742         skipped tests.
1743         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1744
1745 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1746
1747         [ews-app] Add method to fetch patch
1748         https://bugs.webkit.org/show_bug.cgi?id=194518
1749
1750         Reviewed by Lucas Forschler.
1751
1752         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1753         (Patch.get_patch):
1754
1755 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1756
1757         [LFC] Expand tests coverage (60 new tests -> 860)
1758
1759         Unreviewed test gardening (run-singly, --child-processes=1).
1760
1761         * LayoutReloaded/misc/LFC-passing-tests.txt:
1762
1763 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1764
1765         Allow pages to trigger programmatic paste from script on iOS
1766         https://bugs.webkit.org/show_bug.cgi?id=194271
1767         <rdar://problem/47808810>
1768
1769         Reviewed by Tim Horton.
1770
1771         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1772
1773         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1774         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1775         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1776         (WTR::UIScriptController::rectForMenuAction const):
1777
1778         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1779         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1780         for when the menu is shown or hidden.
1781
1782         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1783         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1784         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1785         (WTR::UIScriptController::setDidShowMenuCallback):
1786         (WTR::UIScriptController::didShowMenuCallback const):
1787         (WTR::UIScriptController::setDidHideMenuCallback):
1788         (WTR::UIScriptController::didHideMenuCallback const):
1789         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1790         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1791         (WTR::UIScriptController::rectForMenuAction const):
1792         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1793         * WebKitTestRunner/TestController.cpp:
1794         (WTR::TestController::resetPreferencesToConsistentValues):
1795         (WTR::updateTestOptionsFromTestHeader):
1796         * WebKitTestRunner/TestOptions.h:
1797
1798         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1799         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1800
1801         (WTR::TestOptions::hasSameInitializationOptions const):
1802         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1803         (WTR::UIScriptController::calendarType const):
1804         (WTR::UIScriptController::platformUndoManager const):
1805         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1806         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1807         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1808         (-[TestRunnerWKWebView dealloc]):
1809         (-[TestRunnerWKWebView _didShowMenu]):
1810         (-[TestRunnerWKWebView _didHideMenu]):
1811
1812         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1813
1814         * WebKitTestRunner/ios/TestControllerIOS.mm:
1815         (WTR::handleMenuWillHideNotification):
1816         (WTR::handleMenuDidHideNotification):
1817         (WTR::TestController::platformInitialize):
1818         (WTR::TestController::platformDestroy):
1819         (WTR::TestController::platformResetStateToConsistentValues):
1820
1821         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1822         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1823
1824         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1825         (WTR::forEachViewInHierarchy):
1826         (WTR::findViewInHierarchyOfType):
1827
1828         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1829         functions that dig through a given view's hierarchy in search of a view of a given class.
1830
1831         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1832         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1833         (WTR::UIScriptController::selectionCaretViewRect const):
1834         (WTR::UIScriptController::selectionRangeViewRects const):
1835         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1836         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1837
1838         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1839
1840         (WTR::UIScriptController::rectForMenuAction const):
1841
1842         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1843         callout bar) whose label matches the given string.
1844
1845         (WTR::UIScriptController::platformContentView const):
1846
1847         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1848         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1849         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1850
1851         (WTR::UIScriptController::platformUndoManager const): Deleted.
1852         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1853         (WTR::UIScriptController::platformContentView const):
1854         (WTR::UIScriptController::platformUndoManager const): Deleted.
1855
1856 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1857
1858         webkitpy: No option to only show unexpected failures in results.html for iPad
1859         https://bugs.webkit.org/show_bug.cgi?id=194554
1860         <rdar://problem/47922442>
1861
1862         Rubber-stamped by Aakash Jain.
1863
1864         Just because a TestExpecations file does not exist for a specific platform does not mean that
1865         TestExpecations are not being used, given that platforms inherit test expectations.
1866
1867         * Scripts/webkitpy/port/base.py:
1868         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1869         * Scripts/webkitpy/port/base_unittest.py:
1870         (PortTest.test_uses_test_expectations_file):
1871
1872 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1873
1874         Remove setDefersLoading infrastructure from WebKit2
1875         https://bugs.webkit.org/show_bug.cgi?id=194506
1876
1877         Reviewed by Brady Eidson.
1878
1879         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1880         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1881         (WTR::TestRunner::setDefersLoading): Deleted.
1882         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1883
1884 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1885
1886         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1887         https://bugs.webkit.org/show_bug.cgi?id=194522
1888         <rdar://problem/47789393>
1889
1890         Reviewed by Chris Dumez.
1891
1892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1893         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1894         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1895         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1896
1897 2019-02-12  Andy Estes  <aestes@apple.com>
1898
1899         [iOSMac] Enable Parental Controls Content Filtering
1900         https://bugs.webkit.org/show_bug.cgi?id=194521
1901         <rdar://39732376>
1902
1903         Reviewed by Tim Horton.
1904
1905         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1906
1907 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1908
1909         [LFC][IFC] Add intrinsic width support for float boxes.
1910         https://bugs.webkit.org/show_bug.cgi?id=194528
1911
1912         Reviewed by Antti Koivisto.
1913
1914         Expand tests coverage (2 new tests -> 800).
1915         (This is the correct test ordering --runs-singly --child-processes=1)
1916
1917         * LayoutReloaded/misc/LFC-passing-tests.txt:
1918
1919 2019-02-12  Rob Buis  <rbuis@igalia.com>
1920
1921         Implement serializing in MIME type parser
1922         https://bugs.webkit.org/show_bug.cgi?id=193909
1923
1924         Reviewed by Darin Adler.
1925
1926         Add various tests involving upper case, non-ASCII, control/null characters,
1927         various HTTP whitespace, single quotes and an unpaired surrogate.
1928
1929         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1930         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1931         (TestWebKitAPI::serializeIfValid):
1932         (TestWebKitAPI::TEST):
1933
1934 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1935
1936         [Cocoa] Ask platform for generic font family mappings
1937         https://bugs.webkit.org/show_bug.cgi?id=187723
1938         <rdar://problem/41892438>
1939
1940         Reviewed by Brent Fulgham.
1941
1942         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1943
1944         * DumpRenderTree/mac/DumpRenderTree.mm:
1945         (allowedFontFamilySet):
1946         * WebKitTestRunner/mac/TestControllerMac.mm:
1947         (WTR::allowedFontFamilySet):
1948
1949 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1950
1951         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1952         https://bugs.webkit.org/show_bug.cgi?id=193622
1953
1954         Reviewed by Michael Catanzaro.
1955
1956         This adds support for loading content extension rule sets from the JSON files which
1957         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1958         of WKTR for this could be removed, but that is left for a follow-up patch with
1959         cleanups.
1960
1961         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1962         * WebKitTestRunner/TestController.cpp:
1963         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1964         avoid having the null-terminator copied into the result.
1965         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1966         part of the preparations to run a test.
1967         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1968         (WTR::contentExtensionStoreCallback): Added.
1969         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1970         used for content extensions test.
1971         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1972         extensions and compiling the JSON rule set for tests involving content extensions.
1973         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1974         testing and disables content extensions.
1975         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1976         resetContentExtensions().
1977         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1978         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1979         configureContentExtensionForTest(), and userContentController().
1980
1981 2019-02-11  Daniel Bates  <dabates@apple.com>
1982
1983         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1984         https://bugs.webkit.org/show_bug.cgi?id=191446
1985         <rdar://problem/45929460>
1986
1987         Reviewed by Tim Horton.
1988
1989         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1990
1991         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1992         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1993         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1994         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1995         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1996         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1997         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1998         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1999         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2000         (WTR::arrayLength):
2001         (WTR::parseModifierArray):
2002         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2003         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2004         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2005         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2006
2007 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2008
2009         Unreviewed, rolling out r241272 and r241276.
2010         https://bugs.webkit.org/show_bug.cgi?id=194514
2011
2012         Broke the Apple Internal build and the fix requires human
2013         intervention :( (Requested by dydz on #webkit).
2014
2015         Reverted changesets:
2016
2017         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2018         https://bugs.webkit.org/show_bug.cgi?id=191446
2019         https://trac.webkit.org/changeset/241272
2020
2021         "Fix internal iOS build after r241272"
2022         https://bugs.webkit.org/show_bug.cgi?id=191446
2023         https://trac.webkit.org/changeset/241276
2024
2025 2019-02-11  Truitt Savell  <tsavell@apple.com>
2026
2027         Unreviewed, rolling out r241269.
2028
2029         Caused 5 layout tests crashes on Mac WK1
2030
2031         Reverted changeset:
2032
2033         "DumpRenderTree should report unknown options"
2034         https://bugs.webkit.org/show_bug.cgi?id=191303
2035         https://trac.webkit.org/changeset/241269
2036
2037 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2038
2039         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2040         https://bugs.webkit.org/show_bug.cgi?id=194313
2041
2042         Reviewed by Tim Horton.
2043
2044         Add a helper to determine whether the web view is presenting modal UI.
2045
2046         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2047         (WTR::UIScriptController::isPresentingModally const):
2048         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2049         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2050         (WTR::UIScriptController::isPresentingModally const):
2051         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2052         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2053         (WTR::UIScriptController::calendarType const): Deleted.
2054         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2055         (WTR::UIScriptController::isPresentingModally const):
2056         (WTR::UIScriptController::calendarType const):
2057         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2058         (WTR::UIScriptController::calendarType const):
2059
2060 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2061
2062         GCHeapInspector: Show the retained sizes in more places
2063         https://bugs.webkit.org/show_bug.cgi?id=194464
2064
2065         Reviewed by Simon Fraser.
2066
2067         * GCHeapInspector/gc-heap-inspector.html:
2068         * GCHeapInspector/script/interface.js:
2069         (HeapInspectorUtils.humanReadableSize):
2070         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2071         (HeapInspectorUtils.spanForNode.span.span):
2072         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2073         (HeapSnapshotInspector.prototype.buildRoots):
2074
2075 2019-02-11  Daniel Bates  <dabates@apple.com>
2076
2077         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2078         https://bugs.webkit.org/show_bug.cgi?id=191446
2079         <rdar://problem/45929460>
2080
2081         Reviewed by Tim Horton.
2082
2083         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2084
2085         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2086         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2087         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2088         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2089         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2090         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2091         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2092         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2093         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2094         (WTR::arrayLength):
2095         (WTR::parseModifierArray):
2096         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2097         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2098         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2099         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2100
2101 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2102
2103         DumpRenderTree should report unknown options
2104         https://bugs.webkit.org/show_bug.cgi?id=191303
2105
2106         Reviewed by Frédéric Wang.
2107
2108         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2109         to report unknown options.
2110         Added and assigned test options which are currently used in tests.
2111
2112         * DumpRenderTree/TestOptions.cpp:
2113         (TestOptions::TestOptions):
2114
2115 2019-02-11  Truitt Savell  <tsavell@apple.com>
2116
2117         Unreviewed, rolling out r241229.
2118
2119         Revision broke internal builds for watchOS.
2120
2121         Reverted changeset:
2122
2123         "[Cocoa] Ask platform for generic font family mappings"
2124         https://bugs.webkit.org/show_bug.cgi?id=187723
2125         https://trac.webkit.org/changeset/241229
2126
2127 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2128
2129         [WinCairo][MiniBrowser] Basic authentication always fails.
2130         https://bugs.webkit.org/show_bug.cgi?id=194496
2131
2132         Reviewed by Don Olmstead.
2133
2134         * MiniBrowser/win/DialogHelper.h:
2135         (Dialog::getText):
2136
2137 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2138
2139         [GStreamer] GstMappedBuffer testsuite build fails
2140         https://bugs.webkit.org/show_bug.cgi?id=194495
2141
2142         Reviewed by Carlos Garcia Campos.
2143
2144         Fix the build by explicitely adding the gstreamer1.0-audio include
2145         directories to the include path.
2146
2147         * TestWebKitAPI/PlatformGTK.cmake:
2148         * TestWebKitAPI/PlatformWPE.cmake:
2149
2150 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2151
2152         [GTK][WPE] Add enable-javascript-markup setting
2153         https://bugs.webkit.org/show_bug.cgi?id=193439
2154
2155         Reviewed by Michael Catanzaro.
2156
2157         Add test cases to check the new setting.
2158
2159         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2160         (testWebKitSettings):
2161         (testWebKitSettingsJavaScriptMarkup):
2162         (beforeAll):
2163
2164 2019-02-10  Darin Adler  <darin@apple.com>
2165
2166         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2167         https://bugs.webkit.org/show_bug.cgi?id=194485
2168
2169         Reviewed by Daniel Bates.
2170
2171         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2172
2173 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2174
2175         Add more tests for clampTo<>()
2176         https://bugs.webkit.org/show_bug.cgi?id=194462
2177
2178         Reviewed by Geoffrey Garen.
2179
2180         Darin suggested to test the very last floating point number
2181         at the boundaries when truncating to integer.
2182         I added test for max/min and max-1/min-1.
2183
2184         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2185         (TestWebKitAPI::TEST):
2186
2187 2019-02-09  Darin Adler  <darin@apple.com>
2188
2189         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2190         https://bugs.webkit.org/show_bug.cgi?id=194021
2191
2192         Reviewed by Geoffrey Garen.
2193
2194         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2195         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2196         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2197
2198 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2199
2200         [LFC][IFC] Add intrinsic width support for basic inline containers
2201         https://bugs.webkit.org/show_bug.cgi?id=194473
2202
2203         Reviewed by Antti Koivisto.
2204
2205         Expand tests coverage (11 new tests -> 798)
2206
2207         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2208
2209 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2210
2211         Fix MiniBrowser's entitlements
2212         https://bugs.webkit.org/show_bug.cgi?id=192431
2213
2214         Reviewed by Joseph Pecoraro.
2215
2216         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2217         files, making it impossible to load any extension.
2218
2219         * MiniBrowser/MiniBrowser.entitlements:
2220
2221 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2222
2223         [Cocoa] Ask platform for generic font family mappings
2224         https://bugs.webkit.org/show_bug.cgi?id=187723
2225         <rdar://problem/41892438>
2226
2227         Reviewed by Brent Fulgham.
2228
2229         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2230
2231         * DumpRenderTree/mac/DumpRenderTree.mm:
2232         (allowedFontFamilySet):
2233         * WebKitTestRunner/mac/TestControllerMac.mm:
2234         (WTR::allowedFontFamilySet):
2235
2236 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2237
2238         [GTK] Implement back/forward touchpad gesture
2239         https://bugs.webkit.org/show_bug.cgi?id=193919
2240
2241         Reviewed by Michael Catanzaro.
2242
2243         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2244         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2245
2246 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2247
2248         Add SPI to use networking daemon instead of XPC service
2249         https://bugs.webkit.org/show_bug.cgi?id=194427
2250
2251         Reviewed by Geoffrey Garen
2252
2253         * MiniBrowser/MiniBrowser.entitlements:
2254
2255 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2256
2257         [ews-build] Ensure that every builder in config.json has short name
2258         https://bugs.webkit.org/show_bug.cgi?id=194461
2259
2260         Reviewed by Lucas Forschler.
2261
2262         * BuildSlaveSupport/ews-build/loadConfig.py:
2263         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2264
2265 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2266
2267         [ews-build] Add short name to config.json
2268         https://bugs.webkit.org/show_bug.cgi?id=194456
2269
2270         Reviewed by Lucas Forschler.
2271
2272         * BuildSlaveSupport/ews-build/config.json: Added short name.
2273         * BuildSlaveSupport/ews-build/loadConfig.py:
2274         (loadBuilderConfig): Set the short name as the builder description.
2275
2276 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2277
2278         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2279         https://bugs.webkit.org/show_bug.cgi?id=194418
2280
2281         Reviewed by Lucas Forschler.
2282
2283         Do not include errors trying when finding crashlogs at the end of
2284         a run-webkit-tests run since we don't process those errors.
2285
2286         * Scripts/webkitpy/port/darwin.py:
2287         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2288         * Scripts/webkitpy/port/ios_device.py:
2289         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2290         * Scripts/webkitpy/port/watch_device.py:
2291         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2292
2293 2019-02-08  Beth Dakin  <bdakin@apple.com>
2294
2295         Add afterScreenUpdates to WKSnapshotConfiguration
2296         https://bugs.webkit.org/show_bug.cgi?id=194362
2297         -and corresponding-
2298         <rdar://problem/40655528> Please add an "after screen updates" property to 
2299         WKSnapshotConfiguration (to solve blank snapshots)
2300
2301         Reviewed by Tim Horton.
2302
2303         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2304         (TEST):
2305
2306 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2307
2308         clampTo(): do not convert the input to double when dealing with integers
2309         https://bugs.webkit.org/show_bug.cgi?id=194263
2310         <rdar://problem/47692312>
2311
2312         Reviewed by Darin Adler.
2313
2314         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2315         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2316         (TestWebKitAPI::testClampFloatingPointToInteger):
2317         (TestWebKitAPI::testClampSameSignIntegers):
2318         (TestWebKitAPI::testClampUnsignedToSigned):
2319         (TestWebKitAPI::testClampSignedToUnsigned):
2320
2321 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2322
2323         webkitpy: Respect --dedicated-simulators flag
2324         https://bugs.webkit.org/show_bug.cgi?id=194416
2325         <rdar://problem/47894722>
2326
2327         Reviewed by Lucas Forschler.
2328
2329         * Scripts/webkitpy/port/device_port.py:
2330         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2331         available devices can be safely ignored.
2332
2333 2019-02-07  Keith Rollin  <krollin@apple.com>
2334
2335         Remove extra copy of 100x100-red.tga
2336         https://bugs.webkit.org/show_bug.cgi?id=194371
2337         <rdar://problem/47873465>
2338
2339         Reviewed by Said Abou-Hallawa.
2340
2341         In order to help it pass its tests, Bug 194190 added a second copy of
2342         the file 100x100-red.tga. However, it turns out that this additional
2343         file wasn't actually needed, and that that sole previous copy was
2344         sufficient. At the same time, this second copy -- which was copied to
2345         the same location in the build output as the first copy -- now caused
2346         XCBuild to complain because there were two production rules for the
2347         same output file. Address this by removing the newly-added extra copy.
2348
2349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2350         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2351
2352 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2353
2354         Deprecate WKBundlePageSetDefersLoading
2355         https://bugs.webkit.org/show_bug.cgi?id=191394
2356
2357         Reviewed by Dean Jackson.
2358
2359         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2360         (WTR::TestRunner::setDefersLoading):
2361
2362 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2363
2364         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2365         https://bugs.webkit.org/show_bug.cgi?id=194391
2366
2367         Reviewed by Antti Koivisto.
2368
2369         * LayoutReloaded/misc/LFC-passing-tests.txt:
2370
2371 2019-02-06  Keith Rollin  <krollin@apple.com>
2372
2373         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2374         https://bugs.webkit.org/show_bug.cgi?id=193975
2375         <rdar://problem/47643306>
2376
2377         Reviewed by Tim Horton.
2378
2379         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2380         the Info.plist file into the bundle. This step is not necessary as the
2381         implicit "bundle up all the build products into a framework" build
2382         phase does this already. Having the Copy Bundle Resources phase do
2383         this causes a conflict under XCBuild, which objects to two build
2384         phases producing the same file (Info.plist). Address this by removing
2385         Info.plist from the Copy Bundle Resources phase.
2386
2387         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2388
2389 2019-02-06  Keith Rollin  <krollin@apple.com>
2390
2391         Really enable the automatic checking and regenerations of .xcfilelists during builds
2392         https://bugs.webkit.org/show_bug.cgi?id=194357
2393         <rdar://problem/47861231>
2394
2395         Reviewed by Chris Dumez.
2396
2397         Bug 194124 was supposed to enable the automatic checking and
2398         regenerating of .xcfilelist files during the build. While related
2399         changes were included in that patch, the change to actually enable the
2400         operation somehow was omitted. This patch actually enables the
2401         operation. The check-xcfilelist.sh scripts now check
2402         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2403         from the checking.
2404
2405         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2406         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2407
2408 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2409
2410         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2411         <https://webkit.org/b/194286>
2412         <rdar://problem/47815558>
2413
2414         Reviewed by Alexey Proskuryakov.
2415
2416         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2417         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2418         WKRetainPtr<> to avoid leaking the WKDataRef.
2419
2420 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2421
2422         Unreviewed, fix a typo
2423
2424         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2425
2426 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2427
2428         [GTK][WPE] force libpsl build to use ICU in jhbuild
2429         https://bugs.webkit.org/show_bug.cgi?id=194288
2430
2431         Reviewed by Carlos Garcia Campos.
2432
2433         * gtk/jhbuild.modules:
2434         Require ICU for libpsl build in jhbuild, like done in WPE.
2435
2436 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2437
2438         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2439         https://bugs.webkit.org/show_bug.cgi?id=194209
2440
2441         Reviewed by Carlos Garcia Campos.
2442
2443         Enhance TestCookieManager to ensure this doesn't happen again.
2444
2445         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2446         (testCookieManagerPersistentStorage):
2447         (beforeAll):
2448
2449 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2450
2451         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2452         https://bugs.webkit.org/show_bug.cgi?id=194324
2453
2454         Reviewed by Andy Estes.
2455
2456         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2457         part of the name is already implicit, since this is in testing code in TestOptions.
2458
2459         * WebKitTestRunner/TestController.cpp:
2460         (WTR::TestController::generateContextConfiguration const):
2461         (WTR::updateTestOptionsFromTestHeader):
2462         * WebKitTestRunner/TestOptions.h:
2463         (WTR::TestOptions::hasSameInitializationOptions const):
2464
2465 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2466
2467         [ews-build] Allow * as platform for builders and workers
2468         https://bugs.webkit.org/show_bug.cgi?id=188533
2469
2470         Reviewed by Lucas Forschler.
2471
2472         * BuildSlaveSupport/ews-build/loadConfig.py:
2473         (checkWorkersAndBuildersForConsistency):
2474
2475 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2476
2477         [ews-build] Add few bots to config.json
2478         https://bugs.webkit.org/show_bug.cgi?id=194304
2479
2480         Reviewed by Lucas Forschler.
2481
2482         * BuildSlaveSupport/ews-build/config.json:
2483
2484 2019-02-05  Keith Rollin  <krollin@apple.com>
2485
2486         Enable the automatic checking and regenerations of .xcfilelists during builds
2487         https://bugs.webkit.org/show_bug.cgi?id=194124
2488         <rdar://problem/47721277>
2489
2490         Reviewed by Tim Horton.
2491
2492         Bug 193790 add a facility for checking -- during build time -- that
2493         any needed .xcfilelist files are up-to-date and for updating them if
2494         they are not. This facility was initially opt-in by setting
2495         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2496         the process seemed robust. Its now time to enable this facility and
2497         make it opt-out. If there is a need to disable this facility, set and
2498         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2499         running `make` or `build-webkit`, or before running Xcode from the
2500         command line.
2501
2502         Additionally, remove the step that generates a list of source files
2503         going into the UnifiedSources build step. It's only necessarily to
2504         specify Sources.txt and SourcesCocoa.txt as inputs.
2505
2506         * Scripts/generate-xcfilelists:
2507
2508 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2509
2510         [GTK][WPE] force libpsl build to use ICU in jhbuild
2511         https://bugs.webkit.org/show_bug.cgi?id=194288
2512
2513         Reviewed by Philippe Normand.
2514
2515         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2516         This can cause build failures if libidn is detected but libunistring is not available.
2517
2518         Make sure that ICU is used for runtime and builtin PSL data.
2519
2520         * gtk/jhbuild.modules:
2521         * wpe/jhbuild.modules:
2522
2523 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2524
2525         [ews-app] Modified timestamp should be updated on updating data
2526         https://bugs.webkit.org/show_bug.cgi?id=194295
2527
2528         Reviewed by Lucas Forschler.
2529
2530         * BuildSlaveSupport/ews-app/ews/models/build.py:
2531         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2532         * BuildSlaveSupport/ews-app/ews/models/step.py:
2533
2534 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2535
2536         Unreviewed, rolling out r240742.
2537
2538         Causes crashes on iOS simulator.
2539
2540         Reverted changeset:
2541
2542         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2543         not focused in a content-editable element"
2544         https://bugs.webkit.org/show_bug.cgi?id=192824
2545         https://trac.webkit.org/changeset/240742
2546
2547 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2548
2549         run-webkit-tests emits message "...running None" when running tests
2550         https://bugs.webkit.org/show_bug.cgi?id=194133
2551         <rdar://problem/47724738>
2552
2553         Reviewed by Lucas Forschler.
2554
2555         * Scripts/webkitpy/xcode/device_type.py:
2556         (DeviceType.__str__): Use both version mapping tables and use just the variant
2557         name if no version name is available.
2558         * Scripts/webkitpy/xcode/device_type_unittest.py:
2559         (DeviceTypeTest):
2560         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2561         an associated named.
2562
2563 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2564
2565         [WPE] require python3-setuptools for meson build in jhbuild
2566         https://bugs.webkit.org/show_bug.cgi?id=194287
2567
2568         Reviewed by Philippe Normand.
2569
2570         python3-setuptools is needed to build meson in jhbuild.
2571         It is already required by the GTK port.
2572
2573         * wpe/install-dependencies:
2574
2575 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2576
2577         [ews-app] Add method to save BuilderMapping to database
2578         https://bugs.webkit.org/show_bug.cgi?id=194264
2579
2580         Reviewed by Lucas Forschler.
2581
2582         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2583         (BuilderMapping.__str__):
2584         (BuilderMapping):
2585         (BuilderMapping.save_mapping):
2586         (BuilderMapping.update_mapping):
2587         (BuilderMapping.get_existing_mapping):
2588         (BuilderMapping.is_valid_mapping):
2589
2590 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2591
2592         [ews-app] Add timestamp fields for BuilderMappings
2593         https://bugs.webkit.org/show_bug.cgi?id=194266
2594
2595         Reviewed by Lucas Forschler.
2596
2597         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2598         (BuilderMapping):
2599
2600 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2601
2602         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2603         https://bugs.webkit.org/show_bug.cgi?id=174816
2604
2605         Reviewed by Michael Catanzaro.
2606
2607         Add tests for webkit_uri_for_display().
2608
2609         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2610         (testURIForDisplayUnaffected):
2611         (testURIForDisplayAffected):
2612         (beforeAll):
2613         (afterAll):
2614         * TestWebKitAPI/glib/CMakeLists.txt:
2615
2616 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2617
2618         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2619         https://bugs.webkit.org/show_bug.cgi?id=194158
2620         <rdar://problem/47737268>
2621
2622         Rubber-stamped by Aakash Jain.
2623
2624         * Scripts/webkitpy/port/device_port.py:
2625         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2626
2627 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2628
2629         [CG] Enable setAdditionalSupportedImageTypes for WK1
2630         https://bugs.webkit.org/show_bug.cgi?id=194190
2631
2632         Reviewed by Tim Horton.
2633
2634         Add a test similar to the one under WebKit Cocoa but make it create a
2635         WebView instead of a WKWebView.
2636
2637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2638         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2639         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2640         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2641         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2642         (TestWebKitAPI::runTest):
2643         (TestWebKitAPI::TEST):
2644
2645 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2646
2647         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2648         https://bugs.webkit.org/show_bug.cgi?id=194168
2649
2650         Reviewed by Simon Fraser.
2651
2652         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2653
2654         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2655         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2656         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2657         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2658         (TEST):
2659         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2660         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2661
2662 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2663
2664         REGRESSION (r237269): webkit-patch what-broke is broken 
2665         https://bugs.webkit.org/show_bug.cgi?id=193025
2666
2667         Reviewed by Aakash Jain.
2668
2669         * Scripts/webkitpy/common/host.py:
2670         (Host.buildbot):
2671         (Host.bugzilla): Renamed to 'buildbot'.
2672
2673 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2674
2675         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2676         https://bugs.webkit.org/show_bug.cgi?id=194207
2677
2678         Reviewed by Tim Horton.
2679
2680         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2681         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2682         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2683         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2684         start and delete forwards to remove the original attachment.
2685
2686         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2687         (TestWebKitAPI::TEST):
2688
2689 2019-02-04  Youenn Fablet  <youenn@apple.com>
2690
2691         Capture state should be managed consistently when doing process swapping
2692         https://bugs.webkit.org/show_bug.cgi?id=194122
2693         <rdar://problem/47609293>
2694
2695         Reviewed by Eric Carlson.
2696
2697         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2698         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2699         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2700         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2701         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2702         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2703         (WTR::TestRunner::isDoingMediaCapture const):
2704         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2705         * WebKitTestRunner/TestController.cpp:
2706         (WTR::TestController::isDoingMediaCapture const):
2707         * WebKitTestRunner/TestController.h:
2708         * WebKitTestRunner/TestInvocation.cpp:
2709         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2710         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2711         (WTR::TestController::isDoingMediaCapture const):
2712
2713 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2714
2715         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2716         https://bugs.webkit.org/show_bug.cgi?id=194142
2717
2718         Reviewed by Ross Kirsling.
2719
2720         There three 'separator' variables in TestController.cpp. Renamed
2721         it 'pathSeparator', and unified them.
2722
2723         * WebKitTestRunner/TestController.cpp:
2724         (WTR::TestController::generateContextConfiguration const):
2725         (WTR::createTestURL):
2726         (WTR::TestController::platformAdjustContext):
2727
2728 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2729
2730         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2731         https://bugs.webkit.org/show_bug.cgi?id=194198
2732
2733         Reviewed by Antti Koivisto.
2734
2735         No need to set the banner heights on navigation now, since Page stores them.
2736
2737         * MiniBrowser/mac/WK2BrowserWindowController.m:
2738         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2739
2740 2019-02-03  John Wilander  <wilander@apple.com>
2741
2742         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2743         https://bugs.webkit.org/show_bug.cgi?id=194104
2744         <rdar://problem/47649991>
2745
2746         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2747
2748         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2749         (TestWebKitAPI::TEST):
2750             Changed numeric types from unsigned short to uint32_t.
2751
2752 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2753
2754         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2755         <https://webkit.org/b/194178>
2756         <rdar://problem/47753473>
2757
2758         Reviewed by Alexey Proskuryakov.
2759
2760         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2761         (WTR::uninstallFakeHelvetica): Pass nullptr into
2762         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2763
2764 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2765
2766         [LFC] Initialize ICB's style with fixed width/height.
2767         https://bugs.webkit.org/show_bug.cgi?id=194188
2768
2769         Reviewed by Antti Koivisto.
2770
2771         * LayoutReloaded/misc/LFC-passing-tests.txt:
2772
2773 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2774
2775         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2776         https://bugs.webkit.org/show_bug.cgi?id=194185
2777
2778         Reviewed by Antti Koivisto.
2779
2780         * LayoutReloaded/misc/LFC-passing-tests.txt:
2781
2782 2018-12-16  Darin Adler  <darin@apple.com>
2783
2784         Convert additional String::format clients to alternative approaches
2785         https://bugs.webkit.org/show_bug.cgi?id=192746
2786
2787         Reviewed by Alexey Proskuryakov.
2788
2789         * WebKitTestRunner/TestController.cpp:
2790         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2791         as an intermediate in code that ultimately constructs a WTF::String.
2792         (WTR::userMediaOriginHash): Use makeString.
2793         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2794         (WTR::TestController::didPerformClientRedirect): Ditto.
2795         (WTR::TestController::didPerformServerRedirect): Ditto.
2796         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2797
2798 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2799
2800         [ews-build] Add unit test to verify builder keys
2801         https://bugs.webkit.org/show_bug.cgi?id=194152
2802
2803         Reviewed by Lucas Forschler.
2804
2805         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2806         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2807
2808 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2809
2810         [LFC] Expand tests coverage (12 new tests -> 787)
2811
2812         Unreviewed test gardening.
2813
2814         * LayoutReloaded/misc/LFC-passing-tests.txt:
2815
2816 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2817
2818         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2819         https://bugs.webkit.org/show_bug.cgi?id=194163
2820
2821         Reviewed by Simon Fraser.
2822
2823         775
2824
2825         * LayoutReloaded/misc/LFC-passing-tests.txt:
2826
2827 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2828
2829         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2830         https://bugs.webkit.org/show_bug.cgi?id=194140
2831         <rdar://problem/47728098>
2832
2833         Reviewed by Tim Horton.
2834
2835         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2836         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2837         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2838
2839         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2840         test to induce an IPC deadlock when presenting a modal alert during touch start.
2841
2842         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2843         * WebKitTestRunner/TestController.cpp:
2844         (WTR::runJavaScriptAlert):
2845
2846         Add a client callback function for running JavaScript alerts.
2847
2848         (WTR::TestController::createOtherPage):
2849         (WTR::TestController::generateContextConfiguration const):
2850
2851         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2852         the fix in this patch.
2853
2854         (WTR::TestController::createWebViewWithOptions):
2855
2856         Plumb TestOptions to generateContextConfiguration.
2857
2858         (WTR::TestController::resetPreferencesToConsistentValues):
2859         (WTR::TestController::resetStateToConsistentValues):
2860         (WTR::updateTestOptionsFromTestHeader):
2861         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2862         (WTR::TestController::handleJavaScriptAlert):
2863         * WebKitTestRunner/TestController.h:
2864         * WebKitTestRunner/TestInvocation.cpp:
2865         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2866         * WebKitTestRunner/TestOptions.h:
2867         (WTR::TestOptions::hasSameInitializationOptions const):
2868
2869 2019-02-01  Chris Dumez  <cdumez@apple.com>
2870
2871         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2872         https://bugs.webkit.org/show_bug.cgi?id=193740
2873         <rdar://problem/47527267>
2874
2875         Reviewed by Alex Christensen.
2876
2877         Add API test coverage.
2878
2879         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2880
2881 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2882
2883         [ews-app] Add display name field to BuilderMapping model
2884         https://bugs.webkit.org/show_bug.cgi?id=194153
2885
2886         Reviewed by Lucas Forschler.
2887
2888         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2889         (BuilderMapping):
2890
2891 2019-02-01  Youenn Fablet  <youenn@apple.com>
2892
2893         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2894         https://bugs.webkit.org/show_bug.cgi?id=194155
2895
2896         Reviewed by Eric Carlson.
2897
2898         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2899         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2900         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2901
2902 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2903
2904         [LFC] Adjust replaced element's intrinsic ratio
2905         https://bugs.webkit.org/show_bug.cgi?id=194154
2906
2907         Reviewed by Antti Koivisto.
2908
2909         761
2910
2911         * LayoutReloaded/misc/LFC-passing-tests.txt:
2912
2913 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2914
2915         [WPE] Show test results in minibrowser
2916         https://bugs.webkit.org/show_bug.cgi?id=194150
2917
2918         Reviewed by Žan Doberšek.
2919
2920         * Scripts/webkitpy/port/wpe.py:
2921         (WPEPort.show_results_html_file):
2922
2923 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2924
2925         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2926         https://bugs.webkit.org/show_bug.cgi?id=194151
2927
2928         Reviewed by Žan Doberšek.
2929
2930         ALT + <- go back
2931         ALT + -> go forward
2932
2933         * MiniBrowser/wpe/main.cpp:
2934         (main):
2935
2936 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2937
2938         [LFC] Set intrinsic size on Layout::Replaced
2939         https://bugs.webkit.org/show_bug.cgi?id=194139
2940
2941         Reviewed by Antti Koivisto.
2942
2943         744
2944
2945         * LayoutReloaded/misc/LFC-passing-tests.txt:
2946
2947 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2948
2949         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2950         https://bugs.webkit.org/show_bug.cgi?id=194146
2951
2952         Reviewed by Xabier Rodriguez-Calvar.
2953
2954         It allows to open relative paths.
2955
2956         * MiniBrowser/wpe/main.cpp:
2957         (main):
2958
2959 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2960
2961         Update flakiness dashboard configuration after recent queue changes
2962         https://bugs.webkit.org/show_bug.cgi?id=194127
2963
2964         Rubber-stamped by Aakash Jain.
2965
2966         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2967
2968         * TestResultServer/static-dashboards/builders.jsonp:
2969
2970 2019-01-31  Youenn Fablet  <youenn@apple.com>
2971
2972         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2973         https://bugs.webkit.org/show_bug.cgi?id=194106
2974         <rdar://problem/47676333>
2975
2976         Reviewed by Ryosuke Niwa.
2977
2978         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2979         (TestWebKitAPI::didFinishNavigation):
2980         (TestWebKitAPI::TEST):
2981         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2982
2983 2019-01-31  Chris Dumez  <cdumez@apple.com>
2984
2985         Page zoom level is lost after a process swap or a crash
2986         https://bugs.webkit.org/show_bug.cgi?id=194105
2987         <rdar://problem/47610781>
2988
2989         Reviewed by Alex Christensen.
2990
2991         Add API test coverage.
2992
2993         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2994         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2995
2996 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2997
2998         Revert r238819 which is unneeded and caused a performance regression.
2999         https://bugs.webkit.org/show_bug.cgi?id=192272
3000         <rdar://problem/46664625>
3001
3002         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3003         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3004         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3005
3006 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3007
3008         Formalize WebKitAdditions mechanism of LoadOptimizer
3009         https://bugs.webkit.org/show_bug.cgi?id=193886
3010         <rdar://problem/47696809>
3011
3012         Reviewed by Brent Fulgham.
3013
3014         * MiniBrowser/MiniBrowser.entitlements:
3015         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3016
3017 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3018
3019         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3020         https://bugs.webkit.org/show_bug.cgi?id=194090
3021
3022         Reviewed by Antti Koivisto.
3023
3024         * LayoutReloaded/misc/LFC-passing-tests.txt:
3025
3026 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3027
3028         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3029         https://bugs.webkit.org/show_bug.cgi?id=194074
3030
3031         Reviewed by Antti Koivisto.
3032
3033         * LayoutReloaded/misc/LFC-passing-tests.txt:
3034
3035 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3036
3037         [LFC][BFC] Add support for block level replaced box.
3038         https://bugs.webkit.org/show_bug.cgi?id=194071
3039
3040         Reviewed by Antti Koivisto.
3041
3042         * LayoutReloaded/misc/LFC-passing-tests.txt:
3043
3044 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3045
3046         Fix WebKitTestRunner's testPath with Windows full paths
3047         https://bugs.webkit.org/show_bug.cgi?id=194012
3048
3049         Reviewed by Alex Christensen.
3050
3051         updateTestOptionsFromTestHeader failed to open test files because
3052         testPath returned wrong file paths. It returned a path "/C:/..."
3053         if a URL "file:///C:/..." was given.
3054
3055         * WebKitTestRunner/TestController.cpp:
3056         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3057
3058 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3059
3060         [WPE] Bump font related dependencies to match the GTK+ port
3061         https://bugs.webkit.org/show_bug.cgi?id=194017
3062
3063         Reviewed by Žan Doberšek.
3064
3065         * wpe/jhbuild.modules:
3066         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3067         * wpe/patches/icudata-stdlibs.patch: Added.
3068
3069 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3070
3071         Enable swipe tests on iOS
3072         https://bugs.webkit.org/show_bug.cgi?id=194076
3073
3074         Reviewed by Geoffrey Garen.
3075
3076         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3077         it causes a debug assertion failure in runUIScript.
3078
3079         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3080         (WTR::UIScriptController::beginBackSwipe):
3081         (WTR::UIScriptController::completeBackSwipe):
3082
3083 2019-01-30  Keith Rollin  <krollin@apple.com>
3084
3085         Use correct printf format specifier
3086         https://bugs.webkit.org/show_bug.cgi?id=194062
3087         <rdar://problem/47686167>
3088
3089         Reviewed by Alexey Proskuryakov.
3090
3091         LayoutTestSpellChecker.mm is trying to format a variable of type
3092         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3093         actually an unsigned long long. Fix this by formatting with %llu.
3094
3095         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3096         (-[LayoutTestTextCheckingResult description]):
3097
3098 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3099
3100         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3101         https://bugs.webkit.org/show_bug.cgi?id=193979
3102
3103         Reviewed by Wenson Hsieh.
3104
3105         Fix the test for iOS. Make the test work with iOS UA string.
3106
3107         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3108
3109 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3110
3111         Replace High Sierra LLINT CLoop bot due to hardware failure
3112         https://bugs.webkit.org/show_bug.cgi?id=194066
3113
3114         Reviewed by Aakash Jain.
3115
3116         * BuildSlaveSupport/build.webkit.org-config/config.json:
3117
3118 2019-01-30  Keith Rollin  <krollin@apple.com>
3119
3120         [NSDragItem init] is unavailable
3121         https://bugs.webkit.org/show_bug.cgi?id=194059
3122         <rdar://problem/47685715>
3123
3124         Reviewed by Wenson Hsieh.
3125
3126         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3127         DumpRenderTree and TestWebKitAPI, which both try to create an
3128         NSDragItem in a manner that invokes this method. Address this by using
3129         -initWithPasteboardWriter instead.
3130
3131         Note that the parameter passed to initWithPasteboardWriter is likely
3132         incorrect. In both cases, the object passed does not conform to
3133         NSPasteboardWriting. However, with this fix, we're no worse off than
3134         before, and can now perform builds with newer compilers and SDKs until
3135         a real fix can be crafted. That work is tracked in
3136         https://bugs.webkit.org/show_bug.cgi?id=194060
3137
3138         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3139         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3140         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3141         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3142
3143 2019-01-30  Daniel Bates  <dabates@apple.com>
3144
3145         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3146         https://bugs.webkit.org/show_bug.cgi?id=192824
3147         <rdar://problem/47100332>
3148
3149         Reviewed by Wenson Hsieh.
3150
3151         Fix a bug where the wrong usage code was used for F13 thru F24.
3152
3153         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3154         (keyCodeForDOMFunctionKey):
3155
3156 2019-01-30  Chris Dumez  <cdumez@apple.com>
3157
3158         Regression(PSON) Load hang can occur on history navigation
3159         https://bugs.webkit.org/show_bug.cgi?id=194030
3160         <rdar://problem/47656939>
3161
3162         Reviewed by Antti Koivisto.
3163
3164         Add API test coverage.
3165
3166         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3167
3168 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3169
3170         [LFC] Expand tests coverage.
3171
3172         Unreviewed test gardening.
3173
3174         * LayoutReloaded/misc/LFC-passing-tests.txt:
3175
3176 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3177
3178         [Flatpak] Add openjpeg support
3179         https://bugs.webkit.org/show_bug.cgi?id=194019
3180
3181         Reviewed by Michael Catanzaro.
3182
3183         * flatpak/org.webkit.CommonModules.yaml:
3184
3185 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3186
3187         Unreviewed, rolling out r240708.
3188         https://bugs.webkit.org/show_bug.cgi?id=194022
3189
3190         It broke WPE build (Requested by KaL on #webkit).
3191
3192         Reverted changeset:
3193
3194         "[WPE] Bump font related dependencies to match the GTK+ port"
3195         https://bugs.webkit.org/show_bug.cgi?id=194017
3196         https://trac.webkit.org/changeset/240708
3197
3198 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3199
3200         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3201         https://bugs.webkit.org/show_bug.cgi?id=194001
3202
3203         Reviewed by Antti Koivisto.
3204
3205         * LayoutReloaded/misc/LFC-passing-tests.txt:
3206
3207 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3208
3209         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3210         https://bugs.webkit.org/show_bug.cgi?id=194020
3211
3212         Reviewed by Antti Koivisto.
3213
3214         * LayoutReloaded/misc/LFC-passing-tests.txt:
3215
3216 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3217
3218         AX: Support color well on iOS
3219         https://bugs.webkit.org/show_bug.cgi?id=194010
3220
3221         Reviewed by Joanmarie Diggs.
3222
3223         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3224         (WTR::AccessibilityUIElement::stringAttributeValue):
3225
3226 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3227
3228         [WPE] Bump font related dependencies to match the GTK+ port
3229         https://bugs.webkit.org/show_bug.cgi?id=194017
3230
3231         Reviewed by Žan Doberšek.
3232
3233         * wpe/jhbuild.modules:
3234         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3235         * wpe/patches/icudata-stdlibs.patch: Added.
3236
3237 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3238
3239         [Mac] Update window scale API usage
3240         https://bugs.webkit.org/show_bug.cgi?id=193991
3241         rdar://problem/47614795
3242
3243         Reviewed by Tim Horton.
3244
3245         * DumpRenderTree/mac/DumpRenderTree.mm:
3246         (changeWindowScaleIfNeeded):
3247         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3248         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3249         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3250
3251 2019-01-29  Chris Dumez  <cdumez@apple.com>
3252
3253         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3254         https://bugs.webkit.org/show_bug.cgi?id=193977
3255         <rdar://problem/47643716>
3256
3257         Reviewed by Geoff Garen.
3258
3259         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3260         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3261         to the previous provisional committing *before* we make the last load. 
3262
3263         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3264
3265 2019-01-29  Youenn Fablet  <youenn@apple.com>
3266
3267         Adopt new SPI to evaluate server certificate trust
3268         https://bugs.webkit.org/show_bug.cgi?id=193355
3269
3270         Reviewed by Alex Christensen.
3271
3272         Add infrastructure to handle HTTPS server trust evaluation testing.
3273
3274         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3275         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3276         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3277         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3278         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3279         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3280         * WebKitTestRunner/TestController.cpp:
3281         (WTR::TestController::resetPreferencesToConsistentValues):
3282         (WTR::TestController::didReceiveAuthenticationChallenge):
3283         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3284         * WebKitTestRunner/TestController.h:
3285         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3286         * WebKitTestRunner/TestInvocation.cpp:
3287         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3288         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3289         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3290
3291 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3292
3293         [ews-build] Add build step to print bot Configuration
3294         https://bugs.webkit.org/show_bug.cgi?id=193887
3295
3296         Reviewed by Lucas Forschler.
3297
3298         * BuildSlaveSupport/ews-build/steps.py:
3299         (PrintConfiguration): Build step to print configuration.
3300         * BuildSlaveSupport/ews-build/factories.py:
3301
3302 2019-01-29  Chris Dumez  <cdumez@apple.com>
3303
3304         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3305         https://bugs.webkit.org/show_bug.cgi?id=193967
3306         <rdar://problem/47635348>
3307
3308         Reviewed by Alex Christensen.
3309
3310         Add API test coverage.
3311
3312         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3313         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3314
3315 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3316
3317         [ews-app] Handle incoming results data
3318         https://bugs.webkit.org/show_bug.cgi?id=193973
3319
3320         Reviewed by Lucas Forschler.
3321
3322         * BuildSlaveSupport/ews-app/ews/views/results.py:
3323
3324 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3325
3326         [ews-app] Make the results url generic
3327         https://bugs.webkit.org/show_bug.cgi?id=193928
3328
3329         Reviewed by Lucas Forschler.
3330
3331         * BuildSlaveSupport/ews-app/ews/urls.py:
3332
3333 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3334
3335         [ews-build] Configure buildbot to send events to ews-app
3336         https://bugs.webkit.org/show_bug.cgi?id=193968
3337
3338         Reviewed by Lucas Forschler.
3339
3340         * BuildSlaveSupport/ews-build/events.py: Added.
3341         * BuildSlaveSupport/ews-build/master.cfg:
3342
3343 2019-01-29  Keith Rollin  <krollin@apple.com>
3344
3345         Add .xcfilelists to Run Script build phases
3346         https://bugs.webkit.org/show_bug.cgi?id=193792
3347         <rdar://problem/47201785>
3348
3349         Reviewed by Alex Christensen.
3350
3351         As part of supporting XCBuild, update the necessary Run Script build
3352         phases in their Xcode projects to refer to their associated
3353         .xcfilelist files.
3354
3355         Note that the addition of these files bumps the Xcode project version
3356         number to something that's Xcode 10 compatible. This change means that
3357         older versions of the Xcode IDE can't read these projects. Nor can it
3358         fully load workspaces that refer to these projects (the updated
3359         projects are shown as non-expandable placeholders). `xcodebuild` can
3360         still build these projects; it's just that the IDE can't open them.
3361
3362         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3363         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3364
3365 2019-01-29  John Wilander  <wilander@apple.com>
3366
3367         Add data abstraction and validation for Ad Click Attribution
3368         https://bugs.webkit.org/show_bug.cgi?id=193916
3369         <rdar://problem/47603481>
3370
3371         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3372
3373         Ad click attribution has two steps. First, the storage of an ad
3374         campaign ID for a click that takes the user to a destination
3375         site. Second, a conversion on the destination site that can be
3376         attributed to the ad click.
3377
3378         This patch adds a class that represents a request for ad click
3379         attribution. Validation makes sure that the bits of entropy
3380         reported through this mechanism is limited.
3381
3382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3383         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3384         (TestWebKitAPI::TEST):
3385
3386 2019-01-29  Chris Dumez  <cdumez@apple.com>
3387
3388         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3389         https://bugs.webkit.org/show_bug.cgi?id=193932
3390         <rdar://problem/47598947>
3391
3392         Reviewed by Brady Eidson.
3393
3394         Add API test coverage.
3395
3396         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3397
3398 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3399
3400         Adding new passing LFC tests.
3401
3402         Unreviewed test gardening.
3403
3404         * LayoutReloaded/misc/LFC-passing-tests.txt:
3405
3406 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3407
3408         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3409         https://bugs.webkit.org/show_bug.cgi?id=193964
3410
3411         Reviewed by Antti Koivisto.
3412
3413         * LayoutReloaded/misc/LFC-passing-tests.txt:
3414
3415 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3416
3417         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3418         https://bugs.webkit.org/show_bug.cgi?id=193954
3419
3420         Reviewed by Antti Koivisto.
3421
3422         * LayoutReloaded/misc/LFC-passing-tests.txt:
3423
3424 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3425
3426         WebDriver: add support for running subtests
3427         https://bugs.webkit.org/show_bug.cgi?id=193904
3428
3429         Reviewed by Michael Catanzaro.
3430
3431         pytest already supports it by passing test.py::subtest, so we can do the same.
3432
3433         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3434         (get_item_name): Made this global.
3435         (CollectRecorder.__init__): Receive the parameter to ignore.
3436         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3437         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3438         (collect): Add parameter to ignore.
3439         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3440         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3441         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3442         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3443         (WebDriverTestRunnerSelenium.run): Ditto.
3444         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3445         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3446         (WebDriverTestRunnerW3C.run): Ditto.
3447
3448 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3449
3450         User agent string override for navigator.userAgent should be site specific quirks
3451         https://bugs.webkit.org/show_bug.cgi?id=193950
3452
3453         Reviewed by Brent Fulgham.
3454
3455         Updated per the _WKWebsitePolicies rename.
3456
3457         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3458         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3459
3460 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3461
3462         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3463         https://bugs.webkit.org/show_bug.cgi?id=193941
3464
3465         Reviewed by Alex Christensen.
3466
3467         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3468         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3469         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3470         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3471         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3472         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3473         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3474         * TestWebKitAPI/Tests/WTF/Time.cpp:
3475         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3476         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3477         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3478         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3479
3480 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3481
3482         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3483
3484         * Scripts/webkitpy/common/config/contributors.json:
3485
3486 2019-01-28  Andy Estes  <aestes@apple.com>
3487
3488         [watchOS] Enable Parental Controls content filtering
3489         https://bugs.webkit.org/show_bug.cgi?id=193939
3490         <rdar://problem/46641912>
3491
3492         Reviewed by Ryosuke Niwa.
3493
3494         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3495
3496 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3497
3498         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3499         <https://webkit.org/b/193884>
3500
3501         Reviewed by Jiewen Tan.
3502
3503         * Scripts/webkitpy/style/checkers/cpp.py:
3504         (check_language): Add LocalAuthentication to
3505         `frameworks_with_soft_links`.
3506
3507 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3508
3509         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3510         https://bugs.webkit.org/show_bug.cgi?id=193891
3511
3512         Reviewed by Ross Kirsling.
3513
3514         There were three problems in window sizes of WebView and the host window.
3515         1. The sizes of pixel image output were incorrect.
3516         2. The host window is going to appear after window.resize was invoked.
3517         3. window.resize resized only the host window, not WebView.
3518
3519         This change solves them with a following approach.
3520         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3521         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3522            as well as DumpRenderTree in order to match the client area and the window area.
3523         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3524         d. PlatformWebView::setWindowFrame changes both window sizes.
3525         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3526
3527         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3528         (WTR::PlatformWebView::PlatformWebView): Create the host window
3529         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3530         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3531         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3532
3533 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3534
3535         [ews-app] Add method to save Step data to database
3536         https://bugs.webkit.org/show_bug.cgi?id=193890
3537
3538         Reviewed by Lucas Forschler.
3539
3540         * BuildSlaveSupport/ews-app/ews/models/step.py:
3541         (Step.save_step): Method to save step data.
3542         (Step.update_step): Method to update step data.
3543         (Step.get_existing_step): Method to fetch existing step from database.
3544         (Step.is_valid_result): Method to validate valid step result.
3545
3546 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3547
3548         [ews-app] Add method to save Build data to database
3549         https://bugs.webkit.org/show_bug.cgi?id=193735
3550
3551         Reviewed by Lucas Forschler.
3552
3553         * BuildSlaveSupport/ews-app/ews/models/build.py:
3554         (Build.save_build): Method to save build information to database.
3555         (Build.get_existing_build): Method to fetch existing build from database.
3556         (Build.is_valid_result): Method to validate build result.
3557         * BuildSlaveSupport/ews-app/ews/common/util.py:
3558         (is_valid_int_id): Method to validate valid id.
3559
3560 2019-01-28  Chris Dumez  <cdumez@apple.com>
3561
3562         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3563         https://bugs.webkit.org/show_bug.cgi?id=193915
3564         <rdar://problem/47560907>
3565
3566         Reviewed by Alex Christensen.
3567
3568         Add API test coverage.
3569
3570         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3571
3572 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3573
3574         [ews-app] Rename id variables
3575         https://bugs.webkit.org/show_bug.cgi?id=193883
3576
3577         Reviewed by Lucas Forschler.
3578
3579         * BuildSlaveSupport/ews-app/ews/models/build.py:
3580         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3581         * BuildSlaveSupport/ews-app/ews/models/step.py:
3582         * BuildSlaveSupport/ews-app/ews/urls.py:
3583         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3584         * BuildSlaveSupport/ews-app/ews/views/results.py:
3585         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3586
3587 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3588
3589         [ews-app] Allow certain fields to be empty
3590         https://bugs.webkit.org/show_bug.cgi?id=193892
3591
3592         Reviewed by Lucas Forschler.
3593
3594         * BuildSlaveSupport/ews-app/ews/models/build.py:
3595         * BuildSlaveSupport/ews-app/ews/models/step.py:
3596
3597 2019-01-28  Rob Buis  <rbuis@igalia.com>
3598
3599         Update MIME type parser
3600         https://bugs.webkit.org/show_bug.cgi?id=180526
3601
3602         Reviewed by Frédéric Wang.
3603
3604         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3605         (TestWebKitAPI::TEST):
3606
3607 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3608
3609         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3610         https://bugs.webkit.org/show_bug.cgi?id=193896
3611
3612         Reviewed by Antti Koivisto.
3613
3614         * LayoutReloaded/misc/LFC-passing-tests.txt:
3615
3616 2018-12-15  Darin Adler  <darin@apple.com>
3617
3618         Replace many uses of String::format with more type-safe alternatives
3619         https://bugs.webkit.org/show_bug.cgi?id=192742
3620
3621         Reviewed by Mark Lam.
3622
3623         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3624         (WTR::cacheTestRunnerCallback): Use makeString.
3625         * WebKitTestRunner/TestController.cpp:
3626         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3627         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3628
3629 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3630
3631         Use a load optimizer for some sites
3632         https://bugs.webkit.org/show_bug.cgi?id=193881
3633         <rdar://problem/46325455>
3634
3635         Reviewed by Brent Fulgham.
3636
3637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3638         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3639
3640 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3641
3642         AX: Introduce a static accessibility tree
3643         https://bugs.webkit.org/show_bug.cgi?id=193348
3644         <rdar://problem/47203295>
3645
3646         Reviewed by Ryosuke Niwa.
3647
3648         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3649
3650 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3651
3652         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3653         https://bugs.webkit.org/show_bug.cgi?id=193867
3654
3655         Reviewed by Antti Koivisto.
3656
3657         * LayoutReloaded/misc/LFC-passing-tests.txt:
3658
3659 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3660
3661         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3662         https://bugs.webkit.org/show_bug.cgi?id=193865
3663
3664         Reviewed by Antti Koivisto.
3665
3666         * LayoutReloaded/misc/LFC-passing-tests.txt:
3667
3668 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3669
3670         Need a mechanism to override navigator.userAgent
3671         https://bugs.webkit.org/show_bug.cgi?id=193762
3672         <rdar://problem/47504939>
3673
3674         Reviewed by Brent Fulgham.
3675
3676         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3677
3678         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3679         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3680         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3681
3682 2019-01-25  Dean Jackson  <dino@apple.com>
3683
3684         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3685         https://bugs.webkit.org/show_bug.cgi?id=193831
3686         <rdar://problem/47399263>
3687
3688         Reviewed by Chris Dumez.
3689
3690         Two new tests that exercise cross-origin and same-origin System
3691         Previews.
3692
3693         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3694
3695 2019-01-25  Keith Rollin  <krollin@apple.com>
3696
3697         Update Xcode projects with "Check .xcfilelists" build phase
3698         https://bugs.webkit.org/show_bug.cgi?id=193790
3699         <rdar://problem/47201374>
3700
3701         Reviewed by Alex Christensen.
3702
3703         Support for XCBuild includes specifying inputs and outputs to various
3704         Run Script build phases. These inputs and outputs are specified as
3705         .xcfilelist files. Once created, these .xcfilelist files need to be
3706         kept up-to-date. In order to check that they are up-to-date or not,
3707         add an Xcode build step that invokes an external script that performs
3708         the checking. If the .xcfilelists are found to be out-of-date, update
3709         them, halt the build, and instruct the developer to restart the build
3710         with up-to-date files.
3711
3712         At this time, the checking and regenerating is performed only if the
3713         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3714         who want to use this facility can set this variable and test out the
3715         checking/regenerating. Once it seems like there are no egregious
3716         issues that upset a developer's workflow, we'll unconditionally enable
3717         this facility.
3718
3719         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3720         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3721         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3722         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3723
3724 2019-01-25  Keith Rollin  <krollin@apple.com>
3725
3726         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3727         https://bugs.webkit.org/show_bug.cgi?id=193781
3728         <rdar://problem/47201153>
3729
3730         Reviewed by Alex Christensen.
3731
3732         Part of generating the .xcfilelists used as part of adopting XCBuild
3733         includes running `make DerivedSources.make` from a standalone script.
3734         It’s important for this invocation to have the same environment as
3735         when the actual build invokes `make DerivedSources.make`. If the
3736         environments are different, then the two invocations will provide
3737         different results. In order to get the same environment in the
3738         standalone script, have the script launch xcodebuild targeting the
3739         "Apply Configuration to XCFileLists" build target, which will then
3740         re-invoke our standalone script. The script is now running again, this
3741         time in an environment with all workspace, project, target, xcconfig
3742         and other environment variables established.
3743
3744         The "Apply Configuration to XCFileLists" build target accomplishes
3745         this task via a small embedded shell script that consists only of:
3746
3747             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3748
3749         The process that invokes "Apply Configuration to XCFileLists" first
3750         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3751         evaluated and exports it into the shell environment. When xcodebuild
3752         is invoked, it inherits the value of this variable and can `eval` the
3753         contents of that variable. Our external standalone script can then set
3754         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3755         of command-line parameters needed to restart itself in the appropriate
3756         state.
3757
3758         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3759         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3760
3761 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3762
3763         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3764         https://bugs.webkit.org/show_bug.cgi?id=193802
3765         <rdar://problem/46010580>
3766
3767         Reviewed by Andy Estes.
3768
3769         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3770         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3771         (TEST):
3772
3773 2019-01-25  Daniel Bates  <dabates@apple.com>
3774
3775         [iOS] uiController.keyDown() does not translate Control modified key
3776         https://bugs.webkit.org/show_bug.cgi?id=192898
3777
3778         Reviewed by Wenson Hsieh.
3779
3780         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3781         key translation, as applicable. Among other cases, key translation occurs when performing
3782         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3783         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3784         human pressing down and releasing key(s) using a hardware keyboard.
3785
3786         * WebKitTestRunner/ios/HIDEventGenerator.h:
3787         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3788         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3789
3790         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3791         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3792         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3793         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3794         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3795         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3796         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3797         (-[HIDEventGenerator longPress:completionBlock:]):
3798         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3799         Update code for above renaming.
3800
3801         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3802         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3803
3804         (-[HIDEventGenerator keyDown:]): Added.
3805         (-[HIDEventGenerator keyUp:]): Added.
3806         (-[HIDEventGenerator keyPress:completionBlock:]):
3807         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3808         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3809         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3810         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3811         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3812         (WTR::parseModifier): Deleted.
3813
3814 2019-01-25  Keith Rollin  <krollin@apple.com>
3815
3816         Complete the implementation of generate-xcfilelists
3817         https://bugs.webkit.org/show_bug.cgi?id=193782
3818
3819         Reviewed by Alex Christensen.
3820
3821         A preliminary version of generate-xcfilelists was added in r238008.
3822         This patch updates that script in order to:
3823
3824         - Support checking of .xcfilelists
3825         - Perform better execution of `make DerivedSources.make` by
3826           relaunching generate-xcfilelists under xcodebuild
3827         - Support incremental generation and checking of .xcfilelists
3828         - Support supplementary .xcfilelists files from WebKitAdditions
3829         - Support being wrapped by parallel version of generate-xcfilelists in
3830           Internal that adds support for (re)generating WebKit projects in
3831           that repo.
3832         - Support builds that have been performed in WebKitBuild as well as
3833           ~/Library/Developer/code/DerivedData
3834         - Increase robustness and debugging facilities.
3835
3836         * Scripts/generate-xcfilelists:
3837
3838 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3839
3840         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3841         https://bugs.webkit.org/show_bug.cgi?id=193297
3842         <rdar://problem/47158841>
3843
3844         Unreviewed test case fix.
3845
3846         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3847         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3848
3849         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3850         (TEST):
3851
3852 2019-01-25  Keith Rollin  <krollin@apple.com>
3853
3854         Update existing .xcfilelists
3855         https://bugs.webkit.org/show_bug.cgi?id=193791
3856         <rdar://problem/47201706>
3857
3858         Reviewed by Alex Christensen.
3859
3860         Many .xcfilelist files were added in r238824 in order to support
3861         XCBuild. Update these with recent changes to the set of build files
3862         and with the current generate-xcfilelist script.
3863
3864         * DumpRenderTree/DerivedSources-input.xcfilelist:
3865         * DumpRenderTree/DerivedSources-output.xcfilelist:
3866         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3867         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3868
3869 2019-01-25  Keith Rollin  <krollin@apple.com>
3870
3871         Fix missing dependencies in extract-dependencies-from-makefile
3872         https://bugs.webkit.org/show_bug.cgi?id=193783
3873         <rdar://problem/47201571>
3874
3875         Reviewed by Alex Christensen.
3876
3877         The extract-dependencies-from-makefile script generates .xcfilelists
3878         for XCBuild by invoking a makefile in --debug mode, parsing the
3879         dependency information in the output, and extracting information
3880         regarding targets and dependents. However, the way `make` emits this
3881         dependency information is not rigorous, and so we need to determine
3882         what lines to look for and parse by trial and error. This approach
3883         didn't coriginally atch all the information we needed to collect, so
3884         update the script to look for the additional lines we now know to look
3885         for.
3886
3887         * Scripts/extract-dependencies-from-makefile:
3888         (Parser):
3889         (Parser.addTarget):
3890         (Parser.addPrereq):
3891         (Parser.doParse):
3892
3893 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3894
3895         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3896         https://bugs.webkit.org/show_bug.cgi?id=193297
3897         <rdar://problem/47158841>
3898
3899         Reviewed by Alex Christensen.
3900
3901         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3902             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3903         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3904         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3905         activating the message used to trigger the callback when it is set.
3906
3907 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3908
3909         WKWebView.goBack should reload if there is a safe browsing warning
3910         https://bugs.webkit.org/show_bug.cgi?id=193805
3911         <rdar://problem/46908216>
3912
3913         Reviewed by Geoff Garen.
3914
3915         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3916         (+[Simple3LookupContext sharedLookupContext]):
3917         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3918         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3919         (TEST):
3920
3921 2019-01-25  Chris Dumez  <cdumez@apple.com>
3922
3923         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3924         https://bugs.webkit.org/show_bug.cgi?id=193788
3925         <rdar://problem/47531231>
3926
3927         Reviewed by Alex Christensen.
3928
3929         Add API test coverage.
3930
3931         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3932         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3933
3934 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3935
3936         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3937         https://bugs.webkit.org/show_bug.cgi?id=193771
3938
3939         Unreviewed infrastructure fix.
3940
3941         * Scripts/webkitpy/port/darwin.py:
3942         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3943
3944 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3945
3946         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3947
3948 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3949
3950         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3951
3952         * Scripts/webkitpy/common/config/contributors.json:
3953
3954 2019-01-25  Chris Dumez  <cdumez@apple.com>
3955
3956         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3957         https://bugs.webkit.org/show_bug.cgi?id=193779
3958         <rdar://problem/46170903>
3959
3960         Reviewed by Antti Koivisto.
3961
3962         Add API test that quickly navigates forward to a previous process without waiting for it to
3963         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3964         the process' previous page when reconnecting the it for the forward navigation.
3965
3966         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3967
3968 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3969
3970         Need a way for JavaScript (or bundle) code to participate in undo
3971         https://bugs.webkit.org/show_bug.cgi?id=190009
3972         <rdar://problem/44807048>
3973
3974         Reviewed by Ryosuke Niwa.
3975
3976         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3977         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3978
3979         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3980         (WTR::UIScriptController::lastUndoLabel const):
3981         (WTR::UIScriptController::firstRedoLabel const):
3982         (WTR::UIScriptController::platformUndoManager const):
3983         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3984         (WTR::UIScriptController::lastUndoLabel const):
3985         (WTR::UIScriptController::firstRedoLabel const):
3986         (WTR::UIScriptController::platformUndoManager const):
3987         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3988         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3989         (WTR::UIScriptController::lastUndoLabel const):
3990         (WTR::UIScriptController::firstRedoLabel const):
3991         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3992         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3993         (WTR::UIScriptController::lastUndoLabel const):
3994         (WTR::UIScriptController::firstRedoLabel const):
3995         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3996         (WTR::UIScriptController::platformUndoManager const):
3997         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3998         (WTR::UIScriptController::platformUndoManager const):
3999
4000 2019-01-25  Zalan Bujtas  <zalan@apple.com>
4001
4002         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
4003         https://bugs.webkit.org/show_bug.cgi?id=193824
4004
4005         Reviewed by Antti Koivisto.
4006
4007         * LayoutReloaded/misc/LFC-passing-tests.txt:
4008
4009 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
4010
4011         Update macOS JSC bot configurations
4012         https://bugs.webkit.org/show_bug.cgi?id=193739
4013
4014         Reviewed by Alexey Proskuryakov.
4015
4016         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
4017         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4018         (BubbleQueueServer): Move JSC EWS to Mojave section.
4019         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4020         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
4021         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
4022
4023 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
4024
4025         [Win][WebKitTestRunner] Implement EventSenderProxy
4026         https://bugs.webkit.org/show_bug.cgi?id=193755
4027
4028         Reviewed by Don Olmstead.
4029
4030         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
4031         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
4032         (WTR::EventSenderProxy::dispatchMessage):
4033         (WTR::EventSenderProxy::EventSenderProxy):
4034         (WTR::EventSenderProxy::mouseDown):
4035         (WTR::EventSenderProxy::mouseUp):
4036         (WTR::EventSenderProxy::mouseMoveTo):
4037         (WTR::EventSenderProxy::mouseScrollBy):
4038         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
4039
4040 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4041
4042         Unreviewed fix for API test failure after r240437.
4043
4044         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
4045
4046         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
4047
4048 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4049
4050         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
4051         https://bugs.webkit.org/show_bug.cgi?id=193787
4052         <rdar://problem/47497634>
4053
4054         Reviewed by Alexey Proskuryakov.
4055
4056         * Scripts/webkitdirs.pm:
4057         (iosSimulatorApplicationsPath): Pick from available runtime directories.
4058
4059 2019-01-24  Truitt Savell  <tsavell@apple.com>
4060
4061         Unreviewed, rolling out r240446.
4062
4063         Casued 5 API failures
4064
4065         Reverted changeset:
4066
4067         "Activate the WebResourceLoadStatisticsStore in the
4068         NetworkProcess and deactivate it in the UIProcess."
4069         https://bugs.webkit.org/show_bug.cgi?id=193297
4070         https://trac.webkit.org/changeset/240446
4071
4072 2019-01-24  Zalan Bujtas  <zalan@apple.com>
4073
4074         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
4075         https://bugs.webkit.org/show_bug.cgi?id=193741
4076         <rdar://problem/47135030>
4077
4078         Reviewed by Antti Koivisto and Simon Fraser.
4079
4080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4081         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
4082         (TestWebKitAPI::TEST):
4083
4084 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
4085
4086         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4087         https://bugs.webkit.org/show_bug.cgi?id=193297
4088         <rdar://problem/47158841>
4089
4090         Reviewed by Alex Christensen.
4091
4092         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4093         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4094         activating the message used to trigger the callback when it is set.
4095
4096 2019-01-24  John Wilander  <wilander@apple.com>
4097
4098         Add Ad Click Attribution as an internal/experimental feature
4099         https://bugs.webkit.org/show_bug.cgi?id=193685
4100         <rdar://problem/47450399>
4101
4102         Reviewed by Brent Fulgham.
4103
4104         Added test option adClickAttributionEnabled.
4105
4106         * DumpRenderTree/TestOptions.cpp:
4107         (TestOptions::TestOptions):
4108         * DumpRenderTree/TestOptions.h:
4109         * DumpRenderTree/mac/DumpRenderTree.mm:
4110         (setWebPreferencesForTestOptions):
4111
4112 2019-01-24  Antti Koivisto  <antti@apple.com>
4113
4114         [PSON] Flash on back navigation on Mac
4115         https://bugs.webkit.org/show_bug.cgi?id=193716
4116         <rdar://problem/47148458>
4117
4118         Reviewed by Chris Dumez.
4119
4120         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4121
4122         Closing of the previous page is delayed so waiting for didFinishNavigation is
4123         not sufficient to guarantee we have received all the messages. Wait for them.
4124
4125 2019-01-24  Chris Dumez  <cdumez@apple.com>
4126
4127         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
4128         https://bugs.webkit.org/show_bug.cgi?id=193761
4129         <rdar://problem/47456405>
4130
4131         Reviewed by Alex Christensen.
4132
4133         Add API test coverage.
4134
4135         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4136
4137 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4138
4139         webkitpy: Missing PID in crashlog name should not be fatal
4140         https://bugs.webkit.org/show_bug.cgi?id=193771
4141
4142         If we can't determine the PID of a crashlog, just ignore the crashlog instead
4143         of raising an exception.
4144
4145         Reviewed by Lucas Forschler.
4146
4147         * Scripts/webkitpy/port/darwin.py:
4148         (DarwinPort._merge_crash_logs):
4149
4150 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4151
4152         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
4153         https://bugs.webkit.org/show_bug.cgi?id=193746
4154
4155         Reviewed by Youenn Fablet.
4156
4157         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
4158         so we'd best just not call it.
4159
4160         * Scripts/webkitpy/w3c/test_exporter.py:
4161         (WebPlatformTestExporter.create_branch_with_patch):
4162
4163 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4164
4165         Move FileSystem to WTF
4166         https://bugs.webkit.org/show_bug.cgi?id=193602
4167
4168         Reviewed by Yusuke Suzuki.
4169
4170         * DumpRenderTree/win/DumpRenderTree.cpp:
4171         * TestWebKitAPI/CMakeLists.txt:
4172         * TestWebKitAPI/PlatformGTK.cmake:
4173         * TestWebKitAPI/PlatformJSCOnly.cmake:
4174         * TestWebKitAPI/PlatformPlayStation.cmake:
4175         * TestWebKitAPI/PlatformWPE.cmake:
4176         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4177         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
4178         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
4179         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
4180         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
4181         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
4182         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4183         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4184         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4185         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4186
4187 2019-01-24  Philippe Normand  <pnormand@igalia.com>
4188
4189         [WPE] Remove hard dependency on subprocess32 for the API tests
4190
4191         Rubber-stamped by Carlos Garcia Campos.
4192
4193         * glib/api_test_runner.py:
4194         (TestRunner._run_test_qt): Lazily import subprocess32 and check
4195         its presence only when running WPEQt tests.
4196
4197 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4198
4199         [GLIB] Expose JavaScriptCore options in GLib public API
4200         https://bugs.webkit.org/show_bug.cgi?id=188742
4201
4202         Reviewed by Michael Catanzaro.
4203
4204         Add a test for the new API.
4205
4206         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4207         (testsJSCOptions):
4208         (main):
4209
4210 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4211
4212         [GTK][WPE] Support JPEG 2000 images
4213         https://bugs.webkit.org/show_bug.cgi?id=186272
4214
4215         Reviewed by Žan Doberšek.
4216
4217         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
4218
4219         * gtk/jhbuild.modules:
4220         * wpe/jhbuild.modules:
4221
4222 2019-01-23  David Kilzer  <ddkilzer@apple.com>
4223
4224         check-webkit-style should warn when using soft-linking macros in a header
4225         <https://webkit.org/b/193750>
4226
4227         Reviewed by Darin Adler.
4228
4229         * Scripts/webkitpy/style/checkers/cpp.py:
4230         (check_language): Add softlink/header check by refactoring the
4231         softlink/framework check.
4232         (CppChecker): Enable softlink/header check by default.
4233         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4234         (CppStyleTest.test_softlink_framework): Rename from
4235         CppStyleTest.test_softlink() and change test framework name in
4236         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
4237         files. Set file_name for macros that only appear in headers.
4238         (CppStyleTest.test_softlink_header): Add tests for using
4239         soft-link macros in headers.
4240
4241 2019-01-23  Chris Dumez  <cdumez@apple.com>
4242
4243         Deprecate API to limit the maximum number of WebProcesses
4244         https://bugs.webkit.org/show_bug.cgi?id=193725
4245         <rdar://problem/47464879>
4246
4247         Reviewed by Geoff Garen.
4248
4249         Update existing API tests to stop using deprecated API.
4250
4251         * MiniBrowser/mac/AppDelegate.m:
4252         (defaultConfiguration):
4253         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4254         (TestWebKitAPI::TEST):
4255         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
4256         (TestWebKitAPI::TEST):
4257         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4258         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
4259         (TEST):
4260         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
4261         (TEST):
4262
4263 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4264
4265         [ews-app] Rename ews model buildermappings to buildermapping
4266         https://bugs.webkit.org/show_bug.cgi?id=193729
4267
4268         Reviewed by Lucas Forschler.
4269
4270         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
4271         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
4272         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
4273
4274 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4275
4276         [ews-app] Rename ews model steps to step
4277         https://bugs.webkit.org/show_bug.cgi?id=193697
4278
4279         Reviewed by Lucas Forschler.
4280
4281         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
4282         (Step): Renamed Steps to Step.
4283
4284 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
4285
4286         Clean up IndexedDB files between tests
4287         https://bugs.webkit.org/show_bug.cgi?id=192796
4288         <rdar://problem/46824999>
4289
4290         Reviewed by Geoffrey Garen.
4291
4292         * DumpRenderTree/mac/DumpRenderTree.mm:
4293         (runTest):
4294         * WebKitTestRunner/TestController.cpp:
4295         (WTR::TestController::resetStateToConsistentValues):
4296         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
4297         (WTR::RemoveAllIndexedDatabasesCallback):
4298         (WTR::TestController::ClearIndexedDatabases):
4299         * WebKitTestRunner/TestController.h:
4300         * WebKitTestRunner/TestInvocation.cpp:
4301         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4302
4303 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4304
4305         [ews-app] Rename ews model Builds to Build
4306         https://bugs.webkit.org/show_bug.cgi?id=193695
4307
4308         Reviewed by Lucas Forschler.
4309
4310         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
4311         (Build): Renamed Builds to Build.
4312
4313 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
4314
4315         webkitpy: Wait longer when launching WebKitTestRunner
4316         https://bugs.webkit.org/show_bug.cgi?id=193734
4317
4318         Reviewed by Aakash Jain.
4319
4320         * Scripts/webkitpy/port/simulator_process.py:
4321         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
4322
4323 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
4324
4325         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
4326         https://bugs.webkit.org/show_bug.cgi?id=193182
4327         <rdar://problem/47452154>
4328
4329         Reviewed by Tim Horton.
4330
4331         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
4332         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
4333         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
4334
4335         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
4336         preventing later tests from recognizing gestures.
4337
4338         * WebKitTestRunner/ios/TestControllerIOS.mm:
4339         (WTR::TestController::platformResetStateToConsistentValues):
4340
4341         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
4342
4343 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
4344
4345         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
4346         https://bugs.webkit.org/show_bug.cgi?id=193722
4347         <rdar://problem/47481475>
4348
4349         Reviewed by Lucas Forschler.
4350
4351         iPhone and iPad ports should both use the iOS config.
4352
4353         * Scripts/webkitpy/port/ios_simulator.py:
4354         (IPhoneSimulatorPort.__init__):
4355         (IPadSimulatorPort.__init__):
4356
4357 2019-01-23  Rob Buis  <rbuis@igalia.com>
4358
4359         Update MIME type parser
4360         https://bugs.webkit.org/show_bug.cgi?id=180526
4361
4362         Reviewed by Frédéric Wang.
4363
4364         Add unit tests for both parse modes of ParsedContentType.
4365
4366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4367         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
4368         (TestWebKitAPI::TEST):
4369
4370 2019-01-22  Aakash Jain  <aakash_jain@apple.com>