Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2
3         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
4         https://bugs.webkit.org/show_bug.cgi?id=196909
5
6         Reviewed by Wenson Hsieh.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
9         (TestWebKitAPI::TEST):
10
11 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
12
13         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
14         https://bugs.webkit.org/show_bug.cgi?id=196880
15
16         Reviewed by Yusuke Suzuki.
17
18         Add a new function for bytecode cache tests that does not forceDiskCache
19         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
20         test added in this patch, since the code is invalid and therefore won't be
21         cached. It should also be useful for tests that evaluate dynamically
22         generated code.
23
24         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
25         * Scripts/run-jsc-stress-tests:
26
27 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
28
29         Update AudioSession route sharing policy
30         https://bugs.webkit.org/show_bug.cgi?id=196776
31         <rdar://problem/46501611>
32
33         Reviewed by Jer Noble.
34
35         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
36         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
37         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
38         (TestWebKitAPI::TEST):
39
40 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
41
42         [iOS] Software keyboard is shown too frequently on some websites
43         https://bugs.webkit.org/show_bug.cgi?id=195856
44         <rdar://problem/49191395>
45
46         Reviewed by Darin Adler.
47
48         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
49
50         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
51         (WTR::UIScriptController::setHardwareKeyboardAttached):
52         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
53         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
54         (WTR::UIScriptController::setHardwareKeyboardAttached):
55         * TestRunnerShared/UIScriptContext/UIScriptController.h:
56         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
57
58         Additionally link against GraphicsServices in WebKitTestRunner.
59
60         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
61         (WTR::TestController::platformResetStateToConsistentValues):
62         (WTR::UIScriptController::setHardwareKeyboardAttached):
63
64 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
65
66         [GTK][WPE] Fix pacman install-dependencies packages
67         https://bugs.webkit.org/show_bug.cgi?id=196817
68
69         Reviewed by Žan Doberšek.
70         
71         python3-setuptools is called python-setuptools
72         ruby-highline is only available on AUR
73         libv4l-devel is incorporated in v4l-utils
74
75         * gtk/install-dependencies:
76         * wpe/install-dependencies:
77
78 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
79
80         [GTK] REGRESSION(r243860): Many tests failing
81         https://bugs.webkit.org/show_bug.cgi?id=196791
82
83         Reviewed by Joanmarie Diggs.
84
85         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
86         multiple documents and check that accessibility hierarchy is updated after a navigation.
87
88         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
89         (loadChangedCallback):
90         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
91         (AccessibilityTest::AccessibilityTest):
92         (AccessibilityTest::~AccessibilityTest):
93         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
94         (AccessibilityTest::findTestServerApplication):
95         (AccessibilityTest::findDocumentWeb):
96         (AccessibilityTest::findRootObject):
97         (AccessibilityTest::waitUntilChildrenRemoved):
98         (AccessibilityTest::ensureProxy):
99         (testAtspiBasicHierarchy):
100         (beforeAll):
101         (afterAll):
102
103 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
104
105         [ews-build] Handle bug titles with unicode characters
106         https://bugs.webkit.org/show_bug.cgi?id=196802
107
108         Reviewed by Dewei Zhu.
109
110         * BuildSlaveSupport/ews-build/steps.py:
111         (ValidatePatch._is_bug_closed):
112
113 2019-04-11  Michael Saboff  <msaboff@apple.com>
114
115         Improve the Inline Cache Stats code
116         https://bugs.webkit.org/show_bug.cgi?id=196836
117
118         Reviewed by Saam Barati.
119
120         Added a new script to consolidate and arrange the output of --useICStats option.
121
122         This script merges the output from every group into one large table and sorts it from most common to
123         least common.  It also counts the slow path GetById and PutById variants and then calculates the
124         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
125         Put together, this is useful to see what property accesses are not getting cached.
126
127         * Scripts/ic-stats.py: Added.
128         (ICStats):
129         (ICStats.__init__):
130         (ICStats.parse):
131         (ICStats.dumpStats):
132         (usage):
133
134 2019-04-10  Alex Christensen  <achristensen@webkit.org>
135
136         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
137         https://bugs.webkit.org/show_bug.cgi?id=196809
138         <rdar://49800762>
139
140         Reviewed by Brady Eidson.
141
142         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
143         (TEST):
144
145 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
146
147         requestAnimationFrame should execute before the next frame
148         https://bugs.webkit.org/show_bug.cgi?id=177484
149
150         Reviewed by Simon Fraser.
151
152         Add trace points for the page RenderingUpdate.
153
154         * Tracing/SystemTracePoints.plist:
155
156 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
157
158         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
159         https://bugs.webkit.org/show_bug.cgi?id=196760
160
161         Reviewed by Don Olmstead.
162
163         vswhere.exe has been bundled since Visual Studio 2017 version
164         15.2. We shouldn't download vswhere.exe.
165
166         * Scripts/build-jsc: Do not call update-vswhere.py.
167         * Scripts/build-webkit: Ditto.
168         * Scripts/update-vswhere.py: Removed.
169         * Scripts/webkitdirs.pm:
170         (requireModulesForVSWhere): Deleted.
171         (pickCurrentVisualStudioInstallation): Deleted.
172         (visualStudioInstallDirVSWhere): Return the latest installed VS
173         installation path by using the bundled vswhere.exe.
174         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
175         (visualStudioInstallDirFallback): Removed.
176
177 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
178
179         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
180         https://bugs.webkit.org/show_bug.cgi?id=196780
181
182         Reviewed by Alexey Proskuryakov.
183
184         * BuildSlaveSupport/ews-build/steps.py:
185         * BuildSlaveSupport/ews-build/steps_unittest.py:
186
187 2019-04-10  Alex Christensen  <achristensen@webkit.org>
188
189         Add SPI WKNavigationResponse._downloadAttribute
190         https://bugs.webkit.org/show_bug.cgi?id=196755
191         <rdar://49587365>
192
193         Reviewed by Brady Eidson.
194
195         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
196         (-[NavigationResponseTestDelegate navigationResponse]):
197         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
198         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
199         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
200         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
201         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
202         (readRequest):
203         (writeResponse):
204         (TEST):
205
206 2019-04-10  Tim Horton  <timothy_horton@apple.com>
207
208         Add modern API for overriding the page's specified viewport configuration
209         https://bugs.webkit.org/show_bug.cgi?id=167734
210         <rdar://problem/30331795>
211
212         Reviewed by Simon Fraser.
213
214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
215         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
216
217 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
218
219         Add support for incremental bytecode cache updates
220         https://bugs.webkit.org/show_bug.cgi?id=195000
221
222         Reviewed by Filip Pizlo.
223
224         Exit when the initial run to generate bytecode fails.
225
226         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
227
228 2019-04-10  Alex Christensen  <achristensen@webkit.org>
229
230         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
231         https://bugs.webkit.org/show_bug.cgi?id=196744
232         <rdar://49415309>
233
234         Reviewed by Chris Dumez.
235
236         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
237         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
238
239 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
240
241         Add a way to opt into modern compatibility mode in layout tests
242         https://bugs.webkit.org/show_bug.cgi?id=196770
243         <rdar://problem/49777550>
244
245         Reviewed by Antoine Quint.
246
247         Add a new test option to enable modern compatibility mode in layout tests.
248
249         * WebKitTestRunner/TestController.cpp:
250         (WTR::updateTestOptionsFromTestHeader):
251         * WebKitTestRunner/TestController.h:
252         * WebKitTestRunner/TestOptions.h:
253         (WTR::TestOptions::hasSameInitializationOptions const):
254         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
255         (WTR::TestController::platformCreateWebView):
256         (WTR::TestController::enableModernCompatibilityMode):
257
258 2019-04-10  Andy Estes  <aestes@apple.com>
259
260         Try to fix the 32-bit watchOS build.
261
262         * TestWebKitAPI/cocoa/TestWKWebView.mm:
263         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
264
265 2019-04-10  Antoine Quint  <graouts@apple.com>
266
267         Enable Pointer Events on watchOS
268         https://bugs.webkit.org/show_bug.cgi?id=196771
269         <rdar://problem/49040909>
270
271         Reviewed by Dean Jackson.
272
273         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
274
275 2019-04-10  Philippe Normand  <pnormand@igalia.com>
276
277         Unreviewed. Fix WPE accessibility tests after r244059.
278
279         We are failing to load the injected bundle due to undefined symbol
280         AccessibilityUIElement::replaceTextInRange().
281
282         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
283         (WTR::AccessibilityUIElement::replaceTextInRange):
284
285 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
286
287         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
288         https://bugs.webkit.org/show_bug.cgi?id=196727
289
290         Reviewed by Fujii Hironori.
291
292         * MiniBrowser/win/WebKitBrowserWindow.cpp:
293         (WebKitBrowserWindow::create):
294
295 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
296
297         [ews-build] Add unit tests for PrintConfiguration
298         https://bugs.webkit.org/show_bug.cgi?id=196752
299
300         Reviewed by Dewei Zhu.
301
302         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
303
304 2019-04-09  Keith Rollin  <krollin@apple.com>
305
306         Unreviewed build maintenance -- update .xcfilelists.
307
308         * DumpRenderTree/DerivedSources-input.xcfilelist:
309         * DumpRenderTree/DerivedSources-output.xcfilelist:
310
311 2019-04-09  Zalan Bujtas  <zalan@apple.com>
312
313         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
314         https://bugs.webkit.org/show_bug.cgi?id=196743
315         <rdar://problem/43897551>
316
317         Reviewed by Tim Horton.
318
319         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
320         (TEST):
321
322 2019-04-09  Youenn Fablet  <youenn@apple.com>
323
324         Close service worker database on network process suspension
325         https://bugs.webkit.org/show_bug.cgi?id=196623
326         <rdar://problem/48930869>
327
328         Reviewed by Alex Christensen.
329
330         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
331
332 2019-04-09  Daniel Bates  <dabates@apple.com>
333
334         [iPad] Should open popover when the spacebar is pressed
335         https://bugs.webkit.org/show_bug.cgi?id=196360
336         <rdar://problem/49389129>
337
338         Reviewed by Brent Fulgham.
339
340         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
341
342         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
343         (WTR::UIScriptController::isShowingPopover const): Added.
344         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
345         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
346         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
347         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
348         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
349         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
350         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
351         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
352         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
353         (WTR::UIScriptController::isShowingPopover const): Added.
354         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
355         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
356         * TestRunnerShared/UIScriptContext/UIScriptController.h:
357         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
358         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
359         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
360         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
361         (-[TestRunnerWKWebView _willPresentPopover]): Added.
362         (-[TestRunnerWKWebView _didDismissPopover]): Added.
363         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
364         (WTR::UIScriptController::isShowingPopover const): Added.
365         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
366         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
367
368 2019-04-09  Alex Christensen  <achristensen@webkit.org>
369
370         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
371         https://bugs.webkit.org/show_bug.cgi?id=196665
372         <rdar://45115669>
373
374         Reviewed by Geoff Garen.
375
376         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
377         (goBack):
378         (+[SimpleLookupContext sharedLookupContext]):
379         (-[SimpleLookupContext lookUpURL:completionHandler:]):
380         (TEST):
381         (+[Simple3LookupContext sharedLookupContext]): Deleted.
382         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
383
384 2019-04-09  John Wilander  <wilander@apple.com>
385
386         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
387         https://bugs.webkit.org/show_bug.cgi?id=196558
388         <rdar://problem/47650245>
389
390         Reviewed by Youenn Fablet.
391
392         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
393         (TestWebKitAPI::TEST):
394             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
395
396 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
397
398         [CMake] Apple builds should use ICU_INCLUDE_DIRS
399         https://bugs.webkit.org/show_bug.cgi?id=196720
400
401         Reviewed by Konstantin Tokarev.
402
403         * TestWebKitAPI/PlatformMac.cmake:
404
405 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
406
407         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
408         https://bugs.webkit.org/show_bug.cgi?id=196694
409         <rdar://problem/48388734>
410
411         Rubber-stamped by Aakash Jain.
412
413         * Scripts/webkitpy/port/image_diff.py:
414         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
415         * Scripts/webkitpy/port/server_process.py:
416         (ServerProcess.has_available_stdout): Check if stdout has data in it.
417         (ServerProcess._wait_for_data_and_update_buffers_using_select):
418         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
419         * Scripts/webkitpy/port/server_process_mock.py:
420         (MockServerProcess.has_available_stdout):
421         * Scripts/webkitpy/port/server_process_unittest.py:
422         (TestServerProcess.serial_test_basic):
423
424 2019-04-09  Jer Noble  <jer.noble@apple.com>
425
426         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
427         https://bugs.webkit.org/show_bug.cgi?id=196097
428
429         Reviewed by Eric Carlson.
430
431         Drive-by bug fix: allow tests to play audio without a user gesture by default.
432
433         * DumpRenderTree/mac/DumpRenderTree.mm:
434         (resetWebPreferencesToConsistentValues):
435         * WebKitTestRunner/TestController.cpp:
436         (WTR::TestController::resetPreferencesToConsistentValues):
437
438 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
439
440         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
441         https://bugs.webkit.org/show_bug.cgi?id=196690
442
443         Reviewed by Michael Catanzaro.
444
445         * QueueStatusServer/config/queues.py:
446         * Scripts/webkitpy/common/config/ews.json:
447         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
448         (test_ews_name):
449
450 2019-04-09  Chris Dumez  <cdumez@apple.com>
451
452         Loads using loadHTMLString() cause flashing when process-swapping
453         https://bugs.webkit.org/show_bug.cgi?id=196714
454         <rdar://problem/49637354>
455
456         Reviewed by Antti Koivisto.
457
458         Add API test coverage.
459
460         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
461
462 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
463
464         Unreviewed. Fix ATK accessibility tests after r244059.
465
466         We are failing to load the injected bundle due to undefined symbol
467         AccessibilityUIElement::replaceTextInRange().
468
469         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
470         (WTR::AccessibilityUIElement::replaceTextInRange):
471
472 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
473
474         AX: Support API: accessibilityReplaceRange:withText
475         https://bugs.webkit.org/show_bug.cgi?id=196636
476
477         Unreviewed build fix for Windows port.
478
479         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
480         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
481
482 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
483
484         [CMake][WinCairo] Separate copied headers into different directories
485         https://bugs.webkit.org/show_bug.cgi?id=196655
486
487         Reviewed by Michael Catanzaro.
488
489         * DumpRenderTree/CMakeLists.txt:
490         * MiniBrowser/win/CMakeLists.txt:
491         * TestWebKitAPI/CMakeLists.txt:
492         * TestWebKitAPI/PlatformWin.cmake:
493
494 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
495
496         Log stack-trace for run-webkit-tests when interrupted
497         https://bugs.webkit.org/show_bug.cgi?id=176393
498         <rdar://problem/34262310>
499
500         Reviewed by Lucas Forschler.
501
502         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
503         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
504         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
505         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
506         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
507         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
508         (main): Set handlers to log stack trace on interruption.
509
510 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
511
512         AX: Support API: accessibilityReplaceRange:withText
513         https://bugs.webkit.org/show_bug.cgi?id=196636
514
515         Unreviewed build fix for Windows port.
516
517         * DumpRenderTree/AccessibilityUIElement.cpp:
518         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
519
520 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
521
522         [ews-build] Scripts using Buildbot API have CORS error
523         https://bugs.webkit.org/show_bug.cgi?id=196709
524
525         Reviewed by Alexey Proskuryakov.
526
527         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
528
529 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
530
531         AX: Support API: accessibilityReplaceRange:withText
532         https://bugs.webkit.org/show_bug.cgi?id=196636
533
534         Reviewed by Daniel Bates.
535
536         * DumpRenderTree/AccessibilityUIElement.cpp:
537         (replaceTextInRangeCallback):
538         (AccessibilityUIElement::replaceTextInRange):
539         (AccessibilityUIElement::getJSClass):
540         * DumpRenderTree/AccessibilityUIElement.h:
541         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
542         (AccessibilityUIElement::replaceTextInRange):
543         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
544         (AccessibilityUIElement::replaceTextInRange):
545         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
546         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
547         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
548         (WTR::AccessibilityUIElement::replaceTextInRange):
549         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
550         (WTR::AccessibilityUIElement::replaceTextInRange):
551
552 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
553
554         [iOS] Do not allow starting selection drags when selection views are not visible
555         https://bugs.webkit.org/show_bug.cgi?id=196686
556         <rdar://problem/49399192>
557
558         Reviewed by Tim Horton.
559
560         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
561         also add some new API tests to cover scenarios where the web view is not first responder.
562
563         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
564         (TestWebKitAPI::TEST):
565         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
566
567         Add a switch to optionally make the web view first responder when starting the simulated drag.
568
569         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
570         (-[DragAndDropSimulator initWithWebView:]):
571         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
572
573 2019-04-08  Justin Fan  <justin_fan@apple.com>
574
575         [Web GPU] Fix Web GPU experimental feature on iOS
576         https://bugs.webkit.org/show_bug.cgi?id=196632
577
578         Reviewed by Myles C. Maxfield.
579
580         Properly make Web GPU available on iOS 11+.
581
582         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
583
584 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
585
586         [ews-build] Do not upload archive when Compile Fails
587         https://bugs.webkit.org/show_bug.cgi?id=196674
588
589         Reviewed by Alexey Proskuryakov.
590
591         * BuildSlaveSupport/ews-build/factories.py:
592         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
593         * BuildSlaveSupport/ews-build/steps.py:
594         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
595         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
596         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
597
598 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
599
600         Enable DFG on MIPS
601         https://bugs.webkit.org/show_bug.cgi?id=196689
602
603         Reviewed by Žan Doberšek.
604
605         Since the bytecode change, we enabled the baseline JIT on mips in
606         r240432, but DFG is still missing. With this change, all tests are
607         passing on a ci20 board.
608
609         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
610
611 2019-04-08  Philippe Normand  <pnormand@igalia.com>
612
613         [Flatpak] Second run update-webkitwpe-flatpak fails
614         https://bugs.webkit.org/show_bug.cgi?id=192702
615
616         Reviewed by Carlos Garcia Campos.
617
618         * flatpak/flatpakutils.py:
619         (FlatpakObject.flatpak): Fix typo.
620         (FlatpakPackage.install): When installing, also update to the configured remote commit.
621         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
622
623 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
624
625         [GTK][WPE] outlook.live.com displays old-fashioned UI
626         https://bugs.webkit.org/show_bug.cgi?id=196642
627
628         Reviewed by Carlos Garcia Campos.
629
630         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
631         (TestWebKitAPI::TEST): New Mac platform quirk test.
632
633 2019-04-07  Commit Queue  <commit-queue@webkit.org>
634
635         Unreviewed, rolling out r243956.
636         https://bugs.webkit.org/show_bug.cgi?id=196688
637
638         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
639         by aakashjain on #webkit).
640
641         Reverted changeset:
642
643         "Clicking "Go Back" from a safe browsing warning from an
644         iframe should navigate the WKWebView back to the previous
645         page"
646         https://bugs.webkit.org/show_bug.cgi?id=196665
647         https://trac.webkit.org/changeset/243956
648
649 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
650
651         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
652         https://bugs.webkit.org/show_bug.cgi?id=196669
653
654         Reviewed by Geoffrey Garen.
655
656         Added three new unit tests for WeakHashSet.
657
658         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
659         (WTF_WeakPtr.WeakHashSetConstObjects):
660         (WTF_WeakPtr.WeakHashSetComputesEmpty):
661         (WTF_WeakPtr.WeakHashSetComputeSize):
662
663 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
664
665         Hide next and previous form control buttons when WKWebView is editable
666         https://bugs.webkit.org/show_bug.cgi?id=196672
667         <rdar://problem/35625321>
668
669         Reviewed by Tim Horton.
670
671         Add a new API test.
672
673         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
674         (-[TestWKWebView lastTrailingBarButtonGroup]):
675         (TestWebKitAPI::TEST):
676         * TestWebKitAPI/ios/UIKitSPI.h:
677
678 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
679
680         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
681         https://bugs.webkit.org/show_bug.cgi?id=196077
682         <rdar://problem/49108202>
683
684         Reviewed by Chris Dumez.
685
686         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
687         on new web view.
688
689         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
690
691 2019-04-05  Saam Barati  <sbarati@apple.com>
692
693         Make compare-results understand MotionMark
694         https://bugs.webkit.org/show_bug.cgi?id=196666
695
696         Reviewed by Yusuke Suzuki.
697
698         * Scripts/compare-results:
699         (PLT5Results):
700         (detectMotionMark):
701         (detectMotionMark1_1):
702         (motionMarkResults):
703         (motionMark1_1Results):
704         (detectBenchmark):
705         (biggerIsBetter):
706         (main):
707
708 2019-04-05  Alex Christensen  <achristensen@webkit.org>
709
710         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
711         https://bugs.webkit.org/show_bug.cgi?id=196665
712         <rdar://45115669>
713
714         Reviewed by Geoff Garen.
715
716         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
717         (goBack):
718         (+[SimpleLookupContext sharedLookupContext]):
719         (-[SimpleLookupContext lookUpURL:completionHandler:]):
720         (TEST):
721         (+[Simple3LookupContext sharedLookupContext]): Deleted.
722         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
723
724 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
725
726         [ews-build] Add configuration and architecture for windows builders
727         https://bugs.webkit.org/show_bug.cgi?id=196660
728
729         Reviewed by Lucas Forschler.
730
731         * BuildSlaveSupport/ews-build/config.json:
732
733 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
734
735         webkitpy: Don't run subsequent rounds if interrupted
736         https://bugs.webkit.org/show_bug.cgi?id=196646
737
738         Reviewed by Aakash Jain.
739
740         * Scripts/webkitpy/layout_tests/controllers/manager.py:
741         (Manager.run): Bail out if interrupted.
742
743 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
744
745         Test sessionStorage in PSON private browsing mode
746         https://bugs.webkit.org/show_bug.cgi?id=196561
747
748         Reviewed by Alex Christensen.
749
750         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
751
752 2019-04-05  Commit Queue  <commit-queue@webkit.org>
753
754         Unreviewed, rolling out r243833.
755         https://bugs.webkit.org/show_bug.cgi?id=196645
756
757         This change breaks build of WPE and GTK ports (Requested by
758         annulen on #webkit).
759
760         Reverted changeset:
761
762         "[CMake][WTF] Mirror XCode header directories"
763         https://bugs.webkit.org/show_bug.cgi?id=191662
764         https://trac.webkit.org/changeset/243833
765
766 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
767
768         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
769         https://bugs.webkit.org/show_bug.cgi?id=196635
770
771         Reviewed by Antti Koivisto.
772         
773         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
774         for a test to enable async frame scrolling via:
775             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
776         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
777         
778         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
779
780         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
781         (WTR::InjectedBundle::beginTesting):
782         * WebKitTestRunner/TestController.cpp:
783         (WTR::TestController::resetPreferencesToConsistentValues):
784
785 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
786
787         Use a correct LC_RPATH when building with ASan
788         https://bugs.webkit.org/show_bug.cgi?id=196576
789
790         Reviewed by David Kilzer.
791
792         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
793         so that ../Frameworks is checked. This is simpler and more reliable than updating
794         each SPC service xcconfig.
795
796 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
797
798         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
799         https://bugs.webkit.org/show_bug.cgi?id=196629
800
801         Reviewed by Lucas Forschler.
802
803         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
804
805 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
806
807         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
808         https://bugs.webkit.org/show_bug.cgi?id=196618
809
810         Reviewed by Lucas Forschler.
811
812         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
813         (StatusBubble): Added QUEUE_TRIGGERS.
814         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
815         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
816         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
817         its parent(builder).
818
819 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
820
821         [ews-app] Status-bubble steps are sometimes displayed in reverse order
822         https://bugs.webkit.org/show_bug.cgi?id=196625
823
824         Reviewed by Lucas Forschler.
825
826         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
827         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
828
829 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
830
831         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
832         https://bugs.webkit.org/show_bug.cgi?id=196630
833
834         Reviewed by Wenson Hsieh.
835
836         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
837
838 2019-04-04  Youenn Fablet  <youenn@apple.com>
839
840         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
841         https://bugs.webkit.org/show_bug.cgi?id=196543
842
843         Reviewed by Alex Christensen.
844
845         * WebKitTestRunner/TestController.cpp:
846         (WTR::TestController::generatePageConfiguration):
847
848 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
849
850         [ews-app] Status bubble should not display skipped buildbot steps
851         https://bugs.webkit.org/show_bug.cgi?id=196584
852
853         Reviewed by Lucas Forschler.
854
855         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
856
857 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
858
859         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
860         https://bugs.webkit.org/show_bug.cgi?id=196620
861
862         Reviewed by Lucas Forschler.
863
864         * BuildSlaveSupport/ews-app/ews/config.py:
865
866 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
867
868         [Win] DumpRenderTreeWatchDog.py is not checked into source
869         https://bugs.webkit.org/show_bug.cgi?id=196567
870         <rdar://problem/49525901>
871
872         Reviewed by Lucas Forschler.
873
874         This script is used on Win EWS bots to terminate hanging DRT processes.
875
876         * EWSTools/dumprendertreewatchdog.py: Added.
877
878 2019-04-04  Chris Dumez  <cdumez@apple.com>
879
880         Unreviewed, roll out r243858 which made tests time out.
881
882         Disable new API tests on Windows instead.
883
884         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
885         (TestWebKitAPI::TEST):
886
887 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
888
889         [ATK] Cleanup WebPageAccessibilityObjectAtk
890         https://bugs.webkit.org/show_bug.cgi?id=196537
891
892         Reviewed by Michael Catanzaro.
893
894         Also consider files under atk directories as exceptions for GObject conventions.
895
896         * Scripts/webkitpy/style/checkers/cpp.py:
897         (check_identifier_name_in_declaration):
898
899 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
900
901         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
902         https://bugs.webkit.org/show_bug.cgi?id=196588
903         <rdar://problem/49365787>
904
905         Unreviewed build fix for Windows port.
906
907         error C3861: 'kill': identifier not found
908
909         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
910         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
911
912 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
913
914         [ews-build] Cancel build and similar operations should have authentication
915         https://bugs.webkit.org/show_bug.cgi?id=196520
916
917         Reviewed by Dewei Zhu.
918
919         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
920         environment variables.
921
922 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
923
924         [ews-build] Do not trigger queues which are not in production yet
925         https://bugs.webkit.org/show_bug.cgi?id=196581
926
927         Reviewed by Dewei Zhu.
928
929         * BuildSlaveSupport/ews-build/config.json:
930
931 2019-04-03  Chris Dumez  <cdumez@apple.com>
932
933         Unreviewed, fix typo in the name of API test added in r243848.
934
935         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
936         (TestWebKitAPI::TEST):
937
938 2019-04-03  Chris Dumez  <cdumez@apple.com>
939
940         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
941         https://bugs.webkit.org/show_bug.cgi?id=196588
942         <rdar://problem/49365787>
943
944         Reviewed by Ryosuke Niwa.
945
946         Add API test coverage.
947
948         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
949         (TestWebKitAPI::nullJavaScriptCallback):
950         (TestWebKitAPI::didCrashCheckFrames):
951         (TestWebKitAPI::TEST):
952
953 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
954
955         run-webkit-tests: Upload test results (new results database)
956         https://bugs.webkit.org/show_bug.cgi?id=196577
957         <rdar://problem/34841155>
958
959         Reviewed by Lucas Forschler.
960
961         * Scripts/webkitpy/layout_tests/controllers/manager.py:
962         (Manager.run): Upload results after each device shard, since the configuration will be
963         different for each device.
964         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
965         uploaded to a results database.
966         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
967         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
968
969 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
970
971         -apple-trailing-word is needed for browser detection
972         https://bugs.webkit.org/show_bug.cgi?id=196575
973
974         Unreviewed.
975
976         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
977
978 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
979
980         [CMake][WTF] Mirror XCode header directories
981         https://bugs.webkit.org/show_bug.cgi?id=191662
982
983         Reviewed by Konstantin Tokarev.
984
985         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
986         builds.
987
988         * CMakeLists.txt:
989         * DumpRenderTree/CMakeLists.txt:
990         * DumpRenderTree/PlatformWin.cmake:
991         * MiniBrowser/win/CMakeLists.txt:
992         * TestWebKitAPI/CMakeLists.txt:
993         * TestWebKitAPI/PlatformWin.cmake:
994         * WebKitTestRunner/PlatformGTK.cmake:
995         * WebKitTestRunner/PlatformWin.cmake:
996
997 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
998
999         [ews-app] Status bubble should not display certain infrastructure status messages
1000         https://bugs.webkit.org/show_bug.cgi?id=196550
1001
1002         Reviewed by Lucas Forschler.
1003
1004         Do not display the steps which are un-needed for end-user. This information is still avaiable
1005         if the user click on the bubble and look at the Buildbot build.
1006         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1007         (StatusBubble._steps_messages):
1008         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1009
1010 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1011
1012         [ews-build] Use https for sending data to ews-app
1013         https://bugs.webkit.org/show_bug.cgi?id=196492
1014
1015         Reviewed by Lucas Forschler.
1016
1017         * BuildSlaveSupport/ews-build/events.py:
1018
1019 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1020
1021         Remove support for -apple-trailing-word
1022         https://bugs.webkit.org/show_bug.cgi?id=196525
1023
1024         Reviewed by Zalan Bujtas.
1025
1026         This CSS property is nonstandard and not used.
1027
1028         * Scripts/webkitperl/FeatureList.pm:
1029         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1030
1031 2019-04-03  Youenn Fablet  <youenn@apple.com>
1032
1033         Add a test for DOMCache on multiple browsing in case of private browsing
1034         https://bugs.webkit.org/show_bug.cgi?id=196524
1035
1036         Reviewed by Alex Christensen.
1037
1038         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1039         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1040
1041 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1042
1043         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1044         https://bugs.webkit.org/show_bug.cgi?id=196540
1045
1046         Reviewed by Aakash Jain.
1047
1048         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1049
1050 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1051
1052         Add plumbing for a compatibility mode preference in WebKit
1053         https://bugs.webkit.org/show_bug.cgi?id=196005
1054
1055         Reviewed by Tim Horton.
1056
1057         Add new API tests.
1058
1059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1060         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1061
1062 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1063
1064         [WPE][GTK] Update libsrtp dependency package for Debian
1065         https://bugs.webkit.org/show_bug.cgi?id=196528
1066
1067         Reviewed by Frédéric Wang.
1068
1069         * gtk/install-dependencies:
1070         * wpe/install-dependencies:
1071
1072 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1073
1074         [WK2] Add support for Window's beforeprint / afterprint events
1075         https://bugs.webkit.org/show_bug.cgi?id=196478
1076         <rdar://problem/49535124>
1077
1078         Unreviewed build fix for MSVC.
1079
1080         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1081
1082         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1083
1084         * WebKitTestRunner/TestController.cpp:
1085         (WTR::printFrame): Use int and float literals.
1086
1087 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1088
1089         [ews-build] Reassign bots to queues
1090
1091         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1092
1093 2019-04-02  Chris Dumez  <cdumez@apple.com>
1094
1095         [WK2] Add support for Window's beforeprint / afterprint events
1096         https://bugs.webkit.org/show_bug.cgi?id=196478
1097
1098         Reviewed by Alex Christensen.
1099
1100         Add minimal implementation for printFrame in WebKitTestRunner.
1101
1102         * WebKitTestRunner/TestController.cpp:
1103         (WTR::printFrame):
1104         (WTR::TestController::createOtherPage):
1105         (WTR::TestController::createWebViewWithOptions):
1106
1107 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1108
1109         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1110         https://bugs.webkit.org/show_bug.cgi?id=196491
1111
1112         Reviewed by Lucas Forschler.
1113
1114         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1115
1116 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1117
1118         [ews-build] Configure buildbot try credentials in environment variables
1119         https://bugs.webkit.org/show_bug.cgi?id=196501
1120
1121         Reviewed by Lucas Forschler.
1122
1123         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1124         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1125         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1126
1127 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1128
1129         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1130         https://bugs.webkit.org/show_bug.cgi?id=196496
1131         <rdar://problem/49521634>
1132
1133         Reviewed by Chris Dumez.
1134
1135         Add new API tests (see WebKit ChangeLog for more detail).
1136
1137         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1138         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1139         (TEST):
1140
1141 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1142
1143         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1144         <https://webkit.org/b/196499>
1145
1146         Reviewed by Alexey Proskuryakov.
1147
1148         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1149         ENABLE_ADDRESS_SANITIZER.
1150
1151 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1152
1153         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1154         https://bugs.webkit.org/show_bug.cgi?id=182757
1155
1156         Reviewed by Don Olmstead.
1157
1158         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1159         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1160
1161 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1162
1163         run-api-tests: Upload test results
1164         https://bugs.webkit.org/show_bug.cgi?id=196323
1165         <rdar://problem/49356714>
1166
1167         Reviewed by Lucas Forschler.
1168
1169         * Scripts/webkitpy/api_tests/manager.py:
1170         (Manager):
1171         (Manager.run): Upload results to a results database.
1172         * Scripts/webkitpy/api_tests/run_api_tests.py:
1173         (parse_args): Add upload arguments.
1174         * Scripts/webkitpy/port/base.py:
1175         (Port):
1176         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1177         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1178         with commits from any other associated repositories.
1179         * Scripts/webkitpy/port/device.py:
1180         (Device):
1181         (Device.build_version): Access build_versoin of underlying platform device.
1182         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1183         (IOSSimulatorTest):
1184         (IOSSimulatorTest.test_configuration_for_upload):
1185         * Scripts/webkitpy/port/device_port.py:
1186         (DevicePort):
1187         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1188         the same as the machine uploading results.
1189         * Scripts/webkitpy/port/mac.py:
1190         (MacPort):
1191         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1192         * Scripts/webkitpy/port/mac_unittest.py:
1193         (MacTest):
1194         (MacTest.test_configuration_for_upload):
1195         * Scripts/webkitpy/xcode/simulated_device.py:
1196         (SimulatedDeviceManager._create_device_with_runtime):
1197         (SimulatedDevice.__init__): Create simulated device with a build_version.
1198         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1199         (test_existing_simulator):
1200
1201 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1202
1203         Remove extra newline characters (Follow-up fix to r243707)
1204
1205         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1206
1207 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1208
1209         [ews-app] Use API_KEY to accept results data
1210         https://bugs.webkit.org/show_bug.cgi?id=196461
1211
1212         Reviewed by Dewei Zhu.
1213
1214         * BuildSlaveSupport/ews-app/ews/views/results.py:
1215         (Results.post): Validate EWS_API_KEY before accepting any data.
1216         * BuildSlaveSupport/ews-build/events.py:
1217         (Events.sendData): Send EWS_API_KEY if available along with event data.
1218
1219 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1220
1221         Unable to copy and paste a PDF from Notes into Mail compose body
1222         https://bugs.webkit.org/show_bug.cgi?id=196442
1223         <rdar://problem/48573098>
1224
1225         Reviewed by Tim Horton.
1226
1227         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1228         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1229         to be specified on the item providers.
1230
1231         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1232         (TestWebKitAPI::mapItemForTesting):
1233         (TestWebKitAPI::contactItemForTesting):
1234
1235 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1236
1237         Make UIWKDocumentContext rects per-character instead of per-word
1238         https://bugs.webkit.org/show_bug.cgi?id=196459
1239
1240         Reviewed by Wenson Hsieh.
1241
1242         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1243         (TEST):
1244         Adjust test results due to switching to per-character rects.
1245
1246 2019-04-01  Chris Dumez  <cdumez@apple.com>
1247
1248         UIProcess crash when a prewarmed process is terminated
1249         https://bugs.webkit.org/show_bug.cgi?id=196451
1250         <rdar://problem/49245471>
1251
1252         Reviewed by Geoffrey Garen.
1253
1254         Add API test coverage.
1255
1256         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1257         (TEST):
1258
1259 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1260
1261         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1262         https://bugs.webkit.org/show_bug.cgi?id=196449
1263
1264         Reviewed by Lucas Forschler.
1265
1266         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1267         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1268         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1269         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1270
1271 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1272
1273         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1274         https://bugs.webkit.org/show_bug.cgi?id=196444
1275
1276         Reviewed by Lucas Forschler.
1277
1278         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1279
1280 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1281
1282         Add SPI to canonicalize NSURLs with WTF::URL
1283         https://bugs.webkit.org/show_bug.cgi?id=196415
1284         <rdar://problem/44980271>
1285
1286         Reviewed by Darin Adler.
1287
1288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1289         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1290         (TestWebKitAPI::TEST):
1291
1292 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1293
1294         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1295         https://bugs.webkit.org/show_bug.cgi?id=196441
1296
1297         Reviewed by Carlos Garcia Campos.
1298
1299         Don't cache the wpe_view_backend object that might not exist yet at the
1300         time of EventSenderProxy constructor invocation, but instead retrieve
1301         that object whenever it's required for event dispatching. This should
1302         avoid crashes in this constructor now that it's invoked before any
1303         PlatformWindow has been set up (as changed in r243496).
1304
1305         * WebKitTestRunner/EventSenderProxy.h:
1306         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1307         (WTR::viewBackend):
1308         (WTR::EventSenderProxy::EventSenderProxy):
1309         (WTR::EventSenderProxy::mouseDown):
1310         (WTR::EventSenderProxy::mouseUp):
1311         (WTR::EventSenderProxy::mouseMoveTo):
1312         (WTR::EventSenderProxy::mouseScrollBy):
1313         (WTR::EventSenderProxy::keyDown):
1314         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1315
1316 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1317
1318         [Win][WebKit] MiniBrowser should support high DPI display
1319         https://bugs.webkit.org/show_bug.cgi?id=196391
1320
1321         Reviewed by Alex Christensen.
1322
1323         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1324         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1325         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1326         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1327
1328 2019-03-31  Sam Weinig  <weinig@apple.com>
1329
1330         Remove more i386 specific configurations
1331         https://bugs.webkit.org/show_bug.cgi?id=196430
1332
1333         Reviewed by Alexey Proskuryakov.
1334
1335         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1336         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1337
1338 2019-03-31  Andy Estes  <aestes@apple.com>
1339
1340         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1341         https://bugs.webkit.org/show_bug.cgi?id=196433
1342         <rdar://problem/49293305>
1343
1344         Reviewed by Tim Horton.
1345
1346         Enhanced API test coverage to include all navigation response policy decisions in both
1347         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1348
1349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1350         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1351         (TestWebKitAPI::TEST):
1352         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1353         (readFile):
1354         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1355         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1356         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1357         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1358         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1359         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1360         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1361         (-[QuickLookDelegate _downloadDidStart:]):
1362         (-[QuickLookDelegate _download:didReceiveResponse:]):
1363         (-[QuickLookDelegate _download:didReceiveData:]):
1364         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1365         (-[QuickLookDelegate _downloadDidFinish:]):
1366         (-[QuickLookDelegate _download:didFailWithError:]):
1367         (-[QuickLookDelegate _downloadDidCancel:]):
1368         (-[QuickLookDelegate verifyDownload]):
1369         (runTest):
1370         (runTestDecideBeforeLoading):
1371         (runTestDecideAfterLoading):
1372         (TEST):
1373         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1374         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1375         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1376         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1377         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1378         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1379         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1380         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1381         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1382         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1383         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1384         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1385         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1386         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1387
1388 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1389
1390         [CMake] add testdfg as target with build-jsc
1391         https://bugs.webkit.org/show_bug.cgi?id=196393
1392
1393         Reviewed by Saam Barati.
1394
1395         Added testdfg as one of the targets to build when
1396         using CMake.
1397
1398         * Scripts/build-jsc:
1399
1400 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1401
1402         Delete WebMetal implementation in favor of WebGPU
1403         https://bugs.webkit.org/show_bug.cgi?id=195418
1404
1405         Reviewed by Dean Jackson.
1406
1407         * DumpRenderTree/mac/DumpRenderTree.mm:
1408         (enableExperimentalFeatures):
1409         (resetWebPreferencesToConsistentValues):
1410         * Scripts/webkitperl/FeatureList.pm:
1411         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1413         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1414         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1415         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1416         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1417         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1418         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1419         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1420         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1421         (WTR::InjectedBundle::beginTesting):
1422         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1423         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1424         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1425
1426 2019-03-29  Chris Dumez  <cdumez@apple.com>
1427
1428         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1429         https://bugs.webkit.org/show_bug.cgi?id=196405
1430         <rdar://problem/49428130>
1431
1432         Reviewed by Wenson Hsieh.
1433
1434         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1435         the popover presentation methods to be no-ops. Use this in the new test added in
1436         r243523 so that we do not swizzle those methods for all tests. This is needed because
1437         those WatchOS tests rely on the popover getting presented and interactive.
1438
1439         * WebKitTestRunner/TestController.cpp:
1440         (WTR::updateTestOptionsFromTestHeader):
1441         * WebKitTestRunner/TestController.h:
1442         * WebKitTestRunner/TestOptions.h:
1443         (WTR::TestOptions::hasSameInitializationOptions const):
1444         * WebKitTestRunner/ios/TestControllerIOS.mm:
1445         (WTR::TestController::platformInitialize):
1446         (WTR::TestController::platformResetStateToConsistentValues):
1447
1448 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1449
1450         [Curl] Add Server Trust Evaluation Support.
1451         https://bugs.webkit.org/show_bug.cgi?id=191646
1452
1453         Reviewed by Fujii Hironori.
1454
1455         Implemented MiniBrowser UI for asking if user trusts the server.
1456
1457         * MiniBrowser/win/Common.cpp:
1458         (askServerTrustEvaluation):
1459         (replaceString):
1460         * MiniBrowser/win/Common.h:
1461         * MiniBrowser/win/MiniBrowserLib.rc:
1462         * MiniBrowser/win/MiniBrowserLibResource.h:
1463         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1464         (createPEMString):
1465         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1466         (WebKitBrowserWindow::canTrustServerCertificate):
1467         * MiniBrowser/win/WebKitBrowserWindow.h:
1468
1469 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1470
1471         Implement ResizeObserver.
1472         https://bugs.webkit.org/show_bug.cgi?id=157743
1473
1474         Reviewed by Simon Fraser.
1475
1476         Support resizeObserverEnabled webPreferences.
1477
1478         * DumpRenderTree/TestOptions.cpp:
1479         (TestOptions::TestOptions):
1480         * DumpRenderTree/TestOptions.h:
1481         * DumpRenderTree/mac/DumpRenderTree.mm:
1482         (setWebPreferencesForTestOptions):
1483         * DumpRenderTree/win/DumpRenderTree.cpp:
1484         (enableExperimentalFeatures):
1485         * Scripts/webkitperl/FeatureList.pm:
1486         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1487
1488 2019-03-28  John Wilander  <wilander@apple.com>
1489
1490         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1491         https://bugs.webkit.org/show_bug.cgi?id=196281
1492         <rdar://problem/48938748>
1493
1494         Reviewed by Alex Christensen.
1495
1496         This patch adds the function isStatisticsHasLocalStorage() to the
1497         TestRunner. With it, the page can query the WebsiteDataStore in the
1498         UI process to make sure that it sees LocalStorage.
1499
1500         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1501         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1502         (WTR::TestRunner::isStatisticsHasLocalStorage):
1503         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1504         * WebKitTestRunner/TestController.cpp:
1505         (WTR::TestController::isStatisticsHasLocalStorage):
1506         * WebKitTestRunner/TestController.h:
1507         * WebKitTestRunner/TestInvocation.cpp:
1508         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1509
1510 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1511
1512         API::Data::createWithoutCopying should do a null check before calling CFRelease
1513         https://bugs.webkit.org/show_bug.cgi?id=196276
1514         <rdar://problem/48059859>
1515
1516         Reviewed by Alex Christensen.
1517
1518         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1519
1520         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1521         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1522         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1523         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1524         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1525         (TestWebKitAPI::TEST):
1526
1527 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1528
1529         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1530         https://bugs.webkit.org/show_bug.cgi?id=186276
1531
1532         Reviewed by Carlos Garcia Campos.
1533
1534         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1535         (webViewLoadChanged):
1536         (testWebResourceGetDataError):
1537         (testWebResourceGetDataEmpty):
1538         (beforeAll):
1539         (webViewloadChanged): Deleted.
1540
1541 2019-03-27  Andy Estes  <aestes@apple.com>
1542
1543         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1544         https://bugs.webkit.org/show_bug.cgi?id=196317
1545
1546         Reviewed by Dan Bernstein.
1547
1548         package-root copies built products into a staging directory using ditto(1), which does not
1549         follow symbolic links as it traverses a directory. Now that the files in
1550         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1551         itself, these become broken links when ditto'd into the staging directory.
1552
1553         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1554
1555         * Scripts/package-root:
1556
1557 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1558
1559         [ews-app] Update display text of Submit for ews analysis
1560         https://bugs.webkit.org/show_bug.cgi?id=196309
1561
1562         Reviewed by Dewei Zhu.
1563
1564         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1565
1566 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1567
1568         run-webkit-tests should check for leaks in WebKit processes
1569         <https://webkit.org/b/193772>
1570         <rdar://problem/46526680>
1571
1572         Reviewed by Ryosuke Niwa.
1573
1574         This works by doing the following:
1575         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1576           The list of child processes are returned one per line:
1577           process.name: pid
1578         - Run the "#LIST CHILD PROCESSES" command just before the
1579           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1580           processes on the ServerProcess object.
1581         - When the `--leaks` switch is handled, run check_for_leaks() on
1582           each child process after the main test harness.
1583
1584         * DumpRenderTree/mac/DumpRenderTree.mm:
1585         (handleControlCommand):
1586         - Use strncmp() instead of strcmp().
1587         - Add support for handling "#LIST CHILD PROCESSES" command.
1588
1589         * Scripts/webkitpy/port/base.py:
1590         (Port.check_for_leaks):
1591         * Scripts/webkitpy/port/darwin.py:
1592         (DarwinPort.check_for_leaks):
1593         - Rename redundant 'process_pid' argument to 'process_id'.
1594
1595         * Scripts/webkitpy/port/driver.py:
1596         (Driver.do_post_tests_work):
1597         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1598           longer the only command this sends to WebKitTestRunner.
1599         - If the `--leaks` switch is present, send the
1600           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1601           result using Port.set_webkit_processes().
1602         (Driver._parse_child_processes_output):
1603         - Add helper method to parse list of child process names and
1604           process IDs returned from WebKitTestRunner.
1605
1606         * Scripts/webkitpy/port/ios_device.py:
1607         (IOSDevicePort.check_for_leaks):
1608         - Rename redundant 'process_pid' argument to 'process_id'.
1609
1610         * Scripts/webkitpy/port/leakdetector.py:
1611         (LeakDetector._parse_leaks_output):
1612         - Return early if there is no leaks_output.
1613         (LeakDetector.check_for_leaks):
1614         - Rename redundant 'process_pid' argument to 'process_id'.
1615
1616         * Scripts/webkitpy/port/server_process.py:
1617         (ServerProcess.__init__):
1618         (ServerProcess.child_processes):
1619         (ServerProcess.set_child_processes):
1620         - Add instance variable to Port to store list of child process
1621           names and process IDs returned from WebKitTestRunner.
1622         (ServerProcess._start):
1623         - Clear self._child_processes.
1624         (ServerProcess.stop):
1625         - If self._child_processes is set, call
1626           self._port.check_for_leaks() for each child process.
1627
1628         * Scripts/webkitpy/port/server_process_unittest.py:
1629         (TrivialMockPort.check_for_leaks):
1630         - Rename redundant 'process_pid' argument to 'process_id'.
1631
1632         * Scripts/webkitpy/port/simulator_process.py:
1633         (SimulatorProcess.stop):
1634         - If self._child_processes is set, call
1635           self._port.check_for_leaks() for each child process.
1636
1637         * Scripts/webkitpy/port/watch_device.py:
1638         (WatchDevicePort.check_for_leaks):
1639         - Rename redundant 'process_pid' argument to 'process_id'.
1640
1641         * WebKitTestRunner/TestController.cpp:
1642         (WTR::TestController::dumpResponse):
1643         - Extract method from findAndDumpWorldLeaks() so that it may be
1644           reused by findAndDumpWebKitProcessIdentifiers().
1645         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1646         - Add method to output process name and process ID of both the
1647           WebContent and Networking processes.
1648         (WTR::TestController::findAndDumpWorldLeaks):
1649         - Fix missing newline in output when there were no abandoned
1650           documents.
1651         - Call dumpResponse() for extracted code.
1652         (WTR::TestController::handleControlCommand):
1653         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1654         - Use strncmp() instead of strcmp().
1655         - Call findAndDumpWebKitProcessIdentifiers() when
1656           "#LIST CHILD PROCESSES" command is sent.
1657         * WebKitTestRunner/TestController.h:
1658         (WTR::TestController::dumpResponse):
1659         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1660         - Declare methods.
1661
1662 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1663
1664         Unreviewed. Add GLib API test cases after r243434.
1665
1666         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1667         (testWebViewActiveURI):
1668         (serverCallback):
1669         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1670         (sendRequestCallback):
1671
1672 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1673
1674         Geolocation request not complete when watch request was started in a different web process
1675         https://bugs.webkit.org/show_bug.cgi?id=195996
1676
1677         Reviewed by Alex Christensen.
1678
1679         Add a test case.
1680
1681         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1682         (TestWebKitAPI::runJavaScriptAlert):
1683         (TestWebKitAPI::TEST):
1684
1685 2019-03-26  Keith Rollin  <krollin@apple.com>
1686
1687         Update the way generate-xcfilelists returns strings from functions
1688         https://bugs.webkit.org/show_bug.cgi?id=195975
1689         <rdar://problem/49040807>
1690
1691         Reviewed by Dean Jackson.
1692
1693         There are places where generate-xcfilelists executes assignments with
1694         statements like:
1695
1696             FOO=$(some_function)
1697
1698         where "some_function" return a string by echoing it. E.g.
1699
1700             some_function()
1701             {
1702                 echo "Hello, World"
1703             }
1704
1705         This is a common idiom, but it has a problem if "some_function" needs
1706         to call "exit" in an attempt to halt the entire script right then and
1707         there. Since "some_function" is called inside of $(), it's being
1708         executed in a sub-shell. Calling exit in that sub-shell simply exits
1709         that shell; it doesn't not exit the outer shell in which the main part
1710         of the script is still running. As such, the main script keeps
1711         executing when the intent was for the script to halt.
1712
1713         The solution to this is to use a different idiom for returning
1714         strings. The one we now is to pass in the name of the variable to
1715         receive the string result:
1716
1717             some_function()
1718             {
1719                 variable_name=$1
1720                 eval $variable_name ="Hello, World"
1721             }
1722
1723         The call site now looks like
1724
1725             some_function FOO
1726
1727         Because there's no invocation of a sub-shell, some_function can now
1728         call "exit" if it wants to, and the entire script will exit at that
1729         point.
1730
1731         * Scripts/generate-xcfilelists:
1732
1733 2019-03-26  Chris Dumez  <cdumez@apple.com>
1734
1735         Add basic layout test coverage for File Picker on iOS
1736         https://bugs.webkit.org/show_bug.cgi?id=196265
1737
1738         Reviewed by Wenson Hsieh.
1739
1740         Add layout test infrastructure to test the file picker on iOS.
1741
1742         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1743         (WTR::UIScriptController::dismissFilePicker):
1744         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1745         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1746         (WTR::UIScriptController::dismissFilePicker):
1747         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1748         * WebKitTestRunner/TestController.cpp:
1749         (WTR::TestController::createWebViewWithOptions):
1750         (WTR::updateTestOptionsFromTestHeader):
1751         * WebKitTestRunner/TestOptions.h:
1752         (WTR::TestOptions::hasSameInitializationOptions const):
1753         * WebKitTestRunner/ios/TestControllerIOS.mm:
1754         (overridePresentViewController):
1755         (WTR::TestController::platformInitialize):
1756         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1757         (WTR::UIScriptController::dismissFilePicker):
1758
1759 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1760
1761         Implement async paste method on UIWKInteractionViewProtocol
1762         https://bugs.webkit.org/show_bug.cgi?id=196267
1763         <rdar://problem/49236346>
1764
1765         Reviewed by Tim Horton.
1766
1767         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1768         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1769         are now a part of all iOS 12 internal SDKs.
1770
1771         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1772
1773         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1774         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1775
1776         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1777         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1778         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1779         * TestWebKitAPI/ios/UIKitSPI.h:
1780
1781 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1782
1783         [ews-build] Use PostgreSQL for ews.webkit.org database
1784         https://bugs.webkit.org/show_bug.cgi?id=196270
1785
1786         Reviewed by Lucas Forschler.
1787
1788         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1789
1790 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1791
1792         [ews] Reset simctl states on reboot
1793         https://bugs.webkit.org/show_bug.cgi?id=196260
1794
1795         Rubber-stamped by Aakash Jain.
1796
1797         * EWSTools/start-queue-mac.sh:
1798
1799 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1800
1801         [ews-build] Use PostgreSQL for ews-build database
1802         https://bugs.webkit.org/show_bug.cgi?id=196229
1803
1804         Reviewed by Lucas Forschler.
1805
1806         * BuildSlaveSupport/ews-build/master.cfg:
1807
1808 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1809
1810         [ews-build] Get master_hostname dynamically in master.cfg
1811         https://bugs.webkit.org/show_bug.cgi?id=196255
1812
1813         Reviewed by Lucas Forschler.
1814
1815         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1816         send events data in test mode.
1817
1818 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1819
1820         [ews-app] Set db_constraint to False for Foreign Keys
1821         https://bugs.webkit.org/show_bug.cgi?id=196252
1822
1823         Reviewed by Lucas Forschler.
1824
1825         * BuildSlaveSupport/ews-app/ews/models/build.py:
1826         * BuildSlaveSupport/ews-app/ews/models/step.py:
1827
1828 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1829
1830         [ews-build] is_test_mode_enabled should default to True
1831         https://bugs.webkit.org/show_bug.cgi?id=196248
1832
1833         Reviewed by Lucas Forschler.
1834
1835         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1836
1837 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1838
1839         [ews-app] Add webkitperl to ENABLED_QUEUES
1840         https://bugs.webkit.org/show_bug.cgi?id=196253
1841
1842         Reviewed by Lucas Forschler.
1843
1844         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1845
1846 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1847
1848         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1849         https://bugs.webkit.org/show_bug.cgi?id=196211
1850         rdar://problem/49110552
1851
1852         Reviewed by Tim Horton.
1853
1854         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1855         Make sure that EventSenderProxy always exists when running tests. We used to create
1856         it when resetting before the first test, which is a bit too late.
1857
1858         * WebKitTestRunner/TestController.h:
1859         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1860         (WTR::TestController::platformCreateWebView):
1861         (WTR::TestController::platformCreateOtherPage):
1862         (WTR::TestController::finishCreatingPlatformWebView):
1863         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1864         (WTR::PlatformWebView::PlatformWebView):
1865         Moved some code that made NSWindow use NSEvent during web view creation. We may
1866         need to move more if some other case us found, but this is enough for now.
1867
1868 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1869
1870         Unreviewed. Fix typo in GLib geolocation API after r243285.
1871
1872         gelocation -> geolocation.
1873
1874         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1875         (testGeolocationManagerWatchPosition):
1876
1877 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1878
1879         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1880         https://bugs.webkit.org/show_bug.cgi?id=196213
1881
1882         Reviewed by Geoff Garen.
1883
1884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1885         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1886         (credentialWithIdentityAndKeychainPath):
1887         (-[ChallengeDelegate webView:didFinishNavigation:]):
1888         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1889         (TestWebKitAPI::TEST):
1890
1891 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1892
1893         Expected shouldn't assume its contained types are copyable
1894         https://bugs.webkit.org/show_bug.cgi?id=195986
1895
1896         Reviewed by JF Bastien.
1897
1898         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1899         (TestWebKitAPI::NonCopyable::operator== const):
1900         (TestWebKitAPI::NonCopyable::operator!= const):
1901         (TestWebKitAPI::TEST):
1902
1903 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1904
1905         Remove some now-unnecessary dynamic class lookup
1906         https://bugs.webkit.org/show_bug.cgi?id=196237
1907
1908         Reviewed by Simon Fraser.
1909
1910         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1911         (makeRequest):
1912         (TEST):
1913
1914 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1915
1916         Unreviewed, rolling out r243450.
1917
1918         AppleWin and WinCairo port builds get broken.
1919
1920         Reverted changeset:
1921
1922         "Add test for fix of #196095"
1923         https://bugs.webkit.org/show_bug.cgi?id=196097
1924         https://trac.webkit.org/changeset/243450
1925
1926 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1927
1928         Unreviewed, rolling out r243465.
1929         https://bugs.webkit.org/show_bug.cgi?id=196226
1930
1931         the test doesn't build (Requested by thorton on #webkit).
1932
1933         Reverted changeset:
1934
1935         "Do not terminate the NetworkProcess if a third party
1936         application sends a NSCredential with a SecIdentityRef"
1937         https://bugs.webkit.org/show_bug.cgi?id=196213
1938         https://trac.webkit.org/changeset/243465
1939
1940 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1941
1942         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1943         https://bugs.webkit.org/show_bug.cgi?id=196213
1944
1945         Reviewed by Geoff Garen.
1946
1947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1948         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1949         (credentialWithIdentityAndKeychainPath):
1950         (-[ChallengeDelegate webView:didFinishNavigation:]):
1951         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1952         (TestWebKitAPI::TEST):
1953
1954 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1955
1956         [ews-build] Gracefully handle missing patch_id in events
1957         https://bugs.webkit.org/show_bug.cgi?id=196216
1958
1959         Reviewed by Lucas Forschler.
1960
1961         * BuildSlaveSupport/ews-build/events.py:
1962
1963 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1964
1965         [ews-build] use lz4 compression for improving buildbot performance
1966         https://bugs.webkit.org/show_bug.cgi?id=196155
1967
1968         Reviewed by Lucas Forschler.
1969
1970         * BuildSlaveSupport/ews-build/master.cfg:
1971
1972 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1973
1974         Pull some API testing helper methods out of TestWKWebView
1975         https://bugs.webkit.org/show_bug.cgi?id=196212
1976
1977         Reviewed by Tim Horton.
1978
1979         Refactor some more API testing utility methods, so that they can be used in
1980         tests that do not use TestWKWebView.
1981
1982         * TestWebKitAPI/cocoa/TestWKWebView.h:
1983         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1984         (-[WKWebView loadTestPageNamed:]):
1985         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1986         (-[WKWebView synchronouslyLoadHTMLString:]):
1987         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1988         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1989         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1990         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1991         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1992
1993 2019-03-25  Jer Noble  <jer.noble@apple.com>
1994
1995         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1996         https://bugs.webkit.org/show_bug.cgi?id=196097
1997
1998         Reviewed by Eric Carlson.
1999
2000         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2001
2002         * DumpRenderTree/mac/DumpRenderTree.mm:
2003         (resetWebPreferencesToConsistentValues):
2004         * WebKitTestRunner/TestController.cpp:
2005         (WTR::TestController::resetPreferencesToConsistentValues):
2006
2007 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2008
2009         Pull IPadUserInterfaceSwizzler out into a separate header file
2010         https://bugs.webkit.org/show_bug.cgi?id=196193
2011
2012         Reviewed by Anders Carlsson.
2013
2014         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2015         be used in other API tests.
2016
2017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2018         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2019         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2020         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2021         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2022         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2023         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2024
2025 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2026
2027         Remove NavigatorContentUtils in WebCore/Modules
2028         https://bugs.webkit.org/show_bug.cgi?id=196070
2029
2030         Reviewed by Alex Christensen.
2031
2032         NavigatorContentUtils was to support the custom scheme spec [1].
2033         However, in WebKit side, no port has supported the feature in
2034         WebKit layer after EFL port was removed. So there has been the
2035         only IDL implementation of the NavigatorContentUtils in WebCore.
2036         So we don't need to keep the implementation in WebCore anymore.
2037
2038         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2039
2040         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2041
2042 2019-03-24  Andy Estes  <aestes@apple.com>
2043
2044         [watchOS] Remove unused Proximity Networking code
2045         https://bugs.webkit.org/show_bug.cgi?id=196188
2046
2047         Reviewed by Tim Horton.
2048
2049         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2050         (TEST):
2051
2052 2019-03-23  Keith Miller  <keith_miller@apple.com>
2053
2054         Refactor clz/ctz and fix getLSBSet.
2055         https://bugs.webkit.org/show_bug.cgi?id=196162
2056
2057         Reviewed by Saam Barati.
2058
2059         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2060
2061         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2062         (TestWebKitAPI::TEST):
2063
2064 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2065
2066         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2067         https://bugs.webkit.org/show_bug.cgi?id=196143
2068
2069         Reviewed by Michael Catanzaro.
2070
2071         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2072         directories.
2073
2074         * Scripts/webkitpy/style/checkers/cpp.py:
2075         (check_identifier_name_in_declaration):
2076         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2077         (WebKitStyleTest.test_names):
2078
2079 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2080
2081         [Flatpak] Manifest expanding fails for qt WPE extension
2082         https://bugs.webkit.org/show_bug.cgi?id=196148
2083
2084         Reviewed by Alex Christensen.
2085
2086         * flatpak/flatpakutils.py:
2087         (expand_submodules_recurse): The last recurse manifest expand
2088         iteration might lead to a single module so take it into account
2089         and don't try to recurse further.
2090
2091 2019-03-22  Chris Dumez  <cdumez@apple.com>
2092
2093         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2094         https://bugs.webkit.org/show_bug.cgi?id=195348
2095         <rdar://problem/48622090>
2096
2097         Reviewed by Alex Christensen.
2098
2099         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2100         to NO when test.options().shouldIgnoreMetaViewport is false.
2101
2102         * WebKitTestRunner/ios/TestControllerIOS.mm:
2103         (WTR::TestController::platformConfigureViewForTest):
2104
2105 2019-03-22  Chris Dumez  <cdumez@apple.com>
2106
2107         Prewarmed processes should be usable with any website data store
2108         https://bugs.webkit.org/show_bug.cgi?id=196104
2109
2110         Reviewed by Alex Christensen.
2111
2112         Add API test coverage.
2113
2114         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2115         (runInitialWarmedProcessUsedTest):
2116         (TEST):
2117
2118 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2119
2120         Back out local changes to Alex's Subversion working directory
2121
2122         They were accidentally committed.
2123
2124         * Scripts/webkitpy/common/system/abstractexecutive.py:
2125         (AbstractExecutive.wait_newest):
2126         * Scripts/webkitpy/common/system/executive.py:
2127         (Executive.running_pids):
2128         * Scripts/webkitpy/common/system/executive_mock.py:
2129         (MockExecutive.running_pids):
2130         * Scripts/webkitpy/common/system/executive_unittest.py:
2131         (ExecutiveTest.serial_test_running_pids):
2132         * Scripts/webkitpy/port/darwin.py:
2133         (DarwinPort.check_for_leaks):
2134         * Scripts/webkitpy/port/leakdetector.py:
2135         (LeakDetector.check_for_leaks):
2136         - This was the hack attached to Bug 193772.
2137
2138         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2139         (+[WebKitTestRunnerEvent mouseLocation]):
2140         - This works around a crash on an internal build.
2141
2142 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2143
2144         Fix the build after r243354
2145         https://bugs.webkit.org/show_bug.cgi?id=196138
2146         <rdar://problem/49145951>
2147
2148         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2149         (TEST):
2150         * TestWebKitAPI/ios/UIKitSPI.h:
2151
2152 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2153
2154         Adopt UIWKDocumentContext
2155         https://bugs.webkit.org/show_bug.cgi?id=196040
2156         <rdar://problem/48642440>
2157
2158         Reviewed by Ryosuke Niwa.
2159
2160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2161         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2162         (makeRequest):
2163         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2164         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2165         (applyStyle):
2166         (TEST):
2167         Add tests for UIWKDocumentContext.
2168
2169         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2170         (TEST):
2171         (recursiveFindWKContentView): Deleted.
2172         * TestWebKitAPI/cocoa/TestWKWebView.h:
2173         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2174         (recursiveFindWKContentView):
2175         (-[TestWKWebView wkContentView]):
2176         * TestWebKitAPI/ios/UIKitSPI.h:
2177         Share the WKContentView finding code between tests.
2178
2179 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2180
2181         [iOS WK2] Turn on async overflow scrolling by default
2182         https://bugs.webkit.org/show_bug.cgi?id=196011
2183         rdar://problem/48453859
2184
2185         Reviewed by Antti Koivisto.
2186         
2187         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2188         since so many basic layout tests have different results when compositing is triggered for
2189         overflow.
2190         
2191         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2192
2193         * WebKitTestRunner/TestController.cpp:
2194         (WTR::TestController::resetPreferencesToConsistentValues):
2195
2196 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2197
2198         [ews-build] Retry API test in case of failures
2199         https://bugs.webkit.org/show_bug.cgi?id=196004
2200
2201         Reviewed by Lucas Forschler.
2202
2203         * BuildSlaveSupport/ews-build/steps.py:
2204         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2205         (CompileWebKitToT.doStepIf): Ditto.
2206         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2207         (ReRunAPITests): Re-run API tests.
2208         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2209         (RunAPITestsWithoutPatch): Run API tests without patch.
2210         (RunAPITestsWithoutPatch.doStepIf):
2211         (RunAPITestsWithoutPatch.hideStepIf):
2212         (RunAPITestsWithoutPatch.evaluateCommand):
2213         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2214         (AnalyzeAPITestsResults.start):
2215         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2216         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2217         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2218         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2219
2220 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2221
2222         [ews-build] Update queues configurations
2223         https://bugs.webkit.org/show_bug.cgi?id=196074
2224
2225         Reviewed by Dewei Zhu.
2226
2227         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2228         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2229
2230 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2231
2232         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2233         https://bugs.webkit.org/show_bug.cgi?id=195680
2234         <rdar://problem/48903534>
2235
2236         Unreviewed infrastructure fix.
2237
2238         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2239         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2240
2241 2019-03-21  Andy Estes  <aestes@apple.com>
2242
2243         [iOS] Apple Pay should be available in documents with no user agent scripts
2244         https://bugs.webkit.org/show_bug.cgi?id=196061
2245         <rdar://problem/48649391>
2246
2247         Reviewed by Brady Eidson.
2248
2249         Added API tests and related infrastructure.
2250
2251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2252         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2253         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2254         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2255         (TestWebKitAPI::TEST):
2256         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2257         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2258         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2259         * TestWebKitAPI/cocoa/TestProtocol.mm:
2260         (-[TestProtocol startLoading]):
2261         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2262         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2263         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2264         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2265
2266 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2267
2268         REGRESSSION (r243297): webkitpy tests broken
2269         https://bugs.webkit.org/show_bug.cgi?id=196108
2270
2271         Reviewed by Aakash Jain.
2272
2273         r243297 updated contributors.json, which broke a few unit tests.
2274
2275         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2276         (IRCCommandTest.test_whois):
2277         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2278
2279 2019-03-21  Chris Dumez  <cdumez@apple.com>
2280
2281         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2282         https://bugs.webkit.org/show_bug.cgi?id=196041
2283         <rdar://problem/49083230>
2284
2285         Reviewed by Alex Christensen.
2286
2287         Add API test coverage.
2288
2289         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2290         (TEST):
2291
2292 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2293
2294         Add SPI to inform applications of WKContentRuleList actions
2295         https://bugs.webkit.org/show_bug.cgi?id=195965
2296         <rdar://problem/42664365>
2297
2298         Reviewed by Geoff Garen.
2299
2300         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2301         (TestWebKitAPI::allActionsForResourceLoad):
2302         (TestWebKitAPI::testRequest):
2303         (TestWebKitAPI::TEST_F):
2304         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2305         (Notification::description):
2306         (Notification::operator== const):
2307         (toVector):
2308         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2309         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2310         (makeContentRuleList):
2311         (TEST):
2312         (makeWarnContentRuleList): Deleted.
2313
2314 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2315
2316         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2317         https://bugs.webkit.org/show_bug.cgi?id=196088
2318
2319         Reviewed by Brian Burg.
2320
2321         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2322         Support checks when only one platform is specified. Also deprecate macosx() and
2323         force the use of macos() instead.
2324
2325         * Scripts/webkitpy/style/checkers/cpp.py:
2326         (check_min_versions_of_wk_api_available):
2327         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2328         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2329
2330 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2331
2332         Update status inactive committers' status to 'contributor'.
2333
2334         * Scripts/webkitpy/common/config/contributors.json:
2335
2336 2019-03-21  Xan Lopez  <xan@igalia.com>
2337
2338         [JSC][x86] Drop support for x87 floating point
2339         https://bugs.webkit.org/show_bug.cgi?id=194853
2340
2341         Reviewed by Don Olmstead.
2342
2343         Force SSE2 on x86/32bit builds.
2344
2345         * Scripts/webkitdirs.pm:
2346         (generateBuildSystemFromCMakeProject):
2347
2348 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2349
2350         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2351         https://bugs.webkit.org/show_bug.cgi?id=196073
2352
2353         Reviewed by Michael Catanzaro.
2354
2355         Add test cases to check functions and constructors with no arguments but receiving user data.
2356
2357         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2358         (checkUserData):
2359         (testJSCFunction):
2360         (fooCreateWithUserData):
2361         (testJSCClass):
2362
2363 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2364
2365         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2366
2367         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2368
2369         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2370
2371 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2372
2373         [GTK][WPE] Add API to provide geolocation information
2374         https://bugs.webkit.org/show_bug.cgi?id=195940
2375
2376         Reviewed by Michael Catanzaro.
2377
2378         Add a new test to check the new API.
2379
2380         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2381         (testGeolocationManagerCurrentPosition):
2382         (testGeolocationManagerWatchPosition):
2383         (beforeAll):
2384         (afterAll):
2385         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2386         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2387         (beforeAll): Ditto.
2388         * TestWebKitAPI/glib/CMakeLists.txt:
2389
2390 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2391
2392         [GLib] Returning G_TYPE_OBJECT from a method does not work
2393         https://bugs.webkit.org/show_bug.cgi?id=195574
2394
2395         Reviewed by Michael Catanzaro.
2396
2397         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2398
2399         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2400         (getGFile):
2401         (getParent):
2402         (createGString):
2403         (getGString):
2404         (getGStringCopyWillRaise):
2405         (getGStringCopy):
2406         (getGStringStr):
2407         (getGStringLen):
2408         (freeGString):
2409         (testJSCClass):
2410
2411 2019-03-20  Saam Barati  <sbarati@apple.com>
2412
2413         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2414         https://bugs.webkit.org/show_bug.cgi?id=195721
2415
2416         Reviewed by Filip Pizlo.
2417
2418         * Scripts/run-javascriptcore-tests:
2419
2420 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2421
2422         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2423         https://bugs.webkit.org/show_bug.cgi?id=196049
2424
2425         Reviewed by Tim Horton.
2426
2427         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2428         overflow scrolling in general, so rename it.
2429
2430         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2431
2432 2019-03-20  Daniel Bates  <dabates@apple.com>
2433
2434         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2435         https://bugs.webkit.org/show_bug.cgi?id=196031
2436         <rdar://problem/49078172>
2437
2438         Reviewed by Tim Horton.
2439
2440         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2441         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2442         same code path used when the Done button is pressed to dismiss the <select> picker.
2443
2444         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2445         (TestWebKitAPI::TEST):
2446
2447 2019-03-20  Chris Dumez  <cdumez@apple.com>
2448
2449         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2450         https://bugs.webkit.org/show_bug.cgi?id=196029
2451         <rdar://problem/48954651>
2452
2453         Reviewed by Tim Horton.
2454
2455         Add API test coverage.
2456
2457         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2458
2459 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2460
2461         [ews-build] Improve failure summary string for ApplyPatch step
2462         https://bugs.webkit.org/show_bug.cgi?id=195995
2463
2464         Reviewed by Alexey Proskuryakov.
2465
2466         * BuildSlaveSupport/ews-build/steps.py:
2467         (ApplyPatch.getResultSummary): Override getResultSummary.
2468
2469 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2470
2471         AX: Implement support for new meter ARIA role
2472         https://bugs.webkit.org/show_bug.cgi?id=195966
2473
2474         Reviewed by Chris Fleizach.
2475
2476         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2477         to AXLevelIndicator.
2478
2479         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2480
2481 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2482
2483         [WebAuthN] Implement FIDO AppID extension
2484         https://bugs.webkit.org/show_bug.cgi?id=143491
2485         <rdar://problem/48298273>
2486
2487         Reviewed by Brent Fulgham.
2488
2489         Add a test that covers the new flag of convertToU2fSignCommand.
2490
2491         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2492         (TestWebKitAPI::TEST):
2493         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2494         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2495         (TestWebKitAPI::TEST):
2496
2497 2019-03-19  Keith Rollin  <krollin@apple.com>
2498
2499         Add support for more platforms to generate-xcfilelists
2500         https://bugs.webkit.org/show_bug.cgi?id=195977
2501
2502         Reviewed by Alexey Proskuryakov.
2503
2504         generate-xcfilelists incorrectly complains when involved with building
2505         WebKit for iphonesimulator:
2506
2507             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2508             …
2509             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2510
2511         Address this by teaching generate-xcfilelists about more platforms.
2512
2513         * Scripts/generate-xcfilelists:
2514
2515 2019-03-19  John Wilander  <wilander@apple.com>
2516
2517         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2518         https://bugs.webkit.org/show_bug.cgi?id=195923
2519         <rdar://problem/49001272>
2520
2521         Reviewed by Alex Christensen.
2522
2523         This patch does the following to the TestRunner:
2524         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2525         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2526         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2527
2528         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2529         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2530         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2531         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2532         * WebKitTestRunner/TestController.cpp:
2533         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2534         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2535         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2536         * WebKitTestRunner/TestController.h:
2537         * WebKitTestRunner/TestInvocation.cpp:
2538         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2539
2540 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2541
2542         [CMake] Support more clang and gcc sanitizers
2543         https://bugs.webkit.org/show_bug.cgi?id=195956
2544
2545         Reviewed by Michael Catanzaro.
2546
2547         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2548
2549 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2550
2551         [ews-build] Improve summary for PrintConfiguration step
2552         https://bugs.webkit.org/show_bug.cgi?id=195945
2553
2554         Reviewed by Lucas Forschler.
2555
2556         * BuildSlaveSupport/ews-build/steps.py:
2557         (PrintConfiguration.getResultSummary): Override getResultSummary.
2558
2559 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2560
2561         [ews-build] Improve summary for CheckOutSource step
2562         https://bugs.webkit.org/show_bug.cgi?id=195963
2563
2564         Reviewed by Lucas Forschler.
2565
2566         * BuildSlaveSupport/ews-build/steps.py:
2567         (CheckOutSource.getResultSummary):
2568
2569 2019-03-19  Daniel Bates  <dabates@apple.com>
2570
2571         [iOS] Focus not preserved when switching between tabs
2572         https://bugs.webkit.org/show_bug.cgi?id=195820
2573         <rdar://problem/43614450>
2574
2575         Reviewed by Brent Fulgham.
2576
2577         Add tests to ensure that we restore focus when resigning and becoming first responder.
2578
2579         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2580         (TestWebKitAPI::TEST):
2581
2582 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2583
2584         Make WTFLogChannelState and WTFLogLevel enum classes
2585         https://bugs.webkit.org/show_bug.cgi?id=195904
2586
2587         Reviewed by Eric Carlson.
2588
2589         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2590         (TestWebKitAPI::TEST_F):
2591
2592 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2593
2594         [GStreamer][EME] Backported mssdemux protection data crash fix
2595         https://bugs.webkit.org/show_bug.cgi?id=195918
2596
2597         Reviewed by Philippe Normand.
2598
2599         * gstreamer/jhbuild.modules:
2600         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2601
2602 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2603
2604         Unreviewed, rolling out r243132.
2605
2606         Broke GTK build
2607
2608         Reverted changeset:
2609
2610         "Make WTFLogChannelState and WTFLogLevel enum classes"
2611         https://bugs.webkit.org/show_bug.cgi?id=195904
2612         https://trac.webkit.org/changeset/243132
2613
2614 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2615
2616         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2617
2618         * Scripts/webkitdirs.pm:
2619         (builtDylibPathForName): Adjust the shared library name that's changed
2620         with the API version bump in r243073.
2621
2622 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2623
2624         Make WTFLogChannelState and WTFLogLevel enum classes
2625         https://bugs.webkit.org/show_bug.cgi?id=195904
2626
2627         Reviewed by Eric Carlson.
2628
2629         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2630         (TestWebKitAPI::TEST_F):
2631
2632 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2633
2634         Disable flaky test added in r2431100
2635         https://webkit.org/b/195785
2636
2637         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2638         (TestWebKitAPI::TEST):
2639         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2640
2641 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2642
2643         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2644         https://bugs.webkit.org/show_bug.cgi?id=195916
2645
2646         Reviewed by Tim Horton.
2647
2648         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2649         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2650
2651 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2652
2653         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2654
2655         * Scripts/webkitpy/common/config/contributors.json:
2656
2657 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2658
2659         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2660         https://bugs.webkit.org/show_bug.cgi?id=195785
2661
2662         Reviewed by Geoffrey Garen.
2663
2664         * TestWebKitAPI/TCPServer.cpp: Added.
2665         (TestWebKitAPI::TCPServer::TCPServer):
2666         (TestWebKitAPI::TCPServer::~TCPServer):
2667         (TestWebKitAPI::TCPServer::socketBindListen):
2668         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2669         * TestWebKitAPI/TCPServer.h: Added.
2670         (TestWebKitAPI::TCPServer::port const):
2671         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2672         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2673         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2674         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2675         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2676         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2677         (TestWebKitAPI::respondSlowly):
2678         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2679         (TestWebKitAPI::downloadAtRate):
2680         (TestWebKitAPI::TEST):
2681
2682 2019-03-18  Saam Barati  <sbarati@apple.com>
2683
2684         Add a plan file for JetStream 2
2685         https://bugs.webkit.org/show_bug.cgi?id=190734
2686
2687         Reviewed by Mark Lam.
2688
2689         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2690
2691 2019-03-18  Chris Dumez  <cdumez@apple.com>
2692
2693         Delay WebProcess launch until a load is triggered in a Web view
2694         https://bugs.webkit.org/show_bug.cgi?id=195758
2695         <rdar://problem/48126013>
2696
2697         Reviewed by Geoff Garen.
2698
2699         Add API test coverage. Also update some existing API tests to not expect
2700         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2701
2702         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2703         (TestWebKitAPI::TEST):
2704         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2705         (TestWebKitAPI::TEST):
2706         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2707         (TEST):
2708         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2709         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2710         (TEST):
2711         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2712         (TEST):
2713         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2714
2715 2019-03-18  Xan Lopez  <xan@igalia.com>
2716
2717         [CMake] Prevent potential warning when determining $architecture
2718         https://bugs.webkit.org/show_bug.cgi?id=195891
2719
2720         Reviewed by Michael Catanzaro.
2721
2722         It's possible for generateBuildSystemForCMakeProject to be called
2723         before determineArchitecture() is ever called. This will make the
2724         first eq check with $architecture to be bogus (and print a
2725         warning). Change that to an eq check with architecture(), which
2726         implicitly calls determineArchitecture() if needed, and change all
2727         the other similar cases in the method in the same way to prevent
2728         future bugs like this one.
2729
2730         * Scripts/webkitdirs.pm:
2731         (generateBuildSystemFromCMakeProject):
2732
2733 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2734
2735         [WPE] Tarballs generated with “make dist” cannot build documentation
2736         https://bugs.webkit.org/show_bug.cgi?id=195885
2737
2738         Reviewed by Carlos Garcia Campos.
2739
2740         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2741
2742 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2743
2744         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2745         https://bugs.webkit.org/show_bug.cgi?id=195883
2746
2747         Reviewed by Carlos Garcia Campos.
2748
2749         * gtkdoc/gtkdoc.py:
2750         (GTKDoc._run_command): When commands fail to run, include the full command line for
2751         the program invocation and the output it has generated on the standard error stream.
2752
2753 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2754
2755         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2756         https://bugs.webkit.org/show_bug.cgi?id=195786
2757
2758         Reviewed by Philippe Normand.
2759
2760         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2761         * wpe/jhbuild.modules: Ditto.
2762
2763 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2764
2765         [ews-build] Don't run clean builds on EWS builders
2766         https://bugs.webkit.org/show_bug.cgi?id=195851
2767
2768         Reviewed by Geoffrey Garen.
2769
2770         * BuildSlaveSupport/ews-build/factories.py:
2771
2772 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2773
2774         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2775         https://bugs.webkit.org/show_bug.cgi?id=195849
2776
2777         Reviewed by Chris Dumez.
2778
2779         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2780
2781         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2782         (runWebsiteDataStoreCustomPaths):
2783
2784 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2785
2786         webkitpy: Upload test results
2787         https://bugs.webkit.org/show_bug.cgi?id=195755
2788         <rdar://problem/48896182>
2789
2790         Reviewed by Aakash Jain.
2791
2792         Establish a new format for uploading results that is not tied to layout tests, apply
2793         that format to webkitpy tests.
2794
2795         * Scripts/webkitpy/common/checkout/scm/git.py:
2796         (Git.native_branch): Return what branch the current checkout is on.
2797         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2798         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2799         * Scripts/webkitpy/common/checkout/scm/svn.py:
2800         (SVN.native_branch): Ditto.
2801         * Scripts/webkitpy/common/system/platforminfo.py:
2802         (PlatformInfo.build_version): Return a build version for Mac.
2803         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2804         (MockPlatformInfo.__init__):
2805         (MockPlatformInfo.build_version):
2806         * Scripts/webkitpy/results: Added.
2807         * Scripts/webkitpy/results/__init__.py: Added.
2808         * Scripts/webkitpy/results/options.py: Added.
2809         (upload_options): OptParse list for upload options.
2810         * Scripts/webkitpy/results/upload.py: Added.
2811         (Upload): Class which enforces the upload format expected by the results server.
2812         (Upload.Expectations):
2813         (Upload.create_configuration):
2814         (Upload.create_commit):
2815         (Upload.create_details):
2816         (Upload.create_run_stats):
2817         (Upload.create_test_result):
2818         (Upload.__init__):
2819         (Upload.Encoder): Encode Upload object as json.
2820         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2821         * Scripts/webkitpy/results/upload_unittest.py: Added.
2822         * Scripts/webkitpy/test/main.py:
2823         (Tester._parse_args): Add upload arguments.
2824         (Tester._run_tests): Allow results to be uploaded.
2825         * Scripts/webkitpy/test/runner.py:
2826         (Runner.__init__): Record which tests were run, rather than just counting them.
2827         (Runner.handle):
2828         * Scripts/webkitpy/test/runner_unittest.py:
2829         (RunnerTest.test_run):
2830         * Scripts/webkitpy/thirdparty/__init__.py:
2831         (AutoinstallImportHook.find_module): Add requests auto-install.
2832         (AutoinstallImportHook._install_requests):
2833         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2834         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2835
2836 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2837
2838         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2839         https://bugs.webkit.org/show_bug.cgi?id=195810
2840
2841         Reviewed by Tim Horton.
2842
2843         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2844         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2845         ending certain layout tests.
2846
2847         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2848         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2849         (-[TestRunnerWKWebView dealloc]):
2850         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2851
2852         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2853         helper method when destroying the web view, and when resetting state between tests.
2854
2855         * WebKitTestRunner/ios/TestControllerIOS.mm:
2856         (WTR::TestController::platformResetStateToConsistentValues):
2857
2858         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2859
2860 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2861
2862         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2863         https://bugs.webkit.org/show_bug.cgi?id=190350
2864         <rdar://problem/45089503>
2865
2866         Reviewed by Geoffrey Garen.
2867
2868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2869         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2870         (TEST):
2871         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2872         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2873         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2874         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2875         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2876         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2877         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2878         (runTest):
2879         (createDirectories):
2880         (TEST):
2881         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2882         (TEST):
2883         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2884         (TEST):
2885
2886 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2887
2888         Add support to WebPage for getting the contents as an attributed string.
2889         https://bugs.webkit.org/show_bug.cgi?id=195636
2890         rdar://problem/45055697
2891
2892         Reviewed by Tim Horton.
2893
2894         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2895         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2896
2897 2019-03-15  Chris Dumez  <cdumez@apple.com>
2898
2899         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2900         https://bugs.webkit.org/show_bug.cgi?id=195747
2901
2902         Reviewed by Geoff Garen.
2903
2904         Add API test coverage.
2905
2906         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2907
2908 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2909
2910         Unreviewed, rolling out r242952.
2911
2912         Causing API failures on iOS Simulator
2913
2914         Reverted changeset:
2915
2916         "[PSON] Make sure the WebProcessCache is leverage when
2917         relaunching a process after termination"
2918         https://bugs.webkit.org/show_bug.cgi?id=195747
2919         https://trac.webkit.org/changeset/242952
2920
2921 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2922
2923         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2924         https://bugs.webkit.org/show_bug.cgi?id=195740
2925
2926         Reviewed by Ross Kirsling.
2927
2928         window.open doesn't work for WebKitBrowserWindow because it is not
2929         implemented yet.
2930
2931         1. Implemented createNewPage callback of WKPageUIClient.
2932         2. Changed MainWindow to take a BrowserWindow factory function
2933           instead of BrowserWindowType to be flexible to create
2934           BrowserWindow with extra settings.
2935         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2936           because it is not relevant with MainWindow anymore.
2937
2938         * MiniBrowser/win/Common.cpp:
2939         (parseCommandLine):
2940         * MiniBrowser/win/Common.h:
2941         (CommandLineOptions::CommandLineOptions):
2942         * MiniBrowser/win/MainWindow.cpp:
2943         (MainWindow::MainWindow):
2944         (MainWindow::create):
2945         (MainWindow::init):
2946         (MainWindow::WndProc):
2947         * MiniBrowser/win/MainWindow.h:
2948         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2949         (PrintWebUIDelegate::createWebViewWithRequest):
2950         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2951         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2952         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2953         (WebKitBrowserWindow::updateProxySettings):
2954         (WebKitBrowserWindow::createNewPage):
2955         * MiniBrowser/win/WebKitBrowserWindow.h:
2956         * MiniBrowser/win/WinMain.cpp:
2957         (wWinMain):
2958
2959 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2960
2961         Make it possible to test scrolling tree layer manipulation more easily
2962         https://bugs.webkit.org/show_bug.cgi?id=195780
2963
2964         Reviewed by Tim Horton.
2965         
2966         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2967         cuts off communication of scrolling tree scrolls back to the web process
2968         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2969         allows tests to trigger scrolls which run the scrolling tree layer positioning
2970         logic, but never get another commit from the web process that might mask
2971         scrolling tree bugs.
2972         
2973         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2974         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2975         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2976
2977         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2978         (WTR::UIScriptController::scrollUpdatesDisabled const):
2979         (WTR::UIScriptController::setScrollUpdatesDisabled):
2980         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2981         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2982         (WTR::UIScriptController::scrollUpdatesDisabled const):
2983         (WTR::UIScriptController::setScrollUpdatesDisabled):
2984         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2985         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2986         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2987         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2988         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2989         * WebKitTestRunner/ios/TestControllerIOS.mm:
2990         (WTR::TestController::platformResetStateToConsistentValues):
2991         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2992         (WTR::UIScriptController::scrollUpdatesDisabled const):
2993         (WTR::UIScriptController::setScrollUpdatesDisabled):
2994
2995 2019-03-14  Youenn Fablet  <youenn@apple.com>
2996
2997         Move IDB storage in private browsing mode to NetworkProcess
2998         https://bugs.webkit.org/show_bug.cgi?id=195602
2999
3000         Reviewed by Brady Eidson.
3001
3002         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3003         (TEST):
3004
3005 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3006
3007         [ews-build] Make descriptionDone messages more readable
3008         https://bugs.webkit.org/show_bug.cgi?id=195760
3009
3010         Reviewed by Lucas Forschler.
3011
3012         * BuildSlaveSupport/ews-build/steps.py:
3013         * BuildSlaveSupport/ews-build/steps_unittest.py:
3014
3015 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3016
3017         [ews-build] Generate status-bubble hover-over messages
3018         https://bugs.webkit.org/show_bug.cgi?id=195680
3019
3020         Reviewed by Lucas Forschler.
3021
3022         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3023         (StatusBubble):
3024         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3025         on hover-over.
3026         (StatusBubble._iso_time):
3027         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3028         hover-over message.
3029         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3030
3031 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3032
3033         [ews-app] Gracefully handle the case when state_string is None
3034         https://bugs.webkit.org/show_bug.cgi?id=195753
3035
3036         Reviewed by Lucas Forschler.
3037
3038         * BuildSlaveSupport/ews-app/ews/models/build.py:
3039         * BuildSlaveSupport/ews-app/ews/models/step.py:
3040
3041 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3042
3043         [ews-app] Status bubble display pending for currently running build step
3044         https://bugs.webkit.org/show_bug.cgi?id=195744
3045
3046         Reviewed by Lucas Forschler.
3047
3048         * BuildSlaveSupport/ews-build/events.py:
3049         (Events.stepStarted): If state_string is pending, replace it with step name.
3050
3051 2019-03-14  Chris Dumez  <cdumez@apple.com>
3052
3053         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3054         https://bugs.webkit.org/show_bug.cgi?id=195750
3055
3056         Reviewed by Geoffrey Garen.
3057
3058         Add API test coverage.
3059
3060         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3061         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3062         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3063         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3064
3065 2019-03-14  Chris Dumez  <cdumez@apple.com>
3066
3067         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3068         https://bugs.webkit.org/show_bug.cgi?id=195747
3069
3070         Reviewed by Geoff Garen.
3071
3072         Add API test coverage.
3073
3074         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3075
3076 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3077
3078         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3079         https://bugs.webkit.org/show_bug.cgi?id=195725
3080         <rdar://problem/48545062>
3081
3082         Reviewed by Tim Horton.
3083
3084         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3085         handler is nil.
3086
3087         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3088         (TestWebKitAPI::TEST):
3089
3090 2019-03-13  Sam Weinig  <sam@webkit.org>
3091
3092         Add utility function to allow easy reverse range-based iteration of a container
3093         https://bugs.webkit.org/show_bug.cgi?id=195542
3094
3095         Reviewed by Antti Koivisto.
3096
3097         * TestWebKitAPI/CMakeLists.txt:
3098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3099         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3100         (TestWebKitAPI::TEST):
3101         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3102
3103 2019-03-13  Chris Dumez  <cdumez@apple.com>
3104
3105         Use a ServiceWorker process per registrable domain
3106         https://bugs.webkit.org/show_bug.cgi?id=195649
3107
3108         Reviewed by Youenn Fablet.
3109
3110         Update API test coverage.
3111
3112         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3113
3114 2019-03-13  Chris Dumez  <cdumez@apple.com>
3115
3116         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3117         https://bugs.webkit.org/show_bug.cgi?id=195684
3118         <rdar://problem/48294714>
3119
3120         Reviewed by Antti Koivisto.
3121
3122         Add API test coverage.
3123
3124         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3125
3126 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3127
3128         [ews-app] Remove unused patch view
3129         https://bugs.webkit.org/show_bug.cgi?id=195669
3130
3131         Reviewed by Lucas Forschler.
3132
3133         * BuildSlaveSupport/ews-app/ews/urls.py:
3134         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3135
3136 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3137
3138         [ews-app] Use Buildbot result code variables
3139         https://bugs.webkit.org/show_bug.cgi?id=195668
3140
3141         Reviewed by Alexey Proskuryakov.
3142
3143         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3144         (Buildbot): Added Buildbot result code variables.
3145         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3146         (StatusBubble._build_bubble): Used Buildbot result code variables.
3147
3148 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3149
3150         [Flatpak] Expand submodule recursively
3151         https://bugs.webkit.org/show_bug.cgi?id=195672
3152
3153         Building WPE with flatpak was impossible without that as it was raising an exception.
3154         Also update wpebackend-fdo to match what is built in jhbuild
3155
3156         Reviewed by Philippe Normand.
3157
3158         * flatpak/flatpakutils.py:
3159         (expand_submodules_recurse):
3160         (expand_manifest):
3161         * flatpak/org.webkit.WPEModules.yaml:
3162
3163 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3164
3165         [ews-app] status bubble should be hidden for certain builds
3166         https://bugs.webkit.org/show_bug.cgi?id=194597
3167
3168         Reviewed by Dewei Zhu.
3169
3170         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3171         (StatusBubble._build_bubble):
3172         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3173         because the patch didn't have relevant changes.
3174         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3175         in production yet.
3176
3177 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3178
3179         [Win] Fix a slew of simple clang-cl warnings.
3180         https://bugs.webkit.org/show_bug.cgi?id=195652
3181
3182         Reviewed by Don Olmstead.
3183
3184         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3185         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3186
3187 2019-03-12  Justin Fan  <justin_fan@apple.com>
3188
3189         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3190         https://bugs.webkit.org/show_bug.cgi?id=195518
3191         <rdar://problem/46322356>
3192
3193         Reviewed by Myles C. Maxfield.
3194
3195         * DumpRenderTree/DerivedSources-input.xcfilelist:
3196         * DumpRenderTree/DerivedSources-output.xcfilelist:
3197
3198 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3199
3200         Unreviewed, rolling out r242825.
3201         https://bugs.webkit.org/show_bug.cgi?id=195648
3202
3203         "Broke webkitpy tests with my change to
3204         lldb_dump_class_layout.py" (Requested by rmorisset on
3205         #webkit).
3206
3207         Reverted changeset:
3208
3209         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3210         classes with suspicious padding"
3211         https://bugs.webkit.org/show_bug.cgi?id=195573
3212         https://trac.webkit.org/changeset/242825
3213
3214 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3215
3216         [ews-build] Show status bubbles while the patch is waiting in queue
3217         https://bugs.webkit.org/show_bug.cgi?id=195618
3218
3219         Reviewed by Lucas Forschler.
3220
3221         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3222         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3223         enabled in initial deployment.
3224         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3225         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3226         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3227         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3228         (StatusBubble._build_bubbles_for_patch):
3229
3230 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3231
3232         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3233         https://bugs.webkit.org/show_bug.cgi?id=195573
3234
3235         Reviewed by Simon Fraser.
3236
3237         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3238
3239         * Scripts/dump-class-layout:
3240         (main):
3241         * lldb/lldb_dump_class_layout.py:
3242         (ClassLayout.__init__):
3243         (ClassLayout._compute_padding_recursive):
3244         (LLDBDebuggerInstance.dump_layout_for_classname):
3245         (LLDBDebuggerInstance):
3246         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3247         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3248
3249 2019-03-12  Chris Dumez  <cdumez@apple.com>
3250
3251         Device Orientation access permission should be denied unless explicitly granted by the client
3252         https://bugs.webkit.org/show_bug.cgi?id=195625
3253
3254         Reviewed by Youenn Fablet.
3255
3256         add API test coverage.
3257
3258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3259         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3260         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3261         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3262         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3263         (runDeviceOrientationTest):
3264         (TEST):
3265         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3266         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3267
3268 2019-03-12  Jer Noble  <jer.noble@apple.com>
3269
3270         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3271         https://bugs.webkit.org/show_bug.cgi?id=195137
3272         <rdar://problem/48810307>
3273
3274         Reviewed by Eric Carlson.
3275
3276         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3277         (TestWebKitAPI::TEST):
3278
3279 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3280
3281         [ews-build] Change urls from uat to production
3282         https://bugs.webkit.org/show_bug.cgi?id=195566
3283
3284         Reviewed by Lucas Forschler.
3285
3286         * BuildSlaveSupport/ews-app/ews/config.py:
3287         * BuildSlaveSupport/ews-build/events.py:
3288         * BuildSlaveSupport/ews-build/steps.py:
3289
3290 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3291
3292         [ews-build] change max_builds for local-worker to 1
3293         https://bugs.webkit.org/show_bug.cgi?id=195568
3294
3295         Reviewed by Lucas Forschler.
3296
3297         * BuildSlaveSupport/ews-build/loadConfig.py:
3298
3299 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3300
3301         Fix the build
3302
3303         * TestRunnerShared/spi/PencilKitTestSPI.h:
3304         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3305
3306 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3307
3308         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3309         https://bugs.webkit.org/show_bug.cgi?id=194131
3310
3311         Reviewed by Michael Catanzaro.
3312
3313         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3314         (uriChanged):
3315         (testUnfinishedSubresourceLoad):
3316         (serverCallback):
3317         (beforeAll):
3318
3319 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3320
3321         WTF::Expected should use std::addressof instead of operator&
3322         https://bugs.webkit.org/show_bug.cgi?id=195604
3323
3324         Reviewed by Myles Maxfield.
3325
3326         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3327         (TestWebKitAPI::Unique::Unique):
3328         (TestWebKitAPI::Unique::operator&):
3329         (TestWebKitAPI::TEST):
3330
3331 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3332
3333         Add Optional to Forward.h.
3334         https://bugs.webkit.org/show_bug.cgi?id=195586
3335
3336         Reviewed by Darin Adler.
3337
3338         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3339         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3340         Remove unnecessary includes from headers.
3341
3342 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3343
3344         Add testing API to hit-test and scroll overflow scrollers
3345         https://bugs.webkit.org/show_bug.cgi?id=195278
3346
3347         Reviewed by Antti Koivisto.
3348         
3349         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3350         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3351         
3352         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3353
3354         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3355         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3356         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3357         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3358         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3359         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3360         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3361         (WTR::enclosingScrollViewIncludingSelf):
3362         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3363
3364 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3365
3366         API test WebKit.RequestTextInputContext fails on iOS
3367         https://bugs.webkit.org/show_bug.cgi?id=195585
3368
3369         Reviewed by Wenson Hsieh and Simon Fraser.
3370
3371         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3372         (applyStyle):
3373         (TEST):
3374         Add a viewport, so that the coordinates match up on iOS.
3375         Scroll by moving the UIScrollView's contentOffset.
3376
3377 2019-03-11  Chris Dumez  <cdumez@apple.com>
3378
3379         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3380         https://bugs.webkit.org/show_bug.cgi?id=195506
3381         <rdar://problem/48733477>
3382
3383         Reviewed by Alex Christensen.
3384
3385         Add API test coverage.
3386
3387         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3388
3389 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3390
3391         Adding myself to contributors.json
3392
3393         Unreviewed, addming myself to contributors.json .
3394
3395         * Scripts/webkitpy/common/config/contributors.json:
3396
3397 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3398
3399         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3400         https://bugs.webkit.org/show_bug.cgi?id=195511
3401         <rdar://problem/44873269>
3402
3403         Reviewed by Darin Adler.
3404
3405         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3406         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3407         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3408         (TEST_F):
3409
3410 2019-03-11  Chris Dumez  <cdumez@apple.com>
3411
3412         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3413         https://bugs.webkit.org/show_bug.cgi?id=195561
3414
3415         Reviewed by Youenn Fablet.
3416
3417         Make sure the JS in the test requests for permission to receive device orientation events.
3418
3419         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3420
3421 2019-03-11  Youenn Fablet  <youenn@apple.com>
3422
3423         Allow storage quota increase by default in WTR
3424         https://bugs.webkit.org/show_bug.cgi?id=195541
3425
3426         Reviewed by Geoffrey Garen.
3427
3428         Allow storage quota increase by default in WTR.
3429         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3430         Use this for tests that explicitly need cache increase.
3431
3432         Instead of increasing quota by 2, make sure the next request is
3433         granted by adding all given parameters.
3434
3435         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3436         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3437         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3438         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3439         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3440         * WebKitTestRunner/TestController.cpp:
3441         (WTR::TestController::setAllowStorageQuotaIncrease):
3442         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3443         * WebKitTestRunner/TestController.h:
3444         * WebKitTestRunner/TestInvocation.cpp:
3445         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3446         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3447         (WTR::TestController::cocoaResetStateToConsistentValues):
3448         (WTR::TestController::setAllowStorageQuotaIncrease):
3449         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3450         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3451         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3452
3453 2019-03-11  Xan Lopez  <xan@igalia.com>
3454
3455         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3456         https://bugs.webkit.org/show_bug.cgi?id=194147
3457
3458         Reviewed by Michael Saboff.
3459
3460         To make --32-bit work correctly on Linux/64bit we need to:
3461
3462         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3463         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3464         unfortunately CMake only allows us to do this during
3465         crosscompilation, which is overkill here.
3466         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3467         pkg-config detection module uses the x86 .pc files instead of the
3468         x86_64 ones.
3469         - Set the -m32 flags for the compiler.
3470
3471         * Scripts/webkitdirs.pm:
3472         (generateBuildSystemFromCMakeProject):
3473
3474 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3475
3476         Add MotionMark-1.1 plan file for run-benchmark script.
3477         https://bugs.webkit.org/show_bug.cgi?id=195481
3478
3479         Rubber-stamped by Darin Adler.
3480
3481         Run-benchmark script should support MontionMark-1.1.
3482
3483         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3484
3485 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3486
3487         [ews-app] Add support for submit-to-ews url
3488         https://bugs.webkit.org/show_bug.cgi?id=195477
3489
3490         Reviewed by Lucas Forschler.
3491
3492         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3493         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3494         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3495         * BuildSlaveSupport/ews-app/ews/urls.py:
3496         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3497
3498 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3499
3500         Unreviewed, rolling out r242688, r242643, r242624.
3501
3502         Caused multiple layout test failures and crashes on iOS and macOS.
3503
3504         Reverted changeset:
3505
3506         "requestAnimationFrame should execute before the next frame"
3507         https://bugs.webkit.org/show_bug.cgi?id=177484
3508         https://trac.webkit.org/changeset/242624/webkit
3509
3510         * Tracing/SystemTracePoints.plist:
3511
3512 2019-03-11  John Wilander  <wilander@apple.com>
3513
3514         Resource Load Statistics: Make it possible exclude localhost from classification
3515         https://bugs.webkit.org/show_bug.cgi?id=195474
3516         <rdar://problem/47520577>
3517
3518         Reviewed by Brent Fulgham.
3519
3520         This patch allows for localhost to be excluded from classification and
3521         treatment as a prevalent resource.
3522
3523         The WebKit Tools change adds a new function called
3524         testRunner.setStatisticsIsRunningTest() which can be used to control this
3525         behavior.
3526
3527         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3528         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3529         (WTR::TestRunner::setStatisticsIsRunningTest):
3530         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3531         * WebKitTestRunner/TestController.cpp:
3532         (WTR::TestController::setStatisticsIsRunningTest):
3533         * WebKitTestRunner/TestController.h:
3534         * WebKitTestRunner/TestInvocation.cpp:
3535         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3536
3537 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3538
3539         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3540         https://bugs.webkit.org/show_bug.cgi?id=195560
3541
3542         Reviewed by Lucas Forschler.
3543
3544         * BuildSlaveSupport/ews-build/master.cfg:
3545
3546 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3547
3548         Unreviewed, rolling out r242698.
3549
3550         API test crashes on bots.
3551
3552         Reverted changeset:
3553
3554         "Add a WKContentRuleList variant that uses copied memory
3555         instead of mmap'd shared memory for class A containerized
3556         apps"
3557         https://bugs.webkit.org/show_bug.cgi?id=195511
3558         https://trac.webkit.org/changeset/242698
3559
3560 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3561
3562         [WPE] Enable web process sandbox
3563         https://bugs.webkit.org/show_bug.cgi?id=195169
3564
3565         Reviewed by Daniel Bates.
3566
3567         * wpe/install-dependencies:
3568         * wpe/jhbuild.modules:
3569
3570 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3571
3572         [ews-app] Use port 17000 for worker communication
3573         https://bugs.webkit.org/show_bug.cgi?id=195558
3574
3575         Reviewed by Lucas Forschler.
3576
3577         * BuildSlaveSupport/ews-build/master.cfg:
3578
3579 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3580
3581         [ews-build] unit-tests fail when passwords.json is missing
3582         https://bugs.webkit.org/show_bug.cgi?id=195557
3583
3584         Reviewed by Lucas Forschler.
3585
3586         * BuildSlaveSupport/ews-build/loadConfig.py:
3587         (loadBuilderConfig):
3588         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3589         (ConfigDotJSONTest.test_configuration):
3590         * BuildSlaveSupport/ews-build/master.cfg:
3591
3592 2019-03-11  Truitt Savell  <tsavell@apple.com>
3593
3594         Unreviewed, rolling out r242702.
3595
3596         Broke High Sierra builders.
3597
3598         Reverted changeset:
3599
3600         "Add utility function to allow easy reverse range-based
3601         iteration of a container"
3602         https://bugs.webkit.org/show_bug.cgi?id=195542
3603         https://trac.webkit.org/changeset/242702
3604
3605 2019-03-11  Sam Weinig  <sam@webkit.org>
3606
3607         Add utility function to allow easy reverse range-based iteration of a container
3608         https://bugs.webkit.org/show_bug.cgi?id=195542
3609
3610         Reviewed by Antti Koivisto.
3611
3612         * TestWebKitAPI/CMakeLists.txt:
3613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3614         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3615         (TestWebKitAPI::TEST):
3616         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3617
3618 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3619
3620         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3621         https://bugs.webkit.org/show_bug.cgi?id=195511
3622         <rdar://problem/44873269>
3623
3624         Reviewed by Darin Adler.
3625
3626         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3627         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3628         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3629         (TEST_F):
3630
3631 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3632
3633         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3634         https://bugs.webkit.org/show_bug.cgi?id=195499
3635
3636         Reviewed by Darin Adler.
3637
3638         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3639         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3640         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3641         (-[WKWebView synchronouslyFocusTextInputContext:]):
3642         (applyStyle):
3643         (applyIframe):
3644         (TEST):
3645         Add some tests for this SPI.
3646
3647 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3648
3649         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3650         https://bugs.webkit.org/show_bug.cgi?id=181151
3651
3652         Reviewed by Don Olmstead.
3653
3654         * TestWebKitAPI/CMakeLists.txt:
3655         * TestWebKitAPI/PlatformWin.cmake:
3656         Enable TestWTF RunLoop tests in all platforms.
3657
3658         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3659         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3660         (TestWebKitAPI::DerivedOneShotTimer::fired):
3661         (TestWebKitAPI::TEST):
3662         Only a few platforms support nested RunLoop.
3663
3664         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3665         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3666
3667 2019-03-10  David Quesada  <david_quesada@apple.com>
3668
3669         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3670         https://bugs.webkit.org/show_bug.cgi?id=152480
3671
3672         Reviewed by Chris Dumez.
3673
3674         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3675         there are no additional references to the process pool besides the one held by
3676         the download, waits for the download to finish (in the sense that the
3677         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3678         measure, also check that the process pool has been deallocated at the end of the
3679         test. The test wouldn't be meaningful if the process pool were still alive.
3680
3681         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3682         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3683         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3684             The download will be canceled because the delegate does not implement the
3685             method to decide the download's destination, so this is where we know the
3686             DownloadProxyMap is done with the DownloadProxy.
3687         (TEST):
3688
3689 2019-03-08  Chris Dumez  <cdumez@apple.com>
3690
3691         Add support for Device Orientation / Motion permission API
3692         https://bugs.webkit.org/show_bug.cgi?id=195329
3693         <rdar://problem/47645367>
3694
3695         Reviewed by Geoffrey Garen.
3696
3697         Add test infrastructure to help test the Device Orientation / Motion permission API.
3698
3699         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3700         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3701         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3702         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3703         * WebKitTestRunner/TestController.cpp:
3704         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3705         (WTR::TestController::createWebViewWithOptions):
3706         (WTR::TestController::resetStateToConsistentValues):
3707         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3708         * WebKitTestRunner/TestController.h:
3709         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3710         * WebKitTestRunner/TestInvocation.cpp:
3711         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3712
3713 2019-03-08  Saam barati  <sbarati@apple.com>
3714
3715         Add a compare-results script to compare benchmark results
3716         https://bugs.webkit.org/show_bug.cgi?id=195486
3717         <rdar://problem/48723397>
3718
3719         Reviewed by Geoffrey Garen.
3720
3721         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3722         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3723         to extend it to learn about our other benchmarks.
3724
3725         * Scripts/compare-results: Added.
3726         (readJSONFile):
3727         (detectJetStream2):
3728         (JetStream2Results):
3729         (detectSpeedometer2):
3730         (Speedometer2Results):
3731         (detectPLT5):
3732         (PLT5Results):
3733         (detectBenchmark):
3734         (biggerIsBetter):
3735         (ttest):
3736         (getOptions):
3737         (main):
3738
3739 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3740
3741         Ensure old tab state is cleared between iterations of run-benchmark
3742         https://bugs.webkit.org/show_bug.cgi?id=195393
3743         <rdar://problem/46885583>
3744
3745         Reviewed by Dewei Zhu.
3746
3747         a) ensure the default to restore state is not set
3748         b) terminate Safari correctly
3749         c) Set the system default to ignore Persistent State in Safari
3750
3751         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3752         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3753         (OSXBrowserDriver.prepare_env): 
3754         (OSXBrowserDriver.restore_env):
3755         (OSXBrowserDriver.close_browsers):
3756         (OSXBrowserDriver._terminate_processes):
3757         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3758         (OSXChromeDriver):
3759         (OSXChromeCanaryDriver):
3760         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3761         (OSXFirefoxDriver):
3762         (OSXFirefoxNightlyDriver):
3763         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3764         (OSXSafariDriver):
3765         (OSXSafariDriver.prepare_env):
3766
3767 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3768
3769         [GTK] Several InputMethodFilter tests are failing
3770         https://bugs.webkit.org/show_bug.cgi?id=195408
3771
3772         Reviewed by Carlos Garcia Campos.
3773
3774         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3775         Regressed in r241751.
3776         Hexadecimal values of keycodes are expressed now in upper letters.
3777         Composited characters should be cast to UTF8 strings.
3778
3779         (TestWebKitAPI::TEST):
3780
3781 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3782
3783         [GTK] Make Tools/gtkdoc python3 compatible
3784         https://bugs.webkit.org/show_bug.cgi?id=195359
3785
3786         Reviewed by Carlos Garcia Campos.
3787
3788         * gtkdoc/generate-gtkdoc:
3789         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3790         work with Python 2 and 3.
3791         (get_gtkdoc_module_paths):
3792         The iteritems() was removed in Python 3, so let's use items() that's
3793         available in Python 2 and 3.
3794         (get_generator_for_config):
3795         * gtkdoc/gtkdoc.py:
3796         (GTKDoc._run_command):
3797         The sys.stdout.write() is expecting str in Python 3 and not bytes
3798         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3799         for passing the bytes there.
3800
3801 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3802
3803         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3804         https://bugs.webkit.org/show_bug.cgi?id=195346
3805         <rdar://problem/48667048>
3806
3807         Unreviewed build fix for clang-cl.
3808
3809         * DumpRenderTree/win/DumpRenderTree.cpp:
3810         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3811
3812 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3813
3814         requestAnimationFrame should execute before the next frame
3815         https://bugs.webkit.org/show_bug.cgi?id=177484
3816
3817         Reviewed by Simon Fraser.
3818
3819         Add trace points for the page RenderingUpdate.
3820
3821         * Tracing/SystemTracePoints.plist:
3822
3823 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3824
3825         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3826         https://bugs.webkit.org/show_bug.cgi?id=195353
3827         <rdar://problem/48626394>
3828
3829         Reviewed by Simon Fraser.
3830
3831         * WebKitTestRunner/ios/TestControllerIOS.mm:
3832         (WTR::TestController::platformResetPreferencesToConsistentValues):
3833
3834 2019-03-07  John Wilander  <wilander@apple.com>
3835
3836         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3837         https://bugs.webkit.org/show_bug.cgi?id=195383
3838         <rdar://problem/48570136>
3839
3840         Reviewed by Brent Fulgham.
3841
3842         This patch adds test infrastructure to purge only script-accessible cookies,
3843         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3844
3845         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3846         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3847         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3848         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3849         * WebKitTestRunner/TestController.cpp:
3850         (WTR::TestController::statisticsDeleteCookiesForHost):
3851         * WebKitTestRunner/TestController.h:
3852         * WebKitTestRunner/TestInvocation.cpp:
3853         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3854
3855 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3856
3857         Unreviewed, rolling out r242354.
3858         https://bugs.webkit.org/show_bug.cgi?id=195402
3859
3860         breaks layout tests in all configurations (Requested by
3861         zdobersek on #webkit).
3862
3863         Reverted changeset:
3864
3865         "[WPE] Enable web process sandbox"
3866         https://bugs.webkit.org/show_bug.cgi?id=195169
3867         https://trac.webkit.org/changeset/242354
3868
3869 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3870
3871         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3872         https://bugs.webkit.org/show_bug.cgi?id=195346
3873
3874         Reviewed by Fujii Hironori.
3875
3876         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3877         (TestWebKitAPI::TEST):
3878         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3879
3880         * DumpRenderTree/win/DumpRenderTree.cpp:
3881         (findFontFallback):
3882         (addFontFallbackIfPresent):
3883         (removeFontFallbackIfPresent):
3884         (main):
3885         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3886         (TestWebKitAPI::Util::moduleDirectory):
3887         (TestWebKitAPI::Util::createInjectedBundlePath):
3888         Use wchar helpers as needed.
3889
3890 2019-03-06  Rob Buis  <rbuis@igalia.com>
3891
3892         Consider supporting the `referrerpolicy` attribute.
3893         https://bugs.webkit.org/show_bug.cgi?id=179053
3894
3895         Reviewed by Darin Adler.
3896
3897         Add a runtime flag for referrerpolicy attribute.
3898
3899         * DumpRenderTree/mac/DumpRenderTree.mm:
3900         (enableExperimentalFeatures):
3901
3902 2019-03-05  Daniel Bates  <dabates@apple.com>
3903
3904         Update expected API test result following r242379
3905         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3906
3907         Update expected x-coordinate of selection rect now that the left padding of
3908         a textarea is sized in ems (so dependent on the font size) just like the left
3909         padding of a text field.
3910
3911         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3912         (TestWebKitAPI::TEST):
3913
3914 2019-03-05  David Quesada  <david_quesada@apple.com>
3915
3916         [WK2] It should be possible to follow links with 'download' attributes
3917         https://bugs.webkit.org/show_bug.cgi?id=195145
3918         rdar://problem/48462642
3919
3920         Reviewed by Alex Christensen.
3921
3922         Add a unit test to verify that activating links with 'download' attributes now
3923         navigates to the linked resource, rather than starts downloading it. Add another
3924         to verify that it is still possible to explicitly download the link via the
3925         'Download' navigation action policy.
3926
3927         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3928         (-[DownloadAttributeTestDelegate init]):
3929         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3930         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3931         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3932         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3933         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3934         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3935         (TEST):
3936         * WebKitTestRunner/TestController.cpp:
3937         (WTR::TestController::decidePolicyForNavigationAction):
3938         * WebKitTestRunner/TestController.h:
3939
3940 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3941
3942         [Curl] Implement Cookie Accept Policy.
3943         https://bugs.webkit.org/show_bug.cgi?id=191645
3944
3945         Reviewed by Fujii Hironori.
3946
3947         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3948         (TestWebKitAPI::Curl::TEST_F):
3949
3950 2019-03-05  Youenn Fablet  <youenn@apple.com>
3951
3952         Rename requestCacheStorageSpace to requestStorageSpace
3953         https://bugs.webkit.org/show_bug.cgi?id=195282
3954
3955         Reviewed by Chris Dumez.
3956
3957         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3958         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3959         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3960
3961 2019-03-05  Brady Eidson  <beidson@apple.com>
3962
3963         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3964         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3965
3966         Reviewed by Tim Horton.
3967
3968         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3969         different directory into that same WKWebView should work.
3970
3971         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3972         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3973
3974 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3975
3976         Add WeakHashSet
3977         https://bugs.webkit.org/show_bug.cgi?id=195152
3978
3979         Reviewed by Antti Koivisto.
3980
3981         Added tests for WeakHashSet.
3982
3983         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3984         (TestWebKitAPI::Base::Base): Moved.
3985         (TestWebKitAPI::Derived::foo): Moved.
3986         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3987         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3988         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3989         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3990
3991 2019-03-04  Chris Dumez  <cdumez@apple.com>
3992
3993         Do not share WebProcesses between private and regular sessions
3994         https://bugs.webkit.org/show_bug.cgi?id=195189
3995         <rdar://problem/48421064>
3996
3997         Reviewed by Alex Christensen.
3998
3999         Add API test coverage.
4000
4001         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4002         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4003
4004 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
4005
4006         [WPE] Enable web process sandbox
4007         https://bugs.webkit.org/show_bug.cgi?id=195169
4008
4009         Reviewed by Daniel Bates.
4010
4011         * wpe/install-dependencies:
4012         * wpe/jhbuild.modules:
4013
4014 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4015
4016         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
4017         https://bugs.webkit.org/show_bug.cgi?id=195206
4018
4019         Reviewed by Žan Doberšek.
4020
4021         Add a new test case.
4022
4023         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4024         (testJSCClass):
4025
4026 2019-03-04  Charlie Turner  <cturner@igalia.com>
4027
4028         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
4029         https://bugs.webkit.org/show_bug.cgi?id=194898
4030
4031         Reviewed by Žan Doberšek.
4032
4033         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
4034         a GCC extension that permits arithmetic on void* pointer. Inline
4035         the macro until this issue is fixed upstream.
4036
4037 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4038
4039         Rid the world of WK_API_ENABLED
4040         https://bugs.webkit.org/show_bug.cgi?id=195263
4041
4042         Reviewed by Dan Bernstein.
4043
4044         List of changed files elided because it's useless.
4045
4046 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4047
4048         Unreviewed follow-up to r242292.
4049
4050         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4051
4052         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4053         (TestWebKitAPI::testStrip): Renamed from strip.
4054         (TestWebKitAPI::TEST):
4055
4056 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4057
4058         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4059
4060         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4061         and bug #194272 for details.
4062
4063         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4064
4065 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4066
4067         Remove some more unused 32-bit code
4068         https://bugs.webkit.org/show_bug.cgi?id=195255
4069
4070         Reviewed by Darin Adler.
4071
4072         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4073         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4074         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4075         (NPP_New):
4076         (NPP_HandleEvent):
4077         (handleEventCarbon): Deleted.
4078
4079 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4080
4081         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4082
4083         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4084         (TestWebKitAPI::TEST):
4085
4086 2019-03-01  Darin Adler  <darin@apple.com>
4087
4088         Finish removing String::format
4089         https://bugs.webkit.org/show_bug.cgi?id=194893
4090
4091         Reviewed by Daniel Bates.
4092 '
4093         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4094
4095 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4096
4097         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4098         https://bugs.webkit.org/show_bug.cgi?id=195229
4099         <rdar://problem/48520362>
4100
4101         Reviewed by Chris Dumez.
4102
4103         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4104         (TEST):
4105
4106 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4107
4108         Add a system trace scope for event region building
4109         https://bugs.webkit.org/show_bug.cgi?id=195226
4110
4111         Reviewed by Jon Lee.
4112
4113         This trace scope measures the time spend converting element rects into Region objects,
4114         which can be large on some pages.
4115
4116         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4117
4118         * Tracing/SystemTracePoints.plist:
4119
4120 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4121
4122         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4123         https://bugs.webkit.org/show_bug.cgi?id=194612
4124
4125         Reviewed by Alex Christensen.
4126
4127         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4128         Just test the new string-processing function and don't touch the actual environment.
4129         (Test cases are all as before, but based on operator== instead of strcmp.)
4130
4131 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4132
4133         [ews-app] Update primary keys for handling multiple Buildbot instances
4134         https://bugs.webkit.org/show_bug.cgi?id=195120
4135
4136         Reviewed by Stephanie Lewis.
4137
4138         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4139         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4140         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4141
4142         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4143         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4144         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4145         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4146         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4147         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4148
4149 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4150
4151         [WinCairo] Enable service worker
4152         https://bugs.webkit.org/show_bug.cgi?id=188318
4153
4154         Reviewed by Youenn Fablet.
4155
4156         * DumpRenderTree/DumpRenderTreePrefix.h:
4157         * TestWebKitAPI/PlatformWin.cmake:
4158         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4159         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4160         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4161
4162 2019-03-01  Justin Fan  <justin_fan@apple.com>
4163
4164         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4165         https://bugs.webkit.org/show_bug.cgi?id=195191
4166
4167         Rubber-stamped by Dean Jackson.
4168
4169         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4170
4171         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4172
4173 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4174
4175         Unreviewed, fix lldb webkitpy tests
4176         https://bugs.webkit.org/show_bug.cgi?id=194375
4177
4178         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4179
4180         * lldb/lldb_webkit.py:
4181         (WTFStringImplProvider.is_8bit):
4182
4183 2019-02-28  David Quesada  <david_quesada@apple.com>
4184
4185         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4186         https://bugs.webkit.org/show_bug.cgi?id=195121
4187         rdar://problem/48450302
4188
4189         Reviewed by Alex Christensen.
4190
4191         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4192         configurations where the 'download' attribute is absent, blank, or populated
4193         with a filename, and where the anchor element is same-origin or cross-origin
4194         (meaning the 'download' attribute shouldn't be honored).
4195
4196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4197         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4198         (-[NavigationActionTestDelegate init]):
4199         (-[NavigationActionTestDelegate navigationAction]):
4200         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4201         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4202         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4203         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4204         (TEST):
4205
4206 2019-02-28  Antoine Quint  <graouts@apple.com>
4207
4208         Enable the Pointer Events runtime flag by default
4209         https://bugs.webkit.org/show_bug.cgi?id=195156
4210
4211         Reviewed by Dean Jackson.
4212
4213         * DumpRenderTree/mac/DumpRenderTree.mm:
4214         (enableExperimentalFeatures):
4215
4216 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4217
4218         Several PasteImage API tests are flaky
4219         https://bugs.webkit.org/show_bug.cgi?id=195160
4220
4221         Reviewed by Tim Horton.
4222
4223         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4224         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4225         listening for a "load" event after image load is already complete.
4226
4227         To address this, make these tests first register a "load" event handler, then run script to insert an image
4228         element into the document, and finally wait until the load event is observed before checking image size.
4229
4230         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4231
4232 2019-02-28  Chris Dumez  <cdumez@apple.com>
4233
4234         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4235         https://bugs.webkit.org/show_bug.cgi?id=195107
4236
4237         Reviewed by Alex Christensen.
4238
4239         Give some time for the zoom level to get restored.
4240
4241         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4242
4243 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4244
4245         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4246         https://bugs.webkit.org/show_bug.cgi?id=194958
4247
4248         Reviewed by Geoffrey Garen.
4249
4250         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4251         (TEST):
4252
4253 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4254
4255         [ews-app] Update method to save build to handle builder_display_name
4256         https://bugs.webkit.org/show_bug.cgi?id=195047
4257
4258         Reviewed by Dewei Zhu.
4259
4260         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4261         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4262
4263 2019-02-28  Justin Fan  <justin_fan@apple.com>
4264
4265         [Web GPU] Enable Web GPU only on 64-bit
4266         https://bugs.webkit.org/show_bug.cgi?id=195139
4267
4268         Because Metal is only supported on 64 bit apps.
4269
4270         Unreviewed build fix.
4271
4272         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4273
4274 2019-02-27  Youenn Fablet  <youenn@apple.com>
4275
4276         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4277         https://bugs.webkit.org/show_bug.cgi?id=194959
4278
4279         Reviewed by Chris Dumez.
4280
4281         Spin loop until getting the condition to remove flakiness.
4282
4283         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4284
4285 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4286
4287         [ews-build] Buildbot should include builder_display_name in the build events
4288         https://bugs.webkit.org/show_bug.cgi?id=195045
4289
4290         Reviewed by Dewei Zhu.
4291
4292         * BuildSlaveSupport/ews-build/events.py:
4293         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4294         buildername to builder_name to be consistent in naming style.
4295         (Events.buildFinished): Ditto.
4296
4297 2019-02-27  Chris Dumez  <cdumez@apple.com>
4298
4299         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4300         https://bugs.webkit.org/show_bug.cgi?id=194480
4301
4302         Reviewed by Brady Eidson.
4303
4304         Update existing API test to make it more likely to reproduce the issue.
4305
4306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4307
4308 2019-02-27  Brady Eidson  <beidson@apple.com>
4309
4310         Universal links from Google search results pages don't open the app.
4311         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4312
4313         Reviewed by Geoffrey Garen.
4314
4315         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4316         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4317         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4318         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4319
4320 2019-02-27  Chris Dumez  <cdumez@apple.com>
4321
4322         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4323         https://bugs.webkit.org/show_bug.cgi?id=195102
4324
4325         Reviewed by Geoffrey Garen.
4326
4327         If the number of processes is not yet what we expect, wait a bit and check again to give
4328         processes some time to exit.
4329
4330         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4331
4332 2019-02-27  Chris Dumez  <cdumez@apple.com>
4333
4334         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4335         https://bugs.webkit.org/show_bug.cgi?id=194545
4336
4337         Reviewed by Brady Eidson.
4338
4339         Make sure the test navigates forward and then back only once. Previously, navigating
4340         back would trigger a navigation again in a timer.
4341
4342         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4343
4344 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4345
4346         High Sierra Debug JSC test queue should use faster hardware
4347         https://bugs.webkit.org/show_bug.cgi?id=194603
4348
4349         Rubber-stamped by Alexey Proskuryakov.
4350
4351         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4352
4353         * BuildSlaveSupport/build.webkit.org-config/config.json:
4354         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4355         (BubbleQueueServer):
4356         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4357         (WebKitBuildbot):
4358         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4359         * QueueStatusServer/config/queues.py:
4360         * Scripts/webkitpy/common/config/ews.json:
4361         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4362         (test_ews_name):
4363
4364 2019-02-27  John Wilander  <wilander@apple.com>
4365
4366         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4367         https://bugs.webkit.org/show_bug.cgi?id=195071
4368         <rdar://problem/48417690>
4369
4370         Reviewed by Alex Christensen and Brent Fulgham.
4371
4372     &nb