Flakiness dashboard contains outdated list of bots on builders.jsonp
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2
3         Flakiness dashboard contains outdated list of bots on builders.jsonp
4         https://bugs.webkit.org/show_bug.cgi?id=132874
5
6         Reviewed by Darin Adler.
7
8         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
9         file by changing to the directory Tools/TestResultServer and executing
10         the script generate_builders_json.py
11
12 2014-05-11  Anders Carlsson  <andersca@apple.com>
13
14         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
15         https://bugs.webkit.org/show_bug.cgi?id=132809
16
17         Reviewed by Dan Bernstein.
18
19         * WebKitTestRunner/TestController.cpp:
20         (WTR::TestController::initialize):
21         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
22
23 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
24
25         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
26         https://bugs.webkit.org/show_bug.cgi?id=132739
27
28         Reviewed Anders Carlsson.
29
30         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
31         the JSC unit tests.
32         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
33
34 2014-05-11  Anders Carlsson  <andersca@apple.com>
35
36         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
37         https://bugs.webkit.org/show_bug.cgi?id=132806
38
39         Reviewed by Beth Dakin.
40
41         Migrate to WKContextConfiguration.
42
43         * WebKitTestRunner/TestController.cpp:
44         (WTR::TestController::initialize):
45
46 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
47
48         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
49         https://bugs.webkit.org/show_bug.cgi?id=132685
50
51         Reviewed by Martin Robinson.
52
53         Use a single TestWebKit2 binary for all WebKit2 C API tests.
54
55         * TestWebKitAPI/PlatformGTK.cmake:
56
57 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
58
59         [iOS] Switch geolocation to an explicit authorization query model
60         https://bugs.webkit.org/show_bug.cgi?id=132717
61
62         Reviewed by Sam Weinig.
63
64         * DumpRenderTree/mac/MockGeolocationProvider.mm:
65         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
66         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
67
68 2014-05-09  David Farler  <dfarler@apple.com>
69
70         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
71         https://bugs.webkit.org/show_bug.cgi?id=132718
72
73         Reviewed by David Kilzer.
74
75         The simulator may not be able to look up runtimes by SDK paths
76         and instead will map SDK versions to runtimes instead. In
77         com.apple.iphonesimulator.startSession notifications,
78         'runtimeIdentifier' (SDK version string) is preferred over
79         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
80         when creating a new DRT or WKTR simulator session.
81
82         IPhoneSimulatorNotification.pm filters out keys for this
83         notification's userInfo with a hard-coded list. There's no harm
84         in including extra key-value pairs in an NSNotification userInfo
85         dictionary anyway and the simulator may again change its
86         userInfo schema for this notification.
87
88         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
89         (postStartSessionNotification):
90         * Scripts/old-run-webkit-tests:
91         (installAndLaunchDumpToolAppUsingNotification):
92
93 2014-05-09  Anders Carlsson  <andersca@apple.com>
94
95         Another build fix.
96
97         * Scripts/build-webkit:
98         WebKit2 should always be built for OS X and iOS.
99
100 2014-05-09  Anders Carlsson  <andersca@apple.com>
101
102         Follow-up build fix.
103
104         * Scripts/build-webkit:
105         WebKit2 should no longer be built before WebKit.
106
107 2014-05-09  Anders Carlsson  <andersca@apple.com>
108
109         Rename WebKit2.framework to WebKit.framework
110         https://bugs.webkit.org/show_bug.cgi?id=132743
111         <rdar://problem/15920046>
112
113         Reviewed by Dan Bernstein.
114
115         * Scripts/check-for-inappropriate-files-in-framework:
116         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
117         Change WebKit2 to WebKit.
118
119         * Scripts/check-for-webkit-framework-include-consistency:
120         Change WebKit to WebKitLegacy.
121
122 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
123
124         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
125         https://bugs.webkit.org/show_bug.cgi?id=132732
126
127         Reviewed by Alexey Proskuryakov.
128
129         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
130
131         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
132         (EWS): Remove GTK+ WK1 EWS.
133
134 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
135
136         Add new u-szeged contributors.
137
138         Reviewed by Csaba Osztrogonác.
139
140         * Scripts/webkitpy/common/config/contributors.json:
141
142 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
143
144         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
145         https://bugs.webkit.org/show_bug.cgi?id=132736
146
147         Reviewed by Philippe Normand.
148
149         There are two problems, the path returned by common.library_build_path() is wrong when
150         common.binary_build_path() has previously been called, and the test is still looking for
151         the .la instead of .so
152
153         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
154         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
155         of .la as extension of the injected bundle library.
156         * gtk/common.py:
157         (binary_build_path): Remove unused global variable and add a new
158         one for binary_build_dir instead of sharing the same global
159         variable for library_build_path and binary_build_path.
160
161 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
162
163         [EFL] Enable MEDIA_STREAM for EFL port
164         https://bugs.webkit.org/show_bug.cgi?id=132648
165
166         Reviewed by Gyuyoung Kim.
167
168         Script modified to enable MEDIA_STREAM for EFL build.
169
170         * Scripts/webkitperl/FeatureList.pm: 
171
172 2014-05-08  David Farler  <dfarler@apple.com>
173
174         old-run-webkit-tests: update strings for simulator devices and app name
175         https://bugs.webkit.org/show_bug.cgi?id=132687
176
177         Reviewed by Darin Adler.
178
179         iPhone Retina (4-inch) -> iPhone 5
180         iPhone Retina (4-inch 64-bit) -> iPhone 5s
181
182         * Scripts/old-run-webkit-tests:
183         (installAndLaunchDumpToolAppUsingNotification):
184         (openIPhoneSimulator):
185         (quitIPhoneSimulator):
186         quit iOS Simulator, not iPhone Simulator.
187
188 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
189
190         REGRESSION(r168471): Update the builder names on the scheduler list.
191         https://bugs.webkit.org/show_bug.cgi?id=132699
192
193         Reviewed by Martin Robinson.
194
195         On r168471 I missed to update the builder names for the GTK build
196         bots on the AnyBranchScheduler type scheduler list of bots.
197
198         * BuildSlaveSupport/build.webkit.org-config/config.json:
199
200 2014-05-08  Brady Eidson  <beidson@apple.com>
201
202         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
203         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
204
205         Reviewed by Tim Horton.
206
207         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
208         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
209
210 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
211
212         REGRESSION(r168471): Duplicate builddirs broke the build master.
213         https://bugs.webkit.org/show_bug.cgi?id=132688
214
215         Reviewed by Carlos Garcia Campos.
216
217         Rename the builddirs of the new GTK bots introduced on r168471 to
218         be unique. Otherwise the master will break.
219
220         * BuildSlaveSupport/build.webkit.org-config/config.json:
221
222 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
223
224         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
225         https://bugs.webkit.org/show_bug.cgi?id=132674
226
227         Reviewed by Philippe Normand.
228
229         Only ignore mkdir failure when exception is raised because the
230         file already exists and it's a directory.
231
232         * gtk/webkitdom.py:
233         (write_doc_files):
234
235 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
236
237         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
238         https://bugs.webkit.org/show_bug.cgi?id=131358
239
240         Reviewed by Carlos Garcia Campos.
241
242         Current 64-bit GTK build bots (Release and Debug) not only test
243         the build, but run all tests. Split each one of the bots in
244         BuildOnly and TestWebKit2.
245
246         This will allow us to have a better overview of the status of
247         the GTK port.
248
249         Original patch from Sergio Villar Senin <svillar@igalia.com>
250
251         * BuildSlaveSupport/build.webkit.org-config/config.json:
252         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
253         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
254         (WebKitBuildbot):
255         * Scripts/webkitpy/port/builders.py:
256         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
257         (TestRebaselineTest.test_baseline_directory):
258         * TestResultServer/static-dashboards/builders.jsonp:
259         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
260         (resetGlobals):
261         * TestResultServer/static-dashboards/loader_unittests.js:
262
263 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
264
265         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
266         https://bugs.webkit.org/show_bug.cgi?id=126022
267
268         Reviewed by Benjamin Poulain.
269
270         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
271
272         Added an unit test case to check if scroll position and scale are restored properly.
273
274         * TestWebKitAPI/PlatformEfl.cmake:
275         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
276         (TestWebKitAPI::didFinishLoadForFrame):
277         (TestWebKitAPI::didChangeContentsPosition):
278         (TestWebKitAPI::TEST):
279         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
280         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
281
282 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
283
284         WebKit1 is flashy when compositing layers come and go
285         https://bugs.webkit.org/show_bug.cgi?id=132655
286         <rdar://problem/16830981&16788846>
287
288         Reviewed by Sam Weinig.
289         
290         Revert the change from r166117.
291
292         * DumpRenderTree/mac/DumpRenderTree.mm:
293         (updateDisplay):
294
295 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
296
297         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
298         https://bugs.webkit.org/show_bug.cgi?id=132622
299
300         Reviewed by Mario Sanchez Prada.
301
302         * DumpRenderTree/AccessibilityUIElement.cpp:
303         (selectTextWithCriteriaCallback):
304         (isEqualCallback):
305         * DumpRenderTree/AccessibilityUIElement.h:
306         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
307         (AccessibilityUIElement::selectTextWithCriteria):
308         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
309         (AccessibilityUIElement::selectTextWithCriteria):
310         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
311         (selectTextParameterizedAttributeForCriteria):
312         (AccessibilityUIElement::selectTextWithCriteria):
313         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
314         (AccessibilityUIElement::selectTextWithCriteria):
315         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
316         (WTR::AccessibilityUIElement::selectTextWithCriteria):
317         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
318         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
319         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
320         (WTR::AccessibilityUIElement::selectTextWithCriteria):
321         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
322         (WTR::AccessibilityUIElement::selectTextWithCriteria):
323         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
324         (WTR::selectTextParameterizedAttributeForCriteria):
325         (WTR::AccessibilityUIElement::selectTextWithCriteria):
326
327 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
328
329         [SOUP] TLSErrors do not cause page load to fail when not ignored
330         https://bugs.webkit.org/show_bug.cgi?id=121548
331
332         Reviewed by Sergio Villar Senin.
333
334         Add unit tests to check that the load fails with TLS errors in
335         case of a redirection.
336
337         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
338         (testTLSErrorsRedirect):
339         (httpsServerCallback):
340         (beforeAll):
341
342 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
343
344         [CSS Grid Layout] Remove runtime feature
345         https://bugs.webkit.org/show_bug.cgi?id=132382
346
347         Reviewed by Benjamin Poulain.
348
349         Remove cssGridLayoutEnabled setting usage.
350
351         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
352         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
353         * DumpRenderTree/efl/TestRunnerEfl.cpp:
354         (TestRunner::overridePreference):
355         * DumpRenderTree/mac/DumpRenderTree.mm:
356         (resetWebPreferencesToConsistentValues):
357
358 2014-05-06  David Kilzer  <ddkilzer@apple.com>
359
360         Add Makefile targets for copying static libraries (LLVM and WKSI)
361         <http://webkit.org/b/132619>
362
363         Reviewed by Mark Rowe.
364
365         * Scripts/copy-webkitlibraries-to-product-directory: Set a
366         sensible default for product directory if not specified on
367         either the command-line or in the environment (by Xcode) by
368         calling productDir() in webkitdirs.pm.
369
370 2014-05-06  Brady Eidson  <beidson@apple.com>
371
372         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
373         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
374
375         Reviewed by Sam Weinig.
376
377         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
378
379         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
380         (TestWebKitAPI::itemURLLastComponentIsString):
381         (TestWebKitAPI::didFinishLoadForFrame):
382         (TestWebKitAPI::willGoToBackForwardListItem):
383         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
384         (TestWebKitAPI::setPageLoaderClient):
385         (TestWebKitAPI::TEST):
386         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
387         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
388
389         * WebKitTestRunner/TestController.cpp:
390         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
391
392 2014-05-06  Darin Adler  <darin@apple.com>
393
394         Try to fix iOS build.
395
396         * DumpRenderTree/mac/TestRunnerMac.mm:
397         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
398         Updated since I changed testRunner into a pointer instead of a reference.
399         Updated argument names to avoid conflict with field names.
400         (-[APITestDelegateIPhone run]): Ditto.
401         (-[APITestDelegateIPhone _cleanUp]): Ditto.
402
403 2014-05-06  Commit Queue  <commit-queue@webkit.org>
404
405         Unreviewed, rolling out r168304.
406         https://bugs.webkit.org/show_bug.cgi?id=132607
407
408         Broke the build (Requested by KaL on #webkit).
409
410         Reverted changeset:
411
412         "[GTK][CMake] Unable to do make install"
413         https://bugs.webkit.org/show_bug.cgi?id=130188
414         http://trac.webkit.org/changeset/168304
415
416 2014-05-04  Darin Adler  <darin@apple.com>
417
418         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
419         https://bugs.webkit.org/show_bug.cgi?id=80222
420
421         Reviewed by Alexey Proskuryakov.
422
423         * DumpRenderTree/mac/TestRunnerMac.mm:
424         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
425         do more work here so we don't use RetainPtr local variables.
426         (-[APITestDelegateIPhone dealloc]): Added.
427         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
428         created. Updated for changes to member names and types.
429         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
430         updated for changes to member names and types. Changed to two word spelling.
431         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
432         name of _cleanUp method.
433         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
434         Ditto.
435         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
436
437 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
438
439         Clean up Image Document and tweak the layout and viewport
440         https://bugs.webkit.org/show_bug.cgi?id=132552
441
442         Reviewed by Anders Carlsson.
443
444         * DumpRenderTree/mac/DumpRenderTree.mm:
445         (resetWebPreferencesToConsistentValues):
446         Update the default settings to have something consistent with WebKit2.
447
448 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
449
450         [GTK][CMake] Unable to do make install
451         https://bugs.webkit.org/show_bug.cgi?id=130188
452
453         Reviewed by Carlos Garcia Campos.
454
455         * Scripts/webkitdirs.pm:
456         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
457         will give an early signal that a change has broken the documentation.
458
459 2014-05-05  Pratik Solanki  <psolanki@apple.com>
460
461         Update framework locations in package-root
462         https://bugs.webkit.org/show_bug.cgi?id=132571
463
464         Reviewed by Simon Fraser.
465
466         * Scripts/package-root:
467
468 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
469
470         [EFL][WK2] Refactor favicon database APIs
471         https://bugs.webkit.org/show_bug.cgi?id=132519
472
473         Reviewed by Gyuyoung Kim.
474
475         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
476         (update_view_favicon):
477         (on_icon_changed_cb):
478         (window_free):
479         (on_url_changed):
480         (window_create):
481         (on_view_favicon_changed): Deleted.
482
483 2014-05-02  Mark Rowe  <mrowe@apple.com>
484
485         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
486
487         Reviewed by Dan Bernstein.
488
489         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
490         when determining which LLVM archive to extract.
491
492 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
493
494         Add Jeremy as a committer.
495         https://bugs.webkit.org/show_bug.cgi?id=132492
496
497         Reviewed by Jer Noble.
498
499         Add myself as a committer.
500
501         * Scripts/webkitpy/common/config/contributors.json:
502
503 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
504
505         Add Jeremy as a committer.
506         https://bugs.webkit.org/show_bug.cgi?id=132492
507
508         Reviewed by Jer Noble.
509
510         Add Jeremy Jones to the committers file.
511
512         * Scripts/webkitpy/common/config/contributors.json:
513
514 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
515
516         Hard to figure out how to run a single test with run-api-tests
517         https://bugs.webkit.org/show_bug.cgi?id=116332
518
519         Reviewed by Alexey Proskuryakov.
520
521         * Scripts/run-api-tests: add two examples to the help message.
522
523 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
524
525         Fix several memory leaks found by code inspection
526         https://bugs.webkit.org/show_bug.cgi?id=132472
527
528         Reviewed by Geoffrey Garen.
529         
530         Fix memory leaks.
531
532         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
533         (TestWebKitAPI::TEST):
534         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
535         (WTR::InjectedBundlePage::willSendRequestForFrame):
536         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
537         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
538
539 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
540
541         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
542         https://bugs.webkit.org/show_bug.cgi?id=132446
543
544         Reviewed by Mark Hahnenberg.
545         
546         Test the FTL by default now that it's enabled by default.
547
548         * Scripts/run-javascriptcore-tests:
549
550 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
551
552         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
553         https://bugs.webkit.org/show_bug.cgi?id=132240
554
555         Reviewed by Anders Carlsson.
556
557         Removed ewk_view_setting_tiled_backingstore related code.
558
559         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
560         (DumpRenderTreeChrome::createView):
561         (shouldUseTiledBackingStore): Deleted.
562         * EWebLauncher/main.c:
563         (windowCreate):
564         (parseUserArguments):
565
566 2014-05-01  Anders Carlsson  <andersca@apple.com>
567
568         window.testRunner.keepWebHistory() should update the UI process state
569         https://bugs.webkit.org/show_bug.cgi?id=132440
570
571         Reviewed by Dan Bernstein.
572
573         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
574         (WTR::InjectedBundle::postSetAddsVisitedLinks):
575         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
576         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
577         (WTR::TestRunner::keepWebHistory):
578         * WebKitTestRunner/TestInvocation.cpp:
579         (WTR::TestInvocation::invoke):
580         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
581
582 2014-05-01  David Kilzer  <ddkilzer@apple.com>
583
584         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
585         <http://webkit.org/b/132432>
586
587         Reviewed by Tim Horton.
588
589         * Scripts/webkitperl/FeatureList.pm: Remove support for
590         --plugin-proxy-for-video switch.
591
592 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
593
594         Kernel sysctl interface hw.activecpu don't exists on Linux.
595         https://bugs.webkit.org/show_bug.cgi?id=132286
596
597         Reviewed by Filip Pizlo.
598
599         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
600         calling sysctl over hw.activecpu
601
602 2014-04-30  Anders Carlsson  <andersca@apple.com>
603
604         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
605         https://bugs.webkit.org/show_bug.cgi?id=132399
606         <rdar://problem/15920046>
607
608         Reviewed by Dan Bernstein.
609
610         * Scripts/check-for-webkit-framework-include-consistency:
611         Allos WAK headers in WebKitLegacy as well as WebKit.
612
613         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
614         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
615         Update header imports.
616
617 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
618
619         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
620         https://bugs.webkit.org/show_bug.cgi?id=131954
621
622         Reviewed by Darin Adler.
623         
624         WebKitTestRunner was adding application-specific information to crash reports
625         to log the test path, but only in the web process. Fix it to also do this
626         for the UI process, for both iOS and OS X.
627         
628         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
629         both iOS and OS X.
630         
631         Factored crash reprorter-related code into CrashReporterInfo, and call it from
632         a new TestController::platformWillRunTest() function on Mac and iOS.
633         
634         Also remove Xcode-added unit test junk from the project.
635
636         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
637         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
638         * WebKitTestRunner/TestController.cpp:
639         (WTR::TestController::runTest):
640         * WebKitTestRunner/TestController.h:
641         * WebKitTestRunner/TestInvocation.cpp:
642         (WTR::TestInvocation::url):
643         * WebKitTestRunner/TestInvocation.h:
644         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
645         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
646         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
647         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
648         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
649         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
650         (WTR::testPathFromURL):
651         (WTR::setCrashReportApplicationSpecificInformationToURL):
652         * WebKitTestRunner/efl/TestControllerEfl.cpp:
653         (WTR::TestController::platformWillRunTest):
654         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
655         (WTR::TestController::platformWillRunTest):
656         * WebKitTestRunner/ios/TestControllerIOS.mm:
657         (WTR::TestController::platformWillRunTest):
658         (WTR::TestController::setHidden):
659         * WebKitTestRunner/mac/TestControllerMac.mm:
660         (WTR::TestController::platformWillRunTest):
661
662 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
663
664         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
665
666         Reviewed by Tim Horton.
667
668         * DumpRenderTree/mac/DumpRenderTree.mm:
669         (resetWebPreferencesToConsistentValues):
670         (prepareConsistentTestingEnvironment):
671
672 2014-04-30  Anders Carlsson  <andersca@apple.com>
673
674         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
675         https://bugs.webkit.org/show_bug.cgi?id=132397
676
677         Reviewed by Dan Bernstein.
678
679         * Scripts/check-for-inappropriate-macros-in-external-headers:
680
681 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
682
683         [GTK] Make it easier to run CMake for downstreams
684         https://bugs.webkit.org/show_bug.cgi?id=132370
685
686         Reviewed by Carlos Garcia Campos.
687
688         * Scripts/webkitdirs.pm:
689         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
690         the GTK+ port.
691
692 2014-04-29  Stephanie Lewis  <slewis@apple.com>
693
694         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
695         
696         Rubber stamped by Jessie Berlin.
697
698         JSON.pm was removed from our tools setup.
699
700         * Scripts/generate-coverage-data:
701
702 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
703
704         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
705         https://bugs.webkit.org/show_bug.cgi?id=112840
706
707         Rubber stamped by Geoffrey Garen.
708
709         * Scripts/build-jsc: Enable it on Mac.
710         * Scripts/build-webkit: Enable it on Mac.
711         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
712
713 2014-04-28  Sam Weinig  <sam@webkit.org>
714
715         REGRESSION (r167751): svn-create-patch is very slow
716         https://bugs.webkit.org/show_bug.cgi?id=132300
717
718         Reviewed by Alexey Proskuryakov.
719
720         * Scripts/svn-create-patch:
721         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
722         by calling `svn-create-patch --style`.
723
724 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
725
726         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
727         https://bugs.webkit.org/show_bug.cgi?id=132190
728
729         Reviewed by Gustavo Noronha Silva.
730
731         * Scripts/webkitdirs.pm:
732         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
733             if ninja is in the path.
734         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
735             to the previous ninja generator if not.
736
737 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
738
739         check-webkit-style should understand --git-index
740         https://bugs.webkit.org/show_bug.cgi?id=125364
741
742         Reviewed by Csaba Osztrogonác.
743
744         * Scripts/webkitpy/common/checkout/scm/git.py:
745         (Git.create_patch): The command now supports the --cached option.
746         * Scripts/webkitpy/style/main.py:
747         (CheckWebKitStyle.main): Passing the --git-index option.
748         * Scripts/webkitpy/style/optparser.py:
749         (CommandOptionValues.__init__): The git-index option is switched off by default.
750         (CommandOptionValues.__eq__): Equality check for the new option.
751         (ArgumentParser._create_option_parser):Adding the --git-index option
752         (ArgumentParser.parse):
753         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
754         (CommandOptionValuesTest.test_init): 
755         (CommandOptionValuesTest.test_eq):
756
757 2014-04-28  Michael Saboff  <msaboff@apple.com>
758
759         Crash in platform/mac/accessibility/table-visible-rows.html
760         https://bugs.webkit.org/show_bug.cgi?id=132146
761
762         Reviewed by Filip Pizlo.
763
764         Instead of creating a local JSValueRef array on the stack and passing that to
765         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
766         values using the JSObjectSetPropertyAtIndex() API.
767
768         * DumpRenderTree/AccessibilityUIElement.cpp:
769         (elementsForRangeCallback):
770         (convertElementsToObjectArray):
771         * DumpRenderTree/mac/TestRunnerMac.mm:
772         (originsArrayToJS):
773         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
774         (WTR::EventSendingController::contextClick):
775         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
776         (WTR::stringArrayToJS):
777         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
778         (WTR::convertElementsToObjectArray):
779
780 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
781
782         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
783         "no-cjit" runs force the old-school threshold.
784
785         Rubber stamped by Mark Hahnenberg.
786
787         * Scripts/run-jsc-stress-tests:
788
789 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
790
791         [GTK] install-dependencies should also install ruby-json and ruby-highline
792         https://bugs.webkit.org/show_bug.cgi?id=132292
793
794         Reviewed by Philippe Normand.
795
796         * gtk/install-dependencies: Install ruby json and highline packages.
797
798 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
799
800         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
801         https://bugs.webkit.org/show_bug.cgi?id=132176
802
803         Reviewed by Gyuyoung Kim.
804
805         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
806         and turn off indexedDB feature until the sqlite implementation is introduced.
807
808         * Scripts/webkitperl/FeatureList.pm:
809
810 2014-04-25  James Craig  <jcraig@apple.com>
811
812         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
813         https://bugs.webkit.org/show_bug.cgi?id=132209
814
815         Reviewed by Daniel Bates.
816
817         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
818         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
819
820         * Scripts/prepare-ChangeLog:
821         (main): 
822
823 2014-04-25  Michael Saboff  <msaboff@apple.com>
824
825         Crash in platform/mac/accessibility/table-visible-rows.html
826         https://bugs.webkit.org/show_bug.cgi?id=132146
827
828         Reviewed by Mark Lam.
829
830         Changed to use a local JSValueRef array temporary instead of a
831         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
832         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
833         the temporary values could be collected.
834
835         * DumpRenderTree/AccessibilityUIElement.cpp:
836         (convertElementsToObjectArray):
837         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
838         (WTR::EventSendingController::contextClick):
839         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
840         (WTR::convertElementsToObjectArray):
841
842 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
843
844         Unreviewed GTK gardening
845
846         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
847         (TestRunner):
848
849 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
850
851         prepare-ChangeLog reports as deleted methods that has not been removed.
852         https://bugs.webkit.org/show_bug.cgi?id=131733
853
854         Reviewed by Ryosuke Niwa.
855
856         * Scripts/prepare-ChangeLog:
857         (originalFile): Set merge base to origin/master by default.
858
859 2014-04-23  James Craig  <jcraig@apple.com>
860
861         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
862         https://bugs.webkit.org/show_bug.cgi?id=131115
863
864         Reviewed by Daniel Bates.
865
866         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
867
868         * Scripts/commit-log-editor: Added --no-style.
869         * Scripts/prepare-ChangeLog: Primary patch.
870         (main): Primary patch.
871         (createPatchCommand): Added --no-style.
872         * Scripts/svn-create-patch: Primary patch.
873         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
874         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
875         (SVN.create_patch): Added --no-style.
876
877 2014-04-23  Anders Carlsson  <andersca@apple.com>
878
879         Try to fix iOS build.
880
881         * DumpRenderTree/mac/DumpRenderTree.mm:
882
883 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
884
885         Eliminate internals.setMockScrollbarsEnabled()
886         https://bugs.webkit.org/show_bug.cgi?id=132085
887
888         Reviewed by Tim Horton.
889
890         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
891         No need to reset the preference, there is no way it can change.
892
893 2014-04-23  James Craig  <jcraig@apple.com>
894
895         Unreviewed. Moving myself from Contributors to Committers list.
896
897         * Scripts/webkitpy/common/config/contributors.json:
898
899 2014-04-23  Tim Horton  <timothy_horton@apple.com>
900
901         Mock scrollbars don't always work in DumpRenderTree
902         https://bugs.webkit.org/show_bug.cgi?id=132082
903
904         Reviewed by Alexey Proskuryakov.
905
906         * DumpRenderTree/mac/DumpRenderTree.mm:
907         (prepareConsistentTestingEnvironment):
908         Set the mock scrollbar setting before creating the WebView, as this setting
909         cannot be dynamically changed, so any scrollbars that are created during
910         WebView initialization and are not replaced before snapshotting will end
911         up being platform scrollbars instead of mock ones.
912         WebKitTestRunner already sets this preference before creating WKViews,
913         so we're just matching its behavior.
914
915 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
916
917         [GTK] ShadowRoot API was removed in r164131
918         https://bugs.webkit.org/show_bug.cgi?id=132059
919
920         Reviewed by Gustavo Noronha Silva.
921
922         Add WebKitDOMShadowRoot to the list of deleted classes to generate
923         the API docs.
924
925         * gtk/webkitdom.py:
926         (WebKitDOMDocGenerator):
927
928 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
929
930         [GTK] run-webkit-tests script is failing to invoke run-launcher
931         https://bugs.webkit.org/show_bug.cgi?id=132051
932
933         Reviewed by Philippe Normand.
934
935         After the WK1 support was dropped, if run-webkit-tests is executed
936         without --no-show-results parameter, the launcher is being called
937         using a -2 parameter that is it causing the run-launcher to break.
938
939         * Scripts/webkitpy/port/gtk.py:
940         (GtkPort.show_results_html_file):
941
942 2014-04-22  Tim Horton  <timothy_horton@apple.com>
943
944         DumpRenderTree generates black snapshots on some platforms
945         https://bugs.webkit.org/show_bug.cgi?id=132029
946         <rdar://problem/16679363>
947
948         Reviewed by Simon Fraser.
949
950         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
951         (createBitmapContextFromWebView):
952         DRT checks with the WebView to determine whether it can use the window's
953         backing store directly or (because of compositing) needs to take a WindowServer
954         snapshot. However, on some platforms and in some situations, the window can
955         be layer backed without the WebView necessarily currently being composited.
956         We should check with the window in addition to the WebView before going
957         ahead and using its backing store.
958
959 2014-04-22  Tim Horton  <timothy_horton@apple.com>
960
961         DumpRenderTree generates white snapshots on some platforms
962         https://bugs.webkit.org/show_bug.cgi?id=132026
963         <rdar://problem/16679363>
964
965         Reviewed by Simon Fraser.
966
967         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
968         Link DRT against QuartzCore.
969
970         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
971         (createBitmapContextFromWebView):
972         Force CoreAnimation to synchronously update layers in a more explicit
973         way that doesn't depend on AppKit behavior. This is very similar to what
974         WebKitTestRunner does (indirectly) during its force repaint.
975
976 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
977
978         [Win] Support Python 2.7 in Cygwin
979         https://bugs.webkit.org/show_bug.cgi?id=132023
980
981         Reviewed by Michael Saboff.
982
983         * Scripts/webkitdirs.pm:
984         (checkInstalledTools): Remove check for Python 2.7, since
985         it now works properly.
986
987 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
988
989         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
990         https://bugs.webkit.org/show_bug.cgi?id=130867
991         <rdar://problem/16432456> 
992
993         Reviewed by Mark Hahnenberg.
994
995         * Scripts/build-webkit:
996         * Scripts/copy-webkitlibraries-to-product-directory:
997
998 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
999
1000         [GTK] Fails to build documentation when output is redirected
1001         https://bugs.webkit.org/show_bug.cgi?id=131178
1002
1003         Reviewed by Martin Robinson.
1004
1005         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
1006         explicitly to avoid encoding issues when they are redirected.
1007
1008 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
1009
1010         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
1011         https://bugs.webkit.org/show_bug.cgi?id=131911
1012
1013         Reviewed by Martin Robinson.
1014
1015         common.get_build_path returns release path even though Debug configuration
1016         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
1017
1018         * gtk/ycm_extra_conf.py:
1019         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
1020         (FlagsForFile):
1021
1022 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
1023
1024         Unreviewed build fix.
1025
1026         * DumpRenderTree/mac/EventSendingController.mm:
1027         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1028         Correct a typo that prevented tests from working properly.
1029
1030 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
1031
1032         [GTK] Should have the ability to output composited contents during layout testing
1033         https://bugs.webkit.org/show_bug.cgi?id=131864
1034
1035         Reviewed by Philippe Normand.
1036
1037         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1038         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
1039         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
1040         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1041         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
1042
1043 2014-04-21  Sam Weinig  <sam@webkit.org>
1044
1045         Attempt to fix the tests.
1046
1047         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1048         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1049         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
1050
1051 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
1052
1053         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
1054         being the same as a "quick run", which is meant for genuinely slow tests).
1055
1056         * Scripts/run-jsc-stress-tests:
1057
1058 2014-04-21  Darin Adler  <darin@apple.com>
1059
1060         Add HashSet::takeAny
1061         https://bugs.webkit.org/show_bug.cgi?id=131928
1062
1063         Reviewed by Benjamin Poulain.
1064
1065         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
1066
1067 2014-04-20  Dan Bernstein  <mitz@apple.com>
1068
1069         Fixed a test timing out after r167572.
1070
1071         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1072         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
1073         -webView:didFinishLoadingNavigation:.
1074
1075 2014-04-20  Commit Queue  <commit-queue@webkit.org>
1076
1077         Unreviewed, rolling out r167510.
1078         https://bugs.webkit.org/show_bug.cgi?id=131915
1079
1080         broke GTK Debug bot (Requested by philn on #webkit).
1081
1082         Reverted changeset:
1083
1084         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
1085         it when running layout tests"
1086         https://bugs.webkit.org/show_bug.cgi?id=131472
1087         http://trac.webkit.org/changeset/167510
1088
1089 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
1090
1091         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
1092         https://bugs.webkit.org/show_bug.cgi?id=131472
1093
1094         Reviewed by Philippe Normand.
1095
1096         * Scripts/webkitpy/port/gtk.py:
1097         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
1098         when running WebKitTestRunner with run-webkit-tests.
1099         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
1100         installed.
1101         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
1102         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
1103         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
1104         deal.
1105
1106 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
1107
1108         DownloadDecideDestinationCrash API test uses an incorrect value for path
1109         https://bugs.webkit.org/show_bug.cgi?id=131845
1110         <rdar://problem/15925560>
1111
1112         Reviewed by Enrica Casucci.
1113
1114         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1115         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
1116
1117 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
1118
1119         [Mac] AttributedStringTest API tests fail with async text input
1120         https://bugs.webkit.org/show_bug.cgi?id=131833
1121
1122         Reviewed by Enrica Casucci.
1123
1124         Don't run sync NSTextInputClient tests where we don't implement these calls.
1125
1126         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1127         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1128         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
1129         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1130         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
1131         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
1132         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
1133
1134 2014-04-18  Philippe Normand  <pnormand@igalia.com>
1135
1136         Remove NETWORK_INFO support
1137         https://bugs.webkit.org/show_bug.cgi?id=131841
1138
1139         Reviewed by Gyuyoung Kim.
1140
1141         * Scripts/webkitperl/FeatureList.pm:
1142
1143 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
1144
1145         [GTK] YouCompleteMe doesn't work for cmake build system.
1146         https://bugs.webkit.org/show_bug.cgi?id=131591
1147
1148         Reviewed by Martin Robinson.
1149
1150         Add cmake build system support for YouCompleteMe. It should work regardless of
1151         using make or ninja. In addition, autotools related code is removed since it's
1152         not used anymore in WebKit.
1153
1154         * Scripts/webkitdirs.pm:
1155         (generateBuildSystemFromCMakeProject):
1156         * gtk/ycm_extra_conf.py:
1157         (transform_relative_paths_to_absolute_paths):
1158         (FlagsForFile):
1159
1160 2014-04-17  Anders Carlsson  <andersca@apple.com>
1161
1162         Fix build.
1163
1164         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1165         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1166         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1167
1168 2014-04-17  Anders Carlsson  <andersca@apple.com>
1169
1170         Remove unused API enums
1171         https://bugs.webkit.org/show_bug.cgi?id=131836
1172
1173         Reviewed by Tim Horton.
1174
1175         * MiniBrowser/mac/WK2BrowserWindowController.m:
1176         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
1177
1178 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
1179
1180         [Win] A few final cleanups to the DataObject classes.
1181         https://bugs.webkit.org/show_bug.cgi?id=131784
1182
1183         Reviewed by Anders Carlsson.
1184
1185         * DumpRenderTree/win/DRTDataObject.cpp:
1186         (DRTDataObject::clearData): Use 'last()' method.
1187         * DumpRenderTree/win/UIDelegate.cpp:
1188         (DRTUndoStack::pop): Use 'takeLast()' method.
1189
1190 2014-04-17  Andres Gomez  <agomez@igalia.com>
1191
1192         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
1193         https://bugs.webkit.org/show_bug.cgi?id=131365
1194
1195         Reviewed by Brent Fulgham.
1196
1197         The cygwin installer is now downloading the wanted versions for
1198         the local installation given to the setup wizard.
1199
1200         * CygwinDownloader/cygwin-downloader.py:
1201         * CygwinDownloader/cygwin-downloader.zip:
1202
1203 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
1204
1205         [GTK] Make run-webkit-tests always use WKTR
1206         https://bugs.webkit.org/show_bug.cgi?id=131737
1207
1208         Reviewed by Darin Adler.
1209
1210         Now that the GTK+ port only has support for WebKit2, instruct
1211         run-webkit-tests to always use WKTR. This avoids needing to pass
1212         flag "-2" every time.
1213
1214         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
1215         (_set_up_derived_options): Always set webkit_test_runner when
1216         the platform is GTK+.
1217
1218 2014-04-17  Brendan Long  <b.long@cablelabs.com>
1219
1220         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
1221         https://bugs.webkit.org/show_bug.cgi?id=131760
1222
1223         Reviewed by Philippe Normand.
1224
1225         * gtk/install-dependencies: Install ninja-build when it's available.
1226
1227 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
1228
1229         [Win] run-javascriptcore-tests fails to run.
1230         https://bugs.webkit.org/show_bug.cgi?id=131761
1231
1232         Reviewed by Brent Fulgham.
1233
1234         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
1235
1236 2014-04-16  Andres Gomez  <agomez@igalia.com>
1237
1238         [Win] Pass default parameters to cygwin setup wizard
1239         https://bugs.webkit.org/show_bug.cgi?id=131361
1240
1241         Reviewed by Brent Fulgham.
1242
1243         Added some parameters to the cygwin setup wizard so the user
1244         doesn't really have to do any interaction.
1245
1246         * CygwinDownloader/cygwin-downloader.py:
1247         * CygwinDownloader/cygwin-downloader.zip:
1248
1249 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
1250
1251         [Win] Eliminate use of deleteAllValues in Windows Files
1252         https://bugs.webkit.org/show_bug.cgi?id=131631
1253
1254         Reviewed by Darin Adler.
1255
1256         Switch to std::unique_ptr for memory lifetime. Get rid of
1257         deleteAllValues now that it is no longer needed. Use ranged
1258         for loops where possible.
1259
1260         * DumpRenderTree/win/DRTDataObject.cpp:
1261         (WCEnumFormatEtc::WCEnumFormatEtc):
1262         (DRTDataObject::~DRTDataObject):
1263         (DRTDataObject::GetData):
1264         (DRTDataObject::QueryGetData):
1265         (DRTDataObject::SetData):
1266         (DRTDataObject::clearData):
1267         * DumpRenderTree/win/DRTDataObject.h:
1268         * DumpRenderTree/win/UIDelegate.cpp:
1269         (DRTUndoObject::DRTUndoObject):
1270         (DRTUndoObject::~DRTUndoObject):
1271         (DRTUndoStack::~DRTUndoStack):
1272         (DRTUndoStack::clear):
1273         (DRTUndoStack::pop):
1274         (DRTUndoManager::DRTUndoManager):
1275         (DRTUndoManager::redo):
1276         (DRTUndoManager::undo):
1277         (UIDelegate::UIDelegate):
1278         (UIDelegate::resetUndoManager):
1279         * DumpRenderTree/win/UIDelegate.h:
1280
1281 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1282
1283         [GTK] Unreviewed GTK gardening.
1284
1285         Update list of skipped unit tests:
1286
1287           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
1288
1289           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
1290           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
1291
1292         * Scripts/run-gtk-tests:
1293         (TestRunner):
1294
1295 2014-04-16  Tim Horton  <timothy_horton@apple.com>
1296
1297         check-webkit-style doesn't check code style in .mm or .m files
1298         https://bugs.webkit.org/show_bug.cgi?id=131708
1299
1300         Reviewed by Darin Adler.
1301
1302         * Scripts/webkitpy/style/checker.py:
1303         * Scripts/webkitpy/style/checker_unittest.py:
1304         (CheckerDispatcherDispatchTest.test_cpp_paths):
1305         (CheckerDispatcherDispatchTest.test_text_paths):
1306         Check .mm and .m files as C++.
1307
1308         * Scripts/webkitpy/style/checkers/cpp.py:
1309         (check_spacing):
1310         Add an override for our ordinary "missing spaces around =" for @synthesize,
1311         which should look like "@synthesize propertyName=_varName;"
1312
1313         Add an override for "missing space before {" for blocks' "^{".
1314
1315         Don't follow the "extra space before [" rule for Objective-C, because
1316         it breaks this rule in a multitude of ways because of method calls.
1317
1318         (check_braces):
1319         Don't complain about { not being on the end of the previous line if
1320         the previous line starts with "- (" or "+ (", which would indicate a
1321         Objective-C method definition.
1322
1323 2014-04-16  Darin Adler  <darin@apple.com>
1324
1325         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
1326         https://bugs.webkit.org/show_bug.cgi?id=131735
1327
1328         Reviewed by Alexey Proskuryakov.
1329
1330         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
1331         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
1332         is on the right. This can be confusing since our JavaScript test framework does it the opposite
1333         way, but gtest works better this way.
1334
1335 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
1336
1337         [EFL] Fix problems with the pixel dump.
1338         https://bugs.webkit.org/show_bug.cgi?id=131265
1339
1340         Reviewed by Gyuyoung Kim.
1341
1342         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
1343         However pixel dump codes still call deprecated functions like ewk_view_paint(),
1344         which causes that nothing is drawn.
1345
1346         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
1347         One of new functions is AcceleratedCompositingContext::extractImageData(),
1348         which replaces deprecated function calls. Besides the extractImageData() is invoked by
1349         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
1350
1351         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1352         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
1353
1354 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
1355
1356         Update LLVM export scrpt to handle the build directory being different from the
1357         source directory.
1358
1359         Rubber stamped by Geoffrey Garen.
1360
1361         * Scripts/export-llvm-build:
1362
1363 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
1364
1365         Update the hyperlink to waterfall views of perf bots on build.webkit.org
1366         https://bugs.webkit.org/show_bug.cgi?id=131695
1367
1368         Reviewed by Antti Koivisto.
1369
1370         Updated.
1371
1372         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1373
1374 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1375
1376         [GTK] Reduce the binary size by compressing the text based web inspector resources
1377         https://bugs.webkit.org/show_bug.cgi?id=121545
1378
1379         Reviewed by Gustavo Noronha Silva.
1380
1381         Compress text based files when compiling inspector resources. It
1382         reduces the binary size in 3MB.
1383
1384         * gtk/generate-inspector-gresource-manifest.py:
1385         (find_all_files_in_directory):
1386         (is_compressible):
1387
1388 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1389
1390         Remove Gtk WebKit1 tester.
1391
1392         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
1393         results over and over as fast as it could.
1394
1395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1396         (WebKitBuildbot):
1397
1398 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1399
1400         Wrong link for webkitpy tests results in dashboard popover
1401         https://bugs.webkit.org/show_bug.cgi?id=131664
1402
1403         Reviewed by Timothy Hatcher.
1404
1405         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1406         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
1407         Use a correct link.
1408
1409 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1410
1411         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
1412
1413         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
1414
1415         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1416         (CommitMessageForThisCommitTest):
1417
1418 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1419
1420         Fix commit-log-editor bug revealed by r165447
1421         https://bugs.webkit.org/show_bug.cgi?id=130676
1422
1423         Reviewed by Csaba Osztrogonác.
1424
1425         * Scripts/commit-log-editor:
1426         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
1427         Add \n before the first block too, because the longest common prefix now ends with only one newline.
1428         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
1429         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
1430
1431 2014-04-13  Darin Adler  <darin@apple.com>
1432
1433         userVisibleString should not try to "encode" host names
1434         https://bugs.webkit.org/show_bug.cgi?id=131587
1435         rdar://problem/14686849
1436
1437         Reviewed by Alexey Proskuryakov.
1438
1439         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
1440
1441         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
1442         Coverage is tiny at this point; we could add a lot more cases!
1443
1444 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1445
1446         Use #include instead of #import
1447         https://bugs.webkit.org/show_bug.cgi?id=131604
1448
1449         Reviewed by Darin Adler.
1450
1451         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
1452
1453         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1454
1455 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
1456
1457         Make slow-stress tests run faster by running fewer VM variants.
1458
1459         Rubber stamped by Geoffrey Garen.
1460
1461         * Scripts/run-javascriptcore-tests:
1462         * Scripts/run-jsc-stress-tests:
1463
1464 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
1465
1466         [CMake] Add missing WTF unit tests
1467         https://bugs.webkit.org/show_bug.cgi?id=131459
1468
1469         Reviewed by Martin Robinson.
1470
1471         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1472         that should be compiled into the TestWTF binary.
1473
1474 2014-04-10  Brendan Long  <b.long@cablelabs.com>
1475
1476         [Gtk] run-launcher doesn't work by default
1477         https://bugs.webkit.org/show_bug.cgi?id=131494
1478
1479         Reviewed by Philippe Normand.
1480
1481         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1482         * Scripts/webkitdirs.pm:
1483         (launcherName): Same.
1484         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1485         * gtk/common.py:
1486         (get_build_path.is_valid_build_directory): Same.
1487         * gtk/manifest.txt: Same.
1488
1489 2014-04-09  Commit Queue  <commit-queue@webkit.org>
1490
1491         Unreviewed, rolling out r167046.
1492         https://bugs.webkit.org/show_bug.cgi?id=131479
1493
1494         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1495         on #webkit).
1496
1497         Reverted changeset:
1498
1499         "Remove "System Font" from whitelisted DRT fonts and char
1500         width calculations"
1501         https://bugs.webkit.org/show_bug.cgi?id=131411
1502         http://trac.webkit.org/changeset/167046
1503
1504 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1505
1506         Remove "System Font" from whitelisted DRT fonts and char width calculations
1507         https://bugs.webkit.org/show_bug.cgi?id=131411
1508
1509         Reviewed by Tim Horton.
1510
1511         Covered by existing tests.
1512
1513         * DumpRenderTree/mac/DumpRenderTree.mm:
1514         (allowedFontFamilySet):
1515
1516 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1517
1518         systemHiddenFontFamilySet in DRT is unnecessary
1519         https://bugs.webkit.org/show_bug.cgi?id=131414
1520
1521         Reviewed by Tim Horton.
1522
1523         It doesn't seem to affect test results on my machine.
1524
1525         * DumpRenderTree/mac/DumpRenderTree.mm:
1526         (drt_NSFontManager_availableFonts):
1527         (systemHiddenFontFamilySet): Deleted.
1528
1529 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1530
1531         [Win] Unreviewed test fix: Don't double-release BSTR.
1532
1533         * DumpRenderTree/win/DumpRenderTree.cpp:
1534         (dump): Remove unneeded call to SysFreeString now that we are
1535         using _bstr_t for this variable.
1536
1537 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1538
1539         [Win] Various DumpRenderTree Fixes.
1540         https://bugs.webkit.org/show_bug.cgi?id=131446.
1541
1542         Reviewed by Tim Horton.
1543
1544         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1545         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1546         (AccessibilityUIElement::description): Ditto.
1547         (AccessibilityUIElement::helpText): Ditto.
1548         (AccessibilityUIElement::intValue): Ditto.
1549         (AccessibilityUIElement::isPressActionSupported): Ditto.
1550         (AccessibilityUIElement::accessibilityValue): Ditto.
1551         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1552         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1553         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1554         (DRTDesktopNotificationPresenter::Release): Ditto.
1555         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1556         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1557         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1558         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1559         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1560         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1561         * DumpRenderTree/win/DumpRenderTree.cpp:
1562         (dumpFrameScrollPosition): Ditto.
1563         (dumpFramesAsText): Ditto.
1564         (compareHistoryItems): Ditto.
1565         (dumpHistoryItem): Ditto.
1566         (dump): Ditto.
1567         (resetDefaultsToConsistentValues): Ditto.
1568         (resetWebViewToConsistentStateBeforeTesting): Ditto.
1569         (runTest): Ditto.
1570         (createWebViewAndOffscreenWindow): Ditto.
1571         * DumpRenderTree/win/EditingDelegate.cpp:
1572         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1573         (EditingDelegate::AddRef): Ditto.
1574         (EditingDelegate::Release): Ditto.
1575         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
1576         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
1577         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1578         (EditingDelegate::shouldInsertNode): Ditto.
1579         (EditingDelegate::shouldInsertText): Ditto.
1580         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1581         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1582         (EditingDelegate::shouldApplyStyle): Ditto.
1583         (EditingDelegate::shouldChangeTypingStyle): Ditto.
1584         (EditingDelegate::doPlatformCommand): Ditto.
1585         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1586         (EditingDelegate::webViewDidChange): Ditto.
1587         (EditingDelegate::webViewDidEndEditing): Ditto.
1588         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
1589         (EditingDelegate::webViewDidChangeSelection): Ditto.
1590         (EditingDelegate::checkSpellingOfString): Ditto.
1591         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1592         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1593         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
1594         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1595         (FrameLoadDelegate::AddRef): Ditto.
1596         (FrameLoadDelegate::Release): Ditto.
1597         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1598         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
1599         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
1600         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
1601         (FrameLoadDelegate::didReceiveTitle): Ditto.
1602         (FrameLoadDelegate::didChangeIcons): Ditto.
1603         (delegatesWithDelayedWork): Ditto.
1604         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
1605         (FrameLoadDelegate::didFailLoadWithError): Ditto.
1606         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
1607         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
1608         (FrameLoadDelegate::willCloseFrame): Ditto.
1609         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
1610         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
1611         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1612         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
1613         (FrameLoadDelegate::didRunInsecureContent): Ditto.
1614         * DumpRenderTree/win/FrameLoadDelegate.h:
1615         * DumpRenderTree/win/HistoryDelegate.cpp:
1616         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1617         (HistoryDelegate::updateHistoryTitle): Ditto.
1618         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
1619         * DumpRenderTree/win/PolicyDelegate.cpp:
1620         (dumpPath):
1621         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1622         (PolicyDelegate::AddRef): Ditto.
1623         (PolicyDelegate::Release): Ditto.
1624         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1625         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
1626         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1627         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1628         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1629         (ResourceLoadDelegate::AddRef): Ditto.
1630         (ResourceLoadDelegate::Release): Ditto.
1631         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1632         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
1633         (ResourceLoadDelegate::willSendRequest): Ditto.
1634         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
1635         (ResourceLoadDelegate::didReceiveResponse): Ditto.
1636         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
1637         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
1638         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1639         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1640         (TestRunner::setUserStyleSheetLocation): Ditto.
1641         (TestRunner::execCommand): Ditto.
1642         (TestRunner::overridePreference): Ditto.
1643         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
1644         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
1645         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1646         (TextInputController::insertText): Ditto.
1647         * DumpRenderTree/win/UIDelegate.cpp:
1648         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1649         (UIDelegate::AddRef): Ditto.
1650         (UIDelegate::Release): Ditto.
1651         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1652         (UIDelegate::trackCustomPopupMenu): Ditto.
1653         (UIDelegate::registerUndoWithTarget): Ditto.
1654         (UIDelegate::removeAllActionsWithTarget): Ditto.
1655         (UIDelegate::setActionTitle): Ditto.
1656         (UIDelegate::undo): Ditto.
1657         (UIDelegate::redo): Ditto.
1658         (UIDelegate::canUndo): Ditto.
1659         (UIDelegate::canRedo): Ditto.
1660         (UIDelegate::printFrame): Ditto.
1661         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
1662         (UIDelegate::webViewHeaderHeight): Ditto.
1663         (UIDelegate::webViewFooterHeight): Ditto.
1664         (UIDelegate::drawHeaderInRect): Ditto.
1665         (UIDelegate::drawFooterInRect): Ditto.
1666         (UIDelegate::webViewPrintingMarginRect): Ditto.
1667         (UIDelegate::canRunModal): Ditto.
1668         (UIDelegate::createModalDialog): Ditto.
1669         (UIDelegate::runModal): Ditto.
1670         (UIDelegate::isMenuBarVisible): Ditto.
1671         (UIDelegate::setMenuBarVisible): Ditto.
1672         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
1673         (UIDelegate::paintCustomScrollbar): Ditto.
1674         (UIDelegate::paintCustomScrollCorner): Ditto.
1675         (UIDelegate::setFrame): Ditto.
1676         (UIDelegate::webViewFrame): Ditto.
1677         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
1678         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1679         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1680         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1681         (UIDelegate::webViewAddMessageToConsole): Ditto.
1682         (UIDelegate::doDragDrop): Ditto.
1683         (UIDelegate::webViewGetDlgCode): Ditto.
1684         (UIDelegate::createWebViewWithRequest): Ditto.
1685         (UIDelegate::webViewClose): Ditto.
1686         (UIDelegate::webViewFocus): Ditto.
1687         (UIDelegate::webViewUnfocus): Ditto.
1688         (UIDelegate::webViewPainted): Ditto.
1689         (UIDelegate::exceededDatabaseQuota): Ditto.
1690         (UIDelegate::embeddedViewWithArguments): Ditto.
1691         (UIDelegate::webViewClosing): Ditto.
1692         (UIDelegate::webViewSetCursor): Ditto.
1693         (UIDelegate::webViewDidInvalidate): Ditto.
1694         (UIDelegate::setStatusText): Ditto.
1695         (UIDelegate::desktopNotificationsDelegate): Ditto.
1696         (UIDelegate::drawBackground): Ditto.
1697         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
1698         (UIDelegate::didPressMissingPluginButton): Ditto.
1699         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
1700         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
1701         (LoadHTMLStringItem::invoke): Ditto.
1702         (ScriptItem::invoke): Ditto.
1703
1704 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1705
1706         Stylechecker: False positive on inline asm code.
1707         https://bugs.webkit.org/show_bug.cgi?id=130570
1708
1709         Reviewed by Csaba Osztrogonác.
1710
1711         Disable stylechecking in asm blocks.
1712
1713         * Scripts/webkitpy/style/checkers/cpp.py:
1714         (process_line):
1715         (_InlineASMState):
1716         (_InlineASMState.__init__):
1717         (_InlineASMState.process_line):
1718         (_InlineASMState.isInside):
1719         (_process_lines):
1720         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1721         (WebKitStyleTest.test_member_initialization_list):
1722
1723 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1724
1725         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
1726         https://bugs.webkit.org/show_bug.cgi?id=131029
1727
1728         Reviewed by Philippe Normand.
1729
1730         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
1731         tests and remove the getWebKit1TestResoucesDir() method.
1732
1733         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1734         (testDownloadLocalFile): Use Test::getResourcesDir().
1735         (testDownloadLocalFileError): Ditto.
1736         (serverCallback): Ditto.
1737         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1738         (serverCallback): Ditto.
1739         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1740         (httpServerCallback): Ditto.
1741         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1742         (serverCallback): Ditto.
1743         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
1744         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
1745         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1746         (Test::getWebKit1TestResoucesDir): Deleted.
1747
1748 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1749
1750         [WK2] HTTP authentication regression tests fail
1751         https://bugs.webkit.org/show_bug.cgi?id=81627
1752         <rdar://problem/11079296>
1753
1754         Reviewed by Anders Carlsson.
1755
1756         * WebKitTestRunner/TestController.h:
1757         * WebKitTestRunner/TestController.cpp:
1758         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
1759         to pageLoaderClient structure.
1760         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
1761         for password based authentication (we do get server trust challenges on some tests,
1762         which WKTR can't handle).
1763         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
1764         calls won't be made, at least on CFNetwork based platforms.
1765         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
1766         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
1767         make sense to associate auth requests with individual resources - there can be
1768         multiple resources loading at once from the same protection space, so WebKit1 API
1769         that had a resource identifier was inherently racy.
1770
1771 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
1772
1773         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
1774         https://bugs.webkit.org/show_bug.cgi?id=131427
1775
1776         Reviewed by Gyuyoung Kim.
1777
1778         Since r166973, font path was changed.
1779
1780         * DumpRenderTree/PlatformEfl.cmake:
1781         * WebKitTestRunner/PlatformEfl.cmake:
1782
1783 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1784
1785         Fix the build-jsc build
1786         https://bugs.webkit.org/show_bug.cgi?id=131410
1787
1788         Reviewed by Michael Saboff.
1789
1790         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
1791         WTF depends on it.
1792
1793 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1794
1795         [GTK] Remove WebKit1 unit tests
1796         https://bugs.webkit.org/show_bug.cgi?id=131359
1797
1798         Reviewed by Anders Carlsson.
1799
1800         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
1801         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
1802         they were inadvertently left in http://trac.webkit.org/changeset/166504.
1803
1804         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
1805         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
1806         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
1807         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
1808         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
1809         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
1810         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
1811         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
1812         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
1813         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
1814         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
1815         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
1816         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
1817         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
1818         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
1819         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
1820         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
1821         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
1822         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
1823         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
1824         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
1825         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
1826         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
1827         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
1828         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
1829         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
1830         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
1831         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
1832         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
1833         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
1834         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
1835         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
1836         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
1837         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
1838         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
1839         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
1840         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
1841         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
1842
1843 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1844
1845         Unreviewed gardening (Take 2): Prevent users from attempting
1846         to build with known invalid cURL. 
1847
1848         * Scripts/webkitdirs.pm:
1849         (checkInstalledTools): Check for 7.34.0 (the broken version), not
1850         7.33.0 (the known good version).
1851
1852 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1853
1854         [GTK] Remove DumpRenderTree and GtkLauncher
1855         https://bugs.webkit.org/show_bug.cgi?id=131373
1856
1857         Reviewed by Andreas Kling.
1858
1859         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
1860         no longer necessary now that WebKit1 GTK+ will be removed.
1861
1862         * CMakeLists.txt:
1863         * DumpRenderTree/PlatformGTK.cmake: Removed.
1864         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
1865         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
1866         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
1867         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
1868         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
1869         * DumpRenderTree/gtk/EventSender.cpp: Removed.
1870         * DumpRenderTree/gtk/EventSender.h: Removed.
1871         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
1872         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
1873         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
1874         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
1875         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
1876         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
1877         * DumpRenderTree/gtk/TextInputController.h: Removed.
1878         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
1879         * GtkLauncher/CMakeLists.txt: Removed.
1880         * GtkLauncher/LauncherInspectorWindow.c: Removed.
1881         * GtkLauncher/LauncherInspectorWindow.h: Removed.
1882         * GtkLauncher/main.c: Removed.
1883         * GtkLauncher/simple.svg: Removed.
1884         * GtkLauncher/text.html: Removed.
1885         * WebKitTestRunner/PlatformGTK.cmake:
1886         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
1887         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
1888         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
1889
1890 2014-04-08  Mark Rowe  <mrowe@apple.com>
1891
1892         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
1893         <https://webkit.org/b/131388> / <rdar://problem/16291687>
1894
1895         Reviewed by Alexey Proskuryakov.
1896
1897         * Scripts/webkitdirs.pm:
1898         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
1899         (execMacWebKitAppForDebugging): Ditto.
1900
1901 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1902
1903         Build bmalloc on iOS too
1904         https://bugs.webkit.org/show_bug.cgi?id=131381
1905
1906         Reviewed by Andreas Kling.
1907
1908         * Scripts/build-webkit:
1909
1910 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1911
1912         Unreviewed gardening: Prevent users from attempting
1913         to build with known invalid cURL.
1914
1915         * Scripts/webkitdirs.pm:
1916         (checkInstalledTools): Block build attempts with bad
1917         Cygwin tool set.
1918
1919 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
1920
1921         Build bmalloc on Mac
1922         https://bugs.webkit.org/show_bug.cgi?id=131333
1923
1924         Reviewed by Mark Rowe.
1925
1926         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
1927         (Note: Just testing Mac is not good enough because in this
1928         script 'Mac' means 'Mac or iOS'.)
1929
1930 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
1931
1932         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
1933         https://bugs.webkit.org/show_bug.cgi?id=130951
1934
1935         Reviewed by Geoffrey Garen.
1936
1937         * Scripts/run-javascriptcore-tests:
1938
1939 2014-04-06  Darin Adler  <darin@apple.com>
1940
1941         Rework CSS calc logic, fixing some reference count mistakes in Length
1942         https://bugs.webkit.org/show_bug.cgi?id=131280
1943
1944         Reviewed by Andreas Kling.
1945
1946         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
1947         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
1948
1949 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
1950
1951         Enable WEB_REPLAY for PLATFORM(MAC)
1952         https://bugs.webkit.org/show_bug.cgi?id=130700
1953
1954         Reviewed by Timothy Hatcher.
1955
1956         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
1957
1958 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1959
1960         [CMake] Include X11's include dirs in TestNetscapePlugin
1961         https://bugs.webkit.org/show_bug.cgi?id=131270
1962
1963         Reviewed by Martin Robinson.
1964
1965         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
1966         TestNetscapePlugin includes WebCore code that includes X headers.
1967
1968 2014-04-05  David Kilzer  <ddkilzer@apple.com>
1969
1970         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
1971         <http://webkit.org/b/130986>
1972
1973         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
1974         prefix to TileCache class names in exception list.
1975
1976 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1977
1978         [GTK] kill-old-processes should kill dbus-daemon processes
1979         https://bugs.webkit.org/show_bug.cgi?id=127352
1980
1981         Reviewed by Martin Robinson.
1982
1983         * BuildSlaveSupport/kill-old-processes:
1984         (main):
1985
1986 2014-04-04  Andres Gomez  <agomez@igalia.com>
1987
1988         [Win] Update obsolete packages in cygwin
1989         https://bugs.webkit.org/show_bug.cgi?id=126264
1990
1991         Reviewed by Brent Fulgham.
1992
1993         Removed "apache" and "minires" as the first has been replaced by
1994         "lighttpd" and the second is now integrated into
1995         "cygwin". Replaced the transitional and now obsolete "gcc" package
1996         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
1997         since the newer version available is "2.7.3" which breaks the
1998         build due to some funniness with environment variable handling.
1999
2000         * CygwinDownloader/cygwin-downloader.py:
2001         * CygwinDownloader/cygwin-downloader.zip:
2002
2003 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
2004
2005         check-webkit-style: Improve warnings on Objective-C @property syntax
2006         https://bugs.webkit.org/show_bug.cgi?id=131200
2007
2008         Reviewed by Dan Bernstein.
2009
2010         * Scripts/webkitpy/style/checkers/cpp.py:
2011         (check_spacing):
2012         (CppChecker):
2013         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2014         (CppStyleTest.test_spacing_in_objective_c_properties):
2015
2016 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2017
2018         Unreviewed. Moving my name to commiter section
2019
2020         * Scripts/webkitpy/common/config/contributors.json:
2021
2022 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2023
2024         Unreviewed. Add myself as a committer.
2025
2026         * Scripts/webkitpy/common/config/contributors.json:
2027
2028 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
2029
2030         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
2031         https://bugs.webkit.org/show_bug.cgi?id=130391
2032
2033         Reviewed by Gyuyoung Kim.
2034
2035         Change the implementation of the zoom functionality from ewk_view_scale_set
2036         to ewk_view_page_zoom_set.
2037
2038         * MiniBrowser/efl/main.c:
2039
2040 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2041
2042         [webkitpy] perf profiler does not understand --call-graph argument
2043         https://bugs.webkit.org/show_bug.cgi?id=131132
2044
2045         Reviewed by Ryosuke Niwa.
2046
2047         New versions of perf profiler have changed the argument from --call-graph to -g.
2048
2049         * Scripts/webkitpy/common/system/profiler.py:
2050         (Perf.wrapper_arguments): Use -g instead of --call-graph.
2051         * Scripts/webkitpy/port/driver_unittest.py:
2052         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
2053
2054 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2055
2056         Add EFL WK2 performance bot to build.webkit.org
2057         https://bugs.webkit.org/show_bug.cgi?id=131034
2058
2059         Fix after r166707, use "Perf" instead of "perf" for consistency.
2060
2061         Reviewed by Csaba Osztrogonác.
2062
2063         * BuildSlaveSupport/build.webkit.org-config/config.json:
2064
2065 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2066
2067         Add EFL WK2 performance bot to build.webkit.org
2068         https://bugs.webkit.org/show_bug.cgi?id=131034
2069
2070         Reviewed by Csaba Osztrogonác.
2071
2072         * BuildSlaveSupport/build.webkit.org-config/config.json:
2073
2074 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
2075
2076         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
2077         https://bugs.webkit.org/show_bug.cgi?id=131151
2078
2079         Reviewed by Gyuyoung Kim.
2080
2081         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
2082         (TouchEventInfo::TouchEventInfo):
2083         (sendTouchEvent):
2084         (addTouchPointCallback):
2085         (updateTouchPointCallback):
2086         (cancelTouchPointCallback):
2087         (releaseTouchPointCallback):
2088
2089 2014-04-02  David Kilzer  <ddkilzer@apple.com>
2090
2091         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
2092         <http://webkit.org/b/131045>
2093
2094         Reviewed by Daniel Bates.
2095
2096         * Scripts/filter-build-webkit:
2097         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
2098         of clang, plus debug data for all DVTAssertions.
2099
2100 2014-04-01  Dean Jackson  <dino@apple.com>
2101
2102         Load Media Controls js/css from bundle
2103         https://bugs.webkit.org/show_bug.cgi?id=131086
2104
2105         Reviewed by Eric Carlson.
2106
2107         We're now putting CSS files into the bundle, so remove the test for them.
2108
2109         * Scripts/check-for-inappropriate-files-in-framework:
2110
2111 2014-04-02  Martin Hock  <mhock@apple.com>
2112
2113         Unify private browsing with sessions.
2114         https://bugs.webkit.org/show_bug.cgi?id=130099
2115
2116         Reviewed by Alexey Proskuryakov.
2117
2118         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
2119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2120         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2121         (TestWebKitAPI::didNavigateWithNavigationData):
2122         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2123         (TestWebKitAPI::TEST):
2124
2125         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
2126         (TestWebKitAPI::didNavigateWithoutNavigationData):
2127         (TestWebKitAPI::didNavigateWithNavigationData):
2128         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2129         (TestWebKitAPI::TEST):
2130
2131 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
2132
2133         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
2134         https://bugs.webkit.org/show_bug.cgi?id=130343
2135
2136         Reviewed by Gustavo Noronha Silva.
2137
2138         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
2139         of directories on the command line and look for all appropriate files in those directories for the
2140         GResource archive. Also make archive paths relative to those directories.
2141         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
2142         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
2143
2144 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2145
2146         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
2147         https://bugs.webkit.org/show_bug.cgi?id=131106
2148
2149         Reviewed by Csaba Osztrogonác.
2150
2151         * Scripts/webkitpy/tool/commands/download.py:
2152         (AbstractRolloutPrepCommand._prepare_state):
2153         * Scripts/webkitpy/tool/commands/download_unittest.py:
2154         (test_prepare_rollout):
2155         (test_create_rollout):
2156         (test_create_rollout_resolved):
2157         (test_rollout):
2158
2159 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
2160
2161         [EFL] Add option to use separate web process for new window in MiniBrowser
2162         https://bugs.webkit.org/show_bug.cgi?id=130190
2163
2164         Reviewed by Gyuyoung Kim.
2165
2166         New created window (CTRL + n) will be open in separated web process.
2167         This option is enabled by adding a flag (S/separate-process) with launching
2168         MiniBrowser.
2169
2170         * MiniBrowser/efl/main.c:
2171         (elm_main):
2172
2173 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2174
2175         [GTK] Move NEWS file to a new location
2176         https://bugs.webkit.org/show_bug.cgi?id=130901
2177
2178         Reviewed by Brent Fulgham.
2179
2180         * gtk/manifest.txt: Update the NEWS file path.
2181
2182 2014-04-01  Anders Carlsson  <andersca@apple.com>
2183
2184         Fix build.
2185
2186         * MiniBrowser/mac/WK2BrowserWindowController.m:
2187         (-[WK2BrowserWindowController awakeFromNib]):
2188         (-[WK2BrowserWindowController dealloc]):
2189         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2190
2191 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
2192
2193         Unreviewed test gardening.
2194
2195         * Scripts/webkitpy/port/base_unittest.py:
2196         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
2197
2198 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
2199
2200         [CSS Exclusions] Remove exclusions parsing support
2201         https://bugs.webkit.org/show_bug.cgi?id=131046
2202
2203         Reviewed by David Hyatt.
2204
2205         * Scripts/webkitperl/FeatureList.pm:
2206
2207 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2208
2209         [GTK] Remove last reference to GTK+ WK1 EWS
2210         https://bugs.webkit.org/show_bug.cgi?id=131058
2211
2212         Reviewed by Martin Robinson.
2213
2214         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
2215
2216         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
2217
2218 2014-04-01  Lucas Forschler  <lforschler@apple.com>
2219
2220         Add a 32bit JSC builder/tester.
2221         https://bugs.webkit.org/show_bug.cgi?id=131054
2222         
2223         Reviewed by Michael Saboff.
2224
2225         * BuildSlaveSupport/build.webkit.org-config/config.json:
2226         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2227         (Compile32bitJSC):
2228         (Run32bitJSCTests):
2229         (Run32bitJSCTests.countFailures):
2230         (BuildAndTest32bitJSCFactory):
2231         (BuildAndTest32bitJSCFactory.__init__):
2232
2233 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
2234
2235         [GTK] No longer build WebKit1 gtkdoc
2236         https://bugs.webkit.org/show_bug.cgi?id=130970
2237
2238         Reviewed by Anders Carlsson.
2239
2240         * gtk/common.py:
2241         (gtk_version_of_pkg_config_file): Deleted.
2242         * gtk/generate-gtkdoc:
2243         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
2244         was only applicable for WebKit1.
2245         (get_generator_for_config): No longer look for the WebKit1 configuration file.
2246
2247 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
2248
2249         [GTK] Running minibrowser with url crashes in debug build
2250         https://bugs.webkit.org/show_bug.cgi?id=130492
2251
2252         Reviewed by Martin Robinson.
2253
2254         Update "uri-scheme" test not to use invalid URIs in it, so we
2255         don't get a mistmatch when comparing the original URI stored in
2256         the test class with the one returned by the WebKitWebView.
2257
2258         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2259         (testWebContextURIScheme): Update the test.
2260
2261 2014-04-01  Mihai Tica  <mitica@adobe.com>
2262
2263         Unreviewed: Add myself as a commiter to the contributors list.
2264
2265         * Scripts/webkitpy/common/config/contributors.json:
2266
2267 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2268
2269         [EFL][WK2] Extract the control of page background out of color_set
2270         https://bugs.webkit.org/show_bug.cgi?id=127539
2271
2272         Reviewed by Gyuyoung Kim.
2273
2274         Added an option(C) to change background color.
2275
2276         * MiniBrowser/efl/main.c:
2277         (window_create):
2278         (elm_main):
2279
2280 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2281
2282         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
2283
2284         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
2285
2286 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2287
2288         Unreviewed test correction after r166530.
2289
2290         * DumpRenderTree/mac/DumpRenderTree.mm:
2291         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
2292         fine-grained setting for swipe tests. This prevents existing tests from breaking.
2293
2294 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2295
2296         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
2297         https://bugs.webkit.org/show_bug.cgi?id=130987
2298
2299         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
2300         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
2301
2302         Reviewed by Martin Robinson.
2303
2304         * BuildSlaveSupport/build.webkit.org-config/config.json:
2305
2306 2014-03-31  Dean Jackson  <dino@apple.com>
2307
2308         Remove WEB_ANIMATIONS
2309         https://bugs.webkit.org/show_bug.cgi?id=130989
2310
2311         Reviewed by Simon Fraser.
2312
2313         Remove this feature flag until we plan to implement.
2314
2315         * Scripts/webkitperl/FeatureList.pm:
2316
2317 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2318
2319         Reduced Latched Scroll Test Flakiness
2320         https://bugs.webkit.org/show_bug.cgi?id=130983
2321
2322         Reviewed by Darin Adler.
2323
2324         * DumpRenderTree/mac/DumpRenderTree.mm:
2325         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
2326         * DumpRenderTree/mac/EventSendingController.mm:
2327         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
2328         with high resolution flags turned on.
2329         * WebKitTestRunner/mac/EventSenderProxy.mm:
2330         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2331
2332 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2333
2334         run-webkit-tests should have a --no-timeout option
2335         https://bugs.webkit.org/show_bug.cgi?id=128286
2336
2337         Reviewed by Joseph Pecoraro.
2338
2339         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2340         (Worker._run_test): Renaming _run_test_with_timeout()
2341         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
2342         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
2343         (Worker._run_test_in_this_thread):
2344         (Worker._run_test_with_timeout): Deleted.
2345         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2346         (parse_args): Added the --no-timeout option
2347
2348 2014-03-31  Samuel White  <samuel_white@apple.com>
2349
2350         AX: Need ability to get line range for text marker.
2351         https://bugs.webkit.org/show_bug.cgi?id=130906
2352
2353         Reviewed by Chris Fleizach.
2354
2355         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
2356
2357         * DumpRenderTree/AccessibilityUIElement.cpp:
2358         (lineTextMarkerRangeForTextMarkerCallback):
2359         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2360         (AccessibilityUIElement::getJSClass):
2361         * DumpRenderTree/AccessibilityUIElement.h:
2362         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2363         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2364         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2365         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2366         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2367         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2368         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2369         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2370         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2371         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2372         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2373         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2374
2375 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
2376
2377         More validation for FTL inline caches
2378         https://bugs.webkit.org/show_bug.cgi?id=130948
2379
2380         Reviewed by Geoffrey Garen.
2381
2382         * Scripts/run-jsc-stress-tests:
2383
2384 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2385
2386         [GTK] Do not run WebKit1 unit tests by default
2387         https://bugs.webkit.org/show_bug.cgi?id=130968
2388
2389         Reviewed by Martin Robinson.
2390
2391         * Scripts/run-gtk-tests:
2392         (TestRunner):
2393
2394 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
2395
2396         [GTK] Remove scripts code only applicable to autotools
2397         https://bugs.webkit.org/show_bug.cgi?id=130841
2398
2399         Reviewed by Anders Carlsson.
2400
2401         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2402         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
2403         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
2404         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
2405         * gtk/find-make-dist-errors: Removed.
2406         * gtk/generate-feature-defines-files: Removed.
2407         * gtk/manifest.txt: No longer need to consider autotools files.
2408
2409 2014-03-30  Andy Estes  <aestes@apple.com>
2410
2411         Fix two failing layout tests on Mountain Lion after r166466.
2412
2413         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2414         (-[DownloadDelegate _downloadDidStart:]):
2415
2416 2014-03-30  Andy Estes  <aestes@apple.com>
2417
2418         [Cocoa] Add an originatingWebView property to _WKDownload
2419         https://bugs.webkit.org/show_bug.cgi?id=130945
2420
2421         Reviewed by Anders Carlsson.
2422
2423         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2424         (-[DownloadDelegate _downloadDidStart:]):
2425         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
2426         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2427         (TEST):
2428
2429 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
2430
2431         Land the stackmap register liveness glue with the uses of the liveness disabled
2432         https://bugs.webkit.org/show_bug.cgi?id=130924
2433
2434         Reviewed by Oliver Hunt.
2435
2436         * Scripts/run-jsc-stress-tests:
2437
2438 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
2439
2440         Update WebKit1.StringTruncator for Mountain Lion.
2441
2442         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
2443         due to different font metrics on 10.8.
2444
2445 2014-03-28  Darin Adler  <darin@apple.com>
2446
2447         Fix recently-introduced off-by-one error in centerTruncateToBuffer
2448         https://bugs.webkit.org/show_bug.cgi?id=130889
2449
2450         Reviewed by Alexey Proskuryakov.
2451
2452         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
2453         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
2454         WebStringTruncator methods; should be good for a start. These are dependent on the
2455         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
2456
2457 2014-03-28  Martin Hock  <mhock@apple.com>
2458
2459         Unreviewed. Add myself as a committer.
2460
2461         * Scripts/webkitpy/common/config/contributors.json:
2462
2463 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
2464
2465         Remove WebKit1 GTK+ bots
2466         https://bugs.webkit.org/show_bug.cgi?id=130904
2467
2468         Reviewed by Anders Carlsson.
2469
2470         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2471         all bots are testing WebKit2 only.
2472         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2473         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2474         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2475         * Scripts/webkitpy/port/builders.py: Ditto.
2476         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2477         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2478
2479 2014-03-28  Timothy Hatcher  <timothy@apple.com>
2480
2481         Remove Brian Burg's apple.com email address.
2482
2483         * Scripts/webkitpy/common/config/contributors.json:
2484
2485 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2486
2487         bisect-builds should print Trac 'changeset' URL if only one build is detected
2488         <http://webkit.org/b/130903>
2489
2490         Reviewed by Dan Bernstein.
2491
2492         * Scripts/bisect-builds:
2493         (printTracLink): Print a direct link to the Trac 'changeset'
2494         URL if there is only one revision in the range.
2495
2496 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2497
2498         [EFL] Bump glib version from 2.36 to 2.38 
2499         https://bugs.webkit.org/show_bug.cgi?id=130886
2500
2501         Reviewed by Csaba Osztrogonác.
2502
2503         There is a build break on EFL port when using glib 2.36 ver. To fix it,
2504         we need to bump glib version up to 2.38 as gtk port.
2505
2506         * efl/jhbuild.modules:
2507
2508 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2509
2510         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2511
2512         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2513         the globalhistory directory.
2514
2515         Reviewed by Sam Weinig.
2516
2517         * WebKitTestRunner/TestController.cpp:
2518         (WTR::TestController::TestController):
2519         (WTR::TestController::initialize): Set the history client.
2520         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2521         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2522         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2523         and we don't yet have API to access the data in question.
2524         (WTR::TestController::didPerformClientRedirect):
2525         (WTR::TestController::didPerformServerRedirect):
2526         (WTR::TestController::didUpdateHistoryTitle):
2527         * WebKitTestRunner/TestController.h:
2528         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2529         * WebKitTestRunner/TestInvocation.cpp:
2530         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2531         (WTR::TestInvocation::invoke):
2532
2533 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2534
2535         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2536
2537         * Scripts/build-webkit:
2538         * Scripts/copy-webkitlibraries-to-product-directory:
2539
2540 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2541
2542         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2543         https://bugs.webkit.org/show_bug.cgi?id=130867
2544         <rdar://problem/16432456> 
2545
2546         Reviewed by Mark Hahnenberg.
2547
2548         * Scripts/build-webkit:
2549         * Scripts/copy-webkitlibraries-to-product-directory:
2550
2551 2014-03-26  Andy Estes  <aestes@apple.com>
2552
2553         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2554         https://bugs.webkit.org/show_bug.cgi?id=130805
2555
2556         Reviewed by Dan Bernstein.
2557
2558         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2559         (-[DownloadDelegate _download:didReceiveResponse:]):
2560         (-[DownloadDelegate _downloadDidFinish:]):
2561         (runTest):
2562         (TEST):
2563         (-[FailingDownloadDelegate _downloadDidFinish:]):
2564         (-[FailingDownloadDelegate _download:didFailWithError:]):
2565         (-[FailingDownloadDelegate _downloadDidCancel:]):
2566         (-[CancelledDownloadDelegate _downloadDidStart:]):
2567         (-[CancelledDownloadDelegate _downloadDidFinish:]):
2568         (-[CancelledDownloadDelegate _download:didFailWithError:]):
2569         (-[CancelledDownloadDelegate _downloadDidCancel:]):
2570         (-[DownloadDelegate initWithSourceURL:]): Deleted.
2571         (-[DownloadDelegate sourceURL]): Deleted.
2572         (runTestWithNavigationDelegate): Deleted.
2573
2574 2014-03-26  Anders Carlsson  <andersca@apple.com>
2575
2576         Change MiniBrowser to hold on to window controllers instead of windows
2577         https://bugs.webkit.org/show_bug.cgi?id=130797
2578
2579         Reviewed by Oliver Hunt.
2580
2581         * MiniBrowser/mac/AppDelegate.h:
2582         * MiniBrowser/mac/AppDelegate.m:
2583         (-[BrowserAppDelegate init]):
2584         (-[BrowserAppDelegate newWindow:]):
2585         (-[BrowserAppDelegate browserWindowWillClose:]):
2586         (-[BrowserAppDelegate applicationWillTerminate:]):
2587         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2588
2589 2014-03-26  Commit Queue  <commit-queue@webkit.org>
2590
2591         Unreviewed, rolling out r166264.
2592         https://bugs.webkit.org/show_bug.cgi?id=130785
2593
2594         Broke some window.opener tests for WK2 Mavericks (Requested by
2595         brrian__ on #webkit).
2596
2597         Reverted changeset:
2598
2599         "Web Replay: resource unique identifiers should be unique-per-
2600         frame, not globally"
2601         https://bugs.webkit.org/show_bug.cgi?id=130632
2602         http://trac.webkit.org/changeset/166264
2603
2604 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2605
2606         [CSS Shapes] Remove shape-inside support
2607         https://bugs.webkit.org/show_bug.cgi?id=130698
2608
2609         Reviewed by David Hyatt.
2610
2611         * Scripts/webkitperl/FeatureList.pm:
2612
2613 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
2614
2615         Unreviewed. Add myself as a committer.
2616
2617         * Scripts/webkitpy/common/config/contributors.json:
2618
2619 2014-03-26  Tomas Popela  <tpopela@redhat.com>
2620
2621         run-launcher is Perl script so use elsif and not elif
2622         https://bugs.webkit.org/show_bug.cgi?id=130771
2623
2624         Reviewed by Carlos Garcia Campos.
2625
2626         * Scripts/run-launcher:
2627
2628 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
2629
2630         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2631         https://bugs.webkit.org/show_bug.cgi?id=130575
2632
2633         Reviewed by Mario Sanchez Prada.
2634
2635         Change ATK version to 2.11.92. Adjust current implementation.
2636
2637         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2638         (AccessibilityUIElement::intValue):
2639         (AccessibilityUIElement::minValue):
2640         (AccessibilityUIElement::maxValue):
2641         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2642         (WTR::AccessibilityUIElement::intValue):
2643         (WTR::AccessibilityUIElement::minValue):
2644         (WTR::AccessibilityUIElement::maxValue):
2645         * efl/jhbuild.modules:
2646         * gtk/jhbuild.modules:
2647
2648 2014-03-12  Philippe Normand  <pnormand@igalia.com>
2649
2650         [GTK] The gnumake package is no longer needed in jhbuild
2651         https://bugs.webkit.org/show_bug.cgi?id=130121
2652
2653         Reviewed by Martin Robinson.
2654
2655         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
2656         for a debug build cmake/system-gnumake worked just fine for me.
2657
2658         * gtk/jhbuild.modules: Removed gnumake.
2659         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
2660         * gtk/patches/make-3.82-parallel-build.patch: Removed.
2661
2662 2014-03-25  Andy Estes  <aestes@apple.com>
2663
2664         Fix a failing API test on Mountain Lion and remove temporary debug logging.
2665
2666         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2667         (-[DownloadDelegate _download:didReceiveData:]):
2668         (-[DownloadDelegate _downloadDidFinish:]):
2669
2670 2014-03-25  Brian Burg  <bburg@apple.com>
2671
2672         Web Replay: resource unique identifiers should be unique-per-frame, not globally
2673         https://bugs.webkit.org/show_bug.cgi?id=130623
2674
2675         Reviewed by Timothy Hatcher.
2676
2677         The resource loader callback dumping routines assumed that resource identifiers
2678         were globally unique. Its map of resource identifiers to URLs must also track the
2679         frame associated with the resource.
2680
2681         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2682         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
2683         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
2684         stable as long as the frame is valid.
2685         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2686         (WTR::InjectedBundlePage::willSendRequestForFrame):
2687         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2688         (WTR::InjectedBundlePage::didFinishLoadForResource):
2689         (WTR::InjectedBundlePage::didFailLoadForResource):
2690
2691 2014-03-25  Andy Estes  <aestes@apple.com>
2692
2693         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
2694
2695         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2696         (-[DownloadDelegate _download:didReceiveResponse:]):
2697         (-[DownloadDelegate _download:didReceiveData:]):
2698
2699 2014-03-25  Andy Estes  <aestes@apple.com>
2700
2701         Add some debug logging to an API test that's failing on Mountain Lion.
2702
2703         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2704         (-[DownloadDelegate _download:didReceiveResponse:]):
2705         (-[DownloadDelegate _downloadDidFinish:]):
2706
2707 2014-03-25  Anders Carlsson  <andersca@apple.com>
2708
2709         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
2710         https://bugs.webkit.org/show_bug.cgi?id=130732
2711
2712         Reviewed by Tim Horton.
2713
2714         * MiniBrowser/mac/WK2BrowserWindowController.m:
2715         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2716
2717 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
2718
2719         [GTK] Remove the autotools build
2720         https://bugs.webkit.org/show_bug.cgi?id=130717
2721
2722         Reviewed by Anders Carlsson.
2723
2724         * DumpRenderTree/config.h: Remove references to the autotools configure file.
2725         * GNUmakefile.am: Removed.
2726         * GtkLauncher/GNUmakefile.am: Removed.
2727         * GtkLauncher/main.c: Remove references to the autotools configure file.
2728         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
2729         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
2730         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
2731         * MiniBrowser/gtk/GNUmakefile.am: Removed.
2732         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
2733         * Scripts/build-webkit: No longer handle autotools.
2734         * Scripts/run-gtk-tests: Ditto.
2735         (TestRunner._setup_testing_environment):
2736         * Scripts/run-launcher: Ditto.
2737         * Scripts/webkitdirs.pm: Ditto.
2738         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
2739         * Scripts/webkitpy/common/config/contributors.json: Ditto.
2740         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
2741         * Scripts/webkitpy/style/checker.py:
2742         * TestWebKitAPI/GNUmakefile.am: Removed.
2743         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
2744         * WebKitTestRunner/GNUmakefile.am: Removed.
2745         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
2746         * gtk/GNUmakefile.am: Removed.
2747         * gtk/common.py: Remove checks for the autotools build.
2748         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
2749
2750 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
2751
2752         prepare-ChangeLog throws false positive warnings for modified files.
2753         https://bugs.webkit.org/show_bug.cgi?id=130687
2754
2755         Reviewed by Darin Adler.
2756
2757         * Scripts/prepare-ChangeLog:
2758         (originalFile): Ignore git commit paremeter.
2759         We don't need this to get the unmodified file.
2760         (extractLineRangeBeforeChange):
2761         Simplify the if statement. Follow-up after r166189.
2762
2763 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
2764
2765         [EFL] Add ARM64 build support
2766         https://bugs.webkit.org/show_bug.cgi?id=130506
2767
2768         Rubber stamped by Gyuyoung Kim.
2769
2770         * Scripts/webkitdirs.pm:
2771         (isARM): Detect aarch64 as ARM.
2772
2773 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2774
2775         [webkitpy] Improve _parse_bug_description to recognize more descriptions
2776         https://bugs.webkit.org/show_bug.cgi?id=130137
2777
2778         Reviewed by Csaba Osztrogonác.
2779
2780         * Scripts/webkitpy/common/checkout/changelog.py:
2781         (ChangeLogEntry._parse_bug_description):
2782         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2783         (test_parse_log_entries_from_changelog):
2784         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2785         (CheckoutTest.test_commit_info_for_revision):
2786
2787 2014-03-24  Andy Estes  <aestes@apple.com>
2788
2789         Fix the iOS build of TestWebKitAPI.
2790
2791         * TestWebKitAPI/Configurations/Base.xcconfig:
2792         * TestWebKitAPI/PlatformUtilities.h:
2793
2794 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2795
2796         Fix prepare-ChangeLog after r166156.
2797         https://bugs.webkit.org/show_bug.cgi?id=130674
2798
2799         Reviewed by Darin Adler.
2800
2801         * Scripts/prepare-ChangeLog:
2802         (generateFunctionLists):
2803         (extractLineRangeBeforeChange):
2804
2805 2014-03-24  Andy Estes  <aestes@apple.com>
2806
2807         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2808         https://bugs.webkit.org/show_bug.cgi?id=129322
2809
2810         Reviewed by Anders Carlsson.
2811
2812         Add an API test suite for _WKDownload.
2813
2814         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2815         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
2816         (-[DownloadDelegate initWithSourceURL:]):
2817         (-[DownloadDelegate sourceURL]):
2818         (-[DownloadDelegate _downloadDidStart:]):
2819         (-[DownloadDelegate _download:didReceiveResponse:]):
2820         (-[DownloadDelegate _download:didReceiveData:]):
2821         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2822         (-[DownloadDelegate _downloadDidFinish:]):
2823         (TEST):
2824         (runTestWithNavigationDelegate):
2825         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2826         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2827
2828 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
2829
2830         filter-build-webkit: reduce unfiltered output
2831         https://bugs.webkit.org/show_bug.cgi?id=130485
2832
2833         Reviewed by Brent Fulgham.
2834
2835         * Scripts/filter-build-webkit:
2836         (shouldIgnoreLine):
2837
2838 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2839
2840         prepare-ChangeLog should list functions that have been removed too.
2841         https://bugs.webkit.org/show_bug.cgi?id=130508
2842
2843         Reviewed by Darin Adler.
2844
2845         The prepare-ChangeLog does not list the deleted functions in the Changelog.
2846         We have to read the functions and the line ranges of them from the source
2847         before the change, then search for overlaps between them and the changed
2848         line ranges from diff.
2849
2850         * Scripts/prepare-ChangeLog:
2851         (originalFile): Get original source command.
2852         (generateFunctionLists): Collect deleted functions too.
2853         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
2854         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
2855         deleted functions ranges too.
2856         (extractLineRange): Renamed to extractLineRangeAfterChange.
2857
2858 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
2859
2860         Move all EFL typedefs into EflTypedefs.h.
2861         https://bugs.webkit.org/show_bug.cgi?id=130511
2862
2863         Reviewed by Gyuyoung Kim.
2864
2865         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
2866         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2867         * WebKitTestRunner/PlatformWebView.h: Ditto.
2868
2869 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
2870
2871         Don't flush compositing layers within FrameView::willPaintContents()
2872         https://bugs.webkit.org/show_bug.cgi?id=130627
2873         <rdar://problem/16368869>
2874
2875         Reviewed by Sam Weinig.
2876         
2877         Fix DRT to correctly render tests with layers now that FrameView::paintContents
2878         does not flush.
2879         
2880         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
2881         into an explicit function called before dumping. 
2882         
2883         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
2884         are flushed to CA. They will be pushed to the window by snapshotting.
2885
2886         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2887         Fix weird path to IOKit.framework.
2888         * DumpRenderTree/mac/DumpRenderTree.mm:
2889         (updateDisplay):
2890         (dump):
2891         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2892         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
2893         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
2894
2895 2014-03-21  David Kilzer  <ddkilzer@apple.com>
2896
2897         fix-blink-patch: tool to fix up renamed directory paths in Blink
2898         <http://webkit.org/b/130609>
2899
2900         Reviewed by Ryosuke Niwa.
2901
2902         Usage: cat blink.patch | fix-blink-patch | svn-apply
2903
2904         * Scripts/fix-blink-patch: Added.
2905
2906 2014-03-21  Darin Adler  <darin@apple.com>
2907
2908         Remove use of deprecatedCharacters in WebKit API tests
2909         https://bugs.webkit.org/show_bug.cgi?id=130602
2910
2911         Reviewed by Antti Koivisto.
2912
2913         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2914         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
2915         (TestWebKitAPI::expectEmpty): Use characters8.
2916         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
2917
2918         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2919         Removed the test that is entirely about 16-bit conversion since that's basically a test of
2920         the deprecatedCharacters function itself, which we are about to delete.
2921
2922 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2923
2924         [webkitpy] Fix has_valid_reviewer()
2925         https://bugs.webkit.org/show_bug.cgi?id=130589
2926
2927         Reviewed by Csaba Osztrogonác.
2928
2929         * Scripts/webkitpy/common/checkout/changelog.py:
2930         (ChangeLogEntry.has_valid_reviewer):
2931         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2932         (test_has_valid_reviewer):
2933         * Scripts/webkitpy/common/config/committers.py:
2934         (CommitterList._reviewer_only):
2935         (CommitterList.committer_by_name):
2936         (CommitterList.reviewer_by_email):
2937         (CommitterList):
2938         (CommitterList.reviewer_by_name):
2939
2940 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2941
2942         Add cache support for jhbuild
2943         https://bugs.webkit.org/show_bug.cgi?id=130588
2944
2945         Reviewed by Csaba Osztrogonác.
2946
2947         * jhbuild/jhbuildrc_common.py:
2948         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
2949
2950 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2951
2952         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
2953         https://bugs.webkit.org/show_bug.cgi?id=130504
2954
2955         Reviewed by Martin Robinson.
2956
2957         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
2958         CMake if not specified.
2959         * Scripts/webkitdirs.pm:
2960         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
2961         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
2962
2963 2014-03-21  Andreas Kling  <akling@apple.com>
2964
2965         RetainPtr API test should use CFArray instead of CFString for testing.
2966         <rdar://problem/16384899>
2967
2968         Unreviewed bot fix.
2969
2970         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2971         (TestWebKitAPI::TEST):
2972         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2973         (TestWebKitAPI::TEST):
2974
2975 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
2976
2977         Move to using std::unique_ptr for EFL objects.
2978         https://bugs.webkit.org/show_bug.cgi?id=129853
2979
2980         Reviewed by Gyuyoung Kim.
2981
2982         EflUniquePtr is a template alias of std::unique_ptr
2983         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
2984         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
2985
2986         * DumpRenderTree/efl/DumpRenderTree.cpp:
2987         (main):
2988         * ImageDiff/efl/ImageDiff.cpp:
2989         (initEfl):
2990         (main):
2991
2992 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
2993
2994         Unreviewed buildfix after r165983 for non Cocoa platforms
2995
2996         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
2997
2998         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2999         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3000         * WebKitTestRunner/TestController.cpp:
3001
3002 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
3003
3004         [GTK][CMake] Add support for building with Clang
3005         https://bugs.webkit.org/show_bug.cgi?id=130260
3006
3007         Reviewed by Martin Robinson.
3008
3009         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
3010         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
3011         included GTest framework headers.
3012         * gtk/generate-gtkdoc:
3013         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
3014         in case of using Clang since that is now set by the CMake rule.
3015
3016 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
3017
3018         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
3019         https://bugs.webkit.org/show_bug.cgi?id=130476
3020
3021         Reviewed by Anders Carlsson.
3022         
3023         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
3024
3025         * MiniBrowser/mac/WK1BrowserWindowController.m:
3026         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3027         Remove log.
3028         * MiniBrowser/mac/WK2BrowserWindowController.m:
3029         (-[WK2BrowserWindowController awakeFromNib]):
3030         (-[WK2BrowserWindowController validateMenuItem:]):
3031         (-[WK2BrowserWindowController reload:]):
3032         Hook up reload.
3033         (-[WK2BrowserWindowController toggleZoomMode:]):
3034         (-[WK2BrowserWindowController resetZoom:]):
3035         (-[WK2BrowserWindowController canResetZoom]):
3036         (-[WK2BrowserWindowController currentZoomFactor]):
3037         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3038         (-[WK2BrowserWindowController canZoomIn]):
3039         (-[WK2BrowserWindowController canZoomOut]):
3040
3041 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
3042
3043         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
3044         https://bugs.webkit.org/show_bug.cgi?id=130463
3045
3046         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
3047
3048 2014-03-18  Samuel White  <samuel_white@apple.com>
3049
3050         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
3051         https://bugs.webkit.org/show_bug.cgi?id=130250
3052
3053         Reviewed by Chris Fleizach.
3054
3055         Added ability to toggle enhanced accessibility on and off to support tests that require it.
3056
3057         * DumpRenderTree/AccessibilityController.cpp:
3058         (enableEnhancedAccessibilityCallback):
3059         (getEnhancedAccessibilityEnabledCallback):
3060         (AccessibilityController::getJSClass):
3061         * DumpRenderTree/AccessibilityController.h:
3062         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3063         (AccessibilityController::enableEnhancedAccessibility):
3064         (AccessibilityController::enhancedAccessibilityEnabled):
3065         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3066         (AccessibilityController::enableEnhancedAccessibility):
3067         (AccessibilityController::enhancedAccessibilityEnabled):
3068         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3069         (AccessibilityController::enableEnhancedAccessibility):
3070         (AccessibilityController::enhancedAccessibilityEnabled):
3071         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3072         (AccessibilityController::enableEnhancedAccessibility):
3073         (AccessibilityController::enhancedAccessibilityEnabled):
3074         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3075         (WTR::AccessibilityController::enableEnhancedAccessibility):
3076         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
3077         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3078         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3079
3080 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
3081
3082         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
3083         yet).
3084
3085         * Scripts/webkitpy/common/config/contributors.json:
3086
3087 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
3088
3089         Web Inspector: Remove stale ReportMemoryUsagePlugin
3090         https://bugs.webkit.org/show_bug.cgi?id=130405
3091
3092         Reviewed by Andreas Kling.
3093
3094         This clang plugin looks like it was used for the old Inspector memory
3095         instrumentation that was removed. So the tool can be removed.
3096
3097         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
3098         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
3099         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
3100         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
3101
3102 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3103
3104         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
3105         https://bugs.webkit.org/show_bug.cgi?id=130220
3106
3107         Reviewed by Csaba Osztrogonác.
3108
3109         * Scripts/webkitpy/common/checkout/changelog.py:
3110         (ChangeLog.set_reviewer):
3111         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3112         (test_set_reviewer):
3113
3114 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
3115
3116         More FTL enabling.
3117
3118         Rubber stamped by Dan Bernstein.
3119
3120         * Tools/Scripts/build-webkit:
3121
3122 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3123
3124         Renable pagination mode in WK2 MiniBrowser
3125         https://bugs.webkit.org/show_bug.cgi?id=130374
3126
3127         Reviewed by Anders Carlsson.
3128         
3129         Put the implementation of togglePaginationMode: back, and correctly
3130         enable the menu item.
3131
3132         * MiniBrowser/mac/WK2BrowserWindowController.m:
3133         (-[WK2BrowserWindowController validateMenuItem:]):
3134         (-[WK2BrowserWindowController isPaginated]):
3135         (-[WK2BrowserWindowController togglePaginationMode:]):
3136
3137 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3138
3139         Add --reset option to Tools/Scripts/set-webkit-configuration script
3140         https://bugs.webkit.org/show_bug.cgi?id=130401
3141
3142         Reviewed by Csaba Osztrogonác.
3143
3144         * Scripts/set-webkit-configuration:
3145
3146 2014-03-18  Alberto Garcia  <berto@igalia.com>
3147
3148         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
3149         https://bugs.webkit.org/show_bug.cgi?id=130388
3150
3151         Reviewed by Sergio Villar Senin.
3152
3153         * Scripts/webkitdirs.pm:
3154         (shouldRemoveCMakeCache): make sure that the build directory
3155         exists before attempting to create a file in it.
3156
3157 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
3158
3159         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
3160         https://bugs.webkit.org/show_bug.cgi?id=130336
3161
3162         Reviewed by Gyuyoung Kim.
3163
3164         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
3165         requires a space between literal and string macro [-Wliteral-suffix]'
3166         warning treated as error.
3167
3168         This patch applies a solution from r162448 to the EFL port.
3169
3170         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
3171         * efl/jhbuild.modules: Added appropriate patch section.
3172
3173 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3174
3175         webkitpy test rebaseline.
3176
3177         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3178         (MainTest.test_default_args):
3179
3180 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3181
3182         --profile should imply --test-runner-count=1 in run-perf-tests
3183         https://bugs.webkit.org/show_bug.cgi?id=130375
3184
3185         Reviewed by Benjamin Poulain.
3186
3187         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
3188
3189         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3190         (PerfTestsRunner._parse_args): Use -1 as the default value.
3191         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
3192         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
3193         should be 1.
3194
3195 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3196
3197         Address some style nits.
3198
3199         * MiniBrowser/mac/WK2BrowserWindowController.m:
3200
3201 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3202
3203         Add transparent window support back into MiniBrowser
3204         https://bugs.webkit.org/show_bug.cgi?id=130363
3205
3206         Reviewed by Anders Carlsson.
3207         
3208         Re-enable transparent window support for WK2.
3209
3210         * MiniBrowser/mac/WK2BrowserWindowController.m:
3211         (-[WK2BrowserWindowController validateMenuItem:]):
3212         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3213
3214 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3215
3216         Fix the 32-bit build; make the open panel make a WK1 window.
3217
3218         * MiniBrowser/mac/AppDelegate.m:
3219         (-[BrowserAppDelegate openDocument:]):
3220
3221 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3222
3223         Convert MiniBrowser to use WKWebView API
3224         https://bugs.webkit.org/show_bug.cgi?id=130061
3225
3226         Reviewed by Anders Carlsson.
3227         
3228         Convert the MiniBrowser WK2 window to use WebKit2 API as much
3229         as possible.
3230         
3231         Some functionality was removed temporarily:
3232             - text zoom, page zoom
3233             - reload
3234             - pagination mode
3235             - transparent window
3236             - dumping source
3237             - window.open support
3238             - beforeUnload panel
3239             - find in page
3240
3241         * MiniBrowser/mac/AppDelegate.h:
3242         * MiniBrowser/mac/AppDelegate.m:
3243         (-[BrowserAppDelegate init]):
3244         (-[BrowserAppDelegate newWindow:]):
3245         (-[BrowserAppDelegate applicationWillTerminate:]):
3246         (-[BrowserAppDelegate openDocument:]):
3247         * MiniBrowser/mac/WK2BrowserWindowController.h:
3248         * MiniBrowser/mac/WK2BrowserWindowController.m:
3249         (-[WK2BrowserWindowController awakeFromNib]):
3250         (-[WK2BrowserWindowController dealloc]):
3251         (-[WK2BrowserWindowController fetch:]):
3252         (-[WK2BrowserWindowController validateMenuItem:]):
3253         (-[WK2BrowserWindowController reload:]):
3254         (-[WK2BrowserWindowController goBack:]):
3255         (-[WK2BrowserWindowController goForward:]):
3256         (-[WK2BrowserWindowController toggleZoomMode:]):
3257         (-[WK2BrowserWindowController resetZoom:]):
3258         (-[WK2BrowserWindowController canResetZoom]):
3259         (-[WK2BrowserWindowController dumpSourceToConsole:]):
3260         (-[WK2BrowserWindowController togglePaginationMode:]):
3261         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3262         (-[WK2BrowserWindowController windowShouldClose:]):
3263         (-[WK2BrowserWindowController applicationTerminating]):
3264         (-[WK2BrowserWindowController currentZoomFactor]):
3265         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3266         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3267         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3268         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3269         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3270         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3271         (-[WK2BrowserWindowController find:]):
3272         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
3273         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
3274         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
3275         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
3276         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3277         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3278         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3279         * WebKitTestRunner/PlatformWebView.h:
3280         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3281         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3282
3283 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
3284
3285         Use RunLoop objects through references instead of pointers
3286         https://bugs.webkit.org/show_bug.cgi?id=130313
3287
3288         Reviewed by Andreas Kling.
3289
3290         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
3291         return RunLoop reference instead of a pointer.
3292
3293         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
3294         (loadedCallback):
3295         (clickedCallback):
3296
3297 2014-03-17  Tim Horton  <timothy_horton@apple.com>
3298
3299         sort-export-file --help doesn't work (missing 'use')
3300         https://bugs.webkit.org/show_bug.cgi?id=130338
3301
3302         Reviewed by Anders Carlsson.
3303
3304         * Scripts/sort-export-file:
3305         Add a missing 'use', and fix a typo in an error message.
3306
3307 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
3308
3309         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
3310         https://bugs.webkit.org/show_bug.cgi?id=130155
3311
3312         Reviewed by Philippe Normand.
3313
3314         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
3315
3316 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3317
3318         [GTK] MiniBrowser fails to load injected bundle lib
3319         https://bugs.webkit.org/show_bug.cgi?id=130332
3320
3321         Reviewed by Anders Carlsson.
3322
3323         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
3324
3325         * MiniBrowser/gtk/main.c:
3326         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
3327         process is spawn.
3328
3329 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
3330
3331         [EFL] Enable TOUCH_SLIDER macro
3332         https://bugs.webkit.org/show_bug.cgi?id=130185
3333
3334         Reviewed by Gyuyoung Kim.
3335
3336         * Scripts/webkitperl/FeatureList.pm:
3337
3338 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
3339
3340         [GTK][CMake] Build with -fno-rtti
3341         https://bugs.webkit.org/show_bug.cgi?id=130261
3342
3343         Reviewed by Martin Robinson.
3344
3345         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
3346         defined to 0 to prevent typeid use in included GTest headers.
3347
3348 2014-03-16  Brian Burg  <bburg@apple.com>
3349
3350         Web Inspector: vended backend commands file should be generated as part of the build
3351         https://bugs.webkit.org/show_bug.cgi?id=130110
3352
3353         Reviewed by Timothy Hatcher.
3354
3355         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
3356
3357 2014-03-16  Diego Pino García  <dpino@igalia.com>
3358
3359         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
3360         https://bugs.webkit.org/show_bug.cgi?id=128999
3361
3362         Reviewed by Philippe Normand.
3363
3364         * MiniBrowser/gtk/BrowserWindow.c:
3365         (reloadPage):
3366         (reloadPageIgnoringCache):
3367         (browser_window_init):
3368
3369 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
3370
3371         [GTK] Improve ninja detection in webkitdirs.pm
3372         https://bugs.webkit.org/show_bug.cgi?id=129902
3373
3374         Reviewed by Daniel Bates.
3375
3376         * Scripts/webkitdirs.pm:
3377         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
3378         us to look for ninja-build as well.
3379
3380 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
3381
3382         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
3383         https://bugs.webkit.org/show_bug.cgi?id=130276
3384         <rdar://problem/16266927>
3385         
3386         Reviewed by Simon Fraser.
3387
3388         * BuildSlaveSupport/build-launcher-app:
3389         * BuildSlaveSupport/build-launcher-dmg:
3390         * DumpRenderTree/DumpRenderTree.h:
3391         * DumpRenderTree/DumpRenderTreePrefix.h:
3392         * DumpRenderTree/GCController.cpp:
3393         * DumpRenderTree/GCController.h:
3394         * DumpRenderTree/JavaScriptThreading.cpp:
3395         * DumpRenderTree/JavaScriptThreading.h:
3396         * DumpRenderTree/PixelDumpSupport.cpp:
3397         * DumpRenderTree/PixelDumpSupport.h:
3398         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
3399         * DumpRenderTree/TestRunner.cpp:
3400         * DumpRenderTree/TestRunner.h:
3401         * DumpRenderTree/WorkQueue.cpp:
3402         * DumpRenderTree/WorkQueue.h:
3403         * DumpRenderTree/WorkQueueItem.h:
3404         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3405         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3406         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
3407         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3408         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3409         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3410         * DumpRenderTree/efl/EditingCallbacks.cpp:
3411         * DumpRenderTree/efl/EditingCallbacks.h:
3412         * DumpRenderTree/efl/EventSender.cpp:
3413         * DumpRenderTree/efl/EventSender.h:
3414         * DumpRenderTree/efl/GCControllerEfl.cpp:
3415         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3416         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3417         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3418         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3419         * DumpRenderTree/gtk/EditingCallbacks.cpp:
3420         * DumpRenderTree/gtk/EditingCallbacks.h:
3421         * DumpRenderTree/gtk/EventSender.cpp:
3422         * DumpRenderTree/gtk/EventSender.h:
3423         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3424         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3425         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
3426         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
3427         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3428         * DumpRenderTree/gtk/TextInputController.cpp:
3429         * DumpRenderTree/gtk/TextInputController.h:
3430         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
3431         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
3432         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3433         * DumpRenderTree/mac/AppleScriptController.h:
3434         * DumpRenderTree/mac/AppleScriptController.m:
3435         * DumpRenderTree/mac/CheckedMalloc.cpp:
3436         * DumpRenderTree/mac/CheckedMalloc.h:
3437         * DumpRenderTree/mac/DumpRenderTree.mm:
3438         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3439         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3440         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3441         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3442         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3443         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3444         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3445         * DumpRenderTree/mac/EditingDelegate.h:
3446         * DumpRenderTree/mac/EditingDelegate.mm:
3447         * DumpRenderTree/mac/EventSendingController.h:
3448         * DumpRenderTree/mac/EventSendingController.mm:
3449         * DumpRenderTree/mac/FrameLoadDelegate.h:
3450         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3451         * DumpRenderTree/mac/GCControllerMac.mm:
3452         * DumpRenderTree/mac/MockWebNotificationProvider.h:
3453         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3454         * DumpRenderTree/mac/NavigationController.h:
3455         * DumpRenderTree/mac/NavigationController.m:
3456         * DumpRenderTree/mac/ObjCController.h:
3457         * DumpRenderTree/mac/ObjCController.m:
3458         * DumpRenderTree/mac/ObjCPlugin.h:
3459         * DumpRenderTree/mac/ObjCPlugin.m:
3460         * DumpRenderTree/mac/ObjCPluginFunction.h:
3461         * DumpRenderTree/mac/ObjCPluginFunction.m:
3462         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3463         * DumpRenderTree/mac/PolicyDelegate.h:
3464         * DumpRenderTree/mac/PolicyDelegate.mm:
3465         * DumpRenderTree/mac/ResourceLoadDelegate.h:
3466         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3467         * DumpRenderTree/mac/TestRunnerMac.mm:
3468         * DumpRenderTree/mac/TextInputController.h:
3469         * DumpRenderTree/mac/TextInputController.m:
3470         * DumpRenderTree/mac/UIDelegate.h:
3471         * DumpRenderTree/mac/UIDelegate.mm:
3472         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3473         * DumpRenderTree/win/DRTDataObject.cpp:
3474         * DumpRenderTree/win/DRTDataObject.h:
3475         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3476         * DumpRenderTree/win/DRTDropSource.cpp:
3477         * DumpRenderTree/win/DRTDropSource.h:
3478         * DumpRenderTree/win/DraggingInfo.h:
3479         * DumpRenderTree/win/DumpRenderTree.cpp:
3480         * DumpRenderTree/win/DumpRenderTreeWin.h:
3481         * DumpRenderTree/win/EditingDelegate.cpp:
3482         * DumpRenderTree/win/EditingDelegate.h:
3483         * DumpRenderTree/win/EventSender.cpp:
3484         * DumpRenderTree/win/EventSender.h:
3485         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3486         * DumpRenderTree/win/FrameLoadDelegate.h:
3487         * DumpRenderTree/win/GCControllerWin.cpp:
3488         * DumpRenderTree/win/HistoryDelegate.cpp:
3489         * DumpRenderTree/win/HistoryDelegate.h:
3490         * DumpRenderTree/win/MD5.cpp:
3491         * DumpRenderTree/win/MD5.h:
3492         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3493         * DumpRenderTree/win/PolicyDelegate.cpp:
3494         * DumpRenderTree/win/PolicyDelegate.h:
3495         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3496         * DumpRenderTree/win/ResourceLoadDelegate.h:
3497         * DumpRenderTree/win/TestRunnerWin.cpp:
3498         * DumpRenderTree/win/TextInputController.cpp:
3499         * DumpRenderTree/win/TextInputController.h:
3500         * DumpRenderTree/win/TextInputControllerWin.cpp:
3501         * DumpRenderTree/win/UIDelegate.cpp:
3502         * DumpRenderTree/win/UIDelegate.h:
3503         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3504         * EWebLauncher/main.c:
3505         * GtkLauncher/main.c:
3506         * ImageDiff/efl/ImageDiff.cpp:
3507         * ImageDiff/gtk/ImageDiff.cpp:
3508         * MiniBrowser/gtk/main.c:
3509         * Scripts/SpacingHeuristics.pm:
3510         * Scripts/VCSUtils.pm:
3511         * Scripts/bisect-builds:
3512         * Scripts/build-dumprendertree:
3513         * Scripts/build-jsc:
3514         * Scripts/build-webkit:
3515         * Scripts/check-dom-results:
3516         * Scripts/check-for-exit-time-destructors:
3517         * Scripts/check-for-global-initializers:
3518         * Scripts/commit-log-editor:
3519         * Scripts/compare-timing-files:
3520         * Scripts/debug-minibrowser:
3521         * Scripts/debug-safari:
3522         * Scripts/do-file-rename:
3523         * Scripts/find-extra-includes:
3524         * Scripts/generate-coverage-data:
3525         * Scripts/make-script-test-wrappers:
3526         * Scripts/malloc-tree:
3527         * Scripts/old-run-webkit-tests:
3528         * Scripts/parse-malloc-history:
3529         * Scripts/report-include-statistics:
3530         * Scripts/resolve-ChangeLogs:
3531         * Scripts/run-bindings-tests:
3532         * Scripts/run-iexploder-tests:
3533         * Scripts/run-javascriptcore-tests:
3534         * Scripts/run-jsc:
3535         * Scripts/run-launcher:
3536         * Scripts/run-leaks:
3537         * Scripts/run-mangleme-tests:
3538         * Scripts/run-minibrowser:
3539         * Scripts/run-pageloadtest:
3540         * Scripts/run-regexp-tests:
3541         * Scripts/run-safari:
3542         * Scripts/run-sunspider:
3543         * Scripts/run-webkit-app:
3544         * Scripts/sampstat:
3545         * Scripts/set-webkit-configuration:
3546         * Scripts/sort-Xcode-project-file:
3547         * Scripts/sort-export-file:
3548         * Scripts/split-file-by-class:
3549         * Scripts/sunspider-compare-results:
3550         * Scripts/svn-apply:
3551         * Scripts/svn-create-patch:
3552         * Scripts/svn-unapply:
3553         * Scripts/test-webkit-scripts:
3554         * Scripts/update-javascriptcore-test-results:
3555         * Scripts/update-webkit:
3556         * Scripts/update-webkit-auxiliary-libs:
3557         * Scripts/update-webkit-dependency:
3558         * Scripts/update-webkit-localizable-strings:
3559         * Scripts/update-webkit-support-libs:
3560         * Scripts/update-webkit-wincairo-libs:
3561         * Scripts/webkit-build-directory:
3562         * Scripts/webkitdirs.pm:
3563         (installedSafariPath):
3564         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3565         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3566         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3567         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3568         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3569         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3570         * Scripts/webkitperl/features.pm:
3571         * Scripts/webkitperl/httpd.pm:
3572         * Scripts/webkitpy/bindings/main.py:
3573         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3574         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3575         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3576         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3577         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3578         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3579         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3580         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3581         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3582         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
3583         * WebKitTestRunner/PixelDumpSupport.cpp:
3584         * WebKitTestRunner/PixelDumpSupport.h:
3585         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3586         * WinLauncher/WinLauncher.cpp:
3587         * WinLauncher/WinLauncher.h:
3588         * WinLauncher/stdafx.cpp:
3589         * WinLauncher/stdafx.h:
3590
3591 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
3592
3593         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
3594         https://bugs.webkit.org/show_bug.cgi?id=130265
3595
3596         Reviewed by Michael Saboff.
3597
3598         * Scripts/build-webkit:
3599         * Scripts/copy-webkitlibraries-to-product-directory:
3600
3601 2014-03-14  Landry Breuil  <landry@openbsd.org>
3602
3603         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
3604         Also allow to set MAKE in the environment.
3605         https://bugs.webkit.org/show_bug.cgi?id=129991
3606
3607         Reviewed by Andreas Kling.
3608
3609         * Scripts/webkitdirs.pm:
3610         (determineArchitecture):
3611         (determineNumberOfCPUs):
3612         (isBSD):
3613         (buildAutotoolsProject):
3614         * Scripts/webkitpy/common/system/platforminfo.py:
3615         (PlatformInfo.__init__):
3616         (PlatformInfo.is_openbsd):
3617         (PlatformInfo):
3618         (PlatformInfo.is_netbsd):
3619         (PlatformInfo._determine_os_name):
3620
3621 2014-03-14  Dean Jackson  <dino@apple.com>
3622
3623         Remove libWebKitSystemInterfaceLion.a
3624         https://bugs.webkit.org/show_bug.cgi?id=130254
3625
3626         Reviewed by Geoffrey Garen and Andreas Kling.
3627
3628         No need to copy the Lion libraries into the build.
3629
3630         * Scripts/copy-webkitlibraries-to-product-directory:
3631
3632 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3633
3634         [EFL][MiniBrowser] Revise help messages of command line parameters
3635         https://bugs.webkit.org/show_bug.cgi?id=130222
3636
3637         Reviewed by Csaba Osztrogonác.
3638
3639         Correct the default value description and make help messages to be consistent.
3640
3641         * MiniBrowser/efl/main.c:
3642
3643 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
3644
3645         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
3646         https://bugs.webkit.org/show_bug.cgi?id=129612
3647
3648         Reviewed by Darin Adler.
3649
3650         For new code use static NeverDestroyed<T> instead.
3651
3652         * DumpRenderTree/JavaScriptThreading.cpp:
3653         (javaScriptThreadsMutex):
3654         (javaScriptThreads):
3655         * DumpRenderTree/efl/EventSender.cpp:
3656         (touchPointList):
3657         (delayedEventQueue):
3658         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3659         (delegatesWithDelayedWork):
3660         * Scripts/check-for-exit-time-destructors:
3661         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
3662         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3663         (testsMap):
3664
3665 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
3666
3667         [EFL][WK2] Fix compilation warning in Minibrowser
3668         https://bugs.webkit.org/show_bug.cgi?id=130132
3669
3670         Reviewed by Csaba Osztrogonác.
3671
3672         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
3673
3674         * MiniBrowser/efl/main.c:
3675         (on_download_request):
3676
3677 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
3678
3679         FTL should support IsBlah
3680         https://bugs.webkit.org/show_bug.cgi?id=130202
3681
3682         Reviewed by Geoffrey Garen.
3683         
3684         Running existing JSRegress tests with noInline gives us coverage for these
3685         changes. Chances are, this will also give coverage for other interesting things
3686         as well.
3687
3688         * Scripts/run-jsc-stress-tests:
3689
3690 2014-03-12  Brian Burg  <bburg@apple.com>
3691
3692         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
3693         https://bugs.webkit.org/show_bug.cgi?id=129744
3694
3695         Reviewed by Timothy Hatcher.
3696
3697         * DumpRenderTree/TestRunner.cpp:
3698         (evaluateInWebInspectorCallback):
3699         * DumpRenderTree/TestRunner.h:
3700         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3701         (TestRunner::evaluateInWebInspector):
3702         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3703         (TestRunner::evaluateInWebInspector):
3704         * DumpRenderTree/mac/TestRunnerMac.mm:
3705         (TestRunner::evaluateInWebInspector):
3706         * DumpRenderTree/win/TestRunnerWin.cpp:
3707         (TestRunner::evaluateInWebInspector):
3708         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3709         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3710         (WTR::TestRunner::evaluateInWebInspector):
3711         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3712
3713 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3714
3715         [GTK] build-webkit shouldn't show error message when ninja isn't installed
3716         https://bugs.webkit.org/show_bug.cgi?id=130129
3717
3718         Reviewed by Csaba Osztrogonác.
3719
3720         * Scripts/webkitdirs.pm:
3721         (canUseNinja): Redirecting stderr to /dev/null
3722
3723 2014-03-13  Andres Gomez  <agomez@igalia.com>
3724
3725         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
3726         https://bugs.webkit.org/show_bug.cgi?id=130092
3727
3728         Reviewed by Csaba Osztrogonác.
3729
3730         Added "python-dev" as dependency for deb based distros. It is
3731         already present for rpm based distros. This dependency will allow
3732         libxml2 to generate its python bindings, needed by gtk-doc.
3733
3734         * gtk/install-dependencies:
3735
3736 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3737
3738         Unreviewed. Fix GTK+ cmake build after r165488.
3739
3740         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
3741
3742 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3743
3744         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
3745         https://bugs.webkit.org/show_bug.cgi?id=130014
3746
3747         Reviewed by Martin Robinson.
3748
3749         Include cmake or autotools config header.
3750
3751         * MiniBrowser/gtk/BrowserDownloadsBar.c:
3752         * MiniBrowser/gtk/BrowserSearchBar.c:
3753         * MiniBrowser/gtk/BrowserWindow.c:
3754         * MiniBrowser/gtk/main.c:
3755
3756 2014-03-12  Commit Queue  <commit-queue@webkit.org>
3757
3758         Unreviewed, rolling out r165471.
3759         https://bugs.webkit.org/show_bug.cgi?id=130139
3760
3761         Didn't really fix the issue and broke another bot (Requested
3762         by mrobinson on #webkit).
3763
3764         Reverted changeset:
3765
3766         "[CMake] Newer versions of CMake cannot find older versions of
3767         Freetype"
3768         https://bugs.webkit.org/show_bug.cgi?id=130107
3769         http://trac.webkit.org/changeset/165471
3770
3771 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
3772
3773         It should be possible to build WebKit with FTL on iOS
3774         https://bugs.webkit.org/show_bug.cgi?id=130116
3775
3776         Reviewed by Dan Bernstein.
3777
3778         * Scripts/build-webkit:
3779         * Scripts/copy-webkitlibraries-to-product-directory:
3780
3781 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
3782
3783         [Win] Remove use of QTSDK
3784         https://bugs.webkit.org/show_bug.cgi?id=130049
3785
3786         Reviewed by Darin Adler.
3787
3788         * DumpRenderTree/win/DumpRenderTree.cpp:
3789         (initialize): Remove QuickTime code.
3790         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
3791         building QTMovieWin.
3792
3793 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
3794
3795         [GTK][CMAKE] Too verbose build output
3796         https://bugs.webkit.org/show_bug.cgi?id=130076
3797
3798         Reviewed by Carlos Garcia Campos.
3799
3800         Instead of building with cmake --build which isn't smart about pretty printing and
3801         colors, we build with a script which calls the proper build command.
3802
3803         * Scripts/webkitdirs.pm:
3804         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
3805         the CMake configuration pass.
3806
3807 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3808
3809         [CMake] Newer versions of CMake cannot find older versions of Freetype
3810         https://bugs.webkit.org/show_bug.cgi?id=130107
3811
3812         Reviewed by Gustavo Noronha Silva.
3813
3814         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
3815         to CMake during jhbuild initialization.
3816
3817 2014-03-12  Zalan Bujtas  <zalan@apple.com>
3818
3819         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
3820         https://bugs.webkit.org/show_bug.cgi?id=129961
3821
3822         Reviewed by Simon Fraser.
3823
3824         Now scaled content can go through the window capturing mechanism too for compositing content.
3825         AppleMagnifiedMode is redundant.
3826
3827         * DumpRenderTree/mac/DumpRenderTree.mm:
3828         (setDefaultsToConsistentValuesForTesting):
3829         (runTest):
3830         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3831         (createBitmapContextFromWebView):
3832         * WebKitTestRunner/PlatformWebView.h:
3833         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3834         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3835         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3836         (WTR::PlatformWebView::didInitializeClients):
3837         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3838         (WTR::PlatformWebView::forceWindowFramesChanged):
3839         * WebKitTestRunner/mac/main.mm:
3840         (setDefaultsToConsistentValuesForTesting):
3841
3842 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
3843
3844         Unreviewed. Add myself as a committer.
3845
3846         * Scripts/webkitpy/common/config/contributors.json:
3847
3848 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
3849
3850         Unreviewed build fix on the EFL port when used lower version of ATK
3851
3852         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3853         (WTR::AccessibilityUIElement::y): Fixed typo.
3854
3855 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3856
3857         Some images are blank in the rebaseline server UI
3858         https://bugs.webkit.org/show_bug.cgi?id=130104
3859
3860         Reviewed by Tim Horton.
3861
3862         Let the server check for images in the 'retries' directory
3863         if it can't find an image otherwise.
3864
3865         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3866         (RebaselineHTTPRequestHandler.test_result):
3867
3868 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3869
3870         [GTK][CMake] --update-gtk has no effect
3871         https://bugs.webkit.org/show_bug.cgi?id=130088
3872
3873         Reviewed by Philippe Normand.
3874
3875         * Scripts/webkitdirs.pm:
3876         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
3877         as an argument.
3878
3879 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3880
3881         Add "System Font" to the list of whitelisted DRT fonts
3882         https://bugs.webkit.org/show_bug.cgi?id=130046
3883
3884         Reviewed by Darin Adler.
3885
3886         * DumpRenderTree/mac/DumpRenderTree.mm:
3887         (allowedFontFamilySet):
3888         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3889
3890 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3891
3892         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
3893         https://bugs.webkit.org/show_bug.cgi?id=130064
3894
3895         Reviewed by Philippe Normand.
3896
3897         * efl/jhbuildrc: Remove duplicated code.
3898         * gtk/jhbuildrc: Remove duplicated code.
3899         * jhbuild/jhbuildrc_common.py:
3900         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
3901         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
3902         and is apparently necessary for GTK+.
3903
3904 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3905
3906         check-webkit-style failed to complain about missing braces
3907         https://bugs.webkit.org/show_bug.cgi?id=34189
3908
3909         Reviewed by Ryosuke Niwa.
3910
3911         * Scripts/webkitpy/style/checkers/cpp.py:
3912         (check_braces):
3913         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3914         (WebKitStyleTest.test_braces):
3915
3916 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3917
3918         Remove Qt cruft from style checker.
3919         https://bugs.webkit.org/show_bug.cgi?id=130085
3920
3921         Reviewed by Csaba Osztrogonác.
3922
3923         There is no 'foreach' keyword in c++. That was a Qt feature
3924         added in: http://trac.webkit.org/changeset/46113
3925         Qt was removed from WebKit, so we should remove the checks
3926         of this keyword from check-webkit-style scripts.
3927
3928         * Scripts/webkitpy/style/checkers/cpp.py:
3929         (check_spacing_for_function_call):
3930         (check_spacing):
3931         (check_braces):
3932         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3933         (CppStyleTest.test_mismatching_spaces_in_parens):
3934         (CppStyleTest.test_spacing_for_fncall):
3935         (WebKitStyleTest.test_braces):
3936
3937 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
3938
3939         [GTK] update-webkitgtk-libs needs itstool
3940         https://bugs.webkit.org/show_bug.cgi?id=130082
3941
3942         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
3943         itstool is a dependency of building gtk-doc from version 1.19, so it should
3944         be added to Tools/gtk/install-dependencies script, too.
3945
3946         Reviewed by Philippe Normand.
3947
3948         * gtk/install-dependencies:
3949
3950 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3951
3952         webkitbot rollout ChangeLogs should be nicer
3953         https://bugs.webkit.org/show_bug.cgi?id=122654
3954
3955         Reviewed by Csaba Osztrogonác.
3956
3957         Added bug urls and descriptions of rolled out patches to the rollout changelog
3958         if they are present in the original changelog. Additionally removed the list of
3959         changed files and functions.
3960
3961         * Scripts/webkitpy/common/checkout/changelog.py:
3962         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
3963         * Scripts/webkitpy/common/checkout/checkout.py:
3964         (Checkout._changelog_data_for_revision): Store bug description.
3965         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3966         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3967         (CheckoutTest.test_commit_info_for_revision):
3968         * Scripts/webkitpy/common/checkout/commitinfo.py:
3969         (CommitInfo.bug_description): Added.
3970         (CommitInfo.to_json):
3971         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3972         (CommitInfoTest.test_commit_info_creation):
3973         * Scripts/webkitpy/tool/commands/download.py:
3974         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
3975         out patches for creating rollout changelog.
3976         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
3977         caused the regression is stored in state["bug_blocked"] now.
3978         * Scripts/webkitpy/tool/commands/download_unittest.py:
3979         (test_prepare_rollout):
3980         (test_create_rollout_multiple_revision):
3981         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3982         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
3983         rolled out patches to the changelog.
3984         (PrepareChangeLogForRevert.run):
3985         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3986         (UpdateChangeLogsForRevertTest):
3987         (test_message_for_revert):
3988         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3989         (ReopenBugAfterRollout.run):
3990
3991 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3992
3993         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
3994         https://bugs.webkit.org/show_bug.cgi?id=130021
3995
3996         Reviewed by Mario Sanchez Prada.
3997
3998         Replace deprecated functions to use new API from ATK 2.11.90.
3999
4000         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4001         (AccessibilityUIElement::x):
4002         (AccessibilityUIElement::y):
4003         (AccessibilityUIElement::width):
4004         (AccessibilityUIElement::height):
4005         (AccessibilityUIElement::clickPointX):
4006         (AccessibilityUIElement::clickPointY):
4007         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4008         (WTR::AccessibilityUIElement::x):
4009         (WTR::AccessibilityUIElement::y):
4010         (WTR::AccessibilityUIElement::width):
4011         (WTR::AccessibilityUIElement::height):
4012         (WTR::AccessibilityUIElement::clickPointX):
4013         (WTR::AccessibilityUIElement::clickPointY):
4014
4015 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
4016
4017         [ATK] Expose aria-posinset and aria-setsize through object attributes
4018         https://bugs.webkit.org/show_bug.cgi?id=130011
4019
4020         Reviewed by Chris Fleizach.
4021
4022         Added missing implementation of numberAttributeValue both to WKTR and DRT.
4023
4024         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4025         (AccessibilityUIElement::numberAttributeValue):
4026         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4027         (WTR::AccessibilityUIElement::numberAttributeValue):
4028
4029 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
4030
4031         [Win] Unreviewed build fix.
4032
4033         Some bad Windows code was committed at some point that prevents the Apple Windows port
4034         from finding its runtime dependencies reliably.
4035
4036         * win/DLLLauncher/DLLLauncherMain.cpp:
4037         (appleApplicationSupportDirectory): Restored this function.
4038         (modifyPath): Update to use appleApplicationSupportDirectory function.
4039
4040 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
4041
4042         Let the user define the full address of the performance-site-server for uploading results
4043         https://bugs.webkit.org/show_bug.cgi?id=129819
4044
4045         Reviewed by Ryosuke Niwa.
4046
4047         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
4048         can be confusing. It's more straightforward, if you need to define explicitly the server's full
4049         address along with the protocol, when you're using this parameter. I added HTTPS as the default
4050         protocol for now, in order to avoid breaking the perf bots.
4051
4052         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4053         (_upload_json):
4054         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4055         (MainTest.test_upload_json):
4056
4057 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
4058
4059         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
4060         https://bugs.webkit.org/show_bug.cgi?id=130023
4061
4062         Reviewed by Dean Jackson.
4063
4064         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
4065         /SAFESEH flag to DLL launcher process.
4066
4067 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
4068
4069         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
4070         https://bugs.webkit.org/show_bug.cgi?id=129980
4071
4072         Reviewed by Carlos Garcia Campos.
4073
4074         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
4075
4076 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
4077
4078         [GTK] Remove the WebView source-mode WebKit1 test
4079         https://bugs.webkit.org/show_bug.cgi?id=129976
4080
4081         Reviewed by Carlos Garcia Campos.
4082
4083         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
4084
4085 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
4086
4087         Unreviewed build fix for GTKbuild after the switch to CMake
4088
4089         * gtk/common.py:
4090         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
4091         test-only bot doesn't have any build files.
4092
4093 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
4094
4095         [GTK] built-product-archive does not handle GTK+ CMake build
4096         https://bugs.webkit.org/show_bug.cgi?id=129941
4097
4098         * BuildSlaveSupport/built-product-archive:
4099         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
4100         the CMake build.
4101
4102 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
4103
4104         [GTK] Include CMake into install-dependencies script
4105         https://bugs.webkit.org/show_bug.cgi?id=129909
4106
4107         Reviewed by Martin Robinson.
4108
4109         As since r165267 buid-webkit uses CMake by default, the dependency
4110         with 'cmake' package should be introduced.
4111
4112         * gtk/install-dependencies: Ditto.
4113
4114 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
4115
4116         REGRESSION(165267): Broke a webkitpy unit tests
4117         https://bugs.webkit.org/show_bug.cgi?id=129904
4118
4119         Reviewed by Jon Honeycutt.
4120
4121         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
4122         (GtkPort._is_cmake_build):
4123
4124 2014-03-07  Andres Gomez  <agomez@igalia.com>
4125
4126         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
4127         https://bugs.webkit.org/show_bug.cgi?id=129893
4128
4129         Reviewed by Martin Robinson.
4130
4131         Added "git-svn" as dependency for deb based distros and,
4132         additionally, "subversion" for rpm based distros.
4133
4134         * gtk/install-dependencies:
4135
4136 2014-03-07  Roger Fong  <roger_fong@apple.com>
4137
4138         Remove dummy setSystemWebGLLoadPolicy client method.
4139         https://bugs.webkit.org/show_bug.cgi?id=129873.
4140
4141         Reviewed by Dean Jackson.
4142
4143         * WebKitTestRunner/TestController.cpp:
4144         (WTR::TestController::createWebViewWithOptions):
4145
4146 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
4147
4148         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
4149         https://bugs.webkit.org/show_bug.cgi?id=129886
4150
4151         Reviewed by Mark Lam.
4152
4153         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
4154         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
4155         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
4156         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
4157         make it through when in non-verbose mode.
4158
4159 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
4160
4161         [GTK] buid-webkit should use CMake by default
4162         https://bugs.webkit.org/show_bug.cgi?id=129855
4163
4164         Reviewed by Carlos Garcia Campos.
4165
4166         Make the CMake build the default GTK+ build when using build-webkit. This will
4167         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
4168         so that we have --gtk and --gtkautotools.
4169
4170         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
4171         * Scripts/webkitpy/port/gtk.py: Ditto.
4172
4173 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
4174
4175         [CMake] [GTK] Build with ninja when it is available
4176         https://bugs.webkit.org/show_bug.cgi?id=129805
4177
4178         Reviewed by Philippe Normand.
4179
4180         * Scripts/webkitdirs.pm:
4181         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
4182         if it's available on the system.
4183         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
4184         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
4185
4186 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
4187
4188         If the FTL is build-time enabled then it should be run-time enabled.
4189
4190         Rubber stamped by Geoffrey Garen.
4191
4192         * Scripts/run-jsc-stress-tests:
4193
4194 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
4195
4196         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
4197         https://bugs.webkit.org/show_bug.cgi?id=129837
4198
4199         Reviewed by Michael Saboff.
4200
4201         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
4202         The fix is to use find instead of ls like we do in shell-runner.sh.
4203
4204         * Scripts/run-jsc-stress-tests:
4205
4206 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
4207
4208         filter-build-webkit should not strip .o
4209         https://bugs.webkit.org/show_bug.cgi?id=129614
4210
4211         Reviewed by Dean Jackson.
4212
4213         This makes it much easier to jump from the failing output at
4214         the end back up to the compile errors earlier in the output.
4215
4216         * Scripts/filter-build-webkit:
4217
4218 2014-03-06  Anders Carlsson  <andersca@apple.com>
4219
4220         Build WebKit2 before building WebKit
4221         https://bugs.webkit.org/show_bug.cgi?id=129831
4222         <rdar://problem/15920020>
4223
4224         Reviewed by Dan Bernstein.
4225
4226         * Scripts/build-webkit:
4227         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
4228
4229 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
4230
4231         make-3.82 fails to build on ARM/Linux
4232         https://bugs.webkit.org/show_bug.cgi?id=107926
4233
4234         Reviewed by Martin Robinson.
4235
4236         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
4237         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
4238         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
4239         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
4240
4241         * gtk/patches/make-3.82-arg-list-length.patch:
4242
4243 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4244
4245         [GTK] Close the page when the view is disposed instead of when finalized
4246         https://bugs.webkit.org/show_bug.cgi?id=129783
4247
4248         Reviewed by Sergio Villar Senin.
4249
4250         Add test case but disabled for now because it's affetected by bug #129684.
4251
4252         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
4253         (testProcessPerWebView):
4254
4255 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4256
4257         [GTK] MiniBrowser crashes when opening several urls passed as command line options
4258         https://bugs.webkit.org/show_bug.cgi?id=129738
4259
4260         Reviewed by Sergio Villar Senin.
4261
4262         The problem is that we are calling g_object_unref() for the
4263         WebKitWebSettings everytime we set it to a WebKitWebView, but the
4264         view only increases the reference counter when the settings is not
4265         the same it currently has. We should release our reference once.
4266
4267         * MiniBrowser/gtk/main.c:
4268         (createBrowserWindow):
4269         (main):
4270
4271 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4272
4273         [GTK][CMake] Tarball is created with wrong tarball paths
4274         https://bugs.webkit.org/show_bug.cgi?id=129496
4275
4276         Reviewed by Daniel Bates.
4277
4278         * gtk/make-dist.py:
4279         (Manifest.__init__): I inadvertently inverted the logic of these checks when
4280         landing the original patch with some suggestions from the reviewer. With the
4281         checks corrected, the tarball path is constructed properly.
4282
4283 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
4284
4285         Unreviewed. Update my email in contributors.json
4286
4287         * Scripts/webkitpy/common/config/contributors.json:
4288
4289 2014-03-05  Dean Jackson  <dino@apple.com>
4290
4291         [WebGL] Use WKSI to see what the system policy for WebGL is
4292         https://bugs.webkit.org/show_bug.cgi?id=129722
4293         <rdar://problem/15790542>
4294
4295         Reviewed by Tim Horton.
4296
4297         Dummy entry for setSystemWebGLLoadPolicy.
4298
4299         * WebKitTestRunner/TestController.cpp:
4300         (WTR::TestController::createWebViewWithOptions):
4301
4302 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
4303
4304         [GTK][CMake] Generate documentation for the DOM bindings
4305         https://bugs.webkit.org/show_bug.cgi?id=126211
4306
4307         Reviewed by Carlos Garcia Campos.
4308
4309         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
4310         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
4311         * gtk/generate-webkitdom-doc-files: Removed.
4312         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
4313         that it can be called by generate-gtkdoc.
4314
4315 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4316
4317         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
4318         https://bugs.webkit.org/show_bug.cgi?id=129380
4319
4320         Reviewed by Philippe Normand.
4321
4322         * Scripts/webkitdirs.pm:
4323         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
4324         skipping CMake execution.
4325
4326 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4327
4328         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
4329         https://bugs.webkit.org/show_bug.cgi?id=129651
4330
4331         Reviewed by Philippe Normand.
4332