showAllRuns checkbox no longer works on the stats dashboard
[WebKit-https.git] / Tools / ChangeLog
1 2013-03-07  Julie Parent  <jparent@chromium.org>
2
3         showAllRuns checkbox no longer works on the stats dashboard
4         https://bugs.webkit.org/show_bug.cgi?id=111673
5
6         Reviewed by Ojan Vafai.
7
8         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
9         so we were trying to index into an undefined object.
10         
11         * TestResultServer/static-dashboards/dashboard_base.js:
12         (invalidateQueryParameters):
13
14 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
15
16         [Chromium] Update #include for WebStorageNamespace.h
17         https://bugs.webkit.org/show_bug.cgi?id=111748
18
19         Reviewed by Adam Barth.
20
21         In anticipation of removing
22         WK/chromium/public/WebStorageNamespace.h (once downstream
23         references have been updated)
24
25         * DumpRenderTree/chromium/WebViewHost.cpp:
26
27 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
28
29         run-perf-tests fails due to svn_revision not working on a pure git clone
30         https://bugs.webkit.org/show_bug.cgi?id=110839
31
32         Reviewed by Ryosuke Niwa.
33
34         Previously we would call git svn find-rev to look up the commit for
35         a given revision, and that'll hang in a pure git checkout.
36
37         This patch changes the way we look up svn revisions in a git
38         repository to use git log --grep 'git-svn-id', which is much faster
39         than grepping ourselves. It also renames timestamp_of_latest_commit()
40         to timestamp_of_revision() in order to accurately reflect what
41         the method is doing. Note that this patch only changes the logic
42         inside latest_revision() and svn_revision(). I'll file a separate
43         bug to change git_commit_from_svn_revision().
44
45         This patch also contains some fixes to unit tests that had bit-rotted
46         or were otherwise fragile, so that test-webkitpy --all would pass
47         cleanly, and a fix to outputcapture so that
48         test-webkitpy -p would work correctly again.
49
50         * Scripts/webkitpy/common/checkout/scm/git.py:
51         (Git.svn_revision):
52         (Git.timestamp_of_revision):
53         * Scripts/webkitpy/common/checkout/scm/scm.py:
54         (SCM.svn_revision):
55         (SCM.timestamp_of_revision):
56         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
57         (MockSCM.timestamp_of_revision):
58         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
59         (_shared_test_commit_with_message):
60         (test_commit_without_authorization):
61         (test_timestamp_of_revision):
62         * Scripts/webkitpy/common/checkout/scm/svn.py:
63         (SVN.timestamp_of_revision):
64         * Scripts/webkitpy/common/system/outputcapture.py:
65           Importing unittest2 directly may not be safe if this module is
66           imported before the autoinstaller gets a chance to set things up
67           properly. We don't actually need unittest2 here.
68         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
69         (PerfTestsRunner._generate_results_dict):
70
71 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
72
73         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
74         https://bugs.webkit.org/show_bug.cgi?id=111756
75
76         Reviewed by Kenneth Rohde Christiansen.
77
78         Bump libsoup to v2.40.3 to fix the regressions introduced by
79         previous v2.40.0 bump.
80
81         * efl/jhbuild.modules:
82
83 2013-03-07  Roger Fong  <roger_fong@apple.com>
84
85         Re-enable Win EWS tests.
86
87         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
88         (WinEWS):
89
90 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
91
92         [nrwt] handle corrupt http server pid files cleanly
93         https://bugs.webkit.org/show_bug.cgi?id=111628
94
95         Reviewed by Eric Seidel.
96
97         If the pid file from a previous http server is corrupt for some
98         reason, NRWT will just raise errors and not clean it up or recover.
99         This patch fixes that to at least delete the pid file and
100         not throw; not that we may still have stale http servers left on
101         the system, since there's no way to know which pid to kill if
102         the file was corrupted.
103
104         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
105         (HttpServerBase.start):
106         (HttpServerBase.stop):
107         (HttpServerBase._remove_pid_file):
108         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
109         (TestHttpServerBase):
110         (TestHttpServerBase.test_corrupt_pid_file):
111
112 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
113
114         AX: Can't activate links with VoiceOver in Safari
115         https://bugs.webkit.org/show_bug.cgi?id=111755
116
117         Reviewed by Tim Horton.
118
119         * DumpRenderTree/AccessibilityUIElement.cpp:
120         (supportedActionsCallback):
121         (AccessibilityUIElement::getJSClass):
122         * DumpRenderTree/AccessibilityUIElement.h:
123         (AccessibilityUIElement):
124         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
125         (AccessibilityUIElement::supportedActions):
126
127 2013-03-07  Roger Fong  <roger_fong@apple.com>
128
129         Windows debug layout tests are crashing like crazy again.
130         Disable tests on Win EWS bots temporarily.
131
132         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
133         (WinEWS):
134
135 2013-03-07  Roger Fong  <roger_fong@apple.com>
136
137         Make EWS bots build and test in release.
138
139         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
140         (WinEWS):
141         * Scripts/webkitpy/tool/steps/runtests.py:
142         (RunTests.run):
143
144 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
145
146         [chromium] don't track the top loading frame if no layout test is currently running
147         https://bugs.webkit.org/show_bug.cgi?id=111716
148
149         Reviewed by Kentaro Hara.
150
151         In DRT, we synchronously stop the test and start loading the next test
152         URL. However, in content_shell, this happens asynchronously. It's
153         important that the top loading frame is not changed due to stray
154         navigation events before the next test starts.
155
156         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
157         (WebTestRunner::TestRunner::setTopLoadingFrame):
158
159 2013-03-06  Julie Parent  <jparent@chromium.org>
160
161         Dashboard cleanup: Move all dashboard ui related code into ui.js.
162         https://bugs.webkit.org/show_bug.cgi?id=111621
163
164         Reviewed by Ojan Vafai.
165         
166         Creates ui.js, a package for the common UI code the various
167         dashboards use. HTML generation is now in the ui.html namespace
168         and popup handling is in ui.popup.
169         Also moves the event listening for popups to ui.popup.show and
170         removes it on ui.popup.hid rather than having listener always
171         around.
172
173         * TestResultServer/static-dashboards/aggregate_results.html:
174         * TestResultServer/static-dashboards/dashboard_base.js:
175         * TestResultServer/static-dashboards/flakiness_dashboard.html:
176         * TestResultServer/static-dashboards/flakiness_dashboard.js:
177         (showPopupForBuild):
178         (htmlForNavBar):
179         (generatePageForIndividualTests.if):
180         (generatePageForIndividualTests):
181         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
182         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
183         * TestResultServer/static-dashboards/run-embedded-unittests.html:
184         * TestResultServer/static-dashboards/run-unittests.html:
185         * TestResultServer/static-dashboards/timeline_explorer.html:
186         * TestResultServer/static-dashboards/treemap.html:
187         * TestResultServer/static-dashboards/ui.js: Added.
188         (.):
189
190 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
191
192         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
193         https://bugs.webkit.org/show_bug.cgi?id=110584
194
195         Reviewed by Gyuyoung Kim.
196
197         Adds missing implementation of AccessibilityControllerEfl
198         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
199         so that it can make accessibilityController as a js object.
200
201         * DumpRenderTree/AccessibilityController.h:
202         (AccessibilityController):
203         * DumpRenderTree/AccessibilityUIElement.h:
204         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
205         (AccessibilityController::childElementById): Moved declaration to base class.
206         Implementation can be shared among other ports.
207         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
208         (AccessibilityController::focusedElement):
209         (AccessibilityController::rootElement):
210         (AccessibilityController::accessibleElementById):
211         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
212         (AccessibilityUIElement::helpText):
213         * DumpRenderTree/efl/CMakeLists.txt:
214         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
215         (DumpRenderTreeChrome::DumpRenderTreeChrome):
216         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
217         (DumpRenderTreeChrome::onWindowObjectCleared):
218         (DumpRenderTreeChrome::accessibilityController):
219         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
220         (DumpRenderTreeChrome):
221         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
222
223 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
224
225         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
226         https://bugs.webkit.org/show_bug.cgi?id=42696
227
228         Reviewed by Andreas Kling.
229
230         * DumpRenderTree/TestRunner.cpp:
231         (TestRunner::staticFunctions):
232         * DumpRenderTree/TestRunner.h:
233         (TestRunner):
234         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
235         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
236         (WebTestRunner::TestRunner::TestRunner):
237         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
238         (TestRunner):
239         * DumpRenderTree/efl/TestRunnerEfl.cpp:
240         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
241         * DumpRenderTree/mac/TestRunnerMac.mm:
242         * DumpRenderTree/qt/TestRunnerQt.cpp:
243         * DumpRenderTree/qt/TestRunnerQt.h:
244         (TestRunnerQt):
245         * DumpRenderTree/win/TestRunnerWin.cpp:
246         * DumpRenderTree/wx/TestRunnerWx.cpp:
247
248 2013-03-06  Roger Fong  <roger_fong@apple.com>
249
250         Re-enable WinEWS test and decrease iterations before clean build back to 10.
251
252         * EWSTools/start-queue-win.sh:
253         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
254         (WinEWS):
255
256 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
257
258         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
259         https://bugs.webkit.org/show_bug.cgi?id=82866
260
261         Reviewed by Martin Robinson.
262
263         * Scripts/run-gtk-tests:
264         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
265         it is passing now.
266
267 2013-03-06  Julie Parent  <jparent@chromium.org>
268
269         Dashboard cleanup: remove dashboard time logging.
270         https://bugs.webkit.org/show_bug.cgi?id=111608
271
272         Reviewed by Dirk Pranke.
273
274         Remove logTime.  It was never accurate, and the dev tools
275         have better ways to measure this if anyone cares to look
276         into dashboard perf.
277         
278         * TestResultServer/static-dashboards/dashboard_base.js:
279         * TestResultServer/static-dashboards/flakiness_dashboard.js:
280         (processTestRunsForBuilder):
281         (appendHTML):
282
283 2013-03-06  Tony Chang  <tony@chromium.org>
284
285         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
286         https://bugs.webkit.org/show_bug.cgi?id=111509
287
288         Reviewed by Dirk Pranke.
289
290         Add DumpRenderTree.pak to DumpRenderTree.app again.
291
292         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
293
294 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
295
296         [chromium] introduce WebUserGestureIndicator
297         https://bugs.webkit.org/show_bug.cgi?id=111531
298
299         Reviewed by Adam Barth.
300
301         * DumpRenderTree/chromium/WebViewHost.cpp:
302         (WebViewHost::createView):
303
304 2013-03-06  Alan Cutter  <alancutter@chromium.org>
305
306         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
307         https://bugs.webkit.org/show_bug.cgi?id=73482
308
309         Reviewed by Ryosuke Niwa.
310
311         Added input checking to the UpdateChromiumDEPS step.
312         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
313
314         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
315         (RollChromiumDEPS):
316         (RollChromiumDEPS._parse_args):
317         (RollChromiumDEPS.execute):
318         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
319         (IRCCommandTest.test_roll_chromium_deps):
320         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
321         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
322         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
323         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
324         (UpdateChromiumDEPS._fetch_last_known_good_revision):
325         (UpdateChromiumDEPS):
326         (UpdateChromiumDEPS._parse_revision_number):
327         (UpdateChromiumDEPS._validate_revisions):
328         (UpdateChromiumDEPS.run):
329         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
330         (UpdateChromiumDEPSTest):
331         (UpdateChromiumDEPSTest.test_parse_revision_number):
332         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
333         (RollChromiumDEPS):
334         (PostChromiumDEPSRoll):
335
336 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
337
338         [Qt][MiniBrowser] Touch mocking broken for chained getures
339         https://bugs.webkit.org/show_bug.cgi?id=111430
340
341         Reviewed by Jocelyn Turcotte.
342
343         Make it possible again to use touch mocking to test gesture chains
344         like pan->pinch->pan->pinch without lifting the primary "finger".
345         For this to work we need to track the pressed mouse buttons and
346         only synthesize touch release events when the ctrl key is released
347         if no mouse button is pressed. Else the pressed mouse button(s)
348         should result in a stationary touch point in a touch update event.
349         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
350         to check for the state of the ctrl key modifier instead of getting
351         it from the mouse events.
352
353         * MiniBrowser/qt/MiniBrowserApplication.cpp:
354         (MiniBrowserApplication::MiniBrowserApplication):
355         (MiniBrowserApplication::notify):
356
357 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
358
359         [chromium] don't use custom freetype on linux asan for now
360         https://bugs.webkit.org/show_bug.cgi?id=111516
361
362         Unreviewed, build fix.
363
364         Turns out the custom lib is getting picked up by other binaries
365         on our bot, which is bad.
366
367         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
368
369 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
370
371         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
372         https://bugs.webkit.org/show_bug.cgi?id=111509
373
374         Unreviewed, build fix.
375
376         Actually comment out the flag :(.
377
378         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
379
380 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
381
382         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
383         https://bugs.webkit.org/show_bug.cgi?id=111509
384
385         Unreviewed, build fix.
386
387         r144863 appears to have broken the xcode build; I'm temporarily
388         trying this instead, and if this doesn't work, I'll revert the
389         other changes.
390
391         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
392
393 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
394
395         [chromium] build a DumpRenderTree.pak even on windows
396         https://bugs.webkit.org/show_bug.cgi?id=111504
397
398         Reviewed by Tony Chang.
399
400         The Chromium Aura build uses the default theme to draw
401         controls, and that theme requires the ui ResourceBundle
402         to be initialized. On every other platform, we build
403         a DumpRenderTree.pak that works for this, but on Windows we
404         still compile the resources directly into DRT. As a first step,
405         let's build the pak file. I will then need to land a patch
406         in Chromium to actually load it. Then I can go back and move
407         the resources over to just use the .pak file and no longer need
408         the .rc's.
409
410         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
411
412 2013-03-05  Julie Parent  <jparent@chromium.org>
413         Dashboard cleanup: move string utilities into their own namespace.
414         
415         https://bugs.webkit.org/show_bug.cgi?id=111485
416
417         Reviewed by Ojan Vafai.
418         
419         One of many pieces to clean up dashboard_base.
420         
421         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
422
423         * TestResultServer/static-dashboards/aggregate_results.html:
424         * TestResultServer/static-dashboards/dashboard_base.js:
425         (isTreeMap):
426         (isFlakinessDashboard):
427         * TestResultServer/static-dashboards/flakiness_dashboard.html:
428         * TestResultServer/static-dashboards/flakiness_dashboard.js:
429         (determineWKPlatform):
430         (chromiumPlatform):
431         (platformAndBuildType):
432         (substringList):
433         (individualTestsForSubstringList):
434         (filterBugs):
435         (populateExpectationsData):
436         (processMissingTestsWithExpectations):
437         (processMissingAndExtraExpectations):
438         (htmlForSingleTestRow):
439         (.dummyNode.onload):
440         (expectationsTitle):
441         * TestResultServer/static-dashboards/run-embedded-unittests.html:
442         * TestResultServer/static-dashboards/run-unittests.html:
443         * TestResultServer/static-dashboards/string.js: Added.
444         * TestResultServer/static-dashboards/timeline_explorer.html:
445         * TestResultServer/static-dashboards/treemap.html:
446
447 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
448
449         [EFL] Build break with latest EFL libraries
450         https://bugs.webkit.org/show_bug.cgi?id=111028
451
452         Reviewed by Dirk Pranke.
453
454         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
455         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
456         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
457
458 2013-03-05  Roger Fong  <roger_fong@apple.com>
459
460         Increase number of WinEWS iterations to 20.
461         Don't reboot after each iteration set.
462         Make EWS bots just build temporarily so that the queue catches up again.
463
464         * EWSTools/start-queue-win.sh:
465         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
466         (WinEWS):
467
468 2013-03-04  James Robinson  <jamesr@chromium.org>
469
470         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
471         https://bugs.webkit.org/show_bug.cgi?id=111386
472
473         Reviewed by Adrienne Walker.
474
475         * DumpRenderTree/chromium/TestShell.cpp:
476         (TestShell::initialize):
477
478 2013-03-05  Min Qin  <qinmin@chromium.org>
479
480         Copy dictionary to the external storage before running layout test on android
481         https://bugs.webkit.org/show_bug.cgi?id=111480
482
483         Reviewed by Adam Barth.
484
485         TestWebKitPlatformSupport now needs to read an external dictionary file.
486         This file does not exist on the device. We need to copy it before running layout tests.
487
488         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
489         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
490         (ChromiumAndroidDriver._push_platform_resources):
491
492 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
493
494         [chromium] DRT crashes in an Aura/Win build
495         https://bugs.webkit.org/show_bug.cgi?id=111394
496
497         Reviewed by Tony Chang.
498
499         When building (and running) with use_aura=1, we assume that
500         we're using the default theme engine, but DRT creates the
501         DRTWin theme engine and overwrites the default, leading to crashes
502         in basically every test from the mismatch.
503
504         This fix gets us down to at least "lots of crashes" :).
505
506         * DumpRenderTree/chromium/TestShellWin.cpp:
507         (platformInit):
508
509 2013-03-05  Eric Seidel  <eric@webkit.org>
510
511         Add html-parser-threaded perf test now that the threaded parser is enabled by default
512         https://bugs.webkit.org/show_bug.cgi?id=111200
513
514         Reviewed by Ryosuke Niwa.
515
516         Had to teach run-perf-tests to ignore one more warning.
517
518         * Scripts/webkitpy/performance_tests/perftest.py:
519         (PerfTest):
520
521 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
522
523         Update list of builders for test results server
524         https://bugs.webkit.org/show_bug.cgi?id=111166
525
526         Reviewed by Ojan Vafai.
527
528         * TestResultServer/static-dashboards/builders.jsonp:
529
530 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
531
532         [GTK] Move basic dependency installation to a script
533         https://bugs.webkit.org/show_bug.cgi?id=110692
534
535         Reviewed by Gustavo Noronha Silva.
536
537         * gtk/install-dependencies: Added. A Script which installs all dependencies
538         necessary for building for Debian-based distributions and Fedora.
539
540 2013-03-05  James Robinson  <jamesr@chromium.org>
541
542         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
543         https://bugs.webkit.org/show_bug.cgi?id=111440
544
545         Reviewed by Adrienne Walker.
546
547         Remove unnecessary WebCompositorSupport::shutdown call
548
549         * DumpRenderTree/chromium/DumpRenderTree.cpp:
550         (main):
551
552 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
553
554         Unreviewed build fix.
555
556         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
557
558 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
559
560         [Qt][MiniBrowser] Improve the update of touch indicators
561         https://bugs.webkit.org/show_bug.cgi?id=111429
562
563         Reviewed by Jocelyn Turcotte.
564
565         MiniBrowserApplication::sendTouchEvent sends an empty list
566         to BrowserWindow::updateVisualMockTouchPoints if the control
567         button is released, in which case the touch indicators should
568         be hidden so that we never end up with a leftover indicator
569         sticking on the screen.
570         This patch also simplifies the lookup of the indicator items by
571         replacing the findChild search in the item tree with a QHash
572         that stores the touch ID's and the pointers to the corresponding
573         indicator items.
574
575         * MiniBrowser/qt/BrowserWindow.cpp:
576         (BrowserWindow::updateVisualMockTouchPoints):
577         * MiniBrowser/qt/BrowserWindow.h:
578         (BrowserWindow):
579
580 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
581
582         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
583         https://bugs.webkit.org/show_bug.cgi?id=81042
584
585         Reviewed by Enrica Casucci.
586
587         Add setAsynchronousSpellCheckingEnabled implementation for
588         WebKitTestRunner to have the possibility to test asynchronous
589         spell checking implementation from bug 109577.
590
591         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
592         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
593         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
594         * WebKitTestRunner/InjectedBundle/TestRunner.h:
595         * WebKitTestRunner/TestController.cpp:
596         (WTR::TestController::resetStateToConsistentValues):
597
598 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
599
600         MediaStream API: Add the getStreamById method on RTCPeerConnection
601         https://bugs.webkit.org/show_bug.cgi?id=111311
602
603         Reviewed by Adam Barth.
604
605         Changing mocks to be more realistic.
606
607         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
608         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
609         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
610         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
611         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
612
613 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
614
615         Add content shell bots to garden-o-matic for general failurse
616         https://bugs.webkit.org/show_bug.cgi?id=111168
617
618         Reviewed by Adam Barth.
619
620         All but the WebKit (Content Shell) Android bot is stable enough. While
621         they're not green yet, there must not be any non-layout test failures on
622         them.
623
624         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
625         (.):
626
627 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
628
629         [chromium] remove deprecated WebTestRunner::setFocus API
630         https://bugs.webkit.org/show_bug.cgi?id=111354
631
632         Reviewed by James Robinson.
633
634         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
635         (WebTestDelegate):
636
637 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
638
639         Run the bindings generation tests on EWS and CQ bots
640         https://bugs.webkit.org/show_bug.cgi?id=111358
641
642         Reviewed by Adam Barth.
643
644         The tests are super fast and not flaky.
645
646         * Scripts/webkitpy/common/config/ports.py:
647         (DeprecatedPort.run_bindings_tests_command):
648         * Scripts/webkitpy/common/config/ports_mock.py:
649         (MockPort.run_webkit_tests_command):
650         (MockPort):
651         (MockPort.run_bindings_tests_command):
652         * Scripts/webkitpy/tool/commands/download_unittest.py:
653         * Scripts/webkitpy/tool/steps/runtests.py:
654         (RunTests.run):
655         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
656         (RunTestsTest.test_webkit_run_unit_tests):
657         * Scripts/webkitpy/tool/steps/steps_unittest.py:
658
659 2013-03-04  Eric Seidel  <eric@webkit.org>
660
661         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
662         https://bugs.webkit.org/show_bug.cgi?id=111384
663
664         Reviewed by Ryosuke Niwa.
665
666         Sometimes I want to know why various LayoutTests are slow
667         without having to convert them into PerformanceTests in order
668         to use our fancy profiling.  The Driver already knows how to
669         do the right thing, we just need to expose the options to the user.
670
671         Handling of these options is already unittested in the perftests_unittest.
672
673         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
674         (parse_args):
675
676 2013-03-04  Alan Cutter  <alancutter@chromium.org>
677
678         check-webkit-style says "Have to enable auto props in the subversion config file"
679         https://bugs.webkit.org/show_bug.cgi?id=107724
680
681         Reviewed by Tony Chang.
682
683         Added a standard svn config file for WebKit developers to use.
684         Updated the style and commit queue bot build scripts to load this file.
685
686         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
687         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
688         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
689         * svn-config: Added.
690
691 2013-03-04  James Robinson  <jamesr@chromium.org>
692
693         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
694         https://bugs.webkit.org/show_bug.cgi?id=111285
695
696         Reviewed by Adrienne Walker.
697
698         This removes the need for WebCompositorSupport::initialize and exposes
699         slightly fewer entry points across the repository boundary.
700
701         * DumpRenderTree/chromium/TestShell.cpp:
702         (TestShell::initialize):
703         * DumpRenderTree/chromium/TestShell.h:
704         (TestShell::webCompositorThread):
705         (TestShell):
706         * DumpRenderTree/chromium/WebViewHost.cpp:
707         (WebViewHost::initializeLayerTreeView):
708
709 2013-03-04  Roger Fong  <roger_fong@apple.com>
710
711         Unreviewed. Get rid of some AppleWin VS2010 build warnings.
712
713         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
714
715 2013-03-04  David Kilzer  <ddkilzer@apple.com>
716
717         BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
718
719             Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
720                 NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
721                                         ^         ~~~~~~~~~~~~~~~~~~~~~
722             1 error generated.
723
724         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
725         AccessibilityCommonMac.h.
726
727 2013-03-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
728
729         [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
730         https://bugs.webkit.org/show_bug.cgi?id=109828
731
732         Reviewed by Kenneth Rohde Christiansen.
733
734         Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
735         callbacks.
736
737         * TestWebKitAPI/CMakeLists.txt:
738
739             Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
740             considered.
741
742         * TestWebKitAPI/PlatformEfl.cmake:
743         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
744         (TestWebKitAPI):
745         (TestWebKitAPI::didFinishLoadForFrame):
746         (TestWebKitAPI::setPageLoaderClient):
747         (TestWebKitAPI::webProcessCrashed):
748         (TestWebKitAPI::webProcessDidRelaunch):
749         (TestWebKitAPI::setViewClient):
750         (TestWebKitAPI::TEST):
751
752 2013-03-04  Chris Fleizach  <cfleizach@apple.com>
753
754         AX: Upstream iOS Accessibility DumpRenderTree changes
755         https://bugs.webkit.org/show_bug.cgi?id=111220
756
757         Reviewed by David Kilzer.
758
759         Upstream the iOS changes for accessibility in DumpRenderTree.
760
761         * DumpRenderTree/AccessibilityUIElement.cpp:
762         (headerElementAtIndexCallback):
763         (linkedElementCallback):
764         (elementsForRangeCallback):
765         (increaseTextSelectionCallback):
766         (decreaseTextSelectionCallback):
767         (assistiveTechnologySimulatedFocusCallback):
768         (stringForSelectionCallback):
769         (getIPhoneLabelCallback):
770         (getIPhoneHintCallback):
771         (getIPhoneValueCallback):
772         (getIPhoneIdentifierCallback):
773         (getIPhoneTraitsCallback):
774         (getIPhoneIsElementCallback):
775         (getIPhoneElementTextPositionCallback):
776         (getIPhoneElementTextLengthCallback):
777         (AccessibilityUIElement::getJSClass):
778         * DumpRenderTree/AccessibilityUIElement.h:
779         (AccessibilityUIElement):
780         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
781         * DumpRenderTree/ios: Added.
782         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
783         (AccessibilityController::AccessibilityController):
784         (AccessibilityController::~AccessibilityController):
785         (AccessibilityController::elementAtPoint):
786         (AccessibilityController::focusedElement):
787         (AccessibilityController::rootElement):
788         (findAccessibleObjectById):
789         (AccessibilityController::accessibleElementById):
790         (AccessibilityController::setLogFocusEvents):
791         (AccessibilityController::setLogScrollingStartEvents):
792         (AccessibilityController::setLogValueChangeEvents):
793         (AccessibilityController::setLogAccessibilityEvents):
794         (AccessibilityController::addNotificationListener):
795         (AccessibilityController::removeNotificationListener):
796         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
797         (AccessibilityUIElement::AccessibilityUIElement):
798         (AccessibilityUIElement::~AccessibilityUIElement):
799         (concatenateAttributeAndValue):
800         (AccessibilityUIElement::iphoneLabel):
801         (AccessibilityUIElement::iphoneHint):
802         (AccessibilityUIElement::iphoneValue):
803         (AccessibilityUIElement::iphoneIdentifier):
804         (AccessibilityUIElement::iphoneTraits):
805         (AccessibilityUIElement::iphoneIsElement):
806         (AccessibilityUIElement::iphoneElementTextPosition):
807         (AccessibilityUIElement::iphoneElementTextLength):
808         (AccessibilityUIElement::url):
809         (AccessibilityUIElement::x):
810         (AccessibilityUIElement::y):
811         (AccessibilityUIElement::width):
812         (AccessibilityUIElement::height):
813         (AccessibilityUIElement::clickPointX):
814         (AccessibilityUIElement::clickPointY):
815         (AccessibilityUIElement::getChildren):
816         (AccessibilityUIElement::getChildrenWithRange):
817         (AccessibilityUIElement::childrenCount):
818         (AccessibilityUIElement::elementAtPoint):
819         (AccessibilityUIElement::indexOfChild):
820         (AccessibilityUIElement::getChildAtIndex):
821         (AccessibilityUIElement::headerElementAtIndex):
822         (AccessibilityUIElement::linkedElement):
823         (AccessibilityUIElement::linkedUIElementAtIndex):
824         (AccessibilityUIElement::ariaOwnsElementAtIndex):
825         (AccessibilityUIElement::ariaFlowToElementAtIndex):
826         (AccessibilityUIElement::disclosedRowAtIndex):
827         (AccessibilityUIElement::selectedRowAtIndex):
828         (AccessibilityUIElement::rowAtIndex):
829         (AccessibilityUIElement::titleUIElement):
830         (AccessibilityUIElement::parentElement):
831         (AccessibilityUIElement::disclosedByRow):
832         (AccessibilityUIElement::increaseTextSelection):
833         (AccessibilityUIElement::decreaseTextSelection):
834         (AccessibilityUIElement::stringForSelection):
835         (AccessibilityUIElement::stringForRange):
836         (AccessibilityUIElement::attributedStringForRange):
837         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
838         (AccessibilityUIElement::elementsForRange):
839         (AccessibilityUIElement::getLinkedUIElements):
840         (AccessibilityUIElement::getDocumentLinks):
841         (AccessibilityUIElement::attributesOfLinkedUIElements):
842         (AccessibilityUIElement::attributesOfDocumentLinks):
843         (AccessibilityUIElement::attributesOfChildren):
844         (AccessibilityUIElement::allAttributes):
845         (AccessibilityUIElement::stringAttributeValue):
846         (AccessibilityUIElement::isPressActionSupported):
847         (AccessibilityUIElement::isIncrementActionSupported):
848         (AccessibilityUIElement::isDecrementActionSupported):
849         (AccessibilityUIElement::boolAttributeValue):
850         (AccessibilityUIElement::isAttributeSettable):
851         (AccessibilityUIElement::isAttributeSupported):
852         (AccessibilityUIElement::parameterizedAttributeNames):
853         (AccessibilityUIElement::role):
854         (AccessibilityUIElement::subrole):
855         (AccessibilityUIElement::roleDescription):
856         (AccessibilityUIElement::title):
857         (AccessibilityUIElement::description):
858         (AccessibilityUIElement::orientation):
859         (AccessibilityUIElement::stringValue):
860         (AccessibilityUIElement::language):
861         (AccessibilityUIElement::helpText):
862         (AccessibilityUIElement::intValue):
863         (AccessibilityUIElement::minValue):
864         (AccessibilityUIElement::maxValue):
865         (AccessibilityUIElement::valueDescription):
866         (AccessibilityUIElement::insertionPointLineNumber):
867         (AccessibilityUIElement::isEnabled):
868         (AccessibilityUIElement::isRequired):
869         (AccessibilityUIElement::isFocused):
870         (AccessibilityUIElement::isSelected):
871         (AccessibilityUIElement::isExpanded):
872         (AccessibilityUIElement::isChecked):
873         (AccessibilityUIElement::hierarchicalLevel):
874         (AccessibilityUIElement::ariaIsGrabbed):
875         (AccessibilityUIElement::ariaDropEffects):
876         (AccessibilityUIElement::lineForIndex):
877         (AccessibilityUIElement::boundsForRange):
878         (AccessibilityUIElement::attributesOfColumnHeaders):
879         (AccessibilityUIElement::attributesOfRowHeaders):
880         (AccessibilityUIElement::attributesOfColumns):
881         (AccessibilityUIElement::attributesOfRows):
882         (AccessibilityUIElement::attributesOfVisibleCells):
883         (AccessibilityUIElement::attributesOfHeader):
884         (AccessibilityUIElement::rowCount):
885         (AccessibilityUIElement::columnCount):
886         (AccessibilityUIElement::indexInTable):
887         (AccessibilityUIElement::rowIndexRange):
888         (AccessibilityUIElement::columnIndexRange):
889         (AccessibilityUIElement::cellForColumnAndRow):
890         (AccessibilityUIElement::selectedTextRange):
891         (AccessibilityUIElement::assistiveTechnologySimulatedFocus):
892         (AccessibilityUIElement::setSelectedTextRange):
893         (AccessibilityUIElement::increment):
894         (AccessibilityUIElement::decrement):
895         (AccessibilityUIElement::showMenu):
896         (AccessibilityUIElement::press):
897         (AccessibilityUIElement::accessibilityValue):
898         (AccessibilityUIElement::documentEncoding):
899         (AccessibilityUIElement::documentURI):
900         (_accessibilityNotificationCallback):
901         (AccessibilityUIElement::addNotificationListener):
902         (AccessibilityUIElement::removeNotificationListener):
903         (AccessibilityUIElement::isFocusable):
904         (AccessibilityUIElement::isSelectable):
905         (AccessibilityUIElement::isMultiSelectable):
906         (AccessibilityUIElement::isSelectedOptionActive):
907         (AccessibilityUIElement::isVisible):
908         (AccessibilityUIElement::isOffScreen):
909         (AccessibilityUIElement::isCollapsed):
910         (AccessibilityUIElement::isIgnored):
911         (AccessibilityUIElement::hasPopup):
912         (AccessibilityUIElement::takeFocus):
913         (AccessibilityUIElement::takeSelection):
914         (AccessibilityUIElement::addSelection):
915         (AccessibilityUIElement::removeSelection):
916         (AccessibilityUIElement::uiElementForSearchPredicate):
917         (AccessibilityUIElement::numberAttributeValue):
918
919 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
920
921         [chromium] pass all focus handling methods through the WebTestDelegate
922         https://bugs.webkit.org/show_bug.cgi?id=111328
923
924         Reviewed by Nico Weber.
925
926         In content_shell, the focus handling is asynchronous. To allow for
927         switching the focus synchronously between WebViews, we need to intercept
928         didFocus and didBlur and forward it to the WebTestDelegate.
929
930         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
931         (WebTestDelegate):
932         (WebTestRunner::WebTestDelegate::setFocus):
933         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
934         (WebTestRunner::WebTestProxy::didFocus):
935         (WebTestRunner::WebTestProxy::didBlur):
936         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
937         (WebTestRunner::TestRunner::setWindowIsKey):
938         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
939         (WebTestRunner::WebTestProxyBase::didFocus):
940         (WebTestRunner):
941         (WebTestRunner::WebTestProxyBase::didBlur):
942         * DumpRenderTree/chromium/WebViewHost.cpp:
943         (WebViewHost::didFocus):
944         (WebViewHost::didBlur):
945         (WebViewHost::setFocus):
946         * DumpRenderTree/chromium/WebViewHost.h:
947         (WebViewHost):
948
949 2013-03-04  Claudio Saavedra  <csaavedra@igalia.com>
950
951         [GTK] No need to manually add system paths to jhbuildrc
952         https://bugs.webkit.org/show_bug.cgi?id=110850
953
954         Reviewed by Gustavo Noronha Silva.
955
956         * gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
957         already takes care of.
958
959 2013-03-04  Kinuko Yasuda  <kinuko@chromium.org>
960
961         [chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
962         https://bugs.webkit.org/show_bug.cgi?id=111284
963
964         Disabling the failing two tests on Android.
965
966         Reviewed by Jochen Eisinger.
967
968         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
969         (TestWebKitAPI):
970         (TestWebKitAPI::TEST):
971
972 2013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
973
974         Add build flag for FontLoader
975         https://bugs.webkit.org/show_bug.cgi?id=111289
976
977         Reviewed by Benjamin Poulain.
978
979         Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
980
981         * Scripts/webkitperl/FeatureList.pm:
982         * qmake/mkspecs/features/features.pri:
983
984 2013-03-03  Benjamin Poulain  <benjamin@webkit.org>
985
986         [Mac] Get rid of a useless method from DOMHTMLInputElement
987         https://bugs.webkit.org/show_bug.cgi?id=111279
988
989         Reviewed by Sam Weinig.
990
991         * DumpRenderTree/mac/TestRunnerMac.mm:
992         (TestRunner::setValueForUser):
993         The method _setValueForUser: was added for testing. This feature is already
994         exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
995         in real use cases. Get rid of the method created for testing, use the real thing
996         instead.
997
998 2013-03-03  Ryosuke Niwa  <rniwa@webkit.org>
999
1000         Some perf. tests have variances that differ greatly between runs
1001         https://bugs.webkit.org/show_bug.cgi?id=97510
1002
1003         Reviewed by Benjamin Poulain.
1004
1005         Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
1006         environment on test results (we run each instance after one another, not in parallel).
1007
1008         We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
1009         iterations as it was done previously in single process. These values are hard-coded in perftest.py
1010         and runner.js but they are to be configurable in the future.
1011
1012         Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
1013         metric now reports an array of the length 4 with each element containing an array of 5 iteration
1014         values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.
1015
1016         Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
1017         and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
1018         as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.
1019
1020         * Scripts/webkitpy/performance_tests/perftest.py:
1021         (PerfTestMetric.append_group): Renamed from append.
1022         (PerfTestMetric.grouped_iteration_values): Added.
1023         (PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.
1024
1025         (PerfTest.__init__): Takes the number of processes (drivers) to run tests with.
1026         This parameter is only used by SingleProcessPerfTest.
1027
1028         (PerfTest.run): Repeat tests using different driver processes.
1029         (PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
1030         since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
1031         We instead use _ensure_metrics to obtain the matched metrics and store the data there.
1032         (PerfTest._ensure_metrics): Added.
1033
1034         (SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
1035         instances of DumpRenderTree/WebKitTestRunner takes too long.
1036         (SingleProcessPerfTest.__init__):
1037
1038         (ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.
1039
1040         (PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.
1041
1042         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect
1043         _run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
1044         the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.
1045
1046         (TestPerfTestMetric.test_append): Updated per name and added some test cases for
1047         grouped_iteration_values.
1048
1049         (TestPerfTest._assert_results_are_correct):
1050
1051         (TestSingleProcessPerfTest): Added.
1052         (TestSingleProcessPerfTest.test_use_only_one_process):
1053         (TestSingleProcessPerfTest.test_use_only_one_process.run_single):
1054
1055         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1056         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1057
1058         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of
1059         sample standard deviations since we're now running tests 4 times.
1060         (MainTest._test_run_with_json_output.mock_upload_json):
1061         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
1062
1063 2013-03-03  Alexandre Elias  <aelias@chromium.org>
1064
1065         [chromium] Remove WebLayerTreeView::setViewportSize call
1066         https://bugs.webkit.org/show_bug.cgi?id=110727
1067
1068         Reviewed by James Robinson.
1069
1070         After https://codereview.chromium.org/12328080 lands,
1071         setViewportSize is called from the Chromium side. The multiplication
1072         by deviceScaleFactor here was prone to off-by-one errors.
1073         The layoutSize() function was only used here so delete it as well.
1074
1075         DumpRenderTree WebViewHost must now call this method as well.
1076
1077         * DumpRenderTree/chromium/WebViewHost.cpp:
1078         (WebViewHost::initializeLayerTreeView):
1079         (WebViewHost::setWindowRect):
1080         (WebViewHost::setDeviceScaleFactor):
1081         (WebViewHost::updateViewportSize):
1082         * DumpRenderTree/chromium/WebViewHost.h:
1083         (WebViewHost):
1084
1085 2013-02-27  Darin Adler  <darin@apple.com>
1086
1087         StringHasher functions require alignment that call sites do not all guarantee
1088         https://bugs.webkit.org/show_bug.cgi?id=110171
1089
1090         Reviewed by Benjamin Poulain.
1091
1092         * TestWebKitAPI/CMakeLists.txt:
1093         * TestWebKitAPI/GNUmakefile.am:
1094         * TestWebKitAPI/TestWebKitAPI.gypi:
1095         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1096         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1097         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1098         * TestWebKitAPI/Tests/WTF/WTF.pro:
1099         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1100         Added the StringHasher.cpp file.
1101
1102         * TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests
1103         for the functions in the StringHasher class.
1104
1105 2013-03-02  Benjamin Poulain  <bpoulain@apple.com>
1106
1107         Move computedStyleIncludingVisitedInfo from TestRunner to Internals
1108         https://bugs.webkit.org/show_bug.cgi?id=109772
1109
1110         Reviewed by Andreas Kling.
1111
1112         * DumpRenderTree/TestRunner.cpp:
1113         (TestRunner::staticFunctions):
1114         * DumpRenderTree/TestRunner.h:
1115         (TestRunner):
1116         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1117         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1118         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1119         * DumpRenderTree/mac/TestRunnerMac.mm:
1120         * DumpRenderTree/qt/TestRunnerQt.cpp:
1121         * DumpRenderTree/qt/TestRunnerQt.h:
1122         (TestRunner):
1123         * DumpRenderTree/win/TestRunnerWin.cpp:
1124         * DumpRenderTree/wx/TestRunnerWx.cpp:
1125         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1126         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1127         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1128         (TestRunner):
1129
1130 2013-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
1131
1132         Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
1133         https://bugs.webkit.org/show_bug.cgi?id=110943
1134
1135         Reviewed by Yury Semikhatsky.
1136
1137         Unfortunately in many cases raw pointer may point to an object that has been deleted.
1138         There is no working solution to solve this problem in general.
1139         It could be solved only on case by case basis.
1140
1141         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
1142         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
1143         (TestWebKitAPI::TEST):
1144
1145 2013-03-01  Jason Anderssen  <janderssen@gmail.com>
1146
1147         Move markerTextForListItem from TestRunner to Internals
1148         https://bugs.webkit.org/show_bug.cgi?id=110939
1149
1150         Reviewed by Benjamin Poulain.
1151
1152         * DumpRenderTree/TestRunner.cpp:
1153         (TestRunner::staticFunctions):
1154         * DumpRenderTree/TestRunner.h:
1155         (TestRunner):
1156         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1157         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1158         (WebTestRunner::TestRunner::TestRunner):
1159         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1160         (TestRunner):
1161         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1162         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1163         * DumpRenderTree/mac/TestRunnerMac.mm:
1164         * DumpRenderTree/qt/TestRunnerQt.cpp:
1165         * DumpRenderTree/qt/TestRunnerQt.h:
1166         (TestRunnerQt):
1167         * DumpRenderTree/win/TestRunnerWin.cpp:
1168         * DumpRenderTree/wx/TestRunnerWx.cpp:
1169         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1170         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1171         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1172         (TestRunner):
1173
1174 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1175
1176         Don't use legacy test names when returning results from PerfTest.run
1177         https://bugs.webkit.org/show_bug.cgi?id=111148
1178
1179         Reviewed by Dirk Pranke.
1180
1181         * Scripts/webkitpy/performance_tests/perftest.py:
1182         (PerfTestMetric.name): Renamed from metric.
1183         (PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
1184         (PerfTest.run): Use metric name instead of the legacy name to store iteration values.
1185         (ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.
1186
1187         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1188         (TestPerfTestMetric.test_init_set_time_metric):
1189         (TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
1190         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1191         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1192
1193         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1194         (PerfTestsRunner.__init__):
1195         (PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
1196         to obtain the trac URL instead of hard coding it.
1197         (PerfTestsRunner._run_tests_set):
1198
1199 2013-03-01  Roger Fong  <roger_fong@apple.com>
1200
1201         Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
1202         https://bugs.webkit.org/show_bug.cgi?id=111202
1203
1204         This is useful for running VCExpress builds from command line because there is
1205         no unified solution output, only per project build logs.
1206         The project will be run as the last project in the solution.
1207
1208         * win/AssembleBuildLogs: Added.
1209         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
1210         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
1211         * win/AssembleBuildLogs/AssembleLogs.cmd: Added.
1212         * win/AssembleBuildLogs/README: Added.
1213
1214 2013-03-01  Roger Fong  <roger_fong@apple.com>
1215
1216         Unreviewed. Increase number of patches processed before clean building on WinEWS bots.
1217
1218         * EWSTools/start-queue-win.sh:
1219
1220 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1221
1222         Don't return statistics in PerfTest.run
1223         https://bugs.webkit.org/show_bug.cgi?id=111145
1224
1225         Reviewed by Dirk Pranke.
1226
1227         Simply return a list of values obtained in each iteration from PerfTest.run.
1228         Also simplify various methods as needed.
1229
1230         * Scripts/webkitpy/performance_tests/perftest.py:
1231         (PerfTestMetric.__init__): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
1232         as needed from PerfTestsRunner._generate_results_dict.
1233
1234         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
1235         that we don't have to worry about the backward compatibility here.
1236
1237         (PerfTestMetric.iteration_values): Added.
1238         (PerfTestMetric.unit): Added.
1239         (PerfTestMetric.metric_to_unit):
1240         (PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.
1241
1242         (PerfTest.run):
1243         (PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.
1244
1245         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1246         (TestPerfTestMetric.test_init_set_missing_unit):
1247         (TestPerfTestMetric.test_init_set_time_metric): Added.
1248         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
1249         (TestPerfTestMetric.test_append):
1250         (TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
1251         test cases and it's not critical to keep math right as they're not used in output JSON anymore.
1252         (TestPerfTest._assert_results_are_correct):
1253         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1254         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1255
1256         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1257         (PerfTestsRunner._generate_results_dict):
1258
1259         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1260         (EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
1261         (SomeParserTestData): Ditto.
1262         (MemoryTestData): Ditto.
1263
1264 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1265
1266         [Qt] Enable LINK_PREFETCH
1267         https://bugs.webkit.org/show_bug.cgi?id=111158
1268
1269         Reviewed by Simon Hausmann.
1270
1271         * qmake/mkspecs/features/features.pri:
1272
1273 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1274
1275         [Qt] Update features.pri with new features
1276         https://bugs.webkit.org/show_bug.cgi?id=111157
1277
1278         Reviewed by Jocelyn Turcotte.
1279
1280         * qmake/mkspecs/features/features.pri:
1281
1282 2013-03-01  Jochen Eisinger  <jochen@chromium.org>
1283
1284         [chromium] put WebTestProxy::scheduleComposite back in place
1285         https://bugs.webkit.org/show_bug.cgi?id=111146
1286
1287         Reviewed by Nico Weber.
1288
1289         The call was removed in http://trac.webkit.org/changeset/144398 because
1290         DRT doesn't need it. However, content shell depends on this call.
1291
1292         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1293         (WebTestRunner::WebTestProxy::scheduleComposite):
1294
1295 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1296
1297         Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
1298         https://bugs.webkit.org/show_bug.cgi?id=111142
1299
1300         Reviewed by Adam Barth.
1301
1302         Merged _run_single_test into _run_tests_set. The code looks much cleaner now.
1303
1304         Also removed _print_status since it's never used anywhere.
1305
1306         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1307         (PerfTestsRunner.run):
1308         (PerfTestsRunner._run_tests_set):
1309         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1310         (MainTest.run_test):
1311         (MainTest.test_run_test_set):
1312         (MainTest.test_run_test_set_kills_drt_per_run):
1313         (MainTest.test_run_test_set_for_parser_tests):
1314
1315 2013-02-28  Kiran Muppala  <cmuppala@apple.com>
1316
1317         Disable window occlusion detection for WebKitTestRunner Web View on Mac
1318         https://bugs.webkit.org/show_bug.cgi?id=111116
1319
1320         Reviewed by Simon Fraser.
1321
1322         Window occlusion notifications were causing WebKitTestRunner's Web View
1323         to be detected as occluded and causing a few JavaScript timer layout
1324         tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
1325         by initializing the page visibility to "visible" after creating the view.
1326         But a better solution is to disable window occlusion detection, so that
1327         not only the page but also the view is treated as visible.
1328
1329         * WebKitTestRunner/TestController.cpp:
1330         (WTR::TestController::createWebViewWithOptions): Remove call to
1331         setVisibilityState, since it is no longer necessary.
1332         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1333         (WTR::PlatformWebView::PlatformWebView): Disable window occlusion
1334         detection for the created WKView.
1335
1336 2013-02-28  Li Yin  <li.yin@intel.com>
1337
1338         [chromium] Events can't be triggered on MediaStreamTrack
1339         https://bugs.webkit.org/show_bug.cgi?id=110930
1340
1341         Reviewed by Kentaro Hara.
1342
1343         Related code was moved to MediaStreamCenterChromium::didStopLocalMediaStream
1344
1345         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
1346         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
1347
1348 2013-02-27  James Robinson  <jamesr@chromium.org>
1349
1350         [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
1351         https://bugs.webkit.org/show_bug.cgi?id=111017
1352
1353         Reviewed by Adam Barth.
1354
1355         This decouples DumpRenderTree from WebLayerTreeViewClient.
1356
1357         * DumpRenderTree/chromium/WebViewHost.cpp:
1358         (WebViewHostDRTLayerTreeViewClient):
1359         (WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
1360         (WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
1361         (WebViewHostDRTLayerTreeViewClient::Layout):
1362         (WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
1363         (WebViewHost::initializeLayerTreeView):
1364         * DumpRenderTree/chromium/WebViewHost.h:
1365         (webkit_support):
1366         (WebViewHost):
1367
1368 2013-02-28  Ryuan Choi  <ryuan.choi@samsung.com>
1369
1370         Unreviewed, add my secondary email address to the list.
1371
1372         * Scripts/webkitpy/common/config/committers.py:
1373
1374 2013-02-28  Philip Rogers  <pdr@google.com>
1375
1376         Add Philip Rogers as a reviewer.
1377
1378         Unreviewed update of committers.py.
1379
1380         * Scripts/webkitpy/common/config/committers.py:
1381
1382 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1383
1384         Merge more methods on PerfTest
1385         https://bugs.webkit.org/show_bug.cgi?id=111030
1386
1387         Reviewed by Dirk Pranke.
1388
1389         Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
1390         and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.
1391
1392         This makes the control flow a lot more comprehensible.
1393
1394         * Scripts/webkitpy/performance_tests/perftest.py:
1395         (PerfTest._run_with_driver):
1396         (PerfTest._should_ignore_line):
1397         (PerfTest._filter_output):
1398
1399         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1400         (TestPerfTest._assert_results_are_correct):
1401         (test_ignored_stderr_lines):
1402
1403 2013-02-28  Robert Hogan  <robert@webkit.org>
1404
1405         Update my IRC nick
1406
1407         Unreviewed.
1408
1409         * Scripts/webkitpy/common/config/committers.py:
1410
1411 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
1412
1413         [Qt] Enable thin archives before parsing the project files
1414
1415         Rubber-stamped by Simon Hausmann.
1416
1417         The targetSubDir() function can be called before default_post.prf has been
1418         parsed therefore the gnu_thin_archives option has to be set in default_pre.prf
1419         which is parsed before the main project file.
1420         This issue was revealed by r144299 and fixes the clean build.
1421
1422         * qmake/mkspecs/features/default_post.prf:
1423         * qmake/mkspecs/features/default_pre.prf:
1424
1425 2013-02-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1426
1427         [Qt] Enable CANVAS_PATH flag
1428         https://bugs.webkit.org/show_bug.cgi?id=108508
1429
1430         Reviewed by Simon Hausmann.
1431
1432         Also enable CANVAS_PATH flag for Qt.
1433
1434         * qmake/mkspecs/features/features.pri:
1435
1436 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
1437
1438         [Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSubDir()
1439
1440         Rubber-stamped by Csaba Osztrogonác.
1441
1442         Besides suppressing a warning about the non-existing function this
1443         fixes the build if there is a subdirectory (eg. debug-and-release).
1444
1445         * TestWebKitAPI/InjectedBundle.pri:
1446         * TestWebKitAPI/TestWebKitAPI.pri:
1447
1448 2013-02-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1449
1450         [EFL][WTR] WTR cannot load injected bundle
1451         https://bugs.webkit.org/show_bug.cgi?id=111063
1452
1453         Reviewed by Csaba Osztrogonác.
1454
1455         WTR was not able to load injected bundle because of undefined 
1456         symbols for AccessibilityUIElement::scrollToMakeVisible(). 
1457         Adding empty implementation of this function to AccessibilityUIElementAtk.cpp
1458         solves the problem.
1459
1460         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1461         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1462
1463 2013-02-28  Alberto Garcia  <albgarcia@rim.com>
1464
1465         [BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
1466         https://bugs.webkit.org/show_bug.cgi?id=110464
1467
1468         Reviewed by Rob Buis.
1469
1470         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1471
1472 2013-02-28  Xan Lopez  <xlopez@rim.com>
1473
1474         [BlackBerry] DumpRenderTreeSupport: update the set position methods
1475         https://bugs.webkit.org/show_bug.cgi?id=110578
1476
1477         Reviewed by Rob Buis.
1478
1479         TestRunner::setMockGeolocationPosition() changed in r130416:
1480         http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
1481
1482         DumpRenderTreeSupport::setMockGeolocationError() was renamed to
1483         setMockGeolocationPositionUnavailableError() in r129444:
1484         http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h
1485
1486         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1487         (TestRunner::setMockGeolocationPosition):
1488         (TestRunner::setMockGeolocationPositionUnavailableError):
1489
1490 2013-02-28  Xan Lopez  <xlopez@rim.com>
1491
1492         [BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
1493         https://bugs.webkit.org/show_bug.cgi?id=110465
1494
1495         Reviewed by Rob Buis.
1496
1497         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1498         (LoadItem::invoke):
1499
1500 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1501
1502         PerfTestRunner doesn't need _needs_http and _has_http_lock
1503         https://bugs.webkit.org/show_bug.cgi?id=111037
1504
1505         Reviewed by Adam Barth.
1506
1507         Delete these variables in favor of using a local variable.
1508
1509         Member variables are like global variables. They introduce implicit dependencies
1510         between member functions.
1511
1512         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1513         (PerfTestsRunner.__init__):
1514         (PerfTestsRunner._start_http_servers):
1515         (PerfTestsRunner):
1516         (PerfTestsRunner._stop_http_servers):
1517         (PerfTestsRunner.run):
1518
1519 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1520
1521         Unreviewed, rolling out r144224.
1522         http://trac.webkit.org/changeset/144224
1523         https://bugs.webkit.org/show_bug.cgi?id=111045
1524
1525         Caused plugins/pass-different-npp-struct.html to time out
1526         (Requested by abarth on #webkit).
1527
1528         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1529         (PassDifferentNPPStruct::NPP_SetWindow):
1530         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1531         (NPP_SetWindow):
1532
1533 2013-02-27  Adam Barth  <abarth@webkit.org>
1534
1535         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
1536         https://bugs.webkit.org/show_bug.cgi?id=110907
1537
1538         Reviewed by Eric Seidel.
1539
1540         This patch changes --enable-threaded-html-parser into
1541         --disable-threaded-html-parser and thereby enables the threaded HTML
1542         parser by default for the Chromium port.
1543
1544         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1545         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1546         (WebTestRunner::WebPreferences::reset):
1547         * DumpRenderTree/chromium/TestShell.cpp:
1548         (TestShell::TestShell):
1549
1550 2013-02-27  Kiran Muppala  <cmuppala@apple.com>
1551
1552         Initialize page visibility after creating WebKitTestRunner WebView on Mac
1553         https://bugs.webkit.org/show_bug.cgi?id=111025
1554
1555         Reviewed by Simon Fraser.
1556
1557         Set page visibility to "visible" after creating WebView to override
1558         visibility state inferred from window occlusion notifications on Mac.
1559
1560         * WebKitTestRunner/TestController.cpp:
1561         (WTR::TestController::createWebViewWithOptions): Add call to
1562         setVisibilityState.
1563
1564 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1565
1566         Merge PageLoadingPerfTest into ReplayPerfTest
1567         https://bugs.webkit.org/show_bug.cgi?id=111027
1568
1569         Reviewed by Dirk Pranke.
1570
1571         Merged two classes.
1572
1573         We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
1574         part of ReplayPerfTest.
1575
1576         * Scripts/webkitpy/performance_tests/perftest.py:
1577         (ReplayPerfTest): Moved _FORCE_GC_FILE here.
1578         (ReplayPerfTest.__init__):
1579         (ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
1580         (ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.
1581         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1582         (TestReplayPerfTest):
1583         (TestReplayPerfTest.test_run_single.run_test):
1584         (TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
1585         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
1586         TestPageLoadingPerfTest.test_run.
1587         (TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
1588         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
1589         TestPageLoadingPerfTest.test_run_with_memory_output
1590         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
1591         (TestReplayPerfTest.test_prepare_calls_run_single):
1592
1593 2013-02-27  Eric Seidel  <eric@webkit.org>
1594
1595         Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
1596         https://bugs.webkit.org/show_bug.cgi?id=111021
1597
1598         Reviewed by Dirk Pranke.
1599
1600         The underlying code (which is shared with run-webkit-tests)
1601         already knew how to support this option, it just wasn't exposed
1602         via the run-perf-tests front-end.  This patch fixes that.
1603
1604         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1605         (PerfTestsRunner._parse_args):
1606
1607 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1608
1609         Stop uploading results to webkit-perf.appspot.com
1610         https://bugs.webkit.org/show_bug.cgi?id=110954
1611
1612         Reviewed by Benjamin Poulain.
1613
1614         Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.
1615
1616         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1617         (RunAndUploadPerfTests):
1618
1619 2013-02-27  James Simonsen  <simonjam@chromium.org>
1620
1621         [chromium] Lower priority of preloaded images
1622         https://bugs.webkit.org/show_bug.cgi?id=110527
1623
1624         Plumb the didChangePriority signal into DRT so it can be tested.
1625
1626         Reviewed by Nate Chapin.
1627
1628         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1629         (WebKit):
1630         (WebTestRunner::WebTestProxy::didChangeResourcePriority):
1631         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1632         (WebTestRunner::TestRunner::TestRunner):
1633         (WebTestRunner::TestRunner::reset):
1634         (WebTestRunner::TestRunner::shouldDumpResourcePriorities):
1635         (WebTestRunner):
1636         (WebTestRunner::TestRunner::dumpResourceRequestPriorities):
1637         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1638         (TestRunner):
1639         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1640         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
1641         (WebTestRunner::WebTestProxyBase::willSendRequest):
1642         (WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
1643         (WebTestRunner):
1644
1645 2013-02-27  Chris Fleizach  <cfleizach@apple.com>
1646
1647         AX: Mac platform should support ability to scroll an element into visible
1648         https://bugs.webkit.org/show_bug.cgi?id=109860
1649
1650         Reviewed by Beth Dakin.
1651
1652         * DumpRenderTree/AccessibilityUIElement.cpp:
1653         (scrollToMakeVisibleCallback):
1654         (AccessibilityUIElement::getJSClass):
1655         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1656         (AccessibilityUIElement::scrollToMakeVisible):
1657         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1658         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1659         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1660         (AccessibilityUIElement):
1661         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1662         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1663         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1664         (WTR):
1665
1666 2013-02-27  John Bauman  <jbauman@chromium.org>
1667
1668         Plugin in iframe may not display
1669         https://bugs.webkit.org/show_bug.cgi?id=109879
1670
1671         Reviewed by Simon Fraser.
1672
1673         LogNPPSetWindow will be used with other ports as well.
1674
1675         * DumpRenderTree/DumpRenderTree.gypi:
1676         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1677
1678 2013-02-27  Jochen Eisinger  <jochen@chromium.org>
1679
1680         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
1681         https://bugs.webkit.org/show_bug.cgi?id=110973
1682
1683         Reviewed by Adam Barth.
1684
1685         There is nothing that ensures that the log messages from the plugin
1686         come in before the layout test finished loading.
1687
1688         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1689         (PassDifferentNPPStruct::NPP_SetWindow):
1690         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1691         (NPP_SetWindow):
1692
1693 2013-02-27  Glenn Adams  <glenn@skynav.com>
1694
1695         Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
1696         https://bugs.webkit.org/show_bug.cgi?id=110944
1697
1698         Reviewed by Dean Jackson.
1699
1700         * Scripts/webkitperl/FeatureList.pm:
1701         * qmake/mkspecs/features/features.pri:
1702
1703 2013-02-27  Yong Li  <yong.li.webkit@outlook.com>
1704
1705         Unreviewed. Remove myself from watchlist.
1706
1707         * Scripts/webkitpy/common/config/watchlist:
1708
1709 2013-02-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1710
1711         Switch QtWebKit to GStreamer 1.0.
1712         https://bugs.webkit.org/show_bug.cgi?id=106669.
1713
1714         Original patch by Sebastian Dröge.
1715         Reviewed by Csaba Osztrogonác.
1716
1717         Build with GStreamer 1.0 if available, but support GStreamer 0.10 
1718         temporarily to make upgrading easy and the patch suitable for Qt5.
1719
1720         * qmake/mkspecs/features/features.prf:
1721
1722 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
1723
1724         Unreviewed. Added myself to committers.py
1725
1726         * Scripts/webkitpy/common/config/committers.py:
1727
1728 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1729
1730         Unreviewed, rolling out r144192.
1731         http://trac.webkit.org/changeset/144192
1732         https://bugs.webkit.org/show_bug.cgi?id=110984
1733
1734         Stored svn password on wrong computer (Requested by kkristof
1735         on #webkit).
1736
1737         * Scripts/webkitpy/common/config/committers.py:
1738
1739 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
1740
1741         Unreviewed. Added myself to committers.py
1742
1743         * Scripts/webkitpy/common/config/committers.py:
1744
1745 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1746
1747         Build fix after r144155. The report page is located at /api/report, not /api/test/report.
1748
1749         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1750         (PerfTestsRunner._upload_json):
1751
1752 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1753
1754         Stop uploading results to webkit-perf.appspot.com
1755         https://bugs.webkit.org/show_bug.cgi?id=110954
1756
1757         Reviewed by Benjamin Poulain.
1758
1759         When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
1760         Also, always use the new JSON format. Removed the code to generate the old format.
1761
1762         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1763         (PerfTestsRunner._generate_and_show_results):
1764         (PerfTestsRunner._generate_results_dict):
1765         (PerfTestsRunner._merge_slave_config_json):
1766         (PerfTestsRunner._generate_output_files):
1767
1768 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1769
1770         Unreviewed, rolling out r144136, r144143, and r144147.
1771         http://trac.webkit.org/changeset/144136
1772         http://trac.webkit.org/changeset/144143
1773         http://trac.webkit.org/changeset/144147
1774         https://bugs.webkit.org/show_bug.cgi?id=110950
1775
1776         Caused some timeouts and flaky crashes (Requested by abarth on
1777         #webkit).
1778
1779         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1780         (main):
1781         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1782         (WebTestRunner::WebPreferences::reset):
1783         * DumpRenderTree/chromium/TestShell.cpp:
1784         (TestShell::TestShell):
1785
1786 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1787
1788         Use perf.webkit.org JSON format in results page
1789         https://bugs.webkit.org/show_bug.cgi?id=110842
1790
1791         Reviewed by Benjamin Poulain.
1792
1793         Change the default JSON format from that of webkit-perf.appspot.com to that of perf.webkit.org.
1794
1795         A whole bunch of integration tests have been updated to use the new JSON format.
1796
1797         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1798         (PerfTestsRunner._generate_and_show_results): Renamed output and output_path to legacy_output
1799         and legacy_output_json_path respectively.
1800         (PerfTestsRunner._generate_results_dict): Don't assume meta build information is always available.
1801         (PerfTestsRunner._generate_output_files): Make json_output, which is used to generate the default
1802         JSON file and the results page out of perf_webkit_output instead of legacy_output.
1803
1804         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1805         (MainTest.test_run_memory_test):
1806         (MainTest._test_run_with_json_output.mock_upload_json):
1807         (MainTest):
1808         (MainTest.test_run_with_json_output):
1809         (MainTest.test_run_with_description):
1810         (MainTest.test_run_generates_json_by_default):
1811         (MainTest.test_run_merges_output_by_default):
1812         (MainTest.test_run_respects_reset_results):
1813         (MainTest.test_run_generates_and_show_results_page):
1814         (MainTest.test_run_with_slave_config_json):
1815         (MainTest.test_run_with_multiple_repositories):
1816         (MainTest.test_run_with_upload_json):
1817         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
1818
1819 2013-02-26  Adam Barth  <abarth@webkit.org>
1820
1821         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
1822         https://bugs.webkit.org/show_bug.cgi?id=110907
1823
1824         Reviewed by Eric Seidel.
1825
1826         This patch changes --enable-threaded-html-parser into
1827         --disable-threaded-html-parser and thereby enables the threaded HTML
1828         parser by default for the Chromium port.
1829
1830         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1831         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1832         (WebTestRunner::WebPreferences::reset):
1833         * DumpRenderTree/chromium/TestShell.cpp:
1834         (TestShell::TestShell):
1835
1836 2013-02-26  Dirk Pranke  <dpranke@chromium.org>
1837
1838         [chromium] Re-enable the fixed version of freetype on linux
1839         https://bugs.webkit.org/show_bug.cgi?id=110542
1840
1841         Reviewed by Tony Chang.
1842
1843         Re-land the change in r143794 to switch to building with a fixed
1844         version of FreeType for just DumpRenderTree. This allows us to share
1845         one version of pixel baselines for both Lucid and Precise, and run the
1846         layout tests in a stock Precise install (instead of a Lucid chroot).
1847         Going forward, this approach isolates us from os-level changes to the
1848         version of FreeType. Note that Chromium itself still uses the system
1849         FreeType and is unaffected by this change.
1850         
1851         This setting can still be turned off (at compile/gyp-time) by
1852         manually setting use_custom_freetype=0.
1853
1854         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1855
1856 2013-02-26  Nico Weber  <thakis@chromium.org>
1857
1858         [chromium] content shell drt: Enable WebKit::setLayoutTestMode()
1859         https://bugs.webkit.org/show_bug.cgi?id=110890
1860
1861         Reviewed by Jochen Eisinger.
1862
1863         Several functions in webkit check that bit to change rendering
1864         in layout test mode. For example, platform/graphics/skia/FrontSkia.cpp
1865         disables font smoothing in this mode. TestShell and DRT both set
1866         this flag, so content shell drt should set it too.
1867
1868         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1869         (WebTestRunner::TestInterfaces::TestInterfaces):
1870
1871 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
1872
1873         new-commit-bot: Fix the unit test newcommitbot-unittest.py due to r144040
1874         https://bugs.webkit.org/show_bug.cgi?id=110884
1875
1876         Reviewed by Csaba Osztrogonác.
1877
1878         Adding the missing spaces before ':' in the unit test.
1879
1880         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1881
1882 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
1883
1884         new-commit-bot: Some IRC clients doesn't linkify rollout messages
1885         https://bugs.webkit.org/show_bug.cgi?id=110861
1886
1887         Reviewed by Ryosuke Niwa.
1888
1889         Adding the space before ':' in order to fix the links shown for the rollout message.
1890
1891         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1892         (NewCommitBot._summarize_commit_log):
1893
1894 2013-02-26  Joone Hur  <joone.hur@intel.com>
1895
1896         [GTK] Add Clutter to jhbuild
1897         https://bugs.webkit.org/show_bug.cgi?id=110245
1898
1899         Reviewed by Martin Robinson.
1900
1901         Add clutter, cogl, clutter-gtk, and atk to the optional moduleset.
1902         This allows to build WebKitGtk+ with clutter as an acceleration backend
1903         within the jhbuild environment. 
1904
1905         * gtk/jhbuild-optional.modules:
1906
1907 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1908
1909         Another fix attempt after r143991 since having \r? after a greedy match doesn't help.
1910
1911         * Scripts/webkitpy/common/checkout/scm/svn.py:
1912         (SVN.value_from_svn_info):
1913
1914 2013-02-25  Alan Cutter  <alancutter@chromium.org>
1915
1916         GCE EWS bots failing intermittently on HTTP 502 error while updating their status
1917         https://bugs.webkit.org/show_bug.cgi?id=110845
1918
1919         Unreviewed EWS bot fix.
1920
1921         Switch the Queue Status Server address the EWS bots use to a more direct URL that
1922         doesn't seem to be having problems from GCE like queues.webkit.org.
1923
1924         * Scripts/webkitpy/common/net/statusserver.py:
1925         (StatusServer):
1926
1927 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
1928
1929         Forgot to delete a no-longer-needed unit test after r143980.
1930
1931         Unreviewed, build fix.
1932
1933         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1934         (ChromiumWinTest.test_path_to_image_diff):
1935
1936 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1937
1938         Build fix. run-perf-tests was reporting with revision numbers ending with \r.
1939         Don't include \r at the end of svn info lines on Windows.
1940
1941         This is similar to r143839.
1942
1943         * Scripts/webkitpy/common/checkout/scm/svn.py:
1944         (SVN.value_from_svn_info):
1945
1946 2013-02-25  James Simonsen  <simonjam@chromium.org>
1947
1948         [Resource Timing] Update test suite so it can be exported to the W3C
1949         https://bugs.webkit.org/show_bug.cgi?id=107343
1950
1951         Reviewed by Tony Gentilcore.
1952
1953         * Scripts/export-w3c-performance-wg-tests: Clean up output.
1954         * Scripts/import-w3c-performance-wg-tests:
1955
1956 2013-02-25  Anders Carlsson  <andersca@apple.com>
1957
1958         Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
1959         https://bugs.webkit.org/show_bug.cgi?id=110821
1960         <rdar://problem/13265303>
1961
1962         Reviewed by Beth Dakin.
1963
1964         Update for WebKit2 changes.
1965
1966         * MiniBrowser/mac/WK2BrowserWindowController.m:
1967         (-[WK2BrowserWindowController awakeFromNib]):
1968         * WebKitTestRunner/TestController.cpp:
1969         (WTR::TestController::createOtherPage):
1970         (WTR::TestController::createWebViewWithOptions):
1971         (WTR::TestController::unavailablePluginButtonClicked):
1972         * WebKitTestRunner/TestController.h:
1973         (TestController):
1974
1975 2013-02-21  Jeffrey Pfau  <jpfau@apple.com>
1976
1977         Optionally partition cache to prevent using cache for tracking
1978         https://bugs.webkit.org/show_bug.cgi?id=110269
1979
1980         Reviewed by Maciej Stachowiak.
1981
1982         Add test suite for public suffix functions on Mac.
1983
1984         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1985         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.
1986         (TestWebKitAPI):
1987         (TestWebKitAPI::TEST_F):
1988
1989 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
1990
1991         nrwt: reenable multiple http shards on chromium win
1992         https://bugs.webkit.org/show_bug.cgi?id=110814
1993
1994         Reviewed by Tony Chang.
1995
1996         The underlying bug in DumpRenderTree that was causing us to look for a
1997         pac file and timeout under load was fixed a while ago.
1998
1999         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2000         (ChromiumWinPort.relative_test_filename):
2001
2002 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
2003
2004         Make ninja the default w/ build-webkit --chromium on windows.
2005         https://bugs.webkit.org/show_bug.cgi?id=110731
2006
2007         Unreviewed - TBR'ing thakis :).
2008
2009         * Scripts/update-webkit-chromium:
2010
2011 2013-02-25  Anders Carlsson  <andersca@apple.com>
2012
2013         Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
2014         https://bugs.webkit.org/show_bug.cgi?id=110793
2015         <rdar://problem/13265303>
2016
2017         Reviewed by Sam Weinig.
2018
2019         Update for WebKit2 API changes.
2020
2021         * MiniBrowser/mac/WK2BrowserWindowController.m:
2022         (-[WK2BrowserWindowController awakeFromNib]):
2023         * WebKitTestRunner/TestController.cpp:
2024         (WTR::TestController::createWebViewWithOptions):
2025
2026 2013-02-25  Nico Weber  <thakis@chromium.org>
2027
2028         Fix python unit tests after yoli's email address update in http://trac.webkit.org/changeset/143922
2029         https://bugs.webkit.org/show_bug.cgi?id=110775
2030
2031         Unreviewed, basically a rebaseline.
2032
2033         * Scripts/webkitpy/common/config/watchlist:
2034
2035 2013-02-25  Nico Weber  <thakis@chromium.org>
2036
2037         [chromium] Try to get the webkit builder to use msvs again
2038         https://bugs.webkit.org/show_bug.cgi?id=110771
2039
2040         Reviewed by Eric Seidel.
2041
2042         The msvs gyp generator apparently doesn't write the sln file on every
2043         run, so check the vcxproj file instead.
2044
2045         * Scripts/webkitdirs.pm:
2046         (determineIsChromiumNinja):
2047
2048 2013-02-25  Nico Weber  <thakis@chromium.org>
2049
2050         [chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
2051         https://bugs.webkit.org/show_bug.cgi?id=110767
2052
2053         Reviewed by Eric Seidel.
2054
2055         The tester runs gyp, which generates out/Release/build.ninja. The bot
2056         scripts use existence (and timestamp) of that file to decide if the
2057         current build is supposed to be ninja or xcodebuild. The file exists,
2058         so the snapshot is extracted to out/Release. The snapshot doesn't
2059         contain build.ninja however due to
2060         http://trac.webkit.org/changeset/140375 , so after extracting the
2061         snapshot the scripts think that this is an xcodebuild build. So remove
2062         the part of that revision that removed ninja files from the archive,
2063         and the bots should be happy again.
2064
2065         * BuildSlaveSupport/built-product-archive:
2066         (archiveBuiltProduct):
2067
2068 2013-02-25  Nico Weber  <thakis@chromium.org>
2069
2070         Fix tests after r143910
2071         https://bugs.webkit.org/show_bug.cgi?id=110757
2072
2073         Reviewed by Andreas Kling.
2074
2075         While here, also add a test for the bug r143910 fixed.
2076
2077         * Scripts/webkitpy/common/system/executive_unittest.py:
2078         (ScriptErrorTest.test_message_with_output):
2079         (ScriptErrorTest):
2080         (ScriptErrorTest.test_message_with_tuple):
2081
2082 2013-02-25  Nico Weber  <thakis@chromium.org>
2083
2084         [chromium] Apparently built-product-archive is written in Python, not Perl :-/
2085         https://bugs.webkit.org/show_bug.cgi?id=110755
2086
2087         Reviewed by Jochen Eisinger.
2088
2089         * BuildSlaveSupport/built-product-archive:
2090         (archiveBuiltProduct):
2091         (extractBuiltProduct):
2092
2093 2013-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2094
2095         Unreviewed, rolling out r143895.
2096         http://trac.webkit.org/changeset/143895
2097         https://bugs.webkit.org/show_bug.cgi?id=110758
2098
2099         broke a bunch of tests (Requested by thakis__ on #webkit).
2100
2101         * Scripts/update-webkit-chromium:
2102
2103 2013-02-25  Andreas Kling  <akling@apple.com>
2104
2105         Unreviewed, fix simple mistake in r143903.
2106         <http://webkit.org/b/110746>
2107
2108         Reviewed by Andreas Kling.
2109
2110         Pass git revision, not svn revision, to git shell command.
2111
2112         * Scripts/webkitpy/common/checkout/scm/git.py:
2113         (Git.timestamp_of_latest_commit):
2114
2115 2013-02-25  Nico Weber  <thakis@chromium.org>
2116
2117         [chromium] Let built-product-archive log which directory it's archiving from and extracting to
2118         https://bugs.webkit.org/show_bug.cgi?id=110748
2119
2120         Reviewed by Jochen Eisinger.
2121
2122         One of the mac testers runs DRT from out/ but WebKitUnitTests from
2123         xcodebuild. I'm trying to understand what's going on.
2124
2125         * BuildSlaveSupport/built-product-archive:
2126         (archiveBuiltProduct):
2127         (extractBuiltProduct):
2128
2129 2013-02-23  Ilya Tikhonovsky  <loislo@chromium.org>
2130
2131         Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
2132         https://bugs.webkit.org/show_bug.cgi?id=110599
2133
2134         Reviewed by Yury Semikhatsky.
2135
2136         Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
2137         that were given us via MemoryInstrumentation calls.
2138         So I extended client api with registerString method that pushes the strings
2139         down to the serializer.
2140
2141         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2142         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
2143         (TestWebKitAPI::Helper::Helper):
2144         (Helper):
2145         (TestWebKitAPI::Helper::addNode):
2146         (TestWebKitAPI::TEST):
2147
2148 2013-02-25  Nico Weber  <thakis@chromium.org>
2149
2150         Make ScriptError not crash when args is a tuple
2151         https://bugs.webkit.org/show_bug.cgi?id=110747
2152
2153         Reviewed by Jochen Eisinger.
2154
2155         I'm trying to understand the error on
2156         http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
2157         better. I'll likely have to revert the ninja switch on windows, but
2158         having error reporting code that doesn't itself crash sounds like a
2159         good thing to have anyways.
2160
2161         The problem is that '%s' % (1, 2) errors out, and args is sometimes a
2162         tuple not a list.
2163
2164         * Scripts/run-chromium-webkit-unit-tests:
2165         * Scripts/webkitpy/common/system/executive.py:
2166         (ScriptError.__init__):
2167
2168 2013-02-25  Laszlo Gombos  <l.gombos@samsung.com>
2169
2170         [EFL] Align feature defaults
2171         https://bugs.webkit.org/show_bug.cgi?id=110715
2172
2173         Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
2174         OptionsEfl.cmake.
2175
2176         Reviewed by Gyuyoung Kim.
2177
2178         * Scripts/webkitperl/FeatureList.pm:
2179
2180 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2181
2182         run-perf-tests reports wrong commit time
2183         https://bugs.webkit.org/show_bug.cgi?id=110746
2184
2185         Reviewed by Andreas Kling.
2186
2187         The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
2188         of when the subdirectory was last modified.
2189
2190         Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
2191         insufficient since running "svn log -r <revision>" on a partial checkout only returns
2192         an empty result if the revision didn't modify the subdirectory.
2193
2194         For git, there is no partial checkout, so we just need to pass in "-r" option to keep
2195         the interface compatible with svn.
2196
2197         * Scripts/webkitpy/common/checkout/scm/git.py:
2198         (Git.timestamp_of_latest_commit):
2199         * Scripts/webkitpy/common/checkout/scm/scm.py:
2200         (SCM.timestamp_of_latest_commit):
2201         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2202         (MockSCM.timestamp_of_latest_commit):
2203         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2204         (test_timestamp_of_latest_commit):
2205         * Scripts/webkitpy/common/checkout/scm/svn.py:
2206         (SVN.timestamp_of_latest_commit):
2207         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2208         (PerfTestsRunner._generate_results_dict):
2209
2210 2013-02-25  Jochen Eisinger  <jochen@chromium.org>
2211
2212         [chromium] move WebRuntimeFeatures configuration to TestRunner library
2213         https://bugs.webkit.org/show_bug.cgi?id=110712
2214
2215         Reviewed by Nico Weber.
2216
2217         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2218         (WebTestRunner::TestInterfaces::TestInterfaces):
2219         * DumpRenderTree/chromium/TestShell.cpp:
2220         (TestShell::TestShell):
2221
2222 2013-02-25  Nico Weber  <thakis@chromium.org>
2223
2224         Make ninja the default build system for build-webkit --chromium on windows
2225         https://bugs.webkit.org/show_bug.cgi?id=110731
2226
2227         Reviewed by Jochen Eisinger.
2228
2229         With http://crbug.com/169945 fixed, this should now work.
2230
2231         * Scripts/update-webkit-chromium:
2232
2233 2013-02-24  Gustavo Noronha Silva  <gns@gnome.org>
2234
2235         [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
2236         https://bugs.webkit.org/show_bug.cgi?id=110702
2237
2238         Reviewed by Martin Robinson.
2239
2240         * GtkLauncher/main.c: include autotoolsconfig.h.
2241         * Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
2242         the include ordering check, since it uses autotoolsconfig.h which needs to
2243         come first.
2244
2245 2013-02-24  Hajime Morrita  <morrita@google.com>
2246
2247         [Custom Elements] Implement bare-bone document.register()
2248         https://bugs.webkit.org/show_bug.cgi?id=100229
2249
2250         Reviewed by Adam Barth.
2251
2252         Added enableCustomDOMElements flag.
2253
2254         * DumpRenderTree/chromium/TestShell.cpp:
2255         (TestShell::TestShell):
2256
2257 2013-02-23  Mark Pilgrim  <pilgrim@chromium.org>
2258
2259         [Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
2260         https://bugs.webkit.org/show_bug.cgi?id=110606
2261
2262         Reviewed by Adam Barth.
2263
2264         Part of a larger refactoring series; see tracking bug 82948.
2265
2266         * DumpRenderTree/DumpRenderTree.gypi:
2267         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2268         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
2269         (WebKitSupportTestEnvironment::mockPlatform):
2270         (WebKitSupportTestEnvironment):
2271         * DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
2272         (MockPlatform::create):
2273         (MockPlatform::MockPlatform):
2274         (MockPlatform::~MockPlatform):
2275         (MockPlatform::setInterfaces):
2276         (MockPlatform::cryptographicallyRandomValues):
2277         (MockPlatform::createMediaStreamCenter):
2278         (MockPlatform::createRTCPeerConnectionHandler):
2279         * DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
2280         (MockPlatform):
2281         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
2282         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
2283         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2284         (WebTestDelegate):
2285         * DumpRenderTree/chromium/TestShell.cpp:
2286         (TestShell::initialize):
2287         * DumpRenderTree/chromium/TestShell.h:
2288         (TestShell):
2289
2290 2013-02-23  Ryosuke Niwa  <rniwa@webkit.org>
2291
2292         Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.
2293
2294         * Scripts/webkitpy/common/checkout/scm/svn.py:
2295         (SVN.timestamp_of_latest_commit):
2296
2297 2013-02-23  Jason Anderssen  <janderssen@gmail.com>
2298
2299         Move setAutofilled from TestRunner to WebCore
2300         https://bugs.webkit.org/show_bug.cgi?id=110521
2301
2302         Reviewed by Benjamin Poulain.
2303
2304         * DumpRenderTree/TestRunner.cpp:
2305         (TestRunner::staticFunctions):
2306         * DumpRenderTree/TestRunner.h:
2307         (TestRunner):
2308         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2309         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2310         (WebTestRunner::TestRunner::TestRunner):
2311         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2312         (TestRunner):
2313         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2314         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2315         * DumpRenderTree/mac/TestRunnerMac.mm:
2316         * DumpRenderTree/qt/TestRunnerQt.cpp:
2317         * DumpRenderTree/qt/TestRunnerQt.h:
2318         (TestRunnerQt):
2319         * DumpRenderTree/win/TestRunnerWin.cpp:
2320         * DumpRenderTree/wx/TestRunnerWx.cpp:
2321
2322 2013-02-22  Ryosuke Niwa  <rniwa@webkit.org>
2323
2324         Upload results to perf.webkit.org in addition to the one specified by --test-results-server
2325         https://bugs.webkit.org/show_bug.cgi?id=108577
2326
2327         Reviewed by Dirk Pranke.
2328
2329         Upload results to perf.webkit.org using new JSON format as well as the host specified by
2330         --test-results-server. The new format is needed to provide extra information perf.webkit.org
2331         need such as the subversion commit time and test URLs. This is a temporarily measure until
2332         we complete the transition and the old JSON format and the code to upload results to
2333         webkit-perf.appspot.com can be deleted.
2334
2335         This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
2336         in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
2337         so that the app can sort performance test results based on the timestamp of the last commit.
2338
2339         It also changes the repository names returned by port objects to be properly capitalized
2340         human readable names such as WebKit instead of lowercased names such as webkit since these names
2341         are displayed on perf.webkit.org for humans. Several users of this feature has been updated
2342         to explicitly lowercase the names.
2343
2344
2345         * Scripts/webkitpy/common/checkout/scm/git.py:
2346         (Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
2347         git's timestamp granularity is seconds so we're losing some information compared to using a regular
2348         subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
2349         UTC so we're going to manually fiddle with timezone.
2350
2351         * Scripts/webkitpy/common/checkout/scm/scm.py:
2352         (SCM.timestamp_of_latest_commit): Added.
2353
2354         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2355         (MockSCM.timestamp_of_latest_commit): Added.
2356
2357         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2358         (test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.
2359
2360         * Scripts/webkitpy/common/checkout/scm/svn.py:
2361         (SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
2362         the timestamp which is always in UTC.
2363
2364         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2365         (JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
2366         'chromium' needs to be substituted by 'chrome' for historical reasons.
2367
2368         * Scripts/webkitpy/layout_tests/port/base.py:
2369         (Port.repository_paths): Return WebKit instead of webkit as noted above.
2370
2371         * Scripts/webkitpy/layout_tests/port/chromium.py:
2372         (ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.
2373
2374         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2375         (PerfTestsRunner.__init__): Store the current time in UTC as well as in local time.
2376         (PerfTestsRunner._collect_tests):
2377
2378         (PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
2379         and upload them appropriately.
2380
2381         (PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
2382         in revisions_for_perf_webkit and construct an output for perf.webkit.org.
2383
2384         (PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.
2385
2386         (PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
2387         and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
2388         e.g. "processor" would be renamed to "builderProcessor".
2389
2390         (PerfTestsRunner._generate_output_files):
2391
2392         (PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
2393         on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
2394         to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
2395         webkit-perf.appspot.com which spits out a plaintext response.
2396
2397         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2398         (MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
2399         (MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
2400         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.
2401
2402         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2403         (MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
2404         cases to parse JSON responses.
2405         (MainTest.test_upload_json.MockFileUploader): Refactored.
2406         (MainTest.test_upload_json.MockFileUploader.reset): Added.
2407         (MainTest.test_upload_json.MockFileUploader.__init__):
2408         (MainTest.test_upload_json.MockFileUploader.upload_single_text_file):
2409
2410 2013-02-22  Roger Fong  <roger_fong@apple.com>
2411
2412         Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.
2413
2414         * BuildSlaveSupport/build.webkit.org-config/config.json:
2415
2416 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
2417
2418         Unreviewed, rolling out r143794.
2419         http://trac.webkit.org/changeset/143794
2420         https://bugs.webkit.org/show_bug.cgi?id=110542
2421
2422         debug linux builds broken?
2423
2424         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2425
2426 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
2427
2428         [chromium] enable the fixed version of freetype on linux
2429         https://bugs.webkit.org/show_bug.cgi?id=110542
2430
2431         Reviewed by Tony Chang.
2432
2433         Switch to building with a fixed version of FreeType for
2434         just DumpRenderTree. This allows us to share one version
2435         of pixel baselines for both Lucid and Precise, and run
2436         the layout tests in a stock Precise install (instead of a Lucid
2437         chroot). Going forward, this approach isolates us from os-level
2438         changes to the version of FreeType. Note that Chromium itself
2439         still uses the system FreeType and is unaffected by this change.
2440         
2441         This setting can still be turned off (at compile/gyp-time) by
2442         manually setting use_custom_freetype=0.
2443
2444         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2445
2446 2013-02-22  Anders Carlsson  <andersca@apple.com>
2447
2448         Move pluginLoadPolicy to the page loader client
2449         https://bugs.webkit.org/show_bug.cgi?id=110635
2450
2451         Reviewed by Sam Weinig.
2452
2453         * MiniBrowser/mac/WK2BrowserWindowController.m:
2454         (-[WK2BrowserWindowController awakeFromNib]):
2455         * WebKitTestRunner/TestController.cpp:
2456         (WTR::TestController::createOtherPage):
2457         (WTR::TestController::createWebViewWithOptions):
2458
2459 2013-02-22  Kenneth Russell  <kbr@google.com>
2460
2461         Unreviewed. Changed gman's primary address for auto-complete in Bugzilla.
2462
2463         * Scripts/webkitpy/common/config/committers.py:
2464
2465 2013-02-22  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2466
2467         [WTR] Do not dump information about empty subframes.
2468         https://bugs.webkit.org/show_bug.cgi?id=110585
2469
2470         Reviewed by Simon Fraser.
2471
2472         Follow DumpRenderTree more closely by skipping empty frames
2473         (frames which have no document). We are not really interested in
2474         showing anything about them.
2475
2476         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2477         (WTR::dumpDescendantFramesText): Do not print subframe names when they
2478         have no associated Document.
2479
2480 2013-02-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2481
2482         [EFL][DRT] Do not dump empty frames.
2483         https://bugs.webkit.org/show_bug.cgi?id=110474
2484
2485         Reviewed by Kenneth Rohde Christiansen.
2486
2487         Follow the original Mac implementation more closely by skipping
2488         empty frames (frames which have no document). We are not really
2489         interested in showing anything about them.
2490
2491         * DumpRenderTree/efl/DumpRenderTree.cpp:
2492         (dumpFramesAsText):
2493
2494 2013-02-21  Dirk Pranke  <dpranke@chromium.org>
2495
2496         [chromium] support the lucid version of freetype on precise in DRT
2497         https://bugs.webkit.org/show_bug.cgi?id=107338
2498
2499         Reviewed by Tony Chang.
2500
2501         Modify the DRT build so that we can optionally link against
2502         a fixed version of Freetype2. This allows us to share pixel test
2503         results across multiple versions of Ubuntu without having to
2504         worry about differences in font rendering.
2505
2506         At the moment this feature is off by default. Eventually it will
2507         be on by default on linux.
2508
2509         Note that this only affects DRT; the regular Chromium binary
2510         (and, for now, content_shell) will still use the system version
2511         of Freetype.
2512
2513         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2514
2515 2013-02-21  Rouslan Solomakhin  <rouslan@chromium.org>
2516
2517         [Chromium] Remove the word "cheher" from the list of misspelled words
2518         https://bugs.webkit.org/show_bug.cgi?id=110447
2519
2520         Reviewed by Tony Chang.
2521
2522         Other platforms do not mark "cheher" as a misspelled word in layout tests.
2523         This change is to bring Chromium platform in line with the rest of the
2524         platforms.
2525
2526         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
2527         (WebTestRunner::MockSpellCheck::hasInCache): Changed "cheher" to "wellcome".
2528         (WebTestRunner::MockSpellCheck::fillSuggestionList): Removed "cheher" misspelling and "checker" suggestion.
2529         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Removed "cheher" misspelling.
2530
2531 2013-02-21  Jochen Eisinger  <jochen@chromium.org>
2532
2533         [chromium] document WebTestDelegate and WebTestRunner interfaces
2534         https://bugs.webkit.org/show_bug.cgi?id=110472
2535
2536         Reviewed by Adam Barth.
2537
2538         Also remove the default implementation of the remaining WebTestDelegate
2539         methods now that all embedders provide this interface.
2540
2541         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2542         (WebTestDelegate):
2543         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2544         (WebTestRunner):
2545
2546 2013-02-19  Mark Hahnenberg  <mhahnenberg@apple.com>
2547
2548         Objective-C API: Need a way to use the Objective-C JavaScript API with WebKit
2549         https://bugs.webkit.org/show_bug.cgi?id=106059
2550
2551         Reviewed by Geoffrey Garen.
2552
2553         Added new tests for the WebKit API portion of the JSC Objective-C API.
2554
2555         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2556         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache1.html: Added.
2557         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache2.html: Added.
2558         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm: Added.
2559         (-[MyConsole log:]):
2560         (-[MyConsole printHelloWorld]):
2561         (-[MyConsole add:to:]):
2562         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didFinishLoadForFrame:]):
2563         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
2564         (TestWebKitAPI):
2565         (TestWebKitAPI::TEST):
2566
2567 2013-02-21  Stephen Chenney  <schenney@chromium.org>
2568
2569         Unreviewed, add myself as a reviewer
2570
2571         * Scripts/webkitpy/common/config/committers.py:
2572
2573 2013-02-21  Jer Noble  <jer.noble@apple.com>
2574
2575         Unreviewed; add myself to the Media watchlist and update my committers.py setting to Reviewer.
2576
2577         * Scripts/webkitpy/common/config/committers.py:
2578         * Scripts/webkitpy/common/config/watchlist:
2579
2580 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
2581
2582         gtk/DumpRenderTree.cpp is missing <locale.h> include
2583         https://bugs.webkit.org/show_bug.cgi?id=109386
2584
2585         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build
2586         by include locale.h when we use setlocale.
2587
2588 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
2589
2590         [GTK] Move feature overriding to the configure phase
2591         https://bugs.webkit.org/show_bug.cgi?id=110293
2592
2593         Reviewed by Gustavo Noronha Silva.
2594
2595         * Scripts/webkitdirs.pm:
2596         (runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
2597         WebKitFeatureOverrides.txt to better match the other filenames used in
2598         the new feature processing.
2599         * gtk/generate-feature-defines-files: Added. A script which takes as an argument
2600         the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
2601         and writes WebKitFeatures.txt and WebKitFeatures.h.
2602         * gtk/override-feature-defines: Removed.
2603
2604 2013-02-21  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
2605
2606         [Qt] Remove obsolete DEPENDPATH assignment
2607
2608         Reviewed by Simon Hausmann
2609
2610         qmake now adds CONFIG+=depend_includepath by default, making manual
2611         DEPENDPATH setup unnecessary.
2612
2613         * qmake/mkspecs/features/default_post.prf:
2614
2615 2013-02-20  Vivek Galatage  <vivekg@webkit.org>
2616
2617         Unreviewed. Changing primary email id.
2618
2619         * Scripts/webkitpy/common/config/committers.py:
2620
2621 2013-02-14  James Robinson  <jamesr@chromium.org>
2622
2623         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
2624         https://bugs.webkit.org/show_bug.cgi?id=109634
2625
2626         Reviewed by Adrienne Walker.
2627
2628         * DumpRenderTree/chromium/WebViewHost.cpp:
2629         (WebViewHost::createOutputSurface):
2630         (WebViewHost::initializeLayerTreeView):
2631
2632 2013-02-20  Martin Robinson  <mrobinson@igalia.com>
2633
2634         [GTK] Re-enable 3D CSS transforms when using build-webkit
2635         https://bugs.webkit.org/show_bug.cgi?id=110402
2636
2637         Reviewed by Xan Lopez.
2638
2639         * Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default
2640         when building WebKitGTK+.
2641
2642 2013-02-20  Roger Fong  <roger_fong@apple.com>
2643
2644         Get VS2010 Solution B&I ready.
2645         <rdar://problem/1322988>
2646
2647         Rubberstamped by Timothy Horton.        
2648         
2649         Add Production configurations.
2650         
2651         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2652         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2653         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Added.
2654         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
2655         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Added.
2656         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
2657         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2658         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2659         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Added.
2660         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
2661         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Added.
2662         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
2663         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2664         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Added.
2665         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
2666         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2667         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Added.
2668         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
2669         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2670         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2671         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Added.
2672         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
2673         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Added.
2674         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
2675         * win/record-memory/record-memory.vcxproj:
2676         * win/record-memory/record-memoryProduction.props: Added.
2677         * win/record-memory/record-memoryRelease.props:
2678
2679 2013-02-20  Dirk Schulze  <krit@webkit.org>
2680
2681         Enable CANVAS_PATH flag
2682         https://bugs.webkit.org/show_bug.cgi?id=108508
2683
2684         Reviewed by Simon Fraser.
2685
2686         Enable CANVAS_PATH flag on trunk.
2687
2688         * Scripts/webkitperl/FeatureList.pm:
2689
2690 2013-02-20  Tony Chang  <tony@chromium.org>
2691
2692         Parse author names with commas in ChangeLogs
2693         https://bugs.webkit.org/show_bug.cgi?id=110356
2694
2695         Reviewed by Dirk Pranke.
2696
2697         Paweł's name has a comma in it, which was confusing the ChangeLog parser.
2698
2699         * Scripts/webkitpy/common/checkout/changelog.py:
2700         (ChangeLogEntry): Move name splitting regexp into a constant.
2701         (ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
2702         (ChangeLogEntry._split_reviewer_names): Rename to be more specific.
2703         (ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
2704         (ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.
2705         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2706         (test_parse_authors): Test case with Paweł's name.
2707
2708 2013-02-15  Dirk Schulze  <krit@webkit.org>
2709
2710         [Chromium] Add runtime flag for CanvasPath
2711         https://bugs.webkit.org/show_bug.cgi?id=109997
2712
2713         Reviewed by Adam Barth.
2714
2715         Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
2716         the constructor for Path on DOMWindow would never be activatable, since the script
2717         is running after creating the DOMWindow object.
2718
2719         * DumpRenderTree/chromium/TestShell.cpp:
2720         (TestShell::TestShell):
2721
2722 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
2723
2724         [chromium] use a WebTestProxyBase pointer to identify the window we need the history for
2725         https://bugs.webkit.org/show_bug.cgi?id=110346
2726
2727         Reviewed by Adam Barth.
2728
2729         Using an index is very brittle, as the TestRunner API does not define
2730         any ordering of windows.
2731
2732         Also, make TestRunner::shouldDumpBackForwardList() so content shell can
2733         trigger the capturing in the browser process before generating the
2734         text dump.
2735
2736         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2737         (WebTestRunner):
2738         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
2739         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2740         (WebTestRunner):
2741         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2742         (TestRunner):
2743         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2744         (WebTestRunner::WebTestProxyBase::captureTree):
2745         * DumpRenderTree/chromium/WebViewHost.cpp:
2746         (WebViewHost::captureHistoryForWindow):
2747         * DumpRenderTree/chromium/WebViewHost.h:
2748         (WebViewHost):
2749
2750 2013-02-19  Rouslan Solomakhin  <rouslan@chromium.org>
2751
2752         [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache
2753         https://bugs.webkit.org/show_bug.cgi?id=109220
2754
2755         Reviewed by Tony Chang.
2756
2757         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
2758         (WebTestRunner::MockSpellCheck::hasInCache): Added a method to detect whether spellcheck results can be served from cache.
2759         (WebTestRunner):
2760         (WebTestRunner::MockSpellCheck::fillSuggestionList): Modified to suggest "checker" for the word "cheher".
2761         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Modified to mark "cheher" as misspelling.
2762         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
2763         (MockSpellCheck):
2764         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
2765         (WebTestRunner::SpellCheckClient::requestCheckingOfText): Modified to serve spellcheck suggestions from cache when possible.
2766
2767 2013-02-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2768
2769         [Gtk] HTML5 Media controls require a design refresh
2770         https://bugs.webkit.org/show_bug.cgi?id=83869
2771
2772         Reviewed by Philippe Normand.
2773
2774         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2775         (initializeGtkFontSettings): Added gnome as default icon theme for
2776         the DRT.
2777         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2778         (WTR::initializeGtkSettings): Added gnome as default icon theme for
2779         the WTR.
2780         * gtk/jhbuild.modules: Added gnome-icon-theme-symbolic as external
2781         dependency.
2782
2783 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
2784
2785         [chromium] move most of the remaining mocks to TestRunner library
2786         https://bugs.webkit.org/show_bug.cgi?id=110217
2787
2788         Reviewed by Nico Weber.
2789
2790         While most of the functionality provided by these mocks is also
2791         available in the content module, there is no straight forward way to
2792         inject the mock results required for layout tests.
2793
2794         * DumpRenderTree/DumpRenderTree.gypi:
2795         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2796         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2797         (WebKit):
2798         (WebTestRunner):
2799         (WebTestRunner::WebTestProxy::geolocationClient):
2800         (WebTestRunner::WebTestProxy::speechInputController):
2801         (WebTestRunner::WebTestProxy::speechRecognizer):
2802         (WebTestRunner::WebTestProxy::deviceOrientationClient):
2803         (WebTestRunner::WebTestProxy::requestPointerLock):
2804         (WebTestRunner::WebTestProxy::requestPointerUnlock):
2805         (WebTestRunner::WebTestProxy::isPointerLocked):
2806         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.
2807         (WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
2808         (WebTestRunner):
2809         (WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
2810         (WebTestRunner::MockWebSpeechInputController::setDelegate):
2811         (WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
2812         (WebTestRunner::MockWebSpeechInputController::setDumpRect):
2813         (WebTestRunner::MockWebSpeechInputController::clearResults):
2814         (WebTestRunner::MockWebSpeechInputController::startRecognition):
2815         (WebTestRunner::MockWebSpeechInputController::cancelRecognition):
2816         (WebTestRunner::MockWebSpeechInputController::stopRecording):
2817         (WebTestRunner::MockWebSpeechInputController::speechTaskFired):
2818         (WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
2819         (WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
2820         (WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):
2821         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.
2822         (WebKit):
2823         (WebTestRunner):
2824         (MockWebSpeechInputController):
2825         (WebTestRunner::MockWebSpeechInputController::taskList):
2826         (SpeechTask):
2827         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.
2828         (WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
2829         (WebTestRunner):
2830         (WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
2831         (WebTestRunner::MockWebSpeechRecognizer::setDelegate):
2832         (WebTestRunner::MockWebSpeechRecognizer::start):
2833         (WebTestRunner::MockWebSpeechRecognizer::stop):
2834         (WebTestRunner::MockWebSpeechRecognizer::abort):
2835         (WebTestRunner::MockWebSpeechRecognizer::addMockResult):
2836         (WebTestRunner::MockWebSpeechRecognizer::setError):
2837         (WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
2838         (WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
2839         (WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):
2840         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.
2841         (WebKit):
2842         (WebTestRunner):
2843         (MockWebSpeechRecognizer):
2844         (WebTestRunner::MockWebSpeechRecognizer::wasAborted):
2845         (WebTestRunner::MockWebSpeechRecognizer::client):
2846         (WebTestRunner::MockWebSpeechRecognizer::handle):
2847         (WebTestRunner::MockWebSpeechRecognizer::taskList):
2848         (Task):
2849         (WebTestRunner::MockWebSpeechRecognizer::Task::Task):
2850         (WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
2851         (StepTask):
2852         (WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):
2853         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2854         (WebTestRunner::TestInterfaces::TestInterfaces):
2855         (WebTestRunner::TestInterfaces::windowOpened):
2856         (WebTestRunner):
2857         (WebTestRunner::TestInterfaces::windowClosed):
2858         (WebTestRunner::TestInterfaces::windowList):
2859         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2860         (TestInterfaces):
2861         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2862         (WebTestRunner::TestRunner::TestRunner):
2863         (WebTestRunner::TestRunner::reset):
2864         (WebTestRunner::TestRunner::requestPointerLock):
2865         (WebTestRunner):
2866         (WebTestRunner::TestRunner::requestPointerUnlock):
2867         (WebTestRunner::TestRunner::isPointerLocked):
2868         (WebTestRunner::TestRunner::didAcquirePointerLockInternal):
2869         (WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
2870         (WebTestRunner::TestRunner::didLosePointerLockInternal):
2871         (WebTestRunner::TestRunner::windowCount):
2872         (WebTestRunner::TestRunner::setMockDeviceOrientation):
2873         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
2874         (WebTestRunner::TestRunner::setGeolocationPermission):
2875         (WebTestRunner::TestRunner::setMockGeolocationPosition):
2876         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
2877         (WebTestRunner::TestRunner::addMockSpeechInputResult):
2878         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
2879         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
2880         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
2881         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
2882         (WebTestRunner::TestRunner::didAcquirePointerLock):
2883         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
2884         (WebTestRunner::TestRunner::didLosePointerLock):
2885         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
2886         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
2887         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2888         (WebTestRunner):
2889         (TestRunner):
2890         (HostMethodTask):
2891         (WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
2892         (WebTestRunner::TestRunner::HostMethodTask::runIfValid):
2893         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2894         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
2895         (WebTestRunner::WebTestProxyBase::setInterfaces):
2896         (WebTestRunner::WebTestProxyBase::setDelegate):
2897         (WebTestRunner::WebTestProxyBase::reset):
2898         (WebTestRunner::WebTestProxyBase::captureTree):
2899         (WebTestRunner::WebTestProxyBase::geolocationClientMock):
2900         (WebTestRunner):
2901         (WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
2902         (WebTestRunner::WebTestProxyBase::speechInputControllerMock):
2903         (WebTestRunner::WebTestProxyBase::speechRecognizerMock):
2904         (WebTestRunner::WebTestProxyBase::geolocationClient):
2905         (WebTestRunner::WebTestProxyBase::speechInputController):
2906         (WebTestRunner::WebTestProxyBase::speechRecognizer):
2907         (WebTestRunner::WebTestProxyBase::deviceOrientationClient):
2908         (WebTestRunner::WebTestProxyBase::requestPointerLock):
2909         (WebTestRunner::WebTestProxyBase::requestPointerUnlock):
2910         (WebTestRunner::WebTestProxyBase::isPointerLocked):
2911         * DumpRenderTree/chromium/WebViewHost.cpp:
2912         (WebViewHost::reset):
2913         * DumpRenderTree/chromium/WebViewHost.h:
2914         (WebKit):
2915         (WebViewHost):
2916
2917 2013-02-20  Andras Becsi  <andras.becsi@digia.com>
2918
2919         [Qt] Make debug builds possible on 32bit Linux
2920         https://bugs.webkit.org/show_bug.cgi?id=110231
2921
2922         Reviewed by Tor Arne Vestbø.
2923
2924         Use the stabs format for debug builds to make the object files
2925         a bit smaller so that they can be linked on a 32bit system.
2926
2927         * qmake/mkspecs/features/unix/default_post.prf:
2928
2929 2013-02-20  Takashi Toyoshima  <toyoshim@chromium.org>
2930
2931         Unreviewed. Add myself to watch lists.
2932
2933         * Scripts/webkitpy/common/config/committers.py:
2934         * Scripts/webkitpy/common/config/watchlist:
2935
2936 2013-02-19  Joshua Bell  <jsbell@chromium.org>
2937
2938         Remove warning from run-bindings-tests
2939         https://bugs.webkit.org/show_bug.cgi?id=110285
2940
2941         Reviewed by Kentaro Hara.
2942
2943         Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
2944         "Unknown option: idlattributesfile". That option was removed from
2945         bindings/scripts/preprocess-idls.pl but was still being passed by
2946         the test script. Remove it.
2947
2948         * Scripts/webkitpy/bindings/main.py:
2949         (BindingsTests.generate_supplemental_dependency): Remove unused arg.
2950
2951 2013-02-19  Elliott Sprehn  <esprehn@chromium.org>
2952
2953         Unreviewed. Add myself to watch lists.
2954
2955         * Scripts/webkitpy/common/config/committers.py:
2956         * Scripts/webkitpy/common/config/watchlist:
2957
2958 2013-02-19  Hans Muller  <hmuller@adobe.com>
2959
2960         Unreviewed, corrected primary email.
2961
2962         * Scripts/webkitpy/common/config/committers.py:
2963
2964 2013-02-19  Hans Muller  <hmuller@adobe.com>
2965
2966         Unreviewed. Adding myself as a committer.
2967
2968         * Scripts/webkitpy/common/config/committers.py:
2969
2970 2013-02-19  Pravin D  <pravind@webkit.org>
2971
2972         Unreviewed, changing primary email.
2973
2974         * Scripts/webkitpy/common/config/committers.py:
2975
2976 2013-02-19  Alan Cutter  <alancutter@chromium.org>
2977
2978         REGRESSION: Sheriffbot is failing to process rollout requests
2979         https://bugs.webkit.org/show_bug.cgi?id=106945
2980
2981         Reviewed by Adam Barth.
2982
2983         Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
2984         This resolves problems when Sheriffbot attempts to perform a rollout request.
2985
2986         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2987         * EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
2988         * EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.
2989
2990 2013-02-19  Claudio Saavedra  <csaavedra@igalia.com>
2991
2992         Unreviewed build fix.
2993
2994         * efl/jhbuild.modules:
2995         * gtk/jhbuild.modules:
2996
2997         Bump harfbuzz module to 0.9.7. See related bug 110145.
2998
2999 2013-02-19  Simon Hausmann  <simon.hausmann@digia.com>
3000
3001         [Qt] Skip the build with a warning if certain tools cannot be found in the PATH
3002         https://bugs.webkit.org/show_bug.cgi?id=110215
3003
3004         Reviewed by Tor Arne Vestbø.
3005
3006         Check that gperf, python, ruby, perl, bison and flex are in the PATH before
3007         continuing the build. Otherwise skip with an error message explaining which
3008         programs are missing from the build.
3009
3010         * qmake/mkspecs/features/configure.prf:
3011         * qmake/mkspecs/features/functions.prf:
3012
3013 2013-02-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3014
3015         Unreviewed, rolling out r143319.
3016         http://trac.webkit.org/changeset/143319
3017         https://bugs.webkit.org/show_bug.cgi?id=110214
3018
3019         Causes build issues on win32 (Requested by carewolf on
3020         #webkit).
3021
3022         * qmake/mkspecs/features/features.pri:
3023
3024 2013-02-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3025
3026         [Qt] Enable MathML
3027         https://bugs.webkit.org/show_bug.cgi?id=110205
3028
3029         Reviewed by Simon Hausmann.
3030
3031         * qmake/mkspecs/features/features.pri:
3032
3033 2013-02-17  Andrei Bucur  <abucur@adobe.com>
3034
3035         Unreviewed. Adding myself as a committer.
3036
3037         * Scripts/webkitpy/common/config/committers.py:
3038
3039 2013-02-19  Hajime Morrita  <morrita@google.com>
3040
3041         Unreviewed, updated spelling of my name.
3042
3043         * Scripts/webkitpy/common/config/committers.py:
3044
3045 2013-02-18  Ilya Tikhonovsky  <loislo@chromium.org>
3046
3047         Unreviewed. Adjust expectations.
3048
3049         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
3050         (TestWebKitAPI::TEST):
3051
3052 2013-02-18  Zan Dobersek  <zdobersek@igalia.com>
3053
3054         Unreviewed GTK gardening.
3055
3056         * Scripts/run-gtk-tests:
3057         (TestRunner): Skipped the ReloadPageAfterCrash unit test as it is flakily timing out.
3058
3059 2013-02-18  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3060
3061         [Qt][WK2] Remove duped test name and append new test in project file
3062         https://bugs.webkit.org/show_bug.cgi?id=110117
3063
3064         A new WK2 API test has landed recently (ResizeWindowAfterCrash), this patch will
3065         add this test into the runnable test suite and remove a duped test in project file.
3066
3067         Reviewed by Jocelyn Turcotte.
3068
3069         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
3070
3071 2013-02-18  Jochen Eisinger  <jochen@chromium.org>
3072
3073         [chromium] remove log spew from dumpAllBackForwardLists
3074         https://bugs.webkit.org/show_bug.cgi?id=110108
3075
3076         Reviewed by Nico Weber.
3077
3078         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3079
3080 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3081
3082         [EFL][WK2] Disable failing API tests
3083         https://bugs.webkit.org/show_bug.cgi?id=110081
3084
3085         Reviewed by Kenneth Rohde Christiansen.
3086
3087         Disable DOMWindowExtensionBasic WK2 test on EFL port as it times out.
3088
3089         * TestWebKitAPI/PlatformEfl.cmake:
3090
3091 2013-02-18  Simon Hausmann  <simon.hausmann@digia.com>
3092
3093         [Qt] Disable the build if certain configure checks fail
3094         https://bugs.webkit.org/show_bug.cgi?id=110094
3095
3096         Reviewed by Tor Arne Vestbø.
3097
3098         Allow for the build to be skipped (clear out SUBDIRS) if certain
3099         configure conditions aren't met.
3100
3101         * qmake/mkspecs/features/configure.prf:
3102
3103 2013-02-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3104
3105         [Qt][WK2] Support WK2 API tests
3106         https://bugs.webkit.org/show_bug.cgi?id=109843
3107
3108         Reviewed by Jocelyn Turcotte.
3109
3110         * TestWebKitAPI/DerivedSources.pri: Added.
3111         * TestWebKitAPI/InjectedBundle.pri: Added.
3112         * TestWebKitAPI/PlatformWebView.h:
3113         * TestWebKitAPI/TestWebKitAPI.pri:
3114         * TestWebKitAPI/TestWebKitAPI.pro:
3115         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Added.
3116         * TestWebKitAPI/Tests/WTF/WTF.pro:
3117         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Added.
3118         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp:
3119         (TestWebKitAPI::Util::sleep):
3120         (TestWebKitAPI::Util::createInjectedBundlePath):
3121         (TestWebKitAPI::Util::createURLForResource):
3122         (TestWebKitAPI::Util::isKeyDown):
3123         (Util):
3124         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Added.
3125         (TestWebKitAPI):
3126         (WrapperWindow):
3127         (TestWebKitAPI::WrapperWindow::WrapperWindow):
3128         (TestWebKitAPI::WrapperWindow::handleStatusChanged):
3129         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3130         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3131         (TestWebKitAPI::PlatformWebView::resizeTo):
3132         (TestWebKitAPI::PlatformWebView::page):
3133         (TestWebKitAPI::PlatformWebView::focus):
3134         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3135         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
3136         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3137         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3138         * TestWebKitAPI/qt/main.cpp:
3139         (addQtWebProcessToPath):
3140         (main):
3141
3142 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3143
3144         [EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal C++ API
3145         https://bugs.webkit.org/show_bug.cgi?id=108598
3146
3147         Reviewed by Kenneth Rohde Christiansen.
3148
3149         Update EFL's MiniBrowser to make use of new Ewk_Favicon API.
3150
3151         * MiniBrowser/efl/main.c:
3152         (update_view_favicon):
3153         (on_view_favicon_changed):
3154         (window_create):
3155
3156 2013-02-18  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
3157
3158         Unreviewed. Add myself as a committer.
3159
3160         * Scripts/webkitpy/common/config/committers.py:
3161
3162 2013-02-13  Ilya Tikhonovsky  <loislo@chromium.org>
3163
3164         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
3165         https://bugs.webkit.org/show_bug.cgi?id=109554
3166
3167         In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
3168         can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
3169
3170         Drive by fix: I introduced a client interface for the HeapGraphSerializer.
3171         It helps me to do the tests for the serializer.
3172
3173         Reviewed by Yury Semikhatsky.
3174
3175         It is covered by newly added tests in TestWebKitAPI.
3176
3177         * TestWebKitAPI/TestWebKitAPI.gypi:
3178         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
3179         (TestWebKitAPI):
3180         (HeapGraphReceiver):
3181         (TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
3182         (TestWebKitAPI::HeapGraphReceiver::printGraph):
3183         (TestWebKitAPI::HeapGraphReceiver::dumpNodes):
3184         (TestWebKitAPI::HeapGraphReceiver::dumpEdges):
3185         (TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
3186         (TestWebKitAPI::HeapGraphReceiver::dumpStrings):
3187         (TestWebKitAPI::HeapGraphReceiver::serializer):
3188         (TestWebKitAPI::HeapGraphReceiver::chunkPart):
3189         (TestWebKitAPI::HeapGraphReceiver::dumpPart):
3190         (TestWebKitAPI::HeapGraphReceiver::stringValue):
3191         (TestWebKitAPI::HeapGraphReceiver::intValue):
3192         (TestWebKitAPI::HeapGraphReceiver::nodeToString):
3193         (TestWebKitAPI::HeapGraphReceiver::edgeToString):
3194         (TestWebKitAPI::HeapGraphReceiver::printNode):
3195         (Helper):
3196         (TestWebKitAPI::Helper::Helper):
3197         (TestWebKitAPI::Helper::addNode):
3198         (TestWebKitAPI::Helper::addEdge):
3199         (TestWebKitAPI::Helper::done):
3200         (Object):
3201         (TestWebKitAPI::Helper::Object::Object):
3202         (TestWebKitAPI::TEST):
3203         (Owner):
3204         (TestWebKitAPI::Owner::Owner):
3205         (TestWebKitAPI::Owner::reportMemoryUsage):
3206
3207 2013-02-18  Ryosuke Niwa  <rniwa@webkit.org>
3208
3209         WKR build fix. Always use ascii since irclib/ircbot doesn't support unicode.
3210
3211         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3212         (NewCommitBot.next_work_item):
3213
3214 2013-02-17  Kangil Han  <kangil.han@samsung.com>
3215
3216         Unreviewed. Add myself as a committer.
3217
3218         * Scripts/webkitpy/common/config/committers.py:
3219
3220 2013-02-17  Alan Cutter  <alancutter@chromium.org>
3221
3222         GCE EWS bots are all offline
3223         https://bugs.webkit.org/show_bug.cgi?id=110069
3224
3225         Reviewed by Eric Seidel.
3226
3227         Updated GCE EWS build scripts to use the gcel-10-04-v20130104 image instead of the obsoleted ubuntu-10-04-v20120621.
3228         This changed the ephemeral disk path to /dev/sdb and required /etc/hosts to be chmodded to 644.
3229
3230         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3231         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3232         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
3233         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3234         * EWSTools/build-vm.sh:
3235         * EWSTools/start-queue.sh:
3236
3237 2013-02-18  Eugene Klyuchnikov  <eustas@chromium.org>
3238
3239         Unreviewed, add myself to commiters.py.
3240
3241         * Scripts/webkitpy/common/config/committers.py:
3242
3243 2013-02-17  Dongwoo Joshua Im  <dw.im@samsung.com>
3244
3245         Unreviewed. Add myself as a committer.
3246
3247         * Scripts/webkitpy/common/config/committers.py:
3248
3249 2013-02-17  Roger Fong  <roger_fong@apple.com>
3250
3251         Unreviewed. Fix typo in script.
3252
3253         * EWSTools/start-queue-win.sh:
3254
3255 2013-02-15  Roger Fong  <roger_fong@apple.com>
3256
3257         Pass in bot name as parameter to start-queue-win script.
3258         https://bugs.webkit.org/show_bug.cgi?id=109998.
3259
3260         Reviewed by Darin Adler.
3261
3262         * EWSTools/start-queue-win.sh:
3263
3264 2013-02-18  Byungwoo Lee  <bw80.lee@samsung.com>
3265
3266         Unreviewed. Add myself as a committer.
3267
3268         * Scripts/webkitpy/common/config/committers.py:
3269
3270 2013-02-17  Ryosuke Niwa  <rniwa@webkit.org>
3271
3272         Rename new-commit-bot to WKR to disambiguate it from commit-queue.
3273
3274         Rubber-stamped by Andreas Kling.
3275
3276         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3277         (NewCommitBot.begin_work_queue):
3278
3279 2013-02-16  Glenn Adams  <glenn@skynav.com>
3280
3281         Unreviewed. Add myself as a committer.
3282
3283         * Scripts/webkitpy/common/config/committers.py:
3284
3285 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
3286
3287         new-commit-bot should report the full name of committer and reviewer instead of just nicks
3288         https://bugs.webkit.org/show_bug.cgi?id=110040
3289
3290         Reviewed by Darin Adler.
3291
3292         Have it report names like "Ryosuke Niwa (rniwa)" instead of just "rniwa".
3293
3294         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3295         (NewCommitBot):
3296         (NewCommitBot._summarize_commit_log):
3297         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3298
3299 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
3300
3301         We need a CIA replacement
3302         https://bugs.webkit.org/show_bug.cgi?id=110008
3303
3304         Reviewed by Andreas Kling.
3305
3306         Added new-commit-bot.
3307
3308         * Scripts/webkitpy/tool/bot/queueengine.py:
3309         (QueueEngine.__init__):
3310         (QueueEngine): Made the sleep tiem configurable.
3311         (QueueEngine._sleep_message):
3312         (QueueEngine._sleep):
3313         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3314         (QueueEngineTest.test_sleep_message):
3315         * Scripts/webkitpy/tool/commands/__init__.py:
3316         * Scripts/webkitpy/tool/commands/newcommitbot.py: Added.
3317         (PingPong): Added. Implements the ping pong protocol.
3318         (NewCommitBot):
3319         (NewCommitBot.begin_work_queue):
3320         (NewCommitBot.work_item_log_path):
3321         (NewCommitBot.next_work_item): Update SVN revision and report any new commits made since
3322         the last time we checked the head SVN revision.
3323         (NewCommitBot.process_work_item):
3324         (NewCommitBot._update_checkout): svn up.
3325         (NewCommitBot._new_svn_revisions): Returns a range of new revisions.
3326         (NewCommitBot._summarize_commit_log): Summarize a commit log to be posted on IRC.
3327         (NewCommitBot.handle_unexpected_error):
3328         (NewCommitBot.handle_script_error):
3329         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Added.
3330         (NewCommitBotTest.test_summarize_commit_log_basic): Tests for summarizing non-rollout commits.
3331         (NewCommitBotTest.test_summarize_commit_log_rollout): Tests for summarizing rollouts.
3332         * Scripts/webkitpy/tool/commands/queues.py:
3333         (AbstractQueue.execute):
3334         * Scripts/webkitpy/tool/commands/queuestest.py:
3335         (MockQueueEngine.__init__):
3336         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3337         (SheriffBotTest.test_command_aliases):
3338         * Scripts/webkitpy/tool/main.py:
3339         (WebKitPatch):
3340
3341 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
3342
3343         [chromium] initialize all variables of TestRunner classes
3344         https://bugs.webkit.org/show_bug.cgi?id=110013
3345
3346         Reviewed by Adam Barth.
3347
3348         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3349         (WebTestRunner::TestInterfaces::TestInterfaces):
3350         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3351         (WebTestRunner::TestRunner::TestRunner):
3352
3353 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
3354
3355         [chromium] destroy the TestPlugin when the destroy() method is invoked.
3356         https://bugs.webkit.org/show_bug.cgi?id=110012
3357
3358         Reviewed by Adam Barth.
3359
3360         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3361         (WebTestRunner::TestPlugin::destroy):
3362
3363 2013-02-15  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3364
3365         [WK2] Write a test to simulate crashed WebProcess followed by Window resize
3366         https://bugs.webkit.org/show_bug.cgi?id=109842
3367
3368         Reviewed by Benjamin Poulain.
3369
3370         This new test will kill WebProcess, followed by next resizing the Window. It helps to
3371         identify if the port is testing for WebPageProxy data members state (e.g. DrawingArea, Frames)
3372         before making calls into them.
3373
3374         * TestWebKitAPI/GNUmakefile.am:
3375         * TestWebKitAPI/PlatformEfl.cmake:
3376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3377         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Added.
3378         (TestWebKitAPI):
3379         (TestWebKitAPI::didFinishLoad):
3380         (TestWebKitAPI::didCrash):
3381         (TestWebKitAPI::TEST):
3382
3383 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3384
3385         Add CString operators for comparison with const char*
3386         https://bugs.webkit.org/show_bug.cgi?id=109947
3387
3388         Reviewed by Darin Adler.
3389
3390         Add tests for WTF::CString's comparison operators.
3391
3392         * TestWebKitAPI/Tests/WTF/CString.cpp:
3393         (TEST):
3394
3395 2013-02-15  Zan Dobersek  <zdobersek@igalia.com>
3396
3397         webkit-patch suggest-reviewers should limit itself to 5 reviewers
3398         https://bugs.webkit.org/show_bug.cgi?id=107528
3399
3400         Reviewed by Eric Seidel.
3401
3402         * Scripts/webkitpy/common/checkout/checkout.py:
3403         (Checkout.suggested_reviewers): Iterate through the sorted commit info list,
3404         scraping reviewers from the commit information and in the end producing a list
3405         of reviewers that's sorted from the most to least recent activity of any reviewer
3406         that has reviewed or authored patches for the changed files.
3407         * Scripts/webkitpy/tool/commands/queries.py:
3408         (SuggestReviewers): Use the SuggestReviewers step instead of reimplementing much of
3409         the same logic.
3410         (SuggestReviewers._prepare_state): Force the reviewer suggestion because the option
3411         defaults to False.
3412         * Scripts/webkitpy/tool/steps/suggestreviewers.py:
3413         (SuggestReviewers.run): Only list the first five suggested reviewers, now printed out
3414         on a single line.  Only ask for CC-ing the suggested reviewers to the bug if the
3415         bug ID is located in the command's state.
3416
3417 2013-02-15  Pablo Flouret  <pablof@motorola.com>
3418
3419         Unreviewed. Add myself as a committer.
3420
3421         * Scripts/webkitpy/common/config/committers.py:
3422
3423 2013-02-15  Roger Fong  <roger_fong@apple.com>
3424
3425         Get Win EWS startup script checked into tree so we can make changes to all the EWS bots more easily.
3426
3427         * EWSTools/start-queue-win.sh: Added.
3428
3429 2013-02-15  Andreas Kling  <akling@apple.com>
3430
3431         Unbreak webkit-patch -- can't have both Committer and Contributor entry with same e-mail address.
3432
3433         * Scripts/webkitpy/common/config/committers.py:
3434
3435 2013-02-15  Joanmarie Diggs  <jdiggs@igalia.com>
3436
3437         Unreviewed. Add myself as a committer.
3438
3439         * Scripts/webkitpy/common/config/committers.py:
3440
3441 2013-02-15  Ryosuke Niwa  <rniwa@webkit.org>
3442
3443         NRWT: ML Debug Test bot is timing out after cleaning up ports
3444         https://bugs.webkit.org/show_bug.cgi?id=109912
3445
3446         Reviewed by Simon Fraser.
3447
3448         Added more debug messgaes to diagnose the issue.
3449
3450         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3451         (Manager.run):
3452
3453 2013-02-15  Claudio Saavedra  <csaavedra@igalia.com>
3454
3455         Unreviewed. Add myself as a committer.
3456
3457         * Scripts/webkitpy/common/config/committers.py:
3458
3459 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3460
3461         Unreviewed. Update Yi Shen, Antonio Gomes and Laszlo Gombos'
3462         emails on their behalf.
3463
3464         * Scripts/webkitpy/common/config/committers.py:
3465
3466 2013-02-15  Andrey Lushnikov  <lushnikov@chromium.org>
3467
3468         Web Inspector: implement smart braces functionality
3469         https://bugs.webkit.org/show_bug.cgi?id=109200
3470
3471         Reviewed by Pavel Feldman.
3472
3473         Fix eventSender.keyDown implementation to correctly process opening
3474         round brace symbol.
3475
3476         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3477         (WebTestRunner):
3478         (WebTestRunner::EventSender::keyDown):
3479
3480 2013-02-15  Jochen Eisinger  <jochen@chromium.org>
3481
3482         Speculative build fix for chromium-win.
3483
3484         Unreviewed build fix.
3485
3486         Add declarations of the copy constructor and assignment operator to
3487         WebTestProxyBase, so VS doesn't try to generate them.
3488
3489         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3490
3491 2013-02-15  Simon Hausmann  <simon.hausmann@digia.com>
3492
3493         [Qt] Port GCController to JSC C API
3494         https://bugs.webkit.org/show_bug.cgi?id=109690
3495
3496         Reviewed by Benjamin Poulain.
3497
3498         Rename TestRunner to TestRunnerQt to avoid conflict when
3499         including TestRunner.h in the future.
3500
3501         Replaced QObject based GCController implementation with JSC C API
3502         based one.
3503
3504         * DumpRenderTree/qt/DumpRenderTree.pro:
3505         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3506         (WebCore::DumpRenderTree::DumpRenderTree):
3507         (WebCore::DumpRenderTree::open):
3508         (WebCore::DumpRenderTree::initJSObjects):
3509         (WebCore::methodNameStringForFailedTest):
3510         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3511         (WebCore::DumpRenderTree::testRunner):
3512         (DumpRenderTree):
3513         * DumpRenderTree/qt/GCControllerQt.cpp:
3514         (GCController::getJSObjectCount):
3515         * DumpRenderTree/qt/GCControllerQt.h: Removed.
3516         * DumpRenderTree/qt/TestRunnerQt.cpp:
3517         (TestRunnerQt::TestRunnerQt):
3518         (TestRunnerQt::reset):
3519         (TestRunnerQt::dumpNotifications):
3520         (TestRunnerQt::processWork):
3521         (TestRunnerQt::maybeDump):
3522         (TestRunnerQt::dumpAsText):
3523         (TestRunnerQt::waitUntilDone):
3524         (TestRunnerQt::setViewModeMediaFeature):
3525         (TestRunnerQt::webHistoryItemCount):
3526         (TestRunnerQt::keepWebHistory):
3527         (TestRunnerQt::notifyDone):
3528         (TestRunnerQt::windowCount):
3529         (TestRunnerQt::grantWebNotificationPermission):
3530         (TestRunnerQt::ignoreLegacyWebNotificationPermissionRequests):
3531         (TestRunnerQt::denyWebNotificationPermission):
3532         (TestRunnerQt::removeAllWebNotificationPermissions):
3533         (TestRunnerQt::simulateWebNotificationClick):
3534         (TestRunnerQt::simulateLegacyWebNotificationClick):
3535         (TestRunnerQt::display):
3536         (TestRunnerQt::displayInvalidatedRegion):
3537         (TestRunnerQt::clearBackForwardList):
3538         (TestRunnerQt::pathToLocalResource):
3539         (TestRunnerQt::dumpEditingCallbacks):
3540         (TestRunnerQt::dumpFrameLoadCallbacks):
3541         (TestRunnerQt::dumpProgressFinishedCallback):
3542         (TestRunnerQt::dumpUserGestureInFrameLoadCallbacks):
3543         (TestRunnerQt::dumpResourceLoadCallbacks):
3544         (TestRunnerQt::dumpResourceResponseMIMETypes):
3545         (TestRunnerQt::dumpWillCacheResponse):
3546         (TestRunnerQt::dumpHistoryCallbacks):
3547         (TestRunnerQt::setWillSendRequestReturnsNullOnRedirect):
3548         (TestRunnerQt::setWillSendRequestReturnsNull):
3549         (TestRunnerQt::setWillSendRequestClearHeader):
3550         (TestRunnerQt::setDeferMainResourceDataLoad):
3551         (TestRunnerQt::queueBackNavigation):
3552         (TestRunnerQt::queueForwardNavigation):
3553         (TestRunnerQt::queueLoad):
3554         (TestRunnerQt::queueLoadHTMLString):
3555         (TestRunnerQt::queueReload):
3556         (TestRunnerQt::queueLoadingScript):
3557         (TestRunnerQt::queueNonLoadingScript):
3558         (TestRunnerQt::provisionalLoad):
3559         (TestRunnerQt::timerEvent):
3560         (TestRunnerQt::encodeHostName):
3561         (TestRunnerQt::decodeHostName):
3562         (TestRunnerQt::closeWebInspector):
3563         (TestRunnerQt::setDeveloperExtrasEnabled):
3564         (TestRunnerQt::setAsynchronousSpellCheckingEnabled):
3565         (TestRunnerQt::showWebInspector):
3566         (TestRunnerQt::evaluateInWebInspector):
3567         (TestRunnerQt::goBack):
3568         (TestRunnerQt::setDefersLoading):
3569         (TestRunnerQt::setAllowUniversalAccessFromFileURLs):
3570         (TestRunnerQt::setAllowFileAccessFromFileURLs):
3571         (TestRunnerQt::setAppCacheMaximumSize):
3572         (TestRunnerQt::setAutofilled):
3573         (TestRunnerQt::setValueForUser):
3574         (TestRunnerQt::setFixedContentsSize):
3575         (TestRunnerQt::setPrivateBrowsingEnabled):
3576         (TestRunnerQt::setSpatialNavigationEnabled):
3577         (TestRunnerQt::setPopupBlockingEnabled):
3578         (TestRunnerQt::setPluginsEnabled):
3579         (TestRunnerQt::setPOSIXLocale):
3580         (TestRunnerQt::setWindowIsKey):
3581         (TestRunnerQt::setMainFrameIsFirstResponder):
3582         (TestRunnerQt::setJavaScriptCanAccessClipboard):
3583         (TestRunnerQt::setXSSAuditorEnabled):
3584         (TestRunnerQt::dispatchPendingLoadRequests):
3585         (TestRunnerQt::clearAllApplicationCaches):
3586         (TestRunnerQt::clearApplicationCacheForOrigin):
3587         (TestRunnerQt::localStorageDiskUsageForOrigin):
3588         (TestRunnerQt::setApplicationCacheOriginQuota):
3589         (TestRunnerQt::applicationCacheDiskUsageForOrigin):
3590         (TestRunnerQt::originsWithApplicationCache):
3591         (TestRunnerQt::setCacheModel):
3592         (TestRunnerQt::setDatabaseQuota):
3593         (TestRunnerQt::clearAllDatabases):
3594         (TestRunnerQt::addOriginAccessWhitelistEntry):
3595         (TestRunnerQt::removeOriginAccessWhitelistEntry):
3596         (TestRunnerQt::setCustomPolicyDelegate):
3597         (TestRunnerQt::waitForPolicyDelegate):
3598         (TestRunnerQt::overridePreference):
3599         (TestRunnerQt::setUserStyleSheetLocation):
3600         (TestRunnerQt::setCaretBrowsingEnabled):
3601         (TestRunnerQt::setAuthorAndUserStylesEnabled):
3602         (TestRunnerQt::setUserStyleSheetEnabled):
3603         (TestRunnerQt::setDomainRelaxationForbiddenForURLScheme):
3604         (TestRunnerQt::callShouldCloseOnWebView):
3605         (TestRunnerQt::setScrollbarPolicy):
3606         (TestRunnerQt::setSmartInsertDeleteEnabled):
3607         (TestRunnerQt::setSelectTrailingWhitespaceEnabled):
3608         (TestRunnerQt::execCommand):
3609         (TestRunnerQt::isCommandEnabled):
3610         (TestRunnerQt::findString):
3611         (TestRunnerQt::markerTextForListItem):
3612         (TestRunnerQt::computedStyleIncludingVisitedInfo):
3613         (TestRunnerQt::elementDoesAutoCompleteForElementWithId):
3614         (TestRunnerQt::authenticateSession):
3615         (TestRunnerQt::setIconDatabaseEnabled):
3616         (TestRunnerQt::setMockDeviceOrientation):
3617         (TestRunnerQt::setGeolocationPermission):
3618         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3619         (TestRunnerQt::setGeolocationPermissionCommon):
3620         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3621         (TestRunnerQt::setMockGeolocationPosition):
3622         (TestRunnerQt::addMockSpeechInputResult):
3623         (TestRunnerQt::setMockSpeechInputDumpRect):
3624         (TestRunnerQt::startSpeechInput):
3625         (TestRunnerQt::evaluateScriptInIsolatedWorldAndReturnValue):
3626         (TestRunnerQt::evaluateScriptInIsolatedWorld):
3627         (TestRunnerQt::addUserStyleSheet):
3628         (TestRunnerQt::removeAllVisitedLinks):
3629         (TestRunnerQt::addURLToRedirect):
3630         (TestRunnerQt::originsWithLocalStorage):
3631         (TestRunnerQt::deleteAllLocalStorage):
3632         (TestRunnerQt::deleteLocalStorageForOrigin):
3633         (TestRunnerQt::observeStorageTrackerNotifications):
3634         (TestRunnerQt::syncLocalStorage):
3635         (TestRunnerQt::resetPageVisibility):
3636         (TestRunnerQt::setPageVisibility):
3637         (TestRunnerQt::setAutomaticLinkDetectionEnabled):
3638         (TestRunnerQt::setTextDirection):
3639         (TestRunnerQt::setAlwaysAcceptCookies):
3640         (TestRunnerQt::setAlwaysBlockCookies):
3641         (TestRunnerQt::setAudioData):
3642         * DumpRenderTree/qt/TestRunnerQt.h:
3643         (TestRunnerQt):
3644
3645 2013-02-14  Karen Grunberg  <kareng@chromium.org>
3646
3647         adding myself as a committer
3648
3649         * Scripts/webkitpy/common/config/committers.py:
3650
3651 2013-02-14  Glenn Adams  <glenn@skynav.com>
3652
3653         new-run-webkit-tests needs a shared TestExpectations between all WebKit ports
3654         https://bugs.webkit.org/show_bug.cgi?id=37565
3655
3656         Introduce generic TestExpectations file that applies as a fallback for all ports, the location of which
3657         is LayoutTests/TestExpectations.
3658
3659         Reviewed by Dirk Pranke.
3660
3661         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3662         (FakePort.path_to_generic_test_expectations_file):
3663         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3664         (TestExpectations.__init__):
3665         * Scripts/webkitpy/layout_tests/port/base.py:
3666         (Port.path_to_generic_test_expectations_file):
3667         (Port):
3668         (Port._port_specific_expectations_files):
3669         (Port.expectations_files):
3670         * Scripts/webkitpy/layout_tests/port/chromium.py:
3671         (ChromiumPort._port_specific_expectations_files):
3672         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3673         (ChromiumAndroidPort._port_specific_expectations_files):
3674         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
3675         (ChromiumPortTestCase.test_expectations_files):
3676         * Scripts/webkitpy/layout_tests/port/efl.py:
3677         (EflPort._port_specific_expectations_files):
3678         * Scripts/webkitpy/layout_tests/port/gtk.py:
3679         (GtkPort._port_specific_expectations_files):
3680         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3681         (GtkPortTest.test_expectations_files):
3682         * Scripts/webkitpy/layout_tests/port/mac.py:
3683         (MacPort._port_specific_expectations_files):
3684         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3685         (PortTestCase.test_expectations_ordering):
3686         (test_expectations_files):
3687         * Scripts/webkitpy/layout_tests/port/qt.py:
3688         (QtPort._port_specific_expectations_files):
3689         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3690         (QtPortTest.test_expectations_files):
3691         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3692         (WinPortTest.test_expectations_files):
3693         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3694         (PrintExpectationsTest.test_paths):
3695         * Scripts/webkitpy/tool/commands/rebaseline.py:
3696         (RebaselineTest._update_expectations_file):
3697
3698 2013-02-14  Jochen Eisinger  <jochen@chromium.org>
3699
3700         [chromium] move pixel generation logic to TestRunner library
3701         https://bugs.webkit.org/show_bug.cgi?id=109686
3702
3703         Reviewed by Stephen White.
3704
3705         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3706         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3707         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3708         (WebTestRunner):
3709         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3710         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3711         (WebTestRunner):
3712         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3713         (WebTestRunner::TestInterfaces::~TestInterfaces):
3714         (WebTestRunner::TestInterfaces::setWebView):
3715         (WebTestRunner::TestInterfaces::proxy):
3716         (WebTestRunner):
3717         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3718         (WebTestRunner):
3719         (TestInterfaces):
3720         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3721         (WebTestRunner::TestRunner::setWebView):
3722         (WebTestRunner):
3723         (WebTestRunner::TestRunner::setBackingScaleFactor):
3724         (WebTestRunner::TestRunner::display):
3725         (WebTestRunner::TestRunner::displayInvalidatedRegion):
3726         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3727         (WebTestRunner):
3728         (TestRunner):
3729         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3730         (WebTestRunner::WebTestInterfaces::setWebView):
3731         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3732         (WebTestRunner::WebTestProxyBase::reset):
3733         (WebTestRunner::WebTestProxyBase::capturePixels):
3734         (WebTestRunner):
3735         (WebTestRunner::WebTestProxyBase::paintRect):
3736         (WebTestRunner::WebTestProxyBase::paintInvalidatedRegion):
3737         (WebTestRunner::WebTestProxyBase::paintPagesWithBoundaries):
3738         (WebTestRunner::WebTestProxyBase::canvas):
3739         (WebTestRunner::WebTestProxyBase::displayRepaintMask):
3740         (WebTestRunner::WebTestProxyBase::display):
3741         (WebTestRunner::WebTestProxyBase::displayInvalidatedRegion):
3742         (WebTestRunner::WebTestProxyBase::discardBackingStore):
3743         (WebTestRunner::WebTestProxyBase::setWindowRect):
3744         (WebTestRunner::WebTestProxyBase::userMediaClient):
3745         * DumpRenderTree/chromium/TestShell.cpp:
3746         (TestShell::createMainWindow):
3747         (TestShell::~TestShell):
3748         (TestShell::showDevTools):
3749         (TestShell::closeDevTools):
3750         (TestShell::dump):
3751         * DumpRenderTree/chromium/WebViewHost.cpp:
3752         (WebViewHost::setWindowRect):
3753         (WebViewHost::setDeviceScaleFactor):
3754         (WebViewHost::reset):
3755         * DumpRenderTree/chromium/WebViewHost.h:
3756         (WebViewHost):
3757
3758 2013-02-14  Tony Chang  <tony@chromium.org>
3759
3760         Unreviewed, set svn:eol-style native for .sln, .vcproj, and .vsprops files.
3761         https://bugs.webkit.org/show_bug.cgi?id=96934
3762
3763         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3764         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3765         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added property svn:eol-style.
3766         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added property svn:eol-style.
3767         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added property svn:eol-style.
3768         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3769         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added property svn:eol-style.
3770         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added property svn:eol-style.
3771         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3772         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added property svn:eol-style.
3773         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added property svn:eol-style.
3774         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added property svn:eol-style.
3775         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3776         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added property svn:eol-style.
3777         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added property svn:eol-style.
3778         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3779         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added property svn:eol-style.
3780         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3781         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added property svn:eol-style.
3782         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added property svn:eol-style.
3783         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added property svn:eol-style.
3784         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3785         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added property svn:eol-style.
3786         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added property svn:eol-style.
3787         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3788         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added property svn:eol-style.
3789         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added property svn:eol-style.
3790         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added property svn:eol-style.
3791         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added property svn:eol-style.
3792         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added property svn:eol-style.
3793         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added property svn:eol-style.
3794         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3795         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added property svn:eol-style.
3796         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
3797         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added property svn:eol-style.
3798         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added property svn:eol-style.
3799         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added property svn:eol-style.
3800         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3801         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added property svn:eol-style.
3802         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added property svn:eol-style.
3803         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3804         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added property svn:eol-style.
3805         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added property svn:eol-style.
3806         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added property svn:eol-style.
3807         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3808         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added property svn:eol-style.
3809         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added property svn:eol-style.
3810         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3811
3812 2013-02-14  Tony Chang  <tony@chromium.org>
3813
3814         Unreviewed, set svn:eol-style CRLF for .sln files.
3815
3816         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3817         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3818         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3819         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
3820
3821 2013-02-14  Zan Dobersek  <zdobersek@igalia.com>
3822
3823         [GTK] Errors when building WebKit2 with Clang
3824         https://bugs.webkit.org/show_bug.cgi?id=109603
3825
3826         Reviewed by Alexey Proskuryakov.
3827
3828         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3829         (WTR::PlatformWebView::resizeTo): Cast the width and height parameters to the integer
3830         type when constructing the GtkAllocation.
3831
3832         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3833         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3834         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3835         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
3836
3837 2013-02-14  Roger Fong  <roger_fong@apple.com>
3838
3839         Add eol-style=native to solution files. Add a new solution file.
3840
3841         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added property svn:eol-style.
3842         * TestWebKitAPI/TestWebKitAPI.vcxproj: Added property svn:eol-style. Modified property svn:ignore.
3843         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Added.
3844
3845 2013-02-14  Mario Sanchez Prada  <mario.prada@samsung.com>
3846
3847         [GTK] Missing call to g_object_ref while retrieving accessible table cells
3848         https://bugs.webkit.org/show_bug.cgi?id=106903
3849
3850         Reviewed by Martin Robinson.
3851
3852         Both DRT and WKTR need to call g_object_unref() now that an extra
3853         reference is added in the implementation of atk_table_ref_at().
3854
3855         * DumpRenderTree/atk/AccessibilityUIElementGtk.cpp:
3856         (AccessibilityUIElement::cellForColumnAndRow): Call g_object_unref
3857         before returning the new instance of AccessibilityUIElement.
3858         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3859         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
3860
3861 2013-02-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3862
3863         Unreviewed, rolling out r142841.
3864         http://trac.webkit.org/changeset/142841
3865         https://bugs.webkit.org/show_bug.cgi?id=109791
3866
3867         Caused webkit_unit_tests to crash on chromium bots. (Requested
3868         by atwilson_ on #webkit).
3869
3870         * DumpRenderTree/chromium/WebViewHost.cpp:
3871         (WebViewHost::createOutputSurface):
3872         (WebViewHost::initializeLayerTreeView):
3873
3874 2013-02-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3875
3876         [EFL][jhbuild] Silence GSettings-related warning.
3877         https://bugs.webkit.org/show_bug.cgi?id=109749
3878
3879         Reviewed by Martin Robinson.
3880
3881         Apply the same change done to the GTK+ port in r109127; this
3882         silences the warnings printed by glib about the memory GSettings
3883         backend being used.
3884
3885         Not only does this make the bots (as well as manual runs of, say,
3886         WebKitTestRunner) much more silent, but it also removes an stderr
3887         line (which run-perf-tests considers as a failure).
3888
3889         * Scripts/webkitpy/layout_tests/port/efl.py:
3890         (EflPort.setup_environ_for_server): Explicitly set the
3891         GSETTINGS_BACKEND environment variable to "memory".
3892
3893 2013-02-14  Jochen Eisinger  <jochen@chromium.org>
3894
3895         [chromium] move mock notification presenter to TestRunner library
3896         https://bugs.webkit.org/show_bug.cgi?id=109706
3897
3898         Reviewed by Adam Barth.
3899
3900         * DumpRenderTree/DumpRenderTree.gypi:
3901         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3902         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3903         (WebKit):
3904         (WebTestRunner::WebTestProxy::notificationPresenter):
3905         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Renamed from Tools/DumpRenderTree/chromium/NotificationPresenter.cpp.
3906         (WebTestRunner::NotificationPresenter::NotificationPresenter):
3907         (WebTestRunner):
3908         (WebTestRunner::NotificationPresenter::~NotificationPresenter):
3909         (WebTestRunner::NotificationPresenter::grantPermission):
3910         (WebTestRunner::NotificationPresenter::simulateClick):
3911         (WebTestRunner::NotificationPresenter::show):
3912         (WebTestRunner::NotificationPresenter::cancel):
3913         (WebTestRunner::NotificationPresenter::objectDestroyed):
3914         (WebTestRunner::NotificationPresenter::checkPermission):
3915         (WebTestRunner::NotificationPresenter::requestPermission):
3916         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Renamed from Tools/DumpRenderTree/chromium/NotificationPresenter.h.
3917         (WebTestRunner):
3918         (NotificationPresenter):
3919         (WebTestRunner::NotificationPresenter::setDelegate):
3920         (WebTestRunner::NotificationPresenter::reset):
3921         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3922         (WebTestRunner::TestRunner::TestRunner):
3923         (WebTestRunner::TestRunner::setDelegate):
3924         (WebTestRunner::TestRunner::reset):
3925         (WebTestRunner::TestRunner::notificationPresenter):
3926         (WebTestRunner):
3927         (WebTestRunner::TestRunner::grantWebNotificationPermission):
3928         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
3929         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3930         (WebKit):
3931         (WebTestRunner):
3932         (TestRunner):
3933         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3934         (WebTestRunner::WebTestProxyBase::notificationPresenter):
3935         (WebTestRunner):
3936         * DumpRenderTree/chromium/TestShell.cpp:
3937         (TestShell::initialize):
3938         (TestShell::resetTestController):
3939         * DumpRenderTree/chromium/TestShell.h:
3940         (WebKit):
3941         (TestShell):
3942         * DumpRenderTree/chromium/WebViewHost.cpp:
3943         * DumpRenderTree/chromium/WebViewHost.h:
3944
3945 2013-02-13  Roger Fong  <roger_fong@apple.com>
3946
3947         Unreviewed. Add separate DumpRenderTree VS2010 solution file.
3948
3949         * DumpRenderTree/DumpRenderTree.vcxproj: Added property svn:ignore.
3950         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added.
3951
3952 2013-02-12  James Robinson  <jamesr@chromium.org>
3953
3954         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
3955         https://bugs.webkit.org/show_bug.cgi?id=109634
3956
3957         Reviewed by Adrienne Walker.
3958
3959         * DumpRenderTree/chromium/WebViewHost.cpp:
3960         (WebViewHost::createOutputSurface):
3961         (WebViewHost::initializeLayerTreeView):
3962
3963 2013-02-13  David Farler  <dfarler@apple.com>
3964
3965         TestWebKitAPI fails to build for iphonesimulator: 'CFNetwork/CFNetworkDefs.h' file not found
3966         https://bugs.webkit.org/show_bug.cgi?id=109766
3967
3968         Reviewed by David Kilzer.
3969
3970         * TestWebKitAPI/Configurations/Base.xcconfig:
3971         - Don't search Mac OS X header search paths when building on iOS
3972
3973 2013-02-13  Zan Dobersek  <zdobersek@igalia.com>
3974
3975         The 'global isinf/isnan' compiler quirk required when using clang with libstdc++
3976         https://bugs.webkit.org/show_bug.cgi?id=109325
3977
3978         Reviewed by Anders Carlsson.
3979
3980         Prefix calls to the isinf and isnan methods with std::, declaring we want to use the
3981         two methods as they're provided by the C++ standard library being used.
3982
3983         * DumpRenderTree/TestRunner.cpp:
3984         (setAppCacheMaximumSizeCallback):
3985         (setApplicationCacheOriginQuotaCallback):
3986         (setDatabaseQuotaCallback):
3987
3988 2013-02-13  Alan Cutter  <alancutter@chromium.org>
3989
3990         cr-linux debug should use clang and maybe be a components build
3991         https://bugs.webkit.org/show_bug.cgi?id=108512
3992
3993         Reviewed by Adam Barth.
3994
3995         Modified GCE cr-linux-debug-ews bot build scripts to configure clang over gcc for build performance.
3996         Build bots will update clang with each bot cycle.
3997         Updated GCE image paths to suit gcutil 1.6.1.
3998
3999         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
4000         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
4001         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
4002         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
4003         * EWSTools/configure-clang-linux.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
4004         * EWSTools/start-queue.sh:
4005
4006 2013-02-13  Sheriff Bot  <webkit.review.bot@gmail.com>
4007
4008         Unreviewed, rolling out r142747.
4009         http://trac.webkit.org/changeset/142747
4010         https://bugs.webkit.org/show_bug.cgi?id=109746
4011
4012         broke component build (Requested by alecf_gardening on
4013         #webkit).
4014
4015         * TestWebKitAPI/TestWebKitAPI.gypi:
4016         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
4017
4018 2013-02-13  Jochen Eisinger  <jochen@chromium.org>
4019
4020         [chromium] fix TestRunner build with enable_webrtc=0
4021         https://bugs.webkit.org/show_bug.cgi?id=109700
4022
4023         Reviewed by Tony Chang.
4024
4025         We can't use ENABLE() macros in the TestRunner library, however,
4026         ENABLE_WEBRTC is defined by build/common.gypi, so we can use it.
4027
4028         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp:
4029         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
4030         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp:
4031         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp:
4032         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
4033         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
4034         (WebTestRunner):
4035         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4036         (WebTestRunner::WebTestProxyBase::userMediaClient):
4037         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
4038
4039 2013-02-12  Roger Fong  <roger_fong@apple.com>
4040
4041         TestWebKitAPI and record-memory projects and property sheets for VS2010.
4042         https://bugs.webkit.org/show_bug.cgi?id=107034
4043
4044         Reviewed by Brent Fulgham.
4045
4046         * TestWebKitAPI/TestWebKitAPI.vcxproj: Added.
4047         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Added.
4048         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Added.
4049         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd.
4050         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd.
4051         * win/record-memory: Added.
4052         * win/record-memory/main.cpp: Copied from Tools/record-memory-win/main.cpp.
4053         * win/record-memory/record-memory.vcxproj: Added.
4054         * win/record-memory/record-memory.vcxproj.filters: Added.
4055         * win/record-memory/record-memoryCommon.props: Added.
4056         * win/record-memory/record-memoryDebug.props: Added.
4057         * win/record-memory/record-memoryRelease.props: Added.
4058
4059 2013-02-13  Tommy Widenflycht  <tommyw@google.com>
4060
4061         MediaStream API: Use the source id when creating new tracks
4062         https://bugs.webkit.org/show_bug.cgi?id=109688
4063
4064         Reviewed by Adam Barth.
4065
4066         Switching mock to new API.
4067
4068         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
4069         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
4070
4071 2013-02-13  Brent Fulgham  <bfulgham@webkit.org>
4072
4073         [Windows] Unreviewed VS2010 fix to add $(ConfigurationBuildDir)/private
4074         to include paths, to match VS2005 build behavior.
4075
4076         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
4077         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
4078         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
4079         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
4080         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
4081
4082 2013-02-13  Sheriff Bot  <webkit.review.bot@gmail.com>
4083
4084         Unreviewed, rolling out r142736.
4085         http://trac.webkit.org/changeset/142736
4086         https://bugs.webkit.org/show_bug.cgi?id=109716
4087
4088         Broke ABI, nightly builds crash on launch (Requested by ap on
4089         #webkit).
4090
4091         * MiniBrowser/mac/WK2BrowserWindowController.m:
4092         (-[WK2BrowserWindowController awakeFromNib]):
4093         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4094         (WTR::InjectedBundlePage::InjectedBundlePage):
4095         * WebKitTestRunner/TestController.cpp:
4096         (WTR::TestController::createWebViewWithOptions):
4097
4098 2013-02-13  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4099
4100         [WK2][EFL][WTR] Regression(r141836): WTR crashes on exit
4101         https://bugs.webkit.org/show_bug.cgi?id=109456
4102
4103         Reviewed by Anders Carlsson.
4104
4105         WebView instance must not live longer than EwkView, as EwkView owns
4106         objects that page proxy refers to, doing otherwise leads to a crash.
4107
4108         Test controller has own ptr containing WebView. Invoking of ewk_shutdown()
4109         leads to evas objects deletion. So, the problem was that test controller was
4110         deleted after ewk_shutdown() had been called in main() function causing
4111         crashes on WTR exit.
4112
4113         The patch introduces a scope for test controller so that it is deleted first.
4114
4115         * WebKitTestRunner/efl/main.cpp:
4116         (main):
4117
4118 2013-02-13  Ilya Tikhonovsky  <loislo@chromium.org>
4119
4120         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
4121         https://bugs.webkit.org/show_bug.cgi?id=109554
4122
4123         In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
4124         can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
4125
4126         Drive by fix: I introduced a client interface for the HeapGraphSerializer.
4127         It helps me to do the tests for the serializer.
4128
4129         Reviewed by Yury Semikhatsky.
4130
4131         It is covered by newly added tests in TestWebKitAPI.
4132
4133         * TestWebKitAPI/TestWebKitAPI.gypi:
4134         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
4135         (TestWebKitAPI):
4136         (HeapGraphReceiver):
4137         (TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
4138         (TestWebKitAPI::HeapGraphReceiver::printGraph):
4139         (TestWebKitAPI::HeapGraphReceiver::dumpNodes):
4140         (TestWebKitAPI::HeapGraphReceiver::dumpEdges):
4141         (TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
4142         (TestWebKitAPI::HeapGraphReceiver::dumpStrings):
4143         (TestWebKitAPI::HeapGraphReceiver::serializer):
4144         (TestWebKitAPI::HeapGraphReceiver::chunkPart):
4145         (TestWebKitAPI::HeapGraphReceiver::dumpPart):
4146         (TestWebKitAPI::HeapGraphReceiver::stringValue):
4147         (TestWebKitAPI::HeapGraphReceiver::intValue):
4148         (TestWebKitAPI::HeapGraphReceiver::nodeToString):
4149         (TestWebKitAPI::HeapGraphReceiver::edgeToString):
4150         (TestWebKitAPI::HeapGraphReceiver::printNode):
4151         (Helper):
4152         (TestWebKitAPI::Helper::Helper):
4153         (TestWebKitAPI::Helper::addNode):
4154         (TestWebKitAPI::Helper::addEdge):
4155         (TestWebKitAPI::Helper::done):
4156         (Object):
4157         (TestWebKitAPI::Helper::Object::Object):
4158         (TestWebKitAPI::TEST):
4159         (Owner):
4160         (TestWebKitAPI::Owner::Owner):
4161         (TestWebKitAPI::Owner::reportMemoryUsage):
4162
4163 2013-02-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4164
4165         [WK2] Remove web intents callbacks
4166         https://bugs.webkit.org/show_bug.cgi?id=109654
4167
4168         Reviewed by Benjamin Poulain.
4169
4170         Web intents was removed by r142549.
4171
4172         * MiniBrowser/mac/WK2BrowserWindowController.m:
4173         (-[WK2BrowserWindowController awakeFromNib]):
4174         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4175         (WTR::InjectedBundlePage::InjectedBundlePage):
4176         * WebKitTestRunner/TestController.cpp:
4177         (WTR::TestController::createWebViewWithOptions):
4178
4179 2013-02-12  Adenilson Cavalcanti  <cavalcantii@gmail.com>
4180
4181         [WK2] Page reloading will crash UIProcess after WebProcess was killed
4182         https://bugs.webkit.org/show_bug.cgi?id=109305
4183
4184         Reviewed by Benjamin Poulain.
4185
4186         Adding a new test to simulate the case of WebProcess crash followed by a trying
4187         to load a new page.
4188
4189         * TestWebKitAPI/GNUmakefile.am:
4190         * TestWebKitAPI/PlatformEfl.cmake:
4191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4192         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: Added.
4193         (TestWebKitAPI):
4194         (TestWebKitAPI::didFinishLoad):
4195         (TestWebKitAPI::TEST):
4196
4197 2013-02-11  Brent Fulgham  <bfulgham@webkit.org>
4198
4199         Update WebKitDirs.pm for new Windows paths
4200         https://bugs.webkit.org/show_bug.cgi?id=107714
4201
4202         Reviewed by Daniel Bates.
4203
4204         * Scripts/webkitdirs.pm: For each existing Windows environment
4205         variable, also include creation of the 'new' variables. The
4206         'old' variables will be removed in a future update.
4207         (windowsSourceSourceDir): New helper routine to return the
4208         actual 'Source' folder of the WebKit source tree.
4209
4210 2013-02-12  Alec Flett  <alecflett@chromium.org>
4211
4212         Fix signedness in WebTestProxy
4213         https://bugs.webkit.org/show_bug.cgi?id=109623
4214
4215         Reviewed by Adam Barth.
4216
4217         Fix signedness problem, using size_t instead of int.
4218
4219         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4220
4221 2013-02-12  Raymond Toy  <rtoy@google.com>
4222
4223         Add alias
4224         https://bugs.webkit.org/show_bug.cgi?id=109621
4225
4226         No review needed.
4227
4228         * Scripts/webkitpy/common/config/committers.py:
4229
4230 2013-02-12  Jochen Eisinger  <jochen@chromium.org>
4231
4232         [chromium] move text dump generation to TestRunner library
4233         https://bugs.webkit.org/show_bug.cgi?id=109575
4234
4235         Reviewed by Adam Barth.
4236
4237         * DumpRenderTree/DumpRenderTree.gypi:
4238         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
4239         (WebKit):
4240         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
4241         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4242         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
4243         (WebTestRunner):
4244         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestCommon.h.
4245         (WebTestRunner::normalizeLayoutTestURL):
4246         (WebTestRunner):
4247         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h:
4248         (WebTestRunner):
4249         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4250         (WebTestRunner::TestRunner::checkResponseMimeType):
4251         (WebTestRunner):
4252         (WebTestRunner::TestRunner::shouldDumpAsText):
4253         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
4254         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4255         (TestRunner):
4256         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
4257         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4258         (WebTestRunner::WebTestProxyBase::captureTree):
4259         (WebTestRunner):
4260         * DumpRenderTree/chromium/TestShell.cpp:
4261         (TestShell::dump):
4262         (TestShell::captureHistoryForWindow):
4263         * DumpRenderTree/chromium/TestShell.h:
4264         (TestShell):
4265         * DumpRenderTree/chromium/WebViewHost.cpp:
4266         (WebViewHost::captureHistoryForWindow):
4267         * DumpRenderTree/chromium/WebViewHost.h:
4268
4269 2013-02-12  Jessie Berlin  <jberlin@apple.com>
4270
4271         Rollout r142618, it broke all the Mac builds.
4272
4273         * TestWebKitAPI/TestWebKitAPI.gypi:
4274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4275         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
4276         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4277
4278 2013-02-12  Yury Semikhatsky  <yurys@chromium.org>
4279
4280         Unreviewed. Fix Chromium compilation after r142618.
4281
4282         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
4283         (TestWebKitAPI::HeapGraphReceiver::printNode):