Link clicks in PDFs shouldn't send referrer headers.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-17  Brady Eidson  <beidson@apple.com>
2
3         Link clicks in PDFs shouldn't send referrer headers.
4         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
5
6         Reviewed by Tim Horton.
7
8         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
10         (putPDFBytesCallback):
11         (emptyReleaseInfoCallback):
12         (createPDFWithLinkToURL):
13         (TEST):
14
15 2019-04-17  Tim Horton  <timothy_horton@apple.com>
16
17         UI↔Web deadlock when printing with a JavaScript alert visible
18         https://bugs.webkit.org/show_bug.cgi?id=196839
19         <rdar://problem/49157642>
20
21         Reviewed by Andy Estes.
22
23         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
25         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
26         (TEST):
27
28 2019-04-17  Alex Christensen  <achristensen@webkit.org>
29
30         WKRetainPtr's adoption constructor should be private
31         https://bugs.webkit.org/show_bug.cgi?id=197019
32
33         Reviewed by Tim Horton.
34
35         * DumpRenderTree/mac/DumpRenderTree.mm:
36         (dumpFramesAsText):
37         * TestWebKitAPI/InjectedBundleController.cpp:
38         (TestWebKitAPI::InjectedBundleController::initialize):
39         * TestWebKitAPI/PlatformUtilities.cpp:
40         (TestWebKitAPI::Util::createContextWithInjectedBundle):
41         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
42         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
43         (TestWebKitAPI::Util::toWK):
44         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
45         (TestWebKitAPI::TEST):
46         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
47         (TestWebKitAPI::TEST):
48         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
49         (TestWebKitAPI::TEST):
50         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
51         (TestWebKitAPI::TEST):
52         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
53         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
54         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
55         (TestWebKitAPI::TEST):
56         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
57         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
58         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
59         (TestWebKitAPI::TEST):
60         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
61         (TestWebKitAPI::TEST):
62         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
63         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
64         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
65         (TestWebKitAPI::TEST):
66         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
67         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
68         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
69         (TestWebKitAPI::TEST):
70         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
71         (TestWebKitAPI::TEST):
72         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
73         (TestWebKitAPI::TEST):
74         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
75         (TestWebKitAPI::TEST):
76         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
77         (TestWebKitAPI::TEST):
78         * TestWebKitAPI/Tests/WebKit/Find.cpp:
79         (TestWebKitAPI::TEST):
80         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
81         (TestWebKitAPI::TEST):
82         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
83         (TestWebKitAPI::TEST):
84         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
85         (TestWebKitAPI::TEST):
86         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
87         (TestWebKitAPI::TEST):
88         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
89         (TestWebKitAPI::TEST):
90         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
91         (TestWebKitAPI::TEST):
92         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
93         (TestWebKitAPI::TEST):
94         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
95         (TestWebKitAPI::TEST):
96         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
97         (TestWebKitAPI::TEST):
98         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
99         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
100         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
101         (TestWebKitAPI::TEST):
102         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
103         (TestWebKitAPI::TEST):
104         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
105         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
106         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
107         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
108         (TestWebKitAPI::TEST):
109         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
110         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
111         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
112         (TestWebKitAPI::TEST):
113         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
114         (TestWebKitAPI::TEST):
115         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
116         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
117         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
118         (TestWebKitAPI::TEST):
119         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
120         (TestWebKitAPI::loadAlternateHTMLString):
121         (TestWebKitAPI::TEST):
122         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
123         (TestWebKitAPI::TEST):
124         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
125         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
126         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
127         (TestWebKitAPI::buildAndPerformTest):
128         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
129         (TestWebKitAPI::TEST):
130         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
131         (TestWebKitAPI::TEST):
132         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
133         (TestWebKitAPI::TEST):
134         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
135         (TestWebKitAPI::TEST):
136         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
137         (TestWebKitAPI::TEST):
138         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
139         (TestWebKitAPI::TEST):
140         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
141         (TestWebKitAPI::TEST):
142         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
143         (TestWebKitAPI::TEST):
144         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
145         (TestWebKitAPI::TEST):
146         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
147         (TestWebKitAPI::TEST):
148         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
149         (TestWebKitAPI::TEST):
150         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
151         (TestWebKitAPI::TEST):
152         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
153         (TestWebKitAPI::TEST):
154         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
155         (TestWebKitAPI::TEST):
156         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
157         (TestWebKitAPI::TEST):
158         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
159         (TestWebKitAPI::TEST):
160         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
161         (TestWebKitAPI::TEST):
162         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
163         (TestWebKitAPI::TEST):
164         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
165         (TestWebKitAPI::TEST):
166         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
167         (TestWebKitAPI::TEST):
168         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
169         (TestWebKitAPI::TEST):
170         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
171         (TestWebKitAPI::TEST):
172         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
173         (TestWebKitAPI::TEST):
174         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
175         (TestWebKitAPI::TEST):
176         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
177         (TestWebKitAPI::TEST):
178         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
179         (TestWebKitAPI::TEST):
180         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
181         (TestWebKitAPI::TEST):
182         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
183         (TestWebKitAPI::TEST):
184         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
185         (TestWebKitAPI::TEST):
186         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
187         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
188         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
189         (TestWebKitAPI::TEST):
190         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
191         (TestWebKitAPI::TEST):
192         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
193         (TestWebKitAPI::TEST):
194         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
195         (TestWebKitAPI::TEST):
196         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
197         (TestWebKitAPI::TEST):
198         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
199         (TestWebKitAPI::TEST):
200         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
201         (TestWebKitAPI::TEST):
202         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
203         (TestWebKitAPI::TEST):
204         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
205         (TestWebKitAPI::TEST):
206         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
207         (TestWebKitAPI::TEST):
208         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
209         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
210         (TEST):
211         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
212         (TEST):
213         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
214         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
215         (TEST):
216         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
217         (TestWebKitAPI::TEST):
218         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
219         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
220         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
221         (WTR::getMenuItemTitleCallback):
222         (WTR::createMouseMessageBody):
223         (WTR::EventSendingController::mouseDown):
224         (WTR::EventSendingController::mouseUp):
225         (WTR::EventSendingController::mouseMoveTo):
226         (WTR::EventSendingController::mouseForceClick):
227         (WTR::EventSendingController::startAndCancelMouseForceClick):
228         (WTR::EventSendingController::mouseForceDown):
229         (WTR::EventSendingController::mouseForceUp):
230         (WTR::EventSendingController::mouseForceChanged):
231         (WTR::EventSendingController::leapForward):
232         (WTR::EventSendingController::scheduleAsynchronousClick):
233         (WTR::createKeyDownMessageBody):
234         (WTR::EventSendingController::keyDown):
235         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
236         (WTR::EventSendingController::mouseScrollBy):
237         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
238         (WTR::EventSendingController::continuousMouseScrollBy):
239         (WTR::EventSendingController::addTouchPoint):
240         (WTR::EventSendingController::updateTouchPoint):
241         (WTR::EventSendingController::setTouchModifier):
242         (WTR::EventSendingController::setTouchPointRadius):
243         (WTR::EventSendingController::touchStart):
244         (WTR::EventSendingController::touchMove):
245         (WTR::EventSendingController::touchEnd):
246         (WTR::EventSendingController::touchCancel):
247         (WTR::EventSendingController::clearTouchPoints):
248         (WTR::EventSendingController::releaseTouchPoint):
249         (WTR::EventSendingController::cancelTouchPoint):
250         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
251         (WTR::InjectedBundle::didCreatePage):
252         (WTR::InjectedBundle::didReceiveMessage):
253         (WTR::InjectedBundle::didReceiveMessageToPage):
254         (WTR::InjectedBundle::booleanForKey):
255         (WTR::InjectedBundle::done):
256         (WTR::InjectedBundle::dumpToStdErr):
257         (WTR::InjectedBundle::outputText):
258         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
259         (WTR::InjectedBundle::postAddChromeInputField):
260         (WTR::InjectedBundle::postRemoveChromeInputField):
261         (WTR::InjectedBundle::postFocusWebView):
262         (WTR::InjectedBundle::postSetBackingScaleFactor):
263         (WTR::InjectedBundle::postSetWindowIsKey):
264         (WTR::InjectedBundle::postSetViewSize):
265         (WTR::InjectedBundle::postSimulateWebNotificationClick):
266         (WTR::InjectedBundle::postSetAddsVisitedLinks):
267         (WTR::InjectedBundle::setGeolocationPermission):
268         (WTR::InjectedBundle::setMockGeolocationPosition):
269         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
270         (WTR::InjectedBundle::isGeolocationProviderActive const):
271         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
272         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
273         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
274         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
275         (WTR::InjectedBundle::setCustomPolicyDelegate):
276         (WTR::InjectedBundle::setHidden):
277         (WTR::InjectedBundle::setCacheModel):
278         (WTR::InjectedBundle::shouldProcessWorkQueue const):
279         (WTR::InjectedBundle::processWorkQueue):
280         (WTR::InjectedBundle::queueBackNavigation):
281         (WTR::InjectedBundle::queueForwardNavigation):
282         (WTR::InjectedBundle::queueLoad):
283         (WTR::InjectedBundle::queueLoadHTMLString):
284         (WTR::InjectedBundle::queueReload):
285         (WTR::InjectedBundle::queueLoadingScript):
286         (WTR::InjectedBundle::queueNonLoadingScript):
287         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
288         (WTR::frameToStr):
289         (WTR::InjectedBundlePage::InjectedBundlePage):
290         (WTR::dumpFrameDescriptionSuitableForTestResult):
291         (WTR::dumpFrameScrollPosition):
292         (WTR::dumpDescendantFrameScrollPositions):
293         (WTR::dumpFrameText):
294         (WTR::dumpDescendantFramesText):
295         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
296         (WTR::TestRunner::shouldDumpPixels const):
297         (WTR::TestRunner::setDumpPixels):
298         (WTR::TestRunner::whatToDump const):
299         (WTR::TestRunner::setWhatToDump):
300         (WTR::TestRunner::setWaitUntilDone):
301         (WTR::TestRunner::shouldWaitUntilDone const):
302         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
303         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
304         (WTR::TestRunner::clearAllDatabases):
305         (WTR::TestRunner::setIDBPerOriginQuota):
306         (WTR::TestRunner::originsWithApplicationCache):
307         (WTR::TestRunner::setCanOpenWindows):
308         (WTR::TestRunner::setXSSAuditorEnabled):
309         (WTR::TestRunner::setMediaDevicesEnabled):
310         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
311         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
312         (WTR::TestRunner::setCustomUserAgent):
313         (WTR::TestRunner::setWebAPIStatisticsEnabled):
314         (WTR::TestRunner::setModernMediaControlsEnabled):
315         (WTR::TestRunner::setWebGL2Enabled):
316         (WTR::TestRunner::setWritableStreamAPIEnabled):
317         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
318         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
319         (WTR::TestRunner::setAllowsAnySSLCertificate):
320         (WTR::TestRunner::setPluginsEnabled):
321         (WTR::TestRunner::setValueForUser):
322         (WTR::TestRunner::setAudioResult):
323         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
324         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
325         (WTR::TestRunner::setAlwaysAcceptCookies):
326         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
327         (WTR::TestRunner::isDoingMediaCapture const):
328         (WTR::TestRunner::queueLoad):
329         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
330         (WTR::TestRunner::setHandlesAuthenticationChallenges):
331         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
332         (WTR::TestRunner::setShouldLogDownloadCallbacks):
333         (WTR::TestRunner::setAuthenticationUsername):
334         (WTR::TestRunner::setAuthenticationPassword):
335         (WTR::TestRunner::secureEventInputIsEnabled const):
336         (WTR::TestRunner::setBlockAllPlugins):
337         (WTR::TestRunner::setPluginSupportedMode):
338         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
339         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
340         (WTR::TestRunner::setNavigationGesturesEnabled):
341         (WTR::TestRunner::setIgnoresViewportScaleLimits):
342         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
343         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
344         (WTR::TestRunner::terminateNetworkProcess):
345         (WTR::TestRunner::terminateServiceWorkerProcess):
346         (WTR::TestRunner::runUIScript):
347         (WTR::TestRunner::setStatisticsDebugMode):
348         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
349         (WTR::TestRunner::setStatisticsLastSeen):
350         (WTR::TestRunner::setStatisticsPrevalentResource):
351         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
352         (WTR::TestRunner::dumpResourceLoadStatistics):
353         (WTR::TestRunner::isStatisticsPrevalentResource):
354         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
355         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
356         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
357         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
358         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
359         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
360         (WTR::TestRunner::setStatisticsGrandfathered):
361         (WTR::TestRunner::isStatisticsGrandfathered):
362         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
363         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
364         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
365         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
366         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
367         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
368         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
369         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
370         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
371         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
372         (WTR::TestRunner::statisticsUpdateCookieBlocking):
373         (WTR::TestRunner::statisticsSubmitTelemetry):
374         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
375         (WTR::TestRunner::setStatisticsIsRunningTest):
376         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
377         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
378         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
379         (WTR::TestRunner::setStatisticsGrandfatheringTime):
380         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
381         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
382         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
383         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
384         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
385         (WTR::TestRunner::statisticsDeleteCookiesForHost):
386         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
387         (WTR::TestRunner::statisticsResetToConsistentState):
388         (WTR::TestRunner::setStorageAccessAPIEnabled):
389         (WTR::TestRunner::getAllStorageAccessEntries):
390         (WTR::TestRunner::addMockMediaDevice):
391         (WTR::TestRunner::clearMockMediaDevices):
392         (WTR::TestRunner::removeMockMediaDevice):
393         (WTR::TestRunner::resetMockMediaDevices):
394         (WTR::TestRunner::connectMockGamepad):
395         (WTR::TestRunner::disconnectMockGamepad):
396         (WTR::TestRunner::setMockGamepadDetails):
397         (WTR::TestRunner::setMockGamepadAxisValue):
398         (WTR::TestRunner::setMockGamepadButtonValue):
399         (WTR::TestRunner::removeAllSessionCredentials):
400         (WTR::TestRunner::clearDOMCache):
401         (WTR::TestRunner::clearDOMCaches):
402         (WTR::TestRunner::hasDOMCache):
403         (WTR::TestRunner::domCacheSize):
404         (WTR::TestRunner::setAllowStorageQuotaIncrease):
405         (WTR::TestRunner::getApplicationManifestThen):
406         (WTR::TestRunner::injectUserScript):
407         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
408         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
409         (WTR::TestRunner::addTestKeyToKeychain):
410         (WTR::TestRunner::cleanUpKeychain):
411         (WTR::TestRunner::keyExistsInKeychain):
412         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
413         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
414         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
415         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
416         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
417         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
418         * WebKitTestRunner/TestController.cpp:
419         (WTR::TestController::initialize):
420         (WTR::parseStringTestHeaderValueAsRelativePath):
421         (WTR::updateTestOptionsFromTestHeader):
422         (WTR::TestController::runTest):
423         (WTR::TestController::didReceiveLiveDocumentsList):
424         (WTR::TestController::didReceiveMessageFromInjectedBundle):
425         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
426         (WTR::TestController::didFinishNavigation):
427         (WTR::TestController::didReceiveAuthenticationChallenge):
428         * WebKitTestRunner/TestInvocation.cpp:
429         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
430         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
431         (WTR::TestInvocation::uiScriptDidComplete):
432         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
433         * WebKitTestRunner/WebNotificationProvider.cpp:
434         (WTR::WebNotificationProvider::closeWebNotification):
435         * WebKitTestRunner/WorkQueueManager.cpp:
436         (WTR::ScriptItem::ScriptItem):
437         (WTR::WorkQueueManager::queueLoad):
438         (WTR::WorkQueueManager::queueLoadHTMLString):
439
440 2019-04-17  Alex Christensen  <achristensen@webkit.org>
441
442         Add a comment to make my test from r244139 less mysterious.
443         https://bugs.webkit.org/show_bug.cgi?id=196744
444
445         As suggested by Darin Adler.
446
447         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
448         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
449
450 2019-04-17  Chris Dumez  <cdumez@apple.com>
451
452         Remember device orientation permission for the duration of the browsing session
453         https://bugs.webkit.org/show_bug.cgi?id=196992
454         <rdar://problem/49946067>
455
456         Reviewed by Alex Christensen.
457
458         Add API test coverage.
459
460         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
461         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
462         (TEST):
463
464 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
465
466         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
467         https://bugs.webkit.org/show_bug.cgi?id=196675
468
469         Reviewed by Lucas Forschler.
470
471         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
472         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
473
474 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
475
476         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
477         https://bugs.webkit.org/show_bug.cgi?id=196919
478         <rdar://problem/41630459>
479
480         Reviewed by Tim Horton.
481
482         Add iOS support for several new testing hooks. See below for more detail.
483
484         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
485         (WTR::UIScriptController::isDismissingMenu const):
486
487         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
488         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
489         by UIKit when dismissing the callout bar (i.e. UIMenuController).
490
491         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
492         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
493         (WTR::UIScriptController::isDismissingMenu const):
494         * TestRunnerShared/UIScriptContext/UIScriptController.h:
495         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
496         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
497         (WTR::InjectedBundle::didReceiveMessageToPage):
498         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
499         (WTR::TestRunner::setAllowedMenuActions):
500
501         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
502         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
503         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
504         against the name of the custom action.
505
506         (WTR::TestRunner::installCustomMenuAction):
507
508         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
509         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
510         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
511         triggered.
512
513         (WTR::TestRunner::performCustomMenuAction):
514
515         Invoked when the custom menu action is triggered.
516
517         * WebKitTestRunner/InjectedBundle/TestRunner.h:
518         * WebKitTestRunner/TestController.cpp:
519         (WTR::TestController::installCustomMenuAction):
520         (WTR::TestController::setAllowedMenuActions):
521         * WebKitTestRunner/TestController.h:
522         * WebKitTestRunner/TestInvocation.cpp:
523         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
524         (WTR::TestInvocation::performCustomMenuAction):
525
526         Add plumbing to call back into the injected bundle when performing the custom action.
527
528         * WebKitTestRunner/TestInvocation.h:
529         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
530         (WTR::TestController::installCustomMenuAction):
531         (WTR::TestController::setAllowedMenuActions):
532         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
533         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
534         (-[TestRunnerWKWebView initWithFrame:configuration:]):
535         (-[TestRunnerWKWebView becomeFirstResponder]):
536         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
537
538         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
539         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
540         in the Mail app on iOS.
541
542         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
543         (-[TestRunnerWKWebView setAllowedMenuActions:]):
544         (-[TestRunnerWKWebView resetCustomMenuAction]):
545         (-[TestRunnerWKWebView performCustomAction:]):
546         (-[TestRunnerWKWebView canPerformAction:withSender:]):
547         (-[TestRunnerWKWebView _willHideMenu]):
548         (-[TestRunnerWKWebView _didHideMenu]):
549         * WebKitTestRunner/ios/TestControllerIOS.mm:
550         (WTR::TestController::platformResetStateToConsistentValues):
551
552         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
553         if specified.
554
555         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
556         (WTR::UIScriptController::isDismissingMenu const):
557
558 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
559
560         Allow sharing from imageSheet on an image document
561         https://bugs.webkit.org/show_bug.cgi?id=196891
562         <rdar://problem/25377386>
563
564         Reviewed by Tim Horton.
565
566         Test to make sure that the correct imageURL is extracted from an image element.
567
568         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
569         (TestWebKitAPI::TEST):
570
571 2019-04-16  Alex Christensen  <achristensen@webkit.org>
572
573         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
574         https://bugs.webkit.org/show_bug.cgi?id=196995
575
576         Reviewed by Brady Eidson.
577
578         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
579         (TEST):
580
581 2019-04-16  Chris Dumez  <cdumez@apple.com>
582
583         URL set by document.open() is not communicated to the UIProcess
584         https://bugs.webkit.org/show_bug.cgi?id=196941
585         <rdar://problem/49237544>
586
587         Reviewed by Geoff Garen.
588
589         Add API test coverage.
590
591         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
592         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
593         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
594         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
595         (TEST):
596
597 2019-04-16  Commit Queue  <commit-queue@webkit.org>
598
599         Unreviewed, rolling out r244321.
600         https://bugs.webkit.org/show_bug.cgi?id=196968
601
602         Causing all WK2 Debug builds to exit early after Assertion
603         failures. (Requested by ShawnRoberts on #webkit).
604
605         Reverted changeset:
606
607         "URL set by document.open() is not communicated to the
608         UIProcess"
609         https://bugs.webkit.org/show_bug.cgi?id=196941
610         https://trac.webkit.org/changeset/244321
611
612 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
613
614         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
615         https://bugs.webkit.org/show_bug.cgi?id=196948
616
617         Reviewed by Zalan Bujtas.
618
619         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
620         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
621
622 2019-04-15  Chris Dumez  <cdumez@apple.com>
623
624         URL set by document.open() is not communicated to the UIProcess
625         https://bugs.webkit.org/show_bug.cgi?id=196941
626         <rdar://problem/49237544>
627
628         Reviewed by Geoffrey Garen.
629
630         Add API test coverage.
631
632         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
633         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
634         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
635         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
636         (TEST):
637
638 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
639
640         Using Tools/Scripts/clean-webkit should not install requests
641         https://bugs.webkit.org/show_bug.cgi?id=196940
642
643         Reviewed by Lucas Forschler.
644
645         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
646         existing, depending on the path autoinstalled is run through.
647         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
648         needed.
649         (Port.configuration_for_upload):
650         (Port.commits_for_upload):
651
652 2019-04-15  Alex Christensen  <achristensen@webkit.org>
653
654         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
655         https://bugs.webkit.org/show_bug.cgi?id=196773
656
657         Reviewed by Jer Noble.
658
659         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
660         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
661         (TEST):
662
663 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
664
665         ews-build should clearly indicate flaky test failures
666         https://bugs.webkit.org/show_bug.cgi?id=196947
667
668         Reviewed by Lucas Forschler.
669
670         * BuildSlaveSupport/ews-build/steps.py:
671         (AnalyzeAPITestsResults.analyzeResults):
672
673 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
674
675         InjectedBundle parameters often need initialization function called before unarchiving
676         https://bugs.webkit.org/show_bug.cgi?id=189709
677         <rdar://problem/44573653>
678
679         Reviewed by Ryosuke Niwa.
680
681         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
682         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
683
684 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
685
686         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
687         https://bugs.webkit.org/show_bug.cgi?id=196681
688
689         Reviewed by Darin Adler.
690
691         Added tests.
692
693         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
694         (WTF_HashSet.RemoveIf):
695         (WTF_HashSet.RemoveIfShrinkToBestSize):
696
697 2019-04-15  John Wilander  <wilander@apple.com>
698
699         Send delayed Ad Click Attribution conversion requests to the click source
700         https://bugs.webkit.org/show_bug.cgi?id=196838
701         <rdar://problem/47650157>
702
703         Reviewed by Chris Dumez and Youenn Fablet.
704
705         This patch adds test infrastructure to override the default behavior in
706         WebKit::NetworkAdClickAttribution.
707
708         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
709         (TestWebKitAPI::TEST):
710         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
711         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
712         (WTR::TestRunner::dumpAdClickAttribution):
713         (WTR::TestRunner::clearAdClickAttribution):
714         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
715         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
716         * WebKitTestRunner/InjectedBundle/TestRunner.h:
717         * WebKitTestRunner/TestController.cpp:
718         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
719         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
720         * WebKitTestRunner/TestController.h:
721         * WebKitTestRunner/TestInvocation.cpp:
722         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
723
724 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
725
726         [ews-app] status-bubble should display position in queue
727         https://bugs.webkit.org/show_bug.cgi?id=196607
728
729         Reviewed by Lucas Forschler.
730
731         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
732         (StatusBubble._build_bubble):
733         (StatusBubble._queue_position): Method to calculate patch's position in queue.
734
735 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
736
737         [ews-build] Do not run clean build by default on EWS builders
738         https://bugs.webkit.org/show_bug.cgi?id=196897
739
740         Reviewed by Lucas Forschler.
741
742         * BuildSlaveSupport/ews-build/steps.py:
743         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
744         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
745         untracked directories like WebKitBuild).
746         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
747         untracked files/directories (like WebKitBuild).
748
749 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
750
751         TestRunner::notifyDone() should be safely reentrant
752         https://bugs.webkit.org/show_bug.cgi?id=196898
753
754         Reviewed by Darin Adler.
755
756         It is currently possible that TestRunner::notifyDone() will call itself, since
757         notifyDone() will force a repaint, which can start executing JavaScript, which
758         may call notifyDone() again. This can lead to test failures and flakiness.
759         Fix this by setting the m_waitToDump flag before calling the dump() method.
760
761         * DumpRenderTree/mac/TestRunnerMac.mm:
762         (TestRunner::notifyDone):
763         (TestRunner::forceImmediateCompletion):
764         * DumpRenderTree/win/TestRunnerWin.cpp:
765         (TestRunner::notifyDone):
766         (TestRunner::forceImmediateCompletion):
767
768 2019-04-15  Philippe Normand  <pnormand@igalia.com>
769
770         [GTK][WPE] Add enable-media websetting
771         https://bugs.webkit.org/show_bug.cgi?id=196863
772
773         Reviewed by Michael Catanzaro.
774
775         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
776         (testWebKitSettings): Add test for the enable-media web-setting.
777
778 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
779
780         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
781         https://bugs.webkit.org/show_bug.cgi?id=196905
782         <rdar://problem/49886096>
783
784         Reviewed by Tim Horton.
785
786         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
787         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
788         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
789         delay timer, we end up with this sequence of events in the problematic (failure) case:
790
791         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
792             ...IPC from UI to web process...
793         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
794             ...IPC from web to UI process...
795         (c) [UI]    Invoke completion handler for script #1
796         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
797             ...IPC from UI to web process...
798         (e) [Web]   Evaluate script #2 in the web process
799         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
800
801         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
802         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
803         #2 is run in step (e).
804
805         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
806         the UI process by waiting on a script message posted by the web process, after attachment updates are
807         dispatched.
808
809         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
810         (TestWebKitAPI::TEST):
811
812 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
813
814         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
815         https://bugs.webkit.org/show_bug.cgi?id=196909
816
817         Reviewed by Wenson Hsieh.
818
819         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
820         (TestWebKitAPI::TEST):
821
822 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
823
824         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
825         https://bugs.webkit.org/show_bug.cgi?id=196880
826
827         Reviewed by Yusuke Suzuki.
828
829         Add a new function for bytecode cache tests that does not forceDiskCache
830         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
831         test added in this patch, since the code is invalid and therefore won't be
832         cached. It should also be useful for tests that evaluate dynamically
833         generated code.
834
835         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
836         * Scripts/run-jsc-stress-tests:
837
838 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
839
840         Update AudioSession route sharing policy
841         https://bugs.webkit.org/show_bug.cgi?id=196776
842         <rdar://problem/46501611>
843
844         Reviewed by Jer Noble.
845
846         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
847         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
848         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
849         (TestWebKitAPI::TEST):
850
851 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
852
853         [iOS] Software keyboard is shown too frequently on some websites
854         https://bugs.webkit.org/show_bug.cgi?id=195856
855         <rdar://problem/49191395>
856
857         Reviewed by Darin Adler.
858
859         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
860
861         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
862         (WTR::UIScriptController::setHardwareKeyboardAttached):
863         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
864         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
865         (WTR::UIScriptController::setHardwareKeyboardAttached):
866         * TestRunnerShared/UIScriptContext/UIScriptController.h:
867         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
868
869         Additionally link against GraphicsServices in WebKitTestRunner.
870
871         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
872         (WTR::TestController::platformResetStateToConsistentValues):
873         (WTR::UIScriptController::setHardwareKeyboardAttached):
874
875 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
876
877         [GTK][WPE] Fix pacman install-dependencies packages
878         https://bugs.webkit.org/show_bug.cgi?id=196817
879
880         Reviewed by Žan Doberšek.
881         
882         python3-setuptools is called python-setuptools
883         ruby-highline is only available on AUR
884         libv4l-devel is incorporated in v4l-utils
885
886         * gtk/install-dependencies:
887         * wpe/install-dependencies:
888
889 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
890
891         [GTK] REGRESSION(r243860): Many tests failing
892         https://bugs.webkit.org/show_bug.cgi?id=196791
893
894         Reviewed by Joanmarie Diggs.
895
896         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
897         multiple documents and check that accessibility hierarchy is updated after a navigation.
898
899         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
900         (loadChangedCallback):
901         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
902         (AccessibilityTest::AccessibilityTest):
903         (AccessibilityTest::~AccessibilityTest):
904         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
905         (AccessibilityTest::findTestServerApplication):
906         (AccessibilityTest::findDocumentWeb):
907         (AccessibilityTest::findRootObject):
908         (AccessibilityTest::waitUntilChildrenRemoved):
909         (AccessibilityTest::ensureProxy):
910         (testAtspiBasicHierarchy):
911         (beforeAll):
912         (afterAll):
913
914 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
915
916         [ews-build] Handle bug titles with unicode characters
917         https://bugs.webkit.org/show_bug.cgi?id=196802
918
919         Reviewed by Dewei Zhu.
920
921         * BuildSlaveSupport/ews-build/steps.py:
922         (ValidatePatch._is_bug_closed):
923
924 2019-04-11  Michael Saboff  <msaboff@apple.com>
925
926         Improve the Inline Cache Stats code
927         https://bugs.webkit.org/show_bug.cgi?id=196836
928
929         Reviewed by Saam Barati.
930
931         Added a new script to consolidate and arrange the output of --useICStats option.
932
933         This script merges the output from every group into one large table and sorts it from most common to
934         least common.  It also counts the slow path GetById and PutById variants and then calculates the
935         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
936         Put together, this is useful to see what property accesses are not getting cached.
937
938         * Scripts/ic-stats.py: Added.
939         (ICStats):
940         (ICStats.__init__):
941         (ICStats.parse):
942         (ICStats.dumpStats):
943         (usage):
944
945 2019-04-10  Alex Christensen  <achristensen@webkit.org>
946
947         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
948         https://bugs.webkit.org/show_bug.cgi?id=196809
949         <rdar://49800762>
950
951         Reviewed by Brady Eidson.
952
953         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
954         (TEST):
955
956 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
957
958         requestAnimationFrame should execute before the next frame
959         https://bugs.webkit.org/show_bug.cgi?id=177484
960
961         Reviewed by Simon Fraser.
962
963         Add trace points for the page RenderingUpdate.
964
965         * Tracing/SystemTracePoints.plist:
966
967 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
968
969         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
970         https://bugs.webkit.org/show_bug.cgi?id=196760
971
972         Reviewed by Don Olmstead.
973
974         vswhere.exe has been bundled since Visual Studio 2017 version
975         15.2. We shouldn't download vswhere.exe.
976
977         * Scripts/build-jsc: Do not call update-vswhere.py.
978         * Scripts/build-webkit: Ditto.
979         * Scripts/update-vswhere.py: Removed.
980         * Scripts/webkitdirs.pm:
981         (requireModulesForVSWhere): Deleted.
982         (pickCurrentVisualStudioInstallation): Deleted.
983         (visualStudioInstallDirVSWhere): Return the latest installed VS
984         installation path by using the bundled vswhere.exe.
985         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
986         (visualStudioInstallDirFallback): Removed.
987
988 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
989
990         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
991         https://bugs.webkit.org/show_bug.cgi?id=196780
992
993         Reviewed by Alexey Proskuryakov.
994
995         * BuildSlaveSupport/ews-build/steps.py:
996         * BuildSlaveSupport/ews-build/steps_unittest.py:
997
998 2019-04-10  Alex Christensen  <achristensen@webkit.org>
999
1000         Add SPI WKNavigationResponse._downloadAttribute
1001         https://bugs.webkit.org/show_bug.cgi?id=196755
1002         <rdar://49587365>
1003
1004         Reviewed by Brady Eidson.
1005
1006         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1007         (-[NavigationResponseTestDelegate navigationResponse]):
1008         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1009         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1010         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1011         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1012         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1013         (readRequest):
1014         (writeResponse):
1015         (TEST):
1016
1017 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1018
1019         Add modern API for overriding the page's specified viewport configuration
1020         https://bugs.webkit.org/show_bug.cgi?id=167734
1021         <rdar://problem/30331795>
1022
1023         Reviewed by Simon Fraser.
1024
1025         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1026         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1027
1028 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1029
1030         Add support for incremental bytecode cache updates
1031         https://bugs.webkit.org/show_bug.cgi?id=195000
1032
1033         Reviewed by Filip Pizlo.
1034
1035         Exit when the initial run to generate bytecode fails.
1036
1037         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1038
1039 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1040
1041         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1042         https://bugs.webkit.org/show_bug.cgi?id=196744
1043         <rdar://49415309>
1044
1045         Reviewed by Chris Dumez.
1046
1047         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1048         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1049
1050 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1051
1052         Add a way to opt into modern compatibility mode in layout tests
1053         https://bugs.webkit.org/show_bug.cgi?id=196770
1054         <rdar://problem/49777550>
1055
1056         Reviewed by Antoine Quint.
1057
1058         Add a new test option to enable modern compatibility mode in layout tests.
1059
1060         * WebKitTestRunner/TestController.cpp:
1061         (WTR::updateTestOptionsFromTestHeader):
1062         * WebKitTestRunner/TestController.h:
1063         * WebKitTestRunner/TestOptions.h:
1064         (WTR::TestOptions::hasSameInitializationOptions const):
1065         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1066         (WTR::TestController::platformCreateWebView):
1067         (WTR::TestController::enableModernCompatibilityMode):
1068
1069 2019-04-10  Andy Estes  <aestes@apple.com>
1070
1071         Try to fix the 32-bit watchOS build.
1072
1073         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1074         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1075
1076 2019-04-10  Antoine Quint  <graouts@apple.com>
1077
1078         Enable Pointer Events on watchOS
1079         https://bugs.webkit.org/show_bug.cgi?id=196771
1080         <rdar://problem/49040909>
1081
1082         Reviewed by Dean Jackson.
1083
1084         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1085
1086 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1087
1088         Unreviewed. Fix WPE accessibility tests after r244059.
1089
1090         We are failing to load the injected bundle due to undefined symbol
1091         AccessibilityUIElement::replaceTextInRange().
1092
1093         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1094         (WTR::AccessibilityUIElement::replaceTextInRange):
1095
1096 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1097
1098         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1099         https://bugs.webkit.org/show_bug.cgi?id=196727
1100
1101         Reviewed by Fujii Hironori.
1102
1103         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1104         (WebKitBrowserWindow::create):
1105
1106 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1107
1108         [ews-build] Add unit tests for PrintConfiguration
1109         https://bugs.webkit.org/show_bug.cgi?id=196752
1110
1111         Reviewed by Dewei Zhu.
1112
1113         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1114
1115 2019-04-09  Keith Rollin  <krollin@apple.com>
1116
1117         Unreviewed build maintenance -- update .xcfilelists.
1118
1119         * DumpRenderTree/DerivedSources-input.xcfilelist:
1120         * DumpRenderTree/DerivedSources-output.xcfilelist:
1121
1122 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1123
1124         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1125         https://bugs.webkit.org/show_bug.cgi?id=196743
1126         <rdar://problem/43897551>
1127
1128         Reviewed by Tim Horton.
1129
1130         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1131         (TEST):
1132
1133 2019-04-09  Youenn Fablet  <youenn@apple.com>
1134
1135         Close service worker database on network process suspension
1136         https://bugs.webkit.org/show_bug.cgi?id=196623
1137         <rdar://problem/48930869>
1138
1139         Reviewed by Alex Christensen.
1140
1141         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1142
1143 2019-04-09  Daniel Bates  <dabates@apple.com>
1144
1145         [iPad] Should open popover when the spacebar is pressed
1146         https://bugs.webkit.org/show_bug.cgi?id=196360
1147         <rdar://problem/49389129>
1148
1149         Reviewed by Brent Fulgham.
1150
1151         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1152
1153         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1154         (WTR::UIScriptController::isShowingPopover const): Added.
1155         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1156         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1157         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1158         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1159         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1160         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1161         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1162         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1163         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1164         (WTR::UIScriptController::isShowingPopover const): Added.
1165         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1166         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1167         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1168         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1169         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1170         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1171         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1172         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1173         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1174         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1175         (WTR::UIScriptController::isShowingPopover const): Added.
1176         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1177         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1178
1179 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1180
1181         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1182         https://bugs.webkit.org/show_bug.cgi?id=196665
1183         <rdar://45115669>
1184
1185         Reviewed by Geoff Garen.
1186
1187         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1188         (goBack):
1189         (+[SimpleLookupContext sharedLookupContext]):
1190         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1191         (TEST):
1192         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1193         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1194
1195 2019-04-09  John Wilander  <wilander@apple.com>
1196
1197         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1198         https://bugs.webkit.org/show_bug.cgi?id=196558
1199         <rdar://problem/47650245>
1200
1201         Reviewed by Youenn Fablet.
1202
1203         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1204         (TestWebKitAPI::TEST):
1205             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1206
1207 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1208
1209         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1210         https://bugs.webkit.org/show_bug.cgi?id=196720
1211
1212         Reviewed by Konstantin Tokarev.
1213
1214         * TestWebKitAPI/PlatformMac.cmake:
1215
1216 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1217
1218         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1219         https://bugs.webkit.org/show_bug.cgi?id=196694
1220         <rdar://problem/48388734>
1221
1222         Rubber-stamped by Aakash Jain.
1223
1224         * Scripts/webkitpy/port/image_diff.py:
1225         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1226         * Scripts/webkitpy/port/server_process.py:
1227         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1228         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1229         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1230         * Scripts/webkitpy/port/server_process_mock.py:
1231         (MockServerProcess.has_available_stdout):
1232         * Scripts/webkitpy/port/server_process_unittest.py:
1233         (TestServerProcess.serial_test_basic):
1234
1235 2019-04-09  Jer Noble  <jer.noble@apple.com>
1236
1237         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1238         https://bugs.webkit.org/show_bug.cgi?id=196097
1239
1240         Reviewed by Eric Carlson.
1241
1242         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1243
1244         * DumpRenderTree/mac/DumpRenderTree.mm:
1245         (resetWebPreferencesToConsistentValues):
1246         * WebKitTestRunner/TestController.cpp:
1247         (WTR::TestController::resetPreferencesToConsistentValues):
1248
1249 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1250
1251         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1252         https://bugs.webkit.org/show_bug.cgi?id=196690
1253
1254         Reviewed by Michael Catanzaro.
1255
1256         * QueueStatusServer/config/queues.py:
1257         * Scripts/webkitpy/common/config/ews.json:
1258         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1259         (test_ews_name):
1260
1261 2019-04-09  Chris Dumez  <cdumez@apple.com>
1262
1263         Loads using loadHTMLString() cause flashing when process-swapping
1264         https://bugs.webkit.org/show_bug.cgi?id=196714
1265         <rdar://problem/49637354>
1266
1267         Reviewed by Antti Koivisto.
1268
1269         Add API test coverage.
1270
1271         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1272
1273 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1274
1275         Unreviewed. Fix ATK accessibility tests after r244059.
1276
1277         We are failing to load the injected bundle due to undefined symbol
1278         AccessibilityUIElement::replaceTextInRange().
1279
1280         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1281         (WTR::AccessibilityUIElement::replaceTextInRange):
1282
1283 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1284
1285         AX: Support API: accessibilityReplaceRange:withText
1286         https://bugs.webkit.org/show_bug.cgi?id=196636
1287
1288         Unreviewed build fix for Windows port.
1289
1290         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1291         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1292
1293 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1294
1295         [CMake][WinCairo] Separate copied headers into different directories
1296         https://bugs.webkit.org/show_bug.cgi?id=196655
1297
1298         Reviewed by Michael Catanzaro.
1299
1300         * DumpRenderTree/CMakeLists.txt:
1301         * MiniBrowser/win/CMakeLists.txt:
1302         * TestWebKitAPI/CMakeLists.txt:
1303         * TestWebKitAPI/PlatformWin.cmake:
1304
1305 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1306
1307         Log stack-trace for run-webkit-tests when interrupted
1308         https://bugs.webkit.org/show_bug.cgi?id=176393
1309         <rdar://problem/34262310>
1310
1311         Reviewed by Lucas Forschler.
1312
1313         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1314         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1315         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1316         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1317         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1318         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1319         (main): Set handlers to log stack trace on interruption.
1320
1321 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1322
1323         AX: Support API: accessibilityReplaceRange:withText
1324         https://bugs.webkit.org/show_bug.cgi?id=196636
1325
1326         Unreviewed build fix for Windows port.
1327
1328         * DumpRenderTree/AccessibilityUIElement.cpp:
1329         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1330
1331 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1332
1333         [ews-build] Scripts using Buildbot API have CORS error
1334         https://bugs.webkit.org/show_bug.cgi?id=196709
1335
1336         Reviewed by Alexey Proskuryakov.
1337
1338         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1339
1340 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1341
1342         AX: Support API: accessibilityReplaceRange:withText
1343         https://bugs.webkit.org/show_bug.cgi?id=196636
1344
1345         Reviewed by Daniel Bates.
1346
1347         * DumpRenderTree/AccessibilityUIElement.cpp:
1348         (replaceTextInRangeCallback):
1349         (AccessibilityUIElement::replaceTextInRange):
1350         (AccessibilityUIElement::getJSClass):
1351         * DumpRenderTree/AccessibilityUIElement.h:
1352         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1353         (AccessibilityUIElement::replaceTextInRange):
1354         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1355         (AccessibilityUIElement::replaceTextInRange):
1356         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1357         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1358         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1359         (WTR::AccessibilityUIElement::replaceTextInRange):
1360         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1361         (WTR::AccessibilityUIElement::replaceTextInRange):
1362
1363 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1364
1365         [iOS] Do not allow starting selection drags when selection views are not visible
1366         https://bugs.webkit.org/show_bug.cgi?id=196686
1367         <rdar://problem/49399192>
1368
1369         Reviewed by Tim Horton.
1370
1371         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1372         also add some new API tests to cover scenarios where the web view is not first responder.
1373
1374         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1375         (TestWebKitAPI::TEST):
1376         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1377
1378         Add a switch to optionally make the web view first responder when starting the simulated drag.
1379
1380         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1381         (-[DragAndDropSimulator initWithWebView:]):
1382         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1383
1384 2019-04-08  Justin Fan  <justin_fan@apple.com>
1385
1386         [Web GPU] Fix Web GPU experimental feature on iOS
1387         https://bugs.webkit.org/show_bug.cgi?id=196632
1388
1389         Reviewed by Myles C. Maxfield.
1390
1391         Properly make Web GPU available on iOS 11+.
1392
1393         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1394
1395 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1396
1397         [ews-build] Do not upload archive when Compile Fails
1398         https://bugs.webkit.org/show_bug.cgi?id=196674
1399
1400         Reviewed by Alexey Proskuryakov.
1401
1402         * BuildSlaveSupport/ews-build/factories.py:
1403         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1404         * BuildSlaveSupport/ews-build/steps.py:
1405         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1406         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1407         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1408
1409 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1410
1411         Enable DFG on MIPS
1412         https://bugs.webkit.org/show_bug.cgi?id=196689
1413
1414         Reviewed by Žan Doberšek.
1415
1416         Since the bytecode change, we enabled the baseline JIT on mips in
1417         r240432, but DFG is still missing. With this change, all tests are
1418         passing on a ci20 board.
1419
1420         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1421
1422 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1423
1424         [Flatpak] Second run update-webkitwpe-flatpak fails
1425         https://bugs.webkit.org/show_bug.cgi?id=192702
1426
1427         Reviewed by Carlos Garcia Campos.
1428
1429         * flatpak/flatpakutils.py:
1430         (FlatpakObject.flatpak): Fix typo.
1431         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1432         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1433
1434 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1435
1436         [GTK][WPE] outlook.live.com displays old-fashioned UI
1437         https://bugs.webkit.org/show_bug.cgi?id=196642
1438
1439         Reviewed by Carlos Garcia Campos.
1440
1441         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1442         (TestWebKitAPI::TEST): New Mac platform quirk test.
1443
1444 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1445
1446         Unreviewed, rolling out r243956.
1447         https://bugs.webkit.org/show_bug.cgi?id=196688
1448
1449         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1450         by aakashjain on #webkit).
1451
1452         Reverted changeset:
1453
1454         "Clicking "Go Back" from a safe browsing warning from an
1455         iframe should navigate the WKWebView back to the previous
1456         page"
1457         https://bugs.webkit.org/show_bug.cgi?id=196665
1458         https://trac.webkit.org/changeset/243956
1459
1460 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1461
1462         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1463         https://bugs.webkit.org/show_bug.cgi?id=196669
1464
1465         Reviewed by Geoffrey Garen.
1466
1467         Added three new unit tests for WeakHashSet.
1468
1469         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1470         (WTF_WeakPtr.WeakHashSetConstObjects):
1471         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1472         (WTF_WeakPtr.WeakHashSetComputeSize):
1473
1474 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1475
1476         Hide next and previous form control buttons when WKWebView is editable
1477         https://bugs.webkit.org/show_bug.cgi?id=196672
1478         <rdar://problem/35625321>
1479
1480         Reviewed by Tim Horton.
1481
1482         Add a new API test.
1483
1484         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1485         (-[TestWKWebView lastTrailingBarButtonGroup]):
1486         (TestWebKitAPI::TEST):
1487         * TestWebKitAPI/ios/UIKitSPI.h:
1488
1489 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1490
1491         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1492         https://bugs.webkit.org/show_bug.cgi?id=196077
1493         <rdar://problem/49108202>
1494
1495         Reviewed by Chris Dumez.
1496
1497         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1498         on new web view.
1499
1500         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1501
1502 2019-04-05  Saam Barati  <sbarati@apple.com>
1503
1504         Make compare-results understand MotionMark
1505         https://bugs.webkit.org/show_bug.cgi?id=196666
1506
1507         Reviewed by Yusuke Suzuki.
1508
1509         * Scripts/compare-results:
1510         (PLT5Results):
1511         (detectMotionMark):
1512         (detectMotionMark1_1):
1513         (motionMarkResults):
1514         (motionMark1_1Results):
1515         (detectBenchmark):
1516         (biggerIsBetter):
1517         (main):
1518
1519 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1520
1521         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1522         https://bugs.webkit.org/show_bug.cgi?id=196665
1523         <rdar://45115669>
1524
1525         Reviewed by Geoff Garen.
1526
1527         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1528         (goBack):
1529         (+[SimpleLookupContext sharedLookupContext]):
1530         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1531         (TEST):
1532         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1533         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1534
1535 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1536
1537         [ews-build] Add configuration and architecture for windows builders
1538         https://bugs.webkit.org/show_bug.cgi?id=196660
1539
1540         Reviewed by Lucas Forschler.
1541
1542         * BuildSlaveSupport/ews-build/config.json:
1543
1544 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1545
1546         webkitpy: Don't run subsequent rounds if interrupted
1547         https://bugs.webkit.org/show_bug.cgi?id=196646
1548
1549         Reviewed by Aakash Jain.
1550
1551         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1552         (Manager.run): Bail out if interrupted.
1553
1554 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1555
1556         Test sessionStorage in PSON private browsing mode
1557         https://bugs.webkit.org/show_bug.cgi?id=196561
1558
1559         Reviewed by Alex Christensen.
1560
1561         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1562
1563 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1564
1565         Unreviewed, rolling out r243833.
1566         https://bugs.webkit.org/show_bug.cgi?id=196645
1567
1568         This change breaks build of WPE and GTK ports (Requested by
1569         annulen on #webkit).
1570
1571         Reverted changeset:
1572
1573         "[CMake][WTF] Mirror XCode header directories"
1574         https://bugs.webkit.org/show_bug.cgi?id=191662
1575         https://trac.webkit.org/changeset/243833
1576
1577 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1578
1579         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1580         https://bugs.webkit.org/show_bug.cgi?id=196635
1581
1582         Reviewed by Antti Koivisto.
1583         
1584         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1585         for a test to enable async frame scrolling via:
1586             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1587         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1588         
1589         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1590
1591         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1592         (WTR::InjectedBundle::beginTesting):
1593         * WebKitTestRunner/TestController.cpp:
1594         (WTR::TestController::resetPreferencesToConsistentValues):
1595
1596 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1597
1598         Use a correct LC_RPATH when building with ASan
1599         https://bugs.webkit.org/show_bug.cgi?id=196576
1600
1601         Reviewed by David Kilzer.
1602
1603         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1604         so that ../Frameworks is checked. This is simpler and more reliable than updating
1605         each SPC service xcconfig.
1606
1607 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1608
1609         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1610         https://bugs.webkit.org/show_bug.cgi?id=196629
1611
1612         Reviewed by Lucas Forschler.
1613
1614         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1615
1616 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1617
1618         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1619         https://bugs.webkit.org/show_bug.cgi?id=196618
1620
1621         Reviewed by Lucas Forschler.
1622
1623         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1624         (StatusBubble): Added QUEUE_TRIGGERS.
1625         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1626         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1627         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1628         its parent(builder).
1629
1630 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1631
1632         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1633         https://bugs.webkit.org/show_bug.cgi?id=196625
1634
1635         Reviewed by Lucas Forschler.
1636
1637         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1638         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1639
1640 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1641
1642         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1643         https://bugs.webkit.org/show_bug.cgi?id=196630
1644
1645         Reviewed by Wenson Hsieh.
1646
1647         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1648
1649 2019-04-04  Youenn Fablet  <youenn@apple.com>
1650
1651         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1652         https://bugs.webkit.org/show_bug.cgi?id=196543
1653
1654         Reviewed by Alex Christensen.
1655
1656         * WebKitTestRunner/TestController.cpp:
1657         (WTR::TestController::generatePageConfiguration):
1658
1659 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1660
1661         [ews-app] Status bubble should not display skipped buildbot steps
1662         https://bugs.webkit.org/show_bug.cgi?id=196584
1663
1664         Reviewed by Lucas Forschler.
1665
1666         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1667
1668 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1669
1670         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1671         https://bugs.webkit.org/show_bug.cgi?id=196620
1672
1673         Reviewed by Lucas Forschler.
1674
1675         * BuildSlaveSupport/ews-app/ews/config.py:
1676
1677 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1678
1679         [Win] DumpRenderTreeWatchDog.py is not checked into source
1680         https://bugs.webkit.org/show_bug.cgi?id=196567
1681         <rdar://problem/49525901>
1682
1683         Reviewed by Lucas Forschler.
1684
1685         This script is used on Win EWS bots to terminate hanging DRT processes.
1686
1687         * EWSTools/dumprendertreewatchdog.py: Added.
1688
1689 2019-04-04  Chris Dumez  <cdumez@apple.com>
1690
1691         Unreviewed, roll out r243858 which made tests time out.
1692
1693         Disable new API tests on Windows instead.
1694
1695         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1696         (TestWebKitAPI::TEST):
1697
1698 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1699
1700         [ATK] Cleanup WebPageAccessibilityObjectAtk
1701         https://bugs.webkit.org/show_bug.cgi?id=196537
1702
1703         Reviewed by Michael Catanzaro.
1704
1705         Also consider files under atk directories as exceptions for GObject conventions.
1706
1707         * Scripts/webkitpy/style/checkers/cpp.py:
1708         (check_identifier_name_in_declaration):
1709
1710 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1711
1712         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1713         https://bugs.webkit.org/show_bug.cgi?id=196588
1714         <rdar://problem/49365787>
1715
1716         Unreviewed build fix for Windows port.
1717
1718         error C3861: 'kill': identifier not found
1719
1720         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1721         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1722
1723 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1724
1725         [ews-build] Cancel build and similar operations should have authentication
1726         https://bugs.webkit.org/show_bug.cgi?id=196520
1727
1728         Reviewed by Dewei Zhu.
1729
1730         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1731         environment variables.
1732
1733 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1734
1735         [ews-build] Do not trigger queues which are not in production yet
1736         https://bugs.webkit.org/show_bug.cgi?id=196581
1737
1738         Reviewed by Dewei Zhu.
1739
1740         * BuildSlaveSupport/ews-build/config.json:
1741
1742 2019-04-03  Chris Dumez  <cdumez@apple.com>
1743
1744         Unreviewed, fix typo in the name of API test added in r243848.
1745
1746         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1747         (TestWebKitAPI::TEST):
1748
1749 2019-04-03  Chris Dumez  <cdumez@apple.com>
1750
1751         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1752         https://bugs.webkit.org/show_bug.cgi?id=196588
1753         <rdar://problem/49365787>
1754
1755         Reviewed by Ryosuke Niwa.
1756
1757         Add API test coverage.
1758
1759         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1760         (TestWebKitAPI::nullJavaScriptCallback):
1761         (TestWebKitAPI::didCrashCheckFrames):
1762         (TestWebKitAPI::TEST):
1763
1764 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1765
1766         run-webkit-tests: Upload test results (new results database)
1767         https://bugs.webkit.org/show_bug.cgi?id=196577
1768         <rdar://problem/34841155>
1769
1770         Reviewed by Lucas Forschler.
1771
1772         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1773         (Manager.run): Upload results after each device shard, since the configuration will be
1774         different for each device.
1775         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1776         uploaded to a results database.
1777         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1778         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1779
1780 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1781
1782         -apple-trailing-word is needed for browser detection
1783         https://bugs.webkit.org/show_bug.cgi?id=196575
1784
1785         Unreviewed.
1786
1787         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1788
1789 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1790
1791         [CMake][WTF] Mirror XCode header directories
1792         https://bugs.webkit.org/show_bug.cgi?id=191662
1793
1794         Reviewed by Konstantin Tokarev.
1795
1796         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1797         builds.
1798
1799         * CMakeLists.txt:
1800         * DumpRenderTree/CMakeLists.txt:
1801         * DumpRenderTree/PlatformWin.cmake:
1802         * MiniBrowser/win/CMakeLists.txt:
1803         * TestWebKitAPI/CMakeLists.txt:
1804         * TestWebKitAPI/PlatformWin.cmake:
1805         * WebKitTestRunner/PlatformGTK.cmake:
1806         * WebKitTestRunner/PlatformWin.cmake:
1807
1808 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1809
1810         [ews-app] Status bubble should not display certain infrastructure status messages
1811         https://bugs.webkit.org/show_bug.cgi?id=196550
1812
1813         Reviewed by Lucas Forschler.
1814
1815         Do not display the steps which are un-needed for end-user. This information is still avaiable
1816         if the user click on the bubble and look at the Buildbot build.
1817         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1818         (StatusBubble._steps_messages):
1819         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1820
1821 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1822
1823         [ews-build] Use https for sending data to ews-app
1824         https://bugs.webkit.org/show_bug.cgi?id=196492
1825
1826         Reviewed by Lucas Forschler.
1827
1828         * BuildSlaveSupport/ews-build/events.py:
1829
1830 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1831
1832         Remove support for -apple-trailing-word
1833         https://bugs.webkit.org/show_bug.cgi?id=196525
1834
1835         Reviewed by Zalan Bujtas.
1836
1837         This CSS property is nonstandard and not used.
1838
1839         * Scripts/webkitperl/FeatureList.pm:
1840         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1841
1842 2019-04-03  Youenn Fablet  <youenn@apple.com>
1843
1844         Add a test for DOMCache on multiple browsing in case of private browsing
1845         https://bugs.webkit.org/show_bug.cgi?id=196524
1846
1847         Reviewed by Alex Christensen.
1848
1849         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1850         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1851
1852 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1853
1854         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1855         https://bugs.webkit.org/show_bug.cgi?id=196540
1856
1857         Reviewed by Aakash Jain.
1858
1859         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1860
1861 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1862
1863         Add plumbing for a compatibility mode preference in WebKit
1864         https://bugs.webkit.org/show_bug.cgi?id=196005
1865
1866         Reviewed by Tim Horton.
1867
1868         Add new API tests.
1869
1870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1871         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1872
1873 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1874
1875         [WPE][GTK] Update libsrtp dependency package for Debian
1876         https://bugs.webkit.org/show_bug.cgi?id=196528
1877
1878         Reviewed by Frédéric Wang.
1879
1880         * gtk/install-dependencies:
1881         * wpe/install-dependencies:
1882
1883 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1884
1885         [WK2] Add support for Window's beforeprint / afterprint events
1886         https://bugs.webkit.org/show_bug.cgi?id=196478
1887         <rdar://problem/49535124>
1888
1889         Unreviewed build fix for MSVC.
1890
1891         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1892
1893         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1894
1895         * WebKitTestRunner/TestController.cpp:
1896         (WTR::printFrame): Use int and float literals.
1897
1898 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1899
1900         [ews-build] Reassign bots to queues
1901
1902         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1903
1904 2019-04-02  Chris Dumez  <cdumez@apple.com>
1905
1906         [WK2] Add support for Window's beforeprint / afterprint events
1907         https://bugs.webkit.org/show_bug.cgi?id=196478
1908
1909         Reviewed by Alex Christensen.
1910
1911         Add minimal implementation for printFrame in WebKitTestRunner.
1912
1913         * WebKitTestRunner/TestController.cpp:
1914         (WTR::printFrame):
1915         (WTR::TestController::createOtherPage):
1916         (WTR::TestController::createWebViewWithOptions):
1917
1918 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1919
1920         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1921         https://bugs.webkit.org/show_bug.cgi?id=196491
1922
1923         Reviewed by Lucas Forschler.
1924
1925         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1926
1927 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1928
1929         [ews-build] Configure buildbot try credentials in environment variables
1930         https://bugs.webkit.org/show_bug.cgi?id=196501
1931
1932         Reviewed by Lucas Forschler.
1933
1934         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1935         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1936         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1937
1938 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1939
1940         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1941         https://bugs.webkit.org/show_bug.cgi?id=196496
1942         <rdar://problem/49521634>
1943
1944         Reviewed by Chris Dumez.
1945
1946         Add new API tests (see WebKit ChangeLog for more detail).
1947
1948         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1949         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1950         (TEST):
1951
1952 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1953
1954         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1955         <https://webkit.org/b/196499>
1956
1957         Reviewed by Alexey Proskuryakov.
1958
1959         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1960         ENABLE_ADDRESS_SANITIZER.
1961
1962 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1963
1964         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1965         https://bugs.webkit.org/show_bug.cgi?id=182757
1966
1967         Reviewed by Don Olmstead.
1968
1969         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1970         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1971
1972 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1973
1974         run-api-tests: Upload test results
1975         https://bugs.webkit.org/show_bug.cgi?id=196323
1976         <rdar://problem/49356714>
1977
1978         Reviewed by Lucas Forschler.
1979
1980         * Scripts/webkitpy/api_tests/manager.py:
1981         (Manager):
1982         (Manager.run): Upload results to a results database.
1983         * Scripts/webkitpy/api_tests/run_api_tests.py:
1984         (parse_args): Add upload arguments.
1985         * Scripts/webkitpy/port/base.py:
1986         (Port):
1987         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1988         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1989         with commits from any other associated repositories.
1990         * Scripts/webkitpy/port/device.py:
1991         (Device):
1992         (Device.build_version): Access build_versoin of underlying platform device.
1993         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1994         (IOSSimulatorTest):
1995         (IOSSimulatorTest.test_configuration_for_upload):
1996         * Scripts/webkitpy/port/device_port.py:
1997         (DevicePort):
1998         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1999         the same as the machine uploading results.
2000         * Scripts/webkitpy/port/mac.py:
2001         (MacPort):
2002         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2003         * Scripts/webkitpy/port/mac_unittest.py:
2004         (MacTest):
2005         (MacTest.test_configuration_for_upload):
2006         * Scripts/webkitpy/xcode/simulated_device.py:
2007         (SimulatedDeviceManager._create_device_with_runtime):
2008         (SimulatedDevice.__init__): Create simulated device with a build_version.
2009         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2010         (test_existing_simulator):
2011
2012 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2013
2014         Remove extra newline characters (Follow-up fix to r243707)
2015
2016         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2017
2018 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2019
2020         [ews-app] Use API_KEY to accept results data
2021         https://bugs.webkit.org/show_bug.cgi?id=196461
2022
2023         Reviewed by Dewei Zhu.
2024
2025         * BuildSlaveSupport/ews-app/ews/views/results.py:
2026         (Results.post): Validate EWS_API_KEY before accepting any data.
2027         * BuildSlaveSupport/ews-build/events.py:
2028         (Events.sendData): Send EWS_API_KEY if available along with event data.
2029
2030 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2031
2032         Unable to copy and paste a PDF from Notes into Mail compose body
2033         https://bugs.webkit.org/show_bug.cgi?id=196442
2034         <rdar://problem/48573098>
2035
2036         Reviewed by Tim Horton.
2037
2038         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2039         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2040         to be specified on the item providers.
2041
2042         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2043         (TestWebKitAPI::mapItemForTesting):
2044         (TestWebKitAPI::contactItemForTesting):
2045
2046 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2047
2048         Make UIWKDocumentContext rects per-character instead of per-word
2049         https://bugs.webkit.org/show_bug.cgi?id=196459
2050
2051         Reviewed by Wenson Hsieh.
2052
2053         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2054         (TEST):
2055         Adjust test results due to switching to per-character rects.
2056
2057 2019-04-01  Chris Dumez  <cdumez@apple.com>
2058
2059         UIProcess crash when a prewarmed process is terminated
2060         https://bugs.webkit.org/show_bug.cgi?id=196451
2061         <rdar://problem/49245471>
2062
2063         Reviewed by Geoffrey Garen.
2064
2065         Add API test coverage.
2066
2067         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2068         (TEST):
2069
2070 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2071
2072         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2073         https://bugs.webkit.org/show_bug.cgi?id=196449
2074
2075         Reviewed by Lucas Forschler.
2076
2077         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2078         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2079         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2080         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2081
2082 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2083
2084         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2085         https://bugs.webkit.org/show_bug.cgi?id=196444
2086
2087         Reviewed by Lucas Forschler.
2088
2089         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2090
2091 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2092
2093         Add SPI to canonicalize NSURLs with WTF::URL
2094         https://bugs.webkit.org/show_bug.cgi?id=196415
2095         <rdar://problem/44980271>
2096
2097         Reviewed by Darin Adler.
2098
2099         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2100         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2101         (TestWebKitAPI::TEST):
2102
2103 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2104
2105         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2106         https://bugs.webkit.org/show_bug.cgi?id=196441
2107
2108         Reviewed by Carlos Garcia Campos.
2109
2110         Don't cache the wpe_view_backend object that might not exist yet at the
2111         time of EventSenderProxy constructor invocation, but instead retrieve
2112         that object whenever it's required for event dispatching. This should
2113         avoid crashes in this constructor now that it's invoked before any
2114         PlatformWindow has been set up (as changed in r243496).
2115
2116         * WebKitTestRunner/EventSenderProxy.h:
2117         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2118         (WTR::viewBackend):
2119         (WTR::EventSenderProxy::EventSenderProxy):
2120         (WTR::EventSenderProxy::mouseDown):
2121         (WTR::EventSenderProxy::mouseUp):
2122         (WTR::EventSenderProxy::mouseMoveTo):
2123         (WTR::EventSenderProxy::mouseScrollBy):
2124         (WTR::EventSenderProxy::keyDown):
2125         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2126
2127 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2128
2129         [Win][WebKit] MiniBrowser should support high DPI display
2130         https://bugs.webkit.org/show_bug.cgi?id=196391
2131
2132         Reviewed by Alex Christensen.
2133
2134         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2135         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2136         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2137         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2138
2139 2019-03-31  Sam Weinig  <weinig@apple.com>
2140
2141         Remove more i386 specific configurations
2142         https://bugs.webkit.org/show_bug.cgi?id=196430
2143
2144         Reviewed by Alexey Proskuryakov.
2145
2146         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2147         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2148
2149 2019-03-31  Andy Estes  <aestes@apple.com>
2150
2151         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2152         https://bugs.webkit.org/show_bug.cgi?id=196433
2153         <rdar://problem/49293305>
2154
2155         Reviewed by Tim Horton.
2156
2157         Enhanced API test coverage to include all navigation response policy decisions in both
2158         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2159
2160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2161         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2162         (TestWebKitAPI::TEST):
2163         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2164         (readFile):
2165         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2166         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2167         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2168         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2169         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2170         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2171         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2172         (-[QuickLookDelegate _downloadDidStart:]):
2173         (-[QuickLookDelegate _download:didReceiveResponse:]):
2174         (-[QuickLookDelegate _download:didReceiveData:]):
2175         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2176         (-[QuickLookDelegate _downloadDidFinish:]):
2177         (-[QuickLookDelegate _download:didFailWithError:]):
2178         (-[QuickLookDelegate _downloadDidCancel:]):
2179         (-[QuickLookDelegate verifyDownload]):
2180         (runTest):
2181         (runTestDecideBeforeLoading):
2182         (runTestDecideAfterLoading):
2183         (TEST):
2184         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2185         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2186         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2187         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2188         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2189         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2190         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2191         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2192         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2193         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2194         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2195         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2196         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2197         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2198
2199 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2200
2201         [CMake] add testdfg as target with build-jsc
2202         https://bugs.webkit.org/show_bug.cgi?id=196393
2203
2204         Reviewed by Saam Barati.
2205
2206         Added testdfg as one of the targets to build when
2207         using CMake.
2208
2209         * Scripts/build-jsc:
2210
2211 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2212
2213         Delete WebMetal implementation in favor of WebGPU
2214         https://bugs.webkit.org/show_bug.cgi?id=195418
2215
2216         Reviewed by Dean Jackson.
2217
2218         * DumpRenderTree/mac/DumpRenderTree.mm:
2219         (enableExperimentalFeatures):
2220         (resetWebPreferencesToConsistentValues):
2221         * Scripts/webkitperl/FeatureList.pm:
2222         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2224         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2225         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2226         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2227         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2228         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2229         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2230         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2231         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2232         (WTR::InjectedBundle::beginTesting):
2233         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2234         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2235         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2236
2237 2019-03-29  Chris Dumez  <cdumez@apple.com>
2238
2239         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2240         https://bugs.webkit.org/show_bug.cgi?id=196405
2241         <rdar://problem/49428130>
2242
2243         Reviewed by Wenson Hsieh.
2244
2245         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2246         the popover presentation methods to be no-ops. Use this in the new test added in
2247         r243523 so that we do not swizzle those methods for all tests. This is needed because
2248         those WatchOS tests rely on the popover getting presented and interactive.
2249
2250         * WebKitTestRunner/TestController.cpp:
2251         (WTR::updateTestOptionsFromTestHeader):
2252         * WebKitTestRunner/TestController.h:
2253         * WebKitTestRunner/TestOptions.h:
2254         (WTR::TestOptions::hasSameInitializationOptions const):
2255         * WebKitTestRunner/ios/TestControllerIOS.mm:
2256         (WTR::TestController::platformInitialize):
2257         (WTR::TestController::platformResetStateToConsistentValues):
2258
2259 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2260
2261         [Curl] Add Server Trust Evaluation Support.
2262         https://bugs.webkit.org/show_bug.cgi?id=191646
2263
2264         Reviewed by Fujii Hironori.
2265
2266         Implemented MiniBrowser UI for asking if user trusts the server.
2267
2268         * MiniBrowser/win/Common.cpp:
2269         (askServerTrustEvaluation):
2270         (replaceString):
2271         * MiniBrowser/win/Common.h:
2272         * MiniBrowser/win/MiniBrowserLib.rc:
2273         * MiniBrowser/win/MiniBrowserLibResource.h:
2274         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2275         (createPEMString):
2276         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2277         (WebKitBrowserWindow::canTrustServerCertificate):
2278         * MiniBrowser/win/WebKitBrowserWindow.h:
2279
2280 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2281
2282         Implement ResizeObserver.
2283         https://bugs.webkit.org/show_bug.cgi?id=157743
2284
2285         Reviewed by Simon Fraser.
2286
2287         Support resizeObserverEnabled webPreferences.
2288
2289         * DumpRenderTree/TestOptions.cpp:
2290         (TestOptions::TestOptions):
2291         * DumpRenderTree/TestOptions.h:
2292         * DumpRenderTree/mac/DumpRenderTree.mm:
2293         (setWebPreferencesForTestOptions):
2294         * DumpRenderTree/win/DumpRenderTree.cpp:
2295         (enableExperimentalFeatures):
2296         * Scripts/webkitperl/FeatureList.pm:
2297         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2298
2299 2019-03-28  John Wilander  <wilander@apple.com>
2300
2301         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2302         https://bugs.webkit.org/show_bug.cgi?id=196281
2303         <rdar://problem/48938748>
2304
2305         Reviewed by Alex Christensen.
2306
2307         This patch adds the function isStatisticsHasLocalStorage() to the
2308         TestRunner. With it, the page can query the WebsiteDataStore in the
2309         UI process to make sure that it sees LocalStorage.
2310
2311         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2312         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2313         (WTR::TestRunner::isStatisticsHasLocalStorage):
2314         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2315         * WebKitTestRunner/TestController.cpp:
2316         (WTR::TestController::isStatisticsHasLocalStorage):
2317         * WebKitTestRunner/TestController.h:
2318         * WebKitTestRunner/TestInvocation.cpp:
2319         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2320
2321 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2322
2323         API::Data::createWithoutCopying should do a null check before calling CFRelease
2324         https://bugs.webkit.org/show_bug.cgi?id=196276
2325         <rdar://problem/48059859>
2326
2327         Reviewed by Alex Christensen.
2328
2329         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2330
2331         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2332         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2333         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2334         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2335         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2336         (TestWebKitAPI::TEST):
2337
2338 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2339
2340         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2341         https://bugs.webkit.org/show_bug.cgi?id=186276
2342
2343         Reviewed by Carlos Garcia Campos.
2344
2345         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2346         (webViewLoadChanged):
2347         (testWebResourceGetDataError):
2348         (testWebResourceGetDataEmpty):
2349         (beforeAll):
2350         (webViewloadChanged): Deleted.
2351
2352 2019-03-27  Andy Estes  <aestes@apple.com>
2353
2354         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2355         https://bugs.webkit.org/show_bug.cgi?id=196317
2356
2357         Reviewed by Dan Bernstein.
2358
2359         package-root copies built products into a staging directory using ditto(1), which does not
2360         follow symbolic links as it traverses a directory. Now that the files in
2361         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2362         itself, these become broken links when ditto'd into the staging directory.
2363
2364         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2365
2366         * Scripts/package-root:
2367
2368 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2369
2370         [ews-app] Update display text of Submit for ews analysis
2371         https://bugs.webkit.org/show_bug.cgi?id=196309
2372
2373         Reviewed by Dewei Zhu.
2374
2375         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2376
2377 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2378
2379         run-webkit-tests should check for leaks in WebKit processes
2380         <https://webkit.org/b/193772>
2381         <rdar://problem/46526680>
2382
2383         Reviewed by Ryosuke Niwa.
2384
2385         This works by doing the following:
2386         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2387           The list of child processes are returned one per line:
2388           process.name: pid
2389         - Run the "#LIST CHILD PROCESSES" command just before the
2390           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2391           processes on the ServerProcess object.
2392         - When the `--leaks` switch is handled, run check_for_leaks() on
2393           each child process after the main test harness.
2394
2395         * DumpRenderTree/mac/DumpRenderTree.mm:
2396         (handleControlCommand):
2397         - Use strncmp() instead of strcmp().
2398         - Add support for handling "#LIST CHILD PROCESSES" command.
2399
2400         * Scripts/webkitpy/port/base.py:
2401         (Port.check_for_leaks):
2402         * Scripts/webkitpy/port/darwin.py:
2403         (DarwinPort.check_for_leaks):
2404         - Rename redundant 'process_pid' argument to 'process_id'.
2405
2406         * Scripts/webkitpy/port/driver.py:
2407         (Driver.do_post_tests_work):
2408         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2409           longer the only command this sends to WebKitTestRunner.
2410         - If the `--leaks` switch is present, send the
2411           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2412           result using Port.set_webkit_processes().
2413         (Driver._parse_child_processes_output):
2414         - Add helper method to parse list of child process names and
2415           process IDs returned from WebKitTestRunner.
2416
2417         * Scripts/webkitpy/port/ios_device.py:
2418         (IOSDevicePort.check_for_leaks):
2419         - Rename redundant 'process_pid' argument to 'process_id'.
2420
2421         * Scripts/webkitpy/port/leakdetector.py:
2422         (LeakDetector._parse_leaks_output):
2423         - Return early if there is no leaks_output.
2424         (LeakDetector.check_for_leaks):
2425         - Rename redundant 'process_pid' argument to 'process_id'.
2426
2427         * Scripts/webkitpy/port/server_process.py:
2428         (ServerProcess.__init__):
2429         (ServerProcess.child_processes):
2430         (ServerProcess.set_child_processes):
2431         - Add instance variable to Port to store list of child process
2432           names and process IDs returned from WebKitTestRunner.
2433         (ServerProcess._start):
2434         - Clear self._child_processes.
2435         (ServerProcess.stop):
2436         - If self._child_processes is set, call
2437           self._port.check_for_leaks() for each child process.
2438
2439         * Scripts/webkitpy/port/server_process_unittest.py:
2440         (TrivialMockPort.check_for_leaks):
2441         - Rename redundant 'process_pid' argument to 'process_id'.
2442
2443         * Scripts/webkitpy/port/simulator_process.py:
2444         (SimulatorProcess.stop):
2445         - If self._child_processes is set, call
2446           self._port.check_for_leaks() for each child process.
2447
2448         * Scripts/webkitpy/port/watch_device.py:
2449         (WatchDevicePort.check_for_leaks):
2450         - Rename redundant 'process_pid' argument to 'process_id'.
2451
2452         * WebKitTestRunner/TestController.cpp:
2453         (WTR::TestController::dumpResponse):
2454         - Extract method from findAndDumpWorldLeaks() so that it may be
2455           reused by findAndDumpWebKitProcessIdentifiers().
2456         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2457         - Add method to output process name and process ID of both the
2458           WebContent and Networking processes.
2459         (WTR::TestController::findAndDumpWorldLeaks):
2460         - Fix missing newline in output when there were no abandoned
2461           documents.
2462         - Call dumpResponse() for extracted code.
2463         (WTR::TestController::handleControlCommand):
2464         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2465         - Use strncmp() instead of strcmp().
2466         - Call findAndDumpWebKitProcessIdentifiers() when
2467           "#LIST CHILD PROCESSES" command is sent.
2468         * WebKitTestRunner/TestController.h:
2469         (WTR::TestController::dumpResponse):
2470         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2471         - Declare methods.
2472
2473 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2474
2475         Unreviewed. Add GLib API test cases after r243434.
2476
2477         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2478         (testWebViewActiveURI):
2479         (serverCallback):
2480         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2481         (sendRequestCallback):
2482
2483 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2484
2485         Geolocation request not complete when watch request was started in a different web process
2486         https://bugs.webkit.org/show_bug.cgi?id=195996
2487
2488         Reviewed by Alex Christensen.
2489
2490         Add a test case.
2491
2492         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2493         (TestWebKitAPI::runJavaScriptAlert):
2494         (TestWebKitAPI::TEST):
2495
2496 2019-03-26  Keith Rollin  <krollin@apple.com>
2497
2498         Update the way generate-xcfilelists returns strings from functions
2499         https://bugs.webkit.org/show_bug.cgi?id=195975
2500         <rdar://problem/49040807>
2501
2502         Reviewed by Dean Jackson.
2503
2504         There are places where generate-xcfilelists executes assignments with
2505         statements like:
2506
2507             FOO=$(some_function)
2508
2509         where "some_function" return a string by echoing it. E.g.
2510
2511             some_function()
2512             {
2513                 echo "Hello, World"
2514             }
2515
2516         This is a common idiom, but it has a problem if "some_function" needs
2517         to call "exit" in an attempt to halt the entire script right then and
2518         there. Since "some_function" is called inside of $(), it's being
2519         executed in a sub-shell. Calling exit in that sub-shell simply exits
2520         that shell; it doesn't not exit the outer shell in which the main part
2521         of the script is still running. As such, the main script keeps
2522         executing when the intent was for the script to halt.
2523
2524         The solution to this is to use a different idiom for returning
2525         strings. The one we now is to pass in the name of the variable to
2526         receive the string result:
2527
2528             some_function()
2529             {
2530                 variable_name=$1
2531                 eval $variable_name ="Hello, World"
2532             }
2533
2534         The call site now looks like
2535
2536             some_function FOO
2537
2538         Because there's no invocation of a sub-shell, some_function can now
2539         call "exit" if it wants to, and the entire script will exit at that
2540         point.
2541
2542         * Scripts/generate-xcfilelists:
2543
2544 2019-03-26  Chris Dumez  <cdumez@apple.com>
2545
2546         Add basic layout test coverage for File Picker on iOS
2547         https://bugs.webkit.org/show_bug.cgi?id=196265
2548
2549         Reviewed by Wenson Hsieh.
2550
2551         Add layout test infrastructure to test the file picker on iOS.
2552
2553         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2554         (WTR::UIScriptController::dismissFilePicker):
2555         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2556         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2557         (WTR::UIScriptController::dismissFilePicker):
2558         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2559         * WebKitTestRunner/TestController.cpp:
2560         (WTR::TestController::createWebViewWithOptions):
2561         (WTR::updateTestOptionsFromTestHeader):
2562         * WebKitTestRunner/TestOptions.h:
2563         (WTR::TestOptions::hasSameInitializationOptions const):
2564         * WebKitTestRunner/ios/TestControllerIOS.mm:
2565         (overridePresentViewController):
2566         (WTR::TestController::platformInitialize):
2567         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2568         (WTR::UIScriptController::dismissFilePicker):
2569
2570 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2571
2572         Implement async paste method on UIWKInteractionViewProtocol
2573         https://bugs.webkit.org/show_bug.cgi?id=196267
2574         <rdar://problem/49236346>
2575
2576         Reviewed by Tim Horton.
2577
2578         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2579         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2580         are now a part of all iOS 12 internal SDKs.
2581
2582         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2583
2584         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2585         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2586
2587         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2588         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2589         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2590         * TestWebKitAPI/ios/UIKitSPI.h:
2591
2592 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2593
2594         [ews-build] Use PostgreSQL for ews.webkit.org database
2595         https://bugs.webkit.org/show_bug.cgi?id=196270
2596
2597         Reviewed by Lucas Forschler.
2598
2599         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2600
2601 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2602
2603         [ews] Reset simctl states on reboot
2604         https://bugs.webkit.org/show_bug.cgi?id=196260
2605
2606         Rubber-stamped by Aakash Jain.
2607
2608         * EWSTools/start-queue-mac.sh:
2609
2610 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2611
2612         [ews-build] Use PostgreSQL for ews-build database
2613         https://bugs.webkit.org/show_bug.cgi?id=196229
2614
2615         Reviewed by Lucas Forschler.
2616
2617         * BuildSlaveSupport/ews-build/master.cfg:
2618
2619 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2620
2621         [ews-build] Get master_hostname dynamically in master.cfg
2622         https://bugs.webkit.org/show_bug.cgi?id=196255
2623
2624         Reviewed by Lucas Forschler.
2625
2626         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2627         send events data in test mode.
2628
2629 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2630
2631         [ews-app] Set db_constraint to False for Foreign Keys
2632         https://bugs.webkit.org/show_bug.cgi?id=196252
2633
2634         Reviewed by Lucas Forschler.
2635
2636         * BuildSlaveSupport/ews-app/ews/models/build.py:
2637         * BuildSlaveSupport/ews-app/ews/models/step.py:
2638
2639 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2640
2641         [ews-build] is_test_mode_enabled should default to True
2642         https://bugs.webkit.org/show_bug.cgi?id=196248
2643
2644         Reviewed by Lucas Forschler.
2645
2646         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2647
2648 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2649
2650         [ews-app] Add webkitperl to ENABLED_QUEUES
2651         https://bugs.webkit.org/show_bug.cgi?id=196253
2652
2653         Reviewed by Lucas Forschler.
2654
2655         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2656
2657 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2658
2659         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2660         https://bugs.webkit.org/show_bug.cgi?id=196211
2661         rdar://problem/49110552
2662
2663         Reviewed by Tim Horton.
2664
2665         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2666         Make sure that EventSenderProxy always exists when running tests. We used to create
2667         it when resetting before the first test, which is a bit too late.
2668
2669         * WebKitTestRunner/TestController.h:
2670         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2671         (WTR::TestController::platformCreateWebView):
2672         (WTR::TestController::platformCreateOtherPage):
2673         (WTR::TestController::finishCreatingPlatformWebView):
2674         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2675         (WTR::PlatformWebView::PlatformWebView):
2676         Moved some code that made NSWindow use NSEvent during web view creation. We may
2677         need to move more if some other case us found, but this is enough for now.
2678
2679 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2680
2681         Unreviewed. Fix typo in GLib geolocation API after r243285.
2682
2683         gelocation -> geolocation.
2684
2685         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2686         (testGeolocationManagerWatchPosition):
2687
2688 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2689
2690         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2691         https://bugs.webkit.org/show_bug.cgi?id=196213
2692
2693         Reviewed by Geoff Garen.
2694
2695         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2696         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2697         (credentialWithIdentityAndKeychainPath):
2698         (-[ChallengeDelegate webView:didFinishNavigation:]):
2699         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2700         (TestWebKitAPI::TEST):
2701
2702 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2703
2704         Expected shouldn't assume its contained types are copyable
2705         https://bugs.webkit.org/show_bug.cgi?id=195986
2706
2707         Reviewed by JF Bastien.
2708
2709         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2710         (TestWebKitAPI::NonCopyable::operator== const):
2711         (TestWebKitAPI::NonCopyable::operator!= const):
2712         (TestWebKitAPI::TEST):
2713
2714 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2715
2716         Remove some now-unnecessary dynamic class lookup
2717         https://bugs.webkit.org/show_bug.cgi?id=196237
2718
2719         Reviewed by Simon Fraser.
2720
2721         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2722         (makeRequest):
2723         (TEST):
2724
2725 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2726
2727         Unreviewed, rolling out r243450.
2728
2729         AppleWin and WinCairo port builds get broken.
2730
2731         Reverted changeset:
2732
2733         "Add test for fix of #196095"
2734         https://bugs.webkit.org/show_bug.cgi?id=196097
2735         https://trac.webkit.org/changeset/243450
2736
2737 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2738
2739         Unreviewed, rolling out r243465.
2740         https://bugs.webkit.org/show_bug.cgi?id=196226
2741
2742         the test doesn't build (Requested by thorton on #webkit).
2743
2744         Reverted changeset:
2745
2746         "Do not terminate the NetworkProcess if a third party
2747         application sends a NSCredential with a SecIdentityRef"
2748         https://bugs.webkit.org/show_bug.cgi?id=196213
2749         https://trac.webkit.org/changeset/243465
2750
2751 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2752
2753         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2754         https://bugs.webkit.org/show_bug.cgi?id=196213
2755
2756         Reviewed by Geoff Garen.
2757
2758         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2759         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2760         (credentialWithIdentityAndKeychainPath):
2761         (-[ChallengeDelegate webView:didFinishNavigation:]):
2762         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2763         (TestWebKitAPI::TEST):
2764
2765 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2766
2767         [ews-build] Gracefully handle missing patch_id in events
2768         https://bugs.webkit.org/show_bug.cgi?id=196216
2769
2770         Reviewed by Lucas Forschler.
2771
2772         * BuildSlaveSupport/ews-build/events.py:
2773
2774 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2775
2776         [ews-build] use lz4 compression for improving buildbot performance
2777         https://bugs.webkit.org/show_bug.cgi?id=196155
2778
2779         Reviewed by Lucas Forschler.
2780
2781         * BuildSlaveSupport/ews-build/master.cfg:
2782
2783 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2784
2785         Pull some API testing helper methods out of TestWKWebView
2786         https://bugs.webkit.org/show_bug.cgi?id=196212
2787
2788         Reviewed by Tim Horton.
2789
2790         Refactor some more API testing utility methods, so that they can be used in
2791         tests that do not use TestWKWebView.
2792
2793         * TestWebKitAPI/cocoa/TestWKWebView.h:
2794         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2795         (-[WKWebView loadTestPageNamed:]):
2796         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2797         (-[WKWebView synchronouslyLoadHTMLString:]):
2798         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2799         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2800         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2801         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2802         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2803
2804 2019-03-25  Jer Noble  <jer.noble@apple.com>
2805
2806         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2807         https://bugs.webkit.org/show_bug.cgi?id=196097
2808
2809         Reviewed by Eric Carlson.
2810
2811         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2812
2813         * DumpRenderTree/mac/DumpRenderTree.mm:
2814         (resetWebPreferencesToConsistentValues):
2815         * WebKitTestRunner/TestController.cpp:
2816         (WTR::TestController::resetPreferencesToConsistentValues):
2817
2818 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2819
2820         Pull IPadUserInterfaceSwizzler out into a separate header file
2821         https://bugs.webkit.org/show_bug.cgi?id=196193
2822
2823         Reviewed by Anders Carlsson.
2824
2825         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2826         be used in other API tests.
2827
2828         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2829         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2830         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2831         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2832         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2833         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2834         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2835
2836 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2837
2838         Remove NavigatorContentUtils in WebCore/Modules
2839         https://bugs.webkit.org/show_bug.cgi?id=196070
2840
2841         Reviewed by Alex Christensen.
2842
2843         NavigatorContentUtils was to support the custom scheme spec [1].
2844         However, in WebKit side, no port has supported the feature in
2845         WebKit layer after EFL port was removed. So there has been the
2846         only IDL implementation of the NavigatorContentUtils in WebCore.
2847         So we don't need to keep the implementation in WebCore anymore.
2848
2849         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2850
2851         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2852
2853 2019-03-24  Andy Estes  <aestes@apple.com>
2854
2855         [watchOS] Remove unused Proximity Networking code
2856         https://bugs.webkit.org/show_bug.cgi?id=196188
2857
2858         Reviewed by Tim Horton.
2859
2860         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2861         (TEST):
2862
2863 2019-03-23  Keith Miller  <keith_miller@apple.com>
2864
2865         Refactor clz/ctz and fix getLSBSet.
2866         https://bugs.webkit.org/show_bug.cgi?id=196162
2867
2868         Reviewed by Saam Barati.
2869
2870         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2871
2872         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2873         (TestWebKitAPI::TEST):
2874
2875 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2876
2877         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2878         https://bugs.webkit.org/show_bug.cgi?id=196143
2879
2880         Reviewed by Michael Catanzaro.
2881
2882         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2883         directories.
2884
2885         * Scripts/webkitpy/style/checkers/cpp.py:
2886         (check_identifier_name_in_declaration):
2887         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2888         (WebKitStyleTest.test_names):
2889
2890 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2891
2892         [Flatpak] Manifest expanding fails for qt WPE extension
2893         https://bugs.webkit.org/show_bug.cgi?id=196148
2894
2895         Reviewed by Alex Christensen.
2896
2897         * flatpak/flatpakutils.py:
2898         (expand_submodules_recurse): The last recurse manifest expand
2899         iteration might lead to a single module so take it into account
2900         and don't try to recurse further.
2901
2902 2019-03-22  Chris Dumez  <cdumez@apple.com>
2903
2904         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2905         https://bugs.webkit.org/show_bug.cgi?id=195348
2906         <rdar://problem/48622090>
2907
2908         Reviewed by Alex Christensen.
2909
2910         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2911         to NO when test.options().shouldIgnoreMetaViewport is false.
2912
2913         * WebKitTestRunner/ios/TestControllerIOS.mm:
2914         (WTR::TestController::platformConfigureViewForTest):
2915
2916 2019-03-22  Chris Dumez  <cdumez@apple.com>
2917
2918         Prewarmed processes should be usable with any website data store
2919         https://bugs.webkit.org/show_bug.cgi?id=196104
2920
2921         Reviewed by Alex Christensen.
2922
2923         Add API test coverage.
2924
2925         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2926         (runInitialWarmedProcessUsedTest):
2927         (TEST):
2928
2929 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2930
2931         Back out local changes to Alex's Subversion working directory
2932
2933         They were accidentally committed.
2934
2935         * Scripts/webkitpy/common/system/abstractexecutive.py:
2936         (AbstractExecutive.wait_newest):
2937         * Scripts/webkitpy/common/system/executive.py:
2938         (Executive.running_pids):
2939         * Scripts/webkitpy/common/system/executive_mock.py:
2940         (MockExecutive.running_pids):
2941         * Scripts/webkitpy/common/system/executive_unittest.py:
2942         (ExecutiveTest.serial_test_running_pids):
2943         * Scripts/webkitpy/port/darwin.py:
2944         (DarwinPort.check_for_leaks):
2945         * Scripts/webkitpy/port/leakdetector.py:
2946         (LeakDetector.check_for_leaks):
2947         - This was the hack attached to Bug 193772.
2948
2949         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2950         (+[WebKitTestRunnerEvent mouseLocation]):
2951         - This works around a crash on an internal build.
2952
2953 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2954
2955         Fix the build after r243354
2956         https://bugs.webkit.org/show_bug.cgi?id=196138
2957         <rdar://problem/49145951>
2958
2959         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2960         (TEST):
2961         * TestWebKitAPI/ios/UIKitSPI.h:
2962
2963 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2964
2965         Adopt UIWKDocumentContext
2966         https://bugs.webkit.org/show_bug.cgi?id=196040
2967         <rdar://problem/48642440>
2968
2969         Reviewed by Ryosuke Niwa.
2970
2971         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2972         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2973         (makeRequest):
2974         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2975         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2976         (applyStyle):
2977         (TEST):
2978         Add tests for UIWKDocumentContext.
2979
2980         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2981         (TEST):
2982         (recursiveFindWKContentView): Deleted.
2983         * TestWebKitAPI/cocoa/TestWKWebView.h:
2984         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2985         (recursiveFindWKContentView):
2986         (-[TestWKWebView wkContentView]):
2987         * TestWebKitAPI/ios/UIKitSPI.h:
2988         Share the WKContentView finding code between tests.
2989
2990 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2991
2992         [iOS WK2] Turn on async overflow scrolling by default
2993         https://bugs.webkit.org/show_bug.cgi?id=196011
2994         rdar://problem/48453859
2995
2996         Reviewed by Antti Koivisto.
2997         
2998         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2999         since so many basic layout tests have different results when compositing is triggered for
3000         overflow.
3001         
3002         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3003
3004         * WebKitTestRunner/TestController.cpp:
3005         (WTR::TestController::resetPreferencesToConsistentValues):
3006
3007 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3008
3009         [ews-build] Retry API test in case of failures
3010         https://bugs.webkit.org/show_bug.cgi?id=196004
3011
3012         Reviewed by Lucas Forschler.
3013
3014         * BuildSlaveSupport/ews-build/steps.py:
3015         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3016         (CompileWebKitToT.doStepIf): Ditto.
3017         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3018         (ReRunAPITests): Re-run API tests.
3019         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3020         (RunAPITestsWithoutPatch): Run API tests without patch.
3021         (RunAPITestsWithoutPatch.doStepIf):
3022         (RunAPITestsWithoutPatch.hideStepIf):
3023         (RunAPITestsWithoutPatch.evaluateCommand):
3024         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3025         (AnalyzeAPITestsResults.start):
3026         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3027         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3028         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3029         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3030
3031 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3032
3033         [ews-build] Update queues configurations
3034         https://bugs.webkit.org/show_bug.cgi?id=196074
3035
3036         Reviewed by Dewei Zhu.
3037
3038         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3039         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3040
3041 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3042
3043         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3044         https://bugs.webkit.org/show_bug.cgi?id=195680
3045         <rdar://problem/48903534>
3046
3047         Unreviewed infrastructure fix.
3048
3049         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3050         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3051
3052 2019-03-21  Andy Estes  <aestes@apple.com>
3053
3054         [iOS] Apple Pay should be available in documents with no user agent scripts
3055         https://bugs.webkit.org/show_bug.cgi?id=196061
3056         <rdar://problem/48649391>
3057
3058         Reviewed by Brady Eidson.
3059
3060         Added API tests and related infrastructure.
3061
3062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3063         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3064         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3065         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3066         (TestWebKitAPI::TEST):
3067         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3068         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3069         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3070         * TestWebKitAPI/cocoa/TestProtocol.mm:
3071         (-[TestProtocol startLoading]):
3072         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3073         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3074         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3075         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3076
3077 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3078
3079         REGRESSSION (r243297): webkitpy tests broken
3080         https://bugs.webkit.org/show_bug.cgi?id=196108
3081
3082         Reviewed by Aakash Jain.
3083
3084         r243297 updated contributors.json, which broke a few unit tests.
3085
3086         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3087         (IRCCommandTest.test_whois):
3088         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3089
3090 2019-03-21  Chris Dumez  <cdumez@apple.com>
3091
3092         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3093         https://bugs.webkit.org/show_bug.cgi?id=196041
3094         <rdar://problem/49083230>
3095
3096         Reviewed by Alex Christensen.
3097
3098         Add API test coverage.
3099
3100         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3101         (TEST):
3102
3103 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3104
3105         Add SPI to inform applications of WKContentRuleList actions
3106         https://bugs.webkit.org/show_bug.cgi?id=195965
3107         <rdar://problem/42664365>
3108
3109         Reviewed by Geoff Garen.
3110
3111         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3112         (TestWebKitAPI::allActionsForResourceLoad):
3113         (TestWebKitAPI::testRequest):
3114         (TestWebKitAPI::TEST_F):
3115         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3116         (Notification::description):
3117         (Notification::operator== const):
3118         (toVector):
3119         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3120         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3121         (makeContentRuleList):
3122         (TEST):
3123         (makeWarnContentRuleList): Deleted.
3124
3125 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3126
3127         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3128         https://bugs.webkit.org/show_bug.cgi?id=196088
3129
3130         Reviewed by Brian Burg.
3131
3132         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3133         Support checks when only one platform is specified. Also deprecate macosx() and
3134         force the use of macos() instead.
3135
3136         * Scripts/webkitpy/style/checkers/cpp.py:
3137         (check_min_versions_of_wk_api_available):
3138         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3139         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3140
3141 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3142
3143         Update status inactive committers' status to 'contributor'.
3144
3145         * Scripts/webkitpy/common/config/contributors.json:
3146
3147 2019-03-21  Xan Lopez  <xan@igalia.com>
3148
3149         [JSC][x86] Drop support for x87 floating point
3150         https://bugs.webkit.org/show_bug.cgi?id=194853
3151
3152         Reviewed by Don Olmstead.
3153
3154         Force SSE2 on x86/32bit builds.
3155
3156         * Scripts/webkitdirs.pm:
3157         (generateBuildSystemFromCMakeProject):
3158
3159 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3160
3161         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3162         https://bugs.webkit.org/show_bug.cgi?id=196073
3163
3164         Reviewed by Michael Catanzaro.
3165
3166         Add test cases to check functions and constructors with no arguments but receiving user data.
3167
3168         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3169         (checkUserData):
3170         (testJSCFunction):
3171         (fooCreateWithUserData):
3172         (testJSCClass):
3173
3174 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3175
3176         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3177
3178         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3179
3180         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3181
3182 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3183
3184         [GTK][WPE] Add API to provide geolocation information
3185         https://bugs.webkit.org/show_bug.cgi?id=195940
3186
3187         Reviewed by Michael Catanzaro.
3188
3189         Add a new test to check the new API.
3190
3191         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3192         (testGeolocationManagerCurrentPosition):
3193         (testGeolocationManagerWatchPosition):
3194         (beforeAll):
3195         (afterAll):
3196         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3197         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3198         (beforeAll): Ditto.
3199         * TestWebKitAPI/glib/CMakeLists.txt:
3200
3201 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3202
3203         [GLib] Returning G_TYPE_OBJECT from a method does not work
3204         https://bugs.webkit.org/show_bug.cgi?id=195574
3205
3206         Reviewed by Michael Catanzaro.
3207
3208         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3209
3210         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3211         (getGFile):
3212         (getParent):
3213         (createGString):
3214         (getGString):
3215         (getGStringCopyWillRaise):
3216         (getGStringCopy):
3217         (getGStringStr):
3218         (getGStringLen):
3219         (freeGString):
3220         (testJSCClass):
3221
3222 2019-03-20  Saam Barati  <sbarati@apple.com>
3223
3224         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3225         https://bugs.webkit.org/show_bug.cgi?id=195721
3226
3227         Reviewed by Filip Pizlo.
3228
3229         * Scripts/run-javascriptcore-tests:
3230
3231 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3232
3233         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3234         https://bugs.webkit.org/show_bug.cgi?id=196049
3235
3236         Reviewed by Tim Horton.
3237
3238         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3239         overflow scrolling in general, so rename it.
3240
3241         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3242
3243 2019-03-20  Daniel Bates  <dabates@apple.com>
3244
3245         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3246         https://bugs.webkit.org/show_bug.cgi?id=196031
3247         <rdar://problem/49078172>
3248
3249         Reviewed by Tim Horton.
3250
3251         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3252         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3253         same code path used when the Done button is pressed to dismiss the <select> picker.
3254
3255         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3256         (TestWebKitAPI::TEST):
3257
3258 2019-03-20  Chris Dumez  <cdumez@apple.com>
3259
3260         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3261         https://bugs.webkit.org/show_bug.cgi?id=196029
3262         <rdar://problem/48954651>
3263
3264         Reviewed by Tim Horton.
3265
3266         Add API test coverage.
3267
3268         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3269
3270 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3271
3272         [ews-build] Improve failure summary string for ApplyPatch step
3273         https://bugs.webkit.org/show_bug.cgi?id=195995
3274
3275         Reviewed by Alexey Proskuryakov.
3276
3277         * BuildSlaveSupport/ews-build/steps.py:
3278         (ApplyPatch.getResultSummary): Override getResultSummary.
3279
3280 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3281
3282         AX: Implement support for new meter ARIA role
3283         https://bugs.webkit.org/show_bug.cgi?id=195966
3284
3285         Reviewed by Chris Fleizach.
3286
3287         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3288         to AXLevelIndicator.
3289
3290         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3291
3292 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3293
3294         [WebAuthN] Implement FIDO AppID extension
3295         https://bugs.webkit.org/show_bug.cgi?id=143491
3296         <rdar://problem/48298273>
3297
3298         Reviewed by Brent Fulgham.
3299
3300         Add a test that covers the new flag of convertToU2fSignCommand.
3301
3302         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3303         (TestWebKitAPI::TEST):
3304         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3305         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3306         (TestWebKitAPI::TEST):
3307
3308 2019-03-19  Keith Rollin  <krollin@apple.com>
3309
3310         Add support for more platforms to generate-xcfilelists
3311         https://bugs.webkit.org/show_bug.cgi?id=195977
3312
3313         Reviewed by Alexey Proskuryakov.
3314
3315         generate-xcfilelists incorrectly complains when involved with building
3316         WebKit for iphonesimulator:
3317
3318             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3319             …
3320             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3321
3322         Address this by teaching generate-xcfilelists about more platforms.
3323
3324         * Scripts/generate-xcfilelists:
3325
3326 2019-03-19  John Wilander  <wilander@apple.com>
3327
3328         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3329         https://bugs.webkit.org/show_bug.cgi?id=195923
3330         <rdar://problem/49001272>
3331
3332         Reviewed by Alex Christensen.
3333
3334         This patch does the following to the TestRunner:
3335         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3336         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3337         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3338
3339         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3340         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3341         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3342         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3343         * WebKitTestRunner/TestController.cpp:
3344         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3345         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3346         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3347         * WebKitTestRunner/TestController.h:
3348         * WebKitTestRunner/TestInvocation.cpp:
3349         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3350
3351 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3352
3353         [CMake] Support more clang and gcc sanitizers
3354         https://bugs.webkit.org/show_bug.cgi?id=195956
3355
3356         Reviewed by Michael Catanzaro.
3357
3358         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3359
3360 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3361
3362         [ews-build] Improve summary for PrintConfiguration step
3363         https://bugs.webkit.org/show_bug.cgi?id=195945
3364
3365         Reviewed by Lucas Forschler.
3366
3367         * BuildSlaveSupport/ews-build/steps.py:
3368         (PrintConfiguration.getResultSummary): Override getResultSummary.
3369
3370 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3371
3372         [ews-build] Improve summary for CheckOutSource step
3373         https://bugs.webkit.org/show_bug.cgi?id=195963
3374
3375         Reviewed by Lucas Forschler.
3376
3377         * BuildSlaveSupport/ews-build/steps.py:
3378         (CheckOutSource.getResultSummary):
3379
3380 2019-03-19  Daniel Bates  <dabates@apple.com>
3381
3382         [iOS] Focus not preserved when switching between tabs
3383         https://bugs.webkit.org/show_bug.cgi?id=195820
3384         <rdar://problem/43614450>
3385
3386         Reviewed by Brent Fulgham.
3387
3388         Add tests to ensure that we restore focus when resigning and becoming first responder.
3389
3390         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3391         (TestWebKitAPI::TEST):
3392
3393 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3394
3395         Make WTFLogChannelState and WTFLogLevel enum classes
3396         https://bugs.webkit.org/show_bug.cgi?id=195904
3397
3398         Reviewed by Eric Carlson.
3399
3400         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3401         (TestWebKitAPI::TEST_F):
3402
3403 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3404
3405         [GStreamer][EME] Backported mssdemux protection data crash fix
3406         https://bugs.webkit.org/show_bug.cgi?id=195918
3407
3408         Reviewed by Philippe Normand.
3409
3410         * gstreamer/jhbuild.modules:
3411         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3412
3413 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3414
3415         Unreviewed, rolling out r243132.
3416
3417         Broke GTK build
3418
3419         Reverted changeset:
3420
3421         "Make WTFLogChannelState and WTFLogLevel enum classes"
3422         https://bugs.webkit.org/show_bug.cgi?id=195904
3423         https://trac.webkit.org/changeset/243132
3424
3425 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3426
3427         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3428
3429         * Scripts/webkitdirs.pm:
3430         (builtDylibPathForName): Adjust the shared library name that's changed
3431         with the API version bump in r243073.
3432
3433 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3434
3435         Make WTFLogChannelState and WTFLogLevel enum classes
3436         https://bugs.webkit.org/show_bug.cgi?id=195904
3437
3438         Reviewed by Eric Carlson.
3439
3440         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3441         (TestWebKitAPI::TEST_F):
3442
3443 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3444
3445         Disable flaky test added in r2431100
3446         https://webkit.org/b/195785
3447
3448         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3449         (TestWebKitAPI::TEST):
3450         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3451
3452 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3453
3454         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3455         https://bugs.webkit.org/show_bug.cgi?id=195916
3456
3457         Reviewed by Tim Horton.
3458
3459         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3460         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3461
3462 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3463
3464         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3465
3466         * Scripts/webkitpy/common/config/contributors.json:
3467
3468 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3469
3470         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3471         https://bugs.webkit.org/show_bug.cgi?id=195785
3472
3473         Reviewed by Geoffrey Garen.
3474
3475         * TestWebKitAPI/TCPServer.cpp: Added.
3476         (TestWebKitAPI::TCPServer::TCPServer):
3477         (TestWebKitAPI::TCPServer::~TCPServer):
3478         (TestWebKitAPI::TCPServer::socketBindListen):
3479         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3480         * TestWebKitAPI/TCPServer.h: Added.
3481         (TestWebKitAPI::TCPServer::port const):
3482         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3483         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3484         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3485         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3486         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3487         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3488         (TestWebKitAPI::respondSlowly):
3489         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3490         (TestWebKitAPI::downloadAtRate):
3491         (TestWebKitAPI::TEST):
3492
3493 2019-03-18  Saam Barati  <sbarati@apple.com>
3494
3495         Add a plan file for JetStream 2
3496         https://bugs.webkit.org/show_bug.cgi?id=190734
3497
3498         Reviewed by Mark Lam.
3499
3500         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3501
3502 2019-03-18  Chris Dumez  <cdumez@apple.com>
3503
3504         Delay WebProcess launch until a load is triggered in a Web view
3505         https://bugs.webkit.org/show_bug.cgi?id=195758
3506         <rdar://problem/48126013>
3507
3508         Reviewed by Geoff Garen.
3509
3510         Add API test coverage. Also update some existing API tests to not expect
3511         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3512
3513         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3514         (TestWebKitAPI::TEST):
3515         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3516         (TestWebKitAPI::TEST):
3517         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3518         (TEST):
3519         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3520         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3521         (TEST):
3522         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3523         (TEST):
3524         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3525
3526 2019-03-18  Xan Lopez  <xan@igalia.com>
3527
3528         [CMake] Prevent potential warning when determining $architecture
3529         https://bugs.webkit.org/show_bug.cgi?id=195891
3530
3531         Reviewed by Michael Catanzaro.
3532
3533         It's possible for generateBuildSystemForCMakeProject to be called
3534         before determineArchitecture() is ever called. This will make the
3535         first eq check with $architecture to be bogus (and print a
3536         warning). Change that to an eq check with architecture(), which
3537         implicitly calls determineArchitecture() if needed, and change all
3538         the other similar cases in the method in the same way to prevent
3539         future bugs like this one.
3540
3541         * Scripts/webkitdirs.pm:
3542         (generateBuildSystemFromCMakeProject):
3543
3544 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3545
3546         [WPE] Tarballs generated with “make dist” cannot build documentation
3547         https://bugs.webkit.org/show_bug.cgi?id=195885
3548
3549         Reviewed by Carlos Garcia Campos.
3550
3551         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3552
3553 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3554
3555         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3556         https://bugs.webkit.org/show_bug.cgi?id=195883
3557
3558         Reviewed by Carlos Garcia Campos.
3559
3560         * gtkdoc/gtkdoc.py:
3561         (GTKDoc._run_command): When commands fail to run, include the full command line for
3562         the program invocation and the output it has generated on the standard error stream.
3563
3564 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3565
3566         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3567         https://bugs.webkit.org/show_bug.cgi?id=195786
3568
3569         Reviewed by Philippe Normand.
3570
3571         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3572         * wpe/jhbuild.modules: Ditto.
3573
3574 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3575
3576         [ews-build] Don't run clean builds on EWS builders
3577         https://bugs.webkit.org/show_bug.cgi?id=195851
3578
3579         Reviewed by Geoffrey Garen.
3580
3581         * BuildSlaveSupport/ews-build/factories.py:
3582
3583 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3584
3585         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3586         https://bugs.webkit.org/show_bug.cgi?id=195849
3587
3588         Reviewed by Chris Dumez.
3589
3590         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3591
3592         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3593         (runWebsiteDataStoreCustomPaths):
3594
3595 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3596
3597         webkitpy: Upload test results
3598         https://bugs.webkit.org/show_bug.cgi?id=195755
3599         <rdar://problem/48896182>
3600
3601         Reviewed by Aakash Jain.
3602
3603         Establish a new format for uploading results that is not tied to layout tests, apply
3604         that format to webkitpy tests.
3605
3606         * Scripts/webkitpy/common/checkout/scm/git.py:
3607         (Git.native_branch): Return what branch the current checkout is on.
3608         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3609         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3610         * Scripts/webkitpy/common/checkout/scm/svn.py:
3611         (SVN.native_branch): Ditto.
3612         * Scripts/webkitpy/common/system/platforminfo.py:
3613         (PlatformInfo.build_version): Return a build version for Mac.
3614         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3615         (MockPlatformInfo.__init__):
3616         (MockPlatformInfo.build_version):
3617         * Scripts/webkitpy/results: Added.
3618         * Scripts/webkitpy/results/__init__.py: Added.
3619         * Scripts/webkitpy/results/options.py: Added.
3620         (upload_options): OptParse list for upload options.
3621         * Scripts/webkitpy/results/upload.py: Added.
3622         (Upload): Class which enforces the upload format expected by the results server.
3623         (Upload.Expectations):
3624         (Upload.create_configuration):
3625         (Upload.create_commit):
3626         (Upload.create_details):
3627         (Upload.create_run_stats):
3628         (Upload.create_test_result):
3629         (Upload.__init__):
3630         (Upload.Encoder): Encode Upload object as json.
3631         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3632         * Scripts/webkitpy/results/upload_unittest.py: Added.
3633         * Scripts/webkitpy/test/main.py:
3634         (Tester._parse_args): Add upload arguments.
3635         (Tester._run_tests): Allow results to be uploaded.
3636         * Scripts/webkitpy/test/runner.py:
3637         (Runner.__init__): Record which tests were run, rather than just counting them.
3638         (Runner.handle):
3639         * Scripts/webkitpy/test/runner_unittest.py:
3640         (RunnerTest.test_run):
3641         * Scripts/webkitpy/thirdparty/__init__.py:
3642         (AutoinstallImportHook.find_module): Add requests auto-install.
3643         (AutoinstallImportHook._install_requests):
3644         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3645         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3646
3647 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3648
3649         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3650         https://bugs.webkit.org/show_bug.cgi?id=195810
3651
3652         Reviewed by Tim Horton.
3653
3654         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3655         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3656         ending certain layout tests.
3657
3658         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3659         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3660         (-[TestRunnerWKWebView dealloc]):
3661         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3662
3663         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3664         helper method when destroying the web view, and when resetting state between tests.
3665
3666         * WebKitTestRunner/ios/TestControllerIOS.mm:
3667         (WTR::TestController::platformResetStateToConsistentValues):
3668
3669         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3670
3671 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3672
3673         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3674         https://bugs.webkit.org/show_bug.cgi?id=190350
3675         <rdar://problem/45089503>
3676
3677         Reviewed by Geoffrey Garen.
3678
3679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3680         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3681         (TEST):
3682         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3683         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3684         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3685         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3686         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3687         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3688         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3689         (runTest):
3690         (createDirectories):
3691         (TEST):
3692         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3693         (TEST):
3694         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3695         (TEST):
3696
3697 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3698
3699         Add support to WebPage for getting the contents as an attributed string.
3700         https://bugs.webkit.org/show_bug.cgi?id=195636
3701         rdar://problem/45055697
3702
3703         Reviewed by Tim Horton.
3704
3705         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3706         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3707
3708 2019-03-15  Chris Dumez  <cdumez@apple.com>
3709
3710         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3711         https://bugs.webkit.org/show_bug.cgi?id=195747
3712
3713         Reviewed by Geoff Garen.
3714
3715         Add API test coverage.
3716
3717         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3718
3719 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3720
3721         Unreviewed, rolling out r242952.
3722
3723         Causing API failures on iOS Simulator
3724
3725         Reverted changeset:
3726
3727         "[PSON] Make sure the WebProcessCache is leverage when
3728         relaunching a process after termination"
3729         https://bugs.webkit.org/show_bug.cgi?id=195747
3730         https://trac.webkit.org/changeset/242952
3731
3732 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3733
3734         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3735         https://bugs.webkit.org/show_bug.cgi?id=195740
3736
3737         Reviewed by Ross Kirsling.
3738
3739         window.open doesn't work for WebKitBrowserWindow because it is not
3740         implemented yet.
3741
3742         1. Implemented createNewPage callback of WKPageUIClient.
3743         2. Changed MainWindow to take a BrowserWindow factory function
3744           instead of BrowserWindowType to be flexible to create
3745           BrowserWindow with extra settings.
3746         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3747           because it is not relevant with MainWindow anymore.
3748
3749         * MiniBrowser/win/Common.cpp:
3750         (parseCommandLine):
3751         * MiniBrowser/win/Common.h:
3752         (CommandLineOptions::CommandLineOptions):
3753         * MiniBrowser/win/MainWindow.cpp:
3754         (MainWindow::MainWindow):
3755         (MainWindow::create):
3756         (MainWindow::init):
3757         (MainWindow::WndProc):
3758         * MiniBrowser/win/MainWindow.h:
3759         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3760         (PrintWebUIDelegate::createWebViewWithRequest):
3761         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3762         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3763         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3764         (WebKitBrowserWindow::updateProxySettings):
3765         (WebKitBrowserWindow::createNewPage):
3766         * MiniBrowser/win/WebKitBrowserWindow.h:
3767         * MiniBrowser/win/WinMain.cpp:
3768         (wWinMain):
3769
3770 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3771
3772         Make it possible to test scrolling tree layer manipulation more easily
3773         https://bugs.webkit.org/show_bug.cgi?id=195780
3774
3775         Reviewed by Tim Horton.
3776         
3777         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3778         cuts off communication of scrolling tree scrolls back to the web process
3779         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3780         allows tests to trigger scrolls which run the scrolling tree layer positioning
3781         logic, but never get another commit from the web process that might mask
3782         scrolling tree bugs.
3783         
3784         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3785         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3786         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3787
3788         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3789         (WTR::UIScriptController::scrollUpdatesDisabled const):
3790         (WTR::UIScriptController::setScrollUpdatesDisabled):
3791         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3792         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3793         (WTR::UIScriptController::scrollUpdatesDisabled const):
3794         (WTR::UIScriptController::setScrollUpdatesDisabled):
3795         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3796         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3797         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3798         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3799         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3800         * WebKitTestRunner/ios/TestControllerIOS.mm:
3801         (WTR::TestController::platformResetStateToConsistentValues):
3802         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3803         (WTR::UIScriptController::scrollUpdatesDisabled const):
3804         (WTR::UIScriptController::setScrollUpdatesDisabled):
3805
3806 2019-03-14  Youenn Fablet  <youenn@apple.com>
3807
3808         Move IDB storage in private browsing mode to NetworkProcess
3809         https://bugs.webkit.org/show_bug.cgi?id=195602
3810
3811         Reviewed by Brady Eidson.
3812
3813         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3814         (TEST):
3815
3816 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3817
3818         [ews-build] Make descriptionDone messages more readable
3819         https://bugs.webkit.org/show_bug.cgi?id=195760
3820
3821         Reviewed by Lucas Forschler.
3822
3823         * BuildSlaveSupport/ews-build/steps.py:
3824         * BuildSlaveSupport/ews-build/steps_unittest.py:
3825
3826 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3827
3828         [ews-build] Generate status-bubble hover-over messages
3829         https://bugs.webkit.org/show_bug.cgi?id=195680
3830
3831         Reviewed by Lucas Forschler.
3832
3833         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3834         (StatusBubble):
3835         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3836         on hover-over.
3837         (StatusBubble._iso_time):
3838         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3839         hover-over message.
3840         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3841
3842 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3843
3844         [ews-app] Gracefully handle the case when state_string is None
3845         https://bugs.webkit.org/show_bug.cgi?id=195753
3846
3847         Reviewed by Lucas Forschler.
3848
3849         * BuildSlaveSupport/ews-app/ews/models/build.py:
3850         * BuildSlaveSupport/ews-app/ews/models/step.py:
3851
3852 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3853
3854         [ews-app] Status bubble display pending for currently running build step
3855         https://bugs.webkit.org/show_bug.cgi?id=195744
3856
3857         Reviewed by Lucas Forschler.
3858
3859         * BuildSlaveSupport/ews-build/events.py:
3860         (Events.stepStarted): If state_string is pending, replace it with step name.
3861
3862 2019-03-14  Chris Dumez  <cdumez@apple.com>
3863
3864         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3865         https://bugs.webkit.org/show_bug.cgi?id=195750
3866
3867         Reviewed by Geoffrey Garen.
3868
3869         Add API test coverage.
3870
3871         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3872         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3873         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3874         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3875
3876 2019-03-14  Chris Dumez  <cdumez@apple.com>
3877
3878         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3879         https://bugs.webkit.org/show_bug.cgi?id=195747
3880
3881         Reviewed by Geoff Garen.
3882
3883         Add API test coverage.
3884
3885         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3886
3887 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3888
3889         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3890         https://bugs.webkit.org/show_bug.cgi?id=195725
3891         <rdar://problem/48545062>
3892
3893         Reviewed by Tim Horton.
3894
3895         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3896         handler is nil.
3897
3898         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3899         (TestWebKitAPI::TEST):
3900
3901 2019-03-13  Sam Weinig  <sam@webkit.org>
3902
3903         Add utility function to allow easy reverse range-based iteration of a container
3904         https://bugs.webkit.org/show_bug.cgi?id=195542
3905
3906         Reviewed by Antti Koivisto.
3907
3908         * TestWebKitAPI/CMakeLists.txt:
3909         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3910         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3911         (TestWebKitAPI::TEST):
3912         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3913
3914 2019-03-13  Chris Dumez  <cdumez@apple.com>
3915
3916         Use a ServiceWorker process per registrable domain
3917         https://bugs.webkit.org/show_bug.cgi?id=195649
3918
3919         Reviewed by Youenn Fablet.
3920
3921         Update API test coverage.
3922
3923         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3924
3925 2019-03-13  Chris Dumez  <cdumez@apple.com>
3926
3927         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3928         https://bugs.webkit.org/show_bug.cgi?id=195684
3929         <rdar://problem/48294714>
3930
3931         Reviewed by Antti Koivisto.
3932
3933         Add API test coverage.
3934
3935         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3936
3937 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3938
3939         [ews-app] Remove unused patch view
3940         https://bugs.webkit.org/show_bug.cgi?id=195669
3941
3942         Reviewed by Lucas Forschler.
3943
3944         * BuildSlaveSupport/ews-app/ews/urls.py:
3945         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3946
3947 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3948
3949         [ews-app] Use Buildbot result code variables
3950         https://bugs.webkit.org/show_bug.cgi?id=195668
3951
3952         Reviewed by Alexey Proskuryakov.
3953
3954         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3955         (Buildbot): Added Buildbot result code variables.
3956         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3957         (StatusBubble._build_bubble): Used Buildbot result code variables.
3958
3959 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3960
3961         [Flatpak] Expand submodule recursively
3962         https://bugs.webkit.org/show_bug.cgi?id=195672
3963
3964         Building WPE with flatpak was impossible without that as it was raising an exception.
3965         Also update wpebackend-fdo to match what is built in jhbuild
3966
3967         Reviewed by Philippe Normand.
3968
3969         * flatpak/flatpakutils.py:
3970         (expand_submodules_recurse):
3971         (expand_manifest):
3972         * flatpak/org.webkit.WPEModules.yaml:
3973
3974 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3975
3976         [ews-app] status bubble should be hidden for certain builds
3977         https://bugs.webkit.org/show_bug.cgi?id=194597
3978
3979         Reviewed by Dewei Zhu.
3980
3981         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3982         (StatusBubble._build_bubble):
3983         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3984         because the patch didn't have relevant changes.
3985         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3986         in production yet.
3987
3988 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3989
3990         [Win] Fix a slew of simple clang-cl warnings.
3991         https://bugs.webkit.org/show_bug.cgi?id=195652
3992
3993         Reviewed by Don Olmstead.
3994
3995         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3996         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3997
3998 2019-03-12  Justin Fan  <justin_fan@apple.com>
3999
4000         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
4001         https://bugs.webkit.org/show_bug.cgi?id=195518
4002         <rdar://problem/46322356>
4003
4004         Reviewed by Myles C. Maxfield.
4005
4006         * DumpRenderTree/DerivedSources-input.xcfilelist:
4007         * DumpRenderTree/DerivedSources-output.xcfilelist:
4008
4009 2019-03-12  Commit Queue  <commit-queue@webkit.org>
4010
4011         Unreviewed, rolling out r242825.
4012         https://bugs.webkit.org/show_bug.cgi?id=195648
4013
4014         "Broke webkitpy tests with my change to
4015         lldb_dump_class_layout.py" (Requested by rmorisset on
4016         #webkit).
4017
4018         Reverted changeset:
4019
4020         "Alter Tools/Scripts/dump-class-layout to be able to dump all
4021         classes with suspicious padding"
4022         https://bugs.webkit.org/show_bug.cgi?id=195573
4023         https://trac.webkit.org/changeset/242825
4024
4025 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4026
4027         [ews-build] Show status bubbles while the patch is waiting in queue
4028         https://bugs.webkit.org/show_bug.cgi?id=195618
4029
4030         Reviewed by Lucas Forschler.
4031
4032         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4033         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
4034         enabled in initial deployment.
4035         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
4036         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
4037         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
4038         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
4039         (StatusBubble._build_bubbles_for_patch):
4040
4041 2019-03-12  Robin Morisset  <rmorisset@apple.com>
4042
4043         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
4044         https://bugs.webkit.org/show_bug.cgi?id=195573
4045
4046         Reviewed by Simon Fraser.
4047
4048         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
4049
4050         * Scripts/dump-class-layout:
4051         (main):
4052         * lldb/lldb_dump_class_layout.py:
4053         (ClassLayout.__init__):
4054         (ClassLayout._compute_padding_recursive):
4055         (LLDBDebuggerInstance.dump_layout_for_classname):
4056         (LLDBDebuggerInstance):
4057         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
4058         (LLDBDebuggerInstance.layout_for_classname): Deleted.
4059
4060 2019-03-12  Chris Dumez  <cdumez@apple.com>
4061
4062         Device Orientation access permission should be denied unless explicitly granted by the client
4063         https://bugs.webkit.org/show_bug.cgi?id=195625
4064
4065         Reviewed by Youenn Fablet.
4066
4067         add API test coverage.
4068
4069         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4070         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
4071         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
4072         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
4073         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4074         (runDeviceOrientationTest):
4075         (TEST):
4076         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4077         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4078
4079 2019-03-12  Jer Noble  <jer.noble@apple.com>
4080
4081         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
4082         https://bugs.webkit.org/show_bug.cgi?id=195137
4083         <rdar://problem/48810307>
4084
4085         Reviewed by Eric Carlson.
4086
4087         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
4088         (TestWebKitAPI::TEST):
4089
4090 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4091
4092         [ews-build] Change urls from uat to production
4093         https://bugs.webkit.org/show_bug.cgi?id=195566
4094
4095         Reviewed by Lucas Forschler.
4096
4097         * BuildSlaveSupport/ews-app/ews/config.py:
4098         * BuildSlaveSupport/ews-build/events.py:
4099         * BuildSlaveSupport/ews-build/steps.py:
4100
4101 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4102
4103         [ews-build] change max_builds for local-worker to 1
4104         https://bugs.webkit.org/show_bug.cgi?id=195568
4105
4106         Reviewed by Lucas Forschler.
4107
4108         * BuildSlaveSupport/ews-build/loadConfig.py:
4109
4110 2019-03-12  Tim Horton  <timothy_horton@apple.com>
4111
4112         Fix the build
4113
4114         * TestRunnerShared/spi/PencilKitTestSPI.h:
4115         * TestWebKitAPI/ios/PencilKitTestSPI.h:
4116
4117 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
4118
4119         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
4120         https://bugs.webkit.org/show_bug.cgi?id=194131
4121
4122         Reviewed by Michael Catanzaro.
4123
4124         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4125         (uriChanged):
4126         (testUnfinishedSubresourceLoad):
4127         (serverCallback):
4128         (beforeAll):
4129
4130 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4131
4132         WTF::Expected should use std::addressof instead of operator&
4133         https://bugs.webkit.org/show_bug.cgi?id=195604
4134
4135         Reviewed by Myles Maxfield.
4136
4137         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4138         (TestWebKitAPI::Unique::Unique):
4139         (TestWebKitAPI::Unique::operator&):
4140         (TestWebKitAPI::TEST):
4141
4142 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
4143
4144         Add Optional to Forward.h.
4145         https://bugs.webkit.org/show_bug.cgi?id=195586
4146
4147         Reviewed by Darin Adler.
4148
4149         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
4150         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
4151         Remove unnecessary includes from headers.
4152
4153 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
4154
4155         Add testing API to hit-test and scroll overflow scrollers
4156         https://bugs.webkit.org/show_bug.cgi?id=195278
4157
4158         Reviewed by Antti Koivisto.
4159         
4160         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
4161         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
4162         
4163         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
4164
4165         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4166         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4167         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4168         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4169         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4170         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4171         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4172         (WTR::enclosingScrollViewIncludingSelf):
4173         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4174
4175 2019-03-11  Tim Horton  <timothy_horton@apple.com>
4176
4177         API test WebKit.RequestTextInputContext fails on iOS
4178         https://bugs.webkit.org/show_bug.cgi?id=195585
4179
4180         Reviewed by Wenson Hsieh and Simon Fraser.
4181
4182         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4183         (applyStyle):
4184         (TEST):
4185         Add a viewport, so that the coordinates match up on iOS.
4186         Scroll by moving the UIScrollView's contentOffset.
4187
4188 2019-03-11  Chris Dumez  <cdumez@apple.com>
4189
4190         Assert in WebPageProxy::suspendCurrentPageIfPossible()
4191         https://bugs.webkit.org/show_bug.cgi?id=195506
4192         <rdar://problem/48733477>
4193
4194         Reviewed by Alex Christensen.
4195
4196         Add API test coverage.
4197
4198         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4199
4200 2019-03-11  Shawn Roberts  <sroberts@apple.com>
4201
4202         Adding myself to contributors.json
4203
4204         Unreviewed, addming myself to contributors.json .
4205
4206         * Scripts/webkitpy/common/config/contributors.json:
4207
4208 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4209
4210         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
4211         https://bugs.webkit.org/show_bug.cgi?id=195511
4212         <rdar://problem/44873269>
4213
4214         Reviewed by Darin Adler.
4215
4216         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
4217         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
4218         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
4219         (TEST_F):
4220
4221 2019-03-11  Chris Dumez  <cdumez@apple.com>
4222
4223         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
4224         https://bugs.webkit.org/show_bug.cgi?id=195561
4225
4226         Reviewed by Youenn Fablet.
4227
4228         Make sure the JS in the test requests for permission to receive device orientation events.
4229
4230         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4231
4232 2019-03-11  Youenn Fablet  <youenn@apple.com>
4233
4234         Allow storage quota increase by default in WTR
4235         https://bugs.webkit.org/show_bug.cgi?id=195541
4236
4237         Reviewed by Geoffrey Garen.
4238
4239         Allow storage quota increase by default in WTR.
4240         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
4241         Use this for tests that explicitly need cache increase.
4242
4243         Instead of increasing quota by 2, make sure the next request is
4244         granted by adding all given parameters.
4245
4246         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4247         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4248         (WTR::TestRunner::setAllowStorageQuotaIncrease):
4249         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
4250         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4251         * WebKitTestRunner/TestController.cpp:
4252         (WTR::TestController::setAllowStorageQuotaIncrease):
4253         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
4254         * WebKitTestRunner/TestController.h:
4255         * WebKitTestRunner/TestInvocation.cpp:
4256         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4257         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4258         (WTR::TestController::cocoaResetStateToConsistentValues):
4259         (WTR::TestController::setAllowStorageQuotaIncrease):
4260         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
4261         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4262         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4263
4264 2019-03-11  Xan Lopez  <xan@igalia.com>
4265
4266         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
4267         https://bugs.webkit.org/show_bug.cgi?id=194147
4268
4269         Reviewed by Michael Saboff.
4270
4271         To make --32-bit work correctly on Linux/64bit we need to:
4272
4273         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
4274         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
4275         unfortunately CMake only allows us to do this during
4276         crosscompilation, which is overkill here.
4277         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
4278         pkg-config detection module uses the x86 .pc files instead of the
4279         x86_64 ones.
4280         - Set the -m32 flags for the compiler.
4281
4282         * Scripts/webkitdirs.pm:
4283         (generateBuildSystemFromCMakeProject):
4284
4285 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
4286
4287         Add MotionMark-1.1 plan file for run-benchmark script.
4288         https://bugs.webkit.org/show_bug.cgi?id=195481
4289
4290         Rubber-stamped by Darin Adler.
4291
4292         Run-benchmark script should support MontionMark-1.1.
4293
4294         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
4295
4296 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
4297
4298         [ews-app] Add support for submit-to-ews url
4299         https://bugs.webkit.org/show_bug.cgi?id=195477
4300
4301         Reviewed by Lucas Forschler.
4302
4303         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4304         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
4305         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
4306         * BuildSlaveSupport/ews-app/ews/urls.py:
4307         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
4308
4309 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
4310
4311         Unreviewed, rolling out r242688, r242643, r242624.
4312
4313         Caused multiple layout test failures and crashes on iOS and macOS.
4314
4315         Reverted changeset:
4316
4317         "requestAnimationFrame should execute before the next frame"
4318         https://bugs.webkit.org/show_bug.cgi?id=177484
4319         https://trac.webkit.org/changeset/242624/webkit
4320