Detach frame from document when entering page cache
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-10  Daniel Bates  <dabates@apple.com>
2
3         Detach frame from document when entering page cache
4         https://bugs.webkit.org/show_bug.cgi?id=166774
5         <rdar://problem/29904368>
6
7         Reviewed by Chris Dumez.
8
9         * DumpRenderTree/mac/DumpRenderTree.mm:
10         (resetWebPreferencesToConsistentValues):
11         * DumpRenderTree/win/DumpRenderTree.cpp:
12         (resetWebPreferencesToConsistentValues):
13         * WebKitTestRunner/TestController.cpp:
14         (WTR::TestController::resetPreferencesToConsistentValues):
15
16 2017-02-10  Tim Horton  <timothy_horton@apple.com>
17
18         Infinite UI process hang under ensurePositionInformationIsUpToDate
19         https://bugs.webkit.org/show_bug.cgi?id=168154
20         <rdar://problem/30428673>
21
22         Reviewed by Simon Fraser.
23
24         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
26         (recursiveFindHighlightLongPressRecognizer):
27         (TEST):
28         Add a somewhat nasty test that does an async interaction information update, but
29         kills the Web process before it arrives, and then does a sync interaction
30         information update, which will wait for the oustanding async interaction
31         information update if we still think it's coming. Before the patch, this
32         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
33
34 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
35
36         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
37         https://bugs.webkit.org/show_bug.cgi?id=168127
38         rdar://problem/30467120
39
40         Reviewed by Tim Horton.
41
42         Reparent the web view before we try to fetch it via:
43             [[[window contentView] subviews] objectAtIndex:0];
44         which would throw an exception if the test unparented it.
45
46         * DumpRenderTree/mac/DumpRenderTree.mm:
47         (resetWebViewToConsistentStateBeforeTesting):
48         (runTest):
49
50 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
51
52         [Resource Timing] Enable Resource Timing by default in Tests
53         https://bugs.webkit.org/show_bug.cgi?id=168145
54
55         Reviewed by Ryosuke Niwa.
56
57         * DumpRenderTree/mac/DumpRenderTree.mm:
58         (resetWebPreferencesToConsistentValues):
59         * DumpRenderTree/win/DumpRenderTree.cpp:
60         (resetWebPreferencesToConsistentValues):
61         * WebKitTestRunner/TestController.cpp:
62         (WTR::TestController::resetPreferencesToConsistentValues):
63
64 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
65
66         Removing LayoutTestRelay
67         https://bugs.webkit.org/show_bug.cgi?id=165927
68
69         Reviewed by Daniel Bates.
70         Part 2
71
72         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
73         simulators through simctl (iOS 10 and later), use this functionality instead.
74
75         * BuildSlaveSupport/built-product-archive:
76         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
77         Added a FIXME that we will need to implement similar archiving machinery once we build
78         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
79         * BuildSlaveSupport/kill-old-processes:
80         (main): Remove LayoutTestRelay from list of processes.
81         * LayoutTestRelay: Removed LayoutTestRelay.
82         * Makefile:
83         * Scripts/build-layouttestrelay: Removed.
84         * Scripts/build-webkit: Removed LayoutTestRelay references.
85
86 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
87
88         [WebCrypto] Add WebCryptoAPI to watchlist
89         https://bugs.webkit.org/show_bug.cgi?id=168138
90
91         Reviewed by Youenn Fablet.
92
93         * Scripts/webkitpy/common/config/watchlist:
94
95 2017-02-10  Brady Eidson  <beidson@apple.com>
96
97         Replace all WebKit Library Version checks in WK2 with SDK version checks.
98         https://bugs.webkit.org/show_bug.cgi?id=168124
99
100         Reviewed by Geoffrey Garen.
101
102         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
103         
104         * MiniBrowser/mac/main.m:
105         (main):
106         * MobileMiniBrowser/MobileMiniBrowser/main.m:
107         (main):
108         * TestWebKitAPI/ios/mainIOS.mm:
109         (main):
110         * TestWebKitAPI/mac/mainMac.mm:
111         (main):
112         * WebKitTestRunner/ios/mainIOS.mm:
113         (main):
114         * WebKitTestRunner/mac/main.mm:
115         (setDefaultsToConsistentValuesForTesting):
116
117 2017-02-10  Alex Christensen  <achristensen@webkit.org>
118
119         Fix El Capitan build.
120
121         * Scripts/build-webkit:
122         Don't build libwebrtc anywhere for now.
123
124 2017-02-10  Andy Estes  <aestes@apple.com>
125
126         Move two MiniBrowserBundle settings out of the .pbxproj
127         https://bugs.webkit.org/show_bug.cgi?id=168106
128
129         Reviewed by Tim Horton.
130
131         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
132         the project file. This removes the project file override.
133
134         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
135
136         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
137         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
138
139 2017-02-10  Alex Christensen  <achristensen@webkit.org>
140
141         Fix 32-and-64-bit build on El Capitan.
142
143         * Scripts/build-webkit:
144         Somebody's building with something like this:
145         build-webkit ARCHS="i386 x86_64"
146         We want this to also not build libwebrtc for now.
147
148 2017-02-10  Alex Christensen  <achristensen@webkit.org>
149
150         Fix 32-bit build on El Capitan.
151
152         * Scripts/build-webkit:
153         The bot uses ARCHS=i386 instead of --32-bit.
154         This is a hack, but it should fix the bot until I can do a better fix in the morning.
155
156 2017-02-10  Alex Christensen  <achristensen@webkit.org>
157
158         Fix 32-bit build on El Capitan.
159
160         * Scripts/build-webkit:
161         Don't build i386 libwebrtc.
162
163 2017-02-09  Alex Christensen  <achristensen@webkit.org>
164
165         Unreviewed, rolling out r212040.
166
167         Broke build.  I'm not surprised
168
169         Reverted changeset:
170
171         "[WebRTC][Mac] Activate libwebrtc"
172         https://bugs.webkit.org/show_bug.cgi?id=167293
173         http://trac.webkit.org/changeset/212040
174
175 2017-02-09  Alex Christensen  <achristensen@webkit.org>
176
177         Build libwebrtc on bots without using it yet
178         https://bugs.webkit.org/show_bug.cgi?id=168062
179
180         Reviewed by Brent Fulgham.
181
182         * Scripts/build-webkit:
183
184 2017-02-09  Alex Christensen  <achristensen@webkit.org>
185
186         Don't build libwebrtc.
187
188         * Scripts/build-webkit:
189         Not ready yet.  It broke El Capitan and iOS.
190
191 2017-02-09  Alex Christensen  <achristensen@webkit.org>
192
193         Build libwebrtc on bots without using it yet
194         https://bugs.webkit.org/show_bug.cgi?id=168062
195
196         Reviewed by Brent Fulgham.
197
198         * Scripts/build-webkit:
199
200 2017-02-09  Alex Christensen  <achristensen@webkit.org>
201
202         Rename isAppleMacWebKit to isAppleCocoaWebKit
203         https://bugs.webkit.org/show_bug.cgi?id=168075
204
205         Reviewed by Geoffrey Garen.
206
207         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
208
209         * Scripts/build-api-tests:
210         * Scripts/build-dumprendertree:
211         * Scripts/build-jsc:
212         (buildMyProject):
213         * Scripts/build-layouttestrelay:
214         * Scripts/build-webkit:
215         * Scripts/build-webkittestrunner:
216         * Scripts/run-api-tests:
217         (isSupportedPlatform):
218         (runTest):
219         (listAllTests):
220         (prepareEnvironmentForRunningTestTool):
221         * Scripts/run-content-extension-tester:
222         * Scripts/run-javascriptcore-tests:
223         * Scripts/run-minibrowser:
224         * Scripts/show-pretty-diff:
225         * Scripts/webkitdirs.pm:
226         (determineBaseProductDir):
227         (determineArchitecture):
228         (determinePassedArchitecture):
229         (safariPath):
230         (builtDylibPathForName):
231         (checkFrameworks):
232         (isAppleWebKit):
233         (isAppleCocoaWebKit):
234         (determineNmPath):
235         (launcherName):
236         (wrapperPrefixIfNeeded):
237         (isCMakeBuild):
238         (mobileSafariBundle):
239         (debugSafari):
240         (runSafari):
241         (runMiniBrowser):
242         (debugMiniBrowser):
243         (runWebKitTestRunner):
244         (debugWebKitTestRunner):
245         (isAppleMacWebKit): Deleted.
246         * Scripts/webkitperl/FeatureList.pm:
247
248 2017-02-09  Alex Christensen  <achristensen@webkit.org>
249
250         Revert r211991
251         https://bugs.webkit.org/show_bug.cgi?id=168062
252
253         * Scripts/build-webkit:
254         Not quite ready yet.
255
256 2017-02-09  Alex Christensen  <achristensen@webkit.org>
257
258         Build libwebrtc on bots without using it yet
259         https://bugs.webkit.org/show_bug.cgi?id=168062
260
261         Reviewed by Brent Fulgham.
262
263         * Scripts/build-webkit:
264         Build libwebrtc on Mac when we build ANGLE.
265
266 2017-02-09  Youenn Fablet  <youenn@apple.com>
267
268         Improve W3C importer command line options
269         https://bugs.webkit.org/show_bug.cgi?id=167448
270
271         Reviewed by Ryosuke Niwa.
272
273         Making the list of test paths to import the main arguments of the script.
274         Allow passing the source directory to import as a -s option.
275         Adding a warning when given test paths are skipped by default in ImportExpectations.
276
277         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
278         Link conversion rules do not change when imported tests are downloaded by the script.
279
280         * Scripts/webkitpy/w3c/test_importer.py:
281         (main):
282         (parse_args):
283         (TestImporter.__init__):
284         (TestImporter.do_import):
285         (TestImporter):
286         (TestImporter.check_imported_expectations):
287
288 2017-02-08  Chris Dumez  <cdumez@apple.com>
289
290         Update web-platform-tests resources
291         https://bugs.webkit.org/show_bug.cgi?id=168026
292
293         Reviewed by Youenn Fablet.
294
295         Stop copying testharness.js from resources/ to web-platform-tests/resources.
296
297         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
298         (WebPlatformTestServer._copy_webkit_test_files):
299
300 2017-02-08  Andy Estes  <aestes@apple.com>
301
302         Custom protocols should not continue loading after a network process crash
303         https://bugs.webkit.org/show_bug.cgi?id=168028
304         <rdar://problem/27607520>
305
306         Reviewed by Brady Eidson.
307
308         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
309         (processGroup):
310         (-[CloseWhileStartingProtocol startLoading]):
311         (-[CloseWhileStartingProtocol stopLoading]):
312         (TestWebKitAPI::runTest):
313         (TestWebKitAPI::TEST):
314
315 2017-02-08  Dan Bernstein  <mitz@apple.com>
316
317         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
318         https://bugs.webkit.org/show_bug.cgi?id=168031
319
320         Reviewed by Tim Horton.
321
322         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
323         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
324         (TEST):
325         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
326         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
327
328 2017-02-08  Chris Dumez  <cdumez@apple.com>
329
330         Use smaller tiles in windows that are not active to facilitate App Napping
331         https://bugs.webkit.org/show_bug.cgi?id=167997
332         <rdar://problem/30358835>
333
334         Reviewed by Simon Fraser.
335
336         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
337         (WTR::PlatformWebView::setWindowIsKey):
338         Actually update windowIsKey state of NSWindow so the WebView
339         properly updates its activity state.
340
341 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
342
343         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
344         https://bugs.webkit.org/show_bug.cgi?id=167942
345         <rdar://problem/30315079>
346
347         Reviewed by Tim Horton.
348
349         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
350         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
351         contenteditable in these cases.
352
353         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
354         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
355         performDragOperation:) directly.
356
357         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
358         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
359         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
360         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
361         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
362         (-[DragSource draggingSourceOperationMaskForLocal:]):
363         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
364         (-[DragInfo lastMousePosition]):
365         (-[DragInfo setLastMousePosition:]):
366         (-[DragInfo draggingDestinationWindow]):
367         (-[DragInfo draggingSourceOperationMask]):
368         (-[DragInfo draggingLocation]):
369         (-[DragInfo draggedImageLocation]):
370         (-[DragInfo draggedImage]):
371         (-[DragInfo draggingPasteboard]):
372         (-[DragInfo draggingSource]):
373         (-[DragInfo draggingSequenceNumber]):
374         (-[DragInfo slideDraggedImageTo:]):
375         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
376         (-[DragInfo draggingFormation]):
377         (-[DragInfo setDraggingFormation:]):
378         (-[DragInfo animatesToDestination]):
379         (-[DragInfo setAnimatesToDestination:]):
380         (-[DragInfo numberOfValidItemsForDrop]):
381         (-[DragInfo setNumberOfValidItemsForDrop:]):
382         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
383         (-[DragInfo springLoadingHighlight]):
384         (-[DragInfo resetSpringLoading]):
385         (TestWebKitAPI::getTestImage):
386         (TestWebKitAPI::webViewAfterPerformingDragOperation):
387         (TestWebKitAPI::TEST):
388         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
389
390 2017-02-08  Jer Noble  <jer.noble@apple.com>
391
392         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
393         https://bugs.webkit.org/show_bug.cgi?id=168007
394
395         Reviewed by Alex Christensen.
396
397         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
398         (didFinishLoadForFrame):
399         (TestWebKitAPI::TEST):
400
401 2017-02-08  Commit Queue  <commit-queue@webkit.org>
402
403         Unreviewed, rolling out r211873.
404         https://bugs.webkit.org/show_bug.cgi?id=168001
405
406         It's in jhbuild for consistent layout tests (Requested by
407         mcatanzaro on #webkit).
408
409         Reverted changeset:
410
411         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
412         https://bugs.webkit.org/show_bug.cgi?id=167993
413         http://trac.webkit.org/changeset/211873
414
415 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
416
417         [GTK] Add icu packages to Tools/gtk/install-dependencies
418         https://bugs.webkit.org/show_bug.cgi?id=167993
419
420         Reviewed by Michael Catanzaro.
421
422         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
423         depending in the GNU/Linux distribution)
424
425 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
426
427         Update flakiness dashboard configuration.
428         https://bugs.webkit.org/show_bug.cgi?id=167957
429
430         Reviewed by Alexey Proskuryakov.
431
432         * TestResultServer/static-dashboards/builders.jsonp:
433
434 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
435
436         Replace a bot that has an incorrect configuration.
437         https://bugs.webkit.org/show_bug.cgi?id=167747
438
439         Rubber-stamped by Alexey Proskuryakov.
440
441         * BuildSlaveSupport/build.webkit.org-config/config.json:
442
443 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
444
445         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
446         https://bugs.webkit.org/show_bug.cgi?id=167927
447
448         Reviewed by Brent Fulgham.
449
450         Enable ComplexTextController API tests on the Win and GTK ports.
451
452         * TestWebKitAPI/PlatformGTK.cmake:
453         * TestWebKitAPI/PlatformWin.cmake:
454
455 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
456
457         File index appended to previous file in svn-create-patch with SVN 1.9
458         https://bugs.webkit.org/show_bug.cgi?id=167903
459         <rdar://problem/30387395>
460
461         Reviewed by Daniel Bates.
462
463         * Scripts/VCSUtils.pm:
464         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
465         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
466         trailing newline character from the expected result before comparing it to the actual result.
467
468 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
469
470         [webkitdirs] remove unused host_processor variable in determineArchitecture()
471         https://bugs.webkit.org/show_bug.cgi?id=167936
472
473         Reviewed by Michael Catanzaro.
474
475         * Scripts/webkitdirs.pm:
476         (determineArchitecture):
477         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
478         since r195083.
479
480 2017-02-07  Youenn Fablet  <youenn@apple.com>
481
482         Use a JSON file to define which WPT files/folders to import
483         https://bugs.webkit.org/show_bug.cgi?id=167923
484
485         Reviewed by Alex Christensen.
486
487         * Scripts/webkitpy/w3c/test_downloader.py:
488         (TestDownloader.__init__):
489         (TestDownloader._init_paths_from_expectations):
490         * Scripts/webkitpy/w3c/test_importer.py:
491         (parse_args):
492         * Scripts/webkitpy/w3c/test_importer_unittest.py:
493
494 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
495
496         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
497         https://bugs.webkit.org/show_bug.cgi?id=167916
498
499         Reviewed by Carlos Garcia Campos.
500
501         URL of mesa-11.0.6.tar.xz has been moved.
502
503         * gtk/jhbuild.modules: Fix the module path.
504
505 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
506
507         Static Analyzer: Address some leaks in MiniBrowser
508         https://bugs.webkit.org/show_bug.cgi?id=167897
509
510         Reviewed by Alexey Proskuryakov.
511
512         * MiniBrowser/mac/BrowserWindowController.m:
513         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
514         * MiniBrowser/mac/ExtensionManagerWindowController.m:
515         (-[ExtensionManagerWindowController add:]):
516         (-[ExtensionManagerWindowController remove:]):
517         * MiniBrowser/mac/SettingsController.m:
518         (-[SettingsController _populateMenu]):
519         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
520         Address obvious leaks caught by the static analyzer.
521
522 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
523
524         Migrate ComplexTextController to use platform-independent types
525         https://bugs.webkit.org/show_bug.cgi?id=167833
526
527         Reviewed by Brent Fulgham.
528
529         Migrate tests away from platform-dependent types.
530
531         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
532         (TestWebKitAPI::TEST_F):
533
534 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
535
536         Correct File Path Handling in SecurityOrigin and FileSystem
537         https://bugs.webkit.org/show_bug.cgi?id=167894
538         <rdar://problem/30380080>
539
540         Reviewed by Alexey Proskuryakov.
541
542         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
543         and perform same-volume checks using filesystem-compatible paths.        
544         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
545         filesystem paths, and perform validation of same-volume checks.
546         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
547         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
548         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
549         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
550
551 2017-02-06  Jer Noble  <jer.noble@apple.com>
552
553         Playback stalls when a SourceBuffer append causes frame eviction
554         https://bugs.webkit.org/show_bug.cgi?id=167834
555
556         Reviewed by Eric Carlson.
557
558         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
559         for the WTF::MediaTime class.
560
561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
562         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
563         (TestWebKitAPI::TEST):
564         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
565         (WTF::operator<<):
566         (TestWebKitAPI::TestSample::create):
567         (TestWebKitAPI::TestSample::TestSample):
568         (TestWebKitAPI::TEST_F):
569
570 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
571
572         Change capitalization in platform name after r211735.
573
574         Unreviewed dashboard fix.
575
576         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
577         (WebKitBuildbot):
578
579 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
580
581         Move the Leaks bot to Sierra
582         https://bugs.webkit.org/show_bug.cgi?id=167886
583
584         Reviewed by Daniel Bates.
585
586         * BuildSlaveSupport/build.webkit.org-config/config.json:
587         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
588         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
589         (LeaksViewer._displayURLPrompt):
590         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
591         (WebKitBuildbot):
592
593 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
594
595         Prevent app crash on launch during simctl install workaround
596         https://bugs.webkit.org/show_bug.cgi?id=167685
597
598         Reviewed by Daniel Bates.
599
600         * Scripts/webkitpy/port/simulator_process.py:
601         (SimulatorProcess.__init__): Pass environment to install.
602         * Scripts/webkitpy/xcode/simulator.py:
603         (Device.install_app): Accept environment, pass environment to launch.
604
605 2017-02-06  Alex Christensen  <achristensen@webkit.org>
606
607         Rebase API tests after r211638
608         https://bugs.webkit.org/show_bug.cgi?id=167779
609
610         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
611         (TestWebKitAPI::TEST_F):
612         URLs with non-special schemes and characters like % in the host now fail to parse,
613         more like their special counterparts and according to spec.
614
615 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
616
617         Unreviewed trivial fix after r211697.
618         https://bugs.webkit.org/show_bug.cgi?id=167863
619
620         * Scripts/run-javascriptcore-tests:
621         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
622
623 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
624
625         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
626         https://bugs.webkit.org/show_bug.cgi?id=167850
627
628         Reviewed by Tim Horton.
629
630         * DumpRenderTree/TestRunner.cpp:
631         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
632
633 2017-02-04  Andreas Kling  <akling@apple.com>
634
635         Plug some leaks in TestController and UIScriptContext.
636         <https://webkit.org/b/167839>
637
638         Reviewed by Alexey Proskuryakov.
639
640         Fix a couple of the leaks seen on the leaks bot.
641
642         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
643         (UIScriptContext::runUIScript):
644         * WebKitTestRunner/TestController.cpp:
645         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
646         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
647
648 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
649
650         WK1 mouse events are missing movementX and movementY for pointerlock.
651         https://bugs.webkit.org/show_bug.cgi?id=167775
652         rdar://problem/30343810
653
654         Reviewed by Alexey Proskuryakov.
655
656         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
657
658         * DumpRenderTree/mac/EventSendingController.mm:
659         (-[EventSendingController mouseMoveToX:Y:]):
660         * WebKitTestRunner/mac/EventSenderProxy.mm:
661         (WTR::EventSenderProxy::mouseMoveTo):
662
663 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
664
665         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
666         https://bugs.webkit.org/show_bug.cgi?id=167774
667
668         Reviewed by Tim Horton.
669
670         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
671         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
672         web process are async, so the callback fires after the web process gets the new state.
673
674         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
675         (WTR::UIScriptController::removeViewFromWindow):
676         (WTR::UIScriptController::addViewToWindow):
677         * DumpRenderTree/mac/DumpRenderTree.mm:
678         (createWebViewAndOffscreenWindow):
679         (resetWebViewToConsistentStateBeforeTesting):
680         * DumpRenderTree/mac/DumpRenderTreeMac.h:
681         * DumpRenderTree/mac/UIScriptControllerMac.mm:
682         (WTR::UIScriptController::removeViewFromWindow):
683         (WTR::UIScriptController::addViewToWindow):
684         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
685         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
686         (WTR::UIScriptController::removeViewFromWindow):
687         (WTR::UIScriptController::addViewToWindow):
688         * TestRunnerShared/UIScriptContext/UIScriptController.h:
689         * WebKitTestRunner/PlatformWebView.h:
690         * WebKitTestRunner/TestController.cpp:
691         (WTR::TestController::resetStateToConsistentValues):
692         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
693         (WTR::PlatformWebView::removeFromWindow):
694         (WTR::PlatformWebView::addToWindow):
695         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
696         (WTR::UIScriptController::removeViewFromWindow):
697         (WTR::UIScriptController::addViewToWindow):
698         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
699         (WTR::PlatformWebView::removeFromWindow):
700         (WTR::PlatformWebView::addToWindow):
701         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
702         (WTR::UIScriptController::removeViewFromWindow):
703         (WTR::UIScriptController::addViewToWindow):
704
705 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
706
707         Remove check for SkipSafariExecutableEntitlementChecks
708         https://bugs.webkit.org/show_bug.cgi?id=167762
709
710         Reviewed by Dan Bernstein.
711
712         Follow-up fix: don't break internal behavior.
713
714         * Scripts/webkitdirs.pm:
715         (safariPath):
716         (executableHasEntitlements): Deleted.
717         (safariPathFromSafariBundle): Deleted.
718         (installedSafariPath): Deleted.
719
720 2017-02-03  Daniel Bates  <dabates@apple.com>
721
722         [Mac][WK2] Add SPI to override the Content Security Policy of a page
723         https://bugs.webkit.org/show_bug.cgi?id=167810
724         <rdar://problem/30102568>
725
726         Reviewed by Anders Carlsson.
727
728         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
729
730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
731         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
732         (TEST):
733         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
734         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
735         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
736         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
737
738 2017-02-02  Alex Christensen  <achristensen@webkit.org>
739
740         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
741         https://bugs.webkit.org/show_bug.cgi?id=167773
742         <rdar://problem/30221102>
743
744         Reviewed by Ryosuke Niwa.
745
746         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
747         (TestWebKitAPI::TEST_F):
748
749 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
750
751         Remove check for SkipSafariExecutableEntitlementChecks
752         https://bugs.webkit.org/show_bug.cgi?id=167762
753         rdar://problem/22480673
754
755         Reviewed by Dan Bernstein.
756
757         * Scripts/webkitdirs.pm:
758         (safariPathFromSafariBundle):
759         (skipSafariExecutableEntitlementChecks): Deleted.
760
761 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
762
763         Undefined subroutine in svn-create-patch
764         https://bugs.webkit.org/show_bug.cgi?id=167742
765
766         Unreviewed build-fix after r211543.
767
768         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
769
770 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
771
772         Unreviewed. Fix jhbuild dependencies build.
773
774         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
775         Patch updated.
776
777 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
778
779         [EME][GStreamer] Fixed decryptor selection
780         https://bugs.webkit.org/show_bug.cgi?id=167588
781
782         Reviewed by Žan Doberšek.
783
784         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
785
786         * gtk/jhbuild.modules: Added patches to gstreamer and
787         gst-plugins-good packages.
788         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
789         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
790
791 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
792
793         Make run-benchmark script supports 'config' key in test plan.
794         https://bugs.webkit.org/show_bug.cgi?id=167715
795
796         Reviewed by Ryosuke Niwa.
797
798         Add support for 'config' key in test paln.
799         'config' key is a dictionary that specifies environment configurations while test is running.
800         Specifies orientation to be portrait in MotionMark benchmark.
801
802         * Scripts/webkitpy/benchmark_runner/README.md:
803         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
804         (BenchmarkRunner.__init__):
805         (BenchmarkRunner._run_benchmark):
806         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
807         (BrowserDriver.prepare_env):
808         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
809         (LinuxBrowserDriver.prepare_env):
810         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
811         (OSXBrowserDriver.prepare_env):
812         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
813         (OSXSafariDriver.prepare_env):
814         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
815
816 2017-02-01  Daniel Bates  <dabates@apple.com>
817
818         REGRESSION (r210820): svn-create-patch does not emit property change only diff
819         https://bugs.webkit.org/show_bug.cgi?id=167169
820
821         Reviewed by David Kilzer.
822
823         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
824         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
825         header from the output of "svn diff" on a file that was copied or moved.
826
827         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
828         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
829         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
830         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
831         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
832         of a file with only a property change also does not contain any chunk range lines. Therefore
833         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
834         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
835         we should directly test for the presence of a leading SVN diff header with an empty body and
836         remove such lines from the diff.
837
838         * Scripts/VCSUtils.pm:
839         (fixSVNPatchForAdditionWithHistory): Added.
840         * Scripts/svn-create-patch:
841         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
842         we have a non empty patch for an added file with history (i.e. a copied or moved file).
843         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
844
845 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
846
847         [Mac] Update CARingBuffer class
848         https://bugs.webkit.org/show_bug.cgi?id=167656
849
850         Reviewed by Jer Noble.
851
852         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
853         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
854         (TestWebKitAPI::CARingBufferTest::SetUp):
855         (TestWebKitAPI::CARingBufferTest::setup):
856         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
857         (TestWebKitAPI::CARingBufferTest::description):
858         (TestWebKitAPI::CARingBufferTest::bufferList):
859         (TestWebKitAPI::CARingBufferTest::ringBuffer):
860         (TestWebKitAPI::CARingBufferTest::capacity):
861         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
862         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
863         (TestWebKitAPI::TEST_F):
864         (TestWebKitAPI::MixingTest::run):
865
866 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
867
868         [Mac] TestWebKitAPI includes system frameworks incorrectly
869         https://bugs.webkit.org/show_bug.cgi?id=167703
870         rdar://problem/30301498
871
872         Reviewed by Ryosuke Niwa.
873
874         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
875         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
876
877         Also, reduced the number of subframework search paths, looks like we only need one now.
878
879         * TestWebKitAPI/Configurations/Base.xcconfig:
880
881 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
882
883         Correct "filesHaveSameVolume" predicate
884         https://bugs.webkit.org/show_bug.cgi?id=167696
885         <rdar://problem/30298722>
886
887         Reviewed by David Kilzer.
888
889         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
890         percent-escaped path inputs.
891
892         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
893         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
894         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
895         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
896         (TestWebKitAPI::TEST_F):
897
898 2017-02-01  Tomas Popela  <tpopela@redhat.com>
899
900         Unreviewed. Fix coding style in MiniBrowser
901
902         * MiniBrowser/gtk/BrowserWindow.c:
903         (editingCommandCallback):
904         (insertImageCommandCallback):
905         (insertLinkCommandCallback):
906
907 2017-02-01  Tomas Popela  <tpopela@redhat.com>
908
909         [GTK] Add an API to add a custom tab into the print dialog
910         https://bugs.webkit.org/show_bug.cgi?id=151998
911
912         Reviewed by Carlos Garcia Campos.
913
914         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
915         that is testing a newly added API.
916
917         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
918         (testPrintCustomWidget):
919         (beforeAll):
920
921 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
922
923         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
924         https://bugs.webkit.org/show_bug.cgi?id=166529
925
926         Reviewed by Xabier Rodriguez-Calvar.
927
928         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
929         New patch version accepted in GStreamer upstream.
930
931 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
932
933         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
934         https://bugs.webkit.org/show_bug.cgi?id=167498
935
936         Reviewed by Carlos Garcia Campos.
937
938         Depending on the distro version you can need either libxfont1-dev
939         or libfont-dev to build with jhbuild.
940
941         * gtk/install-dependencies:
942
943 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
944
945         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
946         https://bugs.webkit.org/show_bug.cgi?id=167594
947
948         Unreviewed test gardening.
949
950         Disabling this test while we investigate the cause of a timeout on ios-simulator.
951
952         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
953         (TEST):
954
955 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
956
957         Move slow-running microbenchmarks out of JSTests/microbenchmarks
958         https://bugs.webkit.org/show_bug.cgi?id=167676
959
960         Reviewed by Saam Barati.
961
962         * Scripts/run-javascriptcore-tests:
963         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
964
965 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
966
967         Make Dump Render Tree not crash
968         https://bugs.webkit.org/show_bug.cgi?id=167667
969
970         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
971         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
972         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
973         This does not fix any tests, it just fixes the crash.
974         
975         Reviewed by Simon Fraser.
976
977         * DumpRenderTree/TestRunner.cpp:
978         (TestRunner::callUIScriptCallback):
979
980 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
981
982         Workaround for simctl install failing to report install failure
983         https://bugs.webkit.org/show_bug.cgi?id=167654
984
985         Reviewed by Daniel Bates.
986
987         simctl install will sometimes report success even though install has failed.
988         To workaround this bug, we attempt an app launch after install to ensure
989         install has succeeded.
990
991         * Scripts/webkitpy/xcode/simulator.py:
992         (Device.install_app): Attempt app launch after install, retry install if launch fails.
993         (Device.launch_app): Correct comment.
994
995 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
996
997         Unreviewed webkitpy fix after r211405.
998
999         * Scripts/webkitpy/xcode/simulator.py:
1000         (Device.launch_app): Remove @staticmethod on _log_debug_error.
1001
1002 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1003
1004         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
1005
1006         * gtk/manifest.txt.in:
1007
1008 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
1009
1010         AX: enable search predication for iOS
1011         https://bugs.webkit.org/show_bug.cgi?id=167558
1012         <rdar://problem/30251367>
1013
1014         Reviewed by Joanmarie Diggs.
1015
1016         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1017         (AccessibilityUIElement::uiElementForSearchPredicate):
1018         * DumpRenderTree/mac/AccessibilityCommonMac.h:
1019         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1020         (searchPredicateParameterizedAttributeForSearchCriteria):
1021         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1022         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1023         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1024         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1025         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1026         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
1027         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1028         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1029         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1030         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1031         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1032
1033 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1034
1035         Workaround for simctl launch bug
1036         https://bugs.webkit.org/show_bug.cgi?id=167613
1037
1038         Reviewed by Daniel Bates.
1039
1040         simctl launch will sometimes fail because of a race condition when many
1041         simulators are being run simultaneously. These failures will always have
1042         an exit code of 1. This change attempts to launch an app multiple times
1043         before reporting a failure to workaround this bug.
1044
1045         * Scripts/webkitpy/xcode/simulator.py:
1046         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
1047
1048 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
1049
1050         Commit queue fails to look at real name aliases for the reviewer
1051         https://bugs.webkit.org/show_bug.cgi?id=167422
1052
1053         Reviewed by Joseph Pecoraro.
1054
1055         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1056         (test_has_valid_reviewer): Added tests.
1057
1058         * Scripts/webkitpy/common/config/committers.py:
1059         (CommitterList._name_to_contributor_map):
1060         Made _name_to_contributor_map include alias names.
1061
1062         * Scripts/webkitpy/common/config/committers_unittest.py:
1063         (CommittersTest.test_contributors_by_fuzzy_match):
1064         Removed subtests that are now obsolete, as these matches are strict. It is not
1065         obvious if distance based fuzzy matching for names is useful at all, but we can
1066         look into that some other time.
1067
1068 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
1069
1070         QueueStatusServer should have an explicit timeout for _fetch_url
1071         https://bugs.webkit.org/show_bug.cgi?id=167467
1072
1073         Reviewed by Alexey Proskuryakov.
1074
1075         * Scripts/webkitpy/common/net/statusserver.py:
1076         (StatusServer._fetch_url): Add an explicit timeout of 300s.
1077
1078 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
1079
1080         Add support for Trac instances that host multiple projects.
1081         https://bugs.webkit.org/show_bug.cgi?id=167524
1082
1083         Reviewed by Alexey Proskuryakov.
1084
1085         When multiple projects are hosted on a single Trac instance, the current
1086         behavior will retrieve changesets from all tracked projects.
1087         This patch teaches Trac.js to get project-specific changesets from Trac.
1088         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
1089         when querying the Trac timeline.
1090
1091         To tell Trac to be aware of multi-project instances we leverage the 
1092         `options` parameter when creating a new instance: 
1093
1094             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
1095
1096         If this option is not provided, the original behaviour will prevail.
1097         Additionally, add corresponding tests.
1098
1099         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1100         (Trac): Reason about new optional parameter 'projectIdentifier'.
1101         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
1102         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
1103         replace default parameter `changeset=on` with `repo-projectname=on`.
1104         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
1105         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1106         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
1107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1108         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
1109         Add the following tests:
1110             test("revisionURL")
1111             test("revisionURL with Trac Identifier")
1112             test("_xmlTimelineURL")
1113             test("_xmlTimelineURL with Trac Identifier")
1114         (this.view._latestProductiveIteration): Fix missing ';'.
1115
1116 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
1117
1118         Correct spacing regression on inter-element complex path shaping on some fonts
1119         https://bugs.webkit.org/show_bug.cgi?id=166013
1120
1121         Reviewed by Simon Fraser.
1122
1123         Unskip existing tests and make some new tests:
1124         - Testing complex text with no origins
1125         - Testing initial expansions
1126         - Testing the sign of vertical advances
1127
1128         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1129         (TestWebKitAPI::TEST_F):
1130
1131 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1132
1133         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1134         https://bugs.webkit.org/show_bug.cgi?id=167596
1135
1136         Reviewed by Daniel Bates.
1137
1138         We avoid needing a thin directory by invoking the zip program with
1139         the list of directories from the build directory to be zipped,
1140         and by using the zip feature to exclude files matching a pattern.
1141
1142         * BuildSlaveSupport/built-product-archive:
1143         (copyBuildFiles):
1144         (createZipFromList):
1145         (archiveBuiltProduct):
1146
1147 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1148
1149         Use simctl instead of LayoutTestRelay
1150         https://bugs.webkit.org/show_bug.cgi?id=165927
1151
1152         Reviewed by Daniel Bates.
1153
1154         Part 1
1155
1156         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1157         simulators through simctl (iOS 10 and later), use this functionality instead.
1158
1159         * Scripts/webkitpy/port/base.py:
1160         (Port.__init__): Added _test_runner_process_constructor.
1161         * Scripts/webkitpy/port/darwin.py:
1162         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1163         * Scripts/webkitpy/port/driver.py:
1164         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1165         (IOSSimulatorDriver): Deleted.
1166         * Scripts/webkitpy/port/driver_unittest.py:
1167         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1168         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1169         (DriverTest.test_start_actually_starts): Ditto.
1170         * Scripts/webkitpy/port/ios.py:
1171         (IOSSimulatorPort): Remove relay_name.
1172         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1173         (IOSSimulatorPort._create_simulators): Formatting change.
1174         (IOSSimulatorPort.relay_path): Deleted.
1175         (IOSSimulatorPort._check_relay): Deleted.
1176         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1177         (IOSSimulatorPort._build_relay): Deleted.
1178         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1179         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1180         * Scripts/webkitpy/port/ios_unittest.py:
1181         (iosTest.test_32bit): Update test.
1182         (iosTest.test_64bit): Update test.
1183         * Scripts/webkitpy/port/server_process.py:
1184         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1185         (ServerProcess._set_file_nonblocking): Added to share common code.
1186         * Scripts/webkitpy/port/server_process_mock.py:
1187         (MockServerProcess.__init__): Added argument worker_number.
1188         * Scripts/webkitpy/port/simulator_process.py: Added.
1189         (SimulatorProcess): Added.
1190         (SimulatorProcess.Popen): Added.
1191         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1192         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1193         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1194         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1195         (SimulatorProcess._reset): Added. Unlink fifos.
1196         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1197         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1198         * Scripts/webkitpy/xcode/simulator.py:
1199         (Device.__init__): Accept host to run install/launch/terminate.
1200         (Device.install_app): Install app to target Device.
1201         (Device.launch_app): Launch app on target Device.
1202         (Device.terminate_app): Shutdown app on target Device.
1203         (Simulator._parse_devices): Pass host to Device.
1204
1205 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1206
1207         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1208         https://bugs.webkit.org/show_bug.cgi?id=167411
1209
1210         Reviewed by Michael Catanzaro.
1211
1212         Disable the ARM iwMMXt fast path for pixman, because it triggers
1213         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1214
1215         * gtk/jhbuild.modules:
1216
1217 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1218
1219         [GTK] Add API to handle the accelerated compositing policy
1220         https://bugs.webkit.org/show_bug.cgi?id=167509
1221
1222         Reviewed by Michael Catanzaro.
1223
1224         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1225         as a special case. Also add test cases to the get/set API.
1226
1227         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1228         (hardwareAccelerationPolicyToString):
1229         (stringToHardwareAccelerationPolicy):
1230         (cellRendererChanged):
1231         (browserSettingsDialogConstructed):
1232         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1233         (testWebKitSettings):
1234
1235 2017-01-29  Andy Estes  <aestes@apple.com>
1236
1237         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1238         https://bugs.webkit.org/show_bug.cgi?id=167563
1239         <rdar://problem/30253207>
1240
1241         Reviewed by Andreas Kling.
1242
1243         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1244         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1245         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1246         (runTest):
1247         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1248         (TEST):
1249
1250 2017-01-29  Dan Bernstein  <mitz@apple.com>
1251
1252         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
1253         https://bugs.webkit.org/show_bug.cgi?id=167565
1254
1255         Reviewed by Sam Weinig.
1256
1257         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1258         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
1259         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
1260         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
1261         (TEST):
1262         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
1263         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1264         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1265         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
1266
1267 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1268
1269         Add Link Preload as an off-by-default experimental feature menu item.
1270         https://bugs.webkit.org/show_bug.cgi?id=167201
1271
1272         Reviewed by Ryosuke Niwa.
1273
1274         * DumpRenderTree/mac/DumpRenderTree.mm:
1275         (resetWebPreferencesToConsistentValues):
1276         * DumpRenderTree/win/DumpRenderTree.cpp:
1277         (resetWebPreferencesToConsistentValues):
1278
1279 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1280
1281         Add User Timing Experimental Feature
1282         https://bugs.webkit.org/show_bug.cgi?id=167542
1283         <rdar://problem/22746307>
1284
1285         Reviewed by Ryosuke Niwa.
1286
1287         * DumpRenderTree/mac/DumpRenderTree.mm:
1288         (enableExperimentalFeatures):
1289         (resetWebPreferencesToConsistentValues):
1290         * DumpRenderTree/win/DumpRenderTree.cpp:
1291         (enableExperimentalFeatures):
1292
1293 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1294
1295         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
1296         https://bugs.webkit.org/show_bug.cgi?id=167519
1297
1298         Reviewed by Ryosuke Niwa.
1299
1300         * QueueStatusServer/templates/statusbubble.html:
1301         To measure the bubbleContainer's width, it must not be wrapping based
1302         on its parent container. So when measuring the width temporarily set
1303         the parent to a very large width so as to not artificially wrap us.
1304         Restore the parent's width after measuring.
1305
1306 2017-01-27  Andy Estes  <aestes@apple.com>
1307
1308         [iOS] Add a test for _WKNSFileManagerExtras
1309         https://bugs.webkit.org/show_bug.cgi?id=167478
1310
1311         Reviewed by Andreas Kling.
1312
1313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1314         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
1315         (expectAttributes):
1316         (TEST):
1317
1318 2017-01-27  Keith Miller  <keith_miller@apple.com>
1319
1320         run-benchmarks should make sure it passes the test url to the right application
1321         https://bugs.webkit.org/show_bug.cgi?id=167533
1322
1323         Reviewed by Joseph Pecoraro.
1324
1325         This fixes an issue when trying to run-benchmark script with the
1326         system default browser set to STP. Previously, it would run
1327         the test in STP rather than the provided build. Now, it should run
1328         in the provided build.
1329
1330         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1331         (OSXSafariDriver.launch_url):
1332
1333 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1334
1335         [Cocoa] Prepare ComplexTextController for unit testing
1336         https://bugs.webkit.org/show_bug.cgi?id=167493
1337
1338         Reviewed by Simon Fraser.
1339
1340         Addressing post-review comments from Simon Fraser.
1341
1342         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1343         (TestWebKitAPI::TEST_F):
1344
1345 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1346
1347         [Cocoa] Prepare ComplexTextController for unit testing
1348         https://bugs.webkit.org/show_bug.cgi?id=167493
1349
1350         Reviewed by Dean Jackson.
1351
1352         Create four unit tests.
1353
1354         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1355         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
1356         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
1357         (TestWebKitAPI::TEST_F):
1358
1359 2017-01-26  Chris Dumez  <cdumez@apple.com>
1360
1361         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1362         https://bugs.webkit.org/show_bug.cgi?id=167421
1363         <rdar://problem/30188490>
1364
1365         Reviewed by Darin Adler.
1366
1367         Add a new setting allowing layout tests to enable PageCache in a window
1368         that has an opener, for convenience.
1369
1370         * DumpRenderTree/mac/DumpRenderTree.mm:
1371         (resetWebPreferencesToConsistentValues):
1372         * DumpRenderTree/win/DumpRenderTree.cpp:
1373         (resetWebPreferencesToConsistentValues):
1374         * WebKitTestRunner/TestController.cpp:
1375         (WTR::TestController::resetPreferencesToConsistentValues):
1376
1377 2017-01-26  Keith Miller  <keith_miller@apple.com>
1378
1379         classInfo should take a VM so it is not materialized from the object on each call
1380         https://bugs.webkit.org/show_bug.cgi?id=167424
1381
1382         Rubber Stamped by Michael Saboff.
1383
1384         Previously, classInfo() would get the VM from the target's
1385         MarkedBlock.  Most callers already have a VM on hand, so it is
1386         wasteful to compute the VM from the marked block every time. This
1387         patch refactors some of the most common callers of classInfo(),
1388         jsDynamicCast and inherits to take a VM as well.
1389
1390         * DumpRenderTree/TestRunner.cpp:
1391         (setAudioResultCallback):
1392
1393 2017-01-26  Jer Noble  <jer.noble@apple.com>
1394
1395         Autoplay muted videos stop playback of any streaming app in the background
1396         https://bugs.webkit.org/show_bug.cgi?id=163993
1397         <rdar://problem/29020431>
1398
1399         Reviewed by Eric Carlson.
1400
1401         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1402         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1403         (TestWebKitAPI::TEST):
1404         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
1405
1406 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
1407
1408         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
1409         https://bugs.webkit.org/show_bug.cgi?id=167466
1410
1411         Unreviewed test gardening.
1412
1413         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1414         (TEST):
1415
1416 2017-01-26  Matt Rajca  <mrajca@apple.com>
1417
1418         Notify clients when the user plays media otherwise prevented from autoplaying
1419         https://bugs.webkit.org/show_bug.cgi?id=167390
1420
1421         Reviewed by Alex Christensen.
1422
1423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1424         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1425         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1426         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1427         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1428         (TEST):
1429         * TestWebKitAPI/cocoa/TestWKWebView.h:
1430         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1431         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1432         (-[TestWKWebView waitForLoad]):
1433         (-[TestWKWebView mouseUpAtPoint:]):
1434         * WebKitTestRunner/TestController.cpp:
1435         (WTR::TestController::createOtherPage):
1436         (WTR::TestController::createWebViewWithOptions):
1437
1438 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1439
1440         Crash when setting custom scale factor.
1441         https://bugs.webkit.org/show_bug.cgi?id=167369
1442
1443         Reviewed by Sam Weinig.
1444
1445         Added API test.
1446
1447         * TestWebKitAPI/PlatformWin.cmake:
1448         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1449         (TestWebKitAPI::WebKitCreateInstance):
1450         (TestWebKitAPI::ScaleWebView::SetUp):
1451         (TestWebKitAPI::ScaleWebView::TearDown):
1452         (TestWebKitAPI::TEST_F):
1453
1454 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1455
1456         run-benchmark nests MotionMark results by the suite name twice
1457         https://bugs.webkit.org/show_bug.cgi?id=164948
1458
1459         Reviewed by Said Abou-Hallawa.
1460
1461         Use a single level MotionMark now that this is the name of the benchmark,
1462         and we no longer have tests that aren't part of the MotionMark suite.
1463
1464         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1465
1466 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1467
1468         Unreviewed, rolling out r211193.
1469
1470         This change broke internal builds.
1471
1472         Reverted changeset:
1473
1474         "Notify clients when the user plays media otherwise prevented
1475         from autoplaying"
1476         https://bugs.webkit.org/show_bug.cgi?id=167390
1477         http://trac.webkit.org/changeset/211193
1478
1479 2017-01-25  Matt Rajca  <mrajca@apple.com>
1480
1481         Notify clients when the user plays media otherwise prevented from autoplaying
1482         https://bugs.webkit.org/show_bug.cgi?id=167390
1483
1484         Reviewed by Alex Christensen.
1485
1486         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1487         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1488         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1489         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1490         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1491         (TEST):
1492         * TestWebKitAPI/cocoa/TestWKWebView.h:
1493         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1494         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1495         (-[TestWKWebView waitForLoad]):
1496         (-[TestWKWebView mouseUpAtPoint:]):
1497         * WebKitTestRunner/TestController.cpp:
1498         (WTR::TestController::createOtherPage):
1499         (WTR::TestController::createWebViewWithOptions):
1500
1501 2017-01-25  Matt Rajca  <mrajca@apple.com>
1502
1503         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1504         https://bugs.webkit.org/show_bug.cgi?id=167385
1505
1506         Reviewed by Alex Christensen.
1507
1508         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1509         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1510         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1511         (TEST): Allow inline (rather than full screen) media playback on iOS.
1512
1513 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1514
1515         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1516         https://bugs.webkit.org/show_bug.cgi?id=167414
1517
1518         Reviewed by Michael Catanzaro.
1519
1520         Add a test case to check ephemeral web views don't write favicons to the database.
1521
1522         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1523         (ephemeralViewLoadChanged):
1524         (testPrivateBrowsing):
1525         (testFaviconDatabase):
1526
1527 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1528
1529         [GTK] Add a private browsing mode to MiniBrowser
1530         https://bugs.webkit.org/show_bug.cgi?id=167413
1531
1532         Reviewed by Michael Catanzaro.
1533
1534         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1535         private windows, even on non-private instances.
1536
1537         * MiniBrowser/gtk/BrowserWindow.c:
1538         (webViewTitleChanged): Add [Private] to title window for private windows.
1539         (webViewCreate): Pass web context to browser_window_new.
1540         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1541         (browserWindowFinalize): Disconnect web context signal handlers.
1542         (browser_window_init): Add shortcut for opening private window.
1543         (browser_window_new): It now receives the context and connect to download-started here.
1544         (browser_window_get_web_context): Return the context.
1545         * MiniBrowser/gtk/BrowserWindow.h:
1546         * MiniBrowser/gtk/main.c:
1547         (createBrowserTab): Create the web view for the window web context.
1548         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1549         (aboutDataHandleRequest): Ditto.
1550         (aboutURISchemeRequestCallback): Ditto.
1551         (main): Create ephemeral web context if private command line option is used.
1552
1553 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1554
1555         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1556         https://bugs.webkit.org/show_bug.cgi?id=167409
1557
1558         Reviewed by Antti Koivisto.
1559
1560         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1561         as well as tests for the newly added matchingElementInFlatTree.
1562
1563         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1564         (TestWebKitAPI::runJavaScriptAlert):
1565         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1566         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1567         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1568
1569 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1570
1571         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1572         https://bugs.webkit.org/show_bug.cgi?id=167370
1573
1574         Reviewed by Michael Catanzaro.
1575
1576         Add several test cases of ephemeral web views.
1577
1578         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1579         (testWebViewAuthenticationStorage):
1580         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1581         (ephemeralViewloadChanged):
1582         (testCookieManagerEphemeral):
1583         (beforeAll):
1584         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1585         (testWebKitSettings):
1586         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1587         (testWebContextEphemeral):
1588         (ephemeralViewloadChanged):
1589         (testWebContextProxySettings):
1590         (beforeAll):
1591         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1592         (ephemeralViewloadChanged):
1593         (testWebViewEphemeral):
1594         (beforeAll):
1595         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1596         (ephemeralViewloadChanged):
1597         (testWebsiteDataEphemeral):
1598         (beforeAll):
1599
1600 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1601
1602         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1603         https://bugs.webkit.org/show_bug.cgi?id=167402
1604
1605         Reviewed by Ryosuke Niwa.
1606
1607         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1608         (TestWebKitAPI::TEST):
1609
1610 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1611
1612         Add simple line layout toggle to MiniBrowser
1613         https://bugs.webkit.org/show_bug.cgi?id=167405
1614
1615         Reviewed by Andreas Kling.
1616
1617         * MiniBrowser/mac/SettingsController.h:
1618         * MiniBrowser/mac/SettingsController.m:
1619         (-[SettingsController _populateMenu]):
1620         (-[SettingsController validateMenuItem:]):
1621         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1622         (-[SettingsController simpleLineLayoutEnabled]):
1623         * MiniBrowser/mac/WK1BrowserWindowController.m:
1624         (-[WK1BrowserWindowController didChangeSettings]):
1625         * MiniBrowser/mac/WK2BrowserWindowController.m:
1626         (-[WK2BrowserWindowController didChangeSettings]):
1627
1628 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1629
1630         WKR does not include my nick when commit-queue lands my patch
1631         https://bugs.webkit.org/show_bug.cgi?id=167388
1632
1633         Reviewed by Ryosuke Niwa.
1634
1635         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1636         (NewCommitBot._summarize_commit_log):
1637         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1638         Perform nickname insertion before grabbing "Patch by" details.
1639         This way we can include the nickname with the full name.
1640
1641 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1642
1643         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1644         https://bugs.webkit.org/show_bug.cgi?id=167394
1645
1646         Reviewed by Ryosuke Niwa.
1647
1648         * Scripts/webkitperl/FeatureList.pm:
1649         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1650
1651 2017-01-24  Youenn Fablet  <youenn@apple.com>
1652
1653         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1654         https://bugs.webkit.org/show_bug.cgi?id=167353
1655
1656         Reviewed by Alex Christensen.
1657
1658         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1659         (CMakeGenerator.initialize_targets):
1660
1661 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1662
1663         WKR should not confuse Miguel Gomez with Andres Gomez
1664         https://bugs.webkit.org/show_bug.cgi?id=167389
1665
1666         Reviewed by Lucas Forschler.
1667
1668         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1669         "mAndres Gomez". Fix this.
1670
1671         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1672         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1673         space on each side of the email address, so expect both spaces to be there before
1674         considering the email for replacement.
1675         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1676
1677 2017-01-24  Matt Rajca  <mrajca@apple.com>
1678
1679         Pass down website autoplay policies to media elements
1680         https://bugs.webkit.org/show_bug.cgi?id=167355
1681
1682         Reviewed by Alex Christensen.
1683
1684         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1685         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1686         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1687         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1688         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1689         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1690         (TEST):
1691
1692 2017-01-24  Nan Wang  <n_wang@apple.com>
1693
1694         AX: Speak Selection does not work in an iframe
1695         https://bugs.webkit.org/show_bug.cgi?id=166794
1696         <rdar://problem/29913013>
1697
1698         Reviewed by Chris Fleizach.
1699
1700         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1701         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1702         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1703         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1704         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1705         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1706         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1707         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1708         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1709         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1710         (-[TestRunnerWKWebView dealloc]):
1711         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1712         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1713         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1714         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1715         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1716
1717 2017-01-24  Daniel Bates  <dabates@apple.com>
1718
1719         StringView.split() should use an iterator design pattern instead of allocating a Vector
1720         https://bugs.webkit.org/show_bug.cgi?id=163225
1721
1722         Reviewed by Darin Adler.
1723
1724         Add unit tests for StringView.split().
1725
1726         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1727         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1728         used in the StringView.split() unit tests.
1729         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1730         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1731         object to a Vector of String objects.
1732         (TestWebKitAPI::TEST): Added the following tests:
1733             - WTF.StringViewSplitEmptyAndNullStrings
1734             - WTF.StringViewSplitBasic
1735             - WTF.StringViewSplitWithConsecutiveSeparators
1736
1737 2017-01-23  Anders Carlsson  <andersca@apple.com>
1738
1739         The Score Esports crashes on launch
1740         https://bugs.webkit.org/show_bug.cgi?id=167338
1741         rdar://problem/29948645
1742
1743         Reviewed by Dan Bernstein.
1744
1745         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1746         (TestWebKitAPI::TEST):
1747         Add a test.
1748
1749 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1750
1751         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1752         https://bugs.webkit.org/show_bug.cgi?id=146589
1753
1754         Reviewed by Michael Catanzaro.
1755
1756         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1757         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1758
1759         * MiniBrowser/gtk/BrowserWindow.c:
1760         (webViewDecidePolicy):
1761         (newTabCallback):
1762         * MiniBrowser/gtk/main.c:
1763         (createBrowserTab):
1764         (aboutDataRequestFree):
1765         (aboutDataRequestNew):
1766         (aboutDataRequestForView):
1767         (websiteDataRemovedCallback):
1768         (websiteDataClearedCallback):
1769         (aboutDataScriptMessageReceivedCallback):
1770         (domainListFree):
1771         (aboutDataFillTable):
1772         (gotWebsiteDataCallback):
1773         (aboutDataHandleRequest):
1774         (aboutURISchemeRequestCallback):
1775         (main):
1776         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1777         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1778         (serverCallback):
1779         (beforeAll):
1780         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
1781         (serverCallback):
1782         (WebsiteDataTest::WebsiteDataTest):
1783         (WebsiteDataTest::~WebsiteDataTest):
1784         (WebsiteDataTest::fetch):
1785         (WebsiteDataTest::remove):
1786         (WebsiteDataTest::clear):
1787         (testWebsiteDataConfiguration):
1788         (testWebsiteDataCache):
1789         (testWebsiteDataStorage):
1790         (testWebsiteDataDatabases):
1791         (testWebsiteDataAppcache):
1792         (beforeAll):
1793         (afterAll):
1794
1795 2017-01-23  Commit Queue  <commit-queue@webkit.org>
1796
1797         Unreviewed, rolling out r211062.
1798         https://bugs.webkit.org/show_bug.cgi?id=167354
1799
1800         broke API tests (Requested by alexchristensen on #webkit).
1801
1802         Reverted changeset:
1803
1804         "Pass down website autoplay policies to media elements"
1805         https://bugs.webkit.org/show_bug.cgi?id=167132
1806         http://trac.webkit.org/changeset/211062
1807
1808 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1809
1810         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
1811         https://bugs.webkit.org/show_bug.cgi?id=167330
1812
1813         Reviewed by Tim Horton.
1814
1815         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1816         (TestWebKitAPI::TEST_F):
1817
1818 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1819
1820         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
1821         https://bugs.webkit.org/show_bug.cgi?id=167317
1822
1823         Reviewed by Sam Weinig.
1824
1825         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1826         (TestWebKitAPI::TEST_F):
1827
1828 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
1829
1830         svn-create-patch should emit properties when files are moved or copied
1831         https://bugs.webkit.org/show_bug.cgi?id=167264
1832
1833         Reviewed by Daniel Bates.
1834
1835         * Scripts/svn-create-patch:
1836         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
1837
1838 2017-01-23  Youenn Fablet  <youenn@apple.com>
1839
1840         [WebRTC] Filter libwebrtc link flags
1841         https://bugs.webkit.org/show_bug.cgi?id=167287
1842
1843         Reviewed by Alex Christensen.
1844
1845         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1846         (CMakeGenerator._compute_link_flags):
1847         (CMakeGenerator._compute_link_flags.keep_flag):
1848         (CMakeGenerator._generate_compile_target_options):
1849
1850 2017-01-23  Youenn Fablet  <youennf@gmail.com>
1851
1852         [WebRTC] Make VP8 optional in libwebrtc
1853         https://bugs.webkit.org/show_bug.cgi?id=167257
1854
1855         Reviewed by Darin Adler.
1856
1857         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1858         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
1859
1860 2017-01-23  Jer Noble  <jer.noble@apple.com>
1861
1862         Video details does not apear and missing scrubber in Control Center
1863         https://bugs.webkit.org/show_bug.cgi?id=167233
1864
1865         Reviewed by Alex Christensen.
1866
1867         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
1868         NowPlayingControlTests for iOS.
1869
1870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1871         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1872         (-[NowPlayingTestWebView setWindowVisible:]):
1873         (TestWebKitAPI::TEST):
1874         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1875         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1876         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1877         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
1878         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
1879         (SOFT_LINK_CLASS):
1880         (-[TestMessageHandler addMessage:withHandler:]):
1881         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1882         (__simulated_forceClickAssociatedEventsMask):
1883         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1884         (-[TestWKWebViewHostWindow isKeyWindow]):
1885         (-[TestWKWebViewHostWindow makeKeyWindow]):
1886         (-[TestWKWebViewHostWindow resignKeyWindow]):
1887         (-[TestWKWebView initWithFrame:]):
1888         (-[TestWKWebView initWithFrame:configuration:]):
1889         (-[TestWKWebView _setUpTestWindow:]):
1890         (-[TestWKWebView performAfterReceivingMessage:action:]):
1891         (-[TestWKWebView loadTestPageNamed:]):
1892         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1893         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1894         (-[TestWKWebView waitForMessage:]):
1895         (-[TestWKWebView performAfterLoading:]):
1896         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1897         (-[TestWKWebView typeCharacter:]):
1898
1899 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1900
1901         Unreviewed. Bring back gtk-doc error messages after r209981.
1902
1903         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
1904         impossible to know what's wrong.
1905
1906         * gtk/gtkdoc.py:
1907         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
1908
1909 2017-01-20  Youenn Fablet  <youennf@gmail.com>
1910
1911         [WebRTC] Update build system to make G711 optional in libwebrtc
1912         https://bugs.webkit.org/show_bug.cgi?id=167256
1913
1914         Reviewed by Alex Christensen.
1915
1916         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1917         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
1918
1919 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1920
1921         Cleanup RuntimeEnabledFeatures
1922         https://bugs.webkit.org/show_bug.cgi?id=167228
1923
1924         Reviewed by Simon Fraser.
1925
1926         * DumpRenderTree/mac/DumpRenderTree.mm:
1927         (enableExperimentalFeatures):
1928         (resetWebPreferencesToConsistentValues):
1929         (setWebPreferencesForTestOptions):
1930         (resetWebViewToConsistentStateBeforeTesting):
1931         * DumpRenderTree/win/DumpRenderTree.cpp:
1932         (enableExperimentalFeatures):
1933         (resetWebPreferencesToConsistentValues):
1934         More closely match WebKitTestRunner initialization of preferences
1935         for experimental features.
1936
1937 2017-01-20  Alex Christensen  <achristensen@webkit.org>
1938
1939         Build Fix for Windows DumpRenderTree after r210976
1940         https://bugs.webkit.org/show_bug.cgi?id=167115
1941
1942         * DumpRenderTree/win/DumpRenderTree.cpp:
1943         (resetWebPreferencesToConsistentValues):
1944
1945 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1946
1947         Remove outdated ENABLE(CSP_NEXT) build flag
1948         https://bugs.webkit.org/show_bug.cgi?id=167252
1949
1950         Reviewed by Brent Fulgham.
1951
1952         * Scripts/webkitperl/FeatureList.pm:
1953         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1954
1955 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1956
1957         Build Fix for Windows DumpRenderTree after r210976
1958
1959         * DumpRenderTree/win/DumpRenderTree.cpp:
1960         (resetWebPreferencesToConsistentValues):
1961
1962 2017-01-20  Antoine Quint  <graouts@apple.com>
1963
1964         Web Animations should be off by default and enabled as an experimental feature
1965         https://bugs.webkit.org/show_bug.cgi?id=167115
1966         <rdar://problem/30048963>
1967
1968         Reviewed by Joseph Pecoraro.
1969
1970         Turn Web Animations on in DRT.
1971
1972         * DumpRenderTree/mac/DumpRenderTree.mm:
1973         (resetWebPreferencesToConsistentValues):
1974         * DumpRenderTree/win/DumpRenderTree.cpp:
1975         (resetWebPreferencesToConsistentValues):
1976
1977 2017-01-20  Youenn Fablet  <youenn@apple.com>
1978
1979         [WebRTC] Add libwebrtc build infrastructure
1980         https://bugs.webkit.org/show_bug.cgi?id=167207
1981
1982         Reviewed by Alex Christensen.
1983
1984         Adding a script doing the libwebrtc project json to CMake file conversion.
1985
1986         * Scripts/generate-libwebrtc-cmake: Added.
1987         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
1988         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
1989
1990 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1991
1992         Mini Browser: Show tooltip for Experimental Features
1993         https://bugs.webkit.org/show_bug.cgi?id=167225
1994
1995         Reviewed by Alex Christensen.
1996
1997         * MiniBrowser/mac/SettingsController.m:
1998         (-[SettingsController _populateMenu]):
1999         Include the full details string as a tooltip.
2000
2001 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
2002
2003         [Win] Test output results should not be written twice.
2004         https://bugs.webkit.org/show_bug.cgi?id=167197
2005
2006         Reviewed by Brent Fulgham.
2007
2008         Prevent test output from being written twice by returning early from
2009         the dump() function, if it already has been called.
2010         This patch also adds a missing newline to a test output line. 
2011         
2012         * DumpRenderTree/win/DumpRenderTree.cpp:
2013         (dump):
2014
2015 2017-01-20  Antoine Quint  <graouts@apple.com>
2016
2017         [Modern Media Controls] Turn modern media controls on by default
2018         https://bugs.webkit.org/show_bug.cgi?id=165668
2019
2020         Reviewed by Dean Jackson.
2021
2022         Enabled modern media controls by default in test runners.
2023
2024         * DumpRenderTree/TestOptions.h:
2025         * WebKitTestRunner/TestOptions.h:
2026
2027 2017-01-19  Chris Dumez  <cdumez@apple.com>
2028
2029         iterable<> should be enabled on WK1
2030         https://bugs.webkit.org/show_bug.cgi?id=167221
2031         <rdar://problem/30108531>
2032
2033         Reviewed by Youenn Fablet.
2034
2035         * DumpRenderTree/mac/DumpRenderTree.mm:
2036         (resetWebPreferencesToConsistentValues):
2037         * DumpRenderTree/win/DumpRenderTree.cpp:
2038         (resetWebPreferencesToConsistentValues):
2039         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2040         (WTR::InjectedBundle::beginTesting):
2041         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2042         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
2043         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2044
2045 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
2046
2047         Ensure status server logs go to log file
2048         https://bugs.webkit.org/show_bug.cgi?id=167210
2049
2050         Reviewed by Alexey Proskuryakov.
2051
2052         * Scripts/webkitpy/common/net/statusserver.py:
2053         (StatusServer.next_work_item): Change log level from debug to info in
2054         order to facilitate deubgging issues.
2055         (StatusServer.update_work_items): Same.
2056
2057 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
2058
2059         Additional selection tests and interpolation fix
2060         https://bugs.webkit.org/show_bug.cgi?id=167171
2061
2062         Reviewed by Simon Fraser.
2063
2064         We weren't adding the final event when interpolating event streams.
2065
2066         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2067         (-[HIDEventGenerator interpolatedEvents:]):
2068
2069 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2070
2071         [Cocoa] Variation fonts are erroneously disabled on iOS
2072         https://bugs.webkit.org/show_bug.cgi?id=167172
2073
2074         Reviewed by Simon Fraser.
2075
2076         OpenSource builders don't seem to understand sdk=embedded*.
2077
2078         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2079
2080 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2081
2082         Unreviewed. Fix GTK+ unit tests failing since r210531.
2083
2084         Avoid using paths to files that don't actually exist.
2085
2086         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2087         (testWebKitConsoleMessageNetworkError):
2088         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2089         (testContextMenuDefaultMenu):
2090         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
2091         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
2092         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
2093
2094 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2095
2096         [GTK] Provide API to set proxy settings
2097         https://bugs.webkit.org/show_bug.cgi?id=128674
2098
2099         Reviewed by Michael Catanzaro.
2100
2101         Add tests for new proxy settings API.
2102
2103         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2104         (serverCallback):
2105         (ProxyTest::ProxyTest):
2106         (ProxyTest::~ProxyTest):
2107         (ProxyTest::loadURIAndGetMainResourceData):
2108         (ProxyTest::proxyServerPortAsString):
2109         (testWebContextProxySettings):
2110         (beforeAll):
2111
2112 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2113
2114         Add back my old email address so old commits will still match it.
2115
2116         * Scripts/webkitpy/common/config/contributors.json:
2117
2118 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2119
2120         Remove my old email address from contributors.json and watchlist.
2121
2122         * Scripts/validate-committer-lists:
2123         (CommitterListFromGit): Change the mapping to the correct email.
2124         * Scripts/webkitpy/common/config/contributors.json:
2125         * Scripts/webkitpy/common/config/watchlist:
2126
2127 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2128
2129         Unreviewed, rolling out r210848.
2130
2131         This change introduced media-related LayoutTest failures and
2132         crashes on macOS.
2133
2134         Reverted changeset:
2135
2136         "[Modern Media Controls] Turn modern media controls on by
2137         default"
2138         https://bugs.webkit.org/show_bug.cgi?id=165668
2139         http://trac.webkit.org/changeset/210848
2140
2141 2017-01-18  Andreas Kling  <akling@apple.com>
2142
2143         Document::securityOrigin() should return a reference.
2144         <https://webkit.org/b/167124>
2145
2146         Reviewed by Sam Weinig.
2147
2148         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2149         (TestWebKitAPI::TEST_F):
2150
2151 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2152
2153         [Win] Clipboard tests are flaky.
2154         https://bugs.webkit.org/show_bug.cgi?id=167088
2155
2156         Reviewed by Brent Fulgham.
2157
2158         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2159         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2160
2161         * DumpRenderTree/win/DumpRenderTree.cpp:
2162         (main):
2163
2164 2017-01-18  Antoine Quint  <graouts@apple.com>
2165
2166         [Modern Media Controls] Turn modern media controls on by default
2167         https://bugs.webkit.org/show_bug.cgi?id=165668
2168
2169         Reviewed by Dean Jackson.
2170
2171         Enabled modern media controls by default in test runners. 
2172
2173         * DumpRenderTree/TestOptions.h:
2174         * WebKitTestRunner/TestOptions.h:
2175
2176 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2177
2178         Unreviewed, rolling out r210834
2179         https://bugs.webkit.org/show_bug.cgi?id=165668
2180
2181         It introduced dozens of test timeouts.
2182
2183         Reverted changeset:
2184         "[Modern Media Controls] Turn modern media controls on by default"
2185         https://bugs.webkit.org/show_bug.cgi?id=165668
2186         http://trac.webkit.org/changeset/210834
2187
2188 2017-01-17  Antoine Quint  <graouts@apple.com>
2189
2190         [Modern Media Controls] Turn modern media controls on by default
2191         https://bugs.webkit.org/show_bug.cgi?id=165668
2192
2193         Reviewed by Dean Jackson.
2194
2195         Enabled modern media controls by default in test runners. 
2196
2197         * DumpRenderTree/TestOptions.h:
2198         * WebKitTestRunner/TestOptions.h:
2199
2200 2017-01-17  Chris Dumez  <cdumez@apple.com>
2201
2202         Document title changed twice when setting document.title
2203         https://bugs.webkit.org/show_bug.cgi?id=167065
2204
2205         Reviewed by Darin Adler.
2206
2207         Add WebKit2GTK API test that was written by Michael Catanzaro.
2208
2209         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2210         (testWebViewTitleChange):
2211         (beforeAll):
2212
2213 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2214
2215         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2216         https://bugs.webkit.org/show_bug.cgi?id=116551
2217         <rdar://problem/13949830>
2218
2219         Reviewed by Alex Christensen.
2220
2221         * Scripts/webkitperl/FeatureList.pm:
2222         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2223         that is part of the existing WEB_TIMING feature.
2224
2225         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2226
2227 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
2228
2229         'webkit-patch post' no longer works with moved/copied files
2230         https://bugs.webkit.org/show_bug.cgi?id=166914
2231         <rdar://problem/29979707>
2232
2233         Reviewed by Daniel Bates.
2234
2235         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
2236         file outputs only the "Index:" line with an empty body.  This workaround
2237         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
2238         public email list tracking this bug is below.
2239         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
2240         
2241
2242         * Scripts/svn-create-patch:
2243         (generateDiff): Ignore an "Index:" line with an empty body.
2244
2245 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2246
2247         Remove the REQUEST_ANIMATION_FRAME flag
2248         https://bugs.webkit.org/show_bug.cgi?id=156980
2249         <rdar://problem/25906849>
2250
2251         Reviewed by Simon Fraser.
2252
2253         * Scripts/webkitperl/FeatureList.pm:
2254         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2255
2256 2017-01-15  Sam Weinig  <sam@webkit.org>
2257
2258         Add the ability to use numbers in makeString()
2259         https://bugs.webkit.org/show_bug.cgi?id=167087
2260
2261         Reviewed by Darin Adler.
2262
2263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2264         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
2265         Add tests for StringConcatenate, focusing on new numeric additions.
2266
2267 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2268
2269         Unreviewed, remove stale comment.
2270
2271         This test was fixed by r163173.
2272
2273         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2274
2275 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2276
2277         Annotate large string tests with largeHeap
2278         https://bugs.webkit.org/show_bug.cgi?id=167054
2279
2280         Reviewed by Filip Pizlo.
2281
2282         * Scripts/run-javascriptcore-tests:
2283         * Scripts/run-jsc-stress-tests:
2284
2285 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
2286
2287         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
2288         https://bugs.webkit.org/show_bug.cgi?id=167043
2289
2290         Reviewed by Darin Adler.
2291
2292         * Scripts/webkitperl/FeatureList.pm:
2293
2294 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2295
2296         Remove ENABLE(DETAILS_ELEMENT) guards
2297         https://bugs.webkit.org/show_bug.cgi?id=167042
2298
2299         Reviewed by Alex Christensen.
2300
2301         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2302
2303 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
2304
2305         26 MotionMark performance tests failing
2306         https://bugs.webkit.org/show_bug.cgi?id=166854
2307
2308         Reviewed by Ryosuke Niwa.
2309
2310         Unrelated change. This is the last place that we need to rename Animometer
2311         to MotionMark.
2312
2313         * Scripts/webkitpy/common/config/watchlist:
2314
2315 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2316
2317         run-jsc-benchmarks' echo should have -e option
2318         https://bugs.webkit.org/show_bug.cgi?id=167009
2319
2320         Reviewed by Sam Weinig.
2321
2322         echo requires `-e` option to use escape sequence.
2323         Without it, in some environment (in my Fedora 25), the escape sequence is not
2324         recognized and just dumped as `\c` etc.
2325
2326         * Scripts/run-jsc-benchmarks:
2327
2328 2017-01-12  Chris Dumez  <cdumez@apple.com>
2329
2330         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2331         https://bugs.webkit.org/show_bug.cgi?id=166995
2332
2333         Reviewed by Jer Noble.
2334
2335         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2336         as some people are having trouble building without it.
2337
2338         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2339
2340 2017-01-12  Sam Weinig  <sam@webkit.org>
2341
2342         Add the ability to filter the set of bindings tests you want to run
2343         https://bugs.webkit.org/show_bug.cgi?id=166977
2344
2345         Reviewed by Tim Horton.
2346
2347         Allows doing things like:
2348             run-bindings-tests TestObj* TestCEReactions*
2349         
2350         to run only those tests that match the patterns.
2351
2352         * Scripts/run-bindings-tests:
2353         (main):
2354         Switch to using optparse and pass the remaining args as the filters.
2355
2356         * Scripts/webkitpy/bindings/main.py:
2357         (BindingsTests.__init__):
2358         Store the pattens.
2359
2360         (BindingsTests.test_matches_patterns):
2361         Add helper predicate to determine if a test should be run. When no
2362         patterns are present, all tests should run.
2363
2364         (BindingsTests.run_tests):
2365         Filter tests using the passed in patterns.
2366
2367 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
2368
2369         Followup fix after r210503.
2370         https://bugs.webkit.org/show_bug.cgi?id=166887
2371
2372         Reviewed by Alex Christensen.
2373
2374         After <http://trac.webkit.org/changeset/210503>, test results are written to a
2375         duplicated file handle on Windows. This patch fixes the remaining call sites.
2376
2377         * DumpRenderTree/PixelDumpSupport.cpp:
2378         * DumpRenderTree/TestRunner.cpp:
2379         (TestRunner::waitToDumpWatchdogTimerFired):
2380         * DumpRenderTree/TestRunner.h:
2381         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2382         * DumpRenderTree/win/DumpRenderTree.cpp:
2383         * DumpRenderTree/win/DumpRenderTreeWin.h:
2384         * DumpRenderTree/win/TestRunnerWin.cpp:
2385         (TestRunner::setSpellCheckerLoggingEnabled):
2386
2387 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
2388
2389         Add committer status for Megan
2390         https://bugs.webkit.org/show_bug.cgi?id=166954
2391
2392         Reviewed by Tim Horton.
2393
2394         Add committer status for Megan Gardner
2395
2396         * Scripts/webkitpy/common/config/contributors.json:
2397
2398 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2399
2400         Unreviewed test fix after r210599.
2401
2402         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2403         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
2404
2405 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2406
2407         Unreviewed build fix after r210599.
2408
2409         Add missing files.
2410
2411         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2412         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2413
2414 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2415
2416         File scheme should not allow access of a resource on a different volume.
2417         https://bugs.webkit.org/show_bug.cgi?id=158552
2418         <rdar://problem/15307582>
2419
2420         Reviewed by Alex Christensen.
2421
2422         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2423         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2424         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2425
2426 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2427
2428         Unreviewed, rolling out r210571.
2429
2430         This change broke the 32-bit macOS build and caused LayoutTest
2431         failures.
2432
2433         Reverted changeset:
2434
2435         "File scheme should not allow access of a resource on a
2436         different volume."
2437         https://bugs.webkit.org/show_bug.cgi?id=158552
2438         http://trac.webkit.org/changeset/210571
2439
2440 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2441
2442         [GTK] install-dependencies script misses gdb
2443         https://bugs.webkit.org/show_bug.cgi?id=166917
2444
2445         Reviewed by Michael Catanzaro.
2446
2447         gdb is needed for generating the crash logs.
2448
2449         * gtk/install-dependencies:
2450
2451 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2452
2453         [GTK] No way for applications to set notification permissions without waiting for permission request
2454         https://bugs.webkit.org/show_bug.cgi?id=163366
2455
2456         Reviewed by Carlos Garcia Campos.
2457
2458         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2459         (testWebViewNotification):
2460         (setInitialNotificationPermissionsAllowedCallback):
2461         (setInitialNotificationPermissionsDisallowedCallback):
2462         (testWebViewNotificationInitialPermissionAllowed):
2463         (testWebViewNotificationInitialPermissionDisallowed):
2464         (beforeAll):
2465         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2466         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2467         (WebViewTest::WebViewTest):
2468         (WebViewTest::initializeWebView):
2469         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2470
2471 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2472
2473         MobileMiniBrowser tests don't work by default
2474         https://bugs.webkit.org/show_bug.cgi?id=166910
2475
2476         Reviewed by Alex Christensen.
2477
2478         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2479         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2480
2481 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2482
2483         File scheme should not allow access of a resource on a different volume.
2484         https://bugs.webkit.org/show_bug.cgi?id=158552
2485         <rdar://problem/15307582>
2486
2487         Reviewed by Alex Christensen.
2488
2489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2490         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2491         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2492
2493 2017-01-10  Mark Lam  <mark.lam@apple.com>
2494
2495         Reverting run-jsc-stress-tests' $buildType to use string values.
2496         https://bugs.webkit.org/show_bug.cgi?id=166912
2497
2498         Rubber stamped by Filip Pizlo.
2499
2500         This is so that we can test for it in the tests e.g.
2501         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2502
2503         * Scripts/run-jsc-stress-tests:
2504
2505 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2506
2507         Temporarily add back the file removed in r210463 to unbreak internal bots.
2508
2509         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2510
2511 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2512
2513         svn-apply failed to apply a patch (deleting file with svn property)
2514         https://bugs.webkit.org/show_bug.cgi?id=165953
2515
2516         Reviewed by Daniel Bates.
2517
2518         * Scripts/VCSUtils.pm:
2519         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2520         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2521
2522 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2523
2524         Update flakiness dashboard configuration.
2525         https://bugs.webkit.org/show_bug.cgi?id=166869
2526
2527         Reviewed by Alexey Proskuryakov.
2528
2529         * TestResultServer/static-dashboards/builders.jsonp:
2530         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2531
2532 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2533
2534         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2535         https://bugs.webkit.org/show_bug.cgi?id=165232
2536
2537         Unreviewed follow-up patch after r210539 and r210523.
2538
2539         Instead of using that environment variable, the argument
2540         --display-server=xorg should be passed now.
2541
2542         The GTK+ performance bot was the only bot using this, and is
2543         already passing --display-server=xorg after r210539.
2544
2545         * Scripts/webkitpy/port/gtk.py:
2546         (GtkPort._driver_class):
2547
2548 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2549
2550         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2551         https://bugs.webkit.org/show_bug.cgi?id=166872
2552
2553         Reviewed by Michael Catanzaro.
2554
2555         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2556         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2557         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2558         The step RunWebKitTests already has support for it.
2559
2560         * BuildSlaveSupport/build.webkit.org-config/config.json:
2561         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2562         (RunGtkAPITests.start):
2563         (RunAndUploadPerfTests.start):
2564         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2565
2566 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2567
2568         Unreviewed, rolling out r210531.
2569
2570         This change broke the 32-bit macOS build and caused LayoutTest
2571         failures.
2572
2573         Reverted changeset:
2574
2575         "File scheme should not allow access of a resource on a
2576         different volume."
2577         https://bugs.webkit.org/show_bug.cgi?id=158552
2578         http://trac.webkit.org/changeset/210531
2579
2580 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2581
2582         File scheme should not allow access of a resource on a different volume.
2583         https://bugs.webkit.org/show_bug.cgi?id=158552
2584         <rdar://problem/15307582>
2585
2586         Reviewed by Alex Christensen.
2587
2588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2589         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2590         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2591
2592 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2593
2594         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2595         https://bugs.webkit.org/show_bug.cgi?id=165232
2596
2597         Reviewed by Michael Catanzaro.
2598
2599         Add a new WaylandDriver to run the tests in the user current wayland session.
2600
2601         Also merge all the configuration options for selecting the display server inside one
2602         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2603
2604         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2605
2606         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2607         (TestRunner._create_driver):
2608         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2609         (parse_args):
2610         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2611         (PerfTestsRunner._parse_args):
2612         * Scripts/webkitpy/port/gtk.py:
2613         (GtkPort.__init__):
2614         (GtkPort._driver_class):
2615         (GtkPort._search_paths):
2616         * Scripts/webkitpy/port/waylanddriver.py: Added.
2617         (WaylandDriver):
2618         (WaylandDriver.check_driver):
2619         (WaylandDriver._setup_environ_for_test):
2620         (WaylandDriver._start):
2621
2622 2017-01-09  Andy Estes  <aestes@apple.com>
2623
2624         [QuickLook] Add a layout test for webkit.org/b/135651
2625         https://bugs.webkit.org/show_bug.cgi?id=166855
2626
2627         Reviewed by Andreas Kling.
2628
2629         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2630         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2631         errors with code WebKitErrorCannotShowURL.
2632         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2633         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2634         not specific to WebKit2 error codes.
2635
2636 2017-01-09  Antoine Quint  <graouts@apple.com>
2637
2638         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2639         https://bugs.webkit.org/show_bug.cgi?id=166837
2640
2641         Reviewed by Alex Christensen.
2642
2643         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2644         the provided value when trying to determine the path to the test file. Failing
2645         that, we use the computed URL or the raw path provided to cover all cases.
2646         
2647         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2648         by applying this patch and seeing the number test failures dramatically reduced
2649         with WK1 due to the option to turn modern media controls off for older media controls
2650         tests.
2651
2652         * DumpRenderTree/DumpRenderTree.h:
2653         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2654         (parseInputLine):
2655         * DumpRenderTree/TestOptions.h:
2656         * DumpRenderTree/TestOptions.mm:
2657         (TestOptions::TestOptions):
2658         * DumpRenderTree/mac/DumpRenderTree.mm:
2659         (runTest):
2660
2661 2017-01-09  Milan Crha  <mcrha@redhat.com>
2662
2663         prepare-ChangeLog: Correct help string for --style option
2664         https://bugs.webkit.org/show_bug.cgi?id=166725
2665
2666         Reviewed by Alexey Proskuryakov.
2667
2668         * Scripts/prepare-ChangeLog:
2669         (main):
2670
2671 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2672
2673         https://bugs.webkit.org/show_bug.cgi?id=166839
2674         Add php7 support for macOS.
2675         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2676
2677         Reviewed by Alexey Proskuryakov.
2678
2679         * Scripts/webkitpy/port/base.py:
2680         (Port._is_darwin_php_version_7):
2681         (Port._debian_php_version):
2682         (Port):
2683         (Port._darwin_php_version):
2684         (Port._apache_config_file_name_for_platform):
2685
2686 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2687
2688         [GTK] Should support key and code properties on keyboard events
2689         https://bugs.webkit.org/show_bug.cgi?id=166759
2690
2691         Reviewed by Carlos Garcia Campos.
2692
2693         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2694         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2695         on tests.
2696
2697 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2698
2699         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2700         https://bugs.webkit.org/show_bug.cgi?id=166760
2701
2702         Reviewed by Darin Adler.
2703
2704         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2705         We can work around that by duplicating and redirecting stdout.
2706
2707         * DumpRenderTree/PixelDumpSupport.cpp:
2708         (dumpWebViewAsPixelsAndCompareWithExpected):
2709         (printPNG):
2710         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2711         (logEventProc):
2712         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2713         (DRTDesktopNotificationPresenter::showDesktopNotification):
2714         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2715         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2716         * DumpRenderTree/win/DumpRenderTree.cpp:
2717         (dumpFrameScrollPosition):
2718         (dumpHistoryItem):
2719         (dumpBackForwardList):
2720         (dump):
2721         (runTest):
2722         (main):
2723         * DumpRenderTree/win/DumpRenderTreeWin.h:
2724         * DumpRenderTree/win/EditingDelegate.cpp:
2725         (EditingDelegate::shouldBeginEditingInDOMRange):
2726         (EditingDelegate::shouldEndEditingInDOMRange):
2727         (EditingDelegate::shouldInsertNode):
2728         (EditingDelegate::shouldInsertText):
2729         (EditingDelegate::shouldDeleteDOMRange):
2730         (EditingDelegate::shouldChangeSelectedDOMRange):
2731         (EditingDelegate::shouldApplyStyle):
2732         (EditingDelegate::shouldChangeTypingStyle):
2733         (EditingDelegate::doPlatformCommand):
2734         (EditingDelegate::webViewDidBeginEditing):
2735         (EditingDelegate::webViewDidChange):
2736         (EditingDelegate::webViewDidEndEditing):
2737         (EditingDelegate::webViewDidChangeTypingStyle):
2738         (EditingDelegate::webViewDidChangeSelection):
2739         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2740         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2741         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2742         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2743         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2744         (FrameLoadDelegate::didCommitLoadForFrame):
2745         (FrameLoadDelegate::didReceiveTitle):
2746         (FrameLoadDelegate::didFinishLoadForFrame):
2747         (FrameLoadDelegate::didFailLoadWithError):
2748         (FrameLoadDelegate::willPerformClientRedirectToURL):
2749         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2750         (FrameLoadDelegate::windowScriptObjectAvailable):
2751         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2752         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2753         (FrameLoadDelegate::didDisplayInsecureContent):
2754         (FrameLoadDelegate::didRunInsecureContent):
2755         (FrameLoadDelegate::webViewProgressFinishedNotification):
2756         * DumpRenderTree/win/HistoryDelegate.cpp:
2757         (HistoryDelegate::didNavigateWithNavigationData):
2758         (HistoryDelegate::didPerformClientRedirectFromURL):
2759         (HistoryDelegate::didPerformServerRedirectFromURL):
2760         (HistoryDelegate::updateHistoryTitle):
2761         (HistoryDelegate::populateVisitedLinksForWebView):
2762         * DumpRenderTree/win/PolicyDelegate.cpp:
2763         (PolicyDelegate::decidePolicyForNavigationAction):
2764         (PolicyDelegate::unableToImplementPolicyWithError):
2765         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2766         (ResourceLoadDelegate::willSendRequest):
2767         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2768         (ResourceLoadDelegate::didReceiveResponse):
2769         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2770         (ResourceLoadDelegate::didFailLoadingWithError):
2771         * DumpRenderTree/win/TestRunnerWin.cpp:
2772         (TestRunner::addDisallowedURL):
2773         (TestRunner::originsWithApplicationCache):
2774         (TestRunner::setStorageDatabaseIdleInterval):
2775         (TestRunner::closeIdleLocalStorageDatabases):
2776         (TestRunner::copyDecodedHostName):
2777         (TestRunner::copyEncodedHostName):
2778         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2779         (TestRunner::isGeolocationProviderActive):
2780         (TestRunner::pathToLocalResource):
2781         (TestRunner::setMockDeviceOrientation):
2782         (TestRunner::setMockGeolocationPosition):
2783         (TestRunner::setMockGeolocationPositionUnavailableError):
2784         (TestRunner::setSpatialNavigationEnabled):
2785         (TestRunner::setAutomaticLinkDetectionEnabled):
2786         (TestRunner::isCommandEnabled):
2787         (TestRunner::authenticateSession):
2788         (TestRunner::addChromeInputField):
2789         (TestRunner::removeChromeInputField):
2790         (TestRunner::focusWebView):
2791         (TestRunner::grantWebNotificationPermission):
2792         (TestRunner::denyWebNotificationPermission):
2793         (TestRunner::removeAllWebNotificationPermissions):
2794         (TestRunner::simulateWebNotificationClick):
2795         (TestRunner::imageCountInGeneralPasteboard):
2796         * DumpRenderTree/win/UIDelegate.cpp:
2797         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2798         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2799         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2800         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2801         (UIDelegate::webViewAddMessageToConsole):
2802         (UIDelegate::exceededDatabaseQuota):
2803         (UIDelegate::setStatusText):
2804         (UIDelegate::didPressMissingPluginButton):
2805
2806 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2807
2808         Add a setting to create editable MiniBrowser windows by default
2809         https://bugs.webkit.org/show_bug.cgi?id=166806
2810
2811         Reviewed by Beth Dakin.
2812
2813         * MiniBrowser/mac/AppDelegate.m:
2814         (-[BrowserAppDelegate createBrowserWindowController:]):
2815         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2816         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2817         * MiniBrowser/mac/SettingsController.h:
2818         * MiniBrowser/mac/SettingsController.m:
2819         (-[SettingsController _populateMenu]):
2820         (-[SettingsController validateMenuItem:]):
2821         (-[SettingsController toggleCreateEditorByDefault:]):
2822         (-[SettingsController createEditorByDefault]):
2823         Add a setting and update the key equivalents accordingly.
2824         Also make sure to make the right kind of window on launch.
2825
2826 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2827
2828         Fix the 32-bit build.
2829
2830         * MiniBrowser/mac/BrowserWindowController.h:
2831         * MiniBrowser/mac/BrowserWindowController.m:
2832
2833 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2834
2835         Fix the 32-bit build.
2836
2837         * MiniBrowser/mac/BrowserWindowController.m:
2838
2839 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2840
2841         Make it possible to drop HTML files on the MiniBrowser icon
2842         https://bugs.webkit.org/show_bug.cgi?id=166802
2843
2844         Reviewed by Simon Fraser.
2845
2846         * MiniBrowser/mac/AppDelegate.m:
2847         (-[BrowserAppDelegate application:openFile:]):
2848         * MiniBrowser/mac/Info.plist:
2849         If you're using an editable window, the usual trick of dropping on the
2850         window doesn't work anymore (it makes an <attachment> instead).
2851
2852 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2853
2854         MiniBrowser window gets smaller each time it is instantiated
2855         https://bugs.webkit.org/show_bug.cgi?id=166807
2856
2857         Reviewed by Andy Estes.
2858
2859         * MiniBrowser/mac/BrowserWindowController.m:
2860         (-[BrowserWindowController windowDidLoad]):
2861         * MiniBrowser/mac/BrowserWindow.xib:
2862         Turn on full-window content view support with IB, instead of waiting
2863         until after the views have been loaded. This seems to resolve the
2864         longstanding ever-shrinking-window problem.
2865
2866 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2867
2868         Add indent/outdent items to MiniBrowser's new format menu
2869         https://bugs.webkit.org/show_bug.cgi?id=166805
2870
2871         Reviewed by Dan Bernstein.
2872
2873         * MiniBrowser/mac/MainMenu.xib:
2874
2875 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2876
2877         Add a stock Format menu to MiniBrowser
2878         https://bugs.webkit.org/show_bug.cgi?id=166804
2879
2880         Reviewed by Andy Estes.
2881
2882         * MiniBrowser/mac/MainMenu.xib:
2883         Many of the features automatically work with editable web views.
2884         However, this seems to expose a bug where none of the font-related features
2885         (Cmd-B, for example) work until the first time the font panel is shown,
2886         per process, which will need to be investigated separately.
2887
2888 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2889
2890         Remove unused applicationWillTerminate methods from MiniBrowser
2891         https://bugs.webkit.org/show_bug.cgi?id=166803
2892
2893         Reviewed by Andy Estes.
2894
2895         * MiniBrowser/mac/AppDelegate.m:
2896         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
2897         * MiniBrowser/mac/BrowserWindowController.h:
2898         * MiniBrowser/mac/BrowserWindowController.m:
2899         (-[BrowserWindowController applicationTerminating]): Deleted.
2900         * MiniBrowser/mac/WK1BrowserWindowController.m:
2901         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
2902         * MiniBrowser/mac/WK2BrowserWindowController.m:
2903         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
2904
2905 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2906
2907         Add the ability to create empty contentEditable windows in MiniBrowser
2908         https://bugs.webkit.org/show_bug.cgi?id=166801
2909
2910         Reviewed by Wenson Hsieh.
2911
2912         * MiniBrowser/mac/AppDelegate.h:
2913         * MiniBrowser/mac/AppDelegate.m:
2914         (-[BrowserAppDelegate createBrowserWindowController:]):
2915         (-[BrowserAppDelegate newWindow:]):
2916         (-[BrowserAppDelegate newEditorWindow:]):
2917         (-[BrowserAppDelegate openDocument:]):
2918         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2919         * MiniBrowser/mac/BrowserWindowController.h:
2920         * MiniBrowser/mac/BrowserWindowController.m:
2921         (-[BrowserWindowController loadHTMLString:]):
2922         (-[BrowserWindowController toggleEditable:]):
2923         * MiniBrowser/mac/MainMenu.xib:
2924         * MiniBrowser/mac/WK1BrowserWindowController.m:
2925         (-[WK1BrowserWindowController awakeFromNib]):
2926         (-[WK1BrowserWindowController loadHTMLString:]):
2927         (-[WK1BrowserWindowController validateMenuItem:]):
2928         (-[WK1BrowserWindowController setEditable:]):
2929         (-[WK1BrowserWindowController updateTitle:]):
2930         * MiniBrowser/mac/WK2BrowserWindowController.m:
2931         (-[WK2BrowserWindowController awakeFromNib]):
2932         (-[WK2BrowserWindowController validateMenuItem:]):
2933         (-[WK2BrowserWindowController setEditable:]):
2934         (-[WK2BrowserWindowController updateTitle:]):
2935         (-[WK2BrowserWindowController loadHTMLString:]):
2936         Merge more functionality from WebEditingTester.
2937         Add two menu items for creating empty editable WebKit1/2 windows.
2938         Add a menu item to the Edit menu to toggle editability on any window.
2939
2940 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2941
2942         Implement find-in-page in MiniBrowser
2943         https://bugs.webkit.org/show_bug.cgi?id=166799
2944
2945         Reviewed by Andy Estes.
2946
2947         * MiniBrowser/mac/BrowserWindow.xib:
2948         * MiniBrowser/mac/BrowserWindowController.h:
2949         * MiniBrowser/mac/BrowserWindowController.m:
2950         (-[BrowserWindowController find:]): Deleted.
2951         * MiniBrowser/mac/MainMenu.xib:
2952         * MiniBrowser/mac/WK1BrowserWindowController.m:
2953         (-[WK1BrowserWindowController toggleShrinkToFit:]):
2954         (-[WK1BrowserWindowController find:]): Deleted.
2955         * MiniBrowser/mac/WK2BrowserWindowController.m:
2956         (-[WK2BrowserWindowController awakeFromNib]):
2957         (-[WK2BrowserWindowController dealloc]):
2958         (-[WK2BrowserWindowController validateMenuItem:]):
2959         (-[WK2BrowserWindowController performTextFinderAction:]):
2960         (-[WK2BrowserWindowController findBarView]):
2961         (-[WK2BrowserWindowController setFindBarView:]):
2962         (-[WK2BrowserWindowController isFindBarVisible]):
2963         (-[WK2BrowserWindowController setFindBarVisible:]):
2964         (-[WK2BrowserWindowController contentView]):
2965         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
2966         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
2967         (-[WK2BrowserWindowController find:]): Deleted.
2968         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
2969         protocol. At first glance, it's pretty broken, but vaguely works.
2970
2971 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2972
2973         Share the implementation of MiniBrowser view hiding functionality
2974         https://bugs.webkit.org/show_bug.cgi?id=166800
2975
2976         Reviewed by Andy Estes.
2977
2978         * MiniBrowser/mac/BrowserWindowController.m:
2979         (-[BrowserWindowController showHideWebView:]):
2980         (-[BrowserWindowController removeReinsertWebView:]):
2981         * MiniBrowser/mac/WK1BrowserWindowController.m:
2982         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
2983         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
2984         * MiniBrowser/mac/WK2BrowserWindowController.m:
2985         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
2986         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
2987         Move the implementation of these two things to the shared superclass,
2988         since they don't depend on WebKit-specific things.
2989         Also, there was no reason to retain the (WK)WebView while it was unparented,
2990         as the BrowserWindowController maintains a reference the entire time.
2991
2992 2017-01-06  Andy Estes  <aestes@apple.com>
2993
2994         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
2995         https://bugs.webkit.org/show_bug.cgi?id=166789
2996
2997         Reviewed by Alex Christensen.
2998
2999         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3000         * DumpRenderTree/PlatformMac.cmake:
3001         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
3002         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
3003         * DumpRenderTree/mac/DumpRenderTree.mm:
3004         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3005         createXMLStringFromWebArchiveData().
3006         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
3007         * WebKitTestRunner/Configurations/Base.xcconfig:
3008         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
3009         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3010         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3011         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3012         createXMLStringFromWebArchiveData().
3013         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
3014         * WebKitTestRunner/PlatformMac.cmake:
3015         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3016         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
3017
3018 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3019
3020         Minor cleanups to IndentOutdentCommand and related code
3021         https://bugs.webkit.org/show_bug.cgi?id=166791
3022
3023         Reviewed by Simon Fraser.
3024
3025         * WebEditingTester/EditingOperations.m:
3026         (editingOperations):
3027         Add the outdent operation to WebEditingTester.
3028
3029 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3030
3031         Create a plan and a patch files for MotionMark and delete the Animometer's ones
3032         https://bugs.webkit.org/show_bug.cgi?id=166785
3033
3034         Reviewed by Ryosuke Niwa.
3035
3036         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3037         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
3038
3039 2017-01-06  Antoine Quint  <graouts@apple.com>
3040
3041         Support webkit-test-runner key-value pairs in http tests
3042         https://bugs.webkit.org/show_bug.cgi?id=149812
3043
3044         Reviewed by Alex Christensen.
3045
3046         We pass the absolute path for a test through to WKTR so that we can parse
3047         tests that are running as URLs for webkit-test-runner options.
3048
3049         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3050         (parseInputLine):
3051
3052         Explicitly skip the --absolute-path option in DRT or else we'd crash.
3053
3054         * Scripts/webkitpy/port/driver.py:
3055         (Driver._command_from_driver_input):
3056
3057         Pass the absolute path to the file through the CLI.
3058
3059         * WebKitTestRunner/TestController.cpp:
3060         (WTR::updateTestOptionsFromTestHeader):
3061         (WTR::TestController::testOptionsForTest):
3062         (WTR::parseInputLine):
3063         (WTR::TestController::runTest):
3064         * WebKitTestRunner/TestController.h:
3065
3066 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3067
3068         Warning about unconnectable outlets when opening a MiniBrowser window
3069         https://bugs.webkit.org/show_bug.cgi?id=166756
3070
3071         Reviewed by Dan Bernstein.
3072
3073         * MiniBrowser/mac/BrowserWindow.xib:
3074         When launching MiniBrowser, it says:
3075         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
3076             (MBToolbarItem): missing setter or instance variable
3077         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
3078             (NSButtonCell): missing setter or instance variable.
3079
3080         It looks like someone added the connection from the share button
3081         to the BrowserWindowController three times; only one of the connections
3082         is valid. Remove the other two.
3083
3084 2017-01-05  Keith Rollin  <krollin@apple.com>
3085
3086         Add WebCore::URL::protocolHostAndPort
3087         https://bugs.webkit.org/show_bug.cgi?id=166426
3088
3089         Reviewed by Alex Christensen.
3090
3091         Add test for protocolHostAndPort.
3092
3093         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3094         (TestWebKitAPI::TEST_F):
3095
3096 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
3097
3098         [Win] Archive test result is failing.
3099         https://bugs.webkit.org/show_bug.cgi?id=166720
3100
3101         Reviewed by Alex Christensen.
3102
3103         Deleting the layout test result folder is sometimes failing
3104         on Windows. This is not a critical error.
3105
3106         * BuildSlaveSupport/test-result-archive:
3107         (archiveTestResults):
3108
3109 2017-01-04  Tomas Popela  <tpopela@redhat.com>
3110
3111         [GTK] Minibrowser: Add printing support
3112         https://bugs.webkit.org/show_bug.cgi?id=165298
3113
3114         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
3115         an error during the print, it's printed on the console.
3116
3117         Reviewed by Michael Catanzaro.
3118
3119         * MiniBrowser/gtk/BrowserWindow.c:
3120         (webKitPrintOperationFailedCallback):
3121         (printPage):
3122         (browser_window_init):
3123
3124 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
3125
3126         [css-grid] Fix crash clamping grid lines
3127         https://bugs.webkit.org/show_bug.cgi?id=166637
3128
3129         Reviewed by Darin Adler.
3130
3131         Creates new unit test to verify that the maximum tracks limit
3132         is used in GridPosition too.
3133
3134         * TestWebKitAPI/PlatformEfl.cmake:
3135         * TestWebKitAPI/PlatformGTK.cmake:
3136         * TestWebKitAPI/PlatformWin.cmake:
3137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3138         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
3139         (TestWebKitAPI::TEST):
3140
3141 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3142
3143         Move editing history scripts to WebCore PrivateHeaders
3144         https://bugs.webkit.org/show_bug.cgi?id=166709
3145         <rdar://problem/29876612>
3146
3147         Reviewed by Dan Bernstein.
3148
3149         Update references to editing script files in WebCore that were moved.
3150
3151         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
3152
3153 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3154
3155         Unreviewed, build fix after r210313 part 2
3156         https://bugs.webkit.org/show_bug.cgi?id=166676
3157
3158         Add 'U' suffix.
3159
3160         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3161         (TestWebKitAPI::TEST):
3162         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3163         (TestWebKitAPI::TEST):
3164
3165 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3166
3167         Limit thread name appropriately
3168         https://bugs.webkit.org/show_bug.cgi?id=166676
3169
3170         Reviewed by Sam Weinig.
3171
3172         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3173         (TestWebKitAPI::TEST):
3174         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3175         (TestWebKitAPI::TEST):
3176
3177 2017-01-04  Andy Estes  <aestes@apple.com>
3178
3179         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
3180         https://bugs.webkit.org/show_bug.cgi?id=166696
3181
3182         Reviewed by Tim Horton.
3183
3184         * TestWebKitAPI/PlatformGTK.cmake:
3185         * TestWebKitAPI/PlatformWin.cmake:
3186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3187         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
3188         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
3189         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
3190         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
3191         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
3192         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
3193
3194 2017-01-03  Brian Burg  <bburg@apple.com>
3195
3196         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
3197         https://bugs.webkit.org/show_bug.cgi?id=166003
3198         <rdar://problem/28718990>
3199
3200         Reviewed by Joseph Pecoraro.
3201
3202         Teach run-inspector-generator-tests to generate test output using the platform name
3203         derived from the directory that the test is in. For example, tests in the /generic/
3204         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
3205
3206         * Scripts/webkitpy/inspector/main.py:
3207         (InspectorGeneratorTests.generate_from_json):
3208         (InspectorGeneratorTests.run_tests):
3209         (InspectorGeneratorTests.main):
3210
3211 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3212
3213         Unreviewed cmake buildfix after r210266.
3214
3215         * DumpRenderTree/PlatformMac.cmake:
3216
3217 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3218
3219         Provide a setting for clients to always prefer low-power WebGL
3220         https://bugs.webkit.org/show_bug.cgi?id=166675
3221         <rdar://problem/29834093>
3222
3223         Reviewed by Dan Bernstein.
3224
3225         * MiniBrowser/mac/Info.plist:
3226         Have MiniBrowser claim to be a modern app that supports
3227         automatic graphics switching. WebKit needs to support automatic
3228         graphics switching, so our test app might as well. Without this
3229         Info.plist parameter, this change has no effect, and bringing up
3230         a WebGL context still brings up the discrete GPU (also true of the
3231         existing web-exposed preferLowPowerToHighPerformance API).
3232
3233 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3234
3235         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
3236         https://bugs.webkit.org/show_bug.cgi?id=166645
3237
3238         Reviewed by Carlos Garcia Campos.
3239
3240         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3241         (TestWebKitAPI::TEST):
3242
3243 2017-01-03  Andy Estes  <aestes@apple.com>
3244
3245         Place all the Cocoa WebCore API tests in the same directory
3246         https://bugs.webkit.org/show_bug.cgi?id=166673
3247
3248         Reviewed by Michael Catanzaro.
3249
3250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3251         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
3252         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
3253         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
3254
3255 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3256
3257         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3258         https://bugs.webkit.org/show_bug.cgi?id=166450
3259         <rdar://problem/29447824>
3260
3261         Reviewed by Darin Adler.
3262
3263         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3264         * DumpRenderTree/TestRunner.cpp:
3265         (TestRunner::staticFunctions):
3266         * DumpRenderTree/mac/TestRunnerMac.mm:
3267         (setSpellCheckerLoggingEnabledCallback):
3268         * DumpRenderTree/win/TestRunnerWin.cpp:
3269         (setSpellCheckerLoggingEnabledCallback):
3270         * DumpRenderTree/mac/DumpRenderTree.mm:
3271         (resetWebViewToConsistentStateBeforeTesting):
3272         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
3273         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
3274         (stringForCorrectionResponse):
3275         (drt_NSSpellChecker_recordResponseToCorrection):
3276         (swizzleNSSpellCheckerMethodsIfNeeded):
3277         (setSpellCheckerLoggingEnabled):
3278         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
3279         set to true, logs to stdout (which ends up in the test result) whenever
3280         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3281         is called, and then calls the original method. It is reset to false between tests.
3282
3283 2017-01-03  Sam Weinig  <sam@webkit.org>
3284
3285         Make WTF::Expected support Ref template parameters
3286         https://bugs.webkit.org/show_bug.cgi?id=166662
3287
3288         Reviewed by Alex Christensen.
3289
3290         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3291         (TestWebKitAPI::TEST):
3292         Add tests for using Ref with Expected.
3293
3294 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3295
3296         [GTK] Expose WebKitSecurityOrigin API
3297         https://bugs.webkit.org/show_bug.cgi?id=166632
3298
3299         Reviewed by Carlos Garcia Campos.
3300
3301         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3302         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
3303         (testSecurityOriginBasicConstructor):
3304         (testSecurityOriginURIConstructor):
3305         (testSecurityOriginDefaultPort):
3306         (testSecurityOriginFileURI):
3307         (testSecurityOriginDataURI):
3308         (beforeAll):
3309         (afterAll):
3310
3311 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3312
3313         [GTK] HTTP auth layout tests are flaky
3314         https://bugs.webkit.org/show_bug.cgi?id=158919
3315
3316         Reviewed by Michael Catanzaro.
3317
3318         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
3319         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
3320         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
3321         missing valac in the bots.
3322
3323 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3324
3325         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
3326         https://bugs.webkit.org/show_bug.cgi?id=165797
3327
3328         Reviewed by Michael Catanzaro.
3329
3330         Move directory ruleset after all exclude rules of Source rulset.
3331
3332         * gtk/manifest.txt.in:
3333
3334 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3335
3336         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
3337         https://bugs.webkit.org/show_bug.cgi?id=166636
3338
3339         Reviewed by Darin Adler.
3340
3341         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3342         (TestWebKitAPI::TEST):
3343
3344 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
3345
3346         [GTK] WebCore/CSSParser unit test is not being built
3347         https://bugs.webkit.org/show_bug.cgi?id=166492
3348
3349         Reviewed by Michael Catanzaro.
3350
3351         This test was introduced in r175930, but we were not building
3352         it on GTK+ port since r176015.
3353         This patch marks the test to be built again on GTK+.
3354         JFTR, the test is passing right now.
3355
3356         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
3357         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
3358
3359 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
3360
3361         AX: Expose block quote level to iOS API
3362         https://bugs.webkit.org/show_bug.cgi?id=166629
3363         <rdar://problem/29834793>
3364
3365         Reviewed by Darin Adler.
3366
3367         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3368         (AccessibilityUIElement::numberAttributeValue):
3369         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3370         (WTR::AccessibilityUIElement::numberAttributeValue):
3371
3372 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
3373
3374         SecurityOrigin::create triplet constructor does not canonicalize port
3375         https://bugs.webkit.org/show_bug.cgi?id=166624
3376
3377         Reviewed by Daniel Bates.
3378
3379         * TestWebKitAPI/PlatformGTK.cmake:
3380         * TestWebKitAPI/PlatformWin.cmake:
3381         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3382         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
3383         (TestWebKitAPI::SecurityOriginTest::SetUp):
3384         (TestWebKitAPI::TEST_F):
3385
3386 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3387
3388         [GTK] Improve user agent construction
3389         https://bugs.webkit.org/show_bug.cgi?id=142074
3390
3391         Reviewed by Carlos Garcia Campos.
3392
3393         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3394         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3395         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3396         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3397         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3398         (TestWebKitAPI::TEST):
3399
3400 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3401
3402         [GTK] Improve user agent construction
3403         https://bugs.webkit.org/show_bug.cgi?id=142074
3404
3405         Reviewed by Carlos Garcia Campos.
3406
3407         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3408         (TestWebKitAPI::TEST):
3409
3410 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
3411
3412         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
3413         https://bugs.webkit.org/show_bug.cgi?id=166472
3414         rdar://problem/29675551
3415
3416         Reviewed by Tim Horton.
3417
3418         These changes are necessary to allow the mouse to leave the WTR window while
3419         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
3420         (which DRT does); we'd always go through mouseMoved, which hits an early return
3421         in WebViewImpl::mouseMoved() when the point is outside the view.
3422
3423         * WebKitTestRunner/mac/EventSenderProxy.mm:
3424         (WTR::EventSenderProxy::mouseMoveTo):
3425
3426 2016-12-23  Andy Estes  <aestes@apple.com>
3427
3428         [iOS] Fix some crashing webarchive tests
3429         https://bugs.webkit.org/show_bug.cgi?id=166470
3430
3431         Reviewed by Andreas Kling.
3432
3433         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
3434         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
3435         so this change uses that on both platforms.
3436
3437         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
3438         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
3439         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
3440         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
3441         * WebKitTestRunner/PlatformMac.cmake:
3442         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3443         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3444
3445 2016-12-22  Saam Barati  <sbarati@apple.com>
3446
3447         WebAssembly: Silence the output of the spec-tests
3448         https://bugs.webkit.org/show_bug.cgi?id=166417
3449
3450         Reviewed by Mark Lam.
3451
3452         * Scripts/run-jsc-stress-tests:
3453
3454 2016-12-22  Zhuo Li  <zachli@apple.com>
3455
3456         [Cocoa] SPI for setloadsImagesAutomatically.
3457         https://bugs.webkit.org/show_bug.cgi?id=166401.
3458
3459         Reviewed by Darin Adler.
3460
3461         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3462         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3463         _loadsImagesAutomatically returns YES.
3464
3465 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3466
3467         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3468         https://bugs.webkit.org/show_bug.cgi?id=161328
3469         <rdar://problem/28475977>
3470
3471         Reviewed by Darin Adler.
3472
3473         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3474         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3475         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3476         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3477         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3478         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3479         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3480         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3481         we finish running a test and before we load the next test.
3482
3483         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3484         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3485         previous test started zooming and then finished before zooming completed. Since this happens before the next
3486         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3487
3488         * WebKitTestRunner/ios/TestControllerIOS.mm:
3489         (WTR::TestController::platformResetStateToConsistentValues):
3490
3491 2016-12-22  Jer Noble  <jer.noble@apple.com>
3492
3493         Muted media element playback should not interrupt other audio playback
3494         https://bugs.webkit.org/show_bug.cgi?id=166347
3495
3496         Reviewed by Eric Carlson.
3497
3498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3499         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3500         (TestWebKitAPI::TEST):
3501         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3502
3503 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3504
3505         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3506         https://bugs.webkit.org/show_bug.cgi?id=166346
3507
3508         Reviewed by Carlos Garcia Campos.
3509
3510         Enable WebRTC by default to simplify testing.
3511
3512         * MiniBrowser/gtk/main.c:
3513         (main):
3514
3515 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3516
3517         REGRESSION: API test failure: WKWebView.LocalStorageClear
3518         https://bugs.webkit.org/show_bug.cgi?id=166032
3519         <rdar://problem/29758423>
3520
3521         Reviewed by Simon Fraser.
3522
3523         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3524         to ensure that the view is destroyed before the callback fires.
3525
3526         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3527         (TEST):
3528
3529 2016-12-21  Saam Barati  <sbarati@apple.com>
3530
3531         WebAssembly: Import spec tests
3532         https://bugs.webkit.org/show_bug.cgi?id=166395
3533
3534         Rubber stamped by Keith Miller.
3535
3536         * Scripts/run-jsc-stress-tests:
3537
3538 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3539
3540         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3541         https://bugs.webkit.org/show_bug.cgi?id=166033
3542         <rdar://problem/29758428>
3543
3544         Reviewed by Simon Fraser.
3545
3546         Add an @autoreleasepool around the code that allocates the WKWebView, 
3547         so that it can be destroyed by removing the last reference in _downloadDidStart.
3548
3549         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3550         (TEST):
3551
3552 2016-12-21  Daniel Bates  <dabates@apple.com>
3553
3554         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3555         https://bugs.webkit.org/show_bug.cgi?id=166356
3556
3557         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3558         as a means to allow a test to explicit allow an embedding client to open a new windows
3559         such that the default behavior is for the embedding client to forbid such an action.
3560         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3561         it is currently skipped on WebKit2 because questions were raised in the patch for
3562         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3563         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3564         this test.
3565
3566         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3567         (WTR::TestRunner::setCanOpenWindows):
3568
3569 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3570
3571         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3572         https://bugs.webkit.org/show_bug.cgi?id=166031
3573
3574         Reviewed by Tim Horton.
3575         
3576         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3577         to ensure that the view is destroyed before the callback fires.
3578
3579         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3580
3581 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3582
3583         Throw Exception when test doesn't clean up HID Events properly
3584         https://bugs.webkit.org/show_bug.cgi?id=166271
3585
3586         Reviewed by Simon Fraser.
3587
3588         Add in a check when UIScriptController is deleted to make sure that the HID event
3589         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3590         the program to crash without any good information. Crashes are race-y, and will still
3591         happen with malformed test, but the information will be much more helpful. 
3592
3593         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3594         (WTR::UIScriptController::checkForClean):
3595         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3596         (UIScriptContext::~UIScriptContext):
3597         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3598         (WTR::UIScriptController::checkForClean):
3599         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3600         * WebKitTestRunner/ios/HIDEventGenerator.h:
3601         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3602         (-[HIDEventGenerator checkHIDCallbacksClear]):
3603         * WebKitTestRunner/ios/TestControllerIOS.mm:
3604         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3605         (WTR::UIScriptController::checkForClean):
3606
3607 2016-12-20  Andy Estes  <aestes@apple.com>
3608
3609         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3610         https://bugs.webkit.org/show_bug.cgi?id=165992
3611
3612         Reviewed by Brady Eidson.
3613
3614         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3615         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3616         (expectException):
3617         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3618         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3619         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3620         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3621         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3622         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3623         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3624         (TEST):
3625         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3626
3627 2016-12-20  Dean Jackson  <dino@apple.com>
3628
3629         Remove INDIE_UI
3630         https://bugs.webkit.org/show_bug.cgi?id=165881
3631         <rdar://problem/29672532>
3632
3633         Reviewed by Simon Fraser.
3634
3635         The Indie UI work has been discontinued.
3636
3637         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3638
3639 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3640
3641         [ES6] Enable ES6 Modules
3642         https://bugs.webkit.org/show_bug.cgi?id=165849
3643
3644         Reviewed by Geoffrey Garen.
3645
3646         * DumpRenderTree/mac/DumpRenderTree.mm:
3647         (resetWebPreferencesToConsistentValues):
3648         * DumpRenderTree/win/DumpRenderTree.cpp:
3649         (resetWebPreferencesToConsistentValues):
3650         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3651         (WTR::InjectedBundle::beginTesting):
3652         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3653         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3654         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3655
3656 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3657
3658         Repurpose bots and clean up dashboard.
3659         https://bugs.webkit.org/show_bug.cgi?id=166045
3660
3661         Reviewed by Lucas Forschler.
3662
3663         * BuildSlaveSupport/build.webkit.org-config/config.json:
3664         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3665         (BubbleQueueServer):
3666         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3667         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3668         (WebKitBuildbot):
3669         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3670         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3671
3672 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3673
3674         [CMake] TestWebKitAPIBase links to itself
3675         https://bugs.webkit.org/show_bug.cgi?id=165985
3676
3677         Reviewed by Alex Christensen.
3678
3679         Fix CMake warning about a target linking to itself, which makes no sense.
3680
3681         * TestWebKitAPI/CMakeLists.txt:
3682
3683 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3684
3685         [GTK] GtkDoc build should be quieter
3686         https://bugs.webkit.org/show_bug.cgi?id=165994
3687
3688         Reviewed by Carlos Garcia Campos.
3689
3690         Make it not print by default.
3691
3692         * gtk/generate-gtkdoc:
3693         (get_generator_for_config):
3694         (generate_doc):
3695         * gtk/gtkdoc.py:
3696         (GTKDoc._run_command):
3697         (GTKDoc._copy_doc_files_to_output_dir):
3698
3699 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3700
3701         Expose a way for MiniBrowser to simulate header and footer banners
3702         https://bugs.webkit.org/show_bug.cgi?id=166005
3703
3704         Reviewed by Wenson Hsieh.
3705         
3706         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3707         banners. This only works in WebKit2.
3708         
3709         We need to reset these on each navigation, since newly created FrameViews
3710         don't re-fetch the header and footer height stored on Page.
3711         
3712         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3713         as well as fixing webViewWebContentProcessDidTerminate:
3714
3715         * MiniBrowser/mac/SettingsController.h:
3716         * MiniBrowser/mac/SettingsController.m:
3717         (-[SettingsController _populateMenu]):
3718         (-[SettingsController validateMenuItem:]):
3719         (-[SettingsController toggleReserveSpaceForBanners:]):
3720         (-[SettingsController isSpaceReservedForBanners]):
3721         * MiniBrowser/mac/WK2BrowserWindowController.m:
3722         (-[WK2BrowserWindowController didChangeSettings]):
3723         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3724         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3725         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3726         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3727
3728 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3729
3730         Fix iOS test results after r209967.
3731         
3732         Subtracting out the status bar height was erroneously happening for all tests,
3733         not just for flexible viewport tests.
3734         
3735         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3736
3737         * WebKitTestRunner/PlatformWebView.h:
3738         * WebKitTestRunner/TestController.cpp:
3739         (WTR::TestController::resetStateToConsistentValues):
3740         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3741         (WTR::PlatformWebView::resizeTo):
3742         (WTR::PlatformWebView::setWindowFrame):
3743         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3744         (WTR::PlatformWebView::resizeTo):
3745         (WTR::PlatformWebView::setWindowFrame):
3746         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3747         (WTR::PlatformWebView::resizeTo):
3748         (WTR::PlatformWebView::setWindowFrame):
3749         * WebKitTestRunner/ios/TestControllerIOS.mm:
3750         (WTR::TestController::platformConfigureViewForTest):
3751         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3752         (WTR::PlatformWebView::resizeTo):
3753         (WTR::PlatformWebView::setWindowFrame):
3754
3755 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3756
3757         [EFL] bump EFL version to 1.18.4
3758         https://bugs.webkit.org/show_bug.cgi?id=166004
3759
3760         Reviewed by Gyuyoung Kim.
3761
3762         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3763
3764 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3765
3766         Visual viewports: bottom fixed elements disappear behind the keyboard
3767         https://bugs.webkit.org/show_bug.cgi?id=165983
3768         <rdar://problem/29409852>
3769
3770         Reviewed by Simon Fraser.
3771
3772         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
3773         the keyboard when it is up.
3774
3775         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3776         (WTR::UIScriptController::inputViewBounds):
3777         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3778         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3779         (WTR::UIScriptController::inputViewBounds):
3780         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3781         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3782         (WTR::viewRectForWindowRect):
3783
3784         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
3785         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
3786         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
3787
3788         (WTR::PlatformWebView::PlatformWebView):
3789         (WTR::PlatformWebView::setWindowFrame):
3790         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3791         (WTR::UIScriptController::inputViewBounds):
3792
3793 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3794
3795         Deleting a character converted from pinyin after an image causes a Safari crash
3796         https://bugs.webkit.org/show_bug.cgi?id=165839
3797         <rdar://problem/27951933>
3798
3799         Reviewed by Wenson Hsieh.
3800
3801         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
3802         while the proposed range contains an image. This should not cause a WebProcess to crash
3803         or send an invalid message to the UIProcess.
3804
3805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3806         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
3807         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
3808         (TestWebKitAPI::didFinishLoadForFrame):
3809         (TestWebKitAPI::processDidCrash):
3810         (TestWebKitAPI::invalidMessageFunction):
3811         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
3812
3813 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3814
3815         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
3816         https://bugs.webkit.org/show_bug.cgi?id=165767
3817         <rdar://problem/29602382>
3818
3819         Reviewed by Simon Fraser.
3820
3821         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
3822         WebKit2 ChangeLog for more details.
3823
3824         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3825         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3826         (WTR::UIScriptController::textSelectionCaretRect):
3827         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3828         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3829         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3830         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3831         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3832         (WTR::UIScriptController::textSelectionCaretRect):
3833         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3834         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3835         (-[TestRunnerWKWebView _setStableStateOverride:]):
3836
3837         Force the WKWebView to update its visible content rects when changing the stable state override.
3838
3839         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3840         (WTR::toNSDictionary):
3841         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3842         (WTR::UIScriptController::selectionRangeViewRects):
3843         (WTR::UIScriptController::textSelectionCaretRect):
3844         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3845         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3846
3847 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
3848
3849         Arguments called in wrong order
3850         https://bugs.webkit.org/show_bug.cgi?id=165923
3851
3852         Reviewed by Simon Fraser.
3853
3854         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
3855         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
3856
3857         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3858         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
3859         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
3860
3861 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
3862
3863         [EFL] Disable non-srcdir builds for failing libraries
3864         https://bugs.webkit.org/show_bug.cgi?id=165896
3865
3866         Reviewed by Gyuyoung Kim.
3867
3868         * efl/jhbuild.modules: Set non srcdir builds to no
3869
3870 2016-12-15  Daniel Bates  <dabates@apple.com>
3871
3872         check-style should not complain about code in icu directories
3873         https://bugs.webkit.org/show_bug.cgi?id=53929
3874
3875         Reviewed by Darin Adler.
3876
3877         Skip style checking of imported ICU headers to avoid a deluge of style issues
3878         as they do not conform to the WebKit Code Style guideline. We want to preserve
3879         the formatting of these headers so as to make it straightforward to merge
3880         changes to them, if necessary.
3881
3882         * Scripts/webkitpy/style/checker.py:
3883
3884 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
3885
3886         Move JSC testers from Yosemite to Sierra
3887         https://bugs.webkit.org/show_bug.cgi?id=165925
3888
3889         Reviewed by Lucas Forschler.
3890
3891         * BuildSlaveSupport/build.webkit.org-config/config.json:
3892         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3893         (WebKitBuildbot):
3894
3895 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
3896
3897         Add coordinate space to event streams and streamline tests
3898         https://bugs.webkit.org/show_bug.cgi?id=165119
3899
3900         Reviewed by Simon Fraser.
3901
3902         Update event streams to allow for both content and global coordinate space.
3903         Update example script to more accurately show all the available options.
3904
3905         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3906         * WebKitTestRunner/ios/HIDEventGenerator.h:
3907         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3908         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3909         (WTR::convertCoordinates):
3910         (WTR::UIScriptController::sendEventStream):
3911
3912 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
3913
3914         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
3915         https://bugs.webkit.org/show_bug.cgi?id=165855
3916
3917         Reviewed by Philippe Normand.
3918
3919         GStreamer's autogen.sh enables gtk-doc always so we end up building
3920         docs even if we disable them. Use the configure script instead, since
3921         we build from packages and these include it already.
3922
3923         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
3924         upstream gstreamer packages.
3925
3926 2016-12-15  Alex Christensen  <achristensen@webkit.org>
3927
3928         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
3929         https://bugs.webkit.org/show_bug.cgi?id=165885
3930         <rdar://problem/29476917>
3931
3932         Reviewed by Darin Adler.
3933
3934         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3935         (TestWebKitAPI::utf16String): Deleted.
3936         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
3937         (TestWebKitAPI::TEST_F):
3938         * TestWebKitAPI/WTFStringUtilities.h:
3939         (utf16String):
3940         Moved from URLParser to share with other tests.
3941
3942 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3943
3944         iOS: An element with tabindex is not focusable unless there is no mouse event handler
3945         https://bugs.webkit.org/show_bug.cgi?id=165843
3946
3947         Reviewed by Antti Koivisto.
3948
3949         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
3950         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
3951         and DumpRenderTree's runUIScript would hit an assertion :(
3952
3953         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3954         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3955         (WTR::TestRunner::isWebKit2):
3956
3957 2016-12-14  Brady Eidson  <beidson@apple.com>
3958
3959         IndexedDB 2.0: Massively speedup IDBIndex.get().
3960         https://bugs.webkit.org/show_bug.cgi?id=165802
3961
3962         Reviewed by Alex Christensen.
3963
3964         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3965         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
3966         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
3967         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
3968         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
3969
3970 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3971
3972         [GTK][EFL] Update the JHBuild version.
3973         https://bugs.webkit.org/show_bug.cgi?id=165838
3974
3975         Reviewed by Michael Catanzaro.
3976
3977         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
3978         usage of the JHBUILD_MIRROR feature with git repositories.
3979
3980 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3981
3982         [GTK] Yasm is needed for building the JHBuild after r208940
3983         https://bugs.webkit.org/show_bug.cgi?id=165837
3984
3985         Reviewed by Alejandro G. Castro.
3986
3987         * gtk/install-dependencies: Yasm is needed for building libvpx.
3988
3989 2016-12-14  Youenn Fablet  <youenn@apple.com>
3990
3991         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
3992         https://bugs.webkit.org/show_bug.cgi?id=161310
3993
3994         Reviewed by Ryosuke Niwa.
3995
3996         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
3997         When set, WTR and DRT output JS console log in the stderr and not the test output.
3998         This allows removing potentially flaky information while still being able to read it for investigation.
3999
4000         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
4001
4002         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
4003         This test should have this option when fetch API will start logging resource loader errors.
4004
4005         * DumpRenderTree/DumpRenderTree.h:
4006         (TestCommand::TestCommand): Deleted.
4007         * DumpRenderTree/DumpRenderTreeCommon.cpp:
4008         (parseInputLine):
4009         * DumpRenderTree/TestRunner.h:
4010         (TestRunner::setDumpJSConsoleLogInStdErr):
4011         (TestRunner::dumpJSConsoleLogInStdErr):
4012         * DumpRenderTree/mac/DumpRenderTree.mm:
4013         (runTest):
4014         * DumpRenderTree/mac/UIDelegate.mm:
4015         (-[UIDelegate webView:addMessageToConsole:withSource:]):
4016         * DumpRenderTree/win/DumpRenderTree.cpp:
4017         (runTest):
4018         * DumpRenderTree/win/UIDelegate.cpp:
4019         (UIDelegate::webViewAddMessageToConsole):
4020         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4021         (TestExpectationParser._tokenize_line):
4022         * Scripts/webkitpy/port/driver.py:
4023         (Driver._command_from_driver_input):
4024         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4025         (WTR::InjectedBundle::didReceiveMessageToPage):
4026         (WTR::InjectedBundle::dumpToStdErr):
4027         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4028         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
4029         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4030         (WTR::InjectedBundlePage::willAddMessageToConsole):
4031         * WebKitTestRunner/TestController.cpp:
4032         (WTR::parseInputLine):
4033         (WTR::TestController::runTest):
4034         (WTR::TestCommand::TestCommand): Deleted.
4035         * WebKitTestRunner/TestInvocation.cpp:
4036         (WTR::TestInvocation::invoke):
4037         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4038         * WebKitTestRunner/TestInvocation.h:
4039         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
4040
4041
4042 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
4043
4044         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
4045         https://bugs.webkit.org/show_bug.cgi?id=164022
4046
4047         Reviewed by Xabier Rodriguez-Calvar.
4048
4049         * Scripts/webkitperl/FeatureList.pm:
4050           Re-enable MEDIA_SOURCE for the GTK+ port.
4051
4052 2016-12-13  Alex Christensen  <achristensen@webkit.org>
4053
4054         Fix CMake build.
4055
4056         * DumpRenderTree/PlatformMac.cmake:
4057         Define NS_RETURNS_RETAINED as nothing for now.
4058
4059 2016-12-13  Jer Noble  <jer.noble@apple.com>
4060
4061         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
4062         https://bugs.webkit.org/show_bug.cgi?id=165697
4063
4064         Reviewed by Tim Horton.
4065
4066         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
4067         (TestWebKitAPI::TEST):
4068
4069 2016-12-13  Andy Estes  <aestes@apple.com>
4070
4071         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
4072         https://bugs.webkit.org/show_bug.cgi?id=165785
4073         <rdar://problem/26929398>
4074
4075         Reviewed by Darin Adler.
4076
4077         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4078         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
4079         expectations for the text, range, and action.
4080         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
4081         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
4082         plain-text string to the pasteboard, executed a paste action, and verified that the selected
4083         text in the web view did not change.
4084         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
4085         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
4086         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
4087         parameter.
4088         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
4089         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
4090         and returned the value of _editingDelegateShouldInsertText.
4091         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
4092         -shouldInsertText:replacingRange:givenAction:.
4093
4094 2016-12-13  Chris Dumez  <cdumez@apple.com>
4095
4096         Unreviewed, rolling out r209544.
4097
4098         Looks like r209489 did not cause the performance regression
4099         after all
4100
4101         Reverted changeset:
4102
4103         "Unreviewed, rolling out r209489."
4104         https://bugs.webkit.org/show_bug.cgi?id=165550
4105         http://trac.webkit.org/changeset/209544
4106
4107 2016-12-12  Sam Weinig  <sam@webkit.org>
4108
4109         [WebIDL] Remove use of Dictionary in ApplePaySession
4110         https://bugs.webkit.org/show_bug.cgi?id=165787
4111
4112         Reviewed by Anders Carlsson.
4113
4114         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4115         (WTR::initializeWebViewConfiguration):
4116         (WTR::TestController::platformCreateWebView):
4117         Enable ApplePay for the tests (where supported).
4118
4119 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
4120
4121         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
4122         https://bugs.webkit.org/show_bug.cgi?id=165251
4123
4124         Reviewed by Youenn Fablet.
4125
4126         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
4127         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
4128         the preferences have been set.
4129
4130 2016-12-08  Antti Koivisto  <antti@apple.com>
4131
4132         Enable network cache speculative revalidation in MiniBrowser
4133         https://bugs.webkit.org/show_bug.cgi?id=165616
4134
4135         Reviewed by Darin Adler.
4136
4137         Match Safari. Also add a menu item to disable it.
4138
4139         * MiniBrowser/mac/AppDelegate.m:
4140         (defaultConfiguration):
4141         * MiniBrowser/mac/SettingsController.h:
4142         * MiniBrowser/mac/SettingsController.m:
4143         (-[SettingsController _populateMenu]):
4144         (-[SettingsController validateMenuItem:]):
4145         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
4146         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
4147
4148 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
4149
4150         ChangeLogs become readonly after resolving a conflict
4151         https://bugs.webkit.org/show_bug.cgi?id=165440
4152         rdar://problem/29491002
4153
4154         Reviewed by Darin Adler.
4155
4156         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
4157         moving the file.
4158
4159 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
4160
4161         Re-enable collectContinuously since it doesn't crash anymore
4162
4163         Rubber stamped by Michael Saboff.
4164
4165         * Scripts/run-jsc-stress-tests:
4166
4167 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
4168
4169         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
4170         https://bugs.webkit.org/show_bug.cgi?id=165686
4171
4172         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
4173         so that right config.h comes first in include path.
4174
4175 2016-12-11  Dave Hyatt  <hyatt@apple.com>
4176
4177         [CSS Parser] Make sure content extensions initialize AtomicString
4178         https://bugs.webkit.org/show_bug.cgi?id=165737
4179
4180         Reviewed by Darin Adler.
4181
4182         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4183         (TestWebKitAPI::makeBackend):
4184
4185 2016-12-08  Dave Hyatt  <hyatt@apple.com>
4186
4187         [CSS Parser] Remove the old CSS Parser
4188         https://bugs.webkit.org/show_bug.cgi?id=165645
4189
4190         Reviewed by Daniel Bates.
4191
4192         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
4193         (TestWebKitAPI::TEST):
4194
4195 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
4196
4197         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
4198         https://bugs.webkit.org/show_bug.cgi?id=165686
4199
4200         Reviewed by Michael Catanzaro.
4201
4202         This change reduces duplication of include path lists between modules,
4203         and reduces future need for fixes like r209605 (broken build because of
4204         WebCore header suddenly becoming used in WebKit2).
4205
4206         * DumpRenderTree/CMakeLists.txt:
4207         * DumpRenderTree/PlatformMac.cmake:
4208         * ImageDiff/CMakeLists.txt:
4209         * MiniBrowser/gtk/CMakeLists.txt:
4210         * MiniBrowser/mac/CMakeLists.txt:
4211         * MiniBrowser/win/CMakeLists.txt:
4212         * TestWebKitAPI/CMakeLists.txt:
4213         * TestWebKitAPI/PlatformEfl.cmake:
4214         * TestWebKitAPI/PlatformJSCOnly.cmake:
4215         * TestWebKitAPI/PlatformMac.cmake:
4216         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
4217         * WebKitTestRunner/CMakeLists.txt:
4218         * WebKitTestRunner/PlatformGTK.cmake:
4219         * WebKitTestRunner/PlatformMac.cmake:
4220
4221 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
4222
4223         Unreviewed buildfix after r209630.
4224
4225         * Scripts/build-jsc: Remove building the non-existing testWASM.
4226
4227 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
4228
4229         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
4230         https://bugs.webkit.org/show_bug.cgi?id=165251
4231
4232         Reviewed by Dean Jackson.
4233
4234         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
4235
4236         * DumpRenderTree/mac/DumpRenderTree.mm:
4237         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
4238
4239         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4240         (WTR::InjectedBundle::beginTesting): Ditto.
4241
4242         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4243         (WTR::TestRunner::setMediaStreamEnabled): New.
4244         (WTR::TestRunner::setPeerConnectionEnabled): New.
4245         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4246
4247 2016-12-09  Brady Eidson  <beidson@apple.com> 
4248  
4249         Re-landing:
4250         Add _WKIconLoadingDelegate SPI. 
4251         https://bugs.webkit.org/show_bug.cgi?id=164894 
4252  
4253         Reviewed by Alex Christensen. 
4254         
4255         Add MiniBrowser support for this new SPI, configurable with a setting. 
4256  
4257         * MiniBrowser/mac/SettingsController.h: 
4258         * MiniBrowser/mac/SettingsController.m: 
4259         (-[SettingsController _populateMenu]): 
4260         (-[SettingsController validateMenuItem:]): 
4261         (-[SettingsController loadsAllSiteIcons]): 
4262         (-[SettingsController toggleLoadsAllSiteIcons:]): 
4263         * MiniBrowser/mac/WK2BrowserWindowController.m: 
4264         (-[WK2BrowserWindowController awakeFromNib]): 
4265         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
4266
4267 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
4268
4269         Fix the 32-bit build.
4270
4271         Unreviewed build fix.
4272
4273         * MiniBrowser/mac/SettingsController.h:
4274
4275 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4276
4277         Fedora also needs a PHP7 config file alternative
4278         https://bugs.webkit.org/show_bug.cgi?id=165606
4279
4280         Reviewed by Michael Catanzaro.
4281
4282         * Scripts/webkitpy/port/base.py:
4283         (Port._is_fedora_php_version_7): check for the php7 library.
4284         (Port._fedora_php_version): get the appropriate filename for Fedora.
4285         (Port._apache_config_file_name_for_platform):
4286
4287 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
4288
4289         Complete the revert of r208865.
4290         https://bugs.webkit.org/show_bug.cgi?id=164894
4291
4292         Unreviewed build fix.
4293
4294         * MiniBrowser/mac/SettingsController.h:
4295         * MiniBrowser/mac/SettingsController.m:
4296         (-[SettingsController _populateMenu]):
4297         (-[SettingsController validateMenuItem:]):
4298         (-[SettingsController loadsAllSiteIcons]): Deleted.
4299         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
4300         * MiniBrowser/mac/WK2BrowserWindowController.m:
4301         (-[WK2BrowserWindowController awakeFromNib]):
4302         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
4303
4304 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4305
4306         [GTK] Force GDK backend to x11 when running with XvfbDriver
4307         https://bugs.webkit.org/show_bug.cgi?id=165612
4308
4309         Reviewed by Michael Catanzaro.
4310
4311         When the developer is running a Wayland session, GDK may get confused
4312         and try to use its Wayland backend (which is higher priority) instead.
4313         This ensures it will use the appropriate backend when running under
4314         Xvfb.
4315
4316         * Scripts/webkitpy/port/gtk.py:
4317         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
4318         force GDK_BACKEND to x11.
4319
4320 2016-12-08  Keith Miller  <keith_miller@apple.com>
4321
4322         Add 64-bit signed LEB decode method
4323         https://bugs.webkit.org/show_bug.cgi?id=165630
4324
4325         Reviewed by Ryosuke Niwa.