[ews-build] Use PostgreSQL for ews.webkit.org database
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Use PostgreSQL for ews.webkit.org database
4         https://bugs.webkit.org/show_bug.cgi?id=196270
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-app/ews-app/settings.py:
9
10 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
11
12         [ews] Reset simctl states on reboot
13         https://bugs.webkit.org/show_bug.cgi?id=196260
14
15         Rubber-stamped by Aakash Jain.
16
17         * EWSTools/start-queue-mac.sh:
18
19 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
20
21         [ews-build] Use PostgreSQL for ews-build database
22         https://bugs.webkit.org/show_bug.cgi?id=196229
23
24         Reviewed by Lucas Forschler.
25
26         * BuildSlaveSupport/ews-build/master.cfg:
27
28 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
29
30         [ews-build] Get master_hostname dynamically in master.cfg
31         https://bugs.webkit.org/show_bug.cgi?id=196255
32
33         Reviewed by Lucas Forschler.
34
35         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
36         send events data in test mode.
37
38 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
39
40         [ews-app] Set db_constraint to False for Foreign Keys
41         https://bugs.webkit.org/show_bug.cgi?id=196252
42
43         Reviewed by Lucas Forschler.
44
45         * BuildSlaveSupport/ews-app/ews/models/build.py:
46         * BuildSlaveSupport/ews-app/ews/models/step.py:
47
48 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
49
50         [ews-build] is_test_mode_enabled should default to True
51         https://bugs.webkit.org/show_bug.cgi?id=196248
52
53         Reviewed by Lucas Forschler.
54
55         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
56
57 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
58
59         [ews-app] Add webkitperl to ENABLED_QUEUES
60         https://bugs.webkit.org/show_bug.cgi?id=196253
61
62         Reviewed by Lucas Forschler.
63
64         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
65
66 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
67
68         Address NSWindow sometimes using WebKitTestRunnerEvent too early
69         https://bugs.webkit.org/show_bug.cgi?id=196211
70         rdar://problem/49110552
71
72         Reviewed by Tim Horton.
73
74         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
75         Make sure that EventSenderProxy always exists when running tests. We used to create
76         it when resetting before the first test, which is a bit too late.
77
78         * WebKitTestRunner/TestController.h:
79         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
80         (WTR::TestController::platformCreateWebView):
81         (WTR::TestController::platformCreateOtherPage):
82         (WTR::TestController::finishCreatingPlatformWebView):
83         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
84         (WTR::PlatformWebView::PlatformWebView):
85         Moved some code that made NSWindow use NSEvent during web view creation. We may
86         need to move more if some other case us found, but this is enough for now.
87
88 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
89
90         Unreviewed. Fix typo in GLib geolocation API after r243285.
91
92         gelocation -> geolocation.
93
94         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
95         (testGeolocationManagerWatchPosition):
96
97 2019-03-25  Alex Christensen  <achristensen@webkit.org>
98
99         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
100         https://bugs.webkit.org/show_bug.cgi?id=196213
101
102         Reviewed by Geoff Garen.
103
104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
105         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
106         (credentialWithIdentityAndKeychainPath):
107         (-[ChallengeDelegate webView:didFinishNavigation:]):
108         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
109         (TestWebKitAPI::TEST):
110
111 2019-03-25  Alex Christensen  <achristensen@webkit.org>
112
113         Expected shouldn't assume its contained types are copyable
114         https://bugs.webkit.org/show_bug.cgi?id=195986
115
116         Reviewed by JF Bastien.
117
118         * TestWebKitAPI/Tests/WTF/Expected.cpp:
119         (TestWebKitAPI::NonCopyable::operator== const):
120         (TestWebKitAPI::NonCopyable::operator!= const):
121         (TestWebKitAPI::TEST):
122
123 2019-03-25  Tim Horton  <timothy_horton@apple.com>
124
125         Remove some now-unnecessary dynamic class lookup
126         https://bugs.webkit.org/show_bug.cgi?id=196237
127
128         Reviewed by Simon Fraser.
129
130         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
131         (makeRequest):
132         (TEST):
133
134 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
135
136         Unreviewed, rolling out r243450.
137
138         AppleWin and WinCairo port builds get broken.
139
140         Reverted changeset:
141
142         "Add test for fix of #196095"
143         https://bugs.webkit.org/show_bug.cgi?id=196097
144         https://trac.webkit.org/changeset/243450
145
146 2019-03-25  Commit Queue  <commit-queue@webkit.org>
147
148         Unreviewed, rolling out r243465.
149         https://bugs.webkit.org/show_bug.cgi?id=196226
150
151         the test doesn't build (Requested by thorton on #webkit).
152
153         Reverted changeset:
154
155         "Do not terminate the NetworkProcess if a third party
156         application sends a NSCredential with a SecIdentityRef"
157         https://bugs.webkit.org/show_bug.cgi?id=196213
158         https://trac.webkit.org/changeset/243465
159
160 2019-03-25  Alex Christensen  <achristensen@webkit.org>
161
162         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
163         https://bugs.webkit.org/show_bug.cgi?id=196213
164
165         Reviewed by Geoff Garen.
166
167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
168         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
169         (credentialWithIdentityAndKeychainPath):
170         (-[ChallengeDelegate webView:didFinishNavigation:]):
171         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
172         (TestWebKitAPI::TEST):
173
174 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
175
176         [ews-build] Gracefully handle missing patch_id in events
177         https://bugs.webkit.org/show_bug.cgi?id=196216
178
179         Reviewed by Lucas Forschler.
180
181         * BuildSlaveSupport/ews-build/events.py:
182
183 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
184
185         [ews-build] use lz4 compression for improving buildbot performance
186         https://bugs.webkit.org/show_bug.cgi?id=196155
187
188         Reviewed by Lucas Forschler.
189
190         * BuildSlaveSupport/ews-build/master.cfg:
191
192 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
193
194         Pull some API testing helper methods out of TestWKWebView
195         https://bugs.webkit.org/show_bug.cgi?id=196212
196
197         Reviewed by Tim Horton.
198
199         Refactor some more API testing utility methods, so that they can be used in
200         tests that do not use TestWKWebView.
201
202         * TestWebKitAPI/cocoa/TestWKWebView.h:
203         * TestWebKitAPI/cocoa/TestWKWebView.mm:
204         (-[WKWebView loadTestPageNamed:]):
205         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
206         (-[WKWebView synchronouslyLoadHTMLString:]):
207         (-[WKWebView synchronouslyLoadTestPageNamed:]):
208         (-[TestWKWebView loadTestPageNamed:]): Deleted.
209         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
210         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
211         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
212
213 2019-03-25  Jer Noble  <jer.noble@apple.com>
214
215         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
216         https://bugs.webkit.org/show_bug.cgi?id=196097
217
218         Reviewed by Eric Carlson.
219
220         Drive-by bug fix: allow tests to play audio without a user gesture by default.
221
222         * DumpRenderTree/mac/DumpRenderTree.mm:
223         (resetWebPreferencesToConsistentValues):
224         * WebKitTestRunner/TestController.cpp:
225         (WTR::TestController::resetPreferencesToConsistentValues):
226
227 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
228
229         Pull IPadUserInterfaceSwizzler out into a separate header file
230         https://bugs.webkit.org/show_bug.cgi?id=196193
231
232         Reviewed by Anders Carlsson.
233
234         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
235         be used in other API tests.
236
237         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
238         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
239         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
240         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
241         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
242         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
243         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
244
245 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
246
247         Remove NavigatorContentUtils in WebCore/Modules
248         https://bugs.webkit.org/show_bug.cgi?id=196070
249
250         Reviewed by Alex Christensen.
251
252         NavigatorContentUtils was to support the custom scheme spec [1].
253         However, in WebKit side, no port has supported the feature in
254         WebKit layer after EFL port was removed. So there has been the
255         only IDL implementation of the NavigatorContentUtils in WebCore.
256         So we don't need to keep the implementation in WebCore anymore.
257
258         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
259
260         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
261
262 2019-03-24  Andy Estes  <aestes@apple.com>
263
264         [watchOS] Remove unused Proximity Networking code
265         https://bugs.webkit.org/show_bug.cgi?id=196188
266
267         Reviewed by Tim Horton.
268
269         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
270         (TEST):
271
272 2019-03-23  Keith Miller  <keith_miller@apple.com>
273
274         Refactor clz/ctz and fix getLSBSet.
275         https://bugs.webkit.org/show_bug.cgi?id=196162
276
277         Reviewed by Saam Barati.
278
279         Add tests for clz, ctz, getLSBSet, and getMSBSet.
280
281         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
282         (TestWebKitAPI::TEST):
283
284 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
285
286         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
287         https://bugs.webkit.org/show_bug.cgi?id=196143
288
289         Reviewed by Michael Catanzaro.
290
291         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
292         directories.
293
294         * Scripts/webkitpy/style/checkers/cpp.py:
295         (check_identifier_name_in_declaration):
296         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
297         (WebKitStyleTest.test_names):
298
299 2019-03-22  Philippe Normand  <pnormand@igalia.com>
300
301         [Flatpak] Manifest expanding fails for qt WPE extension
302         https://bugs.webkit.org/show_bug.cgi?id=196148
303
304         Reviewed by Alex Christensen.
305
306         * flatpak/flatpakutils.py:
307         (expand_submodules_recurse): The last recurse manifest expand
308         iteration might lead to a single module so take it into account
309         and don't try to recurse further.
310
311 2019-03-22  Chris Dumez  <cdumez@apple.com>
312
313         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
314         https://bugs.webkit.org/show_bug.cgi?id=195348
315         <rdar://problem/48622090>
316
317         Reviewed by Alex Christensen.
318
319         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
320         to NO when test.options().shouldIgnoreMetaViewport is false.
321
322         * WebKitTestRunner/ios/TestControllerIOS.mm:
323         (WTR::TestController::platformConfigureViewForTest):
324
325 2019-03-22  Chris Dumez  <cdumez@apple.com>
326
327         Prewarmed processes should be usable with any website data store
328         https://bugs.webkit.org/show_bug.cgi?id=196104
329
330         Reviewed by Alex Christensen.
331
332         Add API test coverage.
333
334         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
335         (runInitialWarmedProcessUsedTest):
336         (TEST):
337
338 2019-03-22  David Kilzer  <ddkilzer@apple.com>
339
340         Back out local changes to Alex's Subversion working directory
341
342         They were accidentally committed.
343
344         * Scripts/webkitpy/common/system/abstractexecutive.py:
345         (AbstractExecutive.wait_newest):
346         * Scripts/webkitpy/common/system/executive.py:
347         (Executive.running_pids):
348         * Scripts/webkitpy/common/system/executive_mock.py:
349         (MockExecutive.running_pids):
350         * Scripts/webkitpy/common/system/executive_unittest.py:
351         (ExecutiveTest.serial_test_running_pids):
352         * Scripts/webkitpy/port/darwin.py:
353         (DarwinPort.check_for_leaks):
354         * Scripts/webkitpy/port/leakdetector.py:
355         (LeakDetector.check_for_leaks):
356         - This was the hack attached to Bug 193772.
357
358         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
359         (+[WebKitTestRunnerEvent mouseLocation]):
360         - This works around a crash on an internal build.
361
362 2019-03-22  Tim Horton  <timothy_horton@apple.com>
363
364         Fix the build after r243354
365         https://bugs.webkit.org/show_bug.cgi?id=196138
366         <rdar://problem/49145951>
367
368         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
369         (TEST):
370         * TestWebKitAPI/ios/UIKitSPI.h:
371
372 2019-03-21  Tim Horton  <timothy_horton@apple.com>
373
374         Adopt UIWKDocumentContext
375         https://bugs.webkit.org/show_bug.cgi?id=196040
376         <rdar://problem/48642440>
377
378         Reviewed by Ryosuke Niwa.
379
380         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
381         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
382         (makeRequest):
383         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
384         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
385         (applyStyle):
386         (TEST):
387         Add tests for UIWKDocumentContext.
388
389         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
390         (TEST):
391         (recursiveFindWKContentView): Deleted.
392         * TestWebKitAPI/cocoa/TestWKWebView.h:
393         * TestWebKitAPI/cocoa/TestWKWebView.mm:
394         (recursiveFindWKContentView):
395         (-[TestWKWebView wkContentView]):
396         * TestWebKitAPI/ios/UIKitSPI.h:
397         Share the WKContentView finding code between tests.
398
399 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
400
401         [iOS WK2] Turn on async overflow scrolling by default
402         https://bugs.webkit.org/show_bug.cgi?id=196011
403         rdar://problem/48453859
404
405         Reviewed by Antti Koivisto.
406         
407         Explicitly turn off the async overflow scrolling internal feature for tests by default,
408         since so many basic layout tests have different results when compositing is triggered for
409         overflow.
410         
411         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
412
413         * WebKitTestRunner/TestController.cpp:
414         (WTR::TestController::resetPreferencesToConsistentValues):
415
416 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
417
418         [ews-build] Retry API test in case of failures
419         https://bugs.webkit.org/show_bug.cgi?id=196004
420
421         Reviewed by Lucas Forschler.
422
423         * BuildSlaveSupport/ews-build/steps.py:
424         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
425         (CompileWebKitToT.doStepIf): Ditto.
426         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
427         (ReRunAPITests): Re-run API tests.
428         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
429         (RunAPITestsWithoutPatch): Run API tests without patch.
430         (RunAPITestsWithoutPatch.doStepIf):
431         (RunAPITestsWithoutPatch.hideStepIf):
432         (RunAPITestsWithoutPatch.evaluateCommand):
433         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
434         (AnalyzeAPITestsResults.start):
435         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
436         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
437         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
438         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
439
440 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
441
442         [ews-build] Update queues configurations
443         https://bugs.webkit.org/show_bug.cgi?id=196074
444
445         Reviewed by Dewei Zhu.
446
447         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
448         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
449
450 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
451
452         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
453         https://bugs.webkit.org/show_bug.cgi?id=195680
454         <rdar://problem/48903534>
455
456         Unreviewed infrastructure fix.
457
458         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
459         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
460
461 2019-03-21  Andy Estes  <aestes@apple.com>
462
463         [iOS] Apple Pay should be available in documents with no user agent scripts
464         https://bugs.webkit.org/show_bug.cgi?id=196061
465         <rdar://problem/48649391>
466
467         Reviewed by Brady Eidson.
468
469         Added API tests and related infrastructure.
470
471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
472         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
473         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
474         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
475         (TestWebKitAPI::TEST):
476         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
477         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
478         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
479         * TestWebKitAPI/cocoa/TestProtocol.mm:
480         (-[TestProtocol startLoading]):
481         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
482         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
483         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
484         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
485
486 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
487
488         REGRESSSION (r243297): webkitpy tests broken
489         https://bugs.webkit.org/show_bug.cgi?id=196108
490
491         Reviewed by Aakash Jain.
492
493         r243297 updated contributors.json, which broke a few unit tests.
494
495         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
496         (IRCCommandTest.test_whois):
497         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
498
499 2019-03-21  Chris Dumez  <cdumez@apple.com>
500
501         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
502         https://bugs.webkit.org/show_bug.cgi?id=196041
503         <rdar://problem/49083230>
504
505         Reviewed by Alex Christensen.
506
507         Add API test coverage.
508
509         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
510         (TEST):
511
512 2019-03-21  Alex Christensen  <achristensen@webkit.org>
513
514         Add SPI to inform applications of WKContentRuleList actions
515         https://bugs.webkit.org/show_bug.cgi?id=195965
516         <rdar://problem/42664365>
517
518         Reviewed by Geoff Garen.
519
520         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
521         (TestWebKitAPI::allActionsForResourceLoad):
522         (TestWebKitAPI::testRequest):
523         (TestWebKitAPI::TEST_F):
524         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
525         (Notification::description):
526         (Notification::operator== const):
527         (toVector):
528         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
529         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
530         (makeContentRuleList):
531         (TEST):
532         (makeWarnContentRuleList): Deleted.
533
534 2019-03-21  Timothy Hatcher  <timothy@apple.com>
535
536         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
537         https://bugs.webkit.org/show_bug.cgi?id=196088
538
539         Reviewed by Brian Burg.
540
541         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
542         Support checks when only one platform is specified. Also deprecate macosx() and
543         force the use of macos() instead.
544
545         * Scripts/webkitpy/style/checkers/cpp.py:
546         (check_min_versions_of_wk_api_available):
547         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
548         (WebKitStyleTest.test_min_versions_of_wk_api_available):
549
550 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
551
552         Update status inactive committers' status to 'contributor'.
553
554         * Scripts/webkitpy/common/config/contributors.json:
555
556 2019-03-21  Xan Lopez  <xan@igalia.com>
557
558         [JSC][x86] Drop support for x87 floating point
559         https://bugs.webkit.org/show_bug.cgi?id=194853
560
561         Reviewed by Don Olmstead.
562
563         Force SSE2 on x86/32bit builds.
564
565         * Scripts/webkitdirs.pm:
566         (generateBuildSystemFromCMakeProject):
567
568 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
569
570         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
571         https://bugs.webkit.org/show_bug.cgi?id=196073
572
573         Reviewed by Michael Catanzaro.
574
575         Add test cases to check functions and constructors with no arguments but receiving user data.
576
577         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
578         (checkUserData):
579         (testJSCFunction):
580         (fooCreateWithUserData):
581         (testJSCClass):
582
583 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
584
585         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
586
587         Add g_assert_cmpfloat_with_epsilon macro if not defined.
588
589         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
590
591 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
592
593         [GTK][WPE] Add API to provide geolocation information
594         https://bugs.webkit.org/show_bug.cgi?id=195940
595
596         Reviewed by Michael Catanzaro.
597
598         Add a new test to check the new API.
599
600         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
601         (testGeolocationManagerCurrentPosition):
602         (testGeolocationManagerWatchPosition):
603         (beforeAll):
604         (afterAll):
605         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
606         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
607         (beforeAll): Ditto.
608         * TestWebKitAPI/glib/CMakeLists.txt:
609
610 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
611
612         [GLib] Returning G_TYPE_OBJECT from a method does not work
613         https://bugs.webkit.org/show_bug.cgi?id=195574
614
615         Reviewed by Michael Catanzaro.
616
617         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
618
619         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
620         (getGFile):
621         (getParent):
622         (createGString):
623         (getGString):
624         (getGStringCopyWillRaise):
625         (getGStringCopy):
626         (getGStringStr):
627         (getGStringLen):
628         (freeGString):
629         (testJSCClass):
630
631 2019-03-20  Saam Barati  <sbarati@apple.com>
632
633         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
634         https://bugs.webkit.org/show_bug.cgi?id=195721
635
636         Reviewed by Filip Pizlo.
637
638         * Scripts/run-javascriptcore-tests:
639
640 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
641
642         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
643         https://bugs.webkit.org/show_bug.cgi?id=196049
644
645         Reviewed by Tim Horton.
646
647         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
648         overflow scrolling in general, so rename it.
649
650         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
651
652 2019-03-20  Daniel Bates  <dabates@apple.com>
653
654         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
655         https://bugs.webkit.org/show_bug.cgi?id=196031
656         <rdar://problem/49078172>
657
658         Reviewed by Tim Horton.
659
660         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
661         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
662         same code path used when the Done button is pressed to dismiss the <select> picker.
663
664         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
665         (TestWebKitAPI::TEST):
666
667 2019-03-20  Chris Dumez  <cdumez@apple.com>
668
669         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
670         https://bugs.webkit.org/show_bug.cgi?id=196029
671         <rdar://problem/48954651>
672
673         Reviewed by Tim Horton.
674
675         Add API test coverage.
676
677         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
678
679 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
680
681         [ews-build] Improve failure summary string for ApplyPatch step
682         https://bugs.webkit.org/show_bug.cgi?id=195995
683
684         Reviewed by Alexey Proskuryakov.
685
686         * BuildSlaveSupport/ews-build/steps.py:
687         (ApplyPatch.getResultSummary): Override getResultSummary.
688
689 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
690
691         AX: Implement support for new meter ARIA role
692         https://bugs.webkit.org/show_bug.cgi?id=195966
693
694         Reviewed by Chris Fleizach.
695
696         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
697         to AXLevelIndicator.
698
699         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
700
701 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
702
703         [WebAuthN] Implement FIDO AppID extension
704         https://bugs.webkit.org/show_bug.cgi?id=143491
705         <rdar://problem/48298273>
706
707         Reviewed by Brent Fulgham.
708
709         Add a test that covers the new flag of convertToU2fSignCommand.
710
711         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
712         (TestWebKitAPI::TEST):
713         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
714         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
715         (TestWebKitAPI::TEST):
716
717 2019-03-19  Keith Rollin  <krollin@apple.com>
718
719         Add support for more platforms to generate-xcfilelists
720         https://bugs.webkit.org/show_bug.cgi?id=195977
721
722         Reviewed by Alexey Proskuryakov.
723
724         generate-xcfilelists incorrectly complains when involved with building
725         WebKit for iphonesimulator:
726
727             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
728             …
729             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
730
731         Address this by teaching generate-xcfilelists about more platforms.
732
733         * Scripts/generate-xcfilelists:
734
735 2019-03-19  John Wilander  <wilander@apple.com>
736
737         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
738         https://bugs.webkit.org/show_bug.cgi?id=195923
739         <rdar://problem/49001272>
740
741         Reviewed by Alex Christensen.
742
743         This patch does the following to the TestRunner:
744         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
745         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
746         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
747
748         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
749         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
750         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
751         * WebKitTestRunner/InjectedBundle/TestRunner.h:
752         * WebKitTestRunner/TestController.cpp:
753         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
754         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
755         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
756         * WebKitTestRunner/TestController.h:
757         * WebKitTestRunner/TestInvocation.cpp:
758         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
759
760 2019-03-19  Christopher Reid  <chris.reid@sony.com>
761
762         [CMake] Support more clang and gcc sanitizers
763         https://bugs.webkit.org/show_bug.cgi?id=195956
764
765         Reviewed by Michael Catanzaro.
766
767         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
768
769 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
770
771         [ews-build] Improve summary for PrintConfiguration step
772         https://bugs.webkit.org/show_bug.cgi?id=195945
773
774         Reviewed by Lucas Forschler.
775
776         * BuildSlaveSupport/ews-build/steps.py:
777         (PrintConfiguration.getResultSummary): Override getResultSummary.
778
779 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
780
781         [ews-build] Improve summary for CheckOutSource step
782         https://bugs.webkit.org/show_bug.cgi?id=195963
783
784         Reviewed by Lucas Forschler.
785
786         * BuildSlaveSupport/ews-build/steps.py:
787         (CheckOutSource.getResultSummary):
788
789 2019-03-19  Daniel Bates  <dabates@apple.com>
790
791         [iOS] Focus not preserved when switching between tabs
792         https://bugs.webkit.org/show_bug.cgi?id=195820
793         <rdar://problem/43614450>
794
795         Reviewed by Brent Fulgham.
796
797         Add tests to ensure that we restore focus when resigning and becoming first responder.
798
799         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
800         (TestWebKitAPI::TEST):
801
802 2019-03-19  Alex Christensen  <achristensen@webkit.org>
803
804         Make WTFLogChannelState and WTFLogLevel enum classes
805         https://bugs.webkit.org/show_bug.cgi?id=195904
806
807         Reviewed by Eric Carlson.
808
809         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
810         (TestWebKitAPI::TEST_F):
811
812 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
813
814         [GStreamer][EME] Backported mssdemux protection data crash fix
815         https://bugs.webkit.org/show_bug.cgi?id=195918
816
817         Reviewed by Philippe Normand.
818
819         * gstreamer/jhbuild.modules:
820         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
821
822 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
823
824         Unreviewed, rolling out r243132.
825
826         Broke GTK build
827
828         Reverted changeset:
829
830         "Make WTFLogChannelState and WTFLogLevel enum classes"
831         https://bugs.webkit.org/show_bug.cgi?id=195904
832         https://trac.webkit.org/changeset/243132
833
834 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
835
836         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
837
838         * Scripts/webkitdirs.pm:
839         (builtDylibPathForName): Adjust the shared library name that's changed
840         with the API version bump in r243073.
841
842 2019-03-18  Alex Christensen  <achristensen@webkit.org>
843
844         Make WTFLogChannelState and WTFLogLevel enum classes
845         https://bugs.webkit.org/show_bug.cgi?id=195904
846
847         Reviewed by Eric Carlson.
848
849         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
850         (TestWebKitAPI::TEST_F):
851
852 2019-03-18  Alex Christensen  <achristensen@webkit.org>
853
854         Disable flaky test added in r2431100
855         https://webkit.org/b/195785
856
857         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
858         (TestWebKitAPI::TEST):
859         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
860
861 2019-03-18  Timothy Hatcher  <timothy@apple.com>
862
863         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
864         https://bugs.webkit.org/show_bug.cgi?id=195916
865
866         Reviewed by Tim Horton.
867
868         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
869         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
870
871 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
872
873         Add a secondary e-mail address for Fujii Hironori to make tools happier.
874
875         * Scripts/webkitpy/common/config/contributors.json:
876
877 2019-03-18  Alex Christensen  <achristensen@webkit.org>
878
879         Implement DownloadMonitor to prevent long-running slow downloads from background apps
880         https://bugs.webkit.org/show_bug.cgi?id=195785
881
882         Reviewed by Geoffrey Garen.
883
884         * TestWebKitAPI/TCPServer.cpp: Added.
885         (TestWebKitAPI::TCPServer::TCPServer):
886         (TestWebKitAPI::TCPServer::~TCPServer):
887         (TestWebKitAPI::TCPServer::socketBindListen):
888         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
889         * TestWebKitAPI/TCPServer.h: Added.
890         (TestWebKitAPI::TCPServer::port const):
891         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
892         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
893         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
894         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
895         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
896         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
897         (TestWebKitAPI::respondSlowly):
898         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
899         (TestWebKitAPI::downloadAtRate):
900         (TestWebKitAPI::TEST):
901
902 2019-03-18  Saam Barati  <sbarati@apple.com>
903
904         Add a plan file for JetStream 2
905         https://bugs.webkit.org/show_bug.cgi?id=190734
906
907         Reviewed by Mark Lam.
908
909         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
910
911 2019-03-18  Chris Dumez  <cdumez@apple.com>
912
913         Delay WebProcess launch until a load is triggered in a Web view
914         https://bugs.webkit.org/show_bug.cgi?id=195758
915         <rdar://problem/48126013>
916
917         Reviewed by Geoff Garen.
918
919         Add API test coverage. Also update some existing API tests to not expect
920         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
921
922         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
923         (TestWebKitAPI::TEST):
924         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
925         (TestWebKitAPI::TEST):
926         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
927         (TEST):
928         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
929         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
930         (TEST):
931         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
932         (TEST):
933         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
934
935 2019-03-18  Xan Lopez  <xan@igalia.com>
936
937         [CMake] Prevent potential warning when determining $architecture
938         https://bugs.webkit.org/show_bug.cgi?id=195891
939
940         Reviewed by Michael Catanzaro.
941
942         It's possible for generateBuildSystemForCMakeProject to be called
943         before determineArchitecture() is ever called. This will make the
944         first eq check with $architecture to be bogus (and print a
945         warning). Change that to an eq check with architecture(), which
946         implicitly calls determineArchitecture() if needed, and change all
947         the other similar cases in the method in the same way to prevent
948         future bugs like this one.
949
950         * Scripts/webkitdirs.pm:
951         (generateBuildSystemFromCMakeProject):
952
953 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
954
955         [WPE] Tarballs generated with “make dist” cannot build documentation
956         https://bugs.webkit.org/show_bug.cgi?id=195885
957
958         Reviewed by Carlos Garcia Campos.
959
960         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
961
962 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
963
964         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
965         https://bugs.webkit.org/show_bug.cgi?id=195883
966
967         Reviewed by Carlos Garcia Campos.
968
969         * gtkdoc/gtkdoc.py:
970         (GTKDoc._run_command): When commands fail to run, include the full command line for
971         the program invocation and the output it has generated on the standard error stream.
972
973 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
974
975         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
976         https://bugs.webkit.org/show_bug.cgi?id=195786
977
978         Reviewed by Philippe Normand.
979
980         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
981         * wpe/jhbuild.modules: Ditto.
982
983 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
984
985         [ews-build] Don't run clean builds on EWS builders
986         https://bugs.webkit.org/show_bug.cgi?id=195851
987
988         Reviewed by Geoffrey Garen.
989
990         * BuildSlaveSupport/ews-build/factories.py:
991
992 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
993
994         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
995         https://bugs.webkit.org/show_bug.cgi?id=195849
996
997         Reviewed by Chris Dumez.
998
999         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1000
1001         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1002         (runWebsiteDataStoreCustomPaths):
1003
1004 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1005
1006         webkitpy: Upload test results
1007         https://bugs.webkit.org/show_bug.cgi?id=195755
1008         <rdar://problem/48896182>
1009
1010         Reviewed by Aakash Jain.
1011
1012         Establish a new format for uploading results that is not tied to layout tests, apply
1013         that format to webkitpy tests.
1014
1015         * Scripts/webkitpy/common/checkout/scm/git.py:
1016         (Git.native_branch): Return what branch the current checkout is on.
1017         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1018         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1019         * Scripts/webkitpy/common/checkout/scm/svn.py:
1020         (SVN.native_branch): Ditto.
1021         * Scripts/webkitpy/common/system/platforminfo.py:
1022         (PlatformInfo.build_version): Return a build version for Mac.
1023         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1024         (MockPlatformInfo.__init__):
1025         (MockPlatformInfo.build_version):
1026         * Scripts/webkitpy/results: Added.
1027         * Scripts/webkitpy/results/__init__.py: Added.
1028         * Scripts/webkitpy/results/options.py: Added.
1029         (upload_options): OptParse list for upload options.
1030         * Scripts/webkitpy/results/upload.py: Added.
1031         (Upload): Class which enforces the upload format expected by the results server.
1032         (Upload.Expectations):
1033         (Upload.create_configuration):
1034         (Upload.create_commit):
1035         (Upload.create_details):
1036         (Upload.create_run_stats):
1037         (Upload.create_test_result):
1038         (Upload.__init__):
1039         (Upload.Encoder): Encode Upload object as json.
1040         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1041         * Scripts/webkitpy/results/upload_unittest.py: Added.
1042         * Scripts/webkitpy/test/main.py:
1043         (Tester._parse_args): Add upload arguments.
1044         (Tester._run_tests): Allow results to be uploaded.
1045         * Scripts/webkitpy/test/runner.py:
1046         (Runner.__init__): Record which tests were run, rather than just counting them.
1047         (Runner.handle):
1048         * Scripts/webkitpy/test/runner_unittest.py:
1049         (RunnerTest.test_run):
1050         * Scripts/webkitpy/thirdparty/__init__.py:
1051         (AutoinstallImportHook.find_module): Add requests auto-install.
1052         (AutoinstallImportHook._install_requests):
1053         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1054         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1055
1056 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1057
1058         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1059         https://bugs.webkit.org/show_bug.cgi?id=195810
1060
1061         Reviewed by Tim Horton.
1062
1063         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1064         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1065         ending certain layout tests.
1066
1067         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1068         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1069         (-[TestRunnerWKWebView dealloc]):
1070         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1071
1072         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1073         helper method when destroying the web view, and when resetting state between tests.
1074
1075         * WebKitTestRunner/ios/TestControllerIOS.mm:
1076         (WTR::TestController::platformResetStateToConsistentValues):
1077
1078         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1079
1080 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1081
1082         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1083         https://bugs.webkit.org/show_bug.cgi?id=190350
1084         <rdar://problem/45089503>
1085
1086         Reviewed by Geoffrey Garen.
1087
1088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1089         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1090         (TEST):
1091         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1092         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1093         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1094         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1095         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1096         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1097         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1098         (runTest):
1099         (createDirectories):
1100         (TEST):
1101         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1102         (TEST):
1103         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1104         (TEST):
1105
1106 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1107
1108         Add support to WebPage for getting the contents as an attributed string.
1109         https://bugs.webkit.org/show_bug.cgi?id=195636
1110         rdar://problem/45055697
1111
1112         Reviewed by Tim Horton.
1113
1114         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1115         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1116
1117 2019-03-15  Chris Dumez  <cdumez@apple.com>
1118
1119         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1120         https://bugs.webkit.org/show_bug.cgi?id=195747
1121
1122         Reviewed by Geoff Garen.
1123
1124         Add API test coverage.
1125
1126         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1127
1128 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1129
1130         Unreviewed, rolling out r242952.
1131
1132         Causing API failures on iOS Simulator
1133
1134         Reverted changeset:
1135
1136         "[PSON] Make sure the WebProcessCache is leverage when
1137         relaunching a process after termination"
1138         https://bugs.webkit.org/show_bug.cgi?id=195747
1139         https://trac.webkit.org/changeset/242952
1140
1141 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1142
1143         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1144         https://bugs.webkit.org/show_bug.cgi?id=195740
1145
1146         Reviewed by Ross Kirsling.
1147
1148         window.open doesn't work for WebKitBrowserWindow because it is not
1149         implemented yet.
1150
1151         1. Implemented createNewPage callback of WKPageUIClient.
1152         2. Changed MainWindow to take a BrowserWindow factory function
1153           instead of BrowserWindowType to be flexible to create
1154           BrowserWindow with extra settings.
1155         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1156           because it is not relevant with MainWindow anymore.
1157
1158         * MiniBrowser/win/Common.cpp:
1159         (parseCommandLine):
1160         * MiniBrowser/win/Common.h:
1161         (CommandLineOptions::CommandLineOptions):
1162         * MiniBrowser/win/MainWindow.cpp:
1163         (MainWindow::MainWindow):
1164         (MainWindow::create):
1165         (MainWindow::init):
1166         (MainWindow::WndProc):
1167         * MiniBrowser/win/MainWindow.h:
1168         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1169         (PrintWebUIDelegate::createWebViewWithRequest):
1170         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1171         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1172         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1173         (WebKitBrowserWindow::updateProxySettings):
1174         (WebKitBrowserWindow::createNewPage):
1175         * MiniBrowser/win/WebKitBrowserWindow.h:
1176         * MiniBrowser/win/WinMain.cpp:
1177         (wWinMain):
1178
1179 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1180
1181         Make it possible to test scrolling tree layer manipulation more easily
1182         https://bugs.webkit.org/show_bug.cgi?id=195780
1183
1184         Reviewed by Tim Horton.
1185         
1186         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1187         cuts off communication of scrolling tree scrolls back to the web process
1188         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1189         allows tests to trigger scrolls which run the scrolling tree layer positioning
1190         logic, but never get another commit from the web process that might mask
1191         scrolling tree bugs.
1192         
1193         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1194         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1195         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1196
1197         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1198         (WTR::UIScriptController::scrollUpdatesDisabled const):
1199         (WTR::UIScriptController::setScrollUpdatesDisabled):
1200         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1201         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1202         (WTR::UIScriptController::scrollUpdatesDisabled const):
1203         (WTR::UIScriptController::setScrollUpdatesDisabled):
1204         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1205         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1206         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1207         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1208         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1209         * WebKitTestRunner/ios/TestControllerIOS.mm:
1210         (WTR::TestController::platformResetStateToConsistentValues):
1211         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1212         (WTR::UIScriptController::scrollUpdatesDisabled const):
1213         (WTR::UIScriptController::setScrollUpdatesDisabled):
1214
1215 2019-03-14  Youenn Fablet  <youenn@apple.com>
1216
1217         Move IDB storage in private browsing mode to NetworkProcess
1218         https://bugs.webkit.org/show_bug.cgi?id=195602
1219
1220         Reviewed by Brady Eidson.
1221
1222         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1223         (TEST):
1224
1225 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1226
1227         [ews-build] Make descriptionDone messages more readable
1228         https://bugs.webkit.org/show_bug.cgi?id=195760
1229
1230         Reviewed by Lucas Forschler.
1231
1232         * BuildSlaveSupport/ews-build/steps.py:
1233         * BuildSlaveSupport/ews-build/steps_unittest.py:
1234
1235 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1236
1237         [ews-build] Generate status-bubble hover-over messages
1238         https://bugs.webkit.org/show_bug.cgi?id=195680
1239
1240         Reviewed by Lucas Forschler.
1241
1242         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1243         (StatusBubble):
1244         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1245         on hover-over.
1246         (StatusBubble._iso_time):
1247         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1248         hover-over message.
1249         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1250
1251 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1252
1253         [ews-app] Gracefully handle the case when state_string is None
1254         https://bugs.webkit.org/show_bug.cgi?id=195753
1255
1256         Reviewed by Lucas Forschler.
1257
1258         * BuildSlaveSupport/ews-app/ews/models/build.py:
1259         * BuildSlaveSupport/ews-app/ews/models/step.py:
1260
1261 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1262
1263         [ews-app] Status bubble display pending for currently running build step
1264         https://bugs.webkit.org/show_bug.cgi?id=195744
1265
1266         Reviewed by Lucas Forschler.
1267
1268         * BuildSlaveSupport/ews-build/events.py:
1269         (Events.stepStarted): If state_string is pending, replace it with step name.
1270
1271 2019-03-14  Chris Dumez  <cdumez@apple.com>
1272
1273         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1274         https://bugs.webkit.org/show_bug.cgi?id=195750
1275
1276         Reviewed by Geoffrey Garen.
1277
1278         Add API test coverage.
1279
1280         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1281         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1282         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1283         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1284
1285 2019-03-14  Chris Dumez  <cdumez@apple.com>
1286
1287         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1288         https://bugs.webkit.org/show_bug.cgi?id=195747
1289
1290         Reviewed by Geoff Garen.
1291
1292         Add API test coverage.
1293
1294         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1295
1296 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1297
1298         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1299         https://bugs.webkit.org/show_bug.cgi?id=195725
1300         <rdar://problem/48545062>
1301
1302         Reviewed by Tim Horton.
1303
1304         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1305         handler is nil.
1306
1307         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1308         (TestWebKitAPI::TEST):
1309
1310 2019-03-13  Sam Weinig  <sam@webkit.org>
1311
1312         Add utility function to allow easy reverse range-based iteration of a container
1313         https://bugs.webkit.org/show_bug.cgi?id=195542
1314
1315         Reviewed by Antti Koivisto.
1316
1317         * TestWebKitAPI/CMakeLists.txt:
1318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1319         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1320         (TestWebKitAPI::TEST):
1321         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1322
1323 2019-03-13  Chris Dumez  <cdumez@apple.com>
1324
1325         Use a ServiceWorker process per registrable domain
1326         https://bugs.webkit.org/show_bug.cgi?id=195649
1327
1328         Reviewed by Youenn Fablet.
1329
1330         Update API test coverage.
1331
1332         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1333
1334 2019-03-13  Chris Dumez  <cdumez@apple.com>
1335
1336         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1337         https://bugs.webkit.org/show_bug.cgi?id=195684
1338         <rdar://problem/48294714>
1339
1340         Reviewed by Antti Koivisto.
1341
1342         Add API test coverage.
1343
1344         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1345
1346 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1347
1348         [ews-app] Remove unused patch view
1349         https://bugs.webkit.org/show_bug.cgi?id=195669
1350
1351         Reviewed by Lucas Forschler.
1352
1353         * BuildSlaveSupport/ews-app/ews/urls.py:
1354         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1355
1356 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1357
1358         [ews-app] Use Buildbot result code variables
1359         https://bugs.webkit.org/show_bug.cgi?id=195668
1360
1361         Reviewed by Alexey Proskuryakov.
1362
1363         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1364         (Buildbot): Added Buildbot result code variables.
1365         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1366         (StatusBubble._build_bubble): Used Buildbot result code variables.
1367
1368 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
1369
1370         [Flatpak] Expand submodule recursively
1371         https://bugs.webkit.org/show_bug.cgi?id=195672
1372
1373         Building WPE with flatpak was impossible without that as it was raising an exception.
1374         Also update wpebackend-fdo to match what is built in jhbuild
1375
1376         Reviewed by Philippe Normand.
1377
1378         * flatpak/flatpakutils.py:
1379         (expand_submodules_recurse):
1380         (expand_manifest):
1381         * flatpak/org.webkit.WPEModules.yaml:
1382
1383 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1384
1385         [ews-app] status bubble should be hidden for certain builds
1386         https://bugs.webkit.org/show_bug.cgi?id=194597
1387
1388         Reviewed by Dewei Zhu.
1389
1390         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1391         (StatusBubble._build_bubble):
1392         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
1393         because the patch didn't have relevant changes.
1394         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
1395         in production yet.
1396
1397 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
1398
1399         [Win] Fix a slew of simple clang-cl warnings.
1400         https://bugs.webkit.org/show_bug.cgi?id=195652
1401
1402         Reviewed by Don Olmstead.
1403
1404         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1405         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
1406
1407 2019-03-12  Justin Fan  <justin_fan@apple.com>
1408
1409         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
1410         https://bugs.webkit.org/show_bug.cgi?id=195518
1411         <rdar://problem/46322356>
1412
1413         Reviewed by Myles C. Maxfield.
1414
1415         * DumpRenderTree/DerivedSources-input.xcfilelist:
1416         * DumpRenderTree/DerivedSources-output.xcfilelist:
1417
1418 2019-03-12  Commit Queue  <commit-queue@webkit.org>
1419
1420         Unreviewed, rolling out r242825.
1421         https://bugs.webkit.org/show_bug.cgi?id=195648
1422
1423         "Broke webkitpy tests with my change to
1424         lldb_dump_class_layout.py" (Requested by rmorisset on
1425         #webkit).
1426
1427         Reverted changeset:
1428
1429         "Alter Tools/Scripts/dump-class-layout to be able to dump all
1430         classes with suspicious padding"
1431         https://bugs.webkit.org/show_bug.cgi?id=195573
1432         https://trac.webkit.org/changeset/242825
1433
1434 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1435
1436         [ews-build] Show status bubbles while the patch is waiting in queue
1437         https://bugs.webkit.org/show_bug.cgi?id=195618
1438
1439         Reviewed by Lucas Forschler.
1440
1441         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1442         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
1443         enabled in initial deployment.
1444         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
1445         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
1446         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
1447         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
1448         (StatusBubble._build_bubbles_for_patch):
1449
1450 2019-03-12  Robin Morisset  <rmorisset@apple.com>
1451
1452         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
1453         https://bugs.webkit.org/show_bug.cgi?id=195573
1454
1455         Reviewed by Simon Fraser.
1456
1457         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
1458
1459         * Scripts/dump-class-layout:
1460         (main):
1461         * lldb/lldb_dump_class_layout.py:
1462         (ClassLayout.__init__):
1463         (ClassLayout._compute_padding_recursive):
1464         (LLDBDebuggerInstance.dump_layout_for_classname):
1465         (LLDBDebuggerInstance):
1466         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
1467         (LLDBDebuggerInstance.layout_for_classname): Deleted.
1468
1469 2019-03-12  Chris Dumez  <cdumez@apple.com>
1470
1471         Device Orientation access permission should be denied unless explicitly granted by the client
1472         https://bugs.webkit.org/show_bug.cgi?id=195625
1473
1474         Reviewed by Youenn Fablet.
1475
1476         add API test coverage.
1477
1478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1479         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
1480         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
1481         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
1482         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1483         (runDeviceOrientationTest):
1484         (TEST):
1485         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1486         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1487
1488 2019-03-12  Jer Noble  <jer.noble@apple.com>
1489
1490         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
1491         https://bugs.webkit.org/show_bug.cgi?id=195137
1492         <rdar://problem/48810307>
1493
1494         Reviewed by Eric Carlson.
1495
1496         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
1497         (TestWebKitAPI::TEST):
1498
1499 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1500
1501         [ews-build] Change urls from uat to production
1502         https://bugs.webkit.org/show_bug.cgi?id=195566
1503
1504         Reviewed by Lucas Forschler.
1505
1506         * BuildSlaveSupport/ews-app/ews/config.py:
1507         * BuildSlaveSupport/ews-build/events.py:
1508         * BuildSlaveSupport/ews-build/steps.py:
1509
1510 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1511
1512         [ews-build] change max_builds for local-worker to 1
1513         https://bugs.webkit.org/show_bug.cgi?id=195568
1514
1515         Reviewed by Lucas Forschler.
1516
1517         * BuildSlaveSupport/ews-build/loadConfig.py:
1518
1519 2019-03-12  Tim Horton  <timothy_horton@apple.com>
1520
1521         Fix the build
1522
1523         * TestRunnerShared/spi/PencilKitTestSPI.h:
1524         * TestWebKitAPI/ios/PencilKitTestSPI.h:
1525
1526 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1527
1528         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
1529         https://bugs.webkit.org/show_bug.cgi?id=194131
1530
1531         Reviewed by Michael Catanzaro.
1532
1533         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1534         (uriChanged):
1535         (testUnfinishedSubresourceLoad):
1536         (serverCallback):
1537         (beforeAll):
1538
1539 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1540
1541         WTF::Expected should use std::addressof instead of operator&
1542         https://bugs.webkit.org/show_bug.cgi?id=195604
1543
1544         Reviewed by Myles Maxfield.
1545
1546         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1547         (TestWebKitAPI::Unique::Unique):
1548         (TestWebKitAPI::Unique::operator&):
1549         (TestWebKitAPI::TEST):
1550
1551 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
1552
1553         Add Optional to Forward.h.
1554         https://bugs.webkit.org/show_bug.cgi?id=195586
1555
1556         Reviewed by Darin Adler.
1557
1558         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
1559         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
1560         Remove unnecessary includes from headers.
1561
1562 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
1563
1564         Add testing API to hit-test and scroll overflow scrollers
1565         https://bugs.webkit.org/show_bug.cgi?id=195278
1566
1567         Reviewed by Antti Koivisto.
1568         
1569         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
1570         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
1571         
1572         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
1573
1574         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1575         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1576         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1577         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1578         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1579         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1580         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1581         (WTR::enclosingScrollViewIncludingSelf):
1582         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1583
1584 2019-03-11  Tim Horton  <timothy_horton@apple.com>
1585
1586         API test WebKit.RequestTextInputContext fails on iOS
1587         https://bugs.webkit.org/show_bug.cgi?id=195585
1588
1589         Reviewed by Wenson Hsieh and Simon Fraser.
1590
1591         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1592         (applyStyle):
1593         (TEST):
1594         Add a viewport, so that the coordinates match up on iOS.
1595         Scroll by moving the UIScrollView's contentOffset.
1596
1597 2019-03-11  Chris Dumez  <cdumez@apple.com>
1598
1599         Assert in WebPageProxy::suspendCurrentPageIfPossible()
1600         https://bugs.webkit.org/show_bug.cgi?id=195506
1601         <rdar://problem/48733477>
1602
1603         Reviewed by Alex Christensen.
1604
1605         Add API test coverage.
1606
1607         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1608
1609 2019-03-11  Shawn Roberts  <sroberts@apple.com>
1610
1611         Adding myself to contributors.json
1612
1613         Unreviewed, addming myself to contributors.json .
1614
1615         * Scripts/webkitpy/common/config/contributors.json:
1616
1617 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1618
1619         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1620         https://bugs.webkit.org/show_bug.cgi?id=195511
1621         <rdar://problem/44873269>
1622
1623         Reviewed by Darin Adler.
1624
1625         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1626         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1627         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1628         (TEST_F):
1629
1630 2019-03-11  Chris Dumez  <cdumez@apple.com>
1631
1632         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
1633         https://bugs.webkit.org/show_bug.cgi?id=195561
1634
1635         Reviewed by Youenn Fablet.
1636
1637         Make sure the JS in the test requests for permission to receive device orientation events.
1638
1639         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1640
1641 2019-03-11  Youenn Fablet  <youenn@apple.com>
1642
1643         Allow storage quota increase by default in WTR
1644         https://bugs.webkit.org/show_bug.cgi?id=195541
1645
1646         Reviewed by Geoffrey Garen.
1647
1648         Allow storage quota increase by default in WTR.
1649         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
1650         Use this for tests that explicitly need cache increase.
1651
1652         Instead of increasing quota by 2, make sure the next request is
1653         granted by adding all given parameters.
1654
1655         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1656         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1657         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1658         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
1659         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1660         * WebKitTestRunner/TestController.cpp:
1661         (WTR::TestController::setAllowStorageQuotaIncrease):
1662         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1663         * WebKitTestRunner/TestController.h:
1664         * WebKitTestRunner/TestInvocation.cpp:
1665         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1666         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1667         (WTR::TestController::cocoaResetStateToConsistentValues):
1668         (WTR::TestController::setAllowStorageQuotaIncrease):
1669         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1670         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1671         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1672
1673 2019-03-11  Xan Lopez  <xan@igalia.com>
1674
1675         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
1676         https://bugs.webkit.org/show_bug.cgi?id=194147
1677
1678         Reviewed by Michael Saboff.
1679
1680         To make --32-bit work correctly on Linux/64bit we need to:
1681
1682         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
1683         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
1684         unfortunately CMake only allows us to do this during
1685         crosscompilation, which is overkill here.
1686         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
1687         pkg-config detection module uses the x86 .pc files instead of the
1688         x86_64 ones.
1689         - Set the -m32 flags for the compiler.
1690
1691         * Scripts/webkitdirs.pm:
1692         (generateBuildSystemFromCMakeProject):
1693
1694 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
1695
1696         Add MotionMark-1.1 plan file for run-benchmark script.
1697         https://bugs.webkit.org/show_bug.cgi?id=195481
1698
1699         Rubber-stamped by Darin Adler.
1700
1701         Run-benchmark script should support MontionMark-1.1.
1702
1703         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
1704
1705 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1706
1707         [ews-app] Add support for submit-to-ews url
1708         https://bugs.webkit.org/show_bug.cgi?id=195477
1709
1710         Reviewed by Lucas Forschler.
1711
1712         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1713         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1714         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
1715         * BuildSlaveSupport/ews-app/ews/urls.py:
1716         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
1717
1718 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
1719
1720         Unreviewed, rolling out r242688, r242643, r242624.
1721
1722         Caused multiple layout test failures and crashes on iOS and macOS.
1723
1724         Reverted changeset:
1725
1726         "requestAnimationFrame should execute before the next frame"
1727         https://bugs.webkit.org/show_bug.cgi?id=177484
1728         https://trac.webkit.org/changeset/242624/webkit
1729
1730         * Tracing/SystemTracePoints.plist:
1731
1732 2019-03-11  John Wilander  <wilander@apple.com>
1733
1734         Resource Load Statistics: Make it possible exclude localhost from classification
1735         https://bugs.webkit.org/show_bug.cgi?id=195474
1736         <rdar://problem/47520577>
1737
1738         Reviewed by Brent Fulgham.
1739
1740         This patch allows for localhost to be excluded from classification and
1741         treatment as a prevalent resource.
1742
1743         The WebKit Tools change adds a new function called
1744         testRunner.setStatisticsIsRunningTest() which can be used to control this
1745         behavior.
1746
1747         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1748         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1749         (WTR::TestRunner::setStatisticsIsRunningTest):
1750         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1751         * WebKitTestRunner/TestController.cpp:
1752         (WTR::TestController::setStatisticsIsRunningTest):
1753         * WebKitTestRunner/TestController.h:
1754         * WebKitTestRunner/TestInvocation.cpp:
1755         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1756
1757 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1758
1759         [ews-build] Disable waterfall and console view for ews-build.webkit.org
1760         https://bugs.webkit.org/show_bug.cgi?id=195560
1761
1762         Reviewed by Lucas Forschler.
1763
1764         * BuildSlaveSupport/ews-build/master.cfg:
1765
1766 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1767
1768         Unreviewed, rolling out r242698.
1769
1770         API test crashes on bots.
1771
1772         Reverted changeset:
1773
1774         "Add a WKContentRuleList variant that uses copied memory
1775         instead of mmap'd shared memory for class A containerized
1776         apps"
1777         https://bugs.webkit.org/show_bug.cgi?id=195511
1778         https://trac.webkit.org/changeset/242698
1779
1780 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1781
1782         [WPE] Enable web process sandbox
1783         https://bugs.webkit.org/show_bug.cgi?id=195169
1784
1785         Reviewed by Daniel Bates.
1786
1787         * wpe/install-dependencies:
1788         * wpe/jhbuild.modules:
1789
1790 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1791
1792         [ews-app] Use port 17000 for worker communication
1793         https://bugs.webkit.org/show_bug.cgi?id=195558
1794
1795         Reviewed by Lucas Forschler.
1796
1797         * BuildSlaveSupport/ews-build/master.cfg:
1798
1799 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1800
1801         [ews-build] unit-tests fail when passwords.json is missing
1802         https://bugs.webkit.org/show_bug.cgi?id=195557
1803
1804         Reviewed by Lucas Forschler.
1805
1806         * BuildSlaveSupport/ews-build/loadConfig.py:
1807         (loadBuilderConfig):
1808         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1809         (ConfigDotJSONTest.test_configuration):
1810         * BuildSlaveSupport/ews-build/master.cfg:
1811
1812 2019-03-11  Truitt Savell  <tsavell@apple.com>
1813
1814         Unreviewed, rolling out r242702.
1815
1816         Broke High Sierra builders.
1817
1818         Reverted changeset:
1819
1820         "Add utility function to allow easy reverse range-based
1821         iteration of a container"
1822         https://bugs.webkit.org/show_bug.cgi?id=195542
1823         https://trac.webkit.org/changeset/242702
1824
1825 2019-03-11  Sam Weinig  <sam@webkit.org>
1826
1827         Add utility function to allow easy reverse range-based iteration of a container
1828         https://bugs.webkit.org/show_bug.cgi?id=195542
1829
1830         Reviewed by Antti Koivisto.
1831
1832         * TestWebKitAPI/CMakeLists.txt:
1833         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1834         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1835         (TestWebKitAPI::TEST):
1836         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1837
1838 2019-03-10  Alex Christensen  <achristensen@webkit.org>
1839
1840         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1841         https://bugs.webkit.org/show_bug.cgi?id=195511
1842         <rdar://problem/44873269>
1843
1844         Reviewed by Darin Adler.
1845
1846         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1847         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1848         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1849         (TEST_F):
1850
1851 2019-03-10  Tim Horton  <timothy_horton@apple.com>
1852
1853         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
1854         https://bugs.webkit.org/show_bug.cgi?id=195499
1855
1856         Reviewed by Darin Adler.
1857
1858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1859         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
1860         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
1861         (-[WKWebView synchronouslyFocusTextInputContext:]):
1862         (applyStyle):
1863         (applyIframe):
1864         (TEST):
1865         Add some tests for this SPI.
1866
1867 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
1868
1869         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
1870         https://bugs.webkit.org/show_bug.cgi?id=181151
1871
1872         Reviewed by Don Olmstead.
1873
1874         * TestWebKitAPI/CMakeLists.txt:
1875         * TestWebKitAPI/PlatformWin.cmake:
1876         Enable TestWTF RunLoop tests in all platforms.
1877
1878         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1879         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
1880         (TestWebKitAPI::DerivedOneShotTimer::fired):
1881         (TestWebKitAPI::TEST):
1882         Only a few platforms support nested RunLoop.
1883
1884         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
1885         (TestWebKitAPI::DerivedRepeatingTimer::fired):
1886
1887 2019-03-10  David Quesada  <david_quesada@apple.com>
1888
1889         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
1890         https://bugs.webkit.org/show_bug.cgi?id=152480
1891
1892         Reviewed by Chris Dumez.
1893
1894         Add a unit test based on Daniel Bates's test case that starts a download, ensures
1895         there are no additional references to the process pool besides the one held by
1896         the download, waits for the download to finish (in the sense that the
1897         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
1898         measure, also check that the process pool has been deallocated at the end of the
1899         test. The test wouldn't be meaningful if the process pool were still alive.
1900
1901         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1902         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1903         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
1904             The download will be canceled because the delegate does not implement the
1905             method to decide the download's destination, so this is where we know the
1906             DownloadProxyMap is done with the DownloadProxy.
1907         (TEST):
1908
1909 2019-03-08  Chris Dumez  <cdumez@apple.com>
1910
1911         Add support for Device Orientation / Motion permission API
1912         https://bugs.webkit.org/show_bug.cgi?id=195329
1913         <rdar://problem/47645367>
1914
1915         Reviewed by Geoffrey Garen.
1916
1917         Add test infrastructure to help test the Device Orientation / Motion permission API.
1918
1919         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1920         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1921         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1922         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1923         * WebKitTestRunner/TestController.cpp:
1924         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
1925         (WTR::TestController::createWebViewWithOptions):
1926         (WTR::TestController::resetStateToConsistentValues):
1927         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
1928         * WebKitTestRunner/TestController.h:
1929         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
1930         * WebKitTestRunner/TestInvocation.cpp:
1931         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1932
1933 2019-03-08  Saam barati  <sbarati@apple.com>
1934
1935         Add a compare-results script to compare benchmark results
1936         https://bugs.webkit.org/show_bug.cgi?id=195486
1937         <rdar://problem/48723397>
1938
1939         Reviewed by Geoffrey Garen.
1940
1941         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
1942         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
1943         to extend it to learn about our other benchmarks.
1944
1945         * Scripts/compare-results: Added.
1946         (readJSONFile):
1947         (detectJetStream2):
1948         (JetStream2Results):
1949         (detectSpeedometer2):
1950         (Speedometer2Results):
1951         (detectPLT5):
1952         (PLT5Results):
1953         (detectBenchmark):
1954         (biggerIsBetter):
1955         (ttest):
1956         (getOptions):
1957         (main):
1958
1959 2019-03-08  Stephanie Lewis  <slewis@apple.com>
1960
1961         Ensure old tab state is cleared between iterations of run-benchmark
1962         https://bugs.webkit.org/show_bug.cgi?id=195393
1963         <rdar://problem/46885583>
1964
1965         Reviewed by Dewei Zhu.
1966
1967         a) ensure the default to restore state is not set
1968         b) terminate Safari correctly
1969         c) Set the system default to ignore Persistent State in Safari
1970
1971         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1972         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
1973         (OSXBrowserDriver.prepare_env): 
1974         (OSXBrowserDriver.restore_env):
1975         (OSXBrowserDriver.close_browsers):
1976         (OSXBrowserDriver._terminate_processes):
1977         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
1978         (OSXChromeDriver):
1979         (OSXChromeCanaryDriver):
1980         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
1981         (OSXFirefoxDriver):
1982         (OSXFirefoxNightlyDriver):
1983         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
1984         (OSXSafariDriver):
1985         (OSXSafariDriver.prepare_env):
1986
1987 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
1988
1989         [GTK] Several InputMethodFilter tests are failing
1990         https://bugs.webkit.org/show_bug.cgi?id=195408
1991
1992         Reviewed by Carlos Garcia Campos.
1993
1994         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
1995         Regressed in r241751.
1996         Hexadecimal values of keycodes are expressed now in upper letters.
1997         Composited characters should be cast to UTF8 strings.
1998
1999         (TestWebKitAPI::TEST):
2000
2001 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2002
2003         [GTK] Make Tools/gtkdoc python3 compatible
2004         https://bugs.webkit.org/show_bug.cgi?id=195359
2005
2006         Reviewed by Carlos Garcia Campos.
2007
2008         * gtkdoc/generate-gtkdoc:
2009         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2010         work with Python 2 and 3.
2011         (get_gtkdoc_module_paths):
2012         The iteritems() was removed in Python 3, so let's use items() that's
2013         available in Python 2 and 3.
2014         (get_generator_for_config):
2015         * gtkdoc/gtkdoc.py:
2016         (GTKDoc._run_command):
2017         The sys.stdout.write() is expecting str in Python 3 and not bytes
2018         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2019         for passing the bytes there.
2020
2021 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2022
2023         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2024         https://bugs.webkit.org/show_bug.cgi?id=195346
2025         <rdar://problem/48667048>
2026
2027         Unreviewed build fix for clang-cl.
2028
2029         * DumpRenderTree/win/DumpRenderTree.cpp:
2030         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2031
2032 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2033
2034         requestAnimationFrame should execute before the next frame
2035         https://bugs.webkit.org/show_bug.cgi?id=177484
2036
2037         Reviewed by Simon Fraser.
2038
2039         Add trace points for the page RenderingUpdate.
2040
2041         * Tracing/SystemTracePoints.plist:
2042
2043 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2044
2045         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2046         https://bugs.webkit.org/show_bug.cgi?id=195353
2047         <rdar://problem/48626394>
2048
2049         Reviewed by Simon Fraser.
2050
2051         * WebKitTestRunner/ios/TestControllerIOS.mm:
2052         (WTR::TestController::platformResetPreferencesToConsistentValues):
2053
2054 2019-03-07  John Wilander  <wilander@apple.com>
2055
2056         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2057         https://bugs.webkit.org/show_bug.cgi?id=195383
2058         <rdar://problem/48570136>
2059
2060         Reviewed by Brent Fulgham.
2061
2062         This patch adds test infrastructure to purge only script-accessible cookies,
2063         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2064
2065         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2066         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2067         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2068         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2069         * WebKitTestRunner/TestController.cpp:
2070         (WTR::TestController::statisticsDeleteCookiesForHost):
2071         * WebKitTestRunner/TestController.h:
2072         * WebKitTestRunner/TestInvocation.cpp:
2073         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2074
2075 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2076
2077         Unreviewed, rolling out r242354.
2078         https://bugs.webkit.org/show_bug.cgi?id=195402
2079
2080         breaks layout tests in all configurations (Requested by
2081         zdobersek on #webkit).
2082
2083         Reverted changeset:
2084
2085         "[WPE] Enable web process sandbox"
2086         https://bugs.webkit.org/show_bug.cgi?id=195169
2087         https://trac.webkit.org/changeset/242354
2088
2089 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2090
2091         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2092         https://bugs.webkit.org/show_bug.cgi?id=195346
2093
2094         Reviewed by Fujii Hironori.
2095
2096         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2097         (TestWebKitAPI::TEST):
2098         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2099
2100         * DumpRenderTree/win/DumpRenderTree.cpp:
2101         (findFontFallback):
2102         (addFontFallbackIfPresent):
2103         (removeFontFallbackIfPresent):
2104         (main):
2105         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2106         (TestWebKitAPI::Util::moduleDirectory):
2107         (TestWebKitAPI::Util::createInjectedBundlePath):
2108         Use wchar helpers as needed.
2109
2110 2019-03-06  Rob Buis  <rbuis@igalia.com>
2111
2112         Consider supporting the `referrerpolicy` attribute.
2113         https://bugs.webkit.org/show_bug.cgi?id=179053
2114
2115         Reviewed by Darin Adler.
2116
2117         Add a runtime flag for referrerpolicy attribute.
2118
2119         * DumpRenderTree/mac/DumpRenderTree.mm:
2120         (enableExperimentalFeatures):
2121
2122 2019-03-05  Daniel Bates  <dabates@apple.com>
2123
2124         Update expected API test result following r242379
2125         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2126
2127         Update expected x-coordinate of selection rect now that the left padding of
2128         a textarea is sized in ems (so dependent on the font size) just like the left
2129         padding of a text field.
2130
2131         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2132         (TestWebKitAPI::TEST):
2133
2134 2019-03-05  David Quesada  <david_quesada@apple.com>
2135
2136         [WK2] It should be possible to follow links with 'download' attributes
2137         https://bugs.webkit.org/show_bug.cgi?id=195145
2138         rdar://problem/48462642
2139
2140         Reviewed by Alex Christensen.
2141
2142         Add a unit test to verify that activating links with 'download' attributes now
2143         navigates to the linked resource, rather than starts downloading it. Add another
2144         to verify that it is still possible to explicitly download the link via the
2145         'Download' navigation action policy.
2146
2147         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2148         (-[DownloadAttributeTestDelegate init]):
2149         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2150         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2151         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2152         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2153         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2154         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2155         (TEST):
2156         * WebKitTestRunner/TestController.cpp:
2157         (WTR::TestController::decidePolicyForNavigationAction):
2158         * WebKitTestRunner/TestController.h:
2159
2160 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2161
2162         [Curl] Implement Cookie Accept Policy.
2163         https://bugs.webkit.org/show_bug.cgi?id=191645
2164
2165         Reviewed by Fujii Hironori.
2166
2167         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2168         (TestWebKitAPI::Curl::TEST_F):
2169
2170 2019-03-05  Youenn Fablet  <youenn@apple.com>
2171
2172         Rename requestCacheStorageSpace to requestStorageSpace
2173         https://bugs.webkit.org/show_bug.cgi?id=195282
2174
2175         Reviewed by Chris Dumez.
2176
2177         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2178         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2179         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2180
2181 2019-03-05  Brady Eidson  <beidson@apple.com>
2182
2183         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2184         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2185
2186         Reviewed by Tim Horton.
2187
2188         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2189         different directory into that same WKWebView should work.
2190
2191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2192         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2193
2194 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2195
2196         Add WeakHashSet
2197         https://bugs.webkit.org/show_bug.cgi?id=195152
2198
2199         Reviewed by Antti Koivisto.
2200
2201         Added tests for WeakHashSet.
2202
2203         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2204         (TestWebKitAPI::Base::Base): Moved.
2205         (TestWebKitAPI::Derived::foo): Moved.
2206         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2207         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2208         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2209         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2210
2211 2019-03-04  Chris Dumez  <cdumez@apple.com>
2212
2213         Do not share WebProcesses between private and regular sessions
2214         https://bugs.webkit.org/show_bug.cgi?id=195189
2215         <rdar://problem/48421064>
2216
2217         Reviewed by Alex Christensen.
2218
2219         Add API test coverage.
2220
2221         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2222         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2223
2224 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2225
2226         [WPE] Enable web process sandbox
2227         https://bugs.webkit.org/show_bug.cgi?id=195169
2228
2229         Reviewed by Daniel Bates.
2230
2231         * wpe/install-dependencies:
2232         * wpe/jhbuild.modules:
2233
2234 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2235
2236         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2237         https://bugs.webkit.org/show_bug.cgi?id=195206
2238
2239         Reviewed by Žan Doberšek.
2240
2241         Add a new test case.
2242
2243         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2244         (testJSCClass):
2245
2246 2019-03-04  Charlie Turner  <cturner@igalia.com>
2247
2248         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2249         https://bugs.webkit.org/show_bug.cgi?id=194898
2250
2251         Reviewed by Žan Doberšek.
2252
2253         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2254         a GCC extension that permits arithmetic on void* pointer. Inline
2255         the macro until this issue is fixed upstream.
2256
2257 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2258
2259         Rid the world of WK_API_ENABLED
2260         https://bugs.webkit.org/show_bug.cgi?id=195263
2261
2262         Reviewed by Dan Bernstein.
2263
2264         List of changed files elided because it's useless.
2265
2266 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2267
2268         Unreviewed follow-up to r242292.
2269
2270         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2271
2272         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2273         (TestWebKitAPI::testStrip): Renamed from strip.
2274         (TestWebKitAPI::TEST):
2275
2276 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2277
2278         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2279
2280         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2281         and bug #194272 for details.
2282
2283         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2284
2285 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2286
2287         Remove some more unused 32-bit code
2288         https://bugs.webkit.org/show_bug.cgi?id=195255
2289
2290         Reviewed by Darin Adler.
2291
2292         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2293         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2294         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2295         (NPP_New):
2296         (NPP_HandleEvent):
2297         (handleEventCarbon): Deleted.
2298
2299 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2300
2301         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2302
2303         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2304         (TestWebKitAPI::TEST):
2305
2306 2019-03-01  Darin Adler  <darin@apple.com>
2307
2308         Finish removing String::format
2309         https://bugs.webkit.org/show_bug.cgi?id=194893
2310
2311         Reviewed by Daniel Bates.
2312 '
2313         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2314
2315 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2316
2317         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2318         https://bugs.webkit.org/show_bug.cgi?id=195229
2319         <rdar://problem/48520362>
2320
2321         Reviewed by Chris Dumez.
2322
2323         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2324         (TEST):
2325
2326 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2327
2328         Add a system trace scope for event region building
2329         https://bugs.webkit.org/show_bug.cgi?id=195226
2330
2331         Reviewed by Jon Lee.
2332
2333         This trace scope measures the time spend converting element rects into Region objects,
2334         which can be large on some pages.
2335
2336         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2337
2338         * Tracing/SystemTracePoints.plist:
2339
2340 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2341
2342         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2343         https://bugs.webkit.org/show_bug.cgi?id=194612
2344
2345         Reviewed by Alex Christensen.
2346
2347         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2348         Just test the new string-processing function and don't touch the actual environment.
2349         (Test cases are all as before, but based on operator== instead of strcmp.)
2350
2351 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2352
2353         [ews-app] Update primary keys for handling multiple Buildbot instances
2354         https://bugs.webkit.org/show_bug.cgi?id=195120
2355
2356         Reviewed by Stephanie Lewis.
2357
2358         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2359         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
2360         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
2361
2362         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
2363         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
2364         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
2365         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
2366         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
2367         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
2368
2369 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
2370
2371         [WinCairo] Enable service worker
2372         https://bugs.webkit.org/show_bug.cgi?id=188318
2373
2374         Reviewed by Youenn Fablet.
2375
2376         * DumpRenderTree/DumpRenderTreePrefix.h:
2377         * TestWebKitAPI/PlatformWin.cmake:
2378         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
2379         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
2380         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2381
2382 2019-03-01  Justin Fan  <justin_fan@apple.com>
2383
2384         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
2385         https://bugs.webkit.org/show_bug.cgi?id=195191
2386
2387         Rubber-stamped by Dean Jackson.
2388
2389         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
2390
2391         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2392
2393 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
2394
2395         Unreviewed, fix lldb webkitpy tests
2396         https://bugs.webkit.org/show_bug.cgi?id=194375
2397
2398         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
2399
2400         * lldb/lldb_webkit.py:
2401         (WTFStringImplProvider.is_8bit):
2402
2403 2019-02-28  David Quesada  <david_quesada@apple.com>
2404
2405         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
2406         https://bugs.webkit.org/show_bug.cgi?id=195121
2407         rdar://problem/48450302
2408
2409         Reviewed by Alex Christensen.
2410
2411         Add API tests for -WKNavigationAction._shouldPerformDownload in various
2412         configurations where the 'download' attribute is absent, blank, or populated
2413         with a filename, and where the anchor element is same-origin or cross-origin
2414         (meaning the 'download' attribute shouldn't be honored).
2415
2416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2417         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
2418         (-[NavigationActionTestDelegate init]):
2419         (-[NavigationActionTestDelegate navigationAction]):
2420         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
2421         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
2422         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2423         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
2424         (TEST):
2425
2426 2019-02-28  Antoine Quint  <graouts@apple.com>
2427
2428         Enable the Pointer Events runtime flag by default
2429         https://bugs.webkit.org/show_bug.cgi?id=195156
2430
2431         Reviewed by Dean Jackson.
2432
2433         * DumpRenderTree/mac/DumpRenderTree.mm:
2434         (enableExperimentalFeatures):
2435
2436 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2437
2438         Several PasteImage API tests are flaky
2439         https://bugs.webkit.org/show_bug.cgi?id=195160
2440
2441         Reviewed by Tim Horton.
2442
2443         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
2444         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
2445         listening for a "load" event after image load is already complete.
2446
2447         To address this, make these tests first register a "load" event handler, then run script to insert an image
2448         element into the document, and finally wait until the load event is observed before checking image size.
2449
2450         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2451
2452 2019-02-28  Chris Dumez  <cdumez@apple.com>
2453
2454         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
2455         https://bugs.webkit.org/show_bug.cgi?id=195107
2456
2457         Reviewed by Alex Christensen.
2458
2459         Give some time for the zoom level to get restored.
2460
2461         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2462
2463 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
2464
2465         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
2466         https://bugs.webkit.org/show_bug.cgi?id=194958
2467
2468         Reviewed by Geoffrey Garen.
2469
2470         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
2471         (TEST):
2472
2473 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
2474
2475         [ews-app] Update method to save build to handle builder_display_name
2476         https://bugs.webkit.org/show_bug.cgi?id=195047
2477
2478         Reviewed by Dewei Zhu.
2479
2480         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
2481         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
2482
2483 2019-02-28  Justin Fan  <justin_fan@apple.com>
2484
2485         [Web GPU] Enable Web GPU only on 64-bit
2486         https://bugs.webkit.org/show_bug.cgi?id=195139
2487
2488         Because Metal is only supported on 64 bit apps.
2489
2490         Unreviewed build fix.
2491
2492         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2493
2494 2019-02-27  Youenn Fablet  <youenn@apple.com>
2495
2496         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
2497         https://bugs.webkit.org/show_bug.cgi?id=194959
2498
2499         Reviewed by Chris Dumez.
2500
2501         Spin loop until getting the condition to remove flakiness.
2502
2503         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2504
2505 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
2506
2507         [ews-build] Buildbot should include builder_display_name in the build events
2508         https://bugs.webkit.org/show_bug.cgi?id=195045
2509
2510         Reviewed by Dewei Zhu.
2511
2512         * BuildSlaveSupport/ews-build/events.py:
2513         (Events.buildStarted): Included builder_display_name in event data. Also renamed
2514         buildername to builder_name to be consistent in naming style.
2515         (Events.buildFinished): Ditto.
2516
2517 2019-02-27  Chris Dumez  <cdumez@apple.com>
2518
2519         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
2520         https://bugs.webkit.org/show_bug.cgi?id=194480
2521
2522         Reviewed by Brady Eidson.
2523
2524         Update existing API test to make it more likely to reproduce the issue.
2525
2526         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2527
2528 2019-02-27  Brady Eidson  <beidson@apple.com>
2529
2530         Universal links from Google search results pages don't open the app.
2531         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
2532
2533         Reviewed by Geoffrey Garen.
2534
2535         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2536         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2537         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2538         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2539
2540 2019-02-27  Chris Dumez  <cdumez@apple.com>
2541
2542         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
2543         https://bugs.webkit.org/show_bug.cgi?id=195102
2544
2545         Reviewed by Geoffrey Garen.
2546
2547         If the number of processes is not yet what we expect, wait a bit and check again to give
2548         processes some time to exit.
2549
2550         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2551
2552 2019-02-27  Chris Dumez  <cdumez@apple.com>
2553
2554         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
2555         https://bugs.webkit.org/show_bug.cgi?id=194545
2556
2557         Reviewed by Brady Eidson.
2558
2559         Make sure the test navigates forward and then back only once. Previously, navigating
2560         back would trigger a navigation again in a timer.
2561
2562         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2563
2564 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
2565
2566         High Sierra Debug JSC test queue should use faster hardware
2567         https://bugs.webkit.org/show_bug.cgi?id=194603
2568
2569         Rubber-stamped by Alexey Proskuryakov.
2570
2571         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
2572
2573         * BuildSlaveSupport/build.webkit.org-config/config.json:
2574         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2575         (BubbleQueueServer):
2576         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2577         (WebKitBuildbot):
2578         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2579         * QueueStatusServer/config/queues.py:
2580         * Scripts/webkitpy/common/config/ews.json:
2581         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2582         (test_ews_name):
2583
2584 2019-02-27  John Wilander  <wilander@apple.com>
2585
2586         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
2587         https://bugs.webkit.org/show_bug.cgi?id=195071
2588         <rdar://problem/48417690>
2589
2590         Reviewed by Alex Christensen and Brent Fulgham.
2591
2592         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2593         (TestWebKitAPI::createURL):
2594             Convenience function.
2595         (TestWebKitAPI::TEST):
2596             WebCore::AdClickAttribution now takes a URL when creating Source and
2597             Destination.
2598         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
2599         (TestWebKitAPI::TEST):
2600             WebCore::AdClickAttribution now takes a URL when creating Source and
2601             Destination.
2602
2603 2019-02-27  Antoine Quint  <graouts@apple.com>
2604
2605         Support Pointer Events on macOS
2606         https://bugs.webkit.org/show_bug.cgi?id=195008
2607         <rdar://problem/47454419>
2608
2609         Reviewed by Dean Jackson.
2610
2611         * DumpRenderTree/mac/DumpRenderTree.mm:
2612         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
2613         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2614
2615 2019-02-26  Mark Lam  <mark.lam@apple.com>
2616
2617         Remove remaining poisoning code.
2618         https://bugs.webkit.org/show_bug.cgi?id=194138
2619
2620         Reviewed by Saam Barati.
2621
2622         * TestWebKitAPI/CMakeLists.txt:
2623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2624         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
2625         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
2626         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
2627         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
2628         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
2629         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
2630
2631 2019-02-26  Alex Christensen  <achristensen@webkit.org>
2632
2633         Move ephemeral local storage from WebProcess to UIProcess
2634         https://bugs.webkit.org/show_bug.cgi?id=195074
2635         <rdar://problem/47937975>
2636
2637         Reviewed by Geoff Garen.
2638
2639         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2640
2641 2019-02-20  Jer Noble  <jer.noble@apple.com>
2642
2643         [Cocoa] Media elements will restart network buffering just before suspending
2644         https://bugs.webkit.org/show_bug.cgi?id=193691
2645
2646         Reviewed by Eric Carlson.
2647
2648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2649         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2650         (TEST):
2651
2652 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
2653
2654         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
2655         https://bugs.webkit.org/show_bug.cgi?id=191652
2656
2657         Reviewed by Alex Christensen.
2658
2659         Fix WinCairo MiniBrowser behavior of authentication dialog.
2660
2661         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2662         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2663
2664 2019-02-26  Youenn Fablet  <youenn@apple.com>
2665
2666         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
2667         https://bugs.webkit.org/show_bug.cgi?id=195028
2668         <rdar://problem/48243733>
2669
2670         Reviewed by Eric Carlson.
2671
2672         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2673
2674 2019-02-26  Philippe Normand  <pnormand@igalia.com>
2675
2676         [WPE] Add API for webview background color configuration
2677         https://bugs.webkit.org/show_bug.cgi?id=192305
2678
2679         Reviewed by Michael Catanzaro.
2680
2681         * MiniBrowser/wpe/main.cpp:
2682         (main): Add a new option to configure the webview background
2683         color. Example: --bg-color=transparent.
2684         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2685         (testWebViewBackgroundColor): Enable background color API tests for WPE.
2686         (beforeAll): Ditto.
2687
2688 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
2689
2690         scalableNativeWebpageParameters() is not preserved on new page navigation.
2691         https://bugs.webkit.org/show_bug.cgi?id=194892
2692         <rdar://problem/47538280>
2693
2694         Reviewed by Wenson Hsieh.
2695         
2696         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
2697
2698         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2699         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2700         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2701         (WTR::UIScriptController::allowsViewportShrinkToFit):
2702         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2703         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2704         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2705         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2706         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2707         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2708
2709 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2710
2711         [ews-app] Add model for handling multiple Buildbot instances
2712         https://bugs.webkit.org/show_bug.cgi?id=194863
2713
2714         Reviewed by Stephanie Lewis.
2715
2716         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
2717
2718 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2719
2720         [ews-app] Remove BuilderMapping table
2721         https://bugs.webkit.org/show_bug.cgi?id=194961
2722
2723         Reviewed by Stephanie Lewis.
2724
2725         Store builder name directly in build table, instead of having a separate
2726         table for it.
2727
2728         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
2729         * BuildSlaveSupport/ews-app/ews/models/build.py:
2730         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
2731         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2732
2733 2019-02-25  John Wilander  <wilander@apple.com>
2734
2735         Introduce and adopt new class RegistrableDomain for eTLD+1
2736         https://bugs.webkit.org/show_bug.cgi?id=194791
2737         <rdar://problem/48179240>
2738
2739         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
2740
2741         This patch adds an API test and replaces two instances of
2742         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
2743
2744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2745         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2746         (TestWebKitAPI::TEST):
2747             Changed two strings to make sure the registrable domains are still considered
2748             invalid and pass the test.
2749         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
2750         (TestWebKitAPI::TEST):
2751         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2752         (WTR::InjectedBundle::didReceiveMessageToPage):
2753
2754 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
2755
2756         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
2757         https://bugs.webkit.org/show_bug.cgi?id=195001
2758
2759         Reviewed by Carlos Garcia Campos.
2760
2761         API version 1.0 always includes the functionality previously guarded with
2762         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
2763         unconditionally.
2764
2765         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2766         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
2767         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
2768         (WebViewTest::showInWindow): Ditto.
2769         (WebViewTest::hideView): Ditto.
2770         * wpe/backends/HeadlessViewBackend.cpp:
2771         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
2772         * wpe/backends/ViewBackend.cpp:
2773         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
2774         * wpe/backends/WindowViewBackend.cpp:
2775         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
2776         WPE_BACKEND_CHECK_VERSION().
2777         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
2778
2779 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
2780
2781         [Flatpak] Add support for flatpak > 1.1.2
2782         https://bugs.webkit.org/show_bug.cgi?id=194088
2783
2784         Flatpak 1.2 is now out so we need to support that
2785         version now.
2786
2787         Reviewed by Michael Catanzaro.
2788
2789         * flatpak/flatpakutils.py:
2790         (check_flatpak):
2791         (FlatpakPackages.__init__):
2792         (FlatpakPackages.__detect_packages):
2793         (FlatpakPackages.__detect_packages.in):
2794         (FlatpakRepos.update):
2795
2796 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
2797
2798         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
2799         https://bugs.webkit.org/show_bug.cgi?id=194998
2800
2801         Reviewed by Carlos Garcia Campos.
2802
2803         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
2804         to a Git checkout and using the latest commit containing various fixes
2805         and improvements.
2806
2807 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2808
2809         [WPE][GTK] Remove user agent quirk for washingtonpost.com
2810         https://bugs.webkit.org/show_bug.cgi?id=194981
2811
2812         Reviewed by Žan Doberšek.
2813
2814         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2815         (TestWebKitAPI::TEST):
2816
2817 2019-02-23  Keith Miller  <keith_miller@apple.com>
2818
2819         Add new mac target numbers
2820         https://bugs.webkit.org/show_bug.cgi?id=194955
2821
2822         Reviewed by Tim Horton.
2823
2824         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2825         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2826         * MiniBrowser/Configurations/Base.xcconfig:
2827         * TestWebKitAPI/Configurations/Base.xcconfig:
2828         * WebKitTestRunner/Configurations/Base.xcconfig:
2829
2830 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
2831
2832         [WinCairo] Enable wk1/wk2 suffix for platform search path.
2833         https://bugs.webkit.org/show_bug.cgi?id=194846
2834
2835         Reviewed by Don Olmstead.
2836
2837         Added _search_paths() and _port_specific_expectations_files() for
2838         WinCairoPort.
2839
2840         * Scripts/webkitpy/port/win.py:
2841         (WinCairoPort.default_baseline_search_path):
2842         (WinCairoPort):
2843         (WinCairoPort._port_specific_expectations_files):
2844         (WinCairoPort._search_paths):
2845
2846 2019-02-22  Tim Horton  <timothy_horton@apple.com>
2847
2848         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
2849         https://bugs.webkit.org/show_bug.cgi?id=194963
2850
2851         Reviewed by Dean Jackson.
2852
2853         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2854         Do a `contains` check instead of `equals`, because in debug builds we
2855         put the GraphicsLayer pointer in a prefix.
2856
2857 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2858
2859         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
2860         https://bugs.webkit.org/show_bug.cgi?id=194873
2861         <rdar://problem/46701974>
2862
2863         Reviewed by Tim Horton.
2864
2865         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
2866
2867         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2868         (WTR::UIScriptController::menuRect const):
2869         (WTR::UIScriptController::isShowingMenu const):
2870         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2871         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2872         (WTR::UIScriptController::menuRect const):
2873
2874         Add a function to query the bounds of the callout menu in content coordinates.
2875
2876         (WTR::UIScriptController::isShowingMenu const):
2877
2878         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
2879
2880         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2881         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2882         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2883         (WTR::UIScriptController::rectForMenuAction const):
2884         (WTR::UIScriptController::menuRect const):
2885         (WTR::UIScriptController::isShowingMenu const):
2886         (WTR::findViewInHierarchyOfType): Deleted.
2887
2888 2019-02-22  Chris Dumez  <cdumez@apple.com>
2889
2890         Regression(PSON) Unable to preview password-protected documents on iCloud.com
2891         https://bugs.webkit.org/show_bug.cgi?id=194954
2892         <rdar://problem/48127957>
2893
2894         Reviewed by Alex Christensen.
2895
2896         Add API test coverage.
2897
2898         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2899         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2900         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2901         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2902
2903 2019-02-22  Chris Dumez  <cdumez@apple.com>
2904
2905         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
2906         https://bugs.webkit.org/show_bug.cgi?id=194924
2907         <rdar://problem/48216125>
2908
2909         Reviewed by Geoffrey Garen.
2910
2911         Add API test coverage.
2912
2913         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2914
2915 2019-02-22  Chris Dumez  <cdumez@apple.com>
2916
2917         Unreviewed, disable API test added in r241928 on iOS.
2918
2919         The cache is not enabled on devices with less than 3GB of RAM.
2920
2921         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2922
2923 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
2924
2925         Hardcode Visual Viewports on everywhere except iOS WK1
2926         https://bugs.webkit.org/show_bug.cgi?id=194928
2927
2928         Reviewed by Zalan Bujtas.
2929
2930         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
2931         change the default value of the Setting to 'true', and hardcode WebView on iOS to
2932         set it to false. The setting has shipped for several years and there's no need to turn
2933         it off now.
2934
2935         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
2936         Visual Viewports are not enabled.
2937         
2938         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
2939         that only runs in WK2
2940
2941         * MiniBrowser/mac/SettingsController.h:
2942         * MiniBrowser/mac/SettingsController.m:
2943         (-[SettingsController init]):
2944         (-[SettingsController _populateMenu]):
2945         (-[SettingsController validateMenuItem:]):
2946         (-[SettingsController visualViewportEnabled]): Deleted.
2947         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
2948         * MiniBrowser/mac/WK1BrowserWindowController.m:
2949         (-[WK1BrowserWindowController didChangeSettings]):
2950         * MiniBrowser/mac/WK2BrowserWindowController.m:
2951         (-[WK2BrowserWindowController didChangeSettings]):
2952
2953 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
2954
2955         Discard cached processes when clearing website data store
2956         https://bugs.webkit.org/show_bug.cgi?id=194894
2957
2958         Reviewed by Chris Dumez.
2959
2960         Added a test case.
2961
2962         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2963         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
2964
2965 2019-02-21  Alex Christensen  <achristensen@webkit.org>
2966
2967         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
2968         https://bugs.webkit.org/show_bug.cgi?id=194914
2969         <rdar://problem/47586889>
2970
2971         Reviewed by Geoffrey Garen.
2972
2973         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2974         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
2975         (TEST):
2976         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
2977
2978 2019-02-21  David Kilzer  <ddkilzer@apple.com>
2979
2980         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
2981         <https://webkit.org/b/194761>
2982
2983         Reviewed by Myles Maxfield.
2984
2985         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2986         (WTR::activateSystemCoreWebFonts): Log `error` to console if
2987         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
2988         to use ARC-compliant cast.
2989         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
2990         ARC-compliant cast.
2991         (WTR::installFakeHelvetica): Log `error` to console if
2992         CTFontManagerRegisterFontsForURL() fails, but only on supported
2993         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
2994         Call CFRelease() on `error` to fix the leak.  Update to use
2995         ARC-compliant cast.
2996         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
2997         cast.
2998
2999 2019-02-21  Chris Dumez  <cdumez@apple.com>
3000
3001         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3002         https://bugs.webkit.org/show_bug.cgi?id=194481
3003
3004         Reviewed by Alex Christensen.
3005
3006         Give the processes a chance to shutdown and wait until we reached the expected number
3007         of processes.
3008
3009         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3010
3011 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3012
3013         Fix the macOS build
3014
3015         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3016
3017 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3018
3019         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3020
3021         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3022         I am a backwards.
3023
3024 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3025
3026         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3027
3028         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3029         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3030         We could force on UI-side compositing, but I feel like the test might be more
3031         valuable exercising the normal path on each platform (though the original
3032         bug was also UI-side specific). Though we can't validate that the overlay
3033         layer was installed successfully, there are layout tests that do that.
3034
3035 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3036
3037         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3038         https://bugs.webkit.org/show_bug.cgi?id=194845
3039         <rdar://problem/47944579>
3040
3041         Reviewed by Antti Koivisto.
3042
3043         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3044         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3045
3046 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3047
3048         [LFC][Floats] Add support for placing formatting roots in-between floats.
3049         https://bugs.webkit.org/show_bug.cgi?id=194902
3050
3051         Reviewed by Antti Koivisto.
3052
3053         * LayoutReloaded/misc/LFC-passing-tests.txt:
3054
3055 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3056
3057         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3058         https://bugs.webkit.org/show_bug.cgi?id=194901
3059
3060         Unreviewed build fix.
3061
3062         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3063         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3064         WPEBackend-fdo-0.1 as library name.
3065
3066 2019-02-21  Rob Buis  <rbuis@igalia.com>
3067
3068         Update MIME type parser
3069         https://bugs.webkit.org/show_bug.cgi?id=180526
3070
3071         Reviewed by Darin Adler.
3072
3073         Add tests involving leading and trailing whitespace, non-token
3074         characters and quoted strings.
3075
3076         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3077         (TestWebKitAPI::TEST):
3078
3079 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3080
3081         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3082         https://bugs.webkit.org/show_bug.cgi?id=194884
3083
3084         Reviewed by Michael Catanzaro.
3085
3086         * PlatformWin.cmake:
3087
3088 2019-02-20  Chris Dumez  <cdumez@apple.com>
3089
3090         Add API test for <rdar://problem/47471222>
3091         https://bugs.webkit.org/show_bug.cgi?id=194847
3092
3093         Reviewed by Alex Christensen.
3094
3095         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3096
3097 2019-02-20  Chris Dumez  <cdumez@apple.com>
3098
3099         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3100         https://bugs.webkit.org/show_bug.cgi?id=194872
3101         <rdar://problem/47924500>
3102
3103         Reviewed by Alex Christensen.
3104
3105         Add API test coverage.
3106
3107         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3108
3109 2019-02-20  Jer Noble  <jer.noble@apple.com>
3110
3111         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3112         https://bugs.webkit.org/show_bug.cgi?id=191332
3113
3114         Reviewed by Dean Jackson.
3115
3116         * Scripts/git-is-in-range: Added.
3117
3118 2019-02-20  Andy Estes  <aestes@apple.com>
3119
3120         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3121         https://bugs.webkit.org/show_bug.cgi?id=194869
3122
3123         Rubber-stamped by Jer Noble.
3124
3125         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3126         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3127         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3128         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3130         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3131
3132 2019-02-20  Chris Dumez  <cdumez@apple.com>
3133
3134         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3135         https://bugs.webkit.org/show_bug.cgi?id=194857
3136         <rdar://problem/47759323>
3137
3138         Reviewed by Alex Christensen.
3139
3140         Add API test coverage.
3141
3142         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3143
3144 2019-02-20  Chris Dumez  <cdumez@apple.com>
3145
3146         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3147         https://bugs.webkit.org/show_bug.cgi?id=194829
3148         <rdar://problem/47889906>
3149
3150         Reviewed by Alexey Proskuryakov.
3151
3152         Every time the TestOptions were changing we were creating both a new Web view and
3153         a new WKContext, which would start a new Network process. In most cases, we only
3154         need to contruct a new Web view and we do can keep reusing the same WKContext.
3155         This patch implements this optimization and thus avoids spinning a lot of new
3156         Network processes while running the layout tests.
3157
3158         * WebKitTestRunner/TestController.cpp:
3159         (WTR::TestController::generateContextConfiguration const):
3160         (WTR::TestController::generatePageConfiguration):
3161         (WTR::TestController::createWebViewWithOptions):
3162         (WTR::TestController::resetPreferencesToConsistentValues):
3163         (WTR::updateTestOptionsFromTestHeader):
3164         * WebKitTestRunner/TestController.h:
3165         * WebKitTestRunner/TestOptions.h:
3166         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3167         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3168         (WTR::TestOptions::hasSameInitializationOptions const):
3169         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3170         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3171         (WTR::TestController::platformAddTestOptions const):
3172
3173 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3174
3175         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3176         https://bugs.webkit.org/show_bug.cgi?id=167941
3177
3178         Reviewed by Carlos Garcia Campos.
3179
3180         * MiniBrowser/gtk/main.c:
3181         (filterSavedCallback): Added.
3182         (main): Support loading a JSON rule set file for content filtering.
3183         * MiniBrowser/wpe/main.cpp:
3184         (filterSavedCallback): Added.
3185         (main): Support loading a JSON rule set file for content filtering.
3186         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3187         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3188         (WTF::derefGPtr): Ditto.
3189         (testEmptyStore):
3190         (testSaveInvalidFilter):
3191         (testSaveLoadFilter):
3192         (testSavedFilterIdentifierMatch):
3193         (testRemoveFilter):
3194         (testSaveMultipleFilters):
3195         (testSaveFilterFromFile):
3196         (testFilterPersistence):
3197         (beforeAll):
3198         (afterAll):
3199         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3200         (removeOldInjectedContentAndResetLists): Also reset content filters.
3201         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3202         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3203         the element affected by the style sheet.
3204         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3205         and returns it to be used by tests.
3206         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3207         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3208         (serverCallback): Add support for serving a CSS style sheet for testing.
3209         (beforeAll): Add call to testUserContentManagerContentFilter().
3210         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3211
3212 2019-02-19  Keith Rollin  <krollin@apple.com>
3213
3214         Add timing information to build output
3215         https://bugs.webkit.org/show_bug.cgi?id=194839
3216         <rdar://problem/48219609>
3217
3218         Reviewed by Alexey Proskuryakov.
3219
3220         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3221         emit each project's build time to its output. E.g.,
3222
3223             ** BUILD SUCCEEDED ** [0.132 sec]
3224
3225         * Scripts/webkitdirs.pm:
3226         (XcodeOptions):
3227
3228 2019-02-19  Truitt Savell  <tsavell@apple.com>
3229
3230         Unreviewed, rolling out r241784.
3231
3232         Broke all OpenSource builds.
3233
3234         Reverted changeset:
3235
3236         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3237         instances view"
3238         https://bugs.webkit.org/show_bug.cgi?id=172848
3239         https://trac.webkit.org/changeset/241784
3240
3241 2019-02-19  Zalan Bujtas  <zalan@apple.com>
3242
3243         [LFC][Floats] Remove redundant intersecting logic
3244         https://bugs.webkit.org/show_bug.cgi?id=194804
3245
3246         Reviewed by Antti Koivisto.
3247
3248         * LayoutReloaded/misc/LFC-passing-tests.txt:
3249
3250 2019-02-19  Dean Jackson  <dino@apple.com>
3251
3252         Clean-up output from generate-xcfilelists so it can be filtered
3253         https://bugs.webkit.org/show_bug.cgi?id=194795
3254
3255         Reviewed by Joseph Pecoraro (and Keith Rollin).
3256
3257         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
3258         make a slight tweak to filter-build-webkit so such lines are marked
3259         as plain.
3260
3261         * Scripts/filter-build-webkit:
3262         * Scripts/generate-xcfilelists:
3263
3264 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3265
3266         pytest is not correctly auto-installed
3267         https://bugs.webkit.org/show_bug.cgi?id=194707
3268
3269         Reviewed by Carlos Garcia Campos.
3270
3271         * Scripts/webkitpy/thirdparty/__init__.py:
3272         (AutoinstallImportHook._install_pytest):
3273
3274 2019-02-18  Chris Dumez  <cdumez@apple.com>
3275
3276         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
3277         https://bugs.webkit.org/show_bug.cgi?id=194797
3278         <rdar://problem/48055151>
3279
3280         Reviewed by Geoffrey Garen.
3281
3282         Add API test coverage.
3283
3284         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3285
3286 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3287
3288         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
3289         https://bugs.webkit.org/show_bug.cgi?id=194670
3290         <rdar://problem/39066529>
3291
3292         Reviewed by Tim Horton.
3293
3294         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
3295         pasted in an editable area as attachment elements.
3296
3297         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3298         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3299         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
3300         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3301         (TestWebKitAPI::TEST):
3302         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3303         (WTR::InjectedBundlePage::InjectedBundlePage):
3304
3305 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3306
3307         Fix API test after r241728
3308        ​https://bugs.webkit.org/show_bug.cgi?id=194723
3309
3310         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3311         (TEST):
3312         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
3313
3314 2019-02-18  Daniel Bates  <dabates@apple.com>
3315
3316         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3317         https://bugs.webkit.org/show_bug.cgi?id=192824
3318         <rdar://problem/47100332>
3319
3320         Reviewed by Wenson Hsieh.
3321
3322         Fix a bug where the wrong usage code was used for F13 thru F24.
3323
3324         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3325         (keyCodeForDOMFunctionKey):
3326
3327 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
3328
3329         Bytecode cache should a have a boot-specific validation
3330         https://bugs.webkit.org/show_bug.cgi?id=194769
3331         <rdar://problem/48149509>
3332
3333         Reviewed by Keith Miller.
3334
3335         Add test for WTF::bootSessionUUIDString()
3336
3337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3338         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
3339         (TEST):
3340
3341 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3342
3343         Disable safe browsing in WKWebView and remove its WKPreferences API
3344         https://bugs.webkit.org/show_bug.cgi?id=194723
3345         <rdar://problem/48122993>
3346
3347         Reviewed by Geoffrey Garen.
3348
3349         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3350         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3351         (TEST):
3352         (safeBrowsingView):
3353         Make tests use SPI instead of API.
3354
3355 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3356
3357         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
3358         https://bugs.webkit.org/show_bug.cgi?id=194586
3359
3360         Reviewed by Ross Kirsling.
3361
3362         * DumpRenderTree/win/DumpRenderTree.cpp:
3363         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
3364         * Scripts/webkitpy/port/driver.py:
3365         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
3366
3367 2019-02-17  David Kilzer  <ddkilzer@apple.com>
3368
3369         Unreviewed, rolling out r241620.
3370
3371         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
3372         (Requested by ddkilzer on #webkit.)
3373
3374         Reverted changeset:
3375
3376         "[WTF] Add environment variable helpers"
3377         https://bugs.webkit.org/show_bug.cgi?id=192405
3378         https://trac.webkit.org/changeset/241620
3379
3380 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3381
3382         [LFC] RenderImage's default intrinsic size is 0.
3383         https://bugs.webkit.org/show_bug.cgi?id=194745
3384
3385         Reviewed by Antti Koivisto.
3386
3387         * LayoutReloaded/misc/LFC-passing-tests.txt:
3388
3389 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3390
3391         [LFC][BFC] Add support for block replaced intrinsic width.
3392         https://bugs.webkit.org/show_bug.cgi?id=194705
3393
3394         Reviewed by Simon Fraser.
3395
3396         * LayoutReloaded/misc/LFC-passing-tests.txt:
3397
3398 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3399
3400         [LFC] Apply min/max width constraints to preferred width computation
3401         https://bugs.webkit.org/show_bug.cgi?id=194739
3402
3403         Reviewed by Simon Fraser.
3404
3405         * LayoutReloaded/misc/LFC-passing-tests.txt:
3406
3407 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
3408
3409         [WTF] Add environment variable helpers
3410         https://bugs.webkit.org/show_bug.cgi?id=192405
3411
3412         Reviewed by Michael Catanzaro.
3413
3414         * DumpRenderTree/mac/DumpRenderTree.mm:
3415         (libraryPathForDumpRenderTree):
3416         * DumpRenderTree/win/DumpRenderTree.cpp:
3417         (libraryPathForDumpRenderTree):
3418         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3419         (setUpIOSLayoutTestCommunication):
3420         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3421         (beforeAll):
3422         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3423         (main):
3424         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3425         (WebKitTestBus::run):
3426         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3427         (WTR::getOutputDir):
3428         (WTR::initializeFontConfigSetting):
3429         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3430         (WTR::InjectedBundle::platformInitialize):
3431         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3432         (WTR::topLevelPath):
3433         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3434         (WTR::topLevelPath):
3435         (WTR::getOutputDir):
3436         (WTR::activateFonts):
3437         * WebKitTestRunner/TestController.cpp:
3438         (WTR::TestController::libraryPathForTesting):
3439         (WTR::TestController::generateContextConfiguration const):
3440         (WTR::TestController::generatePageConfiguration):
3441         (WTR::TestController::decideDestinationWithSuggestedFilename):
3442         (WTR::TestController::platformAdjustContext):
3443         * WebKitTestRunner/TestController.h:
3444         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3445         (WTR::TestController::cocoaPlatformInitialize):
3446         (WTR::TestController::platformAdjustContext):
3447         * WebKitTestRunner/gtk/main.cpp:
3448         (main):
3449         * WebKitTestRunner/mac/TestControllerMac.mm:
3450         (WTR::TestController::configureContentExtensionForTest):
3451         * WebKitTestRunner/wpe/main.cpp:
3452         (main):
3453         Utilize WTF::Environment where possible.
3454
3455 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3456
3457         [iOS] WKWebView callout bar is missing Change Writing Direction item
3458         https://bugs.webkit.org/show_bug.cgi?id=190015
3459         <rdar://problem/44810366>
3460
3461         Reviewed by Tim Horton.
3462
3463         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
3464         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
3465
3466         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
3467         (TestWebKitAPI::TEST):
3468
3469 2019-02-15  Chris Dumez  <cdumez@apple.com>
3470
3471         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
3472         https://bugs.webkit.org/show_bug.cgi?id=194717
3473         <rdar://problem/47884404>
3474
3475         Reviewed by Brady Eidson.
3476
3477         Add API test coverage.
3478
3479         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3480
3481 2019-02-15  Youenn Fablet  <youenn@apple.com>
3482
3483         Make navigator.mediaDevices SecureContext
3484         https://bugs.webkit.org/show_bug.cgi?id=194666
3485
3486         Reviewed by Eric Carlson.
3487
3488         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3489         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
3490         (TEST_F):
3491
3492 2019-02-15  Brian Burg  <bburg@apple.com>
3493
3494         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3495         https://bugs.webkit.org/show_bug.cgi?id=194411
3496         <rdar://problem/47787614>
3497
3498         Reviewed by Joseph Pecoraro.
3499
3500         Remove unnecessary soft linking macro usage.
3501
3502         * DumpRenderTree/mac/TestRunnerMac.mm:
3503         (TestRunner::inspectorTestStubURL):
3504         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3505         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3506         (WTR::TestRunner::inspectorTestStubURL):
3507
3508 2019-02-15  Commit Queue  <commit-queue@webkit.org>
3509
3510         Unreviewed, rolling out r241559 and r241566.
3511         https://bugs.webkit.org/show_bug.cgi?id=194710
3512
3513         Causes layout test crashes under GuardMalloc (Requested by
3514         ryanhaddad on #webkit).
3515
3516         Reverted changesets:
3517
3518         "[WTF] Add environment variable helpers"
3519         https://bugs.webkit.org/show_bug.cgi?id=192405
3520         https://trac.webkit.org/changeset/241559
3521
3522         "Unreviewed build fix for WinCairo Debug after r241559."
3523         https://trac.webkit.org/changeset/241566
3524
3525 2019-02-15  Zalan Bujtas  <zalan@apple.com>
3526
3527         [LFC] Out-of-flow box is never a float box
3528         https://bugs.webkit.org/show_bug.cgi?id=194704
3529
3530         Reviewed by Antti Koivisto.
3531
3532         * LayoutReloaded/misc/LFC-passing-tests.txt:
3533
3534 2019-02-10  Darin Adler  <darin@apple.com>
3535
3536         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
3537         https://bugs.webkit.org/show_bug.cgi?id=194487
3538
3539         Reviewed by Daniel Bates.
3540
3541         * DumpRenderTree/win/DumpRenderTree.cpp:
3542         (applicationId): Use makeString instead of String::format.
3543         (main): Ditto.
3544         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3545         (TestWebKitAPI::Util::createURLForResource): Ditto.
3546         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3547         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
3548
3549         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3550         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
3551         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
3552         (WTR::createStringWithAttributes): Use appendLiteral.
3553         (WTR::AccessibilityUIElement::helpText const): Ditto.
3554         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
3555         directly instead of using String::format.
3556         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
3557         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
3558
3559 2019-02-15  Truitt Savell  <tsavell@apple.com>
3560
3561         Unreviewed, rolling out r241564.
3562
3563         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
3564
3565         Reverted changeset:
3566
3567         "[Mac] WebInspectorUI.framework does not need to be soft-
3568         linked anymore"
3569         https://bugs.webkit.org/show_bug.cgi?id=194411
3570         https://trac.webkit.org/changeset/241564
3571
3572 2019-02-15  Saam barati  <sbarati@apple.com>
3573
3574         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
3575         https://bugs.webkit.org/show_bug.cgi?id=194036
3576
3577         Reviewed by Yusuke Suzuki.
3578
3579         * Scripts/run-jsc-stress-tests:
3580
3581 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3582
3583         Fix the build.
3584
3585         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3586         (WTR::UIScriptController::drawSquareInEditableImage):
3587         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3588         (TestWebKitAPI::drawSquareInEditableImage):
3589
3590 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3591
3592         Fix the build.
3593
3594         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3595         (WTR::UIScriptController::drawSquareInEditableImage):
3596         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3597         (TestWebKitAPI::drawSquareInEditableImage):
3598
3599 2019-02-14  Brian Burg  <bburg@apple.com>
3600
3601         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3602         https://bugs.webkit.org/show_bug.cgi?id=194411
3603         <rdar://problem/47787614>
3604
3605         Reviewed by Joseph Pecoraro.
3606
3607         Remove unnecessary soft linking macro usage.
3608
3609         * DumpRenderTree/mac/TestRunnerMac.mm:
3610         (TestRunner::inspectorTestStubURL):
3611         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3612         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3613         (WTR::TestRunner::inspectorTestStubURL):
3614
3615 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3616
3617         [ews-app] status bubble should fetch builder name info from BuilderMapping table
3618         https://bugs.webkit.org/show_bug.cgi?id=194599
3619
3620         Reviewed by Lucas Forschler.
3621
3622         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3623         (StatusBubble._build_bubble):
3624
3625 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3626
3627         [ews-app] Set Foreign Key in Django build model
3628         https://bugs.webkit.org/show_bug.cgi?id=194667
3629
3630         Reviewed by Lucas Forschler.
3631
3632         * BuildSlaveSupport/ews-app/ews/models/build.py:
3633         (Build):
3634
3635 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
3636
3637         [WTF] Add environment variable helpers
3638         https://bugs.webkit.org/show_bug.cgi?id=192405
3639
3640         Reviewed by Michael Catanzaro.
3641
3642         * DumpRenderTree/mac/DumpRenderTree.mm:
3643         (libraryPathForDumpRenderTree):
3644         * DumpRenderTree/win/DumpRenderTree.cpp:
3645         (libraryPathForDumpRenderTree):
3646         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3647         (setUpIOSLayoutTestCommunication):
3648         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3649         (TestWebKitAPI::strip):
3650         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3651         (beforeAll):
3652         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3653         (main):
3654         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3655         (WebKitTestBus::run):
3656         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3657         (WTR::getOutputDir):
3658         (WTR::initializeFontConfigSetting):
3659         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3660         (WTR::InjectedBundle::platformInitialize):
3661         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3662         (WTR::topLevelPath):
3663         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3664         (WTR::topLevelPath):
3665         (WTR::getOutputDir):
3666         (WTR::activateFonts):
3667         * WebKitTestRunner/TestController.cpp:
3668         (WTR::TestController::libraryPathForTesting):
3669         (WTR::TestController::generateContextConfiguration const):
3670         (WTR::TestController::generatePageConfiguration):
3671         (WTR::TestController::decideDestinationWithSuggestedFilename):
3672         (WTR::TestController::platformAdjustContext):
3673         * WebKitTestRunner/TestController.h:
3674         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3675         (WTR::TestController::cocoaPlatformInitialize):
3676         (WTR::TestController::platformAdjustContext):
3677         * WebKitTestRunner/gtk/main.cpp:
3678         (main):
3679         * WebKitTestRunner/mac/TestControllerMac.mm:
3680         (WTR::TestController::configureContentExtensionForTest):
3681         * WebKitTestRunner/wpe/main.cpp:
3682         (main):
3683         Utilize WTF::Environment where possible.
3684
3685 2019-02-14  Chris Dumez  <cdumez@apple.com>
3686
3687         [PSON] Introduce a WebContent Process cache
3688         https://bugs.webkit.org/show_bug.cgi?id=194594
3689         <rdar://problem/46793397>
3690
3691         Reviewed by Geoff Garen.
3692
3693         Update API tests to turn on the WebContent Process cache.
3694
3695         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3696
3697 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
3698
3699         Unreviewed, build fix after r241480
3700
3701         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3702         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3703         (-[DragAndDropSimulator initWithWebView:]):
3704
3705 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
3706
3707         AX: ARIA Reflection was disabled in error
3708         https://bugs.webkit.org/show_bug.cgi?id=194647
3709         <rdar://problem/48068336>
3710
3711         Reviewed by Ryosuke Niwa.
3712
3713         Remove test override now that this feature should be enabled by default.
3714
3715         * WebKitTestRunner/TestController.cpp:
3716         (WTR::TestController::resetPreferencesToConsistentValues):
3717
3718 2019-02-14  Commit Queue  <commit-queue@webkit.org>
3719
3720         Unreviewed, rolling out r241486.
3721         https://bugs.webkit.org/show_bug.cgi?id=194655
3722
3723         causing API failures in builds (Requested by ShawnRoberts on
3724         #webkit).
3725
3726         Reverted changeset:
3727
3728         "[Cocoa] Media elements will restart network buffering just
3729         before suspending"
3730         https://bugs.webkit.org/show_bug.cgi?id=193691
3731         https://trac.webkit.org/changeset/241486
3732
3733 2019-02-14  Zalan Bujtas  <zalan@apple.com>
3734
3735         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
3736         https://bugs.webkit.org/show_bug.cgi?id=194622
3737
3738         Reviewed by Antti Koivisto.
3739
3740         * LayoutReloaded/misc/LFC-passing-tests.txt:
3741
3742 2019-02-14  Zalan Bujtas  <zalan@apple.com>
3743
3744         [LFC] Shrink-to-fit-width should be constrained by min/max width
3745         https://bugs.webkit.org/show_bug.cgi?id=194653
3746
3747         Reviewed by Antti Koivisto.
3748
3749         * LayoutReloaded/misc/LFC-passing-tests.txt:
3750
3751 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
3752
3753         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
3754         https://bugs.webkit.org/show_bug.cgi?id=194641
3755
3756         Reviewed by Geoffrey Garen.
3757
3758         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
3759         so that the test would fail without this fix.
3760
3761         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
3762         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
3763
3764 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3765
3766         [ews-app] Change log level for a log statement
3767
3768         Unreviewed minor fix.
3769
3770         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3771         (Patch.save_patch):
3772
3773 2019-02-13  Jer Noble  <jer.noble@apple.com>
3774
3775         [Cocoa] Media elements will restart network buffering just before suspending
3776         https://bugs.webkit.org/show_bug.cgi?id=193691
3777
3778         Reviewed by Eric Carlson.
3779
3780         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3781         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3782         (TEST):
3783
3784 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3785
3786         [ews-app] Fetch builder id to name mapping
3787         https://bugs.webkit.org/show_bug.cgi?id=194355
3788
3789         Reviewed by Lucas Forschler.
3790
3791         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3792         (Buildbot.get_builder_id_to_name_mapping):
3793         (Buildbot._get_display_name_from_builder_name):
3794
3795 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
3796
3797         Further restricting webarchive loads
3798         https://bugs.webkit.org/show_bug.cgi?id=194567
3799         <rdar://problem/47610130>
3800
3801         Reviewed by Youenn Fablet.
3802
3803         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
3804         navigations on drop.
3805
3806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3807         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
3808         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
3809         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3810         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3811         (TestWebKitAPI::TEST):
3812         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
3813         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
3814         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
3815         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3816         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3817         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3818         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
3819
3820 2019-02-13  John Wilander  <wilander@apple.com>
3821
3822         Store Ad Click Attribution requests in the network process
3823         https://bugs.webkit.org/show_bug.cgi?id=194510
3824         <rdar://problem/47650118>
3825
3826         Reviewed by Alex Christensen and Daniel Bates.
3827
3828         This patch adds two TestRunner functions:
3829         - dumpAdClickAttribution()
3830         - clearAdClickAttribution()
3831
3832         They call into the network process to dump and clear Ad Click
3833         Attribution state, respectively.
3834
3835         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3836         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3837         (WTR::TestRunner::dumpAdClickAttribution):
3838         (WTR::TestRunner::clearAdClickAttribution):
3839         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3840         * WebKitTestRunner/TestController.cpp:
3841         (WTR::TestController::resetStateToConsistentValues):
3842         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
3843         (WTR::adClickAttributionStringResultCallback):
3844         (WTR::TestController::dumpAdClickAttribution):
3845         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
3846         (WTR::adClickAttributionVoidCallback):
3847         (WTR::TestController::clearAdClickAttribution):
3848         * WebKitTestRunner/TestController.h:
3849         * WebKitTestRunner/TestInvocation.cpp:
3850         (WTR::TestInvocation::dumpResults):
3851         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3852         (WTR::TestInvocation::dumpAdClickAttribution):
3853         * WebKitTestRunner/TestInvocation.h:
3854
3855 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3856
3857         [ews-app] Generate status-bubble
3858         https://bugs.webkit.org/show_bug.cgi?id=194572
3859
3860         Reviewed by Lucas Forschler.
3861
3862         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3863         (StatusBubble._build_bubble):
3864         (StatusBubble._should_show_bubble_for):
3865         (StatusBubble._build_bubbles_for_patch):
3866
3867 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3868
3869         [ews-app] Add status bubble html template
3870         https://bugs.webkit.org/show_bug.cgi?id=194571
3871
3872         Reviewed by Lucas Forschler.
3873
3874         * BuildSlaveSupport/ews-app/ews/templates: Added.
3875         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
3876
3877 2019-02-12  Chris Dumez  <cdumez@apple.com>
3878
3879         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
3880         https://bugs.webkit.org/show_bug.cgi?id=194568
3881         <rdar://problem/47944490>
3882
3883         Reviewed by Ryosuke Niwa.
3884
3885         Add API test coverage.
3886
3887         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3888         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3889
3890 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
3891
3892         webkitpy: Remove bug_dummy from parsed test expectations
3893         https://bugs.webkit.org/show_bug.cgi?id=194562
3894         <rdar://problem/47853999>
3895
3896         Reviewed by Lucas Forschler.
3897
3898         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3899         (TestExpectationParser):
3900         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
3901         skipped tests.
3902         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3903
3904 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
3905
3906         [ews-app] Add method to fetch patch
3907         https://bugs.webkit.org/show_bug.cgi?id=194518
3908
3909         Reviewed by Lucas Forschler.
3910
3911         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3912         (Patch.get_patch):
3913
3914 2019-02-12  Zalan Bujtas  <zalan@apple.com>
3915
3916         [LFC] Expand tests coverage (60 new tests -> 860)
3917
3918         Unreviewed test gardening (run-singly, --child-processes=1).
3919
3920         * LayoutReloaded/misc/LFC-passing-tests.txt:
3921
3922 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3923
3924         Allow pages to trigger programmatic paste from script on iOS
3925         https://bugs.webkit.org/show_bug.cgi?id=194271
3926         <rdar://problem/47808810>
3927
3928         Reviewed by Tim Horton.
3929
3930         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
3931
3932         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3933         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3934         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3935         (WTR::UIScriptController::rectForMenuAction const):
3936
3937         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
3938         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
3939         for when the menu is shown or hidden.
3940
3941         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3942         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3943         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3944         (WTR::UIScriptController::setDidShowMenuCallback):
3945         (WTR::UIScriptController::didShowMenuCallback const):
3946         (WTR::UIScriptController::setDidHideMenuCallback):
3947         (WTR::UIScriptController::didHideMenuCallback const):
3948         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3949         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3950         (WTR::UIScriptController::rectForMenuAction const):
3951         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3952         * WebKitTestRunner/TestController.cpp:
3953         (WTR::TestController::resetPreferencesToConsistentValues):
3954         (WTR::updateTestOptionsFromTestHeader):
3955         * WebKitTestRunner/TestOptions.h:
3956
3957         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
3958         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
3959
3960         (WTR::TestOptions::hasSameInitializationOptions const):
3961         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3962         (WTR::UIScriptController::calendarType const):
3963         (WTR::UIScriptController::platformUndoManager const):
3964         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3965         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3966         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3967         (-[TestRunnerWKWebView dealloc]):
3968         (-[TestRunnerWKWebView _didShowMenu]):
3969         (-[TestRunnerWKWebView _didHideMenu]):
3970
3971         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
3972
3973         * WebKitTestRunner/ios/TestControllerIOS.mm:
3974         (WTR::handleMenuWillHideNotification):
3975         (WTR::handleMenuDidHideNotification):
3976         (WTR::TestController::platformInitialize):
3977         (WTR::TestController::platformDestroy):
3978         (WTR::TestController::platformResetStateToConsistentValues):
3979
3980         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
3981         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
3982
3983         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3984         (WTR::forEachViewInHierarchy):
3985         (WTR::findViewInHierarchyOfType):
3986
3987         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
3988         functions that dig through a given view's hierarchy in search of a view of a given class.
3989
3990         (WTR::UIScriptController::selectionStartGrabberViewRect const):
3991         (WTR::UIScriptController::selectionEndGrabberViewRect const):
3992         (WTR::UIScriptController::selectionCaretViewRect const):
3993         (WTR::UIScriptController::selectionRangeViewRects const):
3994         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3995         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3996
3997         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
3998
3999         (WTR::UIScriptController::rectForMenuAction const):
4000
4001         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
4002         callout bar) whose label matches the given string.
4003
4004         (WTR::UIScriptController::platformContentView const):
4005
4006         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
4007         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
4008         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
4009
4010         (WTR::UIScriptController::platformUndoManager const): Deleted.
4011         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4012         (WTR::UIScriptController::platformContentView const):
4013         (WTR::UIScriptController::platformUndoManager const): Deleted.
4014
4015 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
4016
4017         webkitpy: No option to only show unexpected failures in results.html for iPad
4018         https://bugs.webkit.org/show_bug.cgi?id=194554
4019         <rdar://problem/47922442>
4020
4021         Rubber-stamped by Aakash Jain.
4022
4023         Just because a TestExpecations file does not exist for a specific platform does not mean that
4024         TestExpecations are not being used, given that platforms inherit test expectations.
4025
4026         * Scripts/webkitpy/port/base.py:
4027         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
4028         * Scripts/webkitpy/port/base_unittest.py:
4029         (PortTest.test_uses_test_expectations_file):
4030
4031 2019-02-12  Alex Christensen  <achristensen@webkit.org>
4032
4033         Remove setDefersLoading infrastructure from WebKit2
4034         https://bugs.webkit.org/show_bug.cgi?id=194506
4035
4036         Reviewed by Brady Eidson.
4037
4038         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4039         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4040         (WTR::TestRunner::setDefersLoading): Deleted.
4041         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4042
4043 2019-02-12  Alex Christensen  <achristensen@webkit.org>
4044
4045         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
4046         https://bugs.webkit.org/show_bug.cgi?id=194522
4047         <rdar://problem/47789393>
4048
4049         Reviewed by Chris Dumez.
4050
4051         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4052         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
4053         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4054         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4055
4056 2019-02-12  Andy Estes  <aestes@apple.com>
4057
4058         [iOSMac] Enable Parental Controls Content Filtering
4059         https://bugs.webkit.org/show_bug.cgi?id=194521
4060         <rdar://39732376>
4061
4062         Reviewed by Tim Horton.
4063
4064         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4065
4066 2019-02-12  Zalan Bujtas  <zalan@apple.com>
4067
4068         [LFC][IFC] Add intrinsic width support for float boxes.
4069         https://bugs.webkit.org/show_bug.cgi?id=194528
4070
4071         Reviewed by Antti Koivisto.
4072
4073         Expand tests coverage (2 new tests -> 800).
4074         (This is the correct test ordering --runs-singly --child-processes=1)
4075
4076         * LayoutReloaded/misc/LFC-passing-tests.txt:
4077
4078 2019-02-12  Rob Buis  <rbuis@igalia.com>
4079
4080         Implement serializing in MIME type parser
4081         https://bugs.webkit.org/show_bug.cgi?id=193909
4082
4083         Reviewed by Darin Adler.
4084
4085         Add various tests involving upper case, non-ASCII, control/null characters,
4086         various HTTP whitespace, single quotes and an unpaired surrogate.
4087
4088         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4089         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
4090         (TestWebKitAPI::serializeIfValid):
4091         (TestWebKitAPI::TEST):
4092
4093 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
4094
4095         [Cocoa] Ask platform for generic font family mappings
4096         https://bugs.webkit.org/show_bug.cgi?id=187723
4097         <rdar://problem/41892438>
4098
4099         Reviewed by Brent Fulgham.
4100
4101         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
4102
4103         * DumpRenderTree/mac/DumpRenderTree.mm:
4104         (allowedFontFamilySet):
4105         * WebKitTestRunner/mac/TestControllerMac.mm:
4106         (WTR::allowedFontFamilySet):
4107
4108 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
4109
4110         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
4111         https://bugs.webkit.org/show_bug.cgi?id=193622
4112
4113         Reviewed by Michael Catanzaro.
4114
4115         This adds support for loading content extension rule sets from the JSON files which
4116         accompany the corresponding layout test, using the C API. The Cocoa specific parts
4117         of WKTR for this could be removed, but that is left for a follow-up patch with
4118         cleanups.
4119
4120         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
4121         * WebKitTestRunner/TestController.cpp:
4122         (WTR::testPath): Subtract one from the length when constructing the result std::string to
4123         avoid having the null-terminator copied into the result.
4124         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
4125         part of the preparations to run a test.
4126         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
4127         (WTR::contentExtensionStoreCallback): Added.
4128         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
4129         used for content extensions test.
4130         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
4131         extensions and compiling the JSON rule set for tests involving content extensions.
4132         (WTR::TestController::resetContentExtensions): Removes the content extension built for
4133         testing and disables content extensions.
4134         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
4135         resetContentExtensions().
4136         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
4137         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
4138         configureContentExtensionForTest(), and userContentController().
4139
4140 2019-02-11  Daniel Bates  <dabates@apple.com>
4141
4142         [iOS] Mouse/Touch/Pointer events are missing modifier keys
4143         https://bugs.webkit.org/show_bug.cgi?id=191446
4144         <rdar://problem/45929460>
4145
4146         Reviewed by Tim Horton.
4147
4148         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
4149
4150         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4151         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4152         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4153         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4154         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4155         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4156         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4157         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4158         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4159         (WTR::arrayLength):
4160         (WTR::parseModifierArray):
4161         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
4162         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4163         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
4164         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4165
4166 2019-02-11  Commit Queue  <commit-queue@webkit.org>
4167
4168         Unreviewed, rolling out r241272 and r241276.
4169         https://bugs.webkit.org/show_bug.cgi?id=194514
4170
4171         Broke the Apple Internal build and the fix requires human
4172         intervention :( (Requested by dydz on #webkit).
4173
4174         Reverted changesets:
4175
4176         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
4177         https://bugs.webkit.org/show_bug.cgi?id=191446
4178         https://trac.webkit.org/changeset/241272
4179
4180         "Fix internal iOS build after r241272"
4181         https://bugs.webkit.org/show_bug.cgi?id=191446
4182         https://trac.webkit.org/changeset/241276
4183
4184 2019-02-11  Truitt Savell  <tsavell@apple.com>
4185
4186         Unreviewed, rolling out r241269.
4187
4188         Caused 5 layout tests crashes on Mac WK1
4189
4190         Reverted changeset:
4191
4192         "DumpRenderTree should report unknown options"
4193         https://bugs.webkit.org/show_bug.cgi?id=191303
4194         https://trac.webkit.org/changeset/241269
4195
4196 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4197
4198         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
4199         https://bugs.webkit.org/show_bug.cgi?id=194313
4200
4201         Reviewed by Tim Horton.
4202
4203         Add a helper to determine whether the web view is presenting modal UI.
4204
4205         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4206         (WTR::UIScriptController::isPresentingModally const):
4207         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4208         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4209         (WTR::UIScriptController::isPresentingModally const):
4210         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4211         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4212         (WTR::UIScriptController::calendarType const): Deleted.
4213         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4214         (WTR::UIScriptController::isPresentingModally const):
4215         (WTR::UIScriptController::calendarType const):
4216         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4217         (WTR::UIScriptController::calendarType const):
4218
4219 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
4220
4221         GCHeapInspector: Show the retained sizes in more places
4222         https://bugs.webkit.org/show_bug.cgi?id=194464
4223
4224         Reviewed by Simon Fraser.
4225
4226         * GCHeapInspector/gc-heap-inspector.html:
4227         * GCHeapInspector/script/interface.js:
4228         (HeapInspectorUtils.humanReadableSize):
4229         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
4230         (HeapInspectorUtils.spanForNode.span.span):
4231         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
4232         (HeapSnapshotInspector.prototype.buildRoots):
4233
4234 2019-02-11  Daniel Bates  <dabates@apple.com>
4235
4236         [iOS] Mouse/Touch/Pointer events are missing modifier keys
4237         https://bugs.webkit.org/show_bug.cgi?id=191446
4238         <rdar://problem/45929460>
4239
4240         Reviewed by Tim Horton.
4241
4242         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
4243
4244         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4245         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4246         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4247         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4248         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4249         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4250         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4251         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4252         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4253         (WTR::arrayLength):
4254         (WTR::parseModifierArray):
4255         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
4256         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4257         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
4258         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4259
4260 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
4261
4262         DumpRenderTree should report unknown options
4263         https://bugs.webkit.org/show_bug.cgi?id=191303
4264
4265         Reviewed by Frédéric Wang.
4266
4267         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
4268         to report unknown options.
4269         Added and assigned test options which are currently used in tests.
4270
4271         * DumpRenderTree/TestOptions.cpp:
4272         (TestOptions::TestOptions):
4273
4274 2019-02-11  Truitt Savell  <tsavell@apple.com>
4275
4276         Unreviewed, rolling out r241229.
4277
4278         Revision broke internal builds for watchOS.
4279
4280         Reverted changeset:
4281
4282         "[Cocoa] Ask platform for generic font family mappings"
4283         https://bugs.webkit.org/show_bug.cgi?id=187723
4284         https://trac.webkit.org/changeset/241229
4285
4286 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
4287
4288         [WinCairo][MiniBrowser] Basic authentication always fails.
4289         https://bugs.webkit.org/show_bug.cgi?id=194496
4290
4291         Reviewed by Don Olmstead.
4292
4293         * MiniBrowser/win/DialogHelper.h:
4294         (Dialog::getText):
4295
4296 2019-02-11  Philippe Normand  <pnormand@igalia.com>
4297
4298         [GStreamer] GstMappedBuffer testsuite build fails
4299         https://bugs.webkit.org/show_bug.cgi?id=194495
4300
4301         Reviewed by Carlos Garcia Campos.
4302
4303         Fix the build by explicitely adding the gstreamer1.0-audio include
4304         directories to the include path.
4305
4306         * TestWebKitAPI/PlatformGTK.cmake:
4307         * TestWebKitAPI/PlatformWPE.cmake:
4308
4309 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4310
4311         [GTK][WPE] Add enable-javascript-markup setting
4312         https://bugs.webkit.org/show_bug.cgi?id=193439
4313
4314         Reviewed by Michael Catanzaro.
4315
4316         Add test cases to check the new setting.
4317
4318         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
4319         (testWebKitSettings):
4320         (testWebKitSettingsJavaScriptMarkup):
4321         (beforeAll):
4322
4323 2019-02-10  Darin Adler  <darin@apple.com>
4324
4325         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
4326         https://bugs.webkit.org/show_bug.cgi?id=194485
4327
4328         Reviewed by Daniel Bates.
4329
4330         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
4331
4332 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
4333
4334         Add more tests for clampTo<>()
4335         https://bugs.webkit.org/show_bug.cgi?id=194462
4336
4337         Reviewed by Geoffrey Garen.
4338
4339         Darin suggested to test the very last floating point number
4340         at the boundaries when truncating to integer.
4341         I added test for max/min and max-1/min-1.
4342
4343         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
4344         (TestWebKitAPI::TEST):
4345
4346 2019-02-09  Darin Adler  <darin@apple.com>
4347
4348         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
4349         https://bugs.webkit.org/show_bug.cgi?id=194021
4350
4351         Reviewed by Geoffrey Garen.
4352
4353         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
4354         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
4355         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
4356
4357 2019-02-09  Zalan Bujtas  <zalan@apple.com>
4358
4359         [LFC][IFC] Add intrinsic width support for basic inline containers
4360         https://bugs.webkit.org/show_bug.cgi?id=194473
4361
4362         Reviewed by Antti Koivisto.
4363
4364         Expand tests coverage (11 new tests -> 798)
4365
4366         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
4367
4368 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
4369
4370         Fix MiniBrowser's entitlements
4371         https://bugs.webkit.org/show_bug.cgi?id=192431
4372
4373         Reviewed by Joseph Pecoraro.
4374
4375         MiniBrows