[ews-build] Handle bug titles with unicode characters
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Handle bug titles with unicode characters
4         https://bugs.webkit.org/show_bug.cgi?id=196802
5
6         Reviewed by Dewei Zhu.
7
8         * BuildSlaveSupport/ews-build/steps.py:
9         (ValidatePatch._is_bug_closed):
10
11 2019-04-11  Michael Saboff  <msaboff@apple.com>
12
13         Improve the Inline Cache Stats code
14         https://bugs.webkit.org/show_bug.cgi?id=196836
15
16         Reviewed by Saam Barati.
17
18         Added a new script to consolidate and arrange the output of --useICStats option.
19
20         This script merges the output from every group into one large table and sorts it from most common to
21         least common.  It also counts the slow path GetById and PutById variants and then calculates the
22         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
23         Put together, this is useful to see what property accesses are not getting cached.
24
25         * Scripts/ic-stats.py: Added.
26         (ICStats):
27         (ICStats.__init__):
28         (ICStats.parse):
29         (ICStats.dumpStats):
30         (usage):
31
32 2019-04-10  Alex Christensen  <achristensen@webkit.org>
33
34         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
35         https://bugs.webkit.org/show_bug.cgi?id=196809
36         <rdar://49800762>
37
38         Reviewed by Brady Eidson.
39
40         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
41         (TEST):
42
43 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
44
45         requestAnimationFrame should execute before the next frame
46         https://bugs.webkit.org/show_bug.cgi?id=177484
47
48         Reviewed by Simon Fraser.
49
50         Add trace points for the page RenderingUpdate.
51
52         * Tracing/SystemTracePoints.plist:
53
54 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
55
56         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
57         https://bugs.webkit.org/show_bug.cgi?id=196760
58
59         Reviewed by Don Olmstead.
60
61         vswhere.exe has been bundled since Visual Studio 2017 version
62         15.2. We shouldn't download vswhere.exe.
63
64         * Scripts/build-jsc: Do not call update-vswhere.py.
65         * Scripts/build-webkit: Ditto.
66         * Scripts/update-vswhere.py: Removed.
67         * Scripts/webkitdirs.pm:
68         (requireModulesForVSWhere): Deleted.
69         (pickCurrentVisualStudioInstallation): Deleted.
70         (visualStudioInstallDirVSWhere): Return the latest installed VS
71         installation path by using the bundled vswhere.exe.
72         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
73         (visualStudioInstallDirFallback): Removed.
74
75 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
76
77         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
78         https://bugs.webkit.org/show_bug.cgi?id=196780
79
80         Reviewed by Alexey Proskuryakov.
81
82         * BuildSlaveSupport/ews-build/steps.py:
83         * BuildSlaveSupport/ews-build/steps_unittest.py:
84
85 2019-04-10  Alex Christensen  <achristensen@webkit.org>
86
87         Add SPI WKNavigationResponse._downloadAttribute
88         https://bugs.webkit.org/show_bug.cgi?id=196755
89         <rdar://49587365>
90
91         Reviewed by Brady Eidson.
92
93         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
94         (-[NavigationResponseTestDelegate navigationResponse]):
95         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
96         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
97         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
98         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
99         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
100         (readRequest):
101         (writeResponse):
102         (TEST):
103
104 2019-04-10  Tim Horton  <timothy_horton@apple.com>
105
106         Add modern API for overriding the page's specified viewport configuration
107         https://bugs.webkit.org/show_bug.cgi?id=167734
108         <rdar://problem/30331795>
109
110         Reviewed by Simon Fraser.
111
112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
113         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
114
115 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
116
117         Add support for incremental bytecode cache updates
118         https://bugs.webkit.org/show_bug.cgi?id=195000
119
120         Reviewed by Filip Pizlo.
121
122         Exit when the initial run to generate bytecode fails.
123
124         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
125
126 2019-04-10  Alex Christensen  <achristensen@webkit.org>
127
128         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
129         https://bugs.webkit.org/show_bug.cgi?id=196744
130         <rdar://49415309>
131
132         Reviewed by Chris Dumez.
133
134         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
135         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
136
137 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
138
139         Add a way to opt into modern compatibility mode in layout tests
140         https://bugs.webkit.org/show_bug.cgi?id=196770
141         <rdar://problem/49777550>
142
143         Reviewed by Antoine Quint.
144
145         Add a new test option to enable modern compatibility mode in layout tests.
146
147         * WebKitTestRunner/TestController.cpp:
148         (WTR::updateTestOptionsFromTestHeader):
149         * WebKitTestRunner/TestController.h:
150         * WebKitTestRunner/TestOptions.h:
151         (WTR::TestOptions::hasSameInitializationOptions const):
152         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
153         (WTR::TestController::platformCreateWebView):
154         (WTR::TestController::enableModernCompatibilityMode):
155
156 2019-04-10  Andy Estes  <aestes@apple.com>
157
158         Try to fix the 32-bit watchOS build.
159
160         * TestWebKitAPI/cocoa/TestWKWebView.mm:
161         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
162
163 2019-04-10  Antoine Quint  <graouts@apple.com>
164
165         Enable Pointer Events on watchOS
166         https://bugs.webkit.org/show_bug.cgi?id=196771
167         <rdar://problem/49040909>
168
169         Reviewed by Dean Jackson.
170
171         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
172
173 2019-04-10  Philippe Normand  <pnormand@igalia.com>
174
175         Unreviewed. Fix WPE accessibility tests after r244059.
176
177         We are failing to load the injected bundle due to undefined symbol
178         AccessibilityUIElement::replaceTextInRange().
179
180         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
181         (WTR::AccessibilityUIElement::replaceTextInRange):
182
183 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
184
185         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
186         https://bugs.webkit.org/show_bug.cgi?id=196727
187
188         Reviewed by Fujii Hironori.
189
190         * MiniBrowser/win/WebKitBrowserWindow.cpp:
191         (WebKitBrowserWindow::create):
192
193 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
194
195         [ews-build] Add unit tests for PrintConfiguration
196         https://bugs.webkit.org/show_bug.cgi?id=196752
197
198         Reviewed by Dewei Zhu.
199
200         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
201
202 2019-04-09  Keith Rollin  <krollin@apple.com>
203
204         Unreviewed build maintenance -- update .xcfilelists.
205
206         * DumpRenderTree/DerivedSources-input.xcfilelist:
207         * DumpRenderTree/DerivedSources-output.xcfilelist:
208
209 2019-04-09  Zalan Bujtas  <zalan@apple.com>
210
211         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
212         https://bugs.webkit.org/show_bug.cgi?id=196743
213         <rdar://problem/43897551>
214
215         Reviewed by Tim Horton.
216
217         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
218         (TEST):
219
220 2019-04-09  Youenn Fablet  <youenn@apple.com>
221
222         Close service worker database on network process suspension
223         https://bugs.webkit.org/show_bug.cgi?id=196623
224         <rdar://problem/48930869>
225
226         Reviewed by Alex Christensen.
227
228         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
229
230 2019-04-09  Daniel Bates  <dabates@apple.com>
231
232         [iPad] Should open popover when the spacebar is pressed
233         https://bugs.webkit.org/show_bug.cgi?id=196360
234         <rdar://problem/49389129>
235
236         Reviewed by Brent Fulgham.
237
238         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
239
240         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
241         (WTR::UIScriptController::isShowingPopover const): Added.
242         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
243         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
244         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
245         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
246         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
247         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
248         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
249         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
250         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
251         (WTR::UIScriptController::isShowingPopover const): Added.
252         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
253         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
254         * TestRunnerShared/UIScriptContext/UIScriptController.h:
255         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
256         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
257         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
258         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
259         (-[TestRunnerWKWebView _willPresentPopover]): Added.
260         (-[TestRunnerWKWebView _didDismissPopover]): Added.
261         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
262         (WTR::UIScriptController::isShowingPopover const): Added.
263         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
264         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
265
266 2019-04-09  Alex Christensen  <achristensen@webkit.org>
267
268         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
269         https://bugs.webkit.org/show_bug.cgi?id=196665
270         <rdar://45115669>
271
272         Reviewed by Geoff Garen.
273
274         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
275         (goBack):
276         (+[SimpleLookupContext sharedLookupContext]):
277         (-[SimpleLookupContext lookUpURL:completionHandler:]):
278         (TEST):
279         (+[Simple3LookupContext sharedLookupContext]): Deleted.
280         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
281
282 2019-04-09  John Wilander  <wilander@apple.com>
283
284         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
285         https://bugs.webkit.org/show_bug.cgi?id=196558
286         <rdar://problem/47650245>
287
288         Reviewed by Youenn Fablet.
289
290         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
291         (TestWebKitAPI::TEST):
292             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
293
294 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
295
296         [CMake] Apple builds should use ICU_INCLUDE_DIRS
297         https://bugs.webkit.org/show_bug.cgi?id=196720
298
299         Reviewed by Konstantin Tokarev.
300
301         * TestWebKitAPI/PlatformMac.cmake:
302
303 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
304
305         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
306         https://bugs.webkit.org/show_bug.cgi?id=196694
307         <rdar://problem/48388734>
308
309         Rubber-stamped by Aakash Jain.
310
311         * Scripts/webkitpy/port/image_diff.py:
312         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
313         * Scripts/webkitpy/port/server_process.py:
314         (ServerProcess.has_available_stdout): Check if stdout has data in it.
315         (ServerProcess._wait_for_data_and_update_buffers_using_select):
316         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
317         * Scripts/webkitpy/port/server_process_mock.py:
318         (MockServerProcess.has_available_stdout):
319         * Scripts/webkitpy/port/server_process_unittest.py:
320         (TestServerProcess.serial_test_basic):
321
322 2019-04-09  Jer Noble  <jer.noble@apple.com>
323
324         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
325         https://bugs.webkit.org/show_bug.cgi?id=196097
326
327         Reviewed by Eric Carlson.
328
329         Drive-by bug fix: allow tests to play audio without a user gesture by default.
330
331         * DumpRenderTree/mac/DumpRenderTree.mm:
332         (resetWebPreferencesToConsistentValues):
333         * WebKitTestRunner/TestController.cpp:
334         (WTR::TestController::resetPreferencesToConsistentValues):
335
336 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
337
338         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
339         https://bugs.webkit.org/show_bug.cgi?id=196690
340
341         Reviewed by Michael Catanzaro.
342
343         * QueueStatusServer/config/queues.py:
344         * Scripts/webkitpy/common/config/ews.json:
345         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
346         (test_ews_name):
347
348 2019-04-09  Chris Dumez  <cdumez@apple.com>
349
350         Loads using loadHTMLString() cause flashing when process-swapping
351         https://bugs.webkit.org/show_bug.cgi?id=196714
352         <rdar://problem/49637354>
353
354         Reviewed by Antti Koivisto.
355
356         Add API test coverage.
357
358         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
359
360 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
361
362         Unreviewed. Fix ATK accessibility tests after r244059.
363
364         We are failing to load the injected bundle due to undefined symbol
365         AccessibilityUIElement::replaceTextInRange().
366
367         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
368         (WTR::AccessibilityUIElement::replaceTextInRange):
369
370 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
371
372         AX: Support API: accessibilityReplaceRange:withText
373         https://bugs.webkit.org/show_bug.cgi?id=196636
374
375         Unreviewed build fix for Windows port.
376
377         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
378         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
379
380 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
381
382         [CMake][WinCairo] Separate copied headers into different directories
383         https://bugs.webkit.org/show_bug.cgi?id=196655
384
385         Reviewed by Michael Catanzaro.
386
387         * DumpRenderTree/CMakeLists.txt:
388         * MiniBrowser/win/CMakeLists.txt:
389         * TestWebKitAPI/CMakeLists.txt:
390         * TestWebKitAPI/PlatformWin.cmake:
391
392 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
393
394         Log stack-trace for run-webkit-tests when interrupted
395         https://bugs.webkit.org/show_bug.cgi?id=176393
396         <rdar://problem/34262310>
397
398         Reviewed by Lucas Forschler.
399
400         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
401         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
402         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
403         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
404         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
405         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
406         (main): Set handlers to log stack trace on interruption.
407
408 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
409
410         AX: Support API: accessibilityReplaceRange:withText
411         https://bugs.webkit.org/show_bug.cgi?id=196636
412
413         Unreviewed build fix for Windows port.
414
415         * DumpRenderTree/AccessibilityUIElement.cpp:
416         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
417
418 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
419
420         [ews-build] Scripts using Buildbot API have CORS error
421         https://bugs.webkit.org/show_bug.cgi?id=196709
422
423         Reviewed by Alexey Proskuryakov.
424
425         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
426
427 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
428
429         AX: Support API: accessibilityReplaceRange:withText
430         https://bugs.webkit.org/show_bug.cgi?id=196636
431
432         Reviewed by Daniel Bates.
433
434         * DumpRenderTree/AccessibilityUIElement.cpp:
435         (replaceTextInRangeCallback):
436         (AccessibilityUIElement::replaceTextInRange):
437         (AccessibilityUIElement::getJSClass):
438         * DumpRenderTree/AccessibilityUIElement.h:
439         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
440         (AccessibilityUIElement::replaceTextInRange):
441         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
442         (AccessibilityUIElement::replaceTextInRange):
443         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
444         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
445         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
446         (WTR::AccessibilityUIElement::replaceTextInRange):
447         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
448         (WTR::AccessibilityUIElement::replaceTextInRange):
449
450 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
451
452         [iOS] Do not allow starting selection drags when selection views are not visible
453         https://bugs.webkit.org/show_bug.cgi?id=196686
454         <rdar://problem/49399192>
455
456         Reviewed by Tim Horton.
457
458         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
459         also add some new API tests to cover scenarios where the web view is not first responder.
460
461         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
462         (TestWebKitAPI::TEST):
463         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
464
465         Add a switch to optionally make the web view first responder when starting the simulated drag.
466
467         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
468         (-[DragAndDropSimulator initWithWebView:]):
469         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
470
471 2019-04-08  Justin Fan  <justin_fan@apple.com>
472
473         [Web GPU] Fix Web GPU experimental feature on iOS
474         https://bugs.webkit.org/show_bug.cgi?id=196632
475
476         Reviewed by Myles C. Maxfield.
477
478         Properly make Web GPU available on iOS 11+.
479
480         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
481
482 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
483
484         [ews-build] Do not upload archive when Compile Fails
485         https://bugs.webkit.org/show_bug.cgi?id=196674
486
487         Reviewed by Alexey Proskuryakov.
488
489         * BuildSlaveSupport/ews-build/factories.py:
490         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
491         * BuildSlaveSupport/ews-build/steps.py:
492         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
493         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
494         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
495
496 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
497
498         Enable DFG on MIPS
499         https://bugs.webkit.org/show_bug.cgi?id=196689
500
501         Reviewed by Žan Doberšek.
502
503         Since the bytecode change, we enabled the baseline JIT on mips in
504         r240432, but DFG is still missing. With this change, all tests are
505         passing on a ci20 board.
506
507         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
508
509 2019-04-08  Philippe Normand  <pnormand@igalia.com>
510
511         [Flatpak] Second run update-webkitwpe-flatpak fails
512         https://bugs.webkit.org/show_bug.cgi?id=192702
513
514         Reviewed by Carlos Garcia Campos.
515
516         * flatpak/flatpakutils.py:
517         (FlatpakObject.flatpak): Fix typo.
518         (FlatpakPackage.install): When installing, also update to the configured remote commit.
519         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
520
521 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
522
523         [GTK][WPE] outlook.live.com displays old-fashioned UI
524         https://bugs.webkit.org/show_bug.cgi?id=196642
525
526         Reviewed by Carlos Garcia Campos.
527
528         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
529         (TestWebKitAPI::TEST): New Mac platform quirk test.
530
531 2019-04-07  Commit Queue  <commit-queue@webkit.org>
532
533         Unreviewed, rolling out r243956.
534         https://bugs.webkit.org/show_bug.cgi?id=196688
535
536         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
537         by aakashjain on #webkit).
538
539         Reverted changeset:
540
541         "Clicking "Go Back" from a safe browsing warning from an
542         iframe should navigate the WKWebView back to the previous
543         page"
544         https://bugs.webkit.org/show_bug.cgi?id=196665
545         https://trac.webkit.org/changeset/243956
546
547 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
548
549         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
550         https://bugs.webkit.org/show_bug.cgi?id=196669
551
552         Reviewed by Geoffrey Garen.
553
554         Added three new unit tests for WeakHashSet.
555
556         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
557         (WTF_WeakPtr.WeakHashSetConstObjects):
558         (WTF_WeakPtr.WeakHashSetComputesEmpty):
559         (WTF_WeakPtr.WeakHashSetComputeSize):
560
561 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
562
563         Hide next and previous form control buttons when WKWebView is editable
564         https://bugs.webkit.org/show_bug.cgi?id=196672
565         <rdar://problem/35625321>
566
567         Reviewed by Tim Horton.
568
569         Add a new API test.
570
571         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
572         (-[TestWKWebView lastTrailingBarButtonGroup]):
573         (TestWebKitAPI::TEST):
574         * TestWebKitAPI/ios/UIKitSPI.h:
575
576 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
577
578         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
579         https://bugs.webkit.org/show_bug.cgi?id=196077
580         <rdar://problem/49108202>
581
582         Reviewed by Chris Dumez.
583
584         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
585         on new web view.
586
587         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
588
589 2019-04-05  Saam Barati  <sbarati@apple.com>
590
591         Make compare-results understand MotionMark
592         https://bugs.webkit.org/show_bug.cgi?id=196666
593
594         Reviewed by Yusuke Suzuki.
595
596         * Scripts/compare-results:
597         (PLT5Results):
598         (detectMotionMark):
599         (detectMotionMark1_1):
600         (motionMarkResults):
601         (motionMark1_1Results):
602         (detectBenchmark):
603         (biggerIsBetter):
604         (main):
605
606 2019-04-05  Alex Christensen  <achristensen@webkit.org>
607
608         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
609         https://bugs.webkit.org/show_bug.cgi?id=196665
610         <rdar://45115669>
611
612         Reviewed by Geoff Garen.
613
614         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
615         (goBack):
616         (+[SimpleLookupContext sharedLookupContext]):
617         (-[SimpleLookupContext lookUpURL:completionHandler:]):
618         (TEST):
619         (+[Simple3LookupContext sharedLookupContext]): Deleted.
620         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
621
622 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
623
624         [ews-build] Add configuration and architecture for windows builders
625         https://bugs.webkit.org/show_bug.cgi?id=196660
626
627         Reviewed by Lucas Forschler.
628
629         * BuildSlaveSupport/ews-build/config.json:
630
631 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
632
633         webkitpy: Don't run subsequent rounds if interrupted
634         https://bugs.webkit.org/show_bug.cgi?id=196646
635
636         Reviewed by Aakash Jain.
637
638         * Scripts/webkitpy/layout_tests/controllers/manager.py:
639         (Manager.run): Bail out if interrupted.
640
641 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
642
643         Test sessionStorage in PSON private browsing mode
644         https://bugs.webkit.org/show_bug.cgi?id=196561
645
646         Reviewed by Alex Christensen.
647
648         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
649
650 2019-04-05  Commit Queue  <commit-queue@webkit.org>
651
652         Unreviewed, rolling out r243833.
653         https://bugs.webkit.org/show_bug.cgi?id=196645
654
655         This change breaks build of WPE and GTK ports (Requested by
656         annulen on #webkit).
657
658         Reverted changeset:
659
660         "[CMake][WTF] Mirror XCode header directories"
661         https://bugs.webkit.org/show_bug.cgi?id=191662
662         https://trac.webkit.org/changeset/243833
663
664 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
665
666         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
667         https://bugs.webkit.org/show_bug.cgi?id=196635
668
669         Reviewed by Antti Koivisto.
670         
671         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
672         for a test to enable async frame scrolling via:
673             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
674         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
675         
676         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
677
678         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
679         (WTR::InjectedBundle::beginTesting):
680         * WebKitTestRunner/TestController.cpp:
681         (WTR::TestController::resetPreferencesToConsistentValues):
682
683 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
684
685         Use a correct LC_RPATH when building with ASan
686         https://bugs.webkit.org/show_bug.cgi?id=196576
687
688         Reviewed by David Kilzer.
689
690         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
691         so that ../Frameworks is checked. This is simpler and more reliable than updating
692         each SPC service xcconfig.
693
694 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
695
696         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
697         https://bugs.webkit.org/show_bug.cgi?id=196629
698
699         Reviewed by Lucas Forschler.
700
701         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
702
703 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
704
705         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
706         https://bugs.webkit.org/show_bug.cgi?id=196618
707
708         Reviewed by Lucas Forschler.
709
710         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
711         (StatusBubble): Added QUEUE_TRIGGERS.
712         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
713         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
714         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
715         its parent(builder).
716
717 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
718
719         [ews-app] Status-bubble steps are sometimes displayed in reverse order
720         https://bugs.webkit.org/show_bug.cgi?id=196625
721
722         Reviewed by Lucas Forschler.
723
724         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
725         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
726
727 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
728
729         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
730         https://bugs.webkit.org/show_bug.cgi?id=196630
731
732         Reviewed by Wenson Hsieh.
733
734         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
735
736 2019-04-04  Youenn Fablet  <youenn@apple.com>
737
738         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
739         https://bugs.webkit.org/show_bug.cgi?id=196543
740
741         Reviewed by Alex Christensen.
742
743         * WebKitTestRunner/TestController.cpp:
744         (WTR::TestController::generatePageConfiguration):
745
746 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
747
748         [ews-app] Status bubble should not display skipped buildbot steps
749         https://bugs.webkit.org/show_bug.cgi?id=196584
750
751         Reviewed by Lucas Forschler.
752
753         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
754
755 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
756
757         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
758         https://bugs.webkit.org/show_bug.cgi?id=196620
759
760         Reviewed by Lucas Forschler.
761
762         * BuildSlaveSupport/ews-app/ews/config.py:
763
764 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
765
766         [Win] DumpRenderTreeWatchDog.py is not checked into source
767         https://bugs.webkit.org/show_bug.cgi?id=196567
768         <rdar://problem/49525901>
769
770         Reviewed by Lucas Forschler.
771
772         This script is used on Win EWS bots to terminate hanging DRT processes.
773
774         * EWSTools/dumprendertreewatchdog.py: Added.
775
776 2019-04-04  Chris Dumez  <cdumez@apple.com>
777
778         Unreviewed, roll out r243858 which made tests time out.
779
780         Disable new API tests on Windows instead.
781
782         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
783         (TestWebKitAPI::TEST):
784
785 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
786
787         [ATK] Cleanup WebPageAccessibilityObjectAtk
788         https://bugs.webkit.org/show_bug.cgi?id=196537
789
790         Reviewed by Michael Catanzaro.
791
792         Also consider files under atk directories as exceptions for GObject conventions.
793
794         * Scripts/webkitpy/style/checkers/cpp.py:
795         (check_identifier_name_in_declaration):
796
797 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
798
799         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
800         https://bugs.webkit.org/show_bug.cgi?id=196588
801         <rdar://problem/49365787>
802
803         Unreviewed build fix for Windows port.
804
805         error C3861: 'kill': identifier not found
806
807         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
808         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
809
810 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
811
812         [ews-build] Cancel build and similar operations should have authentication
813         https://bugs.webkit.org/show_bug.cgi?id=196520
814
815         Reviewed by Dewei Zhu.
816
817         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
818         environment variables.
819
820 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
821
822         [ews-build] Do not trigger queues which are not in production yet
823         https://bugs.webkit.org/show_bug.cgi?id=196581
824
825         Reviewed by Dewei Zhu.
826
827         * BuildSlaveSupport/ews-build/config.json:
828
829 2019-04-03  Chris Dumez  <cdumez@apple.com>
830
831         Unreviewed, fix typo in the name of API test added in r243848.
832
833         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
834         (TestWebKitAPI::TEST):
835
836 2019-04-03  Chris Dumez  <cdumez@apple.com>
837
838         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
839         https://bugs.webkit.org/show_bug.cgi?id=196588
840         <rdar://problem/49365787>
841
842         Reviewed by Ryosuke Niwa.
843
844         Add API test coverage.
845
846         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
847         (TestWebKitAPI::nullJavaScriptCallback):
848         (TestWebKitAPI::didCrashCheckFrames):
849         (TestWebKitAPI::TEST):
850
851 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
852
853         run-webkit-tests: Upload test results (new results database)
854         https://bugs.webkit.org/show_bug.cgi?id=196577
855         <rdar://problem/34841155>
856
857         Reviewed by Lucas Forschler.
858
859         * Scripts/webkitpy/layout_tests/controllers/manager.py:
860         (Manager.run): Upload results after each device shard, since the configuration will be
861         different for each device.
862         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
863         uploaded to a results database.
864         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
865         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
866
867 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
868
869         -apple-trailing-word is needed for browser detection
870         https://bugs.webkit.org/show_bug.cgi?id=196575
871
872         Unreviewed.
873
874         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
875
876 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
877
878         [CMake][WTF] Mirror XCode header directories
879         https://bugs.webkit.org/show_bug.cgi?id=191662
880
881         Reviewed by Konstantin Tokarev.
882
883         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
884         builds.
885
886         * CMakeLists.txt:
887         * DumpRenderTree/CMakeLists.txt:
888         * DumpRenderTree/PlatformWin.cmake:
889         * MiniBrowser/win/CMakeLists.txt:
890         * TestWebKitAPI/CMakeLists.txt:
891         * TestWebKitAPI/PlatformWin.cmake:
892         * WebKitTestRunner/PlatformGTK.cmake:
893         * WebKitTestRunner/PlatformWin.cmake:
894
895 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
896
897         [ews-app] Status bubble should not display certain infrastructure status messages
898         https://bugs.webkit.org/show_bug.cgi?id=196550
899
900         Reviewed by Lucas Forschler.
901
902         Do not display the steps which are un-needed for end-user. This information is still avaiable
903         if the user click on the bubble and look at the Buildbot build.
904         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
905         (StatusBubble._steps_messages):
906         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
907
908 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
909
910         [ews-build] Use https for sending data to ews-app
911         https://bugs.webkit.org/show_bug.cgi?id=196492
912
913         Reviewed by Lucas Forschler.
914
915         * BuildSlaveSupport/ews-build/events.py:
916
917 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
918
919         Remove support for -apple-trailing-word
920         https://bugs.webkit.org/show_bug.cgi?id=196525
921
922         Reviewed by Zalan Bujtas.
923
924         This CSS property is nonstandard and not used.
925
926         * Scripts/webkitperl/FeatureList.pm:
927         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
928
929 2019-04-03  Youenn Fablet  <youenn@apple.com>
930
931         Add a test for DOMCache on multiple browsing in case of private browsing
932         https://bugs.webkit.org/show_bug.cgi?id=196524
933
934         Reviewed by Alex Christensen.
935
936         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
937         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
938
939 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
940
941         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
942         https://bugs.webkit.org/show_bug.cgi?id=196540
943
944         Reviewed by Aakash Jain.
945
946         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
947
948 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
949
950         Add plumbing for a compatibility mode preference in WebKit
951         https://bugs.webkit.org/show_bug.cgi?id=196005
952
953         Reviewed by Tim Horton.
954
955         Add new API tests.
956
957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
958         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
959
960 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
961
962         [WPE][GTK] Update libsrtp dependency package for Debian
963         https://bugs.webkit.org/show_bug.cgi?id=196528
964
965         Reviewed by Frédéric Wang.
966
967         * gtk/install-dependencies:
968         * wpe/install-dependencies:
969
970 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
971
972         [WK2] Add support for Window's beforeprint / afterprint events
973         https://bugs.webkit.org/show_bug.cgi?id=196478
974         <rdar://problem/49535124>
975
976         Unreviewed build fix for MSVC.
977
978         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
979
980         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
981
982         * WebKitTestRunner/TestController.cpp:
983         (WTR::printFrame): Use int and float literals.
984
985 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
986
987         [ews-build] Reassign bots to queues
988
989         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
990
991 2019-04-02  Chris Dumez  <cdumez@apple.com>
992
993         [WK2] Add support for Window's beforeprint / afterprint events
994         https://bugs.webkit.org/show_bug.cgi?id=196478
995
996         Reviewed by Alex Christensen.
997
998         Add minimal implementation for printFrame in WebKitTestRunner.
999
1000         * WebKitTestRunner/TestController.cpp:
1001         (WTR::printFrame):
1002         (WTR::TestController::createOtherPage):
1003         (WTR::TestController::createWebViewWithOptions):
1004
1005 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1006
1007         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1008         https://bugs.webkit.org/show_bug.cgi?id=196491
1009
1010         Reviewed by Lucas Forschler.
1011
1012         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1013
1014 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1015
1016         [ews-build] Configure buildbot try credentials in environment variables
1017         https://bugs.webkit.org/show_bug.cgi?id=196501
1018
1019         Reviewed by Lucas Forschler.
1020
1021         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1022         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1023         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1024
1025 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1026
1027         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1028         https://bugs.webkit.org/show_bug.cgi?id=196496
1029         <rdar://problem/49521634>
1030
1031         Reviewed by Chris Dumez.
1032
1033         Add new API tests (see WebKit ChangeLog for more detail).
1034
1035         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1036         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1037         (TEST):
1038
1039 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1040
1041         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1042         <https://webkit.org/b/196499>
1043
1044         Reviewed by Alexey Proskuryakov.
1045
1046         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1047         ENABLE_ADDRESS_SANITIZER.
1048
1049 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1050
1051         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1052         https://bugs.webkit.org/show_bug.cgi?id=182757
1053
1054         Reviewed by Don Olmstead.
1055
1056         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1057         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1058
1059 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1060
1061         run-api-tests: Upload test results
1062         https://bugs.webkit.org/show_bug.cgi?id=196323
1063         <rdar://problem/49356714>
1064
1065         Reviewed by Lucas Forschler.
1066
1067         * Scripts/webkitpy/api_tests/manager.py:
1068         (Manager):
1069         (Manager.run): Upload results to a results database.
1070         * Scripts/webkitpy/api_tests/run_api_tests.py:
1071         (parse_args): Add upload arguments.
1072         * Scripts/webkitpy/port/base.py:
1073         (Port):
1074         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1075         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1076         with commits from any other associated repositories.
1077         * Scripts/webkitpy/port/device.py:
1078         (Device):
1079         (Device.build_version): Access build_versoin of underlying platform device.
1080         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1081         (IOSSimulatorTest):
1082         (IOSSimulatorTest.test_configuration_for_upload):
1083         * Scripts/webkitpy/port/device_port.py:
1084         (DevicePort):
1085         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1086         the same as the machine uploading results.
1087         * Scripts/webkitpy/port/mac.py:
1088         (MacPort):
1089         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1090         * Scripts/webkitpy/port/mac_unittest.py:
1091         (MacTest):
1092         (MacTest.test_configuration_for_upload):
1093         * Scripts/webkitpy/xcode/simulated_device.py:
1094         (SimulatedDeviceManager._create_device_with_runtime):
1095         (SimulatedDevice.__init__): Create simulated device with a build_version.
1096         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1097         (test_existing_simulator):
1098
1099 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1100
1101         Remove extra newline characters (Follow-up fix to r243707)
1102
1103         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1104
1105 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1106
1107         [ews-app] Use API_KEY to accept results data
1108         https://bugs.webkit.org/show_bug.cgi?id=196461
1109
1110         Reviewed by Dewei Zhu.
1111
1112         * BuildSlaveSupport/ews-app/ews/views/results.py:
1113         (Results.post): Validate EWS_API_KEY before accepting any data.
1114         * BuildSlaveSupport/ews-build/events.py:
1115         (Events.sendData): Send EWS_API_KEY if available along with event data.
1116
1117 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1118
1119         Unable to copy and paste a PDF from Notes into Mail compose body
1120         https://bugs.webkit.org/show_bug.cgi?id=196442
1121         <rdar://problem/48573098>
1122
1123         Reviewed by Tim Horton.
1124
1125         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1126         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1127         to be specified on the item providers.
1128
1129         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1130         (TestWebKitAPI::mapItemForTesting):
1131         (TestWebKitAPI::contactItemForTesting):
1132
1133 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1134
1135         Make UIWKDocumentContext rects per-character instead of per-word
1136         https://bugs.webkit.org/show_bug.cgi?id=196459
1137
1138         Reviewed by Wenson Hsieh.
1139
1140         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1141         (TEST):
1142         Adjust test results due to switching to per-character rects.
1143
1144 2019-04-01  Chris Dumez  <cdumez@apple.com>
1145
1146         UIProcess crash when a prewarmed process is terminated
1147         https://bugs.webkit.org/show_bug.cgi?id=196451
1148         <rdar://problem/49245471>
1149
1150         Reviewed by Geoffrey Garen.
1151
1152         Add API test coverage.
1153
1154         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1155         (TEST):
1156
1157 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1158
1159         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1160         https://bugs.webkit.org/show_bug.cgi?id=196449
1161
1162         Reviewed by Lucas Forschler.
1163
1164         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1165         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1166         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1167         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1168
1169 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1170
1171         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1172         https://bugs.webkit.org/show_bug.cgi?id=196444
1173
1174         Reviewed by Lucas Forschler.
1175
1176         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1177
1178 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1179
1180         Add SPI to canonicalize NSURLs with WTF::URL
1181         https://bugs.webkit.org/show_bug.cgi?id=196415
1182         <rdar://problem/44980271>
1183
1184         Reviewed by Darin Adler.
1185
1186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1187         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1188         (TestWebKitAPI::TEST):
1189
1190 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1191
1192         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1193         https://bugs.webkit.org/show_bug.cgi?id=196441
1194
1195         Reviewed by Carlos Garcia Campos.
1196
1197         Don't cache the wpe_view_backend object that might not exist yet at the
1198         time of EventSenderProxy constructor invocation, but instead retrieve
1199         that object whenever it's required for event dispatching. This should
1200         avoid crashes in this constructor now that it's invoked before any
1201         PlatformWindow has been set up (as changed in r243496).
1202
1203         * WebKitTestRunner/EventSenderProxy.h:
1204         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1205         (WTR::viewBackend):
1206         (WTR::EventSenderProxy::EventSenderProxy):
1207         (WTR::EventSenderProxy::mouseDown):
1208         (WTR::EventSenderProxy::mouseUp):
1209         (WTR::EventSenderProxy::mouseMoveTo):
1210         (WTR::EventSenderProxy::mouseScrollBy):
1211         (WTR::EventSenderProxy::keyDown):
1212         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1213
1214 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1215
1216         [Win][WebKit] MiniBrowser should support high DPI display
1217         https://bugs.webkit.org/show_bug.cgi?id=196391
1218
1219         Reviewed by Alex Christensen.
1220
1221         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1222         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1223         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1224         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1225
1226 2019-03-31  Sam Weinig  <weinig@apple.com>
1227
1228         Remove more i386 specific configurations
1229         https://bugs.webkit.org/show_bug.cgi?id=196430
1230
1231         Reviewed by Alexey Proskuryakov.
1232
1233         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1234         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1235
1236 2019-03-31  Andy Estes  <aestes@apple.com>
1237
1238         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1239         https://bugs.webkit.org/show_bug.cgi?id=196433
1240         <rdar://problem/49293305>
1241
1242         Reviewed by Tim Horton.
1243
1244         Enhanced API test coverage to include all navigation response policy decisions in both
1245         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1246
1247         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1248         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1249         (TestWebKitAPI::TEST):
1250         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1251         (readFile):
1252         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1253         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1254         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1255         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1256         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1257         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1258         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1259         (-[QuickLookDelegate _downloadDidStart:]):
1260         (-[QuickLookDelegate _download:didReceiveResponse:]):
1261         (-[QuickLookDelegate _download:didReceiveData:]):
1262         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1263         (-[QuickLookDelegate _downloadDidFinish:]):
1264         (-[QuickLookDelegate _download:didFailWithError:]):
1265         (-[QuickLookDelegate _downloadDidCancel:]):
1266         (-[QuickLookDelegate verifyDownload]):
1267         (runTest):
1268         (runTestDecideBeforeLoading):
1269         (runTestDecideAfterLoading):
1270         (TEST):
1271         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1272         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1273         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1274         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1275         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1276         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1277         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1278         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1279         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1280         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1281         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1282         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1283         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1284         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1285
1286 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1287
1288         [CMake] add testdfg as target with build-jsc
1289         https://bugs.webkit.org/show_bug.cgi?id=196393
1290
1291         Reviewed by Saam Barati.
1292
1293         Added testdfg as one of the targets to build when
1294         using CMake.
1295
1296         * Scripts/build-jsc:
1297
1298 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1299
1300         Delete WebMetal implementation in favor of WebGPU
1301         https://bugs.webkit.org/show_bug.cgi?id=195418
1302
1303         Reviewed by Dean Jackson.
1304
1305         * DumpRenderTree/mac/DumpRenderTree.mm:
1306         (enableExperimentalFeatures):
1307         (resetWebPreferencesToConsistentValues):
1308         * Scripts/webkitperl/FeatureList.pm:
1309         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1310         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1311         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1312         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1313         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1314         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1315         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1316         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1317         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1318         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1319         (WTR::InjectedBundle::beginTesting):
1320         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1321         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1322         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1323
1324 2019-03-29  Chris Dumez  <cdumez@apple.com>
1325
1326         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1327         https://bugs.webkit.org/show_bug.cgi?id=196405
1328         <rdar://problem/49428130>
1329
1330         Reviewed by Wenson Hsieh.
1331
1332         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1333         the popover presentation methods to be no-ops. Use this in the new test added in
1334         r243523 so that we do not swizzle those methods for all tests. This is needed because
1335         those WatchOS tests rely on the popover getting presented and interactive.
1336
1337         * WebKitTestRunner/TestController.cpp:
1338         (WTR::updateTestOptionsFromTestHeader):
1339         * WebKitTestRunner/TestController.h:
1340         * WebKitTestRunner/TestOptions.h:
1341         (WTR::TestOptions::hasSameInitializationOptions const):
1342         * WebKitTestRunner/ios/TestControllerIOS.mm:
1343         (WTR::TestController::platformInitialize):
1344         (WTR::TestController::platformResetStateToConsistentValues):
1345
1346 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1347
1348         [Curl] Add Server Trust Evaluation Support.
1349         https://bugs.webkit.org/show_bug.cgi?id=191646
1350
1351         Reviewed by Fujii Hironori.
1352
1353         Implemented MiniBrowser UI for asking if user trusts the server.
1354
1355         * MiniBrowser/win/Common.cpp:
1356         (askServerTrustEvaluation):
1357         (replaceString):
1358         * MiniBrowser/win/Common.h:
1359         * MiniBrowser/win/MiniBrowserLib.rc:
1360         * MiniBrowser/win/MiniBrowserLibResource.h:
1361         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1362         (createPEMString):
1363         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1364         (WebKitBrowserWindow::canTrustServerCertificate):
1365         * MiniBrowser/win/WebKitBrowserWindow.h:
1366
1367 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1368
1369         Implement ResizeObserver.
1370         https://bugs.webkit.org/show_bug.cgi?id=157743
1371
1372         Reviewed by Simon Fraser.
1373
1374         Support resizeObserverEnabled webPreferences.
1375
1376         * DumpRenderTree/TestOptions.cpp:
1377         (TestOptions::TestOptions):
1378         * DumpRenderTree/TestOptions.h:
1379         * DumpRenderTree/mac/DumpRenderTree.mm:
1380         (setWebPreferencesForTestOptions):
1381         * DumpRenderTree/win/DumpRenderTree.cpp:
1382         (enableExperimentalFeatures):
1383         * Scripts/webkitperl/FeatureList.pm:
1384         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1385
1386 2019-03-28  John Wilander  <wilander@apple.com>
1387
1388         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1389         https://bugs.webkit.org/show_bug.cgi?id=196281
1390         <rdar://problem/48938748>
1391
1392         Reviewed by Alex Christensen.
1393
1394         This patch adds the function isStatisticsHasLocalStorage() to the
1395         TestRunner. With it, the page can query the WebsiteDataStore in the
1396         UI process to make sure that it sees LocalStorage.
1397
1398         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1399         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1400         (WTR::TestRunner::isStatisticsHasLocalStorage):
1401         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1402         * WebKitTestRunner/TestController.cpp:
1403         (WTR::TestController::isStatisticsHasLocalStorage):
1404         * WebKitTestRunner/TestController.h:
1405         * WebKitTestRunner/TestInvocation.cpp:
1406         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1407
1408 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1409
1410         API::Data::createWithoutCopying should do a null check before calling CFRelease
1411         https://bugs.webkit.org/show_bug.cgi?id=196276
1412         <rdar://problem/48059859>
1413
1414         Reviewed by Alex Christensen.
1415
1416         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1417
1418         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1419         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1420         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1421         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1422         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1423         (TestWebKitAPI::TEST):
1424
1425 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1426
1427         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1428         https://bugs.webkit.org/show_bug.cgi?id=186276
1429
1430         Reviewed by Carlos Garcia Campos.
1431
1432         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1433         (webViewLoadChanged):
1434         (testWebResourceGetDataError):
1435         (testWebResourceGetDataEmpty):
1436         (beforeAll):
1437         (webViewloadChanged): Deleted.
1438
1439 2019-03-27  Andy Estes  <aestes@apple.com>
1440
1441         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1442         https://bugs.webkit.org/show_bug.cgi?id=196317
1443
1444         Reviewed by Dan Bernstein.
1445
1446         package-root copies built products into a staging directory using ditto(1), which does not
1447         follow symbolic links as it traverses a directory. Now that the files in
1448         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1449         itself, these become broken links when ditto'd into the staging directory.
1450
1451         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1452
1453         * Scripts/package-root:
1454
1455 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1456
1457         [ews-app] Update display text of Submit for ews analysis
1458         https://bugs.webkit.org/show_bug.cgi?id=196309
1459
1460         Reviewed by Dewei Zhu.
1461
1462         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1463
1464 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1465
1466         run-webkit-tests should check for leaks in WebKit processes
1467         <https://webkit.org/b/193772>
1468         <rdar://problem/46526680>
1469
1470         Reviewed by Ryosuke Niwa.
1471
1472         This works by doing the following:
1473         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1474           The list of child processes are returned one per line:
1475           process.name: pid
1476         - Run the "#LIST CHILD PROCESSES" command just before the
1477           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1478           processes on the ServerProcess object.
1479         - When the `--leaks` switch is handled, run check_for_leaks() on
1480           each child process after the main test harness.
1481
1482         * DumpRenderTree/mac/DumpRenderTree.mm:
1483         (handleControlCommand):
1484         - Use strncmp() instead of strcmp().
1485         - Add support for handling "#LIST CHILD PROCESSES" command.
1486
1487         * Scripts/webkitpy/port/base.py:
1488         (Port.check_for_leaks):
1489         * Scripts/webkitpy/port/darwin.py:
1490         (DarwinPort.check_for_leaks):
1491         - Rename redundant 'process_pid' argument to 'process_id'.
1492
1493         * Scripts/webkitpy/port/driver.py:
1494         (Driver.do_post_tests_work):
1495         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1496           longer the only command this sends to WebKitTestRunner.
1497         - If the `--leaks` switch is present, send the
1498           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1499           result using Port.set_webkit_processes().
1500         (Driver._parse_child_processes_output):
1501         - Add helper method to parse list of child process names and
1502           process IDs returned from WebKitTestRunner.
1503
1504         * Scripts/webkitpy/port/ios_device.py:
1505         (IOSDevicePort.check_for_leaks):
1506         - Rename redundant 'process_pid' argument to 'process_id'.
1507
1508         * Scripts/webkitpy/port/leakdetector.py:
1509         (LeakDetector._parse_leaks_output):
1510         - Return early if there is no leaks_output.
1511         (LeakDetector.check_for_leaks):
1512         - Rename redundant 'process_pid' argument to 'process_id'.
1513
1514         * Scripts/webkitpy/port/server_process.py:
1515         (ServerProcess.__init__):
1516         (ServerProcess.child_processes):
1517         (ServerProcess.set_child_processes):
1518         - Add instance variable to Port to store list of child process
1519           names and process IDs returned from WebKitTestRunner.
1520         (ServerProcess._start):
1521         - Clear self._child_processes.
1522         (ServerProcess.stop):
1523         - If self._child_processes is set, call
1524           self._port.check_for_leaks() for each child process.
1525
1526         * Scripts/webkitpy/port/server_process_unittest.py:
1527         (TrivialMockPort.check_for_leaks):
1528         - Rename redundant 'process_pid' argument to 'process_id'.
1529
1530         * Scripts/webkitpy/port/simulator_process.py:
1531         (SimulatorProcess.stop):
1532         - If self._child_processes is set, call
1533           self._port.check_for_leaks() for each child process.
1534
1535         * Scripts/webkitpy/port/watch_device.py:
1536         (WatchDevicePort.check_for_leaks):
1537         - Rename redundant 'process_pid' argument to 'process_id'.
1538
1539         * WebKitTestRunner/TestController.cpp:
1540         (WTR::TestController::dumpResponse):
1541         - Extract method from findAndDumpWorldLeaks() so that it may be
1542           reused by findAndDumpWebKitProcessIdentifiers().
1543         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1544         - Add method to output process name and process ID of both the
1545           WebContent and Networking processes.
1546         (WTR::TestController::findAndDumpWorldLeaks):
1547         - Fix missing newline in output when there were no abandoned
1548           documents.
1549         - Call dumpResponse() for extracted code.
1550         (WTR::TestController::handleControlCommand):
1551         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1552         - Use strncmp() instead of strcmp().
1553         - Call findAndDumpWebKitProcessIdentifiers() when
1554           "#LIST CHILD PROCESSES" command is sent.
1555         * WebKitTestRunner/TestController.h:
1556         (WTR::TestController::dumpResponse):
1557         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1558         - Declare methods.
1559
1560 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1561
1562         Unreviewed. Add GLib API test cases after r243434.
1563
1564         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1565         (testWebViewActiveURI):
1566         (serverCallback):
1567         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1568         (sendRequestCallback):
1569
1570 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1571
1572         Geolocation request not complete when watch request was started in a different web process
1573         https://bugs.webkit.org/show_bug.cgi?id=195996
1574
1575         Reviewed by Alex Christensen.
1576
1577         Add a test case.
1578
1579         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1580         (TestWebKitAPI::runJavaScriptAlert):
1581         (TestWebKitAPI::TEST):
1582
1583 2019-03-26  Keith Rollin  <krollin@apple.com>
1584
1585         Update the way generate-xcfilelists returns strings from functions
1586         https://bugs.webkit.org/show_bug.cgi?id=195975
1587         <rdar://problem/49040807>
1588
1589         Reviewed by Dean Jackson.
1590
1591         There are places where generate-xcfilelists executes assignments with
1592         statements like:
1593
1594             FOO=$(some_function)
1595
1596         where "some_function" return a string by echoing it. E.g.
1597
1598             some_function()
1599             {
1600                 echo "Hello, World"
1601             }
1602
1603         This is a common idiom, but it has a problem if "some_function" needs
1604         to call "exit" in an attempt to halt the entire script right then and
1605         there. Since "some_function" is called inside of $(), it's being
1606         executed in a sub-shell. Calling exit in that sub-shell simply exits
1607         that shell; it doesn't not exit the outer shell in which the main part
1608         of the script is still running. As such, the main script keeps
1609         executing when the intent was for the script to halt.
1610
1611         The solution to this is to use a different idiom for returning
1612         strings. The one we now is to pass in the name of the variable to
1613         receive the string result:
1614
1615             some_function()
1616             {
1617                 variable_name=$1
1618                 eval $variable_name ="Hello, World"
1619             }
1620
1621         The call site now looks like
1622
1623             some_function FOO
1624
1625         Because there's no invocation of a sub-shell, some_function can now
1626         call "exit" if it wants to, and the entire script will exit at that
1627         point.
1628
1629         * Scripts/generate-xcfilelists:
1630
1631 2019-03-26  Chris Dumez  <cdumez@apple.com>
1632
1633         Add basic layout test coverage for File Picker on iOS
1634         https://bugs.webkit.org/show_bug.cgi?id=196265
1635
1636         Reviewed by Wenson Hsieh.
1637
1638         Add layout test infrastructure to test the file picker on iOS.
1639
1640         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1641         (WTR::UIScriptController::dismissFilePicker):
1642         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1643         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1644         (WTR::UIScriptController::dismissFilePicker):
1645         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1646         * WebKitTestRunner/TestController.cpp:
1647         (WTR::TestController::createWebViewWithOptions):
1648         (WTR::updateTestOptionsFromTestHeader):
1649         * WebKitTestRunner/TestOptions.h:
1650         (WTR::TestOptions::hasSameInitializationOptions const):
1651         * WebKitTestRunner/ios/TestControllerIOS.mm:
1652         (overridePresentViewController):
1653         (WTR::TestController::platformInitialize):
1654         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1655         (WTR::UIScriptController::dismissFilePicker):
1656
1657 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1658
1659         Implement async paste method on UIWKInteractionViewProtocol
1660         https://bugs.webkit.org/show_bug.cgi?id=196267
1661         <rdar://problem/49236346>
1662
1663         Reviewed by Tim Horton.
1664
1665         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1666         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1667         are now a part of all iOS 12 internal SDKs.
1668
1669         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1670
1671         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1672         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1673
1674         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1675         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1676         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1677         * TestWebKitAPI/ios/UIKitSPI.h:
1678
1679 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1680
1681         [ews-build] Use PostgreSQL for ews.webkit.org database
1682         https://bugs.webkit.org/show_bug.cgi?id=196270
1683
1684         Reviewed by Lucas Forschler.
1685
1686         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1687
1688 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1689
1690         [ews] Reset simctl states on reboot
1691         https://bugs.webkit.org/show_bug.cgi?id=196260
1692
1693         Rubber-stamped by Aakash Jain.
1694
1695         * EWSTools/start-queue-mac.sh:
1696
1697 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1698
1699         [ews-build] Use PostgreSQL for ews-build database
1700         https://bugs.webkit.org/show_bug.cgi?id=196229
1701
1702         Reviewed by Lucas Forschler.
1703
1704         * BuildSlaveSupport/ews-build/master.cfg:
1705
1706 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1707
1708         [ews-build] Get master_hostname dynamically in master.cfg
1709         https://bugs.webkit.org/show_bug.cgi?id=196255
1710
1711         Reviewed by Lucas Forschler.
1712
1713         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1714         send events data in test mode.
1715
1716 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1717
1718         [ews-app] Set db_constraint to False for Foreign Keys
1719         https://bugs.webkit.org/show_bug.cgi?id=196252
1720
1721         Reviewed by Lucas Forschler.
1722
1723         * BuildSlaveSupport/ews-app/ews/models/build.py:
1724         * BuildSlaveSupport/ews-app/ews/models/step.py:
1725
1726 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1727
1728         [ews-build] is_test_mode_enabled should default to True
1729         https://bugs.webkit.org/show_bug.cgi?id=196248
1730
1731         Reviewed by Lucas Forschler.
1732
1733         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1734
1735 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1736
1737         [ews-app] Add webkitperl to ENABLED_QUEUES
1738         https://bugs.webkit.org/show_bug.cgi?id=196253
1739
1740         Reviewed by Lucas Forschler.
1741
1742         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1743
1744 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1745
1746         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1747         https://bugs.webkit.org/show_bug.cgi?id=196211
1748         rdar://problem/49110552
1749
1750         Reviewed by Tim Horton.
1751
1752         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1753         Make sure that EventSenderProxy always exists when running tests. We used to create
1754         it when resetting before the first test, which is a bit too late.
1755
1756         * WebKitTestRunner/TestController.h:
1757         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1758         (WTR::TestController::platformCreateWebView):
1759         (WTR::TestController::platformCreateOtherPage):
1760         (WTR::TestController::finishCreatingPlatformWebView):
1761         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1762         (WTR::PlatformWebView::PlatformWebView):
1763         Moved some code that made NSWindow use NSEvent during web view creation. We may
1764         need to move more if some other case us found, but this is enough for now.
1765
1766 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1767
1768         Unreviewed. Fix typo in GLib geolocation API after r243285.
1769
1770         gelocation -> geolocation.
1771
1772         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1773         (testGeolocationManagerWatchPosition):
1774
1775 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1776
1777         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1778         https://bugs.webkit.org/show_bug.cgi?id=196213
1779
1780         Reviewed by Geoff Garen.
1781
1782         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1783         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1784         (credentialWithIdentityAndKeychainPath):
1785         (-[ChallengeDelegate webView:didFinishNavigation:]):
1786         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1787         (TestWebKitAPI::TEST):
1788
1789 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1790
1791         Expected shouldn't assume its contained types are copyable
1792         https://bugs.webkit.org/show_bug.cgi?id=195986
1793
1794         Reviewed by JF Bastien.
1795
1796         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1797         (TestWebKitAPI::NonCopyable::operator== const):
1798         (TestWebKitAPI::NonCopyable::operator!= const):
1799         (TestWebKitAPI::TEST):
1800
1801 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1802
1803         Remove some now-unnecessary dynamic class lookup
1804         https://bugs.webkit.org/show_bug.cgi?id=196237
1805
1806         Reviewed by Simon Fraser.
1807
1808         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1809         (makeRequest):
1810         (TEST):
1811
1812 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1813
1814         Unreviewed, rolling out r243450.
1815
1816         AppleWin and WinCairo port builds get broken.
1817
1818         Reverted changeset:
1819
1820         "Add test for fix of #196095"
1821         https://bugs.webkit.org/show_bug.cgi?id=196097
1822         https://trac.webkit.org/changeset/243450
1823
1824 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1825
1826         Unreviewed, rolling out r243465.
1827         https://bugs.webkit.org/show_bug.cgi?id=196226
1828
1829         the test doesn't build (Requested by thorton on #webkit).
1830
1831         Reverted changeset:
1832
1833         "Do not terminate the NetworkProcess if a third party
1834         application sends a NSCredential with a SecIdentityRef"
1835         https://bugs.webkit.org/show_bug.cgi?id=196213
1836         https://trac.webkit.org/changeset/243465
1837
1838 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1839
1840         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1841         https://bugs.webkit.org/show_bug.cgi?id=196213
1842
1843         Reviewed by Geoff Garen.
1844
1845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1846         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1847         (credentialWithIdentityAndKeychainPath):
1848         (-[ChallengeDelegate webView:didFinishNavigation:]):
1849         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1850         (TestWebKitAPI::TEST):
1851
1852 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1853
1854         [ews-build] Gracefully handle missing patch_id in events
1855         https://bugs.webkit.org/show_bug.cgi?id=196216
1856
1857         Reviewed by Lucas Forschler.
1858
1859         * BuildSlaveSupport/ews-build/events.py:
1860
1861 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1862
1863         [ews-build] use lz4 compression for improving buildbot performance
1864         https://bugs.webkit.org/show_bug.cgi?id=196155
1865
1866         Reviewed by Lucas Forschler.
1867
1868         * BuildSlaveSupport/ews-build/master.cfg:
1869
1870 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1871
1872         Pull some API testing helper methods out of TestWKWebView
1873         https://bugs.webkit.org/show_bug.cgi?id=196212
1874
1875         Reviewed by Tim Horton.
1876
1877         Refactor some more API testing utility methods, so that they can be used in
1878         tests that do not use TestWKWebView.
1879
1880         * TestWebKitAPI/cocoa/TestWKWebView.h:
1881         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1882         (-[WKWebView loadTestPageNamed:]):
1883         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1884         (-[WKWebView synchronouslyLoadHTMLString:]):
1885         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1886         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1887         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1888         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1889         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1890
1891 2019-03-25  Jer Noble  <jer.noble@apple.com>
1892
1893         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1894         https://bugs.webkit.org/show_bug.cgi?id=196097
1895
1896         Reviewed by Eric Carlson.
1897
1898         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1899
1900         * DumpRenderTree/mac/DumpRenderTree.mm:
1901         (resetWebPreferencesToConsistentValues):
1902         * WebKitTestRunner/TestController.cpp:
1903         (WTR::TestController::resetPreferencesToConsistentValues):
1904
1905 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1906
1907         Pull IPadUserInterfaceSwizzler out into a separate header file
1908         https://bugs.webkit.org/show_bug.cgi?id=196193
1909
1910         Reviewed by Anders Carlsson.
1911
1912         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1913         be used in other API tests.
1914
1915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1916         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1917         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1918         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1919         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1920         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1921         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1922
1923 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1924
1925         Remove NavigatorContentUtils in WebCore/Modules
1926         https://bugs.webkit.org/show_bug.cgi?id=196070
1927
1928         Reviewed by Alex Christensen.
1929
1930         NavigatorContentUtils was to support the custom scheme spec [1].
1931         However, in WebKit side, no port has supported the feature in
1932         WebKit layer after EFL port was removed. So there has been the
1933         only IDL implementation of the NavigatorContentUtils in WebCore.
1934         So we don't need to keep the implementation in WebCore anymore.
1935
1936         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1937
1938         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1939
1940 2019-03-24  Andy Estes  <aestes@apple.com>
1941
1942         [watchOS] Remove unused Proximity Networking code
1943         https://bugs.webkit.org/show_bug.cgi?id=196188
1944
1945         Reviewed by Tim Horton.
1946
1947         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1948         (TEST):
1949
1950 2019-03-23  Keith Miller  <keith_miller@apple.com>
1951
1952         Refactor clz/ctz and fix getLSBSet.
1953         https://bugs.webkit.org/show_bug.cgi?id=196162
1954
1955         Reviewed by Saam Barati.
1956
1957         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1958
1959         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1960         (TestWebKitAPI::TEST):
1961
1962 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1963
1964         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1965         https://bugs.webkit.org/show_bug.cgi?id=196143
1966
1967         Reviewed by Michael Catanzaro.
1968
1969         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1970         directories.
1971
1972         * Scripts/webkitpy/style/checkers/cpp.py:
1973         (check_identifier_name_in_declaration):
1974         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1975         (WebKitStyleTest.test_names):
1976
1977 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1978
1979         [Flatpak] Manifest expanding fails for qt WPE extension
1980         https://bugs.webkit.org/show_bug.cgi?id=196148
1981
1982         Reviewed by Alex Christensen.
1983
1984         * flatpak/flatpakutils.py:
1985         (expand_submodules_recurse): The last recurse manifest expand
1986         iteration might lead to a single module so take it into account
1987         and don't try to recurse further.
1988
1989 2019-03-22  Chris Dumez  <cdumez@apple.com>
1990
1991         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1992         https://bugs.webkit.org/show_bug.cgi?id=195348
1993         <rdar://problem/48622090>
1994
1995         Reviewed by Alex Christensen.
1996
1997         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1998         to NO when test.options().shouldIgnoreMetaViewport is false.
1999
2000         * WebKitTestRunner/ios/TestControllerIOS.mm:
2001         (WTR::TestController::platformConfigureViewForTest):
2002
2003 2019-03-22  Chris Dumez  <cdumez@apple.com>
2004
2005         Prewarmed processes should be usable with any website data store
2006         https://bugs.webkit.org/show_bug.cgi?id=196104
2007
2008         Reviewed by Alex Christensen.
2009
2010         Add API test coverage.
2011
2012         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2013         (runInitialWarmedProcessUsedTest):
2014         (TEST):
2015
2016 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2017
2018         Back out local changes to Alex's Subversion working directory
2019
2020         They were accidentally committed.
2021
2022         * Scripts/webkitpy/common/system/abstractexecutive.py:
2023         (AbstractExecutive.wait_newest):
2024         * Scripts/webkitpy/common/system/executive.py:
2025         (Executive.running_pids):
2026         * Scripts/webkitpy/common/system/executive_mock.py:
2027         (MockExecutive.running_pids):
2028         * Scripts/webkitpy/common/system/executive_unittest.py:
2029         (ExecutiveTest.serial_test_running_pids):
2030         * Scripts/webkitpy/port/darwin.py:
2031         (DarwinPort.check_for_leaks):
2032         * Scripts/webkitpy/port/leakdetector.py:
2033         (LeakDetector.check_for_leaks):
2034         - This was the hack attached to Bug 193772.
2035
2036         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2037         (+[WebKitTestRunnerEvent mouseLocation]):
2038         - This works around a crash on an internal build.
2039
2040 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2041
2042         Fix the build after r243354
2043         https://bugs.webkit.org/show_bug.cgi?id=196138
2044         <rdar://problem/49145951>
2045
2046         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2047         (TEST):
2048         * TestWebKitAPI/ios/UIKitSPI.h:
2049
2050 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2051
2052         Adopt UIWKDocumentContext
2053         https://bugs.webkit.org/show_bug.cgi?id=196040
2054         <rdar://problem/48642440>
2055
2056         Reviewed by Ryosuke Niwa.
2057
2058         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2059         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2060         (makeRequest):
2061         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2062         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2063         (applyStyle):
2064         (TEST):
2065         Add tests for UIWKDocumentContext.
2066
2067         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2068         (TEST):
2069         (recursiveFindWKContentView): Deleted.
2070         * TestWebKitAPI/cocoa/TestWKWebView.h:
2071         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2072         (recursiveFindWKContentView):
2073         (-[TestWKWebView wkContentView]):
2074         * TestWebKitAPI/ios/UIKitSPI.h:
2075         Share the WKContentView finding code between tests.
2076
2077 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2078
2079         [iOS WK2] Turn on async overflow scrolling by default
2080         https://bugs.webkit.org/show_bug.cgi?id=196011
2081         rdar://problem/48453859
2082
2083         Reviewed by Antti Koivisto.
2084         
2085         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2086         since so many basic layout tests have different results when compositing is triggered for
2087         overflow.
2088         
2089         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2090
2091         * WebKitTestRunner/TestController.cpp:
2092         (WTR::TestController::resetPreferencesToConsistentValues):
2093
2094 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2095
2096         [ews-build] Retry API test in case of failures
2097         https://bugs.webkit.org/show_bug.cgi?id=196004
2098
2099         Reviewed by Lucas Forschler.
2100
2101         * BuildSlaveSupport/ews-build/steps.py:
2102         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2103         (CompileWebKitToT.doStepIf): Ditto.
2104         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2105         (ReRunAPITests): Re-run API tests.
2106         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2107         (RunAPITestsWithoutPatch): Run API tests without patch.
2108         (RunAPITestsWithoutPatch.doStepIf):
2109         (RunAPITestsWithoutPatch.hideStepIf):
2110         (RunAPITestsWithoutPatch.evaluateCommand):
2111         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2112         (AnalyzeAPITestsResults.start):
2113         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2114         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2115         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2116         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2117
2118 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2119
2120         [ews-build] Update queues configurations
2121         https://bugs.webkit.org/show_bug.cgi?id=196074
2122
2123         Reviewed by Dewei Zhu.
2124
2125         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2126         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2127
2128 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2129
2130         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2131         https://bugs.webkit.org/show_bug.cgi?id=195680
2132         <rdar://problem/48903534>
2133
2134         Unreviewed infrastructure fix.
2135
2136         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2137         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2138
2139 2019-03-21  Andy Estes  <aestes@apple.com>
2140
2141         [iOS] Apple Pay should be available in documents with no user agent scripts
2142         https://bugs.webkit.org/show_bug.cgi?id=196061
2143         <rdar://problem/48649391>
2144
2145         Reviewed by Brady Eidson.
2146
2147         Added API tests and related infrastructure.
2148
2149         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2150         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2151         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2152         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2153         (TestWebKitAPI::TEST):
2154         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2155         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2156         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2157         * TestWebKitAPI/cocoa/TestProtocol.mm:
2158         (-[TestProtocol startLoading]):
2159         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2160         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2161         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2162         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2163
2164 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2165
2166         REGRESSSION (r243297): webkitpy tests broken
2167         https://bugs.webkit.org/show_bug.cgi?id=196108
2168
2169         Reviewed by Aakash Jain.
2170
2171         r243297 updated contributors.json, which broke a few unit tests.
2172
2173         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2174         (IRCCommandTest.test_whois):
2175         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2176
2177 2019-03-21  Chris Dumez  <cdumez@apple.com>
2178
2179         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2180         https://bugs.webkit.org/show_bug.cgi?id=196041
2181         <rdar://problem/49083230>
2182
2183         Reviewed by Alex Christensen.
2184
2185         Add API test coverage.
2186
2187         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2188         (TEST):
2189
2190 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2191
2192         Add SPI to inform applications of WKContentRuleList actions
2193         https://bugs.webkit.org/show_bug.cgi?id=195965
2194         <rdar://problem/42664365>
2195
2196         Reviewed by Geoff Garen.
2197
2198         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2199         (TestWebKitAPI::allActionsForResourceLoad):
2200         (TestWebKitAPI::testRequest):
2201         (TestWebKitAPI::TEST_F):
2202         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2203         (Notification::description):
2204         (Notification::operator== const):
2205         (toVector):
2206         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2207         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2208         (makeContentRuleList):
2209         (TEST):
2210         (makeWarnContentRuleList): Deleted.
2211
2212 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2213
2214         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2215         https://bugs.webkit.org/show_bug.cgi?id=196088
2216
2217         Reviewed by Brian Burg.
2218
2219         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2220         Support checks when only one platform is specified. Also deprecate macosx() and
2221         force the use of macos() instead.
2222
2223         * Scripts/webkitpy/style/checkers/cpp.py:
2224         (check_min_versions_of_wk_api_available):
2225         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2226         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2227
2228 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2229
2230         Update status inactive committers' status to 'contributor'.
2231
2232         * Scripts/webkitpy/common/config/contributors.json:
2233
2234 2019-03-21  Xan Lopez  <xan@igalia.com>
2235
2236         [JSC][x86] Drop support for x87 floating point
2237         https://bugs.webkit.org/show_bug.cgi?id=194853
2238
2239         Reviewed by Don Olmstead.
2240
2241         Force SSE2 on x86/32bit builds.
2242
2243         * Scripts/webkitdirs.pm:
2244         (generateBuildSystemFromCMakeProject):
2245
2246 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2247
2248         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2249         https://bugs.webkit.org/show_bug.cgi?id=196073
2250
2251         Reviewed by Michael Catanzaro.
2252
2253         Add test cases to check functions and constructors with no arguments but receiving user data.
2254
2255         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2256         (checkUserData):
2257         (testJSCFunction):
2258         (fooCreateWithUserData):
2259         (testJSCClass):
2260
2261 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2262
2263         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2264
2265         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2266
2267         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2268
2269 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2270
2271         [GTK][WPE] Add API to provide geolocation information
2272         https://bugs.webkit.org/show_bug.cgi?id=195940
2273
2274         Reviewed by Michael Catanzaro.
2275
2276         Add a new test to check the new API.
2277
2278         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2279         (testGeolocationManagerCurrentPosition):
2280         (testGeolocationManagerWatchPosition):
2281         (beforeAll):
2282         (afterAll):
2283         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2284         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2285         (beforeAll): Ditto.
2286         * TestWebKitAPI/glib/CMakeLists.txt:
2287
2288 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2289
2290         [GLib] Returning G_TYPE_OBJECT from a method does not work
2291         https://bugs.webkit.org/show_bug.cgi?id=195574
2292
2293         Reviewed by Michael Catanzaro.
2294
2295         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2296
2297         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2298         (getGFile):
2299         (getParent):
2300         (createGString):
2301         (getGString):
2302         (getGStringCopyWillRaise):
2303         (getGStringCopy):
2304         (getGStringStr):
2305         (getGStringLen):
2306         (freeGString):
2307         (testJSCClass):
2308
2309 2019-03-20  Saam Barati  <sbarati@apple.com>
2310
2311         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2312         https://bugs.webkit.org/show_bug.cgi?id=195721
2313
2314         Reviewed by Filip Pizlo.
2315
2316         * Scripts/run-javascriptcore-tests:
2317
2318 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2319
2320         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2321         https://bugs.webkit.org/show_bug.cgi?id=196049
2322
2323         Reviewed by Tim Horton.
2324
2325         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2326         overflow scrolling in general, so rename it.
2327
2328         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2329
2330 2019-03-20  Daniel Bates  <dabates@apple.com>
2331
2332         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2333         https://bugs.webkit.org/show_bug.cgi?id=196031
2334         <rdar://problem/49078172>
2335
2336         Reviewed by Tim Horton.
2337
2338         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2339         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2340         same code path used when the Done button is pressed to dismiss the <select> picker.
2341
2342         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2343         (TestWebKitAPI::TEST):
2344
2345 2019-03-20  Chris Dumez  <cdumez@apple.com>
2346
2347         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2348         https://bugs.webkit.org/show_bug.cgi?id=196029
2349         <rdar://problem/48954651>
2350
2351         Reviewed by Tim Horton.
2352
2353         Add API test coverage.
2354
2355         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2356
2357 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2358
2359         [ews-build] Improve failure summary string for ApplyPatch step
2360         https://bugs.webkit.org/show_bug.cgi?id=195995
2361
2362         Reviewed by Alexey Proskuryakov.
2363
2364         * BuildSlaveSupport/ews-build/steps.py:
2365         (ApplyPatch.getResultSummary): Override getResultSummary.
2366
2367 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2368
2369         AX: Implement support for new meter ARIA role
2370         https://bugs.webkit.org/show_bug.cgi?id=195966
2371
2372         Reviewed by Chris Fleizach.
2373
2374         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2375         to AXLevelIndicator.
2376
2377         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2378
2379 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2380
2381         [WebAuthN] Implement FIDO AppID extension
2382         https://bugs.webkit.org/show_bug.cgi?id=143491
2383         <rdar://problem/48298273>
2384
2385         Reviewed by Brent Fulgham.
2386
2387         Add a test that covers the new flag of convertToU2fSignCommand.
2388
2389         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2390         (TestWebKitAPI::TEST):
2391         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2392         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2393         (TestWebKitAPI::TEST):
2394
2395 2019-03-19  Keith Rollin  <krollin@apple.com>
2396
2397         Add support for more platforms to generate-xcfilelists
2398         https://bugs.webkit.org/show_bug.cgi?id=195977
2399
2400         Reviewed by Alexey Proskuryakov.
2401
2402         generate-xcfilelists incorrectly complains when involved with building
2403         WebKit for iphonesimulator:
2404
2405             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2406             …
2407             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2408
2409         Address this by teaching generate-xcfilelists about more platforms.
2410
2411         * Scripts/generate-xcfilelists:
2412
2413 2019-03-19  John Wilander  <wilander@apple.com>
2414
2415         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2416         https://bugs.webkit.org/show_bug.cgi?id=195923
2417         <rdar://problem/49001272>
2418
2419         Reviewed by Alex Christensen.
2420
2421         This patch does the following to the TestRunner:
2422         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2423         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2424         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2425
2426         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2427         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2428         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2429         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2430         * WebKitTestRunner/TestController.cpp:
2431         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2432         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2433         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2434         * WebKitTestRunner/TestController.h:
2435         * WebKitTestRunner/TestInvocation.cpp:
2436         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2437
2438 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2439
2440         [CMake] Support more clang and gcc sanitizers
2441         https://bugs.webkit.org/show_bug.cgi?id=195956
2442
2443         Reviewed by Michael Catanzaro.
2444
2445         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2446
2447 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2448
2449         [ews-build] Improve summary for PrintConfiguration step
2450         https://bugs.webkit.org/show_bug.cgi?id=195945
2451
2452         Reviewed by Lucas Forschler.
2453
2454         * BuildSlaveSupport/ews-build/steps.py:
2455         (PrintConfiguration.getResultSummary): Override getResultSummary.
2456
2457 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2458
2459         [ews-build] Improve summary for CheckOutSource step
2460         https://bugs.webkit.org/show_bug.cgi?id=195963
2461
2462         Reviewed by Lucas Forschler.
2463
2464         * BuildSlaveSupport/ews-build/steps.py:
2465         (CheckOutSource.getResultSummary):
2466
2467 2019-03-19  Daniel Bates  <dabates@apple.com>
2468
2469         [iOS] Focus not preserved when switching between tabs
2470         https://bugs.webkit.org/show_bug.cgi?id=195820
2471         <rdar://problem/43614450>
2472
2473         Reviewed by Brent Fulgham.
2474
2475         Add tests to ensure that we restore focus when resigning and becoming first responder.
2476
2477         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2478         (TestWebKitAPI::TEST):
2479
2480 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2481
2482         Make WTFLogChannelState and WTFLogLevel enum classes
2483         https://bugs.webkit.org/show_bug.cgi?id=195904
2484
2485         Reviewed by Eric Carlson.
2486
2487         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2488         (TestWebKitAPI::TEST_F):
2489
2490 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2491
2492         [GStreamer][EME] Backported mssdemux protection data crash fix
2493         https://bugs.webkit.org/show_bug.cgi?id=195918
2494
2495         Reviewed by Philippe Normand.
2496
2497         * gstreamer/jhbuild.modules:
2498         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2499
2500 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2501
2502         Unreviewed, rolling out r243132.
2503
2504         Broke GTK build
2505
2506         Reverted changeset:
2507
2508         "Make WTFLogChannelState and WTFLogLevel enum classes"
2509         https://bugs.webkit.org/show_bug.cgi?id=195904
2510         https://trac.webkit.org/changeset/243132
2511
2512 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2513
2514         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2515
2516         * Scripts/webkitdirs.pm:
2517         (builtDylibPathForName): Adjust the shared library name that's changed
2518         with the API version bump in r243073.
2519
2520 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2521
2522         Make WTFLogChannelState and WTFLogLevel enum classes
2523         https://bugs.webkit.org/show_bug.cgi?id=195904
2524
2525         Reviewed by Eric Carlson.
2526
2527         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2528         (TestWebKitAPI::TEST_F):
2529
2530 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2531
2532         Disable flaky test added in r2431100
2533         https://webkit.org/b/195785
2534
2535         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2536         (TestWebKitAPI::TEST):
2537         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2538
2539 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2540
2541         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2542         https://bugs.webkit.org/show_bug.cgi?id=195916
2543
2544         Reviewed by Tim Horton.
2545
2546         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2547         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2548
2549 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2550
2551         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2552
2553         * Scripts/webkitpy/common/config/contributors.json:
2554
2555 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2556
2557         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2558         https://bugs.webkit.org/show_bug.cgi?id=195785
2559
2560         Reviewed by Geoffrey Garen.
2561
2562         * TestWebKitAPI/TCPServer.cpp: Added.
2563         (TestWebKitAPI::TCPServer::TCPServer):
2564         (TestWebKitAPI::TCPServer::~TCPServer):
2565         (TestWebKitAPI::TCPServer::socketBindListen):
2566         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2567         * TestWebKitAPI/TCPServer.h: Added.
2568         (TestWebKitAPI::TCPServer::port const):
2569         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2570         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2571         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2572         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2573         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2574         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2575         (TestWebKitAPI::respondSlowly):
2576         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2577         (TestWebKitAPI::downloadAtRate):
2578         (TestWebKitAPI::TEST):
2579
2580 2019-03-18  Saam Barati  <sbarati@apple.com>
2581
2582         Add a plan file for JetStream 2
2583         https://bugs.webkit.org/show_bug.cgi?id=190734
2584
2585         Reviewed by Mark Lam.
2586
2587         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2588
2589 2019-03-18  Chris Dumez  <cdumez@apple.com>
2590
2591         Delay WebProcess launch until a load is triggered in a Web view
2592         https://bugs.webkit.org/show_bug.cgi?id=195758
2593         <rdar://problem/48126013>
2594
2595         Reviewed by Geoff Garen.
2596
2597         Add API test coverage. Also update some existing API tests to not expect
2598         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2599
2600         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2601         (TestWebKitAPI::TEST):
2602         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2603         (TestWebKitAPI::TEST):
2604         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2605         (TEST):
2606         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2607         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2608         (TEST):
2609         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2610         (TEST):
2611         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2612
2613 2019-03-18  Xan Lopez  <xan@igalia.com>
2614
2615         [CMake] Prevent potential warning when determining $architecture
2616         https://bugs.webkit.org/show_bug.cgi?id=195891
2617
2618         Reviewed by Michael Catanzaro.
2619
2620         It's possible for generateBuildSystemForCMakeProject to be called
2621         before determineArchitecture() is ever called. This will make the
2622         first eq check with $architecture to be bogus (and print a
2623         warning). Change that to an eq check with architecture(), which
2624         implicitly calls determineArchitecture() if needed, and change all
2625         the other similar cases in the method in the same way to prevent
2626         future bugs like this one.
2627
2628         * Scripts/webkitdirs.pm:
2629         (generateBuildSystemFromCMakeProject):
2630
2631 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2632
2633         [WPE] Tarballs generated with “make dist” cannot build documentation
2634         https://bugs.webkit.org/show_bug.cgi?id=195885
2635
2636         Reviewed by Carlos Garcia Campos.
2637
2638         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2639
2640 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2641
2642         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2643         https://bugs.webkit.org/show_bug.cgi?id=195883
2644
2645         Reviewed by Carlos Garcia Campos.
2646
2647         * gtkdoc/gtkdoc.py:
2648         (GTKDoc._run_command): When commands fail to run, include the full command line for
2649         the program invocation and the output it has generated on the standard error stream.
2650
2651 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2652
2653         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2654         https://bugs.webkit.org/show_bug.cgi?id=195786
2655
2656         Reviewed by Philippe Normand.
2657
2658         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2659         * wpe/jhbuild.modules: Ditto.
2660
2661 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2662
2663         [ews-build] Don't run clean builds on EWS builders
2664         https://bugs.webkit.org/show_bug.cgi?id=195851
2665
2666         Reviewed by Geoffrey Garen.
2667
2668         * BuildSlaveSupport/ews-build/factories.py:
2669
2670 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2671
2672         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2673         https://bugs.webkit.org/show_bug.cgi?id=195849
2674
2675         Reviewed by Chris Dumez.
2676
2677         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2678
2679         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2680         (runWebsiteDataStoreCustomPaths):
2681
2682 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2683
2684         webkitpy: Upload test results
2685         https://bugs.webkit.org/show_bug.cgi?id=195755
2686         <rdar://problem/48896182>
2687
2688         Reviewed by Aakash Jain.
2689
2690         Establish a new format for uploading results that is not tied to layout tests, apply
2691         that format to webkitpy tests.
2692
2693         * Scripts/webkitpy/common/checkout/scm/git.py:
2694         (Git.native_branch): Return what branch the current checkout is on.
2695         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2696         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2697         * Scripts/webkitpy/common/checkout/scm/svn.py:
2698         (SVN.native_branch): Ditto.
2699         * Scripts/webkitpy/common/system/platforminfo.py:
2700         (PlatformInfo.build_version): Return a build version for Mac.
2701         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2702         (MockPlatformInfo.__init__):
2703         (MockPlatformInfo.build_version):
2704         * Scripts/webkitpy/results: Added.
2705         * Scripts/webkitpy/results/__init__.py: Added.
2706         * Scripts/webkitpy/results/options.py: Added.
2707         (upload_options): OptParse list for upload options.
2708         * Scripts/webkitpy/results/upload.py: Added.
2709         (Upload): Class which enforces the upload format expected by the results server.
2710         (Upload.Expectations):
2711         (Upload.create_configuration):
2712         (Upload.create_commit):
2713         (Upload.create_details):
2714         (Upload.create_run_stats):
2715         (Upload.create_test_result):
2716         (Upload.__init__):
2717         (Upload.Encoder): Encode Upload object as json.
2718         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2719         * Scripts/webkitpy/results/upload_unittest.py: Added.
2720         * Scripts/webkitpy/test/main.py:
2721         (Tester._parse_args): Add upload arguments.
2722         (Tester._run_tests): Allow results to be uploaded.
2723         * Scripts/webkitpy/test/runner.py:
2724         (Runner.__init__): Record which tests were run, rather than just counting them.
2725         (Runner.handle):
2726         * Scripts/webkitpy/test/runner_unittest.py:
2727         (RunnerTest.test_run):
2728         * Scripts/webkitpy/thirdparty/__init__.py:
2729         (AutoinstallImportHook.find_module): Add requests auto-install.
2730         (AutoinstallImportHook._install_requests):
2731         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2732         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2733
2734 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2735
2736         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2737         https://bugs.webkit.org/show_bug.cgi?id=195810
2738
2739         Reviewed by Tim Horton.
2740
2741         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2742         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2743         ending certain layout tests.
2744
2745         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2746         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2747         (-[TestRunnerWKWebView dealloc]):
2748         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2749
2750         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2751         helper method when destroying the web view, and when resetting state between tests.
2752
2753         * WebKitTestRunner/ios/TestControllerIOS.mm:
2754         (WTR::TestController::platformResetStateToConsistentValues):
2755
2756         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2757
2758 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2759
2760         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2761         https://bugs.webkit.org/show_bug.cgi?id=190350
2762         <rdar://problem/45089503>
2763
2764         Reviewed by Geoffrey Garen.
2765
2766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2767         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2768         (TEST):
2769         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2770         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2771         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2772         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2773         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2774         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2775         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2776         (runTest):
2777         (createDirectories):
2778         (TEST):
2779         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2780         (TEST):
2781         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2782         (TEST):
2783
2784 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2785
2786         Add support to WebPage for getting the contents as an attributed string.
2787         https://bugs.webkit.org/show_bug.cgi?id=195636
2788         rdar://problem/45055697
2789
2790         Reviewed by Tim Horton.
2791
2792         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2793         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2794
2795 2019-03-15  Chris Dumez  <cdumez@apple.com>
2796
2797         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2798         https://bugs.webkit.org/show_bug.cgi?id=195747
2799
2800         Reviewed by Geoff Garen.
2801
2802         Add API test coverage.
2803
2804         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2805
2806 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2807
2808         Unreviewed, rolling out r242952.
2809
2810         Causing API failures on iOS Simulator
2811
2812         Reverted changeset:
2813
2814         "[PSON] Make sure the WebProcessCache is leverage when
2815         relaunching a process after termination"
2816         https://bugs.webkit.org/show_bug.cgi?id=195747
2817         https://trac.webkit.org/changeset/242952
2818
2819 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2820
2821         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2822         https://bugs.webkit.org/show_bug.cgi?id=195740
2823
2824         Reviewed by Ross Kirsling.
2825
2826         window.open doesn't work for WebKitBrowserWindow because it is not
2827         implemented yet.
2828
2829         1. Implemented createNewPage callback of WKPageUIClient.
2830         2. Changed MainWindow to take a BrowserWindow factory function
2831           instead of BrowserWindowType to be flexible to create
2832           BrowserWindow with extra settings.
2833         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2834           because it is not relevant with MainWindow anymore.
2835
2836         * MiniBrowser/win/Common.cpp:
2837         (parseCommandLine):
2838         * MiniBrowser/win/Common.h:
2839         (CommandLineOptions::CommandLineOptions):
2840         * MiniBrowser/win/MainWindow.cpp:
2841         (MainWindow::MainWindow):
2842         (MainWindow::create):
2843         (MainWindow::init):
2844         (MainWindow::WndProc):
2845         * MiniBrowser/win/MainWindow.h:
2846         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2847         (PrintWebUIDelegate::createWebViewWithRequest):
2848         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2849         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2850         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2851         (WebKitBrowserWindow::updateProxySettings):
2852         (WebKitBrowserWindow::createNewPage):
2853         * MiniBrowser/win/WebKitBrowserWindow.h:
2854         * MiniBrowser/win/WinMain.cpp:
2855         (wWinMain):
2856
2857 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2858
2859         Make it possible to test scrolling tree layer manipulation more easily
2860         https://bugs.webkit.org/show_bug.cgi?id=195780
2861
2862         Reviewed by Tim Horton.
2863         
2864         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2865         cuts off communication of scrolling tree scrolls back to the web process
2866         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2867         allows tests to trigger scrolls which run the scrolling tree layer positioning
2868         logic, but never get another commit from the web process that might mask
2869         scrolling tree bugs.
2870         
2871         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2872         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2873         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2874
2875         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2876         (WTR::UIScriptController::scrollUpdatesDisabled const):
2877         (WTR::UIScriptController::setScrollUpdatesDisabled):
2878         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2879         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2880         (WTR::UIScriptController::scrollUpdatesDisabled const):
2881         (WTR::UIScriptController::setScrollUpdatesDisabled):
2882         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2883         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2884         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2885         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2886         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2887         * WebKitTestRunner/ios/TestControllerIOS.mm:
2888         (WTR::TestController::platformResetStateToConsistentValues):
2889         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2890         (WTR::UIScriptController::scrollUpdatesDisabled const):
2891         (WTR::UIScriptController::setScrollUpdatesDisabled):
2892
2893 2019-03-14  Youenn Fablet  <youenn@apple.com>
2894
2895         Move IDB storage in private browsing mode to NetworkProcess
2896         https://bugs.webkit.org/show_bug.cgi?id=195602
2897
2898         Reviewed by Brady Eidson.
2899
2900         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2901         (TEST):
2902
2903 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2904
2905         [ews-build] Make descriptionDone messages more readable
2906         https://bugs.webkit.org/show_bug.cgi?id=195760
2907
2908         Reviewed by Lucas Forschler.
2909
2910         * BuildSlaveSupport/ews-build/steps.py:
2911         * BuildSlaveSupport/ews-build/steps_unittest.py:
2912
2913 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2914
2915         [ews-build] Generate status-bubble hover-over messages
2916         https://bugs.webkit.org/show_bug.cgi?id=195680
2917
2918         Reviewed by Lucas Forschler.
2919
2920         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2921         (StatusBubble):
2922         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2923         on hover-over.
2924         (StatusBubble._iso_time):
2925         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2926         hover-over message.
2927         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2928
2929 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2930
2931         [ews-app] Gracefully handle the case when state_string is None
2932         https://bugs.webkit.org/show_bug.cgi?id=195753
2933
2934         Reviewed by Lucas Forschler.
2935
2936         * BuildSlaveSupport/ews-app/ews/models/build.py:
2937         * BuildSlaveSupport/ews-app/ews/models/step.py:
2938
2939 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2940
2941         [ews-app] Status bubble display pending for currently running build step
2942         https://bugs.webkit.org/show_bug.cgi?id=195744
2943
2944         Reviewed by Lucas Forschler.
2945
2946         * BuildSlaveSupport/ews-build/events.py:
2947         (Events.stepStarted): If state_string is pending, replace it with step name.
2948
2949 2019-03-14  Chris Dumez  <cdumez@apple.com>
2950
2951         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2952         https://bugs.webkit.org/show_bug.cgi?id=195750
2953
2954         Reviewed by Geoffrey Garen.
2955
2956         Add API test coverage.
2957
2958         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2959         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2960         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2961         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2962
2963 2019-03-14  Chris Dumez  <cdumez@apple.com>
2964
2965         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2966         https://bugs.webkit.org/show_bug.cgi?id=195747
2967
2968         Reviewed by Geoff Garen.
2969
2970         Add API test coverage.
2971
2972         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2973
2974 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2975
2976         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2977         https://bugs.webkit.org/show_bug.cgi?id=195725
2978         <rdar://problem/48545062>
2979
2980         Reviewed by Tim Horton.
2981
2982         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2983         handler is nil.
2984
2985         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2986         (TestWebKitAPI::TEST):
2987
2988 2019-03-13  Sam Weinig  <sam@webkit.org>
2989
2990         Add utility function to allow easy reverse range-based iteration of a container
2991         https://bugs.webkit.org/show_bug.cgi?id=195542
2992
2993         Reviewed by Antti Koivisto.
2994
2995         * TestWebKitAPI/CMakeLists.txt:
2996         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2997         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2998         (TestWebKitAPI::TEST):
2999         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3000
3001 2019-03-13  Chris Dumez  <cdumez@apple.com>
3002
3003         Use a ServiceWorker process per registrable domain
3004         https://bugs.webkit.org/show_bug.cgi?id=195649
3005
3006         Reviewed by Youenn Fablet.
3007
3008         Update API test coverage.
3009
3010         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3011
3012 2019-03-13  Chris Dumez  <cdumez@apple.com>
3013
3014         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3015         https://bugs.webkit.org/show_bug.cgi?id=195684
3016         <rdar://problem/48294714>
3017
3018         Reviewed by Antti Koivisto.
3019
3020         Add API test coverage.
3021
3022         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3023
3024 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3025
3026         [ews-app] Remove unused patch view
3027         https://bugs.webkit.org/show_bug.cgi?id=195669
3028
3029         Reviewed by Lucas Forschler.
3030
3031         * BuildSlaveSupport/ews-app/ews/urls.py:
3032         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3033
3034 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3035
3036         [ews-app] Use Buildbot result code variables
3037         https://bugs.webkit.org/show_bug.cgi?id=195668
3038
3039         Reviewed by Alexey Proskuryakov.
3040
3041         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3042         (Buildbot): Added Buildbot result code variables.
3043         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3044         (StatusBubble._build_bubble): Used Buildbot result code variables.
3045
3046 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3047
3048         [Flatpak] Expand submodule recursively
3049         https://bugs.webkit.org/show_bug.cgi?id=195672
3050
3051         Building WPE with flatpak was impossible without that as it was raising an exception.
3052         Also update wpebackend-fdo to match what is built in jhbuild
3053
3054         Reviewed by Philippe Normand.
3055
3056         * flatpak/flatpakutils.py:
3057         (expand_submodules_recurse):
3058         (expand_manifest):
3059         * flatpak/org.webkit.WPEModules.yaml:
3060
3061 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3062
3063         [ews-app] status bubble should be hidden for certain builds
3064         https://bugs.webkit.org/show_bug.cgi?id=194597
3065
3066         Reviewed by Dewei Zhu.
3067
3068         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3069         (StatusBubble._build_bubble):
3070         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3071         because the patch didn't have relevant changes.
3072         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3073         in production yet.
3074
3075 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3076
3077         [Win] Fix a slew of simple clang-cl warnings.
3078         https://bugs.webkit.org/show_bug.cgi?id=195652
3079
3080         Reviewed by Don Olmstead.
3081
3082         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3083         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3084
3085 2019-03-12  Justin Fan  <justin_fan@apple.com>
3086
3087         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3088         https://bugs.webkit.org/show_bug.cgi?id=195518
3089         <rdar://problem/46322356>
3090
3091         Reviewed by Myles C. Maxfield.
3092
3093         * DumpRenderTree/DerivedSources-input.xcfilelist:
3094         * DumpRenderTree/DerivedSources-output.xcfilelist:
3095
3096 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3097
3098         Unreviewed, rolling out r242825.
3099         https://bugs.webkit.org/show_bug.cgi?id=195648
3100
3101         "Broke webkitpy tests with my change to
3102         lldb_dump_class_layout.py" (Requested by rmorisset on
3103         #webkit).
3104
3105         Reverted changeset:
3106
3107         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3108         classes with suspicious padding"
3109         https://bugs.webkit.org/show_bug.cgi?id=195573
3110         https://trac.webkit.org/changeset/242825
3111
3112 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3113
3114         [ews-build] Show status bubbles while the patch is waiting in queue
3115         https://bugs.webkit.org/show_bug.cgi?id=195618
3116
3117         Reviewed by Lucas Forschler.
3118
3119         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3120         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3121         enabled in initial deployment.
3122         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3123         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3124         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3125         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3126         (StatusBubble._build_bubbles_for_patch):
3127
3128 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3129
3130         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3131         https://bugs.webkit.org/show_bug.cgi?id=195573
3132
3133         Reviewed by Simon Fraser.
3134
3135         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3136
3137         * Scripts/dump-class-layout:
3138         (main):
3139         * lldb/lldb_dump_class_layout.py:
3140         (ClassLayout.__init__):
3141         (ClassLayout._compute_padding_recursive):
3142         (LLDBDebuggerInstance.dump_layout_for_classname):
3143         (LLDBDebuggerInstance):
3144         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3145         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3146
3147 2019-03-12  Chris Dumez  <cdumez@apple.com>
3148
3149         Device Orientation access permission should be denied unless explicitly granted by the client
3150         https://bugs.webkit.org/show_bug.cgi?id=195625
3151
3152         Reviewed by Youenn Fablet.
3153
3154         add API test coverage.
3155
3156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3157         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3158         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3159         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3160         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3161         (runDeviceOrientationTest):
3162         (TEST):
3163         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3164         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3165
3166 2019-03-12  Jer Noble  <jer.noble@apple.com>
3167
3168         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3169         https://bugs.webkit.org/show_bug.cgi?id=195137
3170         <rdar://problem/48810307>
3171
3172         Reviewed by Eric Carlson.
3173
3174         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3175         (TestWebKitAPI::TEST):
3176
3177 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3178
3179         [ews-build] Change urls from uat to production
3180         https://bugs.webkit.org/show_bug.cgi?id=195566
3181
3182         Reviewed by Lucas Forschler.
3183
3184         * BuildSlaveSupport/ews-app/ews/config.py:
3185         * BuildSlaveSupport/ews-build/events.py:
3186         * BuildSlaveSupport/ews-build/steps.py:
3187
3188 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3189
3190         [ews-build] change max_builds for local-worker to 1
3191         https://bugs.webkit.org/show_bug.cgi?id=195568
3192
3193         Reviewed by Lucas Forschler.
3194
3195         * BuildSlaveSupport/ews-build/loadConfig.py:
3196
3197 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3198
3199         Fix the build
3200
3201         * TestRunnerShared/spi/PencilKitTestSPI.h:
3202         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3203
3204 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3205
3206         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3207         https://bugs.webkit.org/show_bug.cgi?id=194131
3208
3209         Reviewed by Michael Catanzaro.
3210
3211         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3212         (uriChanged):
3213         (testUnfinishedSubresourceLoad):
3214         (serverCallback):
3215         (beforeAll):
3216
3217 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3218
3219         WTF::Expected should use std::addressof instead of operator&
3220         https://bugs.webkit.org/show_bug.cgi?id=195604
3221
3222         Reviewed by Myles Maxfield.
3223
3224         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3225         (TestWebKitAPI::Unique::Unique):
3226         (TestWebKitAPI::Unique::operator&):
3227         (TestWebKitAPI::TEST):
3228
3229 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3230
3231         Add Optional to Forward.h.
3232         https://bugs.webkit.org/show_bug.cgi?id=195586
3233
3234         Reviewed by Darin Adler.
3235
3236         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3237         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3238         Remove unnecessary includes from headers.
3239
3240 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3241
3242         Add testing API to hit-test and scroll overflow scrollers
3243         https://bugs.webkit.org/show_bug.cgi?id=195278
3244
3245         Reviewed by Antti Koivisto.
3246         
3247         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3248         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3249         
3250         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3251
3252         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3253         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3254         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3255         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3256         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3257         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3258         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3259         (WTR::enclosingScrollViewIncludingSelf):
3260         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3261
3262 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3263
3264         API test WebKit.RequestTextInputContext fails on iOS
3265         https://bugs.webkit.org/show_bug.cgi?id=195585
3266
3267         Reviewed by Wenson Hsieh and Simon Fraser.
3268
3269         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3270         (applyStyle):
3271         (TEST):
3272         Add a viewport, so that the coordinates match up on iOS.
3273         Scroll by moving the UIScrollView's contentOffset.
3274
3275 2019-03-11  Chris Dumez  <cdumez@apple.com>
3276
3277         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3278         https://bugs.webkit.org/show_bug.cgi?id=195506
3279         <rdar://problem/48733477>
3280
3281         Reviewed by Alex Christensen.
3282
3283         Add API test coverage.
3284
3285         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3286
3287 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3288
3289         Adding myself to contributors.json
3290
3291         Unreviewed, addming myself to contributors.json .
3292
3293         * Scripts/webkitpy/common/config/contributors.json:
3294
3295 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3296
3297         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3298         https://bugs.webkit.org/show_bug.cgi?id=195511
3299         <rdar://problem/44873269>
3300
3301         Reviewed by Darin Adler.
3302
3303         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3304         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3305         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3306         (TEST_F):
3307
3308 2019-03-11  Chris Dumez  <cdumez@apple.com>
3309
3310         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3311         https://bugs.webkit.org/show_bug.cgi?id=195561
3312
3313         Reviewed by Youenn Fablet.
3314
3315         Make sure the JS in the test requests for permission to receive device orientation events.
3316
3317         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3318
3319 2019-03-11  Youenn Fablet  <youenn@apple.com>
3320
3321         Allow storage quota increase by default in WTR
3322         https://bugs.webkit.org/show_bug.cgi?id=195541
3323
3324         Reviewed by Geoffrey Garen.
3325
3326         Allow storage quota increase by default in WTR.
3327         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3328         Use this for tests that explicitly need cache increase.
3329
3330         Instead of increasing quota by 2, make sure the next request is
3331         granted by adding all given parameters.
3332
3333         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3334         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3335         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3336         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3337         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3338         * WebKitTestRunner/TestController.cpp:
3339         (WTR::TestController::setAllowStorageQuotaIncrease):
3340         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3341         * WebKitTestRunner/TestController.h:
3342         * WebKitTestRunner/TestInvocation.cpp:
3343         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3344         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3345         (WTR::TestController::cocoaResetStateToConsistentValues):
3346         (WTR::TestController::setAllowStorageQuotaIncrease):
3347         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3348         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3349         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3350
3351 2019-03-11  Xan Lopez  <xan@igalia.com>
3352
3353         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3354         https://bugs.webkit.org/show_bug.cgi?id=194147
3355
3356         Reviewed by Michael Saboff.
3357
3358         To make --32-bit work correctly on Linux/64bit we need to:
3359
3360         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3361         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3362         unfortunately CMake only allows us to do this during
3363         crosscompilation, which is overkill here.
3364         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3365         pkg-config detection module uses the x86 .pc files instead of the
3366         x86_64 ones.
3367         - Set the -m32 flags for the compiler.
3368
3369         * Scripts/webkitdirs.pm:
3370         (generateBuildSystemFromCMakeProject):
3371
3372 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3373
3374         Add MotionMark-1.1 plan file for run-benchmark script.
3375         https://bugs.webkit.org/show_bug.cgi?id=195481
3376
3377         Rubber-stamped by Darin Adler.
3378
3379         Run-benchmark script should support MontionMark-1.1.
3380
3381         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3382
3383 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3384
3385         [ews-app] Add support for submit-to-ews url
3386         https://bugs.webkit.org/show_bug.cgi?id=195477
3387
3388         Reviewed by Lucas Forschler.
3389
3390         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3391         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3392         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3393         * BuildSlaveSupport/ews-app/ews/urls.py:
3394         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3395
3396 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3397
3398         Unreviewed, rolling out r242688, r242643, r242624.
3399
3400         Caused multiple layout test failures and crashes on iOS and macOS.
3401
3402         Reverted changeset:
3403
3404         "requestAnimationFrame should execute before the next frame"
3405         https://bugs.webkit.org/show_bug.cgi?id=177484
3406         https://trac.webkit.org/changeset/242624/webkit
3407
3408         * Tracing/SystemTracePoints.plist:
3409
3410 2019-03-11  John Wilander  <wilander@apple.com>
3411
3412         Resource Load Statistics: Make it possible exclude localhost from classification
3413         https://bugs.webkit.org/show_bug.cgi?id=195474
3414         <rdar://problem/47520577>
3415
3416         Reviewed by Brent Fulgham.
3417
3418         This patch allows for localhost to be excluded from classification and
3419         treatment as a prevalent resource.
3420
3421         The WebKit Tools change adds a new function called
3422         testRunner.setStatisticsIsRunningTest() which can be used to control this
3423         behavior.
3424
3425         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3426         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3427         (WTR::TestRunner::setStatisticsIsRunningTest):
3428         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3429         * WebKitTestRunner/TestController.cpp:
3430         (WTR::TestController::setStatisticsIsRunningTest):
3431         * WebKitTestRunner/TestController.h:
3432         * WebKitTestRunner/TestInvocation.cpp:
3433         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3434
3435 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3436
3437         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3438         https://bugs.webkit.org/show_bug.cgi?id=195560
3439
3440         Reviewed by Lucas Forschler.
3441
3442         * BuildSlaveSupport/ews-build/master.cfg:
3443
3444 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3445
3446         Unreviewed, rolling out r242698.
3447
3448         API test crashes on bots.
3449
3450         Reverted changeset:
3451
3452         "Add a WKContentRuleList variant that uses copied memory
3453         instead of mmap'd shared memory for class A containerized
3454         apps"
3455         https://bugs.webkit.org/show_bug.cgi?id=195511
3456         https://trac.webkit.org/changeset/242698
3457
3458 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3459
3460         [WPE] Enable web process sandbox
3461         https://bugs.webkit.org/show_bug.cgi?id=195169
3462
3463         Reviewed by Daniel Bates.
3464
3465         * wpe/install-dependencies:
3466         * wpe/jhbuild.modules:
3467
3468 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3469
3470         [ews-app] Use port 17000 for worker communication
3471         https://bugs.webkit.org/show_bug.cgi?id=195558
3472
3473         Reviewed by Lucas Forschler.
3474
3475         * BuildSlaveSupport/ews-build/master.cfg:
3476
3477 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3478
3479         [ews-build] unit-tests fail when passwords.json is missing
3480         https://bugs.webkit.org/show_bug.cgi?id=195557
3481
3482         Reviewed by Lucas Forschler.
3483
3484         * BuildSlaveSupport/ews-build/loadConfig.py:
3485         (loadBuilderConfig):
3486         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3487         (ConfigDotJSONTest.test_configuration):
3488         * BuildSlaveSupport/ews-build/master.cfg:
3489
3490 2019-03-11  Truitt Savell  <tsavell@apple.com>
3491
3492         Unreviewed, rolling out r242702.
3493
3494         Broke High Sierra builders.
3495
3496         Reverted changeset:
3497
3498         "Add utility function to allow easy reverse range-based
3499         iteration of a container"
3500         https://bugs.webkit.org/show_bug.cgi?id=195542
3501         https://trac.webkit.org/changeset/242702
3502
3503 2019-03-11  Sam Weinig  <sam@webkit.org>
3504
3505         Add utility function to allow easy reverse range-based iteration of a container
3506         https://bugs.webkit.org/show_bug.cgi?id=195542
3507
3508         Reviewed by Antti Koivisto.
3509
3510         * TestWebKitAPI/CMakeLists.txt:
3511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3512         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3513         (TestWebKitAPI::TEST):
3514         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3515
3516 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3517
3518         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3519         https://bugs.webkit.org/show_bug.cgi?id=195511
3520         <rdar://problem/44873269>
3521
3522         Reviewed by Darin Adler.
3523
3524         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3525         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3526         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3527         (TEST_F):
3528
3529 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3530
3531         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3532         https://bugs.webkit.org/show_bug.cgi?id=195499
3533
3534         Reviewed by Darin Adler.
3535
3536         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3537         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3538         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3539         (-[WKWebView synchronouslyFocusTextInputContext:]):
3540         (applyStyle):
3541         (applyIframe):
3542         (TEST):
3543         Add some tests for this SPI.
3544
3545 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3546
3547         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3548         https://bugs.webkit.org/show_bug.cgi?id=181151
3549
3550         Reviewed by Don Olmstead.
3551
3552         * TestWebKitAPI/CMakeLists.txt:
3553         * TestWebKitAPI/PlatformWin.cmake:
3554         Enable TestWTF RunLoop tests in all platforms.
3555
3556         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3557         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3558         (TestWebKitAPI::DerivedOneShotTimer::fired):
3559         (TestWebKitAPI::TEST):
3560         Only a few platforms support nested RunLoop.
3561
3562         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3563         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3564
3565 2019-03-10  David Quesada  <david_quesada@apple.com>
3566
3567         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3568         https://bugs.webkit.org/show_bug.cgi?id=152480
3569
3570         Reviewed by Chris Dumez.
3571
3572         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3573         there are no additional references to the process pool besides the one held by
3574         the download, waits for the download to finish (in the sense that the
3575         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3576         measure, also check that the process pool has been deallocated at the end of the
3577         test. The test wouldn't be meaningful if the process pool were still alive.
3578
3579         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3580         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3581         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3582             The download will be canceled because the delegate does not implement the
3583             method to decide the download's destination, so this is where we know the
3584             DownloadProxyMap is done with the DownloadProxy.
3585         (TEST):
3586
3587 2019-03-08  Chris Dumez  <cdumez@apple.com>
3588
3589         Add support for Device Orientation / Motion permission API
3590         https://bugs.webkit.org/show_bug.cgi?id=195329
3591         <rdar://problem/47645367>
3592
3593         Reviewed by Geoffrey Garen.
3594
3595         Add test infrastructure to help test the Device Orientation / Motion permission API.
3596
3597         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3598         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3599         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3600         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3601         * WebKitTestRunner/TestController.cpp:
3602         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3603         (WTR::TestController::createWebViewWithOptions):
3604         (WTR::TestController::resetStateToConsistentValues):
3605         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3606         * WebKitTestRunner/TestController.h:
3607         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3608         * WebKitTestRunner/TestInvocation.cpp:
3609         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3610
3611 2019-03-08  Saam barati  <sbarati@apple.com>
3612
3613         Add a compare-results script to compare benchmark results
3614         https://bugs.webkit.org/show_bug.cgi?id=195486
3615         <rdar://problem/48723397>
3616
3617         Reviewed by Geoffrey Garen.
3618
3619         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3620         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3621         to extend it to learn about our other benchmarks.
3622
3623         * Scripts/compare-results: Added.
3624         (readJSONFile):
3625         (detectJetStream2):
3626         (JetStream2Results):
3627         (detectSpeedometer2):
3628         (Speedometer2Results):
3629         (detectPLT5):
3630         (PLT5Results):
3631         (detectBenchmark):
3632         (biggerIsBetter):
3633         (ttest):
3634         (getOptions):
3635         (main):
3636
3637 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3638
3639         Ensure old tab state is cleared between iterations of run-benchmark
3640         https://bugs.webkit.org/show_bug.cgi?id=195393
3641         <rdar://problem/46885583>
3642
3643         Reviewed by Dewei Zhu.
3644
3645         a) ensure the default to restore state is not set
3646         b) terminate Safari correctly
3647         c) Set the system default to ignore Persistent State in Safari
3648
3649         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3650         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3651         (OSXBrowserDriver.prepare_env): 
3652         (OSXBrowserDriver.restore_env):
3653         (OSXBrowserDriver.close_browsers):
3654         (OSXBrowserDriver._terminate_processes):
3655         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3656         (OSXChromeDriver):
3657         (OSXChromeCanaryDriver):
3658         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3659         (OSXFirefoxDriver):
3660         (OSXFirefoxNightlyDriver):
3661         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3662         (OSXSafariDriver):
3663         (OSXSafariDriver.prepare_env):
3664
3665 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3666
3667         [GTK] Several InputMethodFilter tests are failing
3668         https://bugs.webkit.org/show_bug.cgi?id=195408
3669
3670         Reviewed by Carlos Garcia Campos.
3671
3672         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3673         Regressed in r241751.
3674         Hexadecimal values of keycodes are expressed now in upper letters.
3675         Composited characters should be cast to UTF8 strings.
3676
3677         (TestWebKitAPI::TEST):
3678
3679 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3680
3681         [GTK] Make Tools/gtkdoc python3 compatible
3682         https://bugs.webkit.org/show_bug.cgi?id=195359
3683
3684         Reviewed by Carlos Garcia Campos.
3685
3686         * gtkdoc/generate-gtkdoc:
3687         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3688         work with Python 2 and 3.
3689         (get_gtkdoc_module_paths):
3690         The iteritems() was removed in Python 3, so let's use items() that's
3691         available in Python 2 and 3.
3692         (get_generator_for_config):
3693         * gtkdoc/gtkdoc.py:
3694         (GTKDoc._run_command):
3695         The sys.stdout.write() is expecting str in Python 3 and not bytes
3696         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3697         for passing the bytes there.
3698
3699 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3700
3701         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3702         https://bugs.webkit.org/show_bug.cgi?id=195346
3703         <rdar://problem/48667048>
3704
3705         Unreviewed build fix for clang-cl.
3706
3707         * DumpRenderTree/win/DumpRenderTree.cpp:
3708         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3709
3710 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3711
3712         requestAnimationFrame should execute before the next frame
3713         https://bugs.webkit.org/show_bug.cgi?id=177484
3714
3715         Reviewed by Simon Fraser.
3716
3717         Add trace points for the page RenderingUpdate.
3718
3719         * Tracing/SystemTracePoints.plist:
3720
3721 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3722
3723         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3724         https://bugs.webkit.org/show_bug.cgi?id=195353
3725         <rdar://problem/48626394>
3726
3727         Reviewed by Simon Fraser.
3728
3729         * WebKitTestRunner/ios/TestControllerIOS.mm:
3730         (WTR::TestController::platformResetPreferencesToConsistentValues):
3731
3732 2019-03-07  John Wilander  <wilander@apple.com>
3733
3734         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3735         https://bugs.webkit.org/show_bug.cgi?id=195383
3736         <rdar://problem/48570136>
3737
3738         Reviewed by Brent Fulgham.
3739
3740         This patch adds test infrastructure to purge only script-accessible cookies,
3741         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3742
3743         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3744         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3745         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3746         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3747         * WebKitTestRunner/TestController.cpp:
3748         (WTR::TestController::statisticsDeleteCookiesForHost):
3749         * WebKitTestRunner/TestController.h:
3750         * WebKitTestRunner/TestInvocation.cpp:
3751         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3752
3753 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3754
3755         Unreviewed, rolling out r242354.
3756         https://bugs.webkit.org/show_bug.cgi?id=195402
3757
3758         breaks layout tests in all configurations (Requested by
3759         zdobersek on #webkit).
3760
3761         Reverted changeset:
3762
3763         "[WPE] Enable web process sandbox"
3764         https://bugs.webkit.org/show_bug.cgi?id=195169
3765         https://trac.webkit.org/changeset/242354
3766
3767 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3768
3769         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3770         https://bugs.webkit.org/show_bug.cgi?id=195346
3771
3772         Reviewed by Fujii Hironori.
3773
3774         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3775         (TestWebKitAPI::TEST):
3776         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3777
3778         * DumpRenderTree/win/DumpRenderTree.cpp:
3779         (findFontFallback):
3780         (addFontFallbackIfPresent):
3781         (removeFontFallbackIfPresent):
3782         (main):
3783         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3784         (TestWebKitAPI::Util::moduleDirectory):
3785         (TestWebKitAPI::Util::createInjectedBundlePath):
3786         Use wchar helpers as needed.
3787
3788 2019-03-06  Rob Buis  <rbuis@igalia.com>
3789
3790         Consider supporting the `referrerpolicy` attribute.
3791         https://bugs.webkit.org/show_bug.cgi?id=179053
3792
3793         Reviewed by Darin Adler.
3794
3795         Add a runtime flag for referrerpolicy attribute.
3796
3797         * DumpRenderTree/mac/DumpRenderTree.mm:
3798         (enableExperimentalFeatures):
3799
3800 2019-03-05  Daniel Bates  <dabates@apple.com>
3801
3802         Update expected API test result following r242379
3803         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3804
3805         Update expected x-coordinate of selection rect now that the left padding of
3806         a textarea is sized in ems (so dependent on the font size) just like the left
3807         padding of a text field.
3808
3809         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3810         (TestWebKitAPI::TEST):
3811
3812 2019-03-05  David Quesada  <david_quesada@apple.com>
3813
3814         [WK2] It should be possible to follow links with 'download' attributes
3815         https://bugs.webkit.org/show_bug.cgi?id=195145
3816         rdar://problem/48462642
3817
3818         Reviewed by Alex Christensen.
3819
3820         Add a unit test to verify that activating links with 'download' attributes now
3821         navigates to the linked resource, rather than starts downloading it. Add another
3822         to verify that it is still possible to explicitly download the link via the
3823         'Download' navigation action policy.
3824
3825         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3826         (-[DownloadAttributeTestDelegate init]):
3827         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3828         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3829         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3830         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3831         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3832         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3833         (TEST):
3834         * WebKitTestRunner/TestController.cpp:
3835         (WTR::TestController::decidePolicyForNavigationAction):
3836         * WebKitTestRunner/TestController.h:
3837
3838 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3839
3840         [Curl] Implement Cookie Accept Policy.
3841         https://bugs.webkit.org/show_bug.cgi?id=191645
3842
3843         Reviewed by Fujii Hironori.
3844
3845         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3846         (TestWebKitAPI::Curl::TEST_F):
3847
3848 2019-03-05  Youenn Fablet  <youenn@apple.com>
3849
3850         Rename requestCacheStorageSpace to requestStorageSpace
3851         https://bugs.webkit.org/show_bug.cgi?id=195282
3852
3853         Reviewed by Chris Dumez.
3854
3855         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3856         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3857         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3858
3859 2019-03-05  Brady Eidson  <beidson@apple.com>
3860
3861         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3862         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3863
3864         Reviewed by Tim Horton.
3865
3866         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3867         different directory into that same WKWebView should work.
3868
3869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3870         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3871
3872 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3873
3874         Add WeakHashSet
3875         https://bugs.webkit.org/show_bug.cgi?id=195152
3876
3877         Reviewed by Antti Koivisto.
3878
3879         Added tests for WeakHashSet.
3880
3881         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3882         (TestWebKitAPI::Base::Base): Moved.
3883         (TestWebKitAPI::Derived::foo): Moved.
3884         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3885         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3886         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3887         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3888
3889 2019-03-04  Chris Dumez  <cdumez@apple.com>
3890
3891         Do not share WebProcesses between private and regular sessions
3892         https://bugs.webkit.org/show_bug.cgi?id=195189
3893         <rdar://problem/48421064>
3894
3895         Reviewed by Alex Christensen.
3896
3897         Add API test coverage.
3898
3899         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3900         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3901
3902 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3903
3904         [WPE] Enable web process sandbox
3905         https://bugs.webkit.org/show_bug.cgi?id=195169
3906
3907         Reviewed by Daniel Bates.
3908
3909         * wpe/install-dependencies:
3910         * wpe/jhbuild.modules:
3911
3912 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3913
3914         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3915         https://bugs.webkit.org/show_bug.cgi?id=195206
3916
3917         Reviewed by Žan Doberšek.
3918
3919         Add a new test case.
3920
3921         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3922         (testJSCClass):
3923
3924 2019-03-04  Charlie Turner  <cturner@igalia.com>
3925
3926         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3927         https://bugs.webkit.org/show_bug.cgi?id=194898
3928
3929         Reviewed by Žan Doberšek.
3930
3931         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3932         a GCC extension that permits arithmetic on void* pointer. Inline
3933         the macro until this issue is fixed upstream.
3934
3935 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3936
3937         Rid the world of WK_API_ENABLED
3938         https://bugs.webkit.org/show_bug.cgi?id=195263
3939
3940         Reviewed by Dan Bernstein.
3941
3942         List of changed files elided because it's useless.
3943
3944 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3945
3946         Unreviewed follow-up to r242292.
3947
3948         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3949
3950         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3951         (TestWebKitAPI::testStrip): Renamed from strip.
3952         (TestWebKitAPI::TEST):
3953
3954 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3955
3956         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3957
3958         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3959         and bug #194272 for details.
3960
3961         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3962
3963 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3964
3965         Remove some more unused 32-bit code
3966         https://bugs.webkit.org/show_bug.cgi?id=195255
3967
3968         Reviewed by Darin Adler.
3969
3970         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3971         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3972         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3973         (NPP_New):
3974         (NPP_HandleEvent):
3975         (handleEventCarbon): Deleted.
3976
3977 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3978
3979         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3980
3981         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3982         (TestWebKitAPI::TEST):
3983
3984 2019-03-01  Darin Adler  <darin@apple.com>
3985
3986         Finish removing String::format
3987         https://bugs.webkit.org/show_bug.cgi?id=194893
3988
3989         Reviewed by Daniel Bates.
3990 '
3991         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3992
3993 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3994
3995         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3996         https://bugs.webkit.org/show_bug.cgi?id=195229
3997         <rdar://problem/48520362>
3998
3999         Reviewed by Chris Dumez.
4000
4001         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4002         (TEST):
4003
4004 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4005
4006         Add a system trace scope for event region building
4007         https://bugs.webkit.org/show_bug.cgi?id=195226
4008
4009         Reviewed by Jon Lee.
4010
4011         This trace scope measures the time spend converting element rects into Region objects,
4012         which can be large on some pages.
4013
4014         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4015
4016         * Tracing/SystemTracePoints.plist:
4017
4018 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4019
4020         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4021         https://bugs.webkit.org/show_bug.cgi?id=194612
4022
4023         Reviewed by Alex Christensen.
4024
4025         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4026         Just test the new string-processing function and don't touch the actual environment.
4027         (Test cases are all as before, but based on operator== instead of strcmp.)
4028
4029 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4030
4031         [ews-app] Update primary keys for handling multiple Buildbot instances
4032         https://bugs.webkit.org/show_bug.cgi?id=195120
4033
4034         Reviewed by Stephanie Lewis.
4035
4036         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4037         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4038         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4039
4040         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4041         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4042         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4043         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4044         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4045         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4046
4047 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4048
4049         [WinCairo] Enable service worker
4050         https://bugs.webkit.org/show_bug.cgi?id=188318
4051
4052         Reviewed by Youenn Fablet.
4053
4054         * DumpRenderTree/DumpRenderTreePrefix.h:
4055         * TestWebKitAPI/PlatformWin.cmake:
4056         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4057         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4058         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4059
4060 2019-03-01  Justin Fan  <justin_fan@apple.com>
4061
4062         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4063         https://bugs.webkit.org/show_bug.cgi?id=195191
4064
4065         Rubber-stamped by Dean Jackson.
4066
4067         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4068
4069         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4070
4071 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4072
4073         Unreviewed, fix lldb webkitpy tests
4074         https://bugs.webkit.org/show_bug.cgi?id=194375
4075
4076         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4077
4078         * lldb/lldb_webkit.py:
4079         (WTFStringImplProvider.is_8bit):
4080
4081 2019-02-28  David Quesada  <david_quesada@apple.com>
4082
4083         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4084         https://bugs.webkit.org/show_bug.cgi?id=195121
4085         rdar://problem/48450302
4086
4087         Reviewed by Alex Christensen.
4088
4089         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4090         configurations where the 'download' attribute is absent, blank, or populated
4091         with a filename, and where the anchor element is same-origin or cross-origin
4092         (meaning the 'download' attribute shouldn't be honored).
4093
4094         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4095         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4096         (-[NavigationActionTestDelegate init]):
4097         (-[NavigationActionTestDelegate navigationAction]):
4098         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4099         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4100         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4101         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4102         (TEST):
4103
4104 2019-02-28  Antoine Quint  <graouts@apple.com>
4105
4106         Enable the Pointer Events runtime flag by default
4107         https://bugs.webkit.org/show_bug.cgi?id=195156
4108
4109         Reviewed by Dean Jackson.
4110
4111         * DumpRenderTree/mac/DumpRenderTree.mm:
4112         (enableExperimentalFeatures):
4113
4114 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4115
4116         Several PasteImage API tests are flaky
4117         https://bugs.webkit.org/show_bug.cgi?id=195160
4118
4119         Reviewed by Tim Horton.
4120
4121         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4122         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4123         listening for a "load" event after image load is already complete.
4124
4125         To address this, make these tests first register a "load" event handler, then run script to insert an image
4126         element into the document, and finally wait until the load event is observed before checking image size.
4127
4128         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4129
4130 2019-02-28  Chris Dumez  <cdumez@apple.com>
4131
4132         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4133         https://bugs.webkit.org/show_bug.cgi?id=195107
4134
4135         Reviewed by Alex Christensen.
4136
4137         Give some time for the zoom level to get restored.
4138
4139         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4140
4141 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4142
4143         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4144         https://bugs.webkit.org/show_bug.cgi?id=194958
4145
4146         Reviewed by Geoffrey Garen.
4147
4148         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4149         (TEST):
4150
4151 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4152
4153         [ews-app] Update method to save build to handle builder_display_name
4154         https://bugs.webkit.org/show_bug.cgi?id=195047
4155
4156         Reviewed by Dewei Zhu.
4157
4158         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4159         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4160
4161 2019-02-28  Justin Fan  <justin_fan@apple.com>
4162
4163         [Web GPU] Enable Web GPU only on 64-bit
4164         https://bugs.webkit.org/show_bug.cgi?id=195139
4165
4166         Because Metal is only supported on 64 bit apps.
4167
4168         Unreviewed build fix.
4169
4170         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4171
4172 2019-02-27  Youenn Fablet  <youenn@apple.com>
4173
4174         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4175         https://bugs.webkit.org/show_bug.cgi?id=194959
4176
4177         Reviewed by Chris Dumez.
4178
4179         Spin loop until getting the condition to remove flakiness.
4180
4181         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4182
4183 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4184
4185         [ews-build] Buildbot should include builder_display_name in the build events
4186         https://bugs.webkit.org/show_bug.cgi?id=195045
4187
4188         Reviewed by Dewei Zhu.
4189
4190         * BuildSlaveSupport/ews-build/events.py:
4191         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4192         buildername to builder_name to be consistent in naming style.
4193         (Events.buildFinished): Ditto.
4194
4195 2019-02-27  Chris Dumez  <cdumez@apple.com>
4196
4197         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4198         https://bugs.webkit.org/show_bug.cgi?id=194480
4199
4200         Reviewed by Brady Eidson.
4201
4202         Update existing API test to make it more likely to reproduce the issue.
4203
4204         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4205
4206 2019-02-27  Brady Eidson  <beidson@apple.com>
4207
4208         Universal links from Google search results pages don't open the app.
4209         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4210
4211         Reviewed by Geoffrey Garen.
4212
4213         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4214         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4215         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4216         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4217
4218 2019-02-27  Chris Dumez  <cdumez@apple.com>
4219
4220         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4221         https://bugs.webkit.org/show_bug.cgi?id=195102
4222
4223         Reviewed by Geoffrey Garen.
4224
4225         If the number of processes is not yet what we expect, wait a bit and check again to give
4226         processes some time to exit.
4227
4228         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4229
4230 2019-02-27  Chris Dumez  <cdumez@apple.com>
4231
4232         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4233         https://bugs.webkit.org/show_bug.cgi?id=194545
4234
4235         Reviewed by Brady Eidson.
4236
4237         Make sure the test navigates forward and then back only once. Previously, navigating
4238         back would trigger a navigation again in a timer.
4239
4240         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4241
4242 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4243
4244         High Sierra Debug JSC test queue should use faster hardware
4245         https://bugs.webkit.org/show_bug.cgi?id=194603
4246
4247         Rubber-stamped by Alexey Proskuryakov.
4248
4249         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4250
4251         * BuildSlaveSupport/build.webkit.org-config/config.json:
4252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4253         (BubbleQueueServer):
4254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4255         (WebKitBuildbot):
4256         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4257         * QueueStatusServer/config/queues.py:
4258         * Scripts/webkitpy/common/config/ews.json:
4259         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4260         (test_ews_name):
4261
4262 2019-02-27  John Wilander  <wilander@apple.com>
4263
4264         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4265         https://bugs.webkit.org/show_bug.cgi?id=195071
4266         <rdar://problem/48417690>
4267
4268         Reviewed by Alex Christensen and Brent Fulgham.
4269
4270         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4271         (TestWebKitAPI::createURL):
4272             Convenience function.
4273         (TestWebKitAPI::TEST):
4274             WebCore::AdClickAttribution now takes a URL when creating Source and
4275             Destination.
4276         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4277         (TestWebKitAPI::TEST):
4278             WebCore::AdClickAttribution now takes a URL when creating Source and
4279             Destination.
4280
4281 2019-02-27  Antoine Quint  <graouts@apple.com>
4282
4283         Support Pointer Events on macOS
4284         https://bugs.webkit.org/show_bug.cgi?id=195008
4285         <rdar://problem/47454419>
4286
4287         Reviewed by Dean Jackson.
4288
4289         * DumpRenderTree/mac/DumpRenderTree.mm:
4290         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4291         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4292
4293 2019-02-26  Mark Lam  <mark.lam@apple.com>
4294
4295         Remove remaining poisoning code.
4296         https://bugs.webkit.org/show_bug.cgi?id=194138
4297
4298         Reviewed by Saam Barati.
4299
4300         * TestWebKitAPI/CMakeLists.txt:
4301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4302         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4303         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4304         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4305         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4306         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4307         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4308
4309 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4310
4311         Move ephemeral local storage from WebProcess to UIProcess
4312         https://bugs.webkit.org/show_bug.cgi?id=195074
4313         <rdar://problem/47937975>
4314
4315         Reviewed by Geoff Garen.
4316
4317         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4318
4319 2019-02-20  Jer Noble  <jer.noble@apple.com>
4320
4321         [Cocoa] Media elements will restart network buffering just before suspending
4322         https://bugs.webkit.org/show_bug.cgi?id=193691
4323
4324         Reviewed by Eric Carlson.
4325
4326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4327         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4328         (TEST):
4329
4330 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4331
4332         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4333         https://bugs.webkit.org/show_bug.cgi?id=191652
4334
4335         Reviewed by Alex Christensen.
4336
4337         Fix WinCairo MiniBrowser behavior of authentication dialog.
4338
4339         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4340         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4341
4342 2019-02-26  Youenn Fablet  <youenn@apple.com>
4343
4344         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4345         https://bugs.webkit.org/show_bug.cgi?id=195028
4346         <rdar://problem/48243733>
4347
4348         Reviewed by Eric Carlson.
4349
4350         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4351
4352 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4353
4354         [WPE] Add API for webview background color configuration
4355         https://bugs.webkit.org/show_bug.cgi?id=192305
4356
4357         Reviewed by Michael Catanzaro.
4358
4359         * MiniBrowser/wpe/main.cpp:
4360         (main): Add a new option to configure the webview background
4361         color. Example: --bg-color=transparent.
4362         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4363         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4364         (beforeAll): Ditto.
4365
4366 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4367
4368         scalableNativeWebpageParameters() is not preserved on new page navigation.
4369         https://bugs.webkit.org/show_bug.cgi?id=194892
4370         <rdar://problem/47538280>
4371
4372         Reviewed by Wenson Hsieh.
4373