Unreviewed.
[WebKit-https.git] / Tools / ChangeLog
1 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2
3         Unreviewed.
4
5         Added imported tests to Streams API watchlist.
6
7         * Scripts/webkitpy/common/config/watchlist:
8
9 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
10
11         Remove default copy of wpt testharness.js when launching wpt server
12         https://bugs.webkit.org/show_bug.cgi?id=152298
13
14         Reviewed by Darin Adler.
15
16         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
17         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
18
19 2015-12-15  David Kilzer  <ddkilzer@apple.com>
20
21         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
22         <http://webkit.org/b/152314>
23
24         Reviewed by Daniel Bates.
25
26         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
27         code path to exit immediately when calling main().
28         Unfortunately, DumpRenderTreeMain.mm was used for both
29         DumpRenderTree command-line binary and DumpRenderTree.app, which
30         meant that the app would exit immediately with no error code
31         when run!
32
33         The workaround is to introduce a separate source file called
34         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
35         already does.
36
37         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
38         DumpRenderTreeAppMain.mm to the project.  Make it the only
39         compiled source for the DumpRenderTree.app target.
40         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
41         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
42         case someone tries mistakenly to use the app.
43         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
44         Link to JavaScriptCore.framework on iOS for the assert.
45         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
46         Link to JavaScriptCore.framework on OS X for the assert.  Remove
47         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
48         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
49         (main): Add assert for iOS so that a crash occurs if someone
50         tries to run the wrong command.
51
52 2015-12-14  Tim Horton  <timothy_horton@apple.com>
53
54         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
55         https://bugs.webkit.org/show_bug.cgi?id=152266
56         <rdar://problem/22092676>
57
58         Reviewed by Simon Fraser.
59
60         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
61         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
62         Add a test that crashed before this change, and doesn't crash after.
63
64 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
65
66         AX: iOS: Text field variations do not have the correct traits
67         https://bugs.webkit.org/show_bug.cgi?id=152237
68
69         Reviewed by Mario Sanchez Prada.
70
71         Add iOS calls for determing if an object is a search field or a text area.
72
73         * DumpRenderTree/AccessibilityUIElement.cpp:
74         (getIsSearchFieldCallback):
75         (getIsTextAreaCallback):
76         (stringForSelectionCallback):
77         (AccessibilityUIElement::getJSClass):
78         * DumpRenderTree/AccessibilityUIElement.h:
79         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
80         (AccessibilityUIElement::identifier):
81         (AccessibilityUIElement::isTextArea):
82         (AccessibilityUIElement::isSearchField):
83         (AccessibilityUIElement::traits):
84         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
85         (WTR::AccessibilityUIElement::scrollPageRight):
86         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
87         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
88         (WTR::AccessibilityUIElement::isSearchField):
89         (WTR::AccessibilityUIElement::isTextArea):
90         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
91         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
92         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
93         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
94         (WTR::AccessibilityUIElement::isTextArea):
95         (WTR::AccessibilityUIElement::isSearchField):
96         (WTR::AccessibilityUIElement::rowCount):
97
98 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
99
100         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
101         https://bugs.webkit.org/show_bug.cgi?id=152252
102
103         Reviewed by Sergio Villar Senin.
104
105         * gtk/install-dependencies: Add libtool-bin to the list of packages required
106         for building the JHBuild on Debian systems.
107
108 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
109
110         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
111         https://bugs.webkit.org/show_bug.cgi?id=152156
112
113         Reviewed by Dan Bernstein.
114
115         Our frameworks should appropriately prefix all ObjC classes,
116         not just external symbols.
117
118         * Scripts/check-for-inappropriate-objc-class-names:
119         Remove the -g switch to check all ObjC class names.
120
121 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
122
123         [MediaStream] Expose media capture devices persistent permissions to WebCore
124         https://bugs.webkit.org/show_bug.cgi?id=152087
125
126         Add support for the new user media permission checker page UI client method.
127
128         Reviewed by Chris Dumez.
129
130         * WebKitTestRunner/TestController.cpp:
131         (WTR::decidePolicyForUserMediaPermissionRequest):
132         (WTR::checkUserMediaPermissionForOrigin):
133         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
134         (WTR::TestController::createWebViewWithOptions): Ditto.
135         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
136         (WTR::originUserVisibleName): New, create a string for the origin.
137         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
138           according to the state of the origin permission map.
139         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
140           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
141         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
142           origin permission map.
143         * WebKitTestRunner/TestController.h:
144
145 2015-12-10  Alex Christensen  <achristensen@webkit.org>
146
147         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
148         https://bugs.webkit.org/show_bug.cgi?id=152022
149         rdar://problem/23763584
150
151         Reviewed by Darin Adler.
152
153         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
154         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
155         (WTR::InjectedBundlePage::willSendRequestForFrame):
156         * WebKitTestRunner/InjectedBundle/TestRunner.h:
157         (WTR::TestRunner::setWillSendRequestReturnsNull):
158         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
159         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
160         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
161         (WTR::TestRunner::willSendRequestHTTPBody):
162         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
163
164 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
165
166         Remove additional simulator checks before running layout-tests
167         https://bugs.webkit.org/show_bug.cgi?id=152146
168
169         Reviewed by Darin Adler.
170
171         * Scripts/webkitpy/port/ios.py:
172         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
173         * Scripts/webkitpy/xcode/simulator.py:
174         (Simulator._boot_and_shutdown_simulator_device): Deleted.
175         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
176
177 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
178
179         Run atleast one simulator even if max process limit is low
180         https://bugs.webkit.org/show_bug.cgi?id=152081
181         <rdar://problem/23819694>
182
183         Reviewed by Alexey Proskuryakov.
184
185 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
186
187         [GTK] Crash in WebProcess when loading large content with custom URI schemes
188         https://bugs.webkit.org/show_bug.cgi?id=144262
189
190         Reviewed by Carlos Garcia Campos.
191
192         Added new unit test to check the additional scenarios we now
193         handle for custom URI schemes.
194
195         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
196         (generateHTMLContent): New helper function to generate big enough content.
197         (testWebContextURIScheme): New unit test.
198
199 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
200
201         [EFL] Fix unhandled web process message when launching MiniBrowser
202         https://bugs.webkit.org/show_bug.cgi?id=152048
203
204         Reviewed by Gyuyoung Kim.
205
206         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
207         (TestWebKitAPI::TEST):
208
209 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
210
211         [GTK] Add API to handle beforeunload events
212         https://bugs.webkit.org/show_bug.cgi?id=139090
213
214         Reviewed by Gustavo Noronha Silva.
215
216         * MiniBrowser/gtk/BrowserWindow.c:
217         (browserWindowConstructed):
218         (browserWindowDeleteEvent):
219         (browser_window_class_init):
220         Handle delete-event to prevent the window from being closed when
221         the page has beforeunload handlers. Use
222         webkit_web_view_try_close() when the window is requested to be
223         closed.
224         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
225         (testWebViewJavaScriptDialogs):
226         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
227         script dialog type.
228
229 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
230
231         Refactored initialization code in LoadTrackingTest.
232
233         Rubber-stamped by Carlos Garcia Campos.
234
235         Small refactoring to make sure that the state of a LoadTrackingTest
236         gets properly reset before loading new web content.
237
238         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
239         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
240         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
241         functions and reset the remaining local variables.
242         (LoadTrackingTest::loadURI): Call reset();
243         (LoadTrackingTest::loadHtml): Ditto.
244         (LoadTrackingTest::loadPlainText): Ditto.
245         (LoadTrackingTest::loadBytes): Ditto.
246         (LoadTrackingTest::loadRequest): Ditto.
247         (LoadTrackingTest::reload): Ditto.
248         (LoadTrackingTest::goBack): Ditto.
249         (LoadTrackingTest::goForward): Ditto.
250
251 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
252
253         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
254         https://bugs.webkit.org/show_bug.cgi?id=151942
255
256         Reviewed by Darin Adler.
257
258         * MiniBrowser/efl/main.c:
259         (window_create): Enable offline web application cache feature on MiniBrowser.
260         (elm_main):
261
262 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
263
264         https://bugs.webkit.org/show_bug.cgi?id=151243
265         <rdar://problem/22955197>
266
267         Reviewed by Alexey Proskuryakov.
268
269         * LayoutTestRelay/LayoutTestRelay/main.m:
270         (getTestingSimDevice): Use separate testing device for each worker.
271         * Scripts/webkitpy/layout_tests/controllers/manager.py:
272         (Manager.run): Perform cleanup even if setup fails.
273         * Scripts/webkitpy/port/ios.py:
274         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
275         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
276         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
277         (IOSSimulatorPort._quit_ios_simulator): Same
278         (IOSSimulatorPort.clean_up_test_run): Same
279         (IOSSimulatorPort.check_sys_deps): Same
280         (IOSSimulatorPort.testing_device): Same
281         (IOSSimulatorPort.reset_preferences): Same
282         (IOSSimulatorPort.get_simulator_path): Return simulator path.
283         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
284         * Scripts/webkitpy/xcode/simulator.py:
285         (Device.delete): Delete the simulator device.
286         (Simulator.delete_device): Same
287         (Simulator.wait_until_device_is_booted): Wait for device booting.
288
289 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
290
291         [EFL] Add API to provide preferences before creating ewk_view
292         https://bugs.webkit.org/show_bug.cgi?id=151587
293
294         Reviewed by Gyuyoung Kim.
295
296         * MiniBrowser/efl/main.c:
297         (on_key_down):
298         (quit):
299         (window_create):
300         Moved settings related code to configuration() not to update settings
301         whenever ewk_view is created.
302         (configuration):
303         (elm_main):
304
305 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
306
307         Unreviewed. Fix GTK+ API tests after r193639.
308
309         The new jhbuild version needs some more variables ot be present in
310         the builtin dict, even if they are set to None.
311
312         * jhbuild/jhbuildutils.py:
313         (enter_jhbuild_environment_if_available):
314
315 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
316
317         [GTK] Notify WebCore when notification is clicked
318         https://bugs.webkit.org/show_bug.cgi?id=151951
319
320         Reviewed by Carlos Garcia Campos.
321
322         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
323         (testWebViewNotification): test the new API.
324
325 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
326
327         'jhbuild build' should fail immediately when building any module fails
328         https://bugs.webkit.org/show_bug.cgi?id=145697
329
330         Reviewed by Carlos Garcia Campos.
331
332         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
333         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
334         Everything is placed under lib instead of lib64 now.
335         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
336         --exit-on-error when running 'jhbuild build'.
337         * jhbuild/jhbuildrc_common.py:
338         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
339         jhbuild should be able to handle these for us without breaking things....
340
341 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
342
343         Add support to import w3c tests from a repository with a different root that the main repo dir
344         https://bugs.webkit.org/show_bug.cgi?id=151751
345
346         Reviewed by Ryosuke Niwa and Youenn Fablet.
347
348         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
349         in a different directory than the repository root.
350
351         This patch introduces a new parameter tests_directory that we will use as root directory to search for
352         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
353         requires having the copy_path lists including tuples of origin and destination directories.
354
355         * Scripts/webkitpy/w3c/test_downloader.py:
356         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
357         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
358         * Scripts/webkitpy/w3c/test_importer_unittest.py:
359         (TestImporterTest.test_tests_directory): Test.
360
361 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
362
363         Mock TestRepositories in W3C importer tests
364         https://bugs.webkit.org/show_bug.cgi?id=151938
365
366         Reviewed by Youenn Fablet.
367
368         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
369         is because the test repository method reading the file was using the filesystem directly instead of taking the
370         host one. This patch changes that.
371
372         * Scripts/webkitpy/w3c/test_downloader.py:
373         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
374         default one.
375         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
376         * Scripts/webkitpy/w3c/test_importer_unittest.py:
377         (TestImporterTest.test_harnesslinks_conversion):
378         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
379
380 2015-12-07  David Kilzer  <ddkilzer@apple.com>
381
382         TestNetscapePlugIn: Address review comment on 193607
383         <http://webkit.org/b/151881>
384
385         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
386         (testSetStatus): Initializing std::unique_ptr<char[]> with
387         nullptr is redundant.
388
389 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
390
391         [GTK] Add webkit_uri_request_get_http_method
392         https://bugs.webkit.org/show_bug.cgi?id=151601
393
394         Reviewed by Martin Robinson.
395
396         Add test case to check HTTP method of WebKitURIRequest.
397
398         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
399         (testURIRequestHTTPMethod):
400         (serverCallback):
401         (beforeAll):
402         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
403         (sendRequestCallback):
404
405 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
406
407         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
408         https://bugs.webkit.org/show_bug.cgi?id=79918
409
410         Reviewed by Gustavo Noronha Silva.
411
412         Add unit tests to check the different console messages.
413
414         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
415         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
416         (ConsoleMessageTest::ConsoleMessage::operator==):
417         (ConsoleMessageTest::consoleMessageReceivedCallback):
418         (ConsoleMessageTest::ConsoleMessageTest):
419         (ConsoleMessageTest::~ConsoleMessageTest):
420         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
421         (testWebKitConsoleMessageConsoleAPI):
422         (testWebKitConsoleMessageJavaScriptException):
423         (testWebKitConsoleMessageNetworkError):
424         (testWebKitConsoleMessageSecurityError):
425         (beforeAll):
426         (afterAll):
427         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
428         (consoleMessageSentCallback):
429         (pageCreatedCallback):
430
431 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
432
433         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
434         https://bugs.webkit.org/show_bug.cgi?id=151934
435
436         Reviewed by Csaba Osztrogonác.
437
438         * MiniBrowser/efl/main.c:
439         (on_window_deletion): Revert the changes of r192767.
440
441 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
442
443         [GTK] update-webkitgtk-libs cannot build mesa
444         https://bugs.webkit.org/show_bug.cgi?id=151535
445
446         Reviewed by Martin Robinson.
447
448         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
449         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
450         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
451         does not have a stable API and we cannot expect mesa to be buildable unless we control the
452         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
453         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
454
455         * gtk/jhbuild.modules:
456
457 2015-12-07  Philippe Normand  <pnormand@igalia.com>
458
459         [GTK][Mac] libWebExtensionTest link error
460         https://bugs.webkit.org/show_bug.cgi?id=150802
461
462         Reviewed by Carlos Garcia Campos.
463
464         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
465
466 2015-12-06  David Kilzer  <ddkilzer@apple.com>
467
468         TestNetscapePlugIn: Fix leaks found by static analyzer
469         <http://webkit.org/b/151881>
470
471         Reviewed by Darin Adler.
472
473         Fixes the following leaks found by the static analyzer:
474             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
475                     return false;
476                            ^~~~~
477             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
478                     return false;
479                            ^~~~~
480             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
481                     return false;
482                            ^~~~~
483
484         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
485         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
486         early return if allocation fails.
487         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
488         Make sure to call fclose() on filehandle, even for an early
489         return.
490         (testSetStatus): Switch to using std::unique_ptr<char[]>.
491
492 2015-12-05  David Kilzer  <ddkilzer@apple.com>
493
494         prepare-ChangeLog: Fix some warning messages when using svn
495         <http://webkit.org/b/151914>
496
497         Reviewed by Daniel Bates.
498
499         * Scripts/prepare-ChangeLog:
500         (generateFunctionLists): Simplify logic so that we never call
501         normalizePath() with an undefined value.
502         (attributeCommand): Quote $subPath for the shell so that we
503         don't try to run "svn propget" on invalid paths.
504
505 2015-12-04  David Kilzer  <ddkilzer@apple.com>
506
507         TestNetscapePlugIn: Fix remaining static analyzer warnings
508         <http://webkit.org/b/151888>
509
510         Reviewed by Alexey Proskuryakov.
511
512         Fixes the following static analyzer warnings:
513             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
514                     CRASH();
515                     ^~~~~~~
516             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
517                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
518                 ^~~~~~~~~~~~~~~~
519             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
520                 return obj->pluginTest->NPP_SetWindow(window);
521                        ^~~~~~~~~~~~~~~
522             2 warnings generated.
523
524         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
525         (CRASH): Use __builtin_trap() for gcc/clang.
526         (NPP_SetWindow): Add early return if obj is nullptr.
527
528 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
529
530         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
531         https://bugs.webkit.org/show_bug.cgi?id=151797
532
533         Reviewed by Martin Robinson.
534
535         Since we switched to use the network process to run the unit tests
536         the test /webkit2/WebKitWebResource/get-data sometimes fails and
537         sometimes passes. We are now also getting the notification for the
538         css image. Since we wait for 3 resources, sometimes the css image
539         is loaded before and then checkResourceData is called for it, but
540         not handled. When the css image is the last one loaded the test
541         passes. So, we just need to wait for the 4 resources.
542
543         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
544         (testWebResourceGetData):
545
546 2015-12-03  David Kilzer  <ddkilzer@apple.com>
547
548         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
549         <http://webkit.org/b/151845>
550
551         Reviewed by Simon Fraser.
552
553         Fixes the following static analyzer warning:
554             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
555                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
556                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
557
558         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
559         (createBitmapContext): Free 'buffer' after using it in logging
560         to fix the use-after-free.  Assign a value of nullptr to buffer
561         so we don't return with it set to a freed address.
562
563 2015-12-03  Jer Noble  <jer.noble@apple.com>
564
565         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
566         https://bugs.webkit.org/show_bug.cgi?id=151830
567
568         Reviewed by Anders Carlsson.
569
570         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
571
572         * DumpRenderTree/mac/DumpRenderTree.mm:
573         (resetWebPreferencesToConsistentValues):
574         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
575         (WTR::initializeWebViewConfiguration):
576
577 2015-12-03  Anders Carlsson  <andersca@apple.com>
578
579         Remove Objective-C GC support
580         https://bugs.webkit.org/show_bug.cgi?id=151819
581         rdar://problem/23746991
582
583         Reviewed by Dan Bernstein.
584
585         * asan/asan.xcconfig:
586
587 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
588
589         Allow nil for unspecified benchmark pathes
590         https://bugs.webkit.org/show_bug.cgi?id=151784
591
592         Reviewed by Filip Pizlo.
593
594         `Pathname.new(nil)` will raise an error.
595         Only generate Pathname if the benchmark path is specified.
596
597         * Scripts/run-jsc-benchmarks:
598
599 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
600
601         [Win] Run non-http tests without Cygwin
602         https://bugs.webkit.org/show_bug.cgi?id=151721
603
604         Reviewed by Andy Estes.
605
606         Support native 32-bit and 64-bit Python (and Perl) builds
607         for running tests:
608
609         1. Use "startswith('win')", rather than "== 'win32'" to support
610         various Windows build types.
611         2. Supply full path for some native Windows utilities, since the
612         path environment does not always have the specified, and they are
613         guaranteed to exist in those specific locations.
614         3. Make sure native Windows Python test runs pass proper environment
615         variables to run programs.
616         4. Append 'exe' suffix when running Windows executables.
617         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
618         command doesn't exist.
619         
620         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
621         the current Perl executable, rather than requiring a new path search.
622         * Scripts/webkitpy/common/find_files_unittest.py:
623         (TestWinNormalize.test_win): Use startswith('win').
624         * Scripts/webkitpy/common/prettypatch_unittest.py:
625         (test_pretty_diff_encodings): Ditto.
626         * Scripts/webkitpy/common/system/executive.py:
627         (Executive._should_close_fds): Ditto.
628         (Executive.shell_command_for_script): Use startswith('win').
629         (Executive.kill_process): Use full path to killall executable.
630         (Executive.check_running_pid): Use startswith('win').
631         (Executive.running_pids): Ditto.
632         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
633         running under native Windows Python.
634         (Executive._child_process_encoding): Use startswith('win').
635         (Executive._should_encode_child_process_arguments): Ditto.
636         (Executive.popen): Recognize proper script engine on Windows, since it
637         does not support the shebang syntax.
638         (Executive.run_in_parallel): Use startswith('win').
639         * Scripts/webkitpy/common/system/executive_unittest.py:
640         (never_ending_command): Ditto.
641         (ExecutiveTest.test_run_command_with_unicode): Ditto.
642         (ExecutiveTest.serial_test_kill_process): Ditto.
643         (ExecutiveTest.serial_test_kill_all): Ditto.
644         (ExecutiveTest.serial_test_check_running_pid): Ditto.
645         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
646         (main): Ditto.
647         * Scripts/webkitpy/common/system/file_lock.py:
648         (FileLock._create_lock): Ditto.
649         (FileLock._remove_lock): Ditto.
650         * Scripts/webkitpy/common/system/filesystem_unittest.py:
651         (RealFileSystemTest.test_chdir): Ditto.
652         (RealFileSystemTest.test_chdir__notexists): Ditto.
653         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
654         * Scripts/webkitpy/common/system/path_unittest.py:
655         (AbspathTest.test_abspath_to_uri_win): Ditto.
656         * Scripts/webkitpy/common/system/platforminfo.py:
657         (PlatformInfo._determine_os_name): Ditto.
658         * Scripts/webkitpy/common/system/user.py: Ditto.
659         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
660         (ManagerTest.integration_test_needs_servers): Ditto.
661         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
662         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
663         driver letters.
664         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
665         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
666         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
667         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
668         (HttpServerBase._check_that_all_ports_are_available): Ditto.
669         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
670         (TestHttpServer.test_start_cmd): Ditto.
671         * Scripts/webkitpy/port/base.py:
672         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
673         and 'SYSTEMROOT' in environment passed to test runners.
674         (Port._apache_config_file_name_for_platform): Use startswith('win').
675         (Port._build_path): Ditto.
676         (Port._path_to_driver): Include 'exe' suffix when running under native
677         Windows.
678         * Scripts/webkitpy/port/driver.py:
679         (Driver._setup_environ_for_driver): Explicitly make some environment
680         variables strings.
681         * Scripts/webkitpy/port/server_process.py:
682         (ServerProcess.__init__): Use startswith('win').
683         * Scripts/webkitpy/port/win.py:
684         (WinPort): Use the win32 registry utilities on Windows, and appropriate
685         registry key formats.
686         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
687         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
688         and regtool on Cygwin.
689         (WinPort.write_registry_value): Ditto.
690         (WinPort.setup_crash_log_saving): Ditto.
691         (WinPort.restore_crash_log_saving): Ditto.
692         (WinPort.prevent_error_dialogs): Ditto.
693         (WinPort.allow_error_dialogs): Ditto.
694         (WinPort.find_system_pid): Revise to use Windows management
695         infrastructure on native Windows, continue using 'ps' on Cygwin.
696         (WinPort.read_registry_string): Deleted.
697         (WinPort.write_registry_string): Deleted.
698         * Scripts/webkitpy/test/main.py:
699         (main): Use startswith('win').
700         (Tester._parse_args): Ditto.
701
702 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
703
704         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
705         https://bugs.webkit.org/show_bug.cgi?id=150792
706
707         Reviewed by Saam Barati.
708
709         * Scripts/webkitperl/FeatureList.pm:
710
711 2015-12-01  Commit Queue  <commit-queue@webkit.org>
712
713         Unreviewed, rolling out r192914.
714         https://bugs.webkit.org/show_bug.cgi?id=151734
715
716         JSC tests for this change are failing on 32 and 64-bit bots
717         (Requested by ryanhaddad on #webkit).
718
719         Reverted changeset:
720
721         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
722         enable this feature"
723         https://bugs.webkit.org/show_bug.cgi?id=150792
724         http://trac.webkit.org/changeset/192914
725
726 2015-12-01  David Kilzer  <ddkilzer@apple.com>
727
728         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
729         <http://webkit.org/b/151726>
730
731         Reviewed by Simon Fraser.
732
733         * WebKitTestRunner/mac/EventSenderProxy.mm:
734         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
735         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
736
737 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
738
739         Give String and AtomicString an existingHash() function
740         https://bugs.webkit.org/show_bug.cgi?id=151717
741
742         Reviewed by Andreas Kling.
743
744         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
745         (TestWebKitAPI::TEST):
746         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
747         (TestWebKitAPI::TEST):
748
749 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
750
751         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
752         https://bugs.webkit.org/show_bug.cgi?id=150792
753
754         Reviewed by Saam Barati.
755
756         * Scripts/webkitperl/FeatureList.pm:
757
758 2015-12-01  Sam Weinig  <sam@webkit.org>
759
760         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
761         <rdar://problem/23320863>
762         https://bugs.webkit.org/show_bug.cgi?id=151708
763
764         Reviewed by Anders Carlsson.
765
766         * WebKitTestRunner/TestController.cpp:
767         (WTR::TestController::createOtherPage):
768         (WTR::TestController::createWebViewWithOptions):
769         Update for new WKPageUIClient.
770
771 2015-12-01  Anders Carlsson  <andersca@apple.com>
772
773         Remove WebKit2.framework
774         https://bugs.webkit.org/show_bug.cgi?id=151715
775
776         Reviewed by Dan Bernstein.
777
778         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
779         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
780         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
781         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
782         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
783         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
784         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
785
786 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
787
788         Unreviewed common typo fix "occurance" => "occurrence".
789
790         * Scripts/webkitpy/tool/commands/queries.py:
791         (FindFlakyTests._print_statistics):
792
793 2015-11-30  Alex Christensen  <achristensen@webkit.org>
794
795         Make ProcessModel always MultipleSecondaryProcesses
796         https://bugs.webkit.org/show_bug.cgi?id=151662
797
798         Reviewed by Antti Koivisto.
799
800         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
801         (TestWebKitAPI::TEST):
802         * WebKitTestRunner/TestController.cpp:
803         (WTR::TestController::generatePageConfiguration):
804
805 2015-11-30  Alex Christensen  <achristensen@webkit.org>
806
807         Make usesNetworkProcess always true
808         https://bugs.webkit.org/show_bug.cgi?id=151580
809
810         Reviewed by Darin Adler.
811
812         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
813         (TestWebKitAPI::TEST):
814         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
815         (TestWebKitAPI::TEST):
816         * WebKitTestRunner/TestController.cpp:
817         (WTR::TestController::generatePageConfiguration):
818
819 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
820
821         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
822
823         Add a way to skip unit tests only for Debug or Release builds and
824         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
825
826         * Scripts/run-gtk-tests:
827         (SkippedTest):
828         (SkippedTest.__init__):
829         (SkippedTest.__str__):
830         (SkippedTest.skip_entire_suite):
831         (SkippedTest.skip_for_build_type):
832         (TestRunner):
833         (TestRunner.__init__):
834
835 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
836
837         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
838
839         It's an assert hit because we are reloading a view loaded with
840         HTML data which is not supported. Use loadURI instead.
841
842         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
843         (testWebViewCustomCharset):
844
845 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
846
847         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
848         https://bugs.webkit.org/show_bug.cgi?id=151633
849
850         Reviewed by Csaba Osztrogonác.
851
852         * TestWebKitAPI/PlatformGTK.cmake:
853         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
854
855 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
856
857         [GTK] Remove the remaining uses of GMainLoopSource
858         https://bugs.webkit.org/show_bug.cgi?id=151632
859
860         Reviewed by Žan Doberšek.
861
862         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
863         (testWebViewSyncRequestOnMaxConns):
864         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
865         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
866         (WTR::TestRunner::TestRunner):
867         * WebKitTestRunner/InjectedBundle/TestRunner.h:
868         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
869         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
870         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
871         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
872         (WTR::timeoutSource):
873         (WTR::TestController::notifyDone):
874         (WTR::TestController::platformRunUntil):
875
876 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
877
878         [cmake] Add testb3 to the build system
879         https://bugs.webkit.org/show_bug.cgi?id=151619
880
881         Reviewed by Gyuyoung Kim.
882
883         * Scripts/build-jsc:
884
885 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
886
887         [jhbuild] Fix pixman build with clang
888         https://bugs.webkit.org/show_bug.cgi?id=151441
889
890         Reviewed by Carlos Garcia Campos.
891
892         * efl/jhbuild.modules:
893         * gtk/jhbuild.modules:
894
895 2015-11-26  David Kilzer  <ddkilzer@apple.com>
896
897         Extract prependToEnvironmentVariableList
898         <http://webkit.org/b/151536>
899
900         Reviewed by Daniel Bates.
901
902         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
903                webkitdirs_unittest/prependToEnvironmentVariableList.pl
904
905         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
906         and prependToEnvironmentVariableList.
907         (appendToEnvironmentVariableList): Simplify variable name.
908         Switch to use $Config{path_sep}.
909         (prependToEnvironmentVariableList): Add new method.
910         (setupMacWebKitEnvironment): Switch to use
911         prependToEnvironmentVariableList().
912         (setupIOSWebKitEnvironment): Ditto.
913
914         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
915         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
916
917 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
918
919         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
920         https://bugs.webkit.org/show_bug.cgi?id=151567
921
922         Reviewed by Darin Adler.
923
924         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
925         (on_window_deletion):
926
927 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
928
929         [GTK] Use the network process unconditionally
930         https://bugs.webkit.org/show_bug.cgi?id=151541
931
932         Reviewed by Alex Christensen.
933
934         Fix TestInspectorServer test. Do not assume we already have the
935         title we want when the page has been loaded, since the title is
936         changed afterwards. So, check if the title has already been set,
937         and if not wait for it.
938
939         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
940         (openRemoteDebuggingSession):
941
942 2015-11-23  Alex Christensen  <achristensen@webkit.org>
943
944         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
945         https://bugs.webkit.org/show_bug.cgi?id=151532
946
947         Reviewed by Benjamin Poulain.
948
949         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
950         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
951         (TestWebKitAPI::TEST):
952         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
953         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
954         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
955         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
956         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
957         so it was calling a function on a test object that had gone out of scope.
958         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
959         but that will become the default soon and that call will be removed.
960
961 2015-11-22  David Kilzer  <ddkilzer@apple.com>
962
963         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
964         <http://webkit.org/b/151542>
965
966         Reviewed by Daniel Bates.
967
968         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
969         (base_url): Use the Port object (already passed in) to give us
970         the path to the LayoutTests directory, which already checks for a
971         --layout-tests-directory command-line switch.
972         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
973         argument since we can get this from the Port object already
974         passed in via Port.results_directory().  Also switch to use
975         Port.layout_tests_dir() to get the LayoutTests directory.
976
977         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
978         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
979         Add test case for custom LayoutTests directory.
980         (TestWebPlatformTestServer.test_previously_spawned_instance):
981         Update Port object to set mock results directory as if it was
982         set on the command-line.  Remove unneeded argument from
983         WebPlatformTestServer constructor.
984         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
985
986         * Scripts/webkitpy/port/base.py:
987         (Port.to.start_web_platform_test_server): Remove unneeded
988         argument from WebPlatformTestServer constuctor.
989
990 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
991
992         [GTK] Some unit tests fail when using the network process
993         https://bugs.webkit.org/show_bug.cgi?id=151490
994
995         Reviewed by Martin Robinson.
996
997         Run the soup server in a separate thread in TestResources test to
998         avoid deadlocks.
999
1000         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
1001         /webkit2/WebKitWebResource/get-data when using the network process.
1002
1003         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1004         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
1005         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1006         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
1007         present, create a WorkQueue to run the server.
1008         (WebKitTestServer::run): Run the server in the work queue if it
1009         has been created.
1010         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1011         type into server options as flags.
1012
1013 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1014
1015         [GTK] ImageDiff should normalize the diff image
1016         https://bugs.webkit.org/show_bug.cgi?id=151261
1017
1018         Reviewed by Sergio Villar Senin.
1019
1020         * ImageDiff/gtk/ImageDiff.cpp:
1021         (readPixbufFromStdin): Fix memory leak.
1022         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
1023         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
1024
1025 == Rolled over to ChangeLog-2015-11-21 ==