[Cocoa] Ask platform for generic font family mappings
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         [Cocoa] Ask platform for generic font family mappings
4         https://bugs.webkit.org/show_bug.cgi?id=187723
5         <rdar://problem/41892438>
6
7         Reviewed by Brent Fulgham.
8
9         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
10
11         * DumpRenderTree/mac/DumpRenderTree.mm:
12         (allowedFontFamilySet):
13         * WebKitTestRunner/mac/TestControllerMac.mm:
14         (WTR::allowedFontFamilySet):
15
16 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
17
18         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
19         https://bugs.webkit.org/show_bug.cgi?id=193622
20
21         Reviewed by Michael Catanzaro.
22
23         This adds support for loading content extension rule sets from the JSON files which
24         accompany the corresponding layout test, using the C API. The Cocoa specific parts
25         of WKTR for this could be removed, but that is left for a follow-up patch with
26         cleanups.
27
28         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
29         * WebKitTestRunner/TestController.cpp:
30         (WTR::testPath): Subtract one from the length when constructing the result std::string to
31         avoid having the null-terminator copied into the result.
32         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
33         part of the preparations to run a test.
34         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
35         (WTR::contentExtensionStoreCallback): Added.
36         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
37         used for content extensions test.
38         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
39         extensions and compiling the JSON rule set for tests involving content extensions.
40         (WTR::TestController::resetContentExtensions): Removes the content extension built for
41         testing and disables content extensions.
42         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
43         resetContentExtensions().
44         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
45         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
46         configureContentExtensionForTest(), and userContentController().
47
48 2019-02-11  Daniel Bates  <dabates@apple.com>
49
50         [iOS] Mouse/Touch/Pointer events are missing modifier keys
51         https://bugs.webkit.org/show_bug.cgi?id=191446
52         <rdar://problem/45929460>
53
54         Reviewed by Tim Horton.
55
56         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
57
58         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
59         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
60         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
61         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
62         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
63         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
64         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
65         * TestRunnerShared/UIScriptContext/UIScriptController.h:
66         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
67         (WTR::arrayLength):
68         (WTR::parseModifierArray):
69         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
70         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
71         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
72         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
73
74 2019-02-11  Commit Queue  <commit-queue@webkit.org>
75
76         Unreviewed, rolling out r241272 and r241276.
77         https://bugs.webkit.org/show_bug.cgi?id=194514
78
79         Broke the Apple Internal build and the fix requires human
80         intervention :( (Requested by dydz on #webkit).
81
82         Reverted changesets:
83
84         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
85         https://bugs.webkit.org/show_bug.cgi?id=191446
86         https://trac.webkit.org/changeset/241272
87
88         "Fix internal iOS build after r241272"
89         https://bugs.webkit.org/show_bug.cgi?id=191446
90         https://trac.webkit.org/changeset/241276
91
92 2019-02-11  Truitt Savell  <tsavell@apple.com>
93
94         Unreviewed, rolling out r241269.
95
96         Caused 5 layout tests crashes on Mac WK1
97
98         Reverted changeset:
99
100         "DumpRenderTree should report unknown options"
101         https://bugs.webkit.org/show_bug.cgi?id=191303
102         https://trac.webkit.org/changeset/241269
103
104 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
105
106         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
107         https://bugs.webkit.org/show_bug.cgi?id=194313
108
109         Reviewed by Tim Horton.
110
111         Add a helper to determine whether the web view is presenting modal UI.
112
113         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
114         (WTR::UIScriptController::isPresentingModally const):
115         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
116         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
117         (WTR::UIScriptController::isPresentingModally const):
118         * TestRunnerShared/UIScriptContext/UIScriptController.h:
119         * WebKitTestRunner/UIScriptControllerCocoa.mm:
120         (WTR::UIScriptController::calendarType const): Deleted.
121         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
122         (WTR::UIScriptController::isPresentingModally const):
123         (WTR::UIScriptController::calendarType const):
124         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
125         (WTR::UIScriptController::calendarType const):
126
127 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
128
129         GCHeapInspector: Show the retained sizes in more places
130         https://bugs.webkit.org/show_bug.cgi?id=194464
131
132         Reviewed by Simon Fraser.
133
134         * GCHeapInspector/gc-heap-inspector.html:
135         * GCHeapInspector/script/interface.js:
136         (HeapInspectorUtils.humanReadableSize):
137         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
138         (HeapInspectorUtils.spanForNode.span.span):
139         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
140         (HeapSnapshotInspector.prototype.buildRoots):
141
142 2019-02-11  Daniel Bates  <dabates@apple.com>
143
144         [iOS] Mouse/Touch/Pointer events are missing modifier keys
145         https://bugs.webkit.org/show_bug.cgi?id=191446
146         <rdar://problem/45929460>
147
148         Reviewed by Tim Horton.
149
150         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
151
152         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
153         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
154         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
155         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
156         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
157         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
158         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
159         * TestRunnerShared/UIScriptContext/UIScriptController.h:
160         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
161         (WTR::arrayLength):
162         (WTR::parseModifierArray):
163         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
164         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
165         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
166         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
167
168 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
169
170         DumpRenderTree should report unknown options
171         https://bugs.webkit.org/show_bug.cgi?id=191303
172
173         Reviewed by Frédéric Wang.
174
175         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
176         to report unknown options.
177         Added and assigned test options which are currently used in tests.
178
179         * DumpRenderTree/TestOptions.cpp:
180         (TestOptions::TestOptions):
181
182 2019-02-11  Truitt Savell  <tsavell@apple.com>
183
184         Unreviewed, rolling out r241229.
185
186         Revision broke internal builds for watchOS.
187
188         Reverted changeset:
189
190         "[Cocoa] Ask platform for generic font family mappings"
191         https://bugs.webkit.org/show_bug.cgi?id=187723
192         https://trac.webkit.org/changeset/241229
193
194 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
195
196         [WinCairo][MiniBrowser] Basic authentication always fails.
197         https://bugs.webkit.org/show_bug.cgi?id=194496
198
199         Reviewed by Don Olmstead.
200
201         * MiniBrowser/win/DialogHelper.h:
202         (Dialog::getText):
203
204 2019-02-11  Philippe Normand  <pnormand@igalia.com>
205
206         [GStreamer] GstMappedBuffer testsuite build fails
207         https://bugs.webkit.org/show_bug.cgi?id=194495
208
209         Reviewed by Carlos Garcia Campos.
210
211         Fix the build by explicitely adding the gstreamer1.0-audio include
212         directories to the include path.
213
214         * TestWebKitAPI/PlatformGTK.cmake:
215         * TestWebKitAPI/PlatformWPE.cmake:
216
217 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
218
219         [GTK][WPE] Add enable-javascript-markup setting
220         https://bugs.webkit.org/show_bug.cgi?id=193439
221
222         Reviewed by Michael Catanzaro.
223
224         Add test cases to check the new setting.
225
226         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
227         (testWebKitSettings):
228         (testWebKitSettingsJavaScriptMarkup):
229         (beforeAll):
230
231 2019-02-10  Darin Adler  <darin@apple.com>
232
233         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
234         https://bugs.webkit.org/show_bug.cgi?id=194485
235
236         Reviewed by Daniel Bates.
237
238         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
239
240 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
241
242         Add more tests for clampTo<>()
243         https://bugs.webkit.org/show_bug.cgi?id=194462
244
245         Reviewed by Geoffrey Garen.
246
247         Darin suggested to test the very last floating point number
248         at the boundaries when truncating to integer.
249         I added test for max/min and max-1/min-1.
250
251         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
252         (TestWebKitAPI::TEST):
253
254 2019-02-09  Darin Adler  <darin@apple.com>
255
256         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
257         https://bugs.webkit.org/show_bug.cgi?id=194021
258
259         Reviewed by Geoffrey Garen.
260
261         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
262         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
263         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
264
265 2019-02-09  Zalan Bujtas  <zalan@apple.com>
266
267         [LFC][IFC] Add intrinsic width support for basic inline containers
268         https://bugs.webkit.org/show_bug.cgi?id=194473
269
270         Reviewed by Antti Koivisto.
271
272         Expand tests coverage (11 new tests -> 798)
273
274         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
275
276 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
277
278         Fix MiniBrowser's entitlements
279         https://bugs.webkit.org/show_bug.cgi?id=192431
280
281         Reviewed by Joseph Pecoraro.
282
283         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
284         files, making it impossible to load any extension.
285
286         * MiniBrowser/MiniBrowser.entitlements:
287
288 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
289
290         [Cocoa] Ask platform for generic font family mappings
291         https://bugs.webkit.org/show_bug.cgi?id=187723
292         <rdar://problem/41892438>
293
294         Reviewed by Brent Fulgham.
295
296         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
297
298         * DumpRenderTree/mac/DumpRenderTree.mm:
299         (allowedFontFamilySet):
300         * WebKitTestRunner/mac/TestControllerMac.mm:
301         (WTR::allowedFontFamilySet):
302
303 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
304
305         [GTK] Implement back/forward touchpad gesture
306         https://bugs.webkit.org/show_bug.cgi?id=193919
307
308         Reviewed by Michael Catanzaro.
309
310         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
311         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
312
313 2019-02-08  Alex Christensen  <achristensen@webkit.org>
314
315         Add SPI to use networking daemon instead of XPC service
316         https://bugs.webkit.org/show_bug.cgi?id=194427
317
318         Reviewed by Geoffrey Garen
319
320         * MiniBrowser/MiniBrowser.entitlements:
321
322 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
323
324         [ews-build] Ensure that every builder in config.json has short name
325         https://bugs.webkit.org/show_bug.cgi?id=194461
326
327         Reviewed by Lucas Forschler.
328
329         * BuildSlaveSupport/ews-build/loadConfig.py:
330         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
331
332 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
333
334         [ews-build] Add short name to config.json
335         https://bugs.webkit.org/show_bug.cgi?id=194456
336
337         Reviewed by Lucas Forschler.
338
339         * BuildSlaveSupport/ews-build/config.json: Added short name.
340         * BuildSlaveSupport/ews-build/loadConfig.py:
341         (loadBuilderConfig): Set the short name as the builder description.
342
343 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
344
345         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
346         https://bugs.webkit.org/show_bug.cgi?id=194418
347
348         Reviewed by Lucas Forschler.
349
350         Do not include errors trying when finding crashlogs at the end of
351         a run-webkit-tests run since we don't process those errors.
352
353         * Scripts/webkitpy/port/darwin.py:
354         (DarwinPort._look_for_all_crash_logs_in_log_dir):
355         * Scripts/webkitpy/port/ios_device.py:
356         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
357         * Scripts/webkitpy/port/watch_device.py:
358         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
359
360 2019-02-08  Beth Dakin  <bdakin@apple.com>
361
362         Add afterScreenUpdates to WKSnapshotConfiguration
363         https://bugs.webkit.org/show_bug.cgi?id=194362
364         -and corresponding-
365         <rdar://problem/40655528> Please add an "after screen updates" property to 
366         WKSnapshotConfiguration (to solve blank snapshots)
367
368         Reviewed by Tim Horton.
369
370         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
371         (TEST):
372
373 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
374
375         clampTo(): do not convert the input to double when dealing with integers
376         https://bugs.webkit.org/show_bug.cgi?id=194263
377         <rdar://problem/47692312>
378
379         Reviewed by Darin Adler.
380
381         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
382         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
383         (TestWebKitAPI::testClampFloatingPointToInteger):
384         (TestWebKitAPI::testClampSameSignIntegers):
385         (TestWebKitAPI::testClampUnsignedToSigned):
386         (TestWebKitAPI::testClampSignedToUnsigned):
387
388 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
389
390         webkitpy: Respect --dedicated-simulators flag
391         https://bugs.webkit.org/show_bug.cgi?id=194416
392         <rdar://problem/47894722>
393
394         Reviewed by Lucas Forschler.
395
396         * Scripts/webkitpy/port/device_port.py:
397         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
398         available devices can be safely ignored.
399
400 2019-02-07  Keith Rollin  <krollin@apple.com>
401
402         Remove extra copy of 100x100-red.tga
403         https://bugs.webkit.org/show_bug.cgi?id=194371
404         <rdar://problem/47873465>
405
406         Reviewed by Said Abou-Hallawa.
407
408         In order to help it pass its tests, Bug 194190 added a second copy of
409         the file 100x100-red.tga. However, it turns out that this additional
410         file wasn't actually needed, and that that sole previous copy was
411         sufficient. At the same time, this second copy -- which was copied to
412         the same location in the build output as the first copy -- now caused
413         XCBuild to complain because there were two production rules for the
414         same output file. Address this by removing the newly-added extra copy.
415
416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
417         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
418
419 2019-02-07  Alex Christensen  <achristensen@webkit.org>
420
421         Deprecate WKBundlePageSetDefersLoading
422         https://bugs.webkit.org/show_bug.cgi?id=191394
423
424         Reviewed by Dean Jackson.
425
426         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
427         (WTR::TestRunner::setDefersLoading):
428
429 2019-02-07  Zalan Bujtas  <zalan@apple.com>
430
431         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
432         https://bugs.webkit.org/show_bug.cgi?id=194391
433
434         Reviewed by Antti Koivisto.
435
436         * LayoutReloaded/misc/LFC-passing-tests.txt:
437
438 2019-02-06  Keith Rollin  <krollin@apple.com>
439
440         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
441         https://bugs.webkit.org/show_bug.cgi?id=193975
442         <rdar://problem/47643306>
443
444         Reviewed by Tim Horton.
445
446         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
447         the Info.plist file into the bundle. This step is not necessary as the
448         implicit "bundle up all the build products into a framework" build
449         phase does this already. Having the Copy Bundle Resources phase do
450         this causes a conflict under XCBuild, which objects to two build
451         phases producing the same file (Info.plist). Address this by removing
452         Info.plist from the Copy Bundle Resources phase.
453
454         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
455
456 2019-02-06  Keith Rollin  <krollin@apple.com>
457
458         Really enable the automatic checking and regenerations of .xcfilelists during builds
459         https://bugs.webkit.org/show_bug.cgi?id=194357
460         <rdar://problem/47861231>
461
462         Reviewed by Chris Dumez.
463
464         Bug 194124 was supposed to enable the automatic checking and
465         regenerating of .xcfilelist files during the build. While related
466         changes were included in that patch, the change to actually enable the
467         operation somehow was omitted. This patch actually enables the
468         operation. The check-xcfilelist.sh scripts now check
469         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
470         from the checking.
471
472         * DumpRenderTree/Scripts/check-xcfilelists.sh:
473         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
474
475 2019-02-06  David Kilzer  <ddkilzer@apple.com>
476
477         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
478         <https://webkit.org/b/194286>
479         <rdar://problem/47815558>
480
481         Reviewed by Alexey Proskuryakov.
482
483         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
484         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
485         WKRetainPtr<> to avoid leaking the WKDataRef.
486
487 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
488
489         Unreviewed, fix a typo
490
491         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
492
493 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
494
495         [GTK][WPE] force libpsl build to use ICU in jhbuild
496         https://bugs.webkit.org/show_bug.cgi?id=194288
497
498         Reviewed by Carlos Garcia Campos.
499
500         * gtk/jhbuild.modules:
501         Require ICU for libpsl build in jhbuild, like done in WPE.
502
503 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
504
505         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
506         https://bugs.webkit.org/show_bug.cgi?id=194209
507
508         Reviewed by Carlos Garcia Campos.
509
510         Enhance TestCookieManager to ensure this doesn't happen again.
511
512         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
513         (testCookieManagerPersistentStorage):
514         (beforeAll):
515
516 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
517
518         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
519         https://bugs.webkit.org/show_bug.cgi?id=194324
520
521         Reviewed by Andy Estes.
522
523         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
524         part of the name is already implicit, since this is in testing code in TestOptions.
525
526         * WebKitTestRunner/TestController.cpp:
527         (WTR::TestController::generateContextConfiguration const):
528         (WTR::updateTestOptionsFromTestHeader):
529         * WebKitTestRunner/TestOptions.h:
530         (WTR::TestOptions::hasSameInitializationOptions const):
531
532 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
533
534         [ews-build] Allow * as platform for builders and workers
535         https://bugs.webkit.org/show_bug.cgi?id=188533
536
537         Reviewed by Lucas Forschler.
538
539         * BuildSlaveSupport/ews-build/loadConfig.py:
540         (checkWorkersAndBuildersForConsistency):
541
542 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
543
544         [ews-build] Add few bots to config.json
545         https://bugs.webkit.org/show_bug.cgi?id=194304
546
547         Reviewed by Lucas Forschler.
548
549         * BuildSlaveSupport/ews-build/config.json:
550
551 2019-02-05  Keith Rollin  <krollin@apple.com>
552
553         Enable the automatic checking and regenerations of .xcfilelists during builds
554         https://bugs.webkit.org/show_bug.cgi?id=194124
555         <rdar://problem/47721277>
556
557         Reviewed by Tim Horton.
558
559         Bug 193790 add a facility for checking -- during build time -- that
560         any needed .xcfilelist files are up-to-date and for updating them if
561         they are not. This facility was initially opt-in by setting
562         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
563         the process seemed robust. Its now time to enable this facility and
564         make it opt-out. If there is a need to disable this facility, set and
565         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
566         running `make` or `build-webkit`, or before running Xcode from the
567         command line.
568
569         Additionally, remove the step that generates a list of source files
570         going into the UnifiedSources build step. It's only necessarily to
571         specify Sources.txt and SourcesCocoa.txt as inputs.
572
573         * Scripts/generate-xcfilelists:
574
575 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
576
577         [GTK][WPE] force libpsl build to use ICU in jhbuild
578         https://bugs.webkit.org/show_bug.cgi?id=194288
579
580         Reviewed by Philippe Normand.
581
582         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
583         This can cause build failures if libidn is detected but libunistring is not available.
584
585         Make sure that ICU is used for runtime and builtin PSL data.
586
587         * gtk/jhbuild.modules:
588         * wpe/jhbuild.modules:
589
590 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
591
592         [ews-app] Modified timestamp should be updated on updating data
593         https://bugs.webkit.org/show_bug.cgi?id=194295
594
595         Reviewed by Lucas Forschler.
596
597         * BuildSlaveSupport/ews-app/ews/models/build.py:
598         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
599         * BuildSlaveSupport/ews-app/ews/models/step.py:
600
601 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
602
603         Unreviewed, rolling out r240742.
604
605         Causes crashes on iOS simulator.
606
607         Reverted changeset:
608
609         "[iOS] Keyups for non-modifier keys identified as "Dead" when
610         not focused in a content-editable element"
611         https://bugs.webkit.org/show_bug.cgi?id=192824
612         https://trac.webkit.org/changeset/240742
613
614 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
615
616         run-webkit-tests emits message "...running None" when running tests
617         https://bugs.webkit.org/show_bug.cgi?id=194133
618         <rdar://problem/47724738>
619
620         Reviewed by Lucas Forschler.
621
622         * Scripts/webkitpy/xcode/device_type.py:
623         (DeviceType.__str__): Use both version mapping tables and use just the variant
624         name if no version name is available.
625         * Scripts/webkitpy/xcode/device_type_unittest.py:
626         (DeviceTypeTest):
627         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
628         an associated named.
629
630 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
631
632         [WPE] require python3-setuptools for meson build in jhbuild
633         https://bugs.webkit.org/show_bug.cgi?id=194287
634
635         Reviewed by Philippe Normand.
636
637         python3-setuptools is needed to build meson in jhbuild.
638         It is already required by the GTK port.
639
640         * wpe/install-dependencies:
641
642 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
643
644         [ews-app] Add method to save BuilderMapping to database
645         https://bugs.webkit.org/show_bug.cgi?id=194264
646
647         Reviewed by Lucas Forschler.
648
649         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
650         (BuilderMapping.__str__):
651         (BuilderMapping):
652         (BuilderMapping.save_mapping):
653         (BuilderMapping.update_mapping):
654         (BuilderMapping.get_existing_mapping):
655         (BuilderMapping.is_valid_mapping):
656
657 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
658
659         [ews-app] Add timestamp fields for BuilderMappings
660         https://bugs.webkit.org/show_bug.cgi?id=194266
661
662         Reviewed by Lucas Forschler.
663
664         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
665         (BuilderMapping):
666
667 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
668
669         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
670         https://bugs.webkit.org/show_bug.cgi?id=174816
671
672         Reviewed by Michael Catanzaro.
673
674         Add tests for webkit_uri_for_display().
675
676         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
677         (testURIForDisplayUnaffected):
678         (testURIForDisplayAffected):
679         (beforeAll):
680         (afterAll):
681         * TestWebKitAPI/glib/CMakeLists.txt:
682
683 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
684
685         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
686         https://bugs.webkit.org/show_bug.cgi?id=194158
687         <rdar://problem/47737268>
688
689         Rubber-stamped by Aakash Jain.
690
691         * Scripts/webkitpy/port/device_port.py:
692         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
693
694 2019-02-04  Said Abou-Hallawa  <said@apple.com>
695
696         [CG] Enable setAdditionalSupportedImageTypes for WK1
697         https://bugs.webkit.org/show_bug.cgi?id=194190
698
699         Reviewed by Tim Horton.
700
701         Add a test similar to the one under WebKit Cocoa but make it create a
702         WebView instead of a WKWebView.
703
704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
705         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
706         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
707         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
708         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
709         (TestWebKitAPI::runTest):
710         (TestWebKitAPI::TEST):
711
712 2019-02-04  Zalan Bujtas  <zalan@apple.com>
713
714         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
715         https://bugs.webkit.org/show_bug.cgi?id=194168
716
717         Reviewed by Simon Fraser.
718
719         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
720
721         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
722         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
723         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
724         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
725         (TEST):
726         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
727         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
728
729 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
730
731         REGRESSION (r237269): webkit-patch what-broke is broken 
732         https://bugs.webkit.org/show_bug.cgi?id=193025
733
734         Reviewed by Aakash Jain.
735
736         * Scripts/webkitpy/common/host.py:
737         (Host.buildbot):
738         (Host.bugzilla): Renamed to 'buildbot'.
739
740 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
741
742         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
743         https://bugs.webkit.org/show_bug.cgi?id=194207
744
745         Reviewed by Tim Horton.
746
747         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
748         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
749         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
750         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
751         start and delete forwards to remove the original attachment.
752
753         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
754         (TestWebKitAPI::TEST):
755
756 2019-02-04  Youenn Fablet  <youenn@apple.com>
757
758         Capture state should be managed consistently when doing process swapping
759         https://bugs.webkit.org/show_bug.cgi?id=194122
760         <rdar://problem/47609293>
761
762         Reviewed by Eric Carlson.
763
764         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
765         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
766         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
767         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
768         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
769         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
770         (WTR::TestRunner::isDoingMediaCapture const):
771         * WebKitTestRunner/InjectedBundle/TestRunner.h:
772         * WebKitTestRunner/TestController.cpp:
773         (WTR::TestController::isDoingMediaCapture const):
774         * WebKitTestRunner/TestController.h:
775         * WebKitTestRunner/TestInvocation.cpp:
776         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
777         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
778         (WTR::TestController::isDoingMediaCapture const):
779
780 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
781
782         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
783         https://bugs.webkit.org/show_bug.cgi?id=194142
784
785         Reviewed by Ross Kirsling.
786
787         There three 'separator' variables in TestController.cpp. Renamed
788         it 'pathSeparator', and unified them.
789
790         * WebKitTestRunner/TestController.cpp:
791         (WTR::TestController::generateContextConfiguration const):
792         (WTR::createTestURL):
793         (WTR::TestController::platformAdjustContext):
794
795 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
796
797         Make setNeedsLayout on the root more explicitly about triggering its side-effects
798         https://bugs.webkit.org/show_bug.cgi?id=194198
799
800         Reviewed by Antti Koivisto.
801
802         No need to set the banner heights on navigation now, since Page stores them.
803
804         * MiniBrowser/mac/WK2BrowserWindowController.m:
805         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
806
807 2019-02-03  John Wilander  <wilander@apple.com>
808
809         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
810         https://bugs.webkit.org/show_bug.cgi?id=194104
811         <rdar://problem/47649991>
812
813         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
814
815         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
816         (TestWebKitAPI::TEST):
817             Changed numeric types from unsigned short to uint32_t.
818
819 2019-02-02  David Kilzer  <ddkilzer@apple.com>
820
821         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
822         <https://webkit.org/b/194178>
823         <rdar://problem/47753473>
824
825         Reviewed by Alexey Proskuryakov.
826
827         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
828         (WTR::uninstallFakeHelvetica): Pass nullptr into
829         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
830
831 2019-02-02  Zalan Bujtas  <zalan@apple.com>
832
833         [LFC] Initialize ICB's style with fixed width/height.
834         https://bugs.webkit.org/show_bug.cgi?id=194188
835
836         Reviewed by Antti Koivisto.
837
838         * LayoutReloaded/misc/LFC-passing-tests.txt:
839
840 2019-02-02  Zalan Bujtas  <zalan@apple.com>
841
842         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
843         https://bugs.webkit.org/show_bug.cgi?id=194185
844
845         Reviewed by Antti Koivisto.
846
847         * LayoutReloaded/misc/LFC-passing-tests.txt:
848
849 2018-12-16  Darin Adler  <darin@apple.com>
850
851         Convert additional String::format clients to alternative approaches
852         https://bugs.webkit.org/show_bug.cgi?id=192746
853
854         Reviewed by Alexey Proskuryakov.
855
856         * WebKitTestRunner/TestController.cpp:
857         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
858         as an intermediate in code that ultimately constructs a WTF::String.
859         (WTR::userMediaOriginHash): Use makeString.
860         (WTR::TestController::didNavigateWithNavigationData): More of the same.
861         (WTR::TestController::didPerformClientRedirect): Ditto.
862         (WTR::TestController::didPerformServerRedirect): Ditto.
863         (WTR::TestController::didUpdateHistoryTitle): Ditto.
864
865 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
866
867         [ews-build] Add unit test to verify builder keys
868         https://bugs.webkit.org/show_bug.cgi?id=194152
869
870         Reviewed by Lucas Forschler.
871
872         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
873         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
874
875 2019-02-01  Zalan Bujtas  <zalan@apple.com>
876
877         [LFC] Expand tests coverage (12 new tests -> 787)
878
879         Unreviewed test gardening.
880
881         * LayoutReloaded/misc/LFC-passing-tests.txt:
882
883 2019-02-01  Zalan Bujtas  <zalan@apple.com>
884
885         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
886         https://bugs.webkit.org/show_bug.cgi?id=194163
887
888         Reviewed by Simon Fraser.
889
890         775
891
892         * LayoutReloaded/misc/LFC-passing-tests.txt:
893
894 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
895
896         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
897         https://bugs.webkit.org/show_bug.cgi?id=194140
898         <rdar://problem/47728098>
899
900         Reviewed by Tim Horton.
901
902         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
903         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
904         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
905
906         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
907         test to induce an IPC deadlock when presenting a modal alert during touch start.
908
909         * WebKitTestRunner/InjectedBundle/TestRunner.h:
910         * WebKitTestRunner/TestController.cpp:
911         (WTR::runJavaScriptAlert):
912
913         Add a client callback function for running JavaScript alerts.
914
915         (WTR::TestController::createOtherPage):
916         (WTR::TestController::generateContextConfiguration const):
917
918         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
919         the fix in this patch.
920
921         (WTR::TestController::createWebViewWithOptions):
922
923         Plumb TestOptions to generateContextConfiguration.
924
925         (WTR::TestController::resetPreferencesToConsistentValues):
926         (WTR::TestController::resetStateToConsistentValues):
927         (WTR::updateTestOptionsFromTestHeader):
928         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
929         (WTR::TestController::handleJavaScriptAlert):
930         * WebKitTestRunner/TestController.h:
931         * WebKitTestRunner/TestInvocation.cpp:
932         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
933         * WebKitTestRunner/TestOptions.h:
934         (WTR::TestOptions::hasSameInitializationOptions const):
935
936 2019-02-01  Chris Dumez  <cdumez@apple.com>
937
938         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
939         https://bugs.webkit.org/show_bug.cgi?id=193740
940         <rdar://problem/47527267>
941
942         Reviewed by Alex Christensen.
943
944         Add API test coverage.
945
946         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
947
948 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
949
950         [ews-app] Add display name field to BuilderMapping model
951         https://bugs.webkit.org/show_bug.cgi?id=194153
952
953         Reviewed by Lucas Forschler.
954
955         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
956         (BuilderMapping):
957
958 2019-02-01  Youenn Fablet  <youenn@apple.com>
959
960         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
961         https://bugs.webkit.org/show_bug.cgi?id=194155
962
963         Reviewed by Eric Carlson.
964
965         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
966         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
967         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
968
969 2019-02-01  Zalan Bujtas  <zalan@apple.com>
970
971         [LFC] Adjust replaced element's intrinsic ratio
972         https://bugs.webkit.org/show_bug.cgi?id=194154
973
974         Reviewed by Antti Koivisto.
975
976         761
977
978         * LayoutReloaded/misc/LFC-passing-tests.txt:
979
980 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
981
982         [WPE] Show test results in minibrowser
983         https://bugs.webkit.org/show_bug.cgi?id=194150
984
985         Reviewed by Žan Doberšek.
986
987         * Scripts/webkitpy/port/wpe.py:
988         (WPEPort.show_results_html_file):
989
990 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
991
992         [WPE] MiniBrowser: add ky bindings for back/forward navigation
993         https://bugs.webkit.org/show_bug.cgi?id=194151
994
995         Reviewed by Žan Doberšek.
996
997         ALT + <- go back
998         ALT + -> go forward
999
1000         * MiniBrowser/wpe/main.cpp:
1001         (main):
1002
1003 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1004
1005         [LFC] Set intrinsic size on Layout::Replaced
1006         https://bugs.webkit.org/show_bug.cgi?id=194139
1007
1008         Reviewed by Antti Koivisto.
1009
1010         744
1011
1012         * LayoutReloaded/misc/LFC-passing-tests.txt:
1013
1014 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1015
1016         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1017         https://bugs.webkit.org/show_bug.cgi?id=194146
1018
1019         Reviewed by Xabier Rodriguez-Calvar.
1020
1021         It allows to open relative paths.
1022
1023         * MiniBrowser/wpe/main.cpp:
1024         (main):
1025
1026 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1027
1028         Update flakiness dashboard configuration after recent queue changes
1029         https://bugs.webkit.org/show_bug.cgi?id=194127
1030
1031         Rubber-stamped by Aakash Jain.
1032
1033         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1034
1035         * TestResultServer/static-dashboards/builders.jsonp:
1036
1037 2019-01-31  Youenn Fablet  <youenn@apple.com>
1038
1039         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1040         https://bugs.webkit.org/show_bug.cgi?id=194106
1041         <rdar://problem/47676333>
1042
1043         Reviewed by Ryosuke Niwa.
1044
1045         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1046         (TestWebKitAPI::didFinishNavigation):
1047         (TestWebKitAPI::TEST):
1048         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1049
1050 2019-01-31  Chris Dumez  <cdumez@apple.com>
1051
1052         Page zoom level is lost after a process swap or a crash
1053         https://bugs.webkit.org/show_bug.cgi?id=194105
1054         <rdar://problem/47610781>
1055
1056         Reviewed by Alex Christensen.
1057
1058         Add API test coverage.
1059
1060         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1061         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1062
1063 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1064
1065         Revert r238819 which is unneeded and caused a performance regression.
1066         https://bugs.webkit.org/show_bug.cgi?id=192272
1067         <rdar://problem/46664625>
1068
1069         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1070         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1071         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1072
1073 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1074
1075         Formalize WebKitAdditions mechanism of LoadOptimizer
1076         https://bugs.webkit.org/show_bug.cgi?id=193886
1077         <rdar://problem/47696809>
1078
1079         Reviewed by Brent Fulgham.
1080
1081         * MiniBrowser/MiniBrowser.entitlements:
1082         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1083
1084 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1085
1086         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1087         https://bugs.webkit.org/show_bug.cgi?id=194090
1088
1089         Reviewed by Antti Koivisto.
1090
1091         * LayoutReloaded/misc/LFC-passing-tests.txt:
1092
1093 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1094
1095         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1096         https://bugs.webkit.org/show_bug.cgi?id=194074
1097
1098         Reviewed by Antti Koivisto.
1099
1100         * LayoutReloaded/misc/LFC-passing-tests.txt:
1101
1102 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1103
1104         [LFC][BFC] Add support for block level replaced box.
1105         https://bugs.webkit.org/show_bug.cgi?id=194071
1106
1107         Reviewed by Antti Koivisto.
1108
1109         * LayoutReloaded/misc/LFC-passing-tests.txt:
1110
1111 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1112
1113         Fix WebKitTestRunner's testPath with Windows full paths
1114         https://bugs.webkit.org/show_bug.cgi?id=194012
1115
1116         Reviewed by Alex Christensen.
1117
1118         updateTestOptionsFromTestHeader failed to open test files because
1119         testPath returned wrong file paths. It returned a path "/C:/..."
1120         if a URL "file:///C:/..." was given.
1121
1122         * WebKitTestRunner/TestController.cpp:
1123         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1124
1125 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1126
1127         [WPE] Bump font related dependencies to match the GTK+ port
1128         https://bugs.webkit.org/show_bug.cgi?id=194017
1129
1130         Reviewed by Žan Doberšek.
1131
1132         * wpe/jhbuild.modules:
1133         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1134         * wpe/patches/icudata-stdlibs.patch: Added.
1135
1136 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1137
1138         Enable swipe tests on iOS
1139         https://bugs.webkit.org/show_bug.cgi?id=194076
1140
1141         Reviewed by Geoffrey Garen.
1142
1143         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1144         it causes a debug assertion failure in runUIScript.
1145
1146         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1147         (WTR::UIScriptController::beginBackSwipe):
1148         (WTR::UIScriptController::completeBackSwipe):
1149
1150 2019-01-30  Keith Rollin  <krollin@apple.com>
1151
1152         Use correct printf format specifier
1153         https://bugs.webkit.org/show_bug.cgi?id=194062
1154         <rdar://problem/47686167>
1155
1156         Reviewed by Alexey Proskuryakov.
1157
1158         LayoutTestSpellChecker.mm is trying to format a variable of type
1159         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1160         actually an unsigned long long. Fix this by formatting with %llu.
1161
1162         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1163         (-[LayoutTestTextCheckingResult description]):
1164
1165 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1166
1167         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1168         https://bugs.webkit.org/show_bug.cgi?id=193979
1169
1170         Reviewed by Wenson Hsieh.
1171
1172         Fix the test for iOS. Make the test work with iOS UA string.
1173
1174         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1175
1176 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1177
1178         Replace High Sierra LLINT CLoop bot due to hardware failure
1179         https://bugs.webkit.org/show_bug.cgi?id=194066
1180
1181         Reviewed by Aakash Jain.
1182
1183         * BuildSlaveSupport/build.webkit.org-config/config.json:
1184
1185 2019-01-30  Keith Rollin  <krollin@apple.com>
1186
1187         [NSDragItem init] is unavailable
1188         https://bugs.webkit.org/show_bug.cgi?id=194059
1189         <rdar://problem/47685715>
1190
1191         Reviewed by Wenson Hsieh.
1192
1193         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1194         DumpRenderTree and TestWebKitAPI, which both try to create an
1195         NSDragItem in a manner that invokes this method. Address this by using
1196         -initWithPasteboardWriter instead.
1197
1198         Note that the parameter passed to initWithPasteboardWriter is likely
1199         incorrect. In both cases, the object passed does not conform to
1200         NSPasteboardWriting. However, with this fix, we're no worse off than
1201         before, and can now perform builds with newer compilers and SDKs until
1202         a real fix can be crafted. That work is tracked in
1203         https://bugs.webkit.org/show_bug.cgi?id=194060
1204
1205         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1206         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1207         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1208         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1209
1210 2019-01-30  Daniel Bates  <dabates@apple.com>
1211
1212         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1213         https://bugs.webkit.org/show_bug.cgi?id=192824
1214         <rdar://problem/47100332>
1215
1216         Reviewed by Wenson Hsieh.
1217
1218         Fix a bug where the wrong usage code was used for F13 thru F24.
1219
1220         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1221         (keyCodeForDOMFunctionKey):
1222
1223 2019-01-30  Chris Dumez  <cdumez@apple.com>
1224
1225         Regression(PSON) Load hang can occur on history navigation
1226         https://bugs.webkit.org/show_bug.cgi?id=194030
1227         <rdar://problem/47656939>
1228
1229         Reviewed by Antti Koivisto.
1230
1231         Add API test coverage.
1232
1233         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1234
1235 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1236
1237         [LFC] Expand tests coverage.
1238
1239         Unreviewed test gardening.
1240
1241         * LayoutReloaded/misc/LFC-passing-tests.txt:
1242
1243 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1244
1245         [Flatpak] Add openjpeg support
1246         https://bugs.webkit.org/show_bug.cgi?id=194019
1247
1248         Reviewed by Michael Catanzaro.
1249
1250         * flatpak/org.webkit.CommonModules.yaml:
1251
1252 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1253
1254         Unreviewed, rolling out r240708.
1255         https://bugs.webkit.org/show_bug.cgi?id=194022
1256
1257         It broke WPE build (Requested by KaL on #webkit).
1258
1259         Reverted changeset:
1260
1261         "[WPE] Bump font related dependencies to match the GTK+ port"
1262         https://bugs.webkit.org/show_bug.cgi?id=194017
1263         https://trac.webkit.org/changeset/240708
1264
1265 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1266
1267         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1268         https://bugs.webkit.org/show_bug.cgi?id=194001
1269
1270         Reviewed by Antti Koivisto.
1271
1272         * LayoutReloaded/misc/LFC-passing-tests.txt:
1273
1274 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1275
1276         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1277         https://bugs.webkit.org/show_bug.cgi?id=194020
1278
1279         Reviewed by Antti Koivisto.
1280
1281         * LayoutReloaded/misc/LFC-passing-tests.txt:
1282
1283 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1284
1285         AX: Support color well on iOS
1286         https://bugs.webkit.org/show_bug.cgi?id=194010
1287
1288         Reviewed by Joanmarie Diggs.
1289
1290         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1291         (WTR::AccessibilityUIElement::stringAttributeValue):
1292
1293 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1294
1295         [WPE] Bump font related dependencies to match the GTK+ port
1296         https://bugs.webkit.org/show_bug.cgi?id=194017
1297
1298         Reviewed by Žan Doberšek.
1299
1300         * wpe/jhbuild.modules:
1301         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1302         * wpe/patches/icudata-stdlibs.patch: Added.
1303
1304 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1305
1306         [Mac] Update window scale API usage
1307         https://bugs.webkit.org/show_bug.cgi?id=193991
1308         rdar://problem/47614795
1309
1310         Reviewed by Tim Horton.
1311
1312         * DumpRenderTree/mac/DumpRenderTree.mm:
1313         (changeWindowScaleIfNeeded):
1314         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1315         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1316         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1317
1318 2019-01-29  Chris Dumez  <cdumez@apple.com>
1319
1320         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1321         https://bugs.webkit.org/show_bug.cgi?id=193977
1322         <rdar://problem/47643716>
1323
1324         Reviewed by Geoff Garen.
1325
1326         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1327         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1328         to the previous provisional committing *before* we make the last load. 
1329
1330         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1331
1332 2019-01-29  Youenn Fablet  <youenn@apple.com>
1333
1334         Adopt new SPI to evaluate server certificate trust
1335         https://bugs.webkit.org/show_bug.cgi?id=193355
1336
1337         Reviewed by Alex Christensen.
1338
1339         Add infrastructure to handle HTTPS server trust evaluation testing.
1340
1341         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1342         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1343         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1344         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1345         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1346         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1347         * WebKitTestRunner/TestController.cpp:
1348         (WTR::TestController::resetPreferencesToConsistentValues):
1349         (WTR::TestController::didReceiveAuthenticationChallenge):
1350         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1351         * WebKitTestRunner/TestController.h:
1352         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1353         * WebKitTestRunner/TestInvocation.cpp:
1354         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1355         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1356         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1357
1358 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1359
1360         [ews-build] Add build step to print bot Configuration
1361         https://bugs.webkit.org/show_bug.cgi?id=193887
1362
1363         Reviewed by Lucas Forschler.
1364
1365         * BuildSlaveSupport/ews-build/steps.py:
1366         (PrintConfiguration): Build step to print configuration.
1367         * BuildSlaveSupport/ews-build/factories.py:
1368
1369 2019-01-29  Chris Dumez  <cdumez@apple.com>
1370
1371         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1372         https://bugs.webkit.org/show_bug.cgi?id=193967
1373         <rdar://problem/47635348>
1374
1375         Reviewed by Alex Christensen.
1376
1377         Add API test coverage.
1378
1379         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1380         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1381
1382 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1383
1384         [ews-app] Handle incoming results data
1385         https://bugs.webkit.org/show_bug.cgi?id=193973
1386
1387         Reviewed by Lucas Forschler.
1388
1389         * BuildSlaveSupport/ews-app/ews/views/results.py:
1390
1391 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1392
1393         [ews-app] Make the results url generic
1394         https://bugs.webkit.org/show_bug.cgi?id=193928
1395
1396         Reviewed by Lucas Forschler.
1397
1398         * BuildSlaveSupport/ews-app/ews/urls.py:
1399
1400 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1401
1402         [ews-build] Configure buildbot to send events to ews-app
1403         https://bugs.webkit.org/show_bug.cgi?id=193968
1404
1405         Reviewed by Lucas Forschler.
1406
1407         * BuildSlaveSupport/ews-build/events.py: Added.
1408         * BuildSlaveSupport/ews-build/master.cfg:
1409
1410 2019-01-29  Keith Rollin  <krollin@apple.com>
1411
1412         Add .xcfilelists to Run Script build phases
1413         https://bugs.webkit.org/show_bug.cgi?id=193792
1414         <rdar://problem/47201785>
1415
1416         Reviewed by Alex Christensen.
1417
1418         As part of supporting XCBuild, update the necessary Run Script build
1419         phases in their Xcode projects to refer to their associated
1420         .xcfilelist files.
1421
1422         Note that the addition of these files bumps the Xcode project version
1423         number to something that's Xcode 10 compatible. This change means that
1424         older versions of the Xcode IDE can't read these projects. Nor can it
1425         fully load workspaces that refer to these projects (the updated
1426         projects are shown as non-expandable placeholders). `xcodebuild` can
1427         still build these projects; it's just that the IDE can't open them.
1428
1429         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1430         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1431
1432 2019-01-29  John Wilander  <wilander@apple.com>
1433
1434         Add data abstraction and validation for Ad Click Attribution
1435         https://bugs.webkit.org/show_bug.cgi?id=193916
1436         <rdar://problem/47603481>
1437
1438         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1439
1440         Ad click attribution has two steps. First, the storage of an ad
1441         campaign ID for a click that takes the user to a destination
1442         site. Second, a conversion on the destination site that can be
1443         attributed to the ad click.
1444
1445         This patch adds a class that represents a request for ad click
1446         attribution. Validation makes sure that the bits of entropy
1447         reported through this mechanism is limited.
1448
1449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1450         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1451         (TestWebKitAPI::TEST):
1452
1453 2019-01-29  Chris Dumez  <cdumez@apple.com>
1454
1455         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1456         https://bugs.webkit.org/show_bug.cgi?id=193932
1457         <rdar://problem/47598947>
1458
1459         Reviewed by Brady Eidson.
1460
1461         Add API test coverage.
1462
1463         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1464
1465 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1466
1467         Adding new passing LFC tests.
1468
1469         Unreviewed test gardening.
1470
1471         * LayoutReloaded/misc/LFC-passing-tests.txt:
1472
1473 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1474
1475         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1476         https://bugs.webkit.org/show_bug.cgi?id=193964
1477
1478         Reviewed by Antti Koivisto.
1479
1480         * LayoutReloaded/misc/LFC-passing-tests.txt:
1481
1482 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1483
1484         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1485         https://bugs.webkit.org/show_bug.cgi?id=193954
1486
1487         Reviewed by Antti Koivisto.
1488
1489         * LayoutReloaded/misc/LFC-passing-tests.txt:
1490
1491 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1492
1493         WebDriver: add support for running subtests
1494         https://bugs.webkit.org/show_bug.cgi?id=193904
1495
1496         Reviewed by Michael Catanzaro.
1497
1498         pytest already supports it by passing test.py::subtest, so we can do the same.
1499
1500         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1501         (get_item_name): Made this global.
1502         (CollectRecorder.__init__): Receive the parameter to ignore.
1503         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1504         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1505         (collect): Add parameter to ignore.
1506         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1507         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1508         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1509         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1510         (WebDriverTestRunnerSelenium.run): Ditto.
1511         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1512         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1513         (WebDriverTestRunnerW3C.run): Ditto.
1514
1515 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1516
1517         User agent string override for navigator.userAgent should be site specific quirks
1518         https://bugs.webkit.org/show_bug.cgi?id=193950
1519
1520         Reviewed by Brent Fulgham.
1521
1522         Updated per the _WKWebsitePolicies rename.
1523
1524         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1525         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1526
1527 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1528
1529         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1530         https://bugs.webkit.org/show_bug.cgi?id=193941
1531
1532         Reviewed by Alex Christensen.
1533
1534         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1535         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1536         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1537         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1538         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1539         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1540         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1541         * TestWebKitAPI/Tests/WTF/Time.cpp:
1542         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1543         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1544         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1545         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1546
1547 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1548
1549         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1550
1551         * Scripts/webkitpy/common/config/contributors.json:
1552
1553 2019-01-28  Andy Estes  <aestes@apple.com>
1554
1555         [watchOS] Enable Parental Controls content filtering
1556         https://bugs.webkit.org/show_bug.cgi?id=193939
1557         <rdar://problem/46641912>
1558
1559         Reviewed by Ryosuke Niwa.
1560
1561         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1562
1563 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1564
1565         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1566         <https://webkit.org/b/193884>
1567
1568         Reviewed by Jiewen Tan.
1569
1570         * Scripts/webkitpy/style/checkers/cpp.py:
1571         (check_language): Add LocalAuthentication to
1572         `frameworks_with_soft_links`.
1573
1574 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1575
1576         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1577         https://bugs.webkit.org/show_bug.cgi?id=193891
1578
1579         Reviewed by Ross Kirsling.
1580
1581         There were three problems in window sizes of WebView and the host window.
1582         1. The sizes of pixel image output were incorrect.
1583         2. The host window is going to appear after window.resize was invoked.
1584         3. window.resize resized only the host window, not WebView.
1585
1586         This change solves them with a following approach.
1587         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1588         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1589            as well as DumpRenderTree in order to match the client area and the window area.
1590         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1591         d. PlatformWebView::setWindowFrame changes both window sizes.
1592         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1593
1594         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1595         (WTR::PlatformWebView::PlatformWebView): Create the host window
1596         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1597         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1598         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1599
1600 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1601
1602         [ews-app] Add method to save Step data to database
1603         https://bugs.webkit.org/show_bug.cgi?id=193890
1604
1605         Reviewed by Lucas Forschler.
1606
1607         * BuildSlaveSupport/ews-app/ews/models/step.py:
1608         (Step.save_step): Method to save step data.
1609         (Step.update_step): Method to update step data.
1610         (Step.get_existing_step): Method to fetch existing step from database.
1611         (Step.is_valid_result): Method to validate valid step result.
1612
1613 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1614
1615         [ews-app] Add method to save Build data to database
1616         https://bugs.webkit.org/show_bug.cgi?id=193735
1617
1618         Reviewed by Lucas Forschler.
1619
1620         * BuildSlaveSupport/ews-app/ews/models/build.py:
1621         (Build.save_build): Method to save build information to database.
1622         (Build.get_existing_build): Method to fetch existing build from database.
1623         (Build.is_valid_result): Method to validate build result.
1624         * BuildSlaveSupport/ews-app/ews/common/util.py:
1625         (is_valid_int_id): Method to validate valid id.
1626
1627 2019-01-28  Chris Dumez  <cdumez@apple.com>
1628
1629         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1630         https://bugs.webkit.org/show_bug.cgi?id=193915
1631         <rdar://problem/47560907>
1632
1633         Reviewed by Alex Christensen.
1634
1635         Add API test coverage.
1636
1637         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1638
1639 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1640
1641         [ews-app] Rename id variables
1642         https://bugs.webkit.org/show_bug.cgi?id=193883
1643
1644         Reviewed by Lucas Forschler.
1645
1646         * BuildSlaveSupport/ews-app/ews/models/build.py:
1647         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1648         * BuildSlaveSupport/ews-app/ews/models/step.py:
1649         * BuildSlaveSupport/ews-app/ews/urls.py:
1650         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1651         * BuildSlaveSupport/ews-app/ews/views/results.py:
1652         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1653
1654 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1655
1656         [ews-app] Allow certain fields to be empty
1657         https://bugs.webkit.org/show_bug.cgi?id=193892
1658
1659         Reviewed by Lucas Forschler.
1660
1661         * BuildSlaveSupport/ews-app/ews/models/build.py:
1662         * BuildSlaveSupport/ews-app/ews/models/step.py:
1663
1664 2019-01-28  Rob Buis  <rbuis@igalia.com>
1665
1666         Update MIME type parser
1667         https://bugs.webkit.org/show_bug.cgi?id=180526
1668
1669         Reviewed by Frédéric Wang.
1670
1671         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1672         (TestWebKitAPI::TEST):
1673
1674 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1675
1676         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1677         https://bugs.webkit.org/show_bug.cgi?id=193896
1678
1679         Reviewed by Antti Koivisto.
1680
1681         * LayoutReloaded/misc/LFC-passing-tests.txt:
1682
1683 2018-12-15  Darin Adler  <darin@apple.com>
1684
1685         Replace many uses of String::format with more type-safe alternatives
1686         https://bugs.webkit.org/show_bug.cgi?id=192742
1687
1688         Reviewed by Mark Lam.
1689
1690         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1691         (WTR::cacheTestRunnerCallback): Use makeString.
1692         * WebKitTestRunner/TestController.cpp:
1693         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1694         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1695
1696 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1697
1698         Use a load optimizer for some sites
1699         https://bugs.webkit.org/show_bug.cgi?id=193881
1700         <rdar://problem/46325455>
1701
1702         Reviewed by Brent Fulgham.
1703
1704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1705         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1706
1707 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1708
1709         AX: Introduce a static accessibility tree
1710         https://bugs.webkit.org/show_bug.cgi?id=193348
1711         <rdar://problem/47203295>
1712
1713         Reviewed by Ryosuke Niwa.
1714
1715         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1716
1717 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1718
1719         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1720         https://bugs.webkit.org/show_bug.cgi?id=193867
1721
1722         Reviewed by Antti Koivisto.
1723
1724         * LayoutReloaded/misc/LFC-passing-tests.txt:
1725
1726 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1727
1728         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1729         https://bugs.webkit.org/show_bug.cgi?id=193865
1730
1731         Reviewed by Antti Koivisto.
1732
1733         * LayoutReloaded/misc/LFC-passing-tests.txt:
1734
1735 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1736
1737         Need a mechanism to override navigator.userAgent
1738         https://bugs.webkit.org/show_bug.cgi?id=193762
1739         <rdar://problem/47504939>
1740
1741         Reviewed by Brent Fulgham.
1742
1743         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1744
1745         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1746         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1747         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1748
1749 2019-01-25  Dean Jackson  <dino@apple.com>
1750
1751         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1752         https://bugs.webkit.org/show_bug.cgi?id=193831
1753         <rdar://problem/47399263>
1754
1755         Reviewed by Chris Dumez.
1756
1757         Two new tests that exercise cross-origin and same-origin System
1758         Previews.
1759
1760         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1761
1762 2019-01-25  Keith Rollin  <krollin@apple.com>
1763
1764         Update Xcode projects with "Check .xcfilelists" build phase
1765         https://bugs.webkit.org/show_bug.cgi?id=193790
1766         <rdar://problem/47201374>
1767
1768         Reviewed by Alex Christensen.
1769
1770         Support for XCBuild includes specifying inputs and outputs to various
1771         Run Script build phases. These inputs and outputs are specified as
1772         .xcfilelist files. Once created, these .xcfilelist files need to be
1773         kept up-to-date. In order to check that they are up-to-date or not,
1774         add an Xcode build step that invokes an external script that performs
1775         the checking. If the .xcfilelists are found to be out-of-date, update
1776         them, halt the build, and instruct the developer to restart the build
1777         with up-to-date files.
1778
1779         At this time, the checking and regenerating is performed only if the
1780         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1781         who want to use this facility can set this variable and test out the
1782         checking/regenerating. Once it seems like there are no egregious
1783         issues that upset a developer's workflow, we'll unconditionally enable
1784         this facility.
1785
1786         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1787         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1788         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1789         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1790
1791 2019-01-25  Keith Rollin  <krollin@apple.com>
1792
1793         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1794         https://bugs.webkit.org/show_bug.cgi?id=193781
1795         <rdar://problem/47201153>
1796
1797         Reviewed by Alex Christensen.
1798
1799         Part of generating the .xcfilelists used as part of adopting XCBuild
1800         includes running `make DerivedSources.make` from a standalone script.
1801         It’s important for this invocation to have the same environment as
1802         when the actual build invokes `make DerivedSources.make`. If the
1803         environments are different, then the two invocations will provide
1804         different results. In order to get the same environment in the
1805         standalone script, have the script launch xcodebuild targeting the
1806         "Apply Configuration to XCFileLists" build target, which will then
1807         re-invoke our standalone script. The script is now running again, this
1808         time in an environment with all workspace, project, target, xcconfig
1809         and other environment variables established.
1810
1811         The "Apply Configuration to XCFileLists" build target accomplishes
1812         this task via a small embedded shell script that consists only of:
1813
1814             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1815
1816         The process that invokes "Apply Configuration to XCFileLists" first
1817         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1818         evaluated and exports it into the shell environment. When xcodebuild
1819         is invoked, it inherits the value of this variable and can `eval` the
1820         contents of that variable. Our external standalone script can then set
1821         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1822         of command-line parameters needed to restart itself in the appropriate
1823         state.
1824
1825         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1826         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1827
1828 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1829
1830         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1831         https://bugs.webkit.org/show_bug.cgi?id=193802
1832         <rdar://problem/46010580>
1833
1834         Reviewed by Andy Estes.
1835
1836         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1837         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1838         (TEST):
1839
1840 2019-01-25  Daniel Bates  <dabates@apple.com>
1841
1842         [iOS] uiController.keyDown() does not translate Control modified key
1843         https://bugs.webkit.org/show_bug.cgi?id=192898
1844
1845         Reviewed by Wenson Hsieh.
1846
1847         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1848         key translation, as applicable. Among other cases, key translation occurs when performing
1849         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1850         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1851         human pressing down and releasing key(s) using a hardware keyboard.
1852
1853         * WebKitTestRunner/ios/HIDEventGenerator.h:
1854         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1855         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1856
1857         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1858         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1859         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1860         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1861         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1862         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1863         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1864         (-[HIDEventGenerator longPress:completionBlock:]):
1865         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1866         Update code for above renaming.
1867
1868         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1869         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1870
1871         (-[HIDEventGenerator keyDown:]): Added.
1872         (-[HIDEventGenerator keyUp:]): Added.
1873         (-[HIDEventGenerator keyPress:completionBlock:]):
1874         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1875         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1876         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1877         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1878         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1879         (WTR::parseModifier): Deleted.
1880
1881 2019-01-25  Keith Rollin  <krollin@apple.com>
1882
1883         Complete the implementation of generate-xcfilelists
1884         https://bugs.webkit.org/show_bug.cgi?id=193782
1885
1886         Reviewed by Alex Christensen.
1887
1888         A preliminary version of generate-xcfilelists was added in r238008.
1889         This patch updates that script in order to:
1890
1891         - Support checking of .xcfilelists
1892         - Perform better execution of `make DerivedSources.make` by
1893           relaunching generate-xcfilelists under xcodebuild
1894         - Support incremental generation and checking of .xcfilelists
1895         - Support supplementary .xcfilelists files from WebKitAdditions
1896         - Support being wrapped by parallel version of generate-xcfilelists in
1897           Internal that adds support for (re)generating WebKit projects in
1898           that repo.
1899         - Support builds that have been performed in WebKitBuild as well as
1900           ~/Library/Developer/code/DerivedData
1901         - Increase robustness and debugging facilities.
1902
1903         * Scripts/generate-xcfilelists:
1904
1905 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1906
1907         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1908         https://bugs.webkit.org/show_bug.cgi?id=193297
1909         <rdar://problem/47158841>
1910
1911         Unreviewed test case fix.
1912
1913         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1914         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1915
1916         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1917         (TEST):
1918
1919 2019-01-25  Keith Rollin  <krollin@apple.com>
1920
1921         Update existing .xcfilelists
1922         https://bugs.webkit.org/show_bug.cgi?id=193791
1923         <rdar://problem/47201706>
1924
1925         Reviewed by Alex Christensen.
1926
1927         Many .xcfilelist files were added in r238824 in order to support
1928         XCBuild. Update these with recent changes to the set of build files
1929         and with the current generate-xcfilelist script.
1930
1931         * DumpRenderTree/DerivedSources-input.xcfilelist:
1932         * DumpRenderTree/DerivedSources-output.xcfilelist:
1933         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1934         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1935
1936 2019-01-25  Keith Rollin  <krollin@apple.com>
1937
1938         Fix missing dependencies in extract-dependencies-from-makefile
1939         https://bugs.webkit.org/show_bug.cgi?id=193783
1940         <rdar://problem/47201571>
1941
1942         Reviewed by Alex Christensen.
1943
1944         The extract-dependencies-from-makefile script generates .xcfilelists
1945         for XCBuild by invoking a makefile in --debug mode, parsing the
1946         dependency information in the output, and extracting information
1947         regarding targets and dependents. However, the way `make` emits this
1948         dependency information is not rigorous, and so we need to determine
1949         what lines to look for and parse by trial and error. This approach
1950         didn't coriginally atch all the information we needed to collect, so
1951         update the script to look for the additional lines we now know to look
1952         for.
1953
1954         * Scripts/extract-dependencies-from-makefile:
1955         (Parser):
1956         (Parser.addTarget):
1957         (Parser.addPrereq):
1958         (Parser.doParse):
1959
1960 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1961
1962         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1963         https://bugs.webkit.org/show_bug.cgi?id=193297
1964         <rdar://problem/47158841>
1965
1966         Reviewed by Alex Christensen.
1967
1968         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1969             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1970         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1971         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1972         activating the message used to trigger the callback when it is set.
1973
1974 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1975
1976         WKWebView.goBack should reload if there is a safe browsing warning
1977         https://bugs.webkit.org/show_bug.cgi?id=193805
1978         <rdar://problem/46908216>
1979
1980         Reviewed by Geoff Garen.
1981
1982         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1983         (+[Simple3LookupContext sharedLookupContext]):
1984         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1985         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1986         (TEST):
1987
1988 2019-01-25  Chris Dumez  <cdumez@apple.com>
1989
1990         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1991         https://bugs.webkit.org/show_bug.cgi?id=193788
1992         <rdar://problem/47531231>
1993
1994         Reviewed by Alex Christensen.
1995
1996         Add API test coverage.
1997
1998         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1999         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2000
2001 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2002
2003         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2004         https://bugs.webkit.org/show_bug.cgi?id=193771
2005
2006         Unreviewed infrastructure fix.
2007
2008         * Scripts/webkitpy/port/darwin.py:
2009         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2010
2011 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2012
2013         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2014
2015 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2016
2017         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2018
2019         * Scripts/webkitpy/common/config/contributors.json:
2020
2021 2019-01-25  Chris Dumez  <cdumez@apple.com>
2022
2023         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2024         https://bugs.webkit.org/show_bug.cgi?id=193779
2025         <rdar://problem/46170903>
2026
2027         Reviewed by Antti Koivisto.
2028
2029         Add API test that quickly navigates forward to a previous process without waiting for it to
2030         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2031         the process' previous page when reconnecting the it for the forward navigation.
2032
2033         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2034
2035 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2036
2037         Need a way for JavaScript (or bundle) code to participate in undo
2038         https://bugs.webkit.org/show_bug.cgi?id=190009
2039         <rdar://problem/44807048>
2040
2041         Reviewed by Ryosuke Niwa.
2042
2043         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2044         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2045
2046         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2047         (WTR::UIScriptController::lastUndoLabel const):
2048         (WTR::UIScriptController::firstRedoLabel const):
2049         (WTR::UIScriptController::platformUndoManager const):
2050         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2051         (WTR::UIScriptController::lastUndoLabel const):
2052         (WTR::UIScriptController::firstRedoLabel const):
2053         (WTR::UIScriptController::platformUndoManager const):
2054         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2055         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2056         (WTR::UIScriptController::lastUndoLabel const):
2057         (WTR::UIScriptController::firstRedoLabel const):
2058         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2059         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2060         (WTR::UIScriptController::lastUndoLabel const):
2061         (WTR::UIScriptController::firstRedoLabel const):
2062         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2063         (WTR::UIScriptController::platformUndoManager const):
2064         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2065         (WTR::UIScriptController::platformUndoManager const):
2066
2067 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2068
2069         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2070         https://bugs.webkit.org/show_bug.cgi?id=193824
2071
2072         Reviewed by Antti Koivisto.
2073
2074         * LayoutReloaded/misc/LFC-passing-tests.txt:
2075
2076 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2077
2078         Update macOS JSC bot configurations
2079         https://bugs.webkit.org/show_bug.cgi?id=193739
2080
2081         Reviewed by Alexey Proskuryakov.
2082
2083         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2084         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2085         (BubbleQueueServer): Move JSC EWS to Mojave section.
2086         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2087         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2088         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2089
2090 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2091
2092         [Win][WebKitTestRunner] Implement EventSenderProxy
2093         https://bugs.webkit.org/show_bug.cgi?id=193755
2094
2095         Reviewed by Don Olmstead.
2096
2097         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2098         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2099         (WTR::EventSenderProxy::dispatchMessage):
2100         (WTR::EventSenderProxy::EventSenderProxy):
2101         (WTR::EventSenderProxy::mouseDown):
2102         (WTR::EventSenderProxy::mouseUp):
2103         (WTR::EventSenderProxy::mouseMoveTo):
2104         (WTR::EventSenderProxy::mouseScrollBy):
2105         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2106
2107 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2108
2109         Unreviewed fix for API test failure after r240437.
2110
2111         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2112
2113         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2114
2115 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2116
2117         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2118         https://bugs.webkit.org/show_bug.cgi?id=193787
2119         <rdar://problem/47497634>
2120
2121         Reviewed by Alexey Proskuryakov.
2122
2123         * Scripts/webkitdirs.pm:
2124         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2125
2126 2019-01-24  Truitt Savell  <tsavell@apple.com>
2127
2128         Unreviewed, rolling out r240446.
2129
2130         Casued 5 API failures
2131
2132         Reverted changeset:
2133
2134         "Activate the WebResourceLoadStatisticsStore in the
2135         NetworkProcess and deactivate it in the UIProcess."
2136         https://bugs.webkit.org/show_bug.cgi?id=193297
2137         https://trac.webkit.org/changeset/240446
2138
2139 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2140
2141         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2142         https://bugs.webkit.org/show_bug.cgi?id=193741
2143         <rdar://problem/47135030>
2144
2145         Reviewed by Antti Koivisto and Simon Fraser.
2146
2147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2148         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2149         (TestWebKitAPI::TEST):
2150
2151 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2152
2153         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2154         https://bugs.webkit.org/show_bug.cgi?id=193297
2155         <rdar://problem/47158841>
2156
2157         Reviewed by Alex Christensen.
2158
2159         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2160         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2161         activating the message used to trigger the callback when it is set.
2162
2163 2019-01-24  John Wilander  <wilander@apple.com>
2164
2165         Add Ad Click Attribution as an internal/experimental feature
2166         https://bugs.webkit.org/show_bug.cgi?id=193685
2167         <rdar://problem/47450399>
2168
2169         Reviewed by Brent Fulgham.
2170
2171         Added test option adClickAttributionEnabled.
2172
2173         * DumpRenderTree/TestOptions.cpp:
2174         (TestOptions::TestOptions):
2175         * DumpRenderTree/TestOptions.h:
2176         * DumpRenderTree/mac/DumpRenderTree.mm:
2177         (setWebPreferencesForTestOptions):
2178
2179 2019-01-24  Antti Koivisto  <antti@apple.com>
2180
2181         [PSON] Flash on back navigation on Mac
2182         https://bugs.webkit.org/show_bug.cgi?id=193716
2183         <rdar://problem/47148458>
2184
2185         Reviewed by Chris Dumez.
2186
2187         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2188
2189         Closing of the previous page is delayed so waiting for didFinishNavigation is
2190         not sufficient to guarantee we have received all the messages. Wait for them.
2191
2192 2019-01-24  Chris Dumez  <cdumez@apple.com>
2193
2194         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2195         https://bugs.webkit.org/show_bug.cgi?id=193761
2196         <rdar://problem/47456405>
2197
2198         Reviewed by Alex Christensen.
2199
2200         Add API test coverage.
2201
2202         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2203
2204 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2205
2206         webkitpy: Missing PID in crashlog name should not be fatal
2207         https://bugs.webkit.org/show_bug.cgi?id=193771
2208
2209         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2210         of raising an exception.
2211
2212         Reviewed by Lucas Forschler.
2213
2214         * Scripts/webkitpy/port/darwin.py:
2215         (DarwinPort._merge_crash_logs):
2216
2217 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2218
2219         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2220         https://bugs.webkit.org/show_bug.cgi?id=193746
2221
2222         Reviewed by Youenn Fablet.
2223
2224         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2225         so we'd best just not call it.
2226
2227         * Scripts/webkitpy/w3c/test_exporter.py:
2228         (WebPlatformTestExporter.create_branch_with_patch):
2229
2230 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2231
2232         Move FileSystem to WTF
2233         https://bugs.webkit.org/show_bug.cgi?id=193602
2234
2235         Reviewed by Yusuke Suzuki.
2236
2237         * DumpRenderTree/win/DumpRenderTree.cpp:
2238         * TestWebKitAPI/CMakeLists.txt:
2239         * TestWebKitAPI/PlatformGTK.cmake:
2240         * TestWebKitAPI/PlatformJSCOnly.cmake:
2241         * TestWebKitAPI/PlatformPlayStation.cmake:
2242         * TestWebKitAPI/PlatformWPE.cmake:
2243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2244         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2245         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2246         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2247         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2248         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2249         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2250         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2251         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2252         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2253
2254 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2255
2256         [WPE] Remove hard dependency on subprocess32 for the API tests
2257
2258         Rubber-stamped by Carlos Garcia Campos.
2259
2260         * glib/api_test_runner.py:
2261         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2262         its presence only when running WPEQt tests.
2263
2264 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2265
2266         [GLIB] Expose JavaScriptCore options in GLib public API
2267         https://bugs.webkit.org/show_bug.cgi?id=188742
2268
2269         Reviewed by Michael Catanzaro.
2270
2271         Add a test for the new API.
2272
2273         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2274         (testsJSCOptions):
2275         (main):
2276
2277 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2278
2279         [GTK][WPE] Support JPEG 2000 images
2280         https://bugs.webkit.org/show_bug.cgi?id=186272
2281
2282         Reviewed by Žan Doberšek.
2283
2284         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2285
2286         * gtk/jhbuild.modules:
2287         * wpe/jhbuild.modules:
2288
2289 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2290
2291         check-webkit-style should warn when using soft-linking macros in a header
2292         <https://webkit.org/b/193750>
2293
2294         Reviewed by Darin Adler.
2295
2296         * Scripts/webkitpy/style/checkers/cpp.py:
2297         (check_language): Add softlink/header check by refactoring the
2298         softlink/framework check.
2299         (CppChecker): Enable softlink/header check by default.
2300         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2301         (CppStyleTest.test_softlink_framework): Rename from
2302         CppStyleTest.test_softlink() and change test framework name in
2303         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2304         files. Set file_name for macros that only appear in headers.
2305         (CppStyleTest.test_softlink_header): Add tests for using
2306         soft-link macros in headers.
2307
2308 2019-01-23  Chris Dumez  <cdumez@apple.com>
2309
2310         Deprecate API to limit the maximum number of WebProcesses
2311         https://bugs.webkit.org/show_bug.cgi?id=193725
2312         <rdar://problem/47464879>
2313
2314         Reviewed by Geoff Garen.
2315
2316         Update existing API tests to stop using deprecated API.
2317
2318         * MiniBrowser/mac/AppDelegate.m:
2319         (defaultConfiguration):
2320         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2321         (TestWebKitAPI::TEST):
2322         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2323         (TestWebKitAPI::TEST):
2324         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2325         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2326         (TEST):
2327         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2328         (TEST):
2329
2330 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2331
2332         [ews-app] Rename ews model buildermappings to buildermapping
2333         https://bugs.webkit.org/show_bug.cgi?id=193729
2334
2335         Reviewed by Lucas Forschler.
2336
2337         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2338         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2339         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2340
2341 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2342
2343         [ews-app] Rename ews model steps to step
2344         https://bugs.webkit.org/show_bug.cgi?id=193697
2345
2346         Reviewed by Lucas Forschler.
2347
2348         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2349         (Step): Renamed Steps to Step.
2350
2351 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2352
2353         Clean up IndexedDB files between tests
2354         https://bugs.webkit.org/show_bug.cgi?id=192796
2355         <rdar://problem/46824999>
2356
2357         Reviewed by Geoffrey Garen.
2358
2359         * DumpRenderTree/mac/DumpRenderTree.mm:
2360         (runTest):
2361         * WebKitTestRunner/TestController.cpp:
2362         (WTR::TestController::resetStateToConsistentValues):
2363         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2364         (WTR::RemoveAllIndexedDatabasesCallback):
2365         (WTR::TestController::ClearIndexedDatabases):
2366         * WebKitTestRunner/TestController.h:
2367         * WebKitTestRunner/TestInvocation.cpp:
2368         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2369
2370 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2371
2372         [ews-app] Rename ews model Builds to Build
2373         https://bugs.webkit.org/show_bug.cgi?id=193695
2374
2375         Reviewed by Lucas Forschler.
2376
2377         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2378         (Build): Renamed Builds to Build.
2379
2380 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2381
2382         webkitpy: Wait longer when launching WebKitTestRunner
2383         https://bugs.webkit.org/show_bug.cgi?id=193734
2384
2385         Reviewed by Aakash Jain.
2386
2387         * Scripts/webkitpy/port/simulator_process.py:
2388         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2389
2390 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2391
2392         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2393         https://bugs.webkit.org/show_bug.cgi?id=193182
2394         <rdar://problem/47452154>
2395
2396         Reviewed by Tim Horton.
2397
2398         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2399         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2400         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2401
2402         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2403         preventing later tests from recognizing gestures.
2404
2405         * WebKitTestRunner/ios/TestControllerIOS.mm:
2406         (WTR::TestController::platformResetStateToConsistentValues):
2407
2408         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2409
2410 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2411
2412         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2413         https://bugs.webkit.org/show_bug.cgi?id=193722
2414         <rdar://problem/47481475>
2415
2416         Reviewed by Lucas Forschler.
2417
2418         iPhone and iPad ports should both use the iOS config.
2419
2420         * Scripts/webkitpy/port/ios_simulator.py:
2421         (IPhoneSimulatorPort.__init__):
2422         (IPadSimulatorPort.__init__):
2423
2424 2019-01-23  Rob Buis  <rbuis@igalia.com>
2425
2426         Update MIME type parser
2427         https://bugs.webkit.org/show_bug.cgi?id=180526
2428
2429         Reviewed by Frédéric Wang.
2430
2431         Add unit tests for both parse modes of ParsedContentType.
2432
2433         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2434         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2435         (TestWebKitAPI::TEST):
2436
2437 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2438
2439         [ews-app] fetch loop should not stop on network issues
2440         https://bugs.webkit.org/show_bug.cgi?id=193666
2441
2442         Reviewed by Lucas Forschler.
2443
2444         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2445         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2446
2447 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2448
2449         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2450         https://bugs.webkit.org/show_bug.cgi?id=189165
2451         <rdar://problem/47433765>
2452
2453         Reviewed by Tim Horton.
2454
2455         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2456         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2457         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2458         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2459         would make its way to the UI process by the time the layer tree commit is finished.
2460
2461         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2462         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2463         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2464         will fail because it asks for -_autofillContext too early.
2465
2466         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2467         is handled in the UI process.
2468
2469         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2470
2471         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2472         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2473         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2474         input session.
2475
2476         (-[AutofillTestView textInputHasAutofillContext]):
2477
2478         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2479
2480         * TestWebKitAPI/cocoa/TestWKWebView.h:
2481         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2482         (nextInputSessionChangeCount):
2483
2484         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2485         This includes changing the focused element from one to another.
2486
2487         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2488         (-[TestWKWebView didStartFormControlInteraction]):
2489         (-[TestWKWebView didEndFormControlInteraction]):
2490         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2491
2492         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2493         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2494         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2495         that doesn't require an input session to one that doesn't.
2496
2497 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2498
2499         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2500         <https://webkit.org/b/193676>
2501
2502         Reviewed by Alexey Proskuryakov.
2503
2504         * Scripts/webkitpy/style/checkers/cpp.py:
2505         (check_member_initialization_list):
2506         - Don't report missing whitespace around colon if the colon at
2507           the start of the line is formatted correctly.
2508         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2509         (WebKitStyleTest.test_member_initialization_list):
2510         - Add a test for a missing permutation of existing tests.
2511         - Add a test this false-positive.
2512         - Add blank lines between subtests to make them easier to read.
2513
2514 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2515
2516         [build.webkit.org] Unit-test failure after r237113
2517         https://bugs.webkit.org/show_bug.cgi?id=193669
2518
2519         Reviewed by Michael Catanzaro.
2520
2521         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2522         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2523         multiple or zero flags.
2524
2525 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2526
2527         Cache bytecode to disk
2528         https://bugs.webkit.org/show_bug.cgi?id=192782
2529         <rdar://problem/46084932>
2530
2531         Reviewed by Keith Miller.
2532
2533         Add test helper to execute bytecode-cache tests: it executes each test
2534         twice, the first with JSC_diskCachePath set to a temporary directory
2535         and second with JSC_forceDiskCache=true (in addition to the cache path)
2536         to guarantee that only the disk cache is being used and no new
2537         UnlinkedCodeBlocks are being created.
2538
2539         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2540         * Scripts/run-jsc-stress-tests:
2541
2542 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2543
2544         [css-logical] Implement flow-relative margin, padding and border shorthands
2545         https://bugs.webkit.org/show_bug.cgi?id=188697
2546
2547         Reviewed by Simon Fraser and Antti Koivisto.
2548
2549         * DumpRenderTree/TestOptions.cpp:
2550         (TestOptions::TestOptions):
2551         * DumpRenderTree/TestOptions.h:
2552         * DumpRenderTree/mac/DumpRenderTree.mm:
2553         (setWebPreferencesForTestOptions):
2554         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2555
2556         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2557         (JSONCSSPropertiesChecker.check_codegen_properties):
2558         Allow CSS property definitions to have a 'runtime-flag' parameter which
2559         disables the property when the specified runtime flag is disabled.
2560
2561 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2562
2563         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2564         https://bugs.webkit.org/show_bug.cgi?id=193643
2565
2566         Reviewed by Michael Catanzaro.
2567
2568         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2569         * wpe/jhbuild.modules: Ditto.
2570
2571 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2572
2573         [LFC][Floats] Take float top position into account when computing containing block height.
2574         https://bugs.webkit.org/show_bug.cgi?id=193655
2575
2576         Reviewed by Antti Koivisto.
2577
2578         * LayoutReloaded/misc/LFC-passing-tests.txt:
2579
2580 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2581
2582         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2583         <https://webkit.org/b/193645>
2584         <rdar://problem/47421574>
2585
2586         Reviewed by Alex Christensen.
2587
2588         - Now checks for local soft-linking of all frameworks that have
2589           their own *SoftLinking.{cpp,h,mm} files.
2590         - Changes softlink/uikit warning to softlink/framework.
2591
2592         * Scripts/webkitpy/style/checkers/cpp.py:
2593         (check_language):
2594         (CppChecker):
2595         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2596         (CppStyleTest):
2597
2598 2019-01-20  Saam Barati  <sbarati@apple.com>
2599
2600         Rollout r240210: It broke tests on iOS
2601         https://bugs.webkit.org/show_bug.cgi?id=193640
2602
2603         Unreviewed.
2604
2605         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2606         * Scripts/run-jsc-stress-tests:
2607
2608 2019-01-20  chris fleizach  <cfleizach@apple.com>
2609
2610         AX: Support returning relative frames for accessibility
2611         https://bugs.webkit.org/show_bug.cgi?id=193414
2612         <rdar://problem/47268501>
2613
2614         Reviewed by Zalan Bujtas.
2615
2616         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2617         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2618         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2619         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2620         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2621         (WTR::attributesOfElement):
2622         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2623
2624 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2625
2626         Unreviewed, add my new email address
2627
2628         * Scripts/webkitpy/common/config/contributors.json:
2629
2630 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2631
2632         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2633         https://bugs.webkit.org/show_bug.cgi?id=193617
2634
2635         Reviewed by Antti Koivisto.
2636
2637         * LayoutReloaded/misc/LFC-passing-tests.txt:
2638
2639 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2640
2641         Unreviewed, rolling out r240209.
2642
2643         Broke GTK/WPE injected bundle
2644
2645         Reverted changeset:
2646
2647         "AX: Support returning relative frames for accessibility"
2648         https://bugs.webkit.org/show_bug.cgi?id=193414
2649         https://trac.webkit.org/changeset/240209
2650
2651 2019-01-12  Dan Bernstein  <mitz@apple.com>
2652
2653         [Cocoa] Avoid importing directly from subumbrella frameworks
2654         https://bugs.webkit.org/show_bug.cgi?id=186016
2655         <rdar://problem/40591038>
2656
2657         Reviewed by Sam Weinig.
2658
2659         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2660           LaunchServices header.
2661         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2662           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2663         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2664           when using SDKs earlier than 10.13.
2665         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2666           and OTHER_CPLUSPLUSFLAGS.
2667         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2668           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2669         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2670           LaunchServices header.
2671
2672 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2673
2674         Cache bytecode to disk
2675         https://bugs.webkit.org/show_bug.cgi?id=192782
2676         <rdar://problem/46084932>
2677
2678         Reviewed by Keith Miller.
2679
2680         Add test helper to execute bytecode-cache tests: it executes each test
2681         twice, the first with JSC_diskCachePath set to a temporary directory
2682         and second with JSC_forceDiskCache=true (in addition to the cache path)
2683         to guarantee that only the disk cache is being used and no new
2684         UnlinkedCodeBlocks are being created.
2685
2686         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2687         * Scripts/run-jsc-stress-tests:
2688
2689 2019-01-20  chris fleizach  <cfleizach@apple.com>
2690
2691         AX: Support returning relative frames for accessibility
2692         https://bugs.webkit.org/show_bug.cgi?id=193414
2693         <rdar://problem/47268501>
2694
2695         Reviewed by Zalan Bujtas.
2696
2697         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2698         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2699         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2700         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2701         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2702         (WTR::attributesOfElement):
2703         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2704
2705 2019-01-20  Antoine Quint  <graouts@apple.com>
2706
2707         Add a POINTER_EVENTS feature flag
2708         https://bugs.webkit.org/show_bug.cgi?id=193577
2709         <rdar://problem/47408511>
2710
2711         Unreviewed. Also enable Pointer Events for iosmac.
2712
2713         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2714
2715 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2716
2717         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2718         https://bugs.webkit.org/show_bug.cgi?id=193613
2719
2720         Reviewed by Antti Koivisto.
2721
2722         * LayoutReloaded/misc/LFC-passing-tests.txt:
2723
2724 2019-01-19  Antoine Quint  <graouts@apple.com>
2725
2726         Add a POINTER_EVENTS feature flag
2727         https://bugs.webkit.org/show_bug.cgi?id=193577
2728
2729         Reviewed by Dean Jackson.
2730
2731         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2732
2733 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2734
2735         Disable the run-jsc-stress-test remote host key check [second round].
2736         https://bugs.webkit.org/show_bug.cgi?id=192988
2737
2738         Reviewed by Dewei Zhu.
2739
2740         * Scripts/run-jsc-stress-tests:
2741
2742 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2743
2744         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2745         https://bugs.webkit.org/show_bug.cgi?id=193597
2746
2747         Reviewed by Lucas Forschler.
2748
2749         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2750
2751 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2752
2753         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2754         https://bugs.webkit.org/show_bug.cgi?id=193595
2755
2756         Reviewed by Lucas Forschler.
2757
2758         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2759         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2760         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2761
2762 2019-01-18  Chris Dumez  <cdumez@apple.com>
2763
2764         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2765         https://bugs.webkit.org/show_bug.cgi?id=193588
2766         <rdar://problem/47131566>
2767
2768         Reviewed by Alex Christensen.
2769
2770         Add layout test coverage.
2771
2772         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2773
2774 2019-01-18  Jer Noble  <jer.noble@apple.com>
2775
2776         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2777         https://bugs.webkit.org/show_bug.cgi?id=189553
2778
2779         Reviewed by Tim Horton.
2780
2781         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2782
2783         * ContentExtensionTester/Configurations/Base.xcconfig:
2784         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2785         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2786         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2787         * ImageDiff/cg/Configurations/Base.xcconfig:
2788         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2789         * MiniBrowser/Configurations/Base.xcconfig:
2790         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2791         * MobileMiniBrowser/Configurations/Base.xcconfig:
2792         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2793         * Scripts/webkitpy/style/checker.py:
2794         (_all_categories):
2795         (FileType):
2796         (CheckerDispatcher._file_type):
2797         (CheckerDispatcher._create_checker):
2798         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2799         (SDKVariantChecker):
2800         (SDKVariantChecker.__init__):
2801         (SDKVariantChecker.check):
2802         * TestWebKitAPI/Configurations/Base.xcconfig:
2803         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2804         * WebEditingTester/Configurations/Base.xcconfig:
2805         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2806         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2807         * WebKitTestRunner/Configurations/Base.xcconfig:
2808         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2809         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2810         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2811
2812 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2813
2814         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2815         <https://webkit.org/b/193568>
2816         <rdar://problem/47381130>
2817
2818         Reviewed by Alex Christensen.
2819
2820         Make sure no one re-introduces UIKit soft-linking by adding a
2821         style rule.
2822
2823         * Scripts/webkitpy/style/checkers/cpp.py:
2824         (check_language): Add softlink/uikit check.
2825         (CppChecker): Enable softlink/uikit check.
2826         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2827         (CppStyleTest): Add test for softlink/uikit.
2828
2829 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2830
2831         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2832         https://bugs.webkit.org/show_bug.cgi?id=193584
2833
2834         Change "-dev" to "-devel".
2835
2836         Reviewed by Michael Catanzaro.
2837
2838         * gtk/install-dependencies:
2839
2840 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2841
2842         webkitpy: Add iPhone and iPad ports
2843         https://bugs.webkit.org/show_bug.cgi?id=193537
2844         <rdar://problem/47353390>
2845
2846         Reviewed by Lucas Forschler.
2847
2848         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2849         ports. Note that this separation is optional, the --ios-simulator command remains.
2850
2851         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2852         (RunTest.test_device_type_test_division): Drive-by fix.
2853         (RunTest.test_device_type_specific_listing): Ditto.
2854         (RunTest.test_ipad_test_division):
2855         (RunTest):
2856         (RunTest.test_ipad_listing):
2857         * Scripts/webkitpy/port/factory.py:
2858         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2859         (PortFactory):
2860         * Scripts/webkitpy/port/ios_simulator.py:
2861         (IPhoneSimulatorPort):
2862         (IPadSimulatorPort):
2863
2864 2019-01-18  Chris Dumez  <cdumez@apple.com>
2865
2866         Regression(PSON) Scroll position is not always restored properly when navigating back
2867         https://bugs.webkit.org/show_bug.cgi?id=193578
2868         <rdar://problem/47386331>
2869
2870         Reviewed by Tim Horton.
2871
2872         Add API test coverage.
2873
2874         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2875
2876 2019-01-18  Youenn Fablet  <youenn@apple.com>
2877
2878         Add a new SPI to request for cache storage quota increase
2879         https://bugs.webkit.org/show_bug.cgi?id=193323
2880
2881         Reviewed by Alex Christensen.
2882
2883         Implement WebsiteDataStore quota delegate to handle quota requests.
2884         By default, do not update quota.
2885         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2886
2887         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2888         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2889         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2890         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2891         * WebKitTestRunner/TestController.cpp:
2892         (WTR::TestController::allowCacheStorageQuotaIncrease):
2893         * WebKitTestRunner/TestController.h:
2894         * WebKitTestRunner/TestInvocation.cpp:
2895         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2896         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2897         (-[CacheStorageQuotaManager init]):
2898         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2899         (WTR::initializeWebViewConfiguration):
2900         (WTR::TestController::cocoaResetStateToConsistentValues):
2901         (WTR::TestController::allowCacheStorageQuotaIncrease):
2902
2903 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2904
2905         [ews-build] Pass owner to the triggered builds
2906         https://bugs.webkit.org/show_bug.cgi?id=193574
2907
2908         Reviewed by Lucas Forschler.
2909
2910         * BuildSlaveSupport/ews-build/factories.py:
2911         (BuildFactory.propertiesToPassToTriggers):
2912
2913 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2914
2915         [ews-app] Send patch author as a build property
2916         https://bugs.webkit.org/show_bug.cgi?id=193560
2917
2918         Reviewed by Lucas Forschler.
2919
2920         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2921         (BugzillaPatchFetcher.fetch):
2922
2923 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2924
2925         webkitpy: Implement device type specific expected results (Follow-up fix)
2926         https://bugs.webkit.org/show_bug.cgi?id=192162
2927         <rdar://problem/46345449>
2928
2929         Unreviewed infrastructure fix.
2930
2931         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2932         (Manager.run): Don't boot a device if no tests are available to run on it.
2933
2934 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2935
2936         webkitpy: Implement device type specific expected results (Follow-up fix)
2937         https://bugs.webkit.org/show_bug.cgi?id=192162
2938         <rdar://problem/46345449>
2939
2940         Unreviewed infrastructure fix.
2941
2942         * Scripts/webkitpy/api_tests/manager.py:
2943         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2944
2945 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2946
2947         webkitpy: Implement device type specific expected results (Part 2)
2948         https://bugs.webkit.org/show_bug.cgi?id=192162
2949         <rdar://problem/46345449>
2950
2951         Rubber-stamped by Aakash Jain.
2952
2953         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2954         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2955         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2956
2957         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2958         (LayoutTestFinder.find_tests): Pass device_type through.
2959         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2960         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2961         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2962         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2963         (Manager._collect_tests): Pass device type to test finder.
2964         (Manager._needs_web_platform_test):
2965         (Manager._prepare_lists): Index _expectations by device type.
2966         (Manager._test_input_for_file):
2967         (Manager._test_is_slow): Ditto.
2968         (Manager._test_should_dump_jsconsolelog_in_stderr):
2969         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2970         (Manager._get_test_inputs):
2971         (Manager._update_worker_count):
2972         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2973         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2974         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2975         the one which runs the test.
2976         (Manager._run_test_subset):
2977         (Manager._run_tests): Index _expectations by current_device_type.
2978         (Manager._print_expectation_line_for_test): Ditto.
2979         (Manager._print_expectations_for_subset): Ditto.
2980         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2981         Unlike run, this function will behave the same regardless of what devices are available.
2982         (Manager._custom_device_for_test): Deleted.
2983         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2984         (ManagerTest.test_uses_custom_device): Deleted.
2985         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2986         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2987         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2988         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2989         all of the expectations.
2990         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2991         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2992         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2993         (TestExpectations.__init__): Allow device_type to be passed through.
2994         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2995         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2996         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2997         (summarize_results):
2998         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2999         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3000         a test ran with, one must check all expectations to find the first non-skip expectation.
3001         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3002         (RunTest.test_device_type_test_division):
3003         (RunTest):
3004         (RunTest.test_device_type_specific_listing):
3005         * Scripts/webkitpy/port/base.py:
3006         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3007         (Port.supported_device_types): The result of this function will change based on what devices are available.
3008         * Scripts/webkitpy/port/device_port.py:
3009         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3010         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3011         can be used.
3012         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3013         any, or the DEFAULT_DEVICE_TYPES of the port.
3014         * Scripts/webkitpy/port/ios.py:
3015         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3016         * Scripts/webkitpy/port/ios_simulator.py:
3017         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3018         * Scripts/webkitpy/port/watch.py:
3019         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3020         * Scripts/webkitpy/port/watch_simulator.py:
3021         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3022         * Scripts/webkitpy/xcode/device_type.py:
3023         (DeviceType):
3024         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3025
3026 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3027
3028         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3029         https://bugs.webkit.org/show_bug.cgi?id=193575
3030
3031         Reviewed by Michael Catanzaro.
3032
3033         Allow the script to run without explicit port argument because
3034         it's specific to the WPE port anyway.
3035
3036         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3037         and simplify the rest of the code accordingly.
3038
3039 2019-01-18  Charlie Turner  <cturner@igalia.com>
3040
3041         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3042         https://bugs.webkit.org/show_bug.cgi?id=192229
3043
3044         Reviewed by Xabier Rodriguez-Calvar.
3045
3046         * MiniBrowser/wpe/main.cpp:
3047         (main): Enable encrypted-media by default.
3048
3049 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3050
3051         [Flatpak] Missing KeyboardInterrupt exception handler
3052         https://bugs.webkit.org/show_bug.cgi?id=193570
3053
3054         Reviewed by Michael Catanzaro.
3055
3056         * flatpak/flatpakutils.py:
3057         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3058
3059 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3060
3061         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3062         https://bugs.webkit.org/show_bug.cgi?id=193564
3063
3064         Reviewed by Antti Koivisto.
3065
3066         * LayoutReloaded/misc/LFC-passing-tests.txt:
3067
3068 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3069
3070         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3071         https://bugs.webkit.org/show_bug.cgi?id=193562
3072
3073         Reviewed by Antti Koivisto.
3074
3075         * LayoutReloaded/misc/LFC-passing-tests.txt:
3076
3077 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3078
3079         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3080         https://bugs.webkit.org/show_bug.cgi?id=193555
3081
3082         Reviewed by Antti Koivisto.
3083
3084         * LayoutReloaded/misc/LFC-passing-tests.txt:
3085
3086 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3087
3088         [WPE] Add Qt extension
3089         https://bugs.webkit.org/show_bug.cgi?id=191464
3090
3091         Reviewed by Carlos Garcia Campos.
3092
3093         MiniBrowser and API tests for the WPE Qt API. To run the
3094         MiniBrowser a new script is introduced. Example invocation:
3095
3096         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3097
3098         Also note-worthy is the introduction of the python2-subprocess32
3099         dependency to run the GLib API tests.
3100
3101         * MiniBrowser/wpe/CMakeLists.txt:
3102         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3103         * MiniBrowser/wpe/qt/main.cpp: Added.
3104         (main):
3105         * MiniBrowser/wpe/qt/main.qml: Added.
3106         * MiniBrowser/wpe/qt/qml.qrc: Added.
3107         * Scripts/run-gtk-tests:
3108         (GtkTestRunner.is_google_test):
3109         (GtkTestRunner):
3110         (GtkTestRunner.is_qt_test):
3111         * Scripts/run-qt-wpe-minibrowser: Added.
3112         * Scripts/run-wpe-tests:
3113         (WPETestRunner):
3114         (WPETestRunner.is_google_test):
3115         (WPETestRunner.is_qt_test):
3116         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3117         (TestLoad::main):
3118         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3119         (TestLoadHtml::main):
3120         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3121         (TestLoadRequest::main):
3122         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3123         (TestRunJavaScript::main):
3124         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3125         (waitForSignal):
3126         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3127         (LoadSpy::LoadSpy):
3128         (LoadSpy::~LoadSpy):
3129         (LoadSpy::onLoadingChanged):
3130         (LoadStartedCatcher::LoadStartedCatcher):
3131         (LoadStartedCatcher::~LoadStartedCatcher):
3132         (LoadStartedCatcher::onLoadingChanged):
3133         (waitForLoadSucceeded):
3134         (waitForLoadFailed):
3135         * TestWebKitAPI/glib/CMakeLists.txt:
3136         * flatpak/flatpakutils.py:
3137         (WebkitFlatpak.load_from_args):
3138         (WebkitFlatpak.__init__):
3139         (WebkitFlatpak.clean_args):
3140         (WebkitFlatpak.run_in_sandbox):
3141         * flatpak/org.webkit.CommonModules.yaml:
3142         * flatpak/org.webkit.WPE.yaml:
3143         * flatpak/org.webkit.WPEModules.yaml:
3144         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3145         * flatpak/org.webkit.WebKit.yaml:
3146         * glib/api_test_runner.py:
3147         (TestRunner._run_test_qt):
3148         (TestRunner.is_qt_test):
3149         (TestRunner._run_test):
3150
3151 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3152
3153         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3154         https://bugs.webkit.org/show_bug.cgi?id=193494
3155         <rdar://problem/46859627>
3156
3157         Reviewed by Simon Fraser and Tim Horton.
3158
3159         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3160         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3161
3162         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3163         (WTR::UIScriptController::contentOffsetX const):
3164         (WTR::UIScriptController::contentOffsetY const):
3165         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3166         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3167         (WTR::UIScriptController::contentOffsetX const):
3168         (WTR::UIScriptController::contentOffsetY const):
3169         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3170
3171         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3172
3173         * WebKitTestRunner/TestController.cpp:
3174         (WTR::updateTestOptionsFromTestHeader):
3175         * WebKitTestRunner/TestOptions.h:
3176         (WTR::TestOptions::hasSameInitializationOptions const):
3177         * WebKitTestRunner/ios/TestControllerIOS.mm:
3178         (WTR::TestController::platformResetStateToConsistentValues):
3179         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3180         (WTR::UIScriptController::contentOffsetX const):
3181         (WTR::UIScriptController::contentOffsetY const):
3182
3183 2019-01-17  Truitt Savell  <tsavell@apple.com>
3184
3185         Unreviewed, rolling out r240124.
3186
3187         This commit broke an internal build.
3188
3189         Reverted changeset:
3190
3191         "SDK_VARIANT build destinations should be separate from non-
3192         SDK_VARIANT builds"
3193         https://bugs.webkit.org/show_bug.cgi?id=189553
3194         https://trac.webkit.org/changeset/240124
3195
3196 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3197
3198         Fix string concatenation API test after r239920
3199         https://bugs.webkit.org/show_bug.cgi?id=193551
3200         <rdar://problem/47359304>
3201
3202         Reviewed by Youenn Fablet.
3203
3204         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3205         (TestWebKitAPI::TEST):
3206         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3207         in WebKit's build configuration like it apparently is on Linux.
3208
3209 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3210
3211         [ews-build] validate-patch should handle the case when bug_id is None
3212         https://bugs.webkit.org/show_bug.cgi?id=193547
3213
3214         Reviewed by Lucas Forschler.
3215
3216         * BuildSlaveSupport/ews-build/steps.py:
3217         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3218         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3219
3220 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3221
3222         [ews-build] Add patch author information in build
3223         https://bugs.webkit.org/show_bug.cgi?id=193465
3224
3225         Reviewed by Lucas Forschler.
3226
3227         * BuildSlaveSupport/ews-build/steps.py:
3228         (ValidatePatch._is_patch_obsolete):
3229
3230 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3231
3232         [ews-build] Pass bug_id to the triggered builds
3233         https://bugs.webkit.org/show_bug.cgi?id=193548
3234
3235         Reviewed by Lucas Forschler.
3236
3237         * BuildSlaveSupport/ews-build/factories.py:
3238         (BuildFactory.propertiesToPassToTriggers):
3239
3240 2019-01-17  Jer Noble  <jer.noble@apple.com>
3241
3242         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3243         https://bugs.webkit.org/show_bug.cgi?id=189553
3244
3245         Reviewed by Tim Horton.
3246
3247         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3248
3249         * ContentExtensionTester/Configurations/Base.xcconfig:
3250         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3251         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3252         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3253         * ImageDiff/cg/Configurations/Base.xcconfig:
3254         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3255         * MiniBrowser/Configurations/Base.xcconfig:
3256         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3257         * MobileMiniBrowser/Configurations/Base.xcconfig:
3258         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3259         * Scripts/webkitpy/style/checker.py:
3260         (_all_categories):
3261         (FileType):
3262         (CheckerDispatcher._file_type):
3263         (CheckerDispatcher._create_checker):
3264         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3265         (SDKVariantChecker):
3266         (SDKVariantChecker.__init__):
3267         (SDKVariantChecker.check):
3268         * TestWebKitAPI/Configurations/Base.xcconfig:
3269         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3270         * WebEditingTester/Configurations/Base.xcconfig:
3271         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3272         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3273         * WebKitTestRunner/Configurations/Base.xcconfig:
3274         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3275         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3276         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3277
3278 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3279
3280         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3281         https://bugs.webkit.org/show_bug.cgi?id=193534
3282
3283         Reviewed by Antti Koivisto.
3284
3285         * LayoutReloaded/misc/LFC-passing-tests.txt:
3286
3287 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3288
3289         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3290         https://bugs.webkit.org/show_bug.cgi?id=193528
3291
3292         Reviewed by Antti Koivisto.
3293
3294         * LayoutReloaded/misc/LFC-passing-tests.txt:
3295
3296 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3297
3298         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3299         https://bugs.webkit.org/show_bug.cgi?id=193520
3300
3301         Reviewed by Antti Koivisto.
3302
3303         * LayoutReloaded/misc/LFC-passing-tests.txt:
3304
3305 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3306
3307         [ews-build] unapply-patch step should not update source
3308         https://bugs.webkit.org/show_bug.cgi?id=193234
3309
3310         Reviewed by Lucas Forschler.
3311
3312         * BuildSlaveSupport/ews-build/steps.py:
3313         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3314         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3315
3316 2019-01-16  Youenn Fablet  <youenn@apple.com>
3317
3318         Add a new SPI for controlling getUserMedia
3319         https://bugs.webkit.org/show_bug.cgi?id=192793
3320
3321         Reviewed by Eric Carlson.
3322
3323         * MiniBrowser/mac/WK2BrowserWindowController.m:
3324         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3325         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3326         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3327         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3328         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3329         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3330         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3331         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3332         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3333         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3334         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3335         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3336         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3337         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3338
3339 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3340
3341         [LFC][BFC] Inflow non-replaced used width should not be negative.
3342         https://bugs.webkit.org/show_bug.cgi?id=193495
3343
3344         Reviewed by Antti Koivisto.
3345
3346         * LayoutReloaded/misc/LFC-passing-tests.txt:
3347
3348 2019-01-16  Chris Dumez  <cdumez@apple.com>
3349
3350         Regression(PSON) View becomes blank after click a cross-site download link
3351         https://bugs.webkit.org/show_bug.cgi?id=193361
3352         <rdar://problem/47099573>
3353
3354         Reviewed by Geoffrey Garen.
3355
3356         Add API test coverage.
3357
3358         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3359         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3360
3361 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3362
3363         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3364         https://bugs.webkit.org/show_bug.cgi?id=193470
3365
3366         Reviewed by Antti Koivisto.
3367
3368         * LayoutReloaded/misc/LFC-passing-tests.txt:
3369
3370 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3371
3372         [LFC] Adjust margin box verification.
3373         https://bugs.webkit.org/show_bug.cgi?id=193482
3374
3375         Reviewed by Antti Koivisto.
3376
3377         * LayoutReloaded/misc/LFC-passing-tests.txt:
3378
3379 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3380
3381         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3382         https://bugs.webkit.org/show_bug.cgi?id=193451
3383
3384         Reviewed by Geoffrey Garen.
3385
3386         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3387         (TEST):
3388         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3389         (runWebsiteDataStoreCustomPaths):
3390
3391 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3392
3393         webkitpy: Support boolean simctl isAvailable
3394         https://bugs.webkit.org/show_bug.cgi?id=193472
3395         <rdar://problem/47296150>
3396
3397         Reviewed by Ryosuke Niwa.
3398
3399         * Scripts/webkitpy/xcode/simulated_device.py:
3400         (SimulatedDeviceManager._create_runtimes):
3401         (SimulatedDeviceManager._create_device_with_runtime):
3402
3403 2019-01-15  Chris Dumez  <cdumez@apple.com>
3404
3405         Unreviewed, rolling out r239993, r239995, r239997, and
3406         r239999.
3407
3408         Caused assertions under
3409         ViewGestureController::disconnectFromProcess()
3410
3411         Reverted changesets:
3412
3413         "Regression(PSON) View becomes blank after click a cross-site
3414         download link"
3415         https://bugs.webkit.org/show_bug.cgi?id=193361
3416         https://trac.webkit.org/changeset/239993
3417
3418         "Unreviewed iOS build fix after r239993."
3419         https://trac.webkit.org/changeset/239995
3420
3421         "Fix iOS build after r239993"
3422         https://bugs.webkit.org/show_bug.cgi?id=193361
3423         https://trac.webkit.org/changeset/239997
3424
3425         "Unreviewed, revert part of r239997 as it is not needed to fix
3426         the build."
3427         https://trac.webkit.org/changeset/239999
3428
3429 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3430
3431         Cannot tab out of WKWebView on macOS
3432         https://bugs.webkit.org/show_bug.cgi?id=161448
3433         <rdar://problem/28100085>
3434
3435         Reviewed by Dean Jackson.
3436
3437         Add a test that tabbing into and out of WKWebView works correctly.
3438
3439         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3440         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3441         (WebKit2_CommandBackForwardTest::SetUp):
3442         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3443         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3444         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3445         (-[FocusableView canBecomeKeyView]):
3446         (TEST):
3447         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3448         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3449         (-[OffscreenWindow initWithSize:]):
3450         (-[OffscreenWindow isKeyWindow]):
3451         (-[OffscreenWindow isVisible]):
3452         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3453         (TestWebKitAPI::PlatformWebView::initialize):
3454         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3455         (-[ActiveOffscreenWindow isVisible]): Deleted.
3456         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3457
3458 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3459
3460         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3461         https://bugs.webkit.org/show_bug.cgi?id=193459
3462
3463         Reviewed by Mark Lam.
3464
3465         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3466         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3467
3468 2019-01-15  Chris Dumez  <cdumez@apple.com>
3469
3470         Regression(PSON) View becomes blank after click a cross-site download link
3471         https://bugs.webkit.org/show_bug.cgi?id=193361
3472         <rdar://problem/47099573>
3473
3474         Reviewed by Geoff Garen.
3475
3476         Add API test coverage.
3477
3478         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3479         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3480
3481 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3482
3483         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3484         https://bugs.webkit.org/show_bug.cgi?id=193448
3485
3486         Reviewed by Antti Koivisto.
3487
3488         * LayoutReloaded/misc/LFC-passing-tests.txt:
3489
3490 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3491
3492         webkitpy: Implement device type specific expected results (Part 1)
3493         https://bugs.webkit.org/show_bug.cgi?id=192162
3494
3495         Reviewed by Lucas Forschler.
3496
3497         Device type specific expected results covers two related ideas. The first (covered by this change)
3498         is where to search for -expected.* files. The second is which tests to run based on the
3499         TestExpectations.txt file.
3500
3501         After this change, the baseline search path will be determined by the type of device running a
3502         test. Device type will be passed into any function which picks a file based on the baseline search
3503         path.
3504
3505         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3506         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3507         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3508         (Manager.run): Print baseline search path for each round of devices.
3509         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3510         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3511         (SingleTestRunner._expected_driver_output): Ditto.
3512         (SingleTestRunner._driver_input): Ditto.
3513         * Scripts/webkitpy/layout_tests/views/printing.py:
3514         (Printer.print_config): Move printing of baseline search path to a separate function.
3515         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3516         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3517         (Testprinter.test_print_config):
3518         (Testprinter.test_print_baseline_search_path):
3519         * Scripts/webkitpy/port/base.py:
3520         (Port.baseline_search_path): Pass device_type through.
3521         (Port._expected_baselines_for_suffixes): Ditto.
3522         (Port.expected_baselines): Ditto.
3523         (Port.expected_filename): Ditto.
3524         (Port.expected_checksum): Ditto.
3525         (Port.expected_image): Ditto.
3526         (Port.expected_audio): Ditto.
3527         (Port.expected_text): Ditto.
3528         (Port.reference_files): Ditto.
3529         (Port.tests): Ditto.
3530         (Port._expanded_paths): Ditto.
3531         (Port.skipped_layout_tests): Ditto.
3532         (Port.expectations_dict): Ditto.
3533         (Port._port_specific_expectations_files): Ditto.
3534         (Port.expectations_files): Ditto.
3535         (Port.test_search_path): Ditto.
3536         (Port._tests_for_other_platforms): Ditto.
3537         * Scripts/webkitpy/port/base_unittest.py:
3538         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3539         (PortTest.test_nonexistant_expectations): Ditto.
3540         (test_ref_tests_platform_directory): Ditto.
3541         * Scripts/webkitpy/port/darwin.py:
3542         (DarwinPort._port_specific_expectations_files): Accept device_type.
3543         * Scripts/webkitpy/port/driver.py:
3544         (DriverProxy):
3545         (DriverProxy.host): Expose _target_host for device_type information.
3546         * Scripts/webkitpy/port/gtk.py:
3547         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3548         * Scripts/webkitpy/port/ios.py:
3549         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3550         * Scripts/webkitpy/port/mac.py:
3551         (MacPort. default_baseline_search_path): Ditto.
3552         * Scripts/webkitpy/port/port_testcase.py:
3553         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3554         * Scripts/webkitpy/port/test.py:
3555         * Scripts/webkitpy/port/watch.py:
3556         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3557         * Scripts/webkitpy/port/win.py:
3558         (WinPort.test_search_path): Accept, but do not use, device_type.
3559         * Scripts/webkitpy/port/wpe.py:
3560         (WPEPort._port_specific_expectations_files): Ditto.
3561         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3562         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3563
3564 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3565
3566         [LFC] Use the containing block's padding box to position out-of-flow elements.
3567         https://bugs.webkit.org/show_bug.cgi?id=193431
3568
3569         Reviewed by Antti Koivisto.
3570
3571         * LayoutReloaded/misc/LFC-passing-tests.txt:
3572
3573 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3574
3575         Move a test implementation file that got misplaced in the Xcode project
3576
3577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3578
3579 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3580
3581         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3582         r239913, and r239914.
3583         https://bugs.webkit.org/show_bug.cgi?id=193407
3584
3585         These revisions caused an internal failure (Requested by
3586         Truitt on #webkit).
3587
3588         Reverted changesets:
3589
3590         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3591         https://bugs.webkit.org/show_bug.cgi?id=186016
3592         https://trac.webkit.org/changeset/239901
3593
3594         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3595         https://trac.webkit.org/changeset/239909
3596
3597         "Tried to fix the build."
3598         https://trac.webkit.org/changeset/239910
3599
3600         "Fixed iOS builds after r239910."
3601         https://trac.webkit.org/changeset/239912
3602
3603         "More build fixing."
3604         https://trac.webkit.org/changeset/239913
3605
3606         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3607         https://trac.webkit.org/changeset/239914
3608
3609 2019-01-14  Mark Lam  <mark.lam@apple.com>
3610
3611         Re-enable ability to build --cloop builds.
3612         https://bugs.webkit.org/show_bug.cgi?id=192955
3613         <rdar://problem/46882363>
3614
3615         Reviewed by Saam barati and Keith Miller.
3616
3617         The --cloop build option was being ignored this whole time since r236381.
3618         This patch makes it possible to build CLoop builds again.
3619
3620         * Scripts/build-jsc:
3621         * Scripts/webkitperl/FeatureList.pm:
3622         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3623
3624 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3625
3626         webkitpy: Expose device_type from host-like objects
3627         https://bugs.webkit.org/show_bug.cgi?id=193406
3628         <rdar://problem/47262305>
3629
3630         Reviewed by Lucas Forschler.
3631
3632         Devices should expose device_type. As a result, all host objects should
3633         provide a device_type property, even if they do not yet define a device_type.
3634
3635         * Scripts/webkitpy/common/system/systemhost.py:
3636         (SystemHost):
3637         (SystemHost.device_type):
3638         * Scripts/webkitpy/common/system/systemhost_mock.py:
3639         (MockSystemHost):
3640         (MockSystemHost.device_type):
3641         * Scripts/webkitpy/port/device.py:
3642         (Device):
3643         (Device.device_type):
3644         * Scripts/webkitpy/xcode/simulated_device.py:
3645         (SimulatedDeviceManager._find_exisiting_device_for_request):
3646         (SimulatedDeviceManager._disambiguate_device_type):
3647         (SimulatedDeviceManager._does_fulfill_request):
3648         (SimulatedDeviceManager.device_count_for_type):
3649         (SimulatedDeviceManager.initialize_devices):
3650         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3651         (test_available_devices):
3652         (test_swapping_devices):
3653
3654 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3655
3656         webkitpy: Support alternate simctl device list output (Follow-up fix)
3657         https://bugs.webkit.org/show_bug.cgi?id=193362
3658         <rdar://problem/47122965>
3659
3660         Rubber-stamped by Lucas Forschler.
3661
3662         * Scripts/webkitpy/xcode/simulated_device.py:
3663         (SimulatedDeviceManager.populate_available_devices):
3664
3665 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3666
3667         [iOS] Expose SPI to access the current sentence boundary and selection state
3668         https://bugs.webkit.org/show_bug.cgi?id=193398
3669         <rdar://problem/45893108>
3670
3671         Reviewed by Dean Jackson.
3672
3673         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3674         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3675         expected.
3676
3677         * TestWebKitAPI/EditingTestHarness.h:
3678         * TestWebKitAPI/EditingTestHarness.mm:
3679         (-[EditingTestHarness moveBackward]):
3680         (-[EditingTestHarness moveForward]):
3681         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3682
3683         Add a couple of new helper methods on EditingTestHarness.
3684
3685         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3686         (-[SelectionChangeObserver initWithWebView:]):
3687         (-[SelectionChangeObserver webView]):
3688         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3689         (-[SelectionChangeObserver currentSelectionAttributes]):
3690
3691 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3692
3693         [LFC][BFC] Add basic box-sizing support.
3694         https://bugs.webkit.org/show_bug.cgi?id=193392
3695
3696         Reviewed by Antti Koivisto.
3697
3698         * LayoutReloaded/misc/LFC-passing-tests.txt:
3699
3700 2019-01-14  Charlie Turner  <cturner@igalia.com>
3701
3702         [WPE] API test gardening
3703         https://bugs.webkit.org/show_bug.cgi?id=193319
3704
3705         Reviewed by Michael Catanzaro.
3706
3707         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3708         passing tests.
3709
3710 2019-01-14  Charlie Turner  <cturner@igalia.com>
3711
3712         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3713         https://bugs.webkit.org/show_bug.cgi?id=192977
3714
3715         Reviewed by Carlos Garcia Campos.
3716
3717         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3718         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3719         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3720         (TestWebKitAPI::GStreamerTest::SetUp):
3721         (TestWebKitAPI::GStreamerTest::TearDown):
3722         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3723         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3724         (TestWebKitAPI::TEST_F):
3725
3726 2019-01-14  Charlie Turner  <cturner@igalia.com>
3727
3728         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3729         https://bugs.webkit.org/show_bug.cgi?id=193332
3730
3731         Reviewed by Michael Catanzaro.
3732
3733         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3734         defined as a char16_t, which changed in ICU 59, the
3735         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3736         unsigned short. This test is relying on the behaviour that
3737         UChar=unsigned short, which doesn't hold across platforms and ICU
3738         library versions. The full fix would be a special syntax for
3739         literal characters so that these ambiguities do not arise. That
3740         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3741         (TestWebKitAPI::TEST):
3742
3743 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3744
3745         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3746
3747         * Scripts/make-dist:
3748         (Distcheck.configure):
3749
3750 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3751
3752         [ews-build] Update macOS queue configurations
3753         https://bugs.webkit.org/show_bug.cgi?id=193365
3754         <rdar://problem/47221073>
3755
3756         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3757
3758         * BuildSlaveSupport/ews-build/config.json:
3759
3760 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3761
3762         [LFC] Adjust assert for statically positioned fixed elements
3763         https://bugs.webkit.org/show_bug.cgi?id=193385
3764
3765         Reviewed by Antti Koivisto.
3766
3767         * LayoutReloaded/misc/LFC-passing-tests.txt:
3768
3769 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3770
3771         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3772         https://bugs.webkit.org/show_bug.cgi?id=193387
3773
3774         Reviewed by Carlos Garcia Campos.
3775
3776         * MiniBrowser/wpe/main.cpp:
3777         (main):
3778
3779 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3780
3781         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3782         https://bugs.webkit.org/show_bug.cgi?id=191655
3783         rdar://problem/46074680
3784
3785         Reviewed by Megan Gardner.
3786
3787         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3788         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3789
3790 2019-01-12  Dan Bernstein  <mitz@apple.com>
3791
3792         [Cocoa] Avoid importing directly from subumbrella frameworks
3793         https://bugs.webkit.org/show_bug.cgi?id=186016
3794         <rdar://problem/40591038>
3795
3796         Reviewed by Sam Weinig.
3797
3798         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3799           LaunchServices header.
3800         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3801           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3802         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3803           when using SDKs earlier than 10.13.
3804         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3805           and OTHER_CPLUSPLUSFLAGS.
3806         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3807           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3808         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3809           LaunchServices header.
3810
3811 2019-01-11  John Wilander  <wilander@apple.com>
3812
3813         Compile out Web API Statistics Collection
3814         https://bugs.webkit.org/show_bug.cgi?id=193370
3815         <rdar://problem/45388584>
3816
3817         Reviewed by Brent Fulgham.
3818
3819         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3820             Defined ENABLE_WEB_API_STATISTICS, off by default.
3821
3822 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3823
3824         [WPE] Add gtk-doc
3825         https://bugs.webkit.org/show_bug.cgi?id=178900
3826
3827         Reviewed by Michael Catanzaro.
3828
3829         Add Tools/gtkdoc to manifest.txt.in files.
3830         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3831
3832         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3833         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3834
3835 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3836
3837         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3838         https://bugs.webkit.org/show_bug.cgi?id=193364
3839         <rdar://problem/47214117>
3840
3841         Reviewed by Tim Horton.
3842
3843         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3844         precise, whereas dragging near the middle of the textarea does.
3845
3846         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3847         (TestWebKitAPI::TEST):
3848
3849 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3850
3851         webkitpy: Support alternate simctl device list output
3852         https://bugs.webkit.org/show_bug.cgi?id=193362
3853         <rdar://problem/47122965>
3854
3855         Reviewed by Lucas Forschler.
3856
3857         * Scripts/webkitpy/xcode/simulated_device.py:
3858         (SimulatedDeviceManager.populate_available_devices):
3859
3860 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3861
3862         [ews-build] Update macOS queue configurations
3863         https://bugs.webkit.org/show_bug.cgi?id=193365
3864
3865         Reviewed by Lucas Forschler.
3866
3867         * BuildSlaveSupport/ews-build/config.json:
3868
3869 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3870
3871         webkitpy: Incorporate device type into baseline search path
3872         https://bugs.webkit.org/show_bug.cgi?id=193356
3873         <rdar://problem/47215515>
3874
3875         Reviewed by Lucas Forschler.
3876
3877         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3878
3879         * Scripts/webkitpy/port/base.py:
3880         (Port.default_baseline_search_path): Allow device type to be passed in.
3881         * Scripts/webkitpy/port/gtk.py:
3882         (GtkPort.default_baseline_search_path): Ignore device type.
3883         * Scripts/webkitpy/port/ios.py:
3884         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3885         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3886         * Scripts/webkitpy/port/ios_device_unittest.py:
3887         (IOSDeviceTest):
3888         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3889         (IOSSimulatorTest):
3890         * Scripts/webkitpy/port/mac.py:
3891         (MacPort.default_baseline_search_path): Ignore device type.
3892         * Scripts/webkitpy/port/watch.py:
3893         (WatchPort.default_baseline_search_path): Ditto.
3894         * Scripts/webkitpy/port/win.py:
3895         (WinPort.default_baseline_search_path): Ditto.
3896         (WinCairoPort.default_baseline_search_path): Ditto.
3897         * Scripts/webkitpy/port/wpe.py:
3898         (WPEPort.default_baseline_search_path): Ditto.
3899
3900 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3901
3902         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3903         https://bugs.webkit.org/show_bug.cgi?id=193352
3904         <rdar://problem/47210736>
3905
3906         Reviewed by Lucas Forschler.
3907
3908         * Scripts/webkitpy/layout_tests/views/printing.py:
3909         (Printer.print_config): Print list on only baseline search paths which exist. 
3910         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3911         (Testprinter.test_print_config):
3912
3913 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3914
3915         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3916         https://bugs.webkit.org/show_bug.cgi?id=193340
3917
3918         Reviewed by David Kilzer.
3919
3920         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3921         (WTR::InjectedBundle::didReceiveMessageToPage):
3922         Pull the strings out into a WKRetainPtr.
3923
3924         * WebKitTestRunner/WebNotificationProvider.cpp:
3925         (WTR::WebNotificationProvider::closeWebNotification):
3926         Adopt the created value into the WKRetainPtr.
3927
3928         * WebKitTestRunner/mac/TestControllerMac.mm:
3929         (WTR::generateWhitelist):
3930         Immediately adopt a created value to avoid potential mistakes.
3931
3932 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3933
3934         Enable DFG on ARM/Linux again
3935         https://bugs.webkit.org/show_bug.cgi?id=192496
3936
3937         Reviewed by Yusuke Suzuki.
3938
3939         After changing the bytecode format DFG was disabled on all 32-bit
3940         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3941         on ARM by default.
3942
3943         * Scripts/run-jsc-stress-tests:
3944
3945 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3946
3947         Unreviewed, fix #ifdef in API test added in r239851.
3948         https://bugs.webkit.org/show_bug.cgi?id=193327
3949         rdar://problem/47093222
3950
3951         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3952
3953 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3954
3955         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3956         https://bugs.webkit.org/show_bug.cgi?id=193109
3957         <rdar://problem/44807048>
3958
3959         Reviewed by Ryosuke Niwa.
3960
3961         Introduce and respect a test option to enable the UndoManager API.
3962
3963         * WebKitTestRunner/TestController.cpp:
3964         (WTR::updateTestOptionsFromTestHeader):
3965         * WebKitTestRunner/TestOptions.h:
3966         (WTR::TestOptions::hasSameInitializationOptions const):
3967         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3968         (WTR::TestController::platformCreateWebView):
3969
3970 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3971
3972         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3973         https://bugs.webkit.org/show_bug.cgi?id=193346
3974
3975         Reviewed by Antti Koivisto.
3976
3977         * LayoutReloaded/misc/LFC-passing-tests.txt:
3978
3979 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3980
3981         Unreviewed, fix typo that breaks dashboard link.
3982
3983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3984         (WebKitBuildbot):
3985
3986 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3987
3988         Update macOS queue configurations
3989         https://bugs.webkit.org/show_bug.cgi?id=193329
3990
3991         Reviewed by Alexey Proskuryakov.
3992
3993         * BuildSlaveSupport/build.webkit.org-config/config.json:
3994         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3995         (BubbleQueueServer):
3996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3997         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3998         (WebKitBuildbot):
3999         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4000         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
4001         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4002
4003 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
4004
4005         MiniBrowser should be able to navigate to about:blank
4006         https://bugs.webkit.org/show_bug.cgi?id=193345
4007
4008         Reviewed by Simon Fraser.
4009
4010         * MiniBrowser/mac/BrowserWindowController.m:
4011         (-[BrowserWindowController addProtocolIfNecessary:]):
4012         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
4013
4014         * MiniBrowser/mac/WK1BrowserWindowController.m:
4015         (-[WK1BrowserWindowController fetch:]):
4016         * MiniBrowser/mac/WK2BrowserWindowController.m:
4017         (-[WK2BrowserWindowController fetch:]):
4018         Clean up the code that uses this to match style.
4019
4020 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
4021
4022         Remove MiniBrowser custom "Process Swap" menu item which does not work
4023         https://bugs.webkit.org/show_bug.cgi?id=193344
4024
4025         Reviewed by Simon Fraser.
4026
4027         There is a menu item under the Experimental menu that does work.
4028
4029         * MiniBrowser/mac/AppDelegate.m:
4030         (defaultConfiguration):
4031         * MiniBrowser/mac/SettingsController.h:
4032         * MiniBrowser/mac/SettingsController.m:
4033         (-[SettingsController _populateMenu]):
4034         (-[SettingsController validateMenuItem:]):
4035         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
4036         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
4037
4038 2019-01-10  Timothy Hatcher  <timothy@apple.com>
4039
4040         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
4041         https://bugs.webkit.org/show_bug.cgi?id=193327
4042         rdar://problem/47093222
4043
4044         Reviewed by Tim Horton.
4045
4046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4047         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
4048         (TestWebKitAPI::didFinishNavigation):
4049         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
4050         (TestWebKitAPI::TEST):
4051         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
4052         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
4053         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
4054         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
4055         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
4056
4057 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
4058
4059         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
4060         https://bugs.webkit.org/show_bug.cgi?id=193338
4061         <rdar://problem/46664774>
4062
4063         Reviewed by David Kilzer.
4064
4065         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4066         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
4067
4068 2019-01-10  Commit Queue  <commit-queue@webkit.org>
4069
4070         Unreviewed, rolling out r239825.
4071         https://bugs.webkit.org/show_bug.cgi?id=193330
4072
4073         Broke tests on armv7/linux bots (Requested by guijemont on
4074         #webkit).
4075
4076         Reverted changeset:
4077
4078         "Enable DFG on ARM/Linux again"
4079         https://bugs.webkit.org/show_bug.cgi?id=192496
4080         https://trac.webkit.org/changeset/239825
4081
4082 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
4083
4084         Disable the run-jsc-stress-test remote host key check.
4085         https://bugs.webkit.org/show_bug.cgi?id=192988
4086
4087         Reviewed by Alexey Proskuryakov.
4088
4089         * Scripts/run-jsc-stress-tests:
4090
4091 2019-01-10  John Wilander  <wilander@apple.com>
4092
4093         Override the session configuration for cookieAcceptPolicy
4094         https://bugs.webkit.org/show_bug.cgi?id=190925
4095         <rdar://problem/45497382>
4096
4097         Reviewed by Alexey Proskuryakov and Alex Christensen.
4098
4099         Test infrastructure for setting a first-party-only cookie policy.
4100
4101         * DumpRenderTree/TestRunner.cpp:
4102         (setOnlyAcceptFirstPartyCookiesCallback):
4103         (TestRunner::staticFunctions):
4104         * DumpRenderTree/TestRunner.h:
4105         * DumpRenderTree/mac/TestRunnerMac.mm:
4106         (TestRunner::setOnlyAcceptFirstPartyCookies):
4107         * DumpRenderTree/win/TestRunnerWin.cpp:
4108         (TestRunner::setOnlyAcceptFirstPartyCookies):
4109         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4110         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4111         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
4112         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4113         * WebKitTestRunner/TestInvocation.cpp:
4114         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4115
4116 2019-01-09  Matt Rajca  <mrajca@apple.com>
4117
4118         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
4119         https://bugs.webkit.org/show_bug.cgi?id=193301
4120
4121         Reviewed by Jer Noble.
4122         
4123         Added API tests.
4124
4125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4126         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4127         (TEST):
4128         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
4129
4130 2019-01-10  Zalan Bujtas  <zalan@apple.com>
4131
4132         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
4133         https://bugs.webkit.org/show_bug.cgi?id=193310
4134
4135         Reviewed by Antti Koivisto.
4136
4137         * LayoutReloaded/misc/LFC-passing-tests.txt:
4138
4139 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
4140
4141         Enable DFG on ARM/Linux again
4142         https://bugs.webkit.org/show_bug.cgi?id=192496
4143
4144         Reviewed by Yusuke Suzuki.
4145
4146         After changing the bytecode format DFG was disabled on all 32-bit
4147         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
4148         on ARM by default.
4149
4150         * Scripts/run-jsc-stress-tests:
4151
4152 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
4153
4154         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
4155         https://bugs.webkit.org/show_bug.cgi?id=193271
4156
4157         Reviewed by Brent Fulgham.
4158
4159         BSTR is a special data structure created by SysAllocString, not a
4160         wchar_t null-terminated string.
4161
4162         * DumpRenderTree/win/TestRunnerWin.cpp:
4163         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
4164         * MiniBrowser/win/MiniBrowserWebHost.cpp:
4165         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
4166         BSTR from wide string literals.
4167
4168 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
4169
4170         Tweak wording for build/version_check style checker error
4171         https://bugs.webkit.org/show_bug.cgi?id=193256
4172
4173         Reviewed by Tim Horton.
4174
4175         * Scripts/webkitpy/style/checkers/cpp.py:
4176         (check_os_version_checks):
4177         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4178         (WebKitStyleTest.test_os_version_checks):
4179
4180 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4181
4182         [ews-build] Add link to bug along with bug title
4183         https://bugs.webkit.org/show_bug.cgi?id=193293
4184
4185         Reviewed by Lucas Forschler.
4186
4187         * BuildSlaveSupport/ews-build/steps.py:
4188         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
4189         (ConfigureBuild.add_bug_id_url): Deleted.
4190         (ConfigureBuild.getBugURL): Deleted.
4191
4192 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4193
4194         [ews-build] Use https for ews-build server
4195         https://bugs.webkit.org/show_bug.cgi?id=193193
4196
4197         Reviewed by Lucas Forschler.
4198
4199         * BuildSlaveSupport/ews-build/steps.py:
4200
4201 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4202
4203         [ews-build] Parse and display number of style failures
4204         https://bugs.webkit.org/show_bug.cgi?id=193280
4205
4206         Reviewed by Lucas Forschler.
4207
4208         * BuildSlaveSupport/ews-build/steps.py:
4209         (CheckStyle): Use TestWithFailureCount as base class.
4210         (CheckStyle.countFailures): Count the number of style failures.
4211
4212 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4213
4214         [ews-build] use patch_id instead of ewspatchid
4215         https://bugs.webkit.org/show_bug.cgi?id=193235
4216
4217         Reviewed by Lucas Forschler.
4218
4219         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
4220         * BuildSlaveSupport/ews-build/steps.py: Ditto.
4221         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
4222
4223 2019-01-09  Zalan Bujtas  <zalan@apple.com>
4224
4225         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
4226         https://bugs.webkit.org/show_bug.cgi?id=192625
4227
4228         Reviewed by Antti Koivisto.
4229
4230         * LayoutReloaded/misc/LFC-passing-tests.txt:
4231
4232 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
4233
4234         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
4235         https://bugs.webkit.org/show_bug.cgi?id=192841
4236
4237         Reviewed by Carlos Garcia Campos.
4238
4239         There are separate g_assert_*() macros for use in tests, which we use inconsistently
4240         currently. Use them always. We'll get nicer error messages now when tests fail, and the
4241         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
4242
4243         Note that the documentation of g_assert() says that it is not to be used when writing tests.
4244
4245         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4246         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
4247         (WebKitWebEditorTest::testSelectionChanged):
4248         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
4249         (WebKitFrameTest::testMainFrame):
4250         (WebKitFrameTest::testURI):
4251         (WebKitFrameTest::testJavaScriptContext):
4252         (WebKitFrameTest::testJavaScriptValues):
4253         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
4254         (testWebViewAuthenticationRequest):
4255         (testWebViewAuthenticationLoadCancelled):
4256         (testWebViewAuthenticationFailure):
4257         (testWebViewAuthenticationStorage):
4258         (ProxyAuthenticationTest::ProxyAuthenticationTest):
4259         (testWebViewAuthenticationProxy):
4260         (testWebViewAuthenticationProxyHTTPS):
4261         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4262         (testAutomationSessionRequestSession):
4263         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
4264         (testBackForwardListNavigation):
4265         (testWebKitWebViewSessionState):
4266         (testWebKitWebViewSessionStateWithFormData):
4267         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
4268         (ConsoleMessageTest::consoleMessageReceivedCallback):
4269         (testWebKitConsoleMessageConsoleAPI):
4270         (testWebKitConsoleMessageJavaScriptException):
4271         (testWebKitConsoleMessageNetworkError):
4272         (testWebKitConsoleMessageSecurityError):
4273         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
4274         (testCookieManagerAcceptPolicy):
4275         (testCookieManagerCookiesChanged):
4276         (testCookieManagerPersistentStorage):
4277         (testCookieManagerPersistentStorageDeleteAll):
4278         (testCookieManagerEphemeral):
4279         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
4280         (testWebKitDOMElementAutoFill):
4281         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
4282         (downloadLocalFileSuccessfully):
4283         (createFileAtDestination):
4284         (testDownloadOverwriteDestinationDisallowed):
4285         (testDownloadLocalFileError):
4286         (testDownloadRemoteFile):
4287         (testDownloadRemoteFileError):
4288         (testWebViewDownloadURI):
4289         (testPolicyResponseDownload):
4290         (testPolicyResponseDownloadCancel):
4291         (testDownloadMIMEType):
4292         (contextMenuCallback):
4293         (testContextMenuDownloadActions):
4294         (testBlobDownload):
4295         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
4296         (testWebKitWebEditorSelectionChanged):
4297         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
4298         (testWebKitFrameMainFrame):
4299         (testWebKitFrameURI):
4300         (testWebKitFrameJavaScriptContext):
4301         (testWebKitFrameJavaScriptValues):
4302         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4303         (LoadStopTrackingTest::loadFailed):
4304         (testWebViewTitle):
4305         (testURIRequestHTTPHeaders):
4306         (testURIRequestHTTPMethod):
4307         (testURIResponseHTTPHeaders):
4308         (testRedirectToDataURI):
4309         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
4310         (testProcessPerWebView):
4311         (testWebProcessLimit):
4312         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
4313         (testWebViewResources):
4314         (testWebResourceLoading):
4315         (testWebResourceSuggestedFilename):
4316         (testWebResourceGetData):
4317         (testWebResourceGetDataError):
4318         (testWebViewResourcesHistoryCache):
4319         (testWebResourceSendRequest):
4320         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
4321         (testSSL):
4322         (testInsecureContent):
4323         (testTLSErrorsPolicy):
4324         (testTLSErrorsRedirect):
4325         (testTLSErrorsHTTPAuth):
4326         (testLoadFailedWithTLSErrors):
4327         (testSubresourceLoadFailedWithTLSErrors):
4328         (httpsServerCallback):
4329         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
4330         (testWebViewCreateNavigationData):
4331         (testWebViewJavaScriptDialogs):
4332         (testWebViewWindowProperties):
4333         (testWebViewMouseTarget):
4334</