[ews-build] Use https for sending data to ews-app
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Use https for sending data to ews-app
4         https://bugs.webkit.org/show_bug.cgi?id=196492
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-build/events.py:
9
10 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
11
12         Remove support for -apple-trailing-word
13         https://bugs.webkit.org/show_bug.cgi?id=196525
14
15         Reviewed by Zalan Bujtas.
16
17         This CSS property is nonstandard and not used.
18
19         * Scripts/webkitperl/FeatureList.pm:
20         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
21
22 2019-04-03  Youenn Fablet  <youenn@apple.com>
23
24         Add a test for DOMCache on multiple browsing in case of private browsing
25         https://bugs.webkit.org/show_bug.cgi?id=196524
26
27         Reviewed by Alex Christensen.
28
29         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
30         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
31
32 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
33
34         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
35         https://bugs.webkit.org/show_bug.cgi?id=196540
36
37         Reviewed by Aakash Jain.
38
39         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
40
41 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
42
43         Add plumbing for a compatibility mode preference in WebKit
44         https://bugs.webkit.org/show_bug.cgi?id=196005
45
46         Reviewed by Tim Horton.
47
48         Add new API tests.
49
50         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
51         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
52
53 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
54
55         [WPE][GTK] Update libsrtp dependency package for Debian
56         https://bugs.webkit.org/show_bug.cgi?id=196528
57
58         Reviewed by Frédéric Wang.
59
60         * gtk/install-dependencies:
61         * wpe/install-dependencies:
62
63 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
64
65         [WK2] Add support for Window's beforeprint / afterprint events
66         https://bugs.webkit.org/show_bug.cgi?id=196478
67         <rdar://problem/49535124>
68
69         Unreviewed build fix for MSVC.
70
71         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
72
73         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
74
75         * WebKitTestRunner/TestController.cpp:
76         (WTR::printFrame): Use int and float literals.
77
78 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
79
80         [ews-build] Reassign bots to queues
81
82         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
83
84 2019-04-02  Chris Dumez  <cdumez@apple.com>
85
86         [WK2] Add support for Window's beforeprint / afterprint events
87         https://bugs.webkit.org/show_bug.cgi?id=196478
88
89         Reviewed by Alex Christensen.
90
91         Add minimal implementation for printFrame in WebKitTestRunner.
92
93         * WebKitTestRunner/TestController.cpp:
94         (WTR::printFrame):
95         (WTR::TestController::createOtherPage):
96         (WTR::TestController::createWebViewWithOptions):
97
98 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
99
100         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
101         https://bugs.webkit.org/show_bug.cgi?id=196491
102
103         Reviewed by Lucas Forschler.
104
105         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
106
107 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
108
109         [ews-build] Configure buildbot try credentials in environment variables
110         https://bugs.webkit.org/show_bug.cgi?id=196501
111
112         Reviewed by Lucas Forschler.
113
114         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
115         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
116         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
117
118 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
119
120         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
121         https://bugs.webkit.org/show_bug.cgi?id=196496
122         <rdar://problem/49521634>
123
124         Reviewed by Chris Dumez.
125
126         Add new API tests (see WebKit ChangeLog for more detail).
127
128         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
129         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
130         (TEST):
131
132 2019-04-02  David Kilzer  <ddkilzer@apple.com>
133
134         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
135         <https://webkit.org/b/196499>
136
137         Reviewed by Alexey Proskuryakov.
138
139         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
140         ENABLE_ADDRESS_SANITIZER.
141
142 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
143
144         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
145         https://bugs.webkit.org/show_bug.cgi?id=182757
146
147         Reviewed by Don Olmstead.
148
149         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
150         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
151
152 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
153
154         run-api-tests: Upload test results
155         https://bugs.webkit.org/show_bug.cgi?id=196323
156         <rdar://problem/49356714>
157
158         Reviewed by Lucas Forschler.
159
160         * Scripts/webkitpy/api_tests/manager.py:
161         (Manager):
162         (Manager.run): Upload results to a results database.
163         * Scripts/webkitpy/api_tests/run_api_tests.py:
164         (parse_args): Add upload arguments.
165         * Scripts/webkitpy/port/base.py:
166         (Port):
167         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
168         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
169         with commits from any other associated repositories.
170         * Scripts/webkitpy/port/device.py:
171         (Device):
172         (Device.build_version): Access build_versoin of underlying platform device.
173         * Scripts/webkitpy/port/ios_simulator_unittest.py:
174         (IOSSimulatorTest):
175         (IOSSimulatorTest.test_configuration_for_upload):
176         * Scripts/webkitpy/port/device_port.py:
177         (DevicePort):
178         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
179         the same as the machine uploading results.
180         * Scripts/webkitpy/port/mac.py:
181         (MacPort):
182         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
183         * Scripts/webkitpy/port/mac_unittest.py:
184         (MacTest):
185         (MacTest.test_configuration_for_upload):
186         * Scripts/webkitpy/xcode/simulated_device.py:
187         (SimulatedDeviceManager._create_device_with_runtime):
188         (SimulatedDevice.__init__): Create simulated device with a build_version.
189         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
190         (test_existing_simulator):
191
192 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
193
194         Remove extra newline characters (Follow-up fix to r243707)
195
196         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
197
198 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
199
200         [ews-app] Use API_KEY to accept results data
201         https://bugs.webkit.org/show_bug.cgi?id=196461
202
203         Reviewed by Dewei Zhu.
204
205         * BuildSlaveSupport/ews-app/ews/views/results.py:
206         (Results.post): Validate EWS_API_KEY before accepting any data.
207         * BuildSlaveSupport/ews-build/events.py:
208         (Events.sendData): Send EWS_API_KEY if available along with event data.
209
210 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
211
212         Unable to copy and paste a PDF from Notes into Mail compose body
213         https://bugs.webkit.org/show_bug.cgi?id=196442
214         <rdar://problem/48573098>
215
216         Reviewed by Tim Horton.
217
218         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
219         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
220         to be specified on the item providers.
221
222         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
223         (TestWebKitAPI::mapItemForTesting):
224         (TestWebKitAPI::contactItemForTesting):
225
226 2019-04-01  Tim Horton  <timothy_horton@apple.com>
227
228         Make UIWKDocumentContext rects per-character instead of per-word
229         https://bugs.webkit.org/show_bug.cgi?id=196459
230
231         Reviewed by Wenson Hsieh.
232
233         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
234         (TEST):
235         Adjust test results due to switching to per-character rects.
236
237 2019-04-01  Chris Dumez  <cdumez@apple.com>
238
239         UIProcess crash when a prewarmed process is terminated
240         https://bugs.webkit.org/show_bug.cgi?id=196451
241         <rdar://problem/49245471>
242
243         Reviewed by Geoffrey Garen.
244
245         Add API test coverage.
246
247         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
248         (TEST):
249
250 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
251
252         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
253         https://bugs.webkit.org/show_bug.cgi?id=196449
254
255         Reviewed by Lucas Forschler.
256
257         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
258         (StatusBubble.get_os_details): Method to get OS and Xcode details.
259         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
260         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
261
262 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
263
264         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
265         https://bugs.webkit.org/show_bug.cgi?id=196444
266
267         Reviewed by Lucas Forschler.
268
269         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
270
271 2019-04-01  Alex Christensen  <achristensen@webkit.org>
272
273         Add SPI to canonicalize NSURLs with WTF::URL
274         https://bugs.webkit.org/show_bug.cgi?id=196415
275         <rdar://problem/44980271>
276
277         Reviewed by Darin Adler.
278
279         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
280         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
281         (TestWebKitAPI::TEST):
282
283 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
284
285         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
286         https://bugs.webkit.org/show_bug.cgi?id=196441
287
288         Reviewed by Carlos Garcia Campos.
289
290         Don't cache the wpe_view_backend object that might not exist yet at the
291         time of EventSenderProxy constructor invocation, but instead retrieve
292         that object whenever it's required for event dispatching. This should
293         avoid crashes in this constructor now that it's invoked before any
294         PlatformWindow has been set up (as changed in r243496).
295
296         * WebKitTestRunner/EventSenderProxy.h:
297         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
298         (WTR::viewBackend):
299         (WTR::EventSenderProxy::EventSenderProxy):
300         (WTR::EventSenderProxy::mouseDown):
301         (WTR::EventSenderProxy::mouseUp):
302         (WTR::EventSenderProxy::mouseMoveTo):
303         (WTR::EventSenderProxy::mouseScrollBy):
304         (WTR::EventSenderProxy::keyDown):
305         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
306
307 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
308
309         [Win][WebKit] MiniBrowser should support high DPI display
310         https://bugs.webkit.org/show_bug.cgi?id=196391
311
312         Reviewed by Alex Christensen.
313
314         * MiniBrowser/win/WebKitBrowserWindow.cpp:
315         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
316         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
317         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
318
319 2019-03-31  Sam Weinig  <weinig@apple.com>
320
321         Remove more i386 specific configurations
322         https://bugs.webkit.org/show_bug.cgi?id=196430
323
324         Reviewed by Alexey Proskuryakov.
325
326         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
327         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
328
329 2019-03-31  Andy Estes  <aestes@apple.com>
330
331         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
332         https://bugs.webkit.org/show_bug.cgi?id=196433
333         <rdar://problem/49293305>
334
335         Reviewed by Tim Horton.
336
337         Enhanced API test coverage to include all navigation response policy decisions in both
338         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
339
340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
341         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
342         (TestWebKitAPI::TEST):
343         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
344         (readFile):
345         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
346         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
347         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
348         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
349         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
350         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
351         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
352         (-[QuickLookDelegate _downloadDidStart:]):
353         (-[QuickLookDelegate _download:didReceiveResponse:]):
354         (-[QuickLookDelegate _download:didReceiveData:]):
355         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
356         (-[QuickLookDelegate _downloadDidFinish:]):
357         (-[QuickLookDelegate _download:didFailWithError:]):
358         (-[QuickLookDelegate _downloadDidCancel:]):
359         (-[QuickLookDelegate verifyDownload]):
360         (runTest):
361         (runTestDecideBeforeLoading):
362         (runTestDecideAfterLoading):
363         (TEST):
364         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
365         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
366         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
367         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
368         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
369         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
370         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
371         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
372         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
373         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
374         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
375         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
376         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
377         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
378
379 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
380
381         [CMake] add testdfg as target with build-jsc
382         https://bugs.webkit.org/show_bug.cgi?id=196393
383
384         Reviewed by Saam Barati.
385
386         Added testdfg as one of the targets to build when
387         using CMake.
388
389         * Scripts/build-jsc:
390
391 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
392
393         Delete WebMetal implementation in favor of WebGPU
394         https://bugs.webkit.org/show_bug.cgi?id=195418
395
396         Reviewed by Dean Jackson.
397
398         * DumpRenderTree/mac/DumpRenderTree.mm:
399         (enableExperimentalFeatures):
400         (resetWebPreferencesToConsistentValues):
401         * Scripts/webkitperl/FeatureList.pm:
402         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
403         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
404         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
405         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
406         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
407         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
408         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
409         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
410         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
411         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
412         (WTR::InjectedBundle::beginTesting):
413         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
414         (WTR::TestRunner::setWebMetalEnabled): Deleted.
415         * WebKitTestRunner/InjectedBundle/TestRunner.h:
416
417 2019-03-29  Chris Dumez  <cdumez@apple.com>
418
419         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
420         https://bugs.webkit.org/show_bug.cgi?id=196405
421         <rdar://problem/49428130>
422
423         Reviewed by Wenson Hsieh.
424
425         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
426         the popover presentation methods to be no-ops. Use this in the new test added in
427         r243523 so that we do not swizzle those methods for all tests. This is needed because
428         those WatchOS tests rely on the popover getting presented and interactive.
429
430         * WebKitTestRunner/TestController.cpp:
431         (WTR::updateTestOptionsFromTestHeader):
432         * WebKitTestRunner/TestController.h:
433         * WebKitTestRunner/TestOptions.h:
434         (WTR::TestOptions::hasSameInitializationOptions const):
435         * WebKitTestRunner/ios/TestControllerIOS.mm:
436         (WTR::TestController::platformInitialize):
437         (WTR::TestController::platformResetStateToConsistentValues):
438
439 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
440
441         [Curl] Add Server Trust Evaluation Support.
442         https://bugs.webkit.org/show_bug.cgi?id=191646
443
444         Reviewed by Fujii Hironori.
445
446         Implemented MiniBrowser UI for asking if user trusts the server.
447
448         * MiniBrowser/win/Common.cpp:
449         (askServerTrustEvaluation):
450         (replaceString):
451         * MiniBrowser/win/Common.h:
452         * MiniBrowser/win/MiniBrowserLib.rc:
453         * MiniBrowser/win/MiniBrowserLibResource.h:
454         * MiniBrowser/win/WebKitBrowserWindow.cpp:
455         (createPEMString):
456         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
457         (WebKitBrowserWindow::canTrustServerCertificate):
458         * MiniBrowser/win/WebKitBrowserWindow.h:
459
460 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
461
462         Implement ResizeObserver.
463         https://bugs.webkit.org/show_bug.cgi?id=157743
464
465         Reviewed by Simon Fraser.
466
467         Support resizeObserverEnabled webPreferences.
468
469         * DumpRenderTree/TestOptions.cpp:
470         (TestOptions::TestOptions):
471         * DumpRenderTree/TestOptions.h:
472         * DumpRenderTree/mac/DumpRenderTree.mm:
473         (setWebPreferencesForTestOptions):
474         * DumpRenderTree/win/DumpRenderTree.cpp:
475         (enableExperimentalFeatures):
476         * Scripts/webkitperl/FeatureList.pm:
477         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
478
479 2019-03-28  John Wilander  <wilander@apple.com>
480
481         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
482         https://bugs.webkit.org/show_bug.cgi?id=196281
483         <rdar://problem/48938748>
484
485         Reviewed by Alex Christensen.
486
487         This patch adds the function isStatisticsHasLocalStorage() to the
488         TestRunner. With it, the page can query the WebsiteDataStore in the
489         UI process to make sure that it sees LocalStorage.
490
491         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
492         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
493         (WTR::TestRunner::isStatisticsHasLocalStorage):
494         * WebKitTestRunner/InjectedBundle/TestRunner.h:
495         * WebKitTestRunner/TestController.cpp:
496         (WTR::TestController::isStatisticsHasLocalStorage):
497         * WebKitTestRunner/TestController.h:
498         * WebKitTestRunner/TestInvocation.cpp:
499         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
500
501 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
502
503         API::Data::createWithoutCopying should do a null check before calling CFRelease
504         https://bugs.webkit.org/show_bug.cgi?id=196276
505         <rdar://problem/48059859>
506
507         Reviewed by Alex Christensen.
508
509         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
510
511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
512         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
513         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
514         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
515         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
516         (TestWebKitAPI::TEST):
517
518 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
519
520         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
521         https://bugs.webkit.org/show_bug.cgi?id=186276
522
523         Reviewed by Carlos Garcia Campos.
524
525         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
526         (webViewLoadChanged):
527         (testWebResourceGetDataError):
528         (testWebResourceGetDataEmpty):
529         (beforeAll):
530         (webViewloadChanged): Deleted.
531
532 2019-03-27  Andy Estes  <aestes@apple.com>
533
534         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
535         https://bugs.webkit.org/show_bug.cgi?id=196317
536
537         Reviewed by Dan Bernstein.
538
539         package-root copies built products into a staging directory using ditto(1), which does not
540         follow symbolic links as it traverses a directory. Now that the files in
541         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
542         itself, these become broken links when ditto'd into the staging directory.
543
544         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
545
546         * Scripts/package-root:
547
548 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
549
550         [ews-app] Update display text of Submit for ews analysis
551         https://bugs.webkit.org/show_bug.cgi?id=196309
552
553         Reviewed by Dewei Zhu.
554
555         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
556
557 2019-03-27  David Kilzer  <ddkilzer@apple.com>
558
559         run-webkit-tests should check for leaks in WebKit processes
560         <https://webkit.org/b/193772>
561         <rdar://problem/46526680>
562
563         Reviewed by Ryosuke Niwa.
564
565         This works by doing the following:
566         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
567           The list of child processes are returned one per line:
568           process.name: pid
569         - Run the "#LIST CHILD PROCESSES" command just before the
570           "#CHECK FOR WORLD LEAKS" command, and store the list of child
571           processes on the ServerProcess object.
572         - When the `--leaks` switch is handled, run check_for_leaks() on
573           each child process after the main test harness.
574
575         * DumpRenderTree/mac/DumpRenderTree.mm:
576         (handleControlCommand):
577         - Use strncmp() instead of strcmp().
578         - Add support for handling "#LIST CHILD PROCESSES" command.
579
580         * Scripts/webkitpy/port/base.py:
581         (Port.check_for_leaks):
582         * Scripts/webkitpy/port/darwin.py:
583         (DarwinPort.check_for_leaks):
584         - Rename redundant 'process_pid' argument to 'process_id'.
585
586         * Scripts/webkitpy/port/driver.py:
587         (Driver.do_post_tests_work):
588         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
589           longer the only command this sends to WebKitTestRunner.
590         - If the `--leaks` switch is present, send the
591           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
592           result using Port.set_webkit_processes().
593         (Driver._parse_child_processes_output):
594         - Add helper method to parse list of child process names and
595           process IDs returned from WebKitTestRunner.
596
597         * Scripts/webkitpy/port/ios_device.py:
598         (IOSDevicePort.check_for_leaks):
599         - Rename redundant 'process_pid' argument to 'process_id'.
600
601         * Scripts/webkitpy/port/leakdetector.py:
602         (LeakDetector._parse_leaks_output):
603         - Return early if there is no leaks_output.
604         (LeakDetector.check_for_leaks):
605         - Rename redundant 'process_pid' argument to 'process_id'.
606
607         * Scripts/webkitpy/port/server_process.py:
608         (ServerProcess.__init__):
609         (ServerProcess.child_processes):
610         (ServerProcess.set_child_processes):
611         - Add instance variable to Port to store list of child process
612           names and process IDs returned from WebKitTestRunner.
613         (ServerProcess._start):
614         - Clear self._child_processes.
615         (ServerProcess.stop):
616         - If self._child_processes is set, call
617           self._port.check_for_leaks() for each child process.
618
619         * Scripts/webkitpy/port/server_process_unittest.py:
620         (TrivialMockPort.check_for_leaks):
621         - Rename redundant 'process_pid' argument to 'process_id'.
622
623         * Scripts/webkitpy/port/simulator_process.py:
624         (SimulatorProcess.stop):
625         - If self._child_processes is set, call
626           self._port.check_for_leaks() for each child process.
627
628         * Scripts/webkitpy/port/watch_device.py:
629         (WatchDevicePort.check_for_leaks):
630         - Rename redundant 'process_pid' argument to 'process_id'.
631
632         * WebKitTestRunner/TestController.cpp:
633         (WTR::TestController::dumpResponse):
634         - Extract method from findAndDumpWorldLeaks() so that it may be
635           reused by findAndDumpWebKitProcessIdentifiers().
636         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
637         - Add method to output process name and process ID of both the
638           WebContent and Networking processes.
639         (WTR::TestController::findAndDumpWorldLeaks):
640         - Fix missing newline in output when there were no abandoned
641           documents.
642         - Call dumpResponse() for extracted code.
643         (WTR::TestController::handleControlCommand):
644         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
645         - Use strncmp() instead of strcmp().
646         - Call findAndDumpWebKitProcessIdentifiers() when
647           "#LIST CHILD PROCESSES" command is sent.
648         * WebKitTestRunner/TestController.h:
649         (WTR::TestController::dumpResponse):
650         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
651         - Declare methods.
652
653 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
654
655         Unreviewed. Add GLib API test cases after r243434.
656
657         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
658         (testWebViewActiveURI):
659         (serverCallback):
660         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
661         (sendRequestCallback):
662
663 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
664
665         Geolocation request not complete when watch request was started in a different web process
666         https://bugs.webkit.org/show_bug.cgi?id=195996
667
668         Reviewed by Alex Christensen.
669
670         Add a test case.
671
672         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
673         (TestWebKitAPI::runJavaScriptAlert):
674         (TestWebKitAPI::TEST):
675
676 2019-03-26  Keith Rollin  <krollin@apple.com>
677
678         Update the way generate-xcfilelists returns strings from functions
679         https://bugs.webkit.org/show_bug.cgi?id=195975
680         <rdar://problem/49040807>
681
682         Reviewed by Dean Jackson.
683
684         There are places where generate-xcfilelists executes assignments with
685         statements like:
686
687             FOO=$(some_function)
688
689         where "some_function" return a string by echoing it. E.g.
690
691             some_function()
692             {
693                 echo "Hello, World"
694             }
695
696         This is a common idiom, but it has a problem if "some_function" needs
697         to call "exit" in an attempt to halt the entire script right then and
698         there. Since "some_function" is called inside of $(), it's being
699         executed in a sub-shell. Calling exit in that sub-shell simply exits
700         that shell; it doesn't not exit the outer shell in which the main part
701         of the script is still running. As such, the main script keeps
702         executing when the intent was for the script to halt.
703
704         The solution to this is to use a different idiom for returning
705         strings. The one we now is to pass in the name of the variable to
706         receive the string result:
707
708             some_function()
709             {
710                 variable_name=$1
711                 eval $variable_name ="Hello, World"
712             }
713
714         The call site now looks like
715
716             some_function FOO
717
718         Because there's no invocation of a sub-shell, some_function can now
719         call "exit" if it wants to, and the entire script will exit at that
720         point.
721
722         * Scripts/generate-xcfilelists:
723
724 2019-03-26  Chris Dumez  <cdumez@apple.com>
725
726         Add basic layout test coverage for File Picker on iOS
727         https://bugs.webkit.org/show_bug.cgi?id=196265
728
729         Reviewed by Wenson Hsieh.
730
731         Add layout test infrastructure to test the file picker on iOS.
732
733         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
734         (WTR::UIScriptController::dismissFilePicker):
735         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
736         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
737         (WTR::UIScriptController::dismissFilePicker):
738         * TestRunnerShared/UIScriptContext/UIScriptController.h:
739         * WebKitTestRunner/TestController.cpp:
740         (WTR::TestController::createWebViewWithOptions):
741         (WTR::updateTestOptionsFromTestHeader):
742         * WebKitTestRunner/TestOptions.h:
743         (WTR::TestOptions::hasSameInitializationOptions const):
744         * WebKitTestRunner/ios/TestControllerIOS.mm:
745         (overridePresentViewController):
746         (WTR::TestController::platformInitialize):
747         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
748         (WTR::UIScriptController::dismissFilePicker):
749
750 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
751
752         Implement async paste method on UIWKInteractionViewProtocol
753         https://bugs.webkit.org/show_bug.cgi?id=196267
754         <rdar://problem/49236346>
755
756         Reviewed by Tim Horton.
757
758         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
759         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
760         are now a part of all iOS 12 internal SDKs.
761
762         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
763
764         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
765         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
766
767         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
768         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
769         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
770         * TestWebKitAPI/ios/UIKitSPI.h:
771
772 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
773
774         [ews-build] Use PostgreSQL for ews.webkit.org database
775         https://bugs.webkit.org/show_bug.cgi?id=196270
776
777         Reviewed by Lucas Forschler.
778
779         * BuildSlaveSupport/ews-app/ews-app/settings.py:
780
781 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
782
783         [ews] Reset simctl states on reboot
784         https://bugs.webkit.org/show_bug.cgi?id=196260
785
786         Rubber-stamped by Aakash Jain.
787
788         * EWSTools/start-queue-mac.sh:
789
790 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
791
792         [ews-build] Use PostgreSQL for ews-build database
793         https://bugs.webkit.org/show_bug.cgi?id=196229
794
795         Reviewed by Lucas Forschler.
796
797         * BuildSlaveSupport/ews-build/master.cfg:
798
799 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
800
801         [ews-build] Get master_hostname dynamically in master.cfg
802         https://bugs.webkit.org/show_bug.cgi?id=196255
803
804         Reviewed by Lucas Forschler.
805
806         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
807         send events data in test mode.
808
809 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
810
811         [ews-app] Set db_constraint to False for Foreign Keys
812         https://bugs.webkit.org/show_bug.cgi?id=196252
813
814         Reviewed by Lucas Forschler.
815
816         * BuildSlaveSupport/ews-app/ews/models/build.py:
817         * BuildSlaveSupport/ews-app/ews/models/step.py:
818
819 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
820
821         [ews-build] is_test_mode_enabled should default to True
822         https://bugs.webkit.org/show_bug.cgi?id=196248
823
824         Reviewed by Lucas Forschler.
825
826         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
827
828 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
829
830         [ews-app] Add webkitperl to ENABLED_QUEUES
831         https://bugs.webkit.org/show_bug.cgi?id=196253
832
833         Reviewed by Lucas Forschler.
834
835         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
836
837 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
838
839         Address NSWindow sometimes using WebKitTestRunnerEvent too early
840         https://bugs.webkit.org/show_bug.cgi?id=196211
841         rdar://problem/49110552
842
843         Reviewed by Tim Horton.
844
845         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
846         Make sure that EventSenderProxy always exists when running tests. We used to create
847         it when resetting before the first test, which is a bit too late.
848
849         * WebKitTestRunner/TestController.h:
850         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
851         (WTR::TestController::platformCreateWebView):
852         (WTR::TestController::platformCreateOtherPage):
853         (WTR::TestController::finishCreatingPlatformWebView):
854         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
855         (WTR::PlatformWebView::PlatformWebView):
856         Moved some code that made NSWindow use NSEvent during web view creation. We may
857         need to move more if some other case us found, but this is enough for now.
858
859 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
860
861         Unreviewed. Fix typo in GLib geolocation API after r243285.
862
863         gelocation -> geolocation.
864
865         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
866         (testGeolocationManagerWatchPosition):
867
868 2019-03-25  Alex Christensen  <achristensen@webkit.org>
869
870         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
871         https://bugs.webkit.org/show_bug.cgi?id=196213
872
873         Reviewed by Geoff Garen.
874
875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
876         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
877         (credentialWithIdentityAndKeychainPath):
878         (-[ChallengeDelegate webView:didFinishNavigation:]):
879         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
880         (TestWebKitAPI::TEST):
881
882 2019-03-25  Alex Christensen  <achristensen@webkit.org>
883
884         Expected shouldn't assume its contained types are copyable
885         https://bugs.webkit.org/show_bug.cgi?id=195986
886
887         Reviewed by JF Bastien.
888
889         * TestWebKitAPI/Tests/WTF/Expected.cpp:
890         (TestWebKitAPI::NonCopyable::operator== const):
891         (TestWebKitAPI::NonCopyable::operator!= const):
892         (TestWebKitAPI::TEST):
893
894 2019-03-25  Tim Horton  <timothy_horton@apple.com>
895
896         Remove some now-unnecessary dynamic class lookup
897         https://bugs.webkit.org/show_bug.cgi?id=196237
898
899         Reviewed by Simon Fraser.
900
901         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
902         (makeRequest):
903         (TEST):
904
905 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
906
907         Unreviewed, rolling out r243450.
908
909         AppleWin and WinCairo port builds get broken.
910
911         Reverted changeset:
912
913         "Add test for fix of #196095"
914         https://bugs.webkit.org/show_bug.cgi?id=196097
915         https://trac.webkit.org/changeset/243450
916
917 2019-03-25  Commit Queue  <commit-queue@webkit.org>
918
919         Unreviewed, rolling out r243465.
920         https://bugs.webkit.org/show_bug.cgi?id=196226
921
922         the test doesn't build (Requested by thorton on #webkit).
923
924         Reverted changeset:
925
926         "Do not terminate the NetworkProcess if a third party
927         application sends a NSCredential with a SecIdentityRef"
928         https://bugs.webkit.org/show_bug.cgi?id=196213
929         https://trac.webkit.org/changeset/243465
930
931 2019-03-25  Alex Christensen  <achristensen@webkit.org>
932
933         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
934         https://bugs.webkit.org/show_bug.cgi?id=196213
935
936         Reviewed by Geoff Garen.
937
938         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
939         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
940         (credentialWithIdentityAndKeychainPath):
941         (-[ChallengeDelegate webView:didFinishNavigation:]):
942         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
943         (TestWebKitAPI::TEST):
944
945 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
946
947         [ews-build] Gracefully handle missing patch_id in events
948         https://bugs.webkit.org/show_bug.cgi?id=196216
949
950         Reviewed by Lucas Forschler.
951
952         * BuildSlaveSupport/ews-build/events.py:
953
954 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
955
956         [ews-build] use lz4 compression for improving buildbot performance
957         https://bugs.webkit.org/show_bug.cgi?id=196155
958
959         Reviewed by Lucas Forschler.
960
961         * BuildSlaveSupport/ews-build/master.cfg:
962
963 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
964
965         Pull some API testing helper methods out of TestWKWebView
966         https://bugs.webkit.org/show_bug.cgi?id=196212
967
968         Reviewed by Tim Horton.
969
970         Refactor some more API testing utility methods, so that they can be used in
971         tests that do not use TestWKWebView.
972
973         * TestWebKitAPI/cocoa/TestWKWebView.h:
974         * TestWebKitAPI/cocoa/TestWKWebView.mm:
975         (-[WKWebView loadTestPageNamed:]):
976         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
977         (-[WKWebView synchronouslyLoadHTMLString:]):
978         (-[WKWebView synchronouslyLoadTestPageNamed:]):
979         (-[TestWKWebView loadTestPageNamed:]): Deleted.
980         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
981         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
982         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
983
984 2019-03-25  Jer Noble  <jer.noble@apple.com>
985
986         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
987         https://bugs.webkit.org/show_bug.cgi?id=196097
988
989         Reviewed by Eric Carlson.
990
991         Drive-by bug fix: allow tests to play audio without a user gesture by default.
992
993         * DumpRenderTree/mac/DumpRenderTree.mm:
994         (resetWebPreferencesToConsistentValues):
995         * WebKitTestRunner/TestController.cpp:
996         (WTR::TestController::resetPreferencesToConsistentValues):
997
998 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
999
1000         Pull IPadUserInterfaceSwizzler out into a separate header file
1001         https://bugs.webkit.org/show_bug.cgi?id=196193
1002
1003         Reviewed by Anders Carlsson.
1004
1005         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1006         be used in other API tests.
1007
1008         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1009         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1010         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1011         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1012         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1013         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1014         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1015
1016 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1017
1018         Remove NavigatorContentUtils in WebCore/Modules
1019         https://bugs.webkit.org/show_bug.cgi?id=196070
1020
1021         Reviewed by Alex Christensen.
1022
1023         NavigatorContentUtils was to support the custom scheme spec [1].
1024         However, in WebKit side, no port has supported the feature in
1025         WebKit layer after EFL port was removed. So there has been the
1026         only IDL implementation of the NavigatorContentUtils in WebCore.
1027         So we don't need to keep the implementation in WebCore anymore.
1028
1029         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1030
1031         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1032
1033 2019-03-24  Andy Estes  <aestes@apple.com>
1034
1035         [watchOS] Remove unused Proximity Networking code
1036         https://bugs.webkit.org/show_bug.cgi?id=196188
1037
1038         Reviewed by Tim Horton.
1039
1040         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1041         (TEST):
1042
1043 2019-03-23  Keith Miller  <keith_miller@apple.com>
1044
1045         Refactor clz/ctz and fix getLSBSet.
1046         https://bugs.webkit.org/show_bug.cgi?id=196162
1047
1048         Reviewed by Saam Barati.
1049
1050         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1051
1052         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1053         (TestWebKitAPI::TEST):
1054
1055 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1056
1057         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1058         https://bugs.webkit.org/show_bug.cgi?id=196143
1059
1060         Reviewed by Michael Catanzaro.
1061
1062         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1063         directories.
1064
1065         * Scripts/webkitpy/style/checkers/cpp.py:
1066         (check_identifier_name_in_declaration):
1067         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1068         (WebKitStyleTest.test_names):
1069
1070 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1071
1072         [Flatpak] Manifest expanding fails for qt WPE extension
1073         https://bugs.webkit.org/show_bug.cgi?id=196148
1074
1075         Reviewed by Alex Christensen.
1076
1077         * flatpak/flatpakutils.py:
1078         (expand_submodules_recurse): The last recurse manifest expand
1079         iteration might lead to a single module so take it into account
1080         and don't try to recurse further.
1081
1082 2019-03-22  Chris Dumez  <cdumez@apple.com>
1083
1084         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1085         https://bugs.webkit.org/show_bug.cgi?id=195348
1086         <rdar://problem/48622090>
1087
1088         Reviewed by Alex Christensen.
1089
1090         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1091         to NO when test.options().shouldIgnoreMetaViewport is false.
1092
1093         * WebKitTestRunner/ios/TestControllerIOS.mm:
1094         (WTR::TestController::platformConfigureViewForTest):
1095
1096 2019-03-22  Chris Dumez  <cdumez@apple.com>
1097
1098         Prewarmed processes should be usable with any website data store
1099         https://bugs.webkit.org/show_bug.cgi?id=196104
1100
1101         Reviewed by Alex Christensen.
1102
1103         Add API test coverage.
1104
1105         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1106         (runInitialWarmedProcessUsedTest):
1107         (TEST):
1108
1109 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1110
1111         Back out local changes to Alex's Subversion working directory
1112
1113         They were accidentally committed.
1114
1115         * Scripts/webkitpy/common/system/abstractexecutive.py:
1116         (AbstractExecutive.wait_newest):
1117         * Scripts/webkitpy/common/system/executive.py:
1118         (Executive.running_pids):
1119         * Scripts/webkitpy/common/system/executive_mock.py:
1120         (MockExecutive.running_pids):
1121         * Scripts/webkitpy/common/system/executive_unittest.py:
1122         (ExecutiveTest.serial_test_running_pids):
1123         * Scripts/webkitpy/port/darwin.py:
1124         (DarwinPort.check_for_leaks):
1125         * Scripts/webkitpy/port/leakdetector.py:
1126         (LeakDetector.check_for_leaks):
1127         - This was the hack attached to Bug 193772.
1128
1129         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1130         (+[WebKitTestRunnerEvent mouseLocation]):
1131         - This works around a crash on an internal build.
1132
1133 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1134
1135         Fix the build after r243354
1136         https://bugs.webkit.org/show_bug.cgi?id=196138
1137         <rdar://problem/49145951>
1138
1139         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1140         (TEST):
1141         * TestWebKitAPI/ios/UIKitSPI.h:
1142
1143 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1144
1145         Adopt UIWKDocumentContext
1146         https://bugs.webkit.org/show_bug.cgi?id=196040
1147         <rdar://problem/48642440>
1148
1149         Reviewed by Ryosuke Niwa.
1150
1151         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1152         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1153         (makeRequest):
1154         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1155         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1156         (applyStyle):
1157         (TEST):
1158         Add tests for UIWKDocumentContext.
1159
1160         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1161         (TEST):
1162         (recursiveFindWKContentView): Deleted.
1163         * TestWebKitAPI/cocoa/TestWKWebView.h:
1164         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1165         (recursiveFindWKContentView):
1166         (-[TestWKWebView wkContentView]):
1167         * TestWebKitAPI/ios/UIKitSPI.h:
1168         Share the WKContentView finding code between tests.
1169
1170 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1171
1172         [iOS WK2] Turn on async overflow scrolling by default
1173         https://bugs.webkit.org/show_bug.cgi?id=196011
1174         rdar://problem/48453859
1175
1176         Reviewed by Antti Koivisto.
1177         
1178         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1179         since so many basic layout tests have different results when compositing is triggered for
1180         overflow.
1181         
1182         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1183
1184         * WebKitTestRunner/TestController.cpp:
1185         (WTR::TestController::resetPreferencesToConsistentValues):
1186
1187 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1188
1189         [ews-build] Retry API test in case of failures
1190         https://bugs.webkit.org/show_bug.cgi?id=196004
1191
1192         Reviewed by Lucas Forschler.
1193
1194         * BuildSlaveSupport/ews-build/steps.py:
1195         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1196         (CompileWebKitToT.doStepIf): Ditto.
1197         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1198         (ReRunAPITests): Re-run API tests.
1199         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1200         (RunAPITestsWithoutPatch): Run API tests without patch.
1201         (RunAPITestsWithoutPatch.doStepIf):
1202         (RunAPITestsWithoutPatch.hideStepIf):
1203         (RunAPITestsWithoutPatch.evaluateCommand):
1204         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1205         (AnalyzeAPITestsResults.start):
1206         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1207         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1208         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1209         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1210
1211 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1212
1213         [ews-build] Update queues configurations
1214         https://bugs.webkit.org/show_bug.cgi?id=196074
1215
1216         Reviewed by Dewei Zhu.
1217
1218         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1219         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1220
1221 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1222
1223         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1224         https://bugs.webkit.org/show_bug.cgi?id=195680
1225         <rdar://problem/48903534>
1226
1227         Unreviewed infrastructure fix.
1228
1229         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1230         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1231
1232 2019-03-21  Andy Estes  <aestes@apple.com>
1233
1234         [iOS] Apple Pay should be available in documents with no user agent scripts
1235         https://bugs.webkit.org/show_bug.cgi?id=196061
1236         <rdar://problem/48649391>
1237
1238         Reviewed by Brady Eidson.
1239
1240         Added API tests and related infrastructure.
1241
1242         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1243         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1244         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1245         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1246         (TestWebKitAPI::TEST):
1247         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1248         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1249         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1250         * TestWebKitAPI/cocoa/TestProtocol.mm:
1251         (-[TestProtocol startLoading]):
1252         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1253         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1254         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1255         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1256
1257 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1258
1259         REGRESSSION (r243297): webkitpy tests broken
1260         https://bugs.webkit.org/show_bug.cgi?id=196108
1261
1262         Reviewed by Aakash Jain.
1263
1264         r243297 updated contributors.json, which broke a few unit tests.
1265
1266         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1267         (IRCCommandTest.test_whois):
1268         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1269
1270 2019-03-21  Chris Dumez  <cdumez@apple.com>
1271
1272         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1273         https://bugs.webkit.org/show_bug.cgi?id=196041
1274         <rdar://problem/49083230>
1275
1276         Reviewed by Alex Christensen.
1277
1278         Add API test coverage.
1279
1280         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1281         (TEST):
1282
1283 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1284
1285         Add SPI to inform applications of WKContentRuleList actions
1286         https://bugs.webkit.org/show_bug.cgi?id=195965
1287         <rdar://problem/42664365>
1288
1289         Reviewed by Geoff Garen.
1290
1291         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1292         (TestWebKitAPI::allActionsForResourceLoad):
1293         (TestWebKitAPI::testRequest):
1294         (TestWebKitAPI::TEST_F):
1295         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1296         (Notification::description):
1297         (Notification::operator== const):
1298         (toVector):
1299         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1300         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1301         (makeContentRuleList):
1302         (TEST):
1303         (makeWarnContentRuleList): Deleted.
1304
1305 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1306
1307         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1308         https://bugs.webkit.org/show_bug.cgi?id=196088
1309
1310         Reviewed by Brian Burg.
1311
1312         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1313         Support checks when only one platform is specified. Also deprecate macosx() and
1314         force the use of macos() instead.
1315
1316         * Scripts/webkitpy/style/checkers/cpp.py:
1317         (check_min_versions_of_wk_api_available):
1318         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1319         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1320
1321 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1322
1323         Update status inactive committers' status to 'contributor'.
1324
1325         * Scripts/webkitpy/common/config/contributors.json:
1326
1327 2019-03-21  Xan Lopez  <xan@igalia.com>
1328
1329         [JSC][x86] Drop support for x87 floating point
1330         https://bugs.webkit.org/show_bug.cgi?id=194853
1331
1332         Reviewed by Don Olmstead.
1333
1334         Force SSE2 on x86/32bit builds.
1335
1336         * Scripts/webkitdirs.pm:
1337         (generateBuildSystemFromCMakeProject):
1338
1339 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1340
1341         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1342         https://bugs.webkit.org/show_bug.cgi?id=196073
1343
1344         Reviewed by Michael Catanzaro.
1345
1346         Add test cases to check functions and constructors with no arguments but receiving user data.
1347
1348         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1349         (checkUserData):
1350         (testJSCFunction):
1351         (fooCreateWithUserData):
1352         (testJSCClass):
1353
1354 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1355
1356         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1357
1358         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1359
1360         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1361
1362 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1363
1364         [GTK][WPE] Add API to provide geolocation information
1365         https://bugs.webkit.org/show_bug.cgi?id=195940
1366
1367         Reviewed by Michael Catanzaro.
1368
1369         Add a new test to check the new API.
1370
1371         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1372         (testGeolocationManagerCurrentPosition):
1373         (testGeolocationManagerWatchPosition):
1374         (beforeAll):
1375         (afterAll):
1376         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1377         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1378         (beforeAll): Ditto.
1379         * TestWebKitAPI/glib/CMakeLists.txt:
1380
1381 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1382
1383         [GLib] Returning G_TYPE_OBJECT from a method does not work
1384         https://bugs.webkit.org/show_bug.cgi?id=195574
1385
1386         Reviewed by Michael Catanzaro.
1387
1388         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1389
1390         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1391         (getGFile):
1392         (getParent):
1393         (createGString):
1394         (getGString):
1395         (getGStringCopyWillRaise):
1396         (getGStringCopy):
1397         (getGStringStr):
1398         (getGStringLen):
1399         (freeGString):
1400         (testJSCClass):
1401
1402 2019-03-20  Saam Barati  <sbarati@apple.com>
1403
1404         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1405         https://bugs.webkit.org/show_bug.cgi?id=195721
1406
1407         Reviewed by Filip Pizlo.
1408
1409         * Scripts/run-javascriptcore-tests:
1410
1411 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1412
1413         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1414         https://bugs.webkit.org/show_bug.cgi?id=196049
1415
1416         Reviewed by Tim Horton.
1417
1418         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1419         overflow scrolling in general, so rename it.
1420
1421         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1422
1423 2019-03-20  Daniel Bates  <dabates@apple.com>
1424
1425         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1426         https://bugs.webkit.org/show_bug.cgi?id=196031
1427         <rdar://problem/49078172>
1428
1429         Reviewed by Tim Horton.
1430
1431         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1432         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1433         same code path used when the Done button is pressed to dismiss the <select> picker.
1434
1435         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1436         (TestWebKitAPI::TEST):
1437
1438 2019-03-20  Chris Dumez  <cdumez@apple.com>
1439
1440         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1441         https://bugs.webkit.org/show_bug.cgi?id=196029
1442         <rdar://problem/48954651>
1443
1444         Reviewed by Tim Horton.
1445
1446         Add API test coverage.
1447
1448         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1449
1450 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1451
1452         [ews-build] Improve failure summary string for ApplyPatch step
1453         https://bugs.webkit.org/show_bug.cgi?id=195995
1454
1455         Reviewed by Alexey Proskuryakov.
1456
1457         * BuildSlaveSupport/ews-build/steps.py:
1458         (ApplyPatch.getResultSummary): Override getResultSummary.
1459
1460 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1461
1462         AX: Implement support for new meter ARIA role
1463         https://bugs.webkit.org/show_bug.cgi?id=195966
1464
1465         Reviewed by Chris Fleizach.
1466
1467         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1468         to AXLevelIndicator.
1469
1470         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1471
1472 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1473
1474         [WebAuthN] Implement FIDO AppID extension
1475         https://bugs.webkit.org/show_bug.cgi?id=143491
1476         <rdar://problem/48298273>
1477
1478         Reviewed by Brent Fulgham.
1479
1480         Add a test that covers the new flag of convertToU2fSignCommand.
1481
1482         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1483         (TestWebKitAPI::TEST):
1484         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1485         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1486         (TestWebKitAPI::TEST):
1487
1488 2019-03-19  Keith Rollin  <krollin@apple.com>
1489
1490         Add support for more platforms to generate-xcfilelists
1491         https://bugs.webkit.org/show_bug.cgi?id=195977
1492
1493         Reviewed by Alexey Proskuryakov.
1494
1495         generate-xcfilelists incorrectly complains when involved with building
1496         WebKit for iphonesimulator:
1497
1498             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1499             …
1500             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1501
1502         Address this by teaching generate-xcfilelists about more platforms.
1503
1504         * Scripts/generate-xcfilelists:
1505
1506 2019-03-19  John Wilander  <wilander@apple.com>
1507
1508         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1509         https://bugs.webkit.org/show_bug.cgi?id=195923
1510         <rdar://problem/49001272>
1511
1512         Reviewed by Alex Christensen.
1513
1514         This patch does the following to the TestRunner:
1515         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1516         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1517         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1518
1519         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1520         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1521         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1522         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1523         * WebKitTestRunner/TestController.cpp:
1524         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1525         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1526         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1527         * WebKitTestRunner/TestController.h:
1528         * WebKitTestRunner/TestInvocation.cpp:
1529         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1530
1531 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1532
1533         [CMake] Support more clang and gcc sanitizers
1534         https://bugs.webkit.org/show_bug.cgi?id=195956
1535
1536         Reviewed by Michael Catanzaro.
1537
1538         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1539
1540 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1541
1542         [ews-build] Improve summary for PrintConfiguration step
1543         https://bugs.webkit.org/show_bug.cgi?id=195945
1544
1545         Reviewed by Lucas Forschler.
1546
1547         * BuildSlaveSupport/ews-build/steps.py:
1548         (PrintConfiguration.getResultSummary): Override getResultSummary.
1549
1550 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1551
1552         [ews-build] Improve summary for CheckOutSource step
1553         https://bugs.webkit.org/show_bug.cgi?id=195963
1554
1555         Reviewed by Lucas Forschler.
1556
1557         * BuildSlaveSupport/ews-build/steps.py:
1558         (CheckOutSource.getResultSummary):
1559
1560 2019-03-19  Daniel Bates  <dabates@apple.com>
1561
1562         [iOS] Focus not preserved when switching between tabs
1563         https://bugs.webkit.org/show_bug.cgi?id=195820
1564         <rdar://problem/43614450>
1565
1566         Reviewed by Brent Fulgham.
1567
1568         Add tests to ensure that we restore focus when resigning and becoming first responder.
1569
1570         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1571         (TestWebKitAPI::TEST):
1572
1573 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1574
1575         Make WTFLogChannelState and WTFLogLevel enum classes
1576         https://bugs.webkit.org/show_bug.cgi?id=195904
1577
1578         Reviewed by Eric Carlson.
1579
1580         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1581         (TestWebKitAPI::TEST_F):
1582
1583 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1584
1585         [GStreamer][EME] Backported mssdemux protection data crash fix
1586         https://bugs.webkit.org/show_bug.cgi?id=195918
1587
1588         Reviewed by Philippe Normand.
1589
1590         * gstreamer/jhbuild.modules:
1591         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1592
1593 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1594
1595         Unreviewed, rolling out r243132.
1596
1597         Broke GTK build
1598
1599         Reverted changeset:
1600
1601         "Make WTFLogChannelState and WTFLogLevel enum classes"
1602         https://bugs.webkit.org/show_bug.cgi?id=195904
1603         https://trac.webkit.org/changeset/243132
1604
1605 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1606
1607         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1608
1609         * Scripts/webkitdirs.pm:
1610         (builtDylibPathForName): Adjust the shared library name that's changed
1611         with the API version bump in r243073.
1612
1613 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1614
1615         Make WTFLogChannelState and WTFLogLevel enum classes
1616         https://bugs.webkit.org/show_bug.cgi?id=195904
1617
1618         Reviewed by Eric Carlson.
1619
1620         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1621         (TestWebKitAPI::TEST_F):
1622
1623 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1624
1625         Disable flaky test added in r2431100
1626         https://webkit.org/b/195785
1627
1628         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1629         (TestWebKitAPI::TEST):
1630         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1631
1632 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1633
1634         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1635         https://bugs.webkit.org/show_bug.cgi?id=195916
1636
1637         Reviewed by Tim Horton.
1638
1639         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1640         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1641
1642 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1643
1644         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1645
1646         * Scripts/webkitpy/common/config/contributors.json:
1647
1648 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1649
1650         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1651         https://bugs.webkit.org/show_bug.cgi?id=195785
1652
1653         Reviewed by Geoffrey Garen.
1654
1655         * TestWebKitAPI/TCPServer.cpp: Added.
1656         (TestWebKitAPI::TCPServer::TCPServer):
1657         (TestWebKitAPI::TCPServer::~TCPServer):
1658         (TestWebKitAPI::TCPServer::socketBindListen):
1659         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1660         * TestWebKitAPI/TCPServer.h: Added.
1661         (TestWebKitAPI::TCPServer::port const):
1662         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1663         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1664         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1665         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1666         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1667         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1668         (TestWebKitAPI::respondSlowly):
1669         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1670         (TestWebKitAPI::downloadAtRate):
1671         (TestWebKitAPI::TEST):
1672
1673 2019-03-18  Saam Barati  <sbarati@apple.com>
1674
1675         Add a plan file for JetStream 2
1676         https://bugs.webkit.org/show_bug.cgi?id=190734
1677
1678         Reviewed by Mark Lam.
1679
1680         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1681
1682 2019-03-18  Chris Dumez  <cdumez@apple.com>
1683
1684         Delay WebProcess launch until a load is triggered in a Web view
1685         https://bugs.webkit.org/show_bug.cgi?id=195758
1686         <rdar://problem/48126013>
1687
1688         Reviewed by Geoff Garen.
1689
1690         Add API test coverage. Also update some existing API tests to not expect
1691         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1692
1693         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1694         (TestWebKitAPI::TEST):
1695         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1696         (TestWebKitAPI::TEST):
1697         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1698         (TEST):
1699         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1700         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1701         (TEST):
1702         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1703         (TEST):
1704         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1705
1706 2019-03-18  Xan Lopez  <xan@igalia.com>
1707
1708         [CMake] Prevent potential warning when determining $architecture
1709         https://bugs.webkit.org/show_bug.cgi?id=195891
1710
1711         Reviewed by Michael Catanzaro.
1712
1713         It's possible for generateBuildSystemForCMakeProject to be called
1714         before determineArchitecture() is ever called. This will make the
1715         first eq check with $architecture to be bogus (and print a
1716         warning). Change that to an eq check with architecture(), which
1717         implicitly calls determineArchitecture() if needed, and change all
1718         the other similar cases in the method in the same way to prevent
1719         future bugs like this one.
1720
1721         * Scripts/webkitdirs.pm:
1722         (generateBuildSystemFromCMakeProject):
1723
1724 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1725
1726         [WPE] Tarballs generated with “make dist” cannot build documentation
1727         https://bugs.webkit.org/show_bug.cgi?id=195885
1728
1729         Reviewed by Carlos Garcia Campos.
1730
1731         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1732
1733 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1734
1735         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1736         https://bugs.webkit.org/show_bug.cgi?id=195883
1737
1738         Reviewed by Carlos Garcia Campos.
1739
1740         * gtkdoc/gtkdoc.py:
1741         (GTKDoc._run_command): When commands fail to run, include the full command line for
1742         the program invocation and the output it has generated on the standard error stream.
1743
1744 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1745
1746         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1747         https://bugs.webkit.org/show_bug.cgi?id=195786
1748
1749         Reviewed by Philippe Normand.
1750
1751         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1752         * wpe/jhbuild.modules: Ditto.
1753
1754 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1755
1756         [ews-build] Don't run clean builds on EWS builders
1757         https://bugs.webkit.org/show_bug.cgi?id=195851
1758
1759         Reviewed by Geoffrey Garen.
1760
1761         * BuildSlaveSupport/ews-build/factories.py:
1762
1763 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1764
1765         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1766         https://bugs.webkit.org/show_bug.cgi?id=195849
1767
1768         Reviewed by Chris Dumez.
1769
1770         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1771
1772         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1773         (runWebsiteDataStoreCustomPaths):
1774
1775 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1776
1777         webkitpy: Upload test results
1778         https://bugs.webkit.org/show_bug.cgi?id=195755
1779         <rdar://problem/48896182>
1780
1781         Reviewed by Aakash Jain.
1782
1783         Establish a new format for uploading results that is not tied to layout tests, apply
1784         that format to webkitpy tests.
1785
1786         * Scripts/webkitpy/common/checkout/scm/git.py:
1787         (Git.native_branch): Return what branch the current checkout is on.
1788         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1789         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1790         * Scripts/webkitpy/common/checkout/scm/svn.py:
1791         (SVN.native_branch): Ditto.
1792         * Scripts/webkitpy/common/system/platforminfo.py:
1793         (PlatformInfo.build_version): Return a build version for Mac.
1794         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1795         (MockPlatformInfo.__init__):
1796         (MockPlatformInfo.build_version):
1797         * Scripts/webkitpy/results: Added.
1798         * Scripts/webkitpy/results/__init__.py: Added.
1799         * Scripts/webkitpy/results/options.py: Added.
1800         (upload_options): OptParse list for upload options.
1801         * Scripts/webkitpy/results/upload.py: Added.
1802         (Upload): Class which enforces the upload format expected by the results server.
1803         (Upload.Expectations):
1804         (Upload.create_configuration):
1805         (Upload.create_commit):
1806         (Upload.create_details):
1807         (Upload.create_run_stats):
1808         (Upload.create_test_result):
1809         (Upload.__init__):
1810         (Upload.Encoder): Encode Upload object as json.
1811         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1812         * Scripts/webkitpy/results/upload_unittest.py: Added.
1813         * Scripts/webkitpy/test/main.py:
1814         (Tester._parse_args): Add upload arguments.
1815         (Tester._run_tests): Allow results to be uploaded.
1816         * Scripts/webkitpy/test/runner.py:
1817         (Runner.__init__): Record which tests were run, rather than just counting them.
1818         (Runner.handle):
1819         * Scripts/webkitpy/test/runner_unittest.py:
1820         (RunnerTest.test_run):
1821         * Scripts/webkitpy/thirdparty/__init__.py:
1822         (AutoinstallImportHook.find_module): Add requests auto-install.
1823         (AutoinstallImportHook._install_requests):
1824         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1825         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1826
1827 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1828
1829         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1830         https://bugs.webkit.org/show_bug.cgi?id=195810
1831
1832         Reviewed by Tim Horton.
1833
1834         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1835         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1836         ending certain layout tests.
1837
1838         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1839         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1840         (-[TestRunnerWKWebView dealloc]):
1841         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1842
1843         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1844         helper method when destroying the web view, and when resetting state between tests.
1845
1846         * WebKitTestRunner/ios/TestControllerIOS.mm:
1847         (WTR::TestController::platformResetStateToConsistentValues):
1848
1849         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1850
1851 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1852
1853         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1854         https://bugs.webkit.org/show_bug.cgi?id=190350
1855         <rdar://problem/45089503>
1856
1857         Reviewed by Geoffrey Garen.
1858
1859         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1860         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1861         (TEST):
1862         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1863         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1864         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1865         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1866         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1867         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1868         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1869         (runTest):
1870         (createDirectories):
1871         (TEST):
1872         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1873         (TEST):
1874         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1875         (TEST):
1876
1877 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1878
1879         Add support to WebPage for getting the contents as an attributed string.
1880         https://bugs.webkit.org/show_bug.cgi?id=195636
1881         rdar://problem/45055697
1882
1883         Reviewed by Tim Horton.
1884
1885         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1886         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1887
1888 2019-03-15  Chris Dumez  <cdumez@apple.com>
1889
1890         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1891         https://bugs.webkit.org/show_bug.cgi?id=195747
1892
1893         Reviewed by Geoff Garen.
1894
1895         Add API test coverage.
1896
1897         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1898
1899 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1900
1901         Unreviewed, rolling out r242952.
1902
1903         Causing API failures on iOS Simulator
1904
1905         Reverted changeset:
1906
1907         "[PSON] Make sure the WebProcessCache is leverage when
1908         relaunching a process after termination"
1909         https://bugs.webkit.org/show_bug.cgi?id=195747
1910         https://trac.webkit.org/changeset/242952
1911
1912 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1913
1914         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1915         https://bugs.webkit.org/show_bug.cgi?id=195740
1916
1917         Reviewed by Ross Kirsling.
1918
1919         window.open doesn't work for WebKitBrowserWindow because it is not
1920         implemented yet.
1921
1922         1. Implemented createNewPage callback of WKPageUIClient.
1923         2. Changed MainWindow to take a BrowserWindow factory function
1924           instead of BrowserWindowType to be flexible to create
1925           BrowserWindow with extra settings.
1926         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1927           because it is not relevant with MainWindow anymore.
1928
1929         * MiniBrowser/win/Common.cpp:
1930         (parseCommandLine):
1931         * MiniBrowser/win/Common.h:
1932         (CommandLineOptions::CommandLineOptions):
1933         * MiniBrowser/win/MainWindow.cpp:
1934         (MainWindow::MainWindow):
1935         (MainWindow::create):
1936         (MainWindow::init):
1937         (MainWindow::WndProc):
1938         * MiniBrowser/win/MainWindow.h:
1939         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1940         (PrintWebUIDelegate::createWebViewWithRequest):
1941         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1942         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1943         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1944         (WebKitBrowserWindow::updateProxySettings):
1945         (WebKitBrowserWindow::createNewPage):
1946         * MiniBrowser/win/WebKitBrowserWindow.h:
1947         * MiniBrowser/win/WinMain.cpp:
1948         (wWinMain):
1949
1950 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1951
1952         Make it possible to test scrolling tree layer manipulation more easily
1953         https://bugs.webkit.org/show_bug.cgi?id=195780
1954
1955         Reviewed by Tim Horton.
1956         
1957         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1958         cuts off communication of scrolling tree scrolls back to the web process
1959         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1960         allows tests to trigger scrolls which run the scrolling tree layer positioning
1961         logic, but never get another commit from the web process that might mask
1962         scrolling tree bugs.
1963         
1964         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1965         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1966         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1967
1968         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1969         (WTR::UIScriptController::scrollUpdatesDisabled const):
1970         (WTR::UIScriptController::setScrollUpdatesDisabled):
1971         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1972         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1973         (WTR::UIScriptController::scrollUpdatesDisabled const):
1974         (WTR::UIScriptController::setScrollUpdatesDisabled):
1975         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1976         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1977         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1978         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1979         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1980         * WebKitTestRunner/ios/TestControllerIOS.mm:
1981         (WTR::TestController::platformResetStateToConsistentValues):
1982         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1983         (WTR::UIScriptController::scrollUpdatesDisabled const):
1984         (WTR::UIScriptController::setScrollUpdatesDisabled):
1985
1986 2019-03-14  Youenn Fablet  <youenn@apple.com>
1987
1988         Move IDB storage in private browsing mode to NetworkProcess
1989         https://bugs.webkit.org/show_bug.cgi?id=195602
1990
1991         Reviewed by Brady Eidson.
1992
1993         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1994         (TEST):
1995
1996 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1997
1998         [ews-build] Make descriptionDone messages more readable
1999         https://bugs.webkit.org/show_bug.cgi?id=195760
2000
2001         Reviewed by Lucas Forschler.
2002
2003         * BuildSlaveSupport/ews-build/steps.py:
2004         * BuildSlaveSupport/ews-build/steps_unittest.py:
2005
2006 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2007
2008         [ews-build] Generate status-bubble hover-over messages
2009         https://bugs.webkit.org/show_bug.cgi?id=195680
2010
2011         Reviewed by Lucas Forschler.
2012
2013         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2014         (StatusBubble):
2015         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2016         on hover-over.
2017         (StatusBubble._iso_time):
2018         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2019         hover-over message.
2020         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2021
2022 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2023
2024         [ews-app] Gracefully handle the case when state_string is None
2025         https://bugs.webkit.org/show_bug.cgi?id=195753
2026
2027         Reviewed by Lucas Forschler.
2028
2029         * BuildSlaveSupport/ews-app/ews/models/build.py:
2030         * BuildSlaveSupport/ews-app/ews/models/step.py:
2031
2032 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2033
2034         [ews-app] Status bubble display pending for currently running build step
2035         https://bugs.webkit.org/show_bug.cgi?id=195744
2036
2037         Reviewed by Lucas Forschler.
2038
2039         * BuildSlaveSupport/ews-build/events.py:
2040         (Events.stepStarted): If state_string is pending, replace it with step name.
2041
2042 2019-03-14  Chris Dumez  <cdumez@apple.com>
2043
2044         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2045         https://bugs.webkit.org/show_bug.cgi?id=195750
2046
2047         Reviewed by Geoffrey Garen.
2048
2049         Add API test coverage.
2050
2051         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2052         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2053         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2054         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2055
2056 2019-03-14  Chris Dumez  <cdumez@apple.com>
2057
2058         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2059         https://bugs.webkit.org/show_bug.cgi?id=195747
2060
2061         Reviewed by Geoff Garen.
2062
2063         Add API test coverage.
2064
2065         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2066
2067 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2068
2069         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2070         https://bugs.webkit.org/show_bug.cgi?id=195725
2071         <rdar://problem/48545062>
2072
2073         Reviewed by Tim Horton.
2074
2075         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2076         handler is nil.
2077
2078         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2079         (TestWebKitAPI::TEST):
2080
2081 2019-03-13  Sam Weinig  <sam@webkit.org>
2082
2083         Add utility function to allow easy reverse range-based iteration of a container
2084         https://bugs.webkit.org/show_bug.cgi?id=195542
2085
2086         Reviewed by Antti Koivisto.
2087
2088         * TestWebKitAPI/CMakeLists.txt:
2089         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2090         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2091         (TestWebKitAPI::TEST):
2092         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2093
2094 2019-03-13  Chris Dumez  <cdumez@apple.com>
2095
2096         Use a ServiceWorker process per registrable domain
2097         https://bugs.webkit.org/show_bug.cgi?id=195649
2098
2099         Reviewed by Youenn Fablet.
2100
2101         Update API test coverage.
2102
2103         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2104
2105 2019-03-13  Chris Dumez  <cdumez@apple.com>
2106
2107         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2108         https://bugs.webkit.org/show_bug.cgi?id=195684
2109         <rdar://problem/48294714>
2110
2111         Reviewed by Antti Koivisto.
2112
2113         Add API test coverage.
2114
2115         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2116
2117 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2118
2119         [ews-app] Remove unused patch view
2120         https://bugs.webkit.org/show_bug.cgi?id=195669
2121
2122         Reviewed by Lucas Forschler.
2123
2124         * BuildSlaveSupport/ews-app/ews/urls.py:
2125         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2126
2127 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2128
2129         [ews-app] Use Buildbot result code variables
2130         https://bugs.webkit.org/show_bug.cgi?id=195668
2131
2132         Reviewed by Alexey Proskuryakov.
2133
2134         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2135         (Buildbot): Added Buildbot result code variables.
2136         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2137         (StatusBubble._build_bubble): Used Buildbot result code variables.
2138
2139 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2140
2141         [Flatpak] Expand submodule recursively
2142         https://bugs.webkit.org/show_bug.cgi?id=195672
2143
2144         Building WPE with flatpak was impossible without that as it was raising an exception.
2145         Also update wpebackend-fdo to match what is built in jhbuild
2146
2147         Reviewed by Philippe Normand.
2148
2149         * flatpak/flatpakutils.py:
2150         (expand_submodules_recurse):
2151         (expand_manifest):
2152         * flatpak/org.webkit.WPEModules.yaml:
2153
2154 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2155
2156         [ews-app] status bubble should be hidden for certain builds
2157         https://bugs.webkit.org/show_bug.cgi?id=194597
2158
2159         Reviewed by Dewei Zhu.
2160
2161         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2162         (StatusBubble._build_bubble):
2163         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2164         because the patch didn't have relevant changes.
2165         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2166         in production yet.
2167
2168 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2169
2170         [Win] Fix a slew of simple clang-cl warnings.
2171         https://bugs.webkit.org/show_bug.cgi?id=195652
2172
2173         Reviewed by Don Olmstead.
2174
2175         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2176         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2177
2178 2019-03-12  Justin Fan  <justin_fan@apple.com>
2179
2180         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2181         https://bugs.webkit.org/show_bug.cgi?id=195518
2182         <rdar://problem/46322356>
2183
2184         Reviewed by Myles C. Maxfield.
2185
2186         * DumpRenderTree/DerivedSources-input.xcfilelist:
2187         * DumpRenderTree/DerivedSources-output.xcfilelist:
2188
2189 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2190
2191         Unreviewed, rolling out r242825.
2192         https://bugs.webkit.org/show_bug.cgi?id=195648
2193
2194         "Broke webkitpy tests with my change to
2195         lldb_dump_class_layout.py" (Requested by rmorisset on
2196         #webkit).
2197
2198         Reverted changeset:
2199
2200         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2201         classes with suspicious padding"
2202         https://bugs.webkit.org/show_bug.cgi?id=195573
2203         https://trac.webkit.org/changeset/242825
2204
2205 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2206
2207         [ews-build] Show status bubbles while the patch is waiting in queue
2208         https://bugs.webkit.org/show_bug.cgi?id=195618
2209
2210         Reviewed by Lucas Forschler.
2211
2212         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2213         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2214         enabled in initial deployment.
2215         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2216         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2217         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2218         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2219         (StatusBubble._build_bubbles_for_patch):
2220
2221 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2222
2223         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2224         https://bugs.webkit.org/show_bug.cgi?id=195573
2225
2226         Reviewed by Simon Fraser.
2227
2228         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2229
2230         * Scripts/dump-class-layout:
2231         (main):
2232         * lldb/lldb_dump_class_layout.py:
2233         (ClassLayout.__init__):
2234         (ClassLayout._compute_padding_recursive):
2235         (LLDBDebuggerInstance.dump_layout_for_classname):
2236         (LLDBDebuggerInstance):
2237         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2238         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2239
2240 2019-03-12  Chris Dumez  <cdumez@apple.com>
2241
2242         Device Orientation access permission should be denied unless explicitly granted by the client
2243         https://bugs.webkit.org/show_bug.cgi?id=195625
2244
2245         Reviewed by Youenn Fablet.
2246
2247         add API test coverage.
2248
2249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2250         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2251         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2252         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2253         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2254         (runDeviceOrientationTest):
2255         (TEST):
2256         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2257         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2258
2259 2019-03-12  Jer Noble  <jer.noble@apple.com>
2260
2261         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2262         https://bugs.webkit.org/show_bug.cgi?id=195137
2263         <rdar://problem/48810307>
2264
2265         Reviewed by Eric Carlson.
2266
2267         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2268         (TestWebKitAPI::TEST):
2269
2270 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2271
2272         [ews-build] Change urls from uat to production
2273         https://bugs.webkit.org/show_bug.cgi?id=195566
2274
2275         Reviewed by Lucas Forschler.
2276
2277         * BuildSlaveSupport/ews-app/ews/config.py:
2278         * BuildSlaveSupport/ews-build/events.py:
2279         * BuildSlaveSupport/ews-build/steps.py:
2280
2281 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2282
2283         [ews-build] change max_builds for local-worker to 1
2284         https://bugs.webkit.org/show_bug.cgi?id=195568
2285
2286         Reviewed by Lucas Forschler.
2287
2288         * BuildSlaveSupport/ews-build/loadConfig.py:
2289
2290 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2291
2292         Fix the build
2293
2294         * TestRunnerShared/spi/PencilKitTestSPI.h:
2295         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2296
2297 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2298
2299         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2300         https://bugs.webkit.org/show_bug.cgi?id=194131
2301
2302         Reviewed by Michael Catanzaro.
2303
2304         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2305         (uriChanged):
2306         (testUnfinishedSubresourceLoad):
2307         (serverCallback):
2308         (beforeAll):
2309
2310 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2311
2312         WTF::Expected should use std::addressof instead of operator&
2313         https://bugs.webkit.org/show_bug.cgi?id=195604
2314
2315         Reviewed by Myles Maxfield.
2316
2317         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2318         (TestWebKitAPI::Unique::Unique):
2319         (TestWebKitAPI::Unique::operator&):
2320         (TestWebKitAPI::TEST):
2321
2322 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2323
2324         Add Optional to Forward.h.
2325         https://bugs.webkit.org/show_bug.cgi?id=195586
2326
2327         Reviewed by Darin Adler.
2328
2329         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2330         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2331         Remove unnecessary includes from headers.
2332
2333 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2334
2335         Add testing API to hit-test and scroll overflow scrollers
2336         https://bugs.webkit.org/show_bug.cgi?id=195278
2337
2338         Reviewed by Antti Koivisto.
2339         
2340         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2341         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2342         
2343         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2344
2345         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2346         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2347         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2348         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2349         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2350         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2351         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2352         (WTR::enclosingScrollViewIncludingSelf):
2353         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2354
2355 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2356
2357         API test WebKit.RequestTextInputContext fails on iOS
2358         https://bugs.webkit.org/show_bug.cgi?id=195585
2359
2360         Reviewed by Wenson Hsieh and Simon Fraser.
2361
2362         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2363         (applyStyle):
2364         (TEST):
2365         Add a viewport, so that the coordinates match up on iOS.
2366         Scroll by moving the UIScrollView's contentOffset.
2367
2368 2019-03-11  Chris Dumez  <cdumez@apple.com>
2369
2370         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2371         https://bugs.webkit.org/show_bug.cgi?id=195506
2372         <rdar://problem/48733477>
2373
2374         Reviewed by Alex Christensen.
2375
2376         Add API test coverage.
2377
2378         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2379
2380 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2381
2382         Adding myself to contributors.json
2383
2384         Unreviewed, addming myself to contributors.json .
2385
2386         * Scripts/webkitpy/common/config/contributors.json:
2387
2388 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2389
2390         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2391         https://bugs.webkit.org/show_bug.cgi?id=195511
2392         <rdar://problem/44873269>
2393
2394         Reviewed by Darin Adler.
2395
2396         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2397         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2398         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2399         (TEST_F):
2400
2401 2019-03-11  Chris Dumez  <cdumez@apple.com>
2402
2403         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2404         https://bugs.webkit.org/show_bug.cgi?id=195561
2405
2406         Reviewed by Youenn Fablet.
2407
2408         Make sure the JS in the test requests for permission to receive device orientation events.
2409
2410         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2411
2412 2019-03-11  Youenn Fablet  <youenn@apple.com>
2413
2414         Allow storage quota increase by default in WTR
2415         https://bugs.webkit.org/show_bug.cgi?id=195541
2416
2417         Reviewed by Geoffrey Garen.
2418
2419         Allow storage quota increase by default in WTR.
2420         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2421         Use this for tests that explicitly need cache increase.
2422
2423         Instead of increasing quota by 2, make sure the next request is
2424         granted by adding all given parameters.
2425
2426         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2427         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2428         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2429         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2430         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2431         * WebKitTestRunner/TestController.cpp:
2432         (WTR::TestController::setAllowStorageQuotaIncrease):
2433         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2434         * WebKitTestRunner/TestController.h:
2435         * WebKitTestRunner/TestInvocation.cpp:
2436         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2437         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2438         (WTR::TestController::cocoaResetStateToConsistentValues):
2439         (WTR::TestController::setAllowStorageQuotaIncrease):
2440         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2441         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2442         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2443
2444 2019-03-11  Xan Lopez  <xan@igalia.com>
2445
2446         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2447         https://bugs.webkit.org/show_bug.cgi?id=194147
2448
2449         Reviewed by Michael Saboff.
2450
2451         To make --32-bit work correctly on Linux/64bit we need to:
2452
2453         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2454         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2455         unfortunately CMake only allows us to do this during
2456         crosscompilation, which is overkill here.
2457         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2458         pkg-config detection module uses the x86 .pc files instead of the
2459         x86_64 ones.
2460         - Set the -m32 flags for the compiler.
2461
2462         * Scripts/webkitdirs.pm:
2463         (generateBuildSystemFromCMakeProject):
2464
2465 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2466
2467         Add MotionMark-1.1 plan file for run-benchmark script.
2468         https://bugs.webkit.org/show_bug.cgi?id=195481
2469
2470         Rubber-stamped by Darin Adler.
2471
2472         Run-benchmark script should support MontionMark-1.1.
2473
2474         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2475
2476 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2477
2478         [ews-app] Add support for submit-to-ews url
2479         https://bugs.webkit.org/show_bug.cgi?id=195477
2480
2481         Reviewed by Lucas Forschler.
2482
2483         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2484         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2485         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2486         * BuildSlaveSupport/ews-app/ews/urls.py:
2487         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2488
2489 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2490
2491         Unreviewed, rolling out r242688, r242643, r242624.
2492
2493         Caused multiple layout test failures and crashes on iOS and macOS.
2494
2495         Reverted changeset:
2496
2497         "requestAnimationFrame should execute before the next frame"
2498         https://bugs.webkit.org/show_bug.cgi?id=177484
2499         https://trac.webkit.org/changeset/242624/webkit
2500
2501         * Tracing/SystemTracePoints.plist:
2502
2503 2019-03-11  John Wilander  <wilander@apple.com>
2504
2505         Resource Load Statistics: Make it possible exclude localhost from classification
2506         https://bugs.webkit.org/show_bug.cgi?id=195474
2507         <rdar://problem/47520577>
2508
2509         Reviewed by Brent Fulgham.
2510
2511         This patch allows for localhost to be excluded from classification and
2512         treatment as a prevalent resource.
2513
2514         The WebKit Tools change adds a new function called
2515         testRunner.setStatisticsIsRunningTest() which can be used to control this
2516         behavior.
2517
2518         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2519         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2520         (WTR::TestRunner::setStatisticsIsRunningTest):
2521         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2522         * WebKitTestRunner/TestController.cpp:
2523         (WTR::TestController::setStatisticsIsRunningTest):
2524         * WebKitTestRunner/TestController.h:
2525         * WebKitTestRunner/TestInvocation.cpp:
2526         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2527
2528 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2529
2530         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2531         https://bugs.webkit.org/show_bug.cgi?id=195560
2532
2533         Reviewed by Lucas Forschler.
2534
2535         * BuildSlaveSupport/ews-build/master.cfg:
2536
2537 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2538
2539         Unreviewed, rolling out r242698.
2540
2541         API test crashes on bots.
2542
2543         Reverted changeset:
2544
2545         "Add a WKContentRuleList variant that uses copied memory
2546         instead of mmap'd shared memory for class A containerized
2547         apps"
2548         https://bugs.webkit.org/show_bug.cgi?id=195511
2549         https://trac.webkit.org/changeset/242698
2550
2551 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2552
2553         [WPE] Enable web process sandbox
2554         https://bugs.webkit.org/show_bug.cgi?id=195169
2555
2556         Reviewed by Daniel Bates.
2557
2558         * wpe/install-dependencies:
2559         * wpe/jhbuild.modules:
2560
2561 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2562
2563         [ews-app] Use port 17000 for worker communication
2564         https://bugs.webkit.org/show_bug.cgi?id=195558
2565
2566         Reviewed by Lucas Forschler.
2567
2568         * BuildSlaveSupport/ews-build/master.cfg:
2569
2570 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2571
2572         [ews-build] unit-tests fail when passwords.json is missing
2573         https://bugs.webkit.org/show_bug.cgi?id=195557
2574
2575         Reviewed by Lucas Forschler.
2576
2577         * BuildSlaveSupport/ews-build/loadConfig.py:
2578         (loadBuilderConfig):
2579         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2580         (ConfigDotJSONTest.test_configuration):
2581         * BuildSlaveSupport/ews-build/master.cfg:
2582
2583 2019-03-11  Truitt Savell  <tsavell@apple.com>
2584
2585         Unreviewed, rolling out r242702.
2586
2587         Broke High Sierra builders.
2588
2589         Reverted changeset:
2590
2591         "Add utility function to allow easy reverse range-based
2592         iteration of a container"
2593         https://bugs.webkit.org/show_bug.cgi?id=195542
2594         https://trac.webkit.org/changeset/242702
2595
2596 2019-03-11  Sam Weinig  <sam@webkit.org>
2597
2598         Add utility function to allow easy reverse range-based iteration of a container
2599         https://bugs.webkit.org/show_bug.cgi?id=195542
2600
2601         Reviewed by Antti Koivisto.
2602
2603         * TestWebKitAPI/CMakeLists.txt:
2604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2605         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2606         (TestWebKitAPI::TEST):
2607         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2608
2609 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2610
2611         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2612         https://bugs.webkit.org/show_bug.cgi?id=195511
2613         <rdar://problem/44873269>
2614
2615         Reviewed by Darin Adler.
2616
2617         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2618         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2619         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2620         (TEST_F):
2621
2622 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2623
2624         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2625         https://bugs.webkit.org/show_bug.cgi?id=195499
2626
2627         Reviewed by Darin Adler.
2628
2629         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2630         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2631         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2632         (-[WKWebView synchronouslyFocusTextInputContext:]):
2633         (applyStyle):
2634         (applyIframe):
2635         (TEST):
2636         Add some tests for this SPI.
2637
2638 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2639
2640         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2641         https://bugs.webkit.org/show_bug.cgi?id=181151
2642
2643         Reviewed by Don Olmstead.
2644
2645         * TestWebKitAPI/CMakeLists.txt:
2646         * TestWebKitAPI/PlatformWin.cmake:
2647         Enable TestWTF RunLoop tests in all platforms.
2648
2649         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2650         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2651         (TestWebKitAPI::DerivedOneShotTimer::fired):
2652         (TestWebKitAPI::TEST):
2653         Only a few platforms support nested RunLoop.
2654
2655         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2656         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2657
2658 2019-03-10  David Quesada  <david_quesada@apple.com>
2659
2660         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2661         https://bugs.webkit.org/show_bug.cgi?id=152480
2662
2663         Reviewed by Chris Dumez.
2664
2665         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2666         there are no additional references to the process pool besides the one held by
2667         the download, waits for the download to finish (in the sense that the
2668         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2669         measure, also check that the process pool has been deallocated at the end of the
2670         test. The test wouldn't be meaningful if the process pool were still alive.
2671
2672         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2673         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2674         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2675             The download will be canceled because the delegate does not implement the
2676             method to decide the download's destination, so this is where we know the
2677             DownloadProxyMap is done with the DownloadProxy.
2678         (TEST):
2679
2680 2019-03-08  Chris Dumez  <cdumez@apple.com>
2681
2682         Add support for Device Orientation / Motion permission API
2683         https://bugs.webkit.org/show_bug.cgi?id=195329
2684         <rdar://problem/47645367>
2685
2686         Reviewed by Geoffrey Garen.
2687
2688         Add test infrastructure to help test the Device Orientation / Motion permission API.
2689
2690         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2691         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2692         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2693         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2694         * WebKitTestRunner/TestController.cpp:
2695         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2696         (WTR::TestController::createWebViewWithOptions):
2697         (WTR::TestController::resetStateToConsistentValues):
2698         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2699         * WebKitTestRunner/TestController.h:
2700         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2701         * WebKitTestRunner/TestInvocation.cpp:
2702         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2703
2704 2019-03-08  Saam barati  <sbarati@apple.com>
2705
2706         Add a compare-results script to compare benchmark results
2707         https://bugs.webkit.org/show_bug.cgi?id=195486
2708         <rdar://problem/48723397>
2709
2710         Reviewed by Geoffrey Garen.
2711
2712         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2713         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2714         to extend it to learn about our other benchmarks.
2715
2716         * Scripts/compare-results: Added.
2717         (readJSONFile):
2718         (detectJetStream2):
2719         (JetStream2Results):
2720         (detectSpeedometer2):
2721         (Speedometer2Results):
2722         (detectPLT5):
2723         (PLT5Results):
2724         (detectBenchmark):
2725         (biggerIsBetter):
2726         (ttest):
2727         (getOptions):
2728         (main):
2729
2730 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2731
2732         Ensure old tab state is cleared between iterations of run-benchmark
2733         https://bugs.webkit.org/show_bug.cgi?id=195393
2734         <rdar://problem/46885583>
2735
2736         Reviewed by Dewei Zhu.
2737
2738         a) ensure the default to restore state is not set
2739         b) terminate Safari correctly
2740         c) Set the system default to ignore Persistent State in Safari
2741
2742         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2743         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2744         (OSXBrowserDriver.prepare_env): 
2745         (OSXBrowserDriver.restore_env):
2746         (OSXBrowserDriver.close_browsers):
2747         (OSXBrowserDriver._terminate_processes):
2748         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2749         (OSXChromeDriver):
2750         (OSXChromeCanaryDriver):
2751         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2752         (OSXFirefoxDriver):
2753         (OSXFirefoxNightlyDriver):
2754         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2755         (OSXSafariDriver):
2756         (OSXSafariDriver.prepare_env):
2757
2758 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2759
2760         [GTK] Several InputMethodFilter tests are failing
2761         https://bugs.webkit.org/show_bug.cgi?id=195408
2762
2763         Reviewed by Carlos Garcia Campos.
2764
2765         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2766         Regressed in r241751.
2767         Hexadecimal values of keycodes are expressed now in upper letters.
2768         Composited characters should be cast to UTF8 strings.
2769
2770         (TestWebKitAPI::TEST):
2771
2772 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2773
2774         [GTK] Make Tools/gtkdoc python3 compatible
2775         https://bugs.webkit.org/show_bug.cgi?id=195359
2776
2777         Reviewed by Carlos Garcia Campos.
2778
2779         * gtkdoc/generate-gtkdoc:
2780         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2781         work with Python 2 and 3.
2782         (get_gtkdoc_module_paths):
2783         The iteritems() was removed in Python 3, so let's use items() that's
2784         available in Python 2 and 3.
2785         (get_generator_for_config):
2786         * gtkdoc/gtkdoc.py:
2787         (GTKDoc._run_command):
2788         The sys.stdout.write() is expecting str in Python 3 and not bytes
2789         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2790         for passing the bytes there.
2791
2792 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2793
2794         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2795         https://bugs.webkit.org/show_bug.cgi?id=195346
2796         <rdar://problem/48667048>
2797
2798         Unreviewed build fix for clang-cl.
2799
2800         * DumpRenderTree/win/DumpRenderTree.cpp:
2801         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2802
2803 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2804
2805         requestAnimationFrame should execute before the next frame
2806         https://bugs.webkit.org/show_bug.cgi?id=177484
2807
2808         Reviewed by Simon Fraser.
2809
2810         Add trace points for the page RenderingUpdate.
2811
2812         * Tracing/SystemTracePoints.plist:
2813
2814 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2815
2816         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2817         https://bugs.webkit.org/show_bug.cgi?id=195353
2818         <rdar://problem/48626394>
2819
2820         Reviewed by Simon Fraser.
2821
2822         * WebKitTestRunner/ios/TestControllerIOS.mm:
2823         (WTR::TestController::platformResetPreferencesToConsistentValues):
2824
2825 2019-03-07  John Wilander  <wilander@apple.com>
2826
2827         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2828         https://bugs.webkit.org/show_bug.cgi?id=195383
2829         <rdar://problem/48570136>
2830
2831         Reviewed by Brent Fulgham.
2832
2833         This patch adds test infrastructure to purge only script-accessible cookies,
2834         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2835
2836         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2837         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2838         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2839         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2840         * WebKitTestRunner/TestController.cpp:
2841         (WTR::TestController::statisticsDeleteCookiesForHost):
2842         * WebKitTestRunner/TestController.h:
2843         * WebKitTestRunner/TestInvocation.cpp:
2844         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2845
2846 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2847
2848         Unreviewed, rolling out r242354.
2849         https://bugs.webkit.org/show_bug.cgi?id=195402
2850
2851         breaks layout tests in all configurations (Requested by
2852         zdobersek on #webkit).
2853
2854         Reverted changeset:
2855
2856         "[WPE] Enable web process sandbox"
2857         https://bugs.webkit.org/show_bug.cgi?id=195169
2858         https://trac.webkit.org/changeset/242354
2859
2860 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2861
2862         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2863         https://bugs.webkit.org/show_bug.cgi?id=195346
2864
2865         Reviewed by Fujii Hironori.
2866
2867         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2868         (TestWebKitAPI::TEST):
2869         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2870
2871         * DumpRenderTree/win/DumpRenderTree.cpp:
2872         (findFontFallback):
2873         (addFontFallbackIfPresent):
2874         (removeFontFallbackIfPresent):
2875         (main):
2876         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2877         (TestWebKitAPI::Util::moduleDirectory):
2878         (TestWebKitAPI::Util::createInjectedBundlePath):
2879         Use wchar helpers as needed.
2880
2881 2019-03-06  Rob Buis  <rbuis@igalia.com>
2882
2883         Consider supporting the `referrerpolicy` attribute.
2884         https://bugs.webkit.org/show_bug.cgi?id=179053
2885
2886         Reviewed by Darin Adler.
2887
2888         Add a runtime flag for referrerpolicy attribute.
2889
2890         * DumpRenderTree/mac/DumpRenderTree.mm:
2891         (enableExperimentalFeatures):
2892
2893 2019-03-05  Daniel Bates  <dabates@apple.com>
2894
2895         Update expected API test result following r242379
2896         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2897
2898         Update expected x-coordinate of selection rect now that the left padding of
2899         a textarea is sized in ems (so dependent on the font size) just like the left
2900         padding of a text field.
2901
2902         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2903         (TestWebKitAPI::TEST):
2904
2905 2019-03-05  David Quesada  <david_quesada@apple.com>
2906
2907         [WK2] It should be possible to follow links with 'download' attributes
2908         https://bugs.webkit.org/show_bug.cgi?id=195145
2909         rdar://problem/48462642
2910
2911         Reviewed by Alex Christensen.
2912
2913         Add a unit test to verify that activating links with 'download' attributes now
2914         navigates to the linked resource, rather than starts downloading it. Add another
2915         to verify that it is still possible to explicitly download the link via the
2916         'Download' navigation action policy.
2917
2918         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2919         (-[DownloadAttributeTestDelegate init]):
2920         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2921         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2922         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2923         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2924         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2925         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2926         (TEST):
2927         * WebKitTestRunner/TestController.cpp:
2928         (WTR::TestController::decidePolicyForNavigationAction):
2929         * WebKitTestRunner/TestController.h:
2930
2931 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2932
2933         [Curl] Implement Cookie Accept Policy.
2934         https://bugs.webkit.org/show_bug.cgi?id=191645
2935
2936         Reviewed by Fujii Hironori.
2937
2938         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2939         (TestWebKitAPI::Curl::TEST_F):
2940
2941 2019-03-05  Youenn Fablet  <youenn@apple.com>
2942
2943         Rename requestCacheStorageSpace to requestStorageSpace
2944         https://bugs.webkit.org/show_bug.cgi?id=195282
2945
2946         Reviewed by Chris Dumez.
2947
2948         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2949         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2950         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2951
2952 2019-03-05  Brady Eidson  <beidson@apple.com>
2953
2954         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2955         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2956
2957         Reviewed by Tim Horton.
2958
2959         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2960         different directory into that same WKWebView should work.
2961
2962         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2963         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2964
2965 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2966
2967         Add WeakHashSet
2968         https://bugs.webkit.org/show_bug.cgi?id=195152
2969
2970         Reviewed by Antti Koivisto.
2971
2972         Added tests for WeakHashSet.
2973
2974         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2975         (TestWebKitAPI::Base::Base): Moved.
2976         (TestWebKitAPI::Derived::foo): Moved.
2977         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2978         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2979         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2980         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2981
2982 2019-03-04  Chris Dumez  <cdumez@apple.com>
2983
2984         Do not share WebProcesses between private and regular sessions
2985         https://bugs.webkit.org/show_bug.cgi?id=195189
2986         <rdar://problem/48421064>
2987
2988         Reviewed by Alex Christensen.
2989
2990         Add API test coverage.
2991
2992         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2993         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2994
2995 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2996
2997         [WPE] Enable web process sandbox
2998         https://bugs.webkit.org/show_bug.cgi?id=195169
2999
3000         Reviewed by Daniel Bates.
3001
3002         * wpe/install-dependencies:
3003         * wpe/jhbuild.modules:
3004
3005 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3006
3007         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3008         https://bugs.webkit.org/show_bug.cgi?id=195206
3009
3010         Reviewed by Žan Doberšek.
3011
3012         Add a new test case.
3013
3014         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3015         (testJSCClass):
3016
3017 2019-03-04  Charlie Turner  <cturner@igalia.com>
3018
3019         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3020         https://bugs.webkit.org/show_bug.cgi?id=194898
3021
3022         Reviewed by Žan Doberšek.
3023
3024         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3025         a GCC extension that permits arithmetic on void* pointer. Inline
3026         the macro until this issue is fixed upstream.
3027
3028 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3029
3030         Rid the world of WK_API_ENABLED
3031         https://bugs.webkit.org/show_bug.cgi?id=195263
3032
3033         Reviewed by Dan Bernstein.
3034
3035         List of changed files elided because it's useless.
3036
3037 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3038
3039         Unreviewed follow-up to r242292.
3040
3041         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3042
3043         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3044         (TestWebKitAPI::testStrip): Renamed from strip.
3045         (TestWebKitAPI::TEST):
3046
3047 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3048
3049         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3050
3051         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3052         and bug #194272 for details.
3053
3054         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3055
3056 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3057
3058         Remove some more unused 32-bit code
3059         https://bugs.webkit.org/show_bug.cgi?id=195255
3060
3061         Reviewed by Darin Adler.
3062
3063         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3064         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3065         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3066         (NPP_New):
3067         (NPP_HandleEvent):
3068         (handleEventCarbon): Deleted.
3069
3070 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3071
3072         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3073
3074         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3075         (TestWebKitAPI::TEST):
3076
3077 2019-03-01  Darin Adler  <darin@apple.com>
3078
3079         Finish removing String::format
3080         https://bugs.webkit.org/show_bug.cgi?id=194893
3081
3082         Reviewed by Daniel Bates.
3083 '
3084         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3085
3086 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3087
3088         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3089         https://bugs.webkit.org/show_bug.cgi?id=195229
3090         <rdar://problem/48520362>
3091
3092         Reviewed by Chris Dumez.
3093
3094         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3095         (TEST):
3096
3097 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3098
3099         Add a system trace scope for event region building
3100         https://bugs.webkit.org/show_bug.cgi?id=195226
3101
3102         Reviewed by Jon Lee.
3103
3104         This trace scope measures the time spend converting element rects into Region objects,
3105         which can be large on some pages.
3106
3107         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3108
3109         * Tracing/SystemTracePoints.plist:
3110
3111 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3112
3113         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3114         https://bugs.webkit.org/show_bug.cgi?id=194612
3115
3116         Reviewed by Alex Christensen.
3117
3118         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3119         Just test the new string-processing function and don't touch the actual environment.
3120         (Test cases are all as before, but based on operator== instead of strcmp.)
3121
3122 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3123
3124         [ews-app] Update primary keys for handling multiple Buildbot instances
3125         https://bugs.webkit.org/show_bug.cgi?id=195120
3126
3127         Reviewed by Stephanie Lewis.
3128
3129         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3130         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3131         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3132
3133         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3134         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3135         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3136         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3137         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3138         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3139
3140 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3141
3142         [WinCairo] Enable service worker
3143         https://bugs.webkit.org/show_bug.cgi?id=188318
3144
3145         Reviewed by Youenn Fablet.
3146
3147         * DumpRenderTree/DumpRenderTreePrefix.h:
3148         * TestWebKitAPI/PlatformWin.cmake:
3149         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3150         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3151         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3152
3153 2019-03-01  Justin Fan  <justin_fan@apple.com>
3154
3155         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3156         https://bugs.webkit.org/show_bug.cgi?id=195191
3157
3158         Rubber-stamped by Dean Jackson.
3159
3160         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3161
3162         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3163
3164 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3165
3166         Unreviewed, fix lldb webkitpy tests
3167         https://bugs.webkit.org/show_bug.cgi?id=194375
3168
3169         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3170
3171         * lldb/lldb_webkit.py:
3172         (WTFStringImplProvider.is_8bit):
3173
3174 2019-02-28  David Quesada  <david_quesada@apple.com>
3175
3176         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3177         https://bugs.webkit.org/show_bug.cgi?id=195121
3178         rdar://problem/48450302
3179
3180         Reviewed by Alex Christensen.
3181
3182         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3183         configurations where the 'download' attribute is absent, blank, or populated
3184         with a filename, and where the anchor element is same-origin or cross-origin
3185         (meaning the 'download' attribute shouldn't be honored).
3186
3187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3188         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3189         (-[NavigationActionTestDelegate init]):
3190         (-[NavigationActionTestDelegate navigationAction]):
3191         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3192         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3193         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3194         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3195         (TEST):
3196
3197 2019-02-28  Antoine Quint  <graouts@apple.com>
3198
3199         Enable the Pointer Events runtime flag by default
3200         https://bugs.webkit.org/show_bug.cgi?id=195156
3201
3202         Reviewed by Dean Jackson.
3203
3204         * DumpRenderTree/mac/DumpRenderTree.mm:
3205         (enableExperimentalFeatures):
3206
3207 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3208
3209         Several PasteImage API tests are flaky
3210         https://bugs.webkit.org/show_bug.cgi?id=195160
3211
3212         Reviewed by Tim Horton.
3213
3214         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3215         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3216         listening for a "load" event after image load is already complete.
3217
3218         To address this, make these tests first register a "load" event handler, then run script to insert an image
3219         element into the document, and finally wait until the load event is observed before checking image size.
3220
3221         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3222
3223 2019-02-28  Chris Dumez  <cdumez@apple.com>
3224
3225         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3226         https://bugs.webkit.org/show_bug.cgi?id=195107
3227
3228         Reviewed by Alex Christensen.
3229
3230         Give some time for the zoom level to get restored.
3231
3232         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3233
3234 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3235
3236         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3237         https://bugs.webkit.org/show_bug.cgi?id=194958
3238
3239         Reviewed by Geoffrey Garen.
3240
3241         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3242         (TEST):
3243
3244 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3245
3246         [ews-app] Update method to save build to handle builder_display_name
3247         https://bugs.webkit.org/show_bug.cgi?id=195047
3248
3249         Reviewed by Dewei Zhu.
3250
3251         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3252         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3253
3254 2019-02-28  Justin Fan  <justin_fan@apple.com>
3255
3256         [Web GPU] Enable Web GPU only on 64-bit
3257         https://bugs.webkit.org/show_bug.cgi?id=195139
3258
3259         Because Metal is only supported on 64 bit apps.
3260
3261         Unreviewed build fix.
3262
3263         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3264
3265 2019-02-27  Youenn Fablet  <youenn@apple.com>
3266
3267         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3268         https://bugs.webkit.org/show_bug.cgi?id=194959
3269
3270         Reviewed by Chris Dumez.
3271
3272         Spin loop until getting the condition to remove flakiness.
3273
3274         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3275
3276 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3277
3278         [ews-build] Buildbot should include builder_display_name in the build events
3279         https://bugs.webkit.org/show_bug.cgi?id=195045
3280
3281         Reviewed by Dewei Zhu.
3282
3283         * BuildSlaveSupport/ews-build/events.py:
3284         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3285         buildername to builder_name to be consistent in naming style.
3286         (Events.buildFinished): Ditto.
3287
3288 2019-02-27  Chris Dumez  <cdumez@apple.com>
3289
3290         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3291         https://bugs.webkit.org/show_bug.cgi?id=194480
3292
3293         Reviewed by Brady Eidson.
3294
3295         Update existing API test to make it more likely to reproduce the issue.
3296
3297         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3298
3299 2019-02-27  Brady Eidson  <beidson@apple.com>
3300
3301         Universal links from Google search results pages don't open the app.
3302         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3303
3304         Reviewed by Geoffrey Garen.
3305
3306         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3307         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3308         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3309         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3310
3311 2019-02-27  Chris Dumez  <cdumez@apple.com>
3312
3313         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3314         https://bugs.webkit.org/show_bug.cgi?id=195102
3315
3316         Reviewed by Geoffrey Garen.
3317
3318         If the number of processes is not yet what we expect, wait a bit and check again to give
3319         processes some time to exit.
3320
3321         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3322
3323 2019-02-27  Chris Dumez  <cdumez@apple.com>
3324
3325         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3326         https://bugs.webkit.org/show_bug.cgi?id=194545
3327
3328         Reviewed by Brady Eidson.
3329
3330         Make sure the test navigates forward and then back only once. Previously, navigating
3331         back would trigger a navigation again in a timer.
3332
3333         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3334
3335 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3336
3337         High Sierra Debug JSC test queue should use faster hardware
3338         https://bugs.webkit.org/show_bug.cgi?id=194603
3339
3340         Rubber-stamped by Alexey Proskuryakov.
3341
3342         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3343
3344         * BuildSlaveSupport/build.webkit.org-config/config.json:
3345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3346         (BubbleQueueServer):
3347         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3348         (WebKitBuildbot):
3349         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3350         * QueueStatusServer/config/queues.py:
3351         * Scripts/webkitpy/common/config/ews.json:
3352         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3353         (test_ews_name):
3354
3355 2019-02-27  John Wilander  <wilander@apple.com>
3356
3357         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3358         https://bugs.webkit.org/show_bug.cgi?id=195071
3359         <rdar://problem/48417690>
3360
3361         Reviewed by Alex Christensen and Brent Fulgham.
3362
3363         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3364         (TestWebKitAPI::createURL):
3365             Convenience function.
3366         (TestWebKitAPI::TEST):
3367             WebCore::AdClickAttribution now takes a URL when creating Source and
3368             Destination.
3369         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3370         (TestWebKitAPI::TEST):
3371             WebCore::AdClickAttribution now takes a URL when creating Source and
3372             Destination.
3373
3374 2019-02-27  Antoine Quint  <graouts@apple.com>
3375
3376         Support Pointer Events on macOS
3377         https://bugs.webkit.org/show_bug.cgi?id=195008
3378         <rdar://problem/47454419>
3379
3380         Reviewed by Dean Jackson.
3381
3382         * DumpRenderTree/mac/DumpRenderTree.mm:
3383         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3384         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3385
3386 2019-02-26  Mark Lam  <mark.lam@apple.com>
3387
3388         Remove remaining poisoning code.
3389         https://bugs.webkit.org/show_bug.cgi?id=194138
3390
3391         Reviewed by Saam Barati.
3392
3393         * TestWebKitAPI/CMakeLists.txt:
3394         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3395         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3396         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3397         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3398         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3399         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3400         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3401
3402 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3403
3404         Move ephemeral local storage from WebProcess to UIProcess
3405         https://bugs.webkit.org/show_bug.cgi?id=195074
3406         <rdar://problem/47937975>
3407
3408         Reviewed by Geoff Garen.
3409
3410         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3411
3412 2019-02-20  Jer Noble  <jer.noble@apple.com>
3413
3414         [Cocoa] Media elements will restart network buffering just before suspending
3415         https://bugs.webkit.org/show_bug.cgi?id=193691
3416
3417         Reviewed by Eric Carlson.
3418
3419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3420         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3421         (TEST):
3422
3423 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3424
3425         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3426         https://bugs.webkit.org/show_bug.cgi?id=191652
3427
3428         Reviewed by Alex Christensen.
3429
3430         Fix WinCairo MiniBrowser behavior of authentication dialog.
3431
3432         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3433         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3434
3435 2019-02-26  Youenn Fablet  <youenn@apple.com>
3436
3437         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3438         https://bugs.webkit.org/show_bug.cgi?id=195028
3439         <rdar://problem/48243733>
3440
3441         Reviewed by Eric Carlson.
3442
3443         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3444
3445 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3446
3447         [WPE] Add API for webview background color configuration
3448         https://bugs.webkit.org/show_bug.cgi?id=192305
3449
3450         Reviewed by Michael Catanzaro.
3451
3452         * MiniBrowser/wpe/main.cpp:
3453         (main): Add a new option to configure the webview background
3454         color. Example: --bg-color=transparent.
3455         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3456         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3457         (beforeAll): Ditto.
3458
3459 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3460
3461         scalableNativeWebpageParameters() is not preserved on new page navigation.
3462         https://bugs.webkit.org/show_bug.cgi?id=194892
3463         <rdar://problem/47538280>
3464
3465         Reviewed by Wenson Hsieh.
3466         
3467         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3468
3469         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3470         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3471         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3472         (WTR::UIScriptController::allowsViewportShrinkToFit):
3473         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3474         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3475         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3476         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3477         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3478         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3479
3480 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3481
3482         [ews-app] Add model for handling multiple Buildbot instances
3483         https://bugs.webkit.org/show_bug.cgi?id=194863
3484
3485         Reviewed by Stephanie Lewis.
3486
3487         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3488
3489 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3490
3491         [ews-app] Remove BuilderMapping table
3492         https://bugs.webkit.org/show_bug.cgi?id=194961
3493
3494         Reviewed by Stephanie Lewis.
3495
3496         Store builder name directly in build table, instead of having a separate
3497         table for it.
3498
3499         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3500         * BuildSlaveSupport/ews-app/ews/models/build.py:
3501         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3502         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3503
3504 2019-02-25  John Wilander  <wilander@apple.com>
3505
3506         Introduce and adopt new class RegistrableDomain for eTLD+1
3507         https://bugs.webkit.org/show_bug.cgi?id=194791
3508         <rdar://problem/48179240>
3509
3510         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3511
3512         This patch adds an API test and replaces two instances of
3513         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3514
3515         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3516         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3517         (TestWebKitAPI::TEST):
3518             Changed two strings to make sure the registrable domains are still considered
3519             invalid and pass the test.
3520         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3521         (TestWebKitAPI::TEST):
3522         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3523         (WTR::InjectedBundle::didReceiveMessageToPage):
3524
3525 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3526
3527         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3528         https://bugs.webkit.org/show_bug.cgi?id=195001
3529
3530         Reviewed by Carlos Garcia Campos.
3531
3532         API version 1.0 always includes the functionality previously guarded with
3533         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3534         unconditionally.
3535
3536         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3537         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3538         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3539         (WebViewTest::showInWindow): Ditto.
3540         (WebViewTest::hideView): Ditto.
3541         * wpe/backends/HeadlessViewBackend.cpp:
3542         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3543         * wpe/backends/ViewBackend.cpp:
3544         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3545         * wpe/backends/WindowViewBackend.cpp:
3546         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3547         WPE_BACKEND_CHECK_VERSION().
3548         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3549
3550 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3551
3552         [Flatpak] Add support for flatpak > 1.1.2
3553         https://bugs.webkit.org/show_bug.cgi?id=194088
3554
3555         Flatpak 1.2 is now out so we need to support that
3556         version now.
3557
3558         Reviewed by Michael Catanzaro.
3559
3560         * flatpak/flatpakutils.py:
3561         (check_flatpak):
3562         (FlatpakPackages.__init__):
3563         (FlatpakPackages.__detect_packages):
3564         (FlatpakPackages.__detect_packages.in):
3565         (FlatpakRepos.update):
3566
3567 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3568
3569         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3570         https://bugs.webkit.org/show_bug.cgi?id=194998
3571
3572         Reviewed by Carlos Garcia Campos.
3573
3574         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3575         to a Git checkout and using the latest commit containing various fixes
3576         and improvements.
3577
3578 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3579
3580         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3581         https://bugs.webkit.org/show_bug.cgi?id=194981
3582
3583         Reviewed by Žan Doberšek.
3584
3585         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3586         (TestWebKitAPI::TEST):
3587
3588 2019-02-23  Keith Miller  <keith_miller@apple.com>
3589
3590         Add new mac target numbers
3591         https://bugs.webkit.org/show_bug.cgi?id=194955
3592
3593         Reviewed by Tim Horton.
3594
3595         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3596         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3597         * MiniBrowser/Configurations/Base.xcconfig:
3598         * TestWebKitAPI/Configurations/Base.xcconfig:
3599         * WebKitTestRunner/Configurations/Base.xcconfig:
3600
3601 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3602
3603         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3604         https://bugs.webkit.org/show_bug.cgi?id=194846
3605
3606         Reviewed by Don Olmstead.
3607
3608         Added _search_paths() and _port_specific_expectations_files() for
3609         WinCairoPort.
3610
3611         * Scripts/webkitpy/port/win.py:
3612         (WinCairoPort.default_baseline_search_path):
3613         (WinCairoPort):
3614         (WinCairoPort._port_specific_expectations_files):
3615         (WinCairoPort._search_paths):
3616
3617 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3618
3619         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3620         https://bugs.webkit.org/show_bug.cgi?id=194963
3621
3622         Reviewed by Dean Jackson.
3623
3624         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3625         Do a `contains` check instead of `equals`, because in debug builds we
3626         put the GraphicsLayer pointer in a prefix.
3627
3628 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3629
3630         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3631         https://bugs.webkit.org/show_bug.cgi?id=194873
3632         <rdar://problem/46701974>
3633
3634         Reviewed by Tim Horton.
3635
3636         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3637
3638         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3639         (WTR::UIScriptController::menuRect const):
3640         (WTR::UIScriptController::isShowingMenu const):
3641         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3642         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3643         (WTR::UIScriptController::menuRect const):
3644
3645         Add a function to query the bounds of the callout menu in content coordinates.
3646
3647         (WTR::UIScriptController::isShowingMenu const):
3648
3649         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3650
3651         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3652         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3653         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3654         (WTR::UIScriptController::rectForMenuAction const):
3655         (WTR::UIScriptController::menuRect const):
3656         (WTR::UIScriptController::isShowingMenu const):
3657         (WTR::findViewInHierarchyOfType): Deleted.
3658
3659 2019-02-22  Chris Dumez  <cdumez@apple.com>
3660
3661         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3662         https://bugs.webkit.org/show_bug.cgi?id=194954
3663         <rdar://problem/48127957>
3664
3665         Reviewed by Alex Christensen.
3666
3667         Add API test coverage.
3668
3669         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3670         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3671         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3672         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3673
3674 2019-02-22  Chris Dumez  <cdumez@apple.com>
3675
3676         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3677         https://bugs.webkit.org/show_bug.cgi?id=194924
3678         <rdar://problem/48216125>
3679
3680         Reviewed by Geoffrey Garen.
3681
3682         Add API test coverage.
3683
3684         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3685
3686 2019-02-22  Chris Dumez  <cdumez@apple.com>
3687
3688         Unreviewed, disable API test added in r241928 on iOS.
3689
3690         The cache is not enabled on devices with less than 3GB of RAM.
3691
3692         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3693
3694 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3695
3696         Hardcode Visual Viewports on everywhere except iOS WK1
3697         https://bugs.webkit.org/show_bug.cgi?id=194928
3698
3699         Reviewed by Zalan Bujtas.
3700
3701         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3702         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3703         set it to false. The setting has shipped for several years and there's no need to turn
3704         it off now.
3705
3706         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3707         Visual Viewports are not enabled.
3708         
3709         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3710         that only runs in WK2
3711
3712         * MiniBrowser/mac/SettingsController.h:
3713         * MiniBrowser/mac/SettingsController.m:
3714         (-[SettingsController init]):
3715         (-[SettingsController _populateMenu]):
3716         (-[SettingsController validateMenuItem:]):
3717         (-[SettingsController visualViewportEnabled]): Deleted.
3718         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3719         * MiniBrowser/mac/WK1BrowserWindowController.m:
3720         (-[WK1BrowserWindowController didChangeSettings]):
3721         * MiniBrowser/mac/WK2BrowserWindowController.m:
3722         (-[WK2BrowserWindowController didChangeSettings]):
3723
3724 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3725
3726         Discard cached processes when clearing website data store
3727         https://bugs.webkit.org/show_bug.cgi?id=194894
3728
3729         Reviewed by Chris Dumez.
3730
3731         Added a test case.
3732
3733         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3734         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3735
3736 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3737
3738         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3739         https://bugs.webkit.org/show_bug.cgi?id=194914
3740         <rdar://problem/47586889>
3741
3742         Reviewed by Geoffrey Garen.
3743
3744         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3745         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3746         (TEST):
3747         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3748
3749 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3750
3751         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3752         <https://webkit.org/b/194761>
3753
3754         Reviewed by Myles Maxfield.
3755
3756         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3757         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3758         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3759         to use ARC-compliant cast.
3760         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3761         ARC-compliant cast.
3762         (WTR::installFakeHelvetica): Log `error` to console if
3763         CTFontManagerRegisterFontsForURL() fails, but only on supported
3764         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3765         Call CFRelease() on `error` to fix the leak.  Update to use
3766         ARC-compliant cast.
3767         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3768         cast.
3769
3770 2019-02-21  Chris Dumez  <cdumez@apple.com>
3771
3772         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3773         https://bugs.webkit.org/show_bug.cgi?id=194481
3774
3775         Reviewed by Alex Christensen.
3776
3777         Give the processes a chance to shutdown and wait until we reached the expected number
3778         of processes.
3779
3780         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3781
3782 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3783
3784         Fix the macOS build
3785
3786         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3787
3788 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3789
3790         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3791
3792         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3793         I am a backwards.
3794
3795 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3796
3797         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3798
3799         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3800         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3801         We could force on UI-side compositing, but I feel like the test might be more
3802         valuable exercising the normal path on each platform (though the original
3803         bug was also UI-side specific). Though we can't validate that the overlay
3804         layer was installed successfully, there are layout tests that do that.
3805
3806 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3807
3808         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3809         https://bugs.webkit.org/show_bug.cgi?id=194845
3810         <rdar://problem/47944579>
3811
3812         Reviewed by Antti Koivisto.
3813
3814         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3815         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3816
3817 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3818
3819         [LFC][Floats] Add support for placing formatting roots in-between floats.
3820         https://bugs.webkit.org/show_bug.cgi?id=194902
3821
3822         Reviewed by Antti Koivisto.
3823
3824         * LayoutReloaded/misc/LFC-passing-tests.txt:
3825
3826 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3827
3828         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3829         https://bugs.webkit.org/show_bug.cgi?id=194901
3830
3831         Unreviewed build fix.
3832
3833         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3834         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3835         WPEBackend-fdo-0.1 as library name.
3836
3837 2019-02-21  Rob Buis  <rbuis@igalia.com>
3838
3839         Update MIME type parser
3840         https://bugs.webkit.org/show_bug.cgi?id=180526
3841
3842         Reviewed by Darin Adler.
3843
3844         Add tests involving leading and trailing whitespace, non-token
3845         characters and quoted strings.
3846
3847         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3848         (TestWebKitAPI::TEST):
3849
3850 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3851
3852         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3853         https://bugs.webkit.org/show_bug.cgi?id=194884
3854
3855         Reviewed by Michael Catanzaro.
3856
3857         * PlatformWin.cmake:
3858
3859 2019-02-20  Chris Dumez  <cdumez@apple.com>
3860
3861         Add API test for <rdar://problem/47471222>
3862         https://bugs.webkit.org/show_bug.cgi?id=194847
3863
3864         Reviewed by Alex Christensen.
3865
3866         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3867
3868 2019-02-20  Chris Dumez  <cdumez@apple.com>
3869
3870         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3871         https://bugs.webkit.org/show_bug.cgi?id=194872
3872         <rdar://problem/47924500>
3873
3874         Reviewed by Alex Christensen.
3875
3876         Add API test coverage.
3877
3878         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3879
3880 2019-02-20  Jer Noble  <jer.noble@apple.com>
3881
3882         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3883         https://bugs.webkit.org/show_bug.cgi?id=191332
3884
3885         Reviewed by Dean Jackson.
3886
3887         * Scripts/git-is-in-range: Added.
3888
3889 2019-02-20  Andy Estes  <aestes@apple.com>
3890
3891         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3892         https://bugs.webkit.org/show_bug.cgi?id=194869
3893
3894         Rubber-stamped by Jer Noble.
3895
3896         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3897         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3898         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3899         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3900         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3901         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3902
3903 2019-02-20  Chris Dumez  <cdumez@apple.com>
3904
3905         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3906         https://bugs.webkit.org/show_bug.cgi?id=194857
3907         <rdar://problem/47759323>
3908
3909         Reviewed by Alex Christensen.
3910
3911         Add API test coverage.
3912
3913         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3914
3915 2019-02-20  Chris Dumez  <cdumez@apple.com>
3916
3917         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3918         https://bugs.webkit.org/show_bug.cgi?id=194829
3919         <rdar://problem/47889906>
3920
3921         Reviewed by Alexey Proskuryakov.
3922
3923         Every time the TestOptions were changing we were creating both a new Web view and
3924         a new WKContext, which would start a new Network process. In most cases, we only
3925         need to contruct a new Web view and we do can keep reusing the same WKContext.
3926         This patch implements this optimization and thus avoids spinning a lot of new
3927         Network processes while running the layout tests.
3928
3929         * WebKitTestRunner/TestController.cpp:
3930         (WTR::TestController::generateContextConfiguration const):
3931         (WTR::TestController::generatePageConfiguration):
3932         (WTR::TestController::createWebViewWithOptions):
3933         (WTR::TestController::resetPreferencesToConsistentValues):
3934         (WTR::updateTestOptionsFromTestHeader):
3935         * WebKitTestRunner/TestController.h:
3936         * WebKitTestRunner/TestOptions.h:
3937         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3938         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3939         (WTR::TestOptions::hasSameInitializationOptions const):
3940         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3941         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3942         (WTR::TestController::platformAddTestOptions const):
3943
3944 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3945
3946         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3947         https://bugs.webkit.org/show_bug.cgi?id=167941
3948
3949         Reviewed by Carlos Garcia Campos.
3950
3951         * MiniBrowser/gtk/main.c:
3952         (filterSavedCallback): Added.
3953         (main): Support loading a JSON rule set file for content filtering.
3954         * MiniBrowser/wpe/main.cpp:
3955         (filterSavedCallback): Added.
3956         (main): Support loading a JSON rule set file for content filtering.
3957         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3958         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3959         (WTF::derefGPtr): Ditto.
3960         (testEmptyStore):
3961         (testSaveInvalidFilter):
3962         (testSaveLoadFilter):
3963         (testSavedFilterIdentifierMatch):
3964         (testRemoveFilter):
3965         (testSaveMultipleFilters):
3966         (testSaveFilterFromFile):
3967         (testFilterPersistence):
3968         (beforeAll):
3969         (afterAll):
3970         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3971         (removeOldInjectedContentAndResetLists): Also reset content filters.
3972         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3973         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3974         the element affected by the style sheet.
3975         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3976         and returns it to be used by tests.
3977         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3978         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3979         (serverCallback): Add support for serving a CSS style sheet for testing.
3980         (beforeAll): Add call to testUserContentManagerContentFilter().
3981         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3982
3983 2019-02-19  Keith Rollin  <krollin@apple.com>
3984
3985         Add timing information to build output
3986         https://bugs.webkit.org/show_bug.cgi?id=194839
3987         <rdar://problem/48219609>
3988
3989         Reviewed by Alexey Proskuryakov.
3990
3991         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3992         emit each project's build time to its output. E.g.,
3993
3994             ** BUILD SUCCEEDED ** [0.132 sec]
3995
3996         * Scripts/webkitdirs.pm:
3997         (XcodeOptions):
3998
3999 2019-02-19  Truitt Savell  <tsavell@apple.com>
4000
4001         Unreviewed, rolling out r241784.
4002
4003         Broke all OpenSource builds.
4004
4005         Reverted changeset:
4006
4007         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4008         instances view"
4009         https://bugs.webkit.org/show_bug.cgi?id=172848
4010         https://trac.webkit.org/changeset/241784
4011
4012 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4013
4014         [LFC][Floats] Remove redundant intersecting logic
4015         https://bugs.webkit.org/show_bug.cgi?id=194804
4016
4017         Reviewed by Antti Koivisto.
4018
4019         * LayoutReloaded/misc/LFC-passing-tests.txt:
4020
4021 2019-02-19  Dean Jackson  <dino@apple.com>
4022
4023         Clean-up output from generate-xcfilelists so it can be filtered
4024         https://bugs.webkit.org/show_bug.cgi?id=194795
4025
4026         Reviewed by Joseph Pecoraro (and Keith Rollin).
4027
4028         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4029         make a slight tweak to filter-build-webkit so such lines are marked
4030         as plain.
4031
4032         * Scripts/filter-build-webkit:
4033         * Scripts/generate-xcfilelists:
4034
4035 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4036
4037         pytest is not correctly auto-installed
4038         https://bugs.webkit.org/show_bug.cgi?id=194707
4039
4040         Reviewed by Carlos Garcia Campos.
4041
4042         * Scripts/webkitpy/thirdparty/__init__.py:
4043         (AutoinstallImportHook._install_pytest):
4044
4045 2019-02-18  Chris Dumez  <cdumez@apple.com>
4046
4047         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4048         https://bugs.webkit.org/show_bug.cgi?id=194797
4049         <rdar://problem/48055151>
4050
4051         Reviewed by Geoffrey Garen.
4052
4053         Add API test coverage.
4054
4055         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4056
4057 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4058
4059         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4060         https://bugs.webkit.org/show_bug.cgi?id=194670
4061         <rdar://problem/39066529>
4062
4063         Reviewed by Tim Horton.
4064
4065         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4066         pasted in an editable area as attachment elements.
4067
4068         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4069         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4070         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4071         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4072         (TestWebKitAPI::TEST):
4073         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4074         (WTR::InjectedBundlePage::InjectedBundlePage):
4075
4076 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4077
4078         Fix API test after r241728
4079        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4080
4081         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4082         (TEST):
4083         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4084
4085 2019-02-18  Daniel Bates  <dabates@apple.com>
4086
4087         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4088         https://bugs.webkit.org/show_bug.cgi?id=192824
4089         <rdar://problem/47100332>
4090
4091         Reviewed by Wenson Hsieh.
4092
4093         Fix a bug where the wrong usage code was used for F13 thru F24.
4094
4095         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4096         (keyCodeForDOMFunctionKey):
4097
4098 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4099
4100         Bytecode cache should a have a boot-specific validation
4101         https://bugs.webkit.org/show_bug.cgi?id=194769
4102         <rdar://problem/48149509>
4103
4104         Reviewed by Keith Miller.
4105
4106         Add test for WTF::bootSessionUUIDString()
4107
4108         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4109         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4110         (TEST):
4111
4112 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4113
4114         Disable safe browsing in WKWebView and remove its WKPreferences API
4115         https://bugs.webkit.org/show_bug.cgi?id=194723
4116         <rdar://problem/48122993>
4117
4118         Reviewed by Geoffrey Garen.
4119
4120         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4121         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4122         (TEST):
4123         (safeBrowsingView):
4124         Make tests use SPI instead of API.
4125
4126 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4127
4128         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4129         https://bugs.webkit.org/show_bug.cgi?id=194586
4130
4131         Reviewed by Ross Kirsling.
4132
4133         * DumpRenderTree/win/DumpRenderTree.cpp:
4134         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4135         * Scripts/webkitpy/port/driver.py:
4136         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4137
4138 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4139
4140         Unreviewed, rolling out r241620.
4141
4142         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
4143         (Requested by ddkilzer on #webkit.)
4144
4145         Reverted changeset:
4146
4147         "[WTF] Add environment variable helpers"
4148         https://bugs.webkit.org/show_bug.cgi?id=192405
4149         https://trac.webkit.org/changeset/241620
4150
4151 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4152
4153         [LFC] RenderImage's default intrinsic size is 0.
4154         https://bugs.webkit.org/show_bug.cgi?id=194745
4155
4156         Reviewed by Antti Koivisto.
4157
4158         * LayoutReloaded/misc/LFC-passing-tests.txt:
4159
4160 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4161
4162         [LFC][BFC] Add support for block replaced intrinsic width.
4163         https://bugs.webkit.org/show_bug.cgi?id=194705
4164
4165         Reviewed by Simon Fraser.
4166
4167         * LayoutReloaded/misc/LFC-passing-tests.txt:
4168
4169 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4170
4171         [LFC] Apply min/max width constraints to preferred width computation
4172         https://bugs.webkit.org/show_bug.cgi?id=194739
4173
4174         Reviewed by Simon Fraser.
4175
4176         * LayoutReloaded/misc/LFC-passing-tests.txt:
4177
4178 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
4179
4180         [WTF] Add environment variable helpers
4181         https://bugs.webkit.org/show_bug.cgi?id=192405
4182
4183         Reviewed by Michael Catanzaro.
4184
4185         * DumpRenderTree/mac/DumpRenderTree.mm:
4186         (libraryPathForDumpRenderTree):
4187         * DumpRenderTree/win/DumpRenderTree.cpp:
4188         (libraryPathForDumpRenderTree):
4189         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4190         (setUpIOSLayoutTestCommunication):
4191         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4192         (beforeAll):
4193         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4194         (main):
4195         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4196         (WebKitTestBus::run):
4197         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4198         (WTR::getOutputDir):
4199         (WTR::initializeFontConfigSetting):
4200         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4201         (WTR::InjectedBundle::platformInitialize):
4202         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4203         (WTR::topLevelPath):
4204         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4205         (WTR::topLevelPath):
4206         (WTR::getOutputDir):
4207         (WTR::activateFonts):
4208         * WebKitTestRunner/TestController.cpp:
4209         (WTR::TestController::libraryPathForTesting):
4210         (WTR::TestController::generateContextConfiguration const):
4211         (WTR::TestController::generatePageConfiguration):
4212         (WTR::TestController::decideDestinationWithSuggestedFilename):
4213         (WTR::TestController::platformAdjustContext):
4214         * WebKitTestRunner/TestController.h:
4215         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4216         (WTR::TestController::cocoaPlatformInitialize):
4217         (WTR::TestController::platformAdjustContext):
4218         * WebKitTestRunner/gtk/main.cpp:
4219         (main):
4220         * WebKitTestRunner/mac/TestControllerMac.mm:
4221         (WTR::TestController::configureContentExtensionForTest):
4222         * WebKitTestRunner/wpe/main.cpp:
4223         (main):
4224         Utilize WTF::Environment where possible.
4225
4226 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4227
4228         [iOS] WKWebView callout bar is missing Change Writing Direction item
4229         https://bugs.webkit.org/show_bug.cgi?id=190015
4230         <rdar://problem/44810366>
4231
4232         Reviewed by Tim Horton.
4233
4234         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
4235         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
4236
4237         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
4238         (TestWebKitAPI::TEST):
4239
4240 2019-02-15  Chris Dumez  <cdumez@apple.com>
4241
4242         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
4243         https://bugs.webkit.org/show_bug.cgi?id=194717
4244         <rdar://problem/47884404>
4245
4246         Reviewed by Brady Eidson.
4247
4248         Add API test coverage.
4249
4250         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4251
4252 2019-02-15  Youenn Fablet  <youenn@apple.com>
4253
4254         Make navigator.mediaDevices SecureContext
4255         https://bugs.webkit.org/show_bug.cgi?id=194666
4256
4257         Reviewed by Eric Carlson.
4258
4259         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4260         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4261         (TEST_F):
4262
4263 2019-02-15  Brian Burg  <bburg@apple.com>
4264
4265         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4266         https://bugs.webkit.org/show_bug.cgi?id=194411
4267         <rdar://problem/47787614>
4268
4269         Reviewed by Joseph Pecoraro.
4270
4271         Remove unnecessary soft linking macro usage.
4272
4273         * DumpRenderTree/mac/TestRunnerMac.mm:
4274         (TestRunner::inspectorTestStubURL):
4275         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4276         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4277         (WTR::TestRunner::inspectorTestStubURL):
4278
4279 2019-02-15  Commit Queue  <commit-queue@webkit.org>
4280
4281         Unreviewed, rolling out r241559 and r241566.
4282         https://bugs.webkit.org/show_bug.cgi?id=194710
4283
4284         Causes layout test crashes under GuardMalloc (Requested by
4285         ryanhaddad on #webkit).
4286
4287         Reverted changesets:
4288
4289         "[WTF] Add environment variable helpers"
4290         https://bugs.webkit.org/show_bug.cgi?id=192405
4291         https://trac.webkit.org/changeset/241559
4292
4293         "Unreviewed build fix for WinCairo Debug after r241559."
4294         https://trac.webkit.org/changeset/241566
4295
4296 2019-02-15  Zalan Bujtas  <zalan@apple.com>
4297
4298         [LFC] Out-of-flow box is never a float box
4299         https://bugs.webkit.org/show_bug.cgi?id=194704
4300
4301         Reviewed by Antti Koivisto.
4302
4303         * LayoutReloaded/misc/LFC-passing-tests.txt:
4304
4305 2019-02-10  Darin Adler  <darin@apple.com>
4306
4307         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
4308         https://bugs.webkit.org/show_bug.cgi?id=194487
4309
4310         Reviewed by Daniel Bates.
4311
4312         * DumpRenderTree/win/DumpRenderTree.cpp:
4313         (applicationId): Use makeString instead of String::format.
4314         (main): Ditto.
4315         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4316         (TestWebKitAPI::Util::createURLForResource): Ditto.
4317         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
4318         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
4319
4320         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4321         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
4322         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
4323         (WTR::createStringWithAttributes): Use appendLiteral.
4324         (WTR::AccessibilityUIElement::helpText const): Ditto.
4325         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
4326         directly instead of using String::format.
4327         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
4328         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
4329
4330 2019-02-15  Truitt Savell  <tsavell@apple.com>
4331
4332         Unreviewed, rolling out r241564.
4333
4334         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
4335
4336         Reverted changeset:
4337
4338         "[Mac] WebInspectorUI.framework does not need to be soft-
4339         linked anymore"
4340         https://bugs.webkit.org/show_bug.cgi?id=194411
4341         https://trac.webkit.org/changeset/241564
4342
4343 2019-02-15  Saam barati  <sbarati@apple.com>
4344
4345         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
4346         https://bugs.webkit.org/show_bug.cgi?id=194036
4347
4348         Reviewed by Yusuke Suzuki.
4349
4350         * Scripts/run-jsc-stress-tests:
4351
4352 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4353
4354         Fix the build.
4355
4356         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4357         (WTR::UIScriptController::drawSquareInEditableImage):
4358         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4359         (TestWebKitAPI::drawSquareInEditableImage):
4360
4361 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4362