Rid the world of WK_API_ENABLED
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2
3         Rid the world of WK_API_ENABLED
4         https://bugs.webkit.org/show_bug.cgi?id=195263
5
6         Reviewed by Dan Bernstein.
7
8         List of changed files elided because it's useless.
9
10 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
11
12         Unreviewed follow-up to r242292.
13
14         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
15
16         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
17         (TestWebKitAPI::testStrip): Renamed from strip.
18         (TestWebKitAPI::TEST):
19
20 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
21
22         Unreviewed, remove accidentally-committed URLHelpers.cpp test
23
24         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
25         and bug #194272 for details.
26
27         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
28
29 2019-03-03  Tim Horton  <timothy_horton@apple.com>
30
31         Remove some more unused 32-bit code
32         https://bugs.webkit.org/show_bug.cgi?id=195255
33
34         Reviewed by Darin Adler.
35
36         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
37         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
38         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
39         (NPP_New):
40         (NPP_HandleEvent):
41         (handleEventCarbon): Deleted.
42
43 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
44
45         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
46
47         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
48         (TestWebKitAPI::TEST):
49
50 2019-03-01  Darin Adler  <darin@apple.com>
51
52         Finish removing String::format
53         https://bugs.webkit.org/show_bug.cgi?id=194893
54
55         Reviewed by Daniel Bates.
56 '
57         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
58
59 2019-03-01  Alex Christensen  <achristensen@webkit.org>
60
61         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
62         https://bugs.webkit.org/show_bug.cgi?id=195229
63         <rdar://problem/48520362>
64
65         Reviewed by Chris Dumez.
66
67         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
68         (TEST):
69
70 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
71
72         Add a system trace scope for event region building
73         https://bugs.webkit.org/show_bug.cgi?id=195226
74
75         Reviewed by Jon Lee.
76
77         This trace scope measures the time spend converting element rects into Region objects,
78         which can be large on some pages.
79
80         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
81
82         * Tracing/SystemTracePoints.plist:
83
84 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
85
86         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
87         https://bugs.webkit.org/show_bug.cgi?id=194612
88
89         Reviewed by Alex Christensen.
90
91         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
92         Just test the new string-processing function and don't touch the actual environment.
93         (Test cases are all as before, but based on operator== instead of strcmp.)
94
95 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
96
97         [ews-app] Update primary keys for handling multiple Buildbot instances
98         https://bugs.webkit.org/show_bug.cgi?id=195120
99
100         Reviewed by Stephanie Lewis.
101
102         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
103         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
104         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
105
106         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
107         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
108         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
109         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
110         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
111         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
112
113 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
114
115         [WinCairo] Enable service worker
116         https://bugs.webkit.org/show_bug.cgi?id=188318
117
118         Reviewed by Youenn Fablet.
119
120         * DumpRenderTree/DumpRenderTreePrefix.h:
121         * TestWebKitAPI/PlatformWin.cmake:
122         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
123         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
124         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
125
126 2019-03-01  Justin Fan  <justin_fan@apple.com>
127
128         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
129         https://bugs.webkit.org/show_bug.cgi?id=195191
130
131         Rubber-stamped by Dean Jackson.
132
133         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
134
135         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
136
137 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
138
139         Unreviewed, fix lldb webkitpy tests
140         https://bugs.webkit.org/show_bug.cgi?id=194375
141
142         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
143
144         * lldb/lldb_webkit.py:
145         (WTFStringImplProvider.is_8bit):
146
147 2019-02-28  David Quesada  <david_quesada@apple.com>
148
149         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
150         https://bugs.webkit.org/show_bug.cgi?id=195121
151         rdar://problem/48450302
152
153         Reviewed by Alex Christensen.
154
155         Add API tests for -WKNavigationAction._shouldPerformDownload in various
156         configurations where the 'download' attribute is absent, blank, or populated
157         with a filename, and where the anchor element is same-origin or cross-origin
158         (meaning the 'download' attribute shouldn't be honored).
159
160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
161         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
162         (-[NavigationActionTestDelegate init]):
163         (-[NavigationActionTestDelegate navigationAction]):
164         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
165         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
166         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
167         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
168         (TEST):
169
170 2019-02-28  Antoine Quint  <graouts@apple.com>
171
172         Enable the Pointer Events runtime flag by default
173         https://bugs.webkit.org/show_bug.cgi?id=195156
174
175         Reviewed by Dean Jackson.
176
177         * DumpRenderTree/mac/DumpRenderTree.mm:
178         (enableExperimentalFeatures):
179
180 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
181
182         Several PasteImage API tests are flaky
183         https://bugs.webkit.org/show_bug.cgi?id=195160
184
185         Reviewed by Tim Horton.
186
187         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
188         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
189         listening for a "load" event after image load is already complete.
190
191         To address this, make these tests first register a "load" event handler, then run script to insert an image
192         element into the document, and finally wait until the load event is observed before checking image size.
193
194         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
195
196 2019-02-28  Chris Dumez  <cdumez@apple.com>
197
198         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
199         https://bugs.webkit.org/show_bug.cgi?id=195107
200
201         Reviewed by Alex Christensen.
202
203         Give some time for the zoom level to get restored.
204
205         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
206
207 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
208
209         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
210         https://bugs.webkit.org/show_bug.cgi?id=194958
211
212         Reviewed by Geoffrey Garen.
213
214         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
215         (TEST):
216
217 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
218
219         [ews-app] Update method to save build to handle builder_display_name
220         https://bugs.webkit.org/show_bug.cgi?id=195047
221
222         Reviewed by Dewei Zhu.
223
224         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
225         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
226
227 2019-02-28  Justin Fan  <justin_fan@apple.com>
228
229         [Web GPU] Enable Web GPU only on 64-bit
230         https://bugs.webkit.org/show_bug.cgi?id=195139
231
232         Because Metal is only supported on 64 bit apps.
233
234         Unreviewed build fix.
235
236         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
237
238 2019-02-27  Youenn Fablet  <youenn@apple.com>
239
240         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
241         https://bugs.webkit.org/show_bug.cgi?id=194959
242
243         Reviewed by Chris Dumez.
244
245         Spin loop until getting the condition to remove flakiness.
246
247         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
248
249 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
250
251         [ews-build] Buildbot should include builder_display_name in the build events
252         https://bugs.webkit.org/show_bug.cgi?id=195045
253
254         Reviewed by Dewei Zhu.
255
256         * BuildSlaveSupport/ews-build/events.py:
257         (Events.buildStarted): Included builder_display_name in event data. Also renamed
258         buildername to builder_name to be consistent in naming style.
259         (Events.buildFinished): Ditto.
260
261 2019-02-27  Chris Dumez  <cdumez@apple.com>
262
263         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
264         https://bugs.webkit.org/show_bug.cgi?id=194480
265
266         Reviewed by Brady Eidson.
267
268         Update existing API test to make it more likely to reproduce the issue.
269
270         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
271
272 2019-02-27  Brady Eidson  <beidson@apple.com>
273
274         Universal links from Google search results pages don't open the app.
275         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
276
277         Reviewed by Geoffrey Garen.
278
279         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
280         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
281         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
282         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
283
284 2019-02-27  Chris Dumez  <cdumez@apple.com>
285
286         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
287         https://bugs.webkit.org/show_bug.cgi?id=195102
288
289         Reviewed by Geoffrey Garen.
290
291         If the number of processes is not yet what we expect, wait a bit and check again to give
292         processes some time to exit.
293
294         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
295
296 2019-02-27  Chris Dumez  <cdumez@apple.com>
297
298         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
299         https://bugs.webkit.org/show_bug.cgi?id=194545
300
301         Reviewed by Brady Eidson.
302
303         Make sure the test navigates forward and then back only once. Previously, navigating
304         back would trigger a navigation again in a timer.
305
306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
307
308 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
309
310         High Sierra Debug JSC test queue should use faster hardware
311         https://bugs.webkit.org/show_bug.cgi?id=194603
312
313         Rubber-stamped by Alexey Proskuryakov.
314
315         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
316
317         * BuildSlaveSupport/build.webkit.org-config/config.json:
318         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
319         (BubbleQueueServer):
320         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
321         (WebKitBuildbot):
322         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
323         * QueueStatusServer/config/queues.py:
324         * Scripts/webkitpy/common/config/ews.json:
325         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
326         (test_ews_name):
327
328 2019-02-27  John Wilander  <wilander@apple.com>
329
330         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
331         https://bugs.webkit.org/show_bug.cgi?id=195071
332         <rdar://problem/48417690>
333
334         Reviewed by Alex Christensen and Brent Fulgham.
335
336         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
337         (TestWebKitAPI::createURL):
338             Convenience function.
339         (TestWebKitAPI::TEST):
340             WebCore::AdClickAttribution now takes a URL when creating Source and
341             Destination.
342         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
343         (TestWebKitAPI::TEST):
344             WebCore::AdClickAttribution now takes a URL when creating Source and
345             Destination.
346
347 2019-02-27  Antoine Quint  <graouts@apple.com>
348
349         Support Pointer Events on macOS
350         https://bugs.webkit.org/show_bug.cgi?id=195008
351         <rdar://problem/47454419>
352
353         Reviewed by Dean Jackson.
354
355         * DumpRenderTree/mac/DumpRenderTree.mm:
356         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
357         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
358
359 2019-02-26  Mark Lam  <mark.lam@apple.com>
360
361         Remove remaining poisoning code.
362         https://bugs.webkit.org/show_bug.cgi?id=194138
363
364         Reviewed by Saam Barati.
365
366         * TestWebKitAPI/CMakeLists.txt:
367         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
368         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
369         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
370         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
371         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
372         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
373         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
374
375 2019-02-26  Alex Christensen  <achristensen@webkit.org>
376
377         Move ephemeral local storage from WebProcess to UIProcess
378         https://bugs.webkit.org/show_bug.cgi?id=195074
379         <rdar://problem/47937975>
380
381         Reviewed by Geoff Garen.
382
383         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
384
385 2019-02-20  Jer Noble  <jer.noble@apple.com>
386
387         [Cocoa] Media elements will restart network buffering just before suspending
388         https://bugs.webkit.org/show_bug.cgi?id=193691
389
390         Reviewed by Eric Carlson.
391
392         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
393         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
394         (TEST):
395
396 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
397
398         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
399         https://bugs.webkit.org/show_bug.cgi?id=191652
400
401         Reviewed by Alex Christensen.
402
403         Fix WinCairo MiniBrowser behavior of authentication dialog.
404
405         * MiniBrowser/win/WebKitBrowserWindow.cpp:
406         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
407
408 2019-02-26  Youenn Fablet  <youenn@apple.com>
409
410         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
411         https://bugs.webkit.org/show_bug.cgi?id=195028
412         <rdar://problem/48243733>
413
414         Reviewed by Eric Carlson.
415
416         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
417
418 2019-02-26  Philippe Normand  <pnormand@igalia.com>
419
420         [WPE] Add API for webview background color configuration
421         https://bugs.webkit.org/show_bug.cgi?id=192305
422
423         Reviewed by Michael Catanzaro.
424
425         * MiniBrowser/wpe/main.cpp:
426         (main): Add a new option to configure the webview background
427         color. Example: --bg-color=transparent.
428         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
429         (testWebViewBackgroundColor): Enable background color API tests for WPE.
430         (beforeAll): Ditto.
431
432 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
433
434         scalableNativeWebpageParameters() is not preserved on new page navigation.
435         https://bugs.webkit.org/show_bug.cgi?id=194892
436         <rdar://problem/47538280>
437
438         Reviewed by Wenson Hsieh.
439         
440         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
441
442         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
443         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
444         * DumpRenderTree/mac/UIScriptControllerMac.mm:
445         (WTR::UIScriptController::allowsViewportShrinkToFit):
446         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
447         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
448         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
449         * TestRunnerShared/UIScriptContext/UIScriptController.h:
450         * WebKitTestRunner/UIScriptControllerCocoa.mm:
451         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
452
453 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
454
455         [ews-app] Add model for handling multiple Buildbot instances
456         https://bugs.webkit.org/show_bug.cgi?id=194863
457
458         Reviewed by Stephanie Lewis.
459
460         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
461
462 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
463
464         [ews-app] Remove BuilderMapping table
465         https://bugs.webkit.org/show_bug.cgi?id=194961
466
467         Reviewed by Stephanie Lewis.
468
469         Store builder name directly in build table, instead of having a separate
470         table for it.
471
472         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
473         * BuildSlaveSupport/ews-app/ews/models/build.py:
474         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
475         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
476
477 2019-02-25  John Wilander  <wilander@apple.com>
478
479         Introduce and adopt new class RegistrableDomain for eTLD+1
480         https://bugs.webkit.org/show_bug.cgi?id=194791
481         <rdar://problem/48179240>
482
483         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
484
485         This patch adds an API test and replaces two instances of
486         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
487
488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
489         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
490         (TestWebKitAPI::TEST):
491             Changed two strings to make sure the registrable domains are still considered
492             invalid and pass the test.
493         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
494         (TestWebKitAPI::TEST):
495         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
496         (WTR::InjectedBundle::didReceiveMessageToPage):
497
498 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
499
500         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
501         https://bugs.webkit.org/show_bug.cgi?id=195001
502
503         Reviewed by Carlos Garcia Campos.
504
505         API version 1.0 always includes the functionality previously guarded with
506         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
507         unconditionally.
508
509         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
510         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
511         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
512         (WebViewTest::showInWindow): Ditto.
513         (WebViewTest::hideView): Ditto.
514         * wpe/backends/HeadlessViewBackend.cpp:
515         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
516         * wpe/backends/ViewBackend.cpp:
517         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
518         * wpe/backends/WindowViewBackend.cpp:
519         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
520         WPE_BACKEND_CHECK_VERSION().
521         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
522
523 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
524
525         [Flatpak] Add support for flatpak > 1.1.2
526         https://bugs.webkit.org/show_bug.cgi?id=194088
527
528         Flatpak 1.2 is now out so we need to support that
529         version now.
530
531         Reviewed by Michael Catanzaro.
532
533         * flatpak/flatpakutils.py:
534         (check_flatpak):
535         (FlatpakPackages.__init__):
536         (FlatpakPackages.__detect_packages):
537         (FlatpakPackages.__detect_packages.in):
538         (FlatpakRepos.update):
539
540 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
541
542         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
543         https://bugs.webkit.org/show_bug.cgi?id=194998
544
545         Reviewed by Carlos Garcia Campos.
546
547         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
548         to a Git checkout and using the latest commit containing various fixes
549         and improvements.
550
551 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
552
553         [WPE][GTK] Remove user agent quirk for washingtonpost.com
554         https://bugs.webkit.org/show_bug.cgi?id=194981
555
556         Reviewed by Žan Doberšek.
557
558         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
559         (TestWebKitAPI::TEST):
560
561 2019-02-23  Keith Miller  <keith_miller@apple.com>
562
563         Add new mac target numbers
564         https://bugs.webkit.org/show_bug.cgi?id=194955
565
566         Reviewed by Tim Horton.
567
568         * DumpRenderTree/mac/Configurations/Base.xcconfig:
569         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
570         * MiniBrowser/Configurations/Base.xcconfig:
571         * TestWebKitAPI/Configurations/Base.xcconfig:
572         * WebKitTestRunner/Configurations/Base.xcconfig:
573
574 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
575
576         [WinCairo] Enable wk1/wk2 suffix for platform search path.
577         https://bugs.webkit.org/show_bug.cgi?id=194846
578
579         Reviewed by Don Olmstead.
580
581         Added _search_paths() and _port_specific_expectations_files() for
582         WinCairoPort.
583
584         * Scripts/webkitpy/port/win.py:
585         (WinCairoPort.default_baseline_search_path):
586         (WinCairoPort):
587         (WinCairoPort._port_specific_expectations_files):
588         (WinCairoPort._search_paths):
589
590 2019-02-22  Tim Horton  <timothy_horton@apple.com>
591
592         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
593         https://bugs.webkit.org/show_bug.cgi?id=194963
594
595         Reviewed by Dean Jackson.
596
597         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
598         Do a `contains` check instead of `equals`, because in debug builds we
599         put the GraphicsLayer pointer in a prefix.
600
601 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
602
603         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
604         https://bugs.webkit.org/show_bug.cgi?id=194873
605         <rdar://problem/46701974>
606
607         Reviewed by Tim Horton.
608
609         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
610
611         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
612         (WTR::UIScriptController::menuRect const):
613         (WTR::UIScriptController::isShowingMenu const):
614         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
615         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
616         (WTR::UIScriptController::menuRect const):
617
618         Add a function to query the bounds of the callout menu in content coordinates.
619
620         (WTR::UIScriptController::isShowingMenu const):
621
622         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
623
624         * TestRunnerShared/UIScriptContext/UIScriptController.h:
625         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
626         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
627         (WTR::UIScriptController::rectForMenuAction const):
628         (WTR::UIScriptController::menuRect const):
629         (WTR::UIScriptController::isShowingMenu const):
630         (WTR::findViewInHierarchyOfType): Deleted.
631
632 2019-02-22  Chris Dumez  <cdumez@apple.com>
633
634         Regression(PSON) Unable to preview password-protected documents on iCloud.com
635         https://bugs.webkit.org/show_bug.cgi?id=194954
636         <rdar://problem/48127957>
637
638         Reviewed by Alex Christensen.
639
640         Add API test coverage.
641
642         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
643         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
644         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
645         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
646
647 2019-02-22  Chris Dumez  <cdumez@apple.com>
648
649         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
650         https://bugs.webkit.org/show_bug.cgi?id=194924
651         <rdar://problem/48216125>
652
653         Reviewed by Geoffrey Garen.
654
655         Add API test coverage.
656
657         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
658
659 2019-02-22  Chris Dumez  <cdumez@apple.com>
660
661         Unreviewed, disable API test added in r241928 on iOS.
662
663         The cache is not enabled on devices with less than 3GB of RAM.
664
665         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
666
667 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
668
669         Hardcode Visual Viewports on everywhere except iOS WK1
670         https://bugs.webkit.org/show_bug.cgi?id=194928
671
672         Reviewed by Zalan Bujtas.
673
674         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
675         change the default value of the Setting to 'true', and hardcode WebView on iOS to
676         set it to false. The setting has shipped for several years and there's no need to turn
677         it off now.
678
679         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
680         Visual Viewports are not enabled.
681         
682         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
683         that only runs in WK2
684
685         * MiniBrowser/mac/SettingsController.h:
686         * MiniBrowser/mac/SettingsController.m:
687         (-[SettingsController init]):
688         (-[SettingsController _populateMenu]):
689         (-[SettingsController validateMenuItem:]):
690         (-[SettingsController visualViewportEnabled]): Deleted.
691         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
692         * MiniBrowser/mac/WK1BrowserWindowController.m:
693         (-[WK1BrowserWindowController didChangeSettings]):
694         * MiniBrowser/mac/WK2BrowserWindowController.m:
695         (-[WK2BrowserWindowController didChangeSettings]):
696
697 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
698
699         Discard cached processes when clearing website data store
700         https://bugs.webkit.org/show_bug.cgi?id=194894
701
702         Reviewed by Chris Dumez.
703
704         Added a test case.
705
706         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
707         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
708
709 2019-02-21  Alex Christensen  <achristensen@webkit.org>
710
711         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
712         https://bugs.webkit.org/show_bug.cgi?id=194914
713         <rdar://problem/47586889>
714
715         Reviewed by Geoffrey Garen.
716
717         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
718         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
719         (TEST):
720         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
721
722 2019-02-21  David Kilzer  <ddkilzer@apple.com>
723
724         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
725         <https://webkit.org/b/194761>
726
727         Reviewed by Myles Maxfield.
728
729         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
730         (WTR::activateSystemCoreWebFonts): Log `error` to console if
731         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
732         to use ARC-compliant cast.
733         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
734         ARC-compliant cast.
735         (WTR::installFakeHelvetica): Log `error` to console if
736         CTFontManagerRegisterFontsForURL() fails, but only on supported
737         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
738         Call CFRelease() on `error` to fix the leak.  Update to use
739         ARC-compliant cast.
740         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
741         cast.
742
743 2019-02-21  Chris Dumez  <cdumez@apple.com>
744
745         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
746         https://bugs.webkit.org/show_bug.cgi?id=194481
747
748         Reviewed by Alex Christensen.
749
750         Give the processes a chance to shutdown and wait until we reached the expected number
751         of processes.
752
753         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
754
755 2019-02-21  Tim Horton  <timothy_horton@apple.com>
756
757         Fix the macOS build
758
759         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
760
761 2019-02-21  Tim Horton  <timothy_horton@apple.com>
762
763         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
764
765         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
766         I am a backwards.
767
768 2019-02-21  Tim Horton  <timothy_horton@apple.com>
769
770         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
771
772         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
773         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
774         We could force on UI-side compositing, but I feel like the test might be more
775         valuable exercising the normal path on each platform (though the original
776         bug was also UI-side specific). Though we can't validate that the overlay
777         layer was installed successfully, there are layout tests that do that.
778
779 2019-02-21  Tim Horton  <timothy_horton@apple.com>
780
781         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
782         https://bugs.webkit.org/show_bug.cgi?id=194845
783         <rdar://problem/47944579>
784
785         Reviewed by Antti Koivisto.
786
787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
788         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
789
790 2019-02-21  Zalan Bujtas  <zalan@apple.com>
791
792         [LFC][Floats] Add support for placing formatting roots in-between floats.
793         https://bugs.webkit.org/show_bug.cgi?id=194902
794
795         Reviewed by Antti Koivisto.
796
797         * LayoutReloaded/misc/LFC-passing-tests.txt:
798
799 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
800
801         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
802         https://bugs.webkit.org/show_bug.cgi?id=194901
803
804         Unreviewed build fix.
805
806         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
807         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
808         WPEBackend-fdo-0.1 as library name.
809
810 2019-02-21  Rob Buis  <rbuis@igalia.com>
811
812         Update MIME type parser
813         https://bugs.webkit.org/show_bug.cgi?id=180526
814
815         Reviewed by Darin Adler.
816
817         Add tests involving leading and trailing whitespace, non-token
818         characters and quoted strings.
819
820         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
821         (TestWebKitAPI::TEST):
822
823 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
824
825         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
826         https://bugs.webkit.org/show_bug.cgi?id=194884
827
828         Reviewed by Michael Catanzaro.
829
830         * PlatformWin.cmake:
831
832 2019-02-20  Chris Dumez  <cdumez@apple.com>
833
834         Add API test for <rdar://problem/47471222>
835         https://bugs.webkit.org/show_bug.cgi?id=194847
836
837         Reviewed by Alex Christensen.
838
839         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
840
841 2019-02-20  Chris Dumez  <cdumez@apple.com>
842
843         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
844         https://bugs.webkit.org/show_bug.cgi?id=194872
845         <rdar://problem/47924500>
846
847         Reviewed by Alex Christensen.
848
849         Add API test coverage.
850
851         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
852
853 2019-02-20  Jer Noble  <jer.noble@apple.com>
854
855         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
856         https://bugs.webkit.org/show_bug.cgi?id=191332
857
858         Reviewed by Dean Jackson.
859
860         * Scripts/git-is-in-range: Added.
861
862 2019-02-20  Andy Estes  <aestes@apple.com>
863
864         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
865         https://bugs.webkit.org/show_bug.cgi?id=194869
866
867         Rubber-stamped by Jer Noble.
868
869         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
870         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
871         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
872         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
873         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
874         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
875
876 2019-02-20  Chris Dumez  <cdumez@apple.com>
877
878         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
879         https://bugs.webkit.org/show_bug.cgi?id=194857
880         <rdar://problem/47759323>
881
882         Reviewed by Alex Christensen.
883
884         Add API test coverage.
885
886         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
887
888 2019-02-20  Chris Dumez  <cdumez@apple.com>
889
890         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
891         https://bugs.webkit.org/show_bug.cgi?id=194829
892         <rdar://problem/47889906>
893
894         Reviewed by Alexey Proskuryakov.
895
896         Every time the TestOptions were changing we were creating both a new Web view and
897         a new WKContext, which would start a new Network process. In most cases, we only
898         need to contruct a new Web view and we do can keep reusing the same WKContext.
899         This patch implements this optimization and thus avoids spinning a lot of new
900         Network processes while running the layout tests.
901
902         * WebKitTestRunner/TestController.cpp:
903         (WTR::TestController::generateContextConfiguration const):
904         (WTR::TestController::generatePageConfiguration):
905         (WTR::TestController::createWebViewWithOptions):
906         (WTR::TestController::resetPreferencesToConsistentValues):
907         (WTR::updateTestOptionsFromTestHeader):
908         * WebKitTestRunner/TestController.h:
909         * WebKitTestRunner/TestOptions.h:
910         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
911         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
912         (WTR::TestOptions::hasSameInitializationOptions const):
913         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
914         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
915         (WTR::TestController::platformAddTestOptions const):
916
917 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
918
919         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
920         https://bugs.webkit.org/show_bug.cgi?id=167941
921
922         Reviewed by Carlos Garcia Campos.
923
924         * MiniBrowser/gtk/main.c:
925         (filterSavedCallback): Added.
926         (main): Support loading a JSON rule set file for content filtering.
927         * MiniBrowser/wpe/main.cpp:
928         (filterSavedCallback): Added.
929         (main): Support loading a JSON rule set file for content filtering.
930         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
931         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
932         (WTF::derefGPtr): Ditto.
933         (testEmptyStore):
934         (testSaveInvalidFilter):
935         (testSaveLoadFilter):
936         (testSavedFilterIdentifierMatch):
937         (testRemoveFilter):
938         (testSaveMultipleFilters):
939         (testSaveFilterFromFile):
940         (testFilterPersistence):
941         (beforeAll):
942         (afterAll):
943         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
944         (removeOldInjectedContentAndResetLists): Also reset content filters.
945         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
946         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
947         the element affected by the style sheet.
948         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
949         and returns it to be used by tests.
950         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
951         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
952         (serverCallback): Add support for serving a CSS style sheet for testing.
953         (beforeAll): Add call to testUserContentManagerContentFilter().
954         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
955
956 2019-02-19  Keith Rollin  <krollin@apple.com>
957
958         Add timing information to build output
959         https://bugs.webkit.org/show_bug.cgi?id=194839
960         <rdar://problem/48219609>
961
962         Reviewed by Alexey Proskuryakov.
963
964         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
965         emit each project's build time to its output. E.g.,
966
967             ** BUILD SUCCEEDED ** [0.132 sec]
968
969         * Scripts/webkitdirs.pm:
970         (XcodeOptions):
971
972 2019-02-19  Truitt Savell  <tsavell@apple.com>
973
974         Unreviewed, rolling out r241784.
975
976         Broke all OpenSource builds.
977
978         Reverted changeset:
979
980         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
981         instances view"
982         https://bugs.webkit.org/show_bug.cgi?id=172848
983         https://trac.webkit.org/changeset/241784
984
985 2019-02-19  Zalan Bujtas  <zalan@apple.com>
986
987         [LFC][Floats] Remove redundant intersecting logic
988         https://bugs.webkit.org/show_bug.cgi?id=194804
989
990         Reviewed by Antti Koivisto.
991
992         * LayoutReloaded/misc/LFC-passing-tests.txt:
993
994 2019-02-19  Dean Jackson  <dino@apple.com>
995
996         Clean-up output from generate-xcfilelists so it can be filtered
997         https://bugs.webkit.org/show_bug.cgi?id=194795
998
999         Reviewed by Joseph Pecoraro (and Keith Rollin).
1000
1001         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1002         make a slight tweak to filter-build-webkit so such lines are marked
1003         as plain.
1004
1005         * Scripts/filter-build-webkit:
1006         * Scripts/generate-xcfilelists:
1007
1008 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1009
1010         pytest is not correctly auto-installed
1011         https://bugs.webkit.org/show_bug.cgi?id=194707
1012
1013         Reviewed by Carlos Garcia Campos.
1014
1015         * Scripts/webkitpy/thirdparty/__init__.py:
1016         (AutoinstallImportHook._install_pytest):
1017
1018 2019-02-18  Chris Dumez  <cdumez@apple.com>
1019
1020         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1021         https://bugs.webkit.org/show_bug.cgi?id=194797
1022         <rdar://problem/48055151>
1023
1024         Reviewed by Geoffrey Garen.
1025
1026         Add API test coverage.
1027
1028         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1029
1030 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1031
1032         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1033         https://bugs.webkit.org/show_bug.cgi?id=194670
1034         <rdar://problem/39066529>
1035
1036         Reviewed by Tim Horton.
1037
1038         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1039         pasted in an editable area as attachment elements.
1040
1041         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1042         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1043         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1044         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1045         (TestWebKitAPI::TEST):
1046         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1047         (WTR::InjectedBundlePage::InjectedBundlePage):
1048
1049 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1050
1051         Fix API test after r241728
1052        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1053
1054         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1055         (TEST):
1056         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1057
1058 2019-02-18  Daniel Bates  <dabates@apple.com>
1059
1060         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1061         https://bugs.webkit.org/show_bug.cgi?id=192824
1062         <rdar://problem/47100332>
1063
1064         Reviewed by Wenson Hsieh.
1065
1066         Fix a bug where the wrong usage code was used for F13 thru F24.
1067
1068         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1069         (keyCodeForDOMFunctionKey):
1070
1071 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1072
1073         Bytecode cache should a have a boot-specific validation
1074         https://bugs.webkit.org/show_bug.cgi?id=194769
1075         <rdar://problem/48149509>
1076
1077         Reviewed by Keith Miller.
1078
1079         Add test for WTF::bootSessionUUIDString()
1080
1081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1082         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1083         (TEST):
1084
1085 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1086
1087         Disable safe browsing in WKWebView and remove its WKPreferences API
1088         https://bugs.webkit.org/show_bug.cgi?id=194723
1089         <rdar://problem/48122993>
1090
1091         Reviewed by Geoffrey Garen.
1092
1093         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1094         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1095         (TEST):
1096         (safeBrowsingView):
1097         Make tests use SPI instead of API.
1098
1099 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1100
1101         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1102         https://bugs.webkit.org/show_bug.cgi?id=194586
1103
1104         Reviewed by Ross Kirsling.
1105
1106         * DumpRenderTree/win/DumpRenderTree.cpp:
1107         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1108         * Scripts/webkitpy/port/driver.py:
1109         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1110
1111 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1112
1113         Unreviewed, rolling out r241620.
1114
1115         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1116         (Requested by ddkilzer on #webkit.)
1117
1118         Reverted changeset:
1119
1120         "[WTF] Add environment variable helpers"
1121         https://bugs.webkit.org/show_bug.cgi?id=192405
1122         https://trac.webkit.org/changeset/241620
1123
1124 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1125
1126         [LFC] RenderImage's default intrinsic size is 0.
1127         https://bugs.webkit.org/show_bug.cgi?id=194745
1128
1129         Reviewed by Antti Koivisto.
1130
1131         * LayoutReloaded/misc/LFC-passing-tests.txt:
1132
1133 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1134
1135         [LFC][BFC] Add support for block replaced intrinsic width.
1136         https://bugs.webkit.org/show_bug.cgi?id=194705
1137
1138         Reviewed by Simon Fraser.
1139
1140         * LayoutReloaded/misc/LFC-passing-tests.txt:
1141
1142 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1143
1144         [LFC] Apply min/max width constraints to preferred width computation
1145         https://bugs.webkit.org/show_bug.cgi?id=194739
1146
1147         Reviewed by Simon Fraser.
1148
1149         * LayoutReloaded/misc/LFC-passing-tests.txt:
1150
1151 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1152
1153         [WTF] Add environment variable helpers
1154         https://bugs.webkit.org/show_bug.cgi?id=192405
1155
1156         Reviewed by Michael Catanzaro.
1157
1158         * DumpRenderTree/mac/DumpRenderTree.mm:
1159         (libraryPathForDumpRenderTree):
1160         * DumpRenderTree/win/DumpRenderTree.cpp:
1161         (libraryPathForDumpRenderTree):
1162         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1163         (setUpIOSLayoutTestCommunication):
1164         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1165         (beforeAll):
1166         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1167         (main):
1168         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1169         (WebKitTestBus::run):
1170         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1171         (WTR::getOutputDir):
1172         (WTR::initializeFontConfigSetting):
1173         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1174         (WTR::InjectedBundle::platformInitialize):
1175         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1176         (WTR::topLevelPath):
1177         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1178         (WTR::topLevelPath):
1179         (WTR::getOutputDir):
1180         (WTR::activateFonts):
1181         * WebKitTestRunner/TestController.cpp:
1182         (WTR::TestController::libraryPathForTesting):
1183         (WTR::TestController::generateContextConfiguration const):
1184         (WTR::TestController::generatePageConfiguration):
1185         (WTR::TestController::decideDestinationWithSuggestedFilename):
1186         (WTR::TestController::platformAdjustContext):
1187         * WebKitTestRunner/TestController.h:
1188         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1189         (WTR::TestController::cocoaPlatformInitialize):
1190         (WTR::TestController::platformAdjustContext):
1191         * WebKitTestRunner/gtk/main.cpp:
1192         (main):
1193         * WebKitTestRunner/mac/TestControllerMac.mm:
1194         (WTR::TestController::configureContentExtensionForTest):
1195         * WebKitTestRunner/wpe/main.cpp:
1196         (main):
1197         Utilize WTF::Environment where possible.
1198
1199 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1200
1201         [iOS] WKWebView callout bar is missing Change Writing Direction item
1202         https://bugs.webkit.org/show_bug.cgi?id=190015
1203         <rdar://problem/44810366>
1204
1205         Reviewed by Tim Horton.
1206
1207         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1208         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1209
1210         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1211         (TestWebKitAPI::TEST):
1212
1213 2019-02-15  Chris Dumez  <cdumez@apple.com>
1214
1215         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1216         https://bugs.webkit.org/show_bug.cgi?id=194717
1217         <rdar://problem/47884404>
1218
1219         Reviewed by Brady Eidson.
1220
1221         Add API test coverage.
1222
1223         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1224
1225 2019-02-15  Youenn Fablet  <youenn@apple.com>
1226
1227         Make navigator.mediaDevices SecureContext
1228         https://bugs.webkit.org/show_bug.cgi?id=194666
1229
1230         Reviewed by Eric Carlson.
1231
1232         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1233         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1234         (TEST_F):
1235
1236 2019-02-15  Brian Burg  <bburg@apple.com>
1237
1238         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1239         https://bugs.webkit.org/show_bug.cgi?id=194411
1240         <rdar://problem/47787614>
1241
1242         Reviewed by Joseph Pecoraro.
1243
1244         Remove unnecessary soft linking macro usage.
1245
1246         * DumpRenderTree/mac/TestRunnerMac.mm:
1247         (TestRunner::inspectorTestStubURL):
1248         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1249         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1250         (WTR::TestRunner::inspectorTestStubURL):
1251
1252 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1253
1254         Unreviewed, rolling out r241559 and r241566.
1255         https://bugs.webkit.org/show_bug.cgi?id=194710
1256
1257         Causes layout test crashes under GuardMalloc (Requested by
1258         ryanhaddad on #webkit).
1259
1260         Reverted changesets:
1261
1262         "[WTF] Add environment variable helpers"
1263         https://bugs.webkit.org/show_bug.cgi?id=192405
1264         https://trac.webkit.org/changeset/241559
1265
1266         "Unreviewed build fix for WinCairo Debug after r241559."
1267         https://trac.webkit.org/changeset/241566
1268
1269 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1270
1271         [LFC] Out-of-flow box is never a float box
1272         https://bugs.webkit.org/show_bug.cgi?id=194704
1273
1274         Reviewed by Antti Koivisto.
1275
1276         * LayoutReloaded/misc/LFC-passing-tests.txt:
1277
1278 2019-02-10  Darin Adler  <darin@apple.com>
1279
1280         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1281         https://bugs.webkit.org/show_bug.cgi?id=194487
1282
1283         Reviewed by Daniel Bates.
1284
1285         * DumpRenderTree/win/DumpRenderTree.cpp:
1286         (applicationId): Use makeString instead of String::format.
1287         (main): Ditto.
1288         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1289         (TestWebKitAPI::Util::createURLForResource): Ditto.
1290         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1291         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1292
1293         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1294         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1295         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1296         (WTR::createStringWithAttributes): Use appendLiteral.
1297         (WTR::AccessibilityUIElement::helpText const): Ditto.
1298         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1299         directly instead of using String::format.
1300         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1301         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1302
1303 2019-02-15  Truitt Savell  <tsavell@apple.com>
1304
1305         Unreviewed, rolling out r241564.
1306
1307         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1308
1309         Reverted changeset:
1310
1311         "[Mac] WebInspectorUI.framework does not need to be soft-
1312         linked anymore"
1313         https://bugs.webkit.org/show_bug.cgi?id=194411
1314         https://trac.webkit.org/changeset/241564
1315
1316 2019-02-15  Saam barati  <sbarati@apple.com>
1317
1318         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1319         https://bugs.webkit.org/show_bug.cgi?id=194036
1320
1321         Reviewed by Yusuke Suzuki.
1322
1323         * Scripts/run-jsc-stress-tests:
1324
1325 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1326
1327         Fix the build.
1328
1329         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1330         (WTR::UIScriptController::drawSquareInEditableImage):
1331         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1332         (TestWebKitAPI::drawSquareInEditableImage):
1333
1334 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1335
1336         Fix the build.
1337
1338         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1339         (WTR::UIScriptController::drawSquareInEditableImage):
1340         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1341         (TestWebKitAPI::drawSquareInEditableImage):
1342
1343 2019-02-14  Brian Burg  <bburg@apple.com>
1344
1345         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1346         https://bugs.webkit.org/show_bug.cgi?id=194411
1347         <rdar://problem/47787614>
1348
1349         Reviewed by Joseph Pecoraro.
1350
1351         Remove unnecessary soft linking macro usage.
1352
1353         * DumpRenderTree/mac/TestRunnerMac.mm:
1354         (TestRunner::inspectorTestStubURL):
1355         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1356         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1357         (WTR::TestRunner::inspectorTestStubURL):
1358
1359 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1360
1361         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1362         https://bugs.webkit.org/show_bug.cgi?id=194599
1363
1364         Reviewed by Lucas Forschler.
1365
1366         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1367         (StatusBubble._build_bubble):
1368
1369 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1370
1371         [ews-app] Set Foreign Key in Django build model
1372         https://bugs.webkit.org/show_bug.cgi?id=194667
1373
1374         Reviewed by Lucas Forschler.
1375
1376         * BuildSlaveSupport/ews-app/ews/models/build.py:
1377         (Build):
1378
1379 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1380
1381         [WTF] Add environment variable helpers
1382         https://bugs.webkit.org/show_bug.cgi?id=192405
1383
1384         Reviewed by Michael Catanzaro.
1385
1386         * DumpRenderTree/mac/DumpRenderTree.mm:
1387         (libraryPathForDumpRenderTree):
1388         * DumpRenderTree/win/DumpRenderTree.cpp:
1389         (libraryPathForDumpRenderTree):
1390         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1391         (setUpIOSLayoutTestCommunication):
1392         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1393         (TestWebKitAPI::strip):
1394         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1395         (beforeAll):
1396         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1397         (main):
1398         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1399         (WebKitTestBus::run):
1400         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1401         (WTR::getOutputDir):
1402         (WTR::initializeFontConfigSetting):
1403         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1404         (WTR::InjectedBundle::platformInitialize):
1405         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1406         (WTR::topLevelPath):
1407         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1408         (WTR::topLevelPath):
1409         (WTR::getOutputDir):
1410         (WTR::activateFonts):
1411         * WebKitTestRunner/TestController.cpp:
1412         (WTR::TestController::libraryPathForTesting):
1413         (WTR::TestController::generateContextConfiguration const):
1414         (WTR::TestController::generatePageConfiguration):
1415         (WTR::TestController::decideDestinationWithSuggestedFilename):
1416         (WTR::TestController::platformAdjustContext):
1417         * WebKitTestRunner/TestController.h:
1418         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1419         (WTR::TestController::cocoaPlatformInitialize):
1420         (WTR::TestController::platformAdjustContext):
1421         * WebKitTestRunner/gtk/main.cpp:
1422         (main):
1423         * WebKitTestRunner/mac/TestControllerMac.mm:
1424         (WTR::TestController::configureContentExtensionForTest):
1425         * WebKitTestRunner/wpe/main.cpp:
1426         (main):
1427         Utilize WTF::Environment where possible.
1428
1429 2019-02-14  Chris Dumez  <cdumez@apple.com>
1430
1431         [PSON] Introduce a WebContent Process cache
1432         https://bugs.webkit.org/show_bug.cgi?id=194594
1433         <rdar://problem/46793397>
1434
1435         Reviewed by Geoff Garen.
1436
1437         Update API tests to turn on the WebContent Process cache.
1438
1439         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1440
1441 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1442
1443         Unreviewed, build fix after r241480
1444
1445         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1446         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1447         (-[DragAndDropSimulator initWithWebView:]):
1448
1449 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1450
1451         AX: ARIA Reflection was disabled in error
1452         https://bugs.webkit.org/show_bug.cgi?id=194647
1453         <rdar://problem/48068336>
1454
1455         Reviewed by Ryosuke Niwa.
1456
1457         Remove test override now that this feature should be enabled by default.
1458
1459         * WebKitTestRunner/TestController.cpp:
1460         (WTR::TestController::resetPreferencesToConsistentValues):
1461
1462 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1463
1464         Unreviewed, rolling out r241486.
1465         https://bugs.webkit.org/show_bug.cgi?id=194655
1466
1467         causing API failures in builds (Requested by ShawnRoberts on
1468         #webkit).
1469
1470         Reverted changeset:
1471
1472         "[Cocoa] Media elements will restart network buffering just
1473         before suspending"
1474         https://bugs.webkit.org/show_bug.cgi?id=193691
1475         https://trac.webkit.org/changeset/241486
1476
1477 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1478
1479         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1480         https://bugs.webkit.org/show_bug.cgi?id=194622
1481
1482         Reviewed by Antti Koivisto.
1483
1484         * LayoutReloaded/misc/LFC-passing-tests.txt:
1485
1486 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1487
1488         [LFC] Shrink-to-fit-width should be constrained by min/max width
1489         https://bugs.webkit.org/show_bug.cgi?id=194653
1490
1491         Reviewed by Antti Koivisto.
1492
1493         * LayoutReloaded/misc/LFC-passing-tests.txt:
1494
1495 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1496
1497         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1498         https://bugs.webkit.org/show_bug.cgi?id=194641
1499
1500         Reviewed by Geoffrey Garen.
1501
1502         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1503         so that the test would fail without this fix.
1504
1505         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1506         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1507
1508 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1509
1510         [ews-app] Change log level for a log statement
1511
1512         Unreviewed minor fix.
1513
1514         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1515         (Patch.save_patch):
1516
1517 2019-02-13  Jer Noble  <jer.noble@apple.com>
1518
1519         [Cocoa] Media elements will restart network buffering just before suspending
1520         https://bugs.webkit.org/show_bug.cgi?id=193691
1521
1522         Reviewed by Eric Carlson.
1523
1524         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1525         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1526         (TEST):
1527
1528 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1529
1530         [ews-app] Fetch builder id to name mapping
1531         https://bugs.webkit.org/show_bug.cgi?id=194355
1532
1533         Reviewed by Lucas Forschler.
1534
1535         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1536         (Buildbot.get_builder_id_to_name_mapping):
1537         (Buildbot._get_display_name_from_builder_name):
1538
1539 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1540
1541         Further restricting webarchive loads
1542         https://bugs.webkit.org/show_bug.cgi?id=194567
1543         <rdar://problem/47610130>
1544
1545         Reviewed by Youenn Fablet.
1546
1547         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1548         navigations on drop.
1549
1550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1551         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1552         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1553         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1554         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1555         (TestWebKitAPI::TEST):
1556         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1557         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1558         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1559         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1560         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1561         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1562         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1563
1564 2019-02-13  John Wilander  <wilander@apple.com>
1565
1566         Store Ad Click Attribution requests in the network process
1567         https://bugs.webkit.org/show_bug.cgi?id=194510
1568         <rdar://problem/47650118>
1569
1570         Reviewed by Alex Christensen and Daniel Bates.
1571
1572         This patch adds two TestRunner functions:
1573         - dumpAdClickAttribution()
1574         - clearAdClickAttribution()
1575
1576         They call into the network process to dump and clear Ad Click
1577         Attribution state, respectively.
1578
1579         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1580         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1581         (WTR::TestRunner::dumpAdClickAttribution):
1582         (WTR::TestRunner::clearAdClickAttribution):
1583         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1584         * WebKitTestRunner/TestController.cpp:
1585         (WTR::TestController::resetStateToConsistentValues):
1586         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1587         (WTR::adClickAttributionStringResultCallback):
1588         (WTR::TestController::dumpAdClickAttribution):
1589         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1590         (WTR::adClickAttributionVoidCallback):
1591         (WTR::TestController::clearAdClickAttribution):
1592         * WebKitTestRunner/TestController.h:
1593         * WebKitTestRunner/TestInvocation.cpp:
1594         (WTR::TestInvocation::dumpResults):
1595         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1596         (WTR::TestInvocation::dumpAdClickAttribution):
1597         * WebKitTestRunner/TestInvocation.h:
1598
1599 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1600
1601         [ews-app] Generate status-bubble
1602         https://bugs.webkit.org/show_bug.cgi?id=194572
1603
1604         Reviewed by Lucas Forschler.
1605
1606         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1607         (StatusBubble._build_bubble):
1608         (StatusBubble._should_show_bubble_for):
1609         (StatusBubble._build_bubbles_for_patch):
1610
1611 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1612
1613         [ews-app] Add status bubble html template
1614         https://bugs.webkit.org/show_bug.cgi?id=194571
1615
1616         Reviewed by Lucas Forschler.
1617
1618         * BuildSlaveSupport/ews-app/ews/templates: Added.
1619         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1620
1621 2019-02-12  Chris Dumez  <cdumez@apple.com>
1622
1623         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1624         https://bugs.webkit.org/show_bug.cgi?id=194568
1625         <rdar://problem/47944490>
1626
1627         Reviewed by Ryosuke Niwa.
1628
1629         Add API test coverage.
1630
1631         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1632         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1633
1634 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1635
1636         webkitpy: Remove bug_dummy from parsed test expectations
1637         https://bugs.webkit.org/show_bug.cgi?id=194562
1638         <rdar://problem/47853999>
1639
1640         Reviewed by Lucas Forschler.
1641
1642         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1643         (TestExpectationParser):
1644         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1645         skipped tests.
1646         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1647
1648 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1649
1650         [ews-app] Add method to fetch patch
1651         https://bugs.webkit.org/show_bug.cgi?id=194518
1652
1653         Reviewed by Lucas Forschler.
1654
1655         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1656         (Patch.get_patch):
1657
1658 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1659
1660         [LFC] Expand tests coverage (60 new tests -> 860)
1661
1662         Unreviewed test gardening (run-singly, --child-processes=1).
1663
1664         * LayoutReloaded/misc/LFC-passing-tests.txt:
1665
1666 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1667
1668         Allow pages to trigger programmatic paste from script on iOS
1669         https://bugs.webkit.org/show_bug.cgi?id=194271
1670         <rdar://problem/47808810>
1671
1672         Reviewed by Tim Horton.
1673
1674         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1675
1676         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1677         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1678         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1679         (WTR::UIScriptController::rectForMenuAction const):
1680
1681         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1682         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1683         for when the menu is shown or hidden.
1684
1685         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1686         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1687         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1688         (WTR::UIScriptController::setDidShowMenuCallback):
1689         (WTR::UIScriptController::didShowMenuCallback const):
1690         (WTR::UIScriptController::setDidHideMenuCallback):
1691         (WTR::UIScriptController::didHideMenuCallback const):
1692         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1693         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1694         (WTR::UIScriptController::rectForMenuAction const):
1695         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1696         * WebKitTestRunner/TestController.cpp:
1697         (WTR::TestController::resetPreferencesToConsistentValues):
1698         (WTR::updateTestOptionsFromTestHeader):
1699         * WebKitTestRunner/TestOptions.h:
1700
1701         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1702         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1703
1704         (WTR::TestOptions::hasSameInitializationOptions const):
1705         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1706         (WTR::UIScriptController::calendarType const):
1707         (WTR::UIScriptController::platformUndoManager const):
1708         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1709         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1710         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1711         (-[TestRunnerWKWebView dealloc]):
1712         (-[TestRunnerWKWebView _didShowMenu]):
1713         (-[TestRunnerWKWebView _didHideMenu]):
1714
1715         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1716
1717         * WebKitTestRunner/ios/TestControllerIOS.mm:
1718         (WTR::handleMenuWillHideNotification):
1719         (WTR::handleMenuDidHideNotification):
1720         (WTR::TestController::platformInitialize):
1721         (WTR::TestController::platformDestroy):
1722         (WTR::TestController::platformResetStateToConsistentValues):
1723
1724         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1725         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1726
1727         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1728         (WTR::forEachViewInHierarchy):
1729         (WTR::findViewInHierarchyOfType):
1730
1731         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1732         functions that dig through a given view's hierarchy in search of a view of a given class.
1733
1734         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1735         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1736         (WTR::UIScriptController::selectionCaretViewRect const):
1737         (WTR::UIScriptController::selectionRangeViewRects const):
1738         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1739         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1740
1741         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1742
1743         (WTR::UIScriptController::rectForMenuAction const):
1744
1745         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1746         callout bar) whose label matches the given string.
1747
1748         (WTR::UIScriptController::platformContentView const):
1749
1750         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1751         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1752         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1753
1754         (WTR::UIScriptController::platformUndoManager const): Deleted.
1755         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1756         (WTR::UIScriptController::platformContentView const):
1757         (WTR::UIScriptController::platformUndoManager const): Deleted.
1758
1759 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1760
1761         webkitpy: No option to only show unexpected failures in results.html for iPad
1762         https://bugs.webkit.org/show_bug.cgi?id=194554
1763         <rdar://problem/47922442>
1764
1765         Rubber-stamped by Aakash Jain.
1766
1767         Just because a TestExpecations file does not exist for a specific platform does not mean that
1768         TestExpecations are not being used, given that platforms inherit test expectations.
1769
1770         * Scripts/webkitpy/port/base.py:
1771         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1772         * Scripts/webkitpy/port/base_unittest.py:
1773         (PortTest.test_uses_test_expectations_file):
1774
1775 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1776
1777         Remove setDefersLoading infrastructure from WebKit2
1778         https://bugs.webkit.org/show_bug.cgi?id=194506
1779
1780         Reviewed by Brady Eidson.
1781
1782         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1783         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1784         (WTR::TestRunner::setDefersLoading): Deleted.
1785         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1786
1787 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1788
1789         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1790         https://bugs.webkit.org/show_bug.cgi?id=194522
1791         <rdar://problem/47789393>
1792
1793         Reviewed by Chris Dumez.
1794
1795         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1796         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1797         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1798         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1799
1800 2019-02-12  Andy Estes  <aestes@apple.com>
1801
1802         [iOSMac] Enable Parental Controls Content Filtering
1803         https://bugs.webkit.org/show_bug.cgi?id=194521
1804         <rdar://39732376>
1805
1806         Reviewed by Tim Horton.
1807
1808         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1809
1810 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1811
1812         [LFC][IFC] Add intrinsic width support for float boxes.
1813         https://bugs.webkit.org/show_bug.cgi?id=194528
1814
1815         Reviewed by Antti Koivisto.
1816
1817         Expand tests coverage (2 new tests -> 800).
1818         (This is the correct test ordering --runs-singly --child-processes=1)
1819
1820         * LayoutReloaded/misc/LFC-passing-tests.txt:
1821
1822 2019-02-12  Rob Buis  <rbuis@igalia.com>
1823
1824         Implement serializing in MIME type parser
1825         https://bugs.webkit.org/show_bug.cgi?id=193909
1826
1827         Reviewed by Darin Adler.
1828
1829         Add various tests involving upper case, non-ASCII, control/null characters,
1830         various HTTP whitespace, single quotes and an unpaired surrogate.
1831
1832         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1833         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1834         (TestWebKitAPI::serializeIfValid):
1835         (TestWebKitAPI::TEST):
1836
1837 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1838
1839         [Cocoa] Ask platform for generic font family mappings
1840         https://bugs.webkit.org/show_bug.cgi?id=187723
1841         <rdar://problem/41892438>
1842
1843         Reviewed by Brent Fulgham.
1844
1845         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1846
1847         * DumpRenderTree/mac/DumpRenderTree.mm:
1848         (allowedFontFamilySet):
1849         * WebKitTestRunner/mac/TestControllerMac.mm:
1850         (WTR::allowedFontFamilySet):
1851
1852 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1853
1854         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1855         https://bugs.webkit.org/show_bug.cgi?id=193622
1856
1857         Reviewed by Michael Catanzaro.
1858
1859         This adds support for loading content extension rule sets from the JSON files which
1860         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1861         of WKTR for this could be removed, but that is left for a follow-up patch with
1862         cleanups.
1863
1864         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1865         * WebKitTestRunner/TestController.cpp:
1866         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1867         avoid having the null-terminator copied into the result.
1868         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1869         part of the preparations to run a test.
1870         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1871         (WTR::contentExtensionStoreCallback): Added.
1872         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1873         used for content extensions test.
1874         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1875         extensions and compiling the JSON rule set for tests involving content extensions.
1876         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1877         testing and disables content extensions.
1878         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1879         resetContentExtensions().
1880         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1881         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1882         configureContentExtensionForTest(), and userContentController().
1883
1884 2019-02-11  Daniel Bates  <dabates@apple.com>
1885
1886         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1887         https://bugs.webkit.org/show_bug.cgi?id=191446
1888         <rdar://problem/45929460>
1889
1890         Reviewed by Tim Horton.
1891
1892         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1893
1894         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1895         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1896         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1897         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1898         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1899         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1900         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1901         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1902         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1903         (WTR::arrayLength):
1904         (WTR::parseModifierArray):
1905         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1906         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1907         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1908         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1909
1910 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1911
1912         Unreviewed, rolling out r241272 and r241276.
1913         https://bugs.webkit.org/show_bug.cgi?id=194514
1914
1915         Broke the Apple Internal build and the fix requires human
1916         intervention :( (Requested by dydz on #webkit).
1917
1918         Reverted changesets:
1919
1920         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1921         https://bugs.webkit.org/show_bug.cgi?id=191446
1922         https://trac.webkit.org/changeset/241272
1923
1924         "Fix internal iOS build after r241272"
1925         https://bugs.webkit.org/show_bug.cgi?id=191446
1926         https://trac.webkit.org/changeset/241276
1927
1928 2019-02-11  Truitt Savell  <tsavell@apple.com>
1929
1930         Unreviewed, rolling out r241269.
1931
1932         Caused 5 layout tests crashes on Mac WK1
1933
1934         Reverted changeset:
1935
1936         "DumpRenderTree should report unknown options"
1937         https://bugs.webkit.org/show_bug.cgi?id=191303
1938         https://trac.webkit.org/changeset/241269
1939
1940 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1941
1942         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1943         https://bugs.webkit.org/show_bug.cgi?id=194313
1944
1945         Reviewed by Tim Horton.
1946
1947         Add a helper to determine whether the web view is presenting modal UI.
1948
1949         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1950         (WTR::UIScriptController::isPresentingModally const):
1951         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1952         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1953         (WTR::UIScriptController::isPresentingModally const):
1954         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1955         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1956         (WTR::UIScriptController::calendarType const): Deleted.
1957         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1958         (WTR::UIScriptController::isPresentingModally const):
1959         (WTR::UIScriptController::calendarType const):
1960         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1961         (WTR::UIScriptController::calendarType const):
1962
1963 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1964
1965         GCHeapInspector: Show the retained sizes in more places
1966         https://bugs.webkit.org/show_bug.cgi?id=194464
1967
1968         Reviewed by Simon Fraser.
1969
1970         * GCHeapInspector/gc-heap-inspector.html:
1971         * GCHeapInspector/script/interface.js:
1972         (HeapInspectorUtils.humanReadableSize):
1973         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1974         (HeapInspectorUtils.spanForNode.span.span):
1975         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1976         (HeapSnapshotInspector.prototype.buildRoots):
1977
1978 2019-02-11  Daniel Bates  <dabates@apple.com>
1979
1980         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1981         https://bugs.webkit.org/show_bug.cgi?id=191446
1982         <rdar://problem/45929460>
1983
1984         Reviewed by Tim Horton.
1985
1986         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1987
1988         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1989         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1990         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1991         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1992         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1993         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1994         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1995         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1996         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1997         (WTR::arrayLength):
1998         (WTR::parseModifierArray):
1999         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2000         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2001         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2002         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2003
2004 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2005
2006         DumpRenderTree should report unknown options
2007         https://bugs.webkit.org/show_bug.cgi?id=191303
2008
2009         Reviewed by Frédéric Wang.
2010
2011         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2012         to report unknown options.
2013         Added and assigned test options which are currently used in tests.
2014
2015         * DumpRenderTree/TestOptions.cpp:
2016         (TestOptions::TestOptions):
2017
2018 2019-02-11  Truitt Savell  <tsavell@apple.com>
2019
2020         Unreviewed, rolling out r241229.
2021
2022         Revision broke internal builds for watchOS.
2023
2024         Reverted changeset:
2025
2026         "[Cocoa] Ask platform for generic font family mappings"
2027         https://bugs.webkit.org/show_bug.cgi?id=187723
2028         https://trac.webkit.org/changeset/241229
2029
2030 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2031
2032         [WinCairo][MiniBrowser] Basic authentication always fails.
2033         https://bugs.webkit.org/show_bug.cgi?id=194496
2034
2035         Reviewed by Don Olmstead.
2036
2037         * MiniBrowser/win/DialogHelper.h:
2038         (Dialog::getText):
2039
2040 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2041
2042         [GStreamer] GstMappedBuffer testsuite build fails
2043         https://bugs.webkit.org/show_bug.cgi?id=194495
2044
2045         Reviewed by Carlos Garcia Campos.
2046
2047         Fix the build by explicitely adding the gstreamer1.0-audio include
2048         directories to the include path.
2049
2050         * TestWebKitAPI/PlatformGTK.cmake:
2051         * TestWebKitAPI/PlatformWPE.cmake:
2052
2053 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2054
2055         [GTK][WPE] Add enable-javascript-markup setting
2056         https://bugs.webkit.org/show_bug.cgi?id=193439
2057
2058         Reviewed by Michael Catanzaro.
2059
2060         Add test cases to check the new setting.
2061
2062         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2063         (testWebKitSettings):
2064         (testWebKitSettingsJavaScriptMarkup):
2065         (beforeAll):
2066
2067 2019-02-10  Darin Adler  <darin@apple.com>
2068
2069         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2070         https://bugs.webkit.org/show_bug.cgi?id=194485
2071
2072         Reviewed by Daniel Bates.
2073
2074         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2075
2076 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2077
2078         Add more tests for clampTo<>()
2079         https://bugs.webkit.org/show_bug.cgi?id=194462
2080
2081         Reviewed by Geoffrey Garen.
2082
2083         Darin suggested to test the very last floating point number
2084         at the boundaries when truncating to integer.
2085         I added test for max/min and max-1/min-1.
2086
2087         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2088         (TestWebKitAPI::TEST):
2089
2090 2019-02-09  Darin Adler  <darin@apple.com>
2091
2092         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2093         https://bugs.webkit.org/show_bug.cgi?id=194021
2094
2095         Reviewed by Geoffrey Garen.
2096
2097         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2098         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2099         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2100
2101 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2102
2103         [LFC][IFC] Add intrinsic width support for basic inline containers
2104         https://bugs.webkit.org/show_bug.cgi?id=194473
2105
2106         Reviewed by Antti Koivisto.
2107
2108         Expand tests coverage (11 new tests -> 798)
2109
2110         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2111
2112 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2113
2114         Fix MiniBrowser's entitlements
2115         https://bugs.webkit.org/show_bug.cgi?id=192431
2116
2117         Reviewed by Joseph Pecoraro.
2118
2119         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2120         files, making it impossible to load any extension.
2121
2122         * MiniBrowser/MiniBrowser.entitlements:
2123
2124 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2125
2126         [Cocoa] Ask platform for generic font family mappings
2127         https://bugs.webkit.org/show_bug.cgi?id=187723
2128         <rdar://problem/41892438>
2129
2130         Reviewed by Brent Fulgham.
2131
2132         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2133
2134         * DumpRenderTree/mac/DumpRenderTree.mm:
2135         (allowedFontFamilySet):
2136         * WebKitTestRunner/mac/TestControllerMac.mm:
2137         (WTR::allowedFontFamilySet):
2138
2139 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2140
2141         [GTK] Implement back/forward touchpad gesture
2142         https://bugs.webkit.org/show_bug.cgi?id=193919
2143
2144         Reviewed by Michael Catanzaro.
2145
2146         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2147         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2148
2149 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2150
2151         Add SPI to use networking daemon instead of XPC service
2152         https://bugs.webkit.org/show_bug.cgi?id=194427
2153
2154         Reviewed by Geoffrey Garen
2155
2156         * MiniBrowser/MiniBrowser.entitlements:
2157
2158 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2159
2160         [ews-build] Ensure that every builder in config.json has short name
2161         https://bugs.webkit.org/show_bug.cgi?id=194461
2162
2163         Reviewed by Lucas Forschler.
2164
2165         * BuildSlaveSupport/ews-build/loadConfig.py:
2166         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2167
2168 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2169
2170         [ews-build] Add short name to config.json
2171         https://bugs.webkit.org/show_bug.cgi?id=194456
2172
2173         Reviewed by Lucas Forschler.
2174
2175         * BuildSlaveSupport/ews-build/config.json: Added short name.
2176         * BuildSlaveSupport/ews-build/loadConfig.py:
2177         (loadBuilderConfig): Set the short name as the builder description.
2178
2179 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2180
2181         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2182         https://bugs.webkit.org/show_bug.cgi?id=194418
2183
2184         Reviewed by Lucas Forschler.
2185
2186         Do not include errors trying when finding crashlogs at the end of
2187         a run-webkit-tests run since we don't process those errors.
2188
2189         * Scripts/webkitpy/port/darwin.py:
2190         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2191         * Scripts/webkitpy/port/ios_device.py:
2192         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2193         * Scripts/webkitpy/port/watch_device.py:
2194         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2195
2196 2019-02-08  Beth Dakin  <bdakin@apple.com>
2197
2198         Add afterScreenUpdates to WKSnapshotConfiguration
2199         https://bugs.webkit.org/show_bug.cgi?id=194362
2200         -and corresponding-
2201         <rdar://problem/40655528> Please add an "after screen updates" property to 
2202         WKSnapshotConfiguration (to solve blank snapshots)
2203
2204         Reviewed by Tim Horton.
2205
2206         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2207         (TEST):
2208
2209 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2210
2211         clampTo(): do not convert the input to double when dealing with integers
2212         https://bugs.webkit.org/show_bug.cgi?id=194263
2213         <rdar://problem/47692312>
2214
2215         Reviewed by Darin Adler.
2216
2217         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2218         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2219         (TestWebKitAPI::testClampFloatingPointToInteger):
2220         (TestWebKitAPI::testClampSameSignIntegers):
2221         (TestWebKitAPI::testClampUnsignedToSigned):
2222         (TestWebKitAPI::testClampSignedToUnsigned):
2223
2224 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2225
2226         webkitpy: Respect --dedicated-simulators flag
2227         https://bugs.webkit.org/show_bug.cgi?id=194416
2228         <rdar://problem/47894722>
2229
2230         Reviewed by Lucas Forschler.
2231
2232         * Scripts/webkitpy/port/device_port.py:
2233         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2234         available devices can be safely ignored.
2235
2236 2019-02-07  Keith Rollin  <krollin@apple.com>
2237
2238         Remove extra copy of 100x100-red.tga
2239         https://bugs.webkit.org/show_bug.cgi?id=194371
2240         <rdar://problem/47873465>
2241
2242         Reviewed by Said Abou-Hallawa.
2243
2244         In order to help it pass its tests, Bug 194190 added a second copy of
2245         the file 100x100-red.tga. However, it turns out that this additional
2246         file wasn't actually needed, and that that sole previous copy was
2247         sufficient. At the same time, this second copy -- which was copied to
2248         the same location in the build output as the first copy -- now caused
2249         XCBuild to complain because there were two production rules for the
2250         same output file. Address this by removing the newly-added extra copy.
2251
2252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2253         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2254
2255 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2256
2257         Deprecate WKBundlePageSetDefersLoading
2258         https://bugs.webkit.org/show_bug.cgi?id=191394
2259
2260         Reviewed by Dean Jackson.
2261
2262         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2263         (WTR::TestRunner::setDefersLoading):
2264
2265 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2266
2267         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2268         https://bugs.webkit.org/show_bug.cgi?id=194391
2269
2270         Reviewed by Antti Koivisto.
2271
2272         * LayoutReloaded/misc/LFC-passing-tests.txt:
2273
2274 2019-02-06  Keith Rollin  <krollin@apple.com>
2275
2276         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2277         https://bugs.webkit.org/show_bug.cgi?id=193975
2278         <rdar://problem/47643306>
2279
2280         Reviewed by Tim Horton.
2281
2282         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2283         the Info.plist file into the bundle. This step is not necessary as the
2284         implicit "bundle up all the build products into a framework" build
2285         phase does this already. Having the Copy Bundle Resources phase do
2286         this causes a conflict under XCBuild, which objects to two build
2287         phases producing the same file (Info.plist). Address this by removing
2288         Info.plist from the Copy Bundle Resources phase.
2289
2290         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2291
2292 2019-02-06  Keith Rollin  <krollin@apple.com>
2293
2294         Really enable the automatic checking and regenerations of .xcfilelists during builds
2295         https://bugs.webkit.org/show_bug.cgi?id=194357
2296         <rdar://problem/47861231>
2297
2298         Reviewed by Chris Dumez.
2299
2300         Bug 194124 was supposed to enable the automatic checking and
2301         regenerating of .xcfilelist files during the build. While related
2302         changes were included in that patch, the change to actually enable the
2303         operation somehow was omitted. This patch actually enables the
2304         operation. The check-xcfilelist.sh scripts now check
2305         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2306         from the checking.
2307
2308         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2309         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2310
2311 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2312
2313         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2314         <https://webkit.org/b/194286>
2315         <rdar://problem/47815558>
2316
2317         Reviewed by Alexey Proskuryakov.
2318
2319         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2320         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2321         WKRetainPtr<> to avoid leaking the WKDataRef.
2322
2323 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2324
2325         Unreviewed, fix a typo
2326
2327         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2328
2329 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2330
2331         [GTK][WPE] force libpsl build to use ICU in jhbuild
2332         https://bugs.webkit.org/show_bug.cgi?id=194288
2333
2334         Reviewed by Carlos Garcia Campos.
2335
2336         * gtk/jhbuild.modules:
2337         Require ICU for libpsl build in jhbuild, like done in WPE.
2338
2339 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2340
2341         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2342         https://bugs.webkit.org/show_bug.cgi?id=194209
2343
2344         Reviewed by Carlos Garcia Campos.
2345
2346         Enhance TestCookieManager to ensure this doesn't happen again.
2347
2348         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2349         (testCookieManagerPersistentStorage):
2350         (beforeAll):
2351
2352 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2353
2354         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2355         https://bugs.webkit.org/show_bug.cgi?id=194324
2356
2357         Reviewed by Andy Estes.
2358
2359         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2360         part of the name is already implicit, since this is in testing code in TestOptions.
2361
2362         * WebKitTestRunner/TestController.cpp:
2363         (WTR::TestController::generateContextConfiguration const):
2364         (WTR::updateTestOptionsFromTestHeader):
2365         * WebKitTestRunner/TestOptions.h:
2366         (WTR::TestOptions::hasSameInitializationOptions const):
2367
2368 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2369
2370         [ews-build] Allow * as platform for builders and workers
2371         https://bugs.webkit.org/show_bug.cgi?id=188533
2372
2373         Reviewed by Lucas Forschler.
2374
2375         * BuildSlaveSupport/ews-build/loadConfig.py:
2376         (checkWorkersAndBuildersForConsistency):
2377
2378 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2379
2380         [ews-build] Add few bots to config.json
2381         https://bugs.webkit.org/show_bug.cgi?id=194304
2382
2383         Reviewed by Lucas Forschler.
2384
2385         * BuildSlaveSupport/ews-build/config.json:
2386
2387 2019-02-05  Keith Rollin  <krollin@apple.com>
2388
2389         Enable the automatic checking and regenerations of .xcfilelists during builds
2390         https://bugs.webkit.org/show_bug.cgi?id=194124
2391         <rdar://problem/47721277>
2392
2393         Reviewed by Tim Horton.
2394
2395         Bug 193790 add a facility for checking -- during build time -- that
2396         any needed .xcfilelist files are up-to-date and for updating them if
2397         they are not. This facility was initially opt-in by setting
2398         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2399         the process seemed robust. Its now time to enable this facility and
2400         make it opt-out. If there is a need to disable this facility, set and
2401         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2402         running `make` or `build-webkit`, or before running Xcode from the
2403         command line.
2404
2405         Additionally, remove the step that generates a list of source files
2406         going into the UnifiedSources build step. It's only necessarily to
2407         specify Sources.txt and SourcesCocoa.txt as inputs.
2408
2409         * Scripts/generate-xcfilelists:
2410
2411 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2412
2413         [GTK][WPE] force libpsl build to use ICU in jhbuild
2414         https://bugs.webkit.org/show_bug.cgi?id=194288
2415
2416         Reviewed by Philippe Normand.
2417
2418         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2419         This can cause build failures if libidn is detected but libunistring is not available.
2420
2421         Make sure that ICU is used for runtime and builtin PSL data.
2422
2423         * gtk/jhbuild.modules:
2424         * wpe/jhbuild.modules:
2425
2426 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2427
2428         [ews-app] Modified timestamp should be updated on updating data
2429         https://bugs.webkit.org/show_bug.cgi?id=194295
2430
2431         Reviewed by Lucas Forschler.
2432
2433         * BuildSlaveSupport/ews-app/ews/models/build.py:
2434         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2435         * BuildSlaveSupport/ews-app/ews/models/step.py:
2436
2437 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2438
2439         Unreviewed, rolling out r240742.
2440
2441         Causes crashes on iOS simulator.
2442
2443         Reverted changeset:
2444
2445         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2446         not focused in a content-editable element"
2447         https://bugs.webkit.org/show_bug.cgi?id=192824
2448         https://trac.webkit.org/changeset/240742
2449
2450 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2451
2452         run-webkit-tests emits message "...running None" when running tests
2453         https://bugs.webkit.org/show_bug.cgi?id=194133
2454         <rdar://problem/47724738>
2455
2456         Reviewed by Lucas Forschler.
2457
2458         * Scripts/webkitpy/xcode/device_type.py:
2459         (DeviceType.__str__): Use both version mapping tables and use just the variant
2460         name if no version name is available.
2461         * Scripts/webkitpy/xcode/device_type_unittest.py:
2462         (DeviceTypeTest):
2463         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2464         an associated named.
2465
2466 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2467
2468         [WPE] require python3-setuptools for meson build in jhbuild
2469         https://bugs.webkit.org/show_bug.cgi?id=194287
2470
2471         Reviewed by Philippe Normand.
2472
2473         python3-setuptools is needed to build meson in jhbuild.
2474         It is already required by the GTK port.
2475
2476         * wpe/install-dependencies:
2477
2478 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2479
2480         [ews-app] Add method to save BuilderMapping to database
2481         https://bugs.webkit.org/show_bug.cgi?id=194264
2482
2483         Reviewed by Lucas Forschler.
2484
2485         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2486         (BuilderMapping.__str__):
2487         (BuilderMapping):
2488         (BuilderMapping.save_mapping):
2489         (BuilderMapping.update_mapping):
2490         (BuilderMapping.get_existing_mapping):
2491         (BuilderMapping.is_valid_mapping):
2492
2493 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2494
2495         [ews-app] Add timestamp fields for BuilderMappings
2496         https://bugs.webkit.org/show_bug.cgi?id=194266
2497
2498         Reviewed by Lucas Forschler.
2499
2500         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2501         (BuilderMapping):
2502
2503 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2504
2505         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2506         https://bugs.webkit.org/show_bug.cgi?id=174816
2507
2508         Reviewed by Michael Catanzaro.
2509
2510         Add tests for webkit_uri_for_display().
2511
2512         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2513         (testURIForDisplayUnaffected):
2514         (testURIForDisplayAffected):
2515         (beforeAll):
2516         (afterAll):
2517         * TestWebKitAPI/glib/CMakeLists.txt:
2518
2519 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2520
2521         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2522         https://bugs.webkit.org/show_bug.cgi?id=194158
2523         <rdar://problem/47737268>
2524
2525         Rubber-stamped by Aakash Jain.
2526
2527         * Scripts/webkitpy/port/device_port.py:
2528         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2529
2530 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2531
2532         [CG] Enable setAdditionalSupportedImageTypes for WK1
2533         https://bugs.webkit.org/show_bug.cgi?id=194190
2534
2535         Reviewed by Tim Horton.
2536
2537         Add a test similar to the one under WebKit Cocoa but make it create a
2538         WebView instead of a WKWebView.
2539
2540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2541         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2542         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2543         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2544         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2545         (TestWebKitAPI::runTest):
2546         (TestWebKitAPI::TEST):
2547
2548 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2549
2550         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2551         https://bugs.webkit.org/show_bug.cgi?id=194168
2552
2553         Reviewed by Simon Fraser.
2554
2555         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2556
2557         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2558         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2559         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2560         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2561         (TEST):
2562         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2563         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2564
2565 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2566
2567         REGRESSION (r237269): webkit-patch what-broke is broken 
2568         https://bugs.webkit.org/show_bug.cgi?id=193025
2569
2570         Reviewed by Aakash Jain.
2571
2572         * Scripts/webkitpy/common/host.py:
2573         (Host.buildbot):
2574         (Host.bugzilla): Renamed to 'buildbot'.
2575
2576 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2577
2578         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2579         https://bugs.webkit.org/show_bug.cgi?id=194207
2580
2581         Reviewed by Tim Horton.
2582
2583         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2584         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2585         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2586         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2587         start and delete forwards to remove the original attachment.
2588
2589         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2590         (TestWebKitAPI::TEST):
2591
2592 2019-02-04  Youenn Fablet  <youenn@apple.com>
2593
2594         Capture state should be managed consistently when doing process swapping
2595         https://bugs.webkit.org/show_bug.cgi?id=194122
2596         <rdar://problem/47609293>
2597
2598         Reviewed by Eric Carlson.
2599
2600         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2601         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2602         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2603         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2604         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2605         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2606         (WTR::TestRunner::isDoingMediaCapture const):
2607         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2608         * WebKitTestRunner/TestController.cpp:
2609         (WTR::TestController::isDoingMediaCapture const):
2610         * WebKitTestRunner/TestController.h:
2611         * WebKitTestRunner/TestInvocation.cpp:
2612         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2613         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2614         (WTR::TestController::isDoingMediaCapture const):
2615
2616 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2617
2618         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2619         https://bugs.webkit.org/show_bug.cgi?id=194142
2620
2621         Reviewed by Ross Kirsling.
2622
2623         There three 'separator' variables in TestController.cpp. Renamed
2624         it 'pathSeparator', and unified them.
2625
2626         * WebKitTestRunner/TestController.cpp:
2627         (WTR::TestController::generateContextConfiguration const):
2628         (WTR::createTestURL):
2629         (WTR::TestController::platformAdjustContext):
2630
2631 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2632
2633         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2634         https://bugs.webkit.org/show_bug.cgi?id=194198
2635
2636         Reviewed by Antti Koivisto.
2637
2638         No need to set the banner heights on navigation now, since Page stores them.
2639
2640         * MiniBrowser/mac/WK2BrowserWindowController.m:
2641         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2642
2643 2019-02-03  John Wilander  <wilander@apple.com>
2644
2645         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2646         https://bugs.webkit.org/show_bug.cgi?id=194104
2647         <rdar://problem/47649991>
2648
2649         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2650
2651         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2652         (TestWebKitAPI::TEST):
2653             Changed numeric types from unsigned short to uint32_t.
2654
2655 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2656
2657         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2658         <https://webkit.org/b/194178>
2659         <rdar://problem/47753473>
2660
2661         Reviewed by Alexey Proskuryakov.
2662
2663         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2664         (WTR::uninstallFakeHelvetica): Pass nullptr into
2665         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2666
2667 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2668
2669         [LFC] Initialize ICB's style with fixed width/height.
2670         https://bugs.webkit.org/show_bug.cgi?id=194188
2671
2672         Reviewed by Antti Koivisto.
2673
2674         * LayoutReloaded/misc/LFC-passing-tests.txt:
2675
2676 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2677
2678         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2679         https://bugs.webkit.org/show_bug.cgi?id=194185
2680
2681         Reviewed by Antti Koivisto.
2682
2683         * LayoutReloaded/misc/LFC-passing-tests.txt:
2684
2685 2018-12-16  Darin Adler  <darin@apple.com>
2686
2687         Convert additional String::format clients to alternative approaches
2688         https://bugs.webkit.org/show_bug.cgi?id=192746
2689
2690         Reviewed by Alexey Proskuryakov.
2691
2692         * WebKitTestRunner/TestController.cpp:
2693         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2694         as an intermediate in code that ultimately constructs a WTF::String.
2695         (WTR::userMediaOriginHash): Use makeString.
2696         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2697         (WTR::TestController::didPerformClientRedirect): Ditto.
2698         (WTR::TestController::didPerformServerRedirect): Ditto.
2699         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2700
2701 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2702
2703         [ews-build] Add unit test to verify builder keys
2704         https://bugs.webkit.org/show_bug.cgi?id=194152
2705
2706         Reviewed by Lucas Forschler.
2707
2708         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2709         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2710
2711 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2712
2713         [LFC] Expand tests coverage (12 new tests -> 787)
2714
2715         Unreviewed test gardening.
2716
2717         * LayoutReloaded/misc/LFC-passing-tests.txt:
2718
2719 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2720
2721         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2722         https://bugs.webkit.org/show_bug.cgi?id=194163
2723
2724         Reviewed by Simon Fraser.
2725
2726         775
2727
2728         * LayoutReloaded/misc/LFC-passing-tests.txt:
2729
2730 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2731
2732         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2733         https://bugs.webkit.org/show_bug.cgi?id=194140
2734         <rdar://problem/47728098>
2735
2736         Reviewed by Tim Horton.
2737
2738         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2739         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2740         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2741
2742         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2743         test to induce an IPC deadlock when presenting a modal alert during touch start.
2744
2745         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2746         * WebKitTestRunner/TestController.cpp:
2747         (WTR::runJavaScriptAlert):
2748
2749         Add a client callback function for running JavaScript alerts.
2750
2751         (WTR::TestController::createOtherPage):
2752         (WTR::TestController::generateContextConfiguration const):
2753
2754         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2755         the fix in this patch.
2756
2757         (WTR::TestController::createWebViewWithOptions):
2758
2759         Plumb TestOptions to generateContextConfiguration.
2760
2761         (WTR::TestController::resetPreferencesToConsistentValues):
2762         (WTR::TestController::resetStateToConsistentValues):
2763         (WTR::updateTestOptionsFromTestHeader):
2764         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2765         (WTR::TestController::handleJavaScriptAlert):
2766         * WebKitTestRunner/TestController.h:
2767         * WebKitTestRunner/TestInvocation.cpp:
2768         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2769         * WebKitTestRunner/TestOptions.h:
2770         (WTR::TestOptions::hasSameInitializationOptions const):
2771
2772 2019-02-01  Chris Dumez  <cdumez@apple.com>
2773
2774         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2775         https://bugs.webkit.org/show_bug.cgi?id=193740
2776         <rdar://problem/47527267>
2777
2778         Reviewed by Alex Christensen.
2779
2780         Add API test coverage.
2781
2782         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2783
2784 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2785
2786         [ews-app] Add display name field to BuilderMapping model
2787         https://bugs.webkit.org/show_bug.cgi?id=194153
2788
2789         Reviewed by Lucas Forschler.
2790
2791         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2792         (BuilderMapping):
2793
2794 2019-02-01  Youenn Fablet  <youenn@apple.com>
2795
2796         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2797         https://bugs.webkit.org/show_bug.cgi?id=194155
2798
2799         Reviewed by Eric Carlson.
2800
2801         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2802         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2803         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2804
2805 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2806
2807         [LFC] Adjust replaced element's intrinsic ratio
2808         https://bugs.webkit.org/show_bug.cgi?id=194154
2809
2810         Reviewed by Antti Koivisto.
2811
2812         761
2813
2814         * LayoutReloaded/misc/LFC-passing-tests.txt:
2815
2816 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2817
2818         [WPE] Show test results in minibrowser
2819         https://bugs.webkit.org/show_bug.cgi?id=194150
2820
2821         Reviewed by Žan Doberšek.
2822
2823         * Scripts/webkitpy/port/wpe.py:
2824         (WPEPort.show_results_html_file):
2825
2826 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2827
2828         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2829         https://bugs.webkit.org/show_bug.cgi?id=194151
2830
2831         Reviewed by Žan Doberšek.
2832
2833         ALT + <- go back
2834         ALT + -> go forward
2835
2836         * MiniBrowser/wpe/main.cpp:
2837         (main):
2838
2839 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2840
2841         [LFC] Set intrinsic size on Layout::Replaced
2842         https://bugs.webkit.org/show_bug.cgi?id=194139
2843
2844         Reviewed by Antti Koivisto.
2845
2846         744
2847
2848         * LayoutReloaded/misc/LFC-passing-tests.txt:
2849
2850 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2851
2852         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2853         https://bugs.webkit.org/show_bug.cgi?id=194146
2854
2855         Reviewed by Xabier Rodriguez-Calvar.
2856
2857         It allows to open relative paths.
2858
2859         * MiniBrowser/wpe/main.cpp:
2860         (main):
2861
2862 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2863
2864         Update flakiness dashboard configuration after recent queue changes
2865         https://bugs.webkit.org/show_bug.cgi?id=194127
2866
2867         Rubber-stamped by Aakash Jain.
2868
2869         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2870
2871         * TestResultServer/static-dashboards/builders.jsonp:
2872
2873 2019-01-31  Youenn Fablet  <youenn@apple.com>
2874
2875         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2876         https://bugs.webkit.org/show_bug.cgi?id=194106
2877         <rdar://problem/47676333>
2878
2879         Reviewed by Ryosuke Niwa.
2880
2881         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2882         (TestWebKitAPI::didFinishNavigation):
2883         (TestWebKitAPI::TEST):
2884         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2885
2886 2019-01-31  Chris Dumez  <cdumez@apple.com>
2887
2888         Page zoom level is lost after a process swap or a crash
2889         https://bugs.webkit.org/show_bug.cgi?id=194105
2890         <rdar://problem/47610781>
2891
2892         Reviewed by Alex Christensen.
2893
2894         Add API test coverage.
2895
2896         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2897         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2898
2899 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2900
2901         Revert r238819 which is unneeded and caused a performance regression.
2902         https://bugs.webkit.org/show_bug.cgi?id=192272
2903         <rdar://problem/46664625>
2904
2905         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2906         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2907         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2908
2909 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2910
2911         Formalize WebKitAdditions mechanism of LoadOptimizer
2912         https://bugs.webkit.org/show_bug.cgi?id=193886
2913         <rdar://problem/47696809>
2914
2915         Reviewed by Brent Fulgham.
2916
2917         * MiniBrowser/MiniBrowser.entitlements:
2918         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2919
2920 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2921
2922         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2923         https://bugs.webkit.org/show_bug.cgi?id=194090
2924
2925         Reviewed by Antti Koivisto.
2926
2927         * LayoutReloaded/misc/LFC-passing-tests.txt:
2928
2929 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2930
2931         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2932         https://bugs.webkit.org/show_bug.cgi?id=194074
2933
2934         Reviewed by Antti Koivisto.
2935
2936         * LayoutReloaded/misc/LFC-passing-tests.txt:
2937
2938 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2939
2940         [LFC][BFC] Add support for block level replaced box.
2941         https://bugs.webkit.org/show_bug.cgi?id=194071
2942
2943         Reviewed by Antti Koivisto.
2944
2945         * LayoutReloaded/misc/LFC-passing-tests.txt:
2946
2947 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2948
2949         Fix WebKitTestRunner's testPath with Windows full paths
2950         https://bugs.webkit.org/show_bug.cgi?id=194012
2951
2952         Reviewed by Alex Christensen.
2953
2954         updateTestOptionsFromTestHeader failed to open test files because
2955         testPath returned wrong file paths. It returned a path "/C:/..."
2956         if a URL "file:///C:/..." was given.
2957
2958         * WebKitTestRunner/TestController.cpp:
2959         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2960
2961 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2962
2963         [WPE] Bump font related dependencies to match the GTK+ port
2964         https://bugs.webkit.org/show_bug.cgi?id=194017
2965
2966         Reviewed by Žan Doberšek.
2967
2968         * wpe/jhbuild.modules:
2969         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2970         * wpe/patches/icudata-stdlibs.patch: Added.
2971
2972 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2973
2974         Enable swipe tests on iOS
2975         https://bugs.webkit.org/show_bug.cgi?id=194076
2976
2977         Reviewed by Geoffrey Garen.
2978
2979         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2980         it causes a debug assertion failure in runUIScript.
2981
2982         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2983         (WTR::UIScriptController::beginBackSwipe):
2984         (WTR::UIScriptController::completeBackSwipe):
2985
2986 2019-01-30  Keith Rollin  <krollin@apple.com>
2987
2988         Use correct printf format specifier
2989         https://bugs.webkit.org/show_bug.cgi?id=194062
2990         <rdar://problem/47686167>
2991
2992         Reviewed by Alexey Proskuryakov.
2993
2994         LayoutTestSpellChecker.mm is trying to format a variable of type
2995         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2996         actually an unsigned long long. Fix this by formatting with %llu.
2997
2998         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2999         (-[LayoutTestTextCheckingResult description]):
3000
3001 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3002
3003         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3004         https://bugs.webkit.org/show_bug.cgi?id=193979
3005
3006         Reviewed by Wenson Hsieh.
3007
3008         Fix the test for iOS. Make the test work with iOS UA string.
3009
3010         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3011
3012 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3013
3014         Replace High Sierra LLINT CLoop bot due to hardware failure
3015         https://bugs.webkit.org/show_bug.cgi?id=194066
3016
3017         Reviewed by Aakash Jain.
3018
3019         * BuildSlaveSupport/build.webkit.org-config/config.json:
3020
3021 2019-01-30  Keith Rollin  <krollin@apple.com>
3022
3023         [NSDragItem init] is unavailable
3024         https://bugs.webkit.org/show_bug.cgi?id=194059
3025         <rdar://problem/47685715>
3026
3027         Reviewed by Wenson Hsieh.
3028
3029         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3030         DumpRenderTree and TestWebKitAPI, which both try to create an
3031         NSDragItem in a manner that invokes this method. Address this by using
3032         -initWithPasteboardWriter instead.
3033
3034         Note that the parameter passed to initWithPasteboardWriter is likely
3035         incorrect. In both cases, the object passed does not conform to
3036         NSPasteboardWriting. However, with this fix, we're no worse off than
3037         before, and can now perform builds with newer compilers and SDKs until
3038         a real fix can be crafted. That work is tracked in
3039         https://bugs.webkit.org/show_bug.cgi?id=194060
3040
3041         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3042         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3043         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3044         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3045
3046 2019-01-30  Daniel Bates  <dabates@apple.com>
3047
3048         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3049         https://bugs.webkit.org/show_bug.cgi?id=192824
3050         <rdar://problem/47100332>
3051
3052         Reviewed by Wenson Hsieh.
3053
3054         Fix a bug where the wrong usage code was used for F13 thru F24.
3055
3056         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3057         (keyCodeForDOMFunctionKey):
3058
3059 2019-01-30  Chris Dumez  <cdumez@apple.com>
3060
3061         Regression(PSON) Load hang can occur on history navigation
3062         https://bugs.webkit.org/show_bug.cgi?id=194030
3063         <rdar://problem/47656939>
3064
3065         Reviewed by Antti Koivisto.
3066
3067         Add API test coverage.
3068
3069         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3070
3071 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3072
3073         [LFC] Expand tests coverage.
3074
3075         Unreviewed test gardening.
3076
3077         * LayoutReloaded/misc/LFC-passing-tests.txt:
3078
3079 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3080
3081         [Flatpak] Add openjpeg support
3082         https://bugs.webkit.org/show_bug.cgi?id=194019
3083
3084         Reviewed by Michael Catanzaro.
3085
3086         * flatpak/org.webkit.CommonModules.yaml:
3087
3088 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3089
3090         Unreviewed, rolling out r240708.
3091         https://bugs.webkit.org/show_bug.cgi?id=194022
3092
3093         It broke WPE build (Requested by KaL on #webkit).
3094
3095         Reverted changeset:
3096
3097         "[WPE] Bump font related dependencies to match the GTK+ port"
3098         https://bugs.webkit.org/show_bug.cgi?id=194017
3099         https://trac.webkit.org/changeset/240708
3100
3101 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3102
3103         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3104         https://bugs.webkit.org/show_bug.cgi?id=194001
3105
3106         Reviewed by Antti Koivisto.
3107
3108         * LayoutReloaded/misc/LFC-passing-tests.txt:
3109
3110 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3111
3112         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3113         https://bugs.webkit.org/show_bug.cgi?id=194020
3114
3115         Reviewed by Antti Koivisto.
3116
3117         * LayoutReloaded/misc/LFC-passing-tests.txt:
3118
3119 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3120
3121         AX: Support color well on iOS
3122         https://bugs.webkit.org/show_bug.cgi?id=194010
3123
3124         Reviewed by Joanmarie Diggs.
3125
3126         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3127         (WTR::AccessibilityUIElement::stringAttributeValue):
3128
3129 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3130
3131         [WPE] Bump font related dependencies to match the GTK+ port
3132         https://bugs.webkit.org/show_bug.cgi?id=194017
3133
3134         Reviewed by Žan Doberšek.
3135
3136         * wpe/jhbuild.modules:
3137         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3138         * wpe/patches/icudata-stdlibs.patch: Added.
3139
3140 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3141
3142         [Mac] Update window scale API usage
3143         https://bugs.webkit.org/show_bug.cgi?id=193991
3144         rdar://problem/47614795
3145
3146         Reviewed by Tim Horton.
3147
3148         * DumpRenderTree/mac/DumpRenderTree.mm:
3149         (changeWindowScaleIfNeeded):
3150         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3151         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3152         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3153
3154 2019-01-29  Chris Dumez  <cdumez@apple.com>
3155
3156         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3157         https://bugs.webkit.org/show_bug.cgi?id=193977
3158         <rdar://problem/47643716>
3159
3160         Reviewed by Geoff Garen.
3161
3162         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3163         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3164         to the previous provisional committing *before* we make the last load. 
3165
3166         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3167
3168 2019-01-29  Youenn Fablet  <youenn@apple.com>
3169
3170         Adopt new SPI to evaluate server certificate trust
3171         https://bugs.webkit.org/show_bug.cgi?id=193355
3172
3173         Reviewed by Alex Christensen.
3174
3175         Add infrastructure to handle HTTPS server trust evaluation testing.
3176
3177         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3178         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3179         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3180         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3181         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3182         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3183         * WebKitTestRunner/TestController.cpp:
3184         (WTR::TestController::resetPreferencesToConsistentValues):
3185         (WTR::TestController::didReceiveAuthenticationChallenge):
3186         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3187         * WebKitTestRunner/TestController.h:
3188         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3189         * WebKitTestRunner/TestInvocation.cpp:
3190         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3191         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3192         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3193
3194 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3195
3196         [ews-build] Add build step to print bot Configuration
3197         https://bugs.webkit.org/show_bug.cgi?id=193887
3198
3199         Reviewed by Lucas Forschler.
3200
3201         * BuildSlaveSupport/ews-build/steps.py:
3202         (PrintConfiguration): Build step to print configuration.
3203         * BuildSlaveSupport/ews-build/factories.py:
3204
3205 2019-01-29  Chris Dumez  <cdumez@apple.com>
3206
3207         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3208         https://bugs.webkit.org/show_bug.cgi?id=193967
3209         <rdar://problem/47635348>
3210
3211         Reviewed by Alex Christensen.
3212
3213         Add API test coverage.
3214
3215         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3216         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3217
3218 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3219
3220         [ews-app] Handle incoming results data
3221         https://bugs.webkit.org/show_bug.cgi?id=193973
3222
3223         Reviewed by Lucas Forschler.
3224
3225         * BuildSlaveSupport/ews-app/ews/views/results.py:
3226
3227 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3228
3229         [ews-app] Make the results url generic
3230         https://bugs.webkit.org/show_bug.cgi?id=193928
3231
3232         Reviewed by Lucas Forschler.
3233
3234         * BuildSlaveSupport/ews-app/ews/urls.py:
3235
3236 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3237
3238         [ews-build] Configure buildbot to send events to ews-app
3239         https://bugs.webkit.org/show_bug.cgi?id=193968
3240
3241         Reviewed by Lucas Forschler.
3242
3243         * BuildSlaveSupport/ews-build/events.py: Added.
3244         * BuildSlaveSupport/ews-build/master.cfg:
3245
3246 2019-01-29  Keith Rollin  <krollin@apple.com>
3247
3248         Add .xcfilelists to Run Script build phases
3249         https://bugs.webkit.org/show_bug.cgi?id=193792
3250         <rdar://problem/47201785>
3251
3252         Reviewed by Alex Christensen.
3253
3254         As part of supporting XCBuild, update the necessary Run Script build
3255         phases in their Xcode projects to refer to their associated
3256         .xcfilelist files.
3257
3258         Note that the addition of these files bumps the Xcode project version
3259         number to something that's Xcode 10 compatible. This change means that
3260         older versions of the Xcode IDE can't read these projects. Nor can it
3261         fully load workspaces that refer to these projects (the updated
3262         projects are shown as non-expandable placeholders). `xcodebuild` can
3263         still build these projects; it's just that the IDE can't open them.
3264
3265         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3266         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3267
3268 2019-01-29  John Wilander  <wilander@apple.com>
3269
3270         Add data abstraction and validation for Ad Click Attribution
3271         https://bugs.webkit.org/show_bug.cgi?id=193916
3272         <rdar://problem/47603481>
3273
3274         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3275
3276         Ad click attribution has two steps. First, the storage of an ad
3277         campaign ID for a click that takes the user to a destination
3278         site. Second, a conversion on the destination site that can be
3279         attributed to the ad click.
3280
3281         This patch adds a class that represents a request for ad click
3282         attribution. Validation makes sure that the bits of entropy
3283         reported through this mechanism is limited.
3284
3285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3286         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3287         (TestWebKitAPI::TEST):
3288
3289 2019-01-29  Chris Dumez  <cdumez@apple.com>
3290
3291         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3292         https://bugs.webkit.org/show_bug.cgi?id=193932
3293         <rdar://problem/47598947>
3294
3295         Reviewed by Brady Eidson.
3296
3297         Add API test coverage.
3298
3299         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3300
3301 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3302
3303         Adding new passing LFC tests.
3304
3305         Unreviewed test gardening.
3306
3307         * LayoutReloaded/misc/LFC-passing-tests.txt:
3308
3309 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3310
3311         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3312         https://bugs.webkit.org/show_bug.cgi?id=193964
3313
3314         Reviewed by Antti Koivisto.
3315
3316         * LayoutReloaded/misc/LFC-passing-tests.txt:
3317
3318 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3319
3320         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3321         https://bugs.webkit.org/show_bug.cgi?id=193954
3322
3323         Reviewed by Antti Koivisto.
3324
3325         * LayoutReloaded/misc/LFC-passing-tests.txt:
3326
3327 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3328
3329         WebDriver: add support for running subtests
3330         https://bugs.webkit.org/show_bug.cgi?id=193904
3331
3332         Reviewed by Michael Catanzaro.
3333
3334         pytest already supports it by passing test.py::subtest, so we can do the same.
3335
3336         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3337         (get_item_name): Made this global.
3338         (CollectRecorder.__init__): Receive the parameter to ignore.
3339         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3340         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3341         (collect): Add parameter to ignore.
3342         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3343         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3344         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3345         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3346         (WebDriverTestRunnerSelenium.run): Ditto.
3347         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3348         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3349         (WebDriverTestRunnerW3C.run): Ditto.
3350
3351 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3352
3353         User agent string override for navigator.userAgent should be site specific quirks
3354         https://bugs.webkit.org/show_bug.cgi?id=193950
3355
3356         Reviewed by Brent Fulgham.
3357
3358         Updated per the _WKWebsitePolicies rename.
3359
3360         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3361         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3362
3363 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3364
3365         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3366         https://bugs.webkit.org/show_bug.cgi?id=193941
3367
3368         Reviewed by Alex Christensen.
3369
3370         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3371         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3372         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3373         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3374         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3375         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3376         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3377         * TestWebKitAPI/Tests/WTF/Time.cpp:
3378         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3379         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3380         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3381         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3382
3383 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3384
3385         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3386
3387         * Scripts/webkitpy/common/config/contributors.json:
3388
3389 2019-01-28  Andy Estes  <aestes@apple.com>
3390
3391         [watchOS] Enable Parental Controls content filtering
3392         https://bugs.webkit.org/show_bug.cgi?id=193939
3393         <rdar://problem/46641912>
3394
3395         Reviewed by Ryosuke Niwa.
3396
3397         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3398
3399 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3400
3401         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3402         <https://webkit.org/b/193884>
3403
3404         Reviewed by Jiewen Tan.
3405
3406         * Scripts/webkitpy/style/checkers/cpp.py:
3407         (check_language): Add LocalAuthentication to
3408         `frameworks_with_soft_links`.
3409
3410 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3411
3412         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3413         https://bugs.webkit.org/show_bug.cgi?id=193891
3414
3415         Reviewed by Ross Kirsling.
3416
3417         There were three problems in window sizes of WebView and the host window.
3418         1. The sizes of pixel image output were incorrect.
3419         2. The host window is going to appear after window.resize was invoked.
3420         3. window.resize resized only the host window, not WebView.
3421
3422         This change solves them with a following approach.
3423         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3424         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3425            as well as DumpRenderTree in order to match the client area and the window area.
3426         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3427         d. PlatformWebView::setWindowFrame changes both window sizes.
3428         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3429
3430         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3431         (WTR::PlatformWebView::PlatformWebView): Create the host window
3432         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3433         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3434         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3435
3436 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3437
3438         [ews-app] Add method to save Step data to database
3439         https://bugs.webkit.org/show_bug.cgi?id=193890
3440
3441         Reviewed by Lucas Forschler.
3442
3443         * BuildSlaveSupport/ews-app/ews/models/step.py:
3444         (Step.save_step): Method to save step data.
3445         (Step.update_step): Method to update step data.
3446         (Step.get_existing_step): Method to fetch existing step from database.
3447         (Step.is_valid_result): Method to validate valid step result.
3448
3449 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3450
3451         [ews-app] Add method to save Build data to database
3452         https://bugs.webkit.org/show_bug.cgi?id=193735
3453
3454         Reviewed by Lucas Forschler.
3455
3456         * BuildSlaveSupport/ews-app/ews/models/build.py:
3457         (Build.save_build): Method to save build information to database.
3458         (Build.get_existing_build): Method to fetch existing build from database.
3459         (Build.is_valid_result): Method to validate build result.
3460         * BuildSlaveSupport/ews-app/ews/common/util.py:
3461         (is_valid_int_id): Method to validate valid id.
3462
3463 2019-01-28  Chris Dumez  <cdumez@apple.com>
3464
3465         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3466         https://bugs.webkit.org/show_bug.cgi?id=193915
3467         <rdar://problem/47560907>
3468
3469         Reviewed by Alex Christensen.
3470
3471         Add API test coverage.
3472
3473         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3474
3475 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3476
3477         [ews-app] Rename id variables
3478         https://bugs.webkit.org/show_bug.cgi?id=193883
3479
3480         Reviewed by Lucas Forschler.
3481
3482         * BuildSlaveSupport/ews-app/ews/models/build.py:
3483         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3484         * BuildSlaveSupport/ews-app/ews/models/step.py:
3485         * BuildSlaveSupport/ews-app/ews/urls.py:
3486         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3487         * BuildSlaveSupport/ews-app/ews/views/results.py:
3488         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3489
3490 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3491
3492         [ews-app] Allow certain fields to be empty
3493         https://bugs.webkit.org/show_bug.cgi?id=193892
3494
3495         Reviewed by Lucas Forschler.
3496
3497         * BuildSlaveSupport/ews-app/ews/models/build.py:
3498         * BuildSlaveSupport/ews-app/ews/models/step.py:
3499
3500 2019-01-28  Rob Buis  <rbuis@igalia.com>
3501
3502         Update MIME type parser
3503         https://bugs.webkit.org/show_bug.cgi?id=180526
3504
3505         Reviewed by Frédéric Wang.
3506
3507         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3508         (TestWebKitAPI::TEST):
3509
3510 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3511
3512         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3513         https://bugs.webkit.org/show_bug.cgi?id=193896
3514
3515         Reviewed by Antti Koivisto.
3516
3517         * LayoutReloaded/misc/LFC-passing-tests.txt:
3518
3519 2018-12-15  Darin Adler  <darin@apple.com>
3520
3521         Replace many uses of String::format with more type-safe alternatives
3522         https://bugs.webkit.org/show_bug.cgi?id=192742
3523
3524         Reviewed by Mark Lam.
3525
3526         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3527         (WTR::cacheTestRunnerCallback): Use makeString.
3528         * WebKitTestRunner/TestController.cpp:
3529         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3530         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3531
3532 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3533
3534         Use a load optimizer for some sites
3535         https://bugs.webkit.org/show_bug.cgi?id=193881
3536         <rdar://problem/46325455>
3537
3538         Reviewed by Brent Fulgham.
3539
3540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3541         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3542
3543 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3544
3545         AX: Introduce a static accessibility tree
3546         https://bugs.webkit.org/show_bug.cgi?id=193348
3547         <rdar://problem/47203295>
3548
3549         Reviewed by Ryosuke Niwa.
3550
3551         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3552
3553 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3554
3555         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3556         https://bugs.webkit.org/show_bug.cgi?id=193867
3557
3558         Reviewed by Antti Koivisto.
3559
3560         * LayoutReloaded/misc/LFC-passing-tests.txt:
3561
3562 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3563
3564         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3565         https://bugs.webkit.org/show_bug.cgi?id=193865
3566
3567         Reviewed by Antti Koivisto.
3568
3569         * LayoutReloaded/misc/LFC-passing-tests.txt:
3570
3571 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3572
3573         Need a mechanism to override navigator.userAgent
3574         https://bugs.webkit.org/show_bug.cgi?id=193762
3575         <rdar://problem/47504939>
3576
3577         Reviewed by Brent Fulgham.
3578
3579         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3580
3581         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3582         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3583         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3584
3585 2019-01-25  Dean Jackson  <dino@apple.com>
3586
3587         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3588         https://bugs.webkit.org/show_bug.cgi?id=193831
3589         <rdar://problem/47399263>
3590
3591         Reviewed by Chris Dumez.
3592
3593         Two new tests that exercise cross-origin and same-origin System
3594         Previews.
3595
3596         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3597
3598 2019-01-25  Keith Rollin  <krollin@apple.com>
3599
3600         Update Xcode projects with "Check .xcfilelists" build phase
3601         https://bugs.webkit.org/show_bug.cgi?id=193790
3602         <rdar://problem/47201374>
3603
3604         Reviewed by Alex Christensen.
3605
3606         Support for XCBuild includes specifying inputs and outputs to various
3607         Run Script build phases. These inputs and outputs are specified as
3608         .xcfilelist files. Once created, these .xcfilelist files need to be
3609         kept up-to-date. In order to check that they are up-to-date or not,
3610         add an Xcode build step that invokes an external script that performs
3611         the checking. If the .xcfilelists are found to be out-of-date, update
3612         them, halt the build, and instruct the developer to restart the build
3613         with up-to-date files.
3614
3615         At this time, the checking and regenerating is performed only if the
3616         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3617         who want to use this facility can set this variable and test out the
3618         checking/regenerating. Once it seems like there are no egregious
3619         issues that upset a developer's workflow, we'll unconditionally enable
3620         this facility.
3621
3622         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3623         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3624         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3625         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3626
3627 2019-01-25  Keith Rollin  <krollin@apple.com>
3628
3629         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3630         https://bugs.webkit.org/show_bug.cgi?id=193781
3631         <rdar://problem/47201153>
3632
3633         Reviewed by Alex Christensen.
3634
3635         Part of generating the .xcfilelists used as part of adopting XCBuild
3636         includes running `make DerivedSources.make` from a standalone script.
3637         It’s important for this invocation to have the same environment as
3638         when the actual build invokes `make DerivedSources.make`. If the
3639         environments are different, then the two invocations will provide
3640         different results. In order to get the same environment in the
3641         standalone script, have the script launch xcodebuild targeting the
3642         "Apply Configuration to XCFileLists" build target, which will then
3643         re-invoke our standalone script. The script is now running again, this
3644         time in an environment with all workspace, project, target, xcconfig
3645         and other environment variables established.
3646
3647         The "Apply Configuration to XCFileLists" build target accomplishes
3648         this task via a small embedded shell script that consists only of:
3649
3650             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3651
3652         The process that invokes "Apply Configuration to XCFileLists" first
3653         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3654         evaluated and exports it into the shell environment. When xcodebuild
3655         is invoked, it inherits the value of this variable and can `eval` the
3656         contents of that variable. Our external standalone script can then set
3657         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3658         of command-line parameters needed to restart itself in the appropriate
3659         state.
3660
3661         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3662         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3663
3664 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3665
3666         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3667         https://bugs.webkit.org/show_bug.cgi?id=193802
3668         <rdar://problem/46010580>
3669
3670         Reviewed by Andy Estes.
3671
3672         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3673         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3674         (TEST):
3675
3676 2019-01-25  Daniel Bates  <dabates@apple.com>
3677
3678         [iOS] uiController.keyDown() does not translate Control modified key
3679         https://bugs.webkit.org/show_bug.cgi?id=192898
3680
3681         Reviewed by Wenson Hsieh.
3682
3683         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3684         key translation, as applicable. Among other cases, key translation occurs when performing
3685         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3686         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3687         human pressing down and releasing key(s) using a hardware keyboard.
3688
3689         * WebKitTestRunner/ios/HIDEventGenerator.h:
3690         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3691         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3692
3693         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3694         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3695         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3696         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3697         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3698         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3699         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3700         (-[HIDEventGenerator longPress:completionBlock:]):
3701         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3702         Update code for above renaming.
3703
3704         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3705         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3706
3707         (-[HIDEventGenerator keyDown:]): Added.
3708         (-[HIDEventGenerator keyUp:]): Added.
3709         (-[HIDEventGenerator keyPress:completionBlock:]):
3710         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3711         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3712         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3713         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3714         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3715         (WTR::parseModifier): Deleted.
3716
3717 2019-01-25  Keith Rollin  <krollin@apple.com>
3718
3719         Complete the implementation of generate-xcfilelists
3720         https://bugs.webkit.org/show_bug.cgi?id=193782
3721
3722         Reviewed by Alex Christensen.
3723
3724         A preliminary version of generate-xcfilelists was added in r238008.
3725         This patch updates that script in order to:
3726
3727         - Support checking of .xcfilelists
3728         - Perform better execution of `make DerivedSources.make` by
3729           relaunching generate-xcfilelists under xcodebuild
3730         - Support incremental generation and checking of .xcfilelists
3731         - Support supplementary .xcfilelists files from WebKitAdditions
3732         - Support being wrapped by parallel version of generate-xcfilelists in
3733           Internal that adds support for (re)generating WebKit projects in
3734           that repo.
3735         - Support builds that have been performed in WebKitBuild as well as
3736           ~/Library/Developer/code/DerivedData
3737         - Increase robustness and debugging facilities.
3738
3739         * Scripts/generate-xcfilelists:
3740
3741 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3742
3743         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3744         https://bugs.webkit.org/show_bug.cgi?id=193297
3745         <rdar://problem/47158841>
3746
3747         Unreviewed test case fix.
3748
3749         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3750         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3751
3752         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3753         (TEST):
3754
3755 2019-01-25  Keith Rollin  <krollin@apple.com>
3756
3757         Update existing .xcfilelists
3758         https://bugs.webkit.org/show_bug.cgi?id=193791
3759         <rdar://problem/47201706>
3760
3761         Reviewed by Alex Christensen.
3762
3763         Many .xcfilelist files were added in r238824 in order to support
3764         XCBuild. Update these with recent changes to the set of build files
3765         and with the current generate-xcfilelist script.
3766
3767         * DumpRenderTree/DerivedSources-input.xcfilelist:
3768         * DumpRenderTree/DerivedSources-output.xcfilelist:
3769         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3770         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3771
3772 2019-01-25  Keith Rollin  <krollin@apple.com>
3773
3774         Fix missing dependencies in extract-dependencies-from-makefile
3775         https://bugs.webkit.org/show_bug.cgi?id=193783
3776         <rdar://problem/47201571>
3777
3778         Reviewed by Alex Christensen.
3779
3780         The extract-dependencies-from-makefile script generates .xcfilelists
3781         for XCBuild by invoking a makefile in --debug mode, parsing the
3782         dependency information in the output, and extracting information
3783         regarding targets and dependents. However, the way `make` emits this
3784         dependency information is not rigorous, and so we need to determine
3785         what lines to look for and parse by trial and error. This approach
3786         didn't coriginally atch all the information we needed to collect, so
3787         update the script to look for the additional lines we now know to look
3788         for.
3789
3790         * Scripts/extract-dependencies-from-makefile:
3791         (Parser):
3792         (Parser.addTarget):
3793         (Parser.addPrereq):
3794         (Parser.doParse):
3795
3796 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3797
3798         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3799         https://bugs.webkit.org/show_bug.cgi?id=193297
3800         <rdar://problem/47158841>
3801
3802         Reviewed by Alex Christensen.
3803
3804         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3805             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3806         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3807         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3808         activating the message used to trigger the callback when it is set.
3809
3810 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3811
3812         WKWebView.goBack should reload if there is a safe browsing warning
3813         https://bugs.webkit.org/show_bug.cgi?id=193805
3814         <rdar://problem/46908216>
3815
3816         Reviewed by Geoff Garen.
3817
3818         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3819         (+[Simple3LookupContext sharedLookupContext]):
3820         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3821         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3822         (TEST):
3823
3824 2019-01-25  Chris Dumez  <cdumez@apple.com>
3825
3826         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3827         https://bugs.webkit.org/show_bug.cgi?id=193788
3828         <rdar://problem/47531231>
3829
3830         Reviewed by Alex Christensen.
3831
3832         Add API test coverage.
3833
3834         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3835         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3836
3837 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3838
3839         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3840         https://bugs.webkit.org/show_bug.cgi?id=193771
3841
3842         Unreviewed infrastructure fix.
3843
3844         * Scripts/webkitpy/port/darwin.py:
3845         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3846
3847 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3848
3849         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3850
3851 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3852
3853         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3854
3855         * Scripts/webkitpy/common/config/contributors.json:
3856
3857 2019-01-25  Chris Dumez  <cdumez@apple.com>
3858
3859         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3860         https://bugs.webkit.org/show_bug.cgi?id=193779
3861         <rdar://problem/46170903>
3862
3863         Reviewed by Antti Koivisto.
3864
3865         Add API test that quickly navigates forward to a previous process without waiting for it to
3866         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3867         the process' previous page when reconnecting the it for the forward navigation.
3868
3869         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3870
3871 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3872
3873         Need a way for JavaScript (or bundle) code to participate in undo
3874         https://bugs.webkit.org/show_bug.cgi?id=190009
3875         <rdar://problem/44807048>
3876
3877         Reviewed by Ryosuke Niwa.
3878
3879         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3880         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3881
3882         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3883         (WTR::UIScriptController::lastUndoLabel const):
3884         (WTR::UIScriptController::firstRedoLabel const):
3885         (WTR::UIScriptController::platformUndoManager const):
3886         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3887         (WTR::UIScriptController::lastUndoLabel const):
3888         (WTR::UIScriptController::firstRedoLabel const):
3889         (WTR::UIScriptController::platformUndoManager const):
3890         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3891         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3892         (WTR::UIScriptController::lastUndoLabel const):
3893         (WTR::UIScriptController::firstRedoLabel const):
3894         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3895         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3896         (WTR::UIScriptController::lastUndoLabel const):
3897         (WTR::UIScriptController::firstRedoLabel const):
3898         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3899         (WTR::UIScriptController::platformUndoManager const):
3900         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3901         (WTR::UIScriptController::platformUndoManager const):
3902
3903 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3904
3905         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3906         https://bugs.webkit.org/show_bug.cgi?id=193824
3907
3908         Reviewed by Antti Koivisto.
3909
3910         * LayoutReloaded/misc/LFC-passing-tests.txt:
3911
3912 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3913
3914         Update macOS JSC bot configurations
3915         https://bugs.webkit.org/show_bug.cgi?id=193739
3916
3917         Reviewed by Alexey Proskuryakov.
3918
3919         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3920         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3921         (BubbleQueueServer): Move JSC EWS to Mojave section.
3922         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3923         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3924         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3925
3926 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3927
3928         [Win][WebKitTestRunner] Implement EventSenderProxy
3929         https://bugs.webkit.org/show_bug.cgi?id=193755
3930
3931         Reviewed by Don Olmstead.
3932
3933         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3934         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3935         (WTR::EventSenderProxy::dispatchMessage):
3936         (WTR::EventSenderProxy::EventSenderProxy):
3937         (WTR::EventSenderProxy::mouseDown):
3938         (WTR::EventSenderProxy::mouseUp):
3939         (WTR::EventSenderProxy::mouseMoveTo):
3940         (WTR::EventSenderProxy::mouseScrollBy):
3941         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3942
3943 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3944
3945         Unreviewed fix for API test failure after r240437.
3946
3947         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3948
3949         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3950
3951 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3952
3953         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3954         https://bugs.webkit.org/show_bug.cgi?id=193787
3955         <rdar://problem/47497634>
3956
3957         Reviewed by Alexey Proskuryakov.
3958
3959         * Scripts/webkitdirs.pm:
3960         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3961
3962 2019-01-24  Truitt Savell  <tsavell@apple.com>
3963
3964         Unreviewed, rolling out r240446.
3965
3966         Casued 5 API failures
3967
3968         Reverted changeset:
3969
3970         "Activate the WebResourceLoadStatisticsStore in the
3971         NetworkProcess and deactivate it in the UIProcess."
3972         https://bugs.webkit.org/show_bug.cgi?id=193297
3973         https://trac.webkit.org/changeset/240446
3974
3975 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3976
3977         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3978         https://bugs.webkit.org/show_bug.cgi?id=193741
3979         <rdar://problem/47135030>
3980
3981         Reviewed by Antti Koivisto and Simon Fraser.
3982
3983         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3984         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3985         (TestWebKitAPI::TEST):
3986
3987 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3988
3989         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3990         https://bugs.webkit.org/show_bug.cgi?id=193297
3991         <rdar://problem/47158841>
3992
3993         Reviewed by Alex Christensen.
3994
3995         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3996         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3997         activating the message used to trigger the callback when it is set.
3998
3999 2019-01-24  John Wilander  <wilander@apple.com>
4000
4001         Add Ad Click Attribution as an internal/experimental feature
4002         https://bugs.webkit.org/show_bug.cgi?id=193685
4003         <rdar://problem/47450399>
4004
4005         Reviewed by Brent Fulgham.
4006
4007         Added test option adClickAttributionEnabled.
4008
4009         * DumpRenderTree/TestOptions.cpp:
4010         (TestOptions::TestOptions):
4011         * DumpRenderTree/TestOptions.h:
4012         * DumpRenderTree/mac/DumpRenderTree.mm:
4013         (setWebPreferencesForTestOptions):
4014
4015 2019-01-24  Antti Koivisto  <antti@apple.com>
4016
4017         [PSON] Flash on back navigation on Mac
4018         https://bugs.webkit.org/show_bug.cgi?id=193716
4019         <rdar://problem/47148458>
4020
4021         Reviewed by Chris Dumez.
4022
4023         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4024
4025         Closing of the previous page is delayed so waiting for didFinishNavigation is
4026         not sufficient to guarantee we have received all the messages. Wait for them.
4027
4028 2019-01-24  Chris Dumez  <cdumez@apple.com>
4029
4030         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
4031         https://bugs.webkit.org/show_bug.cgi?id=193761
4032         <rdar://problem/47456405>
4033
4034         Reviewed by Alex Christensen.
4035
4036         Add API test coverage.
4037
4038         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4039
4040 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4041
4042         webkitpy: Missing PID in crashlog name should not be fatal
4043         https://bugs.webkit.org/show_bug.cgi?id=193771
4044
4045         If we can't determine the PID of a crashlog, just ignore the crashlog instead
4046         of raising an exception.
4047
4048         Reviewed by Lucas Forschler.
4049
4050         * Scripts/webkitpy/port/darwin.py:
4051         (DarwinPort._merge_crash_logs):
4052
4053 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4054
4055         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
4056         https://bugs.webkit.org/show_bug.cgi?id=193746
4057
4058         Reviewed by Youenn Fablet.
4059
4060         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
4061         so we'd best just not call it.
4062
4063         * Scripts/webkitpy/w3c/test_exporter.py:
4064         (WebPlatformTestExporter.create_branch_with_patch):
4065
4066 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4067
4068         Move FileSystem to WTF
4069         https://bugs.webkit.org/show_bug.cgi?id=193602
4070
4071         Reviewed by Yusuke Suzuki.
4072
4073         * DumpRenderTree/win/DumpRenderTree.cpp:
4074         * TestWebKitAPI/CMakeLists.txt:
4075         * TestWebKitAPI/PlatformGTK.cmake:
4076         * TestWebKitAPI/PlatformJSCOnly.cmake:
4077         * TestWebKitAPI/PlatformPlayStation.cmake:
4078         * TestWebKitAPI/PlatformWPE.cmake:
4079         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4080         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
4081         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
4082         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
4083         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
4084         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
4085         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4086         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4087         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4088         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4089
4090 2019-01-24  Philippe Normand  <pnormand@igalia.com>
4091
4092         [WPE] Remove hard dependency on subprocess32 for the API tests
4093
4094         Rubber-stamped by Carlos Garcia Campos.
4095
4096         * glib/api_test_runner.py:
4097         (TestRunner._run_test_qt): Lazily import subprocess32 and check
4098         its presence only when running WPEQt tests.
4099
4100 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4101
4102         [GLIB] Expose JavaScriptCore options in GLib public API
4103         https://bugs.webkit.org/show_bug.cgi?id=188742
4104
4105         Reviewed by Michael Catanzaro.
4106
4107         Add a test for the new API.
4108
4109         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4110         (testsJSCOptions):
4111         (main):
4112
4113 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4114
4115         [GTK][WPE] Support JPEG 2000 images
4116         https://bugs.webkit.org/show_bug.cgi?id=186272
4117
4118         Reviewed by Žan Doberšek.
4119
4120         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
4121
4122         * gtk/jhbuild.modules:
4123         * wpe/jhbuild.modules:
4124
4125 2019-01-23  David Kilzer  <ddkilzer@apple.com>
4126
4127         check-webkit-style should warn when using soft-linking macros in a header
4128         <https://webkit.org/b/193750>
4129
4130         Reviewed by Darin Adler.
4131
4132         * Scripts/webkitpy/style/checkers/cpp.py:
4133         (check_language): Add softlink/header check by refactoring the
4134         softlink/framework check.
4135         (CppChecker): Enable softlink/header check by default.
4136         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4137         (CppStyleTest.test_softlink_framework): Rename from
4138         CppStyleTest.test_softlink() and change test framework name in
4139         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
4140         files. Set file_name for macros that only appear in headers.
4141         (CppStyleTest.test_softlink_header): Add tests for using
4142         soft-link macros in headers.
4143
4144 2019-01-23  Chris Dumez  <cdumez@apple.com>
4145
4146         Deprecate API to limit the maximum number of WebProcesses
4147         https://bugs.webkit.org/show_bug.cgi?id=193725
4148         <rdar://problem/47464879>
4149
4150         Reviewed by Geoff Garen.
4151
4152         Update existing API tests to stop using deprecated API.
4153
4154         * MiniBrowser/mac/AppDelegate.m:
4155         (defaultConfiguration):
4156         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4157         (TestWebKitAPI::TEST):
4158         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
4159         (TestWebKitAPI::TEST):
4160         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4161         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
4162         (TEST):
4163         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
4164         (TEST):
4165
4166 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4167
4168         [ews-app] Rename ews model buildermappings to buildermapping
4169         https://bugs.webkit.org/show_bug.cgi?id=193729
4170
4171         Reviewed by Lucas Forschler.
4172
4173         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
4174         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
4175         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
4176
4177 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4178
4179         [ews-app] Rename ews model steps to step
4180         https://bugs.webkit.org/show_bug.cgi?id=193697
4181
4182         Reviewed by Lucas Forschler.
4183
4184         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
4185         (Step): Renamed Steps to Step.
4186
4187 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
4188
4189         Clean up IndexedDB files between tests
4190         https://bugs.webkit.org/show_bug.cgi?id=192796
4191         <rdar://problem/46824999>
4192
4193         Reviewed by Geoffrey Garen.
4194
4195         * DumpRenderTree/mac/DumpRenderTree.mm:
4196         (runTest):
4197         * WebKitTestRunner/TestController.cpp:
4198         (WTR::TestController::resetStateToConsistentValues):
4199         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
4200         (WTR::RemoveAllIndexedDatabasesCallback):
4201         (WTR::TestController::ClearIndexedDatabases):
4202         * WebKitTestRunner/TestController.h:
4203         * WebKitTestRunner/TestInvocation.cpp:
4204         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4205
4206 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4207
4208         [ews-app] Rename ews model Builds to Build
4209         https://bugs.webkit.org/show_bug.cgi?id=193695
4210
4211         Reviewed by Lucas Forschler.
4212
4213         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
4214         (Build): Renamed Builds to Build.
4215
4216 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
4217
4218         webkitpy: Wait longer when launching WebKitTestRunner
4219         https://bugs.webkit.org/show_bug.cgi?id=193734
4220
4221         Reviewed by Aakash Jain.
4222
4223         * Scripts/webkitpy/port/simulator_process.py:
4224         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
4225
4226 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
4227
4228         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
4229         https://bugs.webkit.org/show_bug.cgi?id=193182
4230         <rdar://problem/47452154>
4231
4232         Reviewed by Tim Horton.
4233
4234         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
4235         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
4236         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
4237
4238         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
4239         preventing later tests from recognizing gestures.
4240
4241         * WebKitTestRunner/ios/TestControllerIOS.mm:
4242         (WTR::TestController::platformResetStateToConsistentValues):
4243
4244         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
4245
4246 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
4247
4248         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
4249         https://bugs.webkit.org/show_bug.cgi?id=193722
4250         <rdar://problem/47481475>
4251
4252         Reviewed by Lucas Forschler.
4253
4254         iPhone and iPad ports should both use the iOS config.
4255
4256         * Scripts/webkitpy/port/ios_simulator.py:
4257         (IPhoneSimulatorPort.__init__):
4258         (IPadSimulatorPort.__init__):
4259
4260 2019-01-23  Rob Buis  <rbuis@igalia.com>
4261
4262         Update MIME type parser
4263         https://bugs.webkit.org/show_bug.cgi?id=180526
4264
4265         Reviewed by Frédéric Wang.
4266
4267         Add unit tests for both parse modes of ParsedContentType.
4268
4269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4270         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
4271         (TestWebKitAPI::TEST):
4272
4273 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
4274
4275         [ews-app] fetch loop should not stop on network issues
4276         https://bugs.webkit.org/show_bug.cgi?id=193666
4277
4278         Reviewed by Lucas Forschler.
4279
4280         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4281         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
4282
4283 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4284
4285         [iOS] Multiple WKWebViewAutofillTests are flaky failures
4286         https://bugs.webkit.org/show_bug.cgi?id=189165
4287         <rdar://problem/47433765>
4288
4289         Reviewed by Tim Horton.
4290
4291         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
4292         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
4293         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
4294         process in sufficient to ensure that any previous action that blurred the focused element in the web process
4295         would make its way to the UI process by the time the layer tree commit is finished.
4296
4297         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
4298         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
4299         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
4300         will fail because it asks for -_autofillContext too early.
4301
4302         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
4303         is handled in the UI process.
4304
4305         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
4306
4307         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
4308         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
4309         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
4310         input session.
4311
4312         (-[AutofillTestView textInputHasAutofillContext]):
4313
4314         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
4315
4316         * TestWebKitAPI/cocoa/TestWKWebView.h:
4317         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4318         (nextInputSessionChangeCount):
4319
4320         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
4321         This includes changing the focused element from one to another.
4322
4323         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
4324         (-[TestWKWebView didStartFormControlInteraction]):
4325         (-[TestWKWebView didEndFormControlInteraction]):
4326         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
4327
4328         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
4329         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
4330         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
4331         that doesn't require an input session to one that doesn't.
4332
4333 2019-01-22  David Kilzer  <ddkilzer@apple.com>
4334
4335         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
4336         <https://webkit.org/b/193676>
4337
4338         Reviewed by Alexey Proskuryakov.
4339
4340         * Scripts/webkitpy/style/checkers/cpp.py:
4341         (check_member_initialization_list):
4342         - Don't report missing whitespace around colon if the colon at
4343           the start of the line is formatted correctly.
4344         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4345         (WebKitStyleTest.test_member_initialization_list):
4346         - Add a test for a missing permutation of existing tests.
4347         - Add a test this false-positive.
4348         - Add blank lines between subtests to make them easier to read.
4349
4350 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
4351
4352         [build.webkit.org] Unit-test failure after r237113
4353         https://bugs.webkit.org/show_bug.cgi?id=193669
4354
4355         Reviewed by Michael Catanzaro.
4356
4357         * BuildSlaveSupport/build.webkit.org-config/factories.py: