Unreviewed.
[WebKit-https.git] / Tools / ChangeLog
1 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2
3         Unreviewed.
4
5         Added files that have impact in building Streams API to the watchlist.
6
7         * Scripts/webkitpy/common/config/watchlist:
8
9 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
10
11         Unreviewed.
12
13         Added imported tests to Streams API watchlist.
14
15         * Scripts/webkitpy/common/config/watchlist:
16
17 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
18
19         Remove default copy of wpt testharness.js when launching wpt server
20         https://bugs.webkit.org/show_bug.cgi?id=152298
21
22         Reviewed by Darin Adler.
23
24         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
25         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
26
27 2015-12-15  David Kilzer  <ddkilzer@apple.com>
28
29         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
30         <http://webkit.org/b/152314>
31
32         Reviewed by Daniel Bates.
33
34         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
35         code path to exit immediately when calling main().
36         Unfortunately, DumpRenderTreeMain.mm was used for both
37         DumpRenderTree command-line binary and DumpRenderTree.app, which
38         meant that the app would exit immediately with no error code
39         when run!
40
41         The workaround is to introduce a separate source file called
42         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
43         already does.
44
45         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
46         DumpRenderTreeAppMain.mm to the project.  Make it the only
47         compiled source for the DumpRenderTree.app target.
48         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
49         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
50         case someone tries mistakenly to use the app.
51         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
52         Link to JavaScriptCore.framework on iOS for the assert.
53         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
54         Link to JavaScriptCore.framework on OS X for the assert.  Remove
55         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
56         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
57         (main): Add assert for iOS so that a crash occurs if someone
58         tries to run the wrong command.
59
60 2015-12-14  Tim Horton  <timothy_horton@apple.com>
61
62         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
63         https://bugs.webkit.org/show_bug.cgi?id=152266
64         <rdar://problem/22092676>
65
66         Reviewed by Simon Fraser.
67
68         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
69         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
70         Add a test that crashed before this change, and doesn't crash after.
71
72 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
73
74         AX: iOS: Text field variations do not have the correct traits
75         https://bugs.webkit.org/show_bug.cgi?id=152237
76
77         Reviewed by Mario Sanchez Prada.
78
79         Add iOS calls for determing if an object is a search field or a text area.
80
81         * DumpRenderTree/AccessibilityUIElement.cpp:
82         (getIsSearchFieldCallback):
83         (getIsTextAreaCallback):
84         (stringForSelectionCallback):
85         (AccessibilityUIElement::getJSClass):
86         * DumpRenderTree/AccessibilityUIElement.h:
87         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
88         (AccessibilityUIElement::identifier):
89         (AccessibilityUIElement::isTextArea):
90         (AccessibilityUIElement::isSearchField):
91         (AccessibilityUIElement::traits):
92         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
93         (WTR::AccessibilityUIElement::scrollPageRight):
94         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
95         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
96         (WTR::AccessibilityUIElement::isSearchField):
97         (WTR::AccessibilityUIElement::isTextArea):
98         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
99         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
100         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
101         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
102         (WTR::AccessibilityUIElement::isTextArea):
103         (WTR::AccessibilityUIElement::isSearchField):
104         (WTR::AccessibilityUIElement::rowCount):
105
106 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
107
108         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
109         https://bugs.webkit.org/show_bug.cgi?id=152252
110
111         Reviewed by Sergio Villar Senin.
112
113         * gtk/install-dependencies: Add libtool-bin to the list of packages required
114         for building the JHBuild on Debian systems.
115
116 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
117
118         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
119         https://bugs.webkit.org/show_bug.cgi?id=152156
120
121         Reviewed by Dan Bernstein.
122
123         Our frameworks should appropriately prefix all ObjC classes,
124         not just external symbols.
125
126         * Scripts/check-for-inappropriate-objc-class-names:
127         Remove the -g switch to check all ObjC class names.
128
129 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
130
131         [MediaStream] Expose media capture devices persistent permissions to WebCore
132         https://bugs.webkit.org/show_bug.cgi?id=152087
133
134         Add support for the new user media permission checker page UI client method.
135
136         Reviewed by Chris Dumez.
137
138         * WebKitTestRunner/TestController.cpp:
139         (WTR::decidePolicyForUserMediaPermissionRequest):
140         (WTR::checkUserMediaPermissionForOrigin):
141         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
142         (WTR::TestController::createWebViewWithOptions): Ditto.
143         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
144         (WTR::originUserVisibleName): New, create a string for the origin.
145         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
146           according to the state of the origin permission map.
147         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
148           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
149         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
150           origin permission map.
151         * WebKitTestRunner/TestController.h:
152
153 2015-12-10  Alex Christensen  <achristensen@webkit.org>
154
155         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
156         https://bugs.webkit.org/show_bug.cgi?id=152022
157         rdar://problem/23763584
158
159         Reviewed by Darin Adler.
160
161         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
162         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
163         (WTR::InjectedBundlePage::willSendRequestForFrame):
164         * WebKitTestRunner/InjectedBundle/TestRunner.h:
165         (WTR::TestRunner::setWillSendRequestReturnsNull):
166         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
167         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
168         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
169         (WTR::TestRunner::willSendRequestHTTPBody):
170         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
171
172 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
173
174         Remove additional simulator checks before running layout-tests
175         https://bugs.webkit.org/show_bug.cgi?id=152146
176
177         Reviewed by Darin Adler.
178
179         * Scripts/webkitpy/port/ios.py:
180         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
181         * Scripts/webkitpy/xcode/simulator.py:
182         (Simulator._boot_and_shutdown_simulator_device): Deleted.
183         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
184
185 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
186
187         Run atleast one simulator even if max process limit is low
188         https://bugs.webkit.org/show_bug.cgi?id=152081
189         <rdar://problem/23819694>
190
191         Reviewed by Alexey Proskuryakov.
192
193 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
194
195         [GTK] Crash in WebProcess when loading large content with custom URI schemes
196         https://bugs.webkit.org/show_bug.cgi?id=144262
197
198         Reviewed by Carlos Garcia Campos.
199
200         Added new unit test to check the additional scenarios we now
201         handle for custom URI schemes.
202
203         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
204         (generateHTMLContent): New helper function to generate big enough content.
205         (testWebContextURIScheme): New unit test.
206
207 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
208
209         [EFL] Fix unhandled web process message when launching MiniBrowser
210         https://bugs.webkit.org/show_bug.cgi?id=152048
211
212         Reviewed by Gyuyoung Kim.
213
214         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
215         (TestWebKitAPI::TEST):
216
217 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
218
219         [GTK] Add API to handle beforeunload events
220         https://bugs.webkit.org/show_bug.cgi?id=139090
221
222         Reviewed by Gustavo Noronha Silva.
223
224         * MiniBrowser/gtk/BrowserWindow.c:
225         (browserWindowConstructed):
226         (browserWindowDeleteEvent):
227         (browser_window_class_init):
228         Handle delete-event to prevent the window from being closed when
229         the page has beforeunload handlers. Use
230         webkit_web_view_try_close() when the window is requested to be
231         closed.
232         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
233         (testWebViewJavaScriptDialogs):
234         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
235         script dialog type.
236
237 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
238
239         Refactored initialization code in LoadTrackingTest.
240
241         Rubber-stamped by Carlos Garcia Campos.
242
243         Small refactoring to make sure that the state of a LoadTrackingTest
244         gets properly reset before loading new web content.
245
246         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
247         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
248         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
249         functions and reset the remaining local variables.
250         (LoadTrackingTest::loadURI): Call reset();
251         (LoadTrackingTest::loadHtml): Ditto.
252         (LoadTrackingTest::loadPlainText): Ditto.
253         (LoadTrackingTest::loadBytes): Ditto.
254         (LoadTrackingTest::loadRequest): Ditto.
255         (LoadTrackingTest::reload): Ditto.
256         (LoadTrackingTest::goBack): Ditto.
257         (LoadTrackingTest::goForward): Ditto.
258
259 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
260
261         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
262         https://bugs.webkit.org/show_bug.cgi?id=151942
263
264         Reviewed by Darin Adler.
265
266         * MiniBrowser/efl/main.c:
267         (window_create): Enable offline web application cache feature on MiniBrowser.
268         (elm_main):
269
270 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
271
272         https://bugs.webkit.org/show_bug.cgi?id=151243
273         <rdar://problem/22955197>
274
275         Reviewed by Alexey Proskuryakov.
276
277         * LayoutTestRelay/LayoutTestRelay/main.m:
278         (getTestingSimDevice): Use separate testing device for each worker.
279         * Scripts/webkitpy/layout_tests/controllers/manager.py:
280         (Manager.run): Perform cleanup even if setup fails.
281         * Scripts/webkitpy/port/ios.py:
282         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
283         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
284         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
285         (IOSSimulatorPort._quit_ios_simulator): Same
286         (IOSSimulatorPort.clean_up_test_run): Same
287         (IOSSimulatorPort.check_sys_deps): Same
288         (IOSSimulatorPort.testing_device): Same
289         (IOSSimulatorPort.reset_preferences): Same
290         (IOSSimulatorPort.get_simulator_path): Return simulator path.
291         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
292         * Scripts/webkitpy/xcode/simulator.py:
293         (Device.delete): Delete the simulator device.
294         (Simulator.delete_device): Same
295         (Simulator.wait_until_device_is_booted): Wait for device booting.
296
297 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
298
299         [EFL] Add API to provide preferences before creating ewk_view
300         https://bugs.webkit.org/show_bug.cgi?id=151587
301
302         Reviewed by Gyuyoung Kim.
303
304         * MiniBrowser/efl/main.c:
305         (on_key_down):
306         (quit):
307         (window_create):
308         Moved settings related code to configuration() not to update settings
309         whenever ewk_view is created.
310         (configuration):
311         (elm_main):
312
313 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
314
315         Unreviewed. Fix GTK+ API tests after r193639.
316
317         The new jhbuild version needs some more variables ot be present in
318         the builtin dict, even if they are set to None.
319
320         * jhbuild/jhbuildutils.py:
321         (enter_jhbuild_environment_if_available):
322
323 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
324
325         [GTK] Notify WebCore when notification is clicked
326         https://bugs.webkit.org/show_bug.cgi?id=151951
327
328         Reviewed by Carlos Garcia Campos.
329
330         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
331         (testWebViewNotification): test the new API.
332
333 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
334
335         'jhbuild build' should fail immediately when building any module fails
336         https://bugs.webkit.org/show_bug.cgi?id=145697
337
338         Reviewed by Carlos Garcia Campos.
339
340         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
341         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
342         Everything is placed under lib instead of lib64 now.
343         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
344         --exit-on-error when running 'jhbuild build'.
345         * jhbuild/jhbuildrc_common.py:
346         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
347         jhbuild should be able to handle these for us without breaking things....
348
349 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
350
351         Add support to import w3c tests from a repository with a different root that the main repo dir
352         https://bugs.webkit.org/show_bug.cgi?id=151751
353
354         Reviewed by Ryosuke Niwa and Youenn Fablet.
355
356         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
357         in a different directory than the repository root.
358
359         This patch introduces a new parameter tests_directory that we will use as root directory to search for
360         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
361         requires having the copy_path lists including tuples of origin and destination directories.
362
363         * Scripts/webkitpy/w3c/test_downloader.py:
364         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
365         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
366         * Scripts/webkitpy/w3c/test_importer_unittest.py:
367         (TestImporterTest.test_tests_directory): Test.
368
369 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
370
371         Mock TestRepositories in W3C importer tests
372         https://bugs.webkit.org/show_bug.cgi?id=151938
373
374         Reviewed by Youenn Fablet.
375
376         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
377         is because the test repository method reading the file was using the filesystem directly instead of taking the
378         host one. This patch changes that.
379
380         * Scripts/webkitpy/w3c/test_downloader.py:
381         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
382         default one.
383         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
384         * Scripts/webkitpy/w3c/test_importer_unittest.py:
385         (TestImporterTest.test_harnesslinks_conversion):
386         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
387
388 2015-12-07  David Kilzer  <ddkilzer@apple.com>
389
390         TestNetscapePlugIn: Address review comment on 193607
391         <http://webkit.org/b/151881>
392
393         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
394         (testSetStatus): Initializing std::unique_ptr<char[]> with
395         nullptr is redundant.
396
397 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
398
399         [GTK] Add webkit_uri_request_get_http_method
400         https://bugs.webkit.org/show_bug.cgi?id=151601
401
402         Reviewed by Martin Robinson.
403
404         Add test case to check HTTP method of WebKitURIRequest.
405
406         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
407         (testURIRequestHTTPMethod):
408         (serverCallback):
409         (beforeAll):
410         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
411         (sendRequestCallback):
412
413 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
414
415         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
416         https://bugs.webkit.org/show_bug.cgi?id=79918
417
418         Reviewed by Gustavo Noronha Silva.
419
420         Add unit tests to check the different console messages.
421
422         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
423         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
424         (ConsoleMessageTest::ConsoleMessage::operator==):
425         (ConsoleMessageTest::consoleMessageReceivedCallback):
426         (ConsoleMessageTest::ConsoleMessageTest):
427         (ConsoleMessageTest::~ConsoleMessageTest):
428         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
429         (testWebKitConsoleMessageConsoleAPI):
430         (testWebKitConsoleMessageJavaScriptException):
431         (testWebKitConsoleMessageNetworkError):
432         (testWebKitConsoleMessageSecurityError):
433         (beforeAll):
434         (afterAll):
435         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
436         (consoleMessageSentCallback):
437         (pageCreatedCallback):
438
439 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
440
441         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
442         https://bugs.webkit.org/show_bug.cgi?id=151934
443
444         Reviewed by Csaba Osztrogonác.
445
446         * MiniBrowser/efl/main.c:
447         (on_window_deletion): Revert the changes of r192767.
448
449 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
450
451         [GTK] update-webkitgtk-libs cannot build mesa
452         https://bugs.webkit.org/show_bug.cgi?id=151535
453
454         Reviewed by Martin Robinson.
455
456         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
457         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
458         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
459         does not have a stable API and we cannot expect mesa to be buildable unless we control the
460         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
461         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
462
463         * gtk/jhbuild.modules:
464
465 2015-12-07  Philippe Normand  <pnormand@igalia.com>
466
467         [GTK][Mac] libWebExtensionTest link error
468         https://bugs.webkit.org/show_bug.cgi?id=150802
469
470         Reviewed by Carlos Garcia Campos.
471
472         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
473
474 2015-12-06  David Kilzer  <ddkilzer@apple.com>
475
476         TestNetscapePlugIn: Fix leaks found by static analyzer
477         <http://webkit.org/b/151881>
478
479         Reviewed by Darin Adler.
480
481         Fixes the following leaks found by the static analyzer:
482             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
483                     return false;
484                            ^~~~~
485             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
486                     return false;
487                            ^~~~~
488             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
489                     return false;
490                            ^~~~~
491
492         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
493         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
494         early return if allocation fails.
495         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
496         Make sure to call fclose() on filehandle, even for an early
497         return.
498         (testSetStatus): Switch to using std::unique_ptr<char[]>.
499
500 2015-12-05  David Kilzer  <ddkilzer@apple.com>
501
502         prepare-ChangeLog: Fix some warning messages when using svn
503         <http://webkit.org/b/151914>
504
505         Reviewed by Daniel Bates.
506
507         * Scripts/prepare-ChangeLog:
508         (generateFunctionLists): Simplify logic so that we never call
509         normalizePath() with an undefined value.
510         (attributeCommand): Quote $subPath for the shell so that we
511         don't try to run "svn propget" on invalid paths.
512
513 2015-12-04  David Kilzer  <ddkilzer@apple.com>
514
515         TestNetscapePlugIn: Fix remaining static analyzer warnings
516         <http://webkit.org/b/151888>
517
518         Reviewed by Alexey Proskuryakov.
519
520         Fixes the following static analyzer warnings:
521             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
522                     CRASH();
523                     ^~~~~~~
524             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
525                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
526                 ^~~~~~~~~~~~~~~~
527             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
528                 return obj->pluginTest->NPP_SetWindow(window);
529                        ^~~~~~~~~~~~~~~
530             2 warnings generated.
531
532         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
533         (CRASH): Use __builtin_trap() for gcc/clang.
534         (NPP_SetWindow): Add early return if obj is nullptr.
535
536 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
537
538         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
539         https://bugs.webkit.org/show_bug.cgi?id=151797
540
541         Reviewed by Martin Robinson.
542
543         Since we switched to use the network process to run the unit tests
544         the test /webkit2/WebKitWebResource/get-data sometimes fails and
545         sometimes passes. We are now also getting the notification for the
546         css image. Since we wait for 3 resources, sometimes the css image
547         is loaded before and then checkResourceData is called for it, but
548         not handled. When the css image is the last one loaded the test
549         passes. So, we just need to wait for the 4 resources.
550
551         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
552         (testWebResourceGetData):
553
554 2015-12-03  David Kilzer  <ddkilzer@apple.com>
555
556         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
557         <http://webkit.org/b/151845>
558
559         Reviewed by Simon Fraser.
560
561         Fixes the following static analyzer warning:
562             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
563                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
564                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
565
566         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
567         (createBitmapContext): Free 'buffer' after using it in logging
568         to fix the use-after-free.  Assign a value of nullptr to buffer
569         so we don't return with it set to a freed address.
570
571 2015-12-03  Jer Noble  <jer.noble@apple.com>
572
573         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
574         https://bugs.webkit.org/show_bug.cgi?id=151830
575
576         Reviewed by Anders Carlsson.
577
578         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
579
580         * DumpRenderTree/mac/DumpRenderTree.mm:
581         (resetWebPreferencesToConsistentValues):
582         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
583         (WTR::initializeWebViewConfiguration):
584
585 2015-12-03  Anders Carlsson  <andersca@apple.com>
586
587         Remove Objective-C GC support
588         https://bugs.webkit.org/show_bug.cgi?id=151819
589         rdar://problem/23746991
590
591         Reviewed by Dan Bernstein.
592
593         * asan/asan.xcconfig:
594
595 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
596
597         Allow nil for unspecified benchmark pathes
598         https://bugs.webkit.org/show_bug.cgi?id=151784
599
600         Reviewed by Filip Pizlo.
601
602         `Pathname.new(nil)` will raise an error.
603         Only generate Pathname if the benchmark path is specified.
604
605         * Scripts/run-jsc-benchmarks:
606
607 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
608
609         [Win] Run non-http tests without Cygwin
610         https://bugs.webkit.org/show_bug.cgi?id=151721
611
612         Reviewed by Andy Estes.
613
614         Support native 32-bit and 64-bit Python (and Perl) builds
615         for running tests:
616
617         1. Use "startswith('win')", rather than "== 'win32'" to support
618         various Windows build types.
619         2. Supply full path for some native Windows utilities, since the
620         path environment does not always have the specified, and they are
621         guaranteed to exist in those specific locations.
622         3. Make sure native Windows Python test runs pass proper environment
623         variables to run programs.
624         4. Append 'exe' suffix when running Windows executables.
625         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
626         command doesn't exist.
627         
628         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
629         the current Perl executable, rather than requiring a new path search.
630         * Scripts/webkitpy/common/find_files_unittest.py:
631         (TestWinNormalize.test_win): Use startswith('win').
632         * Scripts/webkitpy/common/prettypatch_unittest.py:
633         (test_pretty_diff_encodings): Ditto.
634         * Scripts/webkitpy/common/system/executive.py:
635         (Executive._should_close_fds): Ditto.
636         (Executive.shell_command_for_script): Use startswith('win').
637         (Executive.kill_process): Use full path to killall executable.
638         (Executive.check_running_pid): Use startswith('win').
639         (Executive.running_pids): Ditto.
640         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
641         running under native Windows Python.
642         (Executive._child_process_encoding): Use startswith('win').
643         (Executive._should_encode_child_process_arguments): Ditto.
644         (Executive.popen): Recognize proper script engine on Windows, since it
645         does not support the shebang syntax.
646         (Executive.run_in_parallel): Use startswith('win').
647         * Scripts/webkitpy/common/system/executive_unittest.py:
648         (never_ending_command): Ditto.
649         (ExecutiveTest.test_run_command_with_unicode): Ditto.
650         (ExecutiveTest.serial_test_kill_process): Ditto.
651         (ExecutiveTest.serial_test_kill_all): Ditto.
652         (ExecutiveTest.serial_test_check_running_pid): Ditto.
653         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
654         (main): Ditto.
655         * Scripts/webkitpy/common/system/file_lock.py:
656         (FileLock._create_lock): Ditto.
657         (FileLock._remove_lock): Ditto.
658         * Scripts/webkitpy/common/system/filesystem_unittest.py:
659         (RealFileSystemTest.test_chdir): Ditto.
660         (RealFileSystemTest.test_chdir__notexists): Ditto.
661         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
662         * Scripts/webkitpy/common/system/path_unittest.py:
663         (AbspathTest.test_abspath_to_uri_win): Ditto.
664         * Scripts/webkitpy/common/system/platforminfo.py:
665         (PlatformInfo._determine_os_name): Ditto.
666         * Scripts/webkitpy/common/system/user.py: Ditto.
667         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
668         (ManagerTest.integration_test_needs_servers): Ditto.
669         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
670         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
671         driver letters.
672         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
673         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
674         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
675         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
676         (HttpServerBase._check_that_all_ports_are_available): Ditto.
677         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
678         (TestHttpServer.test_start_cmd): Ditto.
679         * Scripts/webkitpy/port/base.py:
680         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
681         and 'SYSTEMROOT' in environment passed to test runners.
682         (Port._apache_config_file_name_for_platform): Use startswith('win').
683         (Port._build_path): Ditto.
684         (Port._path_to_driver): Include 'exe' suffix when running under native
685         Windows.
686         * Scripts/webkitpy/port/driver.py:
687         (Driver._setup_environ_for_driver): Explicitly make some environment
688         variables strings.
689         * Scripts/webkitpy/port/server_process.py:
690         (ServerProcess.__init__): Use startswith('win').
691         * Scripts/webkitpy/port/win.py:
692         (WinPort): Use the win32 registry utilities on Windows, and appropriate
693         registry key formats.
694         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
695         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
696         and regtool on Cygwin.
697         (WinPort.write_registry_value): Ditto.
698         (WinPort.setup_crash_log_saving): Ditto.
699         (WinPort.restore_crash_log_saving): Ditto.
700         (WinPort.prevent_error_dialogs): Ditto.
701         (WinPort.allow_error_dialogs): Ditto.
702         (WinPort.find_system_pid): Revise to use Windows management
703         infrastructure on native Windows, continue using 'ps' on Cygwin.
704         (WinPort.read_registry_string): Deleted.
705         (WinPort.write_registry_string): Deleted.
706         * Scripts/webkitpy/test/main.py:
707         (main): Use startswith('win').
708         (Tester._parse_args): Ditto.
709
710 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
711
712         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
713         https://bugs.webkit.org/show_bug.cgi?id=150792
714
715         Reviewed by Saam Barati.
716
717         * Scripts/webkitperl/FeatureList.pm:
718
719 2015-12-01  Commit Queue  <commit-queue@webkit.org>
720
721         Unreviewed, rolling out r192914.
722         https://bugs.webkit.org/show_bug.cgi?id=151734
723
724         JSC tests for this change are failing on 32 and 64-bit bots
725         (Requested by ryanhaddad on #webkit).
726
727         Reverted changeset:
728
729         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
730         enable this feature"
731         https://bugs.webkit.org/show_bug.cgi?id=150792
732         http://trac.webkit.org/changeset/192914
733
734 2015-12-01  David Kilzer  <ddkilzer@apple.com>
735
736         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
737         <http://webkit.org/b/151726>
738
739         Reviewed by Simon Fraser.
740
741         * WebKitTestRunner/mac/EventSenderProxy.mm:
742         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
743         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
744
745 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
746
747         Give String and AtomicString an existingHash() function
748         https://bugs.webkit.org/show_bug.cgi?id=151717
749
750         Reviewed by Andreas Kling.
751
752         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
753         (TestWebKitAPI::TEST):
754         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
755         (TestWebKitAPI::TEST):
756
757 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
758
759         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
760         https://bugs.webkit.org/show_bug.cgi?id=150792
761
762         Reviewed by Saam Barati.
763
764         * Scripts/webkitperl/FeatureList.pm:
765
766 2015-12-01  Sam Weinig  <sam@webkit.org>
767
768         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
769         <rdar://problem/23320863>
770         https://bugs.webkit.org/show_bug.cgi?id=151708
771
772         Reviewed by Anders Carlsson.
773
774         * WebKitTestRunner/TestController.cpp:
775         (WTR::TestController::createOtherPage):
776         (WTR::TestController::createWebViewWithOptions):
777         Update for new WKPageUIClient.
778
779 2015-12-01  Anders Carlsson  <andersca@apple.com>
780
781         Remove WebKit2.framework
782         https://bugs.webkit.org/show_bug.cgi?id=151715
783
784         Reviewed by Dan Bernstein.
785
786         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
787         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
788         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
789         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
790         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
791         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
792         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
793
794 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
795
796         Unreviewed common typo fix "occurance" => "occurrence".
797
798         * Scripts/webkitpy/tool/commands/queries.py:
799         (FindFlakyTests._print_statistics):
800
801 2015-11-30  Alex Christensen  <achristensen@webkit.org>
802
803         Make ProcessModel always MultipleSecondaryProcesses
804         https://bugs.webkit.org/show_bug.cgi?id=151662
805
806         Reviewed by Antti Koivisto.
807
808         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
809         (TestWebKitAPI::TEST):
810         * WebKitTestRunner/TestController.cpp:
811         (WTR::TestController::generatePageConfiguration):
812
813 2015-11-30  Alex Christensen  <achristensen@webkit.org>
814
815         Make usesNetworkProcess always true
816         https://bugs.webkit.org/show_bug.cgi?id=151580
817
818         Reviewed by Darin Adler.
819
820         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
821         (TestWebKitAPI::TEST):
822         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
823         (TestWebKitAPI::TEST):
824         * WebKitTestRunner/TestController.cpp:
825         (WTR::TestController::generatePageConfiguration):
826
827 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
828
829         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
830
831         Add a way to skip unit tests only for Debug or Release builds and
832         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
833
834         * Scripts/run-gtk-tests:
835         (SkippedTest):
836         (SkippedTest.__init__):
837         (SkippedTest.__str__):
838         (SkippedTest.skip_entire_suite):
839         (SkippedTest.skip_for_build_type):
840         (TestRunner):
841         (TestRunner.__init__):
842
843 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
844
845         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
846
847         It's an assert hit because we are reloading a view loaded with
848         HTML data which is not supported. Use loadURI instead.
849
850         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
851         (testWebViewCustomCharset):
852
853 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
854
855         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
856         https://bugs.webkit.org/show_bug.cgi?id=151633
857
858         Reviewed by Csaba Osztrogonác.
859
860         * TestWebKitAPI/PlatformGTK.cmake:
861         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
862
863 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
864
865         [GTK] Remove the remaining uses of GMainLoopSource
866         https://bugs.webkit.org/show_bug.cgi?id=151632
867
868         Reviewed by Žan Doberšek.
869
870         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
871         (testWebViewSyncRequestOnMaxConns):
872         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
873         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
874         (WTR::TestRunner::TestRunner):
875         * WebKitTestRunner/InjectedBundle/TestRunner.h:
876         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
877         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
878         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
879         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
880         (WTR::timeoutSource):
881         (WTR::TestController::notifyDone):
882         (WTR::TestController::platformRunUntil):
883
884 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
885
886         [cmake] Add testb3 to the build system
887         https://bugs.webkit.org/show_bug.cgi?id=151619
888
889         Reviewed by Gyuyoung Kim.
890
891         * Scripts/build-jsc:
892
893 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
894
895         [jhbuild] Fix pixman build with clang
896         https://bugs.webkit.org/show_bug.cgi?id=151441
897
898         Reviewed by Carlos Garcia Campos.
899
900         * efl/jhbuild.modules:
901         * gtk/jhbuild.modules:
902
903 2015-11-26  David Kilzer  <ddkilzer@apple.com>
904
905         Extract prependToEnvironmentVariableList
906         <http://webkit.org/b/151536>
907
908         Reviewed by Daniel Bates.
909
910         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
911                webkitdirs_unittest/prependToEnvironmentVariableList.pl
912
913         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
914         and prependToEnvironmentVariableList.
915         (appendToEnvironmentVariableList): Simplify variable name.
916         Switch to use $Config{path_sep}.
917         (prependToEnvironmentVariableList): Add new method.
918         (setupMacWebKitEnvironment): Switch to use
919         prependToEnvironmentVariableList().
920         (setupIOSWebKitEnvironment): Ditto.
921
922         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
923         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
924
925 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
926
927         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
928         https://bugs.webkit.org/show_bug.cgi?id=151567
929
930         Reviewed by Darin Adler.
931
932         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
933         (on_window_deletion):
934
935 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
936
937         [GTK] Use the network process unconditionally
938         https://bugs.webkit.org/show_bug.cgi?id=151541
939
940         Reviewed by Alex Christensen.
941
942         Fix TestInspectorServer test. Do not assume we already have the
943         title we want when the page has been loaded, since the title is
944         changed afterwards. So, check if the title has already been set,
945         and if not wait for it.
946
947         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
948         (openRemoteDebuggingSession):
949
950 2015-11-23  Alex Christensen  <achristensen@webkit.org>
951
952         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
953         https://bugs.webkit.org/show_bug.cgi?id=151532
954
955         Reviewed by Benjamin Poulain.
956
957         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
958         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
959         (TestWebKitAPI::TEST):
960         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
961         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
962         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
963         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
964         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
965         so it was calling a function on a test object that had gone out of scope.
966         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
967         but that will become the default soon and that call will be removed.
968
969 2015-11-22  David Kilzer  <ddkilzer@apple.com>
970
971         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
972         <http://webkit.org/b/151542>
973
974         Reviewed by Daniel Bates.
975
976         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
977         (base_url): Use the Port object (already passed in) to give us
978         the path to the LayoutTests directory, which already checks for a
979         --layout-tests-directory command-line switch.
980         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
981         argument since we can get this from the Port object already
982         passed in via Port.results_directory().  Also switch to use
983         Port.layout_tests_dir() to get the LayoutTests directory.
984
985         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
986         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
987         Add test case for custom LayoutTests directory.
988         (TestWebPlatformTestServer.test_previously_spawned_instance):
989         Update Port object to set mock results directory as if it was
990         set on the command-line.  Remove unneeded argument from
991         WebPlatformTestServer constructor.
992         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
993
994         * Scripts/webkitpy/port/base.py:
995         (Port.to.start_web_platform_test_server): Remove unneeded
996         argument from WebPlatformTestServer constuctor.
997
998 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
999
1000         [GTK] Some unit tests fail when using the network process
1001         https://bugs.webkit.org/show_bug.cgi?id=151490
1002
1003         Reviewed by Martin Robinson.
1004
1005         Run the soup server in a separate thread in TestResources test to
1006         avoid deadlocks.
1007
1008         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
1009         /webkit2/WebKitWebResource/get-data when using the network process.
1010
1011         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1012         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
1013         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1014         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
1015         present, create a WorkQueue to run the server.
1016         (WebKitTestServer::run): Run the server in the work queue if it
1017         has been created.
1018         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1019         type into server options as flags.
1020
1021 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1022
1023         [GTK] ImageDiff should normalize the diff image
1024         https://bugs.webkit.org/show_bug.cgi?id=151261
1025
1026         Reviewed by Sergio Villar Senin.
1027
1028         * ImageDiff/gtk/ImageDiff.cpp:
1029         (readPixbufFromStdin): Fix memory leak.
1030         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
1031         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
1032
1033 == Rolled over to ChangeLog-2015-11-21 ==