[ews-app] Add method to fetch patch
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] Add method to fetch patch
4         https://bugs.webkit.org/show_bug.cgi?id=194518
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-app/ews/models/patch.py:
9         (Patch.get_patch):
10
11 2019-02-12  Zalan Bujtas  <zalan@apple.com>
12
13         [LFC] Expand tests coverage (60 new tests -> 860)
14
15         Unreviewed test gardening (run-singly, --child-processes=1).
16
17         * LayoutReloaded/misc/LFC-passing-tests.txt:
18
19 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
20
21         Allow pages to trigger programmatic paste from script on iOS
22         https://bugs.webkit.org/show_bug.cgi?id=194271
23         <rdar://problem/47808810>
24
25         Reviewed by Tim Horton.
26
27         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
28
29         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
30         (WTR::UIScriptController::platformSetDidShowMenuCallback):
31         (WTR::UIScriptController::platformSetDidHideMenuCallback):
32         (WTR::UIScriptController::rectForMenuAction const):
33
34         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
35         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
36         for when the menu is shown or hidden.
37
38         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
39         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
40         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
41         (WTR::UIScriptController::setDidShowMenuCallback):
42         (WTR::UIScriptController::didShowMenuCallback const):
43         (WTR::UIScriptController::setDidHideMenuCallback):
44         (WTR::UIScriptController::didHideMenuCallback const):
45         (WTR::UIScriptController::platformSetDidShowMenuCallback):
46         (WTR::UIScriptController::platformSetDidHideMenuCallback):
47         (WTR::UIScriptController::rectForMenuAction const):
48         * TestRunnerShared/UIScriptContext/UIScriptController.h:
49         * WebKitTestRunner/TestController.cpp:
50         (WTR::TestController::resetPreferencesToConsistentValues):
51         (WTR::updateTestOptionsFromTestHeader):
52         * WebKitTestRunner/TestOptions.h:
53
54         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
55         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
56
57         (WTR::TestOptions::hasSameInitializationOptions const):
58         * WebKitTestRunner/UIScriptControllerCocoa.mm:
59         (WTR::UIScriptController::calendarType const):
60         (WTR::UIScriptController::platformUndoManager const):
61         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
62         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
63         (-[TestRunnerWKWebView initWithFrame:configuration:]):
64         (-[TestRunnerWKWebView dealloc]):
65         (-[TestRunnerWKWebView _didShowMenu]):
66         (-[TestRunnerWKWebView _didHideMenu]):
67
68         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
69
70         * WebKitTestRunner/ios/TestControllerIOS.mm:
71         (WTR::handleMenuWillHideNotification):
72         (WTR::handleMenuDidHideNotification):
73         (WTR::TestController::platformInitialize):
74         (WTR::TestController::platformDestroy):
75         (WTR::TestController::platformResetStateToConsistentValues):
76
77         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
78         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
79
80         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
81         (WTR::forEachViewInHierarchy):
82         (WTR::findViewInHierarchyOfType):
83
84         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
85         functions that dig through a given view's hierarchy in search of a view of a given class.
86
87         (WTR::UIScriptController::selectionStartGrabberViewRect const):
88         (WTR::UIScriptController::selectionEndGrabberViewRect const):
89         (WTR::UIScriptController::selectionCaretViewRect const):
90         (WTR::UIScriptController::selectionRangeViewRects const):
91         (WTR::UIScriptController::platformSetDidShowMenuCallback):
92         (WTR::UIScriptController::platformSetDidHideMenuCallback):
93
94         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
95
96         (WTR::UIScriptController::rectForMenuAction const):
97
98         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
99         callout bar) whose label matches the given string.
100
101         (WTR::UIScriptController::platformContentView const):
102
103         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
104         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
105         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
106
107         (WTR::UIScriptController::platformUndoManager const): Deleted.
108         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
109         (WTR::UIScriptController::platformContentView const):
110         (WTR::UIScriptController::platformUndoManager const): Deleted.
111
112 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
113
114         webkitpy: No option to only show unexpected failures in results.html for iPad
115         https://bugs.webkit.org/show_bug.cgi?id=194554
116         <rdar://problem/47922442>
117
118         Rubber-stamped by Aakash Jain.
119
120         Just because a TestExpecations file does not exist for a specific platform does not mean that
121         TestExpecations are not being used, given that platforms inherit test expectations.
122
123         * Scripts/webkitpy/port/base.py:
124         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
125         * Scripts/webkitpy/port/base_unittest.py:
126         (PortTest.test_uses_test_expectations_file):
127
128 2019-02-12  Alex Christensen  <achristensen@webkit.org>
129
130         Remove setDefersLoading infrastructure from WebKit2
131         https://bugs.webkit.org/show_bug.cgi?id=194506
132
133         Reviewed by Brady Eidson.
134
135         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
136         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
137         (WTR::TestRunner::setDefersLoading): Deleted.
138         * WebKitTestRunner/InjectedBundle/TestRunner.h:
139
140 2019-02-12  Alex Christensen  <achristensen@webkit.org>
141
142         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
143         https://bugs.webkit.org/show_bug.cgi?id=194522
144         <rdar://problem/47789393>
145
146         Reviewed by Chris Dumez.
147
148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
149         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
150         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
151         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
152
153 2019-02-12  Andy Estes  <aestes@apple.com>
154
155         [iOSMac] Enable Parental Controls Content Filtering
156         https://bugs.webkit.org/show_bug.cgi?id=194521
157         <rdar://39732376>
158
159         Reviewed by Tim Horton.
160
161         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
162
163 2019-02-12  Zalan Bujtas  <zalan@apple.com>
164
165         [LFC][IFC] Add intrinsic width support for float boxes.
166         https://bugs.webkit.org/show_bug.cgi?id=194528
167
168         Reviewed by Antti Koivisto.
169
170         Expand tests coverage (2 new tests -> 800).
171         (This is the correct test ordering --runs-singly --child-processes=1)
172
173         * LayoutReloaded/misc/LFC-passing-tests.txt:
174
175 2019-02-12  Rob Buis  <rbuis@igalia.com>
176
177         Implement serializing in MIME type parser
178         https://bugs.webkit.org/show_bug.cgi?id=193909
179
180         Reviewed by Darin Adler.
181
182         Add various tests involving upper case, non-ASCII, control/null characters,
183         various HTTP whitespace, single quotes and an unpaired surrogate.
184
185         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
186         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
187         (TestWebKitAPI::serializeIfValid):
188         (TestWebKitAPI::TEST):
189
190 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
191
192         [Cocoa] Ask platform for generic font family mappings
193         https://bugs.webkit.org/show_bug.cgi?id=187723
194         <rdar://problem/41892438>
195
196         Reviewed by Brent Fulgham.
197
198         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
199
200         * DumpRenderTree/mac/DumpRenderTree.mm:
201         (allowedFontFamilySet):
202         * WebKitTestRunner/mac/TestControllerMac.mm:
203         (WTR::allowedFontFamilySet):
204
205 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
206
207         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
208         https://bugs.webkit.org/show_bug.cgi?id=193622
209
210         Reviewed by Michael Catanzaro.
211
212         This adds support for loading content extension rule sets from the JSON files which
213         accompany the corresponding layout test, using the C API. The Cocoa specific parts
214         of WKTR for this could be removed, but that is left for a follow-up patch with
215         cleanups.
216
217         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
218         * WebKitTestRunner/TestController.cpp:
219         (WTR::testPath): Subtract one from the length when constructing the result std::string to
220         avoid having the null-terminator copied into the result.
221         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
222         part of the preparations to run a test.
223         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
224         (WTR::contentExtensionStoreCallback): Added.
225         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
226         used for content extensions test.
227         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
228         extensions and compiling the JSON rule set for tests involving content extensions.
229         (WTR::TestController::resetContentExtensions): Removes the content extension built for
230         testing and disables content extensions.
231         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
232         resetContentExtensions().
233         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
234         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
235         configureContentExtensionForTest(), and userContentController().
236
237 2019-02-11  Daniel Bates  <dabates@apple.com>
238
239         [iOS] Mouse/Touch/Pointer events are missing modifier keys
240         https://bugs.webkit.org/show_bug.cgi?id=191446
241         <rdar://problem/45929460>
242
243         Reviewed by Tim Horton.
244
245         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
246
247         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
248         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
249         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
250         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
251         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
252         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
253         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
254         * TestRunnerShared/UIScriptContext/UIScriptController.h:
255         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
256         (WTR::arrayLength):
257         (WTR::parseModifierArray):
258         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
259         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
260         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
261         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
262
263 2019-02-11  Commit Queue  <commit-queue@webkit.org>
264
265         Unreviewed, rolling out r241272 and r241276.
266         https://bugs.webkit.org/show_bug.cgi?id=194514
267
268         Broke the Apple Internal build and the fix requires human
269         intervention :( (Requested by dydz on #webkit).
270
271         Reverted changesets:
272
273         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
274         https://bugs.webkit.org/show_bug.cgi?id=191446
275         https://trac.webkit.org/changeset/241272
276
277         "Fix internal iOS build after r241272"
278         https://bugs.webkit.org/show_bug.cgi?id=191446
279         https://trac.webkit.org/changeset/241276
280
281 2019-02-11  Truitt Savell  <tsavell@apple.com>
282
283         Unreviewed, rolling out r241269.
284
285         Caused 5 layout tests crashes on Mac WK1
286
287         Reverted changeset:
288
289         "DumpRenderTree should report unknown options"
290         https://bugs.webkit.org/show_bug.cgi?id=191303
291         https://trac.webkit.org/changeset/241269
292
293 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
294
295         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
296         https://bugs.webkit.org/show_bug.cgi?id=194313
297
298         Reviewed by Tim Horton.
299
300         Add a helper to determine whether the web view is presenting modal UI.
301
302         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
303         (WTR::UIScriptController::isPresentingModally const):
304         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
305         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
306         (WTR::UIScriptController::isPresentingModally const):
307         * TestRunnerShared/UIScriptContext/UIScriptController.h:
308         * WebKitTestRunner/UIScriptControllerCocoa.mm:
309         (WTR::UIScriptController::calendarType const): Deleted.
310         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
311         (WTR::UIScriptController::isPresentingModally const):
312         (WTR::UIScriptController::calendarType const):
313         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
314         (WTR::UIScriptController::calendarType const):
315
316 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
317
318         GCHeapInspector: Show the retained sizes in more places
319         https://bugs.webkit.org/show_bug.cgi?id=194464
320
321         Reviewed by Simon Fraser.
322
323         * GCHeapInspector/gc-heap-inspector.html:
324         * GCHeapInspector/script/interface.js:
325         (HeapInspectorUtils.humanReadableSize):
326         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
327         (HeapInspectorUtils.spanForNode.span.span):
328         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
329         (HeapSnapshotInspector.prototype.buildRoots):
330
331 2019-02-11  Daniel Bates  <dabates@apple.com>
332
333         [iOS] Mouse/Touch/Pointer events are missing modifier keys
334         https://bugs.webkit.org/show_bug.cgi?id=191446
335         <rdar://problem/45929460>
336
337         Reviewed by Tim Horton.
338
339         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
340
341         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
342         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
343         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
344         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
345         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
346         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
347         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
348         * TestRunnerShared/UIScriptContext/UIScriptController.h:
349         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
350         (WTR::arrayLength):
351         (WTR::parseModifierArray):
352         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
353         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
354         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
355         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
356
357 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
358
359         DumpRenderTree should report unknown options
360         https://bugs.webkit.org/show_bug.cgi?id=191303
361
362         Reviewed by Frédéric Wang.
363
364         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
365         to report unknown options.
366         Added and assigned test options which are currently used in tests.
367
368         * DumpRenderTree/TestOptions.cpp:
369         (TestOptions::TestOptions):
370
371 2019-02-11  Truitt Savell  <tsavell@apple.com>
372
373         Unreviewed, rolling out r241229.
374
375         Revision broke internal builds for watchOS.
376
377         Reverted changeset:
378
379         "[Cocoa] Ask platform for generic font family mappings"
380         https://bugs.webkit.org/show_bug.cgi?id=187723
381         https://trac.webkit.org/changeset/241229
382
383 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
384
385         [WinCairo][MiniBrowser] Basic authentication always fails.
386         https://bugs.webkit.org/show_bug.cgi?id=194496
387
388         Reviewed by Don Olmstead.
389
390         * MiniBrowser/win/DialogHelper.h:
391         (Dialog::getText):
392
393 2019-02-11  Philippe Normand  <pnormand@igalia.com>
394
395         [GStreamer] GstMappedBuffer testsuite build fails
396         https://bugs.webkit.org/show_bug.cgi?id=194495
397
398         Reviewed by Carlos Garcia Campos.
399
400         Fix the build by explicitely adding the gstreamer1.0-audio include
401         directories to the include path.
402
403         * TestWebKitAPI/PlatformGTK.cmake:
404         * TestWebKitAPI/PlatformWPE.cmake:
405
406 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
407
408         [GTK][WPE] Add enable-javascript-markup setting
409         https://bugs.webkit.org/show_bug.cgi?id=193439
410
411         Reviewed by Michael Catanzaro.
412
413         Add test cases to check the new setting.
414
415         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
416         (testWebKitSettings):
417         (testWebKitSettingsJavaScriptMarkup):
418         (beforeAll):
419
420 2019-02-10  Darin Adler  <darin@apple.com>
421
422         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
423         https://bugs.webkit.org/show_bug.cgi?id=194485
424
425         Reviewed by Daniel Bates.
426
427         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
428
429 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
430
431         Add more tests for clampTo<>()
432         https://bugs.webkit.org/show_bug.cgi?id=194462
433
434         Reviewed by Geoffrey Garen.
435
436         Darin suggested to test the very last floating point number
437         at the boundaries when truncating to integer.
438         I added test for max/min and max-1/min-1.
439
440         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
441         (TestWebKitAPI::TEST):
442
443 2019-02-09  Darin Adler  <darin@apple.com>
444
445         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
446         https://bugs.webkit.org/show_bug.cgi?id=194021
447
448         Reviewed by Geoffrey Garen.
449
450         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
451         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
452         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
453
454 2019-02-09  Zalan Bujtas  <zalan@apple.com>
455
456         [LFC][IFC] Add intrinsic width support for basic inline containers
457         https://bugs.webkit.org/show_bug.cgi?id=194473
458
459         Reviewed by Antti Koivisto.
460
461         Expand tests coverage (11 new tests -> 798)
462
463         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
464
465 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
466
467         Fix MiniBrowser's entitlements
468         https://bugs.webkit.org/show_bug.cgi?id=192431
469
470         Reviewed by Joseph Pecoraro.
471
472         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
473         files, making it impossible to load any extension.
474
475         * MiniBrowser/MiniBrowser.entitlements:
476
477 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
478
479         [Cocoa] Ask platform for generic font family mappings
480         https://bugs.webkit.org/show_bug.cgi?id=187723
481         <rdar://problem/41892438>
482
483         Reviewed by Brent Fulgham.
484
485         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
486
487         * DumpRenderTree/mac/DumpRenderTree.mm:
488         (allowedFontFamilySet):
489         * WebKitTestRunner/mac/TestControllerMac.mm:
490         (WTR::allowedFontFamilySet):
491
492 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
493
494         [GTK] Implement back/forward touchpad gesture
495         https://bugs.webkit.org/show_bug.cgi?id=193919
496
497         Reviewed by Michael Catanzaro.
498
499         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
500         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
501
502 2019-02-08  Alex Christensen  <achristensen@webkit.org>
503
504         Add SPI to use networking daemon instead of XPC service
505         https://bugs.webkit.org/show_bug.cgi?id=194427
506
507         Reviewed by Geoffrey Garen
508
509         * MiniBrowser/MiniBrowser.entitlements:
510
511 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
512
513         [ews-build] Ensure that every builder in config.json has short name
514         https://bugs.webkit.org/show_bug.cgi?id=194461
515
516         Reviewed by Lucas Forschler.
517
518         * BuildSlaveSupport/ews-build/loadConfig.py:
519         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
520
521 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
522
523         [ews-build] Add short name to config.json
524         https://bugs.webkit.org/show_bug.cgi?id=194456
525
526         Reviewed by Lucas Forschler.
527
528         * BuildSlaveSupport/ews-build/config.json: Added short name.
529         * BuildSlaveSupport/ews-build/loadConfig.py:
530         (loadBuilderConfig): Set the short name as the builder description.
531
532 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
533
534         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
535         https://bugs.webkit.org/show_bug.cgi?id=194418
536
537         Reviewed by Lucas Forschler.
538
539         Do not include errors trying when finding crashlogs at the end of
540         a run-webkit-tests run since we don't process those errors.
541
542         * Scripts/webkitpy/port/darwin.py:
543         (DarwinPort._look_for_all_crash_logs_in_log_dir):
544         * Scripts/webkitpy/port/ios_device.py:
545         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
546         * Scripts/webkitpy/port/watch_device.py:
547         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
548
549 2019-02-08  Beth Dakin  <bdakin@apple.com>
550
551         Add afterScreenUpdates to WKSnapshotConfiguration
552         https://bugs.webkit.org/show_bug.cgi?id=194362
553         -and corresponding-
554         <rdar://problem/40655528> Please add an "after screen updates" property to 
555         WKSnapshotConfiguration (to solve blank snapshots)
556
557         Reviewed by Tim Horton.
558
559         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
560         (TEST):
561
562 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
563
564         clampTo(): do not convert the input to double when dealing with integers
565         https://bugs.webkit.org/show_bug.cgi?id=194263
566         <rdar://problem/47692312>
567
568         Reviewed by Darin Adler.
569
570         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
571         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
572         (TestWebKitAPI::testClampFloatingPointToInteger):
573         (TestWebKitAPI::testClampSameSignIntegers):
574         (TestWebKitAPI::testClampUnsignedToSigned):
575         (TestWebKitAPI::testClampSignedToUnsigned):
576
577 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
578
579         webkitpy: Respect --dedicated-simulators flag
580         https://bugs.webkit.org/show_bug.cgi?id=194416
581         <rdar://problem/47894722>
582
583         Reviewed by Lucas Forschler.
584
585         * Scripts/webkitpy/port/device_port.py:
586         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
587         available devices can be safely ignored.
588
589 2019-02-07  Keith Rollin  <krollin@apple.com>
590
591         Remove extra copy of 100x100-red.tga
592         https://bugs.webkit.org/show_bug.cgi?id=194371
593         <rdar://problem/47873465>
594
595         Reviewed by Said Abou-Hallawa.
596
597         In order to help it pass its tests, Bug 194190 added a second copy of
598         the file 100x100-red.tga. However, it turns out that this additional
599         file wasn't actually needed, and that that sole previous copy was
600         sufficient. At the same time, this second copy -- which was copied to
601         the same location in the build output as the first copy -- now caused
602         XCBuild to complain because there were two production rules for the
603         same output file. Address this by removing the newly-added extra copy.
604
605         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
606         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
607
608 2019-02-07  Alex Christensen  <achristensen@webkit.org>
609
610         Deprecate WKBundlePageSetDefersLoading
611         https://bugs.webkit.org/show_bug.cgi?id=191394
612
613         Reviewed by Dean Jackson.
614
615         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
616         (WTR::TestRunner::setDefersLoading):
617
618 2019-02-07  Zalan Bujtas  <zalan@apple.com>
619
620         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
621         https://bugs.webkit.org/show_bug.cgi?id=194391
622
623         Reviewed by Antti Koivisto.
624
625         * LayoutReloaded/misc/LFC-passing-tests.txt:
626
627 2019-02-06  Keith Rollin  <krollin@apple.com>
628
629         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
630         https://bugs.webkit.org/show_bug.cgi?id=193975
631         <rdar://problem/47643306>
632
633         Reviewed by Tim Horton.
634
635         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
636         the Info.plist file into the bundle. This step is not necessary as the
637         implicit "bundle up all the build products into a framework" build
638         phase does this already. Having the Copy Bundle Resources phase do
639         this causes a conflict under XCBuild, which objects to two build
640         phases producing the same file (Info.plist). Address this by removing
641         Info.plist from the Copy Bundle Resources phase.
642
643         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
644
645 2019-02-06  Keith Rollin  <krollin@apple.com>
646
647         Really enable the automatic checking and regenerations of .xcfilelists during builds
648         https://bugs.webkit.org/show_bug.cgi?id=194357
649         <rdar://problem/47861231>
650
651         Reviewed by Chris Dumez.
652
653         Bug 194124 was supposed to enable the automatic checking and
654         regenerating of .xcfilelist files during the build. While related
655         changes were included in that patch, the change to actually enable the
656         operation somehow was omitted. This patch actually enables the
657         operation. The check-xcfilelist.sh scripts now check
658         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
659         from the checking.
660
661         * DumpRenderTree/Scripts/check-xcfilelists.sh:
662         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
663
664 2019-02-06  David Kilzer  <ddkilzer@apple.com>
665
666         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
667         <https://webkit.org/b/194286>
668         <rdar://problem/47815558>
669
670         Reviewed by Alexey Proskuryakov.
671
672         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
673         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
674         WKRetainPtr<> to avoid leaking the WKDataRef.
675
676 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
677
678         Unreviewed, fix a typo
679
680         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
681
682 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
683
684         [GTK][WPE] force libpsl build to use ICU in jhbuild
685         https://bugs.webkit.org/show_bug.cgi?id=194288
686
687         Reviewed by Carlos Garcia Campos.
688
689         * gtk/jhbuild.modules:
690         Require ICU for libpsl build in jhbuild, like done in WPE.
691
692 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
693
694         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
695         https://bugs.webkit.org/show_bug.cgi?id=194209
696
697         Reviewed by Carlos Garcia Campos.
698
699         Enhance TestCookieManager to ensure this doesn't happen again.
700
701         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
702         (testCookieManagerPersistentStorage):
703         (beforeAll):
704
705 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
706
707         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
708         https://bugs.webkit.org/show_bug.cgi?id=194324
709
710         Reviewed by Andy Estes.
711
712         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
713         part of the name is already implicit, since this is in testing code in TestOptions.
714
715         * WebKitTestRunner/TestController.cpp:
716         (WTR::TestController::generateContextConfiguration const):
717         (WTR::updateTestOptionsFromTestHeader):
718         * WebKitTestRunner/TestOptions.h:
719         (WTR::TestOptions::hasSameInitializationOptions const):
720
721 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
722
723         [ews-build] Allow * as platform for builders and workers
724         https://bugs.webkit.org/show_bug.cgi?id=188533
725
726         Reviewed by Lucas Forschler.
727
728         * BuildSlaveSupport/ews-build/loadConfig.py:
729         (checkWorkersAndBuildersForConsistency):
730
731 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
732
733         [ews-build] Add few bots to config.json
734         https://bugs.webkit.org/show_bug.cgi?id=194304
735
736         Reviewed by Lucas Forschler.
737
738         * BuildSlaveSupport/ews-build/config.json:
739
740 2019-02-05  Keith Rollin  <krollin@apple.com>
741
742         Enable the automatic checking and regenerations of .xcfilelists during builds
743         https://bugs.webkit.org/show_bug.cgi?id=194124
744         <rdar://problem/47721277>
745
746         Reviewed by Tim Horton.
747
748         Bug 193790 add a facility for checking -- during build time -- that
749         any needed .xcfilelist files are up-to-date and for updating them if
750         they are not. This facility was initially opt-in by setting
751         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
752         the process seemed robust. Its now time to enable this facility and
753         make it opt-out. If there is a need to disable this facility, set and
754         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
755         running `make` or `build-webkit`, or before running Xcode from the
756         command line.
757
758         Additionally, remove the step that generates a list of source files
759         going into the UnifiedSources build step. It's only necessarily to
760         specify Sources.txt and SourcesCocoa.txt as inputs.
761
762         * Scripts/generate-xcfilelists:
763
764 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
765
766         [GTK][WPE] force libpsl build to use ICU in jhbuild
767         https://bugs.webkit.org/show_bug.cgi?id=194288
768
769         Reviewed by Philippe Normand.
770
771         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
772         This can cause build failures if libidn is detected but libunistring is not available.
773
774         Make sure that ICU is used for runtime and builtin PSL data.
775
776         * gtk/jhbuild.modules:
777         * wpe/jhbuild.modules:
778
779 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
780
781         [ews-app] Modified timestamp should be updated on updating data
782         https://bugs.webkit.org/show_bug.cgi?id=194295
783
784         Reviewed by Lucas Forschler.
785
786         * BuildSlaveSupport/ews-app/ews/models/build.py:
787         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
788         * BuildSlaveSupport/ews-app/ews/models/step.py:
789
790 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
791
792         Unreviewed, rolling out r240742.
793
794         Causes crashes on iOS simulator.
795
796         Reverted changeset:
797
798         "[iOS] Keyups for non-modifier keys identified as "Dead" when
799         not focused in a content-editable element"
800         https://bugs.webkit.org/show_bug.cgi?id=192824
801         https://trac.webkit.org/changeset/240742
802
803 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
804
805         run-webkit-tests emits message "...running None" when running tests
806         https://bugs.webkit.org/show_bug.cgi?id=194133
807         <rdar://problem/47724738>
808
809         Reviewed by Lucas Forschler.
810
811         * Scripts/webkitpy/xcode/device_type.py:
812         (DeviceType.__str__): Use both version mapping tables and use just the variant
813         name if no version name is available.
814         * Scripts/webkitpy/xcode/device_type_unittest.py:
815         (DeviceTypeTest):
816         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
817         an associated named.
818
819 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
820
821         [WPE] require python3-setuptools for meson build in jhbuild
822         https://bugs.webkit.org/show_bug.cgi?id=194287
823
824         Reviewed by Philippe Normand.
825
826         python3-setuptools is needed to build meson in jhbuild.
827         It is already required by the GTK port.
828
829         * wpe/install-dependencies:
830
831 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
832
833         [ews-app] Add method to save BuilderMapping to database
834         https://bugs.webkit.org/show_bug.cgi?id=194264
835
836         Reviewed by Lucas Forschler.
837
838         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
839         (BuilderMapping.__str__):
840         (BuilderMapping):
841         (BuilderMapping.save_mapping):
842         (BuilderMapping.update_mapping):
843         (BuilderMapping.get_existing_mapping):
844         (BuilderMapping.is_valid_mapping):
845
846 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
847
848         [ews-app] Add timestamp fields for BuilderMappings
849         https://bugs.webkit.org/show_bug.cgi?id=194266
850
851         Reviewed by Lucas Forschler.
852
853         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
854         (BuilderMapping):
855
856 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
857
858         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
859         https://bugs.webkit.org/show_bug.cgi?id=174816
860
861         Reviewed by Michael Catanzaro.
862
863         Add tests for webkit_uri_for_display().
864
865         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
866         (testURIForDisplayUnaffected):
867         (testURIForDisplayAffected):
868         (beforeAll):
869         (afterAll):
870         * TestWebKitAPI/glib/CMakeLists.txt:
871
872 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
873
874         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
875         https://bugs.webkit.org/show_bug.cgi?id=194158
876         <rdar://problem/47737268>
877
878         Rubber-stamped by Aakash Jain.
879
880         * Scripts/webkitpy/port/device_port.py:
881         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
882
883 2019-02-04  Said Abou-Hallawa  <said@apple.com>
884
885         [CG] Enable setAdditionalSupportedImageTypes for WK1
886         https://bugs.webkit.org/show_bug.cgi?id=194190
887
888         Reviewed by Tim Horton.
889
890         Add a test similar to the one under WebKit Cocoa but make it create a
891         WebView instead of a WKWebView.
892
893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
894         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
895         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
896         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
897         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
898         (TestWebKitAPI::runTest):
899         (TestWebKitAPI::TEST):
900
901 2019-02-04  Zalan Bujtas  <zalan@apple.com>
902
903         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
904         https://bugs.webkit.org/show_bug.cgi?id=194168
905
906         Reviewed by Simon Fraser.
907
908         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
909
910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
911         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
912         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
913         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
914         (TEST):
915         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
916         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
917
918 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
919
920         REGRESSION (r237269): webkit-patch what-broke is broken 
921         https://bugs.webkit.org/show_bug.cgi?id=193025
922
923         Reviewed by Aakash Jain.
924
925         * Scripts/webkitpy/common/host.py:
926         (Host.buildbot):
927         (Host.bugzilla): Renamed to 'buildbot'.
928
929 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
930
931         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
932         https://bugs.webkit.org/show_bug.cgi?id=194207
933
934         Reviewed by Tim Horton.
935
936         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
937         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
938         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
939         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
940         start and delete forwards to remove the original attachment.
941
942         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
943         (TestWebKitAPI::TEST):
944
945 2019-02-04  Youenn Fablet  <youenn@apple.com>
946
947         Capture state should be managed consistently when doing process swapping
948         https://bugs.webkit.org/show_bug.cgi?id=194122
949         <rdar://problem/47609293>
950
951         Reviewed by Eric Carlson.
952
953         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
954         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
955         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
956         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
957         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
958         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
959         (WTR::TestRunner::isDoingMediaCapture const):
960         * WebKitTestRunner/InjectedBundle/TestRunner.h:
961         * WebKitTestRunner/TestController.cpp:
962         (WTR::TestController::isDoingMediaCapture const):
963         * WebKitTestRunner/TestController.h:
964         * WebKitTestRunner/TestInvocation.cpp:
965         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
966         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
967         (WTR::TestController::isDoingMediaCapture const):
968
969 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
970
971         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
972         https://bugs.webkit.org/show_bug.cgi?id=194142
973
974         Reviewed by Ross Kirsling.
975
976         There three 'separator' variables in TestController.cpp. Renamed
977         it 'pathSeparator', and unified them.
978
979         * WebKitTestRunner/TestController.cpp:
980         (WTR::TestController::generateContextConfiguration const):
981         (WTR::createTestURL):
982         (WTR::TestController::platformAdjustContext):
983
984 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
985
986         Make setNeedsLayout on the root more explicitly about triggering its side-effects
987         https://bugs.webkit.org/show_bug.cgi?id=194198
988
989         Reviewed by Antti Koivisto.
990
991         No need to set the banner heights on navigation now, since Page stores them.
992
993         * MiniBrowser/mac/WK2BrowserWindowController.m:
994         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
995
996 2019-02-03  John Wilander  <wilander@apple.com>
997
998         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
999         https://bugs.webkit.org/show_bug.cgi?id=194104
1000         <rdar://problem/47649991>
1001
1002         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1003
1004         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1005         (TestWebKitAPI::TEST):
1006             Changed numeric types from unsigned short to uint32_t.
1007
1008 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1009
1010         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1011         <https://webkit.org/b/194178>
1012         <rdar://problem/47753473>
1013
1014         Reviewed by Alexey Proskuryakov.
1015
1016         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1017         (WTR::uninstallFakeHelvetica): Pass nullptr into
1018         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1019
1020 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1021
1022         [LFC] Initialize ICB's style with fixed width/height.
1023         https://bugs.webkit.org/show_bug.cgi?id=194188
1024
1025         Reviewed by Antti Koivisto.
1026
1027         * LayoutReloaded/misc/LFC-passing-tests.txt:
1028
1029 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1030
1031         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1032         https://bugs.webkit.org/show_bug.cgi?id=194185
1033
1034         Reviewed by Antti Koivisto.
1035
1036         * LayoutReloaded/misc/LFC-passing-tests.txt:
1037
1038 2018-12-16  Darin Adler  <darin@apple.com>
1039
1040         Convert additional String::format clients to alternative approaches
1041         https://bugs.webkit.org/show_bug.cgi?id=192746
1042
1043         Reviewed by Alexey Proskuryakov.
1044
1045         * WebKitTestRunner/TestController.cpp:
1046         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1047         as an intermediate in code that ultimately constructs a WTF::String.
1048         (WTR::userMediaOriginHash): Use makeString.
1049         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1050         (WTR::TestController::didPerformClientRedirect): Ditto.
1051         (WTR::TestController::didPerformServerRedirect): Ditto.
1052         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1053
1054 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1055
1056         [ews-build] Add unit test to verify builder keys
1057         https://bugs.webkit.org/show_bug.cgi?id=194152
1058
1059         Reviewed by Lucas Forschler.
1060
1061         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1062         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1063
1064 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1065
1066         [LFC] Expand tests coverage (12 new tests -> 787)
1067
1068         Unreviewed test gardening.
1069
1070         * LayoutReloaded/misc/LFC-passing-tests.txt:
1071
1072 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1073
1074         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1075         https://bugs.webkit.org/show_bug.cgi?id=194163
1076
1077         Reviewed by Simon Fraser.
1078
1079         775
1080
1081         * LayoutReloaded/misc/LFC-passing-tests.txt:
1082
1083 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1084
1085         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1086         https://bugs.webkit.org/show_bug.cgi?id=194140
1087         <rdar://problem/47728098>
1088
1089         Reviewed by Tim Horton.
1090
1091         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1092         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1093         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1094
1095         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1096         test to induce an IPC deadlock when presenting a modal alert during touch start.
1097
1098         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1099         * WebKitTestRunner/TestController.cpp:
1100         (WTR::runJavaScriptAlert):
1101
1102         Add a client callback function for running JavaScript alerts.
1103
1104         (WTR::TestController::createOtherPage):
1105         (WTR::TestController::generateContextConfiguration const):
1106
1107         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1108         the fix in this patch.
1109
1110         (WTR::TestController::createWebViewWithOptions):
1111
1112         Plumb TestOptions to generateContextConfiguration.
1113
1114         (WTR::TestController::resetPreferencesToConsistentValues):
1115         (WTR::TestController::resetStateToConsistentValues):
1116         (WTR::updateTestOptionsFromTestHeader):
1117         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1118         (WTR::TestController::handleJavaScriptAlert):
1119         * WebKitTestRunner/TestController.h:
1120         * WebKitTestRunner/TestInvocation.cpp:
1121         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1122         * WebKitTestRunner/TestOptions.h:
1123         (WTR::TestOptions::hasSameInitializationOptions const):
1124
1125 2019-02-01  Chris Dumez  <cdumez@apple.com>
1126
1127         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1128         https://bugs.webkit.org/show_bug.cgi?id=193740
1129         <rdar://problem/47527267>
1130
1131         Reviewed by Alex Christensen.
1132
1133         Add API test coverage.
1134
1135         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1136
1137 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1138
1139         [ews-app] Add display name field to BuilderMapping model
1140         https://bugs.webkit.org/show_bug.cgi?id=194153
1141
1142         Reviewed by Lucas Forschler.
1143
1144         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1145         (BuilderMapping):
1146
1147 2019-02-01  Youenn Fablet  <youenn@apple.com>
1148
1149         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1150         https://bugs.webkit.org/show_bug.cgi?id=194155
1151
1152         Reviewed by Eric Carlson.
1153
1154         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1155         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1156         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1157
1158 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1159
1160         [LFC] Adjust replaced element's intrinsic ratio
1161         https://bugs.webkit.org/show_bug.cgi?id=194154
1162
1163         Reviewed by Antti Koivisto.
1164
1165         761
1166
1167         * LayoutReloaded/misc/LFC-passing-tests.txt:
1168
1169 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1170
1171         [WPE] Show test results in minibrowser
1172         https://bugs.webkit.org/show_bug.cgi?id=194150
1173
1174         Reviewed by Žan Doberšek.
1175
1176         * Scripts/webkitpy/port/wpe.py:
1177         (WPEPort.show_results_html_file):
1178
1179 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1180
1181         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1182         https://bugs.webkit.org/show_bug.cgi?id=194151
1183
1184         Reviewed by Žan Doberšek.
1185
1186         ALT + <- go back
1187         ALT + -> go forward
1188
1189         * MiniBrowser/wpe/main.cpp:
1190         (main):
1191
1192 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1193
1194         [LFC] Set intrinsic size on Layout::Replaced
1195         https://bugs.webkit.org/show_bug.cgi?id=194139
1196
1197         Reviewed by Antti Koivisto.
1198
1199         744
1200
1201         * LayoutReloaded/misc/LFC-passing-tests.txt:
1202
1203 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1204
1205         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1206         https://bugs.webkit.org/show_bug.cgi?id=194146
1207
1208         Reviewed by Xabier Rodriguez-Calvar.
1209
1210         It allows to open relative paths.
1211
1212         * MiniBrowser/wpe/main.cpp:
1213         (main):
1214
1215 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1216
1217         Update flakiness dashboard configuration after recent queue changes
1218         https://bugs.webkit.org/show_bug.cgi?id=194127
1219
1220         Rubber-stamped by Aakash Jain.
1221
1222         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1223
1224         * TestResultServer/static-dashboards/builders.jsonp:
1225
1226 2019-01-31  Youenn Fablet  <youenn@apple.com>
1227
1228         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1229         https://bugs.webkit.org/show_bug.cgi?id=194106
1230         <rdar://problem/47676333>
1231
1232         Reviewed by Ryosuke Niwa.
1233
1234         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1235         (TestWebKitAPI::didFinishNavigation):
1236         (TestWebKitAPI::TEST):
1237         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1238
1239 2019-01-31  Chris Dumez  <cdumez@apple.com>
1240
1241         Page zoom level is lost after a process swap or a crash
1242         https://bugs.webkit.org/show_bug.cgi?id=194105
1243         <rdar://problem/47610781>
1244
1245         Reviewed by Alex Christensen.
1246
1247         Add API test coverage.
1248
1249         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1250         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1251
1252 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1253
1254         Revert r238819 which is unneeded and caused a performance regression.
1255         https://bugs.webkit.org/show_bug.cgi?id=192272
1256         <rdar://problem/46664625>
1257
1258         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1259         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1260         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1261
1262 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1263
1264         Formalize WebKitAdditions mechanism of LoadOptimizer
1265         https://bugs.webkit.org/show_bug.cgi?id=193886
1266         <rdar://problem/47696809>
1267
1268         Reviewed by Brent Fulgham.
1269
1270         * MiniBrowser/MiniBrowser.entitlements:
1271         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1272
1273 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1274
1275         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1276         https://bugs.webkit.org/show_bug.cgi?id=194090
1277
1278         Reviewed by Antti Koivisto.
1279
1280         * LayoutReloaded/misc/LFC-passing-tests.txt:
1281
1282 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1283
1284         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1285         https://bugs.webkit.org/show_bug.cgi?id=194074
1286
1287         Reviewed by Antti Koivisto.
1288
1289         * LayoutReloaded/misc/LFC-passing-tests.txt:
1290
1291 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1292
1293         [LFC][BFC] Add support for block level replaced box.
1294         https://bugs.webkit.org/show_bug.cgi?id=194071
1295
1296         Reviewed by Antti Koivisto.
1297
1298         * LayoutReloaded/misc/LFC-passing-tests.txt:
1299
1300 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1301
1302         Fix WebKitTestRunner's testPath with Windows full paths
1303         https://bugs.webkit.org/show_bug.cgi?id=194012
1304
1305         Reviewed by Alex Christensen.
1306
1307         updateTestOptionsFromTestHeader failed to open test files because
1308         testPath returned wrong file paths. It returned a path "/C:/..."
1309         if a URL "file:///C:/..." was given.
1310
1311         * WebKitTestRunner/TestController.cpp:
1312         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1313
1314 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1315
1316         [WPE] Bump font related dependencies to match the GTK+ port
1317         https://bugs.webkit.org/show_bug.cgi?id=194017
1318
1319         Reviewed by Žan Doberšek.
1320
1321         * wpe/jhbuild.modules:
1322         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1323         * wpe/patches/icudata-stdlibs.patch: Added.
1324
1325 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1326
1327         Enable swipe tests on iOS
1328         https://bugs.webkit.org/show_bug.cgi?id=194076
1329
1330         Reviewed by Geoffrey Garen.
1331
1332         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1333         it causes a debug assertion failure in runUIScript.
1334
1335         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1336         (WTR::UIScriptController::beginBackSwipe):
1337         (WTR::UIScriptController::completeBackSwipe):
1338
1339 2019-01-30  Keith Rollin  <krollin@apple.com>
1340
1341         Use correct printf format specifier
1342         https://bugs.webkit.org/show_bug.cgi?id=194062
1343         <rdar://problem/47686167>
1344
1345         Reviewed by Alexey Proskuryakov.
1346
1347         LayoutTestSpellChecker.mm is trying to format a variable of type
1348         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1349         actually an unsigned long long. Fix this by formatting with %llu.
1350
1351         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1352         (-[LayoutTestTextCheckingResult description]):
1353
1354 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1355
1356         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1357         https://bugs.webkit.org/show_bug.cgi?id=193979
1358
1359         Reviewed by Wenson Hsieh.
1360
1361         Fix the test for iOS. Make the test work with iOS UA string.
1362
1363         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1364
1365 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1366
1367         Replace High Sierra LLINT CLoop bot due to hardware failure
1368         https://bugs.webkit.org/show_bug.cgi?id=194066
1369
1370         Reviewed by Aakash Jain.
1371
1372         * BuildSlaveSupport/build.webkit.org-config/config.json:
1373
1374 2019-01-30  Keith Rollin  <krollin@apple.com>
1375
1376         [NSDragItem init] is unavailable
1377         https://bugs.webkit.org/show_bug.cgi?id=194059
1378         <rdar://problem/47685715>
1379
1380         Reviewed by Wenson Hsieh.
1381
1382         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1383         DumpRenderTree and TestWebKitAPI, which both try to create an
1384         NSDragItem in a manner that invokes this method. Address this by using
1385         -initWithPasteboardWriter instead.
1386
1387         Note that the parameter passed to initWithPasteboardWriter is likely
1388         incorrect. In both cases, the object passed does not conform to
1389         NSPasteboardWriting. However, with this fix, we're no worse off than
1390         before, and can now perform builds with newer compilers and SDKs until
1391         a real fix can be crafted. That work is tracked in
1392         https://bugs.webkit.org/show_bug.cgi?id=194060
1393
1394         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1395         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1396         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1397         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1398
1399 2019-01-30  Daniel Bates  <dabates@apple.com>
1400
1401         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1402         https://bugs.webkit.org/show_bug.cgi?id=192824
1403         <rdar://problem/47100332>
1404
1405         Reviewed by Wenson Hsieh.
1406
1407         Fix a bug where the wrong usage code was used for F13 thru F24.
1408
1409         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1410         (keyCodeForDOMFunctionKey):
1411
1412 2019-01-30  Chris Dumez  <cdumez@apple.com>
1413
1414         Regression(PSON) Load hang can occur on history navigation
1415         https://bugs.webkit.org/show_bug.cgi?id=194030
1416         <rdar://problem/47656939>
1417
1418         Reviewed by Antti Koivisto.
1419
1420         Add API test coverage.
1421
1422         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1423
1424 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1425
1426         [LFC] Expand tests coverage.
1427
1428         Unreviewed test gardening.
1429
1430         * LayoutReloaded/misc/LFC-passing-tests.txt:
1431
1432 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1433
1434         [Flatpak] Add openjpeg support
1435         https://bugs.webkit.org/show_bug.cgi?id=194019
1436
1437         Reviewed by Michael Catanzaro.
1438
1439         * flatpak/org.webkit.CommonModules.yaml:
1440
1441 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1442
1443         Unreviewed, rolling out r240708.
1444         https://bugs.webkit.org/show_bug.cgi?id=194022
1445
1446         It broke WPE build (Requested by KaL on #webkit).
1447
1448         Reverted changeset:
1449
1450         "[WPE] Bump font related dependencies to match the GTK+ port"
1451         https://bugs.webkit.org/show_bug.cgi?id=194017
1452         https://trac.webkit.org/changeset/240708
1453
1454 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1455
1456         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1457         https://bugs.webkit.org/show_bug.cgi?id=194001
1458
1459         Reviewed by Antti Koivisto.
1460
1461         * LayoutReloaded/misc/LFC-passing-tests.txt:
1462
1463 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1464
1465         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1466         https://bugs.webkit.org/show_bug.cgi?id=194020
1467
1468         Reviewed by Antti Koivisto.
1469
1470         * LayoutReloaded/misc/LFC-passing-tests.txt:
1471
1472 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1473
1474         AX: Support color well on iOS
1475         https://bugs.webkit.org/show_bug.cgi?id=194010
1476
1477         Reviewed by Joanmarie Diggs.
1478
1479         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1480         (WTR::AccessibilityUIElement::stringAttributeValue):
1481
1482 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1483
1484         [WPE] Bump font related dependencies to match the GTK+ port
1485         https://bugs.webkit.org/show_bug.cgi?id=194017
1486
1487         Reviewed by Žan Doberšek.
1488
1489         * wpe/jhbuild.modules:
1490         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1491         * wpe/patches/icudata-stdlibs.patch: Added.
1492
1493 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1494
1495         [Mac] Update window scale API usage
1496         https://bugs.webkit.org/show_bug.cgi?id=193991
1497         rdar://problem/47614795
1498
1499         Reviewed by Tim Horton.
1500
1501         * DumpRenderTree/mac/DumpRenderTree.mm:
1502         (changeWindowScaleIfNeeded):
1503         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1504         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1505         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1506
1507 2019-01-29  Chris Dumez  <cdumez@apple.com>
1508
1509         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1510         https://bugs.webkit.org/show_bug.cgi?id=193977
1511         <rdar://problem/47643716>
1512
1513         Reviewed by Geoff Garen.
1514
1515         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1516         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1517         to the previous provisional committing *before* we make the last load. 
1518
1519         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1520
1521 2019-01-29  Youenn Fablet  <youenn@apple.com>
1522
1523         Adopt new SPI to evaluate server certificate trust
1524         https://bugs.webkit.org/show_bug.cgi?id=193355
1525
1526         Reviewed by Alex Christensen.
1527
1528         Add infrastructure to handle HTTPS server trust evaluation testing.
1529
1530         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1531         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1532         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1533         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1534         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1535         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1536         * WebKitTestRunner/TestController.cpp:
1537         (WTR::TestController::resetPreferencesToConsistentValues):
1538         (WTR::TestController::didReceiveAuthenticationChallenge):
1539         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1540         * WebKitTestRunner/TestController.h:
1541         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1542         * WebKitTestRunner/TestInvocation.cpp:
1543         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1544         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1545         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1546
1547 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1548
1549         [ews-build] Add build step to print bot Configuration
1550         https://bugs.webkit.org/show_bug.cgi?id=193887
1551
1552         Reviewed by Lucas Forschler.
1553
1554         * BuildSlaveSupport/ews-build/steps.py:
1555         (PrintConfiguration): Build step to print configuration.
1556         * BuildSlaveSupport/ews-build/factories.py:
1557
1558 2019-01-29  Chris Dumez  <cdumez@apple.com>
1559
1560         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1561         https://bugs.webkit.org/show_bug.cgi?id=193967
1562         <rdar://problem/47635348>
1563
1564         Reviewed by Alex Christensen.
1565
1566         Add API test coverage.
1567
1568         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1569         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1570
1571 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1572
1573         [ews-app] Handle incoming results data
1574         https://bugs.webkit.org/show_bug.cgi?id=193973
1575
1576         Reviewed by Lucas Forschler.
1577
1578         * BuildSlaveSupport/ews-app/ews/views/results.py:
1579
1580 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1581
1582         [ews-app] Make the results url generic
1583         https://bugs.webkit.org/show_bug.cgi?id=193928
1584
1585         Reviewed by Lucas Forschler.
1586
1587         * BuildSlaveSupport/ews-app/ews/urls.py:
1588
1589 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1590
1591         [ews-build] Configure buildbot to send events to ews-app
1592         https://bugs.webkit.org/show_bug.cgi?id=193968
1593
1594         Reviewed by Lucas Forschler.
1595
1596         * BuildSlaveSupport/ews-build/events.py: Added.
1597         * BuildSlaveSupport/ews-build/master.cfg:
1598
1599 2019-01-29  Keith Rollin  <krollin@apple.com>
1600
1601         Add .xcfilelists to Run Script build phases
1602         https://bugs.webkit.org/show_bug.cgi?id=193792
1603         <rdar://problem/47201785>
1604
1605         Reviewed by Alex Christensen.
1606
1607         As part of supporting XCBuild, update the necessary Run Script build
1608         phases in their Xcode projects to refer to their associated
1609         .xcfilelist files.
1610
1611         Note that the addition of these files bumps the Xcode project version
1612         number to something that's Xcode 10 compatible. This change means that
1613         older versions of the Xcode IDE can't read these projects. Nor can it
1614         fully load workspaces that refer to these projects (the updated
1615         projects are shown as non-expandable placeholders). `xcodebuild` can
1616         still build these projects; it's just that the IDE can't open them.
1617
1618         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1619         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1620
1621 2019-01-29  John Wilander  <wilander@apple.com>
1622
1623         Add data abstraction and validation for Ad Click Attribution
1624         https://bugs.webkit.org/show_bug.cgi?id=193916
1625         <rdar://problem/47603481>
1626
1627         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1628
1629         Ad click attribution has two steps. First, the storage of an ad
1630         campaign ID for a click that takes the user to a destination
1631         site. Second, a conversion on the destination site that can be
1632         attributed to the ad click.
1633
1634         This patch adds a class that represents a request for ad click
1635         attribution. Validation makes sure that the bits of entropy
1636         reported through this mechanism is limited.
1637
1638         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1639         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1640         (TestWebKitAPI::TEST):
1641
1642 2019-01-29  Chris Dumez  <cdumez@apple.com>
1643
1644         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1645         https://bugs.webkit.org/show_bug.cgi?id=193932
1646         <rdar://problem/47598947>
1647
1648         Reviewed by Brady Eidson.
1649
1650         Add API test coverage.
1651
1652         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1653
1654 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1655
1656         Adding new passing LFC tests.
1657
1658         Unreviewed test gardening.
1659
1660         * LayoutReloaded/misc/LFC-passing-tests.txt:
1661
1662 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1663
1664         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1665         https://bugs.webkit.org/show_bug.cgi?id=193964
1666
1667         Reviewed by Antti Koivisto.
1668
1669         * LayoutReloaded/misc/LFC-passing-tests.txt:
1670
1671 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1672
1673         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1674         https://bugs.webkit.org/show_bug.cgi?id=193954
1675
1676         Reviewed by Antti Koivisto.
1677
1678         * LayoutReloaded/misc/LFC-passing-tests.txt:
1679
1680 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1681
1682         WebDriver: add support for running subtests
1683         https://bugs.webkit.org/show_bug.cgi?id=193904
1684
1685         Reviewed by Michael Catanzaro.
1686
1687         pytest already supports it by passing test.py::subtest, so we can do the same.
1688
1689         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1690         (get_item_name): Made this global.
1691         (CollectRecorder.__init__): Receive the parameter to ignore.
1692         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1693         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1694         (collect): Add parameter to ignore.
1695         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1696         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1697         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1698         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1699         (WebDriverTestRunnerSelenium.run): Ditto.
1700         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1701         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1702         (WebDriverTestRunnerW3C.run): Ditto.
1703
1704 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1705
1706         User agent string override for navigator.userAgent should be site specific quirks
1707         https://bugs.webkit.org/show_bug.cgi?id=193950
1708
1709         Reviewed by Brent Fulgham.
1710
1711         Updated per the _WKWebsitePolicies rename.
1712
1713         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1714         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1715
1716 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1717
1718         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1719         https://bugs.webkit.org/show_bug.cgi?id=193941
1720
1721         Reviewed by Alex Christensen.
1722
1723         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1724         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1725         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1726         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1727         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1728         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1729         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1730         * TestWebKitAPI/Tests/WTF/Time.cpp:
1731         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1732         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1733         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1734         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1735
1736 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1737
1738         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1739
1740         * Scripts/webkitpy/common/config/contributors.json:
1741
1742 2019-01-28  Andy Estes  <aestes@apple.com>
1743
1744         [watchOS] Enable Parental Controls content filtering
1745         https://bugs.webkit.org/show_bug.cgi?id=193939
1746         <rdar://problem/46641912>
1747
1748         Reviewed by Ryosuke Niwa.
1749
1750         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1751
1752 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1753
1754         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1755         <https://webkit.org/b/193884>
1756
1757         Reviewed by Jiewen Tan.
1758
1759         * Scripts/webkitpy/style/checkers/cpp.py:
1760         (check_language): Add LocalAuthentication to
1761         `frameworks_with_soft_links`.
1762
1763 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1764
1765         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1766         https://bugs.webkit.org/show_bug.cgi?id=193891
1767
1768         Reviewed by Ross Kirsling.
1769
1770         There were three problems in window sizes of WebView and the host window.
1771         1. The sizes of pixel image output were incorrect.
1772         2. The host window is going to appear after window.resize was invoked.
1773         3. window.resize resized only the host window, not WebView.
1774
1775         This change solves them with a following approach.
1776         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1777         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1778            as well as DumpRenderTree in order to match the client area and the window area.
1779         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1780         d. PlatformWebView::setWindowFrame changes both window sizes.
1781         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1782
1783         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1784         (WTR::PlatformWebView::PlatformWebView): Create the host window
1785         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1786         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1787         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1788
1789 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1790
1791         [ews-app] Add method to save Step data to database
1792         https://bugs.webkit.org/show_bug.cgi?id=193890
1793
1794         Reviewed by Lucas Forschler.
1795
1796         * BuildSlaveSupport/ews-app/ews/models/step.py:
1797         (Step.save_step): Method to save step data.
1798         (Step.update_step): Method to update step data.
1799         (Step.get_existing_step): Method to fetch existing step from database.
1800         (Step.is_valid_result): Method to validate valid step result.
1801
1802 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1803
1804         [ews-app] Add method to save Build data to database
1805         https://bugs.webkit.org/show_bug.cgi?id=193735
1806
1807         Reviewed by Lucas Forschler.
1808
1809         * BuildSlaveSupport/ews-app/ews/models/build.py:
1810         (Build.save_build): Method to save build information to database.
1811         (Build.get_existing_build): Method to fetch existing build from database.
1812         (Build.is_valid_result): Method to validate build result.
1813         * BuildSlaveSupport/ews-app/ews/common/util.py:
1814         (is_valid_int_id): Method to validate valid id.
1815
1816 2019-01-28  Chris Dumez  <cdumez@apple.com>
1817
1818         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1819         https://bugs.webkit.org/show_bug.cgi?id=193915
1820         <rdar://problem/47560907>
1821
1822         Reviewed by Alex Christensen.
1823
1824         Add API test coverage.
1825
1826         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1827
1828 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1829
1830         [ews-app] Rename id variables
1831         https://bugs.webkit.org/show_bug.cgi?id=193883
1832
1833         Reviewed by Lucas Forschler.
1834
1835         * BuildSlaveSupport/ews-app/ews/models/build.py:
1836         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1837         * BuildSlaveSupport/ews-app/ews/models/step.py:
1838         * BuildSlaveSupport/ews-app/ews/urls.py:
1839         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1840         * BuildSlaveSupport/ews-app/ews/views/results.py:
1841         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1842
1843 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1844
1845         [ews-app] Allow certain fields to be empty
1846         https://bugs.webkit.org/show_bug.cgi?id=193892
1847
1848         Reviewed by Lucas Forschler.
1849
1850         * BuildSlaveSupport/ews-app/ews/models/build.py:
1851         * BuildSlaveSupport/ews-app/ews/models/step.py:
1852
1853 2019-01-28  Rob Buis  <rbuis@igalia.com>
1854
1855         Update MIME type parser
1856         https://bugs.webkit.org/show_bug.cgi?id=180526
1857
1858         Reviewed by Frédéric Wang.
1859
1860         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1861         (TestWebKitAPI::TEST):
1862
1863 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1864
1865         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1866         https://bugs.webkit.org/show_bug.cgi?id=193896
1867
1868         Reviewed by Antti Koivisto.
1869
1870         * LayoutReloaded/misc/LFC-passing-tests.txt:
1871
1872 2018-12-15  Darin Adler  <darin@apple.com>
1873
1874         Replace many uses of String::format with more type-safe alternatives
1875         https://bugs.webkit.org/show_bug.cgi?id=192742
1876
1877         Reviewed by Mark Lam.
1878
1879         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1880         (WTR::cacheTestRunnerCallback): Use makeString.
1881         * WebKitTestRunner/TestController.cpp:
1882         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1883         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1884
1885 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1886
1887         Use a load optimizer for some sites
1888         https://bugs.webkit.org/show_bug.cgi?id=193881
1889         <rdar://problem/46325455>
1890
1891         Reviewed by Brent Fulgham.
1892
1893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1894         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1895
1896 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1897
1898         AX: Introduce a static accessibility tree
1899         https://bugs.webkit.org/show_bug.cgi?id=193348
1900         <rdar://problem/47203295>
1901
1902         Reviewed by Ryosuke Niwa.
1903
1904         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1905
1906 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1907
1908         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1909         https://bugs.webkit.org/show_bug.cgi?id=193867
1910
1911         Reviewed by Antti Koivisto.
1912
1913         * LayoutReloaded/misc/LFC-passing-tests.txt:
1914
1915 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1916
1917         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1918         https://bugs.webkit.org/show_bug.cgi?id=193865
1919
1920         Reviewed by Antti Koivisto.
1921
1922         * LayoutReloaded/misc/LFC-passing-tests.txt:
1923
1924 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1925
1926         Need a mechanism to override navigator.userAgent
1927         https://bugs.webkit.org/show_bug.cgi?id=193762
1928         <rdar://problem/47504939>
1929
1930         Reviewed by Brent Fulgham.
1931
1932         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1933
1934         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1935         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1936         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1937
1938 2019-01-25  Dean Jackson  <dino@apple.com>
1939
1940         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1941         https://bugs.webkit.org/show_bug.cgi?id=193831
1942         <rdar://problem/47399263>
1943
1944         Reviewed by Chris Dumez.
1945
1946         Two new tests that exercise cross-origin and same-origin System
1947         Previews.
1948
1949         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1950
1951 2019-01-25  Keith Rollin  <krollin@apple.com>
1952
1953         Update Xcode projects with "Check .xcfilelists" build phase
1954         https://bugs.webkit.org/show_bug.cgi?id=193790
1955         <rdar://problem/47201374>
1956
1957         Reviewed by Alex Christensen.
1958
1959         Support for XCBuild includes specifying inputs and outputs to various
1960         Run Script build phases. These inputs and outputs are specified as
1961         .xcfilelist files. Once created, these .xcfilelist files need to be
1962         kept up-to-date. In order to check that they are up-to-date or not,
1963         add an Xcode build step that invokes an external script that performs
1964         the checking. If the .xcfilelists are found to be out-of-date, update
1965         them, halt the build, and instruct the developer to restart the build
1966         with up-to-date files.
1967
1968         At this time, the checking and regenerating is performed only if the
1969         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1970         who want to use this facility can set this variable and test out the
1971         checking/regenerating. Once it seems like there are no egregious
1972         issues that upset a developer's workflow, we'll unconditionally enable
1973         this facility.
1974
1975         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1976         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1977         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1978         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1979
1980 2019-01-25  Keith Rollin  <krollin@apple.com>
1981
1982         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1983         https://bugs.webkit.org/show_bug.cgi?id=193781
1984         <rdar://problem/47201153>
1985
1986         Reviewed by Alex Christensen.
1987
1988         Part of generating the .xcfilelists used as part of adopting XCBuild
1989         includes running `make DerivedSources.make` from a standalone script.
1990         It’s important for this invocation to have the same environment as
1991         when the actual build invokes `make DerivedSources.make`. If the
1992         environments are different, then the two invocations will provide
1993         different results. In order to get the same environment in the
1994         standalone script, have the script launch xcodebuild targeting the
1995         "Apply Configuration to XCFileLists" build target, which will then
1996         re-invoke our standalone script. The script is now running again, this
1997         time in an environment with all workspace, project, target, xcconfig
1998         and other environment variables established.
1999
2000         The "Apply Configuration to XCFileLists" build target accomplishes
2001         this task via a small embedded shell script that consists only of:
2002
2003             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2004
2005         The process that invokes "Apply Configuration to XCFileLists" first
2006         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2007         evaluated and exports it into the shell environment. When xcodebuild
2008         is invoked, it inherits the value of this variable and can `eval` the
2009         contents of that variable. Our external standalone script can then set
2010         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2011         of command-line parameters needed to restart itself in the appropriate
2012         state.
2013
2014         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2015         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2016
2017 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2018
2019         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2020         https://bugs.webkit.org/show_bug.cgi?id=193802
2021         <rdar://problem/46010580>
2022
2023         Reviewed by Andy Estes.
2024
2025         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2026         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2027         (TEST):
2028
2029 2019-01-25  Daniel Bates  <dabates@apple.com>
2030
2031         [iOS] uiController.keyDown() does not translate Control modified key
2032         https://bugs.webkit.org/show_bug.cgi?id=192898
2033
2034         Reviewed by Wenson Hsieh.
2035
2036         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2037         key translation, as applicable. Among other cases, key translation occurs when performing
2038         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2039         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2040         human pressing down and releasing key(s) using a hardware keyboard.
2041
2042         * WebKitTestRunner/ios/HIDEventGenerator.h:
2043         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2044         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2045
2046         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2047         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2048         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2049         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2050         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2051         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2052         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2053         (-[HIDEventGenerator longPress:completionBlock:]):
2054         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2055         Update code for above renaming.
2056
2057         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2058         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2059
2060         (-[HIDEventGenerator keyDown:]): Added.
2061         (-[HIDEventGenerator keyUp:]): Added.
2062         (-[HIDEventGenerator keyPress:completionBlock:]):
2063         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2064         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2065         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2066         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2067         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2068         (WTR::parseModifier): Deleted.
2069
2070 2019-01-25  Keith Rollin  <krollin@apple.com>
2071
2072         Complete the implementation of generate-xcfilelists
2073         https://bugs.webkit.org/show_bug.cgi?id=193782
2074
2075         Reviewed by Alex Christensen.
2076
2077         A preliminary version of generate-xcfilelists was added in r238008.
2078         This patch updates that script in order to:
2079
2080         - Support checking of .xcfilelists
2081         - Perform better execution of `make DerivedSources.make` by
2082           relaunching generate-xcfilelists under xcodebuild
2083         - Support incremental generation and checking of .xcfilelists
2084         - Support supplementary .xcfilelists files from WebKitAdditions
2085         - Support being wrapped by parallel version of generate-xcfilelists in
2086           Internal that adds support for (re)generating WebKit projects in
2087           that repo.
2088         - Support builds that have been performed in WebKitBuild as well as
2089           ~/Library/Developer/code/DerivedData
2090         - Increase robustness and debugging facilities.
2091
2092         * Scripts/generate-xcfilelists:
2093
2094 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2095
2096         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2097         https://bugs.webkit.org/show_bug.cgi?id=193297
2098         <rdar://problem/47158841>
2099
2100         Unreviewed test case fix.
2101
2102         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2103         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2104
2105         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2106         (TEST):
2107
2108 2019-01-25  Keith Rollin  <krollin@apple.com>
2109
2110         Update existing .xcfilelists
2111         https://bugs.webkit.org/show_bug.cgi?id=193791
2112         <rdar://problem/47201706>
2113
2114         Reviewed by Alex Christensen.
2115
2116         Many .xcfilelist files were added in r238824 in order to support
2117         XCBuild. Update these with recent changes to the set of build files
2118         and with the current generate-xcfilelist script.
2119
2120         * DumpRenderTree/DerivedSources-input.xcfilelist:
2121         * DumpRenderTree/DerivedSources-output.xcfilelist:
2122         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2123         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2124
2125 2019-01-25  Keith Rollin  <krollin@apple.com>
2126
2127         Fix missing dependencies in extract-dependencies-from-makefile
2128         https://bugs.webkit.org/show_bug.cgi?id=193783
2129         <rdar://problem/47201571>
2130
2131         Reviewed by Alex Christensen.
2132
2133         The extract-dependencies-from-makefile script generates .xcfilelists
2134         for XCBuild by invoking a makefile in --debug mode, parsing the
2135         dependency information in the output, and extracting information
2136         regarding targets and dependents. However, the way `make` emits this
2137         dependency information is not rigorous, and so we need to determine
2138         what lines to look for and parse by trial and error. This approach
2139         didn't coriginally atch all the information we needed to collect, so
2140         update the script to look for the additional lines we now know to look
2141         for.
2142
2143         * Scripts/extract-dependencies-from-makefile:
2144         (Parser):
2145         (Parser.addTarget):
2146         (Parser.addPrereq):
2147         (Parser.doParse):
2148
2149 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2150
2151         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2152         https://bugs.webkit.org/show_bug.cgi?id=193297
2153         <rdar://problem/47158841>
2154
2155         Reviewed by Alex Christensen.
2156
2157         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2158             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2159         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2160         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2161         activating the message used to trigger the callback when it is set.
2162
2163 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2164
2165         WKWebView.goBack should reload if there is a safe browsing warning
2166         https://bugs.webkit.org/show_bug.cgi?id=193805
2167         <rdar://problem/46908216>
2168
2169         Reviewed by Geoff Garen.
2170
2171         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2172         (+[Simple3LookupContext sharedLookupContext]):
2173         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2174         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2175         (TEST):
2176
2177 2019-01-25  Chris Dumez  <cdumez@apple.com>
2178
2179         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2180         https://bugs.webkit.org/show_bug.cgi?id=193788
2181         <rdar://problem/47531231>
2182
2183         Reviewed by Alex Christensen.
2184
2185         Add API test coverage.
2186
2187         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2188         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2189
2190 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2191
2192         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2193         https://bugs.webkit.org/show_bug.cgi?id=193771
2194
2195         Unreviewed infrastructure fix.
2196
2197         * Scripts/webkitpy/port/darwin.py:
2198         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2199
2200 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2201
2202         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2203
2204 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2205
2206         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2207
2208         * Scripts/webkitpy/common/config/contributors.json:
2209
2210 2019-01-25  Chris Dumez  <cdumez@apple.com>
2211
2212         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2213         https://bugs.webkit.org/show_bug.cgi?id=193779
2214         <rdar://problem/46170903>
2215
2216         Reviewed by Antti Koivisto.
2217
2218         Add API test that quickly navigates forward to a previous process without waiting for it to
2219         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2220         the process' previous page when reconnecting the it for the forward navigation.
2221
2222         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2223
2224 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2225
2226         Need a way for JavaScript (or bundle) code to participate in undo
2227         https://bugs.webkit.org/show_bug.cgi?id=190009
2228         <rdar://problem/44807048>
2229
2230         Reviewed by Ryosuke Niwa.
2231
2232         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2233         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2234
2235         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2236         (WTR::UIScriptController::lastUndoLabel const):
2237         (WTR::UIScriptController::firstRedoLabel const):
2238         (WTR::UIScriptController::platformUndoManager const):
2239         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2240         (WTR::UIScriptController::lastUndoLabel const):
2241         (WTR::UIScriptController::firstRedoLabel const):
2242         (WTR::UIScriptController::platformUndoManager const):
2243         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2244         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2245         (WTR::UIScriptController::lastUndoLabel const):
2246         (WTR::UIScriptController::firstRedoLabel const):
2247         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2248         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2249         (WTR::UIScriptController::lastUndoLabel const):
2250         (WTR::UIScriptController::firstRedoLabel const):
2251         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2252         (WTR::UIScriptController::platformUndoManager const):
2253         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2254         (WTR::UIScriptController::platformUndoManager const):
2255
2256 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2257
2258         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2259         https://bugs.webkit.org/show_bug.cgi?id=193824
2260
2261         Reviewed by Antti Koivisto.
2262
2263         * LayoutReloaded/misc/LFC-passing-tests.txt:
2264
2265 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2266
2267         Update macOS JSC bot configurations
2268         https://bugs.webkit.org/show_bug.cgi?id=193739
2269
2270         Reviewed by Alexey Proskuryakov.
2271
2272         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2274         (BubbleQueueServer): Move JSC EWS to Mojave section.
2275         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2276         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2277         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2278
2279 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2280
2281         [Win][WebKitTestRunner] Implement EventSenderProxy
2282         https://bugs.webkit.org/show_bug.cgi?id=193755
2283
2284         Reviewed by Don Olmstead.
2285
2286         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2287         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2288         (WTR::EventSenderProxy::dispatchMessage):
2289         (WTR::EventSenderProxy::EventSenderProxy):
2290         (WTR::EventSenderProxy::mouseDown):
2291         (WTR::EventSenderProxy::mouseUp):
2292         (WTR::EventSenderProxy::mouseMoveTo):
2293         (WTR::EventSenderProxy::mouseScrollBy):
2294         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2295
2296 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2297
2298         Unreviewed fix for API test failure after r240437.
2299
2300         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2301
2302         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2303
2304 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2305
2306         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2307         https://bugs.webkit.org/show_bug.cgi?id=193787
2308         <rdar://problem/47497634>
2309
2310         Reviewed by Alexey Proskuryakov.
2311
2312         * Scripts/webkitdirs.pm:
2313         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2314
2315 2019-01-24  Truitt Savell  <tsavell@apple.com>
2316
2317         Unreviewed, rolling out r240446.
2318
2319         Casued 5 API failures
2320
2321         Reverted changeset:
2322
2323         "Activate the WebResourceLoadStatisticsStore in the
2324         NetworkProcess and deactivate it in the UIProcess."
2325         https://bugs.webkit.org/show_bug.cgi?id=193297
2326         https://trac.webkit.org/changeset/240446
2327
2328 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2329
2330         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2331         https://bugs.webkit.org/show_bug.cgi?id=193741
2332         <rdar://problem/47135030>
2333
2334         Reviewed by Antti Koivisto and Simon Fraser.
2335
2336         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2337         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2338         (TestWebKitAPI::TEST):
2339
2340 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2341
2342         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2343         https://bugs.webkit.org/show_bug.cgi?id=193297
2344         <rdar://problem/47158841>
2345
2346         Reviewed by Alex Christensen.
2347
2348         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2349         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2350         activating the message used to trigger the callback when it is set.
2351
2352 2019-01-24  John Wilander  <wilander@apple.com>
2353
2354         Add Ad Click Attribution as an internal/experimental feature
2355         https://bugs.webkit.org/show_bug.cgi?id=193685
2356         <rdar://problem/47450399>
2357
2358         Reviewed by Brent Fulgham.
2359
2360         Added test option adClickAttributionEnabled.
2361
2362         * DumpRenderTree/TestOptions.cpp:
2363         (TestOptions::TestOptions):
2364         * DumpRenderTree/TestOptions.h:
2365         * DumpRenderTree/mac/DumpRenderTree.mm:
2366         (setWebPreferencesForTestOptions):
2367
2368 2019-01-24  Antti Koivisto  <antti@apple.com>
2369
2370         [PSON] Flash on back navigation on Mac
2371         https://bugs.webkit.org/show_bug.cgi?id=193716
2372         <rdar://problem/47148458>
2373
2374         Reviewed by Chris Dumez.
2375
2376         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2377
2378         Closing of the previous page is delayed so waiting for didFinishNavigation is
2379         not sufficient to guarantee we have received all the messages. Wait for them.
2380
2381 2019-01-24  Chris Dumez  <cdumez@apple.com>
2382
2383         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2384         https://bugs.webkit.org/show_bug.cgi?id=193761
2385         <rdar://problem/47456405>
2386
2387         Reviewed by Alex Christensen.
2388
2389         Add API test coverage.
2390
2391         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2392
2393 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2394
2395         webkitpy: Missing PID in crashlog name should not be fatal
2396         https://bugs.webkit.org/show_bug.cgi?id=193771
2397
2398         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2399         of raising an exception.
2400
2401         Reviewed by Lucas Forschler.
2402
2403         * Scripts/webkitpy/port/darwin.py:
2404         (DarwinPort._merge_crash_logs):
2405
2406 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2407
2408         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2409         https://bugs.webkit.org/show_bug.cgi?id=193746
2410
2411         Reviewed by Youenn Fablet.
2412
2413         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2414         so we'd best just not call it.
2415
2416         * Scripts/webkitpy/w3c/test_exporter.py:
2417         (WebPlatformTestExporter.create_branch_with_patch):
2418
2419 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2420
2421         Move FileSystem to WTF
2422         https://bugs.webkit.org/show_bug.cgi?id=193602
2423
2424         Reviewed by Yusuke Suzuki.
2425
2426         * DumpRenderTree/win/DumpRenderTree.cpp:
2427         * TestWebKitAPI/CMakeLists.txt:
2428         * TestWebKitAPI/PlatformGTK.cmake:
2429         * TestWebKitAPI/PlatformJSCOnly.cmake:
2430         * TestWebKitAPI/PlatformPlayStation.cmake:
2431         * TestWebKitAPI/PlatformWPE.cmake:
2432         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2433         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2434         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2435         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2436         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2437         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2438         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2439         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2440         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2441         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2442
2443 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2444
2445         [WPE] Remove hard dependency on subprocess32 for the API tests
2446
2447         Rubber-stamped by Carlos Garcia Campos.
2448
2449         * glib/api_test_runner.py:
2450         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2451         its presence only when running WPEQt tests.
2452
2453 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2454
2455         [GLIB] Expose JavaScriptCore options in GLib public API
2456         https://bugs.webkit.org/show_bug.cgi?id=188742
2457
2458         Reviewed by Michael Catanzaro.
2459
2460         Add a test for the new API.
2461
2462         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2463         (testsJSCOptions):
2464         (main):
2465
2466 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2467
2468         [GTK][WPE] Support JPEG 2000 images
2469         https://bugs.webkit.org/show_bug.cgi?id=186272
2470
2471         Reviewed by Žan Doberšek.
2472
2473         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2474
2475         * gtk/jhbuild.modules:
2476         * wpe/jhbuild.modules:
2477
2478 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2479
2480         check-webkit-style should warn when using soft-linking macros in a header
2481         <https://webkit.org/b/193750>
2482
2483         Reviewed by Darin Adler.
2484
2485         * Scripts/webkitpy/style/checkers/cpp.py:
2486         (check_language): Add softlink/header check by refactoring the
2487         softlink/framework check.
2488         (CppChecker): Enable softlink/header check by default.
2489         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2490         (CppStyleTest.test_softlink_framework): Rename from
2491         CppStyleTest.test_softlink() and change test framework name in
2492         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2493         files. Set file_name for macros that only appear in headers.
2494         (CppStyleTest.test_softlink_header): Add tests for using
2495         soft-link macros in headers.
2496
2497 2019-01-23  Chris Dumez  <cdumez@apple.com>
2498
2499         Deprecate API to limit the maximum number of WebProcesses
2500         https://bugs.webkit.org/show_bug.cgi?id=193725
2501         <rdar://problem/47464879>
2502
2503         Reviewed by Geoff Garen.
2504
2505         Update existing API tests to stop using deprecated API.
2506
2507         * MiniBrowser/mac/AppDelegate.m:
2508         (defaultConfiguration):
2509         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2510         (TestWebKitAPI::TEST):
2511         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2512         (TestWebKitAPI::TEST):
2513         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2514         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2515         (TEST):
2516         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2517         (TEST):
2518
2519 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2520
2521         [ews-app] Rename ews model buildermappings to buildermapping
2522         https://bugs.webkit.org/show_bug.cgi?id=193729
2523
2524         Reviewed by Lucas Forschler.
2525
2526         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2527         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2528         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2529
2530 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2531
2532         [ews-app] Rename ews model steps to step
2533         https://bugs.webkit.org/show_bug.cgi?id=193697
2534
2535         Reviewed by Lucas Forschler.
2536
2537         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2538         (Step): Renamed Steps to Step.
2539
2540 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2541
2542         Clean up IndexedDB files between tests
2543         https://bugs.webkit.org/show_bug.cgi?id=192796
2544         <rdar://problem/46824999>
2545
2546         Reviewed by Geoffrey Garen.
2547
2548         * DumpRenderTree/mac/DumpRenderTree.mm:
2549         (runTest):
2550         * WebKitTestRunner/TestController.cpp:
2551         (WTR::TestController::resetStateToConsistentValues):
2552         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2553         (WTR::RemoveAllIndexedDatabasesCallback):
2554         (WTR::TestController::ClearIndexedDatabases):
2555         * WebKitTestRunner/TestController.h:
2556         * WebKitTestRunner/TestInvocation.cpp:
2557         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2558
2559 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2560
2561         [ews-app] Rename ews model Builds to Build
2562         https://bugs.webkit.org/show_bug.cgi?id=193695
2563
2564         Reviewed by Lucas Forschler.
2565
2566         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2567         (Build): Renamed Builds to Build.
2568
2569 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2570
2571         webkitpy: Wait longer when launching WebKitTestRunner
2572         https://bugs.webkit.org/show_bug.cgi?id=193734
2573
2574         Reviewed by Aakash Jain.
2575
2576         * Scripts/webkitpy/port/simulator_process.py:
2577         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2578
2579 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2580
2581         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2582         https://bugs.webkit.org/show_bug.cgi?id=193182
2583         <rdar://problem/47452154>
2584
2585         Reviewed by Tim Horton.
2586
2587         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2588         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2589         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2590
2591         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2592         preventing later tests from recognizing gestures.
2593
2594         * WebKitTestRunner/ios/TestControllerIOS.mm:
2595         (WTR::TestController::platformResetStateToConsistentValues):
2596
2597         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2598
2599 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2600
2601         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2602         https://bugs.webkit.org/show_bug.cgi?id=193722
2603         <rdar://problem/47481475>
2604
2605         Reviewed by Lucas Forschler.
2606
2607         iPhone and iPad ports should both use the iOS config.
2608
2609         * Scripts/webkitpy/port/ios_simulator.py:
2610         (IPhoneSimulatorPort.__init__):
2611         (IPadSimulatorPort.__init__):
2612
2613 2019-01-23  Rob Buis  <rbuis@igalia.com>
2614
2615         Update MIME type parser
2616         https://bugs.webkit.org/show_bug.cgi?id=180526
2617
2618         Reviewed by Frédéric Wang.
2619
2620         Add unit tests for both parse modes of ParsedContentType.
2621
2622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2623         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2624         (TestWebKitAPI::TEST):
2625
2626 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2627
2628         [ews-app] fetch loop should not stop on network issues
2629         https://bugs.webkit.org/show_bug.cgi?id=193666
2630
2631         Reviewed by Lucas Forschler.
2632
2633         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2634         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2635
2636 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2637
2638         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2639         https://bugs.webkit.org/show_bug.cgi?id=189165
2640         <rdar://problem/47433765>
2641
2642         Reviewed by Tim Horton.
2643
2644         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2645         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2646         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2647         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2648         would make its way to the UI process by the time the layer tree commit is finished.
2649
2650         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2651         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2652         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2653         will fail because it asks for -_autofillContext too early.
2654
2655         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2656         is handled in the UI process.
2657
2658         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2659
2660         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2661         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2662         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2663         input session.
2664
2665         (-[AutofillTestView textInputHasAutofillContext]):
2666
2667         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2668
2669         * TestWebKitAPI/cocoa/TestWKWebView.h:
2670         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2671         (nextInputSessionChangeCount):
2672
2673         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2674         This includes changing the focused element from one to another.
2675
2676         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2677         (-[TestWKWebView didStartFormControlInteraction]):
2678         (-[TestWKWebView didEndFormControlInteraction]):
2679         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2680
2681         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2682         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2683         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2684         that doesn't require an input session to one that doesn't.
2685
2686 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2687
2688         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2689         <https://webkit.org/b/193676>
2690
2691         Reviewed by Alexey Proskuryakov.
2692
2693         * Scripts/webkitpy/style/checkers/cpp.py:
2694         (check_member_initialization_list):
2695         - Don't report missing whitespace around colon if the colon at
2696           the start of the line is formatted correctly.
2697         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2698         (WebKitStyleTest.test_member_initialization_list):
2699         - Add a test for a missing permutation of existing tests.
2700         - Add a test this false-positive.
2701         - Add blank lines between subtests to make them easier to read.
2702
2703 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2704
2705         [build.webkit.org] Unit-test failure after r237113
2706         https://bugs.webkit.org/show_bug.cgi?id=193669
2707
2708         Reviewed by Michael Catanzaro.
2709
2710         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2711         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2712         multiple or zero flags.
2713
2714 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2715
2716         Cache bytecode to disk
2717         https://bugs.webkit.org/show_bug.cgi?id=192782
2718         <rdar://problem/46084932>
2719
2720         Reviewed by Keith Miller.
2721
2722         Add test helper to execute bytecode-cache tests: it executes each test
2723         twice, the first with JSC_diskCachePath set to a temporary directory
2724         and second with JSC_forceDiskCache=true (in addition to the cache path)
2725         to guarantee that only the disk cache is being used and no new
2726         UnlinkedCodeBlocks are being created.
2727
2728         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2729         * Scripts/run-jsc-stress-tests:
2730
2731 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2732
2733         [css-logical] Implement flow-relative margin, padding and border shorthands
2734         https://bugs.webkit.org/show_bug.cgi?id=188697
2735
2736         Reviewed by Simon Fraser and Antti Koivisto.
2737
2738         * DumpRenderTree/TestOptions.cpp:
2739         (TestOptions::TestOptions):
2740         * DumpRenderTree/TestOptions.h:
2741         * DumpRenderTree/mac/DumpRenderTree.mm:
2742         (setWebPreferencesForTestOptions):
2743         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2744
2745         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2746         (JSONCSSPropertiesChecker.check_codegen_properties):
2747         Allow CSS property definitions to have a 'runtime-flag' parameter which
2748         disables the property when the specified runtime flag is disabled.
2749
2750 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2751
2752         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2753         https://bugs.webkit.org/show_bug.cgi?id=193643
2754
2755         Reviewed by Michael Catanzaro.
2756
2757         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2758         * wpe/jhbuild.modules: Ditto.
2759
2760 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2761
2762         [LFC][Floats] Take float top position into account when computing containing block height.
2763         https://bugs.webkit.org/show_bug.cgi?id=193655
2764
2765         Reviewed by Antti Koivisto.
2766
2767         * LayoutReloaded/misc/LFC-passing-tests.txt:
2768
2769 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2770
2771         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2772         <https://webkit.org/b/193645>
2773         <rdar://problem/47421574>
2774
2775         Reviewed by Alex Christensen.
2776
2777         - Now checks for local soft-linking of all frameworks that have
2778           their own *SoftLinking.{cpp,h,mm} files.
2779         - Changes softlink/uikit warning to softlink/framework.
2780
2781         * Scripts/webkitpy/style/checkers/cpp.py:
2782         (check_language):
2783         (CppChecker):
2784         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2785         (CppStyleTest):
2786
2787 2019-01-20  Saam Barati  <sbarati@apple.com>
2788
2789         Rollout r240210: It broke tests on iOS
2790         https://bugs.webkit.org/show_bug.cgi?id=193640
2791
2792         Unreviewed.
2793
2794         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2795         * Scripts/run-jsc-stress-tests:
2796
2797 2019-01-20  chris fleizach  <cfleizach@apple.com>
2798
2799         AX: Support returning relative frames for accessibility
2800         https://bugs.webkit.org/show_bug.cgi?id=193414
2801         <rdar://problem/47268501>
2802
2803         Reviewed by Zalan Bujtas.
2804
2805         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2806         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2807         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2808         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2809         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2810         (WTR::attributesOfElement):
2811         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2812
2813 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2814
2815         Unreviewed, add my new email address
2816
2817         * Scripts/webkitpy/common/config/contributors.json:
2818
2819 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2820
2821         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2822         https://bugs.webkit.org/show_bug.cgi?id=193617
2823
2824         Reviewed by Antti Koivisto.
2825
2826         * LayoutReloaded/misc/LFC-passing-tests.txt:
2827
2828 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2829
2830         Unreviewed, rolling out r240209.
2831
2832         Broke GTK/WPE injected bundle
2833
2834         Reverted changeset:
2835
2836         "AX: Support returning relative frames for accessibility"
2837         https://bugs.webkit.org/show_bug.cgi?id=193414
2838         https://trac.webkit.org/changeset/240209
2839
2840 2019-01-12  Dan Bernstein  <mitz@apple.com>
2841
2842         [Cocoa] Avoid importing directly from subumbrella frameworks
2843         https://bugs.webkit.org/show_bug.cgi?id=186016
2844         <rdar://problem/40591038>
2845
2846         Reviewed by Sam Weinig.
2847
2848         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2849           LaunchServices header.
2850         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2851           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2852         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2853           when using SDKs earlier than 10.13.
2854         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2855           and OTHER_CPLUSPLUSFLAGS.
2856         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2857           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2858         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2859           LaunchServices header.
2860
2861 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2862
2863         Cache bytecode to disk
2864         https://bugs.webkit.org/show_bug.cgi?id=192782
2865         <rdar://problem/46084932>
2866
2867         Reviewed by Keith Miller.
2868
2869         Add test helper to execute bytecode-cache tests: it executes each test
2870         twice, the first with JSC_diskCachePath set to a temporary directory
2871         and second with JSC_forceDiskCache=true (in addition to the cache path)
2872         to guarantee that only the disk cache is being used and no new
2873         UnlinkedCodeBlocks are being created.
2874
2875         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2876         * Scripts/run-jsc-stress-tests:
2877
2878 2019-01-20  chris fleizach  <cfleizach@apple.com>
2879
2880         AX: Support returning relative frames for accessibility
2881         https://bugs.webkit.org/show_bug.cgi?id=193414
2882         <rdar://problem/47268501>
2883
2884         Reviewed by Zalan Bujtas.
2885
2886         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2887         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2888         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2889         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2890         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2891         (WTR::attributesOfElement):
2892         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2893
2894 2019-01-20  Antoine Quint  <graouts@apple.com>
2895
2896         Add a POINTER_EVENTS feature flag
2897         https://bugs.webkit.org/show_bug.cgi?id=193577
2898         <rdar://problem/47408511>
2899
2900         Unreviewed. Also enable Pointer Events for iosmac.
2901
2902         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2903
2904 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2905
2906         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2907         https://bugs.webkit.org/show_bug.cgi?id=193613
2908
2909         Reviewed by Antti Koivisto.
2910
2911         * LayoutReloaded/misc/LFC-passing-tests.txt:
2912
2913 2019-01-19  Antoine Quint  <graouts@apple.com>
2914
2915         Add a POINTER_EVENTS feature flag
2916         https://bugs.webkit.org/show_bug.cgi?id=193577
2917
2918         Reviewed by Dean Jackson.
2919
2920         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2921
2922 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2923
2924         Disable the run-jsc-stress-test remote host key check [second round].
2925         https://bugs.webkit.org/show_bug.cgi?id=192988
2926
2927         Reviewed by Dewei Zhu.
2928
2929         * Scripts/run-jsc-stress-tests:
2930
2931 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2932
2933         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2934         https://bugs.webkit.org/show_bug.cgi?id=193597
2935
2936         Reviewed by Lucas Forschler.
2937
2938         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2939
2940 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2941
2942         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2943         https://bugs.webkit.org/show_bug.cgi?id=193595
2944
2945         Reviewed by Lucas Forschler.
2946
2947         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2948         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2949         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2950
2951 2019-01-18  Chris Dumez  <cdumez@apple.com>
2952
2953         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2954         https://bugs.webkit.org/show_bug.cgi?id=193588
2955         <rdar://problem/47131566>
2956
2957         Reviewed by Alex Christensen.
2958
2959         Add layout test coverage.
2960
2961         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2962
2963 2019-01-18  Jer Noble  <jer.noble@apple.com>
2964
2965         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2966         https://bugs.webkit.org/show_bug.cgi?id=189553
2967
2968         Reviewed by Tim Horton.
2969
2970         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2971
2972         * ContentExtensionTester/Configurations/Base.xcconfig:
2973         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2974         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2975         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2976         * ImageDiff/cg/Configurations/Base.xcconfig:
2977         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2978         * MiniBrowser/Configurations/Base.xcconfig:
2979         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2980         * MobileMiniBrowser/Configurations/Base.xcconfig:
2981         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2982         * Scripts/webkitpy/style/checker.py:
2983         (_all_categories):
2984         (FileType):
2985         (CheckerDispatcher._file_type):
2986         (CheckerDispatcher._create_checker):
2987         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2988         (SDKVariantChecker):
2989         (SDKVariantChecker.__init__):
2990         (SDKVariantChecker.check):
2991         * TestWebKitAPI/Configurations/Base.xcconfig:
2992         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2993         * WebEditingTester/Configurations/Base.xcconfig:
2994         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2995         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2996         * WebKitTestRunner/Configurations/Base.xcconfig:
2997         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2998         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2999         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3000
3001 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3002
3003         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3004         <https://webkit.org/b/193568>
3005         <rdar://problem/47381130>
3006
3007         Reviewed by Alex Christensen.
3008
3009         Make sure no one re-introduces UIKit soft-linking by adding a
3010         style rule.
3011
3012         * Scripts/webkitpy/style/checkers/cpp.py:
3013         (check_language): Add softlink/uikit check.
3014         (CppChecker): Enable softlink/uikit check.
3015         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3016         (CppStyleTest): Add test for softlink/uikit.
3017
3018 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3019
3020         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3021         https://bugs.webkit.org/show_bug.cgi?id=193584
3022
3023         Change "-dev" to "-devel".
3024
3025         Reviewed by Michael Catanzaro.
3026
3027         * gtk/install-dependencies:
3028
3029 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3030
3031         webkitpy: Add iPhone and iPad ports
3032         https://bugs.webkit.org/show_bug.cgi?id=193537
3033         <rdar://problem/47353390>
3034
3035         Reviewed by Lucas Forschler.
3036
3037         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3038         ports. Note that this separation is optional, the --ios-simulator command remains.
3039
3040         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3041         (RunTest.test_device_type_test_division): Drive-by fix.
3042         (RunTest.test_device_type_specific_listing): Ditto.
3043         (RunTest.test_ipad_test_division):
3044         (RunTest):
3045         (RunTest.test_ipad_listing):
3046         * Scripts/webkitpy/port/factory.py:
3047         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3048         (PortFactory):
3049         * Scripts/webkitpy/port/ios_simulator.py:
3050         (IPhoneSimulatorPort):
3051         (IPadSimulatorPort):
3052
3053 2019-01-18  Chris Dumez  <cdumez@apple.com>
3054
3055         Regression(PSON) Scroll position is not always restored properly when navigating back
3056         https://bugs.webkit.org/show_bug.cgi?id=193578
3057         <rdar://problem/47386331>
3058
3059         Reviewed by Tim Horton.
3060
3061         Add API test coverage.
3062
3063         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3064
3065 2019-01-18  Youenn Fablet  <youenn@apple.com>
3066
3067         Add a new SPI to request for cache storage quota increase
3068         https://bugs.webkit.org/show_bug.cgi?id=193323
3069
3070         Reviewed by Alex Christensen.
3071
3072         Implement WebsiteDataStore quota delegate to handle quota requests.
3073         By default, do not update quota.
3074         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3075
3076         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3077         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3078         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3079         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3080         * WebKitTestRunner/TestController.cpp:
3081         (WTR::TestController::allowCacheStorageQuotaIncrease):
3082         * WebKitTestRunner/TestController.h:
3083         * WebKitTestRunner/TestInvocation.cpp:
3084         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3085         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3086         (-[CacheStorageQuotaManager init]):
3087         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3088         (WTR::initializeWebViewConfiguration):
3089         (WTR::TestController::cocoaResetStateToConsistentValues):
3090         (WTR::TestController::allowCacheStorageQuotaIncrease):
3091
3092 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3093
3094         [ews-build] Pass owner to the triggered builds
3095         https://bugs.webkit.org/show_bug.cgi?id=193574
3096
3097         Reviewed by Lucas Forschler.
3098
3099         * BuildSlaveSupport/ews-build/factories.py:
3100         (BuildFactory.propertiesToPassToTriggers):
3101
3102 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3103
3104         [ews-app] Send patch author as a build property
3105         https://bugs.webkit.org/show_bug.cgi?id=193560
3106
3107         Reviewed by Lucas Forschler.
3108
3109         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3110         (BugzillaPatchFetcher.fetch):
3111
3112 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3113
3114         webkitpy: Implement device type specific expected results (Follow-up fix)
3115         https://bugs.webkit.org/show_bug.cgi?id=192162
3116         <rdar://problem/46345449>
3117
3118         Unreviewed infrastructure fix.
3119
3120         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3121         (Manager.run): Don't boot a device if no tests are available to run on it.
3122
3123 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3124
3125         webkitpy: Implement device type specific expected results (Follow-up fix)
3126         https://bugs.webkit.org/show_bug.cgi?id=192162
3127         <rdar://problem/46345449>
3128
3129         Unreviewed infrastructure fix.
3130
3131         * Scripts/webkitpy/api_tests/manager.py:
3132         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3133
3134 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3135
3136         webkitpy: Implement device type specific expected results (Part 2)
3137         https://bugs.webkit.org/show_bug.cgi?id=192162
3138         <rdar://problem/46345449>
3139
3140         Rubber-stamped by Aakash Jain.
3141
3142         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3143         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3144         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3145
3146         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3147         (LayoutTestFinder.find_tests): Pass device_type through.
3148         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3149         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3150         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3151         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3152         (Manager._collect_tests): Pass device type to test finder.
3153         (Manager._needs_web_platform_test):
3154         (Manager._prepare_lists): Index _expectations by device type.
3155         (Manager._test_input_for_file):
3156         (Manager._test_is_slow): Ditto.
3157         (Manager._test_should_dump_jsconsolelog_in_stderr):
3158         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3159         (Manager._get_test_inputs):
3160         (Manager._update_worker_count):
3161         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3162         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3163         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3164         the one which runs the test.
3165         (Manager._run_test_subset):
3166         (Manager._run_tests): Index _expectations by current_device_type.
3167         (Manager._print_expectation_line_for_test): Ditto.
3168         (Manager._print_expectations_for_subset): Ditto.
3169         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3170         Unlike run, this function will behave the same regardless of what devices are available.
3171         (Manager._custom_device_for_test): Deleted.
3172         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3173         (ManagerTest.test_uses_custom_device): Deleted.
3174         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3175         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3176         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3177         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3178         all of the expectations.
3179         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3180         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3181         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3182         (TestExpectations.__init__): Allow device_type to be passed through.
3183         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3184         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3185         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3186         (summarize_results):
3187         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3188         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3189         a test ran with, one must check all expectations to find the first non-skip expectation.
3190         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3191         (RunTest.test_device_type_test_division):
3192         (RunTest):
3193         (RunTest.test_device_type_specific_listing):
3194         * Scripts/webkitpy/port/base.py:
3195         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3196         (Port.supported_device_types): The result of this function will change based on what devices are available.
3197         * Scripts/webkitpy/port/device_port.py:
3198         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3199         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3200         can be used.
3201         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3202         any, or the DEFAULT_DEVICE_TYPES of the port.
3203         * Scripts/webkitpy/port/ios.py:
3204         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3205         * Scripts/webkitpy/port/ios_simulator.py:
3206         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3207         * Scripts/webkitpy/port/watch.py:
3208         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3209         * Scripts/webkitpy/port/watch_simulator.py:
3210         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3211         * Scripts/webkitpy/xcode/device_type.py:
3212         (DeviceType):
3213         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3214
3215 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3216
3217         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3218         https://bugs.webkit.org/show_bug.cgi?id=193575
3219
3220         Reviewed by Michael Catanzaro.
3221
3222         Allow the script to run without explicit port argument because
3223         it's specific to the WPE port anyway.
3224
3225         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3226         and simplify the rest of the code accordingly.
3227
3228 2019-01-18  Charlie Turner  <cturner@igalia.com>
3229
3230         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3231         https://bugs.webkit.org/show_bug.cgi?id=192229
3232
3233         Reviewed by Xabier Rodriguez-Calvar.
3234
3235         * MiniBrowser/wpe/main.cpp:
3236         (main): Enable encrypted-media by default.
3237
3238 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3239
3240         [Flatpak] Missing KeyboardInterrupt exception handler
3241         https://bugs.webkit.org/show_bug.cgi?id=193570
3242
3243         Reviewed by Michael Catanzaro.
3244
3245         * flatpak/flatpakutils.py:
3246         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3247
3248 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3249
3250         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3251         https://bugs.webkit.org/show_bug.cgi?id=193564
3252
3253         Reviewed by Antti Koivisto.
3254
3255         * LayoutReloaded/misc/LFC-passing-tests.txt:
3256
3257 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3258
3259         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3260         https://bugs.webkit.org/show_bug.cgi?id=193562
3261
3262         Reviewed by Antti Koivisto.
3263
3264         * LayoutReloaded/misc/LFC-passing-tests.txt:
3265
3266 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3267
3268         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3269         https://bugs.webkit.org/show_bug.cgi?id=193555
3270
3271         Reviewed by Antti Koivisto.
3272
3273         * LayoutReloaded/misc/LFC-passing-tests.txt:
3274
3275 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3276
3277         [WPE] Add Qt extension
3278         https://bugs.webkit.org/show_bug.cgi?id=191464
3279
3280         Reviewed by Carlos Garcia Campos.
3281
3282         MiniBrowser and API tests for the WPE Qt API. To run the
3283         MiniBrowser a new script is introduced. Example invocation:
3284
3285         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3286
3287         Also note-worthy is the introduction of the python2-subprocess32
3288         dependency to run the GLib API tests.
3289
3290         * MiniBrowser/wpe/CMakeLists.txt:
3291         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3292         * MiniBrowser/wpe/qt/main.cpp: Added.
3293         (main):
3294         * MiniBrowser/wpe/qt/main.qml: Added.
3295         * MiniBrowser/wpe/qt/qml.qrc: Added.
3296         * Scripts/run-gtk-tests:
3297         (GtkTestRunner.is_google_test):
3298         (GtkTestRunner):
3299         (GtkTestRunner.is_qt_test):
3300         * Scripts/run-qt-wpe-minibrowser: Added.
3301         * Scripts/run-wpe-tests:
3302         (WPETestRunner):
3303         (WPETestRunner.is_google_test):
3304         (WPETestRunner.is_qt_test):
3305         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3306         (TestLoad::main):
3307         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3308         (TestLoadHtml::main):
3309         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3310         (TestLoadRequest::main):
3311         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3312         (TestRunJavaScript::main):
3313         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3314         (waitForSignal):
3315         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3316         (LoadSpy::LoadSpy):
3317         (LoadSpy::~LoadSpy):
3318         (LoadSpy::onLoadingChanged):
3319         (LoadStartedCatcher::LoadStartedCatcher):
3320         (LoadStartedCatcher::~LoadStartedCatcher):
3321         (LoadStartedCatcher::onLoadingChanged):
3322         (waitForLoadSucceeded):
3323         (waitForLoadFailed):
3324         * TestWebKitAPI/glib/CMakeLists.txt:
3325         * flatpak/flatpakutils.py:
3326         (WebkitFlatpak.load_from_args):
3327         (WebkitFlatpak.__init__):
3328         (WebkitFlatpak.clean_args):
3329         (WebkitFlatpak.run_in_sandbox):
3330         * flatpak/org.webkit.CommonModules.yaml:
3331         * flatpak/org.webkit.WPE.yaml:
3332         * flatpak/org.webkit.WPEModules.yaml:
3333         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3334         * flatpak/org.webkit.WebKit.yaml:
3335         * glib/api_test_runner.py:
3336         (TestRunner._run_test_qt):
3337         (TestRunner.is_qt_test):
3338         (TestRunner._run_test):
3339
3340 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3341
3342         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3343         https://bugs.webkit.org/show_bug.cgi?id=193494
3344         <rdar://problem/46859627>
3345
3346         Reviewed by Simon Fraser and Tim Horton.
3347
3348         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3349         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3350
3351         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3352         (WTR::UIScriptController::contentOffsetX const):
3353         (WTR::UIScriptController::contentOffsetY const):
3354         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3355         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3356         (WTR::UIScriptController::contentOffsetX const):
3357         (WTR::UIScriptController::contentOffsetY const):
3358         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3359
3360         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3361
3362         * WebKitTestRunner/TestController.cpp:
3363         (WTR::updateTestOptionsFromTestHeader):
3364         * WebKitTestRunner/TestOptions.h:
3365         (WTR::TestOptions::hasSameInitializationOptions const):
3366         * WebKitTestRunner/ios/TestControllerIOS.mm:
3367         (WTR::TestController::platformResetStateToConsistentValues):
3368         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3369         (WTR::UIScriptController::contentOffsetX const):
3370         (WTR::UIScriptController::contentOffsetY const):
3371
3372 2019-01-17  Truitt Savell  <tsavell@apple.com>
3373
3374         Unreviewed, rolling out r240124.
3375
3376         This commit broke an internal build.
3377
3378         Reverted changeset:
3379
3380         "SDK_VARIANT build destinations should be separate from non-
3381         SDK_VARIANT builds"
3382         https://bugs.webkit.org/show_bug.cgi?id=189553
3383         https://trac.webkit.org/changeset/240124
3384
3385 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3386
3387         Fix string concatenation API test after r239920
3388         https://bugs.webkit.org/show_bug.cgi?id=193551
3389         <rdar://problem/47359304>
3390
3391         Reviewed by Youenn Fablet.
3392
3393         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3394         (TestWebKitAPI::TEST):
3395         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3396         in WebKit's build configuration like it apparently is on Linux.
3397
3398 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3399
3400         [ews-build] validate-patch should handle the case when bug_id is None
3401         https://bugs.webkit.org/show_bug.cgi?id=193547
3402
3403         Reviewed by Lucas Forschler.
3404
3405         * BuildSlaveSupport/ews-build/steps.py:
3406         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3407         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3408
3409 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3410
3411         [ews-build] Add patch author information in build
3412         https://bugs.webkit.org/show_bug.cgi?id=193465
3413
3414         Reviewed by Lucas Forschler.
3415
3416         * BuildSlaveSupport/ews-build/steps.py:
3417         (ValidatePatch._is_patch_obsolete):
3418
3419 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3420
3421         [ews-build] Pass bug_id to the triggered builds
3422         https://bugs.webkit.org/show_bug.cgi?id=193548
3423
3424         Reviewed by Lucas Forschler.
3425
3426         * BuildSlaveSupport/ews-build/factories.py:
3427         (BuildFactory.propertiesToPassToTriggers):
3428
3429 2019-01-17  Jer Noble  <jer.noble@apple.com>
3430
3431         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3432         https://bugs.webkit.org/show_bug.cgi?id=189553
3433
3434         Reviewed by Tim Horton.
3435
3436         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3437
3438         * ContentExtensionTester/Configurations/Base.xcconfig:
3439         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3440         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3441         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3442         * ImageDiff/cg/Configurations/Base.xcconfig:
3443         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3444         * MiniBrowser/Configurations/Base.xcconfig:
3445         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3446         * MobileMiniBrowser/Configurations/Base.xcconfig:
3447         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3448         * Scripts/webkitpy/style/checker.py:
3449         (_all_categories):
3450         (FileType):
3451         (CheckerDispatcher._file_type):
3452         (CheckerDispatcher._create_checker):
3453         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3454         (SDKVariantChecker):
3455         (SDKVariantChecker.__init__):
3456         (SDKVariantChecker.check):
3457         * TestWebKitAPI/Configurations/Base.xcconfig:
3458         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3459         * WebEditingTester/Configurations/Base.xcconfig:
3460         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3461         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3462         * WebKitTestRunner/Configurations/Base.xcconfig:
3463         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3464         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3465         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3466
3467 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3468
3469         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3470         https://bugs.webkit.org/show_bug.cgi?id=193534
3471
3472         Reviewed by Antti Koivisto.
3473
3474         * LayoutReloaded/misc/LFC-passing-tests.txt:
3475
3476 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3477
3478         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3479         https://bugs.webkit.org/show_bug.cgi?id=193528
3480
3481         Reviewed by Antti Koivisto.
3482
3483         * LayoutReloaded/misc/LFC-passing-tests.txt:
3484
3485 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3486
3487         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3488         https://bugs.webkit.org/show_bug.cgi?id=193520
3489
3490         Reviewed by Antti Koivisto.
3491
3492         * LayoutReloaded/misc/LFC-passing-tests.txt:
3493
3494 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3495
3496         [ews-build] unapply-patch step should not update source
3497         https://bugs.webkit.org/show_bug.cgi?id=193234
3498
3499         Reviewed by Lucas Forschler.
3500
3501         * BuildSlaveSupport/ews-build/steps.py:
3502         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3503         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3504
3505 2019-01-16  Youenn Fablet  <youenn@apple.com>
3506
3507         Add a new SPI for controlling getUserMedia
3508         https://bugs.webkit.org/show_bug.cgi?id=192793
3509
3510         Reviewed by Eric Carlson.
3511
3512         * MiniBrowser/mac/WK2BrowserWindowController.m:
3513         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3514         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3515         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3516         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3517         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3518         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3519         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3520         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3521         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3522         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3523         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3524         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3525         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3526         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3527
3528 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3529
3530         [LFC][BFC] Inflow non-replaced used width should not be negative.
3531         https://bugs.webkit.org/show_bug.cgi?id=193495
3532
3533         Reviewed by Antti Koivisto.
3534
3535         * LayoutReloaded/misc/LFC-passing-tests.txt:
3536
3537 2019-01-16  Chris Dumez  <cdumez@apple.com>
3538
3539         Regression(PSON) View becomes blank after click a cross-site download link
3540         https://bugs.webkit.org/show_bug.cgi?id=193361
3541         <rdar://problem/47099573>
3542
3543         Reviewed by Geoffrey Garen.
3544
3545         Add API test coverage.
3546
3547         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3548         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3549
3550 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3551
3552         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3553         https://bugs.webkit.org/show_bug.cgi?id=193470
3554
3555         Reviewed by Antti Koivisto.
3556
3557         * LayoutReloaded/misc/LFC-passing-tests.txt:
3558
3559 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3560
3561         [LFC] Adjust margin box verification.
3562         https://bugs.webkit.org/show_bug.cgi?id=193482
3563
3564         Reviewed by Antti Koivisto.
3565
3566         * LayoutReloaded/misc/LFC-passing-tests.txt:
3567
3568 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3569
3570         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3571         https://bugs.webkit.org/show_bug.cgi?id=193451
3572
3573         Reviewed by Geoffrey Garen.
3574
3575         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3576         (TEST):
3577         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3578         (runWebsiteDataStoreCustomPaths):
3579
3580 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3581
3582         webkitpy: Support boolean simctl isAvailable
3583         https://bugs.webkit.org/show_bug.cgi?id=193472
3584         <rdar://problem/47296150>
3585
3586         Reviewed by Ryosuke Niwa.
3587
3588         * Scripts/webkitpy/xcode/simulated_device.py:
3589         (SimulatedDeviceManager._create_runtimes):
3590         (SimulatedDeviceManager._create_device_with_runtime):
3591
3592 2019-01-15  Chris Dumez  <cdumez@apple.com>
3593
3594         Unreviewed, rolling out r239993, r239995, r239997, and
3595         r239999.
3596
3597         Caused assertions under
3598         ViewGestureController::disconnectFromProcess()
3599
3600         Reverted changesets:
3601
3602         "Regression(PSON) View becomes blank after click a cross-site
3603         download link"
3604         https://bugs.webkit.org/show_bug.cgi?id=193361
3605         https://trac.webkit.org/changeset/239993
3606
3607         "Unreviewed iOS build fix after r239993."
3608         https://trac.webkit.org/changeset/239995
3609
3610         "Fix iOS build after r239993"
3611         https://bugs.webkit.org/show_bug.cgi?id=193361
3612         https://trac.webkit.org/changeset/239997
3613
3614         "Unreviewed, revert part of r239997 as it is not needed to fix
3615         the build."
3616         https://trac.webkit.org/changeset/239999
3617
3618 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3619
3620         Cannot tab out of WKWebView on macOS
3621         https://bugs.webkit.org/show_bug.cgi?id=161448
3622         <rdar://problem/28100085>
3623
3624         Reviewed by Dean Jackson.
3625
3626         Add a test that tabbing into and out of WKWebView works correctly.
3627
3628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3629         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3630         (WebKit2_CommandBackForwardTest::SetUp):
3631         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3632         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3633         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3634         (-[FocusableView canBecomeKeyView]):
3635         (TEST):
3636         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3637         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3638         (-[OffscreenWindow initWithSize:]):
3639         (-[OffscreenWindow isKeyWindow]):
3640         (-[OffscreenWindow isVisible]):
3641         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3642         (TestWebKitAPI::PlatformWebView::initialize):
3643         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3644         (-[ActiveOffscreenWindow isVisible]): Deleted.
3645         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3646
3647 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3648
3649         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3650         https://bugs.webkit.org/show_bug.cgi?id=193459
3651
3652         Reviewed by Mark Lam.
3653
3654         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3655         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3656
3657 2019-01-15  Chris Dumez  <cdumez@apple.com>
3658
3659         Regression(PSON) View becomes blank after click a cross-site download link
3660         https://bugs.webkit.org/show_bug.cgi?id=193361
3661         <rdar://problem/47099573>
3662
3663         Reviewed by Geoff Garen.
3664
3665         Add API test coverage.
3666
3667         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3668         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3669
3670 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3671
3672         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3673         https://bugs.webkit.org/show_bug.cgi?id=193448
3674
3675         Reviewed by Antti Koivisto.
3676
3677         * LayoutReloaded/misc/LFC-passing-tests.txt:
3678
3679 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3680
3681         webkitpy: Implement device type specific expected results (Part 1)
3682         https://bugs.webkit.org/show_bug.cgi?id=192162
3683
3684         Reviewed by Lucas Forschler.
3685
3686         Device type specific expected results covers two related ideas. The first (covered by this change)
3687         is where to search for -expected.* files. The second is which tests to run based on the
3688         TestExpectations.txt file.
3689
3690         After this change, the baseline search path will be determined by the type of device running a
3691         test. Device type will be passed into any function which picks a file based on the baseline search
3692         path.
3693
3694         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3695         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3696         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3697         (Manager.run): Print baseline search path for each round of devices.
3698         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3699         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3700         (SingleTestRunner._expected_driver_output): Ditto.
3701         (SingleTestRunner._driver_input): Ditto.
3702         * Scripts/webkitpy/layout_tests/views/printing.py:
3703         (Printer.print_config): Move printing of baseline search path to a separate function.
3704         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3705         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3706         (Testprinter.test_print_config):
3707         (Testprinter.test_print_baseline_search_path):
3708         * Scripts/webkitpy/port/base.py:
3709         (Port.baseline_search_path): Pass device_type through.
3710         (Port._expected_baselines_for_suffixes): Ditto.
3711         (Port.expected_baselines): Ditto.
3712         (Port.expected_filename): Ditto.
3713         (Port.expected_checksum): Ditto.
3714         (Port.expected_image): Ditto.
3715         (Port.expected_audio): Ditto.
3716         (Port.expected_text): Ditto.
3717         (Port.reference_files): Ditto.
3718         (Port.tests): Ditto.
3719         (Port._expanded_paths): Ditto.
3720         (Port.skipped_layout_tests): Ditto.
3721         (Port.expectations_dict): Ditto.
3722         (Port._port_specific_expectations_files): Ditto.
3723         (Port.expectations_files): Ditto.
3724         (Port.test_search_path): Ditto.
3725         (Port._tests_for_other_platforms): Ditto.
3726         * Scripts/webkitpy/port/base_unittest.py:
3727         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3728         (PortTest.test_nonexistant_expectations): Ditto.
3729         (test_ref_tests_platform_directory): Ditto.
3730         * Scripts/webkitpy/port/darwin.py:
3731         (DarwinPort._port_specific_expectations_files): Accept device_type.
3732         * Scripts/webkitpy/port/driver.py:
3733         (DriverProxy):
3734         (DriverProxy.host): Expose _target_host for device_type information.
3735         * Scripts/webkitpy/port/gtk.py:
3736         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3737         * Scripts/webkitpy/port/ios.py:
3738         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3739         * Scripts/webkitpy/port/mac.py:
3740         (MacPort. default_baseline_search_path): Ditto.
3741         * Scripts/webkitpy/port/port_testcase.py:
3742         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3743         * Scripts/webkitpy/port/test.py:
3744         * Scripts/webkitpy/port/watch.py:
3745         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3746         * Scripts/webkitpy/port/win.py:
3747         (WinPort.test_search_path): Accept, but do not use, device_type.
3748         * Scripts/webkitpy/port/wpe.py:
3749         (WPEPort._port_specific_expectations_files): Ditto.
3750         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3751         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3752
3753 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3754
3755         [LFC] Use the containing block's padding box to position out-of-flow elements.
3756         https://bugs.webkit.org/show_bug.cgi?id=193431
3757
3758         Reviewed by Antti Koivisto.
3759
3760         * LayoutReloaded/misc/LFC-passing-tests.txt:
3761
3762 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3763
3764         Move a test implementation file that got misplaced in the Xcode project
3765
3766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3767
3768 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3769
3770         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3771         r239913, and r239914.
3772         https://bugs.webkit.org/show_bug.cgi?id=193407
3773
3774         These revisions caused an internal failure (Requested by
3775         Truitt on #webkit).
3776
3777         Reverted changesets:
3778
3779         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3780         https://bugs.webkit.org/show_bug.cgi?id=186016
3781         https://trac.webkit.org/changeset/239901
3782
3783         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3784         https://trac.webkit.org/changeset/239909
3785
3786         "Tried to fix the build."
3787         https://trac.webkit.org/changeset/239910
3788
3789         "Fixed iOS builds after r239910."
3790         https://trac.webkit.org/changeset/239912
3791
3792         "More build fixing."
3793         https://trac.webkit.org/changeset/239913
3794
3795         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3796         https://trac.webkit.org/changeset/239914
3797
3798 2019-01-14  Mark Lam  <mark.lam@apple.com>
3799
3800         Re-enable ability to build --cloop builds.
3801         https://bugs.webkit.org/show_bug.cgi?id=192955
3802         <rdar://problem/46882363>
3803
3804         Reviewed by Saam barati and Keith Miller.
3805
3806         The --cloop build option was being ignored this whole time since r236381.
3807         This patch makes it possible to build CLoop builds again.
3808
3809         * Scripts/build-jsc:
3810         * Scripts/webkitperl/FeatureList.pm:
3811         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3812
3813 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3814
3815         webkitpy: Expose device_type from host-like objects
3816         https://bugs.webkit.org/show_bug.cgi?id=193406
3817         <rdar://problem/47262305>
3818
3819         Reviewed by Lucas Forschler.
3820
3821         Devices should expose device_type. As a result, all host objects should
3822         provide a device_type property, even if they do not yet define a device_type.
3823
3824         * Scripts/webkitpy/common/system/systemhost.py:
3825         (SystemHost):
3826         (SystemHost.device_type):
3827         * Scripts/webkitpy/common/system/systemhost_mock.py:
3828         (MockSystemHost):
3829         (MockSystemHost.device_type):
3830         * Scripts/webkitpy/port/device.py:
3831         (Device):
3832         (Device.device_type):
3833         * Scripts/webkitpy/xcode/simulated_device.py:
3834         (SimulatedDeviceManager._find_exisiting_device_for_request):
3835         (SimulatedDeviceManager._disambiguate_device_type):
3836         (SimulatedDeviceManager._does_fulfill_request):
3837         (SimulatedDeviceManager.device_count_for_type):
3838         (SimulatedDeviceManager.initialize_devices):
3839         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3840         (test_available_devices):
3841         (test_swapping_devices):
3842
3843 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3844
3845         webkitpy: Support alternate simctl device list output (Follow-up fix)
3846         https://bugs.webkit.org/show_bug.cgi?id=193362
3847         <rdar://problem/47122965>
3848
3849         Rubber-stamped by Lucas Forschler.
3850
3851         * Scripts/webkitpy/xcode/simulated_device.py:
3852         (SimulatedDeviceManager.populate_available_devices):
3853
3854 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3855
3856         [iOS] Expose SPI to access the current sentence boundary and selection state
3857         https://bugs.webkit.org/show_bug.cgi?id=193398
3858         <rdar://problem/45893108>
3859
3860         Reviewed by Dean Jackson.
3861
3862         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3863         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3864         expected.
3865
3866         * TestWebKitAPI/EditingTestHarness.h:
3867         * TestWebKitAPI/EditingTestHarness.mm:
3868         (-[EditingTestHarness moveBackward]):
3869         (-[EditingTestHarness moveForward]):
3870         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3871
3872         Add a couple of new helper methods on EditingTestHarness.
3873
3874         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3875         (-[SelectionChangeObserver initWithWebView:]):
3876         (-[SelectionChangeObserver webView]):
3877         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3878         (-[SelectionChangeObserver currentSelectionAttributes]):
3879
3880 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3881
3882         [LFC][BFC] Add basic box-sizing support.
3883         https://bugs.webkit.org/show_bug.cgi?id=193392
3884
3885         Reviewed by Antti Koivisto.
3886
3887         * LayoutReloaded/misc/LFC-passing-tests.txt:
3888
3889 2019-01-14  Charlie Turner  <cturner@igalia.com>
3890
3891         [WPE] API test gardening
3892         https://bugs.webkit.org/show_bug.cgi?id=193319
3893
3894         Reviewed by Michael Catanzaro.
3895
3896         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3897         passing tests.
3898
3899 2019-01-14  Charlie Turner  <cturner@igalia.com>
3900
3901         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3902         https://bugs.webkit.org/show_bug.cgi?id=192977
3903
3904         Reviewed by Carlos Garcia Campos.
3905
3906         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3907         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3908         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3909         (TestWebKitAPI::GStreamerTest::SetUp):
3910         (TestWebKitAPI::GStreamerTest::TearDown):
3911         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3912         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3913         (TestWebKitAPI::TEST_F):
3914
3915 2019-01-14  Charlie Turner  <cturner@igalia.com>
3916
3917         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3918         https://bugs.webkit.org/show_bug.cgi?id=193332
3919
3920         Reviewed by Michael Catanzaro.
3921
3922         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3923         defined as a char16_t, which changed in ICU 59, the
3924         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3925         unsigned short. This test is relying on the behaviour that
3926         UChar=unsigned short, which doesn't hold across platforms and ICU
3927         library versions. The full fix would be a special syntax for
3928         literal characters so that these ambiguities do not arise. That
3929         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3930         (TestWebKitAPI::TEST):
3931
3932 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3933
3934         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3935
3936         * Scripts/make-dist:
3937         (Distcheck.configure):
3938
3939 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3940
3941         [ews-build] Update macOS queue configurations
3942         https://bugs.webkit.org/show_bug.cgi?id=193365
3943         <rdar://problem/47221073>
3944
3945         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3946
3947         * BuildSlaveSupport/ews-build/config.json:
3948
3949 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3950
3951         [LFC] Adjust assert for statically positioned fixed elements
3952         https://bugs.webkit.org/show_bug.cgi?id=193385
3953
3954         Reviewed by Antti Koivisto.
3955
3956         * LayoutReloaded/misc/LFC-passing-tests.txt:
3957
3958 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3959
3960         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3961         https://bugs.webkit.org/show_bug.cgi?id=193387
3962
3963         Reviewed by Carlos Garcia Campos.
3964
3965         * MiniBrowser/wpe/main.cpp:
3966         (main):
3967
3968 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3969
3970         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3971         https://bugs.webkit.org/show_bug.cgi?id=191655
3972         rdar://problem/46074680
3973
3974         Reviewed by Megan Gardner.
3975
3976         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3977         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3978
3979 2019-01-12  Dan Bernstein  <mitz@apple.com>
3980
3981         [Cocoa] Avoid importing directly from subumbrella frameworks
3982         https://bugs.webkit.org/show_bug.cgi?id=186016
3983         <rdar://problem/40591038>
3984
3985         Reviewed by Sam Weinig.
3986
3987         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3988           LaunchServices header.
3989         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3990           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3991         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3992           when using SDKs earlier than 10.13.
3993         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3994           and OTHER_CPLUSPLUSFLAGS.
3995         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3996           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3997         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3998           LaunchServices header.
3999
4000 2019-01-11  John Wilander  <wilander@apple.com>
4001
4002         Compile out Web API Statistics Collection
4003         https://bugs.webkit.org/show_bug.cgi?id=193370
4004         <rdar://problem/45388584>
4005
4006         Reviewed by Brent Fulgham.
4007
4008         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4009             Defined ENABLE_WEB_API_STATISTICS, off by default.
4010
4011 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4012
4013         [WPE] Add gtk-doc
4014         https://bugs.webkit.org/show_bug.cgi?id=178900
4015
4016         Reviewed by Michael Catanzaro.
4017
4018         Add Tools/gtkdoc to manifest.txt.in files.
4019         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
4020
4021         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
4022         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
4023
4024 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4025
4026         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
4027         https://bugs.webkit.org/show_bug.cgi?id=193364
4028         <rdar://problem/47214117>
4029
4030         Reviewed by Tim Horton.
4031
4032         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
4033         precise, whereas dragging near the middle of the textarea does.
4034
4035         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4036         (TestWebKitAPI::TEST):
4037
4038 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4039
4040         webkitpy: Support alternate simctl device list output
4041         https://bugs.webkit.org/show_bug.cgi?id=193362
4042         <rdar://problem/47122965>
4043
4044         Reviewed by Lucas Forschler.
4045
4046         * Scripts/webkitpy/xcode/simulated_device.py:
4047         (SimulatedDeviceManager.populate_available_devices):
4048
4049 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
4050
4051         [ews-build] Update macOS queue configurations
4052         https://bugs.webkit.org/show_bug.cgi?id=193365
4053
4054         Reviewed by Lucas Forschler.
4055
4056         * BuildSlaveSupport/ews-build/config.json:
4057
4058 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4059
4060         webkitpy: Incorporate device type into baseline search path
4061         https://bugs.webkit.org/show_bug.cgi?id=193356
4062         <rdar://problem/47215515>
4063
4064         Reviewed by Lucas Forschler.
4065
4066         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
4067
4068         * Scripts/webkitpy/port/base.py:
4069         (Port.default_baseline_search_path): Allow device type to be passed in.
4070         * Scripts/webkitpy/port/gtk.py:
4071         (GtkPort.default_baseline_search_path): Ignore device type.
4072         * Scripts/webkitpy/port/ios.py:
4073         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
4074         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
4075         * Scripts/webkitpy/port/ios_device_unittest.py:
4076         (IOSDeviceTest):
4077         * Scripts/webkitpy/port/ios_simulator_unittest.py:
4078         (IOSSimulatorTest):
4079         * Scripts/webkitpy/port/mac.py:
4080         (MacPort.default_baseline_search_path): Ignore device type.
4081         * Scripts/webkitpy/port/watch.py:
4082         (WatchPort.default_baseline_search_path): Ditto.
4083         * Scripts/webkitpy/port/win.py:
4084         (WinPort.default_baseline_search_path): Ditto.
4085         (WinCairoPort.default_baseline_search_path): Ditto.
4086         * Scripts/webkitpy/port/wpe.py:
4087         (WPEPort.default_baseline_search_path): Ditto.
4088
4089 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4090
4091         webkitpy: Print abbreviated baseline search path that includes only folders that exist
4092         https://bugs.webkit.org/show_bug.cgi?id=193352
4093         <rdar://problem/47210736>
4094
4095         Reviewed by Lucas Forschler.
4096
4097         * Scripts/webkitpy/layout_tests/views/printing.py:
4098         (Printer.print_config): Print list on only baseline search paths which exist. 
4099         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4100         (Testprinter.test_print_config):
4101
4102 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
4103
4104         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
4105         https://bugs.webkit.org/show_bug.cgi?id=193340
4106
4107         Reviewed by David Kilzer.
4108
4109         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4110         (WTR::InjectedBundle::didReceiveMessageToPage):
4111         Pull the strings out into a WKRetainPtr.
4112
4113         * WebKitTestRunner/WebNotificationProvider.cpp:
4114         (WTR::WebNotificationProvider::closeWebNotification):
4115         Adopt the created value into the WKRetainPtr.
4116
4117         * WebKitTestRunner/mac/TestControllerMac.mm:
4118         (WTR::generateWhitelist):
4119         Immediately adopt a created value to avoid potential mistakes.
4120
4121 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
4122
4123         Enable DFG on ARM/Linux again
4124         https://bugs.webkit.org/show_bug.cgi?id=192496
4125
4126         Reviewed by Yusuke Suzuki.
4127
4128         After changing the bytecode format DFG was disabled on all 32-bit
4129         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
4130         on ARM by default.
4131
4132         * Scripts/run-jsc-stress-tests:
4133
4134 2019-01-11  Timothy Hatcher  <timothy@apple.com>
4135
4136         Unreviewed, fix #ifdef in API test added in r239851.
4137         https://bugs.webkit.org/show_bug.cgi?id=193327
4138         rdar://problem/47093222
4139
4140         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
4141
4142 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4143
4144         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
4145         https://bugs.webkit.org/show_bug.cgi?id=193109
4146         <rdar://problem/44807048>
4147
4148         Reviewed by Ryosuke Niwa.
4149
4150         Introduce and respect a test option to enable the UndoManager API.
4151
4152         * WebKitTestRunner/TestController.cpp:
4153         (WTR::updateTestOptionsFromTestHeader):
4154         * WebKitTestRunner/TestOptions.h:
4155         (WTR::TestOptions::hasSameInitializationOptions const):
4156         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4157         (WTR::TestController::platformCreateWebView):
4158
4159 2019-01-11  Zalan Bujtas  <zalan@apple.com>
4160
4161         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
4162         https://bugs.webkit.org/show_bug.cgi?id=193346
4163
4164         Reviewed by Antti Koivisto.
4165
4166         * LayoutReloaded/misc/LFC-passing-tests.txt:
4167
4168 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
4169
4170         Unreviewed, fix typo that breaks dashboard link.
4171
4172         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4173         (WebKitBuildbot):
4174
4175 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
4176
4177         Update macOS queue configurations
4178         https://bugs.webkit.org/show_bug.cgi?id=193329
4179
4180         Reviewed by Alexey Proskuryakov.
4181
4182         * BuildSlaveSupport/build.webkit.org-config/config.json:
4183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4184         (BubbleQueueServer):
4185         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4186         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4187         (WebKitBuildbot):
4188         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4189         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
4190         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4191
4192 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
4193
4194         MiniBrowser should be able to navigate to about:blank
4195         https://bugs.webkit.org/show_bug.cgi?id=193345
4196
4197         Reviewed by Simon Fraser.
4198
4199         * MiniBrowser/mac/BrowserWindowController.m:
4200         (-[BrowserWindowController addProtocolIfNecessary:]):
4201         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
4202
4203         * MiniBrowser/mac/WK1BrowserWindowController.m:
4204         (-[WK1BrowserWindowController fetch:]):
4205         * MiniBrowser/mac/WK2BrowserWindowController.m:
4206         (-[WK2BrowserWindowController fetch:]):
4207         Clean up the code that uses this to match style.
4208
4209 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
4210
4211         Remove MiniBrowser custom "Process Swap" menu item which does not work
4212         https://bugs.webkit.org/show_bug.cgi?id=193344
4213
4214         Reviewed by Simon Fraser.
4215
4216         There is a menu item under the Experimental menu that does work.
4217
4218         * MiniBrowser/mac/AppDelegate.m:
4219         (defaultConfiguration):
4220         * MiniBrowser/mac/SettingsController.h:
4221         * MiniBrowser/mac/SettingsController.m:
4222         (-[SettingsController _populateMenu]):
4223         (-[SettingsController validateMenuItem:]):
4224         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
4225         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
4226
4227 2019-01-10  Timothy Hatcher  <timothy@apple.com>
4228
4229         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
4230         https://bugs.webkit.org/show_bug.cgi?id=193327
4231         rdar://problem/47093222
4232
4233         Reviewed by Tim Horton.
4234
4235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4236         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
4237         (TestWebKitAPI::didFinishNavigation):
4238         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
4239         (TestWebKitAPI::TEST):
4240         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
4241         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
4242         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
4243         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
4244         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
4245
4246 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
4247
4248         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
4249         https://bugs.webkit.org/show_bug.cgi?id=193338
4250         <rdar://problem/46664774>
4251
4252         Reviewed by David Kilzer.
4253
4254         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4255         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
4256
4257 2019-01-10  Commit Queue  <commit-queue@webkit.org>
4258
4259         Unreviewed, rolling out r239825.
4260         https://bugs.webkit.org/show_bug.cgi?id=193330
4261
4262         Broke tests on armv7/linux bots (Requested by guijemont on
4263         #webkit).
4264
4265         Reverted changeset:
4266
4267         "Enable DFG on ARM/Linux again"
4268         https://bugs.webkit.org/show_bug.cgi?id=192496
4269         https://trac.webkit.org/changeset/239825
4270
4271 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
4272
4273         Disable the run-jsc-stress-test remote host key check.
4274         https://bugs.webkit.org/show_bug.cgi?id=192988
4275
4276         Reviewed by Alexey Proskuryakov.
4277
4278         * Scripts/run-jsc-stress-tests:
4279
4280 2019-01-10  John Wilander  <wilander@apple.com>
4281
4282         Override the session configuration for cookieAcceptPolicy
4283         https://bugs.webkit.org/show_bug.cgi?id=190925
4284         <rdar://problem/45497382>
4285
4286         Reviewed by Alexey Proskuryakov and Alex Christensen.
4287
4288         Test infrastructure for setting a first-party-only cookie policy.
4289
4290         * DumpRenderTree/TestRunner.cpp:
4291         (setOnlyAcceptFirstPartyCookiesCallback):
4292         (TestRunner::staticFunctions):
4293         * DumpRenderTree/TestRunner.h:
4294         * DumpRenderTree/mac/TestRunnerMac.mm:
4295         (TestRunner::setOnlyAcceptFirstPartyCookies):
4296         * DumpRenderTree/win/TestRunnerWin.cpp:
4297         (TestRunner::setOnlyAcceptFirstPartyCookies):
4298         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4299         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4300         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
4301         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4302         * WebKitTestRunner/TestInvocation.cpp:
4303         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4304
4305 2019-01-09  Matt Rajca  <mrajca@apple.com>
4306
4307         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
4308         https://bugs.webkit.org/show_bug.cgi?id=193301
4309
4310         Reviewed by Jer Noble.
4311         
4312         Added API tests.
4313
4314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4315         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4316         (TEST):
4317         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
4318
4319 2019-01-10  Zalan Bujtas  <zalan@apple.com>
4320
4321         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
4322         https://bugs.webkit.org/show_bug.cgi?id=193310
4323
4324         Reviewed by Antti Koivisto.
4325
4326         * LayoutReloaded/misc/LFC-passing-tests.txt:
4327
4328 2019-01-10  Dominik Infuehr  <d