Allow sharing from imageSheet on an image document
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2
3         Allow sharing from imageSheet on an image document
4         https://bugs.webkit.org/show_bug.cgi?id=196891
5         <rdar://problem/25377386>
6
7         Reviewed by Tim Horton.
8
9         Test to make sure that the correct imageURL is extracted from an image element.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
12         (TestWebKitAPI::TEST):
13
14 2019-04-16  Alex Christensen  <achristensen@webkit.org>
15
16         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
17         https://bugs.webkit.org/show_bug.cgi?id=196995
18
19         Reviewed by Brady Eidson.
20
21         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
22         (TEST):
23
24 2019-04-16  Chris Dumez  <cdumez@apple.com>
25
26         URL set by document.open() is not communicated to the UIProcess
27         https://bugs.webkit.org/show_bug.cgi?id=196941
28         <rdar://problem/49237544>
29
30         Reviewed by Geoff Garen.
31
32         Add API test coverage.
33
34         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
35         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
36         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
37         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
38         (TEST):
39
40 2019-04-16  Commit Queue  <commit-queue@webkit.org>
41
42         Unreviewed, rolling out r244321.
43         https://bugs.webkit.org/show_bug.cgi?id=196968
44
45         Causing all WK2 Debug builds to exit early after Assertion
46         failures. (Requested by ShawnRoberts on #webkit).
47
48         Reverted changeset:
49
50         "URL set by document.open() is not communicated to the
51         UIProcess"
52         https://bugs.webkit.org/show_bug.cgi?id=196941
53         https://trac.webkit.org/changeset/244321
54
55 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
56
57         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
58         https://bugs.webkit.org/show_bug.cgi?id=196948
59
60         Reviewed by Zalan Bujtas.
61
62         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
63         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
64
65 2019-04-15  Chris Dumez  <cdumez@apple.com>
66
67         URL set by document.open() is not communicated to the UIProcess
68         https://bugs.webkit.org/show_bug.cgi?id=196941
69         <rdar://problem/49237544>
70
71         Reviewed by Geoffrey Garen.
72
73         Add API test coverage.
74
75         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
76         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
77         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
78         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
79         (TEST):
80
81 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
82
83         Using Tools/Scripts/clean-webkit should not install requests
84         https://bugs.webkit.org/show_bug.cgi?id=196940
85
86         Reviewed by Lucas Forschler.
87
88         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
89         existing, depending on the path autoinstalled is run through.
90         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
91         needed.
92         (Port.configuration_for_upload):
93         (Port.commits_for_upload):
94
95 2019-04-15  Alex Christensen  <achristensen@webkit.org>
96
97         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
98         https://bugs.webkit.org/show_bug.cgi?id=196773
99
100         Reviewed by Jer Noble.
101
102         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
103         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
104         (TEST):
105
106 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
107
108         ews-build should clearly indicate flaky test failures
109         https://bugs.webkit.org/show_bug.cgi?id=196947
110
111         Reviewed by Lucas Forschler.
112
113         * BuildSlaveSupport/ews-build/steps.py:
114         (AnalyzeAPITestsResults.analyzeResults):
115
116 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
117
118         InjectedBundle parameters often need initialization function called before unarchiving
119         https://bugs.webkit.org/show_bug.cgi?id=189709
120         <rdar://problem/44573653>
121
122         Reviewed by Ryosuke Niwa.
123
124         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
125         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
126
127 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
128
129         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
130         https://bugs.webkit.org/show_bug.cgi?id=196681
131
132         Reviewed by Darin Adler.
133
134         Added tests.
135
136         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
137         (WTF_HashSet.RemoveIf):
138         (WTF_HashSet.RemoveIfShrinkToBestSize):
139
140 2019-04-15  John Wilander  <wilander@apple.com>
141
142         Send delayed Ad Click Attribution conversion requests to the click source
143         https://bugs.webkit.org/show_bug.cgi?id=196838
144         <rdar://problem/47650157>
145
146         Reviewed by Chris Dumez and Youenn Fablet.
147
148         This patch adds test infrastructure to override the default behavior in
149         WebKit::NetworkAdClickAttribution.
150
151         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
152         (TestWebKitAPI::TEST):
153         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
154         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
155         (WTR::TestRunner::dumpAdClickAttribution):
156         (WTR::TestRunner::clearAdClickAttribution):
157         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
158         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
159         * WebKitTestRunner/InjectedBundle/TestRunner.h:
160         * WebKitTestRunner/TestController.cpp:
161         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
162         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
163         * WebKitTestRunner/TestController.h:
164         * WebKitTestRunner/TestInvocation.cpp:
165         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
166
167 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
168
169         [ews-app] status-bubble should display position in queue
170         https://bugs.webkit.org/show_bug.cgi?id=196607
171
172         Reviewed by Lucas Forschler.
173
174         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
175         (StatusBubble._build_bubble):
176         (StatusBubble._queue_position): Method to calculate patch's position in queue.
177
178 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
179
180         [ews-build] Do not run clean build by default on EWS builders
181         https://bugs.webkit.org/show_bug.cgi?id=196897
182
183         Reviewed by Lucas Forschler.
184
185         * BuildSlaveSupport/ews-build/steps.py:
186         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
187         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
188         untracked directories like WebKitBuild).
189         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
190         untracked files/directories (like WebKitBuild).
191
192 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
193
194         TestRunner::notifyDone() should be safely reentrant
195         https://bugs.webkit.org/show_bug.cgi?id=196898
196
197         Reviewed by Darin Adler.
198
199         It is currently possible that TestRunner::notifyDone() will call itself, since
200         notifyDone() will force a repaint, which can start executing JavaScript, which
201         may call notifyDone() again. This can lead to test failures and flakiness.
202         Fix this by setting the m_waitToDump flag before calling the dump() method.
203
204         * DumpRenderTree/mac/TestRunnerMac.mm:
205         (TestRunner::notifyDone):
206         (TestRunner::forceImmediateCompletion):
207         * DumpRenderTree/win/TestRunnerWin.cpp:
208         (TestRunner::notifyDone):
209         (TestRunner::forceImmediateCompletion):
210
211 2019-04-15  Philippe Normand  <pnormand@igalia.com>
212
213         [GTK][WPE] Add enable-media websetting
214         https://bugs.webkit.org/show_bug.cgi?id=196863
215
216         Reviewed by Michael Catanzaro.
217
218         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
219         (testWebKitSettings): Add test for the enable-media web-setting.
220
221 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
222
223         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
224         https://bugs.webkit.org/show_bug.cgi?id=196905
225         <rdar://problem/49886096>
226
227         Reviewed by Tim Horton.
228
229         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
230         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
231         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
232         delay timer, we end up with this sequence of events in the problematic (failure) case:
233
234         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
235             ...IPC from UI to web process...
236         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
237             ...IPC from web to UI process...
238         (c) [UI]    Invoke completion handler for script #1
239         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
240             ...IPC from UI to web process...
241         (e) [Web]   Evaluate script #2 in the web process
242         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
243
244         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
245         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
246         #2 is run in step (e).
247
248         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
249         the UI process by waiting on a script message posted by the web process, after attachment updates are
250         dispatched.
251
252         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
253         (TestWebKitAPI::TEST):
254
255 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
256
257         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
258         https://bugs.webkit.org/show_bug.cgi?id=196909
259
260         Reviewed by Wenson Hsieh.
261
262         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
263         (TestWebKitAPI::TEST):
264
265 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
266
267         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
268         https://bugs.webkit.org/show_bug.cgi?id=196880
269
270         Reviewed by Yusuke Suzuki.
271
272         Add a new function for bytecode cache tests that does not forceDiskCache
273         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
274         test added in this patch, since the code is invalid and therefore won't be
275         cached. It should also be useful for tests that evaluate dynamically
276         generated code.
277
278         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
279         * Scripts/run-jsc-stress-tests:
280
281 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
282
283         Update AudioSession route sharing policy
284         https://bugs.webkit.org/show_bug.cgi?id=196776
285         <rdar://problem/46501611>
286
287         Reviewed by Jer Noble.
288
289         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
290         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
291         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
292         (TestWebKitAPI::TEST):
293
294 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
295
296         [iOS] Software keyboard is shown too frequently on some websites
297         https://bugs.webkit.org/show_bug.cgi?id=195856
298         <rdar://problem/49191395>
299
300         Reviewed by Darin Adler.
301
302         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
303
304         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
305         (WTR::UIScriptController::setHardwareKeyboardAttached):
306         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
307         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
308         (WTR::UIScriptController::setHardwareKeyboardAttached):
309         * TestRunnerShared/UIScriptContext/UIScriptController.h:
310         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
311
312         Additionally link against GraphicsServices in WebKitTestRunner.
313
314         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
315         (WTR::TestController::platformResetStateToConsistentValues):
316         (WTR::UIScriptController::setHardwareKeyboardAttached):
317
318 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
319
320         [GTK][WPE] Fix pacman install-dependencies packages
321         https://bugs.webkit.org/show_bug.cgi?id=196817
322
323         Reviewed by Žan Doberšek.
324         
325         python3-setuptools is called python-setuptools
326         ruby-highline is only available on AUR
327         libv4l-devel is incorporated in v4l-utils
328
329         * gtk/install-dependencies:
330         * wpe/install-dependencies:
331
332 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
333
334         [GTK] REGRESSION(r243860): Many tests failing
335         https://bugs.webkit.org/show_bug.cgi?id=196791
336
337         Reviewed by Joanmarie Diggs.
338
339         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
340         multiple documents and check that accessibility hierarchy is updated after a navigation.
341
342         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
343         (loadChangedCallback):
344         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
345         (AccessibilityTest::AccessibilityTest):
346         (AccessibilityTest::~AccessibilityTest):
347         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
348         (AccessibilityTest::findTestServerApplication):
349         (AccessibilityTest::findDocumentWeb):
350         (AccessibilityTest::findRootObject):
351         (AccessibilityTest::waitUntilChildrenRemoved):
352         (AccessibilityTest::ensureProxy):
353         (testAtspiBasicHierarchy):
354         (beforeAll):
355         (afterAll):
356
357 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
358
359         [ews-build] Handle bug titles with unicode characters
360         https://bugs.webkit.org/show_bug.cgi?id=196802
361
362         Reviewed by Dewei Zhu.
363
364         * BuildSlaveSupport/ews-build/steps.py:
365         (ValidatePatch._is_bug_closed):
366
367 2019-04-11  Michael Saboff  <msaboff@apple.com>
368
369         Improve the Inline Cache Stats code
370         https://bugs.webkit.org/show_bug.cgi?id=196836
371
372         Reviewed by Saam Barati.
373
374         Added a new script to consolidate and arrange the output of --useICStats option.
375
376         This script merges the output from every group into one large table and sorts it from most common to
377         least common.  It also counts the slow path GetById and PutById variants and then calculates the
378         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
379         Put together, this is useful to see what property accesses are not getting cached.
380
381         * Scripts/ic-stats.py: Added.
382         (ICStats):
383         (ICStats.__init__):
384         (ICStats.parse):
385         (ICStats.dumpStats):
386         (usage):
387
388 2019-04-10  Alex Christensen  <achristensen@webkit.org>
389
390         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
391         https://bugs.webkit.org/show_bug.cgi?id=196809
392         <rdar://49800762>
393
394         Reviewed by Brady Eidson.
395
396         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
397         (TEST):
398
399 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
400
401         requestAnimationFrame should execute before the next frame
402         https://bugs.webkit.org/show_bug.cgi?id=177484
403
404         Reviewed by Simon Fraser.
405
406         Add trace points for the page RenderingUpdate.
407
408         * Tracing/SystemTracePoints.plist:
409
410 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
411
412         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
413         https://bugs.webkit.org/show_bug.cgi?id=196760
414
415         Reviewed by Don Olmstead.
416
417         vswhere.exe has been bundled since Visual Studio 2017 version
418         15.2. We shouldn't download vswhere.exe.
419
420         * Scripts/build-jsc: Do not call update-vswhere.py.
421         * Scripts/build-webkit: Ditto.
422         * Scripts/update-vswhere.py: Removed.
423         * Scripts/webkitdirs.pm:
424         (requireModulesForVSWhere): Deleted.
425         (pickCurrentVisualStudioInstallation): Deleted.
426         (visualStudioInstallDirVSWhere): Return the latest installed VS
427         installation path by using the bundled vswhere.exe.
428         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
429         (visualStudioInstallDirFallback): Removed.
430
431 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
432
433         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
434         https://bugs.webkit.org/show_bug.cgi?id=196780
435
436         Reviewed by Alexey Proskuryakov.
437
438         * BuildSlaveSupport/ews-build/steps.py:
439         * BuildSlaveSupport/ews-build/steps_unittest.py:
440
441 2019-04-10  Alex Christensen  <achristensen@webkit.org>
442
443         Add SPI WKNavigationResponse._downloadAttribute
444         https://bugs.webkit.org/show_bug.cgi?id=196755
445         <rdar://49587365>
446
447         Reviewed by Brady Eidson.
448
449         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
450         (-[NavigationResponseTestDelegate navigationResponse]):
451         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
452         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
453         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
454         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
455         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
456         (readRequest):
457         (writeResponse):
458         (TEST):
459
460 2019-04-10  Tim Horton  <timothy_horton@apple.com>
461
462         Add modern API for overriding the page's specified viewport configuration
463         https://bugs.webkit.org/show_bug.cgi?id=167734
464         <rdar://problem/30331795>
465
466         Reviewed by Simon Fraser.
467
468         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
469         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
470
471 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
472
473         Add support for incremental bytecode cache updates
474         https://bugs.webkit.org/show_bug.cgi?id=195000
475
476         Reviewed by Filip Pizlo.
477
478         Exit when the initial run to generate bytecode fails.
479
480         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
481
482 2019-04-10  Alex Christensen  <achristensen@webkit.org>
483
484         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
485         https://bugs.webkit.org/show_bug.cgi?id=196744
486         <rdar://49415309>
487
488         Reviewed by Chris Dumez.
489
490         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
491         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
492
493 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
494
495         Add a way to opt into modern compatibility mode in layout tests
496         https://bugs.webkit.org/show_bug.cgi?id=196770
497         <rdar://problem/49777550>
498
499         Reviewed by Antoine Quint.
500
501         Add a new test option to enable modern compatibility mode in layout tests.
502
503         * WebKitTestRunner/TestController.cpp:
504         (WTR::updateTestOptionsFromTestHeader):
505         * WebKitTestRunner/TestController.h:
506         * WebKitTestRunner/TestOptions.h:
507         (WTR::TestOptions::hasSameInitializationOptions const):
508         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
509         (WTR::TestController::platformCreateWebView):
510         (WTR::TestController::enableModernCompatibilityMode):
511
512 2019-04-10  Andy Estes  <aestes@apple.com>
513
514         Try to fix the 32-bit watchOS build.
515
516         * TestWebKitAPI/cocoa/TestWKWebView.mm:
517         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
518
519 2019-04-10  Antoine Quint  <graouts@apple.com>
520
521         Enable Pointer Events on watchOS
522         https://bugs.webkit.org/show_bug.cgi?id=196771
523         <rdar://problem/49040909>
524
525         Reviewed by Dean Jackson.
526
527         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
528
529 2019-04-10  Philippe Normand  <pnormand@igalia.com>
530
531         Unreviewed. Fix WPE accessibility tests after r244059.
532
533         We are failing to load the injected bundle due to undefined symbol
534         AccessibilityUIElement::replaceTextInRange().
535
536         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
537         (WTR::AccessibilityUIElement::replaceTextInRange):
538
539 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
540
541         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
542         https://bugs.webkit.org/show_bug.cgi?id=196727
543
544         Reviewed by Fujii Hironori.
545
546         * MiniBrowser/win/WebKitBrowserWindow.cpp:
547         (WebKitBrowserWindow::create):
548
549 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
550
551         [ews-build] Add unit tests for PrintConfiguration
552         https://bugs.webkit.org/show_bug.cgi?id=196752
553
554         Reviewed by Dewei Zhu.
555
556         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
557
558 2019-04-09  Keith Rollin  <krollin@apple.com>
559
560         Unreviewed build maintenance -- update .xcfilelists.
561
562         * DumpRenderTree/DerivedSources-input.xcfilelist:
563         * DumpRenderTree/DerivedSources-output.xcfilelist:
564
565 2019-04-09  Zalan Bujtas  <zalan@apple.com>
566
567         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
568         https://bugs.webkit.org/show_bug.cgi?id=196743
569         <rdar://problem/43897551>
570
571         Reviewed by Tim Horton.
572
573         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
574         (TEST):
575
576 2019-04-09  Youenn Fablet  <youenn@apple.com>
577
578         Close service worker database on network process suspension
579         https://bugs.webkit.org/show_bug.cgi?id=196623
580         <rdar://problem/48930869>
581
582         Reviewed by Alex Christensen.
583
584         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
585
586 2019-04-09  Daniel Bates  <dabates@apple.com>
587
588         [iPad] Should open popover when the spacebar is pressed
589         https://bugs.webkit.org/show_bug.cgi?id=196360
590         <rdar://problem/49389129>
591
592         Reviewed by Brent Fulgham.
593
594         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
595
596         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
597         (WTR::UIScriptController::isShowingPopover const): Added.
598         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
599         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
600         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
601         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
602         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
603         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
604         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
605         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
606         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
607         (WTR::UIScriptController::isShowingPopover const): Added.
608         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
609         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
610         * TestRunnerShared/UIScriptContext/UIScriptController.h:
611         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
612         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
613         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
614         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
615         (-[TestRunnerWKWebView _willPresentPopover]): Added.
616         (-[TestRunnerWKWebView _didDismissPopover]): Added.
617         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
618         (WTR::UIScriptController::isShowingPopover const): Added.
619         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
620         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
621
622 2019-04-09  Alex Christensen  <achristensen@webkit.org>
623
624         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
625         https://bugs.webkit.org/show_bug.cgi?id=196665
626         <rdar://45115669>
627
628         Reviewed by Geoff Garen.
629
630         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
631         (goBack):
632         (+[SimpleLookupContext sharedLookupContext]):
633         (-[SimpleLookupContext lookUpURL:completionHandler:]):
634         (TEST):
635         (+[Simple3LookupContext sharedLookupContext]): Deleted.
636         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
637
638 2019-04-09  John Wilander  <wilander@apple.com>
639
640         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
641         https://bugs.webkit.org/show_bug.cgi?id=196558
642         <rdar://problem/47650245>
643
644         Reviewed by Youenn Fablet.
645
646         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
647         (TestWebKitAPI::TEST):
648             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
649
650 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
651
652         [CMake] Apple builds should use ICU_INCLUDE_DIRS
653         https://bugs.webkit.org/show_bug.cgi?id=196720
654
655         Reviewed by Konstantin Tokarev.
656
657         * TestWebKitAPI/PlatformMac.cmake:
658
659 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
660
661         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
662         https://bugs.webkit.org/show_bug.cgi?id=196694
663         <rdar://problem/48388734>
664
665         Rubber-stamped by Aakash Jain.
666
667         * Scripts/webkitpy/port/image_diff.py:
668         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
669         * Scripts/webkitpy/port/server_process.py:
670         (ServerProcess.has_available_stdout): Check if stdout has data in it.
671         (ServerProcess._wait_for_data_and_update_buffers_using_select):
672         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
673         * Scripts/webkitpy/port/server_process_mock.py:
674         (MockServerProcess.has_available_stdout):
675         * Scripts/webkitpy/port/server_process_unittest.py:
676         (TestServerProcess.serial_test_basic):
677
678 2019-04-09  Jer Noble  <jer.noble@apple.com>
679
680         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
681         https://bugs.webkit.org/show_bug.cgi?id=196097
682
683         Reviewed by Eric Carlson.
684
685         Drive-by bug fix: allow tests to play audio without a user gesture by default.
686
687         * DumpRenderTree/mac/DumpRenderTree.mm:
688         (resetWebPreferencesToConsistentValues):
689         * WebKitTestRunner/TestController.cpp:
690         (WTR::TestController::resetPreferencesToConsistentValues):
691
692 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
693
694         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
695         https://bugs.webkit.org/show_bug.cgi?id=196690
696
697         Reviewed by Michael Catanzaro.
698
699         * QueueStatusServer/config/queues.py:
700         * Scripts/webkitpy/common/config/ews.json:
701         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
702         (test_ews_name):
703
704 2019-04-09  Chris Dumez  <cdumez@apple.com>
705
706         Loads using loadHTMLString() cause flashing when process-swapping
707         https://bugs.webkit.org/show_bug.cgi?id=196714
708         <rdar://problem/49637354>
709
710         Reviewed by Antti Koivisto.
711
712         Add API test coverage.
713
714         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
715
716 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
717
718         Unreviewed. Fix ATK accessibility tests after r244059.
719
720         We are failing to load the injected bundle due to undefined symbol
721         AccessibilityUIElement::replaceTextInRange().
722
723         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
724         (WTR::AccessibilityUIElement::replaceTextInRange):
725
726 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
727
728         AX: Support API: accessibilityReplaceRange:withText
729         https://bugs.webkit.org/show_bug.cgi?id=196636
730
731         Unreviewed build fix for Windows port.
732
733         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
734         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
735
736 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
737
738         [CMake][WinCairo] Separate copied headers into different directories
739         https://bugs.webkit.org/show_bug.cgi?id=196655
740
741         Reviewed by Michael Catanzaro.
742
743         * DumpRenderTree/CMakeLists.txt:
744         * MiniBrowser/win/CMakeLists.txt:
745         * TestWebKitAPI/CMakeLists.txt:
746         * TestWebKitAPI/PlatformWin.cmake:
747
748 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
749
750         Log stack-trace for run-webkit-tests when interrupted
751         https://bugs.webkit.org/show_bug.cgi?id=176393
752         <rdar://problem/34262310>
753
754         Reviewed by Lucas Forschler.
755
756         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
757         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
758         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
759         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
760         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
761         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
762         (main): Set handlers to log stack trace on interruption.
763
764 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
765
766         AX: Support API: accessibilityReplaceRange:withText
767         https://bugs.webkit.org/show_bug.cgi?id=196636
768
769         Unreviewed build fix for Windows port.
770
771         * DumpRenderTree/AccessibilityUIElement.cpp:
772         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
773
774 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
775
776         [ews-build] Scripts using Buildbot API have CORS error
777         https://bugs.webkit.org/show_bug.cgi?id=196709
778
779         Reviewed by Alexey Proskuryakov.
780
781         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
782
783 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
784
785         AX: Support API: accessibilityReplaceRange:withText
786         https://bugs.webkit.org/show_bug.cgi?id=196636
787
788         Reviewed by Daniel Bates.
789
790         * DumpRenderTree/AccessibilityUIElement.cpp:
791         (replaceTextInRangeCallback):
792         (AccessibilityUIElement::replaceTextInRange):
793         (AccessibilityUIElement::getJSClass):
794         * DumpRenderTree/AccessibilityUIElement.h:
795         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
796         (AccessibilityUIElement::replaceTextInRange):
797         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
798         (AccessibilityUIElement::replaceTextInRange):
799         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
800         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
801         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
802         (WTR::AccessibilityUIElement::replaceTextInRange):
803         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
804         (WTR::AccessibilityUIElement::replaceTextInRange):
805
806 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
807
808         [iOS] Do not allow starting selection drags when selection views are not visible
809         https://bugs.webkit.org/show_bug.cgi?id=196686
810         <rdar://problem/49399192>
811
812         Reviewed by Tim Horton.
813
814         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
815         also add some new API tests to cover scenarios where the web view is not first responder.
816
817         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
818         (TestWebKitAPI::TEST):
819         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
820
821         Add a switch to optionally make the web view first responder when starting the simulated drag.
822
823         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
824         (-[DragAndDropSimulator initWithWebView:]):
825         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
826
827 2019-04-08  Justin Fan  <justin_fan@apple.com>
828
829         [Web GPU] Fix Web GPU experimental feature on iOS
830         https://bugs.webkit.org/show_bug.cgi?id=196632
831
832         Reviewed by Myles C. Maxfield.
833
834         Properly make Web GPU available on iOS 11+.
835
836         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
837
838 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
839
840         [ews-build] Do not upload archive when Compile Fails
841         https://bugs.webkit.org/show_bug.cgi?id=196674
842
843         Reviewed by Alexey Proskuryakov.
844
845         * BuildSlaveSupport/ews-build/factories.py:
846         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
847         * BuildSlaveSupport/ews-build/steps.py:
848         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
849         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
850         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
851
852 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
853
854         Enable DFG on MIPS
855         https://bugs.webkit.org/show_bug.cgi?id=196689
856
857         Reviewed by Žan Doberšek.
858
859         Since the bytecode change, we enabled the baseline JIT on mips in
860         r240432, but DFG is still missing. With this change, all tests are
861         passing on a ci20 board.
862
863         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
864
865 2019-04-08  Philippe Normand  <pnormand@igalia.com>
866
867         [Flatpak] Second run update-webkitwpe-flatpak fails
868         https://bugs.webkit.org/show_bug.cgi?id=192702
869
870         Reviewed by Carlos Garcia Campos.
871
872         * flatpak/flatpakutils.py:
873         (FlatpakObject.flatpak): Fix typo.
874         (FlatpakPackage.install): When installing, also update to the configured remote commit.
875         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
876
877 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
878
879         [GTK][WPE] outlook.live.com displays old-fashioned UI
880         https://bugs.webkit.org/show_bug.cgi?id=196642
881
882         Reviewed by Carlos Garcia Campos.
883
884         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
885         (TestWebKitAPI::TEST): New Mac platform quirk test.
886
887 2019-04-07  Commit Queue  <commit-queue@webkit.org>
888
889         Unreviewed, rolling out r243956.
890         https://bugs.webkit.org/show_bug.cgi?id=196688
891
892         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
893         by aakashjain on #webkit).
894
895         Reverted changeset:
896
897         "Clicking "Go Back" from a safe browsing warning from an
898         iframe should navigate the WKWebView back to the previous
899         page"
900         https://bugs.webkit.org/show_bug.cgi?id=196665
901         https://trac.webkit.org/changeset/243956
902
903 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
904
905         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
906         https://bugs.webkit.org/show_bug.cgi?id=196669
907
908         Reviewed by Geoffrey Garen.
909
910         Added three new unit tests for WeakHashSet.
911
912         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
913         (WTF_WeakPtr.WeakHashSetConstObjects):
914         (WTF_WeakPtr.WeakHashSetComputesEmpty):
915         (WTF_WeakPtr.WeakHashSetComputeSize):
916
917 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
918
919         Hide next and previous form control buttons when WKWebView is editable
920         https://bugs.webkit.org/show_bug.cgi?id=196672
921         <rdar://problem/35625321>
922
923         Reviewed by Tim Horton.
924
925         Add a new API test.
926
927         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
928         (-[TestWKWebView lastTrailingBarButtonGroup]):
929         (TestWebKitAPI::TEST):
930         * TestWebKitAPI/ios/UIKitSPI.h:
931
932 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
933
934         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
935         https://bugs.webkit.org/show_bug.cgi?id=196077
936         <rdar://problem/49108202>
937
938         Reviewed by Chris Dumez.
939
940         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
941         on new web view.
942
943         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
944
945 2019-04-05  Saam Barati  <sbarati@apple.com>
946
947         Make compare-results understand MotionMark
948         https://bugs.webkit.org/show_bug.cgi?id=196666
949
950         Reviewed by Yusuke Suzuki.
951
952         * Scripts/compare-results:
953         (PLT5Results):
954         (detectMotionMark):
955         (detectMotionMark1_1):
956         (motionMarkResults):
957         (motionMark1_1Results):
958         (detectBenchmark):
959         (biggerIsBetter):
960         (main):
961
962 2019-04-05  Alex Christensen  <achristensen@webkit.org>
963
964         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
965         https://bugs.webkit.org/show_bug.cgi?id=196665
966         <rdar://45115669>
967
968         Reviewed by Geoff Garen.
969
970         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
971         (goBack):
972         (+[SimpleLookupContext sharedLookupContext]):
973         (-[SimpleLookupContext lookUpURL:completionHandler:]):
974         (TEST):
975         (+[Simple3LookupContext sharedLookupContext]): Deleted.
976         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
977
978 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
979
980         [ews-build] Add configuration and architecture for windows builders
981         https://bugs.webkit.org/show_bug.cgi?id=196660
982
983         Reviewed by Lucas Forschler.
984
985         * BuildSlaveSupport/ews-build/config.json:
986
987 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
988
989         webkitpy: Don't run subsequent rounds if interrupted
990         https://bugs.webkit.org/show_bug.cgi?id=196646
991
992         Reviewed by Aakash Jain.
993
994         * Scripts/webkitpy/layout_tests/controllers/manager.py:
995         (Manager.run): Bail out if interrupted.
996
997 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
998
999         Test sessionStorage in PSON private browsing mode
1000         https://bugs.webkit.org/show_bug.cgi?id=196561
1001
1002         Reviewed by Alex Christensen.
1003
1004         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1005
1006 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1007
1008         Unreviewed, rolling out r243833.
1009         https://bugs.webkit.org/show_bug.cgi?id=196645
1010
1011         This change breaks build of WPE and GTK ports (Requested by
1012         annulen on #webkit).
1013
1014         Reverted changeset:
1015
1016         "[CMake][WTF] Mirror XCode header directories"
1017         https://bugs.webkit.org/show_bug.cgi?id=191662
1018         https://trac.webkit.org/changeset/243833
1019
1020 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1021
1022         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1023         https://bugs.webkit.org/show_bug.cgi?id=196635
1024
1025         Reviewed by Antti Koivisto.
1026         
1027         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1028         for a test to enable async frame scrolling via:
1029             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1030         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1031         
1032         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1033
1034         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1035         (WTR::InjectedBundle::beginTesting):
1036         * WebKitTestRunner/TestController.cpp:
1037         (WTR::TestController::resetPreferencesToConsistentValues):
1038
1039 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1040
1041         Use a correct LC_RPATH when building with ASan
1042         https://bugs.webkit.org/show_bug.cgi?id=196576
1043
1044         Reviewed by David Kilzer.
1045
1046         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1047         so that ../Frameworks is checked. This is simpler and more reliable than updating
1048         each SPC service xcconfig.
1049
1050 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1051
1052         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1053         https://bugs.webkit.org/show_bug.cgi?id=196629
1054
1055         Reviewed by Lucas Forschler.
1056
1057         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1058
1059 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1060
1061         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1062         https://bugs.webkit.org/show_bug.cgi?id=196618
1063
1064         Reviewed by Lucas Forschler.
1065
1066         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1067         (StatusBubble): Added QUEUE_TRIGGERS.
1068         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1069         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1070         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1071         its parent(builder).
1072
1073 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1074
1075         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1076         https://bugs.webkit.org/show_bug.cgi?id=196625
1077
1078         Reviewed by Lucas Forschler.
1079
1080         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1081         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1082
1083 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1084
1085         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1086         https://bugs.webkit.org/show_bug.cgi?id=196630
1087
1088         Reviewed by Wenson Hsieh.
1089
1090         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1091
1092 2019-04-04  Youenn Fablet  <youenn@apple.com>
1093
1094         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1095         https://bugs.webkit.org/show_bug.cgi?id=196543
1096
1097         Reviewed by Alex Christensen.
1098
1099         * WebKitTestRunner/TestController.cpp:
1100         (WTR::TestController::generatePageConfiguration):
1101
1102 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1103
1104         [ews-app] Status bubble should not display skipped buildbot steps
1105         https://bugs.webkit.org/show_bug.cgi?id=196584
1106
1107         Reviewed by Lucas Forschler.
1108
1109         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1110
1111 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1112
1113         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1114         https://bugs.webkit.org/show_bug.cgi?id=196620
1115
1116         Reviewed by Lucas Forschler.
1117
1118         * BuildSlaveSupport/ews-app/ews/config.py:
1119
1120 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1121
1122         [Win] DumpRenderTreeWatchDog.py is not checked into source
1123         https://bugs.webkit.org/show_bug.cgi?id=196567
1124         <rdar://problem/49525901>
1125
1126         Reviewed by Lucas Forschler.
1127
1128         This script is used on Win EWS bots to terminate hanging DRT processes.
1129
1130         * EWSTools/dumprendertreewatchdog.py: Added.
1131
1132 2019-04-04  Chris Dumez  <cdumez@apple.com>
1133
1134         Unreviewed, roll out r243858 which made tests time out.
1135
1136         Disable new API tests on Windows instead.
1137
1138         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1139         (TestWebKitAPI::TEST):
1140
1141 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1142
1143         [ATK] Cleanup WebPageAccessibilityObjectAtk
1144         https://bugs.webkit.org/show_bug.cgi?id=196537
1145
1146         Reviewed by Michael Catanzaro.
1147
1148         Also consider files under atk directories as exceptions for GObject conventions.
1149
1150         * Scripts/webkitpy/style/checkers/cpp.py:
1151         (check_identifier_name_in_declaration):
1152
1153 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1154
1155         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1156         https://bugs.webkit.org/show_bug.cgi?id=196588
1157         <rdar://problem/49365787>
1158
1159         Unreviewed build fix for Windows port.
1160
1161         error C3861: 'kill': identifier not found
1162
1163         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1164         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1165
1166 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1167
1168         [ews-build] Cancel build and similar operations should have authentication
1169         https://bugs.webkit.org/show_bug.cgi?id=196520
1170
1171         Reviewed by Dewei Zhu.
1172
1173         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1174         environment variables.
1175
1176 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1177
1178         [ews-build] Do not trigger queues which are not in production yet
1179         https://bugs.webkit.org/show_bug.cgi?id=196581
1180
1181         Reviewed by Dewei Zhu.
1182
1183         * BuildSlaveSupport/ews-build/config.json:
1184
1185 2019-04-03  Chris Dumez  <cdumez@apple.com>
1186
1187         Unreviewed, fix typo in the name of API test added in r243848.
1188
1189         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1190         (TestWebKitAPI::TEST):
1191
1192 2019-04-03  Chris Dumez  <cdumez@apple.com>
1193
1194         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1195         https://bugs.webkit.org/show_bug.cgi?id=196588
1196         <rdar://problem/49365787>
1197
1198         Reviewed by Ryosuke Niwa.
1199
1200         Add API test coverage.
1201
1202         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1203         (TestWebKitAPI::nullJavaScriptCallback):
1204         (TestWebKitAPI::didCrashCheckFrames):
1205         (TestWebKitAPI::TEST):
1206
1207 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1208
1209         run-webkit-tests: Upload test results (new results database)
1210         https://bugs.webkit.org/show_bug.cgi?id=196577
1211         <rdar://problem/34841155>
1212
1213         Reviewed by Lucas Forschler.
1214
1215         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1216         (Manager.run): Upload results after each device shard, since the configuration will be
1217         different for each device.
1218         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1219         uploaded to a results database.
1220         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1221         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1222
1223 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1224
1225         -apple-trailing-word is needed for browser detection
1226         https://bugs.webkit.org/show_bug.cgi?id=196575
1227
1228         Unreviewed.
1229
1230         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1231
1232 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1233
1234         [CMake][WTF] Mirror XCode header directories
1235         https://bugs.webkit.org/show_bug.cgi?id=191662
1236
1237         Reviewed by Konstantin Tokarev.
1238
1239         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1240         builds.
1241
1242         * CMakeLists.txt:
1243         * DumpRenderTree/CMakeLists.txt:
1244         * DumpRenderTree/PlatformWin.cmake:
1245         * MiniBrowser/win/CMakeLists.txt:
1246         * TestWebKitAPI/CMakeLists.txt:
1247         * TestWebKitAPI/PlatformWin.cmake:
1248         * WebKitTestRunner/PlatformGTK.cmake:
1249         * WebKitTestRunner/PlatformWin.cmake:
1250
1251 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1252
1253         [ews-app] Status bubble should not display certain infrastructure status messages
1254         https://bugs.webkit.org/show_bug.cgi?id=196550
1255
1256         Reviewed by Lucas Forschler.
1257
1258         Do not display the steps which are un-needed for end-user. This information is still avaiable
1259         if the user click on the bubble and look at the Buildbot build.
1260         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1261         (StatusBubble._steps_messages):
1262         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1263
1264 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1265
1266         [ews-build] Use https for sending data to ews-app
1267         https://bugs.webkit.org/show_bug.cgi?id=196492
1268
1269         Reviewed by Lucas Forschler.
1270
1271         * BuildSlaveSupport/ews-build/events.py:
1272
1273 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1274
1275         Remove support for -apple-trailing-word
1276         https://bugs.webkit.org/show_bug.cgi?id=196525
1277
1278         Reviewed by Zalan Bujtas.
1279
1280         This CSS property is nonstandard and not used.
1281
1282         * Scripts/webkitperl/FeatureList.pm:
1283         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1284
1285 2019-04-03  Youenn Fablet  <youenn@apple.com>
1286
1287         Add a test for DOMCache on multiple browsing in case of private browsing
1288         https://bugs.webkit.org/show_bug.cgi?id=196524
1289
1290         Reviewed by Alex Christensen.
1291
1292         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1293         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1294
1295 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1296
1297         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1298         https://bugs.webkit.org/show_bug.cgi?id=196540
1299
1300         Reviewed by Aakash Jain.
1301
1302         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1303
1304 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1305
1306         Add plumbing for a compatibility mode preference in WebKit
1307         https://bugs.webkit.org/show_bug.cgi?id=196005
1308
1309         Reviewed by Tim Horton.
1310
1311         Add new API tests.
1312
1313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1314         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1315
1316 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1317
1318         [WPE][GTK] Update libsrtp dependency package for Debian
1319         https://bugs.webkit.org/show_bug.cgi?id=196528
1320
1321         Reviewed by Frédéric Wang.
1322
1323         * gtk/install-dependencies:
1324         * wpe/install-dependencies:
1325
1326 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1327
1328         [WK2] Add support for Window's beforeprint / afterprint events
1329         https://bugs.webkit.org/show_bug.cgi?id=196478
1330         <rdar://problem/49535124>
1331
1332         Unreviewed build fix for MSVC.
1333
1334         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1335
1336         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1337
1338         * WebKitTestRunner/TestController.cpp:
1339         (WTR::printFrame): Use int and float literals.
1340
1341 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1342
1343         [ews-build] Reassign bots to queues
1344
1345         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1346
1347 2019-04-02  Chris Dumez  <cdumez@apple.com>
1348
1349         [WK2] Add support for Window's beforeprint / afterprint events
1350         https://bugs.webkit.org/show_bug.cgi?id=196478
1351
1352         Reviewed by Alex Christensen.
1353
1354         Add minimal implementation for printFrame in WebKitTestRunner.
1355
1356         * WebKitTestRunner/TestController.cpp:
1357         (WTR::printFrame):
1358         (WTR::TestController::createOtherPage):
1359         (WTR::TestController::createWebViewWithOptions):
1360
1361 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1362
1363         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1364         https://bugs.webkit.org/show_bug.cgi?id=196491
1365
1366         Reviewed by Lucas Forschler.
1367
1368         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1369
1370 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1371
1372         [ews-build] Configure buildbot try credentials in environment variables
1373         https://bugs.webkit.org/show_bug.cgi?id=196501
1374
1375         Reviewed by Lucas Forschler.
1376
1377         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1378         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1379         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1380
1381 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1382
1383         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1384         https://bugs.webkit.org/show_bug.cgi?id=196496
1385         <rdar://problem/49521634>
1386
1387         Reviewed by Chris Dumez.
1388
1389         Add new API tests (see WebKit ChangeLog for more detail).
1390
1391         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1392         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1393         (TEST):
1394
1395 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1396
1397         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1398         <https://webkit.org/b/196499>
1399
1400         Reviewed by Alexey Proskuryakov.
1401
1402         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1403         ENABLE_ADDRESS_SANITIZER.
1404
1405 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1406
1407         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1408         https://bugs.webkit.org/show_bug.cgi?id=182757
1409
1410         Reviewed by Don Olmstead.
1411
1412         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1413         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1414
1415 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1416
1417         run-api-tests: Upload test results
1418         https://bugs.webkit.org/show_bug.cgi?id=196323
1419         <rdar://problem/49356714>
1420
1421         Reviewed by Lucas Forschler.
1422
1423         * Scripts/webkitpy/api_tests/manager.py:
1424         (Manager):
1425         (Manager.run): Upload results to a results database.
1426         * Scripts/webkitpy/api_tests/run_api_tests.py:
1427         (parse_args): Add upload arguments.
1428         * Scripts/webkitpy/port/base.py:
1429         (Port):
1430         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1431         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1432         with commits from any other associated repositories.
1433         * Scripts/webkitpy/port/device.py:
1434         (Device):
1435         (Device.build_version): Access build_versoin of underlying platform device.
1436         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1437         (IOSSimulatorTest):
1438         (IOSSimulatorTest.test_configuration_for_upload):
1439         * Scripts/webkitpy/port/device_port.py:
1440         (DevicePort):
1441         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1442         the same as the machine uploading results.
1443         * Scripts/webkitpy/port/mac.py:
1444         (MacPort):
1445         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1446         * Scripts/webkitpy/port/mac_unittest.py:
1447         (MacTest):
1448         (MacTest.test_configuration_for_upload):
1449         * Scripts/webkitpy/xcode/simulated_device.py:
1450         (SimulatedDeviceManager._create_device_with_runtime):
1451         (SimulatedDevice.__init__): Create simulated device with a build_version.
1452         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1453         (test_existing_simulator):
1454
1455 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1456
1457         Remove extra newline characters (Follow-up fix to r243707)
1458
1459         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1460
1461 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1462
1463         [ews-app] Use API_KEY to accept results data
1464         https://bugs.webkit.org/show_bug.cgi?id=196461
1465
1466         Reviewed by Dewei Zhu.
1467
1468         * BuildSlaveSupport/ews-app/ews/views/results.py:
1469         (Results.post): Validate EWS_API_KEY before accepting any data.
1470         * BuildSlaveSupport/ews-build/events.py:
1471         (Events.sendData): Send EWS_API_KEY if available along with event data.
1472
1473 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1474
1475         Unable to copy and paste a PDF from Notes into Mail compose body
1476         https://bugs.webkit.org/show_bug.cgi?id=196442
1477         <rdar://problem/48573098>
1478
1479         Reviewed by Tim Horton.
1480
1481         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1482         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1483         to be specified on the item providers.
1484
1485         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1486         (TestWebKitAPI::mapItemForTesting):
1487         (TestWebKitAPI::contactItemForTesting):
1488
1489 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1490
1491         Make UIWKDocumentContext rects per-character instead of per-word
1492         https://bugs.webkit.org/show_bug.cgi?id=196459
1493
1494         Reviewed by Wenson Hsieh.
1495
1496         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1497         (TEST):
1498         Adjust test results due to switching to per-character rects.
1499
1500 2019-04-01  Chris Dumez  <cdumez@apple.com>
1501
1502         UIProcess crash when a prewarmed process is terminated
1503         https://bugs.webkit.org/show_bug.cgi?id=196451
1504         <rdar://problem/49245471>
1505
1506         Reviewed by Geoffrey Garen.
1507
1508         Add API test coverage.
1509
1510         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1511         (TEST):
1512
1513 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1514
1515         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1516         https://bugs.webkit.org/show_bug.cgi?id=196449
1517
1518         Reviewed by Lucas Forschler.
1519
1520         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1521         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1522         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1523         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1524
1525 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1526
1527         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1528         https://bugs.webkit.org/show_bug.cgi?id=196444
1529
1530         Reviewed by Lucas Forschler.
1531
1532         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1533
1534 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1535
1536         Add SPI to canonicalize NSURLs with WTF::URL
1537         https://bugs.webkit.org/show_bug.cgi?id=196415
1538         <rdar://problem/44980271>
1539
1540         Reviewed by Darin Adler.
1541
1542         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1543         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1544         (TestWebKitAPI::TEST):
1545
1546 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1547
1548         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1549         https://bugs.webkit.org/show_bug.cgi?id=196441
1550
1551         Reviewed by Carlos Garcia Campos.
1552
1553         Don't cache the wpe_view_backend object that might not exist yet at the
1554         time of EventSenderProxy constructor invocation, but instead retrieve
1555         that object whenever it's required for event dispatching. This should
1556         avoid crashes in this constructor now that it's invoked before any
1557         PlatformWindow has been set up (as changed in r243496).
1558
1559         * WebKitTestRunner/EventSenderProxy.h:
1560         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1561         (WTR::viewBackend):
1562         (WTR::EventSenderProxy::EventSenderProxy):
1563         (WTR::EventSenderProxy::mouseDown):
1564         (WTR::EventSenderProxy::mouseUp):
1565         (WTR::EventSenderProxy::mouseMoveTo):
1566         (WTR::EventSenderProxy::mouseScrollBy):
1567         (WTR::EventSenderProxy::keyDown):
1568         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1569
1570 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1571
1572         [Win][WebKit] MiniBrowser should support high DPI display
1573         https://bugs.webkit.org/show_bug.cgi?id=196391
1574
1575         Reviewed by Alex Christensen.
1576
1577         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1578         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1579         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1580         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1581
1582 2019-03-31  Sam Weinig  <weinig@apple.com>
1583
1584         Remove more i386 specific configurations
1585         https://bugs.webkit.org/show_bug.cgi?id=196430
1586
1587         Reviewed by Alexey Proskuryakov.
1588
1589         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1590         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1591
1592 2019-03-31  Andy Estes  <aestes@apple.com>
1593
1594         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1595         https://bugs.webkit.org/show_bug.cgi?id=196433
1596         <rdar://problem/49293305>
1597
1598         Reviewed by Tim Horton.
1599
1600         Enhanced API test coverage to include all navigation response policy decisions in both
1601         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1602
1603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1604         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1605         (TestWebKitAPI::TEST):
1606         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1607         (readFile):
1608         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1609         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1610         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1611         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1612         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1613         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1614         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1615         (-[QuickLookDelegate _downloadDidStart:]):
1616         (-[QuickLookDelegate _download:didReceiveResponse:]):
1617         (-[QuickLookDelegate _download:didReceiveData:]):
1618         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1619         (-[QuickLookDelegate _downloadDidFinish:]):
1620         (-[QuickLookDelegate _download:didFailWithError:]):
1621         (-[QuickLookDelegate _downloadDidCancel:]):
1622         (-[QuickLookDelegate verifyDownload]):
1623         (runTest):
1624         (runTestDecideBeforeLoading):
1625         (runTestDecideAfterLoading):
1626         (TEST):
1627         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1628         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1629         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1630         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1631         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1632         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1633         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1634         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1635         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1636         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1637         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1638         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1639         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1640         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1641
1642 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1643
1644         [CMake] add testdfg as target with build-jsc
1645         https://bugs.webkit.org/show_bug.cgi?id=196393
1646
1647         Reviewed by Saam Barati.
1648
1649         Added testdfg as one of the targets to build when
1650         using CMake.
1651
1652         * Scripts/build-jsc:
1653
1654 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1655
1656         Delete WebMetal implementation in favor of WebGPU
1657         https://bugs.webkit.org/show_bug.cgi?id=195418
1658
1659         Reviewed by Dean Jackson.
1660
1661         * DumpRenderTree/mac/DumpRenderTree.mm:
1662         (enableExperimentalFeatures):
1663         (resetWebPreferencesToConsistentValues):
1664         * Scripts/webkitperl/FeatureList.pm:
1665         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1666         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1667         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1668         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1669         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1670         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1671         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1672         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1673         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1674         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1675         (WTR::InjectedBundle::beginTesting):
1676         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1677         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1678         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1679
1680 2019-03-29  Chris Dumez  <cdumez@apple.com>
1681
1682         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1683         https://bugs.webkit.org/show_bug.cgi?id=196405
1684         <rdar://problem/49428130>
1685
1686         Reviewed by Wenson Hsieh.
1687
1688         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1689         the popover presentation methods to be no-ops. Use this in the new test added in
1690         r243523 so that we do not swizzle those methods for all tests. This is needed because
1691         those WatchOS tests rely on the popover getting presented and interactive.
1692
1693         * WebKitTestRunner/TestController.cpp:
1694         (WTR::updateTestOptionsFromTestHeader):
1695         * WebKitTestRunner/TestController.h:
1696         * WebKitTestRunner/TestOptions.h:
1697         (WTR::TestOptions::hasSameInitializationOptions const):
1698         * WebKitTestRunner/ios/TestControllerIOS.mm:
1699         (WTR::TestController::platformInitialize):
1700         (WTR::TestController::platformResetStateToConsistentValues):
1701
1702 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1703
1704         [Curl] Add Server Trust Evaluation Support.
1705         https://bugs.webkit.org/show_bug.cgi?id=191646
1706
1707         Reviewed by Fujii Hironori.
1708
1709         Implemented MiniBrowser UI for asking if user trusts the server.
1710
1711         * MiniBrowser/win/Common.cpp:
1712         (askServerTrustEvaluation):
1713         (replaceString):
1714         * MiniBrowser/win/Common.h:
1715         * MiniBrowser/win/MiniBrowserLib.rc:
1716         * MiniBrowser/win/MiniBrowserLibResource.h:
1717         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1718         (createPEMString):
1719         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1720         (WebKitBrowserWindow::canTrustServerCertificate):
1721         * MiniBrowser/win/WebKitBrowserWindow.h:
1722
1723 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1724
1725         Implement ResizeObserver.
1726         https://bugs.webkit.org/show_bug.cgi?id=157743
1727
1728         Reviewed by Simon Fraser.
1729
1730         Support resizeObserverEnabled webPreferences.
1731
1732         * DumpRenderTree/TestOptions.cpp:
1733         (TestOptions::TestOptions):
1734         * DumpRenderTree/TestOptions.h:
1735         * DumpRenderTree/mac/DumpRenderTree.mm:
1736         (setWebPreferencesForTestOptions):
1737         * DumpRenderTree/win/DumpRenderTree.cpp:
1738         (enableExperimentalFeatures):
1739         * Scripts/webkitperl/FeatureList.pm:
1740         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1741
1742 2019-03-28  John Wilander  <wilander@apple.com>
1743
1744         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1745         https://bugs.webkit.org/show_bug.cgi?id=196281
1746         <rdar://problem/48938748>
1747
1748         Reviewed by Alex Christensen.
1749
1750         This patch adds the function isStatisticsHasLocalStorage() to the
1751         TestRunner. With it, the page can query the WebsiteDataStore in the
1752         UI process to make sure that it sees LocalStorage.
1753
1754         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1755         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1756         (WTR::TestRunner::isStatisticsHasLocalStorage):
1757         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1758         * WebKitTestRunner/TestController.cpp:
1759         (WTR::TestController::isStatisticsHasLocalStorage):
1760         * WebKitTestRunner/TestController.h:
1761         * WebKitTestRunner/TestInvocation.cpp:
1762         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1763
1764 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1765
1766         API::Data::createWithoutCopying should do a null check before calling CFRelease
1767         https://bugs.webkit.org/show_bug.cgi?id=196276
1768         <rdar://problem/48059859>
1769
1770         Reviewed by Alex Christensen.
1771
1772         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1773
1774         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1775         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1776         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1777         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1778         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1779         (TestWebKitAPI::TEST):
1780
1781 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1782
1783         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1784         https://bugs.webkit.org/show_bug.cgi?id=186276
1785
1786         Reviewed by Carlos Garcia Campos.
1787
1788         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1789         (webViewLoadChanged):
1790         (testWebResourceGetDataError):
1791         (testWebResourceGetDataEmpty):
1792         (beforeAll):
1793         (webViewloadChanged): Deleted.
1794
1795 2019-03-27  Andy Estes  <aestes@apple.com>
1796
1797         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1798         https://bugs.webkit.org/show_bug.cgi?id=196317
1799
1800         Reviewed by Dan Bernstein.
1801
1802         package-root copies built products into a staging directory using ditto(1), which does not
1803         follow symbolic links as it traverses a directory. Now that the files in
1804         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1805         itself, these become broken links when ditto'd into the staging directory.
1806
1807         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1808
1809         * Scripts/package-root:
1810
1811 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1812
1813         [ews-app] Update display text of Submit for ews analysis
1814         https://bugs.webkit.org/show_bug.cgi?id=196309
1815
1816         Reviewed by Dewei Zhu.
1817
1818         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1819
1820 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1821
1822         run-webkit-tests should check for leaks in WebKit processes
1823         <https://webkit.org/b/193772>
1824         <rdar://problem/46526680>
1825
1826         Reviewed by Ryosuke Niwa.
1827
1828         This works by doing the following:
1829         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1830           The list of child processes are returned one per line:
1831           process.name: pid
1832         - Run the "#LIST CHILD PROCESSES" command just before the
1833           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1834           processes on the ServerProcess object.
1835         - When the `--leaks` switch is handled, run check_for_leaks() on
1836           each child process after the main test harness.
1837
1838         * DumpRenderTree/mac/DumpRenderTree.mm:
1839         (handleControlCommand):
1840         - Use strncmp() instead of strcmp().
1841         - Add support for handling "#LIST CHILD PROCESSES" command.
1842
1843         * Scripts/webkitpy/port/base.py:
1844         (Port.check_for_leaks):
1845         * Scripts/webkitpy/port/darwin.py:
1846         (DarwinPort.check_for_leaks):
1847         - Rename redundant 'process_pid' argument to 'process_id'.
1848
1849         * Scripts/webkitpy/port/driver.py:
1850         (Driver.do_post_tests_work):
1851         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1852           longer the only command this sends to WebKitTestRunner.
1853         - If the `--leaks` switch is present, send the
1854           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1855           result using Port.set_webkit_processes().
1856         (Driver._parse_child_processes_output):
1857         - Add helper method to parse list of child process names and
1858           process IDs returned from WebKitTestRunner.
1859
1860         * Scripts/webkitpy/port/ios_device.py:
1861         (IOSDevicePort.check_for_leaks):
1862         - Rename redundant 'process_pid' argument to 'process_id'.
1863
1864         * Scripts/webkitpy/port/leakdetector.py:
1865         (LeakDetector._parse_leaks_output):
1866         - Return early if there is no leaks_output.
1867         (LeakDetector.check_for_leaks):
1868         - Rename redundant 'process_pid' argument to 'process_id'.
1869
1870         * Scripts/webkitpy/port/server_process.py:
1871         (ServerProcess.__init__):
1872         (ServerProcess.child_processes):
1873         (ServerProcess.set_child_processes):
1874         - Add instance variable to Port to store list of child process
1875           names and process IDs returned from WebKitTestRunner.
1876         (ServerProcess._start):
1877         - Clear self._child_processes.
1878         (ServerProcess.stop):
1879         - If self._child_processes is set, call
1880           self._port.check_for_leaks() for each child process.
1881
1882         * Scripts/webkitpy/port/server_process_unittest.py:
1883         (TrivialMockPort.check_for_leaks):
1884         - Rename redundant 'process_pid' argument to 'process_id'.
1885
1886         * Scripts/webkitpy/port/simulator_process.py:
1887         (SimulatorProcess.stop):
1888         - If self._child_processes is set, call
1889           self._port.check_for_leaks() for each child process.
1890
1891         * Scripts/webkitpy/port/watch_device.py:
1892         (WatchDevicePort.check_for_leaks):
1893         - Rename redundant 'process_pid' argument to 'process_id'.
1894
1895         * WebKitTestRunner/TestController.cpp:
1896         (WTR::TestController::dumpResponse):
1897         - Extract method from findAndDumpWorldLeaks() so that it may be
1898           reused by findAndDumpWebKitProcessIdentifiers().
1899         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1900         - Add method to output process name and process ID of both the
1901           WebContent and Networking processes.
1902         (WTR::TestController::findAndDumpWorldLeaks):
1903         - Fix missing newline in output when there were no abandoned
1904           documents.
1905         - Call dumpResponse() for extracted code.
1906         (WTR::TestController::handleControlCommand):
1907         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1908         - Use strncmp() instead of strcmp().
1909         - Call findAndDumpWebKitProcessIdentifiers() when
1910           "#LIST CHILD PROCESSES" command is sent.
1911         * WebKitTestRunner/TestController.h:
1912         (WTR::TestController::dumpResponse):
1913         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1914         - Declare methods.
1915
1916 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1917
1918         Unreviewed. Add GLib API test cases after r243434.
1919
1920         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1921         (testWebViewActiveURI):
1922         (serverCallback):
1923         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1924         (sendRequestCallback):
1925
1926 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1927
1928         Geolocation request not complete when watch request was started in a different web process
1929         https://bugs.webkit.org/show_bug.cgi?id=195996
1930
1931         Reviewed by Alex Christensen.
1932
1933         Add a test case.
1934
1935         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1936         (TestWebKitAPI::runJavaScriptAlert):
1937         (TestWebKitAPI::TEST):
1938
1939 2019-03-26  Keith Rollin  <krollin@apple.com>
1940
1941         Update the way generate-xcfilelists returns strings from functions
1942         https://bugs.webkit.org/show_bug.cgi?id=195975
1943         <rdar://problem/49040807>
1944
1945         Reviewed by Dean Jackson.
1946
1947         There are places where generate-xcfilelists executes assignments with
1948         statements like:
1949
1950             FOO=$(some_function)
1951
1952         where "some_function" return a string by echoing it. E.g.
1953
1954             some_function()
1955             {
1956                 echo "Hello, World"
1957             }
1958
1959         This is a common idiom, but it has a problem if "some_function" needs
1960         to call "exit" in an attempt to halt the entire script right then and
1961         there. Since "some_function" is called inside of $(), it's being
1962         executed in a sub-shell. Calling exit in that sub-shell simply exits
1963         that shell; it doesn't not exit the outer shell in which the main part
1964         of the script is still running. As such, the main script keeps
1965         executing when the intent was for the script to halt.
1966
1967         The solution to this is to use a different idiom for returning
1968         strings. The one we now is to pass in the name of the variable to
1969         receive the string result:
1970
1971             some_function()
1972             {
1973                 variable_name=$1
1974                 eval $variable_name ="Hello, World"
1975             }
1976
1977         The call site now looks like
1978
1979             some_function FOO
1980
1981         Because there's no invocation of a sub-shell, some_function can now
1982         call "exit" if it wants to, and the entire script will exit at that
1983         point.
1984
1985         * Scripts/generate-xcfilelists:
1986
1987 2019-03-26  Chris Dumez  <cdumez@apple.com>
1988
1989         Add basic layout test coverage for File Picker on iOS
1990         https://bugs.webkit.org/show_bug.cgi?id=196265
1991
1992         Reviewed by Wenson Hsieh.
1993
1994         Add layout test infrastructure to test the file picker on iOS.
1995
1996         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1997         (WTR::UIScriptController::dismissFilePicker):
1998         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1999         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2000         (WTR::UIScriptController::dismissFilePicker):
2001         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2002         * WebKitTestRunner/TestController.cpp:
2003         (WTR::TestController::createWebViewWithOptions):
2004         (WTR::updateTestOptionsFromTestHeader):
2005         * WebKitTestRunner/TestOptions.h:
2006         (WTR::TestOptions::hasSameInitializationOptions const):
2007         * WebKitTestRunner/ios/TestControllerIOS.mm:
2008         (overridePresentViewController):
2009         (WTR::TestController::platformInitialize):
2010         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2011         (WTR::UIScriptController::dismissFilePicker):
2012
2013 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2014
2015         Implement async paste method on UIWKInteractionViewProtocol
2016         https://bugs.webkit.org/show_bug.cgi?id=196267
2017         <rdar://problem/49236346>
2018
2019         Reviewed by Tim Horton.
2020
2021         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2022         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2023         are now a part of all iOS 12 internal SDKs.
2024
2025         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2026
2027         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2028         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2029
2030         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2031         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2032         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2033         * TestWebKitAPI/ios/UIKitSPI.h:
2034
2035 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2036
2037         [ews-build] Use PostgreSQL for ews.webkit.org database
2038         https://bugs.webkit.org/show_bug.cgi?id=196270
2039
2040         Reviewed by Lucas Forschler.
2041
2042         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2043
2044 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2045
2046         [ews] Reset simctl states on reboot
2047         https://bugs.webkit.org/show_bug.cgi?id=196260
2048
2049         Rubber-stamped by Aakash Jain.
2050
2051         * EWSTools/start-queue-mac.sh:
2052
2053 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2054
2055         [ews-build] Use PostgreSQL for ews-build database
2056         https://bugs.webkit.org/show_bug.cgi?id=196229
2057
2058         Reviewed by Lucas Forschler.
2059
2060         * BuildSlaveSupport/ews-build/master.cfg:
2061
2062 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2063
2064         [ews-build] Get master_hostname dynamically in master.cfg
2065         https://bugs.webkit.org/show_bug.cgi?id=196255
2066
2067         Reviewed by Lucas Forschler.
2068
2069         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2070         send events data in test mode.
2071
2072 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2073
2074         [ews-app] Set db_constraint to False for Foreign Keys
2075         https://bugs.webkit.org/show_bug.cgi?id=196252
2076
2077         Reviewed by Lucas Forschler.
2078
2079         * BuildSlaveSupport/ews-app/ews/models/build.py:
2080         * BuildSlaveSupport/ews-app/ews/models/step.py:
2081
2082 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2083
2084         [ews-build] is_test_mode_enabled should default to True
2085         https://bugs.webkit.org/show_bug.cgi?id=196248
2086
2087         Reviewed by Lucas Forschler.
2088
2089         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2090
2091 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2092
2093         [ews-app] Add webkitperl to ENABLED_QUEUES
2094         https://bugs.webkit.org/show_bug.cgi?id=196253
2095
2096         Reviewed by Lucas Forschler.
2097
2098         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2099
2100 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2101
2102         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2103         https://bugs.webkit.org/show_bug.cgi?id=196211
2104         rdar://problem/49110552
2105
2106         Reviewed by Tim Horton.
2107
2108         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2109         Make sure that EventSenderProxy always exists when running tests. We used to create
2110         it when resetting before the first test, which is a bit too late.
2111
2112         * WebKitTestRunner/TestController.h:
2113         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2114         (WTR::TestController::platformCreateWebView):
2115         (WTR::TestController::platformCreateOtherPage):
2116         (WTR::TestController::finishCreatingPlatformWebView):
2117         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2118         (WTR::PlatformWebView::PlatformWebView):
2119         Moved some code that made NSWindow use NSEvent during web view creation. We may
2120         need to move more if some other case us found, but this is enough for now.
2121
2122 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2123
2124         Unreviewed. Fix typo in GLib geolocation API after r243285.
2125
2126         gelocation -> geolocation.
2127
2128         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2129         (testGeolocationManagerWatchPosition):
2130
2131 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2132
2133         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2134         https://bugs.webkit.org/show_bug.cgi?id=196213
2135
2136         Reviewed by Geoff Garen.
2137
2138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2139         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2140         (credentialWithIdentityAndKeychainPath):
2141         (-[ChallengeDelegate webView:didFinishNavigation:]):
2142         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2143         (TestWebKitAPI::TEST):
2144
2145 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2146
2147         Expected shouldn't assume its contained types are copyable
2148         https://bugs.webkit.org/show_bug.cgi?id=195986
2149
2150         Reviewed by JF Bastien.
2151
2152         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2153         (TestWebKitAPI::NonCopyable::operator== const):
2154         (TestWebKitAPI::NonCopyable::operator!= const):
2155         (TestWebKitAPI::TEST):
2156
2157 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2158
2159         Remove some now-unnecessary dynamic class lookup
2160         https://bugs.webkit.org/show_bug.cgi?id=196237
2161
2162         Reviewed by Simon Fraser.
2163
2164         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2165         (makeRequest):
2166         (TEST):
2167
2168 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2169
2170         Unreviewed, rolling out r243450.
2171
2172         AppleWin and WinCairo port builds get broken.
2173
2174         Reverted changeset:
2175
2176         "Add test for fix of #196095"
2177         https://bugs.webkit.org/show_bug.cgi?id=196097
2178         https://trac.webkit.org/changeset/243450
2179
2180 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2181
2182         Unreviewed, rolling out r243465.
2183         https://bugs.webkit.org/show_bug.cgi?id=196226
2184
2185         the test doesn't build (Requested by thorton on #webkit).
2186
2187         Reverted changeset:
2188
2189         "Do not terminate the NetworkProcess if a third party
2190         application sends a NSCredential with a SecIdentityRef"
2191         https://bugs.webkit.org/show_bug.cgi?id=196213
2192         https://trac.webkit.org/changeset/243465
2193
2194 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2195
2196         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2197         https://bugs.webkit.org/show_bug.cgi?id=196213
2198
2199         Reviewed by Geoff Garen.
2200
2201         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2202         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2203         (credentialWithIdentityAndKeychainPath):
2204         (-[ChallengeDelegate webView:didFinishNavigation:]):
2205         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2206         (TestWebKitAPI::TEST):
2207
2208 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2209
2210         [ews-build] Gracefully handle missing patch_id in events
2211         https://bugs.webkit.org/show_bug.cgi?id=196216
2212
2213         Reviewed by Lucas Forschler.
2214
2215         * BuildSlaveSupport/ews-build/events.py:
2216
2217 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2218
2219         [ews-build] use lz4 compression for improving buildbot performance
2220         https://bugs.webkit.org/show_bug.cgi?id=196155
2221
2222         Reviewed by Lucas Forschler.
2223
2224         * BuildSlaveSupport/ews-build/master.cfg:
2225
2226 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2227
2228         Pull some API testing helper methods out of TestWKWebView
2229         https://bugs.webkit.org/show_bug.cgi?id=196212
2230
2231         Reviewed by Tim Horton.
2232
2233         Refactor some more API testing utility methods, so that they can be used in
2234         tests that do not use TestWKWebView.
2235
2236         * TestWebKitAPI/cocoa/TestWKWebView.h:
2237         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2238         (-[WKWebView loadTestPageNamed:]):
2239         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2240         (-[WKWebView synchronouslyLoadHTMLString:]):
2241         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2242         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2243         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2244         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2245         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2246
2247 2019-03-25  Jer Noble  <jer.noble@apple.com>
2248
2249         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2250         https://bugs.webkit.org/show_bug.cgi?id=196097
2251
2252         Reviewed by Eric Carlson.
2253
2254         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2255
2256         * DumpRenderTree/mac/DumpRenderTree.mm:
2257         (resetWebPreferencesToConsistentValues):
2258         * WebKitTestRunner/TestController.cpp:
2259         (WTR::TestController::resetPreferencesToConsistentValues):
2260
2261 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2262
2263         Pull IPadUserInterfaceSwizzler out into a separate header file
2264         https://bugs.webkit.org/show_bug.cgi?id=196193
2265
2266         Reviewed by Anders Carlsson.
2267
2268         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2269         be used in other API tests.
2270
2271         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2272         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2273         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2274         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2275         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2276         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2277         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2278
2279 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2280
2281         Remove NavigatorContentUtils in WebCore/Modules
2282         https://bugs.webkit.org/show_bug.cgi?id=196070
2283
2284         Reviewed by Alex Christensen.
2285
2286         NavigatorContentUtils was to support the custom scheme spec [1].
2287         However, in WebKit side, no port has supported the feature in
2288         WebKit layer after EFL port was removed. So there has been the
2289         only IDL implementation of the NavigatorContentUtils in WebCore.
2290         So we don't need to keep the implementation in WebCore anymore.
2291
2292         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2293
2294         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2295
2296 2019-03-24  Andy Estes  <aestes@apple.com>
2297
2298         [watchOS] Remove unused Proximity Networking code
2299         https://bugs.webkit.org/show_bug.cgi?id=196188
2300
2301         Reviewed by Tim Horton.
2302
2303         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2304         (TEST):
2305
2306 2019-03-23  Keith Miller  <keith_miller@apple.com>
2307
2308         Refactor clz/ctz and fix getLSBSet.
2309         https://bugs.webkit.org/show_bug.cgi?id=196162
2310
2311         Reviewed by Saam Barati.
2312
2313         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2314
2315         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2316         (TestWebKitAPI::TEST):
2317
2318 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2319
2320         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2321         https://bugs.webkit.org/show_bug.cgi?id=196143
2322
2323         Reviewed by Michael Catanzaro.
2324
2325         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2326         directories.
2327
2328         * Scripts/webkitpy/style/checkers/cpp.py:
2329         (check_identifier_name_in_declaration):
2330         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2331         (WebKitStyleTest.test_names):
2332
2333 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2334
2335         [Flatpak] Manifest expanding fails for qt WPE extension
2336         https://bugs.webkit.org/show_bug.cgi?id=196148
2337
2338         Reviewed by Alex Christensen.
2339
2340         * flatpak/flatpakutils.py:
2341         (expand_submodules_recurse): The last recurse manifest expand
2342         iteration might lead to a single module so take it into account
2343         and don't try to recurse further.
2344
2345 2019-03-22  Chris Dumez  <cdumez@apple.com>
2346
2347         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2348         https://bugs.webkit.org/show_bug.cgi?id=195348
2349         <rdar://problem/48622090>
2350
2351         Reviewed by Alex Christensen.
2352
2353         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2354         to NO when test.options().shouldIgnoreMetaViewport is false.
2355
2356         * WebKitTestRunner/ios/TestControllerIOS.mm:
2357         (WTR::TestController::platformConfigureViewForTest):
2358
2359 2019-03-22  Chris Dumez  <cdumez@apple.com>
2360
2361         Prewarmed processes should be usable with any website data store
2362         https://bugs.webkit.org/show_bug.cgi?id=196104
2363
2364         Reviewed by Alex Christensen.
2365
2366         Add API test coverage.
2367
2368         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2369         (runInitialWarmedProcessUsedTest):
2370         (TEST):
2371
2372 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2373
2374         Back out local changes to Alex's Subversion working directory
2375
2376         They were accidentally committed.
2377
2378         * Scripts/webkitpy/common/system/abstractexecutive.py:
2379         (AbstractExecutive.wait_newest):
2380         * Scripts/webkitpy/common/system/executive.py:
2381         (Executive.running_pids):
2382         * Scripts/webkitpy/common/system/executive_mock.py:
2383         (MockExecutive.running_pids):
2384         * Scripts/webkitpy/common/system/executive_unittest.py:
2385         (ExecutiveTest.serial_test_running_pids):
2386         * Scripts/webkitpy/port/darwin.py:
2387         (DarwinPort.check_for_leaks):
2388         * Scripts/webkitpy/port/leakdetector.py:
2389         (LeakDetector.check_for_leaks):
2390         - This was the hack attached to Bug 193772.
2391
2392         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2393         (+[WebKitTestRunnerEvent mouseLocation]):
2394         - This works around a crash on an internal build.
2395
2396 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2397
2398         Fix the build after r243354
2399         https://bugs.webkit.org/show_bug.cgi?id=196138
2400         <rdar://problem/49145951>
2401
2402         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2403         (TEST):
2404         * TestWebKitAPI/ios/UIKitSPI.h:
2405
2406 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2407
2408         Adopt UIWKDocumentContext
2409         https://bugs.webkit.org/show_bug.cgi?id=196040
2410         <rdar://problem/48642440>
2411
2412         Reviewed by Ryosuke Niwa.
2413
2414         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2415         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2416         (makeRequest):
2417         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2418         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2419         (applyStyle):
2420         (TEST):
2421         Add tests for UIWKDocumentContext.
2422
2423         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2424         (TEST):
2425         (recursiveFindWKContentView): Deleted.
2426         * TestWebKitAPI/cocoa/TestWKWebView.h:
2427         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2428         (recursiveFindWKContentView):
2429         (-[TestWKWebView wkContentView]):
2430         * TestWebKitAPI/ios/UIKitSPI.h:
2431         Share the WKContentView finding code between tests.
2432
2433 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2434
2435         [iOS WK2] Turn on async overflow scrolling by default
2436         https://bugs.webkit.org/show_bug.cgi?id=196011
2437         rdar://problem/48453859
2438
2439         Reviewed by Antti Koivisto.
2440         
2441         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2442         since so many basic layout tests have different results when compositing is triggered for
2443         overflow.
2444         
2445         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2446
2447         * WebKitTestRunner/TestController.cpp:
2448         (WTR::TestController::resetPreferencesToConsistentValues):
2449
2450 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2451
2452         [ews-build] Retry API test in case of failures
2453         https://bugs.webkit.org/show_bug.cgi?id=196004
2454
2455         Reviewed by Lucas Forschler.
2456
2457         * BuildSlaveSupport/ews-build/steps.py:
2458         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2459         (CompileWebKitToT.doStepIf): Ditto.
2460         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2461         (ReRunAPITests): Re-run API tests.
2462         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2463         (RunAPITestsWithoutPatch): Run API tests without patch.
2464         (RunAPITestsWithoutPatch.doStepIf):
2465         (RunAPITestsWithoutPatch.hideStepIf):
2466         (RunAPITestsWithoutPatch.evaluateCommand):
2467         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2468         (AnalyzeAPITestsResults.start):
2469         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2470         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2471         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2472         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2473
2474 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2475
2476         [ews-build] Update queues configurations
2477         https://bugs.webkit.org/show_bug.cgi?id=196074
2478
2479         Reviewed by Dewei Zhu.
2480
2481         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2482         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2483
2484 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2485
2486         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2487         https://bugs.webkit.org/show_bug.cgi?id=195680
2488         <rdar://problem/48903534>
2489
2490         Unreviewed infrastructure fix.
2491
2492         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2493         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2494
2495 2019-03-21  Andy Estes  <aestes@apple.com>
2496
2497         [iOS] Apple Pay should be available in documents with no user agent scripts
2498         https://bugs.webkit.org/show_bug.cgi?id=196061
2499         <rdar://problem/48649391>
2500
2501         Reviewed by Brady Eidson.
2502
2503         Added API tests and related infrastructure.
2504
2505         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2506         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2507         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2508         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2509         (TestWebKitAPI::TEST):
2510         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2511         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2512         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2513         * TestWebKitAPI/cocoa/TestProtocol.mm:
2514         (-[TestProtocol startLoading]):
2515         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2516         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2517         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2518         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2519
2520 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2521
2522         REGRESSSION (r243297): webkitpy tests broken
2523         https://bugs.webkit.org/show_bug.cgi?id=196108
2524
2525         Reviewed by Aakash Jain.
2526
2527         r243297 updated contributors.json, which broke a few unit tests.
2528
2529         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2530         (IRCCommandTest.test_whois):
2531         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2532
2533 2019-03-21  Chris Dumez  <cdumez@apple.com>
2534
2535         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2536         https://bugs.webkit.org/show_bug.cgi?id=196041
2537         <rdar://problem/49083230>
2538
2539         Reviewed by Alex Christensen.
2540
2541         Add API test coverage.
2542
2543         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2544         (TEST):
2545
2546 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2547
2548         Add SPI to inform applications of WKContentRuleList actions
2549         https://bugs.webkit.org/show_bug.cgi?id=195965
2550         <rdar://problem/42664365>
2551
2552         Reviewed by Geoff Garen.
2553
2554         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2555         (TestWebKitAPI::allActionsForResourceLoad):
2556         (TestWebKitAPI::testRequest):
2557         (TestWebKitAPI::TEST_F):
2558         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2559         (Notification::description):
2560         (Notification::operator== const):
2561         (toVector):
2562         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2563         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2564         (makeContentRuleList):
2565         (TEST):
2566         (makeWarnContentRuleList): Deleted.
2567
2568 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2569
2570         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2571         https://bugs.webkit.org/show_bug.cgi?id=196088
2572
2573         Reviewed by Brian Burg.
2574
2575         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2576         Support checks when only one platform is specified. Also deprecate macosx() and
2577         force the use of macos() instead.
2578
2579         * Scripts/webkitpy/style/checkers/cpp.py:
2580         (check_min_versions_of_wk_api_available):
2581         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2582         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2583
2584 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2585
2586         Update status inactive committers' status to 'contributor'.
2587
2588         * Scripts/webkitpy/common/config/contributors.json:
2589
2590 2019-03-21  Xan Lopez  <xan@igalia.com>
2591
2592         [JSC][x86] Drop support for x87 floating point
2593         https://bugs.webkit.org/show_bug.cgi?id=194853
2594
2595         Reviewed by Don Olmstead.
2596
2597         Force SSE2 on x86/32bit builds.
2598
2599         * Scripts/webkitdirs.pm:
2600         (generateBuildSystemFromCMakeProject):
2601
2602 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2603
2604         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2605         https://bugs.webkit.org/show_bug.cgi?id=196073
2606
2607         Reviewed by Michael Catanzaro.
2608
2609         Add test cases to check functions and constructors with no arguments but receiving user data.
2610
2611         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2612         (checkUserData):
2613         (testJSCFunction):
2614         (fooCreateWithUserData):
2615         (testJSCClass):
2616
2617 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2618
2619         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2620
2621         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2622
2623         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2624
2625 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2626
2627         [GTK][WPE] Add API to provide geolocation information
2628         https://bugs.webkit.org/show_bug.cgi?id=195940
2629
2630         Reviewed by Michael Catanzaro.
2631
2632         Add a new test to check the new API.
2633
2634         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2635         (testGeolocationManagerCurrentPosition):
2636         (testGeolocationManagerWatchPosition):
2637         (beforeAll):
2638         (afterAll):
2639         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2640         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2641         (beforeAll): Ditto.
2642         * TestWebKitAPI/glib/CMakeLists.txt:
2643
2644 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2645
2646         [GLib] Returning G_TYPE_OBJECT from a method does not work
2647         https://bugs.webkit.org/show_bug.cgi?id=195574
2648
2649         Reviewed by Michael Catanzaro.
2650
2651         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2652
2653         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2654         (getGFile):
2655         (getParent):
2656         (createGString):
2657         (getGString):
2658         (getGStringCopyWillRaise):
2659         (getGStringCopy):
2660         (getGStringStr):
2661         (getGStringLen):
2662         (freeGString):
2663         (testJSCClass):
2664
2665 2019-03-20  Saam Barati  <sbarati@apple.com>
2666
2667         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2668         https://bugs.webkit.org/show_bug.cgi?id=195721
2669
2670         Reviewed by Filip Pizlo.
2671
2672         * Scripts/run-javascriptcore-tests:
2673
2674 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2675
2676         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2677         https://bugs.webkit.org/show_bug.cgi?id=196049
2678
2679         Reviewed by Tim Horton.
2680
2681         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2682         overflow scrolling in general, so rename it.
2683
2684         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2685
2686 2019-03-20  Daniel Bates  <dabates@apple.com>
2687
2688         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2689         https://bugs.webkit.org/show_bug.cgi?id=196031
2690         <rdar://problem/49078172>
2691
2692         Reviewed by Tim Horton.
2693
2694         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2695         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2696         same code path used when the Done button is pressed to dismiss the <select> picker.
2697
2698         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2699         (TestWebKitAPI::TEST):
2700
2701 2019-03-20  Chris Dumez  <cdumez@apple.com>
2702
2703         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2704         https://bugs.webkit.org/show_bug.cgi?id=196029
2705         <rdar://problem/48954651>
2706
2707         Reviewed by Tim Horton.
2708
2709         Add API test coverage.
2710
2711         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2712
2713 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2714
2715         [ews-build] Improve failure summary string for ApplyPatch step
2716         https://bugs.webkit.org/show_bug.cgi?id=195995
2717
2718         Reviewed by Alexey Proskuryakov.
2719
2720         * BuildSlaveSupport/ews-build/steps.py:
2721         (ApplyPatch.getResultSummary): Override getResultSummary.
2722
2723 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2724
2725         AX: Implement support for new meter ARIA role
2726         https://bugs.webkit.org/show_bug.cgi?id=195966
2727
2728         Reviewed by Chris Fleizach.
2729
2730         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2731         to AXLevelIndicator.
2732
2733         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2734
2735 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2736
2737         [WebAuthN] Implement FIDO AppID extension
2738         https://bugs.webkit.org/show_bug.cgi?id=143491
2739         <rdar://problem/48298273>
2740
2741         Reviewed by Brent Fulgham.
2742
2743         Add a test that covers the new flag of convertToU2fSignCommand.
2744
2745         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2746         (TestWebKitAPI::TEST):
2747         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2748         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2749         (TestWebKitAPI::TEST):
2750
2751 2019-03-19  Keith Rollin  <krollin@apple.com>
2752
2753         Add support for more platforms to generate-xcfilelists
2754         https://bugs.webkit.org/show_bug.cgi?id=195977
2755
2756         Reviewed by Alexey Proskuryakov.
2757
2758         generate-xcfilelists incorrectly complains when involved with building
2759         WebKit for iphonesimulator:
2760
2761             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2762             …
2763             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2764
2765         Address this by teaching generate-xcfilelists about more platforms.
2766
2767         * Scripts/generate-xcfilelists:
2768
2769 2019-03-19  John Wilander  <wilander@apple.com>
2770
2771         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2772         https://bugs.webkit.org/show_bug.cgi?id=195923
2773         <rdar://problem/49001272>
2774
2775         Reviewed by Alex Christensen.
2776
2777         This patch does the following to the TestRunner:
2778         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2779         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2780         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2781
2782         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2783         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2784         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2785         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2786         * WebKitTestRunner/TestController.cpp:
2787         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2788         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2789         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2790         * WebKitTestRunner/TestController.h:
2791         * WebKitTestRunner/TestInvocation.cpp:
2792         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2793
2794 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2795
2796         [CMake] Support more clang and gcc sanitizers
2797         https://bugs.webkit.org/show_bug.cgi?id=195956
2798
2799         Reviewed by Michael Catanzaro.
2800
2801         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2802
2803 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2804
2805         [ews-build] Improve summary for PrintConfiguration step
2806         https://bugs.webkit.org/show_bug.cgi?id=195945
2807
2808         Reviewed by Lucas Forschler.
2809
2810         * BuildSlaveSupport/ews-build/steps.py:
2811         (PrintConfiguration.getResultSummary): Override getResultSummary.
2812
2813 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2814
2815         [ews-build] Improve summary for CheckOutSource step
2816         https://bugs.webkit.org/show_bug.cgi?id=195963
2817
2818         Reviewed by Lucas Forschler.
2819
2820         * BuildSlaveSupport/ews-build/steps.py:
2821         (CheckOutSource.getResultSummary):
2822
2823 2019-03-19  Daniel Bates  <dabates@apple.com>
2824
2825         [iOS] Focus not preserved when switching between tabs
2826         https://bugs.webkit.org/show_bug.cgi?id=195820
2827         <rdar://problem/43614450>
2828
2829         Reviewed by Brent Fulgham.
2830
2831         Add tests to ensure that we restore focus when resigning and becoming first responder.
2832
2833         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2834         (TestWebKitAPI::TEST):
2835
2836 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2837
2838         Make WTFLogChannelState and WTFLogLevel enum classes
2839         https://bugs.webkit.org/show_bug.cgi?id=195904
2840
2841         Reviewed by Eric Carlson.
2842
2843         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2844         (TestWebKitAPI::TEST_F):
2845
2846 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2847
2848         [GStreamer][EME] Backported mssdemux protection data crash fix
2849         https://bugs.webkit.org/show_bug.cgi?id=195918
2850
2851         Reviewed by Philippe Normand.
2852
2853         * gstreamer/jhbuild.modules:
2854         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2855
2856 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2857
2858         Unreviewed, rolling out r243132.
2859
2860         Broke GTK build
2861
2862         Reverted changeset:
2863
2864         "Make WTFLogChannelState and WTFLogLevel enum classes"
2865         https://bugs.webkit.org/show_bug.cgi?id=195904
2866         https://trac.webkit.org/changeset/243132
2867
2868 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2869
2870         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2871
2872         * Scripts/webkitdirs.pm:
2873         (builtDylibPathForName): Adjust the shared library name that's changed
2874         with the API version bump in r243073.
2875
2876 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2877
2878         Make WTFLogChannelState and WTFLogLevel enum classes
2879         https://bugs.webkit.org/show_bug.cgi?id=195904
2880
2881         Reviewed by Eric Carlson.
2882
2883         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2884         (TestWebKitAPI::TEST_F):
2885
2886 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2887
2888         Disable flaky test added in r2431100
2889         https://webkit.org/b/195785
2890
2891         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2892         (TestWebKitAPI::TEST):
2893         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2894
2895 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2896
2897         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2898         https://bugs.webkit.org/show_bug.cgi?id=195916
2899
2900         Reviewed by Tim Horton.
2901
2902         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2903         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2904
2905 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2906
2907         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2908
2909         * Scripts/webkitpy/common/config/contributors.json:
2910
2911 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2912
2913         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2914         https://bugs.webkit.org/show_bug.cgi?id=195785
2915
2916         Reviewed by Geoffrey Garen.
2917
2918         * TestWebKitAPI/TCPServer.cpp: Added.
2919         (TestWebKitAPI::TCPServer::TCPServer):
2920         (TestWebKitAPI::TCPServer::~TCPServer):
2921         (TestWebKitAPI::TCPServer::socketBindListen):
2922         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2923         * TestWebKitAPI/TCPServer.h: Added.
2924         (TestWebKitAPI::TCPServer::port const):
2925         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2926         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2927         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2928         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2929         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2930         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2931         (TestWebKitAPI::respondSlowly):
2932         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2933         (TestWebKitAPI::downloadAtRate):
2934         (TestWebKitAPI::TEST):
2935
2936 2019-03-18  Saam Barati  <sbarati@apple.com>
2937
2938         Add a plan file for JetStream 2
2939         https://bugs.webkit.org/show_bug.cgi?id=190734
2940
2941         Reviewed by Mark Lam.
2942
2943         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2944
2945 2019-03-18  Chris Dumez  <cdumez@apple.com>
2946
2947         Delay WebProcess launch until a load is triggered in a Web view
2948         https://bugs.webkit.org/show_bug.cgi?id=195758
2949         <rdar://problem/48126013>
2950
2951         Reviewed by Geoff Garen.
2952
2953         Add API test coverage. Also update some existing API tests to not expect
2954         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2955
2956         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2957         (TestWebKitAPI::TEST):
2958         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2959         (TestWebKitAPI::TEST):
2960         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2961         (TEST):
2962         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2963         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2964         (TEST):
2965         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2966         (TEST):
2967         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2968
2969 2019-03-18  Xan Lopez  <xan@igalia.com>
2970
2971         [CMake] Prevent potential warning when determining $architecture
2972         https://bugs.webkit.org/show_bug.cgi?id=195891
2973
2974         Reviewed by Michael Catanzaro.
2975
2976         It's possible for generateBuildSystemForCMakeProject to be called
2977         before determineArchitecture() is ever called. This will make the
2978         first eq check with $architecture to be bogus (and print a
2979         warning). Change that to an eq check with architecture(), which
2980         implicitly calls determineArchitecture() if needed, and change all
2981         the other similar cases in the method in the same way to prevent
2982         future bugs like this one.
2983
2984         * Scripts/webkitdirs.pm:
2985         (generateBuildSystemFromCMakeProject):
2986
2987 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2988
2989         [WPE] Tarballs generated with “make dist” cannot build documentation
2990         https://bugs.webkit.org/show_bug.cgi?id=195885
2991
2992         Reviewed by Carlos Garcia Campos.
2993
2994         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2995
2996 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2997
2998         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2999         https://bugs.webkit.org/show_bug.cgi?id=195883
3000
3001         Reviewed by Carlos Garcia Campos.
3002
3003         * gtkdoc/gtkdoc.py:
3004         (GTKDoc._run_command): When commands fail to run, include the full command line for
3005         the program invocation and the output it has generated on the standard error stream.
3006
3007 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3008
3009         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3010         https://bugs.webkit.org/show_bug.cgi?id=195786
3011
3012         Reviewed by Philippe Normand.
3013
3014         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3015         * wpe/jhbuild.modules: Ditto.
3016
3017 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3018
3019         [ews-build] Don't run clean builds on EWS builders
3020         https://bugs.webkit.org/show_bug.cgi?id=195851
3021
3022         Reviewed by Geoffrey Garen.
3023
3024         * BuildSlaveSupport/ews-build/factories.py:
3025
3026 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3027
3028         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3029         https://bugs.webkit.org/show_bug.cgi?id=195849
3030
3031         Reviewed by Chris Dumez.
3032
3033         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3034
3035         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3036         (runWebsiteDataStoreCustomPaths):
3037
3038 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3039
3040         webkitpy: Upload test results
3041         https://bugs.webkit.org/show_bug.cgi?id=195755
3042         <rdar://problem/48896182>
3043
3044         Reviewed by Aakash Jain.
3045
3046         Establish a new format for uploading results that is not tied to layout tests, apply
3047         that format to webkitpy tests.
3048
3049         * Scripts/webkitpy/common/checkout/scm/git.py:
3050         (Git.native_branch): Return what branch the current checkout is on.
3051         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3052         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3053         * Scripts/webkitpy/common/checkout/scm/svn.py:
3054         (SVN.native_branch): Ditto.
3055         * Scripts/webkitpy/common/system/platforminfo.py:
3056         (PlatformInfo.build_version): Return a build version for Mac.
3057         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3058         (MockPlatformInfo.__init__):
3059         (MockPlatformInfo.build_version):
3060         * Scripts/webkitpy/results: Added.
3061         * Scripts/webkitpy/results/__init__.py: Added.
3062         * Scripts/webkitpy/results/options.py: Added.
3063         (upload_options): OptParse list for upload options.
3064         * Scripts/webkitpy/results/upload.py: Added.
3065         (Upload): Class which enforces the upload format expected by the results server.
3066         (Upload.Expectations):
3067         (Upload.create_configuration):
3068         (Upload.create_commit):
3069         (Upload.create_details):
3070         (Upload.create_run_stats):
3071         (Upload.create_test_result):
3072         (Upload.__init__):
3073         (Upload.Encoder): Encode Upload object as json.
3074         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3075         * Scripts/webkitpy/results/upload_unittest.py: Added.
3076         * Scripts/webkitpy/test/main.py:
3077         (Tester._parse_args): Add upload arguments.
3078         (Tester._run_tests): Allow results to be uploaded.
3079         * Scripts/webkitpy/test/runner.py:
3080         (Runner.__init__): Record which tests were run, rather than just counting them.
3081         (Runner.handle):
3082         * Scripts/webkitpy/test/runner_unittest.py:
3083         (RunnerTest.test_run):
3084         * Scripts/webkitpy/thirdparty/__init__.py:
3085         (AutoinstallImportHook.find_module): Add requests auto-install.
3086         (AutoinstallImportHook._install_requests):
3087         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3088         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3089
3090 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3091
3092         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3093         https://bugs.webkit.org/show_bug.cgi?id=195810
3094
3095         Reviewed by Tim Horton.
3096
3097         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3098         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3099         ending certain layout tests.
3100
3101         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3102         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3103         (-[TestRunnerWKWebView dealloc]):
3104         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3105
3106         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3107         helper method when destroying the web view, and when resetting state between tests.
3108
3109         * WebKitTestRunner/ios/TestControllerIOS.mm:
3110         (WTR::TestController::platformResetStateToConsistentValues):
3111
3112         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3113
3114 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3115
3116         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3117         https://bugs.webkit.org/show_bug.cgi?id=190350
3118         <rdar://problem/45089503>
3119
3120         Reviewed by Geoffrey Garen.
3121
3122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3123         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3124         (TEST):
3125         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3126         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3127         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3128         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3129         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3130         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3131         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3132         (runTest):
3133         (createDirectories):
3134         (TEST):
3135         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3136         (TEST):
3137         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3138         (TEST):
3139
3140 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3141
3142         Add support to WebPage for getting the contents as an attributed string.
3143         https://bugs.webkit.org/show_bug.cgi?id=195636
3144         rdar://problem/45055697
3145
3146         Reviewed by Tim Horton.
3147
3148         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3149         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3150
3151 2019-03-15  Chris Dumez  <cdumez@apple.com>
3152
3153         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3154         https://bugs.webkit.org/show_bug.cgi?id=195747
3155
3156         Reviewed by Geoff Garen.
3157
3158         Add API test coverage.
3159
3160         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3161
3162 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3163
3164         Unreviewed, rolling out r242952.
3165
3166         Causing API failures on iOS Simulator
3167
3168         Reverted changeset:
3169
3170         "[PSON] Make sure the WebProcessCache is leverage when
3171         relaunching a process after termination"
3172         https://bugs.webkit.org/show_bug.cgi?id=195747
3173         https://trac.webkit.org/changeset/242952
3174
3175 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3176
3177         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3178         https://bugs.webkit.org/show_bug.cgi?id=195740
3179
3180         Reviewed by Ross Kirsling.
3181
3182         window.open doesn't work for WebKitBrowserWindow because it is not
3183         implemented yet.
3184
3185         1. Implemented createNewPage callback of WKPageUIClient.
3186         2. Changed MainWindow to take a BrowserWindow factory function
3187           instead of BrowserWindowType to be flexible to create
3188           BrowserWindow with extra settings.
3189         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3190           because it is not relevant with MainWindow anymore.
3191
3192         * MiniBrowser/win/Common.cpp:
3193         (parseCommandLine):
3194         * MiniBrowser/win/Common.h:
3195         (CommandLineOptions::CommandLineOptions):
3196         * MiniBrowser/win/MainWindow.cpp:
3197         (MainWindow::MainWindow):
3198         (MainWindow::create):
3199         (MainWindow::init):
3200         (MainWindow::WndProc):
3201         * MiniBrowser/win/MainWindow.h:
3202         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3203         (PrintWebUIDelegate::createWebViewWithRequest):
3204         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3205         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3206         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3207         (WebKitBrowserWindow::updateProxySettings):
3208         (WebKitBrowserWindow::createNewPage):
3209         * MiniBrowser/win/WebKitBrowserWindow.h:
3210         * MiniBrowser/win/WinMain.cpp:
3211         (wWinMain):
3212
3213 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3214
3215         Make it possible to test scrolling tree layer manipulation more easily
3216         https://bugs.webkit.org/show_bug.cgi?id=195780
3217
3218         Reviewed by Tim Horton.
3219         
3220         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3221         cuts off communication of scrolling tree scrolls back to the web process
3222         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3223         allows tests to trigger scrolls which run the scrolling tree layer positioning
3224         logic, but never get another commit from the web process that might mask
3225         scrolling tree bugs.
3226         
3227         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3228         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3229         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3230
3231         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3232         (WTR::UIScriptController::scrollUpdatesDisabled const):
3233         (WTR::UIScriptController::setScrollUpdatesDisabled):
3234         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3235         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3236         (WTR::UIScriptController::scrollUpdatesDisabled const):
3237         (WTR::UIScriptController::setScrollUpdatesDisabled):
3238         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3239         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3240         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3241         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3242         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3243         * WebKitTestRunner/ios/TestControllerIOS.mm:
3244         (WTR::TestController::platformResetStateToConsistentValues):
3245         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3246         (WTR::UIScriptController::scrollUpdatesDisabled const):
3247         (WTR::UIScriptController::setScrollUpdatesDisabled):
3248
3249 2019-03-14  Youenn Fablet  <youenn@apple.com>
3250
3251         Move IDB storage in private browsing mode to NetworkProcess
3252         https://bugs.webkit.org/show_bug.cgi?id=195602
3253
3254         Reviewed by Brady Eidson.
3255
3256         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3257         (TEST):
3258
3259 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3260
3261         [ews-build] Make descriptionDone messages more readable
3262         https://bugs.webkit.org/show_bug.cgi?id=195760
3263
3264         Reviewed by Lucas Forschler.
3265
3266         * BuildSlaveSupport/ews-build/steps.py:
3267         * BuildSlaveSupport/ews-build/steps_unittest.py:
3268
3269 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3270
3271         [ews-build] Generate status-bubble hover-over messages
3272         https://bugs.webkit.org/show_bug.cgi?id=195680
3273
3274         Reviewed by Lucas Forschler.
3275
3276         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3277         (StatusBubble):
3278         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3279         on hover-over.
3280         (StatusBubble._iso_time):
3281         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3282         hover-over message.
3283         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3284
3285 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3286
3287         [ews-app] Gracefully handle the case when state_string is None
3288         https://bugs.webkit.org/show_bug.cgi?id=195753
3289
3290         Reviewed by Lucas Forschler.
3291
3292         * BuildSlaveSupport/ews-app/ews/models/build.py:
3293         * BuildSlaveSupport/ews-app/ews/models/step.py:
3294
3295 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3296
3297         [ews-app] Status bubble display pending for currently running build step
3298         https://bugs.webkit.org/show_bug.cgi?id=195744
3299
3300         Reviewed by Lucas Forschler.
3301
3302         * BuildSlaveSupport/ews-build/events.py:
3303         (Events.stepStarted): If state_string is pending, replace it with step name.
3304
3305 2019-03-14  Chris Dumez  <cdumez@apple.com>
3306
3307         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3308         https://bugs.webkit.org/show_bug.cgi?id=195750
3309
3310         Reviewed by Geoffrey Garen.
3311
3312         Add API test coverage.
3313
3314         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3315         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3316         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3317         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3318
3319 2019-03-14  Chris Dumez  <cdumez@apple.com>
3320
3321         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3322         https://bugs.webkit.org/show_bug.cgi?id=195747
3323
3324         Reviewed by Geoff Garen.
3325
3326         Add API test coverage.
3327
3328         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3329
3330 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3331
3332         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3333         https://bugs.webkit.org/show_bug.cgi?id=195725
3334         <rdar://problem/48545062>
3335
3336         Reviewed by Tim Horton.
3337
3338         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3339         handler is nil.
3340
3341         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3342         (TestWebKitAPI::TEST):
3343
3344 2019-03-13  Sam Weinig  <sam@webkit.org>
3345
3346         Add utility function to allow easy reverse range-based iteration of a container
3347         https://bugs.webkit.org/show_bug.cgi?id=195542
3348
3349         Reviewed by Antti Koivisto.
3350
3351         * TestWebKitAPI/CMakeLists.txt:
3352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3353         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3354         (TestWebKitAPI::TEST):
3355         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3356
3357 2019-03-13  Chris Dumez  <cdumez@apple.com>
3358
3359         Use a ServiceWorker process per registrable domain
3360         https://bugs.webkit.org/show_bug.cgi?id=195649
3361
3362         Reviewed by Youenn Fablet.
3363
3364         Update API test coverage.
3365
3366         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3367
3368 2019-03-13  Chris Dumez  <cdumez@apple.com>
3369
3370         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3371         https://bugs.webkit.org/show_bug.cgi?id=195684
3372         <rdar://problem/48294714>
3373
3374         Reviewed by Antti Koivisto.
3375
3376         Add API test coverage.
3377
3378         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3379
3380 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3381
3382         [ews-app] Remove unused patch view
3383         https://bugs.webkit.org/show_bug.cgi?id=195669
3384
3385         Reviewed by Lucas Forschler.
3386
3387         * BuildSlaveSupport/ews-app/ews/urls.py:
3388         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3389
3390 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3391
3392         [ews-app] Use Buildbot result code variables
3393         https://bugs.webkit.org/show_bug.cgi?id=195668
3394
3395         Reviewed by Alexey Proskuryakov.
3396
3397         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3398         (Buildbot): Added Buildbot result code variables.
3399         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3400         (StatusBubble._build_bubble): Used Buildbot result code variables.
3401
3402 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3403
3404         [Flatpak] Expand submodule recursively
3405         https://bugs.webkit.org/show_bug.cgi?id=195672
3406
3407         Building WPE with flatpak was impossible without that as it was raising an exception.
3408         Also update wpebackend-fdo to match what is built in jhbuild
3409
3410         Reviewed by Philippe Normand.
3411
3412         * flatpak/flatpakutils.py:
3413         (expand_submodules_recurse):
3414         (expand_manifest):
3415         * flatpak/org.webkit.WPEModules.yaml:
3416
3417 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3418
3419         [ews-app] status bubble should be hidden for certain builds
3420         https://bugs.webkit.org/show_bug.cgi?id=194597
3421
3422         Reviewed by Dewei Zhu.
3423
3424         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3425         (StatusBubble._build_bubble):
3426         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3427         because the patch didn't have relevant changes.
3428         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3429         in production yet.
3430
3431 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3432
3433         [Win] Fix a slew of simple clang-cl warnings.
3434         https://bugs.webkit.org/show_bug.cgi?id=195652
3435
3436         Reviewed by Don Olmstead.
3437
3438         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3439         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3440
3441 2019-03-12  Justin Fan  <justin_fan@apple.com>
3442
3443         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3444         https://bugs.webkit.org/show_bug.cgi?id=195518
3445         <rdar://problem/46322356>
3446
3447         Reviewed by Myles C. Maxfield.
3448
3449         * DumpRenderTree/DerivedSources-input.xcfilelist:
3450         * DumpRenderTree/DerivedSources-output.xcfilelist:
3451
3452 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3453
3454         Unreviewed, rolling out r242825.
3455         https://bugs.webkit.org/show_bug.cgi?id=195648
3456
3457         "Broke webkitpy tests with my change to
3458         lldb_dump_class_layout.py" (Requested by rmorisset on
3459         #webkit).
3460
3461         Reverted changeset:
3462
3463         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3464         classes with suspicious padding"
3465         https://bugs.webkit.org/show_bug.cgi?id=195573
3466         https://trac.webkit.org/changeset/242825
3467
3468 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3469
3470         [ews-build] Show status bubbles while the patch is waiting in queue
3471         https://bugs.webkit.org/show_bug.cgi?id=195618
3472
3473         Reviewed by Lucas Forschler.
3474
3475         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3476         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3477         enabled in initial deployment.
3478         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3479         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3480         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3481         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3482         (StatusBubble._build_bubbles_for_patch):
3483
3484 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3485
3486         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3487         https://bugs.webkit.org/show_bug.cgi?id=195573
3488
3489         Reviewed by Simon Fraser.
3490
3491         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3492
3493         * Scripts/dump-class-layout:
3494         (main):
3495         * lldb/lldb_dump_class_layout.py:
3496         (ClassLayout.__init__):
3497         (ClassLayout._compute_padding_recursive):
3498         (LLDBDebuggerInstance.dump_layout_for_classname):
3499         (LLDBDebuggerInstance):
3500         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3501         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3502
3503 2019-03-12  Chris Dumez  <cdumez@apple.com>
3504
3505         Device Orientation access permission should be denied unless explicitly granted by the client
3506         https://bugs.webkit.org/show_bug.cgi?id=195625
3507
3508         Reviewed by Youenn Fablet.
3509
3510         add API test coverage.
3511
3512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3513         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3514         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3515         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3516         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3517         (runDeviceOrientationTest):
3518         (TEST):
3519         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3520         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3521
3522 2019-03-12  Jer Noble  <jer.noble@apple.com>
3523
3524         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3525         https://bugs.webkit.org/show_bug.cgi?id=195137
3526         <rdar://problem/48810307>
3527
3528         Reviewed by Eric Carlson.
3529
3530         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3531         (TestWebKitAPI::TEST):
3532
3533 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3534
3535         [ews-build] Change urls from uat to production
3536         https://bugs.webkit.org/show_bug.cgi?id=195566
3537
3538         Reviewed by Lucas Forschler.
3539
3540         * BuildSlaveSupport/ews-app/ews/config.py:
3541         * BuildSlaveSupport/ews-build/events.py:
3542         * BuildSlaveSupport/ews-build/steps.py:
3543
3544 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3545
3546         [ews-build] change max_builds for local-worker to 1
3547         https://bugs.webkit.org/show_bug.cgi?id=195568
3548
3549         Reviewed by Lucas Forschler.
3550
3551         * BuildSlaveSupport/ews-build/loadConfig.py:
3552
3553 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3554
3555         Fix the build
3556
3557         * TestRunnerShared/spi/PencilKitTestSPI.h:
3558         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3559
3560 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3561
3562         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3563         https://bugs.webkit.org/show_bug.cgi?id=194131
3564
3565         Reviewed by Michael Catanzaro.
3566
3567         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3568         (uriChanged):
3569         (testUnfinishedSubresourceLoad):
3570         (serverCallback):
3571         (beforeAll):
3572
3573 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3574
3575         WTF::Expected should use std::addressof instead of operator&
3576         https://bugs.webkit.org/show_bug.cgi?id=195604
3577
3578         Reviewed by Myles Maxfield.
3579
3580         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3581         (TestWebKitAPI::Unique::Unique):
3582         (TestWebKitAPI::Unique::operator&):
3583         (TestWebKitAPI::TEST):
3584
3585 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3586
3587         Add Optional to Forward.h.
3588         https://bugs.webkit.org/show_bug.cgi?id=195586
3589
3590         Reviewed by Darin Adler.
3591
3592         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3593         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3594         Remove unnecessary includes from headers.
3595
3596 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3597
3598         Add testing API to hit-test and scroll overflow scrollers
3599         https://bugs.webkit.org/show_bug.cgi?id=195278
3600
3601         Reviewed by Antti Koivisto.
3602         
3603         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3604         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3605         
3606         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3607
3608         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3609         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3610         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3611         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3612         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3613         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3614         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3615         (WTR::enclosingScrollViewIncludingSelf):
3616         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3617
3618 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3619
3620         API test WebKit.RequestTextInputContext fails on iOS
3621         https://bugs.webkit.org/show_bug.cgi?id=195585
3622
3623         Reviewed by Wenson Hsieh and Simon Fraser.
3624
3625         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3626         (applyStyle):
3627         (TEST):
3628         Add a viewport, so that the coordinates match up on iOS.
3629         Scroll by moving the UIScrollView's contentOffset.
3630
3631 2019-03-11  Chris Dumez  <cdumez@apple.com>
3632
3633         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3634         https://bugs.webkit.org/show_bug.cgi?id=195506
3635         <rdar://problem/48733477>
3636
3637         Reviewed by Alex Christensen.
3638
3639         Add API test coverage.
3640
3641         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3642
3643 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3644
3645         Adding myself to contributors.json
3646
3647         Unreviewed, addming myself to contributors.json .
3648
3649         * Scripts/webkitpy/common/config/contributors.json:
3650
3651 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3652
3653         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3654         https://bugs.webkit.org/show_bug.cgi?id=195511
3655         <rdar://problem/44873269>
3656
3657         Reviewed by Darin Adler.
3658
3659         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3660         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3661         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3662         (TEST_F):
3663
3664 2019-03-11  Chris Dumez  <cdumez@apple.com>
3665
3666         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3667         https://bugs.webkit.org/show_bug.cgi?id=195561
3668
3669         Reviewed by Youenn Fablet.
3670
3671         Make sure the JS in the test requests for permission to receive device orientation events.
3672
3673         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3674
3675 2019-03-11  Youenn Fablet  <youenn@apple.com>
3676
3677         Allow storage quota increase by default in WTR
3678         https://bugs.webkit.org/show_bug.cgi?id=195541
3679
3680         Reviewed by Geoffrey Garen.
3681
3682         Allow storage quota increase by default in WTR.
3683         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3684         Use this for tests that explicitly need cache increase.
3685
3686         Instead of increasing quota by 2, make sure the next request is
3687         granted by adding all given parameters.
3688
3689         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3690         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3691         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3692         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3693         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3694         * WebKitTestRunner/TestController.cpp:
3695         (WTR::TestController::setAllowStorageQuotaIncrease):
3696         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3697         * WebKitTestRunner/TestController.h:
3698         * WebKitTestRunner/TestInvocation.cpp:
3699         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3700         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3701         (WTR::TestController::cocoaResetStateToConsistentValues):
3702         (WTR::TestController::setAllowStorageQuotaIncrease):
3703         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3704         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3705         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3706
3707 2019-03-11  Xan Lopez  <xan@igalia.com>
3708
3709         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3710         https://bugs.webkit.org/show_bug.cgi?id=194147
3711
3712         Reviewed by Michael Saboff.
3713
3714         To make --32-bit work correctly on Linux/64bit we need to:
3715
3716         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3717         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3718         unfortunately CMake only allows us to do this during
3719         crosscompilation, which is overkill here.
3720         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3721         pkg-config detection module uses the x86 .pc files instead of the
3722         x86_64 ones.
3723         - Set the -m32 flags for the compiler.
3724
3725         * Scripts/webkitdirs.pm:
3726         (generateBuildSystemFromCMakeProject):
3727
3728 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3729
3730         Add MotionMark-1.1 plan file for run-benchmark script.
3731         https://bugs.webkit.org/show_bug.cgi?id=195481
3732
3733         Rubber-stamped by Darin Adler.
3734
3735         Run-benchmark script should support MontionMark-1.1.
3736
3737         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3738
3739 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3740
3741         [ews-app] Add support for submit-to-ews url
3742         https://bugs.webkit.org/show_bug.cgi?id=195477
3743
3744         Reviewed by Lucas Forschler.
3745
3746         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3747         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3748         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3749         * BuildSlaveSupport/ews-app/ews/urls.py:
3750         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3751
3752 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3753
3754         Unreviewed, rolling out r242688, r242643, r242624.
3755
3756         Caused multiple layout test failures and crashes on iOS and macOS.
3757
3758         Reverted changeset:
3759
3760         "requestAnimationFrame should execute before the next frame"
3761         https://bugs.webkit.org/show_bug.cgi?id=177484
3762         https://trac.webkit.org/changeset/242624/webkit
3763
3764         * Tracing/SystemTracePoints.plist:
3765
3766 2019-03-11  John Wilander  <wilander@apple.com>
3767
3768         Resource Load Statistics: Make it possible exclude localhost from classification
3769         https://bugs.webkit.org/show_bug.cgi?id=195474
3770         <rdar://problem/47520577>
3771
3772         Reviewed by Brent Fulgham.
3773
3774         This patch allows for localhost to be excluded from classification and
3775         treatment as a prevalent resource.
3776
3777         The WebKit Tools change adds a new function called
3778         testRunner.setStatisticsIsRunningTest() which can be used to control this
3779         behavior.
3780
3781         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3782         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3783         (WTR::TestRunner::setStatisticsIsRunningTest):
3784         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3785         * WebKitTestRunner/TestController.cpp:
3786         (WTR::TestController::setStatisticsIsRunningTest):
3787         * WebKitTestRunner/TestController.h:
3788         * WebKitTestRunner/TestInvocation.cpp:
3789         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3790
3791 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3792
3793         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3794         https://bugs.webkit.org/show_bug.cgi?id=195560
3795
3796         Reviewed by Lucas Forschler.
3797
3798         * BuildSlaveSupport/ews-build/master.cfg:
3799
3800 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3801
3802         Unreviewed, rolling out r242698.
3803
3804         API test crashes on bots.
3805
3806         Reverted changeset:
3807
3808         "Add a WKContentRuleList variant that uses copied memory
3809         instead of mmap'd shared memory for class A containerized
3810         apps"
3811         https://bugs.webkit.org/show_bug.cgi?id=195511
3812         https://trac.webkit.org/changeset/242698
3813
3814 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3815
3816         [WPE] Enable web process sandbox
3817         https://bugs.webkit.org/show_bug.cgi?id=195169
3818
3819         Reviewed by Daniel Bates.
3820
3821         * wpe/install-dependencies:
3822         * wpe/jhbuild.modules:
3823
3824 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3825
3826         [ews-app] Use port 17000 for worker communication
3827         https://bugs.webkit.org/show_bug.cgi?id=195558
3828
3829         Reviewed by Lucas Forschler.
3830
3831         * BuildSlaveSupport/ews-build/master.cfg:
3832
3833 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3834
3835         [ews-build] unit-tests fail when passwords.json is missing
3836         https://bugs.webkit.org/show_bug.cgi?id=195557
3837
3838         Reviewed by Lucas Forschler.
3839
3840         * BuildSlaveSupport/ews-build/loadConfig.py:
3841         (loadBuilderConfig):
3842         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3843         (ConfigDotJSONTest.test_configuration):
3844         * BuildSlaveSupport/ews-build/master.cfg:
3845
3846 2019-03-11  Truitt Savell  <tsavell@apple.com>
3847
3848         Unreviewed, rolling out r242702.
3849
3850         Broke High Sierra builders.
3851
3852         Reverted changeset:
3853
3854         "Add utility function to allow easy reverse range-based
3855         iteration of a container"
3856         https://bugs.webkit.org/show_bug.cgi?id=195542
3857         https://trac.webkit.org/changeset/242702
3858
3859 2019-03-11  Sam Weinig  <sam@webkit.org>
3860
3861         Add utility function to allow easy reverse range-based iteration of a container
3862         https://bugs.webkit.org/show_bug.cgi?id=195542
3863
3864         Reviewed by Antti Koivisto.
3865
3866         * TestWebKitAPI/CMakeLists.txt:
3867         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3868         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3869         (TestWebKitAPI::TEST):
3870         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3871
3872 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3873
3874         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3875         https://bugs.webkit.org/show_bug.cgi?id=195511
3876         <rdar://problem/44873269>
3877
3878         Reviewed by Darin Adler.
3879
3880         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3881         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3882         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3883         (TEST_F):
3884
3885 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3886
3887         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3888         https://bugs.webkit.org/show_bug.cgi?id=195499
3889
3890         Reviewed by Darin Adler.
3891
3892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3893         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3894         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3895         (-[WKWebView synchronouslyFocusTextInputContext:]):
3896         (applyStyle):
3897         (applyIframe):
3898         (TEST):
3899         Add some tests for this SPI.
3900
3901 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3902
3903         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3904         https://bugs.webkit.org/show_bug.cgi?id=181151
3905
3906         Reviewed by Don Olmstead.
3907
3908         * TestWebKitAPI/CMakeLists.txt:
3909         * TestWebKitAPI/PlatformWin.cmake:
3910         Enable TestWTF RunLoop tests in all platforms.
3911
3912         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3913         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3914         (TestWebKitAPI::DerivedOneShotTimer::fired):
3915         (TestWebKitAPI::TEST):
3916         Only a few platforms support nested RunLoop.
3917
3918         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3919         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3920
3921 2019-03-10  David Quesada  <david_quesada@apple.com>
3922
3923         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3924         https://bugs.webkit.org/show_bug.cgi?id=152480
3925
3926         Reviewed by Chris Dumez.
3927
3928         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3929         there are no additional references to the process pool besides the one held by
3930         the download, waits for the download to finish (in the sense that the
3931         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3932         measure, also check that the process pool has been deallocated at the end of the
3933         test. The test wouldn't be meaningful if the process pool were still alive.
3934
3935         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3936         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3937         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3938             The download will be canceled because the delegate does not implement the
3939             method to decide the download's destination, so this is where we know the
3940             DownloadProxyMap is done with the DownloadProxy.
3941         (TEST):
3942
3943 2019-03-08  Chris Dumez  <cdumez@apple.com>
3944
3945         Add support for Device Orientation / Motion permission API
3946         https://bugs.webkit.org/show_bug.cgi?id=195329
3947         <rdar://problem/47645367>
3948
3949         Reviewed by Geoffrey Garen.
3950
3951         Add test infrastructure to help test the Device Orientation / Motion permission API.
3952
3953         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3954         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3955         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3956         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3957         * WebKitTestRunner/TestController.cpp:
3958         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3959         (WTR::TestController::createWebViewWithOptions):
3960         (WTR::TestController::resetStateToConsistentValues):
3961         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3962         * WebKitTestRunner/TestController.h:
3963         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3964         * WebKitTestRunner/TestInvocation.cpp:
3965         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3966
3967 2019-03-08  Saam barati  <sbarati@apple.com>
3968
3969         Add a compare-results script to compare benchmark results
3970         https://bugs.webkit.org/show_bug.cgi?id=195486
3971         <rdar://problem/48723397>
3972
3973         Reviewed by Geoffrey Garen.
3974
3975         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3976         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3977         to extend it to learn about our other benchmarks.
3978
3979         * Scripts/compare-results: Added.
3980         (readJSONFile):
3981         (detectJetStream2):
3982         (JetStream2Results):
3983         (detectSpeedometer2):
3984         (Speedometer2Results):
3985         (detectPLT5):
3986         (PLT5Results):
3987         (detectBenchmark):
3988         (biggerIsBetter):
3989         (ttest):
3990         (getOptions):
3991         (main):
3992
3993 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3994
3995         Ensure old tab state is cleared between iterations of run-benchmark
3996         https://bugs.webkit.org/show_bug.cgi?id=195393
3997         <rdar://problem/46885583>
3998
3999         Reviewed by Dewei Zhu.
4000
4001         a) ensure the default to restore state is not set
4002         b) terminate Safari correctly
4003         c) Set the system default to ignore Persistent State in Safari
4004
4005         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
4006         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
4007         (OSXBrowserDriver.prepare_env): 
4008         (OSXBrowserDriver.restore_env):
4009         (OSXBrowserDriver.close_browsers):
4010         (OSXBrowserDriver._terminate_processes):
4011         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
4012         (OSXChromeDriver):
4013         (OSXChromeCanaryDriver):
4014         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
4015         (OSXFirefoxDriver):
4016         (OSXFirefoxNightlyDriver):
4017         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
4018         (OSXSafariDriver):
4019         (OSXSafariDriver.prepare_env):
4020
4021 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
4022
4023         [GTK] Several InputMethodFilter tests are failing
4024         https://bugs.webkit.org/show_bug.cgi?id=195408
4025
4026         Reviewed by Carlos Garcia Campos.
4027
4028         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
4029         Regressed in r241751.
4030         Hexadecimal values of keycodes are expressed now in upper letters.
4031         Composited characters should be cast to UTF8 strings.
4032
4033         (TestWebKitAPI::TEST):
4034
4035 2019-03-07  Tomas Popela  <tpopela@redhat.com>
4036
4037         [GTK] Make Tools/gtkdoc python3 compatible
4038         https://bugs.webkit.org/show_bug.cgi?id=195359
4039
4040         Reviewed by Carlos Garcia Campos.
4041
4042         * gtkdoc/generate-gtkdoc:
4043         ConfigParser was reworked in Python 3.2 so we have adapt the code to
4044         work with Python 2 and 3.
4045         (get_gtkdoc_module_paths):
4046         The iteritems() was removed in Python 3, so let's use items() that's
4047         available in Python 2 and 3.
4048         (get_generator_for_config):
4049         * gtkdoc/gtkdoc.py:
4050         (GTKDoc._run_command):
4051         The sys.stdout.write() is expecting str in Python 3 and not bytes
4052         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
4053         for passing the bytes there.
4054
4055 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
4056
4057         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4058         https://bugs.webkit.org/show_bug.cgi?id=195346
4059         <rdar://problem/48667048>
4060
4061         Unreviewed build fix for clang-cl.
4062
4063         * DumpRenderTree/win/DumpRenderTree.cpp:
4064         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
4065
4066 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
4067
4068         requestAnimationFrame should execute before the next frame
4069         https://bugs.webkit.org/show_bug.cgi?id=177484
4070
4071         Reviewed by Simon Fraser.
4072
4073         Add trace points for the page RenderingUpdate.
4074
4075         * Tracing/SystemTracePoints.plist:
4076
4077 2019-03-07  Zalan Bujtas  <zalan@apple.com>
4078
4079         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
4080         https://bugs.webkit.org/show_bug.cgi?id=195353
4081         <rdar://problem/48626394>
4082
4083         Reviewed by Simon Fraser.
4084
4085         * WebKitTestRunner/ios/TestControllerIOS.mm:
4086         (WTR::TestController::platformResetPreferencesToConsistentValues):
4087
4088 2019-03-07  John Wilander  <wilander@apple.com>
4089
4090         Resource Load Statistics: Make it possible to purge only script-accessible cookies
4091         https://bugs.webkit.org/show_bug.cgi?id=195383
4092         <rdar://problem/48570136>
4093
4094         Reviewed by Brent Fulgham.
4095
4096         This patch adds test infrastructure to purge only script-accessible cookies,
4097         including a new testRunner function called statisticsDeleteCookiesForHost().git a
4098
4099         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4100         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4101         (WTR::TestRunner::statisticsDeleteCookiesForHost):
4102         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4103         * WebKitTestRunner/TestController.cpp:
4104         (WTR::TestController::statisticsDeleteCookiesForHost):
4105         * WebKitTestRunner/TestController.h:
4106         * WebKitTestRunner/TestInvocation.cpp:
4107         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4108
4109 2019-03-07  Commit Queue  <commit-queue@webkit.org>
4110
4111         Unreviewed, rolling out r242354.
4112         https://bugs.webkit.org/show_bug.cgi?id=195402
4113
4114         breaks layout tests in all configurations (Requested by
4115         zdobersek on #webkit).
4116
4117         Reverted changeset:
4118
4119         "[WPE] Enable web process sandbox"
4120         https://bugs.webkit.org/show_bug.cgi?id=195169
4121         https://trac.webkit.org/changeset/242354
4122
4123 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
4124
4125         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4126         https://bugs.webkit.org/show_bug.cgi?id=195346
4127
4128         Reviewed by Fujii Hironori.
4129
4130         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
4131         (TestWebKitAPI::TEST):
4132         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
4133
4134         * DumpRenderTree/win/DumpRenderTree.cpp:
4135         (findFontFallback):
4136         (addFontFallbackIfPresent):
4137         (removeFontFallbackIfPresent):
4138         (main):
4139         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4140         (TestWebKitAPI::Util::moduleDirectory):
4141         (TestWebKitAPI::Util::createInjectedBundlePath):
4142         Use wchar helpers as needed.
4143
4144 2019-03-06  Rob Buis  <rbuis@igalia.com>
4145
4146         Consider supporting the `referrerpolicy` attribute.
4147         https://bugs.webkit.org/show_bug.cgi?id=179053
4148
4149         Reviewed by Darin Adler.
4150
4151         Add a runtime flag for referrerpolicy attribute.
4152
4153         * DumpRenderTree/mac/DumpRenderTree.mm:
4154         (enableExperimentalFeatures):
4155
4156 2019-03-05  Daniel Bates  <dabates@apple.com>
4157
4158         Update expected API test result following r242379
4159         (https://bugs.webkit.org/show_bug.cgi?id=195125)
4160
4161         Update expected x-coordinate of selection rect now that the left padding of
4162         a textarea is sized in ems (so dependent on the font size) just like the left
4163         padding of a text field.
4164
4165         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4166         (TestWebKitAPI::TEST):
4167
4168 2019-03-05  David Quesada  <david_quesada@apple.com>
4169
4170         [WK2] It should be possible to follow links with 'download' attributes
4171         https://bugs.webkit.org/show_bug.cgi?id=195145
4172         rdar://problem/48462642
4173
4174         Reviewed by Alex Christensen.
4175
4176         Add a unit test to verify that activating links with 'download' attributes now
4177         navigates to the linked resource, rather than starts downloading it. Add another
4178         to verify that it is still possible to explicitly download the link via the
4179         'Download' navigation action policy.
4180
4181         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4182         (-[DownloadAttributeTestDelegate init]):
4183         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
4184         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
4185         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
4186         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
4187         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4188         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
4189         (TEST):
4190         * WebKitTestRunner/TestController.cpp:
4191         (WTR::TestController::decidePolicyForNavigationAction):
4192         * WebKitTestRunner/TestController.h:
4193
4194 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
4195
4196         [Curl] Implement Cookie Accept Policy.
4197         https://bugs.webkit.org/show_bug.cgi?id=191645
4198
4199         Reviewed by Fujii Hironori.
4200
4201         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4202         (TestWebKitAPI::Curl::TEST_F):
4203
4204 2019-03-05  Youenn Fablet  <youenn@apple.com>
4205
4206         Rename requestCacheStorageSpace to requestStorageSpace
4207         https://bugs.webkit.org/show_bug.cgi?id=195282
4208
4209         Reviewed by Chris Dumez.
4210
4211         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4212         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4213         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
4214
4215 2019-03-05  Brady Eidson  <beidson@apple.com>
4216
4217         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
4218         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
4219
4220         Reviewed by Tim Horton.
4221
4222         Loading a file: URL into a WKWebView and then loading another file: url from a completely
4223         different directory into that same WKWebView should work.
4224
4225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4226         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
4227
4228 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
4229
4230         Add WeakHashSet
4231         https://bugs.webkit.org/show_bug.cgi?id=195152
4232
4233         Reviewed by Antti Koivisto.
4234
4235         Added tests for WeakHashSet.
4236
4237         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4238         (TestWebKitAPI::Base::Base): Moved.
4239         (TestWebKitAPI::Derived::foo): Moved.
4240         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
4241         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
4242         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
4243         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
4244
4245 2019-03-04  Chris Dumez  <cdumez@apple.com>
4246
4247         Do not share WebProcesses between private and regular sessions
4248         https://bugs.webkit.org/show_bug.cgi?id=195189
4249         <rdar://problem/48421064>
4250
4251         Reviewed by Alex Christensen.
4252
4253         Add API test coverage.
4254
4255         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4256         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4257
4258 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
4259
4260         [WPE] Enable web process sandbox
4261         https://bugs.webkit.org/show_bug.cgi?id=195169
4262
4263         Reviewed by Daniel Bates.
4264
4265         * wpe/install-dependencies:
4266         * wpe/jhbuild.modules:
4267
4268 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4269
4270         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
4271         https://bugs.webkit.org/show_bug.cgi?id=195206
4272
4273         Reviewed by Žan Doberšek.
4274
4275         Add a new test case.
4276
4277         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4278         (testJSCClass):
4279
4280 2019-03-04  Charlie Turner  <cturner@igalia.com>
4281
4282         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
4283         https://bugs.webkit.org/show_bug.cgi?id=194898
4284
4285         Reviewed by Žan Doberšek.
4286
4287         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
4288         a GCC extension that permits arithmetic on void* pointer. Inline
4289         the macro until this issue is fixed upstream.
4290
4291 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4292
4293         Rid the world of WK_API_ENABLED
4294         https://bugs.webkit.org/show_bug.cgi?id=195263
4295
4296         Reviewed by Dan Bernstein.
4297
4298         List of changed files elided because it's useless.
4299
4300 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4301
4302         Unreviewed follow-up to r242292.
4303
4304         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4305
4306         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4307         (TestWebKitAPI::testStrip): Renamed from strip.
4308         (TestWebKitAPI::TEST):
4309
4310 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4311
4312         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4313
4314         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4315         and bug #194272 for details.
4316
4317         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4318
4319 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4320
4321         Remove some more unused 32-bit code
4322         https://bugs.webkit.org/show_bug.cgi?id=195255
4323
4324         Reviewed by Darin Adler.
4325
4326         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4327         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4328         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4329         (NPP_New):
4330         (NPP_HandleEvent):
4331         (handleEventCarbon): Deleted.
4332
4333 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4334
4335         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4336
4337         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4338         (TestWebKitAPI::TEST):
4339
4340 2019-03-01  Darin Adler  <darin@apple.com>
4341
4342         Finish removing String::format
4343         https://bugs.webkit.org/show_bug.cgi?id=194893
4344
4345         Reviewed by Daniel Bates.
4346 '
4347         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4348
4349 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4350
4351         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4352         https://bugs.webkit.org/show_bug.cgi?id=195229
4353         <rdar://problem/48520362>
4354
4355         Reviewed by Chris Dumez.
4356
4357         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4358         (TEST):
4359
4360 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4361
4362         Add a system trace scope for event region building
4363         https://bugs.webkit.org/show_bug.cgi?id=195226
4364
4365         Reviewed by Jon Lee.
4366