[iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
4         https://bugs.webkit.org/show_bug.cgi?id=196919
5         <rdar://problem/41630459>
6
7         Reviewed by Tim Horton.
8
9         Add iOS support for several new testing hooks. See below for more detail.
10
11         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
12         (WTR::UIScriptController::isDismissingMenu const):
13
14         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
15         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
16         by UIKit when dismissing the callout bar (i.e. UIMenuController).
17
18         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
19         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
20         (WTR::UIScriptController::isDismissingMenu const):
21         * TestRunnerShared/UIScriptContext/UIScriptController.h:
22         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
23         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
24         (WTR::InjectedBundle::didReceiveMessageToPage):
25         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
26         (WTR::TestRunner::setAllowedMenuActions):
27
28         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
29         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
30         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
31         against the name of the custom action.
32
33         (WTR::TestRunner::installCustomMenuAction):
34
35         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
36         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
37         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
38         triggered.
39
40         (WTR::TestRunner::performCustomMenuAction):
41
42         Invoked when the custom menu action is triggered.
43
44         * WebKitTestRunner/InjectedBundle/TestRunner.h:
45         * WebKitTestRunner/TestController.cpp:
46         (WTR::TestController::installCustomMenuAction):
47         (WTR::TestController::setAllowedMenuActions):
48         * WebKitTestRunner/TestController.h:
49         * WebKitTestRunner/TestInvocation.cpp:
50         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
51         (WTR::TestInvocation::performCustomMenuAction):
52
53         Add plumbing to call back into the injected bundle when performing the custom action.
54
55         * WebKitTestRunner/TestInvocation.h:
56         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
57         (WTR::TestController::installCustomMenuAction):
58         (WTR::TestController::setAllowedMenuActions):
59         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
60         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
61         (-[TestRunnerWKWebView initWithFrame:configuration:]):
62         (-[TestRunnerWKWebView becomeFirstResponder]):
63         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
64
65         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
66         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
67         in the Mail app on iOS.
68
69         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
70         (-[TestRunnerWKWebView setAllowedMenuActions:]):
71         (-[TestRunnerWKWebView resetCustomMenuAction]):
72         (-[TestRunnerWKWebView performCustomAction:]):
73         (-[TestRunnerWKWebView canPerformAction:withSender:]):
74         (-[TestRunnerWKWebView _willHideMenu]):
75         (-[TestRunnerWKWebView _didHideMenu]):
76         * WebKitTestRunner/ios/TestControllerIOS.mm:
77         (WTR::TestController::platformResetStateToConsistentValues):
78
79         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
80         if specified.
81
82         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
83         (WTR::UIScriptController::isDismissingMenu const):
84
85 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
86
87         Allow sharing from imageSheet on an image document
88         https://bugs.webkit.org/show_bug.cgi?id=196891
89         <rdar://problem/25377386>
90
91         Reviewed by Tim Horton.
92
93         Test to make sure that the correct imageURL is extracted from an image element.
94
95         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
96         (TestWebKitAPI::TEST):
97
98 2019-04-16  Alex Christensen  <achristensen@webkit.org>
99
100         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
101         https://bugs.webkit.org/show_bug.cgi?id=196995
102
103         Reviewed by Brady Eidson.
104
105         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
106         (TEST):
107
108 2019-04-16  Chris Dumez  <cdumez@apple.com>
109
110         URL set by document.open() is not communicated to the UIProcess
111         https://bugs.webkit.org/show_bug.cgi?id=196941
112         <rdar://problem/49237544>
113
114         Reviewed by Geoff Garen.
115
116         Add API test coverage.
117
118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
119         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
120         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
121         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
122         (TEST):
123
124 2019-04-16  Commit Queue  <commit-queue@webkit.org>
125
126         Unreviewed, rolling out r244321.
127         https://bugs.webkit.org/show_bug.cgi?id=196968
128
129         Causing all WK2 Debug builds to exit early after Assertion
130         failures. (Requested by ShawnRoberts on #webkit).
131
132         Reverted changeset:
133
134         "URL set by document.open() is not communicated to the
135         UIProcess"
136         https://bugs.webkit.org/show_bug.cgi?id=196941
137         https://trac.webkit.org/changeset/244321
138
139 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
140
141         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
142         https://bugs.webkit.org/show_bug.cgi?id=196948
143
144         Reviewed by Zalan Bujtas.
145
146         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
147         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
148
149 2019-04-15  Chris Dumez  <cdumez@apple.com>
150
151         URL set by document.open() is not communicated to the UIProcess
152         https://bugs.webkit.org/show_bug.cgi?id=196941
153         <rdar://problem/49237544>
154
155         Reviewed by Geoffrey Garen.
156
157         Add API test coverage.
158
159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
160         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
161         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
162         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
163         (TEST):
164
165 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
166
167         Using Tools/Scripts/clean-webkit should not install requests
168         https://bugs.webkit.org/show_bug.cgi?id=196940
169
170         Reviewed by Lucas Forschler.
171
172         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
173         existing, depending on the path autoinstalled is run through.
174         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
175         needed.
176         (Port.configuration_for_upload):
177         (Port.commits_for_upload):
178
179 2019-04-15  Alex Christensen  <achristensen@webkit.org>
180
181         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
182         https://bugs.webkit.org/show_bug.cgi?id=196773
183
184         Reviewed by Jer Noble.
185
186         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
187         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
188         (TEST):
189
190 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
191
192         ews-build should clearly indicate flaky test failures
193         https://bugs.webkit.org/show_bug.cgi?id=196947
194
195         Reviewed by Lucas Forschler.
196
197         * BuildSlaveSupport/ews-build/steps.py:
198         (AnalyzeAPITestsResults.analyzeResults):
199
200 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
201
202         InjectedBundle parameters often need initialization function called before unarchiving
203         https://bugs.webkit.org/show_bug.cgi?id=189709
204         <rdar://problem/44573653>
205
206         Reviewed by Ryosuke Niwa.
207
208         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
209         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
210
211 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
212
213         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
214         https://bugs.webkit.org/show_bug.cgi?id=196681
215
216         Reviewed by Darin Adler.
217
218         Added tests.
219
220         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
221         (WTF_HashSet.RemoveIf):
222         (WTF_HashSet.RemoveIfShrinkToBestSize):
223
224 2019-04-15  John Wilander  <wilander@apple.com>
225
226         Send delayed Ad Click Attribution conversion requests to the click source
227         https://bugs.webkit.org/show_bug.cgi?id=196838
228         <rdar://problem/47650157>
229
230         Reviewed by Chris Dumez and Youenn Fablet.
231
232         This patch adds test infrastructure to override the default behavior in
233         WebKit::NetworkAdClickAttribution.
234
235         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
236         (TestWebKitAPI::TEST):
237         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
238         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
239         (WTR::TestRunner::dumpAdClickAttribution):
240         (WTR::TestRunner::clearAdClickAttribution):
241         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
242         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
243         * WebKitTestRunner/InjectedBundle/TestRunner.h:
244         * WebKitTestRunner/TestController.cpp:
245         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
246         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
247         * WebKitTestRunner/TestController.h:
248         * WebKitTestRunner/TestInvocation.cpp:
249         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
250
251 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
252
253         [ews-app] status-bubble should display position in queue
254         https://bugs.webkit.org/show_bug.cgi?id=196607
255
256         Reviewed by Lucas Forschler.
257
258         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
259         (StatusBubble._build_bubble):
260         (StatusBubble._queue_position): Method to calculate patch's position in queue.
261
262 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
263
264         [ews-build] Do not run clean build by default on EWS builders
265         https://bugs.webkit.org/show_bug.cgi?id=196897
266
267         Reviewed by Lucas Forschler.
268
269         * BuildSlaveSupport/ews-build/steps.py:
270         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
271         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
272         untracked directories like WebKitBuild).
273         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
274         untracked files/directories (like WebKitBuild).
275
276 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
277
278         TestRunner::notifyDone() should be safely reentrant
279         https://bugs.webkit.org/show_bug.cgi?id=196898
280
281         Reviewed by Darin Adler.
282
283         It is currently possible that TestRunner::notifyDone() will call itself, since
284         notifyDone() will force a repaint, which can start executing JavaScript, which
285         may call notifyDone() again. This can lead to test failures and flakiness.
286         Fix this by setting the m_waitToDump flag before calling the dump() method.
287
288         * DumpRenderTree/mac/TestRunnerMac.mm:
289         (TestRunner::notifyDone):
290         (TestRunner::forceImmediateCompletion):
291         * DumpRenderTree/win/TestRunnerWin.cpp:
292         (TestRunner::notifyDone):
293         (TestRunner::forceImmediateCompletion):
294
295 2019-04-15  Philippe Normand  <pnormand@igalia.com>
296
297         [GTK][WPE] Add enable-media websetting
298         https://bugs.webkit.org/show_bug.cgi?id=196863
299
300         Reviewed by Michael Catanzaro.
301
302         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
303         (testWebKitSettings): Add test for the enable-media web-setting.
304
305 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
306
307         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
308         https://bugs.webkit.org/show_bug.cgi?id=196905
309         <rdar://problem/49886096>
310
311         Reviewed by Tim Horton.
312
313         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
314         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
315         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
316         delay timer, we end up with this sequence of events in the problematic (failure) case:
317
318         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
319             ...IPC from UI to web process...
320         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
321             ...IPC from web to UI process...
322         (c) [UI]    Invoke completion handler for script #1
323         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
324             ...IPC from UI to web process...
325         (e) [Web]   Evaluate script #2 in the web process
326         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
327
328         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
329         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
330         #2 is run in step (e).
331
332         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
333         the UI process by waiting on a script message posted by the web process, after attachment updates are
334         dispatched.
335
336         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
337         (TestWebKitAPI::TEST):
338
339 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
340
341         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
342         https://bugs.webkit.org/show_bug.cgi?id=196909
343
344         Reviewed by Wenson Hsieh.
345
346         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
347         (TestWebKitAPI::TEST):
348
349 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
350
351         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
352         https://bugs.webkit.org/show_bug.cgi?id=196880
353
354         Reviewed by Yusuke Suzuki.
355
356         Add a new function for bytecode cache tests that does not forceDiskCache
357         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
358         test added in this patch, since the code is invalid and therefore won't be
359         cached. It should also be useful for tests that evaluate dynamically
360         generated code.
361
362         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
363         * Scripts/run-jsc-stress-tests:
364
365 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
366
367         Update AudioSession route sharing policy
368         https://bugs.webkit.org/show_bug.cgi?id=196776
369         <rdar://problem/46501611>
370
371         Reviewed by Jer Noble.
372
373         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
374         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
375         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
376         (TestWebKitAPI::TEST):
377
378 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
379
380         [iOS] Software keyboard is shown too frequently on some websites
381         https://bugs.webkit.org/show_bug.cgi?id=195856
382         <rdar://problem/49191395>
383
384         Reviewed by Darin Adler.
385
386         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
387
388         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
389         (WTR::UIScriptController::setHardwareKeyboardAttached):
390         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
391         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
392         (WTR::UIScriptController::setHardwareKeyboardAttached):
393         * TestRunnerShared/UIScriptContext/UIScriptController.h:
394         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
395
396         Additionally link against GraphicsServices in WebKitTestRunner.
397
398         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
399         (WTR::TestController::platformResetStateToConsistentValues):
400         (WTR::UIScriptController::setHardwareKeyboardAttached):
401
402 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
403
404         [GTK][WPE] Fix pacman install-dependencies packages
405         https://bugs.webkit.org/show_bug.cgi?id=196817
406
407         Reviewed by Žan Doberšek.
408         
409         python3-setuptools is called python-setuptools
410         ruby-highline is only available on AUR
411         libv4l-devel is incorporated in v4l-utils
412
413         * gtk/install-dependencies:
414         * wpe/install-dependencies:
415
416 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
417
418         [GTK] REGRESSION(r243860): Many tests failing
419         https://bugs.webkit.org/show_bug.cgi?id=196791
420
421         Reviewed by Joanmarie Diggs.
422
423         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
424         multiple documents and check that accessibility hierarchy is updated after a navigation.
425
426         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
427         (loadChangedCallback):
428         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
429         (AccessibilityTest::AccessibilityTest):
430         (AccessibilityTest::~AccessibilityTest):
431         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
432         (AccessibilityTest::findTestServerApplication):
433         (AccessibilityTest::findDocumentWeb):
434         (AccessibilityTest::findRootObject):
435         (AccessibilityTest::waitUntilChildrenRemoved):
436         (AccessibilityTest::ensureProxy):
437         (testAtspiBasicHierarchy):
438         (beforeAll):
439         (afterAll):
440
441 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
442
443         [ews-build] Handle bug titles with unicode characters
444         https://bugs.webkit.org/show_bug.cgi?id=196802
445
446         Reviewed by Dewei Zhu.
447
448         * BuildSlaveSupport/ews-build/steps.py:
449         (ValidatePatch._is_bug_closed):
450
451 2019-04-11  Michael Saboff  <msaboff@apple.com>
452
453         Improve the Inline Cache Stats code
454         https://bugs.webkit.org/show_bug.cgi?id=196836
455
456         Reviewed by Saam Barati.
457
458         Added a new script to consolidate and arrange the output of --useICStats option.
459
460         This script merges the output from every group into one large table and sorts it from most common to
461         least common.  It also counts the slow path GetById and PutById variants and then calculates the
462         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
463         Put together, this is useful to see what property accesses are not getting cached.
464
465         * Scripts/ic-stats.py: Added.
466         (ICStats):
467         (ICStats.__init__):
468         (ICStats.parse):
469         (ICStats.dumpStats):
470         (usage):
471
472 2019-04-10  Alex Christensen  <achristensen@webkit.org>
473
474         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
475         https://bugs.webkit.org/show_bug.cgi?id=196809
476         <rdar://49800762>
477
478         Reviewed by Brady Eidson.
479
480         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
481         (TEST):
482
483 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
484
485         requestAnimationFrame should execute before the next frame
486         https://bugs.webkit.org/show_bug.cgi?id=177484
487
488         Reviewed by Simon Fraser.
489
490         Add trace points for the page RenderingUpdate.
491
492         * Tracing/SystemTracePoints.plist:
493
494 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
495
496         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
497         https://bugs.webkit.org/show_bug.cgi?id=196760
498
499         Reviewed by Don Olmstead.
500
501         vswhere.exe has been bundled since Visual Studio 2017 version
502         15.2. We shouldn't download vswhere.exe.
503
504         * Scripts/build-jsc: Do not call update-vswhere.py.
505         * Scripts/build-webkit: Ditto.
506         * Scripts/update-vswhere.py: Removed.
507         * Scripts/webkitdirs.pm:
508         (requireModulesForVSWhere): Deleted.
509         (pickCurrentVisualStudioInstallation): Deleted.
510         (visualStudioInstallDirVSWhere): Return the latest installed VS
511         installation path by using the bundled vswhere.exe.
512         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
513         (visualStudioInstallDirFallback): Removed.
514
515 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
516
517         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
518         https://bugs.webkit.org/show_bug.cgi?id=196780
519
520         Reviewed by Alexey Proskuryakov.
521
522         * BuildSlaveSupport/ews-build/steps.py:
523         * BuildSlaveSupport/ews-build/steps_unittest.py:
524
525 2019-04-10  Alex Christensen  <achristensen@webkit.org>
526
527         Add SPI WKNavigationResponse._downloadAttribute
528         https://bugs.webkit.org/show_bug.cgi?id=196755
529         <rdar://49587365>
530
531         Reviewed by Brady Eidson.
532
533         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
534         (-[NavigationResponseTestDelegate navigationResponse]):
535         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
536         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
537         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
538         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
539         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
540         (readRequest):
541         (writeResponse):
542         (TEST):
543
544 2019-04-10  Tim Horton  <timothy_horton@apple.com>
545
546         Add modern API for overriding the page's specified viewport configuration
547         https://bugs.webkit.org/show_bug.cgi?id=167734
548         <rdar://problem/30331795>
549
550         Reviewed by Simon Fraser.
551
552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
553         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
554
555 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
556
557         Add support for incremental bytecode cache updates
558         https://bugs.webkit.org/show_bug.cgi?id=195000
559
560         Reviewed by Filip Pizlo.
561
562         Exit when the initial run to generate bytecode fails.
563
564         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
565
566 2019-04-10  Alex Christensen  <achristensen@webkit.org>
567
568         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
569         https://bugs.webkit.org/show_bug.cgi?id=196744
570         <rdar://49415309>
571
572         Reviewed by Chris Dumez.
573
574         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
575         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
576
577 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
578
579         Add a way to opt into modern compatibility mode in layout tests
580         https://bugs.webkit.org/show_bug.cgi?id=196770
581         <rdar://problem/49777550>
582
583         Reviewed by Antoine Quint.
584
585         Add a new test option to enable modern compatibility mode in layout tests.
586
587         * WebKitTestRunner/TestController.cpp:
588         (WTR::updateTestOptionsFromTestHeader):
589         * WebKitTestRunner/TestController.h:
590         * WebKitTestRunner/TestOptions.h:
591         (WTR::TestOptions::hasSameInitializationOptions const):
592         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
593         (WTR::TestController::platformCreateWebView):
594         (WTR::TestController::enableModernCompatibilityMode):
595
596 2019-04-10  Andy Estes  <aestes@apple.com>
597
598         Try to fix the 32-bit watchOS build.
599
600         * TestWebKitAPI/cocoa/TestWKWebView.mm:
601         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
602
603 2019-04-10  Antoine Quint  <graouts@apple.com>
604
605         Enable Pointer Events on watchOS
606         https://bugs.webkit.org/show_bug.cgi?id=196771
607         <rdar://problem/49040909>
608
609         Reviewed by Dean Jackson.
610
611         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
612
613 2019-04-10  Philippe Normand  <pnormand@igalia.com>
614
615         Unreviewed. Fix WPE accessibility tests after r244059.
616
617         We are failing to load the injected bundle due to undefined symbol
618         AccessibilityUIElement::replaceTextInRange().
619
620         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
621         (WTR::AccessibilityUIElement::replaceTextInRange):
622
623 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
624
625         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
626         https://bugs.webkit.org/show_bug.cgi?id=196727
627
628         Reviewed by Fujii Hironori.
629
630         * MiniBrowser/win/WebKitBrowserWindow.cpp:
631         (WebKitBrowserWindow::create):
632
633 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
634
635         [ews-build] Add unit tests for PrintConfiguration
636         https://bugs.webkit.org/show_bug.cgi?id=196752
637
638         Reviewed by Dewei Zhu.
639
640         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
641
642 2019-04-09  Keith Rollin  <krollin@apple.com>
643
644         Unreviewed build maintenance -- update .xcfilelists.
645
646         * DumpRenderTree/DerivedSources-input.xcfilelist:
647         * DumpRenderTree/DerivedSources-output.xcfilelist:
648
649 2019-04-09  Zalan Bujtas  <zalan@apple.com>
650
651         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
652         https://bugs.webkit.org/show_bug.cgi?id=196743
653         <rdar://problem/43897551>
654
655         Reviewed by Tim Horton.
656
657         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
658         (TEST):
659
660 2019-04-09  Youenn Fablet  <youenn@apple.com>
661
662         Close service worker database on network process suspension
663         https://bugs.webkit.org/show_bug.cgi?id=196623
664         <rdar://problem/48930869>
665
666         Reviewed by Alex Christensen.
667
668         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
669
670 2019-04-09  Daniel Bates  <dabates@apple.com>
671
672         [iPad] Should open popover when the spacebar is pressed
673         https://bugs.webkit.org/show_bug.cgi?id=196360
674         <rdar://problem/49389129>
675
676         Reviewed by Brent Fulgham.
677
678         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
679
680         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
681         (WTR::UIScriptController::isShowingPopover const): Added.
682         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
683         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
684         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
685         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
686         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
687         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
688         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
689         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
690         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
691         (WTR::UIScriptController::isShowingPopover const): Added.
692         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
693         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
694         * TestRunnerShared/UIScriptContext/UIScriptController.h:
695         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
696         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
697         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
698         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
699         (-[TestRunnerWKWebView _willPresentPopover]): Added.
700         (-[TestRunnerWKWebView _didDismissPopover]): Added.
701         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
702         (WTR::UIScriptController::isShowingPopover const): Added.
703         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
704         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
705
706 2019-04-09  Alex Christensen  <achristensen@webkit.org>
707
708         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
709         https://bugs.webkit.org/show_bug.cgi?id=196665
710         <rdar://45115669>
711
712         Reviewed by Geoff Garen.
713
714         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
715         (goBack):
716         (+[SimpleLookupContext sharedLookupContext]):
717         (-[SimpleLookupContext lookUpURL:completionHandler:]):
718         (TEST):
719         (+[Simple3LookupContext sharedLookupContext]): Deleted.
720         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
721
722 2019-04-09  John Wilander  <wilander@apple.com>
723
724         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
725         https://bugs.webkit.org/show_bug.cgi?id=196558
726         <rdar://problem/47650245>
727
728         Reviewed by Youenn Fablet.
729
730         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
731         (TestWebKitAPI::TEST):
732             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
733
734 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
735
736         [CMake] Apple builds should use ICU_INCLUDE_DIRS
737         https://bugs.webkit.org/show_bug.cgi?id=196720
738
739         Reviewed by Konstantin Tokarev.
740
741         * TestWebKitAPI/PlatformMac.cmake:
742
743 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
744
745         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
746         https://bugs.webkit.org/show_bug.cgi?id=196694
747         <rdar://problem/48388734>
748
749         Rubber-stamped by Aakash Jain.
750
751         * Scripts/webkitpy/port/image_diff.py:
752         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
753         * Scripts/webkitpy/port/server_process.py:
754         (ServerProcess.has_available_stdout): Check if stdout has data in it.
755         (ServerProcess._wait_for_data_and_update_buffers_using_select):
756         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
757         * Scripts/webkitpy/port/server_process_mock.py:
758         (MockServerProcess.has_available_stdout):
759         * Scripts/webkitpy/port/server_process_unittest.py:
760         (TestServerProcess.serial_test_basic):
761
762 2019-04-09  Jer Noble  <jer.noble@apple.com>
763
764         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
765         https://bugs.webkit.org/show_bug.cgi?id=196097
766
767         Reviewed by Eric Carlson.
768
769         Drive-by bug fix: allow tests to play audio without a user gesture by default.
770
771         * DumpRenderTree/mac/DumpRenderTree.mm:
772         (resetWebPreferencesToConsistentValues):
773         * WebKitTestRunner/TestController.cpp:
774         (WTR::TestController::resetPreferencesToConsistentValues):
775
776 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
777
778         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
779         https://bugs.webkit.org/show_bug.cgi?id=196690
780
781         Reviewed by Michael Catanzaro.
782
783         * QueueStatusServer/config/queues.py:
784         * Scripts/webkitpy/common/config/ews.json:
785         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
786         (test_ews_name):
787
788 2019-04-09  Chris Dumez  <cdumez@apple.com>
789
790         Loads using loadHTMLString() cause flashing when process-swapping
791         https://bugs.webkit.org/show_bug.cgi?id=196714
792         <rdar://problem/49637354>
793
794         Reviewed by Antti Koivisto.
795
796         Add API test coverage.
797
798         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
799
800 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
801
802         Unreviewed. Fix ATK accessibility tests after r244059.
803
804         We are failing to load the injected bundle due to undefined symbol
805         AccessibilityUIElement::replaceTextInRange().
806
807         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
808         (WTR::AccessibilityUIElement::replaceTextInRange):
809
810 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
811
812         AX: Support API: accessibilityReplaceRange:withText
813         https://bugs.webkit.org/show_bug.cgi?id=196636
814
815         Unreviewed build fix for Windows port.
816
817         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
818         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
819
820 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
821
822         [CMake][WinCairo] Separate copied headers into different directories
823         https://bugs.webkit.org/show_bug.cgi?id=196655
824
825         Reviewed by Michael Catanzaro.
826
827         * DumpRenderTree/CMakeLists.txt:
828         * MiniBrowser/win/CMakeLists.txt:
829         * TestWebKitAPI/CMakeLists.txt:
830         * TestWebKitAPI/PlatformWin.cmake:
831
832 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
833
834         Log stack-trace for run-webkit-tests when interrupted
835         https://bugs.webkit.org/show_bug.cgi?id=176393
836         <rdar://problem/34262310>
837
838         Reviewed by Lucas Forschler.
839
840         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
841         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
842         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
843         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
844         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
845         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
846         (main): Set handlers to log stack trace on interruption.
847
848 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
849
850         AX: Support API: accessibilityReplaceRange:withText
851         https://bugs.webkit.org/show_bug.cgi?id=196636
852
853         Unreviewed build fix for Windows port.
854
855         * DumpRenderTree/AccessibilityUIElement.cpp:
856         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
857
858 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
859
860         [ews-build] Scripts using Buildbot API have CORS error
861         https://bugs.webkit.org/show_bug.cgi?id=196709
862
863         Reviewed by Alexey Proskuryakov.
864
865         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
866
867 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
868
869         AX: Support API: accessibilityReplaceRange:withText
870         https://bugs.webkit.org/show_bug.cgi?id=196636
871
872         Reviewed by Daniel Bates.
873
874         * DumpRenderTree/AccessibilityUIElement.cpp:
875         (replaceTextInRangeCallback):
876         (AccessibilityUIElement::replaceTextInRange):
877         (AccessibilityUIElement::getJSClass):
878         * DumpRenderTree/AccessibilityUIElement.h:
879         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
880         (AccessibilityUIElement::replaceTextInRange):
881         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
882         (AccessibilityUIElement::replaceTextInRange):
883         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
884         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
885         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
886         (WTR::AccessibilityUIElement::replaceTextInRange):
887         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
888         (WTR::AccessibilityUIElement::replaceTextInRange):
889
890 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
891
892         [iOS] Do not allow starting selection drags when selection views are not visible
893         https://bugs.webkit.org/show_bug.cgi?id=196686
894         <rdar://problem/49399192>
895
896         Reviewed by Tim Horton.
897
898         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
899         also add some new API tests to cover scenarios where the web view is not first responder.
900
901         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
902         (TestWebKitAPI::TEST):
903         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
904
905         Add a switch to optionally make the web view first responder when starting the simulated drag.
906
907         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
908         (-[DragAndDropSimulator initWithWebView:]):
909         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
910
911 2019-04-08  Justin Fan  <justin_fan@apple.com>
912
913         [Web GPU] Fix Web GPU experimental feature on iOS
914         https://bugs.webkit.org/show_bug.cgi?id=196632
915
916         Reviewed by Myles C. Maxfield.
917
918         Properly make Web GPU available on iOS 11+.
919
920         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
921
922 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
923
924         [ews-build] Do not upload archive when Compile Fails
925         https://bugs.webkit.org/show_bug.cgi?id=196674
926
927         Reviewed by Alexey Proskuryakov.
928
929         * BuildSlaveSupport/ews-build/factories.py:
930         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
931         * BuildSlaveSupport/ews-build/steps.py:
932         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
933         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
934         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
935
936 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
937
938         Enable DFG on MIPS
939         https://bugs.webkit.org/show_bug.cgi?id=196689
940
941         Reviewed by Žan Doberšek.
942
943         Since the bytecode change, we enabled the baseline JIT on mips in
944         r240432, but DFG is still missing. With this change, all tests are
945         passing on a ci20 board.
946
947         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
948
949 2019-04-08  Philippe Normand  <pnormand@igalia.com>
950
951         [Flatpak] Second run update-webkitwpe-flatpak fails
952         https://bugs.webkit.org/show_bug.cgi?id=192702
953
954         Reviewed by Carlos Garcia Campos.
955
956         * flatpak/flatpakutils.py:
957         (FlatpakObject.flatpak): Fix typo.
958         (FlatpakPackage.install): When installing, also update to the configured remote commit.
959         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
960
961 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
962
963         [GTK][WPE] outlook.live.com displays old-fashioned UI
964         https://bugs.webkit.org/show_bug.cgi?id=196642
965
966         Reviewed by Carlos Garcia Campos.
967
968         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
969         (TestWebKitAPI::TEST): New Mac platform quirk test.
970
971 2019-04-07  Commit Queue  <commit-queue@webkit.org>
972
973         Unreviewed, rolling out r243956.
974         https://bugs.webkit.org/show_bug.cgi?id=196688
975
976         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
977         by aakashjain on #webkit).
978
979         Reverted changeset:
980
981         "Clicking "Go Back" from a safe browsing warning from an
982         iframe should navigate the WKWebView back to the previous
983         page"
984         https://bugs.webkit.org/show_bug.cgi?id=196665
985         https://trac.webkit.org/changeset/243956
986
987 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
988
989         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
990         https://bugs.webkit.org/show_bug.cgi?id=196669
991
992         Reviewed by Geoffrey Garen.
993
994         Added three new unit tests for WeakHashSet.
995
996         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
997         (WTF_WeakPtr.WeakHashSetConstObjects):
998         (WTF_WeakPtr.WeakHashSetComputesEmpty):
999         (WTF_WeakPtr.WeakHashSetComputeSize):
1000
1001 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1002
1003         Hide next and previous form control buttons when WKWebView is editable
1004         https://bugs.webkit.org/show_bug.cgi?id=196672
1005         <rdar://problem/35625321>
1006
1007         Reviewed by Tim Horton.
1008
1009         Add a new API test.
1010
1011         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1012         (-[TestWKWebView lastTrailingBarButtonGroup]):
1013         (TestWebKitAPI::TEST):
1014         * TestWebKitAPI/ios/UIKitSPI.h:
1015
1016 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1017
1018         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1019         https://bugs.webkit.org/show_bug.cgi?id=196077
1020         <rdar://problem/49108202>
1021
1022         Reviewed by Chris Dumez.
1023
1024         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1025         on new web view.
1026
1027         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1028
1029 2019-04-05  Saam Barati  <sbarati@apple.com>
1030
1031         Make compare-results understand MotionMark
1032         https://bugs.webkit.org/show_bug.cgi?id=196666
1033
1034         Reviewed by Yusuke Suzuki.
1035
1036         * Scripts/compare-results:
1037         (PLT5Results):
1038         (detectMotionMark):
1039         (detectMotionMark1_1):
1040         (motionMarkResults):
1041         (motionMark1_1Results):
1042         (detectBenchmark):
1043         (biggerIsBetter):
1044         (main):
1045
1046 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1047
1048         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1049         https://bugs.webkit.org/show_bug.cgi?id=196665
1050         <rdar://45115669>
1051
1052         Reviewed by Geoff Garen.
1053
1054         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1055         (goBack):
1056         (+[SimpleLookupContext sharedLookupContext]):
1057         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1058         (TEST):
1059         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1060         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1061
1062 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1063
1064         [ews-build] Add configuration and architecture for windows builders
1065         https://bugs.webkit.org/show_bug.cgi?id=196660
1066
1067         Reviewed by Lucas Forschler.
1068
1069         * BuildSlaveSupport/ews-build/config.json:
1070
1071 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1072
1073         webkitpy: Don't run subsequent rounds if interrupted
1074         https://bugs.webkit.org/show_bug.cgi?id=196646
1075
1076         Reviewed by Aakash Jain.
1077
1078         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1079         (Manager.run): Bail out if interrupted.
1080
1081 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1082
1083         Test sessionStorage in PSON private browsing mode
1084         https://bugs.webkit.org/show_bug.cgi?id=196561
1085
1086         Reviewed by Alex Christensen.
1087
1088         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1089
1090 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1091
1092         Unreviewed, rolling out r243833.
1093         https://bugs.webkit.org/show_bug.cgi?id=196645
1094
1095         This change breaks build of WPE and GTK ports (Requested by
1096         annulen on #webkit).
1097
1098         Reverted changeset:
1099
1100         "[CMake][WTF] Mirror XCode header directories"
1101         https://bugs.webkit.org/show_bug.cgi?id=191662
1102         https://trac.webkit.org/changeset/243833
1103
1104 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1105
1106         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1107         https://bugs.webkit.org/show_bug.cgi?id=196635
1108
1109         Reviewed by Antti Koivisto.
1110         
1111         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1112         for a test to enable async frame scrolling via:
1113             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1114         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1115         
1116         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1117
1118         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1119         (WTR::InjectedBundle::beginTesting):
1120         * WebKitTestRunner/TestController.cpp:
1121         (WTR::TestController::resetPreferencesToConsistentValues):
1122
1123 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1124
1125         Use a correct LC_RPATH when building with ASan
1126         https://bugs.webkit.org/show_bug.cgi?id=196576
1127
1128         Reviewed by David Kilzer.
1129
1130         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1131         so that ../Frameworks is checked. This is simpler and more reliable than updating
1132         each SPC service xcconfig.
1133
1134 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1135
1136         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1137         https://bugs.webkit.org/show_bug.cgi?id=196629
1138
1139         Reviewed by Lucas Forschler.
1140
1141         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1142
1143 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1144
1145         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1146         https://bugs.webkit.org/show_bug.cgi?id=196618
1147
1148         Reviewed by Lucas Forschler.
1149
1150         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1151         (StatusBubble): Added QUEUE_TRIGGERS.
1152         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1153         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1154         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1155         its parent(builder).
1156
1157 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1158
1159         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1160         https://bugs.webkit.org/show_bug.cgi?id=196625
1161
1162         Reviewed by Lucas Forschler.
1163
1164         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1165         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1166
1167 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1168
1169         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1170         https://bugs.webkit.org/show_bug.cgi?id=196630
1171
1172         Reviewed by Wenson Hsieh.
1173
1174         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1175
1176 2019-04-04  Youenn Fablet  <youenn@apple.com>
1177
1178         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1179         https://bugs.webkit.org/show_bug.cgi?id=196543
1180
1181         Reviewed by Alex Christensen.
1182
1183         * WebKitTestRunner/TestController.cpp:
1184         (WTR::TestController::generatePageConfiguration):
1185
1186 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1187
1188         [ews-app] Status bubble should not display skipped buildbot steps
1189         https://bugs.webkit.org/show_bug.cgi?id=196584
1190
1191         Reviewed by Lucas Forschler.
1192
1193         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1194
1195 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1196
1197         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1198         https://bugs.webkit.org/show_bug.cgi?id=196620
1199
1200         Reviewed by Lucas Forschler.
1201
1202         * BuildSlaveSupport/ews-app/ews/config.py:
1203
1204 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1205
1206         [Win] DumpRenderTreeWatchDog.py is not checked into source
1207         https://bugs.webkit.org/show_bug.cgi?id=196567
1208         <rdar://problem/49525901>
1209
1210         Reviewed by Lucas Forschler.
1211
1212         This script is used on Win EWS bots to terminate hanging DRT processes.
1213
1214         * EWSTools/dumprendertreewatchdog.py: Added.
1215
1216 2019-04-04  Chris Dumez  <cdumez@apple.com>
1217
1218         Unreviewed, roll out r243858 which made tests time out.
1219
1220         Disable new API tests on Windows instead.
1221
1222         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1223         (TestWebKitAPI::TEST):
1224
1225 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1226
1227         [ATK] Cleanup WebPageAccessibilityObjectAtk
1228         https://bugs.webkit.org/show_bug.cgi?id=196537
1229
1230         Reviewed by Michael Catanzaro.
1231
1232         Also consider files under atk directories as exceptions for GObject conventions.
1233
1234         * Scripts/webkitpy/style/checkers/cpp.py:
1235         (check_identifier_name_in_declaration):
1236
1237 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1238
1239         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1240         https://bugs.webkit.org/show_bug.cgi?id=196588
1241         <rdar://problem/49365787>
1242
1243         Unreviewed build fix for Windows port.
1244
1245         error C3861: 'kill': identifier not found
1246
1247         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1248         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1249
1250 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1251
1252         [ews-build] Cancel build and similar operations should have authentication
1253         https://bugs.webkit.org/show_bug.cgi?id=196520
1254
1255         Reviewed by Dewei Zhu.
1256
1257         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1258         environment variables.
1259
1260 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1261
1262         [ews-build] Do not trigger queues which are not in production yet
1263         https://bugs.webkit.org/show_bug.cgi?id=196581
1264
1265         Reviewed by Dewei Zhu.
1266
1267         * BuildSlaveSupport/ews-build/config.json:
1268
1269 2019-04-03  Chris Dumez  <cdumez@apple.com>
1270
1271         Unreviewed, fix typo in the name of API test added in r243848.
1272
1273         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1274         (TestWebKitAPI::TEST):
1275
1276 2019-04-03  Chris Dumez  <cdumez@apple.com>
1277
1278         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1279         https://bugs.webkit.org/show_bug.cgi?id=196588
1280         <rdar://problem/49365787>
1281
1282         Reviewed by Ryosuke Niwa.
1283
1284         Add API test coverage.
1285
1286         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1287         (TestWebKitAPI::nullJavaScriptCallback):
1288         (TestWebKitAPI::didCrashCheckFrames):
1289         (TestWebKitAPI::TEST):
1290
1291 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1292
1293         run-webkit-tests: Upload test results (new results database)
1294         https://bugs.webkit.org/show_bug.cgi?id=196577
1295         <rdar://problem/34841155>
1296
1297         Reviewed by Lucas Forschler.
1298
1299         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1300         (Manager.run): Upload results after each device shard, since the configuration will be
1301         different for each device.
1302         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1303         uploaded to a results database.
1304         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1305         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1306
1307 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1308
1309         -apple-trailing-word is needed for browser detection
1310         https://bugs.webkit.org/show_bug.cgi?id=196575
1311
1312         Unreviewed.
1313
1314         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1315
1316 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1317
1318         [CMake][WTF] Mirror XCode header directories
1319         https://bugs.webkit.org/show_bug.cgi?id=191662
1320
1321         Reviewed by Konstantin Tokarev.
1322
1323         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1324         builds.
1325
1326         * CMakeLists.txt:
1327         * DumpRenderTree/CMakeLists.txt:
1328         * DumpRenderTree/PlatformWin.cmake:
1329         * MiniBrowser/win/CMakeLists.txt:
1330         * TestWebKitAPI/CMakeLists.txt:
1331         * TestWebKitAPI/PlatformWin.cmake:
1332         * WebKitTestRunner/PlatformGTK.cmake:
1333         * WebKitTestRunner/PlatformWin.cmake:
1334
1335 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1336
1337         [ews-app] Status bubble should not display certain infrastructure status messages
1338         https://bugs.webkit.org/show_bug.cgi?id=196550
1339
1340         Reviewed by Lucas Forschler.
1341
1342         Do not display the steps which are un-needed for end-user. This information is still avaiable
1343         if the user click on the bubble and look at the Buildbot build.
1344         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1345         (StatusBubble._steps_messages):
1346         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1347
1348 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1349
1350         [ews-build] Use https for sending data to ews-app
1351         https://bugs.webkit.org/show_bug.cgi?id=196492
1352
1353         Reviewed by Lucas Forschler.
1354
1355         * BuildSlaveSupport/ews-build/events.py:
1356
1357 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1358
1359         Remove support for -apple-trailing-word
1360         https://bugs.webkit.org/show_bug.cgi?id=196525
1361
1362         Reviewed by Zalan Bujtas.
1363
1364         This CSS property is nonstandard and not used.
1365
1366         * Scripts/webkitperl/FeatureList.pm:
1367         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1368
1369 2019-04-03  Youenn Fablet  <youenn@apple.com>
1370
1371         Add a test for DOMCache on multiple browsing in case of private browsing
1372         https://bugs.webkit.org/show_bug.cgi?id=196524
1373
1374         Reviewed by Alex Christensen.
1375
1376         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1377         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1378
1379 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1380
1381         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1382         https://bugs.webkit.org/show_bug.cgi?id=196540
1383
1384         Reviewed by Aakash Jain.
1385
1386         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1387
1388 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1389
1390         Add plumbing for a compatibility mode preference in WebKit
1391         https://bugs.webkit.org/show_bug.cgi?id=196005
1392
1393         Reviewed by Tim Horton.
1394
1395         Add new API tests.
1396
1397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1398         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1399
1400 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1401
1402         [WPE][GTK] Update libsrtp dependency package for Debian
1403         https://bugs.webkit.org/show_bug.cgi?id=196528
1404
1405         Reviewed by Frédéric Wang.
1406
1407         * gtk/install-dependencies:
1408         * wpe/install-dependencies:
1409
1410 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1411
1412         [WK2] Add support for Window's beforeprint / afterprint events
1413         https://bugs.webkit.org/show_bug.cgi?id=196478
1414         <rdar://problem/49535124>
1415
1416         Unreviewed build fix for MSVC.
1417
1418         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1419
1420         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1421
1422         * WebKitTestRunner/TestController.cpp:
1423         (WTR::printFrame): Use int and float literals.
1424
1425 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1426
1427         [ews-build] Reassign bots to queues
1428
1429         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1430
1431 2019-04-02  Chris Dumez  <cdumez@apple.com>
1432
1433         [WK2] Add support for Window's beforeprint / afterprint events
1434         https://bugs.webkit.org/show_bug.cgi?id=196478
1435
1436         Reviewed by Alex Christensen.
1437
1438         Add minimal implementation for printFrame in WebKitTestRunner.
1439
1440         * WebKitTestRunner/TestController.cpp:
1441         (WTR::printFrame):
1442         (WTR::TestController::createOtherPage):
1443         (WTR::TestController::createWebViewWithOptions):
1444
1445 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1446
1447         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1448         https://bugs.webkit.org/show_bug.cgi?id=196491
1449
1450         Reviewed by Lucas Forschler.
1451
1452         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1453
1454 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1455
1456         [ews-build] Configure buildbot try credentials in environment variables
1457         https://bugs.webkit.org/show_bug.cgi?id=196501
1458
1459         Reviewed by Lucas Forschler.
1460
1461         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1462         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1463         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1464
1465 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1466
1467         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1468         https://bugs.webkit.org/show_bug.cgi?id=196496
1469         <rdar://problem/49521634>
1470
1471         Reviewed by Chris Dumez.
1472
1473         Add new API tests (see WebKit ChangeLog for more detail).
1474
1475         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1476         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1477         (TEST):
1478
1479 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1480
1481         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1482         <https://webkit.org/b/196499>
1483
1484         Reviewed by Alexey Proskuryakov.
1485
1486         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1487         ENABLE_ADDRESS_SANITIZER.
1488
1489 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1490
1491         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1492         https://bugs.webkit.org/show_bug.cgi?id=182757
1493
1494         Reviewed by Don Olmstead.
1495
1496         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1497         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1498
1499 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1500
1501         run-api-tests: Upload test results
1502         https://bugs.webkit.org/show_bug.cgi?id=196323
1503         <rdar://problem/49356714>
1504
1505         Reviewed by Lucas Forschler.
1506
1507         * Scripts/webkitpy/api_tests/manager.py:
1508         (Manager):
1509         (Manager.run): Upload results to a results database.
1510         * Scripts/webkitpy/api_tests/run_api_tests.py:
1511         (parse_args): Add upload arguments.
1512         * Scripts/webkitpy/port/base.py:
1513         (Port):
1514         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1515         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1516         with commits from any other associated repositories.
1517         * Scripts/webkitpy/port/device.py:
1518         (Device):
1519         (Device.build_version): Access build_versoin of underlying platform device.
1520         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1521         (IOSSimulatorTest):
1522         (IOSSimulatorTest.test_configuration_for_upload):
1523         * Scripts/webkitpy/port/device_port.py:
1524         (DevicePort):
1525         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1526         the same as the machine uploading results.
1527         * Scripts/webkitpy/port/mac.py:
1528         (MacPort):
1529         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1530         * Scripts/webkitpy/port/mac_unittest.py:
1531         (MacTest):
1532         (MacTest.test_configuration_for_upload):
1533         * Scripts/webkitpy/xcode/simulated_device.py:
1534         (SimulatedDeviceManager._create_device_with_runtime):
1535         (SimulatedDevice.__init__): Create simulated device with a build_version.
1536         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1537         (test_existing_simulator):
1538
1539 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1540
1541         Remove extra newline characters (Follow-up fix to r243707)
1542
1543         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1544
1545 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1546
1547         [ews-app] Use API_KEY to accept results data
1548         https://bugs.webkit.org/show_bug.cgi?id=196461
1549
1550         Reviewed by Dewei Zhu.
1551
1552         * BuildSlaveSupport/ews-app/ews/views/results.py:
1553         (Results.post): Validate EWS_API_KEY before accepting any data.
1554         * BuildSlaveSupport/ews-build/events.py:
1555         (Events.sendData): Send EWS_API_KEY if available along with event data.
1556
1557 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1558
1559         Unable to copy and paste a PDF from Notes into Mail compose body
1560         https://bugs.webkit.org/show_bug.cgi?id=196442
1561         <rdar://problem/48573098>
1562
1563         Reviewed by Tim Horton.
1564
1565         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1566         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1567         to be specified on the item providers.
1568
1569         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1570         (TestWebKitAPI::mapItemForTesting):
1571         (TestWebKitAPI::contactItemForTesting):
1572
1573 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1574
1575         Make UIWKDocumentContext rects per-character instead of per-word
1576         https://bugs.webkit.org/show_bug.cgi?id=196459
1577
1578         Reviewed by Wenson Hsieh.
1579
1580         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1581         (TEST):
1582         Adjust test results due to switching to per-character rects.
1583
1584 2019-04-01  Chris Dumez  <cdumez@apple.com>
1585
1586         UIProcess crash when a prewarmed process is terminated
1587         https://bugs.webkit.org/show_bug.cgi?id=196451
1588         <rdar://problem/49245471>
1589
1590         Reviewed by Geoffrey Garen.
1591
1592         Add API test coverage.
1593
1594         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1595         (TEST):
1596
1597 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1598
1599         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1600         https://bugs.webkit.org/show_bug.cgi?id=196449
1601
1602         Reviewed by Lucas Forschler.
1603
1604         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1605         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1606         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1607         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1608
1609 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1610
1611         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1612         https://bugs.webkit.org/show_bug.cgi?id=196444
1613
1614         Reviewed by Lucas Forschler.
1615
1616         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1617
1618 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1619
1620         Add SPI to canonicalize NSURLs with WTF::URL
1621         https://bugs.webkit.org/show_bug.cgi?id=196415
1622         <rdar://problem/44980271>
1623
1624         Reviewed by Darin Adler.
1625
1626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1627         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1628         (TestWebKitAPI::TEST):
1629
1630 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1631
1632         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1633         https://bugs.webkit.org/show_bug.cgi?id=196441
1634
1635         Reviewed by Carlos Garcia Campos.
1636
1637         Don't cache the wpe_view_backend object that might not exist yet at the
1638         time of EventSenderProxy constructor invocation, but instead retrieve
1639         that object whenever it's required for event dispatching. This should
1640         avoid crashes in this constructor now that it's invoked before any
1641         PlatformWindow has been set up (as changed in r243496).
1642
1643         * WebKitTestRunner/EventSenderProxy.h:
1644         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1645         (WTR::viewBackend):
1646         (WTR::EventSenderProxy::EventSenderProxy):
1647         (WTR::EventSenderProxy::mouseDown):
1648         (WTR::EventSenderProxy::mouseUp):
1649         (WTR::EventSenderProxy::mouseMoveTo):
1650         (WTR::EventSenderProxy::mouseScrollBy):
1651         (WTR::EventSenderProxy::keyDown):
1652         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1653
1654 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1655
1656         [Win][WebKit] MiniBrowser should support high DPI display
1657         https://bugs.webkit.org/show_bug.cgi?id=196391
1658
1659         Reviewed by Alex Christensen.
1660
1661         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1662         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1663         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1664         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1665
1666 2019-03-31  Sam Weinig  <weinig@apple.com>
1667
1668         Remove more i386 specific configurations
1669         https://bugs.webkit.org/show_bug.cgi?id=196430
1670
1671         Reviewed by Alexey Proskuryakov.
1672
1673         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1674         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1675
1676 2019-03-31  Andy Estes  <aestes@apple.com>
1677
1678         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1679         https://bugs.webkit.org/show_bug.cgi?id=196433
1680         <rdar://problem/49293305>
1681
1682         Reviewed by Tim Horton.
1683
1684         Enhanced API test coverage to include all navigation response policy decisions in both
1685         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1686
1687         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1688         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1689         (TestWebKitAPI::TEST):
1690         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1691         (readFile):
1692         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1693         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1694         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1695         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1696         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1697         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1698         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1699         (-[QuickLookDelegate _downloadDidStart:]):
1700         (-[QuickLookDelegate _download:didReceiveResponse:]):
1701         (-[QuickLookDelegate _download:didReceiveData:]):
1702         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1703         (-[QuickLookDelegate _downloadDidFinish:]):
1704         (-[QuickLookDelegate _download:didFailWithError:]):
1705         (-[QuickLookDelegate _downloadDidCancel:]):
1706         (-[QuickLookDelegate verifyDownload]):
1707         (runTest):
1708         (runTestDecideBeforeLoading):
1709         (runTestDecideAfterLoading):
1710         (TEST):
1711         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1712         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1713         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1714         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1715         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1716         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1717         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1718         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1719         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1720         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1721         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1722         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1723         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1724         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1725
1726 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1727
1728         [CMake] add testdfg as target with build-jsc
1729         https://bugs.webkit.org/show_bug.cgi?id=196393
1730
1731         Reviewed by Saam Barati.
1732
1733         Added testdfg as one of the targets to build when
1734         using CMake.
1735
1736         * Scripts/build-jsc:
1737
1738 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1739
1740         Delete WebMetal implementation in favor of WebGPU
1741         https://bugs.webkit.org/show_bug.cgi?id=195418
1742
1743         Reviewed by Dean Jackson.
1744
1745         * DumpRenderTree/mac/DumpRenderTree.mm:
1746         (enableExperimentalFeatures):
1747         (resetWebPreferencesToConsistentValues):
1748         * Scripts/webkitperl/FeatureList.pm:
1749         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1751         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1752         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1753         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1754         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1755         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1756         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1757         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1758         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1759         (WTR::InjectedBundle::beginTesting):
1760         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1761         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1762         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1763
1764 2019-03-29  Chris Dumez  <cdumez@apple.com>
1765
1766         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1767         https://bugs.webkit.org/show_bug.cgi?id=196405
1768         <rdar://problem/49428130>
1769
1770         Reviewed by Wenson Hsieh.
1771
1772         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1773         the popover presentation methods to be no-ops. Use this in the new test added in
1774         r243523 so that we do not swizzle those methods for all tests. This is needed because
1775         those WatchOS tests rely on the popover getting presented and interactive.
1776
1777         * WebKitTestRunner/TestController.cpp:
1778         (WTR::updateTestOptionsFromTestHeader):
1779         * WebKitTestRunner/TestController.h:
1780         * WebKitTestRunner/TestOptions.h:
1781         (WTR::TestOptions::hasSameInitializationOptions const):
1782         * WebKitTestRunner/ios/TestControllerIOS.mm:
1783         (WTR::TestController::platformInitialize):
1784         (WTR::TestController::platformResetStateToConsistentValues):
1785
1786 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1787
1788         [Curl] Add Server Trust Evaluation Support.
1789         https://bugs.webkit.org/show_bug.cgi?id=191646
1790
1791         Reviewed by Fujii Hironori.
1792
1793         Implemented MiniBrowser UI for asking if user trusts the server.
1794
1795         * MiniBrowser/win/Common.cpp:
1796         (askServerTrustEvaluation):
1797         (replaceString):
1798         * MiniBrowser/win/Common.h:
1799         * MiniBrowser/win/MiniBrowserLib.rc:
1800         * MiniBrowser/win/MiniBrowserLibResource.h:
1801         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1802         (createPEMString):
1803         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1804         (WebKitBrowserWindow::canTrustServerCertificate):
1805         * MiniBrowser/win/WebKitBrowserWindow.h:
1806
1807 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1808
1809         Implement ResizeObserver.
1810         https://bugs.webkit.org/show_bug.cgi?id=157743
1811
1812         Reviewed by Simon Fraser.
1813
1814         Support resizeObserverEnabled webPreferences.
1815
1816         * DumpRenderTree/TestOptions.cpp:
1817         (TestOptions::TestOptions):
1818         * DumpRenderTree/TestOptions.h:
1819         * DumpRenderTree/mac/DumpRenderTree.mm:
1820         (setWebPreferencesForTestOptions):
1821         * DumpRenderTree/win/DumpRenderTree.cpp:
1822         (enableExperimentalFeatures):
1823         * Scripts/webkitperl/FeatureList.pm:
1824         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1825
1826 2019-03-28  John Wilander  <wilander@apple.com>
1827
1828         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1829         https://bugs.webkit.org/show_bug.cgi?id=196281
1830         <rdar://problem/48938748>
1831
1832         Reviewed by Alex Christensen.
1833
1834         This patch adds the function isStatisticsHasLocalStorage() to the
1835         TestRunner. With it, the page can query the WebsiteDataStore in the
1836         UI process to make sure that it sees LocalStorage.
1837
1838         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1839         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1840         (WTR::TestRunner::isStatisticsHasLocalStorage):
1841         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1842         * WebKitTestRunner/TestController.cpp:
1843         (WTR::TestController::isStatisticsHasLocalStorage):
1844         * WebKitTestRunner/TestController.h:
1845         * WebKitTestRunner/TestInvocation.cpp:
1846         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1847
1848 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1849
1850         API::Data::createWithoutCopying should do a null check before calling CFRelease
1851         https://bugs.webkit.org/show_bug.cgi?id=196276
1852         <rdar://problem/48059859>
1853
1854         Reviewed by Alex Christensen.
1855
1856         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1857
1858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1859         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1860         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1861         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1862         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1863         (TestWebKitAPI::TEST):
1864
1865 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1866
1867         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1868         https://bugs.webkit.org/show_bug.cgi?id=186276
1869
1870         Reviewed by Carlos Garcia Campos.
1871
1872         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1873         (webViewLoadChanged):
1874         (testWebResourceGetDataError):
1875         (testWebResourceGetDataEmpty):
1876         (beforeAll):
1877         (webViewloadChanged): Deleted.
1878
1879 2019-03-27  Andy Estes  <aestes@apple.com>
1880
1881         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1882         https://bugs.webkit.org/show_bug.cgi?id=196317
1883
1884         Reviewed by Dan Bernstein.
1885
1886         package-root copies built products into a staging directory using ditto(1), which does not
1887         follow symbolic links as it traverses a directory. Now that the files in
1888         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1889         itself, these become broken links when ditto'd into the staging directory.
1890
1891         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1892
1893         * Scripts/package-root:
1894
1895 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1896
1897         [ews-app] Update display text of Submit for ews analysis
1898         https://bugs.webkit.org/show_bug.cgi?id=196309
1899
1900         Reviewed by Dewei Zhu.
1901
1902         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1903
1904 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1905
1906         run-webkit-tests should check for leaks in WebKit processes
1907         <https://webkit.org/b/193772>
1908         <rdar://problem/46526680>
1909
1910         Reviewed by Ryosuke Niwa.
1911
1912         This works by doing the following:
1913         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1914           The list of child processes are returned one per line:
1915           process.name: pid
1916         - Run the "#LIST CHILD PROCESSES" command just before the
1917           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1918           processes on the ServerProcess object.
1919         - When the `--leaks` switch is handled, run check_for_leaks() on
1920           each child process after the main test harness.
1921
1922         * DumpRenderTree/mac/DumpRenderTree.mm:
1923         (handleControlCommand):
1924         - Use strncmp() instead of strcmp().
1925         - Add support for handling "#LIST CHILD PROCESSES" command.
1926
1927         * Scripts/webkitpy/port/base.py:
1928         (Port.check_for_leaks):
1929         * Scripts/webkitpy/port/darwin.py:
1930         (DarwinPort.check_for_leaks):
1931         - Rename redundant 'process_pid' argument to 'process_id'.
1932
1933         * Scripts/webkitpy/port/driver.py:
1934         (Driver.do_post_tests_work):
1935         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1936           longer the only command this sends to WebKitTestRunner.
1937         - If the `--leaks` switch is present, send the
1938           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1939           result using Port.set_webkit_processes().
1940         (Driver._parse_child_processes_output):
1941         - Add helper method to parse list of child process names and
1942           process IDs returned from WebKitTestRunner.
1943
1944         * Scripts/webkitpy/port/ios_device.py:
1945         (IOSDevicePort.check_for_leaks):
1946         - Rename redundant 'process_pid' argument to 'process_id'.
1947
1948         * Scripts/webkitpy/port/leakdetector.py:
1949         (LeakDetector._parse_leaks_output):
1950         - Return early if there is no leaks_output.
1951         (LeakDetector.check_for_leaks):
1952         - Rename redundant 'process_pid' argument to 'process_id'.
1953
1954         * Scripts/webkitpy/port/server_process.py:
1955         (ServerProcess.__init__):
1956         (ServerProcess.child_processes):
1957         (ServerProcess.set_child_processes):
1958         - Add instance variable to Port to store list of child process
1959           names and process IDs returned from WebKitTestRunner.
1960         (ServerProcess._start):
1961         - Clear self._child_processes.
1962         (ServerProcess.stop):
1963         - If self._child_processes is set, call
1964           self._port.check_for_leaks() for each child process.
1965
1966         * Scripts/webkitpy/port/server_process_unittest.py:
1967         (TrivialMockPort.check_for_leaks):
1968         - Rename redundant 'process_pid' argument to 'process_id'.
1969
1970         * Scripts/webkitpy/port/simulator_process.py:
1971         (SimulatorProcess.stop):
1972         - If self._child_processes is set, call
1973           self._port.check_for_leaks() for each child process.
1974
1975         * Scripts/webkitpy/port/watch_device.py:
1976         (WatchDevicePort.check_for_leaks):
1977         - Rename redundant 'process_pid' argument to 'process_id'.
1978
1979         * WebKitTestRunner/TestController.cpp:
1980         (WTR::TestController::dumpResponse):
1981         - Extract method from findAndDumpWorldLeaks() so that it may be
1982           reused by findAndDumpWebKitProcessIdentifiers().
1983         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1984         - Add method to output process name and process ID of both the
1985           WebContent and Networking processes.
1986         (WTR::TestController::findAndDumpWorldLeaks):
1987         - Fix missing newline in output when there were no abandoned
1988           documents.
1989         - Call dumpResponse() for extracted code.
1990         (WTR::TestController::handleControlCommand):
1991         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1992         - Use strncmp() instead of strcmp().
1993         - Call findAndDumpWebKitProcessIdentifiers() when
1994           "#LIST CHILD PROCESSES" command is sent.
1995         * WebKitTestRunner/TestController.h:
1996         (WTR::TestController::dumpResponse):
1997         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1998         - Declare methods.
1999
2000 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2001
2002         Unreviewed. Add GLib API test cases after r243434.
2003
2004         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2005         (testWebViewActiveURI):
2006         (serverCallback):
2007         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2008         (sendRequestCallback):
2009
2010 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2011
2012         Geolocation request not complete when watch request was started in a different web process
2013         https://bugs.webkit.org/show_bug.cgi?id=195996
2014
2015         Reviewed by Alex Christensen.
2016
2017         Add a test case.
2018
2019         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2020         (TestWebKitAPI::runJavaScriptAlert):
2021         (TestWebKitAPI::TEST):
2022
2023 2019-03-26  Keith Rollin  <krollin@apple.com>
2024
2025         Update the way generate-xcfilelists returns strings from functions
2026         https://bugs.webkit.org/show_bug.cgi?id=195975
2027         <rdar://problem/49040807>
2028
2029         Reviewed by Dean Jackson.
2030
2031         There are places where generate-xcfilelists executes assignments with
2032         statements like:
2033
2034             FOO=$(some_function)
2035
2036         where "some_function" return a string by echoing it. E.g.
2037
2038             some_function()
2039             {
2040                 echo "Hello, World"
2041             }
2042
2043         This is a common idiom, but it has a problem if "some_function" needs
2044         to call "exit" in an attempt to halt the entire script right then and
2045         there. Since "some_function" is called inside of $(), it's being
2046         executed in a sub-shell. Calling exit in that sub-shell simply exits
2047         that shell; it doesn't not exit the outer shell in which the main part
2048         of the script is still running. As such, the main script keeps
2049         executing when the intent was for the script to halt.
2050
2051         The solution to this is to use a different idiom for returning
2052         strings. The one we now is to pass in the name of the variable to
2053         receive the string result:
2054
2055             some_function()
2056             {
2057                 variable_name=$1
2058                 eval $variable_name ="Hello, World"
2059             }
2060
2061         The call site now looks like
2062
2063             some_function FOO
2064
2065         Because there's no invocation of a sub-shell, some_function can now
2066         call "exit" if it wants to, and the entire script will exit at that
2067         point.
2068
2069         * Scripts/generate-xcfilelists:
2070
2071 2019-03-26  Chris Dumez  <cdumez@apple.com>
2072
2073         Add basic layout test coverage for File Picker on iOS
2074         https://bugs.webkit.org/show_bug.cgi?id=196265
2075
2076         Reviewed by Wenson Hsieh.
2077
2078         Add layout test infrastructure to test the file picker on iOS.
2079
2080         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2081         (WTR::UIScriptController::dismissFilePicker):
2082         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2083         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2084         (WTR::UIScriptController::dismissFilePicker):
2085         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2086         * WebKitTestRunner/TestController.cpp:
2087         (WTR::TestController::createWebViewWithOptions):
2088         (WTR::updateTestOptionsFromTestHeader):
2089         * WebKitTestRunner/TestOptions.h:
2090         (WTR::TestOptions::hasSameInitializationOptions const):
2091         * WebKitTestRunner/ios/TestControllerIOS.mm:
2092         (overridePresentViewController):
2093         (WTR::TestController::platformInitialize):
2094         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2095         (WTR::UIScriptController::dismissFilePicker):
2096
2097 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2098
2099         Implement async paste method on UIWKInteractionViewProtocol
2100         https://bugs.webkit.org/show_bug.cgi?id=196267
2101         <rdar://problem/49236346>
2102
2103         Reviewed by Tim Horton.
2104
2105         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2106         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2107         are now a part of all iOS 12 internal SDKs.
2108
2109         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2110
2111         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2112         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2113
2114         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2115         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2116         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2117         * TestWebKitAPI/ios/UIKitSPI.h:
2118
2119 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2120
2121         [ews-build] Use PostgreSQL for ews.webkit.org database
2122         https://bugs.webkit.org/show_bug.cgi?id=196270
2123
2124         Reviewed by Lucas Forschler.
2125
2126         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2127
2128 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2129
2130         [ews] Reset simctl states on reboot
2131         https://bugs.webkit.org/show_bug.cgi?id=196260
2132
2133         Rubber-stamped by Aakash Jain.
2134
2135         * EWSTools/start-queue-mac.sh:
2136
2137 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2138
2139         [ews-build] Use PostgreSQL for ews-build database
2140         https://bugs.webkit.org/show_bug.cgi?id=196229
2141
2142         Reviewed by Lucas Forschler.
2143
2144         * BuildSlaveSupport/ews-build/master.cfg:
2145
2146 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2147
2148         [ews-build] Get master_hostname dynamically in master.cfg
2149         https://bugs.webkit.org/show_bug.cgi?id=196255
2150
2151         Reviewed by Lucas Forschler.
2152
2153         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2154         send events data in test mode.
2155
2156 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2157
2158         [ews-app] Set db_constraint to False for Foreign Keys
2159         https://bugs.webkit.org/show_bug.cgi?id=196252
2160
2161         Reviewed by Lucas Forschler.
2162
2163         * BuildSlaveSupport/ews-app/ews/models/build.py:
2164         * BuildSlaveSupport/ews-app/ews/models/step.py:
2165
2166 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2167
2168         [ews-build] is_test_mode_enabled should default to True
2169         https://bugs.webkit.org/show_bug.cgi?id=196248
2170
2171         Reviewed by Lucas Forschler.
2172
2173         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2174
2175 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2176
2177         [ews-app] Add webkitperl to ENABLED_QUEUES
2178         https://bugs.webkit.org/show_bug.cgi?id=196253
2179
2180         Reviewed by Lucas Forschler.
2181
2182         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2183
2184 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2185
2186         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2187         https://bugs.webkit.org/show_bug.cgi?id=196211
2188         rdar://problem/49110552
2189
2190         Reviewed by Tim Horton.
2191
2192         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2193         Make sure that EventSenderProxy always exists when running tests. We used to create
2194         it when resetting before the first test, which is a bit too late.
2195
2196         * WebKitTestRunner/TestController.h:
2197         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2198         (WTR::TestController::platformCreateWebView):
2199         (WTR::TestController::platformCreateOtherPage):
2200         (WTR::TestController::finishCreatingPlatformWebView):
2201         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2202         (WTR::PlatformWebView::PlatformWebView):
2203         Moved some code that made NSWindow use NSEvent during web view creation. We may
2204         need to move more if some other case us found, but this is enough for now.
2205
2206 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2207
2208         Unreviewed. Fix typo in GLib geolocation API after r243285.
2209
2210         gelocation -> geolocation.
2211
2212         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2213         (testGeolocationManagerWatchPosition):
2214
2215 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2216
2217         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2218         https://bugs.webkit.org/show_bug.cgi?id=196213
2219
2220         Reviewed by Geoff Garen.
2221
2222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2223         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2224         (credentialWithIdentityAndKeychainPath):
2225         (-[ChallengeDelegate webView:didFinishNavigation:]):
2226         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2227         (TestWebKitAPI::TEST):
2228
2229 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2230
2231         Expected shouldn't assume its contained types are copyable
2232         https://bugs.webkit.org/show_bug.cgi?id=195986
2233
2234         Reviewed by JF Bastien.
2235
2236         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2237         (TestWebKitAPI::NonCopyable::operator== const):
2238         (TestWebKitAPI::NonCopyable::operator!= const):
2239         (TestWebKitAPI::TEST):
2240
2241 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2242
2243         Remove some now-unnecessary dynamic class lookup
2244         https://bugs.webkit.org/show_bug.cgi?id=196237
2245
2246         Reviewed by Simon Fraser.
2247
2248         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2249         (makeRequest):
2250         (TEST):
2251
2252 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2253
2254         Unreviewed, rolling out r243450.
2255
2256         AppleWin and WinCairo port builds get broken.
2257
2258         Reverted changeset:
2259
2260         "Add test for fix of #196095"
2261         https://bugs.webkit.org/show_bug.cgi?id=196097
2262         https://trac.webkit.org/changeset/243450
2263
2264 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2265
2266         Unreviewed, rolling out r243465.
2267         https://bugs.webkit.org/show_bug.cgi?id=196226
2268
2269         the test doesn't build (Requested by thorton on #webkit).
2270
2271         Reverted changeset:
2272
2273         "Do not terminate the NetworkProcess if a third party
2274         application sends a NSCredential with a SecIdentityRef"
2275         https://bugs.webkit.org/show_bug.cgi?id=196213
2276         https://trac.webkit.org/changeset/243465
2277
2278 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2279
2280         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2281         https://bugs.webkit.org/show_bug.cgi?id=196213
2282
2283         Reviewed by Geoff Garen.
2284
2285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2286         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2287         (credentialWithIdentityAndKeychainPath):
2288         (-[ChallengeDelegate webView:didFinishNavigation:]):
2289         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2290         (TestWebKitAPI::TEST):
2291
2292 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2293
2294         [ews-build] Gracefully handle missing patch_id in events
2295         https://bugs.webkit.org/show_bug.cgi?id=196216
2296
2297         Reviewed by Lucas Forschler.
2298
2299         * BuildSlaveSupport/ews-build/events.py:
2300
2301 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2302
2303         [ews-build] use lz4 compression for improving buildbot performance
2304         https://bugs.webkit.org/show_bug.cgi?id=196155
2305
2306         Reviewed by Lucas Forschler.
2307
2308         * BuildSlaveSupport/ews-build/master.cfg:
2309
2310 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2311
2312         Pull some API testing helper methods out of TestWKWebView
2313         https://bugs.webkit.org/show_bug.cgi?id=196212
2314
2315         Reviewed by Tim Horton.
2316
2317         Refactor some more API testing utility methods, so that they can be used in
2318         tests that do not use TestWKWebView.
2319
2320         * TestWebKitAPI/cocoa/TestWKWebView.h:
2321         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2322         (-[WKWebView loadTestPageNamed:]):
2323         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2324         (-[WKWebView synchronouslyLoadHTMLString:]):
2325         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2326         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2327         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2328         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2329         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2330
2331 2019-03-25  Jer Noble  <jer.noble@apple.com>
2332
2333         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2334         https://bugs.webkit.org/show_bug.cgi?id=196097
2335
2336         Reviewed by Eric Carlson.
2337
2338         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2339
2340         * DumpRenderTree/mac/DumpRenderTree.mm:
2341         (resetWebPreferencesToConsistentValues):
2342         * WebKitTestRunner/TestController.cpp:
2343         (WTR::TestController::resetPreferencesToConsistentValues):
2344
2345 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2346
2347         Pull IPadUserInterfaceSwizzler out into a separate header file
2348         https://bugs.webkit.org/show_bug.cgi?id=196193
2349
2350         Reviewed by Anders Carlsson.
2351
2352         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2353         be used in other API tests.
2354
2355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2356         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2357         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2358         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2359         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2360         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2361         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2362
2363 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2364
2365         Remove NavigatorContentUtils in WebCore/Modules
2366         https://bugs.webkit.org/show_bug.cgi?id=196070
2367
2368         Reviewed by Alex Christensen.
2369
2370         NavigatorContentUtils was to support the custom scheme spec [1].
2371         However, in WebKit side, no port has supported the feature in
2372         WebKit layer after EFL port was removed. So there has been the
2373         only IDL implementation of the NavigatorContentUtils in WebCore.
2374         So we don't need to keep the implementation in WebCore anymore.
2375
2376         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2377
2378         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2379
2380 2019-03-24  Andy Estes  <aestes@apple.com>
2381
2382         [watchOS] Remove unused Proximity Networking code
2383         https://bugs.webkit.org/show_bug.cgi?id=196188
2384
2385         Reviewed by Tim Horton.
2386
2387         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2388         (TEST):
2389
2390 2019-03-23  Keith Miller  <keith_miller@apple.com>
2391
2392         Refactor clz/ctz and fix getLSBSet.
2393         https://bugs.webkit.org/show_bug.cgi?id=196162
2394
2395         Reviewed by Saam Barati.
2396
2397         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2398
2399         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2400         (TestWebKitAPI::TEST):
2401
2402 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2403
2404         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2405         https://bugs.webkit.org/show_bug.cgi?id=196143
2406
2407         Reviewed by Michael Catanzaro.
2408
2409         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2410         directories.
2411
2412         * Scripts/webkitpy/style/checkers/cpp.py:
2413         (check_identifier_name_in_declaration):
2414         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2415         (WebKitStyleTest.test_names):
2416
2417 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2418
2419         [Flatpak] Manifest expanding fails for qt WPE extension
2420         https://bugs.webkit.org/show_bug.cgi?id=196148
2421
2422         Reviewed by Alex Christensen.
2423
2424         * flatpak/flatpakutils.py:
2425         (expand_submodules_recurse): The last recurse manifest expand
2426         iteration might lead to a single module so take it into account
2427         and don't try to recurse further.
2428
2429 2019-03-22  Chris Dumez  <cdumez@apple.com>
2430
2431         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2432         https://bugs.webkit.org/show_bug.cgi?id=195348
2433         <rdar://problem/48622090>
2434
2435         Reviewed by Alex Christensen.
2436
2437         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2438         to NO when test.options().shouldIgnoreMetaViewport is false.
2439
2440         * WebKitTestRunner/ios/TestControllerIOS.mm:
2441         (WTR::TestController::platformConfigureViewForTest):
2442
2443 2019-03-22  Chris Dumez  <cdumez@apple.com>
2444
2445         Prewarmed processes should be usable with any website data store
2446         https://bugs.webkit.org/show_bug.cgi?id=196104
2447
2448         Reviewed by Alex Christensen.
2449
2450         Add API test coverage.
2451
2452         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2453         (runInitialWarmedProcessUsedTest):
2454         (TEST):
2455
2456 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2457
2458         Back out local changes to Alex's Subversion working directory
2459
2460         They were accidentally committed.
2461
2462         * Scripts/webkitpy/common/system/abstractexecutive.py:
2463         (AbstractExecutive.wait_newest):
2464         * Scripts/webkitpy/common/system/executive.py:
2465         (Executive.running_pids):
2466         * Scripts/webkitpy/common/system/executive_mock.py:
2467         (MockExecutive.running_pids):
2468         * Scripts/webkitpy/common/system/executive_unittest.py:
2469         (ExecutiveTest.serial_test_running_pids):
2470         * Scripts/webkitpy/port/darwin.py:
2471         (DarwinPort.check_for_leaks):
2472         * Scripts/webkitpy/port/leakdetector.py:
2473         (LeakDetector.check_for_leaks):
2474         - This was the hack attached to Bug 193772.
2475
2476         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2477         (+[WebKitTestRunnerEvent mouseLocation]):
2478         - This works around a crash on an internal build.
2479
2480 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2481
2482         Fix the build after r243354
2483         https://bugs.webkit.org/show_bug.cgi?id=196138
2484         <rdar://problem/49145951>
2485
2486         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2487         (TEST):
2488         * TestWebKitAPI/ios/UIKitSPI.h:
2489
2490 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2491
2492         Adopt UIWKDocumentContext
2493         https://bugs.webkit.org/show_bug.cgi?id=196040
2494         <rdar://problem/48642440>
2495
2496         Reviewed by Ryosuke Niwa.
2497
2498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2499         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2500         (makeRequest):
2501         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2502         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2503         (applyStyle):
2504         (TEST):
2505         Add tests for UIWKDocumentContext.
2506
2507         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2508         (TEST):
2509         (recursiveFindWKContentView): Deleted.
2510         * TestWebKitAPI/cocoa/TestWKWebView.h:
2511         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2512         (recursiveFindWKContentView):
2513         (-[TestWKWebView wkContentView]):
2514         * TestWebKitAPI/ios/UIKitSPI.h:
2515         Share the WKContentView finding code between tests.
2516
2517 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2518
2519         [iOS WK2] Turn on async overflow scrolling by default
2520         https://bugs.webkit.org/show_bug.cgi?id=196011
2521         rdar://problem/48453859
2522
2523         Reviewed by Antti Koivisto.
2524         
2525         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2526         since so many basic layout tests have different results when compositing is triggered for
2527         overflow.
2528         
2529         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2530
2531         * WebKitTestRunner/TestController.cpp:
2532         (WTR::TestController::resetPreferencesToConsistentValues):
2533
2534 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2535
2536         [ews-build] Retry API test in case of failures
2537         https://bugs.webkit.org/show_bug.cgi?id=196004
2538
2539         Reviewed by Lucas Forschler.
2540
2541         * BuildSlaveSupport/ews-build/steps.py:
2542         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2543         (CompileWebKitToT.doStepIf): Ditto.
2544         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2545         (ReRunAPITests): Re-run API tests.
2546         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2547         (RunAPITestsWithoutPatch): Run API tests without patch.
2548         (RunAPITestsWithoutPatch.doStepIf):
2549         (RunAPITestsWithoutPatch.hideStepIf):
2550         (RunAPITestsWithoutPatch.evaluateCommand):
2551         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2552         (AnalyzeAPITestsResults.start):
2553         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2554         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2555         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2556         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2557
2558 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2559
2560         [ews-build] Update queues configurations
2561         https://bugs.webkit.org/show_bug.cgi?id=196074
2562
2563         Reviewed by Dewei Zhu.
2564
2565         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2566         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2567
2568 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2569
2570         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2571         https://bugs.webkit.org/show_bug.cgi?id=195680
2572         <rdar://problem/48903534>
2573
2574         Unreviewed infrastructure fix.
2575
2576         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2577         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2578
2579 2019-03-21  Andy Estes  <aestes@apple.com>
2580
2581         [iOS] Apple Pay should be available in documents with no user agent scripts
2582         https://bugs.webkit.org/show_bug.cgi?id=196061
2583         <rdar://problem/48649391>
2584
2585         Reviewed by Brady Eidson.
2586
2587         Added API tests and related infrastructure.
2588
2589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2590         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2591         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2592         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2593         (TestWebKitAPI::TEST):
2594         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2595         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2596         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2597         * TestWebKitAPI/cocoa/TestProtocol.mm:
2598         (-[TestProtocol startLoading]):
2599         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2600         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2601         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2602         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2603
2604 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2605
2606         REGRESSSION (r243297): webkitpy tests broken
2607         https://bugs.webkit.org/show_bug.cgi?id=196108
2608
2609         Reviewed by Aakash Jain.
2610
2611         r243297 updated contributors.json, which broke a few unit tests.
2612
2613         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2614         (IRCCommandTest.test_whois):
2615         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2616
2617 2019-03-21  Chris Dumez  <cdumez@apple.com>
2618
2619         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2620         https://bugs.webkit.org/show_bug.cgi?id=196041
2621         <rdar://problem/49083230>
2622
2623         Reviewed by Alex Christensen.
2624
2625         Add API test coverage.
2626
2627         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2628         (TEST):
2629
2630 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2631
2632         Add SPI to inform applications of WKContentRuleList actions
2633         https://bugs.webkit.org/show_bug.cgi?id=195965
2634         <rdar://problem/42664365>
2635
2636         Reviewed by Geoff Garen.
2637
2638         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2639         (TestWebKitAPI::allActionsForResourceLoad):
2640         (TestWebKitAPI::testRequest):
2641         (TestWebKitAPI::TEST_F):
2642         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2643         (Notification::description):
2644         (Notification::operator== const):
2645         (toVector):
2646         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2647         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2648         (makeContentRuleList):
2649         (TEST):
2650         (makeWarnContentRuleList): Deleted.
2651
2652 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2653
2654         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2655         https://bugs.webkit.org/show_bug.cgi?id=196088
2656
2657         Reviewed by Brian Burg.
2658
2659         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2660         Support checks when only one platform is specified. Also deprecate macosx() and
2661         force the use of macos() instead.
2662
2663         * Scripts/webkitpy/style/checkers/cpp.py:
2664         (check_min_versions_of_wk_api_available):
2665         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2666         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2667
2668 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2669
2670         Update status inactive committers' status to 'contributor'.
2671
2672         * Scripts/webkitpy/common/config/contributors.json:
2673
2674 2019-03-21  Xan Lopez  <xan@igalia.com>
2675
2676         [JSC][x86] Drop support for x87 floating point
2677         https://bugs.webkit.org/show_bug.cgi?id=194853
2678
2679         Reviewed by Don Olmstead.
2680
2681         Force SSE2 on x86/32bit builds.
2682
2683         * Scripts/webkitdirs.pm:
2684         (generateBuildSystemFromCMakeProject):
2685
2686 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2687
2688         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2689         https://bugs.webkit.org/show_bug.cgi?id=196073
2690
2691         Reviewed by Michael Catanzaro.
2692
2693         Add test cases to check functions and constructors with no arguments but receiving user data.
2694
2695         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2696         (checkUserData):
2697         (testJSCFunction):
2698         (fooCreateWithUserData):
2699         (testJSCClass):
2700
2701 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2702
2703         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2704
2705         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2706
2707         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2708
2709 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2710
2711         [GTK][WPE] Add API to provide geolocation information
2712         https://bugs.webkit.org/show_bug.cgi?id=195940
2713
2714         Reviewed by Michael Catanzaro.
2715
2716         Add a new test to check the new API.
2717
2718         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2719         (testGeolocationManagerCurrentPosition):
2720         (testGeolocationManagerWatchPosition):
2721         (beforeAll):
2722         (afterAll):
2723         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2724         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2725         (beforeAll): Ditto.
2726         * TestWebKitAPI/glib/CMakeLists.txt:
2727
2728 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2729
2730         [GLib] Returning G_TYPE_OBJECT from a method does not work
2731         https://bugs.webkit.org/show_bug.cgi?id=195574
2732
2733         Reviewed by Michael Catanzaro.
2734
2735         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2736
2737         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2738         (getGFile):
2739         (getParent):
2740         (createGString):
2741         (getGString):
2742         (getGStringCopyWillRaise):
2743         (getGStringCopy):
2744         (getGStringStr):
2745         (getGStringLen):
2746         (freeGString):
2747         (testJSCClass):
2748
2749 2019-03-20  Saam Barati  <sbarati@apple.com>
2750
2751         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2752         https://bugs.webkit.org/show_bug.cgi?id=195721
2753
2754         Reviewed by Filip Pizlo.
2755
2756         * Scripts/run-javascriptcore-tests:
2757
2758 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2759
2760         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2761         https://bugs.webkit.org/show_bug.cgi?id=196049
2762
2763         Reviewed by Tim Horton.
2764
2765         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2766         overflow scrolling in general, so rename it.
2767
2768         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2769
2770 2019-03-20  Daniel Bates  <dabates@apple.com>
2771
2772         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2773         https://bugs.webkit.org/show_bug.cgi?id=196031
2774         <rdar://problem/49078172>
2775
2776         Reviewed by Tim Horton.
2777
2778         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2779         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2780         same code path used when the Done button is pressed to dismiss the <select> picker.
2781
2782         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2783         (TestWebKitAPI::TEST):
2784
2785 2019-03-20  Chris Dumez  <cdumez@apple.com>
2786
2787         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2788         https://bugs.webkit.org/show_bug.cgi?id=196029
2789         <rdar://problem/48954651>
2790
2791         Reviewed by Tim Horton.
2792
2793         Add API test coverage.
2794
2795         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2796
2797 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2798
2799         [ews-build] Improve failure summary string for ApplyPatch step
2800         https://bugs.webkit.org/show_bug.cgi?id=195995
2801
2802         Reviewed by Alexey Proskuryakov.
2803
2804         * BuildSlaveSupport/ews-build/steps.py:
2805         (ApplyPatch.getResultSummary): Override getResultSummary.
2806
2807 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2808
2809         AX: Implement support for new meter ARIA role
2810         https://bugs.webkit.org/show_bug.cgi?id=195966
2811
2812         Reviewed by Chris Fleizach.
2813
2814         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2815         to AXLevelIndicator.
2816
2817         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2818
2819 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2820
2821         [WebAuthN] Implement FIDO AppID extension
2822         https://bugs.webkit.org/show_bug.cgi?id=143491
2823         <rdar://problem/48298273>
2824
2825         Reviewed by Brent Fulgham.
2826
2827         Add a test that covers the new flag of convertToU2fSignCommand.
2828
2829         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2830         (TestWebKitAPI::TEST):
2831         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2832         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2833         (TestWebKitAPI::TEST):
2834
2835 2019-03-19  Keith Rollin  <krollin@apple.com>
2836
2837         Add support for more platforms to generate-xcfilelists
2838         https://bugs.webkit.org/show_bug.cgi?id=195977
2839
2840         Reviewed by Alexey Proskuryakov.
2841
2842         generate-xcfilelists incorrectly complains when involved with building
2843         WebKit for iphonesimulator:
2844
2845             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2846             …
2847             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2848
2849         Address this by teaching generate-xcfilelists about more platforms.
2850
2851         * Scripts/generate-xcfilelists:
2852
2853 2019-03-19  John Wilander  <wilander@apple.com>
2854
2855         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2856         https://bugs.webkit.org/show_bug.cgi?id=195923
2857         <rdar://problem/49001272>
2858
2859         Reviewed by Alex Christensen.
2860
2861         This patch does the following to the TestRunner:
2862         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2863         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2864         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2865
2866         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2867         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2868         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2869         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2870         * WebKitTestRunner/TestController.cpp:
2871         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2872         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2873         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2874         * WebKitTestRunner/TestController.h:
2875         * WebKitTestRunner/TestInvocation.cpp:
2876         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2877
2878 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2879
2880         [CMake] Support more clang and gcc sanitizers
2881         https://bugs.webkit.org/show_bug.cgi?id=195956
2882
2883         Reviewed by Michael Catanzaro.
2884
2885         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2886
2887 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2888
2889         [ews-build] Improve summary for PrintConfiguration step
2890         https://bugs.webkit.org/show_bug.cgi?id=195945
2891
2892         Reviewed by Lucas Forschler.
2893
2894         * BuildSlaveSupport/ews-build/steps.py:
2895         (PrintConfiguration.getResultSummary): Override getResultSummary.
2896
2897 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2898
2899         [ews-build] Improve summary for CheckOutSource step
2900         https://bugs.webkit.org/show_bug.cgi?id=195963
2901
2902         Reviewed by Lucas Forschler.
2903
2904         * BuildSlaveSupport/ews-build/steps.py:
2905         (CheckOutSource.getResultSummary):
2906
2907 2019-03-19  Daniel Bates  <dabates@apple.com>
2908
2909         [iOS] Focus not preserved when switching between tabs
2910         https://bugs.webkit.org/show_bug.cgi?id=195820
2911         <rdar://problem/43614450>
2912
2913         Reviewed by Brent Fulgham.
2914
2915         Add tests to ensure that we restore focus when resigning and becoming first responder.
2916
2917         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2918         (TestWebKitAPI::TEST):
2919
2920 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2921
2922         Make WTFLogChannelState and WTFLogLevel enum classes
2923         https://bugs.webkit.org/show_bug.cgi?id=195904
2924
2925         Reviewed by Eric Carlson.
2926
2927         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2928         (TestWebKitAPI::TEST_F):
2929
2930 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2931
2932         [GStreamer][EME] Backported mssdemux protection data crash fix
2933         https://bugs.webkit.org/show_bug.cgi?id=195918
2934
2935         Reviewed by Philippe Normand.
2936
2937         * gstreamer/jhbuild.modules:
2938         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2939
2940 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2941
2942         Unreviewed, rolling out r243132.
2943
2944         Broke GTK build
2945
2946         Reverted changeset:
2947
2948         "Make WTFLogChannelState and WTFLogLevel enum classes"
2949         https://bugs.webkit.org/show_bug.cgi?id=195904
2950         https://trac.webkit.org/changeset/243132
2951
2952 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2953
2954         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2955
2956         * Scripts/webkitdirs.pm:
2957         (builtDylibPathForName): Adjust the shared library name that's changed
2958         with the API version bump in r243073.
2959
2960 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2961
2962         Make WTFLogChannelState and WTFLogLevel enum classes
2963         https://bugs.webkit.org/show_bug.cgi?id=195904
2964
2965         Reviewed by Eric Carlson.
2966
2967         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2968         (TestWebKitAPI::TEST_F):
2969
2970 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2971
2972         Disable flaky test added in r2431100
2973         https://webkit.org/b/195785
2974
2975         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2976         (TestWebKitAPI::TEST):
2977         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2978
2979 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2980
2981         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2982         https://bugs.webkit.org/show_bug.cgi?id=195916
2983
2984         Reviewed by Tim Horton.
2985
2986         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2987         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2988
2989 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2990
2991         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2992
2993         * Scripts/webkitpy/common/config/contributors.json:
2994
2995 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2996
2997         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2998         https://bugs.webkit.org/show_bug.cgi?id=195785
2999
3000         Reviewed by Geoffrey Garen.
3001
3002         * TestWebKitAPI/TCPServer.cpp: Added.
3003         (TestWebKitAPI::TCPServer::TCPServer):
3004         (TestWebKitAPI::TCPServer::~TCPServer):
3005         (TestWebKitAPI::TCPServer::socketBindListen):
3006         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3007         * TestWebKitAPI/TCPServer.h: Added.
3008         (TestWebKitAPI::TCPServer::port const):
3009         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3010         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3011         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3012         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3013         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3014         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3015         (TestWebKitAPI::respondSlowly):
3016         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3017         (TestWebKitAPI::downloadAtRate):
3018         (TestWebKitAPI::TEST):
3019
3020 2019-03-18  Saam Barati  <sbarati@apple.com>
3021
3022         Add a plan file for JetStream 2
3023         https://bugs.webkit.org/show_bug.cgi?id=190734
3024
3025         Reviewed by Mark Lam.
3026
3027         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3028
3029 2019-03-18  Chris Dumez  <cdumez@apple.com>
3030
3031         Delay WebProcess launch until a load is triggered in a Web view
3032         https://bugs.webkit.org/show_bug.cgi?id=195758
3033         <rdar://problem/48126013>
3034
3035         Reviewed by Geoff Garen.
3036
3037         Add API test coverage. Also update some existing API tests to not expect
3038         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3039
3040         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3041         (TestWebKitAPI::TEST):
3042         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3043         (TestWebKitAPI::TEST):
3044         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3045         (TEST):
3046         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3047         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3048         (TEST):
3049         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3050         (TEST):
3051         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3052
3053 2019-03-18  Xan Lopez  <xan@igalia.com>
3054
3055         [CMake] Prevent potential warning when determining $architecture
3056         https://bugs.webkit.org/show_bug.cgi?id=195891
3057
3058         Reviewed by Michael Catanzaro.
3059
3060         It's possible for generateBuildSystemForCMakeProject to be called
3061         before determineArchitecture() is ever called. This will make the
3062         first eq check with $architecture to be bogus (and print a
3063         warning). Change that to an eq check with architecture(), which
3064         implicitly calls determineArchitecture() if needed, and change all
3065         the other similar cases in the method in the same way to prevent
3066         future bugs like this one.
3067
3068         * Scripts/webkitdirs.pm:
3069         (generateBuildSystemFromCMakeProject):
3070
3071 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3072
3073         [WPE] Tarballs generated with “make dist” cannot build documentation
3074         https://bugs.webkit.org/show_bug.cgi?id=195885
3075
3076         Reviewed by Carlos Garcia Campos.
3077
3078         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3079
3080 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3081
3082         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3083         https://bugs.webkit.org/show_bug.cgi?id=195883
3084
3085         Reviewed by Carlos Garcia Campos.
3086
3087         * gtkdoc/gtkdoc.py:
3088         (GTKDoc._run_command): When commands fail to run, include the full command line for
3089         the program invocation and the output it has generated on the standard error stream.
3090
3091 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3092
3093         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3094         https://bugs.webkit.org/show_bug.cgi?id=195786
3095
3096         Reviewed by Philippe Normand.
3097
3098         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3099         * wpe/jhbuild.modules: Ditto.
3100
3101 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3102
3103         [ews-build] Don't run clean builds on EWS builders
3104         https://bugs.webkit.org/show_bug.cgi?id=195851
3105
3106         Reviewed by Geoffrey Garen.
3107
3108         * BuildSlaveSupport/ews-build/factories.py:
3109
3110 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3111
3112         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3113         https://bugs.webkit.org/show_bug.cgi?id=195849
3114
3115         Reviewed by Chris Dumez.
3116
3117         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3118
3119         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3120         (runWebsiteDataStoreCustomPaths):
3121
3122 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3123
3124         webkitpy: Upload test results
3125         https://bugs.webkit.org/show_bug.cgi?id=195755
3126         <rdar://problem/48896182>
3127
3128         Reviewed by Aakash Jain.
3129
3130         Establish a new format for uploading results that is not tied to layout tests, apply
3131         that format to webkitpy tests.
3132
3133         * Scripts/webkitpy/common/checkout/scm/git.py:
3134         (Git.native_branch): Return what branch the current checkout is on.
3135         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3136         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3137         * Scripts/webkitpy/common/checkout/scm/svn.py:
3138         (SVN.native_branch): Ditto.
3139         * Scripts/webkitpy/common/system/platforminfo.py:
3140         (PlatformInfo.build_version): Return a build version for Mac.
3141         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3142         (MockPlatformInfo.__init__):
3143         (MockPlatformInfo.build_version):
3144         * Scripts/webkitpy/results: Added.
3145         * Scripts/webkitpy/results/__init__.py: Added.
3146         * Scripts/webkitpy/results/options.py: Added.
3147         (upload_options): OptParse list for upload options.
3148         * Scripts/webkitpy/results/upload.py: Added.
3149         (Upload): Class which enforces the upload format expected by the results server.
3150         (Upload.Expectations):
3151         (Upload.create_configuration):
3152         (Upload.create_commit):
3153         (Upload.create_details):
3154         (Upload.create_run_stats):
3155         (Upload.create_test_result):
3156         (Upload.__init__):
3157         (Upload.Encoder): Encode Upload object as json.
3158         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3159         * Scripts/webkitpy/results/upload_unittest.py: Added.
3160         * Scripts/webkitpy/test/main.py:
3161         (Tester._parse_args): Add upload arguments.
3162         (Tester._run_tests): Allow results to be uploaded.
3163         * Scripts/webkitpy/test/runner.py:
3164         (Runner.__init__): Record which tests were run, rather than just counting them.
3165         (Runner.handle):
3166         * Scripts/webkitpy/test/runner_unittest.py:
3167         (RunnerTest.test_run):
3168         * Scripts/webkitpy/thirdparty/__init__.py:
3169         (AutoinstallImportHook.find_module): Add requests auto-install.
3170         (AutoinstallImportHook._install_requests):
3171         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3172         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3173
3174 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3175
3176         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3177         https://bugs.webkit.org/show_bug.cgi?id=195810
3178
3179         Reviewed by Tim Horton.
3180
3181         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3182         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3183         ending certain layout tests.
3184
3185         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3186         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3187         (-[TestRunnerWKWebView dealloc]):
3188         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3189
3190         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3191         helper method when destroying the web view, and when resetting state between tests.
3192
3193         * WebKitTestRunner/ios/TestControllerIOS.mm:
3194         (WTR::TestController::platformResetStateToConsistentValues):
3195
3196         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3197
3198 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3199
3200         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3201         https://bugs.webkit.org/show_bug.cgi?id=190350
3202         <rdar://problem/45089503>
3203
3204         Reviewed by Geoffrey Garen.
3205
3206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3207         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3208         (TEST):
3209         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3210         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3211         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3212         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3213         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3214         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3215         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3216         (runTest):
3217         (createDirectories):
3218         (TEST):
3219         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3220         (TEST):
3221         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3222         (TEST):
3223
3224 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3225
3226         Add support to WebPage for getting the contents as an attributed string.
3227         https://bugs.webkit.org/show_bug.cgi?id=195636
3228         rdar://problem/45055697
3229
3230         Reviewed by Tim Horton.
3231
3232         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3233         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3234
3235 2019-03-15  Chris Dumez  <cdumez@apple.com>
3236
3237         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3238         https://bugs.webkit.org/show_bug.cgi?id=195747
3239
3240         Reviewed by Geoff Garen.
3241
3242         Add API test coverage.
3243
3244         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3245
3246 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3247
3248         Unreviewed, rolling out r242952.
3249
3250         Causing API failures on iOS Simulator
3251
3252         Reverted changeset:
3253
3254         "[PSON] Make sure the WebProcessCache is leverage when
3255         relaunching a process after termination"
3256         https://bugs.webkit.org/show_bug.cgi?id=195747
3257         https://trac.webkit.org/changeset/242952
3258
3259 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3260
3261         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3262         https://bugs.webkit.org/show_bug.cgi?id=195740
3263
3264         Reviewed by Ross Kirsling.
3265
3266         window.open doesn't work for WebKitBrowserWindow because it is not
3267         implemented yet.
3268
3269         1. Implemented createNewPage callback of WKPageUIClient.
3270         2. Changed MainWindow to take a BrowserWindow factory function
3271           instead of BrowserWindowType to be flexible to create
3272           BrowserWindow with extra settings.
3273         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3274           because it is not relevant with MainWindow anymore.
3275
3276         * MiniBrowser/win/Common.cpp:
3277         (parseCommandLine):
3278         * MiniBrowser/win/Common.h:
3279         (CommandLineOptions::CommandLineOptions):
3280         * MiniBrowser/win/MainWindow.cpp:
3281         (MainWindow::MainWindow):
3282         (MainWindow::create):
3283         (MainWindow::init):
3284         (MainWindow::WndProc):
3285         * MiniBrowser/win/MainWindow.h:
3286         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3287         (PrintWebUIDelegate::createWebViewWithRequest):
3288         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3289         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3290         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3291         (WebKitBrowserWindow::updateProxySettings):
3292         (WebKitBrowserWindow::createNewPage):
3293         * MiniBrowser/win/WebKitBrowserWindow.h:
3294         * MiniBrowser/win/WinMain.cpp:
3295         (wWinMain):
3296
3297 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3298
3299         Make it possible to test scrolling tree layer manipulation more easily
3300         https://bugs.webkit.org/show_bug.cgi?id=195780
3301
3302         Reviewed by Tim Horton.
3303         
3304         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3305         cuts off communication of scrolling tree scrolls back to the web process
3306         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3307         allows tests to trigger scrolls which run the scrolling tree layer positioning
3308         logic, but never get another commit from the web process that might mask
3309         scrolling tree bugs.
3310         
3311         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3312         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3313         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3314
3315         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3316         (WTR::UIScriptController::scrollUpdatesDisabled const):
3317         (WTR::UIScriptController::setScrollUpdatesDisabled):
3318         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3319         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3320         (WTR::UIScriptController::scrollUpdatesDisabled const):
3321         (WTR::UIScriptController::setScrollUpdatesDisabled):
3322         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3323         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3324         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3325         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3326         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3327         * WebKitTestRunner/ios/TestControllerIOS.mm:
3328         (WTR::TestController::platformResetStateToConsistentValues):
3329         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3330         (WTR::UIScriptController::scrollUpdatesDisabled const):
3331         (WTR::UIScriptController::setScrollUpdatesDisabled):
3332
3333 2019-03-14  Youenn Fablet  <youenn@apple.com>
3334
3335         Move IDB storage in private browsing mode to NetworkProcess
3336         https://bugs.webkit.org/show_bug.cgi?id=195602
3337
3338         Reviewed by Brady Eidson.
3339
3340         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3341         (TEST):
3342
3343 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3344
3345         [ews-build] Make descriptionDone messages more readable
3346         https://bugs.webkit.org/show_bug.cgi?id=195760
3347
3348         Reviewed by Lucas Forschler.
3349
3350         * BuildSlaveSupport/ews-build/steps.py:
3351         * BuildSlaveSupport/ews-build/steps_unittest.py:
3352
3353 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3354
3355         [ews-build] Generate status-bubble hover-over messages
3356         https://bugs.webkit.org/show_bug.cgi?id=195680
3357
3358         Reviewed by Lucas Forschler.
3359
3360         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3361         (StatusBubble):
3362         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3363         on hover-over.
3364         (StatusBubble._iso_time):
3365         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3366         hover-over message.
3367         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3368
3369 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3370
3371         [ews-app] Gracefully handle the case when state_string is None
3372         https://bugs.webkit.org/show_bug.cgi?id=195753
3373
3374         Reviewed by Lucas Forschler.
3375
3376         * BuildSlaveSupport/ews-app/ews/models/build.py:
3377         * BuildSlaveSupport/ews-app/ews/models/step.py:
3378
3379 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3380
3381         [ews-app] Status bubble display pending for currently running build step
3382         https://bugs.webkit.org/show_bug.cgi?id=195744
3383
3384         Reviewed by Lucas Forschler.
3385
3386         * BuildSlaveSupport/ews-build/events.py:
3387         (Events.stepStarted): If state_string is pending, replace it with step name.
3388
3389 2019-03-14  Chris Dumez  <cdumez@apple.com>
3390
3391         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3392         https://bugs.webkit.org/show_bug.cgi?id=195750
3393
3394         Reviewed by Geoffrey Garen.
3395
3396         Add API test coverage.
3397
3398         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3399         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3400         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3401         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3402
3403 2019-03-14  Chris Dumez  <cdumez@apple.com>
3404
3405         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3406         https://bugs.webkit.org/show_bug.cgi?id=195747
3407
3408         Reviewed by Geoff Garen.
3409
3410         Add API test coverage.
3411
3412         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3413
3414 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3415
3416         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3417         https://bugs.webkit.org/show_bug.cgi?id=195725
3418         <rdar://problem/48545062>
3419
3420         Reviewed by Tim Horton.
3421
3422         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3423         handler is nil.
3424
3425         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3426         (TestWebKitAPI::TEST):
3427
3428 2019-03-13  Sam Weinig  <sam@webkit.org>
3429
3430         Add utility function to allow easy reverse range-based iteration of a container
3431         https://bugs.webkit.org/show_bug.cgi?id=195542
3432
3433         Reviewed by Antti Koivisto.
3434
3435         * TestWebKitAPI/CMakeLists.txt:
3436         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3437         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3438         (TestWebKitAPI::TEST):
3439         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3440
3441 2019-03-13  Chris Dumez  <cdumez@apple.com>
3442
3443         Use a ServiceWorker process per registrable domain
3444         https://bugs.webkit.org/show_bug.cgi?id=195649
3445
3446         Reviewed by Youenn Fablet.
3447
3448         Update API test coverage.
3449
3450         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3451
3452 2019-03-13  Chris Dumez  <cdumez@apple.com>
3453
3454         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3455         https://bugs.webkit.org/show_bug.cgi?id=195684
3456         <rdar://problem/48294714>
3457
3458         Reviewed by Antti Koivisto.
3459
3460         Add API test coverage.
3461
3462         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3463
3464 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3465
3466         [ews-app] Remove unused patch view
3467         https://bugs.webkit.org/show_bug.cgi?id=195669
3468
3469         Reviewed by Lucas Forschler.
3470
3471         * BuildSlaveSupport/ews-app/ews/urls.py:
3472         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3473
3474 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3475
3476         [ews-app] Use Buildbot result code variables
3477         https://bugs.webkit.org/show_bug.cgi?id=195668
3478
3479         Reviewed by Alexey Proskuryakov.
3480
3481         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3482         (Buildbot): Added Buildbot result code variables.
3483         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3484         (StatusBubble._build_bubble): Used Buildbot result code variables.
3485
3486 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3487
3488         [Flatpak] Expand submodule recursively
3489         https://bugs.webkit.org/show_bug.cgi?id=195672
3490
3491         Building WPE with flatpak was impossible without that as it was raising an exception.
3492         Also update wpebackend-fdo to match what is built in jhbuild
3493
3494         Reviewed by Philippe Normand.
3495
3496         * flatpak/flatpakutils.py:
3497         (expand_submodules_recurse):
3498         (expand_manifest):
3499         * flatpak/org.webkit.WPEModules.yaml:
3500
3501 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3502
3503         [ews-app] status bubble should be hidden for certain builds
3504         https://bugs.webkit.org/show_bug.cgi?id=194597
3505
3506         Reviewed by Dewei Zhu.
3507
3508         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3509         (StatusBubble._build_bubble):
3510         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3511         because the patch didn't have relevant changes.
3512         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3513         in production yet.
3514
3515 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3516
3517         [Win] Fix a slew of simple clang-cl warnings.
3518         https://bugs.webkit.org/show_bug.cgi?id=195652
3519
3520         Reviewed by Don Olmstead.
3521
3522         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3523         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3524
3525 2019-03-12  Justin Fan  <justin_fan@apple.com>
3526
3527         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3528         https://bugs.webkit.org/show_bug.cgi?id=195518
3529         <rdar://problem/46322356>
3530
3531         Reviewed by Myles C. Maxfield.
3532
3533         * DumpRenderTree/DerivedSources-input.xcfilelist:
3534         * DumpRenderTree/DerivedSources-output.xcfilelist:
3535
3536 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3537
3538         Unreviewed, rolling out r242825.
3539         https://bugs.webkit.org/show_bug.cgi?id=195648
3540
3541         "Broke webkitpy tests with my change to
3542         lldb_dump_class_layout.py" (Requested by rmorisset on
3543         #webkit).
3544
3545         Reverted changeset:
3546
3547         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3548         classes with suspicious padding"
3549         https://bugs.webkit.org/show_bug.cgi?id=195573
3550         https://trac.webkit.org/changeset/242825
3551
3552 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3553
3554         [ews-build] Show status bubbles while the patch is waiting in queue
3555         https://bugs.webkit.org/show_bug.cgi?id=195618
3556
3557         Reviewed by Lucas Forschler.
3558
3559         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3560         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3561         enabled in initial deployment.
3562         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3563         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3564         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3565         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3566         (StatusBubble._build_bubbles_for_patch):
3567
3568 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3569
3570         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3571         https://bugs.webkit.org/show_bug.cgi?id=195573
3572
3573         Reviewed by Simon Fraser.
3574
3575         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3576
3577         * Scripts/dump-class-layout:
3578         (main):
3579         * lldb/lldb_dump_class_layout.py:
3580         (ClassLayout.__init__):
3581         (ClassLayout._compute_padding_recursive):
3582         (LLDBDebuggerInstance.dump_layout_for_classname):
3583         (LLDBDebuggerInstance):
3584         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3585         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3586
3587 2019-03-12  Chris Dumez  <cdumez@apple.com>
3588
3589         Device Orientation access permission should be denied unless explicitly granted by the client
3590         https://bugs.webkit.org/show_bug.cgi?id=195625
3591
3592         Reviewed by Youenn Fablet.
3593
3594         add API test coverage.
3595
3596         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3597         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3598         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3599         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3600         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3601         (runDeviceOrientationTest):
3602         (TEST):
3603         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3604         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3605
3606 2019-03-12  Jer Noble  <jer.noble@apple.com>
3607
3608         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3609         https://bugs.webkit.org/show_bug.cgi?id=195137
3610         <rdar://problem/48810307>
3611
3612         Reviewed by Eric Carlson.
3613
3614         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3615         (TestWebKitAPI::TEST):
3616
3617 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3618
3619         [ews-build] Change urls from uat to production
3620         https://bugs.webkit.org/show_bug.cgi?id=195566
3621
3622         Reviewed by Lucas Forschler.
3623
3624         * BuildSlaveSupport/ews-app/ews/config.py:
3625         * BuildSlaveSupport/ews-build/events.py:
3626         * BuildSlaveSupport/ews-build/steps.py:
3627
3628 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3629
3630         [ews-build] change max_builds for local-worker to 1
3631         https://bugs.webkit.org/show_bug.cgi?id=195568
3632
3633         Reviewed by Lucas Forschler.
3634
3635         * BuildSlaveSupport/ews-build/loadConfig.py:
3636
3637 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3638
3639         Fix the build
3640
3641         * TestRunnerShared/spi/PencilKitTestSPI.h:
3642         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3643
3644 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3645
3646         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3647         https://bugs.webkit.org/show_bug.cgi?id=194131
3648
3649         Reviewed by Michael Catanzaro.
3650
3651         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3652         (uriChanged):
3653         (testUnfinishedSubresourceLoad):
3654         (serverCallback):
3655         (beforeAll):
3656
3657 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3658
3659         WTF::Expected should use std::addressof instead of operator&
3660         https://bugs.webkit.org/show_bug.cgi?id=195604
3661
3662         Reviewed by Myles Maxfield.
3663
3664         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3665         (TestWebKitAPI::Unique::Unique):
3666         (TestWebKitAPI::Unique::operator&):
3667         (TestWebKitAPI::TEST):
3668
3669 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3670
3671         Add Optional to Forward.h.
3672         https://bugs.webkit.org/show_bug.cgi?id=195586
3673
3674         Reviewed by Darin Adler.
3675
3676         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3677         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3678         Remove unnecessary includes from headers.
3679
3680 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3681
3682         Add testing API to hit-test and scroll overflow scrollers
3683         https://bugs.webkit.org/show_bug.cgi?id=195278
3684
3685         Reviewed by Antti Koivisto.
3686         
3687         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3688         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3689         
3690         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3691
3692         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3693         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3694         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3695         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3696         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3697         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3698         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3699         (WTR::enclosingScrollViewIncludingSelf):
3700         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3701
3702 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3703
3704         API test WebKit.RequestTextInputContext fails on iOS
3705         https://bugs.webkit.org/show_bug.cgi?id=195585
3706
3707         Reviewed by Wenson Hsieh and Simon Fraser.
3708
3709         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3710         (applyStyle):
3711         (TEST):
3712         Add a viewport, so that the coordinates match up on iOS.
3713         Scroll by moving the UIScrollView's contentOffset.
3714
3715 2019-03-11  Chris Dumez  <cdumez@apple.com>
3716
3717         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3718         https://bugs.webkit.org/show_bug.cgi?id=195506
3719         <rdar://problem/48733477>
3720
3721         Reviewed by Alex Christensen.
3722
3723         Add API test coverage.
3724
3725         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3726
3727 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3728
3729         Adding myself to contributors.json
3730
3731         Unreviewed, addming myself to contributors.json .
3732
3733         * Scripts/webkitpy/common/config/contributors.json:
3734
3735 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3736
3737         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3738         https://bugs.webkit.org/show_bug.cgi?id=195511
3739         <rdar://problem/44873269>
3740
3741         Reviewed by Darin Adler.
3742
3743         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3744         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3745         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3746         (TEST_F):
3747
3748 2019-03-11  Chris Dumez  <cdumez@apple.com>
3749
3750         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3751         https://bugs.webkit.org/show_bug.cgi?id=195561
3752
3753         Reviewed by Youenn Fablet.
3754
3755         Make sure the JS in the test requests for permission to receive device orientation events.
3756
3757         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3758
3759 2019-03-11  Youenn Fablet  <youenn@apple.com>
3760
3761         Allow storage quota increase by default in WTR
3762         https://bugs.webkit.org/show_bug.cgi?id=195541
3763
3764         Reviewed by Geoffrey Garen.
3765
3766         Allow storage quota increase by default in WTR.
3767         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3768         Use this for tests that explicitly need cache increase.
3769
3770         Instead of increasing quota by 2, make sure the next request is
3771         granted by adding all given parameters.
3772
3773         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3774         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3775         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3776         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3777         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3778         * WebKitTestRunner/TestController.cpp:
3779         (WTR::TestController::setAllowStorageQuotaIncrease):
3780         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3781         * WebKitTestRunner/TestController.h:
3782         * WebKitTestRunner/TestInvocation.cpp:
3783         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3784         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3785         (WTR::TestController::cocoaResetStateToConsistentValues):
3786         (WTR::TestController::setAllowStorageQuotaIncrease):
3787         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3788         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3789         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3790
3791 2019-03-11  Xan Lopez  <xan@igalia.com>
3792
3793         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3794         https://bugs.webkit.org/show_bug.cgi?id=194147
3795
3796         Reviewed by Michael Saboff.
3797
3798         To make --32-bit work correctly on Linux/64bit we need to:
3799
3800         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3801         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3802         unfortunately CMake only allows us to do this during
3803         crosscompilation, which is overkill here.
3804         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3805         pkg-config detection module uses the x86 .pc files instead of the
3806         x86_64 ones.
3807         - Set the -m32 flags for the compiler.
3808
3809         * Scripts/webkitdirs.pm:
3810         (generateBuildSystemFromCMakeProject):
3811
3812 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3813
3814         Add MotionMark-1.1 plan file for run-benchmark script.
3815         https://bugs.webkit.org/show_bug.cgi?id=195481
3816
3817         Rubber-stamped by Darin Adler.
3818
3819         Run-benchmark script should support MontionMark-1.1.
3820
3821         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3822
3823 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3824
3825         [ews-app] Add support for submit-to-ews url
3826         https://bugs.webkit.org/show_bug.cgi?id=195477
3827
3828         Reviewed by Lucas Forschler.
3829
3830         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3831         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3832         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3833         * BuildSlaveSupport/ews-app/ews/urls.py:
3834         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3835
3836 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3837
3838         Unreviewed, rolling out r242688, r242643, r242624.
3839
3840         Caused multiple layout test failures and crashes on iOS and macOS.
3841
3842         Reverted changeset:
3843
3844         "requestAnimationFrame should execute before the next frame"
3845         https://bugs.webkit.org/show_bug.cgi?id=177484
3846         https://trac.webkit.org/changeset/242624/webkit
3847
3848         * Tracing/SystemTracePoints.plist:
3849
3850 2019-03-11  John Wilander  <wilander@apple.com>
3851
3852         Resource Load Statistics: Make it possible exclude localhost from classification
3853         https://bugs.webkit.org/show_bug.cgi?id=195474
3854         <rdar://problem/47520577>
3855
3856         Reviewed by Brent Fulgham.
3857
3858         This patch allows for localhost to be excluded from classification and
3859         treatment as a prevalent resource.
3860
3861         The WebKit Tools change adds a new function called
3862         testRunner.setStatisticsIsRunningTest() which can be used to control this
3863         behavior.
3864
3865         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3866         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3867         (WTR::TestRunner::setStatisticsIsRunningTest):
3868         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3869         * WebKitTestRunner/TestController.cpp:
3870         (WTR::TestController::setStatisticsIsRunningTest):
3871         * WebKitTestRunner/TestController.h:
3872         * WebKitTestRunner/TestInvocation.cpp:
3873         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3874
3875 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3876
3877         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3878         https://bugs.webkit.org/show_bug.cgi?id=195560
3879
3880         Reviewed by Lucas Forschler.
3881
3882         * BuildSlaveSupport/ews-build/master.cfg:
3883
3884 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3885
3886         Unreviewed, rolling out r242698.
3887
3888         API test crashes on bots.
3889
3890         Reverted changeset:
3891
3892         "Add a WKContentRuleList variant that uses copied memory
3893         instead of mmap'd shared memory for class A containerized
3894         apps"
3895         https://bugs.webkit.org/show_bug.cgi?id=195511
3896         https://trac.webkit.org/changeset/242698
3897
3898 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3899
3900         [WPE] Enable web process sandbox
3901         https://bugs.webkit.org/show_bug.cgi?id=195169
3902
3903         Reviewed by Daniel Bates.
3904
3905         * wpe/install-dependencies:
3906         * wpe/jhbuild.modules:
3907
3908 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3909
3910         [ews-app] Use port 17000 for worker communication
3911         https://bugs.webkit.org/show_bug.cgi?id=195558
3912
3913         Reviewed by Lucas Forschler.
3914
3915         * BuildSlaveSupport/ews-build/master.cfg:
3916
3917 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3918
3919         [ews-build] unit-tests fail when passwords.json is missing
3920         https://bugs.webkit.org/show_bug.cgi?id=195557
3921
3922         Reviewed by Lucas Forschler.
3923
3924         * BuildSlaveSupport/ews-build/loadConfig.py:
3925         (loadBuilderConfig):
3926         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3927         (ConfigDotJSONTest.test_configuration):
3928         * BuildSlaveSupport/ews-build/master.cfg:
3929
3930 2019-03-11  Truitt Savell  <tsavell@apple.com>
3931
3932         Unreviewed, rolling out r242702.
3933
3934         Broke High Sierra builders.
3935
3936         Reverted changeset:
3937
3938         "Add utility function to allow easy reverse range-based
3939         iteration of a container"
3940         https://bugs.webkit.org/show_bug.cgi?id=195542
3941         https://trac.webkit.org/changeset/242702
3942
3943 2019-03-11  Sam Weinig  <sam@webkit.org>
3944
3945         Add utility function to allow easy reverse range-based iteration of a container
3946         https://bugs.webkit.org/show_bug.cgi?id=195542
3947
3948         Reviewed by Antti Koivisto.
3949
3950         * TestWebKitAPI/CMakeLists.txt:
3951         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3952         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3953         (TestWebKitAPI::TEST):
3954         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3955
3956 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3957
3958         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3959         https://bugs.webkit.org/show_bug.cgi?id=195511
3960         <rdar://problem/44873269>
3961
3962         Reviewed by Darin Adler.
3963
3964         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3965         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3966         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3967         (TEST_F):
3968
3969 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3970
3971         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3972         https://bugs.webkit.org/show_bug.cgi?id=195499
3973
3974         Reviewed by Darin Adler.
3975
3976         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3977         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3978         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3979         (-[WKWebView synchronouslyFocusTextInputContext:]):
3980         (applyStyle):
3981         (applyIframe):
3982         (TEST):
3983         Add some tests for this SPI.
3984
3985 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3986
3987         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3988         https://bugs.webkit.org/show_bug.cgi?id=181151
3989
3990         Reviewed by Don Olmstead.
3991
3992         * TestWebKitAPI/CMakeLists.txt:
3993         * TestWebKitAPI/PlatformWin.cmake:
3994         Enable TestWTF RunLoop tests in all platforms.
3995
3996         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3997         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3998         (TestWebKitAPI::DerivedOneShotTimer::fired):
3999         (TestWebKitAPI::TEST):
4000         Only a few platforms support nested RunLoop.
4001
4002         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
4003         (TestWebKitAPI::DerivedRepeatingTimer::fired):
4004
4005 2019-03-10  David Quesada  <david_quesada@apple.com>
4006
4007         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
4008         https://bugs.webkit.org/show_bug.cgi?id=152480
4009
4010         Reviewed by Chris Dumez.
4011
4012         Add a unit test based on Daniel Bates's test case that starts a download, ensures
4013         there are no additional references to the process pool besides the one held by
4014         the download, waits for the download to finish (in the sense that the
4015         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
4016         measure, also check that the process pool has been deallocated at the end of the
4017         test. The test wouldn't be meaningful if the process pool were still alive.
4018
4019         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4020         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
4021         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
4022             The download will be canceled because the delegate does not implement the
4023             method to decide the download's destination, so this is where we know the
4024             DownloadProxyMap is done with the DownloadProxy.
4025         (TEST):
4026
4027 2019-03-08  Chris Dumez  <cdumez@apple.com>
4028
4029         Add support for Device Orientation / Motion permission API
4030         https://bugs.webkit.org/show_bug.cgi?id=195329
4031         <rdar://problem/47645367>
4032
4033         Reviewed by Geoffrey Garen.
4034
4035         Add test infrastructure to help test the Device Orientation / Motion permission API.
4036
4037         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4038         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4039         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
4040         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4041         * WebKitTestRunner/TestController.cpp:
4042         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
4043         (WTR::TestController::createWebViewWithOptions):
4044         (WTR::TestController::resetStateToConsistentValues):
4045         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
4046         * WebKitTestRunner/TestController.h:
4047         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
4048         * WebKitTestRunner/TestInvocation.cpp:
4049         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4050
4051 2019-03-08  Saam barati  <sbarati@apple.com>
4052
4053         Add a compare-results script to compare benchmark results
4054         https://bugs.webkit.org/show_bug.cgi?id=195486
4055         <rdar://problem/48723397>
4056
4057         Reviewed by Geoffrey Garen.
4058
4059         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
4060         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
4061         to extend it to learn about our other benchmarks.
4062
4063         * Scripts/compare-results: Added.
4064         (readJSONFile):
4065         (detectJetStream2):
4066         (JetStream2Results):
4067         (detectSpeedometer2):
4068         (Speedometer2Results):
4069         (detectPLT5):
4070         (PLT5Results):
4071         (detectBenchmark):
4072         (biggerIsBetter):
4073         (ttest):
4074         (getOptions):
4075         (main):
4076
4077 2019-03-08  Stephanie Lewis  <slewis@apple.com>
4078
4079         Ensure old tab state is cleared between iterations of run-benchmark
4080         https://bugs.webkit.org/show_bug.cgi?id=195393
4081         <rdar://problem/46885583>
4082
4083         Reviewed by Dewei Zhu.
4084
4085         a) ensure the default to restore state is not set
4086         b) terminate Safari correctly
4087         c) Set the system default to ignore Persistent State in Safari
4088
4089         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
4090         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
4091         (OSXBrowserDriver.prepare_env): 
4092         (OSXBrowserDriver.restore_env):
4093         (OSXBrowserDriver.close_browsers):
4094         (OSXBrowserDriver._terminate_processes):
4095         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
4096         (OSXChromeDriver):
4097         (OSXChromeCanaryDriver):
4098         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
4099         (OSXFirefoxDriver):
4100         (OSXFirefoxNightlyDriver):
4101         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
4102         (OSXSafariDriver):
4103         (OSXSafariDriver.prepare_env):
4104
4105 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
4106
4107         [GTK] Several InputMethodFilter tests are failing
4108         https://bugs.webkit.org/show_bug.cgi?id=195408
4109
4110         Reviewed by Carlos Garcia Campos.
4111
4112         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
4113         Regressed in r241751.
4114         Hexadecimal values of keycodes are expressed now in upper letters.
4115         Composited characters should be cast to UTF8 strings.
4116
4117         (TestWebKitAPI::TEST):
4118
4119 2019-03-07  Tomas Popela  <tpopela@redhat.com>
4120
4121         [GTK] Make Tools/gtkdoc python3 compatible
4122         https://bugs.webkit.org/show_bug.cgi?id=195359
4123
4124         Reviewed by Carlos Garcia Campos.
4125
4126         * gtkdoc/generate-gtkdoc:
4127         ConfigParser was reworked in Python 3.2 so we have adapt the code to
4128         work with Python 2 and 3.
4129         (get_gtkdoc_module_paths):
4130         The iteritems() was removed in Python 3, so let's use items() that's
4131         available in Python 2 and 3.
4132         (get_generator_for_config):
4133         * gtkdoc/gtkdoc.py:
4134         (GTKDoc._run_command):
4135         The sys.stdout.write() is expecting str in Python 3 and not bytes
4136         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
4137         for passing the bytes there.
4138
4139 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
4140
4141         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4142         https://bugs.webkit.org/show_bug.cgi?id=195346
4143         <rdar://problem/48667048>
4144
4145         Unreviewed build fix for clang-cl.
4146
4147         * DumpRenderTree/win/DumpRenderTree.cpp:
4148         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
4149
4150 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
4151
4152         requestAnimationFrame should execute before the next frame
4153         https://bugs.webkit.org/show_bug.cgi?id=177484
4154
4155         Reviewed by Simon Fraser.
4156
4157         Add trace points for the page RenderingUpdate.
4158
4159         * Tracing/SystemTracePoints.plist:
4160
4161 2019-03-07  Zalan Bujtas  <zalan@apple.com>
4162
4163         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
4164         https://bugs.webkit.org/show_bug.cgi?id=195353
4165         <rdar://problem/48626394>
4166
4167         Reviewed by Simon Fraser.
4168
4169         * WebKitTestRunner/ios/TestControllerIOS.mm:
4170         (WTR::TestController::platformResetPreferencesToConsistentValues):
4171
4172 2019-03-07  John Wilander  <wilander@apple.com>
4173
4174         Resource Load Statistics: Make it possible to purge only script-accessible cookies
4175         https://bugs.webkit.org/show_bug.cgi?id=195383
4176         <rdar://problem/48570136>
4177
4178         Reviewed by Brent Fulgham.
4179
4180         This patch adds test infrastructure to purge only script-accessible cookies,
4181         including a new testRunner function called statisticsDeleteCookiesForHost().git a
4182
4183         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4184         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4185         (WTR::TestRunner::statisticsDeleteCookiesForHost):
4186         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4187         * WebKitTestRunner/TestController.cpp:
4188         (WTR::TestController::statisticsDeleteCookiesForHost):
4189         * WebKitTestRunner/TestController.h:
4190         * WebKitTestRunner/TestInvocation.cpp:
4191         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4192
4193 2019-03-07  Commit Queue  <commit-queue@webkit.org>
4194
4195         Unreviewed, rolling out r242354.
4196         https://bugs.webkit.org/show_bug.cgi?id=195402
4197
4198         breaks layout tests in all configurations (Requested by
4199         zdobersek on #webkit).
4200
4201         Reverted changeset:
4202
4203         "[WPE] Enable web process sandbox"
4204         https://bugs.webkit.org/show_bug.cgi?id=195169
4205         https://trac.webkit.org/changeset/242354
4206
4207 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
4208
4209         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4210         https://bugs.webkit.org/show_bug.cgi?id=195346
4211
4212         Reviewed by Fujii Hironori.
4213
4214         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
4215         (TestWebKitAPI::TEST):
4216         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
4217
4218         * DumpRenderTree/win/DumpRenderTree.cpp:
4219         (findFontFallback):
4220         (addFontFallbackIfPresent):
4221         (removeFontFallbackIfPresent):
4222         (main):
4223         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4224         (TestWebKitAPI::Util::moduleDirectory):
4225         (TestWebKitAPI::Util::createInjectedBundlePath):
4226         Use wchar helpers as needed.
4227
4228 2019-03-06  Rob Buis  <rbuis@igalia.com>
4229
4230         Consider supporting the `referrerpolicy` attribute.
4231         https://bugs.webkit.org/show_bug.cgi?id=179053
4232
4233         Reviewed by Darin Adler.
4234
4235         Add a runtime flag for referrerpolicy attribute.
4236
4237         * DumpRenderTree/mac/DumpRenderTree.mm:
4238         (enableExperimentalFeatures):
4239
4240 2019-03-05  Daniel Bates  <dabates@apple.com>
4241
4242         Update expected API test result following r242379
4243         (https://bugs.webkit.org/show_bug.cgi?id=195125)
4244
4245         Update expected x-coordinate of selection rect now that the left padding of
4246         a textarea is sized in ems (so dependent on the font size) just like the left
4247         padding of a text field.
4248
4249         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4250         (TestWebKitAPI::TEST):
4251
4252 2019-03-05  David Quesada  <david_quesada@apple.com>
4253
4254         [WK2] It should be possible to follow links with 'download' attributes
4255         https://bugs.webkit.org/show_bug.cgi?id=195145
4256         rdar://problem/48462642
4257
4258         Reviewed by Alex Christensen.
4259
4260         Add a unit test to verify that activating links with 'download' attributes now
4261         navigates to the linked resource, rather than starts downloading it. Add another
4262         to verify that it is still possible to explicitly download the link via the
4263         'Download' navigation action policy.
4264
4265         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4266         (-[DownloadAttributeTestDelegate init]):
4267         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
4268         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
4269         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
4270         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
4271         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4272         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
4273         (TEST):
4274         * WebKitTestRunner/TestController.cpp:
4275         (WTR::TestController::decidePolicyForNavigationAction):
4276         * WebKitTestRunner/TestController.h:
4277
4278 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
4279
4280         [Curl] Implement Cookie Accept Policy.
4281         https://bugs.webkit.org/show_bug.cgi?id=191645
4282
4283         Reviewed by Fujii Hironori.
4284
4285         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4286         (TestWebKitAPI::Curl::TEST_F):
4287
4288 2019-03-05  Youenn Fablet  <youenn@apple.com>
4289
4290         Rename requestCacheStorageSpace to requestStorageSpace
4291         https://bugs.webkit.org/show_bug.cgi?id=195282
4292
4293         Reviewed by Chris Dumez.
4294
4295         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4296         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4297         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
4298
4299 2019-03-05  Brady Eidson  <beidson@apple.com>
4300
4301         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
4302         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
4303
4304         Reviewed by Tim Horton.
4305
4306         Loading a file: URL into a WKWebView and then loading another file: url from a completely
4307         different directory into that same WKWebView should work.
4308
4309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4310         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
4311
4312 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
4313
4314         Add WeakHashSet
4315         https://bugs.webkit.org/show_bug.cgi?id=195152
4316
4317         Reviewed by Antti Koivisto.
4318
4319         Added tests for WeakHashSet.
4320
4321         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4322         (TestWebKitAPI::Base::Base): Moved.
4323         (TestWebKitAPI::Derived::foo): Moved.
4324         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
4325         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
4326         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
4327         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
4328
4329 2019-03-04  Chris Dumez  <cdumez@apple.com>
4330
4331         Do not share WebProcesses between private and regular sessions
4332         https://bugs.webkit.org/show_bug.cgi?id=195189
4333         <rdar://problem/48421064>
4334
4335         Reviewed by Alex Christensen.
4336
4337         Add API test coverage.
4338
4339         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4340         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4341
4342 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
4343
4344         [WPE] Enable web process sandbox
4345         https://bugs.webkit.org/show_bug.cgi?id=195169
4346
4347         Reviewed by Daniel Bates.
4348
4349         * wpe/install-dependencies:
4350         * wpe/jhbuild.modules:
4351
4352 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4353