[Qt] Fix build with some versions of the gold linker
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
2
3         [Qt] Fix build with some versions of the gold linker
4
5         Reviewed by Tor Arne Vestbø.
6
7         Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
8         Instead run a compile/link test first to see if it works.
9
10         * qmake/config.tests/gnuld/gnuld.pro: Added.
11         * qmake/config.tests/gnuld/main.cpp: Added.
12         (main):
13         * qmake/mkspecs/features/unix/default_post.prf:
14
15 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
16
17         [Qt] Remove forced use of gold.
18
19         Reviewed by Tor Arne Vestbø.
20
21         The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
22         modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
23         often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
24
25         * qmake/mkspecs/features/unix/default_post.prf:
26
27 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
28
29         [Qt] Prospective Qt/Windows cross-compiling fix
30
31         Reviewed by Tor Arne Vestbø.
32
33         The win32 scope is not set when cross-compiling from Linux to Windows.
34
35         * qmake/mkspecs/features/functions.prf:
36
37 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
38
39         [EFL] Remove background view on EWebLauncher and MiniBrowser
40         https://bugs.webkit.org/show_bug.cgi?id=96905
41
42         Reviewed by Gyuyoung Kim.
43
44         The size of webview was changed after adding url bar.
45         And the background view is not necessary anymore, since it was used for debugging back in the day.
46
47         * EWebLauncher/main.c:
48         (_ELauncher):
49         (on_ecore_evas_resize):
50         (browserCreate):
51         * MiniBrowser/efl/main.c:
52         (_MiniBrowser):
53         (on_ecore_evas_resize):
54         (browserCreate):
55
56 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
57
58         [GTK] run-webkit-tests unable to find TestExpectations for WK2
59         https://bugs.webkit.org/show_bug.cgi?id=96998
60
61         Reviewed by Philippe Normand.
62
63         We should look for TestExpectations files in all the locations where
64         we currently look for Skipped files. This will allow
65         run-webkit-tests to look for TestExpectations files in
66         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
67
68         * Scripts/webkitpy/layout_tests/port/gtk.py:
69         (GtkPort.expectations_files):
70
71 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
72
73         [Qt] Fix build without the QtQuick module
74
75         Reviewed by Simon Hausmann.
76
77         * qmake/mkspecs/features/features.prf:
78
79 2012-09-18  Stephanie Lewis  <slewis@apple.com>
80
81         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
82
83         Unreviewed.
84
85         * DumpRenderTree/mac/DumpRenderTree.mm:
86         (poseAsClass):
87
88 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
89
90         Unreviewed update of email addresses for Berlin QtWebKit office.
91
92         * Scripts/webkitpy/common/config/committers.py:
93
94 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
95
96         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
97         https://bugs.webkit.org/show_bug.cgi?id=96899
98
99         Reviewed by Martin Robinson.
100
101         When overriding the 'WebKitDisplayImageKey' preference, use the
102         'auto-load-images' property of WebKitWebSettings as the property which
103         should be updated with the corresponding preference value.
104
105         * DumpRenderTree/gtk/DumpRenderTree.cpp:
106         (resetDefaultsToConsistentValues):
107         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
108         (TestRunner::overridePreference):
109
110 2012-09-17  Pratik Solanki  <psolanki@apple.com>
111
112         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
113         https://bugs.webkit.org/show_bug.cgi?id=96973
114
115         Reviewed by Dan Bernstein.
116
117         * DumpRenderTree/mac/Configurations/Base.xcconfig:
118         * WebKitTestRunner/Configurations/Base.xcconfig:
119         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
120
121 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
122
123         nrwt: remove "unexpected EOF" warnings
124         https://bugs.webkit.org/show_bug.cgi?id=96970
125
126         Reviewed by Ojan Vafai.
127
128         After debugging this a bit, it looks like there aren't any cases
129         that I can reproduce where a read() of zero indicates something
130         actually wrong; either it is a prelude to a crash, or a false
131         negative. So, I'm removing these warnings and adding a comment.
132
133         * Scripts/webkitpy/layout_tests/port/server_process.py:
134         (ServerProcess._wait_for_data_and_update_buffers_using_select):
135
136 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
137
138         [chromium] ASAN bot is crashing at the end of the run
139         https://bugs.webkit.org/show_bug.cgi?id=96967
140
141         Reviewed by Abhishek Arya.
142
143         The ASAN bot is crashing attempting to decode some output into
144         UTF-8; there's no reason to do this, so let's not do this and
145         see if something else is going on as well.
146
147         * Scripts/webkitpy/layout_tests/port/chromium.py:
148         (ChromiumPort._get_crash_log):
149
150 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
151
152         nrwt: --results-directory isn't getting printed properly
153         https://bugs.webkit.org/show_bug.cgi?id=96965
154
155         Reviewed by Ojan Vafai.
156
157         options.results_directory isn't actually initialized with the
158         default values until after we call print_config(), so this
159         changes things to print the value directly.
160
161         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
162         (run):
163         * Scripts/webkitpy/layout_tests/views/printing.py:
164         (Printer.print_config):
165         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
166         (Testprinter.test_print_config):
167
168 2012-09-17  Rob Buis  <rbuis@rim.com>
169
170         [BlackBerry] Enable VIDEO_TRACK
171         https://bugs.webkit.org/show_bug.cgi?id=96949
172
173         Reviewed by Antonio Gomes.
174
175         * Scripts/webkitperl/FeatureList.pm:
176
177 2012-09-17  Rick Byers  <rbyers@chromium.org>
178
179         Add handling of new GestureTapCancel in DRT
180
181         https://bugs.webkit.org/show_bug.cgi?id=96183
182
183         Reviewed by Antonio Gomes.
184
185         * DumpRenderTree/chromium/TestWebPlugin.cpp:
186         (TestWebPlugin::handleInputEvent):
187         * DumpRenderTree/chromium/EventSender.cpp:
188         (EventSender::gestureTapCancel):
189
190 2012-09-17  Philip Rogers  <pdr@google.com>
191
192         Teach style checker about preprocessor directive indentation rules
193         https://bugs.webkit.org/show_bug.cgi?id=96874
194
195         Reviewed by Adam Barth.
196
197         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
198         This is not explicit in our style guide but is generally followed in our code.
199         Searching for violations in our codebase shows these are rarely indented:
200             #include - indented in 6 files
201             #ifdef - indented in 0 files
202             #ifndef - indented in 1 file
203             #define - indented in 11 files
204             #if - indented in 7 files
205
206         * Scripts/webkitpy/style/checkers/cpp.py:
207         (check_directive_indentation):
208
209             This is the simple test where we look for spaces followed by a #.
210
211         (check_style):
212         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
213
214             A few tests needed to be modified because they had unintentionally indented
215             preprocessor directives.
216
217         (CppStyleTest.test_build_class.Foo):
218         (CppStyleTest.test_build_class):
219         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
220         (WebKitStyleTest.test_line_breaking):
221         (WebKitStyleTest.test_directive_indentation):
222
223 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
224
225         [Qt] Auto-generate the module pri file for QtWebKit
226
227         Reviewed by Simon Hausmann.
228
229         * qmake/qt_webkit.pri: Removed.
230
231 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
232
233         nrwt: --additional-platform-dir is broken on chromium ports
234         https://bugs.webkit.org/show_bug.cgi?id=96840
235
236         Reviewed by Ojan Vafai.
237
238         Looks like I broke this when cleaning things up as part of
239         adding ML support. Fixing and adding a test.
240
241         * Scripts/webkitpy/layout_tests/port/chromium.py:
242         (ChromiumPort.default_baseline_search_path):
243         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
244         (ChromiumAndroidPort.default_baseline_search_path):
245         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
246         (ChromiumLinuxPort.default_baseline_search_path):
247         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
248         (ChromiumMacPort.__init__):
249         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
250         (ChromiumWinPort.setup_environ_for_server):
251         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
252         (test_check_build):
253         (test_additional_platform_directory):
254
255 2012-09-13  Stephanie Lewis  <slewis@apple.com>
256
257         mac-future ignores previous platform TestExpectations.
258         https://bugs.webkit.org/show_bug.cgi?id=96718.
259
260         Reviewed by Dirk Pranke.
261
262         TestExpectations match an expectation's configuraton against a list of configurations that are 
263         valid for that port.  That list does not contain mac-future so none of the expectations can be
264         applied.
265
266         * Scripts/webkitpy/layout_tests/port/apple.py:
267         (ApplePort._generate_all_test_configurations):
268
269 2012-09-14  Adam Barth  <abarth@webkit.org>
270
271         Remove webkitPostMessage
272         https://bugs.webkit.org/show_bug.cgi?id=96577
273
274         Reviewed by Ojan Vafai.
275
276         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
277
278         * Scripts/webkitperl/FeatureList.pm:
279         * qmake/mkspecs/features/features.pri:
280
281 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
282
283         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
284         https://bugs.webkit.org/show_bug.cgi?id=96817
285
286         Reviewed by Kenneth Rohde Christiansen.
287
288         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
289         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
290         got overlooked when adding logging elsewhere.
291
292 2012-09-14  Peter Beverloo  <peter@chromium.org>
293
294         [Chromium] Build fix for DumpRenderTree following r128628
295         https://bugs.webkit.org/show_bug.cgi?id=96808
296
297         Reviewed by Tony Chang.
298
299         When building DumpRenderTree from the Chromium project, a compile error
300         shows up because including the header ForwardIOStreamsAndroid.h cannot
301         be located. TestWebKitAPI does this correctly.
302
303         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
304
305 2012-09-14  Dana Jansens  <danakj@chromium.org>
306
307         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
308         https://bugs.webkit.org/show_bug.cgi?id=96805
309
310         Reviewed by Dirk Pranke.
311
312         * Scripts/webkitpy/common/config/committers.py:
313         * Scripts/webkitpy/common/config/watchlist:
314
315 2012-09-14  Peter Beverloo  <peter@chromium.org>
316
317         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
318         https://bugs.webkit.org/show_bug.cgi?id=96687
319
320         Reviewed by Tony Chang.
321
322         Android's DumpRenderTree currently supports these arguments, implemented
323         as part of TestShellAndroid:
324         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
325
326         They're used by the layout test runner to get the STDOUT and STDERR while
327         a layout test run is in process, which is a safer alternative to parsing
328         all the logcat output manually. The implementation can be seen here:
329         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
330
331         This patch generalizes parsing of and applying the effects of these arguments
332         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
333         After this patch, this will make it possible to pull out the output-reading
334         code from Android's layout test port and generalize it so it can be re-used
335         in the new test-runner for the other two test suites.
336
337         This has no effect when compiling and running these tests as part of Chromium
338         code, which has a much more advanced test-runner that does parse complete log
339         output, but also directly depends on code licensed under Apache 2.
340
341         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
342         * DumpRenderTree/chromium/TestShellAndroid.cpp:
343         (platformInit):
344         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
345
346 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
347
348         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
349         https://bugs.webkit.org/show_bug.cgi?id=96656
350
351         Reviewed by Adam Barth.
352
353         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
354         macros in 1 line.
355
356         * Scripts/webkitpy/style/checkers/cpp.py:
357         (check_style.definitions):
358         (check_style): Add rule.
359         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
360         (WebKitStyleTest.test_line_breaking): Add unittest.
361
362 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
363
364         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
365         https://bugs.webkit.org/show_bug.cgi?id=57570
366
367         Reviewed by Kenneth Rohde Christiansen.
368
369         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
370         and dump the information expected by the test cases.
371
372         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
373         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
374         (WTR::InjectedBundle::beginTesting): Explicitly set the default
375         database quota.
376         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
377         (WTR::securityOriginToStr): New convenience function to convert
378         a security origin to the string expected in test results.
379         (WTR):
380         (WTR::InjectedBundlePage::InjectedBundlePage):
381         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
382         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
383         refactoring to share code with didExceedDatabaseQuota.
384         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
385         (InjectedBundlePage):
386         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
387         (WTR::TestRunner::TestRunner):
388         * WebKitTestRunner/InjectedBundle/TestRunner.h:
389         (WTR::TestRunner::dumpDatabaseCallbacks):
390         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
391         (TestRunner):
392
393 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
394
395         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
396
397         Rubber-stamped by Simon Hausmann.
398
399         * qmake/mkspecs/features/default_post.prf:
400
401 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
402
403         [Qt] Remove old cruft from the qmake build system
404
405         Rubber-stamped by Simon Hausmann.
406
407         * DumpRenderTree/qt/DumpRenderTree.pro:
408         * qmake/mkspecs/features/default_post.prf:
409
410 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
411
412         [Qt] Enable force_static_libs_as_shared for development
413
414         Not enabled for buildbots or production-builds (part of Qt5)
415
416         Reviewed by Simon Hausmann.
417
418         * qmake/mkspecs/features/default_post.prf:
419
420 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
421
422         [Qt] Make force_static_libs_as_shared work on Mac OS
423
424         We had to move a few LIBS += around that were in the wrong place,
425         and not caught when everything was just linked into the final
426         QtWebKit library.
427
428         Reviewed by Simon Hausmann.
429
430         * qmake/mkspecs/features/default_post.prf:
431         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
432
433 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
434
435         [Qt] Fix build of WTR on Windows
436
437         Reviewed by Tor Arne Vestbø.
438
439         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
440         With qmake's unix makefile generator as well as with the MingW generator,
441         the directory where the pro file lives (WTR/) is automatically added to
442         the include search path, but not so with MSVC. Instead of relying on qmake's
443         implicit feature here, add WTR/ explicitly to the include search path.
444
445         * WebKitTestRunner/Target.pri:
446
447 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
448
449         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
450         https://bugs.webkit.org/show_bug.cgi?id=42691
451
452         Reviewed by Kenneth Rohde Christiansen.
453
454         Add implementation for testrunner.setStopProvisionalFrameLoads()
455         in WebKitTestRunner.
456
457         Original patch by Alexey Proskuryakov.
458
459         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
460         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
461         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
462         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
463         (WTR::TestRunner::TestRunner):
464         * WebKitTestRunner/InjectedBundle/TestRunner.h:
465         (TestRunner):
466         (WTR::TestRunner::setStopProvisionalFrameLoads):
467         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
468
469 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
470
471         [Qt] Fix handling of debug/release/debug_and_release/build_all
472
473         We now pick up the defaults from Qt, in default_pre (CONFIG already
474         contains the appropriate values for debug and release). We then let
475         the command line arguments to qmake, or the project files themselves,
476         override the configuration, and finally we sanitize the configuration
477         in default_post.
478
479         Reviewed by Simon Hausmann.
480
481         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
482         * Scripts/webkitdirs.pm:
483         (buildQMakeProjects):
484         * qmake/mkspecs/features/default_post.prf:
485         * qmake/mkspecs/features/default_pre.prf:
486         * qmake/mkspecs/features/mac/default_pre.prf:
487
488 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
489
490         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
491         https://bugs.webkit.org/show_bug.cgi?id=42687
492
493         Reviewed by Kenneth Rohde Christiansen.
494
495         Implement testRunner.setTabKeyCyclesThroughElements for
496         WebKitTestRunner.
497
498         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
499         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
500         (WTR::InjectedBundle::beginTesting):
501         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
502         (WTR::TestRunner::setTabKeyCyclesThroughElements):
503         (WTR):
504         * WebKitTestRunner/InjectedBundle/TestRunner.h:
505         (TestRunner):
506
507 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
508
509         EventSendingController::keyDown does not support non-array modifier arguments
510         https://bugs.webkit.org/show_bug.cgi?id=96727
511
512         Reviewed by Kenneth Rohde Christiansen.
513
514         Add support for handling a string as modifier argument to
515         EventSendingController::keyDown.
516
517         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
518         (WTR::parseModifierArray):
519
520 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
521
522         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
523         https://bugs.webkit.org/show_bug.cgi?id=42546
524
525         Reviewed by Kenneth Rohde Christiansen.
526
527         Exported TestRunner::setCustomPolicyDelegate() method.
528         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
529
530         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
531         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
532         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
533
534 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
535
536         [GTK] Clear application cache between tests in DumpRenderTree
537         https://bugs.webkit.org/show_bug.cgi?id=96543
538
539         Reviewed by Philippe Normand.
540
541         Call the new DumpRenderTreeSupportGtk method to clear application cache
542         after each test in DumpRenderTree.
543
544         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
545         as well. It's now being set in XvfbDriver._start so that each driver is assigned
546         a cache directory that's constructed out of the driver's name and its worker
547         number. These directories are located in the layout tests results directory.
548         At least on the builders this ensures a driver-specific empty cache directory
549         with each test run.
550
551         * DumpRenderTree/gtk/DumpRenderTree.cpp:
552         (runTest):
553         * Scripts/webkitpy/layout_tests/port/gtk.py:
554         (GtkPort.setup_environ_for_server):
555         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
556         (XvfbDriver._start):
557
558 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
559
560         [Qt] Fix linking on Windows
561
562         Reviewed by Tor Arne Vestbø.
563
564         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
565         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
566         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
567         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
568
569         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
570         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
571         after the module. Therefore QT did never contain webkit anymore and we always passed
572         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
573
574         This patch introduces a creating_module configuration that is used to
575         scope the qt/pkgconfig sanitization.
576
577         * qmake/mkspecs/features/default_post.prf:
578
579 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
580
581         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
582         https://bugs.webkit.org/show_bug.cgi?id=96740
583
584         Reviewed by Kenneth Rohde Christiansen.
585
586         Dump information expected by the test cases about the following
587         frame load callbacks:
588         "didDisplayInsecureContentForFrame"
589         "didRunInsecureContentForFrame"
590         "didDetectXSSForFrame"
591
592         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
593         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
594         as expected by test results by calling pathSuitableForTestResult() instead
595         of printing raw URL.
596         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
597         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
598         (WTR::InjectedBundlePage::didDetectXSSForFrame):
599
600 2012-09-14  Peter Beverloo  <peter@chromium.org>
601
602         The runtime/unsigned category should be valid in the cpp style-checker.
603         https://bugs.webkit.org/show_bug.cgi?id=96748
604
605         Reviewed by Csaba Osztrogonác.
606
607         This is causing the webkitpy tests to fail because it's not listed in the
608         category array. Furthermore, change an "int" to "long" because it's
609         throwing a double error in one of the earlier asserts.
610
611         * Scripts/webkitpy/style/checkers/cpp.py:
612         (CppChecker):
613         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
614         (WebKitStyleTest.test_names):
615
616 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
617
618         Evas_Object* is a ref'ed structure, so tread it as such
619         https://bugs.webkit.org/show_bug.cgi?id=96659
620
621         Reviewed by Adam Barth.
622
623         Replace OwnPtr<Evas_Object> with RefPtr.
624
625         * DumpRenderTree/efl/ImageDiff.cpp:
626         (calculateDifference):
627         (printImageDifferences):
628         (readImageFromStdin):
629         (main):
630
631 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
632
633         Unreviewed, rolling out r128507.
634         http://trac.webkit.org/changeset/128507
635         https://bugs.webkit.org/show_bug.cgi?id=96659
636
637         Revert. r128507 makes too many crashes in EFL layout test bots.
638
639         * DumpRenderTree/efl/ImageDiff.cpp:
640         (calculateDifference):
641         (printImageDifferences):
642         (readImageFromStdin):
643         (main):
644
645 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
646
647         Make compile with both OS(WINCE) and PLATFORM(QT) support
648         https://bugs.webkit.org/show_bug.cgi?id=95536
649
650         Reviewed by Simon Hausmann.
651
652         Fix wince support in qmake files
653
654         * Tools.pro:
655         * qmake/mkspecs/features/configure.prf:
656         * qmake/mkspecs/features/default_post.prf:
657         * qmake/mkspecs/features/features.prf:
658         * qmake/mkspecs/features/functions.prf:
659
660 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
661
662         [WK2] Add color picker API support for WebKit2
663         https://bugs.webkit.org/show_bug.cgi?id=95058
664
665         Reviewed by Gyuyoung Kim.
666
667         Initialization code for color picker callbacks in UI client.
668
669         * MiniBrowser/mac/BrowserWindowController.m:
670         (-[BrowserWindowController awakeFromNib]):
671         * MiniBrowser/win/BrowserView.cpp:
672         (BrowserView::create):
673         * WebKitTestRunner/TestController.cpp:
674         (WTR::TestController::createOtherPage):
675         (WTR::TestController::initialize):
676
677 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
678
679         Upgrade yutak to reviewer
680         https://bugs.webkit.org/show_bug.cgi?id=96721
681
682         Reviewed by Kent Tamura.
683
684         * Scripts/webkitpy/common/config/committers.py:
685
686 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
687
688         Make the style checker report usage of "unsigned int"
689         https://bugs.webkit.org/show_bug.cgi?id=96693
690
691         Reviewed by Dirk Pranke.
692
693         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
694
695         * Scripts/webkitpy/style/checkers/cpp.py:
696         (check_language):
697
698 2012-09-13  Philip Rogers  <pdr@google.com>
699
700         Add gender-neutral form of webkit-patch land-cowboy
701         https://bugs.webkit.org/show_bug.cgi?id=96709
702
703         Reviewed by Adam Barth.
704
705         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
706
707         * Scripts/webkitpy/tool/commands/download.py:
708         (LandCowhand):
709
710 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
711
712         [EFL] Remove some parameters in browserCreate()
713         https://bugs.webkit.org/show_bug.cgi?id=96499
714
715         Reviewed by Kenneth Rohde Christiansen.
716
717         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
718         And I have moved some parameters into User_Arguments.
719
720         * EWebLauncher/main.c:
721         (_User_Arguments):
722         (_ELauncher):
723         (on_key_down):
724         (browserCreate):
725         (findThemePath):
726         (parseUserArguments):
727         (main):
728
729 2012-09-13  Mark Lam  <mark.lam@apple.com>
730
731         Unreviewed. Adding myself to the committers list.
732
733         * Scripts/webkitpy/common/config/committers.py:
734
735 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
736
737         run-perf-tests output cryptic error when the config file is missing.
738         https://bugs.webkit.org/show_bug.cgi?id=96453
739
740         Reviewed by Tony Chang.
741
742         Add a special error message when a configuration file is missing.
743
744         Also update the help message of --source-json-path to signify the fact it specifies
745         the configuration file on performance tests bots.
746
747         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
748         (PerfTestsRunner._parse_args):
749         (PerfTestsRunner._generate_and_show_results):
750         (PerfTestsRunner._merge_slave_config_json):
751         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
752         (_test_run_with_json_output): Make upload to fail by default and assert the result
753         in the function so that we can return logs instead.
754         (_test_run_with_json_output.mock_upload_json):
755         (test_run_with_json_output):
756         (test_run_with_description):
757         (test_run_respects_no_results):
758         (test_run_with_slave_config_json):
759         (test_run_with_bad_slave_config_json):
760         (test_run_with_multiple_repositories):
761
762 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
763
764         Evas_Object* is a ref'ed structure, so tread it as such
765         https://bugs.webkit.org/show_bug.cgi?id=96659
766
767         Reviewed by Adam Barth.
768
769         Replace OwnPtr<Evas_Object> with RefPtr.
770
771         * DumpRenderTree/efl/ImageDiff.cpp:
772         (calculateDifference):
773         (printImageDifferences):
774         (readImageFromStdin):
775         (main):
776
777 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
778
779         One more unreviewed trivial fix after r128399.
780
781         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
782
783 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
784
785         Unreviewed trivial fix after r128399.
786
787         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
788         (getLatestSVNRevision):
789         (waitForSVNRevision):
790
791 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
792
793         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
794         https://bugs.webkit.org/show_bug.cgi?id=96366
795
796         Reviewed by Anders Carlsson.
797
798         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
799         by calling shouldClose() on the FrameLoader.
800
801         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
802         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
803         (WTR::TestRunner::callShouldCloseOnWebView):
804         (WTR):
805         * WebKitTestRunner/InjectedBundle/TestRunner.h:
806         (TestRunner):
807
808 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
809
810         Unreviewed, rolling out r128453.
811         http://trac.webkit.org/changeset/128453
812         https://bugs.webkit.org/show_bug.cgi?id=96681
813
814         Having tests use the same appcache directory leads to timeouts
815         (Requested by zdobersek on #webkit).
816
817         * DumpRenderTree/gtk/DumpRenderTree.cpp:
818         (runTest):
819         * Scripts/webkitpy/layout_tests/port/gtk.py:
820         (GtkPort.setup_environ_for_server):
821
822 2012-09-13  James Robinson  <jamesr@chromium.org>
823
824         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
825         https://bugs.webkit.org/show_bug.cgi?id=96678
826
827         Reviewed by Dirk Pranke.
828
829         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
830         (.):
831
832 2012-09-13  Rob Buis  <rbuis@rim.com>
833
834         Unreviewed changes to watchlist.
835
836         - Add myself to BlackBerry bugs
837
838         * Scripts/webkitpy/common/config/watchlist:
839
840 2012-09-13  Stephen Chenney  <schenney@chromium.org>
841
842         Add an SVG entry to the watchlist
843
844         Unreviewed config change.
845
846         * Scripts/webkitpy/common/config/watchlist:
847         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
848         - Added myself and pdr as watchers
849
850 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
851
852         [Qt] Make WebKit2 work on Windows with Qt 5
853         https://bugs.webkit.org/show_bug.cgi?id=76776
854
855         Reviewed by Tor Arne Vestbø.
856
857         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
858         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
859         that for the GL TextureMapper (it's only built when that feature is set).
860
861         * qmake/mkspecs/features/configure.prf:
862
863 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
864
865         [Qt] Ensure that QT is finalized before loading qt_module.prf
866
867         As qt_module.prf does dependency tracking based on the content of the
868         QT variable. The intermediate WebKit modules modify the variable in
869         their .pri files, so we have to ensure we've loaded all the modules
870         before loading qt_module.
871
872         Reviewed by Tor Arne Vestbø.
873         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
874
875         * qmake/mkspecs/features/default_post.prf:
876         * qmake/mkspecs/features/webkit_modules.prf: Added.
877
878 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
879
880         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
881         https://bugs.webkit.org/show_bug.cgi?id=96633
882
883         Reviewed by Csaba Osztrogonác.
884
885         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
886         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
887         It's the usual problem and the usual solution is to rename one of the conflicting files.
888         This patch chooses to rename DRT instead of WTR and MBR.
889
890         Fixed include order at the same time to match style guide.
891
892         * DumpRenderTree/qt/DumpRenderTree.pro:
893         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
894         (messageHandler):
895         (isOption):
896         (takeOptionValue):
897         (printUsage):
898         (main):
899
900 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
901
902         The Script run-launcher should support -2 in combination with --efl
903         https://bugs.webkit.org/show_bug.cgi?id=96639
904
905         Reviewed by Simon Hausmann.
906
907         Support running the MiniBrowser then supplied -2 as argument.
908
909         * Scripts/run-launcher:
910
911 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
912
913         Unreviewed, add my Intel email address to the list.
914
915         * Scripts/webkitpy/common/config/committers.py:
916
917 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
918
919         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
920
921         Reviewed by Ossy.
922
923         * qmake/mkspecs/features/default_post.prf:
924
925 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
926
927         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
928         https://bugs.webkit.org/show_bug.cgi?id=82294
929
930         Reviewed by Gyuyoung Kim.
931
932         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
933
934         * DumpRenderTree/efl/TestRunnerEfl.cpp:
935         (TestRunner::layerTreeAsText):
936
937 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
938
939         [GTK] Clear application cache between tests in DumpRenderTree
940         https://bugs.webkit.org/show_bug.cgi?id=96543
941
942         Reviewed by Philippe Normand.
943
944         Call the new DumpRenderTreeSupportGtk method to clear application cache
945         after each test.
946
947         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
948         as well. Currently it points to a subdirectory in the layout tests results
949         directory. At least on the builders this ensures an empty cache directory
950         with each test run.
951
952         * DumpRenderTree/gtk/DumpRenderTree.cpp:
953         (runTest):
954         * Scripts/webkitpy/layout_tests/port/gtk.py:
955         (GtkPort.setup_environ_for_server):
956
957 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
958
959         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
960
961         Unless it's actually a dependency of the public QtWebKit API.
962
963         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
964         files with their _PRIVATE equivivalent, but that's likely to break when
965         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
966         clean up the variables in default_post.
967
968         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
969         longer needed, as it was a workaround for the intermediate libraries ending
970         up in the prl file. And, since CONFIG -= staticlib was there to support
971         the explicitlib option, we can remove that too (as well as the exception
972         for gprof, since it would be empty). If gprof needs tweaks to always link
973         statically they should go in gprof.prf.
974
975         Reviewed by Simon Hausmann.
976
977         * qmake/mkspecs/features/default_post.prf:
978         * qmake/mkspecs/features/functions.prf:
979
980 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
981
982         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
983         https://bugs.webkit.org/show_bug.cgi?id=96632
984
985         Reviewed by Carlos Garcia Campos.
986
987         Fix this by using atk_object_get_n_accessible_children instead of
988         calling getChildren() from childCount.
989
990         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
991         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
992         loop by using atk_object_get_n_accessible_children().
993
994 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
995
996         [Qt][Win] Enable USE(3D_GRAPHICS)
997         https://bugs.webkit.org/show_bug.cgi?id=90879
998
999         Reviewed by Kenneth Rohde Christiansen.
1000
1001         Enable it on Windows as well as on QNX (bug fixed).
1002
1003         * qmake/mkspecs/features/features.prf:
1004
1005 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1006
1007         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
1008         https://bugs.webkit.org/show_bug.cgi?id=96359
1009
1010         Reviewed by Tor Arne Vestbø.
1011
1012         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
1013         lexer. The only viable alternative I could find on Windows that provides
1014         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
1015         so let's use that one instead.
1016
1017         * Scripts/webkitdirs.pm:
1018         (checkRequiredSystemConfig):
1019         * qmake/mkspecs/features/default_pre.prf:
1020
1021 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1022
1023         [Qt] Add configuration for production builds
1024         https://bugs.webkit.org/show_bug.cgi?id=96607
1025
1026         Reviewed by Kenneth Rohde Christiansen.
1027
1028         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
1029         and enable all-in-one-files optimizations.
1030
1031         * qmake/mkspecs/features/production_build.prf: Added.
1032
1033 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1034
1035         [Qt] GStreamer detection does not work when cross-compiling
1036         https://bugs.webkit.org/show_bug.cgi?id=96608
1037
1038         Reviewed by Kenneth Rohde Christiansen.
1039
1040         When cross-compiling it is not safe to just use system(pkg-config),
1041         because there is a high probability that it will find packages in the
1042         host system instead of in the target one. Instead use qmake's new
1043         packagesExist() function that takes care of this delicate aspect of
1044         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
1045         PKG_CONFIG_LIBDIR accordingly.
1046
1047         * qmake/mkspecs/features/features.prf:
1048
1049 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
1050
1051         [WK2][WTR] More efficient string handling in InjectedBundlePage
1052         https://bugs.webkit.org/show_bug.cgi?id=96609
1053
1054         Reviewed by Kenneth Rohde Christiansen.
1055
1056         Update StringBuilder usage in InjectedBundlePage to follow
1057         the latest recommandations for efficient string handling:
1058         http://trac.webkit.org/wiki/EfficientStrings
1059
1060         This involves using appendLiteral() or appendNumber()
1061         instead of append() whenever possible.
1062
1063         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1064         (WTR::dumpPath):
1065         (WTR::rangeToStr):
1066         (WTR::styleDecToStr):
1067         (WTR::frameToStr):
1068         (WTR::dumpResourceURL):
1069         (WTR):
1070         (WTR::dumpFrameDescriptionSuitableForTestResult):
1071         (WTR::dumpRequestDescriptionSuitableForTestResult):
1072         (WTR::dumpResponseDescriptionSuitableForTestResult):
1073         (WTR::dumpErrorDescriptionSuitableForTestResult):
1074         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1075         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1076         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1077         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1078         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1079         (WTR::InjectedBundlePage::didFinishProgress):
1080         (WTR::dumpFrameScrollPosition):
1081         (WTR::dumpFrameText):
1082         (WTR::dumpDescendantFramesText):
1083         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1084         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1085         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1086         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1087         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1088         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1089         (WTR::InjectedBundlePage::willSendRequestForFrame):
1090         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1091         (WTR::InjectedBundlePage::didFinishLoadForResource):
1092         (WTR::InjectedBundlePage::didFailLoadForResource):
1093         (WTR::InjectedBundlePage::shouldCacheResponse):
1094         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1095         (WTR::InjectedBundlePage::willAddMessageToConsole):
1096         (WTR::InjectedBundlePage::willSetStatusbarText):
1097         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1098         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1099         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1100         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1101         (WTR::InjectedBundlePage::shouldBeginEditing):
1102         (WTR::InjectedBundlePage::shouldEndEditing):
1103         (WTR::InjectedBundlePage::shouldInsertNode):
1104         (WTR::InjectedBundlePage::shouldInsertText):
1105         (WTR::InjectedBundlePage::shouldDeleteRange):
1106         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1107         (WTR::InjectedBundlePage::shouldApplyStyle):
1108         (WTR::InjectedBundlePage::didBeginEditing):
1109         (WTR::InjectedBundlePage::didEndEditing):
1110         (WTR::InjectedBundlePage::didChange):
1111         (WTR::InjectedBundlePage::didChangeSelection):
1112         (WTR::InjectedBundlePage::supportsFullScreen):
1113         (WTR::InjectedBundlePage::enterFullScreenForElement):
1114         (WTR::InjectedBundlePage::exitFullScreenForElement):
1115         (WTR::InjectedBundlePage::beganEnterFullScreen):
1116         (WTR::InjectedBundlePage::beganExitFullScreen):
1117         (WTR::InjectedBundlePage::closeFullScreen):
1118         (WTR::dumpBackForwardListItem):
1119         (WTR::InjectedBundlePage::dumpBackForwardList):
1120
1121 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1122
1123         [Qt][WK2] Memory leaks in Qt's TestRunner
1124         https://bugs.webkit.org/show_bug.cgi?id=96603
1125
1126         Reviewed by Csaba Osztrogonác.
1127
1128         Fix memory leaks in Qt's TestRunner code by adopting WKString
1129         created with WKStringCreateWithUTF8CString().
1130
1131         * WebKitTestRunner/qt/TestControllerQt.cpp:
1132         (WTR::TestController::initializeInjectedBundlePath):
1133         (WTR::TestController::initializeTestPluginDirectory):
1134
1135 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1136
1137         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
1138         https://bugs.webkit.org/show_bug.cgi?id=96506
1139
1140         Reviewed by Dirk Pranke.
1141
1142         Lower the timeout value to 6 seconds for release configuration and 12 seconds
1143         for debug configuration. These are the same values the Chromium port uses.
1144
1145         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
1146         the layout tests under WebKit2 generally) requires more attention and gardening
1147         than what the current effort produces.
1148
1149         The unit test is updated as well to test these changes.
1150
1151         * Scripts/webkitpy/layout_tests/port/gtk.py:
1152         (GtkPort.default_timeout_ms):
1153         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1154         (GtkPortTest.test_default_timeout_ms):
1155         (GtkPortTest.assertLinesEqual):
1156
1157 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
1158
1159         Add SVN mirror handling feature to build.webkit.org
1160         https://bugs.webkit.org/show_bug.cgi?id=85887
1161
1162         Reviewed by Dirk Pranke.
1163
1164         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
1165         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1166         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
1167         (ConfigureBuild.start):
1168         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
1169         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
1170         (Factory.__init__):
1171         (BuildFactory.__init__):
1172         (TestFactory.__init__):
1173         (BuildAndTestFactory.__init__):
1174         (BuildAndPerfTestFactory.__init__):
1175         (BuildAndPerfTestWebKit2Factory.__init__):
1176         (DownloadAndPerfTestFactory.__init__):
1177         (DownloadAndPerfTestWebKit2Factory.__init__):
1178         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
1179         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1180         (SVNMirrorTest):
1181         (SVNMirrorTest.setUp): Load config.json once at startup.
1182         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
1183         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
1184         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
1185         (getLatestSVNRevision): Get the latest SVN revison from the given server.
1186         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
1187                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
1188
1189 2012-09-12  Kangil Han  <kangil.han@samsung.com>
1190
1191         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
1192         https://bugs.webkit.org/show_bug.cgi?id=81606
1193
1194         Reviewed by Tim Horton.
1195
1196         6 seconds is harsh for some jquery test cases.
1197         Therefore, adjust the value to match DumpRenderTree.
1198
1199         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1200         (WTR):
1201
1202 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
1203
1204         [EFL] Support download attribute feature
1205         https://bugs.webkit.org/show_bug.cgi?id=96462
1206
1207         Reviewed by Gyuyoung Kim.
1208
1209         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
1210         and add "download,request" callback to the DumpRenderTree for EFL.
1211
1212         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1213         (DumpRenderTreeChrome::createView):
1214         (DumpRenderTreeChrome::onDownloadRequest):
1215         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1216         (DumpRenderTreeChrome):
1217         * Scripts/webkitperl/FeatureList.pm:
1218
1219 2012-09-12  Stephanie Lewis  <slewis@apple.com>
1220
1221         Reduce parallism on the wk2 testers.
1222         https://bugs.webkit.org/show_bug.cgi?id=95906
1223
1224         Reviewed by Dirk Pranke.
1225
1226         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
1227         resource contention.  Reducing the number of processes alleviates the issue.  
1228
1229         Starting by reducing 25%.
1230
1231         * Scripts/webkitpy/layout_tests/port/mac.py:
1232         (MacPort.default_child_processes):
1233
1234 2012-09-12  Brady Eidson  <beidson@apple.com>
1235
1236         Assert in NetscapePlugin::destroy() with async plugin init
1237         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
1238
1239         Reviewed by Anders Carlsson.
1240
1241         Expose NPN_Invoke to plug-in tests:
1242         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1243         (PluginTest::NPN_Invoke):
1244         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1245         (PluginTest):
1246
1247         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
1248         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
1249         (InvokeDestroysPluginWithinNPP_New):
1250         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
1251         (InvokeDestroysPluginWithinNPP_New::NPP_New):
1252         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1253
1254 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1255
1256         refactor TestExpectations tokenization slightly in preparation for the new syntax
1257         https://bugs.webkit.org/show_bug.cgi?id=96564
1258
1259         Reviewed by Ojan Vafai.
1260
1261         This change changes how we will tokenize/lex the
1262         TestExpectations files, in preparation for supporting both the
1263         old syntax and the new one. This change by itself should be a
1264         no-op.
1265
1266         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1267         (TestExpectationParser._tokenize_line):
1268         (TestExpectationParser):
1269         (TestExpectationParser._tokenize_line_using_old_format):
1270         (TestExpectationParser._tokenize_line_using_new_format):
1271
1272 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1273
1274         remove unused testexpectations editing code from webkitpy, garden-o-matic
1275         https://bugs.webkit.org/show_bug.cgi?id=96562
1276
1277         Reviewed by Adam Barth.
1278
1279         This code was prototyped but never fully realized. Removing
1280         until it reanimates :).
1281
1282         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1283         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1284         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
1285         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
1286         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1287         (BuildCoverageExtrapolator.extrapolate_test_configurations):
1288         (GardeningHTTPRequestHandler._run_webkit_patch):
1289         (GardeningHTTPRequestHandler.ping):
1290         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1291         (BuildCoverageExtrapolatorTest.test_extrapolate):
1292         (GardeningServerTest.test_rebaseline_new_port):
1293
1294 2012-09-12  Lucas Forschler  <lforschler@apple.com>
1295
1296         Remove unused bot, apple-xserve-1.
1297         https://bugs.webkit.org/show_bug.cgi?id=96570
1298         
1299         Reviewed by Stephanie Lewis.
1300
1301         * BuildSlaveSupport/build.webkit.org-config/config.json:
1302
1303 2012-09-12  Xan Lopez  <xlopez@igalia.com>
1304
1305         [GTK] We attempt to rebase documentation even if it's not present
1306         https://bugs.webkit.org/show_bug.cgi?id=96553
1307
1308         Reviewed by Martin Robinson.
1309
1310         Do not make the documentation rebase step fatal. This allows make
1311         install to succeed when there's no documentation generated.
1312
1313         * gtk/generate-gtkdoc:
1314
1315 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1316
1317         Respect WEBKITOUTPUTDIR when running EFL tests
1318         https://bugs.webkit.org/show_bug.cgi?id=96528
1319
1320         Reviewed by Dirk Pranke.
1321
1322         Expose user set WEBKITOUTPUTDIR to the web process.
1323
1324         * Scripts/webkitpy/layout_tests/port/driver.py:
1325         (Driver._start): Add WEBKITOUTPUTDIR to the environment
1326         of the web process and its potential jhbuild wrapper.
1327
1328 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1329
1330         webkitdirs: fix uname version handling for cygwin
1331         https://bugs.webkit.org/show_bug.cgi?id=96436
1332
1333         Reviewed by Jon Honeycutt.
1334
1335         Newer versions of cygwin embed an additional version string
1336         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
1337         Update the code to handle that.
1338
1339         * Scripts/webkitdirs.pm:
1340         (setupAppleWinEnv):
1341
1342 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1343
1344         Regression(r128338): Broke Windows build
1345         https://bugs.webkit.org/show_bug.cgi?id=96537
1346
1347         Unreviewed build fix.
1348
1349         Fix Apple-Win build by allocating array dynamically
1350         since its size is not constant.
1351
1352         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1353         (WTR::stringArrayToJS):
1354
1355 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
1356
1357         [chromium] Add a virtual test suite for fast/hidpi
1358         https://bugs.webkit.org/show_bug.cgi?id=90192
1359
1360         Reviewed by Dirk Pranke.
1361
1362         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
1363         on the hardware accelerated path as the software path.
1364
1365         * DumpRenderTree/chromium/WebPreferences.cpp:
1366         (WebPreferences::applyTo):
1367         * Scripts/webkitpy/layout_tests/port/chromium.py:
1368         (ChromiumPort.virtual_test_suites):
1369
1370 2012-09-12  Adam Klein  <adamk@chromium.org>
1371
1372         [chromium] Add content_browsertests to the flakiness dashboard
1373         https://bugs.webkit.org/show_bug.cgi?id=96535
1374
1375         Reviewed by Ojan Vafai.
1376
1377         * TestResultServer/static-dashboards/dashboard_base.js:
1378
1379 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1380
1381         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
1382         https://bugs.webkit.org/show_bug.cgi?id=96496
1383
1384         Reviewed by Kenneth Rohde Christiansen.
1385
1386         Add implementation for originsWithApplicationCache to
1387         WebKitTestRunner.
1388
1389         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1390         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1391         (WTR::stringArrayToJS):
1392         (WTR):
1393         (WTR::TestRunner::originsWithApplicationCache):
1394         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1395         (TestRunner):
1396
1397 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1398
1399         Fix Qt/Windows build with Python3
1400         https://bugs.webkit.org/show_bug.cgi?id=96473
1401
1402         Reviewed by Csaba Osztrogonác.
1403
1404         In Python 3 print is a real function, so we must use parentheses around
1405         the function parameters. This is backwards compatible with Python 2.
1406
1407         * Scripts/generate-win32-export-forwards:
1408
1409 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1410
1411         Unreviewed trivial build fix for Qt/Windows after bug #96358.
1412
1413         As pointed out by Kevin, we should inject the "set PATH=..." statement
1414         to add the GnuWin32 directory only if that directory actually exists.
1415
1416         * qmake/mkspecs/features/default_post.prf:
1417
1418 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1419
1420         [EFL] [WK2] Memory leaks in TestControllerEfl
1421         https://bugs.webkit.org/show_bug.cgi?id=96525
1422
1423         Reviewed by Kenneth Rohde Christiansen.
1424
1425         Fix memory leaks in EFL's TestRunner code by adopting an allocation
1426         of WKString created with WKStringCreateWithUTF8CString().
1427
1428         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1429         (WTR::TestController::initializeInjectedBundlePath):
1430         (WTR::TestController::initializeTestPluginDirectory):
1431
1432 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1433
1434         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1435         https://bugs.webkit.org/show_bug.cgi?id=96374
1436
1437         Reviewed by Kenneth Rohde Christiansen.
1438
1439         Implement support for dumpApplicationCacheDelegateCallbacks
1440         and disallowIncreaseForApplicationCacheQuota in
1441         WebKitTestRunner and properly dump the information
1442         expected by the tests.
1443
1444         If the application cache quota is reached for a given
1445         security origin, WebKitTestRunner will reset the quota
1446         to its default value, unless intructed not to via
1447         disallowIncreaseForApplicationCacheQuota().
1448
1449         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1450         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1451         (WTR::InjectedBundlePage::InjectedBundlePage):
1452         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1453         (WTR):
1454         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1455         (InjectedBundlePage):
1456         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1457         (WTR::TestRunner::TestRunner):
1458         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1459         (WTR):
1460         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1461         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1462         (TestRunner):
1463         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1464         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1465
1466 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1467
1468         [chromium] remove deprecated and unused sets import from chromium_android driver
1469         https://bugs.webkit.org/show_bug.cgi?id=96485
1470
1471         Reviewed by Dirk Pranke.
1472
1473         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1474
1475 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
1476
1477         Flakiness dashboard doesn't recognize new Chromium Android test builder
1478         https://bugs.webkit.org/show_bug.cgi?id=96523
1479
1480         Reviewed by Ojan Vafai.
1481
1482         Properly return 'ANDROID' as the Chromium platform for Android builders.
1483
1484         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1485         (chromiumPlatform):
1486         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1487         (test):
1488
1489 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1490
1491         [Qt] Build on Windows requires bison/flex in PATH
1492         https://bugs.webkit.org/show_bug.cgi?id=96358
1493
1494         Reviewed by Tor Arne Vestbø.
1495
1496         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
1497         and Linux that is rarely a problem given how easily available the tools are. On Windows however
1498         a separate installation of various GNU tools is required as the operating system doesn't come with
1499         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
1500         the gnuwin32 directory of the qt5.git top-level repository.
1501
1502         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
1503
1504         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
1505         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
1506         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
1507         updated with the new tool.
1508
1509         * Scripts/webkitdirs.pm:
1510         (checkRequiredSystemConfig):
1511         * qmake/mkspecs/features/default_post.prf:
1512
1513 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1514
1515         [Qt] Update build-jsc after r128174
1516
1517         Reviewed by Ossy.
1518
1519         * Scripts/build-jsc:
1520
1521 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1522
1523         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
1524
1525         By hard-coding the names of the targets we defined we ended up just
1526         redefining the previous target when using addStrictSubdirOrderBetween
1527         more than once in a single project file.
1528
1529         We now embed the two base targets into the target names.
1530
1531         Reviewed by Simon Hausmann.
1532
1533         * qmake/mkspecs/features/functions.prf:
1534
1535 2012-09-12  Philippe Liard  <pliard@google.com>
1536
1537         Depend on {base,net} GYP targets rather than {base,net}_java.
1538         https://bugs.webkit.org/show_bug.cgi?id=95690
1539
1540         Reviewed by Adam Barth.
1541
1542         {base,net}_java became 'private' targets on the Chromium side that
1543         clients should not depend on (see
1544         https://chromiumcodereview.appspot.com/10913083/).
1545         This removes a bunch of trailing white spaces additionally in
1546         TestWebkitAPI.gyp (which includes non-trailing white space changes).
1547
1548         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1549         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1550
1551 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1552
1553         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
1554         https://bugs.webkit.org/show_bug.cgi?id=96494
1555
1556         Reviewed by Tor Arne Vestbø.
1557
1558         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
1559         plugin process feature if we don't have NPAPI.
1560
1561         * qmake/mkspecs/features/features.prf:
1562
1563 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1564
1565         Unreviewed, rolling out r128280.
1566         http://trac.webkit.org/changeset/128280
1567         https://bugs.webkit.org/show_bug.cgi?id=96498
1568
1569         it broke compilation on windows debug bot (Requested by loislo
1570         on #webkit).
1571
1572         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1573         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1574         (WTR::InjectedBundlePage::InjectedBundlePage):
1575         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1576         (InjectedBundlePage):
1577         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1578         (WTR::TestRunner::TestRunner):
1579         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1580         (TestRunner):
1581
1582 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1583
1584         [Qt] Make it possible to build with "make release" and "make debug" on Windows
1585         https://bugs.webkit.org/show_bug.cgi?id=96488
1586
1587         Reviewed by Tor Arne Vestbø.
1588
1589         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
1590         because there are no such targets. We want the generated sources to be independent from release
1591         or debug build configurations, so it is sufficient to provide fake debug and release targets that
1592         redirect to the same general-purpose target (first) of creating the derived sources.
1593
1594         * qmake/mkspecs/features/default_post.prf:
1595
1596 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1597
1598         [EFL] Make DumpRenderTree smarter at finding the fonts
1599         http://webkit.org/b/96281
1600
1601         Reviewed by Gyuyoung Kim.
1602
1603         Respect WEBKITOUTPUTDIR and expand the font dir from it.
1604         Use CString consistently.
1605
1606         * DumpRenderTree/efl/FontManagement.cpp:
1607         (buildPath):
1608         (getCoreFontFiles):
1609         (addFontDirectory):
1610         (addFontFiles):
1611         (getCustomBuildDir):
1612         (getPlatformFontsPath):
1613         (addFontsToEnvironment):
1614
1615 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1616
1617         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1618         https://bugs.webkit.org/show_bug.cgi?id=96374
1619
1620         Reviewed by Kenneth Rohde Christiansen.
1621
1622         Implement support for dumpApplicationCacheDelegateCallbacks
1623         and disallowIncreaseForApplicationCacheQuota in
1624         WebKitTestRunner and properly dump the information
1625         expected by the tests.
1626
1627         If the application cache quota is reached for a given
1628         security origin, WebKitTestRunner will reset the quota
1629         to its default value, unless intructed not to via
1630         disallowIncreaseForApplicationCacheQuota().
1631
1632         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1633         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1634         (WTR::InjectedBundlePage::InjectedBundlePage):
1635         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1636         (WTR):
1637         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1638         (InjectedBundlePage):
1639         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1640         (WTR::TestRunner::TestRunner):
1641         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1642         (WTR):
1643         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1644         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1645         (TestRunner):
1646         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1647         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1648
1649 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1650
1651         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
1652         https://bugs.webkit.org/show_bug.cgi?id=96388
1653
1654         Reviewed by Kenneth Rohde Christiansen.
1655
1656         Exported TestRunner.workerThreadCount as readonly attribute.
1657
1658         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1659         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
1660         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
1661         (WTR):
1662         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
1663         (TestRunner):
1664
1665 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1666
1667         [chromium] Consume a user gesture when creating a new view.
1668         https://bugs.webkit.org/show_bug.cgi?id=96373
1669
1670         Reviewed by Adam Barth.
1671
1672         * DumpRenderTree/chromium/WebViewHost.cpp:
1673         (WebViewHost::createView):
1674
1675 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1676
1677         [WK2][WTR] Some of TestRunner special options are not reset before testing
1678         https://bugs.webkit.org/show_bug.cgi?id=96384
1679
1680         Reviewed by Kenneth Rohde Christiansen.
1681
1682         Now values of the following special options are reset:
1683         void setAcceptsEditing(in boolean value);
1684         void setCloseRemainingWindowsWhenComplete(in boolean value);
1685         void setXSSAuditorEnabled(in boolean value);
1686         void setAllowFileAccessFromFileURLs(in boolean value);
1687         void setPluginsEnabled(in boolean value);
1688         void setPopupBlockingEnabled(in boolean value);
1689
1690         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1691         (WTR::InjectedBundle::beginTesting):
1692
1693 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
1694
1695         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
1696         https://bugs.webkit.org/show_bug.cgi?id=96273
1697
1698         Reviewed by Gyuyoung Kim.
1699
1700         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
1701         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
1702
1703         * WebKitTestRunner/CMakeLists.txt:
1704
1705 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
1706
1707         [chromium] rename webkit_resources
1708         https://bugs.webkit.org/show_bug.cgi?id=95874
1709
1710         Reviewed by James Robinson.
1711
1712         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1713
1714 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
1715
1716         [chromium] don't include content shell builders in the garden-o-matic view
1717         https://bugs.webkit.org/show_bug.cgi?id=96418
1718
1719         Reviewed by James Robinson.
1720
1721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1722
1723 2012-09-11  Adam Klein  <adamk@chromium.org>
1724
1725         Garden-o-matic should ignore a wider variety of warnings in buildbot json
1726         https://bugs.webkit.org/show_bug.cgi?id=96411
1727
1728         Reviewed by Adam Barth.
1729
1730         Previously only the exact string "warning" was treated as a warning
1731         result. This patch treats any string with "warning" as a substring
1732         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
1733
1734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1735         (.):
1736         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1737
1738 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
1739
1740         Restore original value of mock scrollbars enabled in InternalSettings
1741         https://bugs.webkit.org/show_bug.cgi?id=87680
1742
1743         Reviewed by Adam Barth.
1744
1745         Added backup support for mock scrollbars state in
1746         InternalSettings::Backup, and removed support for these
1747         from Qt's DumpRenderTree.
1748
1749         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1750         (WebCore::WebPage::resetSettings):
1751         * DumpRenderTree/qt/TestRunnerQt.cpp:
1752         (TestRunner::setFrameFlatteningEnabled):
1753         * DumpRenderTree/qt/TestRunnerQt.h:
1754         (TestRunner):
1755
1756 2012-09-11  Dan Bernstein  <mitz@apple.com>
1757
1758         Fixed a bug where kill-old-processes failed to kill clang++.
1759
1760         Rubber-stamped by Alexey Proskuryakov.
1761
1762         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
1763         where it is passed as a regular expression to killall.
1764
1765 2012-09-11  Philippe Liard  <pliard@google.com>
1766
1767         Make sure that md5sum is not setup on non-Chromium Android platforms.
1768         https://bugs.webkit.org/show_bug.cgi?id=96393
1769
1770         Reviewed by Adam Barth.
1771
1772         Previously md5sum was setup in ChromiumAndroidDriver's constructor
1773         which is also invoked on non-Chromium Android platforms. The following patch
1774         moves this logic to _startup_test() which is guaranteed to be invoked
1775         only on Android.
1776
1777         This also updates the prompt unit test in chromium_android_unittest.py.
1778
1779         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1780         (ChromiumAndroidDriver.__init__):
1781         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1782         (ChromiumAndroidDriver._setup_test):
1783
1784 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
1785
1786         [EFL] Rewrite the EFL-related Find modules
1787         https://bugs.webkit.org/show_bug.cgi?id=95237
1788
1789         Reviewed by Kenneth Rohde Christiansen.
1790
1791         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
1792         property and include all the Enlightenment Foundation Libraries
1793         required by the target.
1794         * EWebLauncher/CMakeLists.txt: Ditto.
1795         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1796         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
1797         now that they are not added implicitly.
1798         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
1799         property.
1800         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
1801         property and include all the Enlightenment Foundation Libraries
1802         required by the target.
1803
1804 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1805
1806         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
1807         https://bugs.webkit.org/show_bug.cgi?id=96379
1808
1809         Reviewed by Kenneth Rohde Christiansen.
1810
1811         Add implementation for setApplicationCacheOriginQuota
1812         to WebKitTestRunner.
1813
1814         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1815         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1816         (WTR::TestRunner::setApplicationCacheOriginQuota):
1817         (WTR):
1818         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1819         (TestRunner):
1820
1821 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
1822
1823         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
1824         https://bugs.webkit.org/show_bug.cgi?id=91988
1825
1826         Reviewed by Kenneth Rohde Christiansen.
1827
1828         Regular key events generated by Qt for the tab key fill both
1829         keyCode and keyText, so we should do the same for our fake events.
1830
1831         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1832         (WTR::EventSenderProxy::keyDown):
1833
1834 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1835
1836         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
1837         https://bugs.webkit.org/show_bug.cgi?id=96269
1838
1839         Reviewed by Kenneth Rohde Christiansen.
1840
1841         Exported missing testRunner.setSpatialNavigationEnabled() method.
1842
1843         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1844         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1845         (WTR::InjectedBundle::beginTesting):
1846         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1847         (WTR::TestRunner::setSpatialNavigationEnabled):
1848         (WTR):
1849         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1850         (TestRunner):
1851
1852 2012-09-11  Philippe Liard  <pliard@chromium.org>
1853
1854         Support LayoutTests on non-rooted devices for Chromium Android.
1855         https://bugs.webkit.org/show_bug.cgi?id=95346
1856
1857         Reviewed by Dirk Pranke.
1858
1859         We were requiring root permissions to sync resource files with the
1860         device by comparing host and device files' timestamp after we
1861         synchronized the device and host clocks.
1862         We now rely on md5sum provided by Chromium to handle data files
1863         synchronization.
1864
1865         * Scripts/webkitpy/layout_tests/port/chromium.py:
1866         (ChromiumPort._check_driver_build_up_to_date):
1867         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1868         (ChromiumAndroidDriver.__init__):
1869         (ChromiumAndroidDriver._setup_test):
1870         (ChromiumAndroidDriver._push_executable):
1871         (ChromiumAndroidDriver._push_test_resources):
1872         (ChromiumAndroidDriver._read_prompt):
1873
1874 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
1875
1876         [Qt] Fix output paths on Windows
1877
1878         Reviewed by Tor Arne Vestbø.
1879
1880         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
1881         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
1882         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
1883         incorrect here and instead for the calculation we should use forward slashes.
1884
1885         * qmake/mkspecs/features/default_pre.prf:
1886
1887 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1888
1889         [Qt] Fix passing of defines from the build system
1890
1891         We explicitly have to pass -DENABLE_FOO=0 for every single feature
1892         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
1893         will add it's own defaults if the features are not defined.
1894
1895         At some point we might want to run a configure-test to inspect what
1896         Platform.h will do, so we can sync up the build system's view of
1897         the feature-defines with the compile-time situation.
1898
1899         Reviewed by Simon Hausmann.
1900
1901         * qmake/mkspecs/features/functions.prf:
1902
1903 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1904
1905         [Qt] Fix --qt option to build-webkit
1906
1907         Reviewed by Ossy.
1908
1909         * Scripts/webkitdirs.pm:
1910         (buildQMakeProjects):
1911
1912 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1913
1914         [Qt] Add a configure step to the Qt build system
1915
1916         This allows building the Qt port using just 'qmake WebKit.pro'. Using
1917         the build-webkit script is still supported, and will add slightly more
1918         logic to the build, such as detecting the need for clean or incremental
1919         builds.
1920
1921         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
1922         all things related to configuring the build, such as use/have/enable flags,
1923         and these are translated to defines in default_post. Project files should
1924         no longer check contains(DEFINES,...) to detect features, but use the new
1925         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
1926         options have been translated into WEBKIT_CONFIG options as well, and can
1927         be checked using build?().
1928
1929         Reviewed by Simon Hausmann.
1930
1931         * DumpRenderTree/qt/DumpRenderTree.pro:
1932         * MiniBrowser/qt/MiniBrowser.pro:
1933         * QtTestBrowser/QtTestBrowser.pro:
1934         * Scripts/build-webkit:
1935         * Scripts/webkitdirs.pm:
1936         (qtFeatureDefaults):
1937         (buildQMakeProjects):
1938         * Tools.pro:
1939         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1940         * WebKitTestRunner/InjectedBundle/Target.pri:
1941         * WebKitTestRunner/Target.pri:
1942         * qmake/.qmake.cache: Added.
1943         * qmake/configure.pri: Removed.
1944         * qmake/configure.pro: Removed.
1945         * qmake/dump-features: Added.
1946         * qmake/mkspecs/features/configure.prf: Added.
1947         * qmake/mkspecs/features/default_post.prf:
1948         * qmake/mkspecs/features/default_pre.prf:
1949         * qmake/mkspecs/features/features.prf:
1950         * qmake/mkspecs/features/features.pri:
1951         * qmake/mkspecs/features/functions.prf:
1952         * qmake/mkspecs/features/gprof.prf:
1953         * qmake/mkspecs/features/mac/default_pre.prf:
1954         * qmake/mkspecs/features/win32/default_pre.prf:
1955
1956 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1957
1958         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
1959         https://bugs.webkit.org/show_bug.cgi?id=96372
1960
1961         Reviewed by Kenneth Rohde Christiansen.
1962
1963         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
1964
1965         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1966         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1967         (WTR::TestRunner::clearApplicationCacheForOrigin):
1968         (WTR):
1969         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1970         (TestRunner):
1971
1972 2012-09-11  Peter Beverloo  <peter@chromium.org>
1973
1974         Don't ignore .pak files when making an archive for Android
1975         https://bugs.webkit.org/show_bug.cgi?id=96375
1976
1977         Reviewed by Jochen Eisinger.
1978
1979         The .pak files do need to be pushed to the device, which is currently
1980         preventing the layout test runner from correctly pushing all files.
1981
1982         * BuildSlaveSupport/built-product-archive:
1983         (archiveBuiltProduct):
1984
1985 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1986
1987         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
1988         https://bugs.webkit.org/show_bug.cgi?id=96256
1989
1990         Reviewed by Kenneth Rohde Christiansen.
1991
1992         Exported TestRunner::setMinimumTimerInterval() method.
1993
1994         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1995         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1996         (WTR::InjectedBundle::beginTesting):
1997         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1998         (WTR::TestRunner::setMinimumTimerInterval):
1999         (WTR):
2000         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2001         (TestRunner):
2002
2003 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
2004
2005         MediaStream API: add RTCPeerConnection::onnegotiationneeded
2006         https://bugs.webkit.org/show_bug.cgi?id=96097
2007
2008         Reviewed by Adam Barth.
2009
2010         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2011         (MockWebRTCPeerConnectionHandler::addStream):
2012         (MockWebRTCPeerConnectionHandler::removeStream):
2013
2014 2012-09-11  Peter Beverloo  <peter@chromium.org>
2015
2016         Recognize the "--chromium-android" argument in run-webkit-tests
2017         https://bugs.webkit.org/show_bug.cgi?id=96369
2018
2019         Reviewed by Jochen Eisinger.
2020
2021         Chromium for the Android platform cannot determine the platform based on
2022         the host itself, so we'll use the --chromium-android argument as the build
2023         master passes to run-webkit-tests. Make sure the layout test runner
2024         can pick the right port when doing so.
2025
2026         * Scripts/run-webkit-tests:
2027         * Scripts/webkitpy/layout_tests/port/factory.py:
2028         (port_options):
2029
2030 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2031
2032         [QT] Fix build with newer qmake from Qt 5
2033
2034         Rubber-stamped by Tor Arne Vestbø.
2035
2036         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
2037         it with the use of QT_HOST_DATA/mkspecs.
2038         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
2039
2040         * Scripts/webkitdirs.pm:
2041         (builtDylibPathForName):
2042         (qtMakeCommand):
2043
2044 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2045
2046         [Qt] Remove Qt 4 syncqt, no longer needed
2047
2048         Reviewed by Simon Hausmann.
2049
2050         * qmake/syncqt-4.8: Removed.
2051
2052 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
2053
2054         [Qt][WK2] Fix the build with recent Qt5
2055         https://bugs.webkit.org/show_bug.cgi?id=96283
2056
2057         Reviewed by Simon Hausmann.
2058
2059         We should not use deprecated Qt API because doing that results
2060         in build failure since all the deprecated API was disabled
2061         in qtbase (https://codereview.qt-project.org/#change,24890).
2062
2063         * DumpRenderTree/qt/main.cpp:
2064         (main):
2065         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2066         (MiniBrowserApplication::notify):
2067         * MiniBrowser/qt/raw/View.cpp:
2068         (View::exposeEvent):
2069         (main):
2070
2071 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2072
2073         WTR needs an implementation of applicationCacheDiskUsageForOrigin
2074         https://bugs.webkit.org/show_bug.cgi?id=87188
2075
2076         Reviewed by Kenneth Rohde Christiansen.
2077
2078         Add implementation for applicationCacheDiskUsageForOrigin()
2079         in WebKitTestRunner.
2080
2081         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2082         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2083         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
2084         (WTR):
2085         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2086         (TestRunner):
2087
2088 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
2089
2090         Properly expose <legend> elements to ATs
2091         https://bugs.webkit.org/show_bug.cgi?id=84137
2092
2093         Reviewed by Chris Fleizach.
2094
2095         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
2096         the expected platform role, ATK_ROLE_LABEL. Also established the needed
2097         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
2098
2099         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2100         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
2101
2102 2012-09-10  Jer Noble  <jer.noble@apple.com>
2103
2104         Unreviewed; rolling out r128081.
2105         http://trac.webkit.org/changeset/128081
2106         https://bugs.webkit.org/show_bug.cgi?id=96134
2107
2108         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
2109
2110         * DumpRenderTree/TestRunner.cpp:
2111         (TestRunner::TestRunner):
2112         (TestRunner::staticFunctions):
2113         * DumpRenderTree/TestRunner.h:
2114         (TestRunner):
2115         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2116         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2117         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2118         (WTR::InjectedBundlePage::InjectedBundlePage):
2119         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2120         (InjectedBundlePage):
2121         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2122         (WTR::TestRunner::TestRunner):
2123         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2124         (TestRunner):
2125
2126 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2127
2128         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
2129         https://bugs.webkit.org/show_bug.cgi?id=96205
2130
2131         Reviewed by Tony Chang.
2132
2133         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
2134         internally, which means that it would support only 1 TestExpectations file per port. This
2135         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
2136         and efl-wk1 -> efl).
2137
2138         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
2139         instead so that all the ports TestExpectations are recognized. The ports are also
2140         constructed twice, with "webkit_test_runner" option set to True and False so that we
2141         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
2142
2143         * Scripts/webkitpy/style/checkers/test_expectations.py:
2144         (TestExpectationsChecker._determine_port_from_expectations_path):
2145         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
2146         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2147
2148 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
2149
2150         [WTR] Generated source files should include config.h
2151         https://bugs.webkit.org/show_bug.cgi?id=96254
2152
2153         Reviewed by Benjamin Poulain.
2154
2155         Current coding style has encouraged to include config.h at the first position,
2156         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
2157         this rule.
2158         Therefore, this patch added it.
2159
2160         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2161         (_generateImplementationFile):
2162
2163 2012-09-10  Rick Byers  <rbyers@chromium.org>
2164
2165         Add handling of new GestureTapCancel in DRT
2166         
2167         https://bugs.webkit.org/show_bug.cgi?id=96183
2168
2169         Reviewed by Adam Barth.
2170
2171         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2172         (TestWebPlugin::handleInputEvent):
2173
2174 2012-09-10  Brady Eidson  <beidson@apple.com>
2175
2176         Javascript in foreground tabs should not wait synchronously for plug-ins to load
2177         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
2178
2179         Reviewed by Geoff Garen.
2180
2181         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
2182
2183         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
2184         (PluginObject):
2185         (SlowNPPNew::PluginObject::PluginObject):
2186         (SlowNPPNew::PluginObject::~PluginObject):
2187         (SlowNPPNew::PluginObject::hasProperty):
2188         (SlowNPPNew::PluginObject::getProperty):
2189         (SlowNPPNew::NPP_GetValue):
2190         (SlowNPPNew):
2191
2192 2012-09-10  Tim Horton  <timothy_horton@apple.com>
2193
2194         WKTR often reports an unresponsive WebProcess on Mac bots
2195         https://bugs.webkit.org/show_bug.cgi?id=95906
2196
2197         Reviewed by Dan Bernstein.
2198
2199         Attempt to work around resource contention issues by increasing the NRWT
2200         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
2201
2202         * Scripts/webkitpy/layout_tests/port/base.py:
2203         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
2204         * WebKitTestRunner/TestController.cpp:
2205         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
2206
2207 2012-09-07  Jer Noble  <jer.noble@apple.com>
2208
2209         <audio> and <video> should send Do Not Track when appropriate
2210         https://bugs.webkit.org/show_bug.cgi?id=96134
2211
2212         Reviewed by Eric Carlson.
2213
2214         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
2215         WTR. Add FrameLoaderClient client methods for retrieving that value.
2216
2217         * DumpRenderTree/TestRunner.cpp:
2218         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
2219         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
2220         * DumpRenderTree/TestRunner.h:
2221         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
2222         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2223         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2224         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
2225             Pass the question on to the TestRunner.
2226         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2227         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2228         (WTR::InjectedBundlePage::InjectedBundlePage):
2229             Add the setShouldSendDoNotTrackHTTPHeader client function.
2230         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
2231             Pass the question on to the TestRunner.
2232         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2233         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2234         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2235         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2236         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
2237
2238 2012-09-10  Ojan Vafai  <ojan@chromium.org>
2239
2240         Make EFL bots work on the flakiness dashboard
2241         https://bugs.webkit.org/show_bug.cgi?id=96164
2242
2243         Reviewed by Tony Chang.
2244
2245         Also, update outdated unittests that had started failing.
2246
2247         * TestResultServer/static-dashboards/builders.js:
2248         (isWebkitTestRunner):
2249         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2250         (nonChromiumPlatform):
2251         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2252         (test):
2253
2254 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
2255
2256         [chromium] MediaStream API: Remove the Descriptor postfix
2257         https://bugs.webkit.org/show_bug.cgi?id=96268
2258
2259         Reviewed by Adam Barth.
2260
2261         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
2262         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
2263
2264         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2265         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2266         (MockWebRTCPeerConnectionHandler::createOffer):
2267         (MockWebRTCPeerConnectionHandler::createAnswer):
2268         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2269         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2270         (MockWebRTCPeerConnectionHandler::localDescription):
2271         (MockWebRTCPeerConnectionHandler::remoteDescription):
2272         (MockWebRTCPeerConnectionHandler::addICECandidate):
2273         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2274         (MockWebRTCPeerConnectionHandler):
2275
2276 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
2277
2278         [Gtk] failure to build jhbuild dependencies with cups 1.6
2279         https://bugs.webkit.org/show_bug.cgi?id=95991
2280
2281         Reviewed by Gustavo Noronha Silva.
2282
2283         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
2284         building with cups >= 1.6 [GNOME #670373].
2285
2286         * gtk/jhbuild.modules:
2287
2288 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2289
2290         [EFL][DRT] Encoding issue in printed console messages
2291         https://bugs.webkit.org/show_bug.cgi?id=96263
2292
2293         Reviewed by Kenneth Rohde Christiansen.
2294
2295         Correctly handle CONSOLE messages that contain non-ascii
2296         characters in EFL's DRT. We need to use String::fromUTF8()
2297         to construct a WTF::String from a raw string.
2298
2299         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2300         (onConsoleMessage):
2301
2302 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2303
2304         [WK2][WTR] User style sheet location should be reset before each test
2305         https://bugs.webkit.org/show_bug.cgi?id=96262
2306
2307         Reviewed by Kenneth Rohde Christiansen.
2308
2309         User style sheet location is reset before each test now.
2310
2311         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2312         (WTR::InjectedBundle::beginTesting):
2313
2314 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
2315
2316         Fix build of WTR with Qt on Windows
2317         https://bugs.webkit.org/show_bug.cgi?id=96249
2318
2319         Reviewed by Kenneth Rohde Christiansen.
2320
2321         Windows loves to define min and max as macros, which beautifully
2322         clashes in many places where min and max are used as variable or method
2323         names. It can be convinced not to do this when min and max are already
2324         define as macros (expanding to themselves). We have this kind of
2325         workaround in config.h files all over WebKit and as it turns out when
2326         building WTR with Qt on Windows we do end up with such a clash. Therefore
2327         we need the same workaround.
2328
2329         * WebKitTestRunner/config.h:
2330
2331 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2332
2333         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
2334         https://bugs.webkit.org/show_bug.cgi?id=95936
2335
2336         Reviewed by Kenneth Rohde Christiansen.
2337
2338         Enable interactive form validation setting in WebKitTestRunner as
2339         we are currently doing in DumpRenderTree. This is needed for some
2340         tests to pass.
2341
2342         * WebKitTestRunner/TestController.cpp:
2343         (WTR::TestController::resetStateToConsistentValues):
2344
2345 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
2346
2347         Clean up the code in XvfbDriver
2348         https://bugs.webkit.org/show_bug.cgi?id=96202
2349
2350         Reviewed by Philippe Normand.
2351
2352         Changes:
2353         - Remove unneeded imports,
2354         - assign the _lock_file member variable when the display number is determined,
2355         - no need for parentheses around a single string format argument,
2356         - use FileSystem.exists method when checking if lock file is present as it
2357         makes the intention much more clearer.
2358
2359         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2360         (XvfbDriver._start):
2361         (XvfbDriver.stop):
2362
2363 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
2364
2365         Make the String initialization on the function side of String::number()
2366         https://bugs.webkit.org/show_bug.cgi?id=95940
2367
2368         Reviewed by Benjamin Poulain.
2369
2370         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2371         (testBoundaries):
2372         (testNumbers):
2373
2374 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
2375
2376         [WK2] expose element rect for color input type
2377         https://bugs.webkit.org/show_bug.cgi?id=91664
2378
2379         Reviewed by Simon Hausmann.
2380
2381         Update the QML logic in MiniBrowser to take advantage of this.
2382         The picker size is now hardcoded and we try to place it below the
2383         input element if possible.
2384
2385         * MiniBrowser/qt/qml/ColorChooser.qml:
2386
2387 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
2388
2389         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
2390         https://bugs.webkit.org/show_bug.cgi?id=95329
2391
2392         Reviewed by Kenneth Rohde Christiansen.
2393
2394         Explicitely disable TabToLinks setting in WebKitTestRunner.
2395         Tests override the "WebKitTabToLinksPreferenceKey" preference
2396         to enable it.
2397
2398         * WebKitTestRunner/TestController.cpp:
2399         (WTR::TestController::resetStateToConsistentValues):
2400
2401 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
2402
2403         webkit.py gdb pretty printer can't print CString
2404         https://bugs.webkit.org/show_bug.cgi?id=96068
2405
2406         Reviewed by Tony Chang.
2407
2408         Update WTFCStringPrinter to follow r126191.
2409
2410         * gdb/webkit.py:
2411         (WTFCStringPrinter.to_string):
2412
2413 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
2414
2415         Rename the ustring() accessor to string()
2416         https://bugs.webkit.org/show_bug.cgi?id=95919
2417
2418         Reviewed by Geoffrey Garen.
2419
2420         Update EFL's DRT.
2421
2422         Fix some string conversion that have been made useless
2423         with recent changes.
2424
2425         * DumpRenderTree/efl/EventSender.cpp:
2426         (keyPadNameFromJSValue):
2427         (keyNameFromJSValue):
2428         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2429         (TestRunner::queueLoad):
2430         (TestRunner::addOriginAccessWhitelistEntry):
2431         (TestRunner::removeOriginAccessWhitelistEntry):
2432         (TestRunner::setUserStyleSheetLocation):
2433         (TestRunner::setValueForUser):
2434         (TestRunner::elementDoesAutoCompleteForElementWithId):
2435         (TestRunner::execCommand):
2436         (TestRunner::findString):
2437         (TestRunner::isCommandEnabled):
2438         (TestRunner::clearApplicationCacheForOrigin):
2439         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2440         (TestRunner::pauseAnimationAtTimeOnElementWithId):
2441         (TestRunner::pauseTransitionAtTimeOnElementWithId):
2442         (toInt):
2443         (TestRunner::overridePreference):
2444         (TestRunner::addUserScript):
2445         (TestRunner::addUserStyleSheet):
2446         (TestRunner::evaluateInWebInspector):
2447         (TestRunner::evaluateScriptInIsolatedWorld):
2448         (TestRunner::setTextDirection):
2449         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2450         (LoadItem::invoke):
2451         (LoadHTMLStringItem::invoke):
2452         (ScriptItem::invoke):
2453
2454 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
2455
2456         Extend third-party storage blocking API to optionally allow blocking all storage
2457         https://bugs.webkit.org/show_bug.cgi?id=95915
2458
2459         Reviewed by Brady Eidson.
2460
2461         Modified API test to use new revised API.
2462
2463         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2464         (TestWebKitAPI::TEST):
2465
2466 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2467
2468         AX: WebCore accessibility roles should be cross-platform
2469         https://bugs.webkit.org/show_bug.cgi?id=94870
2470
2471         Reviewed by Chris Fleizach.
2472
2473         Add debug strings to Chromium for new accessibility roles.
2474
2475         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2476         (roleToString):
2477
2478 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2479
2480         AX: Chromium needs access to canvasHasFallbackContent
2481         https://bugs.webkit.org/show_bug.cgi?id=96124
2482
2483         Reviewed by Chris Fleizach.
2484
2485         Distinguish between canvas roles with and without fallback
2486         content on Chromium.
2487
2488         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2489         (getRole):
2490
2491 2012-09-07  Ojan Vafai  <ojan@chromium.org>
2492
2493         Handle non-existant TestExpectations files gracefully
2494         https://bugs.webkit.org/show_bug.cgi?id=96149
2495
2496         Reviewed by Eric Seidel.
2497
2498         Even when we get rid of Skipped files, we shouldn't have each port
2499         require a TestExpectations file for each platform if it doesn't
2500         need one.
2501
2502         * Scripts/webkitpy/layout_tests/port/base.py:
2503         (Port.expectations_dict):
2504         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2505         (PortTest.test_nonexistant_expectations):
2506
2507 2012-09-07  Tony Chang  <tony@chromium.org>
2508
2509         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
2510         https://bugs.webkit.org/show_bug.cgi?id=96136
2511
2512         Reviewed by Ojan Vafai.
2513
2514         When we renamed the file to TestExpectations, it was no longer considered a text file so
2515         it was no longer being checked. Since then, test_expectations_overrides() has been removed
2516         from the port object, so I've removed that from the check. I'm not sure what it was
2517         supposed to do.
2518
2519         * Scripts/webkitpy/style/checker.py:
2520         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
2521         * Scripts/webkitpy/style/checkers/test_expectations.py:
2522         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
2523         (TestExpectationsChecker.check): Remove overrides param.
2524         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2525         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
2526
2527 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2528
2529         [EFL] Use same default minimum logical font size in DRT and WTR
2530         https://bugs.webkit.org/show_bug.cgi?id=96116
2531
2532         Reviewed by Martin Robinson.
2533
2534         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2535         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
2536         logical font size to 9 to match the value used in WTR.
2537         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2538         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
2539         logical font size to 9 (default value in WK2)
2540
2541 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
2542
2543         MediaStream API: add RTCPeerConnection::createAnswer
2544         https://bugs.webkit.org/show_bug.cgi?id=96092
2545
2546         Reviewed by Adam Barth.
2547
2548         Expanding and enhancing MockWebRTCPeerConnectionHandler.
2549
2550         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2551         (MockWebRTCPeerConnectionHandler::createOffer):
2552         (MockWebRTCPeerConnectionHandler::createAnswer):
2553         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2554         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2555         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2556         (MockWebRTCPeerConnectionHandler):
2557
2558 2012-09-07  Dean Jackson  <dino@apple.com>
2559
2560         Unreviewed changes to watchlist.
2561
2562         - Add new WebGL and Filters definitions
2563         - Add myself to OpenGL bugs
2564
2565         * Scripts/webkitpy/common/config/watchlist:
2566
2567 2012-09-07  Peter Beverloo  <peter@chromium.org>
2568
2569         Actually trigger the Android Tester
2570         https://bugs.webkit.org/show_bug.cgi?id=96118
2571
2572         Reviewed by Adam Barth.
2573
2574         * BuildSlaveSupport/build.webkit.org-config/config.json:
2575
2576 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
2577
2578         New time input needs accessibility
2579         https://bugs.webkit.org/show_bug.cgi?id=96032
2580
2581         Reviewed by Chris Fleizach.
2582
2583         Add support for valueDescription for testing.
2584
2585         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2586         (getValueDescription):
2587         (AccessibilityUIElement::AccessibilityUIElement):
2588         (AccessibilityUIElement::valueDescriptionGetterCallback):
2589         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
2590         (AccessibilityUIElement):
2591
2592 2012-09-07  Peter Beverloo  <peter@chromium.org>
2593
2594         Add the google-android-tests build slave to the master's config
2595         https://bugs.webkit.org/show_bug.cgi?id=96113
2596
2597         Reviewed by Csaba Osztrogonác.
2598
2599         * BuildSlaveSupport/build.webkit.org-config/config.json:
2600
2601 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2602
2603         [WK2] [EFL] Set theme for WebKit2 API test runner
2604         https://bugs.webkit.org/show_bug.cgi?id=96100
2605
2606         Reviewed by Kenneth Rohde Christiansen.
2607
2608         Set the theme generated by the build for the WebKit2 API test runner.
2609
2610         * TestWebKitAPI/PlatformEfl.cmake:
2611         * TestWebKitAPI/efl/PlatformWebView.cpp:
2612         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2613
2614 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2615
2616         Unreviewed. Add Gábor Ballabás as contributor.
2617
2618         * Scripts/webkitpy/common/config/committers.py:
2619
2620 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2621
2622         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
2623         https://bugs.webkit.org/show_bug.cgi?id=96078
2624
2625         Reviewed by Tor Arne Vestbø.
2626
2627         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
2628
2629         * qmake/mkspecs/features/default_pre.prf:
2630
2631 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2632
2633         [EFL] Add TestExpectations file for efl-wk1
2634         https://bugs.webkit.org/show_bug.cgi?id=96019
2635
2636         Reviewed by Gyuyoung Kim.
2637
2638         Update TestExpectations cascading for EFL port
2639         so that we use efl-wk1 -> efl search paths
2640         for WebKit1 EFL.
2641
2642         * Scripts/webkitpy/layout_tests/port/efl.py:
2643         (EflPort._search_paths):
2644
2645 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
2646
2647         [NRWT] XvfbDriver should stop the Xvfb more aggressively
2648         https://bugs.webkit.org/show_bug.cgi?id=95097
2649
2650         Reviewed by Dirk Pranke.
2651
2652         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
2653         terminating the process does not always work as expected, leading to timeouts
2654         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
2655         as it's not removed by the killed Xvfb process.
2656
2657         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
2658         is tested in different circumstances - whether pixel tests are enabled or not,
2659         with an arbitrary worker number or with an Xorg process already running on the system.
2660         The stopping of the driver is tested by checking that the Xvfb process is truly killed
2661         and then set to None.
2662
2663         * BuildSlaveSupport/kill-old-processes:
2664         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
2665         is left running, potentially clogging up a display at a certain position.
2666         * Scripts/webkitpy/common/system/executive_mock.py:
2667         (MockExecutive.__init__):
2668         The _running_pids is now a dictionary with process names as keys and pids
2669         as values.
2670         (MockExecutive.check_running_pid):
2671         Check whether the passed-in pid is in the _running_pids dictionary's values.
2672         (MockExecutive):
2673         (MockExecutive.running_pids):
2674         This method returns the list of all the process pids of which the name passes
2675         through the process_name_filter.
2676         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2677         Use the Executive object of the port's host to check for running pids and open
2678         new subprocesses or kill them throughout the class.
2679         (XvfbDriver._start):
2680         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
2681         start the server process after it's created.
2682         (XvfbDriver.stop):
2683         Now kills the Xvfb process instead of terminating it and waiting for it to close.
2684         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
2685         (XvfbDriverTest):
2686         (XvfbDriverTest.make_driver):
2687         (XvfbDriverTest.assertDriverStartSuccessful):
2688         (XvfbDriverTest.test_start_no_pixel_tests):
2689         (XvfbDriverTest.test_start_pixel_tests):
2690         (XvfbDriverTest.test_start_arbitrary_worker_number):
2691         (XvfbDriverTest.test_start_existing_xorg_process):
2692         (XvfbDriverTest.test_stop):
2693         (XvfbDriverTest.test_stop.FakeXvfbProcess):
2694
2695 2012-09-06  Peter Beverloo  <peter@chromium.org>
2696
2697         Introduce the Chromium Android Release (Tests) bot
2698         https://bugs.webkit.org/show_bug.cgi?id=95980
2699
2700         Reviewed by Adam Barth.
2701
2702         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
2703         which will be running layout tests on actual Android devices. Right now,
2704         four Galaxy Nexus phones are attached.
2705
2706         * BuildSlaveSupport/build.webkit.org-config/config.json:
2707
2708 2012-09-06  James Robinson  <jamesr@chromium.org>
2709
2710         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
2711         https://bugs.webkit.org/show_bug.cgi?id=96007
2712
2713         Reviewed by Adrienne Walker.
2714
2715         Fixes initialization / settings code to use WebCompositorSupport.
2716
2717         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2718         (main):
2719         * DumpRenderTree/chromium/TestShell.cpp:
2720         (TestShell::initialize):
2721         (TestShell::setPerTilePaintingEnabled):
2722
2723 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2724
2725         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
2726         https://bugs.webkit.org/show_bug.cgi?id=95995
2727
2728         Reviewed by Kenneth Rohde Christiansen.
2729
2730         Provide proper implementation for PlatformWebView::windowFrame()
2731         in EFL's WebKitTestRunner.
2732
2733         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2734         (WTR::PlatformWebView::windowFrame):
2735
2736 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
2737
2738         Fix WTF.Lrint on 32-bit platforms
2739         https://bugs.webkit.org/show_bug.cgi?id=96003
2740
2741         Reviewed by Benjamin Poulain.
2742
2743         Fixed failing WTF.Lrint test on 32-bit platforms.
2744
2745         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2746         (TestWebKitAPI::TEST):
2747
2748 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
2749
2750         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2751         https://bugs.webkit.org/show_bug.cgi?id=95839
2752
2753         Reviewed by Adam Barth.
2754
2755         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2756         up the task definitions a bit. There was no need to have them in the header file.
2757
2758         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2759         (RTCSessionDescriptionRequestSuccededTask):
2760         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2761         (RTCSessionDescriptionRequestFailedTask):
2762         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2763         (RTCVoidRequestTask):
2764         (RTCVoidRequestTask::RTCVoidRequestTask):
2765         (MockWebRTCPeerConnectionHandler::createOffer):
2766         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2767         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2768         (MockWebRTCPeerConnectionHandler::localDescription):
2769         (MockWebRTCPeerConnectionHandler::remoteDescription):
2770         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2771         (MockWebRTCPeerConnectionHandler):
2772
2773 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2774
2775         [Qt] Fix build on Mac OS X 10.6
2776         https://bugs.webkit.org/show_bug.cgi?id=95200
2777
2778         Reviewed by Tor Arne Vestbø.
2779
2780         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
2781         10.7 and newer.
2782
2783         * qmake/mkspecs/features/features.prf:
2784
2785 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2786
2787         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
2788         https://bugs.webkit.org/show_bug.cgi?id=95973
2789
2790         Reviewed by Kenneth Rohde Christiansen.
2791
2792         Correctly map "addSelectionKey" to "Control" modifier
2793         in WKTR's EventSender on other OSes than Mac OS X,
2794         instead of mapping it to the "Meta" modifier.
2795
2796         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2797         (WTR::parseModifier):
2798
2799 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
2800
2801         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
2802         https://bugs.webkit.org/show_bug.cgi?id=95710
2803
2804         Reviewed by Dirk Pranke.
2805
2806         The stdout / stderr output can be None so make sure
2807         we won't raise an exception in this case.
2808
2809         * Scripts/webkitpy/layout_tests/port/driver.py:
2810         (Driver.run_test):
2811
2812 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2813
2814         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
2815         https://bugs.webkit.org/show_bug.cgi?id=95849
2816
2817         Reviewed by Kenneth Rohde Christiansen.
2818
2819         Sanitize URLs passed by the user as program
2820         argument or typed in the URL bar in order to
2821         be more tolerant.
2822
2823         * EWebLauncher/CMakeLists.txt:
2824         * EWebLauncher/main.c:
2825         (main):
2826         * EWebLauncher/url_bar.c:
2827         (_url_bar_url_get_with_protocol):
2828         (on_urlbar_key_down):
2829         * EWebLauncher/url_utils.c: Added.
2830         (has_scheme):
2831         (url_from_user_input): Add utility function to construct a
2832         URL from user input.
2833         * EWebLauncher/url_utils.h: Added.
2834         * MiniBrowser/efl/CMakeLists.txt:
2835         * MiniBrowser/efl/main.c:
2836         (main):
2837
2838 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2839
2840         [Qt] Various small Windows / MSVC build fixes
2841         https://bugs.webkit.org/show_bug.cgi?id=95934
2842
2843         Reviewed by Kenneth Rohde Christiansen.
2844
2845         setFocus takes a boolean as argument: Don't try to implicitly convert
2846         an enum to a boolean, MSVC doesn't like that. The intent here is to
2847         enable focus, so just pass true.
2848
2849         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2850         (WTR::PlatformWebView::focus):
2851
2852 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2853
2854         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
2855         https://bugs.webkit.org/show_bug.cgi?id=95965
2856
2857         Reviewed by Tor Arne Vestbø.
2858
2859         Add ANGLE as a static library module to the Qt WebKit build system.
2860
2861         * qmake/mkspecs/features/default_post.prf:
2862         * qmake/mkspecs/modules/angle.prf: Added.
2863
2864 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
2865
2866         [WK2] Make [Qt]ViewportHandler cross platform
2867         https://bugs.webkit.org/show_bug.cgi?id=91257
2868
2869         Reviewed by Kenneth Rohde Christiansen.
2870
2871         Remove initial scale from viewport info item since it is
2872         set to -1 after applied thus it does not hold any valuable
2873         information.
2874
2875         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
2876
2877 2012-09-05  Tony Chang  <tony@chromium.org>
2878
2879         [chromium] Remove dependency on webkit_user_agent
2880         https://bugs.webkit.org/show_bug.cgi?id=95886
2881
2882         Reviewed by Adam Barth.
2883
2884         The code isn't used by DumpRenderTree.
2885
2886         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2887
2888 2012-09-05  Rick Byers  <rbyers@chromium.org>
2889
2890         Update chromium DumpRenderTree for new WebGestureEvent fields
2891         https://bugs.webkit.org/show_bug.cgi?id=95573
2892
2893         Reviewed by James Robinson.
2894
2895         Update EventSender to write gesture details into the appropriate
2896         type-specific WebGestureEvent fields.
2897         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
2898         (EventSender::gestureEvent):
2899         (EventSender::gestureFlingStart):
2900
2901 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
2902
2903         NRWT lies about the number of tests that it's skipping when used with --repeat-each
2904         https://bugs.webkit.org/show_bug.cgi?id=95789
2905
2906         Reviewed by Ojan Vafai.
2907
2908         Fix miscalculation in log message.
2909
2910         * Scripts/webkitpy/layout_tests/views/printing.py:
2911         (Printer.print_found):
2912
2913 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
2914
2915         Unreviewed, rolling out r127612, r127660, and r127664.
2916         http://trac.webkit.org/changeset/127612
2917         http://trac.webkit.org/changeset/127660
2918         http://trac.webkit.org/changeset/127664
2919         https://bugs.webkit.org/show_bug.cgi?id=95920
2920
2921         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2922         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
2923         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
2924         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
2925         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
2926         (MockWebRTCPeerConnectionHandler::createOffer):
2927         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2928         (MockWebRTCPeerConnectionHandler):
2929         (SuccessCallbackTask):
2930         (FailureCallbackTask):
2931
2932 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2933
2934         Ignore-metrics includes scroll offsets.
2935         https://bugs.webkit.org/show_bug.cgi?id=95845
2936
2937         Reviewed by Dirk Pranke.
2938
2939         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
2940
2941         * Scripts/old-run-webkit-tests:
2942         (stripMetrics):
2943         * Scripts/webkitpy/layout_tests/port/driver.py:
2944         (DriverOutput):
2945
2946 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
2947
2948         Unreviewed test fix.
2949
2950         Including a plugin source file into the build that was added in r127595.
2951
2952         * GNUmakefile.am:
2953
2954 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
2955
2956         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2957         https://bugs.webkit.org/show_bug.cgi?id=95839
2958
2959         Reviewed by Adam Barth.
2960
2961         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2962         up the task definitions a bit. There was no need to have them in the header file.
2963
2964         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2965         (RTCSessionDescriptionRequestSuccededTask):
2966         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2967         (RTCSessionDescriptionRequestFailedTask):
2968         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2969         (RTCVoidRequestTask):
2970         (RTCVoidRequestTask::RTCVoidRequestTask):
2971         (MockWebRTCPeerConnectionHandler::createOffer):
2972         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2973         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2974         (MockWebRTCPeerConnectionHandler::localDescription):
2975         (MockWebRTCPeerConnectionHandler::remoteDescription):
2976         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2977         (MockWebRTCPeerConnectionHandler):
2978
2979 2012-09-05  Kangil Han  <kangil.han@samsung.com>
2980
2981         [EFL] Remove '+=' usage in String
2982         https://bugs.webkit.org/show_bug.cgi?id=95808
2983
2984         Reviewed by Benjamin Poulain.
2985
2986         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
2987
2988         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2989         (descriptionSuitableForTestResult):
2990
2991 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
2992
2993         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
2994         https://bugs.webkit.org/show_bug.cgi?id=95842
2995
2996         Reviewed by Kenneth Rohde Christiansen.
2997
2998         Provide proper implementation for TestRunner::pathToLocalResource()
2999         in EFL WKTR, identical to the one for DumpRenderTree.
3000
3001         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
3002         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
3003         are found my WebKitTestRunner.
3004
3005         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3006         (WTR::TestRunner::pathToLocalResource):
3007
3008 2012-09-05  Brady Eidson  <beidson@apple.com>
3009
3010         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
3011         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
3012
3013         Reviewed by Andy Estes.
3014
3015         Add a plug-in that always fails to initialize:
3016         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
3017         (NPPNewFails):
3018         (NPPNewFails::NPPNewFails):
3019         (NPPNewFails::NPP_New):
3020
3021         Add it to all the project files:
3022         * DumpRenderTree/DumpRenderTree.gypi:
3023         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3024         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3025         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3026         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3027
3028 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3029
3030         [Qt] Fix makefile race condition between derived sources and target
3031
3032         r121966 removed too much of the old qmake logic, including the rule
3033         that ensured that qmake_all would not trigger dual runs of qmake --
3034         one of the derived sources -qmake-all rule, and one for making the
3035         derived sources.
3036
3037         We now follow a similar pattern as before, by introducing a custom
3038         target that explicitly depends on the derived sources' qmake-all before
3039         doing a manual run of make. That ensures a single qmake run for the derived
3040         sources.
3041
3042         https://bugs.webkit.org/show_bug.cgi?id=93847
3043
3044         Reviewed by Csaba Osztrogonác.
3045
3046         * qmake/mkspecs/features/functions.prf:
3047
3048 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3049
3050         WKTR doesn't implement dumpWillCacheResponse()
3051         https://bugs.webkit.org/show_bug.cgi?id=94607
3052
3053         Reviewed by Kenneth Rohde Christiansen.
3054
3055         Define shouldCacheResponse() callback in resource
3056         load client and provide implementation for
3057         dumpWillCacheResponse() in WebKitTestRunner.
3058
3059         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3060         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3061         (WTR::InjectedBundlePage::InjectedBundlePage):
3062         (WTR::InjectedBundlePage::shouldCacheResponse):
3063         (WTR):
3064         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3065         (InjectedBundlePage):
3066         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3067         (WTR::TestRunner::TestRunner):
3068         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3069         (WTR::TestRunner::dumpWillCacheResponse):
3070         (WTR::TestRunner::shouldDumpWillCacheResponse):
3071         (TestRunner):
3072
3073 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3074
3075         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
3076         https://bugs.webkit.org/show_bug.cgi?id=92735
3077
3078         Reviewed by Hajime Morita.
3079
3080         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
3081
3082         * DumpRenderTree/TestRunner.cpp:
3083         (TestRunner::staticFunctions):
3084         * DumpRenderTree/TestRunner.h:
3085         (TestRunner):
3086         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3087         (TestRunner::addUserStyleSheet):
3088         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3089         (DRTTestRunner::DRTTestRunner):
3090         (DRTTestRunner::hasCustomPageSizeStyle):
3091         * DumpRenderTree/chromium/DRTTestRunner.h:
3092         (DRTTestRunner):
3093         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3094         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3095         * DumpRenderTree/mac/TestRunnerMac.mm:
3096         * DumpRenderTree/qt/TestRunnerQt.cpp:
3097         (TestRunner::evaluateScriptInIsolatedWorld):
3098         * DumpRenderTree/qt/TestRunnerQt.h:
3099         (TestRunner):
3100         * DumpRenderTree/win/TestRunnerWin.cpp:
3101         * DumpRenderTree/wx/TestRunnerWx.cpp:
3102         (TestRunner::abortModal):
3103         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3104         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3105         (WTR):
3106         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3107         (TestRunner):
3108
3109 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
3110
3111         [Qt] Automate the use of AllInOne files in the Qt build
3112         https://bugs.webkit.org/show_bug.cgi?id=95837
3113
3114         Reviewed by Tor Arne Vestbø.
3115
3116         New feature file that implements the all-in-one file automation by
3117         adding the requested all-in-one files to SOURCES and removing the files
3118         it includes from SOURCES.
3119
3120         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
3121
3122 2012-09-04  Tim Horton  <timothy_horton@apple.com>
3123
3124         Have NRWT log more output when crash logs are missing
3125         https://bugs.webkit.org/show_bug.cgi?id=95814
3126
3127         Reviewed by Dan Bernstein.
3128
3129         Log the stderr and stdout of the test, in order to provide slightly more
3130         context when the WebProcess times out while running tests.
3131
3132         * Scripts/webkitpy/layout_tests/port/driver.py:
3133         (Driver.run_test):
3134
3135 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3136
3137         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
3138         https://bugs.webkit.org/show_bug.cgi?id=95770
3139
3140         Reviewed by Adam Barth.
3141
3142         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3143         (ChromiumAndroidDriver.__init__):
3144         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
3145         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
3146         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
3147         (ChromiumAndroidDriver._push_executable):
3148         (ChromiumAndroidDriver._push_fonts):
3149         (ChromiumAndroidDriver._push_test_resources):
3150         (ChromiumAndroidDriver._run_adb_command):
3151         (ChromiumAndroidDriver._get_last_stacktrace):
3152         (ChromiumAndroidDriver._get_crash_log):
3153         (ChromiumAndroidDriver._start):
3154         (ChromiumAndroidDriver._start_once):
3155         (ChromiumAndroidDriver._start_once.deadlock_detector):
3156         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3157         (ChromiumAndroidDriverTest.test_get_crash_log):
3158
3159 2012-09-04  Satish Sampath  <satish@chromium.org>
3160
3161         Run git commands within the checkout directory
3162         https://bugs.webkit.org/show_bug.cgi?id=95742
3163
3164         Reviewed by Eric Seidel.
3165
3166         git commands run from scm/git.py are sometimes run with cwd set to the
3167         checkout_root and other times with whatever directory was the default cwd.
3168         Instead all these should run with the checkout root set as the cwd
3169         (except where we explicitly need a different path)
3170
3171         * Scripts/webkitpy/common/checkout/scm/git.py:
3172         (Git._run_git):
3173         (Git.find_checkout_root):
3174         (Git.discard_local_commits):
3175         (Git.local_commits):
3176         (Git.working_directory_is_clean):
3177         (Git.clean_working_directory):
3178         (Git.add_list):
3179         (Git.delete_list):
3180         (Git.exists):
3181         (Git._current_branch):
3182         (Git._changes_files_for_commit):
3183         (Git.revisions_changing_file):
3184         (Git.svn_revision):
3185         (Git._run_git_svn_find_rev):
3186         (Git.contents_at_revision):
3187         (Git.diff_for_file):
3188         (Git.show_head):
3189         (Git.committer_email_for_revision):
3190         (Git.apply_reverse_diff):
3191         (Git.revert_files):
3192         (Git.commit_with_message):
3193         (Git._commit_on_branch):
3194         (Git.svn_commit_log):
3195         (Git.last_svn_commit_log):
3196         (Git.svn_blame):
3197         (Git._branch_ref_exists):
3198         (Git.delete_branch):
3199         (Git.remote_merge_base):
3200         (Git.commit_locally_with_message):
3201         (Git.push_local_commits_to_server):
3202         (Git.commit_ids_from_commitish_arguments):
3203         (Git.commit_message_for_local_commit):
3204         (Git.files_changed_summary_for_commit):
3205
3206 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3207
3208         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
3209         https://bugs.webkit.org/show_bug.cgi?id=95734
3210
3211         Reviewed by Adam Barth.
3212
3213         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3214         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3215         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3216         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3217         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3218         (MockWebRTCPeerConnectionHandler::createOffer):
3219         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3220         (MockWebRTCPeerConnectionHandler):
3221         (MockWebRTCPeerConnectionHandler::taskList):
3222         (SuccessCallbackTask):
3223         (FailureCallbackTask):
3224
3225 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3226
3227         [Chromium-Android] Output time and thread info in crash log
3228         https://bugs.webkit.org/show_bug.cgi?id=95768
3229
3230         Reviewed by Adam Barth.
3231
3232         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3233         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
3234
3235 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3236
3237         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
3238         https://bugs.webkit.org/show_bug.cgi?id=95721
3239
3240         Reviewed by Adam Barth.
3241
3242         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
3243         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
3244         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
3245         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
3246         (MockWebMediaStreamCenter):
3247
3248 2012-09-04  Tony Chang  <tony@chromium.org>
3249
3250         Elide test names when running new-run-webkit-tests
3251         https://bugs.webkit.org/show_bug.cgi?id=95626
3252
3253         Reviewed by Dirk Pranke.
3254
3255         When the test name exceeds the number of terminal columns, it leaves
3256         text on the screen. Avoid this by eliding the test name when running
3257         tests. This is similar to what ninja does when compiling.
3258
3259         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3260         (MeteredStream):
3261         (MeteredStream.number_of_columns): Helper method to get number of
3262         terminal columns. Won't work on Win32 python, but meh.
3263         * Scripts/webkitpy/layout_tests/views/printing.py:
3264         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
3265         because stderr appears to be ascii only.
3266         (Printer.print_started_test): Route through _test_status_line.
3267         (Printer.print_finished_test): Route through _test_status_line.
3268         (Printer._print_test_trace): Route through _test_status_line.
3269         (Printer._print_baseline): Route through _test_status_line.
3270         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3271         (test_test_status_line): Test for _test_status_line.
3272
3273 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
3274
3275         [GTK] Print API missing documentation when generating gtkdoc
3276         https://bugs.webkit.org/show_bug.cgi?id=95703
3277
3278         Reviewed by Carlos Garcia Campos.
3279
3280         Print out API missing documentation when generating gtkdoc. This makes it
3281         easier to fix documentation errors.
3282
3283         * gtk/generate-gtkdoc:
3284         (print_missing_api): Added.
3285         (generate_doc): Inline the rebase step, since it now reports an error
3286         when you try to rebase without generating documentation first.
3287         * gtk/gtkdoc.py:
3288         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
3289         generating documentation first to enable a small cleanup at the caller.
3290         (GTKDoc.api_missing_documentation): Added.
3291
3292 2012-09-04  Vincent Scheib  <scheib@chromium.org>
3293
3294         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
3295         https://bugs.webkit.org/show_bug.cgi?id=95628
3296
3297         Reviewed by James Robinson.
3298
3299         Future tests need the ability to respond asynchronously that
3300         pointer lock requests have been accepted or rejected. This patch
3301         adds the following:
3302             testRunner.setPointerLockWillRespondAsynchronously();
3303             testRunner.didAcquirePointerLock();
3304             testRunner.didNotAcquirePointerLock();
3305
3306         Tested in existing test:
3307             pointerlockchange-pointerlockerror-events.html
3308
3309         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3310         (DRTTestRunner::DRTTestRunner):
3311         (DRTTestRunner::didAcquirePointerLock):
3312         (DRTTestRunner::didNotAcquirePointerLock):
3313         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
3314         * DumpRenderTree/chromium/DRTTestRunner.h:
3315         (DRTTestRunner):
3316         * DumpRenderTree/chromium/WebViewHost.cpp:
3317         (WebViewHost::requestPointerLock):
3318         (WebViewHost::didAcquirePointerLock):
3319         (WebViewHost::didNotAcquirePointerLock):
3320         * DumpRenderTree/chromium/WebViewHost.h:
3321         (WebViewHost):
3322         (WebViewHost::setPointerLockWillRespondAsynchronously):
3323
3324 2012-09-04  Ojan Vafai  <ojan@chromium.org>
3325
3326         Move content shell bots to their own builder group
3327         https://bugs.webkit.org/show_bug.cgi?id=95765
3328
3329         Reviewed by Adam Barth.
3330
3331         In their current state of instability, they add too much noise. Once they get more stable,
3332         we can add them back to the regular group or just have them replace the other bots.
3333
3334         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
3335
3336         * TestResultServer/static-dashboards/builders.js:
3337         (isWebkitTestRunner):
3338         (isChromiumContentShellTestRunner):
3339         (isChromiumWebkitTipOfTreeTestRunner):
3340         (loadBuildersList):
3341
3342 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
3343
3344         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
3345         https://bugs.webkit.org/show_bug.cgi?id=95689
3346
3347         Reviewed by Kenneth Rohde Christiansen.
3348
3349         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
3350         So, there are bugs that key events are always generated in url bar although
3351         the user clicked the web view.
3352
3353         This patch recovers the focus of the web view when left button is pressed and
3354         adds for MiniBrowser to toggle the focus when middle button is pressed
3355         like EWebLauncher already did.
3356
3357         * EWebLauncher/main.c:
3358         (on_mouse_down):
3359         * MiniBrowser/efl/main.c:
3360         (on_mouse_down):
3361         (browserCreate):
3362
3363 2012-09-03  Tao Bai  <michaelbai@chromium.org>
3364
3365         Added ANDROID_GDBSERVER definition for Ant
3366         https://bugs.webkit.org/show_bug.cgi?id=95265
3367
3368         Reviewed by Adam Barth.
3369
3370         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
3371         is only used for finding the gdbserver.
3372
3373         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3374         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3375
3376 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
3377
3378         MediaStream API: Add Ice-related functionality to RTCPeerConnection
3379         https://bugs.webkit.org/show_bug.cgi?id=95565
3380
3381         Reviewed by Adam Barth.
3382
3383         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3384         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3385         (MockWebRTCPeerConnectionHandler::updateICE):
3386         (MockWebRTCPeerConnectionHandler::addICECandidate):
3387         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3388         (MockWebRTCPeerConnectionHandler):
3389
3390 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
3391
3392         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
3393         https://bugs.webkit.org/show_bug.cgi?id=95670
3394
3395         Reviewed by Kenneth Rohde Christiansen.
3396
3397         Fix layout issues related to the URL bar in Minibrowser
3398         and EWebLauncher when the window is resized.
3399
3400         The URL bar was not resized accordingly and the Web
3401         page was moved behing the URL bar, hiding part of it.
3402
3403         * EWebLauncher/main.c:
3404         (on_ecore_evas_resize):
3405         (closeWindow):
3406         * EWebLauncher/url_bar.c:
3407         (url_bar_width_set):
3408         (url_bar_add):
3409         * EWebLauncher/url_bar.h:
3410         * MiniBrowser/efl/main.c:
3411         (on_ecore_evas_resize):
3412         (main):
3413
3414 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
3415
3416         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
3417         https://bugs.webkit.org/show_bug.cgi?id=95605
3418
3419         Reviewed by Dirk Pranke.
3420
3421         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
3422
3423         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3424         (ChromiumAndroidPort.check_sys_deps):
3425         (ChromiumAndroidPort.expectations_files):
3426         (ChromiumAndroidPort.clean_up_test_run):
3427
3428 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
3429
3430         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
3431         https://bugs.webkit.org/show_bug.cgi?id=95180
3432
3433         Reviewed by Chris Fleizach.
3434
3435         The bug that was fixed stood in the way of fully implementing stringValue().
3436         Testing that the bug is fixed requires stringValue() to be fully implemented
3437         and object replacement characters to be printable.
3438
3439         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3440         (replaceCharactersForResults): New method which turns object replacement
3441         characters into "<obj>" so that the characters can be properly shown in
3442         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
3443         accessible text of a single object in the accessible tree doesn't mess up
3444         the readibility of the results.
3445         (AccessibilityUIElement::stringValue): Remove the code that immediately
3446         returned upon encountering an object of ATK_ROLE_PANEL and call the new
3447         replaceCharactersForResults() prior to returning the accessible string
3448         value.
3449
3450 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
3451
3452         MediaStream API: Add MediaStream management to RTCPeerConnection
3453         https://bugs.webkit.org/show_bug.cgi?id=95543
3454
3455         Reviewed by Adam Barth.
3456
3457         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
3458
3459         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3460         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3461         (MockWebRTCPeerConnectionHandler::addStream):
3462         (MockWebRTCPeerConnectionHandler::removeStream):
3463         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3464         (MockWebRTCPeerConnectionHandler):
3465
3466 2012-08-31  Tony Chang  <tony@chromium.org>
3467
3468         Remove ENABLE_CSS3_FLEXBOX compile time flag
3469         https://bugs.webkit.org/show_bug.cgi?id=95382
3470
3471         Reviewed by Ojan Vafai.
3472
3473         Everyone is already enabling this by default and the spec has stablized.
3474
3475         * Scripts/webkitperl/FeatureList.pm:
3476         * qmake/mkspecs/features/features.pri:
3477
3478 2012-08-31  Pratik Solanki  <psolanki@apple.com>
3479
3480         objc_msgSend and IMP should be cast appropriately before using
3481         https://bugs.webkit.org/show_bug.cgi?id=95242
3482
3483         Reviewed by Benjamin Poulain.
3484
3485         Fix for older compilers. Pass id as the return type to the template
3486         instead of relying on default type.
3487
3488         * DumpRenderTree/mac/DumpRenderTree.mm:
3489         (drt_NSFontManager_availableFontFamilies):
3490         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3491         (WTR::wtr_NSFontManager_availableFontFamilies):
3492
3493 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
3494
3495         nrwt: use scm instead of calling svn directly to get the revision in json results generator
3496         https://bugs.webkit.org/show_bug.cgi?id=89616
3497
3498         Reviewed by Eric Seidel.
3499
3500         Add the new 'executive' optional function argument to the SCM.in_working_directory
3501         class method. This way we get to reuse an Executive instance which is necessary in testing
3502         when we're operating with a mock version of the object.
3503
3504         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
3505         the SCMDetector with the generator's FileSystem and Executive instances.
3506
3507         * Scripts/webkitpy/common/checkout/scm/detection.py:
3508         (SCMDetector.detect_scm_system):
3509         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3510         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
3511         Executive output and test it against expected output.
3512         * Scripts/webkitpy/common/checkout/scm/git.py:
3513         (Git.in_working_directory):
3514         * Scripts/webkitpy/common/checkout/scm/scm.py:
3515         (SCM.in_working_directory):
3516         * Scripts/webkitpy/common/checkout/scm/svn.py:
3517         (SVN.in_working_directory):
3518         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3519         (JSONResultsGeneratorBase.__init__):
3520         (JSONResultsGeneratorBase._get_svn_revision):
3521
3522 2012-08-31  Jon Lee  <jonlee@apple.com>
3523
3524         [Tests] Add basic tests to http/tests/notifications
3525         https://bugs.webkit.org/show_bug.cgi?id=95493
3526         <rdar://problem/12209303>
3527
3528         Reviewed by Alexey Proskuryakov.
3529
3530         Add permission request support for WTR.
3531
3532         * WebKitTestRunner/TestController.cpp:
3533         (WTR::TestController::initialize):
3534         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
3535         * WebKitTestRunner/TestController.h:
3536         (TestController):
3537
3538 2012-08-31  Jon Lee  <jonlee@apple.com>
3539
3540         [DRT] Make simulating a web click on a notification a queued task
3541         https://bugs.webkit.org/show_bug.cgi?id=95546
3542         <rdar://problem/12214170>
3543
3544         Reviewed by Alexey Proskuryakov.
3545
3546         Making the web click happen asynchronously better mimics user interaction with the platform.
3547
3548         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
3549         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
3550         not set.
3551         * DumpRenderTree/mac/DumpRenderTree.mm:
3552         (dump): Assert that the flag is not set.
3553         * DumpRenderTree/mac/TestRunnerMac.mm:
3554         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
3555         notification. In the case where the block gets executed after the flag has been unset, we avoid
3556         performing the click.
3557
3558 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
3559
3560         [Qt] ImageDiff output is not in the expected form if image dimensions differ
3561         https://bugs.webkit.org/show_bug.cgi?id=95575
3562
3563         Reviewed by Csaba Osztrogonác.
3564
3565         Output 100% difference in the case of differing image dimensions so
3566         the test harness knows that we won't produce any output further.
3567         This matches the behavior of other ports.
3568
3569         * DumpRenderTree/qt/ImageDiff.cpp:
3570         (main):
3571
3572 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3573
3574         Unreviewed, rolling out r127261.
3575         http://trac.webkit.org/changeset/127261
3576         https://bugs.webkit.org/show_bug.cgi?id=95572
3577
3578         This patch depends on other build fixes (see blockers of bug
3579         95466) which should land first (Requested by milian on
3580         #webkit).
3581
3582         * qmake/mkspecs/features/features.prf:
3583
3584 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
3585
3586         [Qt] Support WebKit2/QML on QNX
3587         https://bugs.webkit.org/show_bug.cgi?id=95466
3588
3589         Reviewed by Noam Rosenthal.
3590
3591         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
3592         this should finally work now.
3593
3594         * qmake/mkspecs/features/features.prf:
3595
3596 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
3597
3598         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
3599         https://bugs.webkit.org/show_bug.cgi?id=95400
3600
3601         Reviewed by Dirk Pranke.
3602
3603         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
3604
3605         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3606         (ChromiumAndroidPort.skipped_layout_tests):
3607
3608 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
3609
3610         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
3611         https://bugs.webkit.org/show_bug.cgi?id=95499
3612
3613         Unreviewed. One more fix to avoid trying to run the empty string.
3614
3615         * Scripts/webkitdirs.pm:
3616         (buildAutotoolsProject):
3617
3618 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3619
3620         Unreviewed, rolling out r127171.
3621         http://trac.webkit.org/changeset/127171
3622         https://bugs.webkit.org/show_bug.cgi?id=95505
3623
3624         testRunner does not need dumpWebNotificationCallbacks().
3625         (Requested by jonlee on #webkit).
3626
3627         * DumpRenderTree/TestRunner.cpp:
3628         (TestRunner::TestRunner):
3629         (TestRunner::staticFunctions):
3630         * DumpRenderTree/TestRunner.h:
3631         (TestRunner):
3632         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3633         (-[MockWebNotificationProvider webView:didShowNotification:]):
3634         (-[MockWebNotificationProvider webView:didClickNotification:]):
3635         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3636         * DumpRenderTree/mac/UIDelegate.mm:
3637         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3638
3639 2012-08-30  Pratik Solanki  <psolanki@apple.com>
3640
3641         objc_msgSend and IMP should be cast appropriately before using
3642         https://bugs.webkit.org/show_bug.cgi?id=95242
3643
3644         Reviewed by Benjamin Poulain.
3645
3646         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
3647         to a function pointer with right types when calling objc_msgSend and an
3648         IMP method directly.
3649
3650         * DumpRenderTree/mac/DumpRenderTree.mm:
3651         (drt_NSFontManager_availableFontFamilies):
3652         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3653         (WTR::wtr_NSFontManager_availableFontFamilies):
3654
3655 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
3656
3657         Replace JSC::UString by WTF::String
3658         https://bugs.webkit.org/show_bug.cgi?id=95271
3659
3660         Reviewed by Geoffrey Garen.
3661
3662         Get rid of UString.
3663
3664         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3665         * gdb/webkit.py:
3666         (WTFStringPrinter.to_string):
3667         (JSCIdentifierPrinter.to_string):
3668         (JSCJSStringPrinter.to_string):
3669         (add_pretty_printers):
3670
3671 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3672
3673         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
3674         https://bugs.webkit.org/show_bug.cgi?id=95495
3675
3676         Reviewed by Ojan Vafai.
3677
3678         This is a follow-on to bug 95370 that adds in support for
3679         platform/wk2/TestExpectations and
3680         platform/{mac,win}-$version/TestExpectations.
3681
3682         * Scripts/webkitpy/layout_tests/port/apple.py:
3683         (ApplePort.expectations_files):
3684         * Scripts/webkitpy/layout_tests/port/base.py:
3685         (Port._skipped_file_search_paths):
3686         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3687         (MacTest.test_expectations_files):
3688         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3689         (MockDRTPortTest.make_port):
3690         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3691         (WinPortTest.test_expectations_files):
3692
3693 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3694
3695         executive.run_in_parallel() hangs if given nothing to do
3696         https://bugs.webkit.org/show_bug.cgi?id=95387
3697
3698         Reviewed by Ojan Vafai.
3699
3700         Check to make sure that Executive.run_in_parallel() requires
3701         a non-empty list of commands to execute; passing an empty list
3702         seems surely like a programming error.
3703
3704         * Scripts/webkitpy/common/system/executive.py:
3705         (Executive.run_in_parallel):
3706         * Scripts/webkitpy/common/system/executive_unittest.py:
3707         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
3708
3709 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3710
3711         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
3712         https://bugs.webkit.org/show_bug.cgi?id=94746
3713
3714         Reviewed by Ojan Vafai.
3715
3716         Add an assertion to diff_image() to check that we are passing
3717         tolerance=0 explicitly when diffing ref test results.
3718
3719         * Scripts/webkitpy/layout_tests/port/test.py:
3720         (TestPort.diff_image):
3721
3722 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3723
3724         NRWT should look in mac-wk2 for a TestExpecations file
3725         https://bugs.webkit.org/show_bug.cgi?id=95370
3726
3727         Reviewed by Ojan Vafai.
3728
3729         Adds support for mac-wk2 and win-wk2 to expectations_files()
3730         for the apple mac and apple win ports.
3731         
3732         * Scripts/webkitpy/layout_tests/port/apple.py:
3733         (ApplePort.expectations_files):
3734         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3735         (MacTest.test_expectations_files):
3736         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3737         (WinTest.test_expectations_files):
3738         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3739         (PortTestCase.test_expectations_files):
3740
3741 2012-08-30  Jon Lee  <jonlee@apple.com>
3742
3743         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
3744         https://bugs.webkit.org/show_bug.cgi?id=95232
3745         <rdar://problem/12190776>
3746
3747         Reviewed by Alexey Proskuryakov.
3748
3749         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
3750
3751         * DumpRenderTree/TestRunner.cpp:
3752         (TestRunner::TestRunner):
3753         (dumpWebNotificationCallbacksCallback):
3754         (TestRunner::staticFunctions):
3755         * DumpRenderTree/TestRunner.h:
3756         (TestRunner):
3757         (TestRunner::dumpWebNotificationCallbacks):
3758         (TestRunner::setDumpWebNotificationCallbacks):
3759         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3760         (-[WebNotification _drt_descriptionSuitableForTestResult]):
3761         (-[MockWebNotificationProvider webView:didShowNotification:]):
3762         (-[MockWebNotificationProvider webView:didClickNotification:]):
3763         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3764         * DumpRenderTree/mac/UIDelegate.mm:
3765         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3766
3767 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
3768
3769         MediaStream API: Introduce MediaConstraints
3770         https://bugs.webkit.org/show_bug.cgi?id=95198
3771
3772         Reviewed by Adam Barth.
3773
3774         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
3775
3776         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3777         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3778         (isSupportedConstraint):
3779         (isValidConstraint):
3780         (MockWebRTCPeerConnectionHandler::initialize):
3781         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3782         (MockWebRTCPeerConnectionHandler):
3783
3784 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3785
3786         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
3787         https://bugs.webkit.org/show_bug.cgi?id=95454
3788
3789         Reviewed by Kenneth Rohde Christiansen.
3790
3791         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
3792
3793         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3794         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3795
3796 2012-08-30  Leo Yang  <leoyang@rim.com>
3797
3798         Update my email address.
3799
3800         Not reviewed.
3801
3802         * Scripts/webkitpy/common/config/committers.py:
3803
3804 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
3805
3806         [NRWT] Add support for recognizing arbitrary process names in crash lines
3807         https://bugs.webkit.org/show_bug.cgi?id=95435
3808
3809         Reviewed by Adam Barth.
3810
3811         When running layout tests in the chromium port using the content shell,
3812         we want to be able to report sub-process crashes as well.
3813
3814         * Scripts/webkitpy/layout_tests/port/driver.py:
3815         (Driver._check_for_driver_crash):
3816         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3817         (DriverTest.test_check_for_driver_crash):
3818
3819 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
3820
3821         Random test-webkitpy failures on the buildbot
3822         https://bugs.webkit.org/show_bug.cgi?id=95096
3823
3824         Reviewed by Dirk Pranke.
3825
3826         Suppress occasional errors when running test-webkitpy on GTK builders
3827         by running these tests serially. The 64-bit Release builder is especially
3828         prone to these as it can run up to 24 tests in parallel.
3829
3830         Despite the tests not being run in parallel, the testing only lasts a handful
3831         of seconds more, so this is a worthy trade-off to avoid unnecessary
3832         false-alarm redness on the GTK builders.
3833
3834         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3835         (RunPythonTests.start):
3836
3837 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
3838
3839         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
3840         https://bugs.webkit.org/show_bug.cgi?id=95380
3841
3842         Reviewed by Michael Saboff.
3843
3844         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3845         Add very basic tests for String::ascii(). This covers the case of null strings that caused
3846         the crash.
3847
3848 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
3849
3850         AX: Canvas should have a distinct role
3851         https://bugs.webkit.org/show_bug.cgi?id=95248
3852
3853         Reviewed by Chris Fleizach.
3854
3855         Add support for canvas accessibility role.
3856
3857         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3858         (roleToString):
3859
3860 2012-08-29  José Dapena Paz  <jdapena@igalia.com>
3861
3862         [Gtk] Process Gtk 3.4 smooth scroll events properly
3863         https://bugs.webkit.org/show_bug.cgi?id=88070
3864
3865         Added continousMouseScrollBy support in WebKitTestRunner, and added
3866         implementation for gtk, and stub for Qt, mac and EFL.
3867
3868         Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
3869         scroll for emulating multi-tick mouseScrollBy events.
3870
3871         Reviewed by Martin Robinson.
3872
3873         * DumpRenderTree/gtk/EventSender.cpp:
3874         (mouseScrollByCallback):
3875         (continuousMouseScrollByCallback):
3876         * WebKitTestRunner/EventSenderProxy.h:
3877         (EventSenderProxy):
3878         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3879         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3880         (WTR::EventSendingController::mouseScrollBy):
3881         (WTR):
3882         (WTR::EventSendingController::continuousMouseScrollBy):
3883         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3884         (EventSendingController):
3885         * WebKitTestRunner/TestController.cpp:
3886         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3887         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3888         (WTR):
3889         (WTR::EventSenderProxy::mouseScrollBy):
3890         (WTR::EventSenderProxy::continuousMouseScrollBy):
3891         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3892         (WTR):
3893         (WTR::EventSenderProxy::continuousMouseScrollBy):
3894         * WebKitTestRunner/mac/EventSenderProxy.mm:
3895         (WTR::EventSenderProxy::continuousScrollBy):
3896         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3897         (WTR::EventSenderProxy::continuousMouseScrollBy):
3898         (WTR):
3899
3900 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
3901
3902         [chromium] Support high DIP pixel tests with DumpRenderTree
3903         https://bugs.webkit.org/show_bug.cgi?id=94935
3904
3905         Reviewed by James Robinson.
3906
3907         Adding device scale factor into the drt image dumping code
3908
3909         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3910         (DRTTestRunner::reset):
3911         (DRTTestRunner::setBackingScaleFactor):
3912         * DumpRenderTree/chromium/WebViewHost.cpp:
3913         (WebViewHost::setDeviceScaleFactor):
3914         (WebViewHost::paintInvalidatedRegion):
3915         (WebViewHost::canvas):
3916         * DumpRenderTree/chromium/WebViewHost.h:
3917         (WebViewHost):
3918
3919 2012-08-29  Kevin Funk  <kevin.funk@kdab.com>
3920
3921         Fix check-webkit-style (and probably others) when WebKit is in a git submodule
3922         https://bugs.webkit.org/show_bug.cgi?id=95177
3923
3924         Reviewed by Dirk Pranke.
3925
3926         Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
3927
3928         * Scripts/webkitpy/common/checkout/scm/git.py:
3929
3930 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
3931
3932         webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
3933         https://bugs.webkit.org/show_bug.cgi?id=95222
3934
3935         Reviewed by Adam Barth.
3936
3937         The code we had to remove REBASELINE lines from the
3938         TestExpectations files did not handle multiple files (in a
3939         cascade) correctly; we weren't limiting lines to a particular
3940         file correctly in without_rebaseline_modifier(). This patch
3941         fixes that and corrects the tests (which weren't correct and
3942         didn't cover things very well).
3943
3944         Note also that the webkit-patch rebaseline-commands are still
3945         using the include_overrides=False option in a couple places;
3946         this is never correct or needed at this point. This patch fixes
3947         the usage for webkit-patch rebaseline-expectations, but I still
3948         need to fix rebaseline-test-internal, which I will do in a
3949         separate patch (see bug 95268).
3950
3951         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3952         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
3953         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3954         (RebaseliningTest.assertRemove):
3955         (RebaseliningTest.test_remove):
3956         * Scripts/webkitpy/tool/commands/rebaseline.py:
3957         (RebaselineExpectations._update_expectations_files):
3958
3959 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
3960
3961         webkit-patch rebaseline-expectations hangs
3962         https://bugs.webkit.org/show_bug.cgi?id=95243
3963
3964         Reviewed by Tony Chang.
3965
3966         Don't try to run no commands in parallel; report an error
3967         instead that we didn't find any tests to rebaseline.
3968
3969         Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
3970
3971         * Scripts/webkitpy/tool/commands/rebaseline.py:
3972         (RebaselineExpectations.execute):
3973         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3974         (_assert_command):
3975         (test_rebaseline_expectations_noop):
3976
3977 2012-08-29  Brady Eidson  <beidson@apple.com>
3978
3979         REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
3980         <rdar://problem/12133021> and https://bugs.webkit.org/show_bug.cgi?id=95274
3981
3982         Reviewed by Sam Weinig.
3983
3984         Add a test plug-in that calls back into the page with info on the NPWindow passed
3985         in to NPP_SetWindow.
3986
3987         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3988         * DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp: Added.
3989         (LogNPPSetWindow):
3990         (LogNPPSetWindow::LogNPPSetWindow):
3991         (LogNPPSetWindow::NPP_SetWindow):
3992
3993 2012-08-29  Jon Lee  <jonlee@apple.com>
3994
3995         [Mac] Basic DRT support for web notifications
3996         https://bugs.webkit.org/show_bug.cgi?id=79492
3997         <rdar://problem/10357639>
3998
3999         Reviewed by Alexey Proskuryakov.
4000
4001         This patch implements the stubs for web notification support on DRT. Assume that when
4002         Notification.requestPermission() is called, the user always chooses to allow it. This can be easily
4003         overridden in layout tests with testRunner.denyWebNotificationPermission() when needed.
4004
4005         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add MockWebNotificationProvider.
4006         * DumpRenderTree/mac/DumpRenderTree.mm:
4007         (createWebViewAndOffscreenWindow): Set MockWebNotificationProvider singleton as the provider for the
4008         web view.
4009         (resetWebViewToConsistentStateBeforeTesting): Make sure to reset the provider's state between each test.
4010
4011         * DumpRenderTree/mac/TestRunnerMac.mm:
4012         (TestRunner::grantWebNotificationPermission): Set permission to granted for specified origin.
4013         (TestRunner::denyWebNotificationPermission): Set permission to denied for specified origin.
4014         (TestRunner::removeAllWebNotificationPermissions):
4015         (TestRunner::simulateWebNotificationClick): Retrieve the notification ID from the JS notification object, and
4016         simulate the click. This is similar to how WTR performs the click.
4017         * DumpRenderTree/mac/UIDelegate.mm:
4018         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): Assume when asked, the
4019         user allows web notifications.
4020
4021         * DumpRenderTree/mac/MockWebNotificationProvider.h: Added. Maintains a list of registered web views, known permissions,
4022         a map of notification IDs to WebNotification instances, and a map of the WebViews from which the notifications were dispatched.
4023         * DumpRenderTree/mac/MockWebNotificationProvider.mm: Added.
4024         (+[MockWebNotificationProvider shared]): The provider is a singleton.
4025         (-[MockWebNotificationProvider init]): Instantiate the permissions map.
4026         (-[MockWebNotificationProvider registerWebView:]):
4027         (-[MockWebNotificationProvider unregisterWebView:]):
4028         (-[MockWebNotificationProvider showNotification:fromWebView:]): Add the notification to the maps. Tell the web view that the
4029         notification did show.
4030         (-[MockWebNotificationProvider cancelNotification:]): Tell the web view the notification did close.
4031         (-[MockWebNotificationProvider notificationDestroyed:]): Remove the notification from the maps. Here we don't make a callback.
4032         (-[MockWebNotificationProvider clearNotifications:]): Remove the specified notifications from the maps. Here we don't make a callback.
4033         (-[MockWebNotificationProvider webView:didShowNotification:]): Delegate callback. Dispatch the show event.
4034         (-[MockWebNotificationProvider webView:didClickNotification:]): Delegate callback. Dispatch the click event.
4035         (-[MockWebNotificationProvider webView:didCloseNotifications:]): Delegate callback. Dispatch the close event.
4036         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Tell the web view we clicked the notification.
4037         (-[MockWebNotificationProvider policyForOrigin:]): Look in the permission dictionary.
4038         (-[MockWebNotificationProvider setWebNotificationOrigin:permission:]): Set the permission for the origin in the dictionary.
4039         (-[MockWebNotificationProvider removeAllWebNotificationPermissions]): Clear the permission map.
4040         (-[MockWebNotificationProvider reset]): Remove all mappings and permissions.
4041
4042 2012-08-29  Rob Buis  <rbuis@rim.com>
4043
4044         [BlackBerry] Adjust wtf include header style
4045         https://bugs.webkit.org/show_bug.cgi?id=95368
4046
4047         Reviewed by Yong Li.
4048
4049         Switch to #include <wtf/...> like the other ports.
4050
4051         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
4052         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
4053         * DumpRenderTree/blackberry/PNGImageEncoder.h:
4054         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
4055         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
4056         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
4057
4058 2012-08-29  Roger Fong  <roger_fong@apple.com>
4059
4060         Update cygwin-downloader.zip to match modified downloader script.
4061         https://bugs.webkit.org/show_bug.cgi?id=76936
4062
4063         Rubber Stamped by Jon Honeycutt.
4064
4065         cygwin-downloader.py was modified in http://trac.webkit.org/changeset/126948.
4066         Updating zip to reflect changes.
4067
4068         * CygwinDownloader/cygwin-downloader.zip:
4069
4070 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
4071
4072         Stylechecker warns about comparison to zero when comparing to 0.5
4073         https://bugs.webkit.org/show_bug.cgi?id=94913
4074
4075         Reviewed by Dirk Pranke.
4076
4077         According to the python documentation, \W is the character group with all
4078         non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
4079         to [^\w]. We need to exclude the dot "." as well, so that floating point
4080         values do not trigger this warning. Adding a unit test that shows the problem.
4081
4082         * Scripts/webkitpy/style/checkers/cpp.py:
4083         (check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
4084         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4085         (WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
4086
4087 2012-08-29  Jon Lee  <jonlee@apple.com>
4088
4089         WTR build fixes.
4090
4091         * WebKitTestRunner/CMakeLists.txt:
4092         * WebKitTestRunner/GNUmakefile.am:
4093         * WebKitTestRunner/Target.pri:
4094         * WebKitTestRunner/WebNotificationProvider.cpp:
4095         (WTR::WebNotificationProvider::showWebNotification): Make ML happier.
4096         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
4097
4098 2012-08-29  Jon Lee  <jonlee@apple.com>
4099
4100         [WK2] Basic WTR support for web notifications
4101         https://bugs.webkit.org/show_bug.cgi?id=95154
4102         <rdar://problem/12184492>
4103
4104         Reviewed by Alexey Proskuryakov.
4105
4106         Implement WTR support, without platform event output (bug 95233).
4107
4108         Legacy APIs will not be supported, since many of the tests are skipped
4109         on ports that do test notifications, and the issue with using file:// as the origin means a lot of the permissions
4110         tests won't work. Bugs 81048 and 81697 will track migrating the existing tests to use the new testRunner API, and move
4111         the tests to http/tests/notifications.
4112
4113         Permissions will be handled only in the injected bundle. This allows tests to set permission synchronously, and not
4114         require a chain of setTimeout()'s when writing a notification test. Clicking a notification, however, should
4115         be invoked from the UIProcess.
4116
4117         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4118         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4119         (WTR::InjectedBundle::didReceiveMessage): When told to "Reset", clear out all of the permissions.
4120         (WTR::InjectedBundle::postSimulateWebNotificationClick): Tell the bundle client to simulate a click based on the
4121         notification's internal ID.
4122         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4123         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4124         (WTR::TestRunner::grantWebNotificationPermission): Manually set the permission using WKBundle SPI.
4125         (WTR::TestRunner::denyWebNotificationPermission): Manually set the permission using WKBundle SPI.
4126         (WTR::TestRunner::removeAllWebNotificationPermissions):
4127         (WTR::TestRunner::simulateWebNotificationClick): Post a message through the injected bundle.
4128         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4129
4130         Because supporting web notifications goes beyond a couple functions, move all of the logic into a WebNotificationProvider
4131         class.
4132         * WebKitTestRunner/TestInvocation.cpp:
4133         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): When the injected bundle sends a message to simulate a click,
4134         TestInvocation forwards that request to the TestController.
4135         * WebKitTestRunner/TestController.cpp:
4136         (WTR::TestController::initialize): Set the provider.
4137         (WTR::TestController::resetStateToConsistentValues): Tell the provider to reset.
4138         (WTR::TestController::simulateWebNotificationClick): Tell the provider to simulate a user clicking on a platform notification.
4139         * WebKitTestRunner/TestController.h: Holds an instance to the provider.
4140
4141         The provider maintains a pointer to one notification manager (presumably the web process associated with WTR), and a set
4142         of notification IDs that have been "shown" by the platform. This allows us to simulate a click on a notification.
4143         * WebKitTestRunner/WebNotificationProvider.h: Added.
4144         * WebKitTestRunner/WebNotificationProvider.cpp: Added.
4145         (WTR::WebNotificationProvider::showWebNotification): Adds the notification to set of shown notifications. Notifies provider that
4146         the notification got shown.
4147         (WTR::WebNotificationProvider::closeWebNotification): Removes the notification from the set. Notifies provider that the notification
4148         got closed.
4149         (WTR::WebNotificationProvider::addNotificationManager): Maintains one manager, which is fine for testing purposes.
4150         (WTR::WebNotificationProvider::removeNotificationManager): Maintains one manager.
4151         (WTR::WebNotificationProvider::notificationPermissions): When the web process starts, it maintains an initial set of known
4152         permissions. For testing purposes, we always want this set to be empty.
4153         (WTR::WebNotificationProvider::simulateWebNotificationClick): Notifies provider that the notification got "clicked".
4154         (WTR::WebNotificationProvider::reset): To reset the state, we pretend that we closed all of the platform notifications.
4155
4156         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add WebNotificationProvider.
4157
4158 2012-08-29  Kamil Blank  <k.blank@samsung.com>
4159
4160         [EFL] Add setting API for allow universal/file access from file URLs.
4161         https://bugs.webkit.org/show_bug.cgi?id=83121
4162
4163         Reviewed by Eric Seidel.
4164
4165         Implementation of setAllowUniversalAccessFromFileURLs and setAllowFileAccessFromFileURLs.
4166
4167         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4168         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4169         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4170         (TestRunner::setAllowUniversalAccessFromFileURLs):
4171         (TestRunner::setAllowFileAccessFromFileURLs):
4172
4173 2012-08-29  Jon Lee  <jonlee@apple.com>
4174
4175         Update TestRunner API for web notifications
4176         https://bugs.webkit.org/show_bug.cgi?id=95093
4177         <rdar://problem/12179649>
4178
4179         Reviewed by Alexey Proskuryakov.
4180
4181         As it turns out the patch for this accidentally got squashed into the commit for
4182         bug 95099 (r126909). This amendment patch adds some comments about the renaming
4183         of the older TestRunner API for web notifications.
4184
4185         * DumpRenderTree/TestRunner.h:
4186         (TestRunner):
4187
4188 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
4189
4190         Unreviewed, rolling out r126972.
4191         http://trac.webkit.org/changeset/126972
4192         https://bugs.webkit.org/show_bug.cgi?id=95349
4193
4194         accessibility/canvas-description-and-role.html has been
4195         failing consistently on several bots and Dominic needs some
4196         time to investigate why (Requested by jchaffraix on #webkit).
4197
4198         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
4199         (roleToString):
4200
4201 2012-08-29  Raphael Kubo da Costa  <rakuco@webkit.org>
4202
4203         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
4204         https://bugs.webkit.org/show_bug.cgi?id=84707
4205
4206         Reviewed by Gustavo Noronha Silva.
4207
4208         Most of the warnings have been fixed now that FindCairo.cmake and
4209         FindGLIB.cmake have been rewritten. The remaining one, related to
4210         FindFontconfig.cmake, shows up when building on a 64-bit
4211         Debian-based systems.
4212
4213         jhbuild installs libraries into lib64/ by default on 64-bit Linux
4214         installations, while CMake does not look for libraries in lib64/
4215         when /etc/debian_version exists on the system. The FIND_LIBRARY()
4216         would then sometimes end up using the system installation instead of
4217         the jhbuild one, causing mismatches and, when pkg-config is not used
4218         at all, failing to find libraries altogether.
4219
4220         * efl/jhbuildrc: Set the CMAKE_LIBRARY_PATH environment variable
4221         when use_lib64 is set to force CMake to look into lib64/ regardless
4222         of the presence of /etc/debian_version.
4223
4224 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
4225
4226         The 2d.imageData.object.round canvas test is failing
4227         https://bugs.webkit.org/show_bug.cgi?id=40272
4228
4229         Reviewed by Benjamin Poulain.
4230
4231         Updating patch to address Benjamin's review comments.
4232         Adding a WTF test to test lrint implementation.
4233
4234         * TestWebKitAPI/CMakeLists.txt: Added MathExtras.cpp test file.
4235         * TestWebKitAPI/GNUmakefile.am: Added MathExtras.cpp test file.
4236         * TestWebKitAPI/TestWebKitAPI.gypi: Added MathExtras.cpp test file.
4237         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added MathExtras.cpp test file.
4238         * TestWebKitAPI/Tests/WTF/MathExtras.cpp: Added this test file containing a test for lrint().
4239         (TestWebKitAPI):
4240         (TestWebKitAPI::TEST):
4241         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added MathExtras.cpp test file.
4242
4243 2012-08-29  Florin Malita  <fmalita@chromium.org>
4244
4245         Unreviewed, updating Kelly Norton's email address at his request.
4246
4247         * Scripts/webkitpy/common/config/committers.py:
4248
4249 2012-08-29  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
4250
4251         [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files
4252         https://bugs.webkit.org/show_bug.cgi?id=93723
4253
4254         Reviewed by Dirk Pranke.
4255
4256         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4257         (TestExpectationParser.expectation_for_skipped_test):
4258         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4259         (SkippedTests.test_skipped_entry_dont_exist):
4260
4261 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
4262
4263         Unreviewed, rolling out r120113.
4264         http://trac.webkit.org/changeset/120113
4265         https://bugs.webkit.org/show_bug.cgi?id=95320
4266
4267         Wrong fix for the problem, experimentally rolling it out for
4268         bug 95237. (Requested by rakuco on #webkit).
4269
4270         * efl/jhbuildrc:
4271
4272 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
4273
4274         AX: Canvas should have a distinct role
4275         https://bugs.webkit.org/show_bug.cgi?id=95248
4276
4277         Reviewed by Chris Fleizach.
4278
4279         Add support for canvas accessibility role.
4280
4281         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
4282         (roleToString):
4283
4284 2012-08-28  Eric Seidel  <eric@webkit.org>
4285
4286         cr-ews bot doesn't set CWD correctly when zipping layout test results
4287         https://bugs.webkit.org/show_bug.cgi?id=91265
4288
4289         Reviewed by Kenneth Russell.
4290
4291         This should make the zips slightly less cumbersome to deal with.
4292
4293         * Scripts/webkitpy/common/system/workspace.py:
4294         (Workspace.create_zip):
4295         * Scripts/webkitpy/common/system/workspace_unittest.py:
4296         (WorkspaceTest.test_create_zip):
4297         (WorkspaceTest.test_create_zip_exception):
4298
4299 2012-08-28  Benjamin Poulain  <benjamin@webkit.org>
4300
4301         Fix the Commiters script
4302
4303         Unreviewed.
4304
4305         Remove Roger Fong from the Contributor list, he appears in the Commiter list since r126949.
4306
4307         * Scripts/webkitpy/common/config/committers.py:
4308
4309 2012-08-28  Roger Fong  <roger_fong@apple.com>
4310
4311         Unreviewed. Adding myself to committers list.
4312
4313         * Scripts/webkitpy/common/config/committers.py: