Move ephemeral local storage from WebProcess to UIProcess
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-26  Alex Christensen  <achristensen@webkit.org>
2
3         Move ephemeral local storage from WebProcess to UIProcess
4         https://bugs.webkit.org/show_bug.cgi?id=195074
5         <rdar://problem/47937975>
6
7         Reviewed by Geoff Garen.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10
11 2019-02-20  Jer Noble  <jer.noble@apple.com>
12
13         [Cocoa] Media elements will restart network buffering just before suspending
14         https://bugs.webkit.org/show_bug.cgi?id=193691
15
16         Reviewed by Eric Carlson.
17
18         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
20         (TEST):
21
22 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
23
24         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
25         https://bugs.webkit.org/show_bug.cgi?id=191652
26
27         Reviewed by Alex Christensen.
28
29         Fix WinCairo MiniBrowser behavior of authentication dialog.
30
31         * MiniBrowser/win/WebKitBrowserWindow.cpp:
32         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
33
34 2019-02-26  Youenn Fablet  <youenn@apple.com>
35
36         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
37         https://bugs.webkit.org/show_bug.cgi?id=195028
38         <rdar://problem/48243733>
39
40         Reviewed by Eric Carlson.
41
42         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
43
44 2019-02-26  Philippe Normand  <pnormand@igalia.com>
45
46         [WPE] Add API for webview background color configuration
47         https://bugs.webkit.org/show_bug.cgi?id=192305
48
49         Reviewed by Michael Catanzaro.
50
51         * MiniBrowser/wpe/main.cpp:
52         (main): Add a new option to configure the webview background
53         color. Example: --bg-color=transparent.
54         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
55         (testWebViewBackgroundColor): Enable background color API tests for WPE.
56         (beforeAll): Ditto.
57
58 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
59
60         scalableNativeWebpageParameters() is not preserved on new page navigation.
61         https://bugs.webkit.org/show_bug.cgi?id=194892
62         <rdar://problem/47538280>
63
64         Reviewed by Wenson Hsieh.
65         
66         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
67
68         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
69         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
70         * DumpRenderTree/mac/UIScriptControllerMac.mm:
71         (WTR::UIScriptController::allowsViewportShrinkToFit):
72         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
73         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
74         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
75         * TestRunnerShared/UIScriptContext/UIScriptController.h:
76         * WebKitTestRunner/UIScriptControllerCocoa.mm:
77         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
78
79 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
80
81         [ews-app] Add model for handling multiple Buildbot instances
82         https://bugs.webkit.org/show_bug.cgi?id=194863
83
84         Reviewed by Stephanie Lewis.
85
86         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
87
88 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
89
90         [ews-app] Remove BuilderMapping table
91         https://bugs.webkit.org/show_bug.cgi?id=194961
92
93         Reviewed by Stephanie Lewis.
94
95         Store builder name directly in build table, instead of having a separate
96         table for it.
97
98         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
99         * BuildSlaveSupport/ews-app/ews/models/build.py:
100         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
101         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
102
103 2019-02-25  John Wilander  <wilander@apple.com>
104
105         Introduce and adopt new class RegistrableDomain for eTLD+1
106         https://bugs.webkit.org/show_bug.cgi?id=194791
107         <rdar://problem/48179240>
108
109         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
110
111         This patch adds an API test and replaces two instances of
112         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
113
114         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
115         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
116         (TestWebKitAPI::TEST):
117             Changed two strings to make sure the registrable domains are still considered
118             invalid and pass the test.
119         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
120         (TestWebKitAPI::TEST):
121         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
122         (WTR::InjectedBundle::didReceiveMessageToPage):
123
124 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
125
126         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
127         https://bugs.webkit.org/show_bug.cgi?id=195001
128
129         Reviewed by Carlos Garcia Campos.
130
131         API version 1.0 always includes the functionality previously guarded with
132         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
133         unconditionally.
134
135         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
136         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
137         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
138         (WebViewTest::showInWindow): Ditto.
139         (WebViewTest::hideView): Ditto.
140         * wpe/backends/HeadlessViewBackend.cpp:
141         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
142         * wpe/backends/ViewBackend.cpp:
143         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
144         * wpe/backends/WindowViewBackend.cpp:
145         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
146         WPE_BACKEND_CHECK_VERSION().
147         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
148
149 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
150
151         [Flatpak] Add support for flatpak > 1.1.2
152         https://bugs.webkit.org/show_bug.cgi?id=194088
153
154         Flatpak 1.2 is now out so we need to support that
155         version now.
156
157         Reviewed by Michael Catanzaro.
158
159         * flatpak/flatpakutils.py:
160         (check_flatpak):
161         (FlatpakPackages.__init__):
162         (FlatpakPackages.__detect_packages):
163         (FlatpakPackages.__detect_packages.in):
164         (FlatpakRepos.update):
165
166 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
167
168         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
169         https://bugs.webkit.org/show_bug.cgi?id=194998
170
171         Reviewed by Carlos Garcia Campos.
172
173         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
174         to a Git checkout and using the latest commit containing various fixes
175         and improvements.
176
177 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
178
179         [WPE][GTK] Remove user agent quirk for washingtonpost.com
180         https://bugs.webkit.org/show_bug.cgi?id=194981
181
182         Reviewed by Žan Doberšek.
183
184         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
185         (TestWebKitAPI::TEST):
186
187 2019-02-23  Keith Miller  <keith_miller@apple.com>
188
189         Add new mac target numbers
190         https://bugs.webkit.org/show_bug.cgi?id=194955
191
192         Reviewed by Tim Horton.
193
194         * DumpRenderTree/mac/Configurations/Base.xcconfig:
195         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
196         * MiniBrowser/Configurations/Base.xcconfig:
197         * TestWebKitAPI/Configurations/Base.xcconfig:
198         * WebKitTestRunner/Configurations/Base.xcconfig:
199
200 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
201
202         [WinCairo] Enable wk1/wk2 suffix for platform search path.
203         https://bugs.webkit.org/show_bug.cgi?id=194846
204
205         Reviewed by Don Olmstead.
206
207         Added _search_paths() and _port_specific_expectations_files() for
208         WinCairoPort.
209
210         * Scripts/webkitpy/port/win.py:
211         (WinCairoPort.default_baseline_search_path):
212         (WinCairoPort):
213         (WinCairoPort._port_specific_expectations_files):
214         (WinCairoPort._search_paths):
215
216 2019-02-22  Tim Horton  <timothy_horton@apple.com>
217
218         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
219         https://bugs.webkit.org/show_bug.cgi?id=194963
220
221         Reviewed by Dean Jackson.
222
223         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
224         Do a `contains` check instead of `equals`, because in debug builds we
225         put the GraphicsLayer pointer in a prefix.
226
227 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
228
229         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
230         https://bugs.webkit.org/show_bug.cgi?id=194873
231         <rdar://problem/46701974>
232
233         Reviewed by Tim Horton.
234
235         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
236
237         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
238         (WTR::UIScriptController::menuRect const):
239         (WTR::UIScriptController::isShowingMenu const):
240         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
241         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
242         (WTR::UIScriptController::menuRect const):
243
244         Add a function to query the bounds of the callout menu in content coordinates.
245
246         (WTR::UIScriptController::isShowingMenu const):
247
248         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
249
250         * TestRunnerShared/UIScriptContext/UIScriptController.h:
251         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
252         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
253         (WTR::UIScriptController::rectForMenuAction const):
254         (WTR::UIScriptController::menuRect const):
255         (WTR::UIScriptController::isShowingMenu const):
256         (WTR::findViewInHierarchyOfType): Deleted.
257
258 2019-02-22  Chris Dumez  <cdumez@apple.com>
259
260         Regression(PSON) Unable to preview password-protected documents on iCloud.com
261         https://bugs.webkit.org/show_bug.cgi?id=194954
262         <rdar://problem/48127957>
263
264         Reviewed by Alex Christensen.
265
266         Add API test coverage.
267
268         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
269         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
270         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
271         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
272
273 2019-02-22  Chris Dumez  <cdumez@apple.com>
274
275         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
276         https://bugs.webkit.org/show_bug.cgi?id=194924
277         <rdar://problem/48216125>
278
279         Reviewed by Geoffrey Garen.
280
281         Add API test coverage.
282
283         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
284
285 2019-02-22  Chris Dumez  <cdumez@apple.com>
286
287         Unreviewed, disable API test added in r241928 on iOS.
288
289         The cache is not enabled on devices with less than 3GB of RAM.
290
291         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
292
293 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
294
295         Hardcode Visual Viewports on everywhere except iOS WK1
296         https://bugs.webkit.org/show_bug.cgi?id=194928
297
298         Reviewed by Zalan Bujtas.
299
300         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
301         change the default value of the Setting to 'true', and hardcode WebView on iOS to
302         set it to false. The setting has shipped for several years and there's no need to turn
303         it off now.
304
305         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
306         Visual Viewports are not enabled.
307         
308         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
309         that only runs in WK2
310
311         * MiniBrowser/mac/SettingsController.h:
312         * MiniBrowser/mac/SettingsController.m:
313         (-[SettingsController init]):
314         (-[SettingsController _populateMenu]):
315         (-[SettingsController validateMenuItem:]):
316         (-[SettingsController visualViewportEnabled]): Deleted.
317         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
318         * MiniBrowser/mac/WK1BrowserWindowController.m:
319         (-[WK1BrowserWindowController didChangeSettings]):
320         * MiniBrowser/mac/WK2BrowserWindowController.m:
321         (-[WK2BrowserWindowController didChangeSettings]):
322
323 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
324
325         Discard cached processes when clearing website data store
326         https://bugs.webkit.org/show_bug.cgi?id=194894
327
328         Reviewed by Chris Dumez.
329
330         Added a test case.
331
332         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
333         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
334
335 2019-02-21  Alex Christensen  <achristensen@webkit.org>
336
337         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
338         https://bugs.webkit.org/show_bug.cgi?id=194914
339         <rdar://problem/47586889>
340
341         Reviewed by Geoffrey Garen.
342
343         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
344         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
345         (TEST):
346         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
347
348 2019-02-21  David Kilzer  <ddkilzer@apple.com>
349
350         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
351         <https://webkit.org/b/194761>
352
353         Reviewed by Myles Maxfield.
354
355         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
356         (WTR::activateSystemCoreWebFonts): Log `error` to console if
357         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
358         to use ARC-compliant cast.
359         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
360         ARC-compliant cast.
361         (WTR::installFakeHelvetica): Log `error` to console if
362         CTFontManagerRegisterFontsForURL() fails, but only on supported
363         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
364         Call CFRelease() on `error` to fix the leak.  Update to use
365         ARC-compliant cast.
366         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
367         cast.
368
369 2019-02-21  Chris Dumez  <cdumez@apple.com>
370
371         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
372         https://bugs.webkit.org/show_bug.cgi?id=194481
373
374         Reviewed by Alex Christensen.
375
376         Give the processes a chance to shutdown and wait until we reached the expected number
377         of processes.
378
379         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
380
381 2019-02-21  Tim Horton  <timothy_horton@apple.com>
382
383         Fix the macOS build
384
385         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
386
387 2019-02-21  Tim Horton  <timothy_horton@apple.com>
388
389         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
390
391         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
392         I am a backwards.
393
394 2019-02-21  Tim Horton  <timothy_horton@apple.com>
395
396         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
397
398         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
399         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
400         We could force on UI-side compositing, but I feel like the test might be more
401         valuable exercising the normal path on each platform (though the original
402         bug was also UI-side specific). Though we can't validate that the overlay
403         layer was installed successfully, there are layout tests that do that.
404
405 2019-02-21  Tim Horton  <timothy_horton@apple.com>
406
407         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
408         https://bugs.webkit.org/show_bug.cgi?id=194845
409         <rdar://problem/47944579>
410
411         Reviewed by Antti Koivisto.
412
413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
414         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
415
416 2019-02-21  Zalan Bujtas  <zalan@apple.com>
417
418         [LFC][Floats] Add support for placing formatting roots in-between floats.
419         https://bugs.webkit.org/show_bug.cgi?id=194902
420
421         Reviewed by Antti Koivisto.
422
423         * LayoutReloaded/misc/LFC-passing-tests.txt:
424
425 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
426
427         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
428         https://bugs.webkit.org/show_bug.cgi?id=194901
429
430         Unreviewed build fix.
431
432         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
433         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
434         WPEBackend-fdo-0.1 as library name.
435
436 2019-02-21  Rob Buis  <rbuis@igalia.com>
437
438         Update MIME type parser
439         https://bugs.webkit.org/show_bug.cgi?id=180526
440
441         Reviewed by Darin Adler.
442
443         Add tests involving leading and trailing whitespace, non-token
444         characters and quoted strings.
445
446         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
447         (TestWebKitAPI::TEST):
448
449 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
450
451         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
452         https://bugs.webkit.org/show_bug.cgi?id=194884
453
454         Reviewed by Michael Catanzaro.
455
456         * PlatformWin.cmake:
457
458 2019-02-20  Chris Dumez  <cdumez@apple.com>
459
460         Add API test for <rdar://problem/47471222>
461         https://bugs.webkit.org/show_bug.cgi?id=194847
462
463         Reviewed by Alex Christensen.
464
465         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
466
467 2019-02-20  Chris Dumez  <cdumez@apple.com>
468
469         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
470         https://bugs.webkit.org/show_bug.cgi?id=194872
471         <rdar://problem/47924500>
472
473         Reviewed by Alex Christensen.
474
475         Add API test coverage.
476
477         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
478
479 2019-02-20  Jer Noble  <jer.noble@apple.com>
480
481         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
482         https://bugs.webkit.org/show_bug.cgi?id=191332
483
484         Reviewed by Dean Jackson.
485
486         * Scripts/git-is-in-range: Added.
487
488 2019-02-20  Andy Estes  <aestes@apple.com>
489
490         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
491         https://bugs.webkit.org/show_bug.cgi?id=194869
492
493         Rubber-stamped by Jer Noble.
494
495         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
496         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
497         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
498         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
499         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
500         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
501
502 2019-02-20  Chris Dumez  <cdumez@apple.com>
503
504         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
505         https://bugs.webkit.org/show_bug.cgi?id=194857
506         <rdar://problem/47759323>
507
508         Reviewed by Alex Christensen.
509
510         Add API test coverage.
511
512         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
513
514 2019-02-20  Chris Dumez  <cdumez@apple.com>
515
516         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
517         https://bugs.webkit.org/show_bug.cgi?id=194829
518         <rdar://problem/47889906>
519
520         Reviewed by Alexey Proskuryakov.
521
522         Every time the TestOptions were changing we were creating both a new Web view and
523         a new WKContext, which would start a new Network process. In most cases, we only
524         need to contruct a new Web view and we do can keep reusing the same WKContext.
525         This patch implements this optimization and thus avoids spinning a lot of new
526         Network processes while running the layout tests.
527
528         * WebKitTestRunner/TestController.cpp:
529         (WTR::TestController::generateContextConfiguration const):
530         (WTR::TestController::generatePageConfiguration):
531         (WTR::TestController::createWebViewWithOptions):
532         (WTR::TestController::resetPreferencesToConsistentValues):
533         (WTR::updateTestOptionsFromTestHeader):
534         * WebKitTestRunner/TestController.h:
535         * WebKitTestRunner/TestOptions.h:
536         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
537         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
538         (WTR::TestOptions::hasSameInitializationOptions const):
539         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
540         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
541         (WTR::TestController::platformAddTestOptions const):
542
543 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
544
545         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
546         https://bugs.webkit.org/show_bug.cgi?id=167941
547
548         Reviewed by Carlos Garcia Campos.
549
550         * MiniBrowser/gtk/main.c:
551         (filterSavedCallback): Added.
552         (main): Support loading a JSON rule set file for content filtering.
553         * MiniBrowser/wpe/main.cpp:
554         (filterSavedCallback): Added.
555         (main): Support loading a JSON rule set file for content filtering.
556         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
557         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
558         (WTF::derefGPtr): Ditto.
559         (testEmptyStore):
560         (testSaveInvalidFilter):
561         (testSaveLoadFilter):
562         (testSavedFilterIdentifierMatch):
563         (testRemoveFilter):
564         (testSaveMultipleFilters):
565         (testSaveFilterFromFile):
566         (testFilterPersistence):
567         (beforeAll):
568         (afterAll):
569         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
570         (removeOldInjectedContentAndResetLists): Also reset content filters.
571         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
572         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
573         the element affected by the style sheet.
574         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
575         and returns it to be used by tests.
576         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
577         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
578         (serverCallback): Add support for serving a CSS style sheet for testing.
579         (beforeAll): Add call to testUserContentManagerContentFilter().
580         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
581
582 2019-02-19  Keith Rollin  <krollin@apple.com>
583
584         Add timing information to build output
585         https://bugs.webkit.org/show_bug.cgi?id=194839
586         <rdar://problem/48219609>
587
588         Reviewed by Alexey Proskuryakov.
589
590         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
591         emit each project's build time to its output. E.g.,
592
593             ** BUILD SUCCEEDED ** [0.132 sec]
594
595         * Scripts/webkitdirs.pm:
596         (XcodeOptions):
597
598 2019-02-19  Truitt Savell  <tsavell@apple.com>
599
600         Unreviewed, rolling out r241784.
601
602         Broke all OpenSource builds.
603
604         Reverted changeset:
605
606         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
607         instances view"
608         https://bugs.webkit.org/show_bug.cgi?id=172848
609         https://trac.webkit.org/changeset/241784
610
611 2019-02-19  Zalan Bujtas  <zalan@apple.com>
612
613         [LFC][Floats] Remove redundant intersecting logic
614         https://bugs.webkit.org/show_bug.cgi?id=194804
615
616         Reviewed by Antti Koivisto.
617
618         * LayoutReloaded/misc/LFC-passing-tests.txt:
619
620 2019-02-19  Dean Jackson  <dino@apple.com>
621
622         Clean-up output from generate-xcfilelists so it can be filtered
623         https://bugs.webkit.org/show_bug.cgi?id=194795
624
625         Reviewed by Joseph Pecoraro (and Keith Rollin).
626
627         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
628         make a slight tweak to filter-build-webkit so such lines are marked
629         as plain.
630
631         * Scripts/filter-build-webkit:
632         * Scripts/generate-xcfilelists:
633
634 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
635
636         pytest is not correctly auto-installed
637         https://bugs.webkit.org/show_bug.cgi?id=194707
638
639         Reviewed by Carlos Garcia Campos.
640
641         * Scripts/webkitpy/thirdparty/__init__.py:
642         (AutoinstallImportHook._install_pytest):
643
644 2019-02-18  Chris Dumez  <cdumez@apple.com>
645
646         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
647         https://bugs.webkit.org/show_bug.cgi?id=194797
648         <rdar://problem/48055151>
649
650         Reviewed by Geoffrey Garen.
651
652         Add API test coverage.
653
654         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
655
656 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
657
658         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
659         https://bugs.webkit.org/show_bug.cgi?id=194670
660         <rdar://problem/39066529>
661
662         Reviewed by Tim Horton.
663
664         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
665         pasted in an editable area as attachment elements.
666
667         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
668         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
669         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
670         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
671         (TestWebKitAPI::TEST):
672         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
673         (WTR::InjectedBundlePage::InjectedBundlePage):
674
675 2019-02-18  Alex Christensen  <achristensen@webkit.org>
676
677         Fix API test after r241728
678        ​https://bugs.webkit.org/show_bug.cgi?id=194723
679
680         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
681         (TEST):
682         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
683
684 2019-02-18  Daniel Bates  <dabates@apple.com>
685
686         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
687         https://bugs.webkit.org/show_bug.cgi?id=192824
688         <rdar://problem/47100332>
689
690         Reviewed by Wenson Hsieh.
691
692         Fix a bug where the wrong usage code was used for F13 thru F24.
693
694         * WebKitTestRunner/ios/HIDEventGenerator.mm:
695         (keyCodeForDOMFunctionKey):
696
697 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
698
699         Bytecode cache should a have a boot-specific validation
700         https://bugs.webkit.org/show_bug.cgi?id=194769
701         <rdar://problem/48149509>
702
703         Reviewed by Keith Miller.
704
705         Add test for WTF::bootSessionUUIDString()
706
707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
708         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
709         (TEST):
710
711 2019-02-18  Alex Christensen  <achristensen@webkit.org>
712
713         Disable safe browsing in WKWebView and remove its WKPreferences API
714         https://bugs.webkit.org/show_bug.cgi?id=194723
715         <rdar://problem/48122993>
716
717         Reviewed by Geoffrey Garen.
718
719         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
720         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
721         (TEST):
722         (safeBrowsingView):
723         Make tests use SPI instead of API.
724
725 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
726
727         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
728         https://bugs.webkit.org/show_bug.cgi?id=194586
729
730         Reviewed by Ross Kirsling.
731
732         * DumpRenderTree/win/DumpRenderTree.cpp:
733         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
734         * Scripts/webkitpy/port/driver.py:
735         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
736
737 2019-02-17  David Kilzer  <ddkilzer@apple.com>
738
739         Unreviewed, rolling out r241620.
740
741         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
742         (Requested by ddkilzer on #webkit.)
743
744         Reverted changeset:
745
746         "[WTF] Add environment variable helpers"
747         https://bugs.webkit.org/show_bug.cgi?id=192405
748         https://trac.webkit.org/changeset/241620
749
750 2019-02-16  Zalan Bujtas  <zalan@apple.com>
751
752         [LFC] RenderImage's default intrinsic size is 0.
753         https://bugs.webkit.org/show_bug.cgi?id=194745
754
755         Reviewed by Antti Koivisto.
756
757         * LayoutReloaded/misc/LFC-passing-tests.txt:
758
759 2019-02-16  Zalan Bujtas  <zalan@apple.com>
760
761         [LFC][BFC] Add support for block replaced intrinsic width.
762         https://bugs.webkit.org/show_bug.cgi?id=194705
763
764         Reviewed by Simon Fraser.
765
766         * LayoutReloaded/misc/LFC-passing-tests.txt:
767
768 2019-02-16  Zalan Bujtas  <zalan@apple.com>
769
770         [LFC] Apply min/max width constraints to preferred width computation
771         https://bugs.webkit.org/show_bug.cgi?id=194739
772
773         Reviewed by Simon Fraser.
774
775         * LayoutReloaded/misc/LFC-passing-tests.txt:
776
777 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
778
779         [WTF] Add environment variable helpers
780         https://bugs.webkit.org/show_bug.cgi?id=192405
781
782         Reviewed by Michael Catanzaro.
783
784         * DumpRenderTree/mac/DumpRenderTree.mm:
785         (libraryPathForDumpRenderTree):
786         * DumpRenderTree/win/DumpRenderTree.cpp:
787         (libraryPathForDumpRenderTree):
788         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
789         (setUpIOSLayoutTestCommunication):
790         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
791         (beforeAll):
792         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
793         (main):
794         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
795         (WebKitTestBus::run):
796         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
797         (WTR::getOutputDir):
798         (WTR::initializeFontConfigSetting):
799         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
800         (WTR::InjectedBundle::platformInitialize):
801         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
802         (WTR::topLevelPath):
803         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
804         (WTR::topLevelPath):
805         (WTR::getOutputDir):
806         (WTR::activateFonts):
807         * WebKitTestRunner/TestController.cpp:
808         (WTR::TestController::libraryPathForTesting):
809         (WTR::TestController::generateContextConfiguration const):
810         (WTR::TestController::generatePageConfiguration):
811         (WTR::TestController::decideDestinationWithSuggestedFilename):
812         (WTR::TestController::platformAdjustContext):
813         * WebKitTestRunner/TestController.h:
814         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
815         (WTR::TestController::cocoaPlatformInitialize):
816         (WTR::TestController::platformAdjustContext):
817         * WebKitTestRunner/gtk/main.cpp:
818         (main):
819         * WebKitTestRunner/mac/TestControllerMac.mm:
820         (WTR::TestController::configureContentExtensionForTest):
821         * WebKitTestRunner/wpe/main.cpp:
822         (main):
823         Utilize WTF::Environment where possible.
824
825 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
826
827         [iOS] WKWebView callout bar is missing Change Writing Direction item
828         https://bugs.webkit.org/show_bug.cgi?id=190015
829         <rdar://problem/44810366>
830
831         Reviewed by Tim Horton.
832
833         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
834         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
835
836         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
837         (TestWebKitAPI::TEST):
838
839 2019-02-15  Chris Dumez  <cdumez@apple.com>
840
841         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
842         https://bugs.webkit.org/show_bug.cgi?id=194717
843         <rdar://problem/47884404>
844
845         Reviewed by Brady Eidson.
846
847         Add API test coverage.
848
849         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
850
851 2019-02-15  Youenn Fablet  <youenn@apple.com>
852
853         Make navigator.mediaDevices SecureContext
854         https://bugs.webkit.org/show_bug.cgi?id=194666
855
856         Reviewed by Eric Carlson.
857
858         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
859         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
860         (TEST_F):
861
862 2019-02-15  Brian Burg  <bburg@apple.com>
863
864         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
865         https://bugs.webkit.org/show_bug.cgi?id=194411
866         <rdar://problem/47787614>
867
868         Reviewed by Joseph Pecoraro.
869
870         Remove unnecessary soft linking macro usage.
871
872         * DumpRenderTree/mac/TestRunnerMac.mm:
873         (TestRunner::inspectorTestStubURL):
874         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
875         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
876         (WTR::TestRunner::inspectorTestStubURL):
877
878 2019-02-15  Commit Queue  <commit-queue@webkit.org>
879
880         Unreviewed, rolling out r241559 and r241566.
881         https://bugs.webkit.org/show_bug.cgi?id=194710
882
883         Causes layout test crashes under GuardMalloc (Requested by
884         ryanhaddad on #webkit).
885
886         Reverted changesets:
887
888         "[WTF] Add environment variable helpers"
889         https://bugs.webkit.org/show_bug.cgi?id=192405
890         https://trac.webkit.org/changeset/241559
891
892         "Unreviewed build fix for WinCairo Debug after r241559."
893         https://trac.webkit.org/changeset/241566
894
895 2019-02-15  Zalan Bujtas  <zalan@apple.com>
896
897         [LFC] Out-of-flow box is never a float box
898         https://bugs.webkit.org/show_bug.cgi?id=194704
899
900         Reviewed by Antti Koivisto.
901
902         * LayoutReloaded/misc/LFC-passing-tests.txt:
903
904 2019-02-10  Darin Adler  <darin@apple.com>
905
906         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
907         https://bugs.webkit.org/show_bug.cgi?id=194487
908
909         Reviewed by Daniel Bates.
910
911         * DumpRenderTree/win/DumpRenderTree.cpp:
912         (applicationId): Use makeString instead of String::format.
913         (main): Ditto.
914         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
915         (TestWebKitAPI::Util::createURLForResource): Ditto.
916         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
917         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
918
919         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
920         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
921         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
922         (WTR::createStringWithAttributes): Use appendLiteral.
923         (WTR::AccessibilityUIElement::helpText const): Ditto.
924         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
925         directly instead of using String::format.
926         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
927         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
928
929 2019-02-15  Truitt Savell  <tsavell@apple.com>
930
931         Unreviewed, rolling out r241564.
932
933         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
934
935         Reverted changeset:
936
937         "[Mac] WebInspectorUI.framework does not need to be soft-
938         linked anymore"
939         https://bugs.webkit.org/show_bug.cgi?id=194411
940         https://trac.webkit.org/changeset/241564
941
942 2019-02-15  Saam barati  <sbarati@apple.com>
943
944         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
945         https://bugs.webkit.org/show_bug.cgi?id=194036
946
947         Reviewed by Yusuke Suzuki.
948
949         * Scripts/run-jsc-stress-tests:
950
951 2019-02-14  Tim Horton  <timothy_horton@apple.com>
952
953         Fix the build.
954
955         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
956         (WTR::UIScriptController::drawSquareInEditableImage):
957         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
958         (TestWebKitAPI::drawSquareInEditableImage):
959
960 2019-02-14  Tim Horton  <timothy_horton@apple.com>
961
962         Fix the build.
963
964         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
965         (WTR::UIScriptController::drawSquareInEditableImage):
966         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
967         (TestWebKitAPI::drawSquareInEditableImage):
968
969 2019-02-14  Brian Burg  <bburg@apple.com>
970
971         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
972         https://bugs.webkit.org/show_bug.cgi?id=194411
973         <rdar://problem/47787614>
974
975         Reviewed by Joseph Pecoraro.
976
977         Remove unnecessary soft linking macro usage.
978
979         * DumpRenderTree/mac/TestRunnerMac.mm:
980         (TestRunner::inspectorTestStubURL):
981         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
982         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
983         (WTR::TestRunner::inspectorTestStubURL):
984
985 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
986
987         [ews-app] status bubble should fetch builder name info from BuilderMapping table
988         https://bugs.webkit.org/show_bug.cgi?id=194599
989
990         Reviewed by Lucas Forschler.
991
992         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
993         (StatusBubble._build_bubble):
994
995 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
996
997         [ews-app] Set Foreign Key in Django build model
998         https://bugs.webkit.org/show_bug.cgi?id=194667
999
1000         Reviewed by Lucas Forschler.
1001
1002         * BuildSlaveSupport/ews-app/ews/models/build.py:
1003         (Build):
1004
1005 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1006
1007         [WTF] Add environment variable helpers
1008         https://bugs.webkit.org/show_bug.cgi?id=192405
1009
1010         Reviewed by Michael Catanzaro.
1011
1012         * DumpRenderTree/mac/DumpRenderTree.mm:
1013         (libraryPathForDumpRenderTree):
1014         * DumpRenderTree/win/DumpRenderTree.cpp:
1015         (libraryPathForDumpRenderTree):
1016         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1017         (setUpIOSLayoutTestCommunication):
1018         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1019         (TestWebKitAPI::strip):
1020         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1021         (beforeAll):
1022         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1023         (main):
1024         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1025         (WebKitTestBus::run):
1026         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1027         (WTR::getOutputDir):
1028         (WTR::initializeFontConfigSetting):
1029         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1030         (WTR::InjectedBundle::platformInitialize):
1031         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1032         (WTR::topLevelPath):
1033         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1034         (WTR::topLevelPath):
1035         (WTR::getOutputDir):
1036         (WTR::activateFonts):
1037         * WebKitTestRunner/TestController.cpp:
1038         (WTR::TestController::libraryPathForTesting):
1039         (WTR::TestController::generateContextConfiguration const):
1040         (WTR::TestController::generatePageConfiguration):
1041         (WTR::TestController::decideDestinationWithSuggestedFilename):
1042         (WTR::TestController::platformAdjustContext):
1043         * WebKitTestRunner/TestController.h:
1044         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1045         (WTR::TestController::cocoaPlatformInitialize):
1046         (WTR::TestController::platformAdjustContext):
1047         * WebKitTestRunner/gtk/main.cpp:
1048         (main):
1049         * WebKitTestRunner/mac/TestControllerMac.mm:
1050         (WTR::TestController::configureContentExtensionForTest):
1051         * WebKitTestRunner/wpe/main.cpp:
1052         (main):
1053         Utilize WTF::Environment where possible.
1054
1055 2019-02-14  Chris Dumez  <cdumez@apple.com>
1056
1057         [PSON] Introduce a WebContent Process cache
1058         https://bugs.webkit.org/show_bug.cgi?id=194594
1059         <rdar://problem/46793397>
1060
1061         Reviewed by Geoff Garen.
1062
1063         Update API tests to turn on the WebContent Process cache.
1064
1065         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1066
1067 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1068
1069         Unreviewed, build fix after r241480
1070
1071         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1072         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1073         (-[DragAndDropSimulator initWithWebView:]):
1074
1075 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1076
1077         AX: ARIA Reflection was disabled in error
1078         https://bugs.webkit.org/show_bug.cgi?id=194647
1079         <rdar://problem/48068336>
1080
1081         Reviewed by Ryosuke Niwa.
1082
1083         Remove test override now that this feature should be enabled by default.
1084
1085         * WebKitTestRunner/TestController.cpp:
1086         (WTR::TestController::resetPreferencesToConsistentValues):
1087
1088 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1089
1090         Unreviewed, rolling out r241486.
1091         https://bugs.webkit.org/show_bug.cgi?id=194655
1092
1093         causing API failures in builds (Requested by ShawnRoberts on
1094         #webkit).
1095
1096         Reverted changeset:
1097
1098         "[Cocoa] Media elements will restart network buffering just
1099         before suspending"
1100         https://bugs.webkit.org/show_bug.cgi?id=193691
1101         https://trac.webkit.org/changeset/241486
1102
1103 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1104
1105         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1106         https://bugs.webkit.org/show_bug.cgi?id=194622
1107
1108         Reviewed by Antti Koivisto.
1109
1110         * LayoutReloaded/misc/LFC-passing-tests.txt:
1111
1112 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1113
1114         [LFC] Shrink-to-fit-width should be constrained by min/max width
1115         https://bugs.webkit.org/show_bug.cgi?id=194653
1116
1117         Reviewed by Antti Koivisto.
1118
1119         * LayoutReloaded/misc/LFC-passing-tests.txt:
1120
1121 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1122
1123         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1124         https://bugs.webkit.org/show_bug.cgi?id=194641
1125
1126         Reviewed by Geoffrey Garen.
1127
1128         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1129         so that the test would fail without this fix.
1130
1131         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1132         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1133
1134 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1135
1136         [ews-app] Change log level for a log statement
1137
1138         Unreviewed minor fix.
1139
1140         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1141         (Patch.save_patch):
1142
1143 2019-02-13  Jer Noble  <jer.noble@apple.com>
1144
1145         [Cocoa] Media elements will restart network buffering just before suspending
1146         https://bugs.webkit.org/show_bug.cgi?id=193691
1147
1148         Reviewed by Eric Carlson.
1149
1150         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1151         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1152         (TEST):
1153
1154 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1155
1156         [ews-app] Fetch builder id to name mapping
1157         https://bugs.webkit.org/show_bug.cgi?id=194355
1158
1159         Reviewed by Lucas Forschler.
1160
1161         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1162         (Buildbot.get_builder_id_to_name_mapping):
1163         (Buildbot._get_display_name_from_builder_name):
1164
1165 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1166
1167         Further restricting webarchive loads
1168         https://bugs.webkit.org/show_bug.cgi?id=194567
1169         <rdar://problem/47610130>
1170
1171         Reviewed by Youenn Fablet.
1172
1173         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1174         navigations on drop.
1175
1176         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1177         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1178         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1179         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1180         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1181         (TestWebKitAPI::TEST):
1182         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1183         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1184         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1185         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1186         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1187         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1188         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1189
1190 2019-02-13  John Wilander  <wilander@apple.com>
1191
1192         Store Ad Click Attribution requests in the network process
1193         https://bugs.webkit.org/show_bug.cgi?id=194510
1194         <rdar://problem/47650118>
1195
1196         Reviewed by Alex Christensen and Daniel Bates.
1197
1198         This patch adds two TestRunner functions:
1199         - dumpAdClickAttribution()
1200         - clearAdClickAttribution()
1201
1202         They call into the network process to dump and clear Ad Click
1203         Attribution state, respectively.
1204
1205         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1206         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1207         (WTR::TestRunner::dumpAdClickAttribution):
1208         (WTR::TestRunner::clearAdClickAttribution):
1209         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1210         * WebKitTestRunner/TestController.cpp:
1211         (WTR::TestController::resetStateToConsistentValues):
1212         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1213         (WTR::adClickAttributionStringResultCallback):
1214         (WTR::TestController::dumpAdClickAttribution):
1215         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1216         (WTR::adClickAttributionVoidCallback):
1217         (WTR::TestController::clearAdClickAttribution):
1218         * WebKitTestRunner/TestController.h:
1219         * WebKitTestRunner/TestInvocation.cpp:
1220         (WTR::TestInvocation::dumpResults):
1221         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1222         (WTR::TestInvocation::dumpAdClickAttribution):
1223         * WebKitTestRunner/TestInvocation.h:
1224
1225 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1226
1227         [ews-app] Generate status-bubble
1228         https://bugs.webkit.org/show_bug.cgi?id=194572
1229
1230         Reviewed by Lucas Forschler.
1231
1232         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1233         (StatusBubble._build_bubble):
1234         (StatusBubble._should_show_bubble_for):
1235         (StatusBubble._build_bubbles_for_patch):
1236
1237 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1238
1239         [ews-app] Add status bubble html template
1240         https://bugs.webkit.org/show_bug.cgi?id=194571
1241
1242         Reviewed by Lucas Forschler.
1243
1244         * BuildSlaveSupport/ews-app/ews/templates: Added.
1245         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1246
1247 2019-02-12  Chris Dumez  <cdumez@apple.com>
1248
1249         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1250         https://bugs.webkit.org/show_bug.cgi?id=194568
1251         <rdar://problem/47944490>
1252
1253         Reviewed by Ryosuke Niwa.
1254
1255         Add API test coverage.
1256
1257         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1258         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1259
1260 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1261
1262         webkitpy: Remove bug_dummy from parsed test expectations
1263         https://bugs.webkit.org/show_bug.cgi?id=194562
1264         <rdar://problem/47853999>
1265
1266         Reviewed by Lucas Forschler.
1267
1268         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1269         (TestExpectationParser):
1270         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1271         skipped tests.
1272         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1273
1274 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1275
1276         [ews-app] Add method to fetch patch
1277         https://bugs.webkit.org/show_bug.cgi?id=194518
1278
1279         Reviewed by Lucas Forschler.
1280
1281         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1282         (Patch.get_patch):
1283
1284 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1285
1286         [LFC] Expand tests coverage (60 new tests -> 860)
1287
1288         Unreviewed test gardening (run-singly, --child-processes=1).
1289
1290         * LayoutReloaded/misc/LFC-passing-tests.txt:
1291
1292 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1293
1294         Allow pages to trigger programmatic paste from script on iOS
1295         https://bugs.webkit.org/show_bug.cgi?id=194271
1296         <rdar://problem/47808810>
1297
1298         Reviewed by Tim Horton.
1299
1300         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1301
1302         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1303         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1304         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1305         (WTR::UIScriptController::rectForMenuAction const):
1306
1307         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1308         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1309         for when the menu is shown or hidden.
1310
1311         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1312         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1313         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1314         (WTR::UIScriptController::setDidShowMenuCallback):
1315         (WTR::UIScriptController::didShowMenuCallback const):
1316         (WTR::UIScriptController::setDidHideMenuCallback):
1317         (WTR::UIScriptController::didHideMenuCallback const):
1318         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1319         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1320         (WTR::UIScriptController::rectForMenuAction const):
1321         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1322         * WebKitTestRunner/TestController.cpp:
1323         (WTR::TestController::resetPreferencesToConsistentValues):
1324         (WTR::updateTestOptionsFromTestHeader):
1325         * WebKitTestRunner/TestOptions.h:
1326
1327         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1328         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1329
1330         (WTR::TestOptions::hasSameInitializationOptions const):
1331         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1332         (WTR::UIScriptController::calendarType const):
1333         (WTR::UIScriptController::platformUndoManager const):
1334         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1335         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1336         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1337         (-[TestRunnerWKWebView dealloc]):
1338         (-[TestRunnerWKWebView _didShowMenu]):
1339         (-[TestRunnerWKWebView _didHideMenu]):
1340
1341         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1342
1343         * WebKitTestRunner/ios/TestControllerIOS.mm:
1344         (WTR::handleMenuWillHideNotification):
1345         (WTR::handleMenuDidHideNotification):
1346         (WTR::TestController::platformInitialize):
1347         (WTR::TestController::platformDestroy):
1348         (WTR::TestController::platformResetStateToConsistentValues):
1349
1350         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1351         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1352
1353         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1354         (WTR::forEachViewInHierarchy):
1355         (WTR::findViewInHierarchyOfType):
1356
1357         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1358         functions that dig through a given view's hierarchy in search of a view of a given class.
1359
1360         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1361         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1362         (WTR::UIScriptController::selectionCaretViewRect const):
1363         (WTR::UIScriptController::selectionRangeViewRects const):
1364         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1365         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1366
1367         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1368
1369         (WTR::UIScriptController::rectForMenuAction const):
1370
1371         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1372         callout bar) whose label matches the given string.
1373
1374         (WTR::UIScriptController::platformContentView const):
1375
1376         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1377         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1378         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1379
1380         (WTR::UIScriptController::platformUndoManager const): Deleted.
1381         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1382         (WTR::UIScriptController::platformContentView const):
1383         (WTR::UIScriptController::platformUndoManager const): Deleted.
1384
1385 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1386
1387         webkitpy: No option to only show unexpected failures in results.html for iPad
1388         https://bugs.webkit.org/show_bug.cgi?id=194554
1389         <rdar://problem/47922442>
1390
1391         Rubber-stamped by Aakash Jain.
1392
1393         Just because a TestExpecations file does not exist for a specific platform does not mean that
1394         TestExpecations are not being used, given that platforms inherit test expectations.
1395
1396         * Scripts/webkitpy/port/base.py:
1397         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1398         * Scripts/webkitpy/port/base_unittest.py:
1399         (PortTest.test_uses_test_expectations_file):
1400
1401 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1402
1403         Remove setDefersLoading infrastructure from WebKit2
1404         https://bugs.webkit.org/show_bug.cgi?id=194506
1405
1406         Reviewed by Brady Eidson.
1407
1408         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1409         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1410         (WTR::TestRunner::setDefersLoading): Deleted.
1411         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1412
1413 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1414
1415         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1416         https://bugs.webkit.org/show_bug.cgi?id=194522
1417         <rdar://problem/47789393>
1418
1419         Reviewed by Chris Dumez.
1420
1421         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1422         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1423         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1424         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1425
1426 2019-02-12  Andy Estes  <aestes@apple.com>
1427
1428         [iOSMac] Enable Parental Controls Content Filtering
1429         https://bugs.webkit.org/show_bug.cgi?id=194521
1430         <rdar://39732376>
1431
1432         Reviewed by Tim Horton.
1433
1434         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1435
1436 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1437
1438         [LFC][IFC] Add intrinsic width support for float boxes.
1439         https://bugs.webkit.org/show_bug.cgi?id=194528
1440
1441         Reviewed by Antti Koivisto.
1442
1443         Expand tests coverage (2 new tests -> 800).
1444         (This is the correct test ordering --runs-singly --child-processes=1)
1445
1446         * LayoutReloaded/misc/LFC-passing-tests.txt:
1447
1448 2019-02-12  Rob Buis  <rbuis@igalia.com>
1449
1450         Implement serializing in MIME type parser
1451         https://bugs.webkit.org/show_bug.cgi?id=193909
1452
1453         Reviewed by Darin Adler.
1454
1455         Add various tests involving upper case, non-ASCII, control/null characters,
1456         various HTTP whitespace, single quotes and an unpaired surrogate.
1457
1458         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1459         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1460         (TestWebKitAPI::serializeIfValid):
1461         (TestWebKitAPI::TEST):
1462
1463 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1464
1465         [Cocoa] Ask platform for generic font family mappings
1466         https://bugs.webkit.org/show_bug.cgi?id=187723
1467         <rdar://problem/41892438>
1468
1469         Reviewed by Brent Fulgham.
1470
1471         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1472
1473         * DumpRenderTree/mac/DumpRenderTree.mm:
1474         (allowedFontFamilySet):
1475         * WebKitTestRunner/mac/TestControllerMac.mm:
1476         (WTR::allowedFontFamilySet):
1477
1478 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1479
1480         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1481         https://bugs.webkit.org/show_bug.cgi?id=193622
1482
1483         Reviewed by Michael Catanzaro.
1484
1485         This adds support for loading content extension rule sets from the JSON files which
1486         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1487         of WKTR for this could be removed, but that is left for a follow-up patch with
1488         cleanups.
1489
1490         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1491         * WebKitTestRunner/TestController.cpp:
1492         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1493         avoid having the null-terminator copied into the result.
1494         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1495         part of the preparations to run a test.
1496         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1497         (WTR::contentExtensionStoreCallback): Added.
1498         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1499         used for content extensions test.
1500         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1501         extensions and compiling the JSON rule set for tests involving content extensions.
1502         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1503         testing and disables content extensions.
1504         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1505         resetContentExtensions().
1506         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1507         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1508         configureContentExtensionForTest(), and userContentController().
1509
1510 2019-02-11  Daniel Bates  <dabates@apple.com>
1511
1512         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1513         https://bugs.webkit.org/show_bug.cgi?id=191446
1514         <rdar://problem/45929460>
1515
1516         Reviewed by Tim Horton.
1517
1518         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1519
1520         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1521         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1522         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1523         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1524         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1525         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1526         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1527         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1528         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1529         (WTR::arrayLength):
1530         (WTR::parseModifierArray):
1531         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1532         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1533         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1534         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1535
1536 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1537
1538         Unreviewed, rolling out r241272 and r241276.
1539         https://bugs.webkit.org/show_bug.cgi?id=194514
1540
1541         Broke the Apple Internal build and the fix requires human
1542         intervention :( (Requested by dydz on #webkit).
1543
1544         Reverted changesets:
1545
1546         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1547         https://bugs.webkit.org/show_bug.cgi?id=191446
1548         https://trac.webkit.org/changeset/241272
1549
1550         "Fix internal iOS build after r241272"
1551         https://bugs.webkit.org/show_bug.cgi?id=191446
1552         https://trac.webkit.org/changeset/241276
1553
1554 2019-02-11  Truitt Savell  <tsavell@apple.com>
1555
1556         Unreviewed, rolling out r241269.
1557
1558         Caused 5 layout tests crashes on Mac WK1
1559
1560         Reverted changeset:
1561
1562         "DumpRenderTree should report unknown options"
1563         https://bugs.webkit.org/show_bug.cgi?id=191303
1564         https://trac.webkit.org/changeset/241269
1565
1566 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1567
1568         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1569         https://bugs.webkit.org/show_bug.cgi?id=194313
1570
1571         Reviewed by Tim Horton.
1572
1573         Add a helper to determine whether the web view is presenting modal UI.
1574
1575         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1576         (WTR::UIScriptController::isPresentingModally const):
1577         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1578         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1579         (WTR::UIScriptController::isPresentingModally const):
1580         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1581         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1582         (WTR::UIScriptController::calendarType const): Deleted.
1583         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1584         (WTR::UIScriptController::isPresentingModally const):
1585         (WTR::UIScriptController::calendarType const):
1586         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1587         (WTR::UIScriptController::calendarType const):
1588
1589 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1590
1591         GCHeapInspector: Show the retained sizes in more places
1592         https://bugs.webkit.org/show_bug.cgi?id=194464
1593
1594         Reviewed by Simon Fraser.
1595
1596         * GCHeapInspector/gc-heap-inspector.html:
1597         * GCHeapInspector/script/interface.js:
1598         (HeapInspectorUtils.humanReadableSize):
1599         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1600         (HeapInspectorUtils.spanForNode.span.span):
1601         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1602         (HeapSnapshotInspector.prototype.buildRoots):
1603
1604 2019-02-11  Daniel Bates  <dabates@apple.com>
1605
1606         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1607         https://bugs.webkit.org/show_bug.cgi?id=191446
1608         <rdar://problem/45929460>
1609
1610         Reviewed by Tim Horton.
1611
1612         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1613
1614         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1615         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1616         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1617         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1618         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1619         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1620         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1621         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1622         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1623         (WTR::arrayLength):
1624         (WTR::parseModifierArray):
1625         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1626         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1627         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1628         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1629
1630 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1631
1632         DumpRenderTree should report unknown options
1633         https://bugs.webkit.org/show_bug.cgi?id=191303
1634
1635         Reviewed by Frédéric Wang.
1636
1637         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1638         to report unknown options.
1639         Added and assigned test options which are currently used in tests.
1640
1641         * DumpRenderTree/TestOptions.cpp:
1642         (TestOptions::TestOptions):
1643
1644 2019-02-11  Truitt Savell  <tsavell@apple.com>
1645
1646         Unreviewed, rolling out r241229.
1647
1648         Revision broke internal builds for watchOS.
1649
1650         Reverted changeset:
1651
1652         "[Cocoa] Ask platform for generic font family mappings"
1653         https://bugs.webkit.org/show_bug.cgi?id=187723
1654         https://trac.webkit.org/changeset/241229
1655
1656 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1657
1658         [WinCairo][MiniBrowser] Basic authentication always fails.
1659         https://bugs.webkit.org/show_bug.cgi?id=194496
1660
1661         Reviewed by Don Olmstead.
1662
1663         * MiniBrowser/win/DialogHelper.h:
1664         (Dialog::getText):
1665
1666 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1667
1668         [GStreamer] GstMappedBuffer testsuite build fails
1669         https://bugs.webkit.org/show_bug.cgi?id=194495
1670
1671         Reviewed by Carlos Garcia Campos.
1672
1673         Fix the build by explicitely adding the gstreamer1.0-audio include
1674         directories to the include path.
1675
1676         * TestWebKitAPI/PlatformGTK.cmake:
1677         * TestWebKitAPI/PlatformWPE.cmake:
1678
1679 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1680
1681         [GTK][WPE] Add enable-javascript-markup setting
1682         https://bugs.webkit.org/show_bug.cgi?id=193439
1683
1684         Reviewed by Michael Catanzaro.
1685
1686         Add test cases to check the new setting.
1687
1688         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1689         (testWebKitSettings):
1690         (testWebKitSettingsJavaScriptMarkup):
1691         (beforeAll):
1692
1693 2019-02-10  Darin Adler  <darin@apple.com>
1694
1695         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1696         https://bugs.webkit.org/show_bug.cgi?id=194485
1697
1698         Reviewed by Daniel Bates.
1699
1700         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1701
1702 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1703
1704         Add more tests for clampTo<>()
1705         https://bugs.webkit.org/show_bug.cgi?id=194462
1706
1707         Reviewed by Geoffrey Garen.
1708
1709         Darin suggested to test the very last floating point number
1710         at the boundaries when truncating to integer.
1711         I added test for max/min and max-1/min-1.
1712
1713         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1714         (TestWebKitAPI::TEST):
1715
1716 2019-02-09  Darin Adler  <darin@apple.com>
1717
1718         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1719         https://bugs.webkit.org/show_bug.cgi?id=194021
1720
1721         Reviewed by Geoffrey Garen.
1722
1723         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1724         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1725         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1726
1727 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1728
1729         [LFC][IFC] Add intrinsic width support for basic inline containers
1730         https://bugs.webkit.org/show_bug.cgi?id=194473
1731
1732         Reviewed by Antti Koivisto.
1733
1734         Expand tests coverage (11 new tests -> 798)
1735
1736         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1737
1738 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1739
1740         Fix MiniBrowser's entitlements
1741         https://bugs.webkit.org/show_bug.cgi?id=192431
1742
1743         Reviewed by Joseph Pecoraro.
1744
1745         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1746         files, making it impossible to load any extension.
1747
1748         * MiniBrowser/MiniBrowser.entitlements:
1749
1750 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1751
1752         [Cocoa] Ask platform for generic font family mappings
1753         https://bugs.webkit.org/show_bug.cgi?id=187723
1754         <rdar://problem/41892438>
1755
1756         Reviewed by Brent Fulgham.
1757
1758         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1759
1760         * DumpRenderTree/mac/DumpRenderTree.mm:
1761         (allowedFontFamilySet):
1762         * WebKitTestRunner/mac/TestControllerMac.mm:
1763         (WTR::allowedFontFamilySet):
1764
1765 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1766
1767         [GTK] Implement back/forward touchpad gesture
1768         https://bugs.webkit.org/show_bug.cgi?id=193919
1769
1770         Reviewed by Michael Catanzaro.
1771
1772         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1773         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1774
1775 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1776
1777         Add SPI to use networking daemon instead of XPC service
1778         https://bugs.webkit.org/show_bug.cgi?id=194427
1779
1780         Reviewed by Geoffrey Garen
1781
1782         * MiniBrowser/MiniBrowser.entitlements:
1783
1784 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1785
1786         [ews-build] Ensure that every builder in config.json has short name
1787         https://bugs.webkit.org/show_bug.cgi?id=194461
1788
1789         Reviewed by Lucas Forschler.
1790
1791         * BuildSlaveSupport/ews-build/loadConfig.py:
1792         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1793
1794 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1795
1796         [ews-build] Add short name to config.json
1797         https://bugs.webkit.org/show_bug.cgi?id=194456
1798
1799         Reviewed by Lucas Forschler.
1800
1801         * BuildSlaveSupport/ews-build/config.json: Added short name.
1802         * BuildSlaveSupport/ews-build/loadConfig.py:
1803         (loadBuilderConfig): Set the short name as the builder description.
1804
1805 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1806
1807         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1808         https://bugs.webkit.org/show_bug.cgi?id=194418
1809
1810         Reviewed by Lucas Forschler.
1811
1812         Do not include errors trying when finding crashlogs at the end of
1813         a run-webkit-tests run since we don't process those errors.
1814
1815         * Scripts/webkitpy/port/darwin.py:
1816         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1817         * Scripts/webkitpy/port/ios_device.py:
1818         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1819         * Scripts/webkitpy/port/watch_device.py:
1820         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1821
1822 2019-02-08  Beth Dakin  <bdakin@apple.com>
1823
1824         Add afterScreenUpdates to WKSnapshotConfiguration
1825         https://bugs.webkit.org/show_bug.cgi?id=194362
1826         -and corresponding-
1827         <rdar://problem/40655528> Please add an "after screen updates" property to 
1828         WKSnapshotConfiguration (to solve blank snapshots)
1829
1830         Reviewed by Tim Horton.
1831
1832         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1833         (TEST):
1834
1835 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1836
1837         clampTo(): do not convert the input to double when dealing with integers
1838         https://bugs.webkit.org/show_bug.cgi?id=194263
1839         <rdar://problem/47692312>
1840
1841         Reviewed by Darin Adler.
1842
1843         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1844         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1845         (TestWebKitAPI::testClampFloatingPointToInteger):
1846         (TestWebKitAPI::testClampSameSignIntegers):
1847         (TestWebKitAPI::testClampUnsignedToSigned):
1848         (TestWebKitAPI::testClampSignedToUnsigned):
1849
1850 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1851
1852         webkitpy: Respect --dedicated-simulators flag
1853         https://bugs.webkit.org/show_bug.cgi?id=194416
1854         <rdar://problem/47894722>
1855
1856         Reviewed by Lucas Forschler.
1857
1858         * Scripts/webkitpy/port/device_port.py:
1859         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1860         available devices can be safely ignored.
1861
1862 2019-02-07  Keith Rollin  <krollin@apple.com>
1863
1864         Remove extra copy of 100x100-red.tga
1865         https://bugs.webkit.org/show_bug.cgi?id=194371
1866         <rdar://problem/47873465>
1867
1868         Reviewed by Said Abou-Hallawa.
1869
1870         In order to help it pass its tests, Bug 194190 added a second copy of
1871         the file 100x100-red.tga. However, it turns out that this additional
1872         file wasn't actually needed, and that that sole previous copy was
1873         sufficient. At the same time, this second copy -- which was copied to
1874         the same location in the build output as the first copy -- now caused
1875         XCBuild to complain because there were two production rules for the
1876         same output file. Address this by removing the newly-added extra copy.
1877
1878         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1879         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1880
1881 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1882
1883         Deprecate WKBundlePageSetDefersLoading
1884         https://bugs.webkit.org/show_bug.cgi?id=191394
1885
1886         Reviewed by Dean Jackson.
1887
1888         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1889         (WTR::TestRunner::setDefersLoading):
1890
1891 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1892
1893         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1894         https://bugs.webkit.org/show_bug.cgi?id=194391
1895
1896         Reviewed by Antti Koivisto.
1897
1898         * LayoutReloaded/misc/LFC-passing-tests.txt:
1899
1900 2019-02-06  Keith Rollin  <krollin@apple.com>
1901
1902         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1903         https://bugs.webkit.org/show_bug.cgi?id=193975
1904         <rdar://problem/47643306>
1905
1906         Reviewed by Tim Horton.
1907
1908         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1909         the Info.plist file into the bundle. This step is not necessary as the
1910         implicit "bundle up all the build products into a framework" build
1911         phase does this already. Having the Copy Bundle Resources phase do
1912         this causes a conflict under XCBuild, which objects to two build
1913         phases producing the same file (Info.plist). Address this by removing
1914         Info.plist from the Copy Bundle Resources phase.
1915
1916         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1917
1918 2019-02-06  Keith Rollin  <krollin@apple.com>
1919
1920         Really enable the automatic checking and regenerations of .xcfilelists during builds
1921         https://bugs.webkit.org/show_bug.cgi?id=194357
1922         <rdar://problem/47861231>
1923
1924         Reviewed by Chris Dumez.
1925
1926         Bug 194124 was supposed to enable the automatic checking and
1927         regenerating of .xcfilelist files during the build. While related
1928         changes were included in that patch, the change to actually enable the
1929         operation somehow was omitted. This patch actually enables the
1930         operation. The check-xcfilelist.sh scripts now check
1931         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1932         from the checking.
1933
1934         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1935         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1936
1937 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1938
1939         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1940         <https://webkit.org/b/194286>
1941         <rdar://problem/47815558>
1942
1943         Reviewed by Alexey Proskuryakov.
1944
1945         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1946         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1947         WKRetainPtr<> to avoid leaking the WKDataRef.
1948
1949 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1950
1951         Unreviewed, fix a typo
1952
1953         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1954
1955 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1956
1957         [GTK][WPE] force libpsl build to use ICU in jhbuild
1958         https://bugs.webkit.org/show_bug.cgi?id=194288
1959
1960         Reviewed by Carlos Garcia Campos.
1961
1962         * gtk/jhbuild.modules:
1963         Require ICU for libpsl build in jhbuild, like done in WPE.
1964
1965 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1966
1967         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1968         https://bugs.webkit.org/show_bug.cgi?id=194209
1969
1970         Reviewed by Carlos Garcia Campos.
1971
1972         Enhance TestCookieManager to ensure this doesn't happen again.
1973
1974         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1975         (testCookieManagerPersistentStorage):
1976         (beforeAll):
1977
1978 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1979
1980         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1981         https://bugs.webkit.org/show_bug.cgi?id=194324
1982
1983         Reviewed by Andy Estes.
1984
1985         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1986         part of the name is already implicit, since this is in testing code in TestOptions.
1987
1988         * WebKitTestRunner/TestController.cpp:
1989         (WTR::TestController::generateContextConfiguration const):
1990         (WTR::updateTestOptionsFromTestHeader):
1991         * WebKitTestRunner/TestOptions.h:
1992         (WTR::TestOptions::hasSameInitializationOptions const):
1993
1994 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1995
1996         [ews-build] Allow * as platform for builders and workers
1997         https://bugs.webkit.org/show_bug.cgi?id=188533
1998
1999         Reviewed by Lucas Forschler.
2000
2001         * BuildSlaveSupport/ews-build/loadConfig.py:
2002         (checkWorkersAndBuildersForConsistency):
2003
2004 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2005
2006         [ews-build] Add few bots to config.json
2007         https://bugs.webkit.org/show_bug.cgi?id=194304
2008
2009         Reviewed by Lucas Forschler.
2010
2011         * BuildSlaveSupport/ews-build/config.json:
2012
2013 2019-02-05  Keith Rollin  <krollin@apple.com>
2014
2015         Enable the automatic checking and regenerations of .xcfilelists during builds
2016         https://bugs.webkit.org/show_bug.cgi?id=194124
2017         <rdar://problem/47721277>
2018
2019         Reviewed by Tim Horton.
2020
2021         Bug 193790 add a facility for checking -- during build time -- that
2022         any needed .xcfilelist files are up-to-date and for updating them if
2023         they are not. This facility was initially opt-in by setting
2024         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2025         the process seemed robust. Its now time to enable this facility and
2026         make it opt-out. If there is a need to disable this facility, set and
2027         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2028         running `make` or `build-webkit`, or before running Xcode from the
2029         command line.
2030
2031         Additionally, remove the step that generates a list of source files
2032         going into the UnifiedSources build step. It's only necessarily to
2033         specify Sources.txt and SourcesCocoa.txt as inputs.
2034
2035         * Scripts/generate-xcfilelists:
2036
2037 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2038
2039         [GTK][WPE] force libpsl build to use ICU in jhbuild
2040         https://bugs.webkit.org/show_bug.cgi?id=194288
2041
2042         Reviewed by Philippe Normand.
2043
2044         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2045         This can cause build failures if libidn is detected but libunistring is not available.
2046
2047         Make sure that ICU is used for runtime and builtin PSL data.
2048
2049         * gtk/jhbuild.modules:
2050         * wpe/jhbuild.modules:
2051
2052 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2053
2054         [ews-app] Modified timestamp should be updated on updating data
2055         https://bugs.webkit.org/show_bug.cgi?id=194295
2056
2057         Reviewed by Lucas Forschler.
2058
2059         * BuildSlaveSupport/ews-app/ews/models/build.py:
2060         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2061         * BuildSlaveSupport/ews-app/ews/models/step.py:
2062
2063 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2064
2065         Unreviewed, rolling out r240742.
2066
2067         Causes crashes on iOS simulator.
2068
2069         Reverted changeset:
2070
2071         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2072         not focused in a content-editable element"
2073         https://bugs.webkit.org/show_bug.cgi?id=192824
2074         https://trac.webkit.org/changeset/240742
2075
2076 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2077
2078         run-webkit-tests emits message "...running None" when running tests
2079         https://bugs.webkit.org/show_bug.cgi?id=194133
2080         <rdar://problem/47724738>
2081
2082         Reviewed by Lucas Forschler.
2083
2084         * Scripts/webkitpy/xcode/device_type.py:
2085         (DeviceType.__str__): Use both version mapping tables and use just the variant
2086         name if no version name is available.
2087         * Scripts/webkitpy/xcode/device_type_unittest.py:
2088         (DeviceTypeTest):
2089         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2090         an associated named.
2091
2092 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2093
2094         [WPE] require python3-setuptools for meson build in jhbuild
2095         https://bugs.webkit.org/show_bug.cgi?id=194287
2096
2097         Reviewed by Philippe Normand.
2098
2099         python3-setuptools is needed to build meson in jhbuild.
2100         It is already required by the GTK port.
2101
2102         * wpe/install-dependencies:
2103
2104 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2105
2106         [ews-app] Add method to save BuilderMapping to database
2107         https://bugs.webkit.org/show_bug.cgi?id=194264
2108
2109         Reviewed by Lucas Forschler.
2110
2111         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2112         (BuilderMapping.__str__):
2113         (BuilderMapping):
2114         (BuilderMapping.save_mapping):
2115         (BuilderMapping.update_mapping):
2116         (BuilderMapping.get_existing_mapping):
2117         (BuilderMapping.is_valid_mapping):
2118
2119 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2120
2121         [ews-app] Add timestamp fields for BuilderMappings
2122         https://bugs.webkit.org/show_bug.cgi?id=194266
2123
2124         Reviewed by Lucas Forschler.
2125
2126         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2127         (BuilderMapping):
2128
2129 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2130
2131         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2132         https://bugs.webkit.org/show_bug.cgi?id=174816
2133
2134         Reviewed by Michael Catanzaro.
2135
2136         Add tests for webkit_uri_for_display().
2137
2138         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2139         (testURIForDisplayUnaffected):
2140         (testURIForDisplayAffected):
2141         (beforeAll):
2142         (afterAll):
2143         * TestWebKitAPI/glib/CMakeLists.txt:
2144
2145 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2146
2147         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2148         https://bugs.webkit.org/show_bug.cgi?id=194158
2149         <rdar://problem/47737268>
2150
2151         Rubber-stamped by Aakash Jain.
2152
2153         * Scripts/webkitpy/port/device_port.py:
2154         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2155
2156 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2157
2158         [CG] Enable setAdditionalSupportedImageTypes for WK1
2159         https://bugs.webkit.org/show_bug.cgi?id=194190
2160
2161         Reviewed by Tim Horton.
2162
2163         Add a test similar to the one under WebKit Cocoa but make it create a
2164         WebView instead of a WKWebView.
2165
2166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2167         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2168         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2169         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2170         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2171         (TestWebKitAPI::runTest):
2172         (TestWebKitAPI::TEST):
2173
2174 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2175
2176         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2177         https://bugs.webkit.org/show_bug.cgi?id=194168
2178
2179         Reviewed by Simon Fraser.
2180
2181         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2182
2183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2184         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2185         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2186         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2187         (TEST):
2188         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2189         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2190
2191 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2192
2193         REGRESSION (r237269): webkit-patch what-broke is broken 
2194         https://bugs.webkit.org/show_bug.cgi?id=193025
2195
2196         Reviewed by Aakash Jain.
2197
2198         * Scripts/webkitpy/common/host.py:
2199         (Host.buildbot):
2200         (Host.bugzilla): Renamed to 'buildbot'.
2201
2202 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2203
2204         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2205         https://bugs.webkit.org/show_bug.cgi?id=194207
2206
2207         Reviewed by Tim Horton.
2208
2209         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2210         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2211         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2212         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2213         start and delete forwards to remove the original attachment.
2214
2215         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2216         (TestWebKitAPI::TEST):
2217
2218 2019-02-04  Youenn Fablet  <youenn@apple.com>
2219
2220         Capture state should be managed consistently when doing process swapping
2221         https://bugs.webkit.org/show_bug.cgi?id=194122
2222         <rdar://problem/47609293>
2223
2224         Reviewed by Eric Carlson.
2225
2226         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2227         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2228         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2229         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2230         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2231         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2232         (WTR::TestRunner::isDoingMediaCapture const):
2233         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2234         * WebKitTestRunner/TestController.cpp:
2235         (WTR::TestController::isDoingMediaCapture const):
2236         * WebKitTestRunner/TestController.h:
2237         * WebKitTestRunner/TestInvocation.cpp:
2238         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2239         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2240         (WTR::TestController::isDoingMediaCapture const):
2241
2242 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2243
2244         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2245         https://bugs.webkit.org/show_bug.cgi?id=194142
2246
2247         Reviewed by Ross Kirsling.
2248
2249         There three 'separator' variables in TestController.cpp. Renamed
2250         it 'pathSeparator', and unified them.
2251
2252         * WebKitTestRunner/TestController.cpp:
2253         (WTR::TestController::generateContextConfiguration const):
2254         (WTR::createTestURL):
2255         (WTR::TestController::platformAdjustContext):
2256
2257 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2258
2259         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2260         https://bugs.webkit.org/show_bug.cgi?id=194198
2261
2262         Reviewed by Antti Koivisto.
2263
2264         No need to set the banner heights on navigation now, since Page stores them.
2265
2266         * MiniBrowser/mac/WK2BrowserWindowController.m:
2267         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2268
2269 2019-02-03  John Wilander  <wilander@apple.com>
2270
2271         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2272         https://bugs.webkit.org/show_bug.cgi?id=194104
2273         <rdar://problem/47649991>
2274
2275         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2276
2277         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2278         (TestWebKitAPI::TEST):
2279             Changed numeric types from unsigned short to uint32_t.
2280
2281 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2282
2283         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2284         <https://webkit.org/b/194178>
2285         <rdar://problem/47753473>
2286
2287         Reviewed by Alexey Proskuryakov.
2288
2289         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2290         (WTR::uninstallFakeHelvetica): Pass nullptr into
2291         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2292
2293 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2294
2295         [LFC] Initialize ICB's style with fixed width/height.
2296         https://bugs.webkit.org/show_bug.cgi?id=194188
2297
2298         Reviewed by Antti Koivisto.
2299
2300         * LayoutReloaded/misc/LFC-passing-tests.txt:
2301
2302 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2303
2304         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2305         https://bugs.webkit.org/show_bug.cgi?id=194185
2306
2307         Reviewed by Antti Koivisto.
2308
2309         * LayoutReloaded/misc/LFC-passing-tests.txt:
2310
2311 2018-12-16  Darin Adler  <darin@apple.com>
2312
2313         Convert additional String::format clients to alternative approaches
2314         https://bugs.webkit.org/show_bug.cgi?id=192746
2315
2316         Reviewed by Alexey Proskuryakov.
2317
2318         * WebKitTestRunner/TestController.cpp:
2319         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2320         as an intermediate in code that ultimately constructs a WTF::String.
2321         (WTR::userMediaOriginHash): Use makeString.
2322         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2323         (WTR::TestController::didPerformClientRedirect): Ditto.
2324         (WTR::TestController::didPerformServerRedirect): Ditto.
2325         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2326
2327 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2328
2329         [ews-build] Add unit test to verify builder keys
2330         https://bugs.webkit.org/show_bug.cgi?id=194152
2331
2332         Reviewed by Lucas Forschler.
2333
2334         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2335         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2336
2337 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2338
2339         [LFC] Expand tests coverage (12 new tests -> 787)
2340
2341         Unreviewed test gardening.
2342
2343         * LayoutReloaded/misc/LFC-passing-tests.txt:
2344
2345 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2346
2347         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2348         https://bugs.webkit.org/show_bug.cgi?id=194163
2349
2350         Reviewed by Simon Fraser.
2351
2352         775
2353
2354         * LayoutReloaded/misc/LFC-passing-tests.txt:
2355
2356 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2357
2358         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2359         https://bugs.webkit.org/show_bug.cgi?id=194140
2360         <rdar://problem/47728098>
2361
2362         Reviewed by Tim Horton.
2363
2364         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2365         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2366         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2367
2368         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2369         test to induce an IPC deadlock when presenting a modal alert during touch start.
2370
2371         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2372         * WebKitTestRunner/TestController.cpp:
2373         (WTR::runJavaScriptAlert):
2374
2375         Add a client callback function for running JavaScript alerts.
2376
2377         (WTR::TestController::createOtherPage):
2378         (WTR::TestController::generateContextConfiguration const):
2379
2380         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2381         the fix in this patch.
2382
2383         (WTR::TestController::createWebViewWithOptions):
2384
2385         Plumb TestOptions to generateContextConfiguration.
2386
2387         (WTR::TestController::resetPreferencesToConsistentValues):
2388         (WTR::TestController::resetStateToConsistentValues):
2389         (WTR::updateTestOptionsFromTestHeader):
2390         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2391         (WTR::TestController::handleJavaScriptAlert):
2392         * WebKitTestRunner/TestController.h:
2393         * WebKitTestRunner/TestInvocation.cpp:
2394         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2395         * WebKitTestRunner/TestOptions.h:
2396         (WTR::TestOptions::hasSameInitializationOptions const):
2397
2398 2019-02-01  Chris Dumez  <cdumez@apple.com>
2399
2400         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2401         https://bugs.webkit.org/show_bug.cgi?id=193740
2402         <rdar://problem/47527267>
2403
2404         Reviewed by Alex Christensen.
2405
2406         Add API test coverage.
2407
2408         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2409
2410 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2411
2412         [ews-app] Add display name field to BuilderMapping model
2413         https://bugs.webkit.org/show_bug.cgi?id=194153
2414
2415         Reviewed by Lucas Forschler.
2416
2417         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2418         (BuilderMapping):
2419
2420 2019-02-01  Youenn Fablet  <youenn@apple.com>
2421
2422         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2423         https://bugs.webkit.org/show_bug.cgi?id=194155
2424
2425         Reviewed by Eric Carlson.
2426
2427         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2428         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2429         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2430
2431 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2432
2433         [LFC] Adjust replaced element's intrinsic ratio
2434         https://bugs.webkit.org/show_bug.cgi?id=194154
2435
2436         Reviewed by Antti Koivisto.
2437
2438         761
2439
2440         * LayoutReloaded/misc/LFC-passing-tests.txt:
2441
2442 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2443
2444         [WPE] Show test results in minibrowser
2445         https://bugs.webkit.org/show_bug.cgi?id=194150
2446
2447         Reviewed by Žan Doberšek.
2448
2449         * Scripts/webkitpy/port/wpe.py:
2450         (WPEPort.show_results_html_file):
2451
2452 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2453
2454         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2455         https://bugs.webkit.org/show_bug.cgi?id=194151
2456
2457         Reviewed by Žan Doberšek.
2458
2459         ALT + <- go back
2460         ALT + -> go forward
2461
2462         * MiniBrowser/wpe/main.cpp:
2463         (main):
2464
2465 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2466
2467         [LFC] Set intrinsic size on Layout::Replaced
2468         https://bugs.webkit.org/show_bug.cgi?id=194139
2469
2470         Reviewed by Antti Koivisto.
2471
2472         744
2473
2474         * LayoutReloaded/misc/LFC-passing-tests.txt:
2475
2476 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2477
2478         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2479         https://bugs.webkit.org/show_bug.cgi?id=194146
2480
2481         Reviewed by Xabier Rodriguez-Calvar.
2482
2483         It allows to open relative paths.
2484
2485         * MiniBrowser/wpe/main.cpp:
2486         (main):
2487
2488 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2489
2490         Update flakiness dashboard configuration after recent queue changes
2491         https://bugs.webkit.org/show_bug.cgi?id=194127
2492
2493         Rubber-stamped by Aakash Jain.
2494
2495         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2496
2497         * TestResultServer/static-dashboards/builders.jsonp:
2498
2499 2019-01-31  Youenn Fablet  <youenn@apple.com>
2500
2501         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2502         https://bugs.webkit.org/show_bug.cgi?id=194106
2503         <rdar://problem/47676333>
2504
2505         Reviewed by Ryosuke Niwa.
2506
2507         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2508         (TestWebKitAPI::didFinishNavigation):
2509         (TestWebKitAPI::TEST):
2510         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2511
2512 2019-01-31  Chris Dumez  <cdumez@apple.com>
2513
2514         Page zoom level is lost after a process swap or a crash
2515         https://bugs.webkit.org/show_bug.cgi?id=194105
2516         <rdar://problem/47610781>
2517
2518         Reviewed by Alex Christensen.
2519
2520         Add API test coverage.
2521
2522         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2523         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2524
2525 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2526
2527         Revert r238819 which is unneeded and caused a performance regression.
2528         https://bugs.webkit.org/show_bug.cgi?id=192272
2529         <rdar://problem/46664625>
2530
2531         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2532         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2533         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2534
2535 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2536
2537         Formalize WebKitAdditions mechanism of LoadOptimizer
2538         https://bugs.webkit.org/show_bug.cgi?id=193886
2539         <rdar://problem/47696809>
2540
2541         Reviewed by Brent Fulgham.
2542
2543         * MiniBrowser/MiniBrowser.entitlements:
2544         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2545
2546 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2547
2548         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2549         https://bugs.webkit.org/show_bug.cgi?id=194090
2550
2551         Reviewed by Antti Koivisto.
2552
2553         * LayoutReloaded/misc/LFC-passing-tests.txt:
2554
2555 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2556
2557         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2558         https://bugs.webkit.org/show_bug.cgi?id=194074
2559
2560         Reviewed by Antti Koivisto.
2561
2562         * LayoutReloaded/misc/LFC-passing-tests.txt:
2563
2564 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2565
2566         [LFC][BFC] Add support for block level replaced box.
2567         https://bugs.webkit.org/show_bug.cgi?id=194071
2568
2569         Reviewed by Antti Koivisto.
2570
2571         * LayoutReloaded/misc/LFC-passing-tests.txt:
2572
2573 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2574
2575         Fix WebKitTestRunner's testPath with Windows full paths
2576         https://bugs.webkit.org/show_bug.cgi?id=194012
2577
2578         Reviewed by Alex Christensen.
2579
2580         updateTestOptionsFromTestHeader failed to open test files because
2581         testPath returned wrong file paths. It returned a path "/C:/..."
2582         if a URL "file:///C:/..." was given.
2583
2584         * WebKitTestRunner/TestController.cpp:
2585         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2586
2587 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2588
2589         [WPE] Bump font related dependencies to match the GTK+ port
2590         https://bugs.webkit.org/show_bug.cgi?id=194017
2591
2592         Reviewed by Žan Doberšek.
2593
2594         * wpe/jhbuild.modules:
2595         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2596         * wpe/patches/icudata-stdlibs.patch: Added.
2597
2598 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2599
2600         Enable swipe tests on iOS
2601         https://bugs.webkit.org/show_bug.cgi?id=194076
2602
2603         Reviewed by Geoffrey Garen.
2604
2605         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2606         it causes a debug assertion failure in runUIScript.
2607
2608         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2609         (WTR::UIScriptController::beginBackSwipe):
2610         (WTR::UIScriptController::completeBackSwipe):
2611
2612 2019-01-30  Keith Rollin  <krollin@apple.com>
2613
2614         Use correct printf format specifier
2615         https://bugs.webkit.org/show_bug.cgi?id=194062
2616         <rdar://problem/47686167>
2617
2618         Reviewed by Alexey Proskuryakov.
2619
2620         LayoutTestSpellChecker.mm is trying to format a variable of type
2621         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2622         actually an unsigned long long. Fix this by formatting with %llu.
2623
2624         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2625         (-[LayoutTestTextCheckingResult description]):
2626
2627 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2628
2629         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2630         https://bugs.webkit.org/show_bug.cgi?id=193979
2631
2632         Reviewed by Wenson Hsieh.
2633
2634         Fix the test for iOS. Make the test work with iOS UA string.
2635
2636         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2637
2638 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2639
2640         Replace High Sierra LLINT CLoop bot due to hardware failure
2641         https://bugs.webkit.org/show_bug.cgi?id=194066
2642
2643         Reviewed by Aakash Jain.
2644
2645         * BuildSlaveSupport/build.webkit.org-config/config.json:
2646
2647 2019-01-30  Keith Rollin  <krollin@apple.com>
2648
2649         [NSDragItem init] is unavailable
2650         https://bugs.webkit.org/show_bug.cgi?id=194059
2651         <rdar://problem/47685715>
2652
2653         Reviewed by Wenson Hsieh.
2654
2655         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2656         DumpRenderTree and TestWebKitAPI, which both try to create an
2657         NSDragItem in a manner that invokes this method. Address this by using
2658         -initWithPasteboardWriter instead.
2659
2660         Note that the parameter passed to initWithPasteboardWriter is likely
2661         incorrect. In both cases, the object passed does not conform to
2662         NSPasteboardWriting. However, with this fix, we're no worse off than
2663         before, and can now perform builds with newer compilers and SDKs until
2664         a real fix can be crafted. That work is tracked in
2665         https://bugs.webkit.org/show_bug.cgi?id=194060
2666
2667         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2668         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2669         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2670         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2671
2672 2019-01-30  Daniel Bates  <dabates@apple.com>
2673
2674         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2675         https://bugs.webkit.org/show_bug.cgi?id=192824
2676         <rdar://problem/47100332>
2677
2678         Reviewed by Wenson Hsieh.
2679
2680         Fix a bug where the wrong usage code was used for F13 thru F24.
2681
2682         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2683         (keyCodeForDOMFunctionKey):
2684
2685 2019-01-30  Chris Dumez  <cdumez@apple.com>
2686
2687         Regression(PSON) Load hang can occur on history navigation
2688         https://bugs.webkit.org/show_bug.cgi?id=194030
2689         <rdar://problem/47656939>
2690
2691         Reviewed by Antti Koivisto.
2692
2693         Add API test coverage.
2694
2695         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2696
2697 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2698
2699         [LFC] Expand tests coverage.
2700
2701         Unreviewed test gardening.
2702
2703         * LayoutReloaded/misc/LFC-passing-tests.txt:
2704
2705 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2706
2707         [Flatpak] Add openjpeg support
2708         https://bugs.webkit.org/show_bug.cgi?id=194019
2709
2710         Reviewed by Michael Catanzaro.
2711
2712         * flatpak/org.webkit.CommonModules.yaml:
2713
2714 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2715
2716         Unreviewed, rolling out r240708.
2717         https://bugs.webkit.org/show_bug.cgi?id=194022
2718
2719         It broke WPE build (Requested by KaL on #webkit).
2720
2721         Reverted changeset:
2722
2723         "[WPE] Bump font related dependencies to match the GTK+ port"
2724         https://bugs.webkit.org/show_bug.cgi?id=194017
2725         https://trac.webkit.org/changeset/240708
2726
2727 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2728
2729         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2730         https://bugs.webkit.org/show_bug.cgi?id=194001
2731
2732         Reviewed by Antti Koivisto.
2733
2734         * LayoutReloaded/misc/LFC-passing-tests.txt:
2735
2736 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2737
2738         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2739         https://bugs.webkit.org/show_bug.cgi?id=194020
2740
2741         Reviewed by Antti Koivisto.
2742
2743         * LayoutReloaded/misc/LFC-passing-tests.txt:
2744
2745 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2746
2747         AX: Support color well on iOS
2748         https://bugs.webkit.org/show_bug.cgi?id=194010
2749
2750         Reviewed by Joanmarie Diggs.
2751
2752         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2753         (WTR::AccessibilityUIElement::stringAttributeValue):
2754
2755 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2756
2757         [WPE] Bump font related dependencies to match the GTK+ port
2758         https://bugs.webkit.org/show_bug.cgi?id=194017
2759
2760         Reviewed by Žan Doberšek.
2761
2762         * wpe/jhbuild.modules:
2763         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2764         * wpe/patches/icudata-stdlibs.patch: Added.
2765
2766 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2767
2768         [Mac] Update window scale API usage
2769         https://bugs.webkit.org/show_bug.cgi?id=193991
2770         rdar://problem/47614795
2771
2772         Reviewed by Tim Horton.
2773
2774         * DumpRenderTree/mac/DumpRenderTree.mm:
2775         (changeWindowScaleIfNeeded):
2776         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2777         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2778         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2779
2780 2019-01-29  Chris Dumez  <cdumez@apple.com>
2781
2782         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2783         https://bugs.webkit.org/show_bug.cgi?id=193977
2784         <rdar://problem/47643716>
2785
2786         Reviewed by Geoff Garen.
2787
2788         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2789         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2790         to the previous provisional committing *before* we make the last load. 
2791
2792         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2793
2794 2019-01-29  Youenn Fablet  <youenn@apple.com>
2795
2796         Adopt new SPI to evaluate server certificate trust
2797         https://bugs.webkit.org/show_bug.cgi?id=193355
2798
2799         Reviewed by Alex Christensen.
2800
2801         Add infrastructure to handle HTTPS server trust evaluation testing.
2802
2803         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2804         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2805         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2806         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2807         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2808         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2809         * WebKitTestRunner/TestController.cpp:
2810         (WTR::TestController::resetPreferencesToConsistentValues):
2811         (WTR::TestController::didReceiveAuthenticationChallenge):
2812         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2813         * WebKitTestRunner/TestController.h:
2814         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2815         * WebKitTestRunner/TestInvocation.cpp:
2816         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2817         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2818         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2819
2820 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2821
2822         [ews-build] Add build step to print bot Configuration
2823         https://bugs.webkit.org/show_bug.cgi?id=193887
2824
2825         Reviewed by Lucas Forschler.
2826
2827         * BuildSlaveSupport/ews-build/steps.py:
2828         (PrintConfiguration): Build step to print configuration.
2829         * BuildSlaveSupport/ews-build/factories.py:
2830
2831 2019-01-29  Chris Dumez  <cdumez@apple.com>
2832
2833         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2834         https://bugs.webkit.org/show_bug.cgi?id=193967
2835         <rdar://problem/47635348>
2836
2837         Reviewed by Alex Christensen.
2838
2839         Add API test coverage.
2840
2841         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2842         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2843
2844 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2845
2846         [ews-app] Handle incoming results data
2847         https://bugs.webkit.org/show_bug.cgi?id=193973
2848
2849         Reviewed by Lucas Forschler.
2850
2851         * BuildSlaveSupport/ews-app/ews/views/results.py:
2852
2853 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2854
2855         [ews-app] Make the results url generic
2856         https://bugs.webkit.org/show_bug.cgi?id=193928
2857
2858         Reviewed by Lucas Forschler.
2859
2860         * BuildSlaveSupport/ews-app/ews/urls.py:
2861
2862 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2863
2864         [ews-build] Configure buildbot to send events to ews-app
2865         https://bugs.webkit.org/show_bug.cgi?id=193968
2866
2867         Reviewed by Lucas Forschler.
2868
2869         * BuildSlaveSupport/ews-build/events.py: Added.
2870         * BuildSlaveSupport/ews-build/master.cfg:
2871
2872 2019-01-29  Keith Rollin  <krollin@apple.com>
2873
2874         Add .xcfilelists to Run Script build phases
2875         https://bugs.webkit.org/show_bug.cgi?id=193792
2876         <rdar://problem/47201785>
2877
2878         Reviewed by Alex Christensen.
2879
2880         As part of supporting XCBuild, update the necessary Run Script build
2881         phases in their Xcode projects to refer to their associated
2882         .xcfilelist files.
2883
2884         Note that the addition of these files bumps the Xcode project version
2885         number to something that's Xcode 10 compatible. This change means that
2886         older versions of the Xcode IDE can't read these projects. Nor can it
2887         fully load workspaces that refer to these projects (the updated
2888         projects are shown as non-expandable placeholders). `xcodebuild` can
2889         still build these projects; it's just that the IDE can't open them.
2890
2891         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2892         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2893
2894 2019-01-29  John Wilander  <wilander@apple.com>
2895
2896         Add data abstraction and validation for Ad Click Attribution
2897         https://bugs.webkit.org/show_bug.cgi?id=193916
2898         <rdar://problem/47603481>
2899
2900         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2901
2902         Ad click attribution has two steps. First, the storage of an ad
2903         campaign ID for a click that takes the user to a destination
2904         site. Second, a conversion on the destination site that can be
2905         attributed to the ad click.
2906
2907         This patch adds a class that represents a request for ad click
2908         attribution. Validation makes sure that the bits of entropy
2909         reported through this mechanism is limited.
2910
2911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2912         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2913         (TestWebKitAPI::TEST):
2914
2915 2019-01-29  Chris Dumez  <cdumez@apple.com>
2916
2917         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2918         https://bugs.webkit.org/show_bug.cgi?id=193932
2919         <rdar://problem/47598947>
2920
2921         Reviewed by Brady Eidson.
2922
2923         Add API test coverage.
2924
2925         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2926
2927 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2928
2929         Adding new passing LFC tests.
2930
2931         Unreviewed test gardening.
2932
2933         * LayoutReloaded/misc/LFC-passing-tests.txt:
2934
2935 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2936
2937         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2938         https://bugs.webkit.org/show_bug.cgi?id=193964
2939
2940         Reviewed by Antti Koivisto.
2941
2942         * LayoutReloaded/misc/LFC-passing-tests.txt:
2943
2944 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2945
2946         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2947         https://bugs.webkit.org/show_bug.cgi?id=193954
2948
2949         Reviewed by Antti Koivisto.
2950
2951         * LayoutReloaded/misc/LFC-passing-tests.txt:
2952
2953 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2954
2955         WebDriver: add support for running subtests
2956         https://bugs.webkit.org/show_bug.cgi?id=193904
2957
2958         Reviewed by Michael Catanzaro.
2959
2960         pytest already supports it by passing test.py::subtest, so we can do the same.
2961
2962         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2963         (get_item_name): Made this global.
2964         (CollectRecorder.__init__): Receive the parameter to ignore.
2965         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2966         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2967         (collect): Add parameter to ignore.
2968         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2969         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2970         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2971         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2972         (WebDriverTestRunnerSelenium.run): Ditto.
2973         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2974         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2975         (WebDriverTestRunnerW3C.run): Ditto.
2976
2977 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2978
2979         User agent string override for navigator.userAgent should be site specific quirks
2980         https://bugs.webkit.org/show_bug.cgi?id=193950
2981
2982         Reviewed by Brent Fulgham.
2983
2984         Updated per the _WKWebsitePolicies rename.
2985
2986         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2987         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2988
2989 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2990
2991         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2992         https://bugs.webkit.org/show_bug.cgi?id=193941
2993
2994         Reviewed by Alex Christensen.
2995
2996         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2997         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2998         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2999         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3000         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3001         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3002         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3003         * TestWebKitAPI/Tests/WTF/Time.cpp:
3004         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3005         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3006         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3007         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3008
3009 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3010
3011         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3012
3013         * Scripts/webkitpy/common/config/contributors.json:
3014
3015 2019-01-28  Andy Estes  <aestes@apple.com>
3016
3017         [watchOS] Enable Parental Controls content filtering
3018         https://bugs.webkit.org/show_bug.cgi?id=193939
3019         <rdar://problem/46641912>
3020
3021         Reviewed by Ryosuke Niwa.
3022
3023         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3024
3025 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3026
3027         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3028         <https://webkit.org/b/193884>
3029
3030         Reviewed by Jiewen Tan.
3031
3032         * Scripts/webkitpy/style/checkers/cpp.py:
3033         (check_language): Add LocalAuthentication to
3034         `frameworks_with_soft_links`.
3035
3036 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3037
3038         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3039         https://bugs.webkit.org/show_bug.cgi?id=193891
3040
3041         Reviewed by Ross Kirsling.
3042
3043         There were three problems in window sizes of WebView and the host window.
3044         1. The sizes of pixel image output were incorrect.
3045         2. The host window is going to appear after window.resize was invoked.
3046         3. window.resize resized only the host window, not WebView.
3047
3048         This change solves them with a following approach.
3049         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3050         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3051            as well as DumpRenderTree in order to match the client area and the window area.
3052         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3053         d. PlatformWebView::setWindowFrame changes both window sizes.
3054         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3055
3056         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3057         (WTR::PlatformWebView::PlatformWebView): Create the host window
3058         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3059         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3060         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3061
3062 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3063
3064         [ews-app] Add method to save Step data to database
3065         https://bugs.webkit.org/show_bug.cgi?id=193890
3066
3067         Reviewed by Lucas Forschler.
3068
3069         * BuildSlaveSupport/ews-app/ews/models/step.py:
3070         (Step.save_step): Method to save step data.
3071         (Step.update_step): Method to update step data.
3072         (Step.get_existing_step): Method to fetch existing step from database.
3073         (Step.is_valid_result): Method to validate valid step result.
3074
3075 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3076
3077         [ews-app] Add method to save Build data to database
3078         https://bugs.webkit.org/show_bug.cgi?id=193735
3079
3080         Reviewed by Lucas Forschler.
3081
3082         * BuildSlaveSupport/ews-app/ews/models/build.py:
3083         (Build.save_build): Method to save build information to database.
3084         (Build.get_existing_build): Method to fetch existing build from database.
3085         (Build.is_valid_result): Method to validate build result.
3086         * BuildSlaveSupport/ews-app/ews/common/util.py:
3087         (is_valid_int_id): Method to validate valid id.
3088
3089 2019-01-28  Chris Dumez  <cdumez@apple.com>
3090
3091         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3092         https://bugs.webkit.org/show_bug.cgi?id=193915
3093         <rdar://problem/47560907>
3094
3095         Reviewed by Alex Christensen.
3096
3097         Add API test coverage.
3098
3099         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3100
3101 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3102
3103         [ews-app] Rename id variables
3104         https://bugs.webkit.org/show_bug.cgi?id=193883
3105
3106         Reviewed by Lucas Forschler.
3107
3108         * BuildSlaveSupport/ews-app/ews/models/build.py:
3109         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3110         * BuildSlaveSupport/ews-app/ews/models/step.py:
3111         * BuildSlaveSupport/ews-app/ews/urls.py:
3112         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3113         * BuildSlaveSupport/ews-app/ews/views/results.py:
3114         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3115
3116 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3117
3118         [ews-app] Allow certain fields to be empty
3119         https://bugs.webkit.org/show_bug.cgi?id=193892
3120
3121         Reviewed by Lucas Forschler.
3122
3123         * BuildSlaveSupport/ews-app/ews/models/build.py:
3124         * BuildSlaveSupport/ews-app/ews/models/step.py:
3125
3126 2019-01-28  Rob Buis  <rbuis@igalia.com>
3127
3128         Update MIME type parser
3129         https://bugs.webkit.org/show_bug.cgi?id=180526
3130
3131         Reviewed by Frédéric Wang.
3132
3133         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3134         (TestWebKitAPI::TEST):
3135
3136 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3137
3138         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3139         https://bugs.webkit.org/show_bug.cgi?id=193896
3140
3141         Reviewed by Antti Koivisto.
3142
3143         * LayoutReloaded/misc/LFC-passing-tests.txt:
3144
3145 2018-12-15  Darin Adler  <darin@apple.com>
3146
3147         Replace many uses of String::format with more type-safe alternatives
3148         https://bugs.webkit.org/show_bug.cgi?id=192742
3149
3150         Reviewed by Mark Lam.
3151
3152         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3153         (WTR::cacheTestRunnerCallback): Use makeString.
3154         * WebKitTestRunner/TestController.cpp:
3155         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3156         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3157
3158 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3159
3160         Use a load optimizer for some sites
3161         https://bugs.webkit.org/show_bug.cgi?id=193881
3162         <rdar://problem/46325455>
3163
3164         Reviewed by Brent Fulgham.
3165
3166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3167         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3168
3169 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3170
3171         AX: Introduce a static accessibility tree
3172         https://bugs.webkit.org/show_bug.cgi?id=193348
3173         <rdar://problem/47203295>
3174
3175         Reviewed by Ryosuke Niwa.
3176
3177         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3178
3179 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3180
3181         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3182         https://bugs.webkit.org/show_bug.cgi?id=193867
3183
3184         Reviewed by Antti Koivisto.
3185
3186         * LayoutReloaded/misc/LFC-passing-tests.txt:
3187
3188 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3189
3190         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3191         https://bugs.webkit.org/show_bug.cgi?id=193865
3192
3193         Reviewed by Antti Koivisto.
3194
3195         * LayoutReloaded/misc/LFC-passing-tests.txt:
3196
3197 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3198
3199         Need a mechanism to override navigator.userAgent
3200         https://bugs.webkit.org/show_bug.cgi?id=193762
3201         <rdar://problem/47504939>
3202
3203         Reviewed by Brent Fulgham.
3204
3205         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3206
3207         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3208         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3209         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3210
3211 2019-01-25  Dean Jackson  <dino@apple.com>
3212
3213         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3214         https://bugs.webkit.org/show_bug.cgi?id=193831
3215         <rdar://problem/47399263>
3216
3217         Reviewed by Chris Dumez.
3218
3219         Two new tests that exercise cross-origin and same-origin System
3220         Previews.
3221
3222         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3223
3224 2019-01-25  Keith Rollin  <krollin@apple.com>
3225
3226         Update Xcode projects with "Check .xcfilelists" build phase
3227         https://bugs.webkit.org/show_bug.cgi?id=193790
3228         <rdar://problem/47201374>
3229
3230         Reviewed by Alex Christensen.
3231
3232         Support for XCBuild includes specifying inputs and outputs to various
3233         Run Script build phases. These inputs and outputs are specified as
3234         .xcfilelist files. Once created, these .xcfilelist files need to be
3235         kept up-to-date. In order to check that they are up-to-date or not,
3236         add an Xcode build step that invokes an external script that performs
3237         the checking. If the .xcfilelists are found to be out-of-date, update
3238         them, halt the build, and instruct the developer to restart the build
3239         with up-to-date files.
3240
3241         At this time, the checking and regenerating is performed only if the
3242         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3243         who want to use this facility can set this variable and test out the
3244         checking/regenerating. Once it seems like there are no egregious
3245         issues that upset a developer's workflow, we'll unconditionally enable
3246         this facility.
3247
3248         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3249         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3250         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3251         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3252
3253 2019-01-25  Keith Rollin  <krollin@apple.com>
3254
3255         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3256         https://bugs.webkit.org/show_bug.cgi?id=193781
3257         <rdar://problem/47201153>
3258
3259         Reviewed by Alex Christensen.
3260
3261         Part of generating the .xcfilelists used as part of adopting XCBuild
3262         includes running `make DerivedSources.make` from a standalone script.
3263         It’s important for this invocation to have the same environment as
3264         when the actual build invokes `make DerivedSources.make`. If the
3265         environments are different, then the two invocations will provide
3266         different results. In order to get the same environment in the
3267         standalone script, have the script launch xcodebuild targeting the
3268         "Apply Configuration to XCFileLists" build target, which will then
3269         re-invoke our standalone script. The script is now running again, this
3270         time in an environment with all workspace, project, target, xcconfig
3271         and other environment variables established.
3272
3273         The "Apply Configuration to XCFileLists" build target accomplishes
3274         this task via a small embedded shell script that consists only of:
3275
3276             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3277
3278         The process that invokes "Apply Configuration to XCFileLists" first
3279         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3280         evaluated and exports it into the shell environment. When xcodebuild
3281         is invoked, it inherits the value of this variable and can `eval` the
3282         contents of that variable. Our external standalone script can then set
3283         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3284         of command-line parameters needed to restart itself in the appropriate
3285         state.
3286
3287         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3288         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3289
3290 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3291
3292         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3293         https://bugs.webkit.org/show_bug.cgi?id=193802
3294         <rdar://problem/46010580>
3295
3296         Reviewed by Andy Estes.
3297
3298         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3299         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3300         (TEST):
3301
3302 2019-01-25  Daniel Bates  <dabates@apple.com>
3303
3304         [iOS] uiController.keyDown() does not translate Control modified key
3305         https://bugs.webkit.org/show_bug.cgi?id=192898
3306
3307         Reviewed by Wenson Hsieh.
3308
3309         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3310         key translation, as applicable. Among other cases, key translation occurs when performing
3311         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3312         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3313         human pressing down and releasing key(s) using a hardware keyboard.
3314
3315         * WebKitTestRunner/ios/HIDEventGenerator.h:
3316         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3317         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3318
3319         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3320         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3321         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3322         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3323         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3324         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3325         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3326         (-[HIDEventGenerator longPress:completionBlock:]):
3327         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3328         Update code for above renaming.
3329
3330         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3331         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3332
3333         (-[HIDEventGenerator keyDown:]): Added.
3334         (-[HIDEventGenerator keyUp:]): Added.
3335         (-[HIDEventGenerator keyPress:completionBlock:]):
3336         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3337         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3338         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3339         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3340         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3341         (WTR::parseModifier): Deleted.
3342
3343 2019-01-25  Keith Rollin  <krollin@apple.com>
3344
3345         Complete the implementation of generate-xcfilelists
3346         https://bugs.webkit.org/show_bug.cgi?id=193782
3347
3348         Reviewed by Alex Christensen.
3349
3350         A preliminary version of generate-xcfilelists was added in r238008.
3351         This patch updates that script in order to:
3352
3353         - Support checking of .xcfilelists
3354         - Perform better execution of `make DerivedSources.make` by
3355           relaunching generate-xcfilelists under xcodebuild
3356         - Support incremental generation and checking of .xcfilelists
3357         - Support supplementary .xcfilelists files from WebKitAdditions
3358         - Support being wrapped by parallel version of generate-xcfilelists in
3359           Internal that adds support for (re)generating WebKit projects in
3360           that repo.
3361         - Support builds that have been performed in WebKitBuild as well as
3362           ~/Library/Developer/code/DerivedData
3363         - Increase robustness and debugging facilities.
3364
3365         * Scripts/generate-xcfilelists:
3366
3367 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3368
3369         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3370         https://bugs.webkit.org/show_bug.cgi?id=193297
3371         <rdar://problem/47158841>
3372
3373         Unreviewed test case fix.
3374
3375         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3376         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3377
3378         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3379         (TEST):
3380
3381 2019-01-25  Keith Rollin  <krollin@apple.com>
3382
3383         Update existing .xcfilelists
3384         https://bugs.webkit.org/show_bug.cgi?id=193791
3385         <rdar://problem/47201706>
3386
3387         Reviewed by Alex Christensen.
3388
3389         Many .xcfilelist files were added in r238824 in order to support
3390         XCBuild. Update these with recent changes to the set of build files
3391         and with the current generate-xcfilelist script.
3392
3393         * DumpRenderTree/DerivedSources-input.xcfilelist:
3394         * DumpRenderTree/DerivedSources-output.xcfilelist:
3395         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3396         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3397
3398 2019-01-25  Keith Rollin  <krollin@apple.com>
3399
3400         Fix missing dependencies in extract-dependencies-from-makefile
3401         https://bugs.webkit.org/show_bug.cgi?id=193783
3402         <rdar://problem/47201571>
3403
3404         Reviewed by Alex Christensen.
3405
3406         The extract-dependencies-from-makefile script generates .xcfilelists
3407         for XCBuild by invoking a makefile in --debug mode, parsing the
3408         dependency information in the output, and extracting information
3409         regarding targets and dependents. However, the way `make` emits this
3410         dependency information is not rigorous, and so we need to determine
3411         what lines to look for and parse by trial and error. This approach
3412         didn't coriginally atch all the information we needed to collect, so
3413         update the script to look for the additional lines we now know to look
3414         for.
3415
3416         * Scripts/extract-dependencies-from-makefile:
3417         (Parser):
3418         (Parser.addTarget):
3419         (Parser.addPrereq):
3420         (Parser.doParse):
3421
3422 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3423
3424         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3425         https://bugs.webkit.org/show_bug.cgi?id=193297
3426         <rdar://problem/47158841>
3427
3428         Reviewed by Alex Christensen.
3429
3430         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3431             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3432         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3433         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3434         activating the message used to trigger the callback when it is set.
3435
3436 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3437
3438         WKWebView.goBack should reload if there is a safe browsing warning
3439         https://bugs.webkit.org/show_bug.cgi?id=193805
3440         <rdar://problem/46908216>
3441
3442         Reviewed by Geoff Garen.
3443
3444         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3445         (+[Simple3LookupContext sharedLookupContext]):
3446         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3447         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3448         (TEST):
3449
3450 2019-01-25  Chris Dumez  <cdumez@apple.com>
3451
3452         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3453         https://bugs.webkit.org/show_bug.cgi?id=193788
3454         <rdar://problem/47531231>
3455
3456         Reviewed by Alex Christensen.
3457
3458         Add API test coverage.
3459
3460         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3461         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3462
3463 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3464
3465         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3466         https://bugs.webkit.org/show_bug.cgi?id=193771
3467
3468         Unreviewed infrastructure fix.
3469
3470         * Scripts/webkitpy/port/darwin.py:
3471         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3472
3473 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3474
3475         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3476
3477 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3478
3479         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3480
3481         * Scripts/webkitpy/common/config/contributors.json:
3482
3483 2019-01-25  Chris Dumez  <cdumez@apple.com>
3484
3485         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3486         https://bugs.webkit.org/show_bug.cgi?id=193779
3487         <rdar://problem/46170903>
3488
3489         Reviewed by Antti Koivisto.
3490
3491         Add API test that quickly navigates forward to a previous process without waiting for it to
3492         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3493         the process' previous page when reconnecting the it for the forward navigation.
3494
3495         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3496
3497 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3498
3499         Need a way for JavaScript (or bundle) code to participate in undo
3500         https://bugs.webkit.org/show_bug.cgi?id=190009
3501         <rdar://problem/44807048>
3502
3503         Reviewed by Ryosuke Niwa.
3504
3505         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3506         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3507
3508         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3509         (WTR::UIScriptController::lastUndoLabel const):
3510         (WTR::UIScriptController::firstRedoLabel const):
3511         (WTR::UIScriptController::platformUndoManager const):
3512         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3513         (WTR::UIScriptController::lastUndoLabel const):
3514         (WTR::UIScriptController::firstRedoLabel const):
3515         (WTR::UIScriptController::platformUndoManager const):
3516         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3517         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3518         (WTR::UIScriptController::lastUndoLabel const):
3519         (WTR::UIScriptController::firstRedoLabel const):
3520         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3521         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3522         (WTR::UIScriptController::lastUndoLabel const):
3523         (WTR::UIScriptController::firstRedoLabel const):
3524         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3525         (WTR::UIScriptController::platformUndoManager const):
3526         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3527         (WTR::UIScriptController::platformUndoManager const):
3528
3529 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3530
3531         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3532         https://bugs.webkit.org/show_bug.cgi?id=193824
3533
3534         Reviewed by Antti Koivisto.
3535
3536         * LayoutReloaded/misc/LFC-passing-tests.txt:
3537
3538 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3539
3540         Update macOS JSC bot configurations
3541         https://bugs.webkit.org/show_bug.cgi?id=193739
3542
3543         Reviewed by Alexey Proskuryakov.
3544
3545         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3547         (BubbleQueueServer): Move JSC EWS to Mojave section.
3548         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3549         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3550         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3551
3552 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3553
3554         [Win][WebKitTestRunner] Implement EventSenderProxy
3555         https://bugs.webkit.org/show_bug.cgi?id=193755
3556
3557         Reviewed by Don Olmstead.
3558
3559         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3560         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3561         (WTR::EventSenderProxy::dispatchMessage):
3562         (WTR::EventSenderProxy::EventSenderProxy):
3563         (WTR::EventSenderProxy::mouseDown):
3564         (WTR::EventSenderProxy::mouseUp):
3565         (WTR::EventSenderProxy::mouseMoveTo):
3566         (WTR::EventSenderProxy::mouseScrollBy):
3567         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3568
3569 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3570
3571         Unreviewed fix for API test failure after r240437.
3572
3573         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3574
3575         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3576
3577 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3578
3579         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3580         https://bugs.webkit.org/show_bug.cgi?id=193787
3581         <rdar://problem/47497634>
3582
3583         Reviewed by Alexey Proskuryakov.
3584
3585         * Scripts/webkitdirs.pm:
3586         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3587
3588 2019-01-24  Truitt Savell  <tsavell@apple.com>
3589
3590         Unreviewed, rolling out r240446.
3591
3592         Casued 5 API failures
3593
3594         Reverted changeset:
3595
3596         "Activate the WebResourceLoadStatisticsStore in the
3597         NetworkProcess and deactivate it in the UIProcess."
3598         https://bugs.webkit.org/show_bug.cgi?id=193297
3599         https://trac.webkit.org/changeset/240446
3600
3601 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3602
3603         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3604         https://bugs.webkit.org/show_bug.cgi?id=193741
3605         <rdar://problem/47135030>
3606
3607         Reviewed by Antti Koivisto and Simon Fraser.
3608
3609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3610         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3611         (TestWebKitAPI::TEST):
3612
3613 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3614
3615         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3616         https://bugs.webkit.org/show_bug.cgi?id=193297
3617         <rdar://problem/47158841>
3618
3619         Reviewed by Alex Christensen.
3620
3621         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3622         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3623         activating the message used to trigger the callback when it is set.
3624
3625 2019-01-24  John Wilander  <wilander@apple.com>
3626
3627         Add Ad Click Attribution as an internal/experimental feature
3628         https://bugs.webkit.org/show_bug.cgi?id=193685
3629         <rdar://problem/47450399>
3630
3631         Reviewed by Brent Fulgham.
3632
3633         Added test option adClickAttributionEnabled.
3634
3635         * DumpRenderTree/TestOptions.cpp:
3636         (TestOptions::TestOptions):
3637         * DumpRenderTree/TestOptions.h:
3638         * DumpRenderTree/mac/DumpRenderTree.mm:
3639         (setWebPreferencesForTestOptions):
3640
3641 2019-01-24  Antti Koivisto  <antti@apple.com>
3642
3643         [PSON] Flash on back navigation on Mac
3644         https://bugs.webkit.org/show_bug.cgi?id=193716
3645         <rdar://problem/47148458>
3646
3647         Reviewed by Chris Dumez.
3648
3649         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3650
3651         Closing of the previous page is delayed so waiting for didFinishNavigation is
3652         not sufficient to guarantee we have received all the messages. Wait for them.
3653
3654 2019-01-24  Chris Dumez  <cdumez@apple.com>
3655
3656         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3657         https://bugs.webkit.org/show_bug.cgi?id=193761
3658         <rdar://problem/47456405>
3659
3660         Reviewed by Alex Christensen.
3661
3662         Add API test coverage.
3663
3664         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3665
3666 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3667
3668         webkitpy: Missing PID in crashlog name should not be fatal
3669         https://bugs.webkit.org/show_bug.cgi?id=193771
3670
3671         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3672         of raising an exception.
3673
3674         Reviewed by Lucas Forschler.
3675
3676         * Scripts/webkitpy/port/darwin.py:
3677         (DarwinPort._merge_crash_logs):
3678
3679 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3680
3681         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3682         https://bugs.webkit.org/show_bug.cgi?id=193746
3683
3684         Reviewed by Youenn Fablet.
3685
3686         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3687         so we'd best just not call it.
3688
3689         * Scripts/webkitpy/w3c/test_exporter.py:
3690         (WebPlatformTestExporter.create_branch_with_patch):
3691
3692 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3693
3694         Move FileSystem to WTF
3695         https://bugs.webkit.org/show_bug.cgi?id=193602
3696
3697         Reviewed by Yusuke Suzuki.
3698
3699         * DumpRenderTree/win/DumpRenderTree.cpp:
3700         * TestWebKitAPI/CMakeLists.txt:
3701         * TestWebKitAPI/PlatformGTK.cmake:
3702         * TestWebKitAPI/PlatformJSCOnly.cmake:
3703         * TestWebKitAPI/PlatformPlayStation.cmake:
3704         * TestWebKitAPI/PlatformWPE.cmake:
3705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3706         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3707         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3708         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3709         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3710         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3711         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3712         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3713         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3714         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3715
3716 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3717
3718         [WPE] Remove hard dependency on subprocess32 for the API tests
3719
3720         Rubber-stamped by Carlos Garcia Campos.
3721
3722         * glib/api_test_runner.py:
3723         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3724         its presence only when running WPEQt tests.
3725
3726 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3727
3728         [GLIB] Expose JavaScriptCore options in GLib public API
3729         https://bugs.webkit.org/show_bug.cgi?id=188742
3730
3731         Reviewed by Michael Catanzaro.
3732
3733         Add a test for the new API.
3734
3735         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3736         (testsJSCOptions):
3737         (main):
3738
3739 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3740
3741         [GTK][WPE] Support JPEG 2000 images
3742         https://bugs.webkit.org/show_bug.cgi?id=186272
3743
3744         Reviewed by Žan Doberšek.
3745
3746         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3747
3748         * gtk/jhbuild.modules:
3749         * wpe/jhbuild.modules:
3750
3751 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3752
3753         check-webkit-style should warn when using soft-linking macros in a header
3754         <https://webkit.org/b/193750>
3755
3756         Reviewed by Darin Adler.
3757
3758         * Scripts/webkitpy/style/checkers/cpp.py:
3759         (check_language): Add softlink/header check by refactoring the
3760         softlink/framework check.
3761         (CppChecker): Enable softlink/header check by default.
3762         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3763         (CppStyleTest.test_softlink_framework): Rename from
3764         CppStyleTest.test_softlink() and change test framework name in
3765         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3766         files. Set file_name for macros that only appear in headers.
3767         (CppStyleTest.test_softlink_header): Add tests for using
3768         soft-link macros in headers.
3769
3770 2019-01-23  Chris Dumez  <cdumez@apple.com>
3771
3772         Deprecate API to limit the maximum number of WebProcesses
3773         https://bugs.webkit.org/show_bug.cgi?id=193725
3774         <rdar://problem/47464879>
3775
3776         Reviewed by Geoff Garen.
3777
3778         Update existing API tests to stop using deprecated API.
3779
3780         * MiniBrowser/mac/AppDelegate.m:
3781         (defaultConfiguration):
3782         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3783         (TestWebKitAPI::TEST):
3784         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3785         (TestWebKitAPI::TEST):
3786         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3787         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3788         (TEST):
3789         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3790         (TEST):
3791
3792 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3793
3794         [ews-app] Rename ews model buildermappings to buildermapping
3795         https://bugs.webkit.org/show_bug.cgi?id=193729
3796
3797         Reviewed by Lucas Forschler.
3798
3799         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3800         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3801         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3802
3803 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3804
3805         [ews-app] Rename ews model steps to step
3806         https://bugs.webkit.org/show_bug.cgi?id=193697
3807
3808         Reviewed by Lucas Forschler.
3809
3810         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3811         (Step): Renamed Steps to Step.
3812
3813 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3814
3815         Clean up IndexedDB files between tests
3816         https://bugs.webkit.org/show_bug.cgi?id=192796
3817         <rdar://problem/46824999>
3818
3819         Reviewed by Geoffrey Garen.
3820
3821         * DumpRenderTree/mac/DumpRenderTree.mm:
3822         (runTest):
3823         * WebKitTestRunner/TestController.cpp:
3824         (WTR::TestController::resetStateToConsistentValues):
3825         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3826         (WTR::RemoveAllIndexedDatabasesCallback):
3827         (WTR::TestController::ClearIndexedDatabases):
3828         * WebKitTestRunner/TestController.h:
3829         * WebKitTestRunner/TestInvocation.cpp:
3830         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3831
3832 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3833
3834         [ews-app] Rename ews model Builds to Build
3835         https://bugs.webkit.org/show_bug.cgi?id=193695
3836
3837         Reviewed by Lucas Forschler.
3838
3839         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3840         (Build): Renamed Builds to Build.
3841
3842 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3843
3844         webkitpy: Wait longer when launching WebKitTestRunner
3845         https://bugs.webkit.org/show_bug.cgi?id=193734
3846
3847         Reviewed by Aakash Jain.
3848
3849         * Scripts/webkitpy/port/simulator_process.py:
3850         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3851
3852 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3853
3854         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3855         https://bugs.webkit.org/show_bug.cgi?id=193182
3856         <rdar://problem/47452154>
3857
3858         Reviewed by Tim Horton.
3859
3860         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3861         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3862         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3863
3864         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3865         preventing later tests from recognizing gestures.
3866
3867         * WebKitTestRunner/ios/TestControllerIOS.mm:
3868         (WTR::TestController::platformResetStateToConsistentValues):
3869
3870         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3871
3872 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3873
3874         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3875         https://bugs.webkit.org/show_bug.cgi?id=193722
3876         <rdar://problem/47481475>
3877
3878         Reviewed by Lucas Forschler.
3879
3880         iPhone and iPad ports should both use the iOS config.
3881
3882         * Scripts/webkitpy/port/ios_simulator.py:
3883         (IPhoneSimulatorPort.__init__):
3884         (IPadSimulatorPort.__init__):
3885
3886 2019-01-23  Rob Buis  <rbuis@igalia.com>
3887
3888         Update MIME type parser
3889         https://bugs.webkit.org/show_bug.cgi?id=180526
3890
3891         Reviewed by Frédéric Wang.
3892
3893         Add unit tests for both parse modes of ParsedContentType.
3894
3895         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3896         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3897         (TestWebKitAPI::TEST):
3898
3899 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3900
3901         [ews-app] fetch loop should not stop on network issues
3902         https://bugs.webkit.org/show_bug.cgi?id=193666
3903
3904         Reviewed by Lucas Forschler.
3905
3906         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3907         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3908
3909 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3910
3911         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3912         https://bugs.webkit.org/show_bug.cgi?id=189165
3913         <rdar://problem/47433765>
3914
3915         Reviewed by Tim Horton.
3916
3917         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3918         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3919         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3920         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3921         would make its way to the UI process by the time the layer tree commit is finished.
3922
3923         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3924         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3925         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3926         will fail because it asks for -_autofillContext too early.
3927
3928         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3929         is handled in the UI process.
3930
3931         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3932
3933         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3934         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3935         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3936         input session.
3937
3938         (-[AutofillTestView textInputHasAutofillContext]):
3939
3940         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3941
3942         * TestWebKitAPI/cocoa/TestWKWebView.h:
3943         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3944         (nextInputSessionChangeCount):
3945
3946         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3947         This includes changing the focused element from one to another.
3948
3949         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3950         (-[TestWKWebView didStartFormControlInteraction]):
3951         (-[TestWKWebView didEndFormControlInteraction]):
3952         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3953
3954         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3955         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3956         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3957         that doesn't require an input session to one that doesn't.
3958
3959 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3960
3961         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3962         <https://webkit.org/b/193676>
3963
3964         Reviewed by Alexey Proskuryakov.
3965
3966         * Scripts/webkitpy/style/checkers/cpp.py:
3967         (check_member_initialization_list):
3968         - Don't report missing whitespace around colon if the colon at
3969           the start of the line is formatted correctly.
3970         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3971         (WebKitStyleTest.test_member_initialization_list):
3972         - Add a test for a missing permutation of existing tests.
3973         - Add a test this false-positive.
3974         - Add blank lines between subtests to make them easier to read.
3975
3976 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3977
3978         [build.webkit.org] Unit-test failure after r237113
3979         https://bugs.webkit.org/show_bug.cgi?id=193669
3980
3981         Reviewed by Michael Catanzaro.
3982
3983         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3984         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3985         multiple or zero flags.
3986
3987 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3988
3989         Cache bytecode to disk
3990         https://bugs.webkit.org/show_bug.cgi?id=192782
3991         <rdar://problem/46084932>
3992
3993         Reviewed by Keith Miller.
3994
3995         Add test helper to execute bytecode-cache tests: it executes each test
3996         twice, the first with JSC_diskCachePath set to a temporary directory
3997         and second with JSC_forceDiskCache=true (in addition to the cache path)
3998         to guarantee that only the disk cache is being used and no new
3999         UnlinkedCodeBlocks are being created.
4000
4001         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
4002         * Scripts/run-jsc-stress-tests:
4003
4004 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
4005
4006         [css-logical] Implement flow-relative margin, padding and border shorthands
4007         https://bugs.webkit.org/show_bug.cgi?id=188697
4008
4009         Reviewed by Simon Fraser and Antti Koivisto.
4010
4011         * DumpRenderTree/TestOptions.cpp:
4012         (TestOptions::TestOptions):
4013         * DumpRenderTree/TestOptions.h:
4014         * DumpRenderTree/mac/DumpRenderTree.mm:
4015         (setWebPreferencesForTestOptions):
4016         Allow tests to enable the CSSLogicalEnabled flag in WK1.
4017
4018         * Scripts/webkitpy/style/checkers/jsonchecker.py:
4019         (JSONCSSPropertiesChecker.check_codegen_properties):
4020         Allow CSS property definitions to have a 'runtime-flag' parameter which
4021         disables the property when the specified runtime flag is disabled.
4022
4023 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
4024
4025         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
4026         https://bugs.webkit.org/show_bug.cgi?id=193643
4027
4028         Reviewed by Michael Catanzaro.
4029
4030         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
4031         * wpe/jhbuild.modules: Ditto.
4032
4033 2019-01-21  Zalan Bujtas  <zalan@apple.com>
4034
4035         [LFC][Floats] Take float top position into account when computing containing block height.
4036         https://bugs.webkit.org/show_bug.cgi?id=193655
4037
4038         Reviewed by Antti Koivisto.
4039
4040         * LayoutReloaded/misc/LFC-passing-tests.txt:
4041
4042 2019-01-21  David Kilzer  <ddkilzer@apple.com>
4043
4044         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
4045         <https://webkit.org/b/193645>
4046         <rdar://problem/47421574>
4047
4048         Reviewed by Alex Christensen.
4049
4050         - Now checks for local soft-linking of all frameworks that have
4051           their own *SoftLinking.{cpp,h,mm} files.
4052         - Changes softlink/uikit warning to softlink/framework.
4053
4054         * Scripts/webkitpy/style/checkers/cpp.py:
4055         (check_language):
4056         (CppChecker):
4057         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4058         (CppStyleTest):
4059
4060 2019-01-20  Saam Barati  <sbarati@apple.com>
4061
4062         Rollout r240210: It broke tests on iOS
4063         https://bugs.webkit.org/show_bug.cgi?id=193640
4064
4065         Unreviewed.
4066
4067         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
4068         * Scripts/run-jsc-stress-tests:
4069
4070 2019-01-20  chris fleizach  <cfleizach@apple.com>
4071
4072         AX: Support returning relative frames for accessibility
4073         https://bugs.webkit.org/show_bug.cgi?id=193414
4074         <rdar://problem/47268501>
4075
4076         Reviewed by Zalan Bujtas.
4077
4078         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4079         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4080         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4081         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4082         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4083         (WTR::attributesOfElement):
4084         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4085
4086 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
4087
4088         Unreviewed, add my new email address
4089
4090         * Scripts/webkitpy/common/config/contributors.json:
4091
4092 2019-01-19  Zalan Bujtas  <zalan@apple.com>
4093
4094         [LFC][BFC] <body>'s overflow property value is propagated to viewport
4095         https://bugs.webkit.org/show_bug.cgi?id=193617
4096
4097         Reviewed by Antti Koivisto.
4098
4099         * LayoutReloaded/misc/LFC-passing-tests.txt:
4100
4101 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
4102
4103         Unreviewed, rolling out r240209.
4104
4105         Broke GTK/WPE injected bundle
4106
4107         Reverted changeset:
4108
4109         "AX: Support returning relative frames for accessibility"
4110         https://bugs.webkit.org/show_bug.cgi?id=193414
4111         https://trac.webkit.org/changeset/240209
4112
4113 2019-01-12  Dan Bernstein  <mitz@apple.com>
4114
4115         [Cocoa] Avoid importing directly from subumbrella frameworks
4116         https://bugs.webkit.org/show_bug.cgi?id=186016
4117         <rdar://problem/40591038>
4118
4119         Reviewed by Sam Weinig.
4120
4121         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4122           LaunchServices header.
4123         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4124           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4125         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4126           when using SDKs earlier than 10.13.
4127         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4128           and OTHER_CPLUSPLUSFLAGS.
4129         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4130           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4131         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4132           LaunchServices header.
4133
4134 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
4135
4136         Cache bytecode to disk
4137         https://bugs.webkit.org/show_bug.cgi?id=192782
4138         <rdar://problem/46084932>
4139
4140         Reviewed by Keith Miller.
4141
4142         Add test helper to execute bytecode-cache tests: it executes each test
4143         twice, the first with JSC_diskCachePath set to a temporary directory
4144         and second with JSC_forceDiskCache=true (in addition to the cache path)
4145         to guarantee that only the disk cache is being used and no new
4146         UnlinkedCodeBlocks are being created.
4147
4148         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
4149         * Scripts/run-jsc-stress-tests:
4150
4151 2019-01-20  chris fleizach  <cfleizach@apple.com>
4152
4153         AX: Support returning relative frames for accessibility
4154         https://bugs.webkit.org/show_bug.cgi?id=193414
4155         <rdar://problem/47268501>
4156
4157         Reviewed by Zalan Bujtas.
4158
4159         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4160         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4161         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4162         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4163         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4164         (WTR::attributesOfElement):
4165         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4166
4167 2019-01-20  Antoine Quint  <graouts@apple.com>
4168
4169         Add a POINTER_EVENTS feature flag
4170         https://bugs.webkit.org/show_bug.cgi?id=193577
4171         <rdar://problem/47408511>
4172
4173         Unreviewed. Also enable Pointer Events for iosmac.
4174
4175         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4176
4177 2019-01-19  Zalan Bujtas  <zalan@apple.com>
4178
4179         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
4180         https://bugs.webkit.org/show_bug.cgi?id=193613
4181
4182         Reviewed by Antti Koivisto.
4183
4184         * LayoutReloaded/misc/LFC-passing-tests.txt:
4185
4186 2019-01-19  Antoine Quint  <graouts@apple.com>
4187
4188         Add a POINTER_EVENTS feature flag
4189         https://bugs.webkit.org/show_bug.cgi?id=193577
4190
4191         Reviewed by Dean Jackson.
4192
4193         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4194
4195 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
4196
4197         Disable the run-jsc-stress-test remote host key check [second round].
4198         https://bugs.webkit.org/show_bug.cgi?id=192988
4199
4200         Reviewed by Dewei Zhu.
4201
4202         * Scripts/run-jsc-stress-tests:
4203
4204 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4205
4206         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
4207         https://bugs.webkit.org/show_bug.cgi?id=193597
4208
4209         Reviewed by Lucas Forschler.
4210
4211         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4212
4213 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4214
4215         [build.webkit.org] api tests failures are incorrectly named as unit test failures
4216         https://bugs.webkit.org/show_bug.cgi?id=193595
4217
4218         Reviewed by Lucas Forschler.
4219
4220         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
4221         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
4222         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
4223
4224 2019-01-18  Chris Dumez  <cdumez@apple.com>
4225
4226         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
4227         https://bugs.webkit.org/show_bug.cgi?id=193588
4228         <rdar://problem/47131566>
4229
4230         Reviewed by Alex Christensen.
4231
4232         Add layout test coverage.
4233
4234         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4235
4236 2019-01-18  Jer Noble  <jer.noble@apple.com>
4237
4238         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
4239         https://bugs.webkit.org/show_bug.cgi?id=189553
4240
4241         Reviewed by Tim Horton.
4242
4243         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
4244
4245         * ContentExtensionTester/Configurations/Base.xcconfig:
4246         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
4247         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4248         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
4249         * ImageDiff/cg/Configurations/Base.xcconfig:
4250         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
4251         * MiniBrowser/Configurations/Base.xcconfig:
4252         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4253         * MobileMiniBrowser/Configurations/Base.xcconfig:
4254         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4255         * Scripts/webkitpy/style/checker.py:
4256         (_all_categories):
4257         (FileType):
4258         (CheckerDispatcher._file_type):
4259         (CheckerDispatcher._create_checker):
4260         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
4261         (SDKVariantChecker):
4262         (SDKVariantChecker.__init__):
4263         (SDKVariantChecker.check):
4264         * TestWebKitAPI/Configurations/Base.xcconfig:
4265         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
4266         * WebEditingTester/Configurations/Base.xcconfig:
4267         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
4268         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
4269         * WebKitTestRunner/Configurations/Base.xcconfig:
4270         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
4271         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
4272         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
4273
4274 2019-01-18  David Kilzer  <ddkilzer@apple.com>
4275
4276         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
4277         <https://webkit.org/b/193568>
4278         <rdar://problem/47381130>
4279
4280         Reviewed by Alex Christensen.
4281
4282         Make sure no one re-introduces UIKit soft-linking by adding a
4283         style rule.
4284
4285         * Scripts/webkitpy/style/checkers/cpp.py:
4286         (check_language): Add softlink/uikit check.
4287         (CppChecker): Enable softlink/uikit check.
4288         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4289         (CppStyleTest): Add test for softlink/uikit.
4290
4291 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
4292
4293         [GTK] install-dependencies tool looks for libunistring-dev for dnf
4294         https://bugs.webkit.org/show_bug.cgi?id=193584
4295
4296         Change "-dev" to "-devel".
4297
4298         Reviewed by Michael Catanzaro.
4299
4300         * gtk/install-dependencies:
4301
4302 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4303
4304         webkitpy: Add iPhone and iPad ports
4305         https://bugs.webkit.org/show_bug.cgi?id=193537
4306         <rdar://problem/47353390>
4307
4308         Reviewed by Lucas Forschler.
4309
4310         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
4311         ports. Note that this separation is optional, the --ios-simulator command remains.
4312
4313         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4314         (RunTest.test_device_type_test_division): Drive-by fix.
4315         (RunTest.test_device_type_specific_listing): Ditto.
4316         (RunTest.test_ipad_test_division):
4317         (RunTest):
4318         (RunTest.test_ipad_listing):
4319         * Scripts/webkitpy/port/factory.py:
4320         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
4321         (PortFactory):
4322         * Scripts/webkitpy/port/ios_simulator.py:
4323         (IPhoneSimulatorPort):
4324         (IPadSimulatorPort):
4325
4326 2019-01-18  Chris Dumez  <cdumez@apple.com>
4327
4328         Regression(PSON) Scroll position is not always restored properly when navigating back
4329         https://bugs.webkit.org/show_bug.cgi?id=193578
4330         <rdar://problem/47386331>
4331
4332         Reviewed by Tim Horton.
4333
4334         Add API test coverage.
4335
4336         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4337
4338 2019-01-18  Youenn Fablet  <youenn@apple.com>
4339
4340         Add a new SPI to request for cache storage quota increase
4341         https://bugs.webkit.org/show_bug.cgi?id=193323
4342
4343         Reviewed by Alex Christensen.
4344
4345         Implement WebsiteDataStore quota delegate to handle quota requests.
4346         By default, do not update quota.
4347         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
4348
4349         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4350         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4351         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
4352         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4353         * WebKitTestRunner/TestController.cpp:
4354         (WTR::TestController::allowCacheStorageQuotaIncrease):
4355         * WebKitTestRunner/TestController.h:
4356         * WebKitTestRunner/TestInvocation.cpp:
4357         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):