Make UIWKDocumentContext rects per-character instead of per-word
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2
3         Make UIWKDocumentContext rects per-character instead of per-word
4         https://bugs.webkit.org/show_bug.cgi?id=196459
5
6         Reviewed by Wenson Hsieh.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
9         (TEST):
10         Adjust test results due to switching to per-character rects.
11
12 2019-04-01  Chris Dumez  <cdumez@apple.com>
13
14         UIProcess crash when a prewarmed process is terminated
15         https://bugs.webkit.org/show_bug.cgi?id=196451
16         <rdar://problem/49245471>
17
18         Reviewed by Geoffrey Garen.
19
20         Add API test coverage.
21
22         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
23         (TEST):
24
25 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
26
27         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
28         https://bugs.webkit.org/show_bug.cgi?id=196449
29
30         Reviewed by Lucas Forschler.
31
32         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
33         (StatusBubble.get_os_details): Method to get OS and Xcode details.
34         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
35         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
36
37 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
38
39         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
40         https://bugs.webkit.org/show_bug.cgi?id=196444
41
42         Reviewed by Lucas Forschler.
43
44         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
45
46 2019-04-01  Alex Christensen  <achristensen@webkit.org>
47
48         Add SPI to canonicalize NSURLs with WTF::URL
49         https://bugs.webkit.org/show_bug.cgi?id=196415
50         <rdar://problem/44980271>
51
52         Reviewed by Darin Adler.
53
54         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
55         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
56         (TestWebKitAPI::TEST):
57
58 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
59
60         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
61         https://bugs.webkit.org/show_bug.cgi?id=196441
62
63         Reviewed by Carlos Garcia Campos.
64
65         Don't cache the wpe_view_backend object that might not exist yet at the
66         time of EventSenderProxy constructor invocation, but instead retrieve
67         that object whenever it's required for event dispatching. This should
68         avoid crashes in this constructor now that it's invoked before any
69         PlatformWindow has been set up (as changed in r243496).
70
71         * WebKitTestRunner/EventSenderProxy.h:
72         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
73         (WTR::viewBackend):
74         (WTR::EventSenderProxy::EventSenderProxy):
75         (WTR::EventSenderProxy::mouseDown):
76         (WTR::EventSenderProxy::mouseUp):
77         (WTR::EventSenderProxy::mouseMoveTo):
78         (WTR::EventSenderProxy::mouseScrollBy):
79         (WTR::EventSenderProxy::keyDown):
80         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
81
82 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
83
84         [Win][WebKit] MiniBrowser should support high DPI display
85         https://bugs.webkit.org/show_bug.cgi?id=196391
86
87         Reviewed by Alex Christensen.
88
89         * MiniBrowser/win/WebKitBrowserWindow.cpp:
90         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
91         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
92         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
93
94 2019-03-31  Sam Weinig  <weinig@apple.com>
95
96         Remove more i386 specific configurations
97         https://bugs.webkit.org/show_bug.cgi?id=196430
98
99         Reviewed by Alexey Proskuryakov.
100
101         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
102         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
103
104 2019-03-31  Andy Estes  <aestes@apple.com>
105
106         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
107         https://bugs.webkit.org/show_bug.cgi?id=196433
108         <rdar://problem/49293305>
109
110         Reviewed by Tim Horton.
111
112         Enhanced API test coverage to include all navigation response policy decisions in both
113         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
114
115         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
116         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
117         (TestWebKitAPI::TEST):
118         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
119         (readFile):
120         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
121         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
122         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
123         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
124         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
125         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
126         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
127         (-[QuickLookDelegate _downloadDidStart:]):
128         (-[QuickLookDelegate _download:didReceiveResponse:]):
129         (-[QuickLookDelegate _download:didReceiveData:]):
130         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
131         (-[QuickLookDelegate _downloadDidFinish:]):
132         (-[QuickLookDelegate _download:didFailWithError:]):
133         (-[QuickLookDelegate _downloadDidCancel:]):
134         (-[QuickLookDelegate verifyDownload]):
135         (runTest):
136         (runTestDecideBeforeLoading):
137         (runTestDecideAfterLoading):
138         (TEST):
139         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
140         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
141         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
142         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
143         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
144         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
145         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
146         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
147         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
148         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
149         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
150         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
151         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
152         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
153
154 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
155
156         [CMake] add testdfg as target with build-jsc
157         https://bugs.webkit.org/show_bug.cgi?id=196393
158
159         Reviewed by Saam Barati.
160
161         Added testdfg as one of the targets to build when
162         using CMake.
163
164         * Scripts/build-jsc:
165
166 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
167
168         Delete WebMetal implementation in favor of WebGPU
169         https://bugs.webkit.org/show_bug.cgi?id=195418
170
171         Reviewed by Dean Jackson.
172
173         * DumpRenderTree/mac/DumpRenderTree.mm:
174         (enableExperimentalFeatures):
175         (resetWebPreferencesToConsistentValues):
176         * Scripts/webkitperl/FeatureList.pm:
177         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
179         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
180         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
181         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
182         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
183         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
184         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
185         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
186         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
187         (WTR::InjectedBundle::beginTesting):
188         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
189         (WTR::TestRunner::setWebMetalEnabled): Deleted.
190         * WebKitTestRunner/InjectedBundle/TestRunner.h:
191
192 2019-03-29  Chris Dumez  <cdumez@apple.com>
193
194         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
195         https://bugs.webkit.org/show_bug.cgi?id=196405
196         <rdar://problem/49428130>
197
198         Reviewed by Wenson Hsieh.
199
200         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
201         the popover presentation methods to be no-ops. Use this in the new test added in
202         r243523 so that we do not swizzle those methods for all tests. This is needed because
203         those WatchOS tests rely on the popover getting presented and interactive.
204
205         * WebKitTestRunner/TestController.cpp:
206         (WTR::updateTestOptionsFromTestHeader):
207         * WebKitTestRunner/TestController.h:
208         * WebKitTestRunner/TestOptions.h:
209         (WTR::TestOptions::hasSameInitializationOptions const):
210         * WebKitTestRunner/ios/TestControllerIOS.mm:
211         (WTR::TestController::platformInitialize):
212         (WTR::TestController::platformResetStateToConsistentValues):
213
214 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
215
216         [Curl] Add Server Trust Evaluation Support.
217         https://bugs.webkit.org/show_bug.cgi?id=191646
218
219         Reviewed by Fujii Hironori.
220
221         Implemented MiniBrowser UI for asking if user trusts the server.
222
223         * MiniBrowser/win/Common.cpp:
224         (askServerTrustEvaluation):
225         (replaceString):
226         * MiniBrowser/win/Common.h:
227         * MiniBrowser/win/MiniBrowserLib.rc:
228         * MiniBrowser/win/MiniBrowserLibResource.h:
229         * MiniBrowser/win/WebKitBrowserWindow.cpp:
230         (createPEMString):
231         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
232         (WebKitBrowserWindow::canTrustServerCertificate):
233         * MiniBrowser/win/WebKitBrowserWindow.h:
234
235 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
236
237         Implement ResizeObserver.
238         https://bugs.webkit.org/show_bug.cgi?id=157743
239
240         Reviewed by Simon Fraser.
241
242         Support resizeObserverEnabled webPreferences.
243
244         * DumpRenderTree/TestOptions.cpp:
245         (TestOptions::TestOptions):
246         * DumpRenderTree/TestOptions.h:
247         * DumpRenderTree/mac/DumpRenderTree.mm:
248         (setWebPreferencesForTestOptions):
249         * DumpRenderTree/win/DumpRenderTree.cpp:
250         (enableExperimentalFeatures):
251         * Scripts/webkitperl/FeatureList.pm:
252         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
253
254 2019-03-28  John Wilander  <wilander@apple.com>
255
256         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
257         https://bugs.webkit.org/show_bug.cgi?id=196281
258         <rdar://problem/48938748>
259
260         Reviewed by Alex Christensen.
261
262         This patch adds the function isStatisticsHasLocalStorage() to the
263         TestRunner. With it, the page can query the WebsiteDataStore in the
264         UI process to make sure that it sees LocalStorage.
265
266         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
267         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
268         (WTR::TestRunner::isStatisticsHasLocalStorage):
269         * WebKitTestRunner/InjectedBundle/TestRunner.h:
270         * WebKitTestRunner/TestController.cpp:
271         (WTR::TestController::isStatisticsHasLocalStorage):
272         * WebKitTestRunner/TestController.h:
273         * WebKitTestRunner/TestInvocation.cpp:
274         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
275
276 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
277
278         API::Data::createWithoutCopying should do a null check before calling CFRelease
279         https://bugs.webkit.org/show_bug.cgi?id=196276
280         <rdar://problem/48059859>
281
282         Reviewed by Alex Christensen.
283
284         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
285
286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
287         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
288         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
289         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
290         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
291         (TestWebKitAPI::TEST):
292
293 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
294
295         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
296         https://bugs.webkit.org/show_bug.cgi?id=186276
297
298         Reviewed by Carlos Garcia Campos.
299
300         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
301         (webViewLoadChanged):
302         (testWebResourceGetDataError):
303         (testWebResourceGetDataEmpty):
304         (beforeAll):
305         (webViewloadChanged): Deleted.
306
307 2019-03-27  Andy Estes  <aestes@apple.com>
308
309         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
310         https://bugs.webkit.org/show_bug.cgi?id=196317
311
312         Reviewed by Dan Bernstein.
313
314         package-root copies built products into a staging directory using ditto(1), which does not
315         follow symbolic links as it traverses a directory. Now that the files in
316         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
317         itself, these become broken links when ditto'd into the staging directory.
318
319         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
320
321         * Scripts/package-root:
322
323 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
324
325         [ews-app] Update display text of Submit for ews analysis
326         https://bugs.webkit.org/show_bug.cgi?id=196309
327
328         Reviewed by Dewei Zhu.
329
330         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
331
332 2019-03-27  David Kilzer  <ddkilzer@apple.com>
333
334         run-webkit-tests should check for leaks in WebKit processes
335         <https://webkit.org/b/193772>
336         <rdar://problem/46526680>
337
338         Reviewed by Ryosuke Niwa.
339
340         This works by doing the following:
341         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
342           The list of child processes are returned one per line:
343           process.name: pid
344         - Run the "#LIST CHILD PROCESSES" command just before the
345           "#CHECK FOR WORLD LEAKS" command, and store the list of child
346           processes on the ServerProcess object.
347         - When the `--leaks` switch is handled, run check_for_leaks() on
348           each child process after the main test harness.
349
350         * DumpRenderTree/mac/DumpRenderTree.mm:
351         (handleControlCommand):
352         - Use strncmp() instead of strcmp().
353         - Add support for handling "#LIST CHILD PROCESSES" command.
354
355         * Scripts/webkitpy/port/base.py:
356         (Port.check_for_leaks):
357         * Scripts/webkitpy/port/darwin.py:
358         (DarwinPort.check_for_leaks):
359         - Rename redundant 'process_pid' argument to 'process_id'.
360
361         * Scripts/webkitpy/port/driver.py:
362         (Driver.do_post_tests_work):
363         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
364           longer the only command this sends to WebKitTestRunner.
365         - If the `--leaks` switch is present, send the
366           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
367           result using Port.set_webkit_processes().
368         (Driver._parse_child_processes_output):
369         - Add helper method to parse list of child process names and
370           process IDs returned from WebKitTestRunner.
371
372         * Scripts/webkitpy/port/ios_device.py:
373         (IOSDevicePort.check_for_leaks):
374         - Rename redundant 'process_pid' argument to 'process_id'.
375
376         * Scripts/webkitpy/port/leakdetector.py:
377         (LeakDetector._parse_leaks_output):
378         - Return early if there is no leaks_output.
379         (LeakDetector.check_for_leaks):
380         - Rename redundant 'process_pid' argument to 'process_id'.
381
382         * Scripts/webkitpy/port/server_process.py:
383         (ServerProcess.__init__):
384         (ServerProcess.child_processes):
385         (ServerProcess.set_child_processes):
386         - Add instance variable to Port to store list of child process
387           names and process IDs returned from WebKitTestRunner.
388         (ServerProcess._start):
389         - Clear self._child_processes.
390         (ServerProcess.stop):
391         - If self._child_processes is set, call
392           self._port.check_for_leaks() for each child process.
393
394         * Scripts/webkitpy/port/server_process_unittest.py:
395         (TrivialMockPort.check_for_leaks):
396         - Rename redundant 'process_pid' argument to 'process_id'.
397
398         * Scripts/webkitpy/port/simulator_process.py:
399         (SimulatorProcess.stop):
400         - If self._child_processes is set, call
401           self._port.check_for_leaks() for each child process.
402
403         * Scripts/webkitpy/port/watch_device.py:
404         (WatchDevicePort.check_for_leaks):
405         - Rename redundant 'process_pid' argument to 'process_id'.
406
407         * WebKitTestRunner/TestController.cpp:
408         (WTR::TestController::dumpResponse):
409         - Extract method from findAndDumpWorldLeaks() so that it may be
410           reused by findAndDumpWebKitProcessIdentifiers().
411         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
412         - Add method to output process name and process ID of both the
413           WebContent and Networking processes.
414         (WTR::TestController::findAndDumpWorldLeaks):
415         - Fix missing newline in output when there were no abandoned
416           documents.
417         - Call dumpResponse() for extracted code.
418         (WTR::TestController::handleControlCommand):
419         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
420         - Use strncmp() instead of strcmp().
421         - Call findAndDumpWebKitProcessIdentifiers() when
422           "#LIST CHILD PROCESSES" command is sent.
423         * WebKitTestRunner/TestController.h:
424         (WTR::TestController::dumpResponse):
425         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
426         - Declare methods.
427
428 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
429
430         Unreviewed. Add GLib API test cases after r243434.
431
432         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
433         (testWebViewActiveURI):
434         (serverCallback):
435         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
436         (sendRequestCallback):
437
438 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
439
440         Geolocation request not complete when watch request was started in a different web process
441         https://bugs.webkit.org/show_bug.cgi?id=195996
442
443         Reviewed by Alex Christensen.
444
445         Add a test case.
446
447         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
448         (TestWebKitAPI::runJavaScriptAlert):
449         (TestWebKitAPI::TEST):
450
451 2019-03-26  Keith Rollin  <krollin@apple.com>
452
453         Update the way generate-xcfilelists returns strings from functions
454         https://bugs.webkit.org/show_bug.cgi?id=195975
455         <rdar://problem/49040807>
456
457         Reviewed by Dean Jackson.
458
459         There are places where generate-xcfilelists executes assignments with
460         statements like:
461
462             FOO=$(some_function)
463
464         where "some_function" return a string by echoing it. E.g.
465
466             some_function()
467             {
468                 echo "Hello, World"
469             }
470
471         This is a common idiom, but it has a problem if "some_function" needs
472         to call "exit" in an attempt to halt the entire script right then and
473         there. Since "some_function" is called inside of $(), it's being
474         executed in a sub-shell. Calling exit in that sub-shell simply exits
475         that shell; it doesn't not exit the outer shell in which the main part
476         of the script is still running. As such, the main script keeps
477         executing when the intent was for the script to halt.
478
479         The solution to this is to use a different idiom for returning
480         strings. The one we now is to pass in the name of the variable to
481         receive the string result:
482
483             some_function()
484             {
485                 variable_name=$1
486                 eval $variable_name ="Hello, World"
487             }
488
489         The call site now looks like
490
491             some_function FOO
492
493         Because there's no invocation of a sub-shell, some_function can now
494         call "exit" if it wants to, and the entire script will exit at that
495         point.
496
497         * Scripts/generate-xcfilelists:
498
499 2019-03-26  Chris Dumez  <cdumez@apple.com>
500
501         Add basic layout test coverage for File Picker on iOS
502         https://bugs.webkit.org/show_bug.cgi?id=196265
503
504         Reviewed by Wenson Hsieh.
505
506         Add layout test infrastructure to test the file picker on iOS.
507
508         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
509         (WTR::UIScriptController::dismissFilePicker):
510         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
511         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
512         (WTR::UIScriptController::dismissFilePicker):
513         * TestRunnerShared/UIScriptContext/UIScriptController.h:
514         * WebKitTestRunner/TestController.cpp:
515         (WTR::TestController::createWebViewWithOptions):
516         (WTR::updateTestOptionsFromTestHeader):
517         * WebKitTestRunner/TestOptions.h:
518         (WTR::TestOptions::hasSameInitializationOptions const):
519         * WebKitTestRunner/ios/TestControllerIOS.mm:
520         (overridePresentViewController):
521         (WTR::TestController::platformInitialize):
522         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
523         (WTR::UIScriptController::dismissFilePicker):
524
525 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
526
527         Implement async paste method on UIWKInteractionViewProtocol
528         https://bugs.webkit.org/show_bug.cgi?id=196267
529         <rdar://problem/49236346>
530
531         Reviewed by Tim Horton.
532
533         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
534         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
535         are now a part of all iOS 12 internal SDKs.
536
537         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
538
539         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
540         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
541
542         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
543         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
544         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
545         * TestWebKitAPI/ios/UIKitSPI.h:
546
547 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
548
549         [ews-build] Use PostgreSQL for ews.webkit.org database
550         https://bugs.webkit.org/show_bug.cgi?id=196270
551
552         Reviewed by Lucas Forschler.
553
554         * BuildSlaveSupport/ews-app/ews-app/settings.py:
555
556 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
557
558         [ews] Reset simctl states on reboot
559         https://bugs.webkit.org/show_bug.cgi?id=196260
560
561         Rubber-stamped by Aakash Jain.
562
563         * EWSTools/start-queue-mac.sh:
564
565 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
566
567         [ews-build] Use PostgreSQL for ews-build database
568         https://bugs.webkit.org/show_bug.cgi?id=196229
569
570         Reviewed by Lucas Forschler.
571
572         * BuildSlaveSupport/ews-build/master.cfg:
573
574 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
575
576         [ews-build] Get master_hostname dynamically in master.cfg
577         https://bugs.webkit.org/show_bug.cgi?id=196255
578
579         Reviewed by Lucas Forschler.
580
581         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
582         send events data in test mode.
583
584 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
585
586         [ews-app] Set db_constraint to False for Foreign Keys
587         https://bugs.webkit.org/show_bug.cgi?id=196252
588
589         Reviewed by Lucas Forschler.
590
591         * BuildSlaveSupport/ews-app/ews/models/build.py:
592         * BuildSlaveSupport/ews-app/ews/models/step.py:
593
594 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
595
596         [ews-build] is_test_mode_enabled should default to True
597         https://bugs.webkit.org/show_bug.cgi?id=196248
598
599         Reviewed by Lucas Forschler.
600
601         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
602
603 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
604
605         [ews-app] Add webkitperl to ENABLED_QUEUES
606         https://bugs.webkit.org/show_bug.cgi?id=196253
607
608         Reviewed by Lucas Forschler.
609
610         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
611
612 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
613
614         Address NSWindow sometimes using WebKitTestRunnerEvent too early
615         https://bugs.webkit.org/show_bug.cgi?id=196211
616         rdar://problem/49110552
617
618         Reviewed by Tim Horton.
619
620         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
621         Make sure that EventSenderProxy always exists when running tests. We used to create
622         it when resetting before the first test, which is a bit too late.
623
624         * WebKitTestRunner/TestController.h:
625         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
626         (WTR::TestController::platformCreateWebView):
627         (WTR::TestController::platformCreateOtherPage):
628         (WTR::TestController::finishCreatingPlatformWebView):
629         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
630         (WTR::PlatformWebView::PlatformWebView):
631         Moved some code that made NSWindow use NSEvent during web view creation. We may
632         need to move more if some other case us found, but this is enough for now.
633
634 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
635
636         Unreviewed. Fix typo in GLib geolocation API after r243285.
637
638         gelocation -> geolocation.
639
640         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
641         (testGeolocationManagerWatchPosition):
642
643 2019-03-25  Alex Christensen  <achristensen@webkit.org>
644
645         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
646         https://bugs.webkit.org/show_bug.cgi?id=196213
647
648         Reviewed by Geoff Garen.
649
650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
651         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
652         (credentialWithIdentityAndKeychainPath):
653         (-[ChallengeDelegate webView:didFinishNavigation:]):
654         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
655         (TestWebKitAPI::TEST):
656
657 2019-03-25  Alex Christensen  <achristensen@webkit.org>
658
659         Expected shouldn't assume its contained types are copyable
660         https://bugs.webkit.org/show_bug.cgi?id=195986
661
662         Reviewed by JF Bastien.
663
664         * TestWebKitAPI/Tests/WTF/Expected.cpp:
665         (TestWebKitAPI::NonCopyable::operator== const):
666         (TestWebKitAPI::NonCopyable::operator!= const):
667         (TestWebKitAPI::TEST):
668
669 2019-03-25  Tim Horton  <timothy_horton@apple.com>
670
671         Remove some now-unnecessary dynamic class lookup
672         https://bugs.webkit.org/show_bug.cgi?id=196237
673
674         Reviewed by Simon Fraser.
675
676         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
677         (makeRequest):
678         (TEST):
679
680 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
681
682         Unreviewed, rolling out r243450.
683
684         AppleWin and WinCairo port builds get broken.
685
686         Reverted changeset:
687
688         "Add test for fix of #196095"
689         https://bugs.webkit.org/show_bug.cgi?id=196097
690         https://trac.webkit.org/changeset/243450
691
692 2019-03-25  Commit Queue  <commit-queue@webkit.org>
693
694         Unreviewed, rolling out r243465.
695         https://bugs.webkit.org/show_bug.cgi?id=196226
696
697         the test doesn't build (Requested by thorton on #webkit).
698
699         Reverted changeset:
700
701         "Do not terminate the NetworkProcess if a third party
702         application sends a NSCredential with a SecIdentityRef"
703         https://bugs.webkit.org/show_bug.cgi?id=196213
704         https://trac.webkit.org/changeset/243465
705
706 2019-03-25  Alex Christensen  <achristensen@webkit.org>
707
708         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
709         https://bugs.webkit.org/show_bug.cgi?id=196213
710
711         Reviewed by Geoff Garen.
712
713         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
714         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
715         (credentialWithIdentityAndKeychainPath):
716         (-[ChallengeDelegate webView:didFinishNavigation:]):
717         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
718         (TestWebKitAPI::TEST):
719
720 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
721
722         [ews-build] Gracefully handle missing patch_id in events
723         https://bugs.webkit.org/show_bug.cgi?id=196216
724
725         Reviewed by Lucas Forschler.
726
727         * BuildSlaveSupport/ews-build/events.py:
728
729 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
730
731         [ews-build] use lz4 compression for improving buildbot performance
732         https://bugs.webkit.org/show_bug.cgi?id=196155
733
734         Reviewed by Lucas Forschler.
735
736         * BuildSlaveSupport/ews-build/master.cfg:
737
738 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
739
740         Pull some API testing helper methods out of TestWKWebView
741         https://bugs.webkit.org/show_bug.cgi?id=196212
742
743         Reviewed by Tim Horton.
744
745         Refactor some more API testing utility methods, so that they can be used in
746         tests that do not use TestWKWebView.
747
748         * TestWebKitAPI/cocoa/TestWKWebView.h:
749         * TestWebKitAPI/cocoa/TestWKWebView.mm:
750         (-[WKWebView loadTestPageNamed:]):
751         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
752         (-[WKWebView synchronouslyLoadHTMLString:]):
753         (-[WKWebView synchronouslyLoadTestPageNamed:]):
754         (-[TestWKWebView loadTestPageNamed:]): Deleted.
755         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
756         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
757         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
758
759 2019-03-25  Jer Noble  <jer.noble@apple.com>
760
761         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
762         https://bugs.webkit.org/show_bug.cgi?id=196097
763
764         Reviewed by Eric Carlson.
765
766         Drive-by bug fix: allow tests to play audio without a user gesture by default.
767
768         * DumpRenderTree/mac/DumpRenderTree.mm:
769         (resetWebPreferencesToConsistentValues):
770         * WebKitTestRunner/TestController.cpp:
771         (WTR::TestController::resetPreferencesToConsistentValues):
772
773 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
774
775         Pull IPadUserInterfaceSwizzler out into a separate header file
776         https://bugs.webkit.org/show_bug.cgi?id=196193
777
778         Reviewed by Anders Carlsson.
779
780         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
781         be used in other API tests.
782
783         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
784         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
785         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
786         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
787         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
788         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
789         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
790
791 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
792
793         Remove NavigatorContentUtils in WebCore/Modules
794         https://bugs.webkit.org/show_bug.cgi?id=196070
795
796         Reviewed by Alex Christensen.
797
798         NavigatorContentUtils was to support the custom scheme spec [1].
799         However, in WebKit side, no port has supported the feature in
800         WebKit layer after EFL port was removed. So there has been the
801         only IDL implementation of the NavigatorContentUtils in WebCore.
802         So we don't need to keep the implementation in WebCore anymore.
803
804         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
805
806         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
807
808 2019-03-24  Andy Estes  <aestes@apple.com>
809
810         [watchOS] Remove unused Proximity Networking code
811         https://bugs.webkit.org/show_bug.cgi?id=196188
812
813         Reviewed by Tim Horton.
814
815         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
816         (TEST):
817
818 2019-03-23  Keith Miller  <keith_miller@apple.com>
819
820         Refactor clz/ctz and fix getLSBSet.
821         https://bugs.webkit.org/show_bug.cgi?id=196162
822
823         Reviewed by Saam Barati.
824
825         Add tests for clz, ctz, getLSBSet, and getMSBSet.
826
827         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
828         (TestWebKitAPI::TEST):
829
830 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
831
832         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
833         https://bugs.webkit.org/show_bug.cgi?id=196143
834
835         Reviewed by Michael Catanzaro.
836
837         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
838         directories.
839
840         * Scripts/webkitpy/style/checkers/cpp.py:
841         (check_identifier_name_in_declaration):
842         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
843         (WebKitStyleTest.test_names):
844
845 2019-03-22  Philippe Normand  <pnormand@igalia.com>
846
847         [Flatpak] Manifest expanding fails for qt WPE extension
848         https://bugs.webkit.org/show_bug.cgi?id=196148
849
850         Reviewed by Alex Christensen.
851
852         * flatpak/flatpakutils.py:
853         (expand_submodules_recurse): The last recurse manifest expand
854         iteration might lead to a single module so take it into account
855         and don't try to recurse further.
856
857 2019-03-22  Chris Dumez  <cdumez@apple.com>
858
859         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
860         https://bugs.webkit.org/show_bug.cgi?id=195348
861         <rdar://problem/48622090>
862
863         Reviewed by Alex Christensen.
864
865         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
866         to NO when test.options().shouldIgnoreMetaViewport is false.
867
868         * WebKitTestRunner/ios/TestControllerIOS.mm:
869         (WTR::TestController::platformConfigureViewForTest):
870
871 2019-03-22  Chris Dumez  <cdumez@apple.com>
872
873         Prewarmed processes should be usable with any website data store
874         https://bugs.webkit.org/show_bug.cgi?id=196104
875
876         Reviewed by Alex Christensen.
877
878         Add API test coverage.
879
880         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
881         (runInitialWarmedProcessUsedTest):
882         (TEST):
883
884 2019-03-22  David Kilzer  <ddkilzer@apple.com>
885
886         Back out local changes to Alex's Subversion working directory
887
888         They were accidentally committed.
889
890         * Scripts/webkitpy/common/system/abstractexecutive.py:
891         (AbstractExecutive.wait_newest):
892         * Scripts/webkitpy/common/system/executive.py:
893         (Executive.running_pids):
894         * Scripts/webkitpy/common/system/executive_mock.py:
895         (MockExecutive.running_pids):
896         * Scripts/webkitpy/common/system/executive_unittest.py:
897         (ExecutiveTest.serial_test_running_pids):
898         * Scripts/webkitpy/port/darwin.py:
899         (DarwinPort.check_for_leaks):
900         * Scripts/webkitpy/port/leakdetector.py:
901         (LeakDetector.check_for_leaks):
902         - This was the hack attached to Bug 193772.
903
904         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
905         (+[WebKitTestRunnerEvent mouseLocation]):
906         - This works around a crash on an internal build.
907
908 2019-03-22  Tim Horton  <timothy_horton@apple.com>
909
910         Fix the build after r243354
911         https://bugs.webkit.org/show_bug.cgi?id=196138
912         <rdar://problem/49145951>
913
914         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
915         (TEST):
916         * TestWebKitAPI/ios/UIKitSPI.h:
917
918 2019-03-21  Tim Horton  <timothy_horton@apple.com>
919
920         Adopt UIWKDocumentContext
921         https://bugs.webkit.org/show_bug.cgi?id=196040
922         <rdar://problem/48642440>
923
924         Reviewed by Ryosuke Niwa.
925
926         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
927         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
928         (makeRequest):
929         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
930         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
931         (applyStyle):
932         (TEST):
933         Add tests for UIWKDocumentContext.
934
935         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
936         (TEST):
937         (recursiveFindWKContentView): Deleted.
938         * TestWebKitAPI/cocoa/TestWKWebView.h:
939         * TestWebKitAPI/cocoa/TestWKWebView.mm:
940         (recursiveFindWKContentView):
941         (-[TestWKWebView wkContentView]):
942         * TestWebKitAPI/ios/UIKitSPI.h:
943         Share the WKContentView finding code between tests.
944
945 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
946
947         [iOS WK2] Turn on async overflow scrolling by default
948         https://bugs.webkit.org/show_bug.cgi?id=196011
949         rdar://problem/48453859
950
951         Reviewed by Antti Koivisto.
952         
953         Explicitly turn off the async overflow scrolling internal feature for tests by default,
954         since so many basic layout tests have different results when compositing is triggered for
955         overflow.
956         
957         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
958
959         * WebKitTestRunner/TestController.cpp:
960         (WTR::TestController::resetPreferencesToConsistentValues):
961
962 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
963
964         [ews-build] Retry API test in case of failures
965         https://bugs.webkit.org/show_bug.cgi?id=196004
966
967         Reviewed by Lucas Forschler.
968
969         * BuildSlaveSupport/ews-build/steps.py:
970         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
971         (CompileWebKitToT.doStepIf): Ditto.
972         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
973         (ReRunAPITests): Re-run API tests.
974         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
975         (RunAPITestsWithoutPatch): Run API tests without patch.
976         (RunAPITestsWithoutPatch.doStepIf):
977         (RunAPITestsWithoutPatch.hideStepIf):
978         (RunAPITestsWithoutPatch.evaluateCommand):
979         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
980         (AnalyzeAPITestsResults.start):
981         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
982         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
983         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
984         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
985
986 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
987
988         [ews-build] Update queues configurations
989         https://bugs.webkit.org/show_bug.cgi?id=196074
990
991         Reviewed by Dewei Zhu.
992
993         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
994         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
995
996 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
997
998         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
999         https://bugs.webkit.org/show_bug.cgi?id=195680
1000         <rdar://problem/48903534>
1001
1002         Unreviewed infrastructure fix.
1003
1004         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1005         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1006
1007 2019-03-21  Andy Estes  <aestes@apple.com>
1008
1009         [iOS] Apple Pay should be available in documents with no user agent scripts
1010         https://bugs.webkit.org/show_bug.cgi?id=196061
1011         <rdar://problem/48649391>
1012
1013         Reviewed by Brady Eidson.
1014
1015         Added API tests and related infrastructure.
1016
1017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1018         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1019         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1020         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1021         (TestWebKitAPI::TEST):
1022         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1023         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1024         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1025         * TestWebKitAPI/cocoa/TestProtocol.mm:
1026         (-[TestProtocol startLoading]):
1027         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1028         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1029         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1030         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1031
1032 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1033
1034         REGRESSSION (r243297): webkitpy tests broken
1035         https://bugs.webkit.org/show_bug.cgi?id=196108
1036
1037         Reviewed by Aakash Jain.
1038
1039         r243297 updated contributors.json, which broke a few unit tests.
1040
1041         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1042         (IRCCommandTest.test_whois):
1043         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1044
1045 2019-03-21  Chris Dumez  <cdumez@apple.com>
1046
1047         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1048         https://bugs.webkit.org/show_bug.cgi?id=196041
1049         <rdar://problem/49083230>
1050
1051         Reviewed by Alex Christensen.
1052
1053         Add API test coverage.
1054
1055         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1056         (TEST):
1057
1058 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1059
1060         Add SPI to inform applications of WKContentRuleList actions
1061         https://bugs.webkit.org/show_bug.cgi?id=195965
1062         <rdar://problem/42664365>
1063
1064         Reviewed by Geoff Garen.
1065
1066         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1067         (TestWebKitAPI::allActionsForResourceLoad):
1068         (TestWebKitAPI::testRequest):
1069         (TestWebKitAPI::TEST_F):
1070         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1071         (Notification::description):
1072         (Notification::operator== const):
1073         (toVector):
1074         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1075         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1076         (makeContentRuleList):
1077         (TEST):
1078         (makeWarnContentRuleList): Deleted.
1079
1080 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1081
1082         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1083         https://bugs.webkit.org/show_bug.cgi?id=196088
1084
1085         Reviewed by Brian Burg.
1086
1087         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1088         Support checks when only one platform is specified. Also deprecate macosx() and
1089         force the use of macos() instead.
1090
1091         * Scripts/webkitpy/style/checkers/cpp.py:
1092         (check_min_versions_of_wk_api_available):
1093         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1094         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1095
1096 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1097
1098         Update status inactive committers' status to 'contributor'.
1099
1100         * Scripts/webkitpy/common/config/contributors.json:
1101
1102 2019-03-21  Xan Lopez  <xan@igalia.com>
1103
1104         [JSC][x86] Drop support for x87 floating point
1105         https://bugs.webkit.org/show_bug.cgi?id=194853
1106
1107         Reviewed by Don Olmstead.
1108
1109         Force SSE2 on x86/32bit builds.
1110
1111         * Scripts/webkitdirs.pm:
1112         (generateBuildSystemFromCMakeProject):
1113
1114 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1115
1116         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1117         https://bugs.webkit.org/show_bug.cgi?id=196073
1118
1119         Reviewed by Michael Catanzaro.
1120
1121         Add test cases to check functions and constructors with no arguments but receiving user data.
1122
1123         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1124         (checkUserData):
1125         (testJSCFunction):
1126         (fooCreateWithUserData):
1127         (testJSCClass):
1128
1129 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1130
1131         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1132
1133         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1134
1135         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1136
1137 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1138
1139         [GTK][WPE] Add API to provide geolocation information
1140         https://bugs.webkit.org/show_bug.cgi?id=195940
1141
1142         Reviewed by Michael Catanzaro.
1143
1144         Add a new test to check the new API.
1145
1146         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1147         (testGeolocationManagerCurrentPosition):
1148         (testGeolocationManagerWatchPosition):
1149         (beforeAll):
1150         (afterAll):
1151         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1152         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1153         (beforeAll): Ditto.
1154         * TestWebKitAPI/glib/CMakeLists.txt:
1155
1156 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1157
1158         [GLib] Returning G_TYPE_OBJECT from a method does not work
1159         https://bugs.webkit.org/show_bug.cgi?id=195574
1160
1161         Reviewed by Michael Catanzaro.
1162
1163         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1164
1165         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1166         (getGFile):
1167         (getParent):
1168         (createGString):
1169         (getGString):
1170         (getGStringCopyWillRaise):
1171         (getGStringCopy):
1172         (getGStringStr):
1173         (getGStringLen):
1174         (freeGString):
1175         (testJSCClass):
1176
1177 2019-03-20  Saam Barati  <sbarati@apple.com>
1178
1179         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1180         https://bugs.webkit.org/show_bug.cgi?id=195721
1181
1182         Reviewed by Filip Pizlo.
1183
1184         * Scripts/run-javascriptcore-tests:
1185
1186 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1187
1188         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1189         https://bugs.webkit.org/show_bug.cgi?id=196049
1190
1191         Reviewed by Tim Horton.
1192
1193         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1194         overflow scrolling in general, so rename it.
1195
1196         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1197
1198 2019-03-20  Daniel Bates  <dabates@apple.com>
1199
1200         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1201         https://bugs.webkit.org/show_bug.cgi?id=196031
1202         <rdar://problem/49078172>
1203
1204         Reviewed by Tim Horton.
1205
1206         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1207         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1208         same code path used when the Done button is pressed to dismiss the <select> picker.
1209
1210         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1211         (TestWebKitAPI::TEST):
1212
1213 2019-03-20  Chris Dumez  <cdumez@apple.com>
1214
1215         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1216         https://bugs.webkit.org/show_bug.cgi?id=196029
1217         <rdar://problem/48954651>
1218
1219         Reviewed by Tim Horton.
1220
1221         Add API test coverage.
1222
1223         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1224
1225 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1226
1227         [ews-build] Improve failure summary string for ApplyPatch step
1228         https://bugs.webkit.org/show_bug.cgi?id=195995
1229
1230         Reviewed by Alexey Proskuryakov.
1231
1232         * BuildSlaveSupport/ews-build/steps.py:
1233         (ApplyPatch.getResultSummary): Override getResultSummary.
1234
1235 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1236
1237         AX: Implement support for new meter ARIA role
1238         https://bugs.webkit.org/show_bug.cgi?id=195966
1239
1240         Reviewed by Chris Fleizach.
1241
1242         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1243         to AXLevelIndicator.
1244
1245         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1246
1247 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1248
1249         [WebAuthN] Implement FIDO AppID extension
1250         https://bugs.webkit.org/show_bug.cgi?id=143491
1251         <rdar://problem/48298273>
1252
1253         Reviewed by Brent Fulgham.
1254
1255         Add a test that covers the new flag of convertToU2fSignCommand.
1256
1257         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1258         (TestWebKitAPI::TEST):
1259         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1260         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1261         (TestWebKitAPI::TEST):
1262
1263 2019-03-19  Keith Rollin  <krollin@apple.com>
1264
1265         Add support for more platforms to generate-xcfilelists
1266         https://bugs.webkit.org/show_bug.cgi?id=195977
1267
1268         Reviewed by Alexey Proskuryakov.
1269
1270         generate-xcfilelists incorrectly complains when involved with building
1271         WebKit for iphonesimulator:
1272
1273             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1274             …
1275             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1276
1277         Address this by teaching generate-xcfilelists about more platforms.
1278
1279         * Scripts/generate-xcfilelists:
1280
1281 2019-03-19  John Wilander  <wilander@apple.com>
1282
1283         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1284         https://bugs.webkit.org/show_bug.cgi?id=195923
1285         <rdar://problem/49001272>
1286
1287         Reviewed by Alex Christensen.
1288
1289         This patch does the following to the TestRunner:
1290         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1291         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1292         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1293
1294         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1295         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1296         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1297         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1298         * WebKitTestRunner/TestController.cpp:
1299         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1300         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1301         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1302         * WebKitTestRunner/TestController.h:
1303         * WebKitTestRunner/TestInvocation.cpp:
1304         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1305
1306 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1307
1308         [CMake] Support more clang and gcc sanitizers
1309         https://bugs.webkit.org/show_bug.cgi?id=195956
1310
1311         Reviewed by Michael Catanzaro.
1312
1313         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1314
1315 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1316
1317         [ews-build] Improve summary for PrintConfiguration step
1318         https://bugs.webkit.org/show_bug.cgi?id=195945
1319
1320         Reviewed by Lucas Forschler.
1321
1322         * BuildSlaveSupport/ews-build/steps.py:
1323         (PrintConfiguration.getResultSummary): Override getResultSummary.
1324
1325 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1326
1327         [ews-build] Improve summary for CheckOutSource step
1328         https://bugs.webkit.org/show_bug.cgi?id=195963
1329
1330         Reviewed by Lucas Forschler.
1331
1332         * BuildSlaveSupport/ews-build/steps.py:
1333         (CheckOutSource.getResultSummary):
1334
1335 2019-03-19  Daniel Bates  <dabates@apple.com>
1336
1337         [iOS] Focus not preserved when switching between tabs
1338         https://bugs.webkit.org/show_bug.cgi?id=195820
1339         <rdar://problem/43614450>
1340
1341         Reviewed by Brent Fulgham.
1342
1343         Add tests to ensure that we restore focus when resigning and becoming first responder.
1344
1345         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1346         (TestWebKitAPI::TEST):
1347
1348 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1349
1350         Make WTFLogChannelState and WTFLogLevel enum classes
1351         https://bugs.webkit.org/show_bug.cgi?id=195904
1352
1353         Reviewed by Eric Carlson.
1354
1355         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1356         (TestWebKitAPI::TEST_F):
1357
1358 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1359
1360         [GStreamer][EME] Backported mssdemux protection data crash fix
1361         https://bugs.webkit.org/show_bug.cgi?id=195918
1362
1363         Reviewed by Philippe Normand.
1364
1365         * gstreamer/jhbuild.modules:
1366         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1367
1368 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1369
1370         Unreviewed, rolling out r243132.
1371
1372         Broke GTK build
1373
1374         Reverted changeset:
1375
1376         "Make WTFLogChannelState and WTFLogLevel enum classes"
1377         https://bugs.webkit.org/show_bug.cgi?id=195904
1378         https://trac.webkit.org/changeset/243132
1379
1380 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1381
1382         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1383
1384         * Scripts/webkitdirs.pm:
1385         (builtDylibPathForName): Adjust the shared library name that's changed
1386         with the API version bump in r243073.
1387
1388 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1389
1390         Make WTFLogChannelState and WTFLogLevel enum classes
1391         https://bugs.webkit.org/show_bug.cgi?id=195904
1392
1393         Reviewed by Eric Carlson.
1394
1395         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1396         (TestWebKitAPI::TEST_F):
1397
1398 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1399
1400         Disable flaky test added in r2431100
1401         https://webkit.org/b/195785
1402
1403         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1404         (TestWebKitAPI::TEST):
1405         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1406
1407 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1408
1409         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1410         https://bugs.webkit.org/show_bug.cgi?id=195916
1411
1412         Reviewed by Tim Horton.
1413
1414         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1415         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1416
1417 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1418
1419         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1420
1421         * Scripts/webkitpy/common/config/contributors.json:
1422
1423 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1424
1425         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1426         https://bugs.webkit.org/show_bug.cgi?id=195785
1427
1428         Reviewed by Geoffrey Garen.
1429
1430         * TestWebKitAPI/TCPServer.cpp: Added.
1431         (TestWebKitAPI::TCPServer::TCPServer):
1432         (TestWebKitAPI::TCPServer::~TCPServer):
1433         (TestWebKitAPI::TCPServer::socketBindListen):
1434         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1435         * TestWebKitAPI/TCPServer.h: Added.
1436         (TestWebKitAPI::TCPServer::port const):
1437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1438         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1439         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1440         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1441         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1442         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1443         (TestWebKitAPI::respondSlowly):
1444         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1445         (TestWebKitAPI::downloadAtRate):
1446         (TestWebKitAPI::TEST):
1447
1448 2019-03-18  Saam Barati  <sbarati@apple.com>
1449
1450         Add a plan file for JetStream 2
1451         https://bugs.webkit.org/show_bug.cgi?id=190734
1452
1453         Reviewed by Mark Lam.
1454
1455         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1456
1457 2019-03-18  Chris Dumez  <cdumez@apple.com>
1458
1459         Delay WebProcess launch until a load is triggered in a Web view
1460         https://bugs.webkit.org/show_bug.cgi?id=195758
1461         <rdar://problem/48126013>
1462
1463         Reviewed by Geoff Garen.
1464
1465         Add API test coverage. Also update some existing API tests to not expect
1466         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1467
1468         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1469         (TestWebKitAPI::TEST):
1470         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1471         (TestWebKitAPI::TEST):
1472         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1473         (TEST):
1474         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1475         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1476         (TEST):
1477         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1478         (TEST):
1479         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1480
1481 2019-03-18  Xan Lopez  <xan@igalia.com>
1482
1483         [CMake] Prevent potential warning when determining $architecture
1484         https://bugs.webkit.org/show_bug.cgi?id=195891
1485
1486         Reviewed by Michael Catanzaro.
1487
1488         It's possible for generateBuildSystemForCMakeProject to be called
1489         before determineArchitecture() is ever called. This will make the
1490         first eq check with $architecture to be bogus (and print a
1491         warning). Change that to an eq check with architecture(), which
1492         implicitly calls determineArchitecture() if needed, and change all
1493         the other similar cases in the method in the same way to prevent
1494         future bugs like this one.
1495
1496         * Scripts/webkitdirs.pm:
1497         (generateBuildSystemFromCMakeProject):
1498
1499 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1500
1501         [WPE] Tarballs generated with “make dist” cannot build documentation
1502         https://bugs.webkit.org/show_bug.cgi?id=195885
1503
1504         Reviewed by Carlos Garcia Campos.
1505
1506         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1507
1508 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1509
1510         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1511         https://bugs.webkit.org/show_bug.cgi?id=195883
1512
1513         Reviewed by Carlos Garcia Campos.
1514
1515         * gtkdoc/gtkdoc.py:
1516         (GTKDoc._run_command): When commands fail to run, include the full command line for
1517         the program invocation and the output it has generated on the standard error stream.
1518
1519 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1520
1521         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1522         https://bugs.webkit.org/show_bug.cgi?id=195786
1523
1524         Reviewed by Philippe Normand.
1525
1526         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1527         * wpe/jhbuild.modules: Ditto.
1528
1529 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1530
1531         [ews-build] Don't run clean builds on EWS builders
1532         https://bugs.webkit.org/show_bug.cgi?id=195851
1533
1534         Reviewed by Geoffrey Garen.
1535
1536         * BuildSlaveSupport/ews-build/factories.py:
1537
1538 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1539
1540         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1541         https://bugs.webkit.org/show_bug.cgi?id=195849
1542
1543         Reviewed by Chris Dumez.
1544
1545         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1546
1547         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1548         (runWebsiteDataStoreCustomPaths):
1549
1550 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1551
1552         webkitpy: Upload test results
1553         https://bugs.webkit.org/show_bug.cgi?id=195755
1554         <rdar://problem/48896182>
1555
1556         Reviewed by Aakash Jain.
1557
1558         Establish a new format for uploading results that is not tied to layout tests, apply
1559         that format to webkitpy tests.
1560
1561         * Scripts/webkitpy/common/checkout/scm/git.py:
1562         (Git.native_branch): Return what branch the current checkout is on.
1563         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1564         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1565         * Scripts/webkitpy/common/checkout/scm/svn.py:
1566         (SVN.native_branch): Ditto.
1567         * Scripts/webkitpy/common/system/platforminfo.py:
1568         (PlatformInfo.build_version): Return a build version for Mac.
1569         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1570         (MockPlatformInfo.__init__):
1571         (MockPlatformInfo.build_version):
1572         * Scripts/webkitpy/results: Added.
1573         * Scripts/webkitpy/results/__init__.py: Added.
1574         * Scripts/webkitpy/results/options.py: Added.
1575         (upload_options): OptParse list for upload options.
1576         * Scripts/webkitpy/results/upload.py: Added.
1577         (Upload): Class which enforces the upload format expected by the results server.
1578         (Upload.Expectations):
1579         (Upload.create_configuration):
1580         (Upload.create_commit):
1581         (Upload.create_details):
1582         (Upload.create_run_stats):
1583         (Upload.create_test_result):
1584         (Upload.__init__):
1585         (Upload.Encoder): Encode Upload object as json.
1586         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1587         * Scripts/webkitpy/results/upload_unittest.py: Added.
1588         * Scripts/webkitpy/test/main.py:
1589         (Tester._parse_args): Add upload arguments.
1590         (Tester._run_tests): Allow results to be uploaded.
1591         * Scripts/webkitpy/test/runner.py:
1592         (Runner.__init__): Record which tests were run, rather than just counting them.
1593         (Runner.handle):
1594         * Scripts/webkitpy/test/runner_unittest.py:
1595         (RunnerTest.test_run):
1596         * Scripts/webkitpy/thirdparty/__init__.py:
1597         (AutoinstallImportHook.find_module): Add requests auto-install.
1598         (AutoinstallImportHook._install_requests):
1599         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1600         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1601
1602 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1603
1604         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1605         https://bugs.webkit.org/show_bug.cgi?id=195810
1606
1607         Reviewed by Tim Horton.
1608
1609         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1610         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1611         ending certain layout tests.
1612
1613         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1614         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1615         (-[TestRunnerWKWebView dealloc]):
1616         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1617
1618         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1619         helper method when destroying the web view, and when resetting state between tests.
1620
1621         * WebKitTestRunner/ios/TestControllerIOS.mm:
1622         (WTR::TestController::platformResetStateToConsistentValues):
1623
1624         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1625
1626 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1627
1628         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1629         https://bugs.webkit.org/show_bug.cgi?id=190350
1630         <rdar://problem/45089503>
1631
1632         Reviewed by Geoffrey Garen.
1633
1634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1635         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1636         (TEST):
1637         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1638         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1639         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1640         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1641         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1642         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1643         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1644         (runTest):
1645         (createDirectories):
1646         (TEST):
1647         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1648         (TEST):
1649         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1650         (TEST):
1651
1652 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1653
1654         Add support to WebPage for getting the contents as an attributed string.
1655         https://bugs.webkit.org/show_bug.cgi?id=195636
1656         rdar://problem/45055697
1657
1658         Reviewed by Tim Horton.
1659
1660         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1661         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1662
1663 2019-03-15  Chris Dumez  <cdumez@apple.com>
1664
1665         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1666         https://bugs.webkit.org/show_bug.cgi?id=195747
1667
1668         Reviewed by Geoff Garen.
1669
1670         Add API test coverage.
1671
1672         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1673
1674 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1675
1676         Unreviewed, rolling out r242952.
1677
1678         Causing API failures on iOS Simulator
1679
1680         Reverted changeset:
1681
1682         "[PSON] Make sure the WebProcessCache is leverage when
1683         relaunching a process after termination"
1684         https://bugs.webkit.org/show_bug.cgi?id=195747
1685         https://trac.webkit.org/changeset/242952
1686
1687 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1688
1689         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1690         https://bugs.webkit.org/show_bug.cgi?id=195740
1691
1692         Reviewed by Ross Kirsling.
1693
1694         window.open doesn't work for WebKitBrowserWindow because it is not
1695         implemented yet.
1696
1697         1. Implemented createNewPage callback of WKPageUIClient.
1698         2. Changed MainWindow to take a BrowserWindow factory function
1699           instead of BrowserWindowType to be flexible to create
1700           BrowserWindow with extra settings.
1701         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1702           because it is not relevant with MainWindow anymore.
1703
1704         * MiniBrowser/win/Common.cpp:
1705         (parseCommandLine):
1706         * MiniBrowser/win/Common.h:
1707         (CommandLineOptions::CommandLineOptions):
1708         * MiniBrowser/win/MainWindow.cpp:
1709         (MainWindow::MainWindow):
1710         (MainWindow::create):
1711         (MainWindow::init):
1712         (MainWindow::WndProc):
1713         * MiniBrowser/win/MainWindow.h:
1714         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1715         (PrintWebUIDelegate::createWebViewWithRequest):
1716         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1717         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1718         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1719         (WebKitBrowserWindow::updateProxySettings):
1720         (WebKitBrowserWindow::createNewPage):
1721         * MiniBrowser/win/WebKitBrowserWindow.h:
1722         * MiniBrowser/win/WinMain.cpp:
1723         (wWinMain):
1724
1725 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1726
1727         Make it possible to test scrolling tree layer manipulation more easily
1728         https://bugs.webkit.org/show_bug.cgi?id=195780
1729
1730         Reviewed by Tim Horton.
1731         
1732         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1733         cuts off communication of scrolling tree scrolls back to the web process
1734         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1735         allows tests to trigger scrolls which run the scrolling tree layer positioning
1736         logic, but never get another commit from the web process that might mask
1737         scrolling tree bugs.
1738         
1739         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1740         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1741         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1742
1743         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1744         (WTR::UIScriptController::scrollUpdatesDisabled const):
1745         (WTR::UIScriptController::setScrollUpdatesDisabled):
1746         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1747         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1748         (WTR::UIScriptController::scrollUpdatesDisabled const):
1749         (WTR::UIScriptController::setScrollUpdatesDisabled):
1750         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1751         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1752         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1753         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1754         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1755         * WebKitTestRunner/ios/TestControllerIOS.mm:
1756         (WTR::TestController::platformResetStateToConsistentValues):
1757         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1758         (WTR::UIScriptController::scrollUpdatesDisabled const):
1759         (WTR::UIScriptController::setScrollUpdatesDisabled):
1760
1761 2019-03-14  Youenn Fablet  <youenn@apple.com>
1762
1763         Move IDB storage in private browsing mode to NetworkProcess
1764         https://bugs.webkit.org/show_bug.cgi?id=195602
1765
1766         Reviewed by Brady Eidson.
1767
1768         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1769         (TEST):
1770
1771 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1772
1773         [ews-build] Make descriptionDone messages more readable
1774         https://bugs.webkit.org/show_bug.cgi?id=195760
1775
1776         Reviewed by Lucas Forschler.
1777
1778         * BuildSlaveSupport/ews-build/steps.py:
1779         * BuildSlaveSupport/ews-build/steps_unittest.py:
1780
1781 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1782
1783         [ews-build] Generate status-bubble hover-over messages
1784         https://bugs.webkit.org/show_bug.cgi?id=195680
1785
1786         Reviewed by Lucas Forschler.
1787
1788         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1789         (StatusBubble):
1790         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1791         on hover-over.
1792         (StatusBubble._iso_time):
1793         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1794         hover-over message.
1795         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1796
1797 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1798
1799         [ews-app] Gracefully handle the case when state_string is None
1800         https://bugs.webkit.org/show_bug.cgi?id=195753
1801
1802         Reviewed by Lucas Forschler.
1803
1804         * BuildSlaveSupport/ews-app/ews/models/build.py:
1805         * BuildSlaveSupport/ews-app/ews/models/step.py:
1806
1807 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1808
1809         [ews-app] Status bubble display pending for currently running build step
1810         https://bugs.webkit.org/show_bug.cgi?id=195744
1811
1812         Reviewed by Lucas Forschler.
1813
1814         * BuildSlaveSupport/ews-build/events.py:
1815         (Events.stepStarted): If state_string is pending, replace it with step name.
1816
1817 2019-03-14  Chris Dumez  <cdumez@apple.com>
1818
1819         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1820         https://bugs.webkit.org/show_bug.cgi?id=195750
1821
1822         Reviewed by Geoffrey Garen.
1823
1824         Add API test coverage.
1825
1826         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1827         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1828         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1829         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1830
1831 2019-03-14  Chris Dumez  <cdumez@apple.com>
1832
1833         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1834         https://bugs.webkit.org/show_bug.cgi?id=195747
1835
1836         Reviewed by Geoff Garen.
1837
1838         Add API test coverage.
1839
1840         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1841
1842 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1843
1844         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1845         https://bugs.webkit.org/show_bug.cgi?id=195725
1846         <rdar://problem/48545062>
1847
1848         Reviewed by Tim Horton.
1849
1850         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1851         handler is nil.
1852
1853         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1854         (TestWebKitAPI::TEST):
1855
1856 2019-03-13  Sam Weinig  <sam@webkit.org>
1857
1858         Add utility function to allow easy reverse range-based iteration of a container
1859         https://bugs.webkit.org/show_bug.cgi?id=195542
1860
1861         Reviewed by Antti Koivisto.
1862
1863         * TestWebKitAPI/CMakeLists.txt:
1864         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1865         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1866         (TestWebKitAPI::TEST):
1867         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1868
1869 2019-03-13  Chris Dumez  <cdumez@apple.com>
1870
1871         Use a ServiceWorker process per registrable domain
1872         https://bugs.webkit.org/show_bug.cgi?id=195649
1873
1874         Reviewed by Youenn Fablet.
1875
1876         Update API test coverage.
1877
1878         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1879
1880 2019-03-13  Chris Dumez  <cdumez@apple.com>
1881
1882         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1883         https://bugs.webkit.org/show_bug.cgi?id=195684
1884         <rdar://problem/48294714>
1885
1886         Reviewed by Antti Koivisto.
1887
1888         Add API test coverage.
1889
1890         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1891
1892 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1893
1894         [ews-app] Remove unused patch view
1895         https://bugs.webkit.org/show_bug.cgi?id=195669
1896
1897         Reviewed by Lucas Forschler.
1898
1899         * BuildSlaveSupport/ews-app/ews/urls.py:
1900         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1901
1902 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1903
1904         [ews-app] Use Buildbot result code variables
1905         https://bugs.webkit.org/show_bug.cgi?id=195668
1906
1907         Reviewed by Alexey Proskuryakov.
1908
1909         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1910         (Buildbot): Added Buildbot result code variables.
1911         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1912         (StatusBubble._build_bubble): Used Buildbot result code variables.
1913
1914 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
1915
1916         [Flatpak] Expand submodule recursively
1917         https://bugs.webkit.org/show_bug.cgi?id=195672
1918
1919         Building WPE with flatpak was impossible without that as it was raising an exception.
1920         Also update wpebackend-fdo to match what is built in jhbuild
1921
1922         Reviewed by Philippe Normand.
1923
1924         * flatpak/flatpakutils.py:
1925         (expand_submodules_recurse):
1926         (expand_manifest):
1927         * flatpak/org.webkit.WPEModules.yaml:
1928
1929 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1930
1931         [ews-app] status bubble should be hidden for certain builds
1932         https://bugs.webkit.org/show_bug.cgi?id=194597
1933
1934         Reviewed by Dewei Zhu.
1935
1936         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1937         (StatusBubble._build_bubble):
1938         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
1939         because the patch didn't have relevant changes.
1940         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
1941         in production yet.
1942
1943 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
1944
1945         [Win] Fix a slew of simple clang-cl warnings.
1946         https://bugs.webkit.org/show_bug.cgi?id=195652
1947
1948         Reviewed by Don Olmstead.
1949
1950         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1951         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
1952
1953 2019-03-12  Justin Fan  <justin_fan@apple.com>
1954
1955         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
1956         https://bugs.webkit.org/show_bug.cgi?id=195518
1957         <rdar://problem/46322356>
1958
1959         Reviewed by Myles C. Maxfield.
1960
1961         * DumpRenderTree/DerivedSources-input.xcfilelist:
1962         * DumpRenderTree/DerivedSources-output.xcfilelist:
1963
1964 2019-03-12  Commit Queue  <commit-queue@webkit.org>
1965
1966         Unreviewed, rolling out r242825.
1967         https://bugs.webkit.org/show_bug.cgi?id=195648
1968
1969         "Broke webkitpy tests with my change to
1970         lldb_dump_class_layout.py" (Requested by rmorisset on
1971         #webkit).
1972
1973         Reverted changeset:
1974
1975         "Alter Tools/Scripts/dump-class-layout to be able to dump all
1976         classes with suspicious padding"
1977         https://bugs.webkit.org/show_bug.cgi?id=195573
1978         https://trac.webkit.org/changeset/242825
1979
1980 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1981
1982         [ews-build] Show status bubbles while the patch is waiting in queue
1983         https://bugs.webkit.org/show_bug.cgi?id=195618
1984
1985         Reviewed by Lucas Forschler.
1986
1987         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1988         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
1989         enabled in initial deployment.
1990         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
1991         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
1992         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
1993         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
1994         (StatusBubble._build_bubbles_for_patch):
1995
1996 2019-03-12  Robin Morisset  <rmorisset@apple.com>
1997
1998         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
1999         https://bugs.webkit.org/show_bug.cgi?id=195573
2000
2001         Reviewed by Simon Fraser.
2002
2003         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2004
2005         * Scripts/dump-class-layout:
2006         (main):
2007         * lldb/lldb_dump_class_layout.py:
2008         (ClassLayout.__init__):
2009         (ClassLayout._compute_padding_recursive):
2010         (LLDBDebuggerInstance.dump_layout_for_classname):
2011         (LLDBDebuggerInstance):
2012         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2013         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2014
2015 2019-03-12  Chris Dumez  <cdumez@apple.com>
2016
2017         Device Orientation access permission should be denied unless explicitly granted by the client
2018         https://bugs.webkit.org/show_bug.cgi?id=195625
2019
2020         Reviewed by Youenn Fablet.
2021
2022         add API test coverage.
2023
2024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2025         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2026         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2027         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2028         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2029         (runDeviceOrientationTest):
2030         (TEST):
2031         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2032         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2033
2034 2019-03-12  Jer Noble  <jer.noble@apple.com>
2035
2036         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2037         https://bugs.webkit.org/show_bug.cgi?id=195137
2038         <rdar://problem/48810307>
2039
2040         Reviewed by Eric Carlson.
2041
2042         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2043         (TestWebKitAPI::TEST):
2044
2045 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2046
2047         [ews-build] Change urls from uat to production
2048         https://bugs.webkit.org/show_bug.cgi?id=195566
2049
2050         Reviewed by Lucas Forschler.
2051
2052         * BuildSlaveSupport/ews-app/ews/config.py:
2053         * BuildSlaveSupport/ews-build/events.py:
2054         * BuildSlaveSupport/ews-build/steps.py:
2055
2056 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2057
2058         [ews-build] change max_builds for local-worker to 1
2059         https://bugs.webkit.org/show_bug.cgi?id=195568
2060
2061         Reviewed by Lucas Forschler.
2062
2063         * BuildSlaveSupport/ews-build/loadConfig.py:
2064
2065 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2066
2067         Fix the build
2068
2069         * TestRunnerShared/spi/PencilKitTestSPI.h:
2070         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2071
2072 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2073
2074         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2075         https://bugs.webkit.org/show_bug.cgi?id=194131
2076
2077         Reviewed by Michael Catanzaro.
2078
2079         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2080         (uriChanged):
2081         (testUnfinishedSubresourceLoad):
2082         (serverCallback):
2083         (beforeAll):
2084
2085 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2086
2087         WTF::Expected should use std::addressof instead of operator&
2088         https://bugs.webkit.org/show_bug.cgi?id=195604
2089
2090         Reviewed by Myles Maxfield.
2091
2092         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2093         (TestWebKitAPI::Unique::Unique):
2094         (TestWebKitAPI::Unique::operator&):
2095         (TestWebKitAPI::TEST):
2096
2097 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2098
2099         Add Optional to Forward.h.
2100         https://bugs.webkit.org/show_bug.cgi?id=195586
2101
2102         Reviewed by Darin Adler.
2103
2104         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2105         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2106         Remove unnecessary includes from headers.
2107
2108 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2109
2110         Add testing API to hit-test and scroll overflow scrollers
2111         https://bugs.webkit.org/show_bug.cgi?id=195278
2112
2113         Reviewed by Antti Koivisto.
2114         
2115         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2116         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2117         
2118         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2119
2120         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2121         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2122         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2123         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2124         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2125         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2126         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2127         (WTR::enclosingScrollViewIncludingSelf):
2128         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2129
2130 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2131
2132         API test WebKit.RequestTextInputContext fails on iOS
2133         https://bugs.webkit.org/show_bug.cgi?id=195585
2134
2135         Reviewed by Wenson Hsieh and Simon Fraser.
2136
2137         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2138         (applyStyle):
2139         (TEST):
2140         Add a viewport, so that the coordinates match up on iOS.
2141         Scroll by moving the UIScrollView's contentOffset.
2142
2143 2019-03-11  Chris Dumez  <cdumez@apple.com>
2144
2145         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2146         https://bugs.webkit.org/show_bug.cgi?id=195506
2147         <rdar://problem/48733477>
2148
2149         Reviewed by Alex Christensen.
2150
2151         Add API test coverage.
2152
2153         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2154
2155 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2156
2157         Adding myself to contributors.json
2158
2159         Unreviewed, addming myself to contributors.json .
2160
2161         * Scripts/webkitpy/common/config/contributors.json:
2162
2163 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2164
2165         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2166         https://bugs.webkit.org/show_bug.cgi?id=195511
2167         <rdar://problem/44873269>
2168
2169         Reviewed by Darin Adler.
2170
2171         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2172         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2173         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2174         (TEST_F):
2175
2176 2019-03-11  Chris Dumez  <cdumez@apple.com>
2177
2178         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2179         https://bugs.webkit.org/show_bug.cgi?id=195561
2180
2181         Reviewed by Youenn Fablet.
2182
2183         Make sure the JS in the test requests for permission to receive device orientation events.
2184
2185         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2186
2187 2019-03-11  Youenn Fablet  <youenn@apple.com>
2188
2189         Allow storage quota increase by default in WTR
2190         https://bugs.webkit.org/show_bug.cgi?id=195541
2191
2192         Reviewed by Geoffrey Garen.
2193
2194         Allow storage quota increase by default in WTR.
2195         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2196         Use this for tests that explicitly need cache increase.
2197
2198         Instead of increasing quota by 2, make sure the next request is
2199         granted by adding all given parameters.
2200
2201         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2202         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2203         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2204         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2205         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2206         * WebKitTestRunner/TestController.cpp:
2207         (WTR::TestController::setAllowStorageQuotaIncrease):
2208         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2209         * WebKitTestRunner/TestController.h:
2210         * WebKitTestRunner/TestInvocation.cpp:
2211         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2212         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2213         (WTR::TestController::cocoaResetStateToConsistentValues):
2214         (WTR::TestController::setAllowStorageQuotaIncrease):
2215         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2216         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2217         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2218
2219 2019-03-11  Xan Lopez  <xan@igalia.com>
2220
2221         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2222         https://bugs.webkit.org/show_bug.cgi?id=194147
2223
2224         Reviewed by Michael Saboff.
2225
2226         To make --32-bit work correctly on Linux/64bit we need to:
2227
2228         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2229         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2230         unfortunately CMake only allows us to do this during
2231         crosscompilation, which is overkill here.
2232         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2233         pkg-config detection module uses the x86 .pc files instead of the
2234         x86_64 ones.
2235         - Set the -m32 flags for the compiler.
2236
2237         * Scripts/webkitdirs.pm:
2238         (generateBuildSystemFromCMakeProject):
2239
2240 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2241
2242         Add MotionMark-1.1 plan file for run-benchmark script.
2243         https://bugs.webkit.org/show_bug.cgi?id=195481
2244
2245         Rubber-stamped by Darin Adler.
2246
2247         Run-benchmark script should support MontionMark-1.1.
2248
2249         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2250
2251 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2252
2253         [ews-app] Add support for submit-to-ews url
2254         https://bugs.webkit.org/show_bug.cgi?id=195477
2255
2256         Reviewed by Lucas Forschler.
2257
2258         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2259         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2260         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2261         * BuildSlaveSupport/ews-app/ews/urls.py:
2262         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2263
2264 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2265
2266         Unreviewed, rolling out r242688, r242643, r242624.
2267
2268         Caused multiple layout test failures and crashes on iOS and macOS.
2269
2270         Reverted changeset:
2271
2272         "requestAnimationFrame should execute before the next frame"
2273         https://bugs.webkit.org/show_bug.cgi?id=177484
2274         https://trac.webkit.org/changeset/242624/webkit
2275
2276         * Tracing/SystemTracePoints.plist:
2277
2278 2019-03-11  John Wilander  <wilander@apple.com>
2279
2280         Resource Load Statistics: Make it possible exclude localhost from classification
2281         https://bugs.webkit.org/show_bug.cgi?id=195474
2282         <rdar://problem/47520577>
2283
2284         Reviewed by Brent Fulgham.
2285
2286         This patch allows for localhost to be excluded from classification and
2287         treatment as a prevalent resource.
2288
2289         The WebKit Tools change adds a new function called
2290         testRunner.setStatisticsIsRunningTest() which can be used to control this
2291         behavior.
2292
2293         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2294         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2295         (WTR::TestRunner::setStatisticsIsRunningTest):
2296         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2297         * WebKitTestRunner/TestController.cpp:
2298         (WTR::TestController::setStatisticsIsRunningTest):
2299         * WebKitTestRunner/TestController.h:
2300         * WebKitTestRunner/TestInvocation.cpp:
2301         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2302
2303 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2304
2305         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2306         https://bugs.webkit.org/show_bug.cgi?id=195560
2307
2308         Reviewed by Lucas Forschler.
2309
2310         * BuildSlaveSupport/ews-build/master.cfg:
2311
2312 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2313
2314         Unreviewed, rolling out r242698.
2315
2316         API test crashes on bots.
2317
2318         Reverted changeset:
2319
2320         "Add a WKContentRuleList variant that uses copied memory
2321         instead of mmap'd shared memory for class A containerized
2322         apps"
2323         https://bugs.webkit.org/show_bug.cgi?id=195511
2324         https://trac.webkit.org/changeset/242698
2325
2326 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2327
2328         [WPE] Enable web process sandbox
2329         https://bugs.webkit.org/show_bug.cgi?id=195169
2330
2331         Reviewed by Daniel Bates.
2332
2333         * wpe/install-dependencies:
2334         * wpe/jhbuild.modules:
2335
2336 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2337
2338         [ews-app] Use port 17000 for worker communication
2339         https://bugs.webkit.org/show_bug.cgi?id=195558
2340
2341         Reviewed by Lucas Forschler.
2342
2343         * BuildSlaveSupport/ews-build/master.cfg:
2344
2345 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2346
2347         [ews-build] unit-tests fail when passwords.json is missing
2348         https://bugs.webkit.org/show_bug.cgi?id=195557
2349
2350         Reviewed by Lucas Forschler.
2351
2352         * BuildSlaveSupport/ews-build/loadConfig.py:
2353         (loadBuilderConfig):
2354         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2355         (ConfigDotJSONTest.test_configuration):
2356         * BuildSlaveSupport/ews-build/master.cfg:
2357
2358 2019-03-11  Truitt Savell  <tsavell@apple.com>
2359
2360         Unreviewed, rolling out r242702.
2361
2362         Broke High Sierra builders.
2363
2364         Reverted changeset:
2365
2366         "Add utility function to allow easy reverse range-based
2367         iteration of a container"
2368         https://bugs.webkit.org/show_bug.cgi?id=195542
2369         https://trac.webkit.org/changeset/242702
2370
2371 2019-03-11  Sam Weinig  <sam@webkit.org>
2372
2373         Add utility function to allow easy reverse range-based iteration of a container
2374         https://bugs.webkit.org/show_bug.cgi?id=195542
2375
2376         Reviewed by Antti Koivisto.
2377
2378         * TestWebKitAPI/CMakeLists.txt:
2379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2380         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2381         (TestWebKitAPI::TEST):
2382         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2383
2384 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2385
2386         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2387         https://bugs.webkit.org/show_bug.cgi?id=195511
2388         <rdar://problem/44873269>
2389
2390         Reviewed by Darin Adler.
2391
2392         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2393         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2394         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2395         (TEST_F):
2396
2397 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2398
2399         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2400         https://bugs.webkit.org/show_bug.cgi?id=195499
2401
2402         Reviewed by Darin Adler.
2403
2404         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2405         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2406         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2407         (-[WKWebView synchronouslyFocusTextInputContext:]):
2408         (applyStyle):
2409         (applyIframe):
2410         (TEST):
2411         Add some tests for this SPI.
2412
2413 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2414
2415         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2416         https://bugs.webkit.org/show_bug.cgi?id=181151
2417
2418         Reviewed by Don Olmstead.
2419
2420         * TestWebKitAPI/CMakeLists.txt:
2421         * TestWebKitAPI/PlatformWin.cmake:
2422         Enable TestWTF RunLoop tests in all platforms.
2423
2424         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2425         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2426         (TestWebKitAPI::DerivedOneShotTimer::fired):
2427         (TestWebKitAPI::TEST):
2428         Only a few platforms support nested RunLoop.
2429
2430         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2431         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2432
2433 2019-03-10  David Quesada  <david_quesada@apple.com>
2434
2435         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2436         https://bugs.webkit.org/show_bug.cgi?id=152480
2437
2438         Reviewed by Chris Dumez.
2439
2440         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2441         there are no additional references to the process pool besides the one held by
2442         the download, waits for the download to finish (in the sense that the
2443         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2444         measure, also check that the process pool has been deallocated at the end of the
2445         test. The test wouldn't be meaningful if the process pool were still alive.
2446
2447         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2448         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2449         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2450             The download will be canceled because the delegate does not implement the
2451             method to decide the download's destination, so this is where we know the
2452             DownloadProxyMap is done with the DownloadProxy.
2453         (TEST):
2454
2455 2019-03-08  Chris Dumez  <cdumez@apple.com>
2456
2457         Add support for Device Orientation / Motion permission API
2458         https://bugs.webkit.org/show_bug.cgi?id=195329
2459         <rdar://problem/47645367>
2460
2461         Reviewed by Geoffrey Garen.
2462
2463         Add test infrastructure to help test the Device Orientation / Motion permission API.
2464
2465         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2466         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2467         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2468         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2469         * WebKitTestRunner/TestController.cpp:
2470         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2471         (WTR::TestController::createWebViewWithOptions):
2472         (WTR::TestController::resetStateToConsistentValues):
2473         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2474         * WebKitTestRunner/TestController.h:
2475         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2476         * WebKitTestRunner/TestInvocation.cpp:
2477         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2478
2479 2019-03-08  Saam barati  <sbarati@apple.com>
2480
2481         Add a compare-results script to compare benchmark results
2482         https://bugs.webkit.org/show_bug.cgi?id=195486
2483         <rdar://problem/48723397>
2484
2485         Reviewed by Geoffrey Garen.
2486
2487         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2488         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2489         to extend it to learn about our other benchmarks.
2490
2491         * Scripts/compare-results: Added.
2492         (readJSONFile):
2493         (detectJetStream2):
2494         (JetStream2Results):
2495         (detectSpeedometer2):
2496         (Speedometer2Results):
2497         (detectPLT5):
2498         (PLT5Results):
2499         (detectBenchmark):
2500         (biggerIsBetter):
2501         (ttest):
2502         (getOptions):
2503         (main):
2504
2505 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2506
2507         Ensure old tab state is cleared between iterations of run-benchmark
2508         https://bugs.webkit.org/show_bug.cgi?id=195393
2509         <rdar://problem/46885583>
2510
2511         Reviewed by Dewei Zhu.
2512
2513         a) ensure the default to restore state is not set
2514         b) terminate Safari correctly
2515         c) Set the system default to ignore Persistent State in Safari
2516
2517         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2518         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2519         (OSXBrowserDriver.prepare_env): 
2520         (OSXBrowserDriver.restore_env):
2521         (OSXBrowserDriver.close_browsers):
2522         (OSXBrowserDriver._terminate_processes):
2523         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2524         (OSXChromeDriver):
2525         (OSXChromeCanaryDriver):
2526         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2527         (OSXFirefoxDriver):
2528         (OSXFirefoxNightlyDriver):
2529         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2530         (OSXSafariDriver):
2531         (OSXSafariDriver.prepare_env):
2532
2533 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2534
2535         [GTK] Several InputMethodFilter tests are failing
2536         https://bugs.webkit.org/show_bug.cgi?id=195408
2537
2538         Reviewed by Carlos Garcia Campos.
2539
2540         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2541         Regressed in r241751.
2542         Hexadecimal values of keycodes are expressed now in upper letters.
2543         Composited characters should be cast to UTF8 strings.
2544
2545         (TestWebKitAPI::TEST):
2546
2547 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2548
2549         [GTK] Make Tools/gtkdoc python3 compatible
2550         https://bugs.webkit.org/show_bug.cgi?id=195359
2551
2552         Reviewed by Carlos Garcia Campos.
2553
2554         * gtkdoc/generate-gtkdoc:
2555         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2556         work with Python 2 and 3.
2557         (get_gtkdoc_module_paths):
2558         The iteritems() was removed in Python 3, so let's use items() that's
2559         available in Python 2 and 3.
2560         (get_generator_for_config):
2561         * gtkdoc/gtkdoc.py:
2562         (GTKDoc._run_command):
2563         The sys.stdout.write() is expecting str in Python 3 and not bytes
2564         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2565         for passing the bytes there.
2566
2567 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2568
2569         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2570         https://bugs.webkit.org/show_bug.cgi?id=195346
2571         <rdar://problem/48667048>
2572
2573         Unreviewed build fix for clang-cl.
2574
2575         * DumpRenderTree/win/DumpRenderTree.cpp:
2576         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2577
2578 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2579
2580         requestAnimationFrame should execute before the next frame
2581         https://bugs.webkit.org/show_bug.cgi?id=177484
2582
2583         Reviewed by Simon Fraser.
2584
2585         Add trace points for the page RenderingUpdate.
2586
2587         * Tracing/SystemTracePoints.plist:
2588
2589 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2590
2591         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2592         https://bugs.webkit.org/show_bug.cgi?id=195353
2593         <rdar://problem/48626394>
2594
2595         Reviewed by Simon Fraser.
2596
2597         * WebKitTestRunner/ios/TestControllerIOS.mm:
2598         (WTR::TestController::platformResetPreferencesToConsistentValues):
2599
2600 2019-03-07  John Wilander  <wilander@apple.com>
2601
2602         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2603         https://bugs.webkit.org/show_bug.cgi?id=195383
2604         <rdar://problem/48570136>
2605
2606         Reviewed by Brent Fulgham.
2607
2608         This patch adds test infrastructure to purge only script-accessible cookies,
2609         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2610
2611         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2612         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2613         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2614         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2615         * WebKitTestRunner/TestController.cpp:
2616         (WTR::TestController::statisticsDeleteCookiesForHost):
2617         * WebKitTestRunner/TestController.h:
2618         * WebKitTestRunner/TestInvocation.cpp:
2619         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2620
2621 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2622
2623         Unreviewed, rolling out r242354.
2624         https://bugs.webkit.org/show_bug.cgi?id=195402
2625
2626         breaks layout tests in all configurations (Requested by
2627         zdobersek on #webkit).
2628
2629         Reverted changeset:
2630
2631         "[WPE] Enable web process sandbox"
2632         https://bugs.webkit.org/show_bug.cgi?id=195169
2633         https://trac.webkit.org/changeset/242354
2634
2635 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2636
2637         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2638         https://bugs.webkit.org/show_bug.cgi?id=195346
2639
2640         Reviewed by Fujii Hironori.
2641
2642         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2643         (TestWebKitAPI::TEST):
2644         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2645
2646         * DumpRenderTree/win/DumpRenderTree.cpp:
2647         (findFontFallback):
2648         (addFontFallbackIfPresent):
2649         (removeFontFallbackIfPresent):
2650         (main):
2651         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2652         (TestWebKitAPI::Util::moduleDirectory):
2653         (TestWebKitAPI::Util::createInjectedBundlePath):
2654         Use wchar helpers as needed.
2655
2656 2019-03-06  Rob Buis  <rbuis@igalia.com>
2657
2658         Consider supporting the `referrerpolicy` attribute.
2659         https://bugs.webkit.org/show_bug.cgi?id=179053
2660
2661         Reviewed by Darin Adler.
2662
2663         Add a runtime flag for referrerpolicy attribute.
2664
2665         * DumpRenderTree/mac/DumpRenderTree.mm:
2666         (enableExperimentalFeatures):
2667
2668 2019-03-05  Daniel Bates  <dabates@apple.com>
2669
2670         Update expected API test result following r242379
2671         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2672
2673         Update expected x-coordinate of selection rect now that the left padding of
2674         a textarea is sized in ems (so dependent on the font size) just like the left
2675         padding of a text field.
2676
2677         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2678         (TestWebKitAPI::TEST):
2679
2680 2019-03-05  David Quesada  <david_quesada@apple.com>
2681
2682         [WK2] It should be possible to follow links with 'download' attributes
2683         https://bugs.webkit.org/show_bug.cgi?id=195145
2684         rdar://problem/48462642
2685
2686         Reviewed by Alex Christensen.
2687
2688         Add a unit test to verify that activating links with 'download' attributes now
2689         navigates to the linked resource, rather than starts downloading it. Add another
2690         to verify that it is still possible to explicitly download the link via the
2691         'Download' navigation action policy.
2692
2693         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2694         (-[DownloadAttributeTestDelegate init]):
2695         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2696         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2697         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2698         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2699         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2700         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2701         (TEST):
2702         * WebKitTestRunner/TestController.cpp:
2703         (WTR::TestController::decidePolicyForNavigationAction):
2704         * WebKitTestRunner/TestController.h:
2705
2706 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2707
2708         [Curl] Implement Cookie Accept Policy.
2709         https://bugs.webkit.org/show_bug.cgi?id=191645
2710
2711         Reviewed by Fujii Hironori.
2712
2713         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2714         (TestWebKitAPI::Curl::TEST_F):
2715
2716 2019-03-05  Youenn Fablet  <youenn@apple.com>
2717
2718         Rename requestCacheStorageSpace to requestStorageSpace
2719         https://bugs.webkit.org/show_bug.cgi?id=195282
2720
2721         Reviewed by Chris Dumez.
2722
2723         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2724         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2725         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2726
2727 2019-03-05  Brady Eidson  <beidson@apple.com>
2728
2729         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2730         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2731
2732         Reviewed by Tim Horton.
2733
2734         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2735         different directory into that same WKWebView should work.
2736
2737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2738         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2739
2740 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2741
2742         Add WeakHashSet
2743         https://bugs.webkit.org/show_bug.cgi?id=195152
2744
2745         Reviewed by Antti Koivisto.
2746
2747         Added tests for WeakHashSet.
2748
2749         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2750         (TestWebKitAPI::Base::Base): Moved.
2751         (TestWebKitAPI::Derived::foo): Moved.
2752         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2753         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2754         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2755         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2756
2757 2019-03-04  Chris Dumez  <cdumez@apple.com>
2758
2759         Do not share WebProcesses between private and regular sessions
2760         https://bugs.webkit.org/show_bug.cgi?id=195189
2761         <rdar://problem/48421064>
2762
2763         Reviewed by Alex Christensen.
2764
2765         Add API test coverage.
2766
2767         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2768         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2769
2770 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2771
2772         [WPE] Enable web process sandbox
2773         https://bugs.webkit.org/show_bug.cgi?id=195169
2774
2775         Reviewed by Daniel Bates.
2776
2777         * wpe/install-dependencies:
2778         * wpe/jhbuild.modules:
2779
2780 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2781
2782         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2783         https://bugs.webkit.org/show_bug.cgi?id=195206
2784
2785         Reviewed by Žan Doberšek.
2786
2787         Add a new test case.
2788
2789         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2790         (testJSCClass):
2791
2792 2019-03-04  Charlie Turner  <cturner@igalia.com>
2793
2794         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2795         https://bugs.webkit.org/show_bug.cgi?id=194898
2796
2797         Reviewed by Žan Doberšek.
2798
2799         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2800         a GCC extension that permits arithmetic on void* pointer. Inline
2801         the macro until this issue is fixed upstream.
2802
2803 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2804
2805         Rid the world of WK_API_ENABLED
2806         https://bugs.webkit.org/show_bug.cgi?id=195263
2807
2808         Reviewed by Dan Bernstein.
2809
2810         List of changed files elided because it's useless.
2811
2812 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2813
2814         Unreviewed follow-up to r242292.
2815
2816         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2817
2818         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2819         (TestWebKitAPI::testStrip): Renamed from strip.
2820         (TestWebKitAPI::TEST):
2821
2822 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2823
2824         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2825
2826         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2827         and bug #194272 for details.
2828
2829         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2830
2831 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2832
2833         Remove some more unused 32-bit code
2834         https://bugs.webkit.org/show_bug.cgi?id=195255
2835
2836         Reviewed by Darin Adler.
2837
2838         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2839         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2840         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2841         (NPP_New):
2842         (NPP_HandleEvent):
2843         (handleEventCarbon): Deleted.
2844
2845 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2846
2847         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2848
2849         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2850         (TestWebKitAPI::TEST):
2851
2852 2019-03-01  Darin Adler  <darin@apple.com>
2853
2854         Finish removing String::format
2855         https://bugs.webkit.org/show_bug.cgi?id=194893
2856
2857         Reviewed by Daniel Bates.
2858 '
2859         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2860
2861 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2862
2863         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2864         https://bugs.webkit.org/show_bug.cgi?id=195229
2865         <rdar://problem/48520362>
2866
2867         Reviewed by Chris Dumez.
2868
2869         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2870         (TEST):
2871
2872 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2873
2874         Add a system trace scope for event region building
2875         https://bugs.webkit.org/show_bug.cgi?id=195226
2876
2877         Reviewed by Jon Lee.
2878
2879         This trace scope measures the time spend converting element rects into Region objects,
2880         which can be large on some pages.
2881
2882         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2883
2884         * Tracing/SystemTracePoints.plist:
2885
2886 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2887
2888         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2889         https://bugs.webkit.org/show_bug.cgi?id=194612
2890
2891         Reviewed by Alex Christensen.
2892
2893         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2894         Just test the new string-processing function and don't touch the actual environment.
2895         (Test cases are all as before, but based on operator== instead of strcmp.)
2896
2897 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2898
2899         [ews-app] Update primary keys for handling multiple Buildbot instances
2900         https://bugs.webkit.org/show_bug.cgi?id=195120
2901
2902         Reviewed by Stephanie Lewis.
2903
2904         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2905         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
2906         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
2907
2908         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
2909         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
2910         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
2911         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
2912         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
2913         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
2914
2915 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
2916
2917         [WinCairo] Enable service worker
2918         https://bugs.webkit.org/show_bug.cgi?id=188318
2919
2920         Reviewed by Youenn Fablet.
2921
2922         * DumpRenderTree/DumpRenderTreePrefix.h:
2923         * TestWebKitAPI/PlatformWin.cmake:
2924         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
2925         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
2926         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2927
2928 2019-03-01  Justin Fan  <justin_fan@apple.com>
2929
2930         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
2931         https://bugs.webkit.org/show_bug.cgi?id=195191
2932
2933         Rubber-stamped by Dean Jackson.
2934
2935         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
2936
2937         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2938
2939 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
2940
2941         Unreviewed, fix lldb webkitpy tests
2942         https://bugs.webkit.org/show_bug.cgi?id=194375
2943
2944         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
2945
2946         * lldb/lldb_webkit.py:
2947         (WTFStringImplProvider.is_8bit):
2948
2949 2019-02-28  David Quesada  <david_quesada@apple.com>
2950
2951         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
2952         https://bugs.webkit.org/show_bug.cgi?id=195121
2953         rdar://problem/48450302
2954
2955         Reviewed by Alex Christensen.
2956
2957         Add API tests for -WKNavigationAction._shouldPerformDownload in various
2958         configurations where the 'download' attribute is absent, blank, or populated
2959         with a filename, and where the anchor element is same-origin or cross-origin
2960         (meaning the 'download' attribute shouldn't be honored).
2961
2962         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2963         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
2964         (-[NavigationActionTestDelegate init]):
2965         (-[NavigationActionTestDelegate navigationAction]):
2966         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
2967         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
2968         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2969         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
2970         (TEST):
2971
2972 2019-02-28  Antoine Quint  <graouts@apple.com>
2973
2974         Enable the Pointer Events runtime flag by default
2975         https://bugs.webkit.org/show_bug.cgi?id=195156
2976
2977         Reviewed by Dean Jackson.
2978
2979         * DumpRenderTree/mac/DumpRenderTree.mm:
2980         (enableExperimentalFeatures):
2981
2982 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2983
2984         Several PasteImage API tests are flaky
2985         https://bugs.webkit.org/show_bug.cgi?id=195160
2986
2987         Reviewed by Tim Horton.
2988
2989         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
2990         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
2991         listening for a "load" event after image load is already complete.
2992
2993         To address this, make these tests first register a "load" event handler, then run script to insert an image
2994         element into the document, and finally wait until the load event is observed before checking image size.
2995
2996         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2997
2998 2019-02-28  Chris Dumez  <cdumez@apple.com>
2999
3000         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3001         https://bugs.webkit.org/show_bug.cgi?id=195107
3002
3003         Reviewed by Alex Christensen.
3004
3005         Give some time for the zoom level to get restored.
3006
3007         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3008
3009 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3010
3011         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3012         https://bugs.webkit.org/show_bug.cgi?id=194958
3013
3014         Reviewed by Geoffrey Garen.
3015
3016         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3017         (TEST):
3018
3019 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3020
3021         [ews-app] Update method to save build to handle builder_display_name
3022         https://bugs.webkit.org/show_bug.cgi?id=195047
3023
3024         Reviewed by Dewei Zhu.
3025
3026         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3027         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3028
3029 2019-02-28  Justin Fan  <justin_fan@apple.com>
3030
3031         [Web GPU] Enable Web GPU only on 64-bit
3032         https://bugs.webkit.org/show_bug.cgi?id=195139
3033
3034         Because Metal is only supported on 64 bit apps.
3035
3036         Unreviewed build fix.
3037
3038         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3039
3040 2019-02-27  Youenn Fablet  <youenn@apple.com>
3041
3042         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3043         https://bugs.webkit.org/show_bug.cgi?id=194959
3044
3045         Reviewed by Chris Dumez.
3046
3047         Spin loop until getting the condition to remove flakiness.
3048
3049         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3050
3051 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3052
3053         [ews-build] Buildbot should include builder_display_name in the build events
3054         https://bugs.webkit.org/show_bug.cgi?id=195045
3055
3056         Reviewed by Dewei Zhu.
3057
3058         * BuildSlaveSupport/ews-build/events.py:
3059         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3060         buildername to builder_name to be consistent in naming style.
3061         (Events.buildFinished): Ditto.
3062
3063 2019-02-27  Chris Dumez  <cdumez@apple.com>
3064
3065         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3066         https://bugs.webkit.org/show_bug.cgi?id=194480
3067
3068         Reviewed by Brady Eidson.
3069
3070         Update existing API test to make it more likely to reproduce the issue.
3071
3072         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3073
3074 2019-02-27  Brady Eidson  <beidson@apple.com>
3075
3076         Universal links from Google search results pages don't open the app.
3077         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3078
3079         Reviewed by Geoffrey Garen.
3080
3081         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3082         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3083         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3084         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3085
3086 2019-02-27  Chris Dumez  <cdumez@apple.com>
3087
3088         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3089         https://bugs.webkit.org/show_bug.cgi?id=195102
3090
3091         Reviewed by Geoffrey Garen.
3092
3093         If the number of processes is not yet what we expect, wait a bit and check again to give
3094         processes some time to exit.
3095
3096         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3097
3098 2019-02-27  Chris Dumez  <cdumez@apple.com>
3099
3100         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3101         https://bugs.webkit.org/show_bug.cgi?id=194545
3102
3103         Reviewed by Brady Eidson.
3104
3105         Make sure the test navigates forward and then back only once. Previously, navigating
3106         back would trigger a navigation again in a timer.
3107
3108         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3109
3110 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3111
3112         High Sierra Debug JSC test queue should use faster hardware
3113         https://bugs.webkit.org/show_bug.cgi?id=194603
3114
3115         Rubber-stamped by Alexey Proskuryakov.
3116
3117         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3118
3119         * BuildSlaveSupport/build.webkit.org-config/config.json:
3120         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3121         (BubbleQueueServer):
3122         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3123         (WebKitBuildbot):
3124         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3125         * QueueStatusServer/config/queues.py:
3126         * Scripts/webkitpy/common/config/ews.json:
3127         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3128         (test_ews_name):
3129
3130 2019-02-27  John Wilander  <wilander@apple.com>
3131
3132         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3133         https://bugs.webkit.org/show_bug.cgi?id=195071
3134         <rdar://problem/48417690>
3135
3136         Reviewed by Alex Christensen and Brent Fulgham.
3137
3138         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3139         (TestWebKitAPI::createURL):
3140             Convenience function.
3141         (TestWebKitAPI::TEST):
3142             WebCore::AdClickAttribution now takes a URL when creating Source and
3143             Destination.
3144         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3145         (TestWebKitAPI::TEST):
3146             WebCore::AdClickAttribution now takes a URL when creating Source and
3147             Destination.
3148
3149 2019-02-27  Antoine Quint  <graouts@apple.com>
3150
3151         Support Pointer Events on macOS
3152         https://bugs.webkit.org/show_bug.cgi?id=195008
3153         <rdar://problem/47454419>
3154
3155         Reviewed by Dean Jackson.
3156
3157         * DumpRenderTree/mac/DumpRenderTree.mm:
3158         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3159         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3160
3161 2019-02-26  Mark Lam  <mark.lam@apple.com>
3162
3163         Remove remaining poisoning code.
3164         https://bugs.webkit.org/show_bug.cgi?id=194138
3165
3166         Reviewed by Saam Barati.
3167
3168         * TestWebKitAPI/CMakeLists.txt:
3169         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3170         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3171         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3172         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3173         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3174         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3175         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3176
3177 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3178
3179         Move ephemeral local storage from WebProcess to UIProcess
3180         https://bugs.webkit.org/show_bug.cgi?id=195074
3181         <rdar://problem/47937975>
3182
3183         Reviewed by Geoff Garen.
3184
3185         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3186
3187 2019-02-20  Jer Noble  <jer.noble@apple.com>
3188
3189         [Cocoa] Media elements will restart network buffering just before suspending
3190         https://bugs.webkit.org/show_bug.cgi?id=193691
3191
3192         Reviewed by Eric Carlson.
3193
3194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3195         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3196         (TEST):
3197
3198 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3199
3200         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3201         https://bugs.webkit.org/show_bug.cgi?id=191652
3202
3203         Reviewed by Alex Christensen.
3204
3205         Fix WinCairo MiniBrowser behavior of authentication dialog.
3206
3207         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3208         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3209
3210 2019-02-26  Youenn Fablet  <youenn@apple.com>
3211
3212         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3213         https://bugs.webkit.org/show_bug.cgi?id=195028
3214         <rdar://problem/48243733>
3215
3216         Reviewed by Eric Carlson.
3217
3218         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3219
3220 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3221
3222         [WPE] Add API for webview background color configuration
3223         https://bugs.webkit.org/show_bug.cgi?id=192305
3224
3225         Reviewed by Michael Catanzaro.
3226
3227         * MiniBrowser/wpe/main.cpp:
3228         (main): Add a new option to configure the webview background
3229         color. Example: --bg-color=transparent.
3230         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3231         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3232         (beforeAll): Ditto.
3233
3234 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3235
3236         scalableNativeWebpageParameters() is not preserved on new page navigation.
3237         https://bugs.webkit.org/show_bug.cgi?id=194892
3238         <rdar://problem/47538280>
3239
3240         Reviewed by Wenson Hsieh.
3241         
3242         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3243
3244         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3245         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3246         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3247         (WTR::UIScriptController::allowsViewportShrinkToFit):
3248         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3249         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3250         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3251         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3252         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3253         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3254
3255 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3256
3257         [ews-app] Add model for handling multiple Buildbot instances
3258         https://bugs.webkit.org/show_bug.cgi?id=194863
3259
3260         Reviewed by Stephanie Lewis.
3261
3262         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3263
3264 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3265
3266         [ews-app] Remove BuilderMapping table
3267         https://bugs.webkit.org/show_bug.cgi?id=194961
3268
3269         Reviewed by Stephanie Lewis.
3270
3271         Store builder name directly in build table, instead of having a separate
3272         table for it.
3273
3274         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3275         * BuildSlaveSupport/ews-app/ews/models/build.py:
3276         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3277         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3278
3279 2019-02-25  John Wilander  <wilander@apple.com>
3280
3281         Introduce and adopt new class RegistrableDomain for eTLD+1
3282         https://bugs.webkit.org/show_bug.cgi?id=194791
3283         <rdar://problem/48179240>
3284
3285         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3286
3287         This patch adds an API test and replaces two instances of
3288         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3289
3290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3291         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3292         (TestWebKitAPI::TEST):
3293             Changed two strings to make sure the registrable domains are still considered
3294             invalid and pass the test.
3295         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3296         (TestWebKitAPI::TEST):
3297         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3298         (WTR::InjectedBundle::didReceiveMessageToPage):
3299
3300 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3301
3302         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3303         https://bugs.webkit.org/show_bug.cgi?id=195001
3304
3305         Reviewed by Carlos Garcia Campos.
3306
3307         API version 1.0 always includes the functionality previously guarded with
3308         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3309         unconditionally.
3310
3311         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3312         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3313         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3314         (WebViewTest::showInWindow): Ditto.
3315         (WebViewTest::hideView): Ditto.
3316         * wpe/backends/HeadlessViewBackend.cpp:
3317         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3318         * wpe/backends/ViewBackend.cpp:
3319         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3320         * wpe/backends/WindowViewBackend.cpp:
3321         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3322         WPE_BACKEND_CHECK_VERSION().
3323         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3324
3325 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3326
3327         [Flatpak] Add support for flatpak > 1.1.2
3328         https://bugs.webkit.org/show_bug.cgi?id=194088
3329
3330         Flatpak 1.2 is now out so we need to support that
3331         version now.
3332
3333         Reviewed by Michael Catanzaro.
3334
3335         * flatpak/flatpakutils.py:
3336         (check_flatpak):
3337         (FlatpakPackages.__init__):
3338         (FlatpakPackages.__detect_packages):
3339         (FlatpakPackages.__detect_packages.in):
3340         (FlatpakRepos.update):
3341
3342 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3343
3344         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3345         https://bugs.webkit.org/show_bug.cgi?id=194998
3346
3347         Reviewed by Carlos Garcia Campos.
3348
3349         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3350         to a Git checkout and using the latest commit containing various fixes
3351         and improvements.
3352
3353 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3354
3355         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3356         https://bugs.webkit.org/show_bug.cgi?id=194981
3357
3358         Reviewed by Žan Doberšek.
3359
3360         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3361         (TestWebKitAPI::TEST):
3362
3363 2019-02-23  Keith Miller  <keith_miller@apple.com>
3364
3365         Add new mac target numbers
3366         https://bugs.webkit.org/show_bug.cgi?id=194955
3367
3368         Reviewed by Tim Horton.
3369
3370         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3371         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3372         * MiniBrowser/Configurations/Base.xcconfig:
3373         * TestWebKitAPI/Configurations/Base.xcconfig:
3374         * WebKitTestRunner/Configurations/Base.xcconfig:
3375
3376 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3377
3378         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3379         https://bugs.webkit.org/show_bug.cgi?id=194846
3380
3381         Reviewed by Don Olmstead.
3382
3383         Added _search_paths() and _port_specific_expectations_files() for
3384         WinCairoPort.
3385
3386         * Scripts/webkitpy/port/win.py:
3387         (WinCairoPort.default_baseline_search_path):
3388         (WinCairoPort):
3389         (WinCairoPort._port_specific_expectations_files):
3390         (WinCairoPort._search_paths):
3391
3392 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3393
3394         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3395         https://bugs.webkit.org/show_bug.cgi?id=194963
3396
3397         Reviewed by Dean Jackson.
3398
3399         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3400         Do a `contains` check instead of `equals`, because in debug builds we
3401         put the GraphicsLayer pointer in a prefix.
3402
3403 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3404
3405         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3406         https://bugs.webkit.org/show_bug.cgi?id=194873
3407         <rdar://problem/46701974>
3408
3409         Reviewed by Tim Horton.
3410
3411         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3412
3413         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3414         (WTR::UIScriptController::menuRect const):
3415         (WTR::UIScriptController::isShowingMenu const):
3416         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3417         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3418         (WTR::UIScriptController::menuRect const):
3419
3420         Add a function to query the bounds of the callout menu in content coordinates.
3421
3422         (WTR::UIScriptController::isShowingMenu const):
3423
3424         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3425
3426         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3427         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3428         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3429         (WTR::UIScriptController::rectForMenuAction const):
3430         (WTR::UIScriptController::menuRect const):
3431         (WTR::UIScriptController::isShowingMenu const):
3432         (WTR::findViewInHierarchyOfType): Deleted.
3433
3434 2019-02-22  Chris Dumez  <cdumez@apple.com>
3435
3436         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3437         https://bugs.webkit.org/show_bug.cgi?id=194954
3438         <rdar://problem/48127957>
3439
3440         Reviewed by Alex Christensen.
3441
3442         Add API test coverage.
3443
3444         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3445         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3446         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3447         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3448
3449 2019-02-22  Chris Dumez  <cdumez@apple.com>
3450
3451         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3452         https://bugs.webkit.org/show_bug.cgi?id=194924
3453         <rdar://problem/48216125>
3454
3455         Reviewed by Geoffrey Garen.
3456
3457         Add API test coverage.
3458
3459         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3460
3461 2019-02-22  Chris Dumez  <cdumez@apple.com>
3462
3463         Unreviewed, disable API test added in r241928 on iOS.
3464
3465         The cache is not enabled on devices with less than 3GB of RAM.
3466
3467         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3468
3469 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3470
3471         Hardcode Visual Viewports on everywhere except iOS WK1
3472         https://bugs.webkit.org/show_bug.cgi?id=194928
3473
3474         Reviewed by Zalan Bujtas.
3475
3476         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3477         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3478         set it to false. The setting has shipped for several years and there's no need to turn
3479         it off now.
3480
3481         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3482         Visual Viewports are not enabled.
3483         
3484         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3485         that only runs in WK2
3486
3487         * MiniBrowser/mac/SettingsController.h:
3488         * MiniBrowser/mac/SettingsController.m:
3489         (-[SettingsController init]):
3490         (-[SettingsController _populateMenu]):
3491         (-[SettingsController validateMenuItem:]):
3492         (-[SettingsController visualViewportEnabled]): Deleted.
3493         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3494         * MiniBrowser/mac/WK1BrowserWindowController.m:
3495         (-[WK1BrowserWindowController didChangeSettings]):
3496         * MiniBrowser/mac/WK2BrowserWindowController.m:
3497         (-[WK2BrowserWindowController didChangeSettings]):
3498
3499 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3500
3501         Discard cached processes when clearing website data store
3502         https://bugs.webkit.org/show_bug.cgi?id=194894
3503
3504         Reviewed by Chris Dumez.
3505
3506         Added a test case.
3507
3508         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3509         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3510
3511 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3512
3513         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3514         https://bugs.webkit.org/show_bug.cgi?id=194914
3515         <rdar://problem/47586889>
3516
3517         Reviewed by Geoffrey Garen.
3518
3519         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3520         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3521         (TEST):
3522         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3523
3524 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3525
3526         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3527         <https://webkit.org/b/194761>
3528
3529         Reviewed by Myles Maxfield.
3530
3531         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3532         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3533         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3534         to use ARC-compliant cast.
3535         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3536         ARC-compliant cast.
3537         (WTR::installFakeHelvetica): Log `error` to console if
3538         CTFontManagerRegisterFontsForURL() fails, but only on supported
3539         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3540         Call CFRelease() on `error` to fix the leak.  Update to use
3541         ARC-compliant cast.
3542         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3543         cast.
3544
3545 2019-02-21  Chris Dumez  <cdumez@apple.com>
3546
3547         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3548         https://bugs.webkit.org/show_bug.cgi?id=194481
3549
3550         Reviewed by Alex Christensen.
3551
3552         Give the processes a chance to shutdown and wait until we reached the expected number
3553         of processes.
3554
3555         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3556
3557 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3558
3559         Fix the macOS build
3560
3561         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3562
3563 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3564
3565         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3566
3567         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3568         I am a backwards.
3569
3570 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3571
3572         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3573
3574         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3575         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3576         We could force on UI-side compositing, but I feel like the test might be more
3577         valuable exercising the normal path on each platform (though the original
3578         bug was also UI-side specific). Though we can't validate that the overlay
3579         layer was installed successfully, there are layout tests that do that.
3580
3581 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3582
3583         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3584         https://bugs.webkit.org/show_bug.cgi?id=194845
3585         <rdar://problem/47944579>
3586
3587         Reviewed by Antti Koivisto.
3588
3589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3590         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3591
3592 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3593
3594         [LFC][Floats] Add support for placing formatting roots in-between floats.
3595         https://bugs.webkit.org/show_bug.cgi?id=194902
3596
3597         Reviewed by Antti Koivisto.
3598
3599         * LayoutReloaded/misc/LFC-passing-tests.txt:
3600
3601 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3602
3603         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3604         https://bugs.webkit.org/show_bug.cgi?id=194901
3605
3606         Unreviewed build fix.
3607
3608         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3609         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3610         WPEBackend-fdo-0.1 as library name.
3611
3612 2019-02-21  Rob Buis  <rbuis@igalia.com>
3613
3614         Update MIME type parser
3615         https://bugs.webkit.org/show_bug.cgi?id=180526
3616
3617         Reviewed by Darin Adler.
3618
3619         Add tests involving leading and trailing whitespace, non-token
3620         characters and quoted strings.
3621
3622         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3623         (TestWebKitAPI::TEST):
3624
3625 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3626
3627         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3628         https://bugs.webkit.org/show_bug.cgi?id=194884
3629
3630         Reviewed by Michael Catanzaro.
3631
3632         * PlatformWin.cmake:
3633
3634 2019-02-20  Chris Dumez  <cdumez@apple.com>
3635
3636         Add API test for <rdar://problem/47471222>
3637         https://bugs.webkit.org/show_bug.cgi?id=194847
3638
3639         Reviewed by Alex Christensen.
3640
3641         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3642
3643 2019-02-20  Chris Dumez  <cdumez@apple.com>
3644
3645         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3646         https://bugs.webkit.org/show_bug.cgi?id=194872
3647         <rdar://problem/47924500>
3648
3649         Reviewed by Alex Christensen.
3650
3651         Add API test coverage.
3652
3653         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3654
3655 2019-02-20  Jer Noble  <jer.noble@apple.com>
3656
3657         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3658         https://bugs.webkit.org/show_bug.cgi?id=191332
3659
3660         Reviewed by Dean Jackson.
3661
3662         * Scripts/git-is-in-range: Added.
3663
3664 2019-02-20  Andy Estes  <aestes@apple.com>
3665
3666         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3667         https://bugs.webkit.org/show_bug.cgi?id=194869
3668
3669         Rubber-stamped by Jer Noble.
3670
3671         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3672         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3673         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3674         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3676         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3677
3678 2019-02-20  Chris Dumez  <cdumez@apple.com>
3679
3680         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3681         https://bugs.webkit.org/show_bug.cgi?id=194857
3682         <rdar://problem/47759323>
3683
3684         Reviewed by Alex Christensen.
3685
3686         Add API test coverage.
3687
3688         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3689
3690 2019-02-20  Chris Dumez  <cdumez@apple.com>
3691
3692         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3693         https://bugs.webkit.org/show_bug.cgi?id=194829
3694         <rdar://problem/47889906>
3695
3696         Reviewed by Alexey Proskuryakov.
3697
3698         Every time the TestOptions were changing we were creating both a new Web view and
3699         a new WKContext, which would start a new Network process. In most cases, we only
3700         need to contruct a new Web view and we do can keep reusing the same WKContext.
3701         This patch implements this optimization and thus avoids spinning a lot of new
3702         Network processes while running the layout tests.
3703
3704         * WebKitTestRunner/TestController.cpp:
3705         (WTR::TestController::generateContextConfiguration const):
3706         (WTR::TestController::generatePageConfiguration):
3707         (WTR::TestController::createWebViewWithOptions):
3708         (WTR::TestController::resetPreferencesToConsistentValues):
3709         (WTR::updateTestOptionsFromTestHeader):
3710         * WebKitTestRunner/TestController.h:
3711         * WebKitTestRunner/TestOptions.h:
3712         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3713         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3714         (WTR::TestOptions::hasSameInitializationOptions const):
3715         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3716         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3717         (WTR::TestController::platformAddTestOptions const):
3718
3719 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3720
3721         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3722         https://bugs.webkit.org/show_bug.cgi?id=167941
3723
3724         Reviewed by Carlos Garcia Campos.
3725
3726         * MiniBrowser/gtk/main.c:
3727         (filterSavedCallback): Added.
3728         (main): Support loading a JSON rule set file for content filtering.
3729         * MiniBrowser/wpe/main.cpp:
3730         (filterSavedCallback): Added.
3731         (main): Support loading a JSON rule set file for content filtering.
3732         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3733         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3734         (WTF::derefGPtr): Ditto.
3735         (testEmptyStore):
3736         (testSaveInvalidFilter):
3737         (testSaveLoadFilter):
3738         (testSavedFilterIdentifierMatch):
3739         (testRemoveFilter):
3740         (testSaveMultipleFilters):
3741         (testSaveFilterFromFile):
3742         (testFilterPersistence):
3743         (beforeAll):
3744         (afterAll):
3745         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3746         (removeOldInjectedContentAndResetLists): Also reset content filters.
3747         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3748         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3749         the element affected by the style sheet.
3750         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3751         and returns it to be used by tests.
3752         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3753         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3754         (serverCallback): Add support for serving a CSS style sheet for testing.
3755         (beforeAll): Add call to testUserContentManagerContentFilter().
3756         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3757
3758 2019-02-19  Keith Rollin  <krollin@apple.com>
3759
3760         Add timing information to build output
3761         https://bugs.webkit.org/show_bug.cgi?id=194839
3762         <rdar://problem/48219609>
3763
3764         Reviewed by Alexey Proskuryakov.
3765
3766         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3767         emit each project's build time to its output. E.g.,
3768
3769             ** BUILD SUCCEEDED ** [0.132 sec]
3770
3771         * Scripts/webkitdirs.pm:
3772         (XcodeOptions):
3773
3774 2019-02-19  Truitt Savell  <tsavell@apple.com>
3775
3776         Unreviewed, rolling out r241784.
3777
3778         Broke all OpenSource builds.
3779
3780         Reverted changeset:
3781
3782         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3783         instances view"
3784         https://bugs.webkit.org/show_bug.cgi?id=172848
3785         https://trac.webkit.org/changeset/241784
3786
3787 2019-02-19  Zalan Bujtas  <zalan@apple.com>
3788
3789         [LFC][Floats] Remove redundant intersecting logic
3790         https://bugs.webkit.org/show_bug.cgi?id=194804
3791
3792         Reviewed by Antti Koivisto.
3793
3794         * LayoutReloaded/misc/LFC-passing-tests.txt:
3795
3796 2019-02-19  Dean Jackson  <dino@apple.com>
3797
3798         Clean-up output from generate-xcfilelists so it can be filtered
3799         https://bugs.webkit.org/show_bug.cgi?id=194795
3800
3801         Reviewed by Joseph Pecoraro (and Keith Rollin).
3802
3803         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
3804         make a slight tweak to filter-build-webkit so such lines are marked
3805         as plain.
3806
3807         * Scripts/filter-build-webkit:
3808         * Scripts/generate-xcfilelists:
3809
3810 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3811
3812         pytest is not correctly auto-installed
3813         https://bugs.webkit.org/show_bug.cgi?id=194707
3814
3815         Reviewed by Carlos Garcia Campos.
3816
3817         * Scripts/webkitpy/thirdparty/__init__.py:
3818         (AutoinstallImportHook._install_pytest):
3819
3820 2019-02-18  Chris Dumez  <cdumez@apple.com>
3821
3822         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
3823         https://bugs.webkit.org/show_bug.cgi?id=194797
3824         <rdar://problem/48055151>
3825
3826         Reviewed by Geoffrey Garen.
3827
3828         Add API test coverage.
3829
3830         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3831
3832 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3833
3834         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
3835         https://bugs.webkit.org/show_bug.cgi?id=194670
3836         <rdar://problem/39066529>
3837
3838         Reviewed by Tim Horton.
3839
3840         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
3841         pasted in an editable area as attachment elements.
3842
3843         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3844         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3845         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
3846         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3847         (TestWebKitAPI::TEST):
3848         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3849         (WTR::InjectedBundlePage::InjectedBundlePage):
3850
3851 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3852
3853         Fix API test after r241728
3854        ​https://bugs.webkit.org/show_bug.cgi?id=194723
3855
3856         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3857         (TEST):
3858         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
3859
3860 2019-02-18  Daniel Bates  <dabates@apple.com>
3861
3862         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3863         https://bugs.webkit.org/show_bug.cgi?id=192824
3864         <rdar://problem/47100332>
3865
3866         Reviewed by Wenson Hsieh.
3867
3868         Fix a bug where the wrong usage code was used for F13 thru F24.
3869
3870         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3871         (keyCodeForDOMFunctionKey):
3872
3873 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
3874
3875         Bytecode cache should a have a boot-specific validation
3876         https://bugs.webkit.org/show_bug.cgi?id=194769
3877         <rdar://problem/48149509>
3878
3879         Reviewed by Keith Miller.
3880
3881         Add test for WTF::bootSessionUUIDString()
3882
3883         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3884         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
3885         (TEST):
3886
3887 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3888
3889         Disable safe browsing in WKWebView and remove its WKPreferences API
3890         https://bugs.webkit.org/show_bug.cgi?id=194723
3891         <rdar://problem/48122993>
3892
3893         Reviewed by Geoffrey Garen.
3894
3895         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3896         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3897         (TEST):
3898         (safeBrowsingView):
3899         Make tests use SPI instead of API.
3900
3901 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3902
3903         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
3904         https://bugs.webkit.org/show_bug.cgi?id=194586
3905
3906         Reviewed by Ross Kirsling.
3907
3908         * DumpRenderTree/win/DumpRenderTree.cpp:
3909         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
3910         * Scripts/webkitpy/port/driver.py:
3911         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
3912
3913 2019-02-17  David Kilzer  <ddkilzer@apple.com>
3914
3915         Unreviewed, rolling out r241620.
3916
3917         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
3918         (Requested by ddkilzer on #webkit.)
3919
3920         Reverted changeset:
3921
3922         "[WTF] Add environment variable helpers"
3923         https://bugs.webkit.org/show_bug.cgi?id=192405
3924         https://trac.webkit.org/changeset/241620
3925
3926 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3927
3928         [LFC] RenderImage's default intrinsic size is 0.
3929         https://bugs.webkit.org/show_bug.cgi?id=194745
3930
3931         Reviewed by Antti Koivisto.
3932
3933         * LayoutReloaded/misc/LFC-passing-tests.txt:
3934
3935 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3936
3937         [LFC][BFC] Add support for block replaced intrinsic width.
3938         https://bugs.webkit.org/show_bug.cgi?id=194705
3939
3940         Reviewed by Simon Fraser.
3941
3942         * LayoutReloaded/misc/LFC-passing-tests.txt:
3943
3944 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3945
3946         [LFC] Apply min/max width constraints to preferred width computation
3947         https://bugs.webkit.org/show_bug.cgi?id=194739
3948
3949         Reviewed by Simon Fraser.
3950
3951         * LayoutReloaded/misc/LFC-passing-tests.txt:
3952
3953 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
3954
3955         [WTF] Add environment variable helpers
3956         https://bugs.webkit.org/show_bug.cgi?id=192405
3957
3958         Reviewed by Michael Catanzaro.
3959
3960         * DumpRenderTree/mac/DumpRenderTree.mm:
3961         (libraryPathForDumpRenderTree):
3962         * DumpRenderTree/win/DumpRenderTree.cpp:
3963         (libraryPathForDumpRenderTree):
3964         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3965         (setUpIOSLayoutTestCommunication):
3966         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3967         (beforeAll):
3968         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3969         (main):
3970         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3971         (WebKitTestBus::run):
3972         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3973         (WTR::getOutputDir):
3974         (WTR::initializeFontConfigSetting):
3975         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3976         (WTR::InjectedBundle::platformInitialize):
3977         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3978         (WTR::topLevelPath):
3979         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3980         (WTR::topLevelPath):
3981         (WTR::getOutputDir):
3982         (WTR::activateFonts):
3983         * WebKitTestRunner/TestController.cpp:
3984         (WTR::TestController::libraryPathForTesting):
3985         (WTR::TestController::generateContextConfiguration const):
3986         (WTR::TestController::generatePageConfiguration):
3987         (WTR::TestController::decideDestinationWithSuggestedFilename):
3988         (WTR::TestController::platformAdjustContext):
3989         * WebKitTestRunner/TestController.h:
3990         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3991         (WTR::TestController::cocoaPlatformInitialize):
3992         (WTR::TestController::platformAdjustContext):
3993         * WebKitTestRunner/gtk/main.cpp:
3994         (main):
3995         * WebKitTestRunner/mac/TestControllerMac.mm:
3996         (WTR::TestController::configureContentExtensionForTest):
3997         * WebKitTestRunner/wpe/main.cpp:
3998         (main):
3999         Utilize WTF::Environment where possible.
4000
4001 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4002
4003         [iOS] WKWebView callout bar is missing Change Writing Direction item
4004         https://bugs.webkit.org/show_bug.cgi?id=190015
4005         <rdar://problem/44810366>
4006
4007         Reviewed by Tim Horton.
4008
4009         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
4010         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
4011
4012         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
4013         (TestWebKitAPI::TEST):
4014
4015 2019-02-15  Chris Dumez  <cdumez@apple.com>
4016
4017         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
4018         https://bugs.webkit.org/show_bug.cgi?id=194717
4019         <rdar://problem/47884404>
4020
4021         Reviewed by Brady Eidson.
4022
4023         Add API test coverage.
4024
4025         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4026
4027 2019-02-15  Youenn Fablet  <youenn@apple.com>
4028
4029         Make navigator.mediaDevices SecureContext
4030         https://bugs.webkit.org/show_bug.cgi?id=194666
4031
4032         Reviewed by Eric Carlson.
4033
4034         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4035         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4036         (TEST_F):
4037
4038 2019-02-15  Brian Burg  <bburg@apple.com>
4039
4040         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4041         https://bugs.webkit.org/show_bug.cgi?id=194411
4042         <rdar://problem/47787614>
4043
4044         Reviewed by Joseph Pecoraro.
4045
4046         Remove unnecessary soft linking macro usage.
4047
4048         * DumpRenderTree/mac/TestRunnerMac.mm:
4049         (TestRunner::inspectorTestStubURL):
4050         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4051         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4052         (WTR::TestRunner::inspectorTestStubURL):
4053
4054 2019-02-15  Commit Queue  <commit-queue@webkit.org>
4055
4056         Unreviewed, rolling out r241559 and r241566.
4057         https://bugs.webkit.org/show_bug.cgi?id=194710
4058
4059         Causes layout test crashes under GuardMalloc (Requested by
4060         ryanhaddad on #webkit).
4061
4062         Reverted changesets:
4063
4064         "[WTF] Add environment variable helpers"
4065         https://bugs.webkit.org/show_bug.cgi?id=192405
4066         https://trac.webkit.org/changeset/241559
4067
4068         "Unreviewed build fix for WinCairo Debug after r241559."
4069         https://trac.webkit.org/changeset/241566
4070
4071 2019-02-15  Zalan Bujtas  <zalan@apple.com>
4072
4073         [LFC] Out-of-flow box is never a float box
4074         https://bugs.webkit.org/show_bug.cgi?id=194704
4075
4076         Reviewed by Antti Koivisto.
4077
4078         * LayoutReloaded/misc/LFC-passing-tests.txt:
4079
4080 2019-02-10  Darin Adler  <darin@apple.com>
4081
4082         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
4083         https://bugs.webkit.org/show_bug.cgi?id=194487
4084
4085         Reviewed by Daniel Bates.
4086
4087         * DumpRenderTree/win/DumpRenderTree.cpp:
4088         (applicationId): Use makeString instead of String::format.
4089         (main): Ditto.
4090         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4091         (TestWebKitAPI::Util::createURLForResource): Ditto.
4092         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
4093         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
4094
4095         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4096         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
4097         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
4098         (WTR::createStringWithAttributes): Use appendLiteral.
4099         (WTR::AccessibilityUIElement::helpText const): Ditto.
4100         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
4101         directly instead of using String::format.
4102         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
4103         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
4104
4105 2019-02-15  Truitt Savell  <tsavell@apple.com>
4106
4107         Unreviewed, rolling out r241564.
4108
4109         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
4110
4111         Reverted changeset:
4112
4113         "[Mac] WebInspectorUI.framework does not need to be soft-
4114         linked anymore"
4115         https://bugs.webkit.org/show_bug.cgi?id=194411
4116         https://trac.webkit.org/changeset/241564
4117
4118 2019-02-15  Saam barati  <sbarati@apple.com>
4119
4120         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
4121         https://bugs.webkit.org/show_bug.cgi?id=194036
4122
4123         Reviewed by Yusuke Suzuki.
4124
4125         * Scripts/run-jsc-stress-tests:
4126
4127 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4128
4129         Fix the build.
4130
4131         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4132         (WTR::UIScriptController::drawSquareInEditableImage):
4133         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4134         (TestWebKitAPI::drawSquareInEditableImage):
4135
4136 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4137
4138         Fix the build.
4139
4140         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4141         (WTR::UIScriptController::drawSquareInEditableImage):
4142         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4143         (TestWebKitAPI::drawSquareInEditableImage):
4144
4145 2019-02-14  Brian Burg  <bburg@apple.com>
4146
4147         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4148         https://bugs.webkit.org/show_bug.cgi?id=194411
4149         <rdar://problem/47787614>
4150
4151         Reviewed by Joseph Pecoraro.
4152
4153         Remove unnecessary soft linking macro usage.
4154
4155         * DumpRenderTree/mac/TestRunnerMac.mm:
4156         (TestRunner::inspectorTestStubURL):
4157         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4158         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4159         (WTR::TestRunner::inspectorTestStubURL):
4160
4161 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
4162
4163         [ews-app] status bubble should fetch builder name info from BuilderMapping table
4164         https://bugs.webkit.org/show_bug.cgi?id=194599
4165
4166         Reviewed by Lucas Forschler.
4167
4168         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4169         (StatusBubble._build_bubble):
4170
4171 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
4172
4173         [ews-app] Set Foreign Key in Django build model
4174         https://bugs.webkit.org/show_bug.cgi?id=194667
4175
4176         Reviewed by Lucas Forschler.
4177
4178         * BuildSlaveSupport/ews-app/ews/models/build.py:
4179         (Build):
4180
4181 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
4182
4183         [WTF] Add environment variable helpers
4184         https://bugs.webkit.org/show_bug.cgi?id=192405
4185
4186         Reviewed by Michael Catanzaro.
4187
4188         * DumpRenderTree/mac/DumpRenderTree.mm:
4189         (libraryPathForDumpRenderTree):
4190         * DumpRenderTree/win/DumpRenderTree.cpp:
4191         (libraryPathForDumpRenderTree):
4192         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4193         (setUpIOSLayoutTestCommunication):
4194         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4195         (TestWebKitAPI::strip):
4196         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4197         (beforeAll):
4198         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4199         (main):
4200         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4201         (WebKitTestBus::run):
4202         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4203         (WTR::getOutputDir):
4204         (WTR::initializeFontConfigSetting):
4205         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4206         (WTR::InjectedBundle::platformInitialize):
4207         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4208         (WTR::topLevelPath):
4209         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4210         (WTR::topLevelPath):
4211         (WTR::getOutputDir):
4212         (WTR::activateFonts):
4213         * WebKitTestRunner/TestController.cpp:
4214         (WTR::TestController::libraryPathForTesting):
4215         (WTR::TestController::generateContextConfiguration const):
4216         (WTR::TestController::generatePageConfiguration):
4217         (WTR::TestController::decideDestinationWithSuggestedFilename):
4218         (WTR::TestController::platformAdjustContext):
4219         * WebKitTestRunner/TestController.h:
4220         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4221         (WTR::TestController::cocoaPlatformInitialize):
4222         (WTR::TestController::platformAdjustContext):
4223         * WebKitTestRunner/gtk/main.cpp:
4224         (main):
4225         * WebKitTestRunner/mac/TestControllerMac.mm:
4226         (WTR::TestController::configureContentExtensionForTest):
4227         * WebKitTestRunner/wpe/main.cpp:
4228         (main):
4229         Utilize WTF::Environment where possible.
4230
4231 2019-02-14  Chris Dumez  <cdumez@apple.com>
4232
4233         [PSON] Introduce a WebContent Process cache
4234         https://bugs.webkit.org/show_bug.cgi?id=194594
4235         <rdar://problem/46793397>
4236
4237         Reviewed by Geoff Garen.
4238
4239         Update API tests to turn on the WebContent Process cache.
4240
4241         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4242
4243 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
4244
4245         Unreviewed, build fix after r241480
4246
4247         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4248         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
4249         (-[DragAndDropSimulator initWithWebView:]):
4250
4251 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
4252
4253         AX: ARIA Reflection was disabled in error
4254         https://bugs.webkit.org/show_bug.cgi?id=194647
4255         <rdar://problem/48068336>
4256
4257         Reviewed by Ryosuke Niwa.
4258
4259         Remove test override now that this feature should be enabled by default.
4260
4261         * WebKitTestRunner/TestController.cpp:
4262         (WTR::TestController::resetPreferencesToConsistentValues):
4263
4264 2019-02-14  Commit Queue  <commit-queue@webkit.org>
4265
4266         Unreviewed, rolling out r241486.
4267         https://bugs.webkit.org/show_bug.cgi?id=194655
4268
4269         causing API failures in builds (Requested by ShawnRoberts on
4270         #webkit).
4271
4272         Reverted changeset:
4273
4274         "[Cocoa] Media elements will restart network buffering just
4275         before suspending"
4276         https://bugs.webkit.org/show_bug.cgi?id=193691
4277         https://trac.webkit.org/changeset/241486
4278
4279 2019-02-14  Zalan Bujtas  <zalan@apple.com>
4280
4281         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
4282         https://bugs.webkit.org/show_bug.cgi?id=194622
4283
4284         Reviewed by Antti Koivisto.
4285
4286         * LayoutReloaded/misc/LFC-passing-tests.txt:
4287
4288 2019-02-14  Zalan Bujtas  <zalan@apple.com>
4289
4290         [LFC] Shrink-to-fit-width should be constrained by min/max width
4291         https://bugs.webkit.org/show_bug.cgi?id=194653
4292
4293         Reviewed by Antti Koivisto.
4294
4295         * LayoutReloaded/misc/LFC-passing-tests.txt:
4296
4297 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
4298
4299         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
4300         https://bugs.webkit.org/show_bug.cgi?id=194641
4301
4302         Reviewed by Geoffrey Garen.
4303
4304         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
4305         so that the test would fail without this fix.
4306
4307         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
4308         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
4309
4310 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
4311
4312         [ews-app] Change log level for a log statement
4313
4314         Unreviewed minor fix.
4315
4316         * BuildSlaveSupport/ews-app/ews/models/patch.py:
4317         (Patch.save_patch):
4318
4319 2019-02-13  Jer Noble  <jer.noble@apple.com>
4320
4321         [Cocoa] Media elements will restart network buffering just before suspending
4322         https://bugs.webkit.org/show_bug.cgi?id=193691
4323
4324         Reviewed by Eric Carlson.
4325
4326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4327         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4328         (TEST):
4329
4330 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
4331
4332         [ews-app] Fetch builder id to name mapping
4333         https://bugs.webkit.org/show_bug.cgi?id=194355
4334
4335         Reviewed by Lucas Forschler.
4336
4337         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
4338         (Buildbot.get_builder_id_to_name_mapping):
4339         (Buildbot._get_display_name_from_builder_name):
4340
4341 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
4342
4343         Further restricting webarchive loads
4344         https://bugs.webkit.org/show_bug.cgi?id=194567
4345         <rdar://problem/47610130>
4346
4347         Reviewed by Youenn Fablet.
4348
4349         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
4350         navigations on drop.
4351
4352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4353         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
4354         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
4355         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
4356         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
4357         (TestWebKitAPI::TEST):
4358         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
4359         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
4360         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
4361         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
4362         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
4363         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):