[Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsi...
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-11  Brian Holt  <brian.holt@samsung.com>
2
3         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
4         https://bugs.webkit.org/show_bug.cgi?id=76796
5
6         Reviewed by Chris Fleizach.
7
8         Make the Gtk window for the DRT a toplevel so that it gets the
9         focus from the window manager when the test starts.
10
11         * DumpRenderTree/gtk/DumpRenderTree.cpp:
12         (main):
13
14 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
15
16         Use CSS4 image-rendering to determing image scaling quality
17         https://bugs.webkit.org/show_bug.cgi?id=113405
18
19         Reviewed by Simon Fraser.
20
21         Introduce new flag to enable experimental support for CSS4 Images.
22
23         * Scripts/webkitperl/FeatureList.pm:
24
25 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
26
27         Remove code for Chromium from wkbuild.py
28         https://bugs.webkit.org/show_bug.cgi?id=114423
29
30         Reviewed by Benjamin Poulain.
31
32         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
33         (_should_file_trigger_build):
34         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
35         (ShouldBuildTest):
36
37 2013-04-11  Philippe Normand  <pnormand@igalia.com>
38
39         Unreviewed, update my IRC nickname.
40
41         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
42
43 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
44
45         Remove the rest of Chromium code from webkitpy
46         https://bugs.webkit.org/show_bug.cgi?id=114420
47
48         Reviewed by Benjamin Poulain.
49
50         * Scripts/webkitpy/common/config/urls.py:
51         (view_revision_url):
52         * Scripts/webkitpy/common/host.py:
53         (Host._engage_awesome_locale_hacks):
54         (Host.initialize_scm):
55         (Host):
56         * Scripts/webkitpy/common/host_mock.py:
57         (MockHost.__init__):
58         (MockHost.checkout):
59         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
60         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
61         (JSONResultsGeneratorBase._insert_generic_metadata):
62         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
63         (TestExpectationParser._tokenize_line):
64         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
65         (ExpectationSyntaxTests.test_bare_name_and_bugs):
66         (ExpectationSyntaxTests.test_warnings):
67         * Scripts/webkitpy/layout_tests/port/base.py:
68         (Port.skips_perf_test):
69         (Port.path_to_test_expectations_file):
70         (Port._port_flag_for_scripts):
71         * Scripts/webkitpy/style/checkers/cpp.py:
72         (check_function_definition):
73         (check_include_line):
74         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
75         (OrderOfIncludesTest.test_check_wtf_includes):
76         (WebKitStyleTest.test_webkit_export_check):
77         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
78         (TestExpectationsTestCase.test_valid_expectations):
79         * Scripts/webkitpy/tool/bot/irc_command.py:
80         (Rollout.execute):
81         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
82         (IRCCommandTest.test_whois):
83         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
84         (IRCBotTest.test_help):
85         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
86         (SheriffBotTest.test_command_aliases):
87
88 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
89
90         roll-chromium-deps doesn't roll DEPS
91         https://bugs.webkit.org/show_bug.cgi?id=114421
92
93         Reviewed by Antti Koivisto.
94
95         Roll DEPS. Rolling DEPS. Rolled DEPS.
96
97         * Scripts/webkitpy/tool/bot/irc_command.py:
98         (RollChromiumDEPS.execute):
99
100 2013-04-11  Glenn Adams  <glenn@skynav.com>
101
102         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
103         https://bugs.webkit.org/show_bug.cgi?id=114418
104
105         Reviewed by Ryosuke Niwa.
106
107         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
108         (MockSCM.add): Remove optional remove_exit_code argument.
109         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
110         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
111         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
112         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
113
114 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
115
116         Fix roll-chromium-deps and hi.
117
118         * Scripts/webkitpy/tool/bot/irc_command.py:
119         (Hi.execute):
120         (RollChromiumDEPS.execute):
121
122 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
123
124         Remove webkitpy code to roll Chromium DEPS
125         https://bugs.webkit.org/show_bug.cgi?id=114415
126
127         Reviewed by Benjamin Poulain.
128
129         Removed the code to roll Chromium DEPS in WebKit.
130
131         * Scripts/webkitpy/common/checkout/checkout.py:
132         (Checkout.bug_id_for_this_commit):
133         * Scripts/webkitpy/common/checkout/checkout_mock.py:
134         (MockCheckout.commit_message_for_this_commit):
135         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
136         (CheckoutTest.test_suggested_reviewers):
137         * Scripts/webkitpy/common/checkout/deps.py: Removed.
138         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
139         * Scripts/webkitpy/tool/bot/irc_command.py:
140         (RollChromiumDEPS): Teach webkitbot a sense of humor.
141         (RollChromiumDEPS.execute):
142         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
143         (IRCCommandTest.test_create_bug):
144         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
145         (IRCBotTest.test_revert):
146         * Scripts/webkitpy/tool/bot/sheriff.py:
147         (Sheriff.post_rollout_patch):
148         * Scripts/webkitpy/tool/commands/__init__.py:
149         * Scripts/webkitpy/tool/commands/roll.py: Removed.
150         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
151         * Scripts/webkitpy/tool/steps/__init__.py:
152         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
153         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
154         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
155
156 2013-04-11  Glenn Adams  <glenn@skynav.com>
157
158         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
159         https://bugs.webkit.org/show_bug.cgi?id=114386
160
161         Reviewed by Benjamin Poulain.
162
163         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
164         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
165         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
166         by default and to return exit code 1 if a file/dir had already been added.
167
168         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
169         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
170         * Scripts/webkitpy/common/checkout/scm/svn.py:
171         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
172
173 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
174
175         Unreviewed.
176
177         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
178
179 2013-04-10  Glenn Adams  <glenn@skynav.com>
180
181         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
182         https://bugs.webkit.org/show_bug.cgi?id=114410
183
184         Reviewed by Ryosuke Niwa.
185
186         * Scripts/webkitpy/common/checkout/scm/git.py:
187         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
188         * Scripts/webkitpy/common/checkout/scm/scm.py:
189         (SCM.add): Remove optional return_exit_code argument.
190         (SCM.add_list): Remove optional return_exit_code argument.
191         * Scripts/webkitpy/common/checkout/scm/svn.py:
192         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
193
194 2013-04-10  Eric Seidel  <eric@webkit.org>
195
196         Remove myself from the watchlists, I'm getting too much bug mail. :)
197
198         * Scripts/webkitpy/common/config/watchlist:
199
200 2013-04-10  Commit Queue  <rniwa@webkit.org>
201
202         Unreviewed, rolling out r148158.
203         http://trac.webkit.org/changeset/148158
204         https://bugs.webkit.org/show_bug.cgi?id=114405
205
206         We need to migrate status data (Requested by rniwa on
207         #webkit).
208
209         * Scripts/webkitpy/common/net/statusserver.py:
210         (StatusServer):
211
212 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
213
214         Mass remove all the empty directories
215
216         Rubberstamped by Ryosuke Niwa.
217
218         * BuildSlaveSupport/gtk/crashmon/log: Removed.
219         * BuildSlaveSupport/gtk/xvfb/log: Removed.
220         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
221         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
222         * MiniBrowser/gtk/WebBundle: Removed.
223         * MiniBrowser/win: Removed.
224         * QtTestPlatformPlugin/mac: Removed.
225         * Scripts/webkitpy/tool/bot/testdata: Removed.
226         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
227         * efl/ImageDiff: Removed.
228         * iExploder/htdocs: Removed.
229         * iExploder/iexploder-1.7.2/output: Removed.
230         * iExploder/tools: Removed.
231         * qmake/config.tests/libexecdir: Removed.
232         * qmake/config.tests/libjpeg: Removed.
233         * qmake/config.tests/libpng: Removed.
234
235 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
236
237         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
238         https://bugs.webkit.org/show_bug.cgi?id=114397
239
240         Reviewed by Benjamin Poulain.
241
242         * Scripts/webkitpy/common/net/statusserver.py:
243         (StatusServer):
244
245 2013-04-10  Adam Barth  <abarth@webkit.org>
246
247         Remove abarth from watchlists
248         https://bugs.webkit.org/show_bug.cgi?id=114390
249
250         Reviewed by Ryosuke Niwa.
251
252         I'm trying to cut down on the amount of bugmail I get so that I'll have
253         more of a chance to notice a piece of bugmail directed at me.
254
255         * Scripts/webkitpy/common/config/watchlist:
256
257 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
258
259         webkit-test-results.appspot.com loads the dashboard for Chromium by default
260         https://bugs.webkit.org/show_bug.cgi?id=114381
261
262         Reviewed by Benjamin Poulain.
263
264         Changed the defaults.
265
266         * TestResultServer/static-dashboards/builders.js:
267         * TestResultServer/static-dashboards/dashboard_base.js:
268         (currentBuilderGroupCategory):
269
270 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
271
272         Remove Chromium EWS bots from the queue status server
273         https://bugs.webkit.org/show_bug.cgi?id=113988
274
275         Reviewed by Benjamin Poulain.
276
277         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
278
279         * QueueStatusServer/app.yaml:
280         * QueueStatusServer/config/queues.py:
281         * QueueStatusServer/model/queues.py:
282         (Queue.short_name):
283         (Queue.display_name):
284         * QueueStatusServer/model/queues_unittest.py:
285         (QueueTest.test_short_name):
286         (QueueTest.test_display_name):
287         (QueueTest.test_name_with_underscores):
288         * QueueStatusServer/templates/activebots.html:
289
290 2013-04-10  Ojan Vafai  <ojan@chromium.org>
291
292         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
293         https://bugs.webkit.org/show_bug.cgi?id=114370
294
295         Reviewed by Ryosuke Niwa.
296
297         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
298         Unfortunately, there's no way to test this until this is committed and there is
299         a master restart.
300
301         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
302         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
303         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
304         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
305         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
306         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
307         * TestResultServer/generate_builders_json.py:
308         * TestResultServer/static-dashboards/dashboard_base.js:
309         * TestResultServer/static-dashboards/loader.js:
310
311 2013-04-10  Glenn Adams  <glenn@skynav.com>
312
313         [Qt] Fix regression to test-webkitpy.
314         https://bugs.webkit.org/show_bug.cgi?id=114368
315
316         Reviewed by Ryosuke Niwa.
317
318         * Scripts/webkitpy/layout_tests/port/factory.py:
319         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
320         (PortFactory.get): Remove obsolete chromium port related code.
321         * Scripts/webkitpy/layout_tests/port/mac.py:
322         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
323
324 2013-04-10  Anders Carlsson  <andersca@apple.com>
325
326         Remove unneeded headers from FrameLoader.h
327         https://bugs.webkit.org/show_bug.cgi?id=114223
328
329         Reviewed by Geoffrey Garen.
330
331         Add back headers implicitly included by other headers.
332
333         * WebKitTestRunner/WorkQueueManager.cpp:
334
335 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
336
337         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
338         https://bugs.webkit.org/show_bug.cgi?id=114365
339
340         Reviewed by Martin Robinson.
341
342         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
343         The patch addresses crashes in the tally_event_reply method. It is already committed into the
344         at-spi2-atk source tree and will be available with the next stable release, after which the
345         patch should be removed and the dependency version bumped.
346
347         * gtk/jhbuild.modules:
348         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
349
350 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
351
352         [WinCairo] Unreviewed build fix. Correct DropBox download link.
353
354         * Scripts/update-webkit-wincairo-libs: Revise download URL to
355         match change in DropBox server behavior.
356
357 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
358
359         Removed an annoying message from svn-create-patch
360         https://bugs.webkit.org/show_bug.cgi?id=114332
361
362         Reviewed by Alexey Proskuryakov.
363
364         I see this message basically every time I write a patch, so it must not
365         be true.
366
367         * Scripts/svn-create-patch:
368         (generateDiff):
369
370 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
371
372         [GTK] Add support for Page Visibility
373         https://bugs.webkit.org/show_bug.cgi?id=97324
374
375         Reviewed by Sam Weinig.
376
377         Implemented test runner API for page visibility layout tests.
378
379         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
380         (TestRunner::resetPageVisibility):
381         (TestRunner::setPageVisibility):
382         * Scripts/webkitperl/FeatureList.pm:
383
384 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
385
386         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
387         https://bugs.webkit.org/show_bug.cgi?id=114342
388
389         Reviewed by Gyuyoung Kim.
390
391         Commit 148033 only added an implementation for the Mac port, which made
392         other ports fail most tests since loading the injected bundle failed
393         with a missing symbol.
394
395         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
396         (WTR::AccessibilityUIElement::pathDescription):
397
398 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
399
400         [EFL] Add spell checking option to MiniBrowser
401         https://bugs.webkit.org/show_bug.cgi?id=114282
402
403         Reviewed by Ryosuke Niwa.
404
405         Spell checking is enabled by adding a flag (t/text-checking)
406         with launching MiniBrowser.
407
408         * MiniBrowser/efl/main.c:
409         (window_create):
410         (elm_main):
411
412 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
413
414         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
415         https://bugs.webkit.org/show_bug.cgi?id=113281
416
417         Reviewed by Darin Adler.
418
419         * Scripts/run-gtk-tests:
420         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
421
422 2013-04-09  Glenn Adams  <glenn@skynav.com>
423
424         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
425
426         Unreviewed.
427
428         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
429         (RunTest.test_build_check):
430
431 2013-04-09  Glenn Adams  <glenn@skynav.com>
432
433         [webkitpy] Remove chromium ports.
434         https://bugs.webkit.org/show_bug.cgi?id=114326
435
436         Reviewed by Dirk Pranke.
437
438         As a side effect, also:
439
440         - remove chromium builders from webkitpy.layout_tests.port.builders
441         - remove chromium builders from rebaseline
442         - rewrite chromium dependent tests in rebaseline_unittest
443         - remove chromium platform from garden-o-matic
444         - select apple platform as default platform in garden-o-matic
445         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
446
447         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
449         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
450         (BaselineOptimizerTest.test_move_baselines):
451         (BaselineOptimizerTest.test_efl):
452         (BaselineOptimizerTest.test_no_add_mac_future):
453         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
454         (BaselineOptimizerTest.test_common_directory_includes_root):
455         (BaselineOptimizerTest.test_complex_shadowing):
456         (BaselineOptimizerTest.test_virtual_ports_filtered):
457         * Scripts/webkitpy/layout_tests/port/builders.py:
458         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
459         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
460         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
461         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
462         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
463         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
464         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
465         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
466         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
467         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
468         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
469         * Scripts/webkitpy/layout_tests/port/factory.py:
470         (platform_options):
471         (PortFactory):
472         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
473         (FactoryTest.test_qt):
474         (FactoryTest.test_get_from_builder_name):
475         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
476         (RunTest.test_build_check):
477         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
478         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
479         * Scripts/webkitpy/tool/commands/rebaseline.py:
480         (Rebaseline._builders_to_pull_from):
481         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
482         (_BaseTestCase):
483         (_BaseTestCase.setUp):
484         (TestRebaselineTest.setUp):
485         (TestRebaselineTest.test_baseline_directory):
486         (test_rebaseline_updates_expectations_file):
487         (test_rebaseline_does_not_include_overrides):
488         (test_rebaseline_test):
489         (test_rebaseline_test_and_print_scm_changes):
490         (test_rebaseline_and_copy_test):
491         (test_rebaseline_and_copy_test_no_existing_result):
492         (test_rebaseline_and_copy_test_with_lion_result):
493         (test_rebaseline_and_copy_no_overwrite_test):
494         (TestRebaselineExpectations.test_rebaseline_expectations):
495
496 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
497
498         newcommitbot (WKR) requires a subversion checkout
499         https://bugs.webkit.org/show_bug.cgi?id=114309
500
501         Reviewed by Benjamin Poulain.
502
503         Directly talk to the subversion server instead of relying on a local checkout.
504         This allows us to run WKR off of a git clone.
505
506         * Scripts/webkitpy/tool/commands/newcommitbot.py:
507         (NewCommitBot.next_work_item):
508         (NewCommitBot.process_work_item):
509
510 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
511
512         webkitbot refers to sheriffbot in help
513         https://bugs.webkit.org/show_bug.cgi?id=114307
514
515         Reviewed by Benjamin Poulain.
516
517         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
518
519         * Scripts/webkitpy/tool/bot/irc_command.py:
520         (Help):
521         (Help.execute):
522         (RollChromiumDEPS.execute):
523         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
524         (IRCBotTest.test_help):
525         * Scripts/webkitpy/tool/bot/sheriff.py:
526         (Sheriff.name):
527
528 2013-04-06  Roger Fong  <roger_fong@apple.com>
529
530         Kill old processes between runs on WinEWS bots.
531         Temporarily disable tests to let bots catch up again.
532
533         * EWSTools/start-queue-win.sh:
534         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
535         (WinEWS):
536
537 2013-04-09  Glenn Adams  <glenn@skynav.com>
538
539         [webkitpy] Remove chromium deprecated port support.
540         https://bugs.webkit.org/show_bug.cgi?id=114228
541
542         Reviewed by Ryosuke Niwa.
543
544         * Scripts/webkitpy/common/config/ports.py:
545         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
546         (ChromiumPort): Removed.
547         (ChromiumAndroidPort): Removed.
548         (ChromiumXVFBPort): Removed.
549         * Scripts/webkitpy/common/config/ports_unittest.py:
550         (DeprecatedPortTest.test_chromium_port): Removed.
551         (DeprecatedPortTest.test_chromium_android_port): Removed.
552         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
553         * Scripts/webkitpy/tool/steps/update_unittest.py:
554         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
555         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
556
557 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
558
559         AX: The bounding paths should be made available through accessibility
560         https://bugs.webkit.org/show_bug.cgi?id=113817
561
562         Reviewed by David Kilzer.
563
564         Add a pathDescription property for testing so that it's possible
565         to verify that a path is being returned correctly.
566
567         * DumpRenderTree/AccessibilityUIElement.cpp:
568         (getPathDescriptionCallback):
569         (AccessibilityUIElement::pathDescription):
570         (AccessibilityUIElement::getJSClass):
571         * DumpRenderTree/AccessibilityUIElement.h:
572         (AccessibilityUIElement):
573         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
574         (_CGPathEnumerationIteration):
575         (AccessibilityUIElement::pathDescription):
576         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
577         (AccessibilityUIElement::pathDescription):
578         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
579         (WTR::AccessibilityUIElement::pathDescription):
580         (WTR):
581         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
582         (AccessibilityUIElement):
583         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
584         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
585         (WTR::AccessibilityUIElement::pathDescription):
586         (WTR):
587
588 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
589
590         [EFL] Declare TEST_THEME_DIR in a single place.
591         https://bugs.webkit.org/show_bug.cgi?id=114285
592
593         Reviewed by Anders Carlsson.
594
595         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
596
597         * DumpRenderTree/efl/CMakeLists.txt:
598         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
599         (DumpRenderTreeChrome::createView):
600         (DumpRenderTreeChrome::createInspectorView):
601         (DumpRenderTreeChrome::initialize):
602         (DumpRenderTreeChrome::onDownloadRequest):
603         * EWebLauncher/CMakeLists.txt:
604         * EWebLauncher/main.c:
605         (findThemePath):
606         * EWebLauncher/url_bar.c:
607         (url_bar_add):
608         * MiniBrowser/efl/CMakeLists.txt:
609         * MiniBrowser/efl/main.c:
610         (window_create):
611         * TestWebKitAPI/PlatformEfl.cmake:
612         * TestWebKitAPI/efl/PlatformWebView.cpp:
613         (TestWebKitAPI::PlatformWebView::PlatformWebView):
614         * WebKitTestRunner/PlatformEfl.cmake:
615         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
616         (WTR::PlatformWebView::PlatformWebView):
617
618 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
619
620         [GTK][AC] upversion of clutter and its dependecy
621         https://bugs.webkit.org/show_bug.cgi?id=114016
622
623         Reviewed by Gustavo Noronha Silva.
624
625         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
626
627         * gtk/jhbuild-optional.modules:
628
629 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
630
631         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
632         https://bugs.webkit.org/show_bug.cgi?id=89875
633
634         Reviewed by Maciej Stachowiak.
635
636         Add unit tests to verify if the handling of the open, openat, creat syscall
637         is being done right. We check if the Read/Write/ReadAndWrite permissions
638         are respected, if the canonical path is being resolved and if
639         the permissions are falling back to the topmost parent directory with a
640         policy set when the directory being opened has no policy.
641
642         We also test if any attempt of blocking SIGSYS is silently ignored.
643         SIGSYS cannot be blocked because in it's handler is where we hook
644         syscalls to the broker process.
645
646         Also added libseccomp to EFL's jhbuild to make the life of developers
647         willing to help easier.
648
649         * Scripts/webkitperl/FeatureList.pm:
650         * TestWebKitAPI/PlatformEfl.cmake:
651         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
652         (TestWebKitAPI):
653         (SeccompEnvironment):
654         (TestWebKitAPI::SeccompEnvironment::SetUp):
655         (TestWebKitAPI::SeccompEnvironment::TearDown):
656         (TestWebKitAPI::dummyHandler):
657         (TestWebKitAPI::TEST):
658         (TestWebKitAPI::stressTest):
659         * efl/jhbuild.modules:
660         * qmake/mkspecs/features/features.pri:
661
662 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
663
664         REGRESSION: Autocorrection doesn't work in DumpRenderTree
665         https://bugs.webkit.org/show_bug.cgi?id=113846
666
667         Reviewed by Alexey Proskuryakov.
668
669         The problem was that we were replacing NSSpellCheck's dictionary with our own
670         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
671
672         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
673         and "would" respectively in DumpRenderTree.
674
675         * DumpRenderTree/mac/DumpRenderTree.mm:
676         (resetDefaultsToConsistentValues):
677
678 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
679
680         Remove the gyp files for Tools
681         https://bugs.webkit.org/show_bug.cgi?id=114248
682
683         Reviewed by Ryosuke Niwa.
684
685         * DumpRenderTree/DumpRenderTree.gyp: Removed.
686         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
687         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
688         * DumpRenderTree/DumpRenderTree.gypi: Removed.
689         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
690         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
691         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
692         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
693
694 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
695
696         WKR (new-commit-bot) is too slow
697         https://bugs.webkit.org/show_bug.cgi?id=110087
698
699         Reviewed by Geoffrey Garen.
700
701         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
702         Just run "svn log -r <revision>" instead to cut down the delay.
703
704         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
705
706         * Scripts/webkitpy/tool/commands/newcommitbot.py:
707         (NewCommitBot):
708         (NewCommitBot.next_work_item):
709         (NewCommitBot._is_empty_log):
710         (NewCommitBot._update_checkout):
711
712 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
713
714         Build fix. Can't remove appendCustomBuildFlags.
715
716         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
717         (appendCustomBuildFlags):
718
719 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
720
721         Remove Chromium builders from build.webkit.org
722         https://bugs.webkit.org/show_bug.cgi?id=113990
723
724         Reviewed by Benjamin Poulain.
725
726         Removed.
727
728         * BuildSlaveSupport/build.webkit.org-config/config.json:
729         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
730         (InstallGtkDependencies):
731         (RunUnitTests.start):
732         (RunWebKit2Tests.start):
733         (Factory.__init__):
734         (unitTestsSupported):
735         (TestFactory.__init__):
736         (BuildAndTestFactory.__init__):
737         (BuildAndPerfTestFactory.__init__):
738         (BuildAndPerfTestWebKit2Factory.__init__):
739         (DownloadAndPerfTestFactory.__init__):
740         (loadBuilderConfig):
741         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
742
743 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
744
745         Remove HTML Notification
746         https://bugs.webkit.org/show_bug.cgi?id=114231
747
748         Reviewed by Ryosuke Niwa.
749
750         * qmake/mkspecs/features/features.pri:
751
752 2013-04-08  Glenn Adams  <glenn@skynav.com>
753
754         Remove chromium EWS support, and fix broken test.
755         https://bugs.webkit.org/show_bug.cgi?id=114221
756
757         Reviewed by Ryosuke Niwa.
758
759         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
760         (AbstractChromiumEWS): Removed.
761         (ChromiumLinuxEWS): Removed.
762         (ChromiumLinuxDebugEWS): Removed.
763         (ChromiumWindowsEWS): Removed.
764         (ChromiumAndroidEWS): Removed.
765         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
766         (EarlyWarningSystemTest): Fix misspelled class name.
767         (test_ewses): Fix entry point name to ensure test is run.
768
769 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
770
771         [WIN] Remove WebKit2 source code
772         https://bugs.webkit.org/show_bug.cgi?id=114096
773
774         Reviewed by Anders Carlsson.
775
776         Remove the windows specific parts of the MiniBrowser.
777
778         * MiniBrowser/MiniBrowser.vcproj: Removed.
779         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
780         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
781         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
782         * MiniBrowser/win/BrowserView.cpp: Removed.
783         * MiniBrowser/win/BrowserView.h: Removed.
784         * MiniBrowser/win/BrowserWindow.cpp: Removed.
785         * MiniBrowser/win/BrowserWindow.h: Removed.
786         * MiniBrowser/win/MiniBrowser.cpp: Removed.
787         * MiniBrowser/win/MiniBrowser.h: Removed.
788         * MiniBrowser/win/MiniBrowser.rc: Removed.
789         * MiniBrowser/win/main.cpp: Removed.
790         * MiniBrowser/win/resource.h: Removed.
791         * MiniBrowser/win/stdafx.cpp: Removed.
792         * MiniBrowser/win/stdafx.h: Removed.
793
794 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
795
796         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
797
798         * Scripts/webkitpy/common/config/irc.py:
799
800 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
801
802         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
803         https://bugs.webkit.org/show_bug.cgi?id=113139
804
805         Reviewed by Anders Carlsson.
806
807         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
808         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
809         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
810         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
811         (ToStringAndValueOfObject):
812         (ToStringAndValueOfObject::ToStringAndValueOfObject):
813         (ScriptableObject):
814         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
815         (ToStringAndValueOfObject::ScriptableObject::invoke):
816         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
817         (ToStringAndValueOfObject::NPP_GetValue):
818         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
819         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
820         * GNUmakefile.am:
821
822 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
823
824         [GTK] Bump gnome-themes-standard to 3.6.0
825         https://bugs.webkit.org/show_bug.cgi?id=114155
826
827         Reviewed by Martin Robinson.
828
829         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
830         dependency of gnome-themes-standard accordingly.
831
832 2013-04-08  David Levin  <levin@chromium.org>
833
834         Remove my watchlist entries.
835         https://bugs.webkit.org/show_bug.cgi?id=114180
836
837         Reviewed by Adam Barth.
838
839         * Scripts/webkitpy/common/config/committers.py:
840         * Scripts/webkitpy/common/config/watchlist:
841
842 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
843
844         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
845         https://bugs.webkit.org/show_bug.cgi?id=114161
846
847         Reviewed by Gyuyoung Kim.
848
849         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
850         as it is crashing due to Bug 111074.
851
852         * TestWebKitAPI/PlatformEfl.cmake:
853
854 2013-04-07  David Kilzer  <ddkilzer@apple.com>
855
856         Remove the rest of SVG_DOM_OBJC_BINDINGS
857         <http://webkit.org/b/114112>
858
859         Reviewed by Geoffrey Garen.
860
861         * Scripts/webkitperl/FeatureList.pm:
862         - Remove --svg-dom-objc-bindings switch.
863         * qmake/mkspecs/features/features.pri:
864         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
865
866 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
867
868         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
869         https://bugs.webkit.org/show_bug.cgi?id=114089
870
871         Reviewed by Chris Fleizach.
872
873         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
874         * DumpRenderTree/AccessibilityController.cpp:
875         * DumpRenderTree/AccessibilityUIElement.cpp:
876         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
877         (DumpRenderTreeChrome::DumpRenderTreeChrome):
878         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
879         (DumpRenderTreeChrome):
880
881 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
882
883         Build fix after r147857, remove remaining USE(JSC) guards.
884
885         Unreviewed.
886
887         * DumpRenderTree/config.h:
888         * TestWebKitAPI/config.h:
889         * WebKitTestRunner/config.h:
890
891 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
892
893         Rename sheriffbot to webkitbot
894         https://bugs.webkit.org/show_bug.cgi?id=114109
895
896         Reviewed by Benjamin Poulain.
897
898         Renamed since sheriffbot will be used in Blink.
899
900         * Scripts/webkitpy/tool/commands/sheriffbot.py:
901         (SheriffBot):
902         (SheriffBot.begin_work_queue):
903
904 2013-04-06  Oliver Hunt  <oliver@apple.com>
905
906         Unify the many and varied stack trace mechanisms, and make the result sane.
907         https://bugs.webkit.org/show_bug.cgi?id=114072
908
909         Reviewed by Filip Pizlo.
910
911         The commandline jsc executable no longer requires arguments, so
912         I've made run-jsc work without them.
913
914         * Scripts/run-jsc:
915
916 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
917
918         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
919         https://bugs.webkit.org/show_bug.cgi?id=114086
920
921         Reviewed by Tim Horton.
922
923         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
924
925 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
926
927         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
928         https://bugs.webkit.org/show_bug.cgi?id=114083
929
930         Reviewed by Ryosuke Niwa.
931
932         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
933         in TestWebKitAPI and WebKitTestRunner.
934
935         * TestWebKitAPI/config.h:
936         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
937         (TestWebKitAPI::InjectedBundleController::platformInitialize):
938         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
939         (WTR::InjectedBundle::platformInitialize):
940
941 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
942
943         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
944         https://bugs.webkit.org/show_bug.cgi?id=114094
945
946         Reviewed by Anders Carlsson.
947
948         * Scripts/run-jsc:
949
950 2013-04-05  Ojan Vafai  <ojan@chromium.org>
951
952         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
953         https://bugs.webkit.org/show_bug.cgi?id=114080
954
955         Reviewed by Ryosuke Niwa.
956
957         This way, the WebKit and Blink dashboard code can change as appropriate without
958         needing to consider the other project's needs. This still doesn't update the
959         buildbots to upload to the new location, or the dashboard code to pull the
960         results.json files from the new location, but it at least allows for changing the
961         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
962
963         * TestResultServer/app.yaml:
964
965 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
966
967         Re-enable testing on the commit queue
968         https://bugs.webkit.org/show_bug.cgi?id=114078
969
970         Reviewed by Darin Adler.
971
972         Re-enabled the feature and the associated tests.
973
974         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
975         (CommitQueueTask.run):
976         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
977         (CommitQueueTaskTest._run_through_task):
978         * Scripts/webkitpy/tool/commands/queues_unittest.py:
979         (CommitQueueTest._mock_test_result):
980
981 2013-04-05  Oliver Hunt  <oliver@apple.com>
982
983         Unify the many and varied stack trace mechanisms, and make the result sane.
984         https://bugs.webkit.org/show_bug.cgi?id=114072
985
986         Reviewed by Filip Pizlo.
987
988         The commandline jsc executable no longer requires arguments, so
989         I've made run-jsc work without them.
990
991         * Scripts/run-jsc:
992
993 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
994
995         AX: Make SVG Group containers accessible elements
996         https://bugs.webkit.org/show_bug.cgi?id=113939
997
998         Reviewed by Simon Fraser.
999
1000         Implement axController.elementAtPoint for iOS.
1001         Implement a correct version of clickPoint for iOS.
1002
1003         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1004         (AccessibilityController::elementAtPoint):
1005         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1006         (AccessibilityUIElement::clickPointX):
1007         (AccessibilityUIElement::clickPointY):
1008
1009 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1010
1011         Unreviewed, rolling out r147773 and r147774.
1012         http://trac.webkit.org/changeset/147773
1013         http://trac.webkit.org/changeset/147774
1014         https://bugs.webkit.org/show_bug.cgi?id=114056
1015
1016         Causing some exceptions on AppEngine I don't understand
1017         (Requested by rniwa on #webkit).
1018
1019         * QueueStatusServer/config/queues.py:
1020         * QueueStatusServer/model/queues.py:
1021         (Queue.short_name):
1022         (Queue.display_name):
1023         * QueueStatusServer/model/queues_unittest.py:
1024         (QueueTest.test_short_name):
1025         (QueueTest.test_display_name):
1026         (QueueTest.test_name_with_underscores):
1027
1028 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
1029
1030         Fixed run-bindings-tests by removing V8
1031         https://bugs.webkit.org/show_bug.cgi?id=114053
1032
1033         Reviewed by Benjamin Poulain.
1034
1035         * Scripts/run-bindings-tests:
1036         (main):
1037
1038 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1039
1040         Build fix.
1041
1042         * QueueStatusServer/model/queues.py:
1043         (Queue.short_name):
1044         (Queue.display_name):
1045
1046 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1047
1048         Remove Chromium EWS bots from the queue status server
1049         https://bugs.webkit.org/show_bug.cgi?id=113988
1050
1051         Reviewed by Benjamin Poulain.
1052
1053         Removed Chromium EWS bots.
1054
1055         * QueueStatusServer/config/queues.py:
1056         * QueueStatusServer/model/queues.py:
1057         (Queue.short_name):
1058         (Queue.display_name):
1059         * QueueStatusServer/model/queues_unittest.py:
1060         (QueueTest.test_short_name):
1061         (QueueTest.test_display_name):
1062         (QueueTest.test_name_with_underscores):
1063
1064 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1065
1066         [EFL] Enable indexed database
1067         https://bugs.webkit.org/show_bug.cgi?id=107248
1068
1069         Reviewed by Alexis Menard.
1070
1071         * Scripts/webkitperl/FeatureList.pm:
1072
1073 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
1074
1075         Remove vestiges of Chromium bits from watchlists.
1076         https://bugs.webkit.org/show_bug.cgi?id=114047
1077
1078         Reviewed by Ryosuke Niwa.
1079
1080         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
1081
1082 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1083
1084         Add James Craig to the contributors list.
1085
1086         * Scripts/webkitpy/common/config/committers.py:
1087
1088 2013-04-04  Kent Tamura  <tkent@chromium.org>
1089
1090         Remove ChromiumPublicApi pattern, and cc/message rules for it.
1091
1092         * Scripts/webkitpy/common/config/watchlist:
1093
1094 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1095
1096         Temporarily disable the Python unittests broken by the commit queue not running layout tests
1097         https://bugs.webkit.org/show_bug.cgi?id=113997
1098
1099         Reviewed by Ryosuke Niwa.
1100
1101         Disable the tests until Ryosuke gets the time and hardware to have
1102         a testing commit-queue.
1103
1104         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1105         (CommitQueueTaskTest):
1106         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1107         (CommitQueueTest):
1108
1109 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1110
1111         Remove Chromium builders from build.webkit.org
1112         https://bugs.webkit.org/show_bug.cgi?id=113990
1113
1114         Reviewed by Benjamin Poulain.
1115
1116         Land the part to disable triggering of Chromium builders first so that we may start
1117         deleting more Chromium code that breaks the update step.
1118
1119         * BuildSlaveSupport/build.webkit.org-config/config.json:
1120
1121 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1122
1123         Remove Chromium's DumpRenderTree
1124         https://bugs.webkit.org/show_bug.cgi?id=113989
1125
1126         Reviewed by Kent Tamura.
1127
1128         On second thought, let's not go to Camelot. It is a silly place.
1129
1130         * DumpRenderTree/mac/DumpRenderTree.mm:
1131         (resetDefaultsToConsistentValues):
1132
1133 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1134
1135         Nixed the defunct chromium folder from DumpRenderTree
1136         https://bugs.webkit.org/show_bug.cgi?id=113993
1137
1138         Reviewed by Ryosuke Niwa.
1139
1140         * DumpRenderTree/chromium: Removed.
1141         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1142         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1143         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1144         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1145         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1146         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1147         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1148         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1149         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1150         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1151         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1152         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1153         * DumpRenderTree/chromium/Task.cpp: Removed.
1154         * DumpRenderTree/chromium/Task.h: Removed.
1155         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1156         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1157         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1158         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1159         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1160         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1161         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1162         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1163         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1164         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1165         * DumpRenderTree/chromium/TestRunner: Removed.
1166         * DumpRenderTree/chromium/TestRunner/public: Removed.
1167         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1168         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1169         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1170         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1171         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1172         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1173         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1174         * DumpRenderTree/chromium/TestRunner/src: Removed.
1175         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1176         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1177         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1178         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1179         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1180         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1181         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1182         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1183         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1184         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1185         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1186         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1187         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1188         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1189         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1190         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1191         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1192         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
1193         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
1194         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
1195         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
1196         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
1197         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
1198         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1199         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1200         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1201         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1202         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1203         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1204         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1205         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1206         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1207         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1208         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1209         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1210         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1211         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1212         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1213         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1214         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1215         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1216         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1217         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1218         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1219         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1220         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1221         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1222         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1223         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1224         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1225         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1226         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1227         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1228         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1229         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1230         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1231         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1232         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1233         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1234         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1235         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1236         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1237         * DumpRenderTree/chromium/TestShell.h: Removed.
1238         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1239         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1240         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1241         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1242         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1243         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1244         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1245         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1246         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1247         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1248         * DumpRenderTree/chromium/config.h: Removed.
1249         * DumpRenderTree/chromium/fonts.conf: Removed.
1250
1251 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1252
1253         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1254
1255         Rubber stamped by Benjamin Poulain.
1256
1257         * RebaselineQueueServer: Removed.
1258         * RebaselineQueueServer/app.yaml: Removed.
1259         * RebaselineQueueServer/handlers: Removed.
1260         * RebaselineQueueServer/handlers/__init__.py: Removed.
1261         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1262         * RebaselineQueueServer/handlers/pages.py: Removed.
1263         * RebaselineQueueServer/index.yaml: Removed.
1264         * RebaselineQueueServer/main.py: Removed.
1265         * RebaselineQueueServer/model: Removed.
1266         * RebaselineQueueServer/model/__init__.py: Removed.
1267         * RebaselineQueueServer/model/queueentry.py: Removed.
1268         * RebaselineQueueServer/static: Removed.
1269         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1270         * RebaselineQueueServer/static/styles.css: Removed.
1271         * RebaselineQueueServer/templates: Removed.
1272         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1273         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1274         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1275         * RebaselineQueueServer/templates/home.html: Removed.
1276
1277 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1278
1279         Fix setup-commit-queue and temporarily disable testing on commit-queue
1280         https://bugs.webkit.org/show_bug.cgi?id=113979
1281
1282         Reviewed by Benjamin Poulain.
1283
1284         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1285         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1286
1287         * EWSTools/setup-commit-queue.sh:
1288         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1289         (CommitQueueTask.run):
1290
1291 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1292
1293         temporarily make flakiness dashboard work again webkit.org bots
1294         https://bugs.webkit.org/show_bug.cgi?id=113972
1295
1296         Reviewed by Ojan Vafai.
1297
1298         This patch disables the chromium.org layout test bots TestExpectations
1299         parsing temporarily until we can work out the right way to split into
1300         two instances for webkit.org and chromium.org and figure out which
1301         code to delete where :).
1302
1303         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1304
1305 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1306
1307         Fix webkitpy tests after r147678.
1308
1309         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1310         (CommitQueueTest.test_commit_queue):
1311         (test_manual_reject_during_processing):
1312
1313 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1314
1315         The commit queue should use Mac MountainLion port
1316         https://bugs.webkit.org/show_bug.cgi?id=113971
1317
1318         Reviewed by Lucas Forschler.
1319
1320         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1321         * Scripts/webkitpy/tool/commands/queues.py:
1322         (CommitQueue):
1323
1324 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1325
1326         turn off running tests on chromium linux EWS bots
1327         https://bugs.webkit.org/show_bug.cgi?id=113959
1328
1329         Reviewed by Geoffrey Garen.
1330
1331         Now that the Chromium port is no longer being maintained
1332         there's little point in running the tests. Soon we should
1333         just shut this bot off altogether.
1334
1335         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1336         (ChromiumLinuxEWS):
1337
1338 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1339
1340         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1341
1342         * Scripts/webkitpy/common/config/watchlist:
1343
1344 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1345
1346         Indentation fix to get webkit-patch working again after r147625
1347
1348         Unreviewed.
1349
1350         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1351         (MacEWS):
1352         (MacWK2EWS):
1353
1354 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1355
1356         Turn tests back on for Mac WK1/WK2 EWS.
1357         
1358         Unreviewed.
1359         
1360         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1361         (MacEWS):
1362         (MacWK2EWS):
1363
1364 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1365
1366         [GTK][WK2] MiniBrowser custom URI scheme support
1367         https://bugs.webkit.org/show_bug.cgi?id=112419
1368
1369         Reviewed by Carlos Garcia Campos.
1370
1371         Add support for about URIs in MiniBrowser. An example about page is show
1372         with URI "about:minibrowser", the rest of the cases it will show a
1373         proper message explaining that the about page didn't exist.
1374
1375         Internally it uses "minibrowser-about" prefix instead of "about", but
1376         from the user point of view it works with "about" prefix.
1377
1378         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1379         (getInternalURI): Method to convert URIs from "about" prefix to
1380         "minibrowser-about".
1381         (getExternalURI): Opposite method.
1382         (webViewURIChanged): Use "about" prefix to show the URI to users.
1383         (webViewEnterFullScreen): Ditto.
1384         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1385         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1386         (aboutURISchemeRequestCallback): Callback to manage about calls.
1387         (main): Register the URI scheme to manage about URIs.
1388
1389 2013-04-03  Roger Fong  <roger_fong@apple.com>
1390
1391         Re-enable WinEWS tests.
1392
1393         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1394         (WinEWS):
1395
1396 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1397
1398         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1399         https://bugs.webkit.org/show_bug.cgi?id=113883
1400
1401         Reviewed by Martin Robinson.
1402
1403         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1404         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1405         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1406
1407 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1408
1409         [GTK] Include Pango in jhbuild-optional.modules
1410         https://bugs.webkit.org/show_bug.cgi?id=113878
1411
1412         Reviewed by Martin Robinson.
1413
1414         Since r147547 Pango 1.32.0 is required. Including the module in the
1415         JHBuild optional moduleset.
1416
1417         * gtk/jhbuild-optional.modules: Add Pango module.
1418
1419 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1420
1421         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1422         https://bugs.webkit.org/show_bug.cgi?id=113864
1423
1424         Moving setDefersLoading from TestRunnerQt to TestRunner
1425         requires access to the non-Qt TestRunner.
1426         As long as we instantiate both TestRunner and TestRunnerQt,
1427         we need a separate getter for the non-Qt TestRunner instance.
1428
1429         Reviewed by Simon Hausmann.
1430
1431         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1432         (WebPage::resetSettings):
1433         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1434         (DumpRenderTree::jscTestRunner):
1435         * DumpRenderTree/qt/TestRunnerQt.cpp:
1436         (TestRunner::setDefersLoading):
1437             Moving setDefersLoading from TestRunnerQt
1438             to TestRunner.
1439         * DumpRenderTree/qt/TestRunnerQt.h:
1440         (TestRunnerQt):
1441
1442 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1443
1444         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1445         https://bugs.webkit.org/show_bug.cgi?id=104779
1446
1447         Reviewed by Carlos Garcia Campos.
1448
1449         * Scripts/run-gtk-tests:
1450         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1451         passing in current trunk.
1452
1453 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1454
1455         Fix HAVE(QTTESTSUPPORT) logic
1456
1457         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1458         resulting in HAVE(QTTESTSUPPORT) never being true.
1459         Move that logic down in sanitizeFeatures.
1460
1461         Rubber-stamped by Tor Arne Vestbø.
1462
1463         * qmake/mkspecs/features/features.prf:
1464
1465 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1466
1467         [GTK] Bump required versions of some dependencies
1468         https://bugs.webkit.org/show_bug.cgi?id=113282
1469
1470         Reviewed by Martin Robinson.
1471
1472         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1473
1474 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1475
1476         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1477         https://bugs.webkit.org/show_bug.cgi?id=113809
1478
1479         Reviewed by Philippe Normand.
1480
1481         Newer Linux kernels have removed some deprecated macros from v4l2
1482         headers, causing gst-plugins-good's build to break. We don't need it
1483         right now, so just disable it.
1484
1485         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1486
1487 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1488
1489         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1490         https://bugs.webkit.org/show_bug.cgi?id=113535
1491
1492         Reviewed by Simon Hausmann.
1493
1494         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1495
1496         * qmake/mkspecs/features/features.prf:
1497
1498 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1499
1500         [Qt] Move logic of simple forwarding functions to TestRunner.
1501         https://bugs.webkit.org/show_bug.cgi?id=113863
1502
1503         Reviewed by Simon Hausmann.
1504
1505         * DumpRenderTree/qt/TestRunnerQt.cpp:
1506         (TestRunner::setTextDirection):
1507         (TestRunner::goBack):
1508         (TestRunner::evaluateScriptInIsolatedWorld):
1509         (TestRunner::addUserStyleSheet):
1510         * DumpRenderTree/qt/TestRunnerQt.h:
1511         (TestRunnerQt):
1512
1513 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1514
1515         [Qt] Disable media support using QuickTime if deployment target != SDK
1516
1517         We link to a single libWebKitSystemInterface static lib, so unless the
1518         deployment target matches the SDK let's not pretend like we'll be able
1519         to run on anything lower than the SDK version.
1520
1521         Reviewed by Simon Hausmann.
1522
1523         * qmake/mkspecs/features/features.prf:
1524
1525 2013-04-02  James Craig  <james@cookiecrook.com>
1526
1527         AXRoleDescripton for DL is "list"; should be "description list"
1528         https://bugs.webkit.org/show_bug.cgi?id=111665
1529
1530         Reviewed by Chris Fleizach.
1531
1532         Defining the role and description strings.
1533
1534         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1535
1536 2013-04-02  Roger Fong  <roger_fong@apple.com>
1537
1538         Unreviewed. Disable running tests on Win EWS queue.
1539
1540         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1541         (WinEWS):
1542
1543 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1544
1545         Disable running tests on the MAC WK2 EWS queue.
1546         
1547         Unreviewed.
1548         
1549         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1550         (MacWK2EWS):
1551
1552 2013-04-02  Julie Parent  <jparent@chromium.org>
1553
1554         Dashboard refactor: Move dashboard specific history related features to History.
1555         https://bugs.webkit.org/show_bug.cgi?id=113717
1556
1557         Reviewed by Ojan Vafai.
1558         
1559         Each dashboard now creates its own History object, with a custom
1560         configuration. This changes from just overriding global functions
1561         to passing in callbacks for generatePage, handleValidHashParameter,
1562         and handleQueryParameterChange. Same with passing in defaultStateValues
1563         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1564         variables.
1565         
1566         All functions related to these features are now (mostly) private
1567         function on History. 
1568         
1569         Loader no longer needs a loadingComplete callback, since it can just
1570         initialize the history object itself.
1571
1572         * TestResultServer/static-dashboards/aggregate_results.js:
1573         (handleValidHashParameter):
1574         * TestResultServer/static-dashboards/dashboard_base.js:
1575         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1576         (generatePage):
1577         (.switch.return):
1578         (handleQueryParameterChange):
1579         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1580         (resetGlobals):
1581         * TestResultServer/static-dashboards/history.js:
1582         (.):
1583         * TestResultServer/static-dashboards/loader.js:
1584         (.):
1585         * TestResultServer/static-dashboards/loader_unittests.js:
1586         * TestResultServer/static-dashboards/timeline_explorer.js:
1587         (generatePage):
1588         (initCurrentBuilderTestResults):
1589         * TestResultServer/static-dashboards/treemap.js:
1590         (generatePage):
1591         (.switch.return):
1592         (handleQueryParameterChange):
1593
1594 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1595
1596         Unreviewed, rolling out r147401.
1597         http://trac.webkit.org/changeset/147401
1598         https://bugs.webkit.org/show_bug.cgi?id=113767
1599
1600         The patch makes it extremely hard to set up the dependencies
1601         properly on the GTK builders (Requested by zdobersek on
1602         #webkit).
1603
1604         * gtk/jhbuild.modules:
1605
1606 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1607
1608         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1609         https://bugs.webkit.org/show_bug.cgi?id=113382
1610
1611         Reviewed by Gyuyoung Kim.
1612
1613         Do not show the empty tooltip box if the text is null.
1614
1615         * MiniBrowser/efl/main.c:
1616         (popup_menu_populate):
1617
1618 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1619
1620         [GTK] Bump required versions of some dependencies
1621         https://bugs.webkit.org/show_bug.cgi?id=113282
1622
1623         Reviewed by Martin Robinson.
1624
1625         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1626
1627 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1628
1629         Unreviewed, rolling out r147319.
1630         http://trac.webkit.org/changeset/147319
1631         https://bugs.webkit.org/show_bug.cgi?id=113707
1632
1633         The unit test is still failing on the buildbot (Requested by
1634         zdobersek on #webkit).
1635
1636         * Scripts/run-gtk-tests:
1637         (TestRunner):
1638
1639 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1640
1641         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1642         https://bugs.webkit.org/show_bug.cgi?id=104779
1643
1644         Reviewed by Carlos Garcia Campos.
1645
1646         * Scripts/run-gtk-tests:
1647         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1648         passing in current trunk.
1649
1650 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1651
1652         Unreviewed, rolling out r147289.
1653         http://trac.webkit.org/changeset/147289
1654         https://bugs.webkit.org/show_bug.cgi?id=113678
1655
1656         broke Win7 (dbg) build (Requested by shinyak|gardener on
1657         #webkit).
1658
1659         * DumpRenderTree/DumpRenderTree.gypi:
1660         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1661         (WebTestRunner):
1662         (WebUserMediaClientMock):
1663         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1664         (WebTestRunner::WebUserMediaClientMock::taskList):
1665         * Scripts/webkitpy/style/checkers/cpp.py:
1666         (check_function_definition):
1667
1668 2013-03-31  Adam Barth  <abarth@webkit.org>
1669
1670         configure-svn-config.sh fails
1671         https://codereview.chromium.org/13392007/
1672
1673         Reviewed by Eric Seidel.
1674
1675         This script was trying to use "svn checkout" to dowload a file from
1676         svn.webkit.org, but "svn checkout" only works with directories.
1677         Instead, we should use "svn export".
1678
1679         * EWSTools/configure-svn-config.sh:
1680
1681 2013-03-31  Wei Jia  <wjia@chromium.org>
1682
1683         Allow WebUserMediaClientMock to be used by client
1684         https://bugs.webkit.org/show_bug.cgi?id=113633
1685
1686         Reviewed by Adam Barth.
1687
1688         Export WebUserMediaClientMock.
1689         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1690
1691         * DumpRenderTree/DumpRenderTree.gypi:
1692         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1693         (WebUserMediaClientMock):
1694         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1695         * Scripts/webkitpy/style/checkers/cpp.py:
1696         (check_function_definition):
1697
1698 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1699
1700         Expose FeatureObserver data to WebKit clients
1701         https://bugs.webkit.org/show_bug.cgi?id=113613
1702
1703         Reviewed by Sam Weinig.
1704
1705         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1706         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1707
1708 2013-03-29  Greg Hughes  <ghughes@apple.com>
1709
1710         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1711         https://bugs.webkit.org/show_bug.cgi?id=112276
1712
1713         Reviewed by Chris Fleizach.
1714
1715         Added support to test accessibility search predicates with multiple keys.  
1716
1717         * DumpRenderTree/AccessibilityUIElement.cpp:
1718         (uiElementForSearchPredicateCallback):
1719         * DumpRenderTree/AccessibilityUIElement.h:
1720         (AccessibilityUIElement):
1721         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1722         (AccessibilityUIElement::uiElementForSearchPredicate):
1723         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1724         (AccessibilityUIElement::uiElementForSearchPredicate):
1725         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1726         (AccessibilityUIElement::uiElementForSearchPredicate):
1727         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1728         (AccessibilityUIElement::uiElementForSearchPredicate):
1729         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1730         (AccessibilityUIElement::uiElementForSearchPredicate):
1731         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1732         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1733         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1734         (AccessibilityUIElement):
1735         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1736         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1737         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1738         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1739         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1740
1741 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1742
1743         Fix a typo in r147147 to fix Mac EWS.
1744
1745         * Scripts/webkitpy/tool/commands/queues.py:
1746         (PatchProcessingQueue._new_port_name_from_old):
1747
1748 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1749
1750         [EFL] Build break with latest EFL libraries after r146265
1751         https://bugs.webkit.org/show_bug.cgi?id=113558
1752
1753         Unreviewed build fix.
1754
1755         * TestWebKitAPI/PlatformWebView.h:
1756         * WebKitTestRunner/PlatformWebView.h:
1757
1758 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1759
1760         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1761
1762         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1763         in libgcrypt build.
1764
1765 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1766
1767         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1768
1769         Unreviewed.
1770
1771         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1772         (MacEWS):
1773
1774 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1775
1776         Use the right OS name on Mac EWS instead of mac-future.
1777
1778         Rubber-stamped by Dirk Pranke.
1779
1780         * Scripts/webkitpy/tool/commands/queues.py:
1781         (PatchProcessingQueue._new_port_name_from_old):
1782         (PatchProcessingQueue.begin_work_queue):
1783         (PatchProcessingQueue._upload_results_archive_for_patch):
1784
1785 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1786
1787         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1788         https://bugs.webkit.org/show_bug.cgi?id=112546
1789
1790         Reviewed by Martin Robinson.
1791
1792         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1793         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1794
1795 2013-03-28  Ming Xie  <mxie@blackberry.com>
1796
1797         [BlackBerry] Committer Email Updates
1798         https://bugs.webkit.org/show_bug.cgi?id=113435
1799
1800         Reviewed by Rob Buis.
1801
1802         Add the @blackberry.com email address for all our BlackBerry
1803         WebKit committers. This is the first step for our email address
1804         migration.
1805
1806         * Scripts/webkitpy/common/config/committers.py:
1807
1808 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1809
1810         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1811         https://bugs.webkit.org/show_bug.cgi?id=113508
1812
1813         Reviewed by Martin Robinson.
1814
1815         Prevent the GStreamer plugin scanner to load system-wide
1816         plugins. Only the ones built in JHBuild should be loaded and used
1817         at runtime.
1818
1819         * efl/jhbuildrc:
1820         * gtk/jhbuildrc:
1821
1822 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1823
1824         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1825         https://bugs.webkit.org/show_bug.cgi?id=113386
1826
1827         Reviewed by Carlos Garcia Campos.
1828
1829         * Scripts/webkitdirs.pm:
1830         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1831         version to 3.0. Reflect this change so the builtDylibPathForName
1832         function doesn't fail to report the library as found.
1833
1834 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1835
1836         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1837         https://bugs.webkit.org/show_bug.cgi?id=113484
1838
1839         Unreviewed build fix.
1840
1841         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1842
1843         * TestWebKitAPI/CMakeLists.txt:
1844         * WebKitTestRunner/CMakeLists.txt:
1845
1846 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1847
1848         Revision for the internal jhbuild is too old
1849         https://bugs.webkit.org/show_bug.cgi?id=113324
1850
1851         Reviewed by Martin Robinson.
1852
1853         Update the minimum required version to a point where jhbuild won't
1854         fail installing packages when trying to remove a symlink to a directory.
1855
1856         * jhbuild/jhbuild-wrapper: Updated revision.
1857
1858 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1859
1860         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1861         https://bugs.webkit.org/show_bug.cgi?id=113203
1862
1863         Reviewed by Philippe Normand.
1864
1865         We build our libsoup without GNOME support. gst-plugins-good does separate
1866         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1867         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1868         build failures as the headers of those diverge. We do not use souphttpsrc, so
1869         disable it when building gst-plugins-good.
1870
1871         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1872
1873 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1874
1875         Build fix after r146852. Please another reference to the Lion leaks builder.
1876
1877         * BuildSlaveSupport/build.webkit.org-config/config.json:
1878
1879 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1880
1881         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1882         https://bugs.webkit.org/show_bug.cgi?id=113421
1883
1884         Reviewed by Dirk Pranke.
1885
1886         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1887         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1888         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1889         in the GTK-specific TestExpectations files.
1890
1891         To avoid this only enable the warnings only when not using WKTR.
1892
1893         * Scripts/webkitpy/layout_tests/port/gtk.py:
1894         (GtkPort.warn_if_bug_missing_in_test_expectations):
1895
1896 2013-03-27  Antti Koivisto  <antti@apple.com>
1897
1898         Fix Zalan's email.
1899
1900         * Scripts/webkitpy/common/config/committers.py:
1901
1902 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1903
1904         master.cfg cleanup
1905         https://bugs.webkit.org/show_bug.cgi?id=113195
1906
1907         Reviewed by Ryosuke Niwa.
1908
1909         * BuildSlaveSupport/build.webkit.org-config/config.json:
1910         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1911
1912 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1913
1914         master.cfg fine-tuning for Qt Mountain Lion Release bot
1915         https://bugs.webkit.org/show_bug.cgi?id=113191
1916
1917         Reviewed by Ryosuke Niwa.
1918
1919         * BuildSlaveSupport/build.webkit.org-config/config.json:
1920           - Rename the slave due to its location change.
1921           - Update the platform of the slave.
1922         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1923         (RunQtAPITests): Enable running WK2 API tests on Qt.
1924         (RunQtAPITests.start):
1925         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1926         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1927
1928 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1929
1930         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1931         https://bugs.webkit.org/show_bug.cgi?id=113403
1932
1933         Reviewed by Kenneth Rohde Christiansen.
1934
1935         As of Evas 1.7.5, when Wayland is detected on the system, support for
1936         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1937         The code, however, seems to depend on a few other flags which must be
1938         explicitly enabled.
1939
1940         If those additional GL-related options are passed, we end up
1941         having issues on the WebKit side, so disable Wayland support for
1942         now.
1943
1944         * efl/jhbuild.modules:
1945
1946 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1947
1948         Unreviewed, rolling out r146864.
1949         http://trac.webkit.org/changeset/146864
1950         https://bugs.webkit.org/show_bug.cgi?id=113391
1951
1952         causes crashes on Wk2 EFL release bot (Requested by drott on
1953         #webkit).
1954
1955         * Scripts/webkitperl/FeatureList.pm:
1956
1957 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1958
1959         [jhbuild] Correctly specify an alternate number of make jobs.
1960         https://bugs.webkit.org/show_bug.cgi?id=113396
1961
1962         Reviewed by Philippe Normand.
1963
1964         So far, we were using the `MAKEFLAGS' environment variable to pass the
1965         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1966         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1967
1968         We now behave more closely to the rest of the WebKit tools by first
1969         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1970         not set, just letting jhbuild itself figure out how many jobs to use.
1971
1972         * efl/jhbuildrc:
1973         * gtk/jhbuildrc:
1974
1975 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1976
1977         [Qt] Remove Qt specific WorkQueueItem definitions.
1978         https://bugs.webkit.org/show_bug.cgi?id=112891
1979
1980         This patch is preparation work for removing
1981         WorkQueue related code from TestRunnerQt and
1982         replacing it with generic TestRunner code.
1983
1984         Reviewed by Benjamin Poulain.
1985
1986         * DumpRenderTree/qt/TestRunnerQt.cpp:
1987         (TestRunnerQt::queueBackNavigation):
1988         (TestRunnerQt::queueForwardNavigation):
1989         (TestRunnerQt::queueLoadHTMLString):
1990         (TestRunnerQt::queueReload):
1991         (TestRunnerQt::queueLoadingScript):
1992         (TestRunnerQt::queueNonLoadingScript):
1993         (TestRunner::queueLoad):
1994         * DumpRenderTree/qt/TestRunnerQt.h:
1995         (TestRunnerQt):
1996         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1997         (LoadItem::invoke):
1998         (LoadHTMLStringItem::invoke):
1999         (LoadAlternateHTMLStringItem::invoke):
2000         (ReloadItem::invoke):
2001         (ScriptItem::invoke):
2002         (BackForwardItem::invoke):
2003         * DumpRenderTree/qt/WorkQueueItemQt.h:
2004         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2005         (LoadAlternateHTMLStringItem):
2006
2007 2013-03-26  Julie Parent  <jparent@chromium.org>
2008
2009         Flakiness dashboard: simplify logic around which tests to show.
2010         https://bugs.webkit.org/show_bug.cgi?id=113250
2011
2012         Reviewed by Ojan Vafai.
2013         
2014         The different filters for showing results are only used for layout
2015         tests, otherwise, we show everything.
2016         
2017         Change the defaults to false (what layout tests used), and only
2018         look at the values when viewing layout tests.
2019
2020         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2021         (htmlForTestsWithExpectationsButNoFailures):
2022         (shouldHideTest):
2023
2024 2013-03-26  Isaac Levy  <ilevy@google.com>
2025
2026         Update bots on test-results.appspot
2027         https://bugs.webkit.org/show_bug.cgi?id=113333
2028
2029         Reviewed by Ojan Vafai.
2030
2031         * TestResultServer/static-dashboards/builders.jsonp:
2032
2033 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2034
2035         Unreviewed GTK gardening.
2036
2037         * Scripts/run-gtk-tests:
2038         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
2039
2040 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2041
2042         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
2043         https://bugs.webkit.org/show_bug.cgi?id=113287
2044
2045         Reviewed by Jocelyn Turcotte.
2046
2047         * Scripts/run-qtwebkit-tests:
2048         (Options.__init__):
2049
2050 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2051
2052         [EFL] Enable IndexedDB by default
2053         https://bugs.webkit.org/show_bug.cgi?id=107248
2054
2055         Reviewed by Laszlo Gombos.
2056
2057         * Scripts/webkitperl/FeatureList.pm:
2058         Enable IndexedDB by default on EFL.
2059
2060 2013-03-26  Alan Cutter  <alancutter@chromium.org>
2061
2062         Sheriffbot should explain rollout failures in a human readable form.
2063         https://bugs.webkit.org/show_bug.cgi?id=107092
2064
2065         Reviewed by Ryosuke Niwa.
2066
2067         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
2068
2069         * Scripts/webkitpy/tool/bot/irc_command.py:
2070         (Rollout._check_diff_failure):
2071         (Rollout.execute):
2072         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2073         (IRCCommandTest.test_rollout):
2074
2075 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2076
2077         Unreviewed GTK gardening.
2078
2079         * Scripts/run-gtk-tests:
2080         (TestRunner): Skipping a failing unit test after r146518.
2081
2082 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2083
2084         Remove Lion leaks builder
2085         https://bugs.webkit.org/show_bug.cgi?id=113252
2086
2087         Reviewed by Andreas Kling.
2088
2089         Removed.
2090
2091         * BuildSlaveSupport/build.webkit.org-config/config.json:
2092
2093 2013-03-25  Kent Tamura  <tkent@chromium.org>
2094
2095         Rename ENABLE_INPUT_TYPE_DATETIME
2096         https://bugs.webkit.org/show_bug.cgi?id=113254
2097
2098         Reviewed by Kentaro Hara.
2099
2100         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
2101         Actually I'd like to remove the code, but we shouldn't remove it yet
2102         because we shipped products with it on some platforms.
2103
2104         * Scripts/webkitperl/FeatureList.pm:
2105         * qmake/mkspecs/features/features.pri:
2106
2107 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2108
2109         Remove one more line that was intended to be removed in r146657.
2110
2111         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2112         (summarize_results):
2113
2114 2013-03-25  Roger Fong  <roger_fong@apple.com>
2115
2116         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2117         Re-enable WinEWS tests.
2118
2119         * Scripts/webkitpy/common/config/ports.py:
2120         (WinPort.run_bindings_tests_command):
2121         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2122         (WinEWS):
2123
2124 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2125
2126         Unreviewed, rolling out r146793.
2127         http://trac.webkit.org/changeset/146793
2128         https://bugs.webkit.org/show_bug.cgi?id=113248
2129
2130         Fix did not work (Requested by rfong on #webkit).
2131
2132         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2133         (WinEWS):
2134
2135 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2136
2137         REGRESSION(r146657): Test failures reported incorrectly
2138         https://bugs.webkit.org/show_bug.cgi?id=113223
2139
2140         Reviewed by Dirk Pranke.
2141
2142         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2143
2144         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2145         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2146
2147         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2148         (Manager.run):
2149
2150         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2151         (RunDetails.__init__):
2152         (summarize_results): Remove the line I intended to remove in r146657.
2153
2154         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2155         (logging_run): Return details instead of the exit code.
2156         (run_and_capture): Ditto.
2157
2158         (RunTest.test_full_results_html):
2159         (RunTest.test_hung_thread):
2160         (RunTest.test_no_tests_found):
2161         (RunTest.test_no_tests_found_2):
2162         (RunTest.test_repeat_each_iterations_num_tests):
2163         (RunTest.test_run_singly_actually_runs_tests):
2164         (RunTest.test_test_list):
2165         (RunTest.test_missing_and_unexpected_results):
2166         (RunTest.test_pixel_test_directories):
2167         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2168         (RunTest.test_crash_with_stderr):
2169         (RunTest.test_no_image_failure_with_image_diff):
2170         (RunTest.test_crash_log):
2171         (RunTest.test_exit_after_n_failures_upload):
2172         (RunTest.test_results_directory_absolute):
2173         (RunTest.test_results_directory_relative):
2174         (RunTest.test_retrying_and_flaky_tests):
2175         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2176         (RunTest.test_retrying_uses_retries_directory):
2177         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2178         (RunTest.test_output_diffs):
2179         (EndToEndTest.test_reftest_with_two_notrefs):
2180         (RebaselineTest.test_reset_results):
2181         (RebaselineTest.test_missing_results):
2182         (RebaselineTest.test_new_baseline):
2183
2184         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2185         (BuildBotPrinter.print_results):
2186         (BuildBotPrinter.print_unexpected_results):
2187         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2188         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2189
2190 2013-03-25  Julie Parent  <jparent@chromium.org>
2191
2192         Dashboard refactor: Move cross dashboard history related code into history.js.
2193         https://bugs.webkit.org/show_bug.cgi?id=113104
2194
2195         Reviewed by Ojan Vafai.
2196
2197         All functions relating to cross dashboard behavior move from being
2198         globals to methods on the history.History object. Names stay the same,
2199         except many are made private, ones that should have been constants now
2200         are, and the long standing TODO to change "currentState" to 
2201         dashboardSpecificState is done.
2202         
2203         We now create a global history object in dashboard_base, as an 
2204         intermediate measure.  Once the dashboard specific code is
2205         added to history, each DB will need to create its own, and this
2206         global will be eliminated.
2207         
2208         * TestResultServer/static-dashboards/aggregate_results.js:
2209         (handleValidHashParameter):
2210         (htmlForBuilder):
2211         (rawValuesHTML):
2212         * TestResultServer/static-dashboards/dashboard_base.js:
2213         (parseDashboardSpecificParameters):
2214         (defaultValue):
2215         (currentBuilderGroupCategory):
2216         (currentBuilderGroupName):
2217         (handleLocationChange):
2218         (expectationsMap):
2219         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2220         (generatePage):
2221         (.switch.return):
2222         (platformAndBuildType):
2223         (individualTests):
2224         (substringList):
2225         (processMissingAndExtraExpectations):
2226         (pathToFailureLog):
2227         (showPopupForBuild):
2228         (htmlForTestsWithExpectationsButNoFailures):
2229         (shouldHideTest):
2230         (isCrossBuilderView):
2231         (tableHeaders):
2232         (htmlForSingleTestRow):
2233         (htmlForTableColumnHeader):
2234         (generatePageForExpectationsUpdate):
2235         (handleUpdate):
2236         (nextUpdate):
2237         (setUpdateIndex):
2238         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2239         (.appendExpectationsItem):
2240         (loadExpectations):
2241         (.dummyNode.onload):
2242         (loadExpectationsLayoutTests):
2243         (appendExpectations):
2244         (htmlForNavBar):
2245         (checkBoxToToggleState):
2246         (linkHTMLToToggleState):
2247         (generatePageForBuilder):
2248         (isInvalidKeyForCrossBuilderView):
2249         (handleQueryParameterChange):
2250         (showLegend):
2251         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2252         (resetGlobals):
2253         (test):
2254         * TestResultServer/static-dashboards/history.js:
2255         (.):
2256         * TestResultServer/static-dashboards/history_unittests.js:
2257         * TestResultServer/static-dashboards/loader.js:
2258         (.):
2259         * TestResultServer/static-dashboards/loader_unittests.js:
2260         * TestResultServer/static-dashboards/timeline_explorer.js:
2261         (generatePage):
2262         (initCurrentBuilderTestResults):
2263         (selectBuild):
2264         (showResultsDelta):
2265         * TestResultServer/static-dashboards/treemap.js:
2266         (generatePage):
2267         (.switch.return):
2268         (handleFocus):
2269         * TestResultServer/static-dashboards/ui.js:
2270
2271 2013-03-25  Roger Fong  <roger_fong@apple.com>
2272
2273         Unreviewed. Enable WinEWS tests again.
2274
2275         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2276         (WinEWS):
2277
2278 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2279
2280         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2281         https://bugs.webkit.org/show_bug.cgi?id=112166
2282
2283         HarfBuzz 0.9.14 merged my patch for icu detection without
2284         pkg-config files, as needed by for example Ubuntu 12.04.
2285         This obsoletes our local workaround. Removed it for GTK and EFL.
2286
2287         Reviewed by Martin Robinson.
2288
2289         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2290         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2291         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2292         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2293
2294 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2295
2296         Unreviewed.  Move self from contributor to committer list.
2297
2298         * Scripts/webkitpy/common/config/committers.py:
2299
2300 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2301
2302         EWS should use a human readable port name when uploading layout test archives
2303         https://bugs.webkit.org/show_bug.cgi?id=113099
2304
2305         Reviewed by Dirk Pranke.
2306
2307         Use new port's object's name() method to report human readable port names.
2308         This will also help us resolving the bug to apply layout test results posted by EWS.
2309
2310         * Scripts/webkitpy/tool/bot/botinfo.py:
2311         (BotInfo.__init__): Take port's name.
2312         (BotInfo.summary_text):
2313
2314         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2315         (BotInfoTest.test_summary_text):
2316
2317         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2318         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2319
2320         * Scripts/webkitpy/tool/commands/queues.py:
2321         (PatchProcessingQueue.__init__): Initialize self._port.
2322         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2323         and use that for the attachment filename and the comment posted.
2324
2325         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2326         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2327         "mac-snowleopard" as expected for TestPort.
2328
2329 2013-03-22  Roger Fong  <roger_fong@apple.com>
2330
2331         Unreviewed. Turn off EWS test on Win again.
2332         The battle continues.
2333
2334         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2335         (WinEWS):
2336
2337 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2338
2339         NRWT: Enable pixel tests when retrying tests
2340         https://bugs.webkit.org/show_bug.cgi?id=112898
2341
2342         Reviewed by Dirk Pranke.
2343
2344         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2345         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2346         if we've forced pixel tests in the retry.
2347         (Manager._run_tests):
2348         (Manager._clean_up_run): Fixed the capitalizations.
2349         (Manager._force_pixel_tests_if_needed): Added.
2350
2351         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2352         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2353         'image_diff_percent' if it doesn't already exist.
2354
2355         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2356         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2357         treat this as a regular regression instead of a flakiness.
2358
2359         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2360         run had image diffs.
2361
2362         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2363         (summarized_results):
2364
2365         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2366         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2367         Also removed some dead code.
2368
2369         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2370         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2371         is set and pixel_tests_enabled is set to false.
2372         (EndToEndTest.test_reftest_with_two_notrefs):
2373
2374 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2375
2376         Make it possible to run layout tests on Retina MBP
2377         https://bugs.webkit.org/show_bug.cgi?id=93673
2378
2379         Reviewed by Ryosuke Niwa.
2380
2381         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2382         windows on 2x machines still run at 1x.
2383
2384         * DumpRenderTree/mac/DumpRenderTree.mm:
2385         (createWebViewAndOffscreenWindow):
2386         Reset the window resolution to 1x on creation.
2387         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2388         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2389         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2390         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2391         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2392         (WTR::PlatformWebView::PlatformWebView):
2393         Add NSWindow details, reset the window resolution to 1x on creation.
2394
2395 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2396
2397         Leak bots shouldn't build
2398         https://bugs.webkit.org/show_bug.cgi?id=112774
2399
2400         Reviewed by Simon Fraser.
2401
2402         Since leak bots use regular debug builds, there is no need to build on these bots.
2403         Simply downloading builds will dramatically improve the cycle time of these bots.
2404
2405         * BuildSlaveSupport/build.webkit.org-config/config.json:
2406         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2407         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2408         TestFactory instead of BuildAndTestFactory.
2409
2410 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2411
2412         [Qt] Fix the TestWebKitAPI build
2413         https://bugs.webkit.org/show_bug.cgi?id=113044
2414
2415         Reviewed by Tor Arne Vestbø.
2416
2417         The generate-forwarding-headers script would only be run
2418         after the targets in InjectedBundle.pri since the second
2419         addStrictSubdirOrderBetween call in
2420         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2421         the derived_sources -> injected_bundle order in SUBDIRS.
2422
2423         Fix it by only moving the dependent target at the end of
2424         SUBDIRS, don't touch its dependency.
2425
2426         * qmake/mkspecs/features/functions.prf:
2427
2428 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2429
2430         [EFL][WK2] View is not focused when fullscreen mode toggled
2431         https://bugs.webkit.org/show_bug.cgi?id=113009
2432
2433         Reviewed by Laszlo Gombos.
2434
2435         Set focus on view when fullscreen mode enabled/disabled
2436         by FullScreen API.
2437
2438         * MiniBrowser/efl/main.c:
2439         (on_fullscreen_accept):
2440         (on_fullscreen_deny):
2441
2442 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2443
2444         nrwt is no longer saving retry results in the retries/ subdirectory
2445         https://bugs.webkit.org/show_bug.cgi?id=112995
2446
2447         Reviewed by Ojan Vafai.
2448
2449         I think this has been broken a long time, unfortunately. This
2450         patch should fix that.
2451
2452         In order to do so, I had to pass the directory to use from
2453         the Worker object through the SingleTestWriter to the
2454         TestResultWriter. While I was plumbing that through, I rationalized
2455         the order of the parameter arguments a bit ...
2456
2457         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2458         (Worker._run_single_test):
2459         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2460         (run_single_test):
2461         (SingleTestRunner.__init__):
2462         (SingleTestRunner._run_compare_test):
2463         (SingleTestRunner._run_rebaseline):
2464         (SingleTestRunner._run_reftest):
2465         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2466         (write_test_result):
2467         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2468         (TestResultWriterTest.test_reftest_diff_image):
2469         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2470         (RunTest.test_retrying_uses_retries_directory):
2471
2472 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2473
2474         JSC profiler should have an at-a-glance report of the success of DFG optimization
2475         https://bugs.webkit.org/show_bug.cgi?id=112988
2476
2477         Reviewed by Geoffrey Garen.
2478
2479         * Scripts/display-profiler-output:
2480
2481 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2482
2483         [chromium] Linux ASAN WebKit canary is running out of memory
2484         https://bugs.webkit.org/show_bug.cgi?id=112978
2485
2486         Reviewed by Tony Chang.
2487
2488         Running the AddressSanitizer on a crash takes a lot of
2489         memory, so we should serialize access to it to avoid running
2490         out of memory on a machine.
2491
2492         * Scripts/webkitpy/layout_tests/port/chromium.py:
2493         (ChromiumPort._get_crash_log):
2494         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2495         (HttpLock.__init__):
2496         (HttpLock.wait_for_httpd_lock):
2497
2498 2013-03-21  Min Qin  <qinmin@chromium.org>
2499
2500         Cleanup android media layout test code
2501         https://bugs.webkit.org/show_bug.cgi?id=112944
2502
2503         Reviewed by Adam Barth.
2504
2505         Chromium change: https://codereview.chromium.org/12892010/
2506         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2507         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2508         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2509         Instead, we should switch to use content shell for layout tests.
2510
2511         * DumpRenderTree/chromium/TestShell.cpp:
2512         (TestShell::resetTestController):
2513
2514 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2515
2516         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2517         https://bugs.webkit.org/show_bug.cgi?id=112953
2518
2519         Reviewed by Tony Chang.
2520
2521         When I created the DumpRenderTree_resources target in r144863 I
2522         forgot to declare the needed dependencies on the other resource
2523         targets. Due to a quirk of ordering, this appears to have been fine
2524         w/ ninja but not w/ Xcode (which is still being used on the chromium
2525         mac valgrind bots). Declaring the dependencies fixes the build
2526         failures.
2527
2528         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2529
2530 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2531
2532         [WinCairo] Correct assert in Empty BitmapImage Test.
2533         https://bugs.webkit.org/show_bug.cgi?id=112934
2534
2535         Reviewed by Tim Horton.
2536
2537         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2538         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2539         to avoid ref counting assertion when leaving test scope.
2540
2541 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2542
2543         [GTK] generate-feature-defines-files is incompatible with Python3
2544         https://bugs.webkit.org/show_bug.cgi?id=112956
2545
2546         Reviewed by Martin Robinson.
2547
2548         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2549         method on the dictionary objects when iterating through said dictionaries.
2550
2551         * gtk/generate-feature-defines-files:
2552         (write_feature_defines_header):
2553         (write_flattened_feature_defines_file):
2554
2555 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2556
2557         kill-old-processes spits out error messages on Mac
2558         https://bugs.webkit.org/show_bug.cgi?id=112878
2559
2560         Reviewed by Jessie Berlin.
2561
2562         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2563         included in the list of options grep --help shows.
2564
2565         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2566
2567         * BuildSlaveSupport/kill-old-processes:
2568         (main):
2569
2570 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2571
2572         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2573         https://bugs.webkit.org/show_bug.cgi?id=112597
2574
2575         Reviewed by Xan Lopez.
2576
2577         These were introduced for the Chromium port in r105295. We need
2578         dummy implementations in order to compile the BlackBerry port.
2579
2580         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2581         (AccessibilityUIElement::scrollToMakeVisible):
2582         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2583         (AccessibilityUIElement::scrollToGlobalPoint):
2584
2585 2013-03-21  Roger Fong  <roger_fong@apple.com>
2586
2587         Re-enable WinEWS tests following r146376.
2588
2589         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2590         (WinEWS):
2591
2592 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2593
2594         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2595
2596         * Scripts/webkitpy/common/config/committers.py:
2597
2598 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2599
2600         [GTK] Missing atk in install-dependencies script
2601         https://bugs.webkit.org/show_bug.cgi?id=112272
2602
2603         Reviewed by Gustavo Noronha Silva.
2604
2605         * gtk/install-dependencies: Add missing atk dependency.
2606
2607 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2608
2609         [GTK] Missing backslash in install-dependencies script
2610         https://bugs.webkit.org/show_bug.cgi?id=112907
2611
2612         Reviewed by Philippe Normand.
2613
2614         * gtk/install-dependencies: Add missing backslash to dependencies
2615         list.
2616
2617 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2618
2619         EWS bots have stopped uploading results to bugzilla
2620         https://bugs.webkit.org/show_bug.cgi?id=101091
2621
2622         Reviewed by Adam Barth.
2623
2624         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2625         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2626         this relative file path resoled to a file inside a non-existent directory for "zip".
2627
2628         Fixed the bug by resolving both test results directory and zip archive paths in
2629         LayoutTestResultsReader.archive.
2630
2631         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2632         in the future.
2633
2634         * Scripts/webkitpy/common/system/filesystem_mock.py:
2635         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2636
2637         * Scripts/webkitpy/common/system/workspace.py:
2638         (Workspace.create_zip): Log the source path when "zip" failed.
2639
2640         * Scripts/webkitpy/common/system/workspace_mock.py:
2641         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2642
2643         * Scripts/webkitpy/common/system/workspace_unittest.py:
2644         (WorkspaceTest.test_create_zip_exception): Test that.
2645
2646         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2647         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2648         This is the actual bug fix.
2649
2650         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2651         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2652
2653 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2654
2655         [chromium] move WebThemeEngine implementations to TestRunner library
2656         https://bugs.webkit.org/show_bug.cgi?id=112751
2657
2658         Reviewed by Adam Barth.
2659
2660         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2661         * DumpRenderTree/DumpRenderTree.gypi:
2662         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2663         (WebKit):
2664         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2665         (WebTestRunner::TestInterfaces::themeEngine):
2666         (WebTestRunner):
2667         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2668         (WebKit):
2669         (TestInterfaces):
2670         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2671         (WebTestRunner::WebTestInterfaces::themeEngine):
2672         (WebTestRunner):
2673         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2674         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2675         (WebTestRunner):
2676         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2677         (WebTestRunner::WebTestThemeControlWin::box):
2678         (WebTestRunner::WebTestThemeControlWin::line):
2679         (WebTestRunner::WebTestThemeControlWin::triangle):
2680         (WebTestRunner::WebTestThemeControlWin::roundRect):
2681         (WebTestRunner::WebTestThemeControlWin::oval):
2682         (WebTestRunner::WebTestThemeControlWin::circle):
2683         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2684         (WebTestRunner::WebTestThemeControlWin::markState):
2685         (WebTestRunner::WebTestThemeControlWin::draw):
2686         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2687         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2688         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2689         (WebTestRunner):
2690         (WebTestThemeControlWin):
2691         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2692         (WebTestRunner):
2693         (WebTestThemeEngineMac):
2694         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2695         (+[FakeActiveWindow alwaysActiveWindow]):
2696         (+[FakeActiveWindow alwaysInactiveWindow]):
2697         (-[FakeActiveWindow initWithActiveControls:]):
2698         (-[FakeActiveWindow _hasActiveControls]):
2699         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2700         (WebTestRunner):
2701         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2702         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2703         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2704         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2705         (WebTestRunner):
2706         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2707         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2708         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2709         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2710         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2711         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2712         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2713         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2714         (WebTestRunner::WebTestThemeEngineWin::getSize):
2715         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2716         (WebTestRunner):
2717         (WebTestThemeEngineWin):
2718         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2719         * DumpRenderTree/chromium/TestShell.cpp:
2720         (TestShell::initialize):
2721         * DumpRenderTree/chromium/TestShell.h:
2722         (WebKit):
2723         * DumpRenderTree/chromium/TestShellMac.mm:
2724         (platformInit):
2725         * DumpRenderTree/chromium/TestShellWin.cpp:
2726         (platformInit):
2727         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2728
2729 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2730
2731         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2732
2733         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2734         New property sheet that does not link against CoreFoundation and
2735         CFNetwork.
2736         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2737         Use new TestWebKitAPICommonWinCairo property sheet.
2738         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2739         Ditto.
2740
2741 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2742
2743         [WinCairo] Unreviewed build fix for VS2010.
2744
2745         Had to add WinCairo-specific property sheets to deal with some
2746         library and path differences with the main Apple port.
2747
2748         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2749         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2750         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2751         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2752         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2753         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2754
2755 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2756
2757         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2758         https://bugs.webkit.org/show_bug.cgi?id=112849
2759
2760         Reviewed by Sam Weinig.
2761
2762         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2763         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2764         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2765
2766 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2767
2768         [WinCairo] Build WebKit Tools under VS2010
2769         https://bugs.webkit.org/show_bug.cgi?id=112821
2770
2771         Reviewed by Tim Horton.
2772
2773         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2774         Add WinCairo-specific build target.
2775         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2776         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2777         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2778         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2779         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2780         Add WinCairo-specific build target.
2781         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2782         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2783         Add WinCairo-specific build target.
2784         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2785         WinCairo-specific build target.
2786         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2787         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2788         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2789         specific build target.
2790         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2791         WinCairo-specific build target.
2792         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2793         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2794         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2795
2796 2013-03-20  Roger Fong  <roger_fong@apple.com>
2797
2798         API test gardening AppleWin port.
2799
2800         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2801
2802         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2803         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2804
2805 2013-03-20  Roger Fong  <roger_fong@apple.com>
2806
2807         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2808
2809         * EWSTools/start-queue-win.sh:
2810
2811 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2812
2813         Unreviewed, add myself to committers.py.
2814
2815 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2816
2817         Unreviewed. Adding another email for me.
2818
2819         * Scripts/webkitpy/common/config/committers.py:
2820
2821 2013-03-20  Justin Novosad  <junov@google.com>
2822
2823         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2824         https://bugs.webkit.org/show_bug.cgi?id=112605
2825
2826         Reviewed by James Robinson.
2827
2828         Deleting all the code that was used for propagating and supporting
2829         the Chromium setting for disabling deferred 2d canvas rendering.
2830
2831         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2832         (main):
2833         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2834         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2835         (WebTestRunner::WebPreferences::reset):
2836         (WebTestRunner::WebPreferences::applyTo):
2837         * DumpRenderTree/chromium/TestShell.cpp:
2838         (TestShell::TestShell):
2839         (TestShell::resetWebSettings):
2840         (TestShell::runFileTest):
2841         * DumpRenderTree/chromium/TestShell.h:
2842         (TestShell):
2843
2844 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2845
2846         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2847         https://bugs.webkit.org/show_bug.cgi?id=112699.
2848
2849         Reviewed by Adam Barth.
2850
2851         * Scripts/webkitpy/layout_tests/port/qt.py:
2852         (QtPort._search_paths):
2853         (QtPort._port_specific_expectations_files):
2854         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2855         (QtPortTest):
2856         (QtPortTest._assert_search_path):
2857         (QtPortTest._assert_expectations_files):
2858
2859 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2860
2861         [Qt] Enable kerning by default
2862         https://bugs.webkit.org/show_bug.cgi?id=112704
2863
2864         Reviewed by Jocelyn Turcotte.
2865
2866         Disable kerning by default, since some reference test expectations
2867         expect kerning to be default off.
2868
2869         * DumpRenderTree/qt/TestRunnerQt.cpp:
2870         (TestRunnerQt::reset):
2871         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2872         (WTR::activateFonts):
2873
2874 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2875
2876         [Qt] Remove empty function stubs from TestRunnerQt.
2877         https://bugs.webkit.org/show_bug.cgi?id=112799
2878
2879         We are reducing the code in TestRunnerQt step by step,
2880         in order to finally replace all of it with the generic
2881         TestRunner implementation.
2882         This patch removes several simple function stubs that
2883         currently do not implement any actual functionality.
2884
2885         Reviewed by Kenneth Rohde Christiansen.
2886
2887         * DumpRenderTree/qt/TestRunnerQt.cpp:
2888         * DumpRenderTree/qt/TestRunnerQt.h:
2889         (TestRunnerQt):
2890
2891 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2892
2893         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2894         https://bugs.webkit.org/show_bug.cgi?id=112687
2895
2896         Reviewed by Kenneth Rohde Christiansen.
2897
2898         Hide the SearchBar by default on window creation.
2899
2900         * MiniBrowser/efl/main.c:
2901         (window_create):
2902
2903 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2904
2905         Unreviewed, rolling out r146304.
2906         http://trac.webkit.org/changeset/146304
2907         https://bugs.webkit.org/show_bug.cgi?id=112788
2908
2909         to many expectations to update (Requested by antonm on
2910         #webkit).
2911
2912         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2913         * DumpRenderTree/DumpRenderTree.gypi:
2914         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2915         (WebKit):
2916         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2917         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2918         (TestInterfaces):
2919         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2920         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2921         * DumpRenderTree/chromium/TestShell.cpp:
2922         (TestShell::initialize):
2923         * DumpRenderTree/chromium/TestShell.h:
2924         (WebKit):
2925         * DumpRenderTree/chromium/TestShellMac.mm:
2926         (platformInit):
2927         * DumpRenderTree/chromium/TestShellWin.cpp:
2928         (platformInit):
2929         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2930         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2931         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2932         (WebThemeControlDRTWin::box):
2933         (WebThemeControlDRTWin::line):
2934         (WebThemeControlDRTWin::triangle):
2935         (WebThemeControlDRTWin::roundRect):
2936         (WebThemeControlDRTWin::oval):
2937         (WebThemeControlDRTWin::circle):
2938         (WebThemeControlDRTWin::nestedBoxes):
2939         (WebThemeControlDRTWin::markState):
2940         (WebThemeControlDRTWin::draw):
2941         (WebThemeControlDRTWin::drawTextField):
2942         (WebThemeControlDRTWin::drawProgressBar):
2943         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2944         (WebThemeControlDRTWin):
2945         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2946         (WebThemeEngineDRTMac):
2947         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2948         (+[FakeActiveWindow alwaysActiveWindow]):
2949         (+[FakeActiveWindow alwaysInactiveWindow]):
2950         (-[FakeActiveWindow initWithActiveControls:]):
2951         (-[FakeActiveWindow _hasActiveControls]):
2952         (WebThemeEngineDRTMac::paintScrollbarThumb):
2953         (stateToHIEnableState):
2954         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2955         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2956         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2957         (webRectToSkIRect):
2958         (drawControl):
2959         (drawTextField):
2960         (drawProgressBar):
2961         (WebThemeEngineDRTWin::paintButton):
2962         (WebThemeEngineDRTWin::paintMenuList):
2963         (WebThemeEngineDRTWin::paintScrollbarArrow):
2964         (WebThemeEngineDRTWin::paintScrollbarThumb):
2965         (WebThemeEngineDRTWin::paintScrollbarTrack):
2966         (WebThemeEngineDRTWin::paintSpinButton):
2967         (WebThemeEngineDRTWin::paintTextField):
2968         (WebThemeEngineDRTWin::paintTrackbar):
2969         (WebThemeEngineDRTWin::paintProgressBar):
2970         (WebThemeEngineDRTWin::getSize):
2971         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2972         (WebThemeEngineDRTWin):
2973         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2974
2975 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2976
2977         [Qt] Support -webkit-font-smoothing
2978         https://bugs.webkit.org/show_bug.cgi?id=106009
2979
2980         Reviewed by Jocelyn Turcotte.
2981
2982         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2983
2984         * DumpRenderTree/qt/TestRunnerQt.cpp:
2985         (TestRunnerQt::reset):
2986
2987 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2988
2989         [GTK] accessibility/aria-scrollbar-role.html is failing
2990         https://bugs.webkit.org/show_bug.cgi?id=98358
2991
2992         Reviewed by Martin Robinson.
2993
2994         Adds support for checking accessibility object's orientation.
2995         Orientation is checked by retrieving proper state of accessibility object.
2996
2997         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2998         (checkElementState):
2999         (AccessibilityUIElement::orientation):
3000         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3001         (WTR::AccessibilityUIElement::orientation):
3002
3003 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3004
3005         [chromium] move WebThemeEngine implementations to TestRunner library
3006         https://bugs.webkit.org/show_bug.cgi?id=112751
3007
3008         Reviewed by Adam Barth.
3009
3010         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3011         * DumpRenderTree/DumpRenderTree.gypi:
3012         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3013         (WebKit):
3014         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3015         (WebTestRunner::TestInterfaces::themeEngine):
3016         (WebTestRunner):
3017         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3018         (WebKit):
3019         (TestInterfaces):
3020         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3021         (WebTestRunner::WebTestInterfaces::themeEngine):
3022         (WebTestRunner):
3023         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3024         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3025         (WebTestRunner):
3026         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3027         (WebTestRunner::WebTestThemeControlWin::box):
3028         (WebTestRunner::WebTestThemeControlWin::line):
3029         (WebTestRunner::WebTestThemeControlWin::triangle):
3030         (WebTestRunner::WebTestThemeControlWin::roundRect):
3031         (WebTestRunner::WebTestThemeControlWin::oval):
3032         (WebTestRunner::WebTestThemeControlWin::circle):
3033         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3034         (WebTestRunner::WebTestThemeControlWin::markState):
3035         (WebTestRunner::WebTestThemeControlWin::draw):
3036         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3037         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3038         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3039         (WebTestRunner):
3040         (WebTestThemeControlWin):
3041         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3042         (WebTestRunner):
3043         (WebTestThemeEngineMac):
3044         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3045         (+[FakeActiveWindow alwaysActiveWindow]):
3046         (+[FakeActiveWindow alwaysInactiveWindow]):
3047         (-[FakeActiveWindow initWithActiveControls:]):
3048         (-[FakeActiveWindow _hasActiveControls]):
3049         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3050         (WebTestRunner):
3051         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3052         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3053         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3054         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3055         (WebTestRunner):
3056         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3057         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3058         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3059         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3060         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3061         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3062         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3063         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3064         (WebTestRunner::WebTestThemeEngineWin::getSize):
3065         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3066         (WebTestRunner):
3067         (WebTestThemeEngineWin):
3068         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3069         * DumpRenderTree/chromium/TestShell.cpp:
3070         (TestShell::initialize):
3071         * DumpRenderTree/chromium/TestShell.h:
3072         (WebKit):
3073         * DumpRenderTree/chromium/TestShellMac.mm:
3074         (platformInit):
3075         * DumpRenderTree/chromium/TestShellWin.cpp:
3076         (platformInit):
3077         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3078
3079 2013-03-19  Tony Chang  <tony@chromium.org>
3080
3081         Move testRunner.setTouchDragDropEnabled to internals.settings
3082         https://bugs.webkit.org/show_bug.cgi?id=112739
3083
3084         Reviewed by Adam Barth.
3085
3086         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3087         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
3088         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3089         (TestRunner): Remove unnecessary code.
3090         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3091         (WebTestRunner::WebPreferences::reset):
3092         (WebTestRunner::WebPreferences::applyTo): Always set to false.
3093
3094 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
3095
3096         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3097         https://bugs.webkit.org/show_bug.cgi?id=112754
3098
3099         Reviewed by Darin Fisher.
3100
3101         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3102         now that it's always defined.
3103
3104         * DumpRenderTree/chromium/WebViewHost.cpp:
3105         * DumpRenderTree/chromium/WebViewHost.h:
3106         (WebViewHost):
3107
3108 2013-03-19  Kenneth Russell  <kbr@google.com>
3109
3110         Unreviewed, rolling out r146290.
3111         http://trac.webkit.org/changeset/146290
3112         https://bugs.webkit.org/show_bug.cgi?id=112751
3113
3114         Broke Chromium Mac build.
3115
3116         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3117         * DumpRenderTree/DumpRenderTree.gypi:
3118         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3119         (WebKit):
3120         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3121         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3122         (TestInterfaces):
3123         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3124         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3125         * DumpRenderTree/chromium/TestShell.cpp:
3126         (TestShell::initialize):
3127         * DumpRenderTree/chromium/TestShell.h:
3128         (WebKit):
3129         * DumpRenderTree/chromium/TestShellMac.mm:
3130         (platformInit):
3131         * DumpRenderTree/chromium/TestShellWin.cpp:
3132         (platformInit):
3133         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3134         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3135         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3136         (WebThemeControlDRTWin::box):
3137         (WebThemeControlDRTWin::line):
3138         (WebThemeControlDRTWin::triangle):
3139         (WebThemeControlDRTWin::roundRect):
3140         (WebThemeControlDRTWin::oval):
3141         (WebThemeControlDRTWin::circle):
3142         (WebThemeControlDRTWin::nestedBoxes):
3143         (WebThemeControlDRTWin::markState):
3144         (WebThemeControlDRTWin::draw):
3145         (WebThemeControlDRTWin::drawTextField):
3146         (WebThemeControlDRTWin::drawProgressBar):
3147         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3148         (WebThemeControlDRTWin):
3149         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3150         (WebThemeEngineDRTMac):
3151         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3152         (+[FakeActiveWindow alwaysActiveWindow]):
3153         (+[FakeActiveWindow alwaysInactiveWindow]):
3154         (-[FakeActiveWindow initWithActiveControls:]):
3155         (-[FakeActiveWindow _hasActiveControls]):
3156         (WebThemeEngineDRTMac::paintScrollbarThumb):
3157         (stateToHIEnableState):
3158         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3159         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3160         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3161         (webRectToSkIRect):
3162         (drawControl):
3163         (drawTextField):
3164         (drawProgressBar):
3165         (WebThemeEngineDRTWin::paintButton):
3166         (WebThemeEngineDRTWin::paintMenuList):
3167         (WebThemeEngineDRTWin::paintScrollbarArrow):
3168         (WebThemeEngineDRTWin::paintScrollbarThumb):
3169         (WebThemeEngineDRTWin::paintScrollbarTrack):
3170         (WebThemeEngineDRTWin::paintSpinButton):
3171         (WebThemeEngineDRTWin::paintTextField):
3172         (WebThemeEngineDRTWin::paintTrackbar):
3173         (WebThemeEngineDRTWin::paintProgressBar):
3174         (WebThemeEngineDRTWin::getSize):
3175         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3176         (WebThemeEngineDRTWin):
3177         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3178
3179 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
3180
3181         [EFL] canvas-fallback-content.html is failing
3182         https://bugs.webkit.org/show_bug.cgi?id=111998
3183
3184         Reviewed by Chris Fleizach.
3185
3186         Adds support for getting platform name.
3187
3188         * DumpRenderTree/TestRunner.cpp:
3189         (TestRunner::staticValues):
3190         * DumpRenderTree/TestRunner.h:
3191         (TestRunner):
3192         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3193         (TestRunner::platformName):
3194
3195 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3196
3197         [chromium] move WebThemeEngine implementations to TestRunner library
3198         https://bugs.webkit.org/show_bug.cgi?id=112751
3199
3200         Reviewed by Adam Barth.
3201
3202         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3203         * DumpRenderTree/DumpRenderTree.gypi:
3204         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3205         (WebKit):
3206         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3207         (WebTestRunner::TestInterfaces::themeEngine):
3208         (WebTestRunner):
3209         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3210         (WebKit):
3211         (TestInterfaces):
3212         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3213         (WebTestRunner::WebTestInterfaces::themeEngine):
3214         (WebTestRunner):
3215         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3216         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3217         (WebTestRunner):
3218         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3219         (WebTestRunner::WebTestThemeControlWin::box):
3220         (WebTestRunner::WebTestThemeControlWin::line):
3221         (WebTestRunner::WebTestThemeControlWin::triangle):
3222         (WebTestRunner::WebTestThemeControlWin::roundRect):
3223         (WebTestRunner::WebTestThemeControlWin::oval):
3224         (WebTestRunner::WebTestThemeControlWin::circle):
3225         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3226         (WebTestRunner::WebTestThemeControlWin::markState):
3227         (WebTestRunner::WebTestThemeControlWin::draw):
3228         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3229         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3230         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3231         (WebTestRunner):
3232         (WebTestThemeControlWin):
3233         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3234         (WebTestRunner):
3235         (WebTestThemeEngineMac):
3236         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3237         (+[FakeActiveWindow alwaysActiveWindow]):
3238         (+[FakeActiveWindow alwaysInactiveWindow]):
3239         (-[FakeActiveWindow initWithActiveControls:]):
3240         (-[FakeActiveWindow _hasActiveControls]):
3241         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3242         (WebTestRunner):
3243         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3244         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3245         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3246         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3247         (WebTestRunner):
3248         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3249         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3250         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3251         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3252         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3253         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3254         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3255         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3256         (WebTestRunner::WebTestThemeEngineWin::getSize):
3257         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3258         (WebTestRunner):
3259         (WebTestThemeEngineWin):
3260         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3261         * DumpRenderTree/chromium/TestShell.cpp:
3262         (TestShell::initialize):
3263         * DumpRenderTree/chromium/TestShell.h:
3264         (WebKit):
3265         * DumpRenderTree/chromium/TestShellMac.mm:
3266         (platformInit):
3267         * DumpRenderTree/chromium/TestShellWin.cpp:
3268         (platformInit):
3269         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3270
3271 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3272
3273         [EFL][WK2] Separate WebView further from EwkView
3274         https://bugs.webkit.org/show_bug.cgi?id=111591
3275
3276         Reviewed by Caio Marcelo de Oliveira Filho.
3277
3278         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3279         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3280         since we can afford it having EWKViewGetWKView() private API to access WKView.
3281
3282         * TestWebKitAPI/PlatformWebView.h:
3283         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3284         (TestWebKitAPI::TEST):
3285         * TestWebKitAPI/efl/PlatformWebView.cpp:
3286         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3287         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3288         (TestWebKitAPI::PlatformWebView::resizeTo):
3289         (TestWebKitAPI::PlatformWebView::page):
3290         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3291         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3292         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3293         * WebKitTestRunner/PlatformWebView.h:
3294         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3295         (WTR::EventSenderProxy::dispatchEvent):
3296         (WTR::EventSenderProxy::keyDown):
3297         (WTR::EventSenderProxy::sendTouchEvent):
3298         (WTR::EventSenderProxy::setTouchModifier):
3299         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3300         (WTR::PlatformWebView::PlatformWebView):
3301         (WTR::PlatformWebView::~PlatformWebView):
3302         (WTR::PlatformWebView::resizeTo):
3303         (WTR::PlatformWebView::page):
3304         (WTR::PlatformWebView::focus):
3305         (WTR::PlatformWebView::windowSnapshotImage):
3306
3307 2013-03-19  Roger Fong  <roger_fong@apple.com>
3308
3309         Changes to VS2010 project files should only trigger builds on Windows bots.
3310         https://bugs.webkit.org/show_bug.cgi?id=112731
3311
3312         Reviewed by Timothy Horton.
3313
3314         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3315         (_should_file_trigger_build):
3316
3317 2013-03-19  Roger Fong  <roger_fong@apple.com>
3318
3319         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3320
3321         * Scripts/webkitpy/tool/steps/runtests.py:
3322         (RunTests.run):
3323         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3324         (RunTestsTest.test_webkit_run_unit_tests):
3325
3326 2013-03-19  Julie Parent  <jparent@chromium.org>
3327
3328         Dashboards: Introduce history namespace and unit tests.
3329         https://bugs.webkit.org/show_bug.cgi?id=112645
3330
3331         Reviewed by Ojan Vafai.
3332         
3333         Laying the framework for introducing the new history object and
3334         namespace.  This moves only static functions into the history
3335         namespace, and moves corresponding unit tests into seperate
3336         unit test file.
3337
3338         * TestResultServer/static-dashboards/aggregate_results.html:
3339         * TestResultServer/static-dashboards/dashboard_base.js:
3340         (parseCrossDashboardParameters):
3341         (parseDashboardSpecificParameters):
3342         (parseParameters):
3343         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3344         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3345         (.switch.return):
3346         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3347         * TestResultServer/static-dashboards/history.js: Added.
3348         * TestResultServer/static-dashboards/history_unittests.js: Added.
3349         * TestResultServer/static-dashboards/loader.js:
3350         (.):
3351         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3352         * TestResultServer/static-dashboards/run-unittests.html:
3353         * TestResultServer/static-dashboards/timeline_explorer.html:
3354         * TestResultServer/static-dashboards/timeline_explorer.js:
3355         * TestResultServer/static-dashboards/treemap.html:
3356         * TestResultServer/static-dashboards/treemap.js:
3357         (.switch.return):
3358         * TestResultServer/static-dashboards/ui.js:
3359
3360 2013-03-19  Daniel Bates  <dbates@webkit.org>
3361
3362         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3363         https://bugs.webkit.org/show_bug.cgi?id=112732
3364
3365         Reviewed by Eric Seidel.
3366
3367         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3368         of an existing file cannot be applied.
3369
3370         In particular, svn-{apply, unapply} compensate for differences in line endings
3371         by converting the line endings in a diff to match the line endings in the target
3372         file. The diff(1) command precedes the last line of a diff that adds a newline
3373         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3374         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3375         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3376         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3377         the newline characters in this special character sequence to match the line endings
3378         in the target file.
3379
3380         * Scripts/VCSUtils.pm:
3381         (parseDiff):
3382         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3383         Added tests:
3384             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3385             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3386             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3387             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3388         (escapeNewLineCharacters): Added.
3389         (toMacLineEndings): Added.
3390
3391 2013-03-19  James Robinson  <jamesr@chromium.org>
3392
3393         [chromium] Remove compositor settings that don't go through WebKit
3394         https://bugs.webkit.org/show_bug.cgi?id=112718
3395
3396         Reviewed by Adam Barth.
3397
3398         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3399         (main):
3400         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3401         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3402         (WebTestRunner::WebPreferences::reset):
3403         (WebTestRunner::WebPreferences::applyTo):
3404         * DumpRenderTree/chromium/TestShell.cpp:
3405         (TestShell::TestShell):
3406         (TestShell::resetWebSettings):
3407         * DumpRenderTree/chromium/TestShell.h:
3408         (TestShell):
3409
3410 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3411
3412         Unreviewed, rolling out r146101.
3413         https://bugs.webkit.org/show_bug.cgi?id=111884
3414
3415         re-enable custom freetype on asan; this needs to be on
3416         now that the bot is running lucid.
3417
3418         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3419
3420 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3421
3422         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3423         https://bugs.webkit.org/show_bug.cgi?id=112365
3424
3425         Reviewed by Benjamin Poulain.
3426
3427         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3428         harcoding it in wtf/Platform.h
3429
3430         * Scripts/webkitperl/FeatureList.pm:
3431
3432 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3433
3434         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3435         https://bugs.webkit.org/show_bug.cgi?id=94782
3436
3437         Based on patch by Csaba Osztrogonác.
3438         Reviewed by Jocelyn Turcotte.
3439
3440         The diff image is generated with bright red indicating errors, but letting the base image
3441         shine through so the context of the error-pixel can be identified.
3442
3443         * DumpRenderTree/qt/ImageDiff.cpp:
3444         (main):
3445
3446 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3447
3448         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3449
3450         Rubber-stamped by Csaba Osztrogonác.
3451
3452         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3453         since the latter might not cover the former.
3454
3455         * QtTestBrowser/launcherwindow.cpp:
3456         (LauncherWindow::print):
3457
3458 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3459
3460         Style tweeks to default.css.
3461         
3462         Rubber-stamped by David Kilzer.
3463         
3464         Give visited links a different color to other links, so you can
3465         see which builds you've viewed.
3466         
3467         Make the <small> text less tiny.
3468
3469         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3470         (small):
3471         (a:link,a:visited,a:active):
3472         (a:visited):
3473
3474 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3475
3476         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3477         https://bugs.webkit.org/show_bug.cgi?id=112494
3478
3479         Reviewed by Dirk Pranke.
3480
3481         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3482         Also merged two pairs of methods to cleanup the code.
3483
3484         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3485         (PerfTestsRunner.run): Merged _upload_and_show_results.
3486         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3487
3488 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3489
3490         [chromium] build xdisplaycheck when building DRT
3491         https://bugs.webkit.org/show_bug.cgi?id=112636
3492
3493         Reviewed by Tony Chang.
3494
3495         It appears that we need xdisplaycheck to be built in order for
3496         Xvfb to be started correctly on the bots, and DRT was missing
3497         a dependency on it. This may be the cause of the ASAN bot not
3498         starting up properly (it only builds DRT).
3499
3500         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3501
3502 2013-03-18  David Levin  <levin@chromium.org>
3503
3504         Implement icon change notification dump for Chromium's test shell.
3505         https://bugs.webkit.org/show_bug.cgi?id=112614
3506
3507         This was previously implemented for some other platforms in r58111
3508         and r116547.
3509
3510         In r122806, fast/dom/icon-url-property.html stopped using it, but
3511         it is useful for tests, so I plan to re-add it to that test again.
3512
3513         Reviewed by Jochen Eisinger.
3514
3515         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3516         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3517          icon change notifications from WebKit may be logged in test output.
3518         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3519         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3520         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3521         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3522         (WebTestRunner):
3523         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3524         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3525         (TestRunner):
3526         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3527         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3528         (WebTestRunner):
3529         * DumpRenderTree/chromium/WebViewHost.cpp:
3530         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3531         * DumpRenderTree/chromium/WebViewHost.h:
3532         (WebViewHost):
3533
3534 2013-03-18  Julie Parent  <jparent@chromium.org>
3535
3536         Cleanup: Move js for treemap and aggregate_results into own js files.
3537         https://bugs.webkit.org/show_bug.cgi?id=112618
3538
3539         Reviewed by Dirk Pranke.
3540         
3541         No functional changes, just moving the code into separate js file
3542         rather than inlined in the html, so we can test it, make it more
3543         modular, etc.  Other dashboard types are already done this way.
3544
3545         * TestResultServer/static-dashboards/aggregate_results.html:
3546         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3547         (generatePage):
3548         (handleValidHashParameter):
3549         (htmlForBuilder):
3550         (rawValuesHTML):
3551         (chartHTML):
3552         (filteredValues):
3553         (chart):
3554         (htmlForRevisionRows):
3555         (wrapHTMLInTable):
3556         (htmlForSummaryTable):
3557         (valuesPerExpectation):
3558         (htmlForTestType):
3559         (htmlForTableRow):
3560         (extendedEncode):
3561         * TestResultServer/static-dashboards/treemap.html:
3562         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3563         (humanReadableTime):
3564         (convertToWebTreemapFormat):
3565         (reverseSortByAverage):
3566         (generatePage):
3567         (focusPath):
3568         (.switch.return):
3569         (handleQueryParameterChange):
3570         (extractName):
3571         (fullName):
3572         (handleFocus.):
3573         (handleFocus):
3574
3575 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3576
3577         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3578         https://bugs.webkit.org/show_bug.cgi?id=112622
3579
3580         Reviewed by Dirk Pranke.
3581
3582         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3583         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3584
3585 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3586
3587         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3588         https://bugs.webkit.org/show_bug.cgi?id=112619
3589
3590         Reviewed by Dirk Pranke.
3591
3592         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3593         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3594
3595         * Scripts/webkitpy/layout_tests/port/gtk.py:
3596         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3597         Port._webkit_baseline_path method.
3598         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3599         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3600         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3601         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3602         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3603         that are expected based on the builder name.
3604
3605 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3606
3607         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3608         https://bugs.webkit.org/show_bug.cgi?id=112571
3609
3610         Reviewed by Adam Barth.
3611
3612         Update function declarations for new WebFileSystemType enum. (All
3613         changes are behind an #ifdef so we can sync required changes in embedders.)
3614
3615         * DumpRenderTree/chromium/WebViewHost.cpp:
3616         (WebViewHost::openFileSystem):
3617         (WebViewHost::deleteFileSystem):
3618         * DumpRenderTree/chromium/WebViewHost.h:
3619         (WebViewHost):
3620
3621 2013-03-18  Julie Parent  <jparent@chromium.org>
3622
3623         Cleanup: Move timeline_exporer js out of html file into js.
3624         https://bugs.webkit.org/show_bug.cgi?id=112188
3625
3626         Reviewed by Dirk Pranke.
3627         
3628         Moves the javascript out of the html file and into a new js file.
3629         This follows the format of flakiness_dashboard.{html|js}.
3630         
3631         Also moves code from dashboard_base that is used only by this one
3632         dashboard, and makes it private to the dashboard.
3633
3634         * TestResultServer/static-dashboards/dashboard_base.js:
3635         * TestResultServer/static-dashboards/timeline_explorer.html:
3636         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3637         (generatePage):
3638         (initCurrentBuilderTestResults):
3639         (shouldShowWebKitRevisionsOnly):
3640         (updateTimelineForBuilder.):
3641         (updateTimelineForBuilder):
3642         (selectBuild):
3643         (updateBuildIndicator):
3644         (.addRow):
3645         (.addNumberRow):
3646         (.inspectorNode.getElementsByTagName.0.onclick):
3647         (.inspectorNode.getElementsByTagName.1.onclick):
3648         (.inspectorNode.getElementsByTagName.2.onclick):
3649         (updateBuildInspector):
3650         (showResultsDelta):
3651         (decompressResults.addFlakyDelta):
3652         (decompressResults):
3653
3654 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3655
3656         Unreviewed, rolling out r145272.
3657         http://trac.webkit.org/changeset/145272
3658         https://bugs.webkit.org/show_bug.cgi?id=111884
3659
3660         Turns out the ASAN build is still broken; possibly there's
3661         something still setting LD_LIBRARY_PATH, or possibly there's
3662         something else wrong. In the meantime, we need it to work again.
3663
3664         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3665
3666 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3667
3668         delete-stale-build-files is too aggressive
3669         https://bugs.webkit.org/show_bug.cgi?id=112595
3670
3671         Reviewed by Tim Horton.
3672
3673         It appears that whitelisting file extensions to keep is not a good idea.
3674         Blacklist files to delete instead, and only delete .o files for now.
3675         We can add more file extensions as needed.
3676
3677         * BuildSlaveSupport/delete-stale-build-files:
3678
3679 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3680
3681         Disable accessibility notifications after each test
3682         https://bugs.webkit.org/show_bug.cgi?id=112579
3683
3684         Reviewed by Tim Horton.
3685         
3686         In WebKitTestRunner, if any tests triggered accessibility notifications,
3687         the global notification handler would thereafter be active, and fire
3688         notifications for all subsequent tests.
3689         
3690         Fix by implementing AccessibilityController::resetToConsistentState() for
3691         Mac, and using it to clear the global notification handler.
3692
3693         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3694         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3695         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3696         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3697         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3698         (e.g. because of -autorelease).
3699         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3700         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3701         if there is one.
3702         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3703         Add -stopObserving
3704         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3705         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3706         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3707         center.
3708
3709 2013-03-18  Dana Jansens  <danakj@chromium.org>
3710
3711         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3712         https://bugs.webkit.org/show_bug.cgi?id=112392
3713
3714         Reviewed by James Robinson.
3715
3716         Removes the command line flag option from DRT.
3717
3718         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3719         (main):
3720
3721 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3722
3723         [GTK] plugins/plugin-clip-subframe.html is failing
3724         https://bugs.webkit.org/show_bug.cgi?id=112570
3725
3726         Reviewed by Martin Robinson.
3727
3728         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3729
3730 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3731
3732         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3733         https://bugs.webkit.org/show_bug.cgi?id=112442
3734
3735         Reviewed by Gustavo Noronha Silva.
3736
3737         * GtkLauncher/main.c:
3738         (reloadCb):
3739         (createToolbar):
3740         (createWindow):
3741
3742 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3743
3744         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3745         https://bugs.webkit.org/show_bug.cgi?id=112205
3746
3747         Disable this API test until Geoff can fix it.
3748
3749         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3750         (TestWebKitAPI::TEST):
3751
3752 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3753
3754         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3755         https://bugs.webkit.org/show_bug.cgi?id=112478
3756
3757         Reviewed by Tony Chang.
3758
3759         There is nothing that ensures that the log messages from the plugin
3760         come in before the layout test finished loading.
3761
3762         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3763         (PassDifferentNPPStruct::NPP_SetWindow):
3764         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3765         (NPP_SetWindow):
3766
3767 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3768
3769         Have the mac port support per_test_timeout in webkitpy
3770         https://bugs.webkit.org/show_bug.cgi?id=112466
3771
3772         Reviewed by Dirk Pranke.
3773         
3774         Both WTR and DRT handle --timeout arguments, so we can
3775         have the scripts pass the timeout values down to the tools.
3776
3777         * Scripts/webkitpy/layout_tests/port/mac.py:
3778         (MacPort.supports_per_test_timeout):
3779
3780 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3781
3782         Remove setAsynchronousSpellCheckingEnabled from test runners
3783         https://bugs.webkit.org/show_bug.cgi?id=112362
3784
3785         Reviewed by Tony Chang.
3786
3787         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3788         in internals.settings, so all ports can share it.
3789
3790         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3791         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3792         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3793         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3794         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3795         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3796         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3797         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3798         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3799         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3800         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3801         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3802
3803 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3804
3805         Fix the stupid unit tests.
3806
3807         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3808         (test_sample_process):
3809
3810 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3811
3812         Collect samples for unresponsive web processes
3813         https://bugs.webkit.org/show_bug.cgi?id=112409
3814
3815         Reviewed by Tim Horton.
3816         
3817         When we detect that a subprocess was unresponsive, run the 'sample'
3818         tool on that process, for the Mac port.
3819         
3820         The sample will be linked to from the results.html page, next
3821         to the crash log link.
3822
3823         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3824         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3825         look for samples on disk.
3826         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3827         (TestResultWriter):
3828         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3829         -sample.txt files, and have it copy their contents to a new file
3830         next to the test that spawned them (as we do for crash logs).
3831         * Scripts/webkitpy/layout_tests/port/base.py:
3832         (Port.look_for_new_samples): Base class does nothing for sampling.
3833         * Scripts/webkitpy/layout_tests/port/driver.py:
3834         (Driver._check_for_driver_crash): Kick off a sample if we detected
3835         that the subprocess was unresponsive.
3836         * Scripts/webkitpy/layout_tests/port/mac.py:
3837         (MacPort.sample_file_path): Utility to generate the file path
3838         to the generated sample files at the top level of layout-test-results.
3839         (MacPort.look_for_new_crash_logs): Fix typo
3840         (MacPort.look_for_new_samples): New function to find sample files.
3841         (MacPort.sample_process): Use the utility function to get the file path.
3842
3843 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3844
3845         [Qt] Remove simple getters and setters from TestRunnerQt
3846         https://bugs.webkit.org/show_bug.cgi?id=112343
3847
3848         Reviewed by Benjamin Poulain.
3849
3850         The removed functions and boolean members
3851         are being replaced by the implementations in the
3852         generic TestRunner.h.
3853
3854         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3855         (DumpRenderTree::dumpFrameScrollPosition):
3856         (DumpRenderTree::dumpFramesAsText):
3857         (DumpRenderTree::dump):
3858         (DumpRenderTree::titleChanged):
3859         (DumpRenderTree::dumpDatabaseQuota):
3860         (DumpRenderTree::dumpApplicationCacheQuota):
3861         (DumpRenderTree::statusBarMessage):
3862         (DumpRenderTree::createWindow):
3863         * DumpRenderTree/qt/TestRunnerQt.cpp:
3864         (TestRunnerQt::reset):
3865         * DumpRenderTree/qt/TestRunnerQt.h:
3866         (TestRunnerQt):
3867
3868 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3869
3870         Update the link on build.webkit.org to refer to perf.webkit.org
3871         https://bugs.webkit.org/show_bug.cgi?id=112416
3872
3873         Reviewed by Philip Rogers.
3874
3875         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3876
3877         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3878
3879 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3880
3881         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3882         https://bugs.webkit.org/show_bug.cgi?id=112394
3883
3884         Reviewed by Philippe Normand.
3885
3886         * GtkLauncher/main.c:
3887         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3888
3889 2013-03-14  Andreas Kling  <akling@apple.com>
3890
3891         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3892         <http://webkit.org/b/111815>
3893         <rdar://problem/13380145>
3894
3895         Reviewed by Anders Carlsson.
3896
3897         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3898         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3899         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3900
3901         * WebKitTestRunner/PlatformWebView.h:
3902         (PlatformWebView):
3903         * WebKitTestRunner/TestController.cpp:
3904         (WTR::TestController::createOtherPage):
3905         (WTR::TestController::createWebViewWithOptions):
3906         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3907         (WTR::PlatformWebView::didInitializeClients):
3908
3909 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3910
3911         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3912         https://bugs.webkit.org/show_bug.cgi?id=112122
3913
3914         Reviewed by Kenneth Rohde Christiansen.
3915
3916         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3917
3918         * MiniBrowser/efl/main.c:
3919         (_Browser_Window):
3920         (search_box_show):
3921         (search_box_hide):
3922         (on_key_down):
3923         (on_url_changed):
3924         (on_search_field_aborted):
3925         (on_search_field_activated):
3926         (on_search_field_clicked):
3927         (on_search_backward_button_clicked):
3928         (on_search_forward_button_clicked):
3929         (window_create):
3930
3931 2013-03-14  Julie Parent  <jparent@chromium.org>
3932
3933         Cleanup: Remove g_resourceLoader.
3934         https://bugs.webkit.org/show_bug.cgi?id=112305
3935
3936         Reviewed by Dirk Pranke.
3937         
3938         Removing another global.
3939         
3940         Now, each dashboard creates its own loader, rather than having
3941         a general global one.
3942         
3943         Remove usage of g_resourceLoader.isLoadingComplete from 
3944         handleLocationChange by ensuring that handleLocationChange is
3945         never called before the loader is done.  It was called in two
3946         places before: 1 was from the callback when the loader is done,
3947         so that was obviously true, and the other was from onhashchange,
3948         where it would just return rather than running.  Instead, lets
3949         only register the onhashchange handler once the loader is
3950         setup, so the check is no longer necessary.
3951         
3952         Remove isLoadingComplete since it is now unused.
3953         
3954         Callback for loader is now initializeHistory, rather than just
3955         handleLocationChange which will set up the hashchange handler now.
3956         This will all eventually be moving to a new History object.
3957
3958         * TestResultServer/static-dashboards/aggregate_results.html:
3959         * TestResultServer/static-dashboards/dashboard_base.js:
3960         (handleLocationChange):
3961         (intializeHistory):
3962         (decompressResults):
3963         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3964         (generatePage):
3965         * TestResultServer/static-dashboards/loader.js:
3966         (.):
3967         * TestResultServer/static-dashboards/loader_unittests.js:
3968         * TestResultServer/static-dashboards/timeline_explorer.html:
3969         * TestResultServer/static-dashboards/treemap.html:
3970
3971 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3972
3973         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3974         https://bugs.webkit.org/show_bug.cgi?id=109404
3975
3976         Reviewed by Tony Chang.
3977
3978         Removes all the code related to smartInsertDeleteEnabled and
3979         selectTrailingWhitespaceEnabled settings as they will be managed from
3980         internals from now on.
3981
3982         * DumpRenderTree/TestRunner.cpp:
3983         (TestRunner::staticFunctions):
3984         * DumpRenderTree/TestRunner.h:
3985         (TestRunner):
3986         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3987         (WebKit):
3988         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3989         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3990         (DumpRenderTree):
3991         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3992         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3993         (WebTestRunner::WebTestProxy::didStopLoading):
3994         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3995         (WebTestRunner::TestRunner::TestRunner):
3996         (WebTestRunner::TestRunner::reset):
3997         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3998         (TestRunner):
3999         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
4000         (WebTestRunner::WebPreferences::applyTo): Set default values for
4001         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
4002         Chromium DRT default values are different from Chromium browser.
4003         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4004         * DumpRenderTree/chromium/WebViewHost.cpp:
4005         * DumpRenderTree/chromium/WebViewHost.h:
4006         (WebViewHost):
4007         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4008         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4009         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4010         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4011         (resetDefaultsToConsistentValues):
4012         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4013         * DumpRenderTree/mac/DumpRenderTree.mm:
4014         (resetWebViewToConsistentStateBeforeTesting):
4015         * DumpRenderTree/mac/TestRunnerMac.mm:
4016         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4017         (WebCore::WebPage::resetSettings):
4018         * DumpRenderTree/qt/TestRunnerQt.cpp:
4019         * DumpRenderTree/qt/TestRunnerQt.h:
4020         (TestRunnerQt):
4021         * DumpRenderTree/win/DumpRenderTree.cpp:
4022         (resetWebViewToConsistentStateBeforeTesting):
4023         * DumpRenderTree/win/TestRunnerWin.cpp:
4024         * DumpRenderTree/wx/TestRunnerWx.cpp:
4025
4026 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
4027
4028         [Qt] Disable DRT on Windows
4029
4030         Reviewed by Jocelyn Turcotte.
4031
4032         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
4033
4034         * qmake/mkspecs/features/configure.prf:
4035
4036 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
4037
4038         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
4039         https://bugs.webkit.org/show_bug.cgi?id=110728
4040
4041         Reviewed by Gyuyoung Kim.
4042
4043         Use the page group to create the view object.
4044
4045         * MiniBrowser/efl/main.c:
4046         (window_create):
4047
4048 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
4049
4050         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
4051
4052         Reviewed by Tor Arne Vestbø.
4053
4054         The mock versions of these web facing features should be instantiated when
4055         running in DumpRenderTree only. In order for them to work, no extra Qt modules
4056         such as QtLocation are actually needed.
4057
4058         This patch decouples enabling device orientation/motion and geolocation from
4059         the underlying Qt modules and makes them available in developer builds
4060         (!production_build) and backed by mock backends when running in drt.
4061
4062         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
4063         developers the web facing features are always enabled (although requests will
4064         time out) and the mock backends are enabled inside DRT, allowing for the layout
4065         tests to run with less dependencies.
4066
4067         In addition this also enables the mock device motion client, which was
4068         previously never instantiated.
4069
4070         * qmake/mkspecs/features/features.prf:
4071
4072 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4073
4074         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
4075         https://bugs.webkit.org/show_bug.cgi?id=112340
4076
4077         Reviewed by Simon Hausmann.
4078
4079         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4080         (DumpRenderTree::dump):
4081             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
4082         (DumpRenderTree::dumpApplicationCacheQuota):
4083         * DumpRenderTree/qt/TestRunnerQt.cpp:
4084         (TestRunnerQt::reset):
4085         * DumpRenderTree/qt/TestRunnerQt.h:
4086         (TestRunnerQt):
4087
4088 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4089
4090         [Qt] Port DRT to use TestRunner::dumpAsText()
4091         https://bugs.webkit.org/show_bug.cgi?id=112260
4092
4093         Reviewed by Benjamin Poulain.
4094
4095         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4096         (WebCore::DumpRenderTree::open):
4097         (WebCore::methodNameStringForFailedTest):
4098             Change parameter from type TestRunnerQt* to TestRunner*.
4099         (WebCore::DumpRenderTree::dump):
4100             TestRunnerQt::shouldDumpPixels() always returned true in our case.
4101             Instead we should rely on TestRunner::generatePixelResults().
4102         * DumpRenderTree/qt/TestRunnerQt.cpp:
4103         (TestRunnerQt::reset):
4104         * DumpRenderTree/qt/TestRunnerQt.h:
4105         (TestRunnerQt):
4106
4107 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
4108
4109         Implement FontLoader interface
4110         https://bugs.webkit.org/show_bug.cgi?id=98395
4111
4112         Reviewed by Eric Seidel.
4113
4114         Enable FontLoadEvents runtime flag for TestShell.
4115
4116         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4117         (WebTestRunner::TestInterfaces::TestInterfaces):
4118
4119 2013-03-13  Julie Parent  <jparent@chromium.org>
4120
4121         CLeanup: remove unnecessary call to parseParameters.
4122         https://bugs.webkit.org/show_bug.cgi?id=112309
4123
4124         Reviewed by Ojan Vafai.
4125         
4126         We call parseCrossDashboardParameters when the dashboard initially
4127         loads to set the state required for loadBuildersList, and then we
4128         call it again once we are fully done with loading, so there is no
4129         reason to call it in the middle of the loading process here.
4130
4131         * TestResultServer/static-dashboards/loader.js:
4132         (.):
4133
4134 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
4135
4136         Unreviewed. Now I'm a reviewer :)
4137
4138         * Scripts/webkitpy/common/config/committers.py:
4139
4140 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
4141
4142         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
4143         https://bugs.webkit.org/show_bug.cgi?id=112277
4144
4145         Reviewed by Adam Barth.
4146
4147         * Scripts/webkitperl/FeatureList.pm:
4148         * qmake/mkspecs/features/features.pri:
4149
4150 2013-03-13  Adam Barth  <abarth@webkit.org>
4151
4152         run-perf-tests should support content_shell
4153         https://bugs.webkit.org/show_bug.cgi?id=112291
4154
4155         Reviewed by Eric Seidel.
4156
4157         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4158         (PerfTestsRunner._parse_args):
4159
4160 2013-03-13  Oliver Hunt  <oliver@apple.com>
4161
4162         Simplify Checked<> multiplication
4163         https://bugs.webkit.org/show_bug.cgi?id=112286
4164
4165         Reviewed by James Robinson.
4166
4167         Add tests for multiplication by zero and max to ensure we don't
4168         mess them up should we ever make changes to Checked<> in future.
4169
4170         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4171         (TestWebKitAPI):
4172
4173 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4174
4175         [Qt] Unreviewed prospective Windows build fix
4176
4177         Do the usual thing, include the moc generated code in the .cpp file instead
4178         of compiling it standalone, to ensure that config.h is included, too, and
4179         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
4180
4181         * DumpRenderTree/qt/EventSenderQt.cpp:
4182
4183 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4184
4185         [Qt] Port TestRunner::findString to shared interface
4186         https://bugs.webkit.org/show_bug.cgi?id=112147
4187
4188         Reviewed by Jocelyn Turcotte.
4189
4190         This patch also removes DumpRenderTree and some other helper classes from
4191         the WebCore namespace, to which they do not really belong.
4192
4193         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4194         (main):
4195         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4196         (DumpRenderTree::DumpRenderTree):
4197         (DumpRenderTree::~DumpRenderTree):
4198         (DumpRenderTree::instance):
4199         (DumpRenderTree::setShouldTimeout):
4200         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4201         (DumpRenderTree):
4202         * DumpRenderTree/qt/EventSenderQt.cpp:
4203         (EventSender::contextClick):
4204         (EventSender::sendEvent):
4205         (EventSender::postEvent):
4206         * DumpRenderTree/qt/EventSenderQt.h:
4207         (EventSender::isGraphicsBased):
4208         * DumpRenderTree/qt/TestRunnerQt.cpp:
4209         (TestRunnerQt::TestRunnerQt):
4210         (TestRunner::findString):
4211         (TestRunnerQt::setMockDeviceOrientation):
4212         (TestRunnerQt::setGeolocationPermission):
4213         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
4214         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
4215         (TestRunnerQt::setMockGeolocationPosition):
4216         * DumpRenderTree/qt/TestRunnerQt.h:
4217         (TestRunnerQt):
4218
4219 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
4220
4221         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
4222         https://bugs.webkit.org/show_bug.cgi?id=112129
4223
4224         Reviewed by Adam Barth.
4225
4226         Following Chromium
4227         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
4228         this is being renamed to better explain what it does.
4229
4230         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4231
4232 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4233
4234         [Qt] Unreviewed trivial typo fix
4235
4236         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
4237         TextRunner.h. Thanks Zeno :)
4238
4239 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
4240
4241         [Qt] Prepare DRT for transition to shared TestRunner interface
4242         https://bugs.webkit.org/show_bug.cgi?id=112144
4243
4244         Reviewed by Benjamin Poulain.
4245
4246         Prepare Qt's DRT for a transition from the QObject based TestRunner to
4247         the JSC C API based one.
4248
4249         This is impplemented by instantiating the QObject based testRunner in
4250         the global object, then instantiating the JSC C based TestRunner
4251         separately and placing it "behind" the QObject based testRunner through
4252         injection of the individual functions through proxies. (prototype
4253         chaining doesn't work due to the this object and Function.prototype.bind
4254         doesn't work due to the native function)
4255
4256         This allows for porting over method by method by removing the method
4257         from the QObject TestRunnerQt and implementing it in the JSC C based
4258         TestRunner.
4259
4260         In order for this to link and run dummy implementations of all the
4261         necessary TestRunner functions are provided.
4262
4263         * DumpRenderTree/qt/DumpRenderTree.pro:
4264         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4265         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4266         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4267         (WebCore::DumpRenderTree::initJSObjects):
4268         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4269         (DumpRenderTree):
4270         * DumpRenderTree/qt/TestRunnerQt.cpp:
4271         (TestRunner::~TestRunner):
4272         (TestRunner::addDisallowedURL):
4273         (TestRunner::queueLoad):
4274         (TestRunner::removeAllVisitedLinks):
4275         (TestRunner::setAcceptsEditing):
4276         (TestRunner::simulateLegacyWebNotificationClick):
4277         (TestRunner::setWindowIsKey):
4278         (TestRunner::setAlwaysAcceptCookies):
4279         (TestRunner::addOriginAccessWhitelistEntry):
4280         (TestRunner::setWebViewEditable):
4281         (TestRunner::clearAllApplicationCaches):
4282         (TestRunner::setTextDirection):
4283         (TestRunner::notifyDone):
4284         (TestRunner::numberOfPendingGeolocationPermissionRequests):
4285         (TestRunner::overridePreference):
4286         (TestRunner::pathToLocalResource):
4287         (TestRunner::removeAllWebNotificationPermissions):
4288         (TestRunner::simulateWebNotificationClick):
4289         (TestRunner::closeIdleLocalStorageDatabases):
4290         (TestRunner::focusWebView):