[Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-17  Dan Bernstein  <mitz@apple.com>
2
3         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
4         https://bugs.webkit.org/show_bug.cgi?id=160938
5         <rdar://problem/27876652>
6
7         Reviewed by Anders Carlsson.
8
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
11         (TestWebKitAPI::TEST):
12
13 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
14
15         AX: Support abbreviations in iOS
16         https://bugs.webkit.org/show_bug.cgi?id=160907
17
18         Reviewed by Joanmarie Diggs.
19
20         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
21         (AccessibilityUIElement::stringAttributeValue):
22         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
23         (WTR::AccessibilityUIElement::stringAttributeValue):
24
25 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
26
27         [EFL] Bump efl version from 1.17 to 1.18
28         https://bugs.webkit.org/show_bug.cgi?id=160899
29
30         Reviewed by Antonio Gomes.
31
32         To use efl-1.18, EFL port needs to update install dependencies as well.
33
34         * efl/install-dependencies:
35         * efl/jhbuild.modules:
36
37 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
38
39         [Win] Add tests for linked fonts.
40         https://bugs.webkit.org/show_bug.cgi?id=160898
41
42         Reviewed by Brent Fulgham.
43
44         Add tests for https://trac.webkit.org/changeset/204502.
45
46         * TestWebKitAPI/PlatformWin.cmake:
47         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
48         (TestWebKitAPI::TEST):
49
50 2016-08-16  Daniel Bates  <dabates@apple.com>
51
52         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
53         https://bugs.webkit.org/show_bug.cgi?id=160924
54
55         Reviewed by Stephanie Lewis.
56
57         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
58         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
59         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
60         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
61         object that mocks out the file system and SCM operations.
62
63         * Scripts/VCSUtils.pm:
64         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
65         * Scripts/prepare-ChangeLog:
66         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
67         abstracting the logic to query the file system and SCM into functions on a delegate object that
68         we pass to it.
69         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
70         (diffHeaderFormat): Deleted.
71
72 2016-08-16  Alex Christensen  <achristensen@webkit.org>
73
74         URLParser should parse URLs without credentials
75         https://bugs.webkit.org/show_bug.cgi?id=160913
76
77         Reviewed by Brady Eidson.
78
79         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
80         (TestWebKitAPI::s):
81         (TestWebKitAPI::checkURL):
82         (TestWebKitAPI::TEST_F):
83
84 2016-08-16  Anders Carlsson  <andersca@apple.com>
85
86         Add WTF::ScopeExit
87         https://bugs.webkit.org/show_bug.cgi?id=160908
88
89         Reviewed by Geoffrey Garen.
90
91         * TestWebKitAPI/CMakeLists.txt:
92         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
93         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
94         (TestWebKitAPI::TEST):
95
96 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
97
98         EWS logs file are rotated too quickly
99         https://bugs.webkit.org/show_bug.cgi?id=160724
100
101         Reviewed by Daniel Bates.
102
103         Currently we are rotating the log file after 10 iterations of queue. If the queue
104         doesn't have any pending patches, these iterations result in very small amount of 
105         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
106         This results in a lot of log files in a day. This patch ensures that we rotate the
107         log file when its file size is greater than or equal to 100 KB.
108
109         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
110
111 2016-08-16  Daniel Bates  <dabates@apple.com>
112
113         WKSI static library should be named by major iOS revision, not individual updates
114         https://bugs.webkit.org/show_bug.cgi?id=160727
115         <rdar://problem/22274848>
116
117         Reviewed by Alexey Proskuryakov.
118
119         * DumpRenderTree/mac/Configurations/Base.xcconfig:
120         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
121         * Scripts/copy-webkitlibraries-to-product-directory:
122         * WebKitTestRunner/Configurations/Base.xcconfig:
123         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
124
125 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
126
127         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
128         https://bugs.webkit.org/show_bug.cgi?id=160909
129
130         Reviewed by Enrica Casucci.
131         
132         Add functions to UIScriptController to dismiss the form accessory view for iOS,
133         and to programmatically pick a row from a <select> picker.
134
135         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
136         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
137         (WTR::UIScriptController::dismissFormAccessoryView):
138         (WTR::UIScriptController::selectFormAccessoryPickerRow):
139         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
140         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
141         (WTR::UIScriptController::dismissFormAccessoryView):
142         (WTR::UIScriptController::selectFormAccessoryPickerRow):
143
144 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
145
146         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
147         https://bugs.webkit.org/show_bug.cgi?id=160878
148
149         Reviewed by Tim Horton.
150         
151         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
152         now that we have the ability to run tests in the iPad simulator.
153
154         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
155         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
156         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
157         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
158         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
159         * WebKitTestRunner/ios/TestControllerIOS.mm:
160         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
161         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
162         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
163         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
164
165 2016-08-15  Anders Carlsson  <andersca@apple.com>
166
167         Add an address-of operator to RetainPtr
168         https://bugs.webkit.org/show_bug.cgi?id=160879
169
170         Reviewed by Tim Horton.
171
172         Test HashMap and HashSet with an object whose operator& is deleted.
173
174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
175         Sort the Xcode project.
176
177         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
178         (DeletedAddressOfOperator::DeletedAddressOfOperator):
179         (DeletedAddressOfOperator::value):
180         (DeletedAddressOfOperator::operator==):
181         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
182         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
183         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
184         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
185         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
186         (TestWebKitAPI::TEST):
187         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
188         (TestWebKitAPI::TEST):
189
190 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
191
192         False crashes in fast/text/emoji-gender-* tests
193         https://bugs.webkit.org/show_bug.cgi?id=160779
194
195         Reviewed by Alexey Proskuryakov.
196
197         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
198
199         * Scripts/webkitpy/port/driver.py:
200         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
201         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
202         * Scripts/webkitpy/port/server_process.py:
203         (ServerProcess.write): Allow caller to disable crash flag on exception.
204
205 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
206
207         webkitpy error in TestRunResults.merge()
208         https://bugs.webkit.org/show_bug.cgi?id=160882
209
210         Reviewed by Daniel Bates.
211         
212         The argument to TestRunResults.merge() can be None if there are no device-specifc
213         initial results or retry results in Manager.run(), so just return early in that case.
214
215         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
216         (TestRunResults.merge):
217
218 2016-08-15  Sam Weinig  <sam@webkit.org>
219
220         Speed up compile times by not including wtf/Variant.h so much
221         https://bugs.webkit.org/show_bug.cgi?id=160847
222
223         Reviewed by Alex Christensen and Saam Barati.
224
225         * TestWebKitAPI/Tests/WTF/Variant.cpp:
226         (TestWebKitAPI::TEST):
227         Explicitly use std::experimental::variant.
228
229 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
230
231         Allow a port to run tests with a custom device setup
232         https://bugs.webkit.org/show_bug.cgi?id=160833
233
234         Reviewed by Daniel Bates.
235
236         These changes allow the IOSSimulator port to run tests in iPad mode.
237
238         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
239         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
240         a custom device will be collected into a set, and run in that device's environment after
241         the other tests have run.
242
243         * Scripts/webkitpy/layout_tests/controllers/manager.py:
244         (Manager._custom_device_for_test): If the test contains a directory matching a
245         custom device suffix, return that custom device.
246         (Manager._set_up_run): Push the custom device class, if any, into options so
247         that the Worker can get to it.
248         (Manager.run): Go through the list of tests, and break it down into device-generic
249         tests, and tests for each device class. _run_test_subset is then called for
250         each collection of tests, and the results merged.
251         (Manager._run_test_subset): Some lines unwrapped.
252         (Manager._end_test_run):
253         (Manager._run_tests):
254         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
255         (SingleTestRunner.__init__): Unwrapped a line.
256         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
257         (TestRunResults.merge): Add this function to merge TestRunResults
258         * Scripts/webkitpy/layout_tests/views/printing.py:
259         (Printer.print_workers_and_shards): Print the custom device, if any.
260         * Scripts/webkitpy/port/base.py:
261         (Port): Base port has empty array of custom devices.
262         (Port.setup_test_run): Add device_class argument.
263         * Scripts/webkitpy/port/driver.py:
264         (DriverInput.__repr__):
265         (Driver.check_driver.implementation):
266         * Scripts/webkitpy/port/efl.py:
267         (EflPort.setup_test_run):
268         * Scripts/webkitpy/port/gtk.py:
269         (GtkPort.setup_test_run):
270         * Scripts/webkitpy/port/ios.py:
271         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
272         (IOSSimulatorPort.__init__):
273         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
274         based on the custom device class.
275         (IOSSimulatorPort._set_device_class):
276         (IOSSimulatorPort._create_simulators): Factor some code into this function.
277         (IOSSimulatorPort.setup_test_run):
278         (IOSSimulatorPort.testing_device):
279         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
280         seemed wrong for this function. That was moved to setup_test_run().
281         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
282         but this happened too early, before we knew which kind of devices to create. Devices
283         are now created in setup_test_run().
284         * Scripts/webkitpy/port/win.py:
285         (WinPort.setup_test_run):
286
287 2016-08-15  Daniel Bates  <dabates@apple.com>
288
289         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
290         private frameworks and libraries
291         https://bugs.webkit.org/show_bug.cgi?id=155931
292         <rdar://problem/25807989>
293
294         Reviewed by Dan Bernstein.
295
296         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
297         where X is the major version of the active iOS SDK.
298
299         * DumpRenderTree/mac/Configurations/Base.xcconfig:
300         * WebKitTestRunner/Configurations/Base.xcconfig:
301
302 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
303
304         Add a setting and preferences to enable visual viewport mode
305         https://bugs.webkit.org/show_bug.cgi?id=160843
306
307         Reviewed by Sam Weinig.
308         
309         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
310
311         * MiniBrowser/mac/SettingsController.h:
312         * MiniBrowser/mac/SettingsController.m:
313         (-[SettingsController _populateMenu]):
314         (-[SettingsController validateMenuItem:]):
315         (-[SettingsController visualViewportEnabled]):
316         (-[SettingsController toggleVisualViewportEnabled:]):
317         * MiniBrowser/mac/WK1BrowserWindowController.m:
318         (-[WK1BrowserWindowController didChangeSettings]):
319         * MiniBrowser/mac/WK2BrowserWindowController.m:
320         (-[WK2BrowserWindowController didChangeSettings]):
321
322 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
323
324         Allow using make-dist with non-GTK ports
325         https://bugs.webkit.org/show_bug.cgi?id=160842
326
327         Reviewed by Michael Catanzaro.
328
329         This patch adds support for setting base name of tarball and argument
330         passed to cmake's -DPORT= via command line arguments.
331
332         * gtk/make-dist.py:
333         (Distcheck.configure):
334         (Distcheck.check):
335         (get_tarball_root_and_output_filename_from_arguments):
336
337 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
338
339         [GTK] Install script lacks gstreamer related dependencies
340         https://bugs.webkit.org/show_bug.cgi?id=160814
341
342         Reviewed by Carlos Garcia Campos.
343
344         * gtk/install-dependencies: Fedora case had already listed this dependencies,
345         but both Arch and Debian/Ubuntu were missing them.
346
347 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
348
349         make-dist.py should not allow unknown rules in manifest
350         https://bugs.webkit.org/show_bug.cgi?id=160841
351
352         Reviewed by Carlos Garcia Campos.
353
354         * gtk/make-dist.py:
355         (Manifest.process_line):
356
357 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
358
359         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
360         https://bugs.webkit.org/show_bug.cgi?id=160809
361
362         Reviewed by Carlos Garcia Campos.
363
364         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
365         case, and use it also for the new package names of libpng and libgeoclue.
366         * gtk/install-dependencies: Ditto.
367
368 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
369
370         Skip to check directories existence in build-webkit
371         https://bugs.webkit.org/show_bug.cgi?id=160691
372
373         Reviewed by Alex Christensen.
374
375         CMake checks if directories are there itself. So CMake ports
376         don't need to check it in the build-webkit script.
377
378         * Scripts/build-webkit:
379         * Scripts/webkitdirs.pm:
380         (determineSourceDir):
381         (isCMakeBuild):
382
383 2016-08-12  Alex Christensen  <achristensen@webkit.org>
384
385         Make URLParser work with URLs missing URL parts
386         https://bugs.webkit.org/show_bug.cgi?id=160824
387
388         Reviewed by Brady Eidson.
389
390         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
391         (TestWebKitAPI::s):
392         (TestWebKitAPI::checkURL):
393         (TestWebKitAPI::TEST_F):
394         (TestWebKitAPI::eq): Deleted.
395
396 2016-08-12  John Wilander  <wilander@apple.com>
397
398         Add HashCountedSet API tests to TestWTFLibrary target
399         https://bugs.webkit.org/show_bug.cgi?id=160815
400
401         Reviewed by Alex Christensen.
402
403         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
404             Added HashCountedSet.cpp and sorted the file reference section
405             according to UNIX sort.
406
407 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
408
409         run-benchmark should run JetStream 1.1 instead of 1.0.1
410         https://bugs.webkit.org/show_bug.cgi?id=160816
411
412         Reviewed by Filip Pizlo.
413
414         Use the latest JetStream 1.1 in run-benchmark.
415
416         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
417         (BenchmarkBuilder.__exit__):
418         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
419         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
420         change to JetStream directory.
421
422 2016-08-12  Alex Christensen  <achristensen@webkit.org>
423
424         Initial URLParser implementation
425         https://bugs.webkit.org/show_bug.cgi?id=160811
426
427         Reviewed by Brady Eidson.
428
429         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
430         (TestWebKitAPI::eq):
431         (TestWebKitAPI::checkURL):
432         (TestWebKitAPI::TEST_F):
433
434 2016-08-12  Brady Eidson  <beidson@apple.com>
435
436         Fix the 32-bit Mac build after:
437         Add WK2 ExperimentalFeature support to MiniBrowser
438         https://bugs.webkit.org/show_bug.cgi?id=160788
439
440         Unreviewed.
441
442         Sprinkle "#if WK_API_ENABLED"s liberally.
443         
444         * MiniBrowser/mac/AppDelegate.m:
445         (defaultConfiguration):
446         * MiniBrowser/mac/SettingsController.m:
447         (-[SettingsController _populateMenu]):
448         (-[SettingsController validateMenuItem:]):
449
450 2016-08-12  Philippe Normand  <pnormand@igalia.com>
451
452         [GStreamer][OWR] Video rendering fixes
453         https://bugs.webkit.org/show_bug.cgi?id=160764
454
455         Reviewed by Xabier Rodriguez-Calvar.
456
457         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
458
459 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
460
461         Add missing return statement in convertFast function added in r204376.
462
463         Unreviewed.
464
465         * Scripts/webkitpy/common/system/path.py:
466         (_CygPath.convertFast):
467
468 2016-08-11  Brady Eidson  <beidson@apple.com>
469
470         Add WK2 ExperimentalFeature support to MiniBrowser.
471         https://bugs.webkit.org/show_bug.cgi?id=160788
472
473         Reviewed by Alex Christensen.
474
475         * MiniBrowser/mac/AppDelegate.h:
476         * MiniBrowser/mac/AppDelegate.m:
477         (defaultConfiguration):
478         (defaultPreferences):
479         
480         * MiniBrowser/mac/SettingsController.m:
481         (-[SettingsController _populateMenu]):
482         (-[SettingsController validateMenuItem:]):
483         (-[SettingsController toggleExperimentalFeature:]):
484
485 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
486
487         Keep EWS logs for longer
488         https://bugs.webkit.org/show_bug.cgi?id=160776
489
490         Reviewed by Daniel Bates.
491
492         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
493
494 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
495
496         iOS DRT/WTR project cleanup
497         https://bugs.webkit.org/show_bug.cgi?id=160778
498
499         Reviewed by Tim Horton.
500
501         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
502
503         Remove AppDelegate.* which were unused.
504
505         Exclude ios/Launch.storyboard on more platforms.
506
507         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
508         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
509         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
510         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
511         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
512         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
513         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
514
515 2016-08-11  Alex Christensen  <achristensen@webkit.org>
516
517         Fix Yosemite bots' cookie accept policies after r204365.
518         https://bugs.webkit.org/show_bug.cgi?id=160758
519
520         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
521         (TEST):
522         This makes the test fully clean up after itself.
523
524 2016-08-11  Alex Christensen  <achristensen@webkit.org>
525
526         Fix Yosemite bots' cookie accept policies after r204365.
527         https://bugs.webkit.org/show_bug.cgi?id=160758
528
529         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
530         (TEST):
531         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
532         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
533         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
534         causing any problems because there are no other API tests that do anything with cookies.
535         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
536         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
537         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
538
539 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
540
541         EWS should check if the patch is still valid before executing every major step
542         https://bugs.webkit.org/show_bug.cgi?id=160739
543         rdar://problem/27768813
544
545         Reviewed by Alexey Proskuryakov.
546
547         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
548         (CommitQueueTask.run): validate method is now executed in base class.
549         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
550         (EarlyWarningSystemTask.run): validate method is now executed in base class.
551         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
552         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
553         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
554         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
555         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
556         * Scripts/webkitpy/tool/commands/perfalizer.py:
557         (PerfalizerTask.validate): Added.
558         * Scripts/webkitpy/tool/commands/queues_unittest.py:
559         (test_manual_reject_during_processing): Updated test case.
560
561 2016-08-11  Alex Christensen  <achristensen@webkit.org>
562
563         Add URLParser stub
564         https://bugs.webkit.org/show_bug.cgi?id=160770
565
566         Reviewed by Sam Weinig.
567
568         * TestWebKitAPI/PlatformGTK.cmake:
569         * TestWebKitAPI/PlatformWin.cmake:
570         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
571         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
572         (TestWebKitAPI::TEST_F):
573
574 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
575
576         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
577         https://bugs.webkit.org/show_bug.cgi?id=160761
578
579         Reviewed by Tim Horton.
580
581         Give iOS DRT a Launch storyboard.
582
583         Have it use a UIViewController so future forms testing works correctly.
584
585         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
586         can run in iPad mode.
587
588         Remove empty InfoPlist.strings files.
589
590         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
591         * DumpRenderTree/ios/Info.plist:
592         * DumpRenderTree/ios/Launch.storyboard: Added.
593         * DumpRenderTree/mac/DumpRenderTree.mm:
594         (createWebViewAndOffscreenWindow):
595         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
596         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
597         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
598         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
599
600 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
601
602         [Win] Unable to reliably run tests in parallel
603         https://bugs.webkit.org/show_bug.cgi?id=140914
604
605         Reviewed by Brent Fulgham.
606
607         The cygpath utility function can fail badly when running with multiple DumpRenderTree
608         processes. We can use string replacement to convert the Cygwin path to a Windows path
609         instead.
610
611         * Scripts/webkitpy/common/system/path.py:
612         (cygpathFast):
613         * Scripts/webkitpy/port/driver.py:
614         (Driver._command_from_driver_input):
615
616 2016-08-10  Alex Christensen  <achristensen@webkit.org>
617
618         Fix crash when changing cookie accept policy after r204327
619         https://bugs.webkit.org/show_bug.cgi?id=160758
620
621         Reviewed by Simon Fraser.
622
623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
624         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
625         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
626         (TEST):
627         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
628
629 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
630
631         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
632         https://bugs.webkit.org/show_bug.cgi?id=160757
633
634         Reviewed by Tim Horton.
635
636         When programmatically creating the test UIWindow, make a root UIViewController and parent
637         the WKWebView in its view. This makes the app more like a normal UIKit application.
638         
639         Move the WKWebView down 20px to avoid the status bar.
640         
641         Give the UIWindow a gray background so it's obvious where the window and view positioned.
642
643         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
644         
645         Remove duplicate references to Launch.storyboard.
646
647         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
648         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
649         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
650         (-[AppDelegate applicationWillResignActive:]): Deleted.
651         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
652         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
653         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
654         (-[AppDelegate applicationWillTerminate:]): Deleted.
655         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
656         (WTR::viewRectForWindowRect):
657         (WTR::PlatformWebView::PlatformWebView):
658         (WTR::PlatformWebView::setWindowFrame):
659
660 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
661
662         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
663         https://bugs.webkit.org/show_bug.cgi?id=160748
664
665         Reviewed by Tim Horton.
666         
667         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
668         opens the door for tests using other device sizes.
669
670         * WebKitTestRunner/ios/TestControllerIOS.mm:
671         (WTR::TestController::platformConfigureViewForTest):
672
673 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
674
675         Sort the feature flags in the FEATURE_DEFINES lines
676         https://bugs.webkit.org/show_bug.cgi?id=160742
677
678         Reviewed by Anders Carlsson.
679         
680         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
681
682 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
683
684         Logging and other minor improvements to iOS webkitpy
685         https://bugs.webkit.org/show_bug.cgi?id=160722
686
687         Reviewed by Dan Bates.
688
689         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
690         to make it easier to debug launching issues.
691
692         Have reset_preferences() reset the device, rather than just nuking the data
693         directory (which broke some versions of the simulator).
694
695         Make the Simulator.app launch in the background with open -g.
696
697         Wait for the simulator device to be in a known state in some more places.
698
699         * Scripts/webkitpy/port/ios.py:
700         (IOSSimulatorPort.setup_test_run):
701         (IOSSimulatorPort._quit_ios_simulator):
702         (IOSSimulatorPort.clean_up_test_run):
703         (IOSSimulatorPort.setup_environ_for_server):
704         (IOSSimulatorPort.reset_preferences):
705         * Scripts/webkitpy/xcode/simulator.py:
706         (Device.create):
707         (Device.delete):
708         (Device):
709         (Device.reset):
710         (Simulator.wait_until_device_is_booted):
711         (Simulator.wait_until_device_is_in_state):
712         (Simulator):
713         (Simulator.delete_device):
714         (Simulator.reset_device):
715         (Simulator.lookup_or_create_device):
716
717 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
718
719         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
720         https://bugs.webkit.org/show_bug.cgi?id=160697
721
722         Reviewed by Antonio Gomes.
723
724         * Scripts/webkitpy/port/base.py:
725         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
726         list of environment variables to copy.
727
728 2016-08-09  George Ruan  <gruan@apple.com>
729
730         Implement functionality of media capture on iOS
731         https://bugs.webkit.org/show_bug.cgi?id=158945
732         <rdar://problem/26893343>
733
734         Reviewed by Tim Horton.
735
736         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
737         Capture feature on iOS.
738
739 2016-08-09  Saam Barati  <sbarati@apple.com>
740
741         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
742         https://bugs.webkit.org/show_bug.cgi?id=160671
743         <rdar://problem/27756112>
744
745         Reviewed by Mark Lam.
746
747         * Scripts/run-jsc-stress-tests:
748
749 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
750
751         Make directory reading code in iOSSimulatorDevices() more strict
752         https://bugs.webkit.org/show_bug.cgi?id=160702
753
754         Reviewed by Tim Horton.
755
756         * Scripts/webkitdirs.pm:
757         (iOSSimulatorDevices):
758
759 2016-08-06  Sam Weinig  <sam@webkit.org>
760
761         Replace NodeOrString with std::variant<RefPtr<Node>, String>
762         https://bugs.webkit.org/show_bug.cgi?id=160638
763
764         Reviewed by Anders Carlsson.
765
766         * TestWebKitAPI/CMakeLists.txt:
767         * TestWebKitAPI/Tests/WTF/Variant.cpp:
768         Add additional tests for the initial state of std::variant and using
769         makeVisitor for visiting.
770
771 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
772
773         EWS logging should ensure the logging to file is stopped on queue termination
774         https://bugs.webkit.org/show_bug.cgi?id=160698
775         rdar://problem/24464570
776
777         Reviewed by Daniel Bates.
778
779         * Scripts/webkitpy/tool/bot/queueengine.py:
780         (QueueEngine._stopping): Stop logging to file on queue termination.
781         (QueueEngine._begin_logging): Configure the Python logger to log to file.
782         * Scripts/webkitpy/common/system/logutils.py:
783         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
784         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
785         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
786         * Scripts/webkitpy/tool/commands/queues.py:
787         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
788         (AbstractQueue.queue_log_path): Same.
789         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
790         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
791         which moved to QueueEngine now.
792         (PatchProcessingQueue.__init__): Same.
793         (CommitQueue.__init__): Same.
794         (AbstractReviewQueue.__init__): Same.
795         (StyleQueue.__init__): Same.
796         * Scripts/webkitpy/tool/commands/queues_unittest.py:
797         (TestCommitQueue): Removed host parameter.
798         (TestCommitQueue.__init__): Same.
799         (AbstractPatchQueueTest.test_next_patch): Same.
800         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
801         (test_commit_queue_failure): Same.
802         (mock_run_webkit_patch):
803         (MockCommitQueueTask.results_from_patch_test_run): Same.
804         (test_rollout_lands): Same.
805         (test_non_valid_patch): Same.
806         (test_auto_retry): Same.
807         (test_style_queue_with_watch_list_exception): Same.
808         (TestQueue.__init__): Deleted.
809         (TestReviewQueue.__init__): Deleted.
810         (TestFeederQueue.__init__): Deleted.
811
812 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
813
814         webkit-gtk tarball fails to build due to missing files
815         https://bugs.webkit.org/show_bug.cgi?id=160684
816
817         Reviewed by Alex Christensen.
818
819         * gtk/manifest.txt.in: Added back spi directories.
820
821 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
822
823         [GTK] Build the jhbuild with -O2 optimization level by default
824         https://bugs.webkit.org/show_bug.cgi?id=160544
825
826         Reviewed by Michael Catanzaro.
827
828         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
829         which don't increases the required disk space significatively and
830         provides better debug information than no passing it.
831
832 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
833
834         Allow more --cmakeargs option in build-jsc and build-webkit
835         https://bugs.webkit.org/show_bug.cgi?id=160340
836
837         Reviewed by Michael Catanzaro.
838
839         * Scripts/build-jsc:
840         * Scripts/build-webkit:
841
842 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
843
844         Do not check if WebKitLibraries folder exists on EFL and GTK
845         https://bugs.webkit.org/show_bug.cgi?id=160659
846
847         Reviewed by Csaba Osztrogonác.
848
849         Though WebKitLibraries is only needed by mac and win ports,
850         EFL and GTK ports have checked whether it exists.
851
852         * Scripts/build-webkit:
853
854 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
855
856         Some EWS console logs doesn't go to log file
857         https://bugs.webkit.org/show_bug.cgi?id=160585
858         rdar://problem/24464570
859
860         Reviewed by Daniel Bates.
861
862         * Scripts/webkitpy/common/system/logutils.py:
863         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
864         any possible overwriting.
865         * Scripts/webkitpy/common/system/filesystem.py:
866         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
867         * Scripts/webkitpy/common/system/filesystem_mock.py:
868         (MockFileSystem.open_text_file_for_writing): Same.
869         * Scripts/webkitpy/common/system/filesystem_unittest.py:
870         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
871         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
872         * Scripts/webkitpy/tool/commands/queues.py:
873         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
874         This will ensure that all the sub-modules inside webkitpy will log to file.
875
876 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
877
878         Have the iOS platform interit from the Apple platform in webkitpy
879         https://bugs.webkit.org/show_bug.cgi?id=160672
880
881         Reviewed by Dan Bates.
882         
883         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
884         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
885         ApplePort.
886         
887         Since WinPort also inherits from ApplePort, it needs to stub out some things
888         that are unavailable on Windows (leaks, sampling).
889         
890         Some SnowLeopard-related code and the associated test were removed.
891
892         * Scripts/webkitpy/port/apple.py:
893         (ApplePort.__init__):
894         (ApplePort):
895         (ApplePort._make_leak_detector):
896         (ApplePort.default_timeout_ms):
897         (ApplePort.supports_per_test_timeout):
898         (ApplePort.should_retry_crashes):
899         (ApplePort._generate_all_test_configurations):
900         (ApplePort.check_for_leaks):
901         (ApplePort.print_leaks_summary):
902         (ApplePort._path_to_webcore_library):
903         (ApplePort.show_results_html_file):
904         (ApplePort._merge_crash_logs):
905         (ApplePort._look_for_all_crash_logs_in_log_dir):
906         (ApplePort._get_crash_log):
907         (ApplePort.look_for_new_crash_logs):
908         (ApplePort.sample_process):
909         (ApplePort.sample_file_path):
910         (ApplePort.look_for_new_samples):
911         (ApplePort._path_to_helper):
912         (ApplePort.determine_full_port_name): Deleted.
913         * Scripts/webkitpy/port/ios.py:
914         (IOSSimulatorPort):
915         (IOSSimulatorPort.__init__):
916         (IOSSimulatorPort.default_timeout_ms): Deleted.
917         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
918         (IOSSimulatorPort.should_retry_crashes): Deleted.
919         (IOSSimulatorPort.check_for_leaks): Deleted.
920         (IOSSimulatorPort.print_leaks_summary): Deleted.
921         (IOSSimulatorPort._path_to_webcore_library): Deleted.
922         (IOSSimulatorPort.show_results_html_file): Deleted.
923         (IOSSimulatorPort.sample_file_path): Deleted.
924         (IOSSimulatorPort._merge_crash_logs): Deleted.
925         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
926         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
927         (IOSSimulatorPort.look_for_new_samples): Deleted.
928         (IOSSimulatorPort.sample_process): Deleted.
929         (IOSSimulatorPort._path_to_helper): Deleted.
930         (IOSSimulatorPort.make_command): Deleted.
931         * Scripts/webkitpy/port/mac.py:
932         (MacPort.__init__):
933         (MacPort.make_command):
934         (MacPort._build_java_test_support):
935         (MacPort): Deleted.
936         (MacPort.default_timeout_ms): Deleted.
937         (MacPort.supports_per_test_timeout): Deleted.
938         (MacPort.should_retry_crashes): Deleted.
939         (MacPort.default_child_processes): Deleted.
940         (MacPort.check_for_leaks): Deleted.
941         (MacPort.print_leaks_summary): Deleted.
942         (MacPort._path_to_webcore_library): Deleted.
943         (MacPort.show_results_html_file): Deleted.
944         (MacPort.sample_file_path): Deleted.
945         (MacPort._merge_crash_logs): Deleted.
946         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
947         (MacPort.look_for_new_crash_logs): Deleted.
948         (MacPort.look_for_new_samples): Deleted.
949         (MacPort.sample_process): Deleted.
950         (MacPort._path_to_helper): Deleted.
951         * Scripts/webkitpy/port/mac_unittest.py:
952         (MacTest.test_default_child_processes): Deleted.
953         * Scripts/webkitpy/port/win.py:
954         (WinPort.look_for_new_samples):
955         (WinPort):
956         (WinPort.sample_process):
957         (WinPort._make_leak_detector):
958         (WinPort.check_for_leaks):
959         (WinPort.print_leaks_summary):
960         (WinPort._path_to_webcore_library):
961
962 2016-08-08  Matt Baker  <mattbaker@apple.com>
963
964         Unreviewed: moved myself to the reviewers list.
965
966         * Scripts/webkitpy/common/config/contributors.json:
967
968 2016-08-08  Chris Dumez  <cdumez@apple.com>
969
970         Update API tests in mac/SetDocumentURI.mm after r204247
971         https://bugs.webkit.org/show_bug.cgi?id=160660
972
973         Reviewed by Alex Christensen.
974
975         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
976         (TestWebKitAPI::TEST):
977
978 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
979
980         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
981         https://bugs.webkit.org/show_bug.cgi?id=159827
982
983         Reviewed by Daniel Bates.
984
985         This change was spurred by a process hang which occurred between tests and did
986         not produce a meaningful crashlog.
987
988         * Scripts/webkitpy/port/driver.py:
989         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
990
991          * Scripts/webkitpy/port/ios.py:
992         (IOSSimulatorPort):
993         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
994         * Scripts/webkitpy/port/mac.py:
995         (MacPort):
996         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
997
998         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
999         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1000
1001         * WebKitTestRunner/TestController.h:
1002         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1003         * WebKitTestRunner/TestInvocation.cpp:
1004         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1005
1006 2016-08-07  Dan Bernstein  <mitz@apple.com>
1007
1008         [Cocoa] Reply block leaks if the remote object doesn’t call it
1009         https://bugs.webkit.org/show_bug.cgi?id=160642
1010
1011         Reviewed by Sam Weinig.
1012
1013         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
1014         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1015         (TEST): Added a test case that checks that the reply block is released even when it’s not
1016           called.
1017         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1018         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
1019           calling the completion handler.
1020
1021 2016-08-07  Chris Dumez  <cdumez@apple.com>
1022
1023         Write API test to cover crash fix in r204135
1024         https://bugs.webkit.org/show_bug.cgi?id=160587
1025
1026         Reviewed by Darin Adler.
1027
1028         Add API test to cover crash fix in r204135. This reproduces the crash
1029         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1030         callback.
1031
1032         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1033         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1034         (TEST):
1035
1036 2016-08-06  Chris Dumez  <cdumez@apple.com>
1037
1038         Unreviewed, rolling out r204226.
1039
1040         Broke some API tests
1041
1042         Reverted changeset:
1043
1044         "Write API test to cover crash fix in r204135"
1045         https://bugs.webkit.org/show_bug.cgi?id=160587
1046         http://trac.webkit.org/changeset/204226
1047
1048 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
1049
1050         EWS Style Queue fails to process patches which fails validation
1051         https://bugs.webkit.org/show_bug.cgi?id=160632
1052
1053         Reviewed by Alexey Proskuryakov.
1054
1055         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1056         (StyleQueueTask.validate): Add more information about validation failure.
1057         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1058         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1059         (test_non_valid_patch): Add a unit test to test the above code path.
1060
1061 2016-08-06  Sam Weinig  <sam@webkit.org>
1062
1063         WTF needs a variant implementation
1064         https://bugs.webkit.org/show_bug.cgi?id=160618
1065
1066         Reviewed by Darin Adler.
1067
1068         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1069         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
1070         Add tests for the variant implementation.
1071
1072 2016-08-06  Chris Dumez  <cdumez@apple.com>
1073
1074         Write API test to cover crash fix in r204135
1075         https://bugs.webkit.org/show_bug.cgi?id=160587
1076
1077         Reviewed by Darin Adler.
1078
1079         Add API test to cover crash fix in r204135. This reproduces the crash
1080         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1081         callback.
1082
1083         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1084         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1085         (TEST):
1086
1087 2016-08-05  Tim Horton  <timothy_horton@apple.com>
1088
1089         run-api-tests should use a headed simulator
1090         https://bugs.webkit.org/show_bug.cgi?id=160611
1091
1092         Reviewed by Sam Weinig.
1093
1094         CADisplayLink doesn't work in a headless simulator, but is
1095         vital for the proper functioning of WebKit2 painting on iOS.
1096         So, we should not use a headless simulator.
1097
1098         * Scripts/run-api-tests:
1099         Launch a simulator app, don't just boot the simulator.
1100
1101         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1102         Re-enable a test that works now.
1103
1104 2016-08-05  Dan Bernstein  <mitz@apple.com>
1105
1106         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
1107         https://bugs.webkit.org/show_bug.cgi?id=160589
1108
1109         Reviewed by Tim Horton.
1110
1111         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1112         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
1113           blocks, which wasn’t caught because the test wasn’t run correctly.
1114         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1115         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
1116           added a test that sends over an NSRange.
1117         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1118         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
1119           handler with the range‘s location and length.
1120
1121 2016-08-05  Enrica Casucci  <enrica@apple.com>
1122
1123         Fixing tests failing after r204175.
1124
1125         Unreviewed.
1126
1127         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
1128
1129 2016-08-05  Enrica Casucci  <enrica@apple.com>
1130
1131         Build fix after 204053.
1132
1133         Unreviewed.
1134
1135         * TestWebKitAPI/Configurations/Base.xcconfig:
1136         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1137         (-[MockContentFilterEnabler initWithCoder:]):
1138         (-[MockContentFilterEnabler dealloc]):
1139
1140 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
1141
1142         Print test name in "Last character read from DRT..." error message.
1143         https://bugs.webkit.org/show_bug.cgi?id=160559
1144
1145         Reviewed by Michael Catanzaro.
1146
1147         * Scripts/webkitpy/port/driver.py:
1148         (Driver.run_test):
1149         (Driver._read_first_block):
1150         (Driver._read_optional_image_block):
1151         (Driver._read_block):
1152         * Scripts/webkitpy/port/driver_unittest.py:
1153         (DriverTest.test_read_block):
1154         (DriverTest.test_read_binary_block):
1155         (DriverTest.test_read_base64_block):
1156
1157 2016-08-05  Commit Queue  <commit-queue@webkit.org>
1158
1159         Unreviewed, rolling out r204123.
1160         https://bugs.webkit.org/show_bug.cgi?id=160597
1161
1162         Caused layout test timeouts on Windows. (Requested by perarne
1163         on #webkit).
1164
1165         Reverted changeset:
1166
1167         "[Win] Unable to reliably run tests in parallel"
1168         https://bugs.webkit.org/show_bug.cgi?id=140914
1169         http://trac.webkit.org/changeset/204123
1170
1171 2016-08-04  Saam Barati  <sbarati@apple.com>
1172
1173         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1174         https://bugs.webkit.org/show_bug.cgi?id=151241
1175
1176         Reviewed by Benjamin Poulain.
1177
1178         * Scripts/run-jsc-stress-tests:
1179
1180 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1181
1182         UI improvements to Flakiness Dashboard.
1183         https://bugs.webkit.org/show_bug.cgi?id=153295
1184
1185         Reviewed by Alexey Proskuryakov.
1186
1187         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1188         (td.options-container): Center text in most fields.
1189         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1190         (createBugHTML): Text/Grammar updates.
1191         (tableHeaders): Ditto.
1192         (htmlForSingleTestRow): Ditto.
1193         (headerForTestTableHtml): Ditto.
1194         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1195         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1196
1197 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1198
1199         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1200         https://bugs.webkit.org/show_bug.cgi?id=160518
1201
1202         Reviewed by Michael Catanzaro.
1203
1204         * Scripts/webkitpy/thirdparty/__init__.py:
1205         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1206         * gtk/install-dependencies:
1207
1208 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1209
1210         Optimize bot watcher's dashboard a little
1211         https://bugs.webkit.org/show_bug.cgi?id=160515
1212         rdar://problem/26096900
1213
1214         Reviewed by Lucas Forschler.
1215
1216         Made re-sorting after loading an iteration more efficient.
1217
1218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1219         (BuildbotIteration.prototype._updateWithData):
1220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1221         (BuildbotQueue.prototype.updateIterationPosition):
1222
1223 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1224
1225         [Win] Unable to reliably run tests in parallel
1226         https://bugs.webkit.org/show_bug.cgi?id=140914
1227
1228         Reviewed by Brent Fulgham.
1229
1230         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1231         processes. We can use string replacement to convert the Cygwin path to a Windows path
1232         instead.
1233  
1234         * Scripts/webkitpy/common/system/path.py:
1235         (cygpathFast):
1236         * Scripts/webkitpy/port/driver.py:
1237         (Driver._command_from_driver_input):
1238
1239 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1240
1241         Document instructions for increasing process and file limits
1242         https://bugs.webkit.org/show_bug.cgi?id=160528
1243         rdar://problem/24777576
1244
1245         Reviewed by Alexey Proskuryakov.
1246
1247         * Scripts/webkitpy/port/ios.py:
1248         (IOSSimulatorPort.default_child_processes):
1249
1250 2016-08-03  Anders Carlsson  <andersca@apple.com>
1251
1252         Remove the Objective-C bindings generator
1253         https://bugs.webkit.org/show_bug.cgi?id=160526
1254
1255         Reviewed by Sam Weinig.
1256
1257         * Scripts/run-bindings-tests:
1258         Update test.
1259
1260 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1261
1262         Revise a TestWebKitAPI comment to mention the actual underlying problem
1263
1264         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1265         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1266
1267 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1268
1269         Benchmark test content-animation timeouts always
1270         https://bugs.webkit.org/show_bug.cgi?id=160057
1271
1272         Reviewed by Simon Fraser.
1273
1274         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1275         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1276         (start):
1277
1278 2016-08-02  Nan Wang  <n_wang@apple.com>
1279
1280         AX: Simulated touch events are not working on iOS
1281         https://bugs.webkit.org/show_bug.cgi?id=160395
1282         <rdar://problem/27633597>
1283
1284         Reviewed by Chris Fleizach.
1285
1286         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1287         (WTR::AccessibilityUIElement::press):
1288         (WTR::AccessibilityUIElement::setSelectedChild):
1289
1290 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1291
1292         run-javascriptcore-tests should accept multiple --extra-tests
1293         https://bugs.webkit.org/show_bug.cgi?id=160486
1294
1295         Reviewed by Saam Barati.
1296         
1297         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1298         test suites. This does it by using GetOpt::Long's array support.
1299
1300         * Scripts/run-javascriptcore-tests:
1301         (runJSCStressTests):
1302
1303 2016-08-02  Enrica Casucci  <enrica@apple.com>
1304
1305         Allow building with content filtering disabled.
1306         https://bugs.webkit.org/show_bug.cgi?id=160454
1307
1308         Reviewed by Simon Fraser.
1309
1310         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1311
1312 2016-08-02  Brady Eidson  <beidson@apple.com>
1313
1314         Removing IndexedDB WebsiteData can fail for some users.
1315         https://bugs.webkit.org/show_bug.cgi?id=160463
1316
1317         Reviewed by Alex Christensen.
1318
1319         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1320
1321 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1322
1323         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1324         https://bugs.webkit.org/show_bug.cgi?id=160437
1325         <rdar://problem/27578272>
1326
1327         Reviewed by Brady Eidson.
1328
1329         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1330         (-[DownloadDelegate _download:didReceiveResponse:]):
1331         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1332         (runTest):
1333         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1334
1335 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1336
1337         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1338         https://bugs.webkit.org/show_bug.cgi?id=160414
1339
1340         Reviewed by Michael Catanzaro.
1341
1342         * Scripts/webkitpy/port/linux_get_crash_log.py:
1343         (GDBCrashLogGenerator._wait_for_corefile):
1344
1345 2016-08-01  Youenn Fablet  <youenn@apple.com>
1346
1347         Make wpt server generate its certificates in layout test results folder
1348         https://bugs.webkit.org/show_bug.cgi?id=160422
1349
1350         Reviewed by Chris Dumez.
1351
1352         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1353         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1354
1355 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1356
1357         Function Call on NULL Object
1358         https://bugs.webkit.org/show_bug.cgi?id=160325
1359
1360         Reviewed by Darin Adler.
1361
1362         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1363         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1364         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1365
1366 2016-08-01  Keith Miller  <keith_miller@apple.com>
1367
1368         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1369         https://bugs.webkit.org/show_bug.cgi?id=160372
1370
1371         Rubber stamped by Geoffrey Garen.
1372
1373         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1374         a new top level directory, JSTests. Having the tests in the Source directory
1375         was both confusing an inconvenient for people that just want to checkout the
1376         source code of WebKit. Since there is no other obvious place to put all the
1377         JavaScript tests a new top level directory seemed the most sensible.
1378
1379         * Scripts/import-test262-tests:
1380         * Scripts/run-javascriptcore-tests:
1381         * Scripts/update-javascriptcore-test-res:
1382
1383 2016-07-31  Nan Wang  <n_wang@apple.com>
1384
1385         AX: Add a check for touch event listener on iOS accessibility object
1386         https://bugs.webkit.org/show_bug.cgi?id=160388
1387
1388         Reviewed by Chris Fleizach.
1389
1390         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1391         (AccessibilityUIElement::boolAttributeValue):
1392         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1393         (WTR::AccessibilityUIElement::boolAttributeValue):
1394
1395 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1396
1397         Unreviewed: add myself to the reviewers list.
1398
1399         * Scripts/webkitpy/common/config/contributors.json:
1400
1401 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1402
1403         Undo r203939, and copy over a rule that clips the logos.
1404
1405         Sierra wasn't the only logo without transparency.
1406
1407         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1409         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1410
1411 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1412
1413         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1414         https://bugs.webkit.org/show_bug.cgi?id=160377
1415
1416         Reviewed by Brian Weinstein.
1417
1418         Update assets to remove the white background and use a transparent background instead.
1419
1420         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1421         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1422
1423 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1424
1425         Ignore most check-webkit-style checks for ANGLE project
1426         <https://webkit.org/b/160333>
1427
1428         Reviewed by Daniel Bates.
1429
1430         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1431         - No tabs.
1432         - No spaces at the end of lines.
1433         - No carriage returns (DOS line endings).
1434
1435 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1436
1437         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1438         https://bugs.webkit.org/show_bug.cgi?id=160360
1439         <rdar://problem/27179484>
1440
1441         Reviewed by Myles C. Maxfield.
1442
1443         Adds two tests verifying that videos may be considered main content as long as they
1444         are large enough and cover a majority of the mainframe's viewport.
1445
1446         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1447         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1448         (TestWebKitAPI::TEST):
1449         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1450         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1451
1452 2016-07-29  Mark Lam  <mark.lam@apple.com>
1453
1454         Gardening: removed unused variable.
1455
1456         Not reviewed.
1457
1458         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1459         (TestWebKitAPI::TEST):
1460
1461 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1462
1463         Add TestWebKitAPI support for interacting with media controls
1464         https://bugs.webkit.org/show_bug.cgi?id=160342
1465         <rdar://problem/27610246>
1466
1467         Reviewed by Beth Dakin.
1468
1469         Adds support for testing interaction with some media controls, as well as a basic test
1470         verifying that media control teardown after interaction does not result in a crash.
1471
1472         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1473         (-[WKWebView mouseDownAtPoint:]):
1474         (-[WKWebView performAfterLoading:]):
1475         (TestWebKitAPI::TEST):
1476
1477 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1478
1479         Crash Log Clobbering on Unbound Crashes
1480         https://bugs.webkit.org/show_bug.cgi?id=160198
1481         <rdar://problem/27472618>
1482
1483         Reviewed by Alexey Proskuryakov.
1484
1485         * Scripts/webkitpy/common/system/crashlogs.py:
1486         (CrashLogs): Fix header order.
1487         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1488         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1489
1490 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1491
1492         Update for contributors.json
1493         https://bugs.webkit.org/show_bug.cgi?id=160294
1494
1495         * Scripts/webkitpy/common/config/contributors.json:
1496
1497 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1498
1499         Remove deprecated SPI for video inline / fullscreen controls
1500         https://bugs.webkit.org/show_bug.cgi?id=160318
1501
1502         Reviewed by Tim Horton.
1503
1504         * DumpRenderTree/mac/DumpRenderTree.mm:
1505         (setDefaultsToConsistentValuesForTesting): Deleted.
1506         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1507         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1508         * WebKitTestRunner/TestController.cpp:
1509         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1510         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1511         (WTR::initializeWebViewConfiguration): Deleted.
1512
1513 2016-07-28  Daniel Bates  <dabates@apple.com>
1514
1515         [iOS] TestWebKitAPI bundle targets are not code signed
1516         https://bugs.webkit.org/show_bug.cgi?id=160328
1517         <rdar://problem/27409246>
1518
1519         Reviewed by Andy Estes.
1520
1521         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1522         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1523         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1524
1525         * TestWebKitAPI/Configurations/Base.xcconfig:
1526
1527 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1528
1529         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1530
1531         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1532         (animatedResizeWebView):
1533         (TEST):
1534         This test times out only when run in the WebKit Testing simulator environment,
1535         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1536
1537 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1538
1539         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1540         https://bugs.webkit.org/show_bug.cgi?id=160289
1541         <rdar://problem/27553464>
1542
1543         Reviewed by Simon Fraser.
1544
1545         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1547         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1548         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1549         (-[AnimatedResizeWebView _endAnimatedResize]):
1550         (animatedResizeWebView):
1551         (TEST):
1552         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1553         Add two tests that ensure that hidden-content and animated resizes
1554         don't cause unnecessary synchronous waits. Only the hidden-content
1555         one fails before my patch, but it seemed reasonable to add both anyway.
1556
1557 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1558
1559         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1560         <https://webkit.org/b/83342>
1561
1562         Reviewed by Ryosuke Niwa.
1563
1564         * Scripts/webkitpy/common/checkout/scm/git.py:
1565         (Git.revisions_changing_file): Remove code to raise an exception
1566         when the file doesn't exist.  If a file was moved or renamed,
1567         then this caused the script to terminate, which was very
1568         frustrating when you wanted a list of reviewers.
1569         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1570         (SCMTest._shared_test_revisions_changing_file): Update test
1571         expectation to return an empty list of revisions.
1572         (test_create_patch_is_full_patch): Drive-by fix when running all
1573         webkitpy tests (including scm tests).
1574         * Scripts/webkitpy/common/checkout/scm/svn.py:
1575         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1576         return an empty array of revisions if this occurs.
1577
1578 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1579
1580         EWS error message "Error: * did not process patch" should include explanation
1581         https://bugs.webkit.org/show_bug.cgi?id=159903
1582         <rdar://problem/27410788>
1583
1584         Reviewed by Alexey Proskuryakov.
1585
1586         * QueueStatusServer/handlers/statusbubble.py:
1587         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1588         is not processed.
1589         * QueueStatusServer/handlers/processingtimesjson.py:
1590         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1591         of the code.
1592         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1593         (CommitQueueTask.validate): Add more information about validation failure.
1594         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1595         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1596         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1597         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1598         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1599         (PatchIsNotValid.__init__): Add the failure_message argument.
1600         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1601         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1602         failure details.
1603         * Scripts/webkitpy/tool/commands/queues.py:
1604         (CommitQueue.process_work_item): Same.
1605         (StyleQueue.review_patch): Same.
1606         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1607         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1608
1609 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1610
1611         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1612         https://bugs.webkit.org/show_bug.cgi?id=160262
1613
1614         Reviewed by Daniel Bates.
1615
1616         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1617         (-[LTRelayController installApp]):
1618
1619 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1620
1621         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1622         https://bugs.webkit.org/show_bug.cgi?id=160225
1623
1624         Reviewed by Alexey Proskuryakov.
1625
1626         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1627
1628 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1629
1630         [GTK] Fix some video/canvas tests that should be passing
1631         https://bugs.webkit.org/show_bug.cgi?id=160023
1632
1633         Reviewed by Carlos Garcia Campos.
1634
1635         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1636         EFL or GTK platforms.
1637
1638         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1639         (WTR::TestController::platformConfigureViewForTest):
1640         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1641         (WTR::TestController::platformConfigureViewForTest):
1642
1643 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1644
1645         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1646         https://bugs.webkit.org/show_bug.cgi?id=160247
1647
1648         Reviewed by Michael Catanzaro.
1649
1650         * BuildSlaveSupport/built-product-archive:
1651         (createZip):
1652         (dirContainsdwo):
1653         (archiveBuiltProduct):
1654
1655 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1656
1657         Fix tests after r203743.
1658         https://bugs.webkit.org/show_bug.cgi?id=156947
1659
1660         * WebKitTestRunner/TestController.cpp:
1661         (WTR::TestController::resetStateToConsistentValues):
1662         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1663
1664 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1665
1666         [iPhone] Playing a video on tudou.com plays only sound, no video
1667         https://bugs.webkit.org/show_bug.cgi?id=160178
1668         <rdar://problem/27535468>
1669
1670         Reviewed by Dan Bernstein.
1671
1672         * DumpRenderTree/mac/DumpRenderTree.mm:
1673         (setDefaultsToConsistentValuesForTesting):
1674         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1675         (RequiresUserActionForPlaybackTest::SetUp):
1676         * WebKitTestRunner/TestController.cpp:
1677         (WTR::TestController::resetPreferencesToConsistentValues):
1678         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1679         (WTR::initializeWebViewConfiguration):
1680
1681 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1682
1683         Allow LOG macros to be used outside the namespace, and other logging cleanup
1684         https://bugs.webkit.org/show_bug.cgi?id=160216
1685
1686         Reviewed by Anders Carlsson.
1687         
1688         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1689
1690         * DumpRenderTree/TestRunner.cpp:
1691         * DumpRenderTree/mac/DumpRenderTree.mm:
1692         (resetWebViewToConsistentStateBeforeTesting):
1693
1694 2016-07-26  David Kilzer <ddkilzer@apple.com>
1695
1696         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1697         https://bugs.webkit.org/show_bug.cgi?id=156947
1698         <rdar://problem/23325160>
1699
1700         Reviewed by Alex Christensen.
1701
1702         * DumpRenderTree/TestRunner.cpp:
1703         (TestRunner::TestRunner):
1704         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1705         * DumpRenderTree/TestRunner.h:
1706         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1707         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1708         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1709         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1710         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1711         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1712         (WTR::TestRunner::queueNonLoadingScript):
1713         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1714         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1715         * WebKitTestRunner/TestController.cpp:
1716         (WTR::TestController::didReceiveAuthenticationChallenge):
1717         * WebKitTestRunner/TestController.h:
1718         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1719         * WebKitTestRunner/TestInvocation.cpp:
1720         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1721         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1722
1723 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1724
1725         check-for-exit-time-destructors should be usable outside Xcode
1726         <https://webkit.org/b/160195>
1727
1728         Reviewed by Darin Adler.
1729
1730         * Scripts/check-for-exit-time-destructors: Update to parse
1731         -h|--help switch, or to take one argument to a binary to check
1732         for exit time destructors on the command-line.  The clang
1733         compiler will find these at compile-time with the
1734         -Wexit-time-destructors switch, but this script will check for
1735         them after-the-fact.
1736
1737 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1738
1739         Test svn.webkit.org functionality after maintenance.
1740
1741 2016-07-25  Brady Eidson  <beidson@apple.com>
1742
1743         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1744         https://bugs.webkit.org/show_bug.cgi?id=153783
1745
1746         Reviewed by Alex Christensen.
1747
1748         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
1749         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1750         
1751         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1752         
1753         Change the relevant API tests to make sure this continues to be no longer required.
1754
1755         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1756         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1757         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1758         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1759         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1760         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1761
1762 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1763
1764         Media controls should not be displayed for a video until it starts playing
1765         https://bugs.webkit.org/show_bug.cgi?id=160092
1766         <rdar://problem/26986673>
1767
1768         Reviewed by Beth Dakin.
1769
1770         Verify that multiple videos do or don't show the media controller depending on whether videos
1771         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1772         passing because we were always showing media controls for large videos with audio, even if they
1773         had not played back yet. This change ensures that large videos with audio show media controls
1774         only after they begin to play back, and not by virtue of being large enough for main content.
1775
1776         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1777         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1778         (TestWebKitAPI::TEST):
1779         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1780         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1781         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1782
1783 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1784
1785         Media controls on apple.com don't disappear when movie finishes playing
1786         https://bugs.webkit.org/show_bug.cgi?id=160068
1787         <rdar://problem/26668526>
1788
1789         Reviewed by Darin Adler.
1790
1791         Adds new API tests. Please see WebCore ChangeLog for more details.
1792
1793         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1794         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1795         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1796         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1797         (TestWebKitAPI::TEST):
1798         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1799         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1800         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1801         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1802         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1803
1804 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1805
1806         Unreviewed, fix test-webkitpy after r203674.
1807
1808         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1809         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1810
1811 2016-07-24  Philippe Normand  <pnormand@igalia.com>
1812
1813         Unreviewed, forgot to commit this file in r203674.
1814
1815         * Scripts/process-linux-coredump: Added.
1816         (main):
1817
1818 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1819
1820         Improve GDB backtrace generation for GTK/EFL
1821         https://bugs.webkit.org/show_bug.cgi?id=128928
1822
1823         Reviewed by Carlos Garcia Campos.
1824
1825         The PID of the crashed process is now correctly supplied to the
1826         crash log reporter. The kernel core_pattern needs to be updated
1827         after this change to something like:
1828
1829         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1830
1831         * Scripts/process-linux-coredump: Added.
1832         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1833         * Scripts/webkitpy/port/efl.py:
1834         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1835         * Scripts/webkitpy/port/gtk.py:
1836         (GtkPort._get_crash_log): Ditto.
1837         * Scripts/webkitpy/port/linux_get_crash_log.py:
1838         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1839         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1840         (GDBCrashLogGenerator): Deleted.
1841         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1842         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
1843         * WebKitTestRunner/TestController.cpp:
1844         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
1845         (WTR::TestController::databaseProcessDidCrash): Ditto.
1846         (WTR::TestController::processDidCrash): Ditto.
1847
1848 2016-07-23  Youenn Fablet  <youenn@apple.com>
1849
1850         WPT stash server should be kept running when launching wpt server
1851         https://bugs.webkit.org/show_bug.cgi?id=160052
1852
1853         Reviewed by Sam Weinig.
1854
1855         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1856         (main): waiting to read stdin while stash server is started.
1857
1858 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1859
1860         Media controls should be displayed for media in media documents
1861         https://bugs.webkit.org/show_bug.cgi?id=160104
1862         <rdar://problem/27438936>
1863
1864         Reviewed by Myles C. Maxfield.
1865
1866         Verifies that even a small video with audio in a media document gets media controls.
1867
1868         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1869         (TestWebKitAPI::TEST):
1870
1871 2016-07-22  Michael Saboff  <msaboff@apple.com>
1872
1873         REGRESSION(203616): no FTL testing was inadvertently removed
1874         https://bugs.webkit.org/show_bug.cgi?id=160100
1875
1876         Rubber-stamped by Filip Pizlo.
1877
1878         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
1879         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
1880         logic for the runLayout and runNoisy variants to match the run test logic,
1881         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
1882         enabled platforms.
1883
1884         * Scripts/run-jsc-stress-tests:
1885
1886 2016-07-22  Brady Eidson  <beidson@apple.com>
1887
1888         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
1889         https://bugs.webkit.org/show_bug.cgi?id=160089
1890
1891         Reviewed by Darin Adler.
1892
1893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1894         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
1895         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
1896
1897 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
1898
1899         [GTK] Improved exclusion patterns in make-dist.py manifest.
1900         https://bugs.webkit.org/show_bug.cgi?id=160094
1901
1902         Reviewed by Michael Catanzaro.
1903
1904         * gtk/manifest.txt.in:
1905         Exclude Platform*.cmake files for more ports.
1906         Removed obsolete .gyp and .pro.user patterns.
1907         Exclude 'Configurations' and 'spi' directories.
1908         Exclude CMakeLists.txt.user (Qt Creator IDE).
1909
1910 2016-07-22  Michael Saboff  <msaboff@apple.com>
1911
1912         Don't run FTL related JSC stress tests on non-FTL platforms
1913         https://bugs.webkit.org/show_bug.cgi?id=160033
1914
1915         Reviewed by Mark Lam.
1916
1917         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
1918         Refactored several of the runXXX test methods to always runXXXDefault and made those
1919         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
1920         doesn't cause a problem.
1921
1922         * Scripts/run-jsc-stress-tests:
1923
1924 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
1925
1926         IWebView::mainFrame crashes if called after IWebView::close
1927         https://bugs.webkit.org/show_bug.cgi?id=32868
1928
1929         Reviewed by Brent Fulgham.
1930
1931         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1932         (TestWebKitAPI::TEST_F): Added test.
1933
1934 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1935
1936         [GTK] Enable threaded compositor by default
1937         https://bugs.webkit.org/show_bug.cgi?id=160079
1938
1939         Reviewed by Žan Doberšek.
1940
1941         * Scripts/webkitperl/FeatureList.pm:
1942
1943 2016-07-22  Youenn Fablet  <youenn@apple.com>
1944
1945         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
1946         https://bugs.webkit.org/show_bug.cgi?id=159921
1947
1948         Reviewed by Brian Burg.
1949
1950         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
1951
1952         * Scripts/webkitpy/codegen/main.py:
1953         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
1954         (BuiltinsGeneratorTests):
1955         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
1956         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
1957         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
1958         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
1959
1960 2016-07-21  Dan Bernstein  <mitz@apple.com>
1961
1962         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
1963         https://bugs.webkit.org/show_bug.cgi?id=160072
1964
1965         Reviewed by Andy Estes.
1966
1967         * Scripts/webkitdirs.pm:
1968         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
1969           for old Xcode versions.
1970         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
1971           to readXcodeUserDefault.
1972         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
1973           debugger.
1974         (determineDebugger): Ditto.
1975         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
1976           7.0.
1977         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
1978           switches.
1979         (execMacWebKitAppForDebugging): Removed support for GDB.
1980
1981 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1982
1983         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
1984         https://bugs.webkit.org/show_bug.cgi?id=160066
1985
1986         Reviewed by Dean Jackson.
1987
1988         * DumpRenderTree/mac/DumpRenderTree.mm:
1989         (setDefaultsToConsistentValuesForTesting): Deleted.
1990         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1991         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1992         * WebKitTestRunner/TestController.cpp:
1993         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1994         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1995         (WTR::initializeWebViewConfiguration): Deleted.
1996
1997 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
1998
1999         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2000         https://bugs.webkit.org/show_bug.cgi?id=159980
2001         rdar://problem/27450825
2002
2003         Reviewed by Dan Bernstein.
2004
2005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2006         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2007         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2008         when our delegate has hit -dealloc.
2009         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
2010         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
2011         will not be messaged.
2012
2013 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2014
2015         Follow-up patch to r203520
2016         https://bugs.webkit.org/show_bug.cgi?id=159967
2017         <rdar://problem/26964090>
2018
2019         Unreviewed.
2020
2021         * DumpRenderTree/mac/DumpRenderTree.mm:
2022         (setDefaultsToConsistentValuesForTesting):
2023         * WebKitTestRunner/TestController.cpp:
2024         (WTR::TestController::resetPreferencesToConsistentValues):
2025
2026 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2027
2028         [iPhone] Playing a video on tudou.com plays only sound, no video
2029         https://bugs.webkit.org/show_bug.cgi?id=159967
2030         <rdar://problem/26964090>
2031
2032         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2033
2034         Migrate tests to use new SPI.
2035
2036         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2037         (RequiresUserActionForPlaybackTest::SetUp):
2038         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2039         (WTR::initializeWebViewConfiguration):
2040
2041 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
2042
2043         Clarify testing mode names in run-jsc-stress-tests
2044         https://bugs.webkit.org/show_bug.cgi?id=160021
2045
2046         Reviewed by Mark Lam.
2047
2048         Default should mean really default, not default with disabled FTL, renamed
2049         - runMozillaTestDefault to runMozillaTestNoFTL
2050         - runMozillaTestDefaultFTL to runMozillaTestDefault
2051         - runDefault to runNoFTL
2052         - runDefaultFTL to runDefault
2053         - runLayoutTestDefault to runLayoutTestNoFTL
2054         - runLayoutTestDefaultFTL to runLayoutTestDefault
2055         - runNoisyTestDefault to runNoisyTestNoFTL
2056         - runNoisyTestDefaultFTL to runNoisyTestDefault
2057
2058         * Scripts/run-jsc-stress-tests:
2059
2060 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
2061
2062         WebBackForwardList's currentIndex could get out of bounds when filtering items.
2063         https://bugs.webkit.org/show_bug.cgi?id=159986
2064
2065         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
2066         to 0.
2067
2068         Reviewed by Dan Bernstein.
2069
2070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2071         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
2072         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
2073         (TEST):
2074
2075 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2076
2077         [GTK] Web view background colors don't work in accelerated compositing mode
2078         https://bugs.webkit.org/show_bug.cgi?id=159455
2079
2080         Reviewed by Michael Catanzaro.
2081
2082         Set always RGBA visual to the view widget when setting a background color.
2083
2084         * MiniBrowser/gtk/BrowserWindow.c:
2085         (browser_window_set_background_color):
2086
2087 2016-07-20  Youenn Fablet  <youenn@apple.com>
2088
2089         Bots should run built-ins generator tests
2090         https://bugs.webkit.org/show_bug.cgi?id=159971
2091
2092         Reviewed by Alexey Proskuryakov.
2093
2094         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2095         (RunBuiltinsTests): New step to run built-in generator tests.
2096         (TestFactory.__init__): Adding an additional step for bultin generator tests.
2097         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
2098         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
2099
2100 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2101
2102         Revert temporary fix r203417
2103         https://bugs.webkit.org/show_bug.cgi?id=160001
2104
2105         Reviewed by Alexey Proskuryakov.
2106
2107         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
2108
2109 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2110
2111         REGRESSION(r148588): ews classes might get garbage collected
2112         https://bugs.webkit.org/show_bug.cgi?id=159990
2113
2114         Reviewed by Ryosuke Niwa.
2115
2116         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
2117         in a variable so that they do not get garbage collected.
2118
2119 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
2120
2121         Add API test for layout constraints after exit fullscreen
2122         https://bugs.webkit.org/show_bug.cgi?id=159900
2123
2124         Reviewed by Jon Lee.
2125
2126         Added Fullscreen.LaytoutConstraints API test. 
2127         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
2128
2129         This test compares layout constraints on the web view before and after fullscreen to make sure 
2130         they are preserved.
2131
2132         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
2133         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
2134         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2135         (TestWebKitAPI::TEST):
2136
2137 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
2138
2139         Disable two failing API tests.
2140
2141         Unreviewed test gardening.
2142
2143         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2144         (TestWebKitAPI::TEST):
2145
2146 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2147
2148         Unreviewed iOS build fix.
2149
2150         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
2151
2152 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2153
2154         Media controls don't appear when pausing a small autoplaying video
2155         https://bugs.webkit.org/show_bug.cgi?id=159972
2156         <rdar://problem/27180657>
2157
2158         Reviewed by Beth Dakin.
2159
2160         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
2161         for simulating basic user interaction in VideoControlsManager.
2162
2163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2164         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2165         (-[WKWebView mouseDownAtPoint:]):
2166         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2167         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2168         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2169         (TestWebKitAPI::TEST):
2170         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2171
2172 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2173
2174         [Win] MathML fonts are not found.
2175         https://bugs.webkit.org/show_bug.cgi?id=159920
2176
2177         Reviewed by Alex Christensen.
2178
2179         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2180         for a specific registry key value.
2181
2182         * Scripts/webkitdirs.pm:
2183         (fontExists):
2184
2185 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2186
2187         Improve prepare-ChangeLog for @media blocks
2188         https://bugs.webkit.org/show_bug.cgi?id=159907
2189
2190         Reviewed by Timothy Hatcher.
2191
2192         * Scripts/prepare-ChangeLog:
2193         (get_selector_line_ranges_for_css):
2194         Get a range for @media blocks just like a selector.
2195             Start Line = line with '{'
2196             End line = line with '}'
2197             Name = "@media ..."
2198
2199         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2200         Improved error messages for unbalanced portions.
2201
2202         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2203         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2204         (.media-query::before):
2205         (@media only screen and (max-width: 980px)):
2206         (.media-query a):
2207         (@media (-webkit-min-device-pixel-ratio: 2)):
2208         (.both a):
2209         (.both b):
2210         (.media-query b):
2211         (.media-query::after):
2212
2213 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2214
2215         Fix expectedFailErrorHandler in run-jsc-stress-tests
2216         https://bugs.webkit.org/show_bug.cgi?id=159811
2217
2218         Reviewed by Yusuke Suzuki.
2219
2220         * Scripts/run-jsc-stress-tests:
2221
2222 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2223
2224         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2225
2226         * TestWebKitAPI/PlatformMac.cmake:
2227
2228 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2229
2230         The default testing mode should not involve disabling the FTL JIT
2231         https://bugs.webkit.org/show_bug.cgi?id=159929
2232
2233         Rubber stamped by Mark Lam and Saam Barati.
2234         
2235         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2236         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2237         FTL was not the default. You had to enable it with an option.
2238         
2239         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2240         all of the major ports. This has become a serious pain. For example, it's useful to be able
2241         to say that a test should only run in the default config that is representative of what a
2242         normal user would see if they ran JSC. Clearly, this would be a config that does not
2243         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2244         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2245         
2246         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2247         try to fix it, because:
2248         
2249         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2250           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2251           doesn't do anything. The code is not really structured to allow this.
2252         
2253         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2254           disabled in testing. On the other hand there are already build bots that do FTL tests
2255           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2256           preserving this broken feature, we should create something that (a) acknowledges the fact
2257           that the FTL is the default on those platforms that support it and (b) avoids running
2258           no-ftl tests on precisely those platforms that don't have FTL.
2259         
2260         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2261           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2262           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2263           pretending that the FTL JIT is not the default just because some bots used that as an
2264           optimization.
2265         
2266         This change allows me to speed up some debug tests and paint some bots green.
2267
2268         * Scripts/run-javascriptcore-tests:
2269         (runJSCStressTests):
2270         * Scripts/run-jsc-stress-tests:
2271
2272 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2273
2274         Fix API test after r203426.
2275         https://bugs.webkit.org/show_bug.cgi?id=159949
2276
2277         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2278         (TEST):
2279         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2280         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2281
2282 2016-07-19  Andy Estes  <aestes@apple.com>
2283
2284         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2285         https://bugs.webkit.org/show_bug.cgi?id=159956
2286
2287         Reviewed by Dan Bernstein.
2288
2289         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2290         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2291         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2292         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2293
2294 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2295
2296         Add regression test for r203392
2297         https://bugs.webkit.org/show_bug.cgi?id=159949
2298
2299         Reviewed by Brady Eidson.
2300
2301         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2302         (fileSize):
2303         (swizzledBundleIdentifierWebBookmarksD):
2304         (defaultApplicationCacheDirectory):
2305         (TEST):
2306         (swizzledBundleIdentifierMobileSafari): Deleted.
2307         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2308         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2309         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2310
2311 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2312
2313         Add regression test for r203392
2314         https://bugs.webkit.org/show_bug.cgi?id=159949
2315
2316         Reviewed by Brady Eidson.
2317
2318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2319         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2320         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2321         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2322         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2323         (TEST):
2324         (fileSize):
2325         (swizzledBundleIdentifierMobileSafari):
2326         (swizzledBundleIdentifierWebBookmarksD):
2327         (defaultApplicationCacheDirectory):
2328         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2329         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2330         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2331         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2332
2333 2016-07-19  Keith Miller  <keith_miller@apple.com>
2334
2335         Test262 should have a file with the revision and url
2336         https://bugs.webkit.org/show_bug.cgi?id=159937
2337
2338         Reviewed by Mark Lam.
2339
2340         The import script should update the information from
2341         the path to the test262 repository it gets.
2342
2343         * Scripts/import-test262-tests:
2344
2345 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2346
2347         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2348         To be deleted once the root cause is found and addressed.
2349
2350         * EWSTools/start-queue-mac.sh:
2351
2352 2016-07-19  Frederic Wang  <fwang@igalia.com>
2353
2354         [win] Fixup the register name for STIX Math and Latin Modern Math
2355
2356         Unreviewed follow-up of r203406
2357
2358         * Scripts/webkitdirs.pm:
2359         (checkInstalledTools):
2360
2361 2016-07-19  Frederic Wang  <fwang@igalia.com>
2362
2363         [win] Update the list of MathML fonts
2364         https://bugs.webkit.org/show_bug.cgi?id=156838
2365
2366         The set of recommended math fonts is now described at
2367         https://trac.webkit.org/wiki/MathML/Fonts
2368         We update the Perl script to use the latest list of fonts.
2369
2370         Reviewed by Brent Fulgham.
2371
2372         * Scripts/webkitdirs.pm:
2373         (checkInstalledTools):
2374
2375 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2376
2377         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2378         https://bugs.webkit.org/show_bug.cgi?id=159342
2379
2380         Reviewed by Darin Adler.
2381
2382         Implement required functions in event sender.
2383
2384         * DumpRenderTree/PlatformWin.cmake:
2385         * DumpRenderTree/win/EventSender.cpp:
2386         (monitorWheelEvents): Added.
2387         (callAfterScrollingCompletes): Added.
2388
2389 2016-07-19  Youenn Fablet  <youenn@apple.com>
2390
2391         Add new aliases to http test server
2392         https://bugs.webkit.org/show_bug.cgi?id=159878
2393
2394         Reviewed by Darin Adler.
2395
2396         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2397         Adding explicitly these links to perl script.
2398         Extracting default alias in an aliases.json file.
2399         Reading that file from python scripts to initialize aliases from that file.
2400
2401         Python script changes covered by unit tests and changed layout test.
2402
2403         * Scripts/webkitperl/httpd.pm:
2404         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2405         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2406         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2407         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2408         Adding -c directives for each alias.
2409         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2410         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2411         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2412         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2413         Adding alias directive for each alias.
2414         (Lighttpd._prepare_config):
2415         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2416         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2417         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2418         layout tests directory.
2419         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2420         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2421         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2422
2423 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2424
2425         EWS console logs doesn't go to log file
2426         https://bugs.webkit.org/show_bug.cgi?id=159539
2427         <rdar://problem/24464570>
2428
2429         Reviewed by David Kilzer.
2430
2431         * Scripts/webkitpy/common/system/logutils.py:
2432         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2433         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2434         to filesystem. It also supports passing MockFilesystem.
2435         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2436         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2437         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2438         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2439         (_test_ews): Same.
2440         * Scripts/webkitpy/tool/commands/queues.py:
2441         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2442         (AbstractQueue._log_directory): Using filesystem object instead of os.
2443         (AbstractQueue.queue_log_path): Same.
2444         (AbstractQueue.__init__): Passed host parameter.
2445         (PatchProcessingQueue.__init__): Same.
2446         (CommitQueue.__init__): Same.
2447         (AbstractReviewQueue.__init__): Same.
2448         (StyleQueue.__init__): Same.
2449         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2450         (TestCommitQueue): Passed MockHost() as host.
2451         (TestCommitQueue.__init__): Same.
2452         (TestQueue.__init__): Same.
2453         (TestReviewQueue.__init__): Same.
2454         (TestFeederQueue.__init__): Same.
2455         (AbstractPatchQueueTest.test_next_patch): Same.
2456         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2457         (test_commit_queue_failure): Same.
2458         (MockCommitQueueTask.results_from_patch_test_run): Same.
2459         (test_rollout_lands): Same.
2460         (test_non_valid_patch): Same.
2461         (test_auto_retry): Same.
2462         (test_style_queue_with_watch_list_exception): Same.
2463
2464 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2465
2466         WTF::Lock should be fair eventually
2467         https://bugs.webkit.org/show_bug.cgi?id=159384
2468
2469         Reviewed by Geoffrey Garen.
2470
2471         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2472
2473 2016-07-17  Sam Weinig  <sam@webkit.org>
2474
2475         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2476         <rdar://problem/26554137>
2477         https://bugs.webkit.org/show_bug.cgi?id=159856
2478
2479         Reviewed by Dan Bernstein.
2480
2481         * MiniBrowser/mac/WK2BrowserWindowController.m:
2482         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2483         Add basic window.open implementation.
2484
2485         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2486         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2487         to open a single non-web URL, all others are dropped.
2488
2489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2490         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2491         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2492         Add API for the new SPI.
2493
2494 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2495
2496         [JSC] Enable test262 module tests
2497         https://bugs.webkit.org/show_bug.cgi?id=159854
2498
2499         Reviewed by Saam Barati.
2500
2501         Use --module-file instead.
2502
2503         * Scripts/run-jsc-stress-tests:
2504
2505 2016-07-16  Chris Dumez  <cdumez@apple.com>
2506
2507         Unreviewed, rolling out r203318.
2508
2509         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2510         SunSpider)
2511
2512         Reverted changeset:
2513
2514         "[JSC] Change some parameters based on a random search"
2515         https://bugs.webkit.org/show_bug.cgi?id=158514
2516         http://trac.webkit.org/changeset/203318
2517
2518 2016-07-16  Chris Dumez  <cdumez@apple.com>
2519
2520         Add move constructor / assignment operator to ListHashSet
2521         https://bugs.webkit.org/show_bug.cgi?id=159837
2522
2523         Reviewed by Darin Adler.
2524
2525         Add API tests.
2526
2527         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2528         (TestWebKitAPI::TEST):
2529
2530 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2531
2532         [JSC] Change some parameters based on a random search
2533         https://bugs.webkit.org/show_bug.cgi?id=158514
2534
2535         Reviewed by Saam Barati.
2536
2537         * Scripts/run-jsc-stress-tests:
2538
2539 2016-07-15  Jon Davis  <jond@apple.com>
2540
2541         Changed the start page URL for WebKit Nightly builds.
2542         https://bugs.webkit.org/show_bug.cgi?id=159816
2543
2544         Reviewed by Timothy Hatcher.
2545
2546         * WebKitLauncher/start.html:
2547
2548 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2549
2550         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2551         https://bugs.webkit.org/show_bug.cgi?id=159414
2552
2553         Reviewed by Brent Fulgham.
2554
2555         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2556         when the HDC parameter is invalid.
2557
2558         * TestWebKitAPI/PlatformWin.cmake:
2559         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2560         (TestWebKitAPI::TEST):
2561
2562 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2563
2564         [GTK] Add basic tabs support to MiniBrowser
2565         https://bugs.webkit.org/show_bug.cgi?id=159803
2566
2567         Reviewed by Sergio Villar Senin.
2568
2569         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2570         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2571
2572         * MiniBrowser/gtk/BrowserTab.c: Added.
2573         (titleChanged):
2574         (isLoadingChanged):
2575         (decidePolicy):
2576         (removeChildIfInfoBar):
2577         (loadChanged):
2578         (createInfoBarQuestionMessage):
2579         (tlsErrorsDialogResponse):
2580         (loadFailedWithTLSerrors):
2581         (permissionRequestDialogResponse):
2582         (decidePermissionRequest):
2583         (colorChooserRGBAChanged):
2584         (popoverColorClosed):
2585         (colorChooserRequestFinished):
2586         (runColorChooserCallback):
2587         (inspectorOpenedInWindow):
2588         (inspectorClosed):
2589         (browserTabSetProperty):
2590         (browserTabFinalize):
2591         (browser_tab_init):
2592         (browserTabConstructed):
2593         (browser_tab_class_init):
2594         (getInternalURI):
2595         (browser_tab_new):
2596         (browser_tab_get_web_view):
2597         (browser_tab_load_uri):
2598         (browser_tab_get_title_widget):
2599         (browser_tab_set_status_text):
2600         (browser_tab_toggle_inspector):
2601         (browser_tab_start_search):
2602         (browser_tab_stop_search):
2603         (browser_tab_add_accelerators):
2604         (fullScreenMessageTimeoutCallback):
2605         (browser_tab_enter_fullscreen):
2606         (browser_tab_leave_fullscreen):
2607         * MiniBrowser/gtk/BrowserTab.h: Added.
2608         * MiniBrowser/gtk/BrowserWindow.c:
2609         (getExternalURI):
2610         (browserWindowSetStatusText):
2611         (reloadOrStopCallback):
2612         (goBackCallback):
2613         (goForwardCallback):
2614         (settingsCallback):
2615         (webViewURIChanged):
2616         (browserWindowHistoryItemActivated):
2617         (browserWindowUpdateNavigationActions):
2618         (webViewCreate):
2619         (webViewEnterFullScreen):
2620         (webViewLeaveFullScreen):
2621         (webViewDecidePolicy):
2622         (browserWindowCanZoomIn):
2623         (browserWindowCanZoomOut):
2624         (browserWindowZoomIn):
2625         (browserWindowZoomOut):
2626         (scrollEventCallback):
2627         (faviconChanged):
2628         (webViewIsLoadingChanged):
2629         (defaultZoomCallback):
2630         (searchCallback):
2631         (newTabCallback):
2632         (toggleWebInspector):
2633         (reloadPage):
2634         (reloadPageIgnoringCache):
2635         (stopPageLoad):
2636         (loadHomePage):
2637         (editingCommandCallback):
2638         (insertImageCommandCallback):
2639         (insertLinkCommandCallback):
2640         (browserWindowSetupEditorToolbar):
2641         (browserWindowSwitchTab):
2642         (browserWindowTabAddedOrRemoved):
2643         (browser_window_init):
2644         (browserWindowConstructed):
2645         (browserWindowSaveSession):
2646         (browserWindowDeleteEvent):
2647         (browser_window_new):
2648         (browser_window_append_view):
2649         (browser_window_load_uri):
2650         (browser_window_load_session):
2651         (browser_window_set_background_color):
2652         (resetStatusText): Deleted.
2653         (activateUriEntryCallback): Deleted.
2654         (webViewTitleChanged): Deleted.
2655         (resetEntryProgress): Deleted.
2656         (browserWindowCreateBackForwardMenu): Deleted.
2657         (webViewReadyToShow): Deleted.
2658         (webViewLoadFailed): Deleted.
2659         (webViewMouseTargetChanged): Deleted.
2660         (browserWindowUpdateZoomActions): Deleted.
2661         (webViewZoomLevelChanged): Deleted.
2662         (updateUriEntryIcon): Deleted.
2663         (zoomInCallback): Deleted.
2664         (zoomOutCallback): Deleted.
2665         (toggleFullScreen): Deleted.
2666         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2667         (browserWindowFinalize): Deleted.
2668         (browser_window_class_init): Deleted.
2669         * MiniBrowser/gtk/BrowserWindow.h:
2670         * MiniBrowser/gtk/CMakeLists.txt:
2671         * MiniBrowser/gtk/main.c:
2672         (createBrowserTab):
2673         (aboutURISchemeRequestCallback):
2674         (main):
2675         (parseBackgroundColor): Deleted.
2676
2677 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2678
2679         Allow RefPtrs of const RefCounted types
2680         https://bugs.webkit.org/show_bug.cgi?id=158269
2681
2682         Reviewed by Anders Carlsson.
2683
2684         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2685         (TestWebKitAPI::TEST):
2686         (TestWebKitAPI::ConstRefCounted::create):
2687         (TestWebKitAPI::returnConstRefCountedRef):
2688         (TestWebKitAPI::returnRefCountedRef):
2689
2690 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2691
2692         Test WTF.StringViewIterators is crashing since r203119
2693         https://bugs.webkit.org/show_bug.cgi?id=159710
2694
2695         Reviewed by Darin Adler.
2696
2697         There are two problems in the test case added in r203119. First is that it's testing
2698         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2699         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2700         const reference to the string view member of the deleted CodePoints object.
2701
2702         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2703         (TestWebKitAPI::TEST):
2704
2705 2016-07-13  Daniel Bates  <dabates@apple.com>
2706
2707         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2708         https://bugs.webkit.org/show_bug.cgi?id=159738
2709         <rdar://problem/27304649>
2710
2711         Reviewed by Dan Bernstein.
2712
2713         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2714         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2715         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2716         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2717
2718         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2719         * WebKitTestRunner/ios/TestControllerIOS.mm:
2720         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2721         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2722
2723 2016-07-13  Beth Dakin  <bdakin@apple.com>
2724
2725         Attempted build fix.
2726
2727         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2728
2729 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2730
2731         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2732         https://bugs.webkit.org/show_bug.cgi?id=159686
2733
2734         Reviewed by Chris Dumez.
2735
2736         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2737
2738         * WebKitTestRunner/TestController.cpp:
2739         (WTR::runOpenPanel):
2740         (WTR::TestController::createOtherPage):
2741         (WTR::TestController::createWebViewWithOptions):
2742
2743 2016-07-13  Beth Dakin  <bdakin@apple.com>
2744
2745         Add more candidate tests
2746         https://bugs.webkit.org/show_bug.cgi?id=159730
2747
2748         Reviewed by Tim Horton.
2749
2750         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
2751         two new tests to that file.
2752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2753         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2754         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2755         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2756         (TestWebKitAPI::TEST):
2757         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2758
2759 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2760
2761         AX: [ATK] spinbutton-crash.html fails
2762         https://bugs.webkit.org/show_bug.cgi?id=159723
2763
2764         Reviewed by Chris Fleizach.
2765
2766         Implement support for AXDecrementButton and AXIncrementButton in
2767         ATK's AccessibilityUIElement::uiElementAttributeValue().
2768
2769         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2770         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2771
2772 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2773
2774         [EFL] [GTK] Enable back crypto subtle on development builds.
2775         https://bugs.webkit.org/show_bug.cgi?id=159260
2776
2777         Reviewed by Carlos Garcia Campos.
2778
2779         * Scripts/webkitperl/FeatureList.pm:
2780
2781 2016-07-12  Mark Lam  <mark.lam@apple.com>
2782
2783         We should use different stack limits for stack checks from JS and host code.
2784         https://bugs.webkit.org/show_bug.cgi?id=159442
2785         <rdar://problem/26889188>
2786
2787         Reviewed by Geoffrey Garen.
2788
2789         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2790         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
2791         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
2792         order to keep the js/regress-139548.html test happy with this patch.
2793
2794         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2795         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
2796
2797         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2798         (-[LTRelayController _environmentVariables]):
2799         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2800         (main):
2801
2802 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
2803
2804         platformUserPreferredLanguages on Mac should not try to put the region into the language
2805         https://bugs.webkit.org/show_bug.cgi?id=159693
2806
2807         Rubber stamped by Alexey Proskuryakov.
2808         
2809         Revert the test change in r200105.
2810
2811         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2812         (TestWebKitAPI::languageForSystemLanguage):
2813
2814 2016-07-12  Chris Dumez  <cdumez@apple.com>
2815
2816         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2817         https://bugs.webkit.org/show_bug.cgi?id=159663
2818         <rdar://problem/18995873>
2819
2820         Reviewed by Benjamin Poulain.
2821
2822         Add API test coverage.
2823
2824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2825         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2826         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2827         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2828         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2829         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2830         (TEST):
2831
2832 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
2833
2834         Relax ordering requirements on StringView::CodePoints iterator
2835         https://bugs.webkit.org/show_bug.cgi?id=159609
2836
2837         Reviewed by Darin Adler.
2838
2839         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2840         (TestWebKitAPI::TEST):
2841
2842 2016-07-12  Youenn Fablet  <youenn@apple.com>
2843
2844         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
2845         https://bugs.webkit.org/show_bug.cgi?id=159564
2846
2847         Reviewed by Brian Burg.
2848
2849         * Scripts/webkitpy/codegen/main.py:
2850         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
2851
2852 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2853
2854         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2855         https://bugs.webkit.org/show_bug.cgi?id=159671
2856
2857         Reviewed by Csaba Osztrogonác.
2858
2859         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2860         https://bugs.webkit.org/show_bug.cgi?id=89235
2861
2862         So this guard can be removed in build scripts.
2863
2864         * Scripts/webkitperl/FeatureList.pm:
2865         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2866
2867 2016-07-11  Jason Marcell  <jmarcell@apple.com>
2868
2869         SVN.create_patch should find svn-create-patch relative to the WebKit root.
2870         https://bugs.webkit.org/show_bug.cgi?id=159652
2871
2872         Reviewed by Daniel Bates.
2873
2874         * Scripts/webkitpy/common/checkout/scm/svn.py:
2875         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
2876
2877 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2878
2879         Implement grapheme cluster iterator on StringView
2880         https://bugs.webkit.org/show_bug.cgi?id=159598
2881
2882         Reviewed by Anders Carlsson.
2883
2884         This is in preparation for honoring the second argument to FontFaceSet.load().
2885
2886         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2887         (TestWebKitAPI::compareLoopIterations):
2888         (TestWebKitAPI::TEST):
2889
2890 2016-07-11  Nan Wang  <n_wang@apple.com>
2891
2892         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
2893         https://bugs.webkit.org/show_bug.cgi?id=158364
2894
2895         Reviewed by Anders Carlsson.
2896
2897         Added a function in TestRunner so that we can toggle the ignoring viewport
2898         scale limits setting. Also added a test option for that in order to change the 
2899         configuration of the webview in test.
2900
2901         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2902         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2903         (WTR::TestRunner::setNavigationGesturesEnabled):
2904         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2905         (WTR::nextUIScriptCallbackID):
2906         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2907         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2908         * WebKitTestRunner/TestController.cpp:
2909         (WTR::TestController::resetStateToConsistentValues):
2910         (WTR::updateTestOptionsFromTestHeader):
2911         (WTR::TestController::setNavigationGesturesEnabled):
2912         (WTR::TestController::setIgnoresViewportScaleLimits):
2913         (WTR::TestController::platformWillRunTest):
2914         * WebKitTestRunner/TestController.h:
2915         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2916         * WebKitTestRunner/TestInvocation.cpp:
2917         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2918         * WebKitTestRunner/TestOptions.h:
2919         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2920         (WTR::TestController::platformCreateWebView):
2921
2922 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
2923
2924         [GTK] install-dependencies should not install packages built by jhbuild.
2925         https://bugs.webkit.org/show_bug.cgi?id=159628
2926
2927         Reviewed by Michael Catanzaro.
2928
2929         * gtk/install-dependencies:
2930         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
2931
2932 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
2933
2934         System proxy settings not used when building deps with jhbuild
2935         https://bugs.webkit.org/show_bug.cgi?id=159567
2936
2937         Reviewed by Michael Catanzaro.
2938
2939         This adds the gsettings-desktop-schemas-devel build dep to enable
2940         the libgiognomeproxy.so gio module in glib-networking, which uses
2941         GSettings on org.gnome.system.proxy.
2942         This is needed to query system proxy settings for Gnome desktops.
2943
2944         dconf can be manually added to jhbuild to build the
2945         libdconfsettings.so gio module for GSettings, so that
2946         libgiognomeproxy.so can access system settings.
2947           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
2948
2949         As an alternative to dconf settings, this commit also adds the
2950         libproxy-devel build dep to enable the libgiolibproxy.so module in
2951         glib-networking (suggested by Fujii Hironori).
2952
2953         It is useful to read proxy settings from environment variables.
2954         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
2955         environment variable to force using the envvar module in libproxy.
2956
2957         * gtk/install-dependencies:
2958
2959 2016-07-11  Mark Lam  <mark.lam@apple.com>
2960
2961         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
2962         https://bugs.webkit.org/show_bug.cgi?id=159524
2963
2964         Reviewed by Michael Saboff.
2965
2966         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
2967         Also fixed up some tests to behave better to work with this new limit.  This
2968         should make stack overflow tests complete sooner.
2969
2970         * Scripts/run-jsc-stress-tests:
2971         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2972         (main):
2973
2974 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2975
2976         [GTK] Whitespace fixes in install-dependencies script
2977
2978         Unreviewed.
2979
2980         * gtk/install-dependencies:
2981
2982 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2983
2984         [GTK] Install missing Fedora dependencies
2985
2986         Unreviewed.
2987
2988         * gtk/install-dependencies:
2989
2990 2016-07-09  Dan Bernstein  <mitz@apple.com>
2991
2992         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
2993         https://bugs.webkit.org/show_bug.cgi?id=159600
2994
2995         Reviewed by Daniel Bates.
2996
2997         * Scripts/git-add-reviewer:
2998         Added the -s|--rubber-stamp option.
2999         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
3000           new option.
3001
3002 2016-07-08  Andy Estes  <aestes@apple.com>
3003
3004         [Content Filtering] Load blocked pages more like other error pages are loaded
3005         https://bugs.webkit.org/show_bug.cgi?id=159485
3006         <rdar://problem/26014076>
3007
3008         Reviewed by Brady Eidson.
3009
3010         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3011         to a content filtering provisional navigation failure is ignored in preference of
3012         ContentFilter's own error page.
3013
3014         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3015         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3016         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3017         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3018         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3019         (loadAlternateTest):
3020         (TEST):
3021         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3022         (-[MockContentFilterEnabler initWithCoder:]):
3023         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3024         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3025         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3026         (TestWebKitAPI::loadAlternateTest):
3027         (TestWebKitAPI::TEST):
3028
3029 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3030
3031         Unreviewed, rolling out r202944.
3032         https://bugs.webkit.org/show_bug.cgi?id=159570
3033
3034         caused some tests to crash under GuardMalloc (Requested by
3035         estes on #webkit).
3036
3037         Reverted changeset:
3038
3039         "[Content Filtering] Load blocked pages more like other error
3040         pages are loaded"
3041         https://bugs.webkit.org/show_bug.cgi?id=159485
3042         http://trac.webkit.org/changeset/202944
3043
3044 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
3045
3046         Remove mrobinson from the MathML watchlist
3047         https://bugs.webkit.org/show_bug.cgi?id=159559
3048
3049         Reviewed by Philippe Normand.
3050
3051         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
3052
3053 2016-07-08  Brady Eidson  <beidson@apple.com>
3054
3055         Clearing LocalStorage doesn't also delete -wal and -shm files.
3056         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
3057
3058         Reviewed by Brent Fulgham.
3059         Also helpfully picked over by Andy "Never Forgets" Estes.
3060
3061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3062         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
3063         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
3064
3065 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
3066
3067         Removed Qt leftovers from Tools.
3068         https://bugs.webkit.org/show_bug.cgi?id=159557
3069
3070         Reviewed by Csaba Osztrogonác.
3071
3072         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3073         Removed 'qt' platform config.
3074         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3075         Deleted non-functional e-mail address.
3076
3077 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3078
3079         Unreviewed, rolling out r202967.
3080         https://bugs.webkit.org/show_bug.cgi?id=159556
3081
3082         This patch caused crashes in https tests on Windows (Requested
3083         by perarne on #webkit).
3084
3085         Reverted changeset:
3086
3087         "[Win] The test http/tests/security/contentSecurityPolicy
3088         /upgrade-insecure-requests/basic-upgrade.https.html is
3089         failing."
3090         https://bugs.webkit.org/show_bug.cgi?id=159510
3091         http://trac.webkit.org/changeset/202967
3092
3093 2016-07-08  Youenn Fablet  <youenn@apple.com>
3094
3095         Generate WebCore builtin wrapper files
3096         https://bugs.webkit.org/show_bug.cgi?id=159461
3097
3098         Reviewed by Brian Burg.
3099
3100         * Scripts/webkitpy/codegen/main.py:
3101         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
3102         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
3103
3104 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
3105
3106         [EFL] Fix build when media-stream is enabled.
3107         https://bugs.webkit.org/show_bug.cgi?id=159206
3108
3109         Bump up the openwebrtc to find the correct package.
3110
3111         Reviewed by Gyuyoung Kim.
3112
3113         * efl/jhbuild.modules:
3114         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
3115
3116 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3117
3118         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
3119         https://bugs.webkit.org/show_bug.cgi?id=159510
3120
3121         Reviewed by Brent Fulgham.
3122
3123         Allow any https certificate when running tests.
3124
3125         * DumpRenderTree/win/DumpRenderTree.cpp:
3126         (runTest):
3127
3128 2016-07-07  Beth Dakin  <bdakin@apple.com>
3129
3130         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3131         https://bugs.webkit.org/show_bug.cgi?id=159532
3132         -and corresponding-
3133         rdar://problem/27177179
3134
3135         Reviewed by Tim Horton.
3136
3137         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
3138         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
3139
3140 2016-07-07  Andy Estes  <aestes@apple.com>
3141
3142         [Content Filtering] Load blocked pages more like other error pages are loaded
3143         https://bugs.webkit.org/show_bug.cgi?id=159485
3144         <rdar://problem/26014076>
3145
3146         Reviewed by Brady Eidson.
3147
3148         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3149         to a content filtering provisional navigation failure is ignored in preference of
3150         ContentFilter's own error page.
3151
3152         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3154         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3155         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3156         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3157         (loadAlternateTest):
3158         (TEST):
3159         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3160         (-[MockContentFilterEnabler initWithCoder:]):
3161         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3162         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3163         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3164         (TestWebKitAPI::loadAlternateTest):
3165         (TestWebKitAPI::TEST):
3166
3167 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3168
3169         Unreviewed: add myself to the reviewers list.
3170
3171         * Scripts/webkitpy/common/config/contributors.json:
3172
3173 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3174
3175         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
3176         https://bugs.webkit.org/show_bug.cgi?id=159509
3177
3178         Reviewed by Alex Christensen.
3179
3180         We should always insert the url in the url map when identifierForInitialRequest
3181         is called. Otherwise we can end up with identifiers not having an entry in the
3182         url map when urls are written to the test output file. 
3183
3184         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3185         (ResourceLoadDelegate::identifierForInitialRequest):
3186
3187 2016-07-06  Tim Horton  <timothy_horton@apple.com>
3188
3189         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3190         https://bugs.webkit.org/show_bug.cgi?id=159498
3191         <rdar://problem/26719903>
3192
3193         Reviewed by Sam Weinig.
3194
3195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3196         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3197         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3198         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3199         (expectLinkCount):
3200         (TEST):
3201         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3202         when deciding what to linkify.
3203
3204 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3205
3206         Build fix - work around rdar://problem/27196668.
3207
3208         * LayoutTestRelay/Configurations/Base.xcconfig:
3209
3210 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3211
3212         Enhance Windows DRT implementation to support platform scroll wheel events.
3213         https://bugs.webkit.org/show_bug.cgi?id=36002
3214
3215         Reviewed by Brent Fulgham.
3216
3217         Implement function continuousMouseScrollBy in Windows event sender.
3218
3219         * DumpRenderTree/win/EventSender.cpp:
3220         (mouseScrollBy):
3221         (continuousMouseScrollBy):
3222
3223 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3224
3225         [Sierra] Rebaseline tests to use un-mocked system font metrics
3226         https://bugs.webkit.org/show_bug.cgi?id=159311
3227         <rdar://problem/24138411>
3228
3229         Reviewed in person by Alexey Proskuryakov.
3230
3231         Stop mocking the system font on Sierra.
3232
3233         * DumpRenderTree/mac/DumpRenderTree.mm:
3234         (setDefaultsToConsistentValuesForTesting):
3235         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3236         (WTR::InjectedBundle::platformInitialize):
3237
3238 2016-07-05  Brady Eidson  <beidson@apple.com>
3239
3240         Database process crashes deleting a corrupt SQLite database file (null deref).
3241         https://bugs.webkit.org/show_bug.cgi?id=155506.
3242
3243         Reviewed by Alex Christensen.
3244
3245         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3246         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3247         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3248         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3249         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3250         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3251
3252 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3253
3254         run-webkit-tests should print more complete baseline search paths
3255         https://bugs.webkit.org/show_bug.cgi?id=159354
3256
3257         Reviewed by Daniel Bates.
3258
3259         run-webkit-tests used to only print directory names in baseline search paths.
3260         This was ok in basic usage, but quickly got confusing when using
3261         --additional-platform-directory flags.
3262
3263         * Scripts/webkitpy/layout_tests/views/printing.py:
3264         (Printer.print_config):
3265         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3266         (Testprinter.test_print_config):
3267         (Testprinter.test_print_one_line_summary):
3268
3269 2016-07-04  Brady Eidson  <beidson@apple.com>
3270
3271         WebProcesses don't handle DatabaseProcess going away uncleanly..
3272         https://bugs.webkit.org/show_bug.cgi?id=159371
3273
3274         Reviewed by Alex Christensen.
3275
3276         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3277         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3278         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3279         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3280         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3281
3282 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3283
3284         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3285         https://bugs.webkit.org/show_bug.cgi?id=158141
3286
3287         Rubber-stamped by Michael Catanzaro.
3288
3289         Instead of checking for an specific Ubuntu version, query the apt
3290         database to see which version of PHP is available.
3291
3292         * efl/install-dependencies:
3293         * gtk/install-dependencies:
3294
3295 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3296
3297         webkit-patch failure-reason always raises TypeError
3298         https://bugs.webkit.org/show_bug.cgi?id=159394
3299
3300         Reviewed by Benjamin Poulain.
3301
3302         In r170637 (Bug 133067), the first and second arguments of
3303         pluralize were swapped.
3304
3305         * Scripts/webkitpy/tool/commands/queries.py:
3306         (FailureReason._builder_to_explain): Swap the first and second
3307         arguments of pluralize.
3308
3309 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3310
3311         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3312         https://bugs.webkit.org/show_bug.cgi?id=152486
3313
3314         Reviewed by Daniel Bates.
3315
3316         Add launch of web-platform-tests server by run-webkit-httpd.
3317         Add two options to disable starting httpd and web-platform-tests servers.
3318
3319         * Scripts/run-webkit-httpd:
3320         (parse_args):
3321         (main):
3322
3323 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3324
3325         REGRESSION(r189668): Notification tests are flakey
3326         https://bugs.webkit.org/show_bug.cgi?id=159375
3327         <rdar://problem/22760990>
3328
3329         Reviewed by Alexey Proskuryakov.
3330
3331         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3332         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3333         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3334         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3335
3336         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3337         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3338         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3339         global notification ID mapping, causing the wrong notification to be investigated.
3340
3341         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3342         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3343         notification is created or destroyed. However, because this object is implemented outside WebKit,
3344         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3345         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3346         WebNotificationProvider can properly map between the different IDs.
3347
3348         * WebKitTestRunner/TestController.cpp:
3349         (WTR::TestController::runTestingServerLoop):
3350         (WTR::TestController::simulateWebNotificationClick):
3351         * WebKitTestRunner/WebNotificationProvider.cpp:
3352         (WTR::WebNotificationProvider::showWebNotification):
3353         (WTR::removeGlobalIDFromIDMap):
3354         (WTR::WebNotificationProvider::closeWebNotification):
3355         (WTR::WebNotificationProvider::removeNotificationManager):
3356         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3357         (WTR::WebNotificationProvider::reset):
3358         * WebKitTestRunner/WebNotificationProvider.h:
3359
3360 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3361
3362         Simplify LayoutTestRelay
3363         https://bugs.webkit.org/show_bug.cgi?id=159353
3364
3365         Reviewed by Daniel Bates.
3366
3367         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3368         by name and runtime makes no sense.
3369         2. Removed code to create devices, webkitpy always does this in advance.
3370         3. Don't create copies of testing apps - we can install the same one into
3371         each simulator, now that we don't run multiple tester processes in a single simulator.
3372         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3373         5. Removed code that kept testing apps alive in the background.
3374         6. Slightly updated coding style in functions that I touched.
3375
3376         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3377         Updated for what we acually use at this point.
3378
3379         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3380         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3381         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3382         (-[LTRelayController ipcIdentifier]):
3383         (-[LTRelayController processName]):
3384         (-[LTRelayController didReceiveStdoutData:]):
3385         (-[LTRelayController didCrashWithMessage:]):
3386         (-[LTRelayController installApp]):
3387         (-[LTRelayController _environmentVariables]):
3388         (-[LTRelayController launchApp]):
3389         (-[LTRelayController start]):
3390         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3391         (-[LTRelayController uniqueAppPath]): Deleted.
3392         (-[LTRelayController uniqueAppURL]): Deleted.
3393         (-[LTRelayController uniqueAppIdentifier]): Deleted.
3394         (-[LTRelayController createUniqueApp]): Deleted.
3395         * LayoutTestRelay/LayoutTestRelay/main.m:
3396         (usage):
3397         (getRequiredStringArgument):
3398         (main):
3399         (getTestingSimDevice): Deleted.
3400         * Scripts/webkitpy/port/driver.py:
3401         (IOSSimulatorDriver.cmd_line):
3402         * WebKitTestRunner/ios/TestControllerIOS.mm:
3403         (WTR::TestController::platformInitialize):
3404         * WebKitTestRunner/ios/mainIOS.mm:
3405         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3406         * DumpRenderTree/mac/DumpRenderTree.mm:
3407         (dumpRenderTree):
3408         (-[DumpRenderTree applicationDidEnterBackground:]):
3409
3410 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
3411
3412         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3413         https://bugs.webkit.org/show_bug.cgi?id=159344
3414
3415         Reviewed by Alex Christensen.
3416
3417         * DumpRenderTree/CMakeLists.txt:
3418
3419 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3420
3421         Add a runtime flag for DOM iterators
3422         https://bugs.webkit.org/show_bug.cgi?id=159300
3423
3424         Reviewed by Alex Christensen.
3425
3426         * DumpRenderTree/mac/DumpRenderTree.mm:
3427         (resetWebPreferencesToConsistentValues):
3428         * DumpRenderTree/win/DumpRenderTree.cpp:
3429         (resetWebPreferencesToConsistentValues):
3430         * Scripts/webkitperl/FeatureList.pm:
3431         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3432         (WTR::InjectedBundle::beginTesting):
3433         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3434         (WTR::TestRunner::setDOMIteratorEnabled):
3435         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3436
3437 2016-06-30  Tina Liu  <iting_liu@apple.com>
3438
3439         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3440         https://bugs.webkit.org/show_bug.cgi?id=159326
3441
3442         Reviewed by Brady Eidson.
3443
3444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3445         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3446         (TestWebKitAPI::didFinishLoadForFrame):
3447         (TestWebKitAPI::didChangeBackForwardListForPage):
3448         (TestWebKitAPI::setPageLoaderClient):
3449         Set the page loader client and register for didFinishLoadForFrame and
3450         didChangeBackForwardList callbacks.
3451         (TestWebKitAPI::createSessionStateData):
3452         Load a webpage ("simple.html") and return the session state for this page.
3453         (TestWebKitAPI::TEST):
3454         Restore the page session state with that of "simple.html" without navigation.
3455         Verify that the committed URL is NULL since there's no navigation involved.
3456         Verify that the current item in the back forward list, which should be what
3457         we restored from the session state, has the expected URL.
3458
3459 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
3460
3461         Generators violate bytecode liveness validation
3462         https://bugs.webkit.org/show_bug.cgi?id=159279
3463
3464         Reviewed by Yusuke Suzuki.
3465         
3466         Add Basic to our test harness.
3467
3468         * Scripts/run-javascriptcore-tests:
3469         (runJSCStressTests):
3470
3471 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
3472
3473         [Win][Debug] Assertion fails in TestWTF.
3474         https://bugs.webkit.org/show_bug.cgi?id=159299
3475
3476         Reviewed by Alex Christensen.
3477
3478         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3479         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3480         the assertion failure. Since the variable is actually used, there is no need to use the
3481         UNUSED_PARAM macro.
3482
3483         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3484         (TestWebKitAPI::TEST):
3485
3486 2016-06-30  Youenn Fablet  <youennf@gmail.com>
3487
3488         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
3489         https://bugs.webkit.org/show_bug.cgi?id=159166
3490         <rdar://problem/27051759>
3491
3492         Reviewed by Alexey Proskuryakov.
3493
3494         Setting the certificate directory to the copied config.json.
3495
3496         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3497         (WebPlatformTestServer._copy_webkit_test_files):
3498
3499 2016-06-29  Mark Lam  <mark.lam@apple.com>
3500
3501         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
3502         https://bugs.webkit.org/show_bug.cgi?id=159274
3503
3504         Reviewed by Keith Miller.
3505
3506         * DumpRenderTree/mac/DumpRenderTree.mm:
3507         (DumpRenderTreeMain):
3508
3509 2016-06-29  Alex Christensen  <achristensen@webkit.org>
3510
3511         WKWebView should ask WKNavigationDelegate about bad ssl certificates
3512         https://bugs.webkit.org/show_bug.cgi?id=159176
3513
3514         Reviewed by Sam Weinig.
3515
3516         * MiniBrowser/mac/WK2BrowserWindowController.m:
3517         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3518         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3519         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3520
3521 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3522
3523         [GTK] Add missing install dependency after r202619
3524         https://bugs.webkit.org/show_bug.cgi?id=156716
3525
3526         Unreviewed.
3527
3528         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3529
3530 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3531
3532         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3533         https://bugs.webkit.org/show_bug.cgi?id=156716
3534
3535         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3536
3537         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3538         (parse_args):
3539         * Scripts/webkitpy/port/gtk.py:
3540         (GtkPort.__init__):
3541         (GtkPort._driver_class):
3542         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3543         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3544         platform directory for storing the wayland specific layout test results and expectations for ${port}.
3545         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3546         test expectations file on the GTK port when running the tests with the --wayland command line switch.
3547         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3548         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3549         (WestonDriver.check_driver):
3550         (WestonDriver.__init__):
3551         (WestonDriver._start):
3552         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3553         (WestonXvfbDriverDisplayTest):
3554         (WestonXvfbDriverDisplayTest.__init__):
3555         (WestonXvfbDriverDisplayTest._xvfb_run):
3556         (WestonDriverTest.make_driver):
3557         (WestonDriverTest.test_start):
3558         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3559         or to satisfy the pkg-config check of the new added modules in JHBuild.
3560         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3561         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3562         provided by the system are already new enough.
3563         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3564         It was the only way to get the software EGL rasterizer working without depending on user drivers.
3565         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3566         feature to avoid building libdrm when the one provided by the system is new enough.
3567         * gtk/jhbuildrc:
3568         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
3569         Xorg had no support for searching the DRI drivers on a custom path at runtime.
3570         This patch implements support for that reusing the same variable that we use with Mesa to set the
3571         custom path for the DRI drivers path.
3572
3573 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
3574
3575         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
3576         https://bugs.webkit.org/show_bug.cgi?id=159256
3577
3578         Reviewed by Philippe Normand.
3579
3580         We need the last fixes in the repository to make the scream queue
3581         work with apprtc.
3582
3583         * gtk/jhbuild.modules:
3584
3585 2016-06-28  Commit Queue  <commit-queue@webkit.org>
3586
3587         Unreviewed, rolling out r202580.
3588         https://bugs.webkit.org/show_bug.cgi?id=159245
3589
3590         Caused all WKTR tests to fail on GuardMalloc and Production
3591         only for unknown reasons, investigating offline. (Requested by
3592         brrian on #webkit).
3593
3594         Reverted changeset:
3595
3596         "RunLoop::Timer should use constructor templates instead of
3597         class templates"
3598         https://bugs.webkit.org/show_bug.cgi?id=159153
3599         http://trac.webkit.org/changeset/202580
3600
3601 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3602
3603         Use a regex to check if a test step is for JavaScriptCore
3604         https://bugs.webkit.org/show_bug.cgi?id=159224
3605
3606         Reviewed by Geoffrey Garen.
3607
3608         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3609         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
3610         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3611         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
3612         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3613         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
3614
3615 2016-06-28  Michael Saboff  <msaboff@apple.com>
3616
3617         btjs no longer accepts optional frame count argument
3618         https://bugs.webkit.org/show_bug.cgi?id=159235
3619
3620         Reviewed by Saam Barati.
3621
3622         Fix the detection of optional backtrace-depth parameter to use the length
3623         of the command.
3624
3625         * lldb/lldb_webkit.py:
3626         (btjs):
3627
3628 2016-06-28  Jon Lee  <jonlee@apple.com>
3629
3630         Update animometer.plan
3631
3632         Rubber-stamped by Said Abou-Hallawa.
3633
3634         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
3635
3636 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
3637
3638         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
3639
3640         * Scripts/run-javascriptcore-tests:
3641         (runJSCStressTests):
3642
3643 2016-06-28  Brian Burg  <bburg@apple.com>
3644
3645         RunLoop::Timer should use constructor templates instead of class templates
3646         https://bugs.webkit.org/show_bug.cgi?id=159153
3647
3648         Reviewed by Alex Christensen.
3649
3650         Remove the RunLoop::Timer class template argument, and pass its constructor
3651         a reference to `this` instead of a pointer to `this`.
3652
3653         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3654         (WTR::TestRunner::TestRunner):
3655         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3656         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3657         (TestWebKitAPI::TEST):
3658
3659 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3660
3661         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3662         https://bugs.webkit.org/show_bug.cgi?id=159199
3663
3664         Reviewed by Alexey Proskuryakov.
3665
3666         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
3667
3668         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3669         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3670         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
3671         an input element getting automatically focused on Mac.
3672
3673 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
3674
3675         [Win] Custom elements tests are failing.
3676         https://bugs.webkit.org/show_bug.cgi?id=159139
3677
3678         Reviewed by Alex Christensen.
3679
3680         Enable custom element API when running tests.
3681
3682         * DumpRenderTree/win/DumpRenderTree.cpp:
3683         (resetWebPreferencesToConsistentValues):
3684
3685 2016-06-27  Lucas Forschler  <lforschler@apple.com>
3686
3687         Test commit. Please ignore.
3688         
3689 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3690
3691         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
3692         https://bugs.webkit.org/show_bug.cgi?id=155073
3693
3694         Reviewed by Daniel Bates.
3695
3696         * Scripts/webkitperl/FeatureList.pm:
3697
3698 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
3699
3700         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3701         https://bugs.webkit.org/show_bug.cgi?id=159077
3702
3703         Reviewed by Tim Horton.
3704
3705         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
3706
3707         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
3708         which is necessary for UI-side compositing.
3709
3710         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
3711         seems to happen for some tests that call window.resizeTo().
3712
3713         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3714         (WTR::InjectedBundlePage::dump): Deleted.
3715         * WebKitTestRunner/TestInvocation.cpp:
3716         (WTR::TestInvocation::dumpResults):
3717         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3718         (WTR::createCGContextFromImage):
3719         (WTR::computeMD5HashStringForContext):
3720         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3721         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3722         (WTR::PlatformWebView::windowSnapshotImage):
3723
3724 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3725
3726         [EFL] Support to build on Debian linux
3727         https://bugs.webkit.org/show_bug.cgi?id=159123
3728
3729         Reviewed by Antonio Gomes.
3730
3731         * efl/install-dependencies: Install libgnutls28-dev.
3732
3733 2016-06-27  Alex Christensen  <achristensen@webkit.org>
3734
3735         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
3736         https://bugs.webkit.org/show_bug.cgi?id=159071
3737
3738         Reviewed by Brady Eidson.
3739
3740         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3741         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3742         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3743         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3744         (WTR::TestRunner::setAuthenticationUsername):
3745         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3746         * WebKitTestRunner/TestController.cpp:
3747         (WTR::TestController::TestController):
3748         (WTR::TestController::resetStateToConsistentValues):
3749         (WTR::TestController::didFinishNavigation):
3750         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3751         (WTR::TestController::didReceiveAuthenticationChallenge):
3752         (WTR::TestController::didCommitNavigation):
3753         * WebKitTestRunner/TestController.h:
3754         (WTR::TestController::setBlockAllPlugins):
3755         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3756         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
3757         (WTR::TestController::isCurrentInvocation):
3758         * WebKitTestRunner/TestInvocation.cpp:
3759         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3760         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
3761
3762 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
3763
3764         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
3765         https://bugs.webkit.org/show_bug.cgi?id=159129
3766
3767         Reviewed by Alex Christensen.
3768
3769         Implement the function mouseScrollBy in the Windows event sender.
3770
3771         * DumpRenderTree/win/EventSender.cpp:
3772         (mouseScrollBy):
3773         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3774
3775 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
3776
3777         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3778         https://bugs.webkit.org/show_bug.cgi?id=159104
3779
3780         Reviewed by Dan Bernstein.
3781         
3782         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
3783         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
3784
3785         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3786         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
3788
3789 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
3790
3791         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
3792         https://bugs.webkit.org/show_bug.cgi?id=159086
3793
3794         Reviewed by Alex Christensen.
3795
3796         Implement required wheel event function in event sender.
3797  
3798         * DumpRenderTree/win/EventSender.cpp:
3799         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3800
3801 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
3802
3803         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3804         https://bugs.webkit.org/show_bug.cgi?id=159104
3805
3806         Reviewed by Mark Lam.
3807         
3808         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
3809         WK.
3810
3811         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3812
3813 2016-06-24  David Kilzer  <ddkilzer@apple.com>
3814
3815         parser_unittests.pl should not hardcode list of tests
3816         <https://webkit.org/b/159074>
3817
3818         Reviewed by Daniel Bates.
3819
3820         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3821         Update to read the list of tests from the 'resources' directory,
3822         and instead map file extensions to subroutine names.  Switch to
3823         use File::Basename::fileparse() to get basename and file
3824         extension for each test.
3825         (readTestFiles): Added.  Reads files from the directory passed
3826         in and ignores: hidden files, anything that isn't a plain file,
3827         and expected test results files.
3828
3829 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3830
3831         Fix Windows build.
3832
3833         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3834         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3835
3836 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3837
3838         [EFL] Change download path of libxslt
3839
3840         Unreviewed EFL build fix.
3841
3842         In Korea current download path can't be accessed. Change it.
3843
3844         * efl/jhbuild.modules:
3845
3846 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3847
3848         https://bugs.webkit.org/show_bug.cgi?id=159077
3849
3850         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
3851         snapshot the final state of the test in release builds. 
3852
3853         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3854         (WTR::InjectedBundlePage::dump):
3855
3856 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3857
3858         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
3859
3860         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3861         (createBitmapContextFromWebView):
3862         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3863         (WTR::PlatformWebView::windowSnapshotImage):
3864
3865 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3866
3867         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3868         https://bugs.webkit.org/show_bug.cgi?id=159077
3869
3870         Reviewed by Tim Horton.
3871
3872         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
3873         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
3874         thus enabling testing of more things.
3875
3876         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3877         (createBitmapContext): Moved to this file to share it.
3878         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3879         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3880         (createBitmapContextFromWebView):
3881         (BitmapContext::createFromUIImage): Deleted.
3882         (BitmapContext::pixelData): Deleted.
3883         (BitmapContext::BitmapContext): Deleted.
3884         (computeMD5HashStringForBitmapContext): Deleted.
3885         (dumpBitmap): Deleted.
3886         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
3887         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3888         (createPagedBitmapContext):
3889         (createBitmapContext): Deleted.
3890         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
3891         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3892         (WTR::InjectedBundlePage::dump): Deleted.
3893         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3894         (WTR::PlatformWebView::windowSnapshotImage):
3895
3896 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3897
3898         [jhbuild] Added libxslt module.
3899         https://bugs.webkit.org/show_bug.cgi?id=159034
3900
3901         Unreviewed, followup for r202373.
3902
3903         * efl/install-dependencies: Removed libxslt 
3904         * gtk/install-dependencies: Ditto.
3905
3906 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3907
3908         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
3909         https://bugs.webkit.org/show_bug.cgi?id=159050
3910
3911         Reviewed by Antonio Gomes.
3912
3913         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
3914
3915         * efl/jhbuild.modules:
3916         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3917         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3918
3919 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3920
3921         [jhbuild] Added libxslt module.
3922         https://bugs.webkit.org/show_bug.cgi?id=159034
3923
3924         Reviewed by Michael Catanzaro.
3925
3926         * efl/jhbuild.modules:
3927         * gtk/jhbuild.modules:
3928
3929 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3930
3931         [Win] Use Windows api function to find top level parent.
3932         https://bugs.webkit.org/show_bug.cgi?id=159021
3933
3934         Reviewed by Brent Fulgham.
3935
3936         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
3937  
3938         * DumpRenderTree/win/UIDelegate.cpp:
3939         (UIDelegate::runModal):
3940         (findTopLevelParent): Deleted.
3941         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3942         (PrintWebUIDelegate::runModal):
3943         (findTopLevelParent): Deleted.
3944
3945 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3946
3947         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
3948         https://bugs.webkit.org/show_bug.cgi?id=158934
3949
3950         Reviewed by Brent Fulgham.
3951
3952         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
3953
3954         * DumpRenderTree/win/TestRunnerWin.cpp:
3955         (TestRunner::clearAllDatabases):
3956
3957 2016-06-22  Saam Barati  <sbarati@apple.com>
3958
3959         run-javascriptcore-tests should have some environment variables for commonly used settings
3960         https://bugs.webkit.org/show_bug.cgi?id=159047
3961
3962         Reviewed by Keith Miller.
3963
3964         This patch adds three environment variables that run-javascriptcore-tests
3965         consults:
3966         - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
3967           determines if we should run the api tests or not.
3968         - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
3969           determines if we will perform a build or not before running the tests.
3970           to set the default should-build setting.
3971         - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
3972           a yaml file. If set, we will run the extra tests it refers to.
3973
3974         All the values in these environment variables will be overridden if an
3975         option is explicitly passed in. For example, the following will run
3976         the api tests:
3977         `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
3978
3979         * Scripts/run-javascriptcore-tests:
3980
3981 2016-06-22  Saam barati  <sbarati@apple.com>
3982
3983         TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
3984         https://bugs.webkit.org/show_bug.cgi?id=159037
3985         <rdar://problem/26935349>
3986
3987         Reviewed by Benjamin Poulain.
3988
3989         Run typeProfiler.yaml tests under an additional CJIT enabled mode.
3990
3991         * Scripts/run-jsc-stress-tests:
3992
3993 2016-06-22  Aakash Jain  <aakash_jain@apple.com>
3994
3995         Fix style issues in webkitpy
3996         https://bugs.webkit.org/show_bug.cgi?id=159019
3997
3998         Reviewed by Daniel Bates.
3999
4000         Fixed the formatting issues as reported by check-webkit-style in webkitpy.
4001         There is no functionality change.
4002         Only affected file names retained below for brevity.
4003
4004         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
4005         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
4006         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
4007         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
4008         * Scripts/webkitpy/benchmark_runner/utils.py:
4009         * Scripts/webkitpy/common/checkout/changelog.py:
4010         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4011         * Scripts/webkitpy/common/checkout/checkout.py:
4012         * Scripts/webkitpy/common/checkout/checkout_mock.py:
4013         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
4014         * Scripts/webkitpy/common/checkout/commitinfo.py:
4015         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
4016         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
4017         * Scripts/webkitpy/common/checkout/scm/scm.py:
4018         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4019         * Scripts/webkitpy/common/config/committers_unittest.py:
4020         * Scripts/webkitpy/common/config/irc.py:
4021         * Scripts/webkitpy/common/config/ports.py:
4022         * Scripts/webkitpy/common/config/ports_unittest.py:
4023         * Scripts/webkitpy/common/config/urls.py:
4024         * Scripts/webkitpy/common/host_mock.py:
4025         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4026         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4027         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4028         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
4029         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4030         * Scripts/webkitpy/common/net/credentials_unittest.py:
4031         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
4032         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
4033         * Scripts/webkitpy/common/net/statusserver.py:
4034         * Scripts/webkitpy/common/system/autoinstall.py:
4035         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
4036         * Scripts/webkitpy/common/system/executive.py:
4037         * Scripts/webkitpy/common/system/executive_mock.py:
4038         * Scripts/webkitpy/common/system/executive_unittest.py:
4039         * Scripts/webkitpy/common/system/filesystem_mock.py:
4040         * Scripts/webkitpy/common/system/filesystem_unittest.py:
4041         * Scripts/webkitpy/common/system/logutils_unittest.py:
4042         * Scripts/webkitpy/common/system/path.py:
4043         * Scripts/webkitpy/common/system/path_unittest.py:
4044         * Scripts/webkitpy/common/system/platforminfo.py:
4045         * Scripts/webkitpy/common/system/user.py:
4046         * Scripts/webkitpy/common/system/user_unittest.py:
4047         * Scripts/webkitpy/common/system/workspace_unittest.py:
4048         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
4049         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
4050         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
4051         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4052         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4053         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4054         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
4055         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
4056         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4057         * Scripts/webkitpy/layout_tests/models/test_failures.py:
4058         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
4059         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4060         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
4061         * Scripts/webkitpy/layout_tests/views/printing.py:
4062         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4063         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
4064         * Scripts/webkitpy/port/base_unittest.py:
4065         * Scripts/webkitpy/port/driver.py:
4066         * Scripts/webkitpy/port/driver_unittest.py:
4067         * Scripts/webkitpy/port/factory.py:
4068         * Scripts/webkitpy/port/gtk.py:
4069         * Scripts/webkitpy/port/server_process_unittest.py:
4070         * Scripts/webkitpy/port/test.py:
4071         * Scripts/webkitpy/port/win.py:
4072         * Scripts/webkitpy/style/checker.py:
4073         * Scripts/webkitpy/style/checkers/common_unittest.py:
4074         * Scripts/webkitpy/style/checkers/cpp.py:
4075         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4076         * Scripts/webkitpy/style/checkers/js.py:
4077         * Scripts/webkitpy/style/checkers/jsonchecker.py:
4078         * Scripts/webkitpy/style/checkers/png.py:
4079         * Scripts/webkitpy/style/checkers/text.py:
4080         * Scripts/webkitpy/style/checkers/text_unittest.py:
4081         * Scripts/webkitpy/style/error_handlers.py:
4082         * Scripts/webkitpy/style/filter.py:
4083         * Scripts/webkitpy/style/filter_unittest.py:
4084         * Scripts/webkitpy/style/optparser.py:
4085         * Scripts/webkitpy/style/optparser_unittest.py:
4086         * Scripts/webkitpy/test/main.py:
4087         * Scripts/webkitpy/w3c/test_converter.py:
4088         * Scripts/webkitpy/w3c/test_converter_unittest.py:
4089         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4090         * Scripts/webkitpy/xcode/simulator.py:
4091
4092 2016-06-22  Brady Eidson  <beidson@apple.com>
4093
4094         DatabaseProcess doesn't handle WebProcesses going away uncleanly.
4095         https://bugs.webkit.org/show_bug.cgi?id=158894
4096
4097         Reviewed by Alex Christensen.
4098
4099         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4100         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
4101         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
4102         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
4103
4104 2016-06-22  Jon Lee  <jonlee@apple.com>
4105
4106         Update animometer.plan
4107         https://bugs.webkit.org/show_bug.cgi?id=159012
4108
4109         Reviewed by Ryosuke Niwa.
4110
4111         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
4112
4113 2016-06-22  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4114
4115         W3C test importer should generate files to ignore by WebKit SCM
4116         https://bugs.webkit.org/show_bug.cgi?id=142743
4117
4118         Reviewed by Darin Adler.
4119
4120         TestDownloader generates the .gitignore file according submodules git repository information.
4121         TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.
4122
4123         * Scripts/webkitpy/w3c/test_downloader.py:
4124         (TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
4125         * Scripts/webkitpy/w3c/test_importer.py:
4126         (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
4127         (TestImporter):
4128         (TestImporter.write_init_py): Writing not empty __init__.py files.
4129         (TestImporter.import_tests): Using  of write_init_py. 
4130         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4131         (TestImporterTest.test_git_ignore_generation): Added .gitignore test.
4132         (TestImporterTest):
4133         (TestImporterTest.test_initpy_generation): Added __init__.py test.
4134
4135 2016-06-21  Sam Weinig  <sam@webkit.org>
4136
4137         WKWebView with no WKNavigationDelegate does not follow universal links
4138         <rdar://problem/24374110>
4139         https://bugs.webkit.org/show_bug.cgi?id=158997
4140
4141         Reviewed by Dan Bernstein.
4142
4143         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4144         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
4145         Add a new test that shows that we have a default navigation delegate by swizzling
4146         -[NSWorkspace openURL:]. This will only be called if there is a default client.
4147
4148 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4149
4150         [Win] Implement modal dialog support in MiniBrowser.
4151         https://bugs.webkit.org/show_bug.cgi?id=158976
4152
4153         Reviewed by Brent Fulgham.
4154
4155         * MiniBrowser/win/PrintWebUIDelegate.cpp:
4156         (PrintWebUIDelegate::createWebViewWithRequest):
4157         (getHandleFromWebView):
4158         (PrintWebUIDelegate::webViewClose):
4159         (PrintWebUIDelegate::setFrame):
4160         (PrintWebUIDelegate::webViewFrame):
4161         (PrintWebUIDelegate::canRunModal):
4162         (findTopLevelParent):
4163         (PrintWebUIDelegate::runModal):
4164         (PrintWebUIDelegate::createModalDialog):
4165         * MiniBrowser/win/PrintWebUIDelegate.h:
4166         (PrintWebUIDelegate::webViewClose):
4167         (PrintWebUIDelegate::setFrame):
4168         (PrintWebUIDelegate::webViewFrame):
4169         (PrintWebUIDelegate::canRunModal):
4170         (PrintWebUIDelegate::runModal):
4171
4172 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4173
4174         window.showModalDialog doesn't work in DumpRenderTree on Windows
4175         https://bugs.webkit.org/show_bug.cgi?id=53675
4176
4177         Reviewed by Brent Fulgham.
4178
4179         Implement modal dialog support in DumpRenderTree.
4180
4181         * DumpRenderTree/win/UIDelegate.cpp:
4182         (UIDelegate::canRunModal):
4183         (getHandleFromWebView):
4184         (UIDelegate::createModalDialog):
4185         (findTopLevelParent):
4186         (UIDelegate::runModal):
4187         (UIDelegate::webViewClose):
4188         * DumpRenderTree/win/UIDelegate.h:
4189
4190 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
4191
4192         Fix formatting issues reported by check-webkit-style
4193         https://bugs.webkit.org/show_bug.cgi?id=159008
4194
4195         Reviewed by Alexey Proskuryakov.
4196
4197         Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
4198         There is no functionality change.
4199
4200         * Scripts/webkitpy/tool/bot/irc_command.py:
4201         (Restart.execute):
4202         (Rollout):
4203         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
4204         (IRCBotTest.test_exception_during_command):
4205         (IRCBotTest.test_exception_during_command.CommandWithException):
4206         (IRCBotTest.test_exception_during_command.CommandWithException.execute):
4207         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
4208         (test_missing_unit_test_results_path):
4209         (test_layout_test_results):
4210         * Scripts/webkitpy/tool/bot/queueengine.py:
4211         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
4212         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
4213         (AbstractSequencedCommand):
4214         (AbstractSequencedCommand.__init__):
4215         * Scripts/webkitpy/tool/commands/download.py:
4216         (Land):
4217         * Scripts/webkitpy/tool/commands/openbugs.py:
4218         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
4219         (OpenBugsTest):
4220         * Scripts/webkitpy/tool/commands/queries.py:
4221         (PatchesToCommitQueue):
4222         (PatchesToCommitQueue.__init__):
4223         (PatchesToCommitQueue._needs_commit_queue):
4224         * Scripts/webkitpy/tool/commands/queries_unittest.py:
4225         (PrintExpectationsTest.test_platform):
4226         (PrintBaselinesTest):
4227         (PrintBaselinesTest.setUp):
4228         * Scripts/webkitpy/tool/commands/queues.py:
4229         (AbstractQueue):
4230         (AbstractQueue.__init__):
4231         (AbstractQueue.execute):
4232         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4233         (test_auto_retry):
4234         * Scripts/webkitpy/tool/commands/rebaseline.py:
4235         (AbstractParallelRebaselineCommand._files_to_add):
4236         (AbstractParallelRebaselineCommand):
4237         (AbstractParallelRebaselineCommand._rebaseline):
4238         * Scripts/webkitpy/tool/commands/setupgitclone.py:
4239         (SetupGitClone):
4240         * Scripts/webkitpy/tool/commands/sheriffbot.py:
4241         * Scripts/webkitpy/tool/commands/stepsequence.py:
4242         * Scripts/webkitpy/tool/commands/upload.py:
4243         (PostCommits._comment_text_for_commit):
4244         (PostCommits):
4245         (PostCommits.execute):
4246         (MarkBugFixed):
4247         (MarkBugFixed.__init__):
4248         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4249         (UploadCommandsTest):
4250         (UploadCommandsTest.test_commit_message_for_current_diff):
4251         * Scripts/webkitpy/tool/grammar_unittest.py:
4252         (GrammarTest):
4253         (GrammarTest.test_join_with_separators):
4254         * Scripts/webkitpy/tool/multicommandtool.py:
4255         (HelpCommand.__init__):
4256         (HelpCommand):
4257         (HelpCommand._help_epilog):
4258         (HelpCommand._remove_help_options):
4259         (MultiCommandTool):
4260         (MultiCommandTool.__init__):
4261         (MultiCommandTool.main):
4262         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
4263         (TrivialCommand):
4264         (TrivialCommand.__init__):
4265         (MultiCommandToolTest):
4266         (MultiCommandToolTest._assert_tool_main_outputs):
4267         (MultiCommandToolTest.test_retry):
4268         (test_command_help):
4269         * Scripts/webkitpy/tool/steps/__init__.py:
4270         * Scripts/webkitpy/tool/steps/abstractstep.py:
4271         * Scripts/webkitpy/tool/steps/applypatch.py:
4272         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
4273         (ApplyPatchWithLocalCommit):
4274   &