Unreviewed, rolling out r243833.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-05  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r243833.
4         https://bugs.webkit.org/show_bug.cgi?id=196645
5
6         This change breaks build of WPE and GTK ports (Requested by
7         annulen on #webkit).
8
9         Reverted changeset:
10
11         "[CMake][WTF] Mirror XCode header directories"
12         https://bugs.webkit.org/show_bug.cgi?id=191662
13         https://trac.webkit.org/changeset/243833
14
15 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
16
17         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
18         https://bugs.webkit.org/show_bug.cgi?id=196635
19
20         Reviewed by Antti Koivisto.
21         
22         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
23         for a test to enable async frame scrolling via:
24             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
25         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
26         
27         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
28
29         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
30         (WTR::InjectedBundle::beginTesting):
31         * WebKitTestRunner/TestController.cpp:
32         (WTR::TestController::resetPreferencesToConsistentValues):
33
34 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
35
36         Use a correct LC_RPATH when building with ASan
37         https://bugs.webkit.org/show_bug.cgi?id=196576
38
39         Reviewed by David Kilzer.
40
41         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
42         so that ../Frameworks is checked. This is simpler and more reliable than updating
43         each SPC service xcconfig.
44
45 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
46
47         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
48         https://bugs.webkit.org/show_bug.cgi?id=196629
49
50         Reviewed by Lucas Forschler.
51
52         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
53
54 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
55
56         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
57         https://bugs.webkit.org/show_bug.cgi?id=196618
58
59         Reviewed by Lucas Forschler.
60
61         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
62         (StatusBubble): Added QUEUE_TRIGGERS.
63         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
64         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
65         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
66         its parent(builder).
67
68 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
69
70         [ews-app] Status-bubble steps are sometimes displayed in reverse order
71         https://bugs.webkit.org/show_bug.cgi?id=196625
72
73         Reviewed by Lucas Forschler.
74
75         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
76         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
77
78 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
79
80         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
81         https://bugs.webkit.org/show_bug.cgi?id=196630
82
83         Reviewed by Wenson Hsieh.
84
85         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
86
87 2019-04-04  Youenn Fablet  <youenn@apple.com>
88
89         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
90         https://bugs.webkit.org/show_bug.cgi?id=196543
91
92         Reviewed by Alex Christensen.
93
94         * WebKitTestRunner/TestController.cpp:
95         (WTR::TestController::generatePageConfiguration):
96
97 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
98
99         [ews-app] Status bubble should not display skipped buildbot steps
100         https://bugs.webkit.org/show_bug.cgi?id=196584
101
102         Reviewed by Lucas Forschler.
103
104         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
105
106 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
107
108         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
109         https://bugs.webkit.org/show_bug.cgi?id=196620
110
111         Reviewed by Lucas Forschler.
112
113         * BuildSlaveSupport/ews-app/ews/config.py:
114
115 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
116
117         [Win] DumpRenderTreeWatchDog.py is not checked into source
118         https://bugs.webkit.org/show_bug.cgi?id=196567
119         <rdar://problem/49525901>
120
121         Reviewed by Lucas Forschler.
122
123         This script is used on Win EWS bots to terminate hanging DRT processes.
124
125         * EWSTools/dumprendertreewatchdog.py: Added.
126
127 2019-04-04  Chris Dumez  <cdumez@apple.com>
128
129         Unreviewed, roll out r243858 which made tests time out.
130
131         Disable new API tests on Windows instead.
132
133         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
134         (TestWebKitAPI::TEST):
135
136 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
137
138         [ATK] Cleanup WebPageAccessibilityObjectAtk
139         https://bugs.webkit.org/show_bug.cgi?id=196537
140
141         Reviewed by Michael Catanzaro.
142
143         Also consider files under atk directories as exceptions for GObject conventions.
144
145         * Scripts/webkitpy/style/checkers/cpp.py:
146         (check_identifier_name_in_declaration):
147
148 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
149
150         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
151         https://bugs.webkit.org/show_bug.cgi?id=196588
152         <rdar://problem/49365787>
153
154         Unreviewed build fix for Windows port.
155
156         error C3861: 'kill': identifier not found
157
158         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
159         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
160
161 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
162
163         [ews-build] Cancel build and similar operations should have authentication
164         https://bugs.webkit.org/show_bug.cgi?id=196520
165
166         Reviewed by Dewei Zhu.
167
168         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
169         environment variables.
170
171 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
172
173         [ews-build] Do not trigger queues which are not in production yet
174         https://bugs.webkit.org/show_bug.cgi?id=196581
175
176         Reviewed by Dewei Zhu.
177
178         * BuildSlaveSupport/ews-build/config.json:
179
180 2019-04-03  Chris Dumez  <cdumez@apple.com>
181
182         Unreviewed, fix typo in the name of API test added in r243848.
183
184         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
185         (TestWebKitAPI::TEST):
186
187 2019-04-03  Chris Dumez  <cdumez@apple.com>
188
189         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
190         https://bugs.webkit.org/show_bug.cgi?id=196588
191         <rdar://problem/49365787>
192
193         Reviewed by Ryosuke Niwa.
194
195         Add API test coverage.
196
197         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
198         (TestWebKitAPI::nullJavaScriptCallback):
199         (TestWebKitAPI::didCrashCheckFrames):
200         (TestWebKitAPI::TEST):
201
202 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
203
204         run-webkit-tests: Upload test results (new results database)
205         https://bugs.webkit.org/show_bug.cgi?id=196577
206         <rdar://problem/34841155>
207
208         Reviewed by Lucas Forschler.
209
210         * Scripts/webkitpy/layout_tests/controllers/manager.py:
211         (Manager.run): Upload results after each device shard, since the configuration will be
212         different for each device.
213         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
214         uploaded to a results database.
215         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
216         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
217
218 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
219
220         -apple-trailing-word is needed for browser detection
221         https://bugs.webkit.org/show_bug.cgi?id=196575
222
223         Unreviewed.
224
225         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
226
227 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
228
229         [CMake][WTF] Mirror XCode header directories
230         https://bugs.webkit.org/show_bug.cgi?id=191662
231
232         Reviewed by Konstantin Tokarev.
233
234         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
235         builds.
236
237         * CMakeLists.txt:
238         * DumpRenderTree/CMakeLists.txt:
239         * DumpRenderTree/PlatformWin.cmake:
240         * MiniBrowser/win/CMakeLists.txt:
241         * TestWebKitAPI/CMakeLists.txt:
242         * TestWebKitAPI/PlatformWin.cmake:
243         * WebKitTestRunner/PlatformGTK.cmake:
244         * WebKitTestRunner/PlatformWin.cmake:
245
246 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
247
248         [ews-app] Status bubble should not display certain infrastructure status messages
249         https://bugs.webkit.org/show_bug.cgi?id=196550
250
251         Reviewed by Lucas Forschler.
252
253         Do not display the steps which are un-needed for end-user. This information is still avaiable
254         if the user click on the bubble and look at the Buildbot build.
255         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
256         (StatusBubble._steps_messages):
257         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
258
259 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
260
261         [ews-build] Use https for sending data to ews-app
262         https://bugs.webkit.org/show_bug.cgi?id=196492
263
264         Reviewed by Lucas Forschler.
265
266         * BuildSlaveSupport/ews-build/events.py:
267
268 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
269
270         Remove support for -apple-trailing-word
271         https://bugs.webkit.org/show_bug.cgi?id=196525
272
273         Reviewed by Zalan Bujtas.
274
275         This CSS property is nonstandard and not used.
276
277         * Scripts/webkitperl/FeatureList.pm:
278         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
279
280 2019-04-03  Youenn Fablet  <youenn@apple.com>
281
282         Add a test for DOMCache on multiple browsing in case of private browsing
283         https://bugs.webkit.org/show_bug.cgi?id=196524
284
285         Reviewed by Alex Christensen.
286
287         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
288         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
289
290 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
291
292         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
293         https://bugs.webkit.org/show_bug.cgi?id=196540
294
295         Reviewed by Aakash Jain.
296
297         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
298
299 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
300
301         Add plumbing for a compatibility mode preference in WebKit
302         https://bugs.webkit.org/show_bug.cgi?id=196005
303
304         Reviewed by Tim Horton.
305
306         Add new API tests.
307
308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
309         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
310
311 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
312
313         [WPE][GTK] Update libsrtp dependency package for Debian
314         https://bugs.webkit.org/show_bug.cgi?id=196528
315
316         Reviewed by Frédéric Wang.
317
318         * gtk/install-dependencies:
319         * wpe/install-dependencies:
320
321 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
322
323         [WK2] Add support for Window's beforeprint / afterprint events
324         https://bugs.webkit.org/show_bug.cgi?id=196478
325         <rdar://problem/49535124>
326
327         Unreviewed build fix for MSVC.
328
329         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
330
331         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
332
333         * WebKitTestRunner/TestController.cpp:
334         (WTR::printFrame): Use int and float literals.
335
336 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
337
338         [ews-build] Reassign bots to queues
339
340         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
341
342 2019-04-02  Chris Dumez  <cdumez@apple.com>
343
344         [WK2] Add support for Window's beforeprint / afterprint events
345         https://bugs.webkit.org/show_bug.cgi?id=196478
346
347         Reviewed by Alex Christensen.
348
349         Add minimal implementation for printFrame in WebKitTestRunner.
350
351         * WebKitTestRunner/TestController.cpp:
352         (WTR::printFrame):
353         (WTR::TestController::createOtherPage):
354         (WTR::TestController::createWebViewWithOptions):
355
356 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
357
358         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
359         https://bugs.webkit.org/show_bug.cgi?id=196491
360
361         Reviewed by Lucas Forschler.
362
363         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
364
365 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
366
367         [ews-build] Configure buildbot try credentials in environment variables
368         https://bugs.webkit.org/show_bug.cgi?id=196501
369
370         Reviewed by Lucas Forschler.
371
372         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
373         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
374         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
375
376 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
377
378         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
379         https://bugs.webkit.org/show_bug.cgi?id=196496
380         <rdar://problem/49521634>
381
382         Reviewed by Chris Dumez.
383
384         Add new API tests (see WebKit ChangeLog for more detail).
385
386         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
387         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
388         (TEST):
389
390 2019-04-02  David Kilzer  <ddkilzer@apple.com>
391
392         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
393         <https://webkit.org/b/196499>
394
395         Reviewed by Alexey Proskuryakov.
396
397         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
398         ENABLE_ADDRESS_SANITIZER.
399
400 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
401
402         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
403         https://bugs.webkit.org/show_bug.cgi?id=182757
404
405         Reviewed by Don Olmstead.
406
407         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
408         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
409
410 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
411
412         run-api-tests: Upload test results
413         https://bugs.webkit.org/show_bug.cgi?id=196323
414         <rdar://problem/49356714>
415
416         Reviewed by Lucas Forschler.
417
418         * Scripts/webkitpy/api_tests/manager.py:
419         (Manager):
420         (Manager.run): Upload results to a results database.
421         * Scripts/webkitpy/api_tests/run_api_tests.py:
422         (parse_args): Add upload arguments.
423         * Scripts/webkitpy/port/base.py:
424         (Port):
425         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
426         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
427         with commits from any other associated repositories.
428         * Scripts/webkitpy/port/device.py:
429         (Device):
430         (Device.build_version): Access build_versoin of underlying platform device.
431         * Scripts/webkitpy/port/ios_simulator_unittest.py:
432         (IOSSimulatorTest):
433         (IOSSimulatorTest.test_configuration_for_upload):
434         * Scripts/webkitpy/port/device_port.py:
435         (DevicePort):
436         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
437         the same as the machine uploading results.
438         * Scripts/webkitpy/port/mac.py:
439         (MacPort):
440         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
441         * Scripts/webkitpy/port/mac_unittest.py:
442         (MacTest):
443         (MacTest.test_configuration_for_upload):
444         * Scripts/webkitpy/xcode/simulated_device.py:
445         (SimulatedDeviceManager._create_device_with_runtime):
446         (SimulatedDevice.__init__): Create simulated device with a build_version.
447         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
448         (test_existing_simulator):
449
450 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
451
452         Remove extra newline characters (Follow-up fix to r243707)
453
454         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
455
456 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
457
458         [ews-app] Use API_KEY to accept results data
459         https://bugs.webkit.org/show_bug.cgi?id=196461
460
461         Reviewed by Dewei Zhu.
462
463         * BuildSlaveSupport/ews-app/ews/views/results.py:
464         (Results.post): Validate EWS_API_KEY before accepting any data.
465         * BuildSlaveSupport/ews-build/events.py:
466         (Events.sendData): Send EWS_API_KEY if available along with event data.
467
468 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
469
470         Unable to copy and paste a PDF from Notes into Mail compose body
471         https://bugs.webkit.org/show_bug.cgi?id=196442
472         <rdar://problem/48573098>
473
474         Reviewed by Tim Horton.
475
476         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
477         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
478         to be specified on the item providers.
479
480         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
481         (TestWebKitAPI::mapItemForTesting):
482         (TestWebKitAPI::contactItemForTesting):
483
484 2019-04-01  Tim Horton  <timothy_horton@apple.com>
485
486         Make UIWKDocumentContext rects per-character instead of per-word
487         https://bugs.webkit.org/show_bug.cgi?id=196459
488
489         Reviewed by Wenson Hsieh.
490
491         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
492         (TEST):
493         Adjust test results due to switching to per-character rects.
494
495 2019-04-01  Chris Dumez  <cdumez@apple.com>
496
497         UIProcess crash when a prewarmed process is terminated
498         https://bugs.webkit.org/show_bug.cgi?id=196451
499         <rdar://problem/49245471>
500
501         Reviewed by Geoffrey Garen.
502
503         Add API test coverage.
504
505         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
506         (TEST):
507
508 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
509
510         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
511         https://bugs.webkit.org/show_bug.cgi?id=196449
512
513         Reviewed by Lucas Forschler.
514
515         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
516         (StatusBubble.get_os_details): Method to get OS and Xcode details.
517         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
518         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
519
520 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
521
522         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
523         https://bugs.webkit.org/show_bug.cgi?id=196444
524
525         Reviewed by Lucas Forschler.
526
527         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
528
529 2019-04-01  Alex Christensen  <achristensen@webkit.org>
530
531         Add SPI to canonicalize NSURLs with WTF::URL
532         https://bugs.webkit.org/show_bug.cgi?id=196415
533         <rdar://problem/44980271>
534
535         Reviewed by Darin Adler.
536
537         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
538         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
539         (TestWebKitAPI::TEST):
540
541 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
542
543         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
544         https://bugs.webkit.org/show_bug.cgi?id=196441
545
546         Reviewed by Carlos Garcia Campos.
547
548         Don't cache the wpe_view_backend object that might not exist yet at the
549         time of EventSenderProxy constructor invocation, but instead retrieve
550         that object whenever it's required for event dispatching. This should
551         avoid crashes in this constructor now that it's invoked before any
552         PlatformWindow has been set up (as changed in r243496).
553
554         * WebKitTestRunner/EventSenderProxy.h:
555         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
556         (WTR::viewBackend):
557         (WTR::EventSenderProxy::EventSenderProxy):
558         (WTR::EventSenderProxy::mouseDown):
559         (WTR::EventSenderProxy::mouseUp):
560         (WTR::EventSenderProxy::mouseMoveTo):
561         (WTR::EventSenderProxy::mouseScrollBy):
562         (WTR::EventSenderProxy::keyDown):
563         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
564
565 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
566
567         [Win][WebKit] MiniBrowser should support high DPI display
568         https://bugs.webkit.org/show_bug.cgi?id=196391
569
570         Reviewed by Alex Christensen.
571
572         * MiniBrowser/win/WebKitBrowserWindow.cpp:
573         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
574         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
575         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
576
577 2019-03-31  Sam Weinig  <weinig@apple.com>
578
579         Remove more i386 specific configurations
580         https://bugs.webkit.org/show_bug.cgi?id=196430
581
582         Reviewed by Alexey Proskuryakov.
583
584         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
585         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
586
587 2019-03-31  Andy Estes  <aestes@apple.com>
588
589         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
590         https://bugs.webkit.org/show_bug.cgi?id=196433
591         <rdar://problem/49293305>
592
593         Reviewed by Tim Horton.
594
595         Enhanced API test coverage to include all navigation response policy decisions in both
596         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
597
598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
599         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
600         (TestWebKitAPI::TEST):
601         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
602         (readFile):
603         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
604         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
605         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
606         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
607         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
608         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
609         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
610         (-[QuickLookDelegate _downloadDidStart:]):
611         (-[QuickLookDelegate _download:didReceiveResponse:]):
612         (-[QuickLookDelegate _download:didReceiveData:]):
613         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
614         (-[QuickLookDelegate _downloadDidFinish:]):
615         (-[QuickLookDelegate _download:didFailWithError:]):
616         (-[QuickLookDelegate _downloadDidCancel:]):
617         (-[QuickLookDelegate verifyDownload]):
618         (runTest):
619         (runTestDecideBeforeLoading):
620         (runTestDecideAfterLoading):
621         (TEST):
622         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
623         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
624         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
625         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
626         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
627         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
628         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
629         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
630         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
631         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
632         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
633         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
634         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
635         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
636
637 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
638
639         [CMake] add testdfg as target with build-jsc
640         https://bugs.webkit.org/show_bug.cgi?id=196393
641
642         Reviewed by Saam Barati.
643
644         Added testdfg as one of the targets to build when
645         using CMake.
646
647         * Scripts/build-jsc:
648
649 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
650
651         Delete WebMetal implementation in favor of WebGPU
652         https://bugs.webkit.org/show_bug.cgi?id=195418
653
654         Reviewed by Dean Jackson.
655
656         * DumpRenderTree/mac/DumpRenderTree.mm:
657         (enableExperimentalFeatures):
658         (resetWebPreferencesToConsistentValues):
659         * Scripts/webkitperl/FeatureList.pm:
660         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
662         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
663         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
664         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
665         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
666         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
667         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
668         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
669         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
670         (WTR::InjectedBundle::beginTesting):
671         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
672         (WTR::TestRunner::setWebMetalEnabled): Deleted.
673         * WebKitTestRunner/InjectedBundle/TestRunner.h:
674
675 2019-03-29  Chris Dumez  <cdumez@apple.com>
676
677         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
678         https://bugs.webkit.org/show_bug.cgi?id=196405
679         <rdar://problem/49428130>
680
681         Reviewed by Wenson Hsieh.
682
683         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
684         the popover presentation methods to be no-ops. Use this in the new test added in
685         r243523 so that we do not swizzle those methods for all tests. This is needed because
686         those WatchOS tests rely on the popover getting presented and interactive.
687
688         * WebKitTestRunner/TestController.cpp:
689         (WTR::updateTestOptionsFromTestHeader):
690         * WebKitTestRunner/TestController.h:
691         * WebKitTestRunner/TestOptions.h:
692         (WTR::TestOptions::hasSameInitializationOptions const):
693         * WebKitTestRunner/ios/TestControllerIOS.mm:
694         (WTR::TestController::platformInitialize):
695         (WTR::TestController::platformResetStateToConsistentValues):
696
697 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
698
699         [Curl] Add Server Trust Evaluation Support.
700         https://bugs.webkit.org/show_bug.cgi?id=191646
701
702         Reviewed by Fujii Hironori.
703
704         Implemented MiniBrowser UI for asking if user trusts the server.
705
706         * MiniBrowser/win/Common.cpp:
707         (askServerTrustEvaluation):
708         (replaceString):
709         * MiniBrowser/win/Common.h:
710         * MiniBrowser/win/MiniBrowserLib.rc:
711         * MiniBrowser/win/MiniBrowserLibResource.h:
712         * MiniBrowser/win/WebKitBrowserWindow.cpp:
713         (createPEMString):
714         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
715         (WebKitBrowserWindow::canTrustServerCertificate):
716         * MiniBrowser/win/WebKitBrowserWindow.h:
717
718 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
719
720         Implement ResizeObserver.
721         https://bugs.webkit.org/show_bug.cgi?id=157743
722
723         Reviewed by Simon Fraser.
724
725         Support resizeObserverEnabled webPreferences.
726
727         * DumpRenderTree/TestOptions.cpp:
728         (TestOptions::TestOptions):
729         * DumpRenderTree/TestOptions.h:
730         * DumpRenderTree/mac/DumpRenderTree.mm:
731         (setWebPreferencesForTestOptions):
732         * DumpRenderTree/win/DumpRenderTree.cpp:
733         (enableExperimentalFeatures):
734         * Scripts/webkitperl/FeatureList.pm:
735         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
736
737 2019-03-28  John Wilander  <wilander@apple.com>
738
739         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
740         https://bugs.webkit.org/show_bug.cgi?id=196281
741         <rdar://problem/48938748>
742
743         Reviewed by Alex Christensen.
744
745         This patch adds the function isStatisticsHasLocalStorage() to the
746         TestRunner. With it, the page can query the WebsiteDataStore in the
747         UI process to make sure that it sees LocalStorage.
748
749         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
750         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
751         (WTR::TestRunner::isStatisticsHasLocalStorage):
752         * WebKitTestRunner/InjectedBundle/TestRunner.h:
753         * WebKitTestRunner/TestController.cpp:
754         (WTR::TestController::isStatisticsHasLocalStorage):
755         * WebKitTestRunner/TestController.h:
756         * WebKitTestRunner/TestInvocation.cpp:
757         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
758
759 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
760
761         API::Data::createWithoutCopying should do a null check before calling CFRelease
762         https://bugs.webkit.org/show_bug.cgi?id=196276
763         <rdar://problem/48059859>
764
765         Reviewed by Alex Christensen.
766
767         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
768
769         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
770         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
771         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
772         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
773         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
774         (TestWebKitAPI::TEST):
775
776 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
777
778         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
779         https://bugs.webkit.org/show_bug.cgi?id=186276
780
781         Reviewed by Carlos Garcia Campos.
782
783         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
784         (webViewLoadChanged):
785         (testWebResourceGetDataError):
786         (testWebResourceGetDataEmpty):
787         (beforeAll):
788         (webViewloadChanged): Deleted.
789
790 2019-03-27  Andy Estes  <aestes@apple.com>
791
792         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
793         https://bugs.webkit.org/show_bug.cgi?id=196317
794
795         Reviewed by Dan Bernstein.
796
797         package-root copies built products into a staging directory using ditto(1), which does not
798         follow symbolic links as it traverses a directory. Now that the files in
799         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
800         itself, these become broken links when ditto'd into the staging directory.
801
802         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
803
804         * Scripts/package-root:
805
806 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
807
808         [ews-app] Update display text of Submit for ews analysis
809         https://bugs.webkit.org/show_bug.cgi?id=196309
810
811         Reviewed by Dewei Zhu.
812
813         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
814
815 2019-03-27  David Kilzer  <ddkilzer@apple.com>
816
817         run-webkit-tests should check for leaks in WebKit processes
818         <https://webkit.org/b/193772>
819         <rdar://problem/46526680>
820
821         Reviewed by Ryosuke Niwa.
822
823         This works by doing the following:
824         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
825           The list of child processes are returned one per line:
826           process.name: pid
827         - Run the "#LIST CHILD PROCESSES" command just before the
828           "#CHECK FOR WORLD LEAKS" command, and store the list of child
829           processes on the ServerProcess object.
830         - When the `--leaks` switch is handled, run check_for_leaks() on
831           each child process after the main test harness.
832
833         * DumpRenderTree/mac/DumpRenderTree.mm:
834         (handleControlCommand):
835         - Use strncmp() instead of strcmp().
836         - Add support for handling "#LIST CHILD PROCESSES" command.
837
838         * Scripts/webkitpy/port/base.py:
839         (Port.check_for_leaks):
840         * Scripts/webkitpy/port/darwin.py:
841         (DarwinPort.check_for_leaks):
842         - Rename redundant 'process_pid' argument to 'process_id'.
843
844         * Scripts/webkitpy/port/driver.py:
845         (Driver.do_post_tests_work):
846         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
847           longer the only command this sends to WebKitTestRunner.
848         - If the `--leaks` switch is present, send the
849           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
850           result using Port.set_webkit_processes().
851         (Driver._parse_child_processes_output):
852         - Add helper method to parse list of child process names and
853           process IDs returned from WebKitTestRunner.
854
855         * Scripts/webkitpy/port/ios_device.py:
856         (IOSDevicePort.check_for_leaks):
857         - Rename redundant 'process_pid' argument to 'process_id'.
858
859         * Scripts/webkitpy/port/leakdetector.py:
860         (LeakDetector._parse_leaks_output):
861         - Return early if there is no leaks_output.
862         (LeakDetector.check_for_leaks):
863         - Rename redundant 'process_pid' argument to 'process_id'.
864
865         * Scripts/webkitpy/port/server_process.py:
866         (ServerProcess.__init__):
867         (ServerProcess.child_processes):
868         (ServerProcess.set_child_processes):
869         - Add instance variable to Port to store list of child process
870           names and process IDs returned from WebKitTestRunner.
871         (ServerProcess._start):
872         - Clear self._child_processes.
873         (ServerProcess.stop):
874         - If self._child_processes is set, call
875           self._port.check_for_leaks() for each child process.
876
877         * Scripts/webkitpy/port/server_process_unittest.py:
878         (TrivialMockPort.check_for_leaks):
879         - Rename redundant 'process_pid' argument to 'process_id'.
880
881         * Scripts/webkitpy/port/simulator_process.py:
882         (SimulatorProcess.stop):
883         - If self._child_processes is set, call
884           self._port.check_for_leaks() for each child process.
885
886         * Scripts/webkitpy/port/watch_device.py:
887         (WatchDevicePort.check_for_leaks):
888         - Rename redundant 'process_pid' argument to 'process_id'.
889
890         * WebKitTestRunner/TestController.cpp:
891         (WTR::TestController::dumpResponse):
892         - Extract method from findAndDumpWorldLeaks() so that it may be
893           reused by findAndDumpWebKitProcessIdentifiers().
894         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
895         - Add method to output process name and process ID of both the
896           WebContent and Networking processes.
897         (WTR::TestController::findAndDumpWorldLeaks):
898         - Fix missing newline in output when there were no abandoned
899           documents.
900         - Call dumpResponse() for extracted code.
901         (WTR::TestController::handleControlCommand):
902         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
903         - Use strncmp() instead of strcmp().
904         - Call findAndDumpWebKitProcessIdentifiers() when
905           "#LIST CHILD PROCESSES" command is sent.
906         * WebKitTestRunner/TestController.h:
907         (WTR::TestController::dumpResponse):
908         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
909         - Declare methods.
910
911 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
912
913         Unreviewed. Add GLib API test cases after r243434.
914
915         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
916         (testWebViewActiveURI):
917         (serverCallback):
918         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
919         (sendRequestCallback):
920
921 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
922
923         Geolocation request not complete when watch request was started in a different web process
924         https://bugs.webkit.org/show_bug.cgi?id=195996
925
926         Reviewed by Alex Christensen.
927
928         Add a test case.
929
930         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
931         (TestWebKitAPI::runJavaScriptAlert):
932         (TestWebKitAPI::TEST):
933
934 2019-03-26  Keith Rollin  <krollin@apple.com>
935
936         Update the way generate-xcfilelists returns strings from functions
937         https://bugs.webkit.org/show_bug.cgi?id=195975
938         <rdar://problem/49040807>
939
940         Reviewed by Dean Jackson.
941
942         There are places where generate-xcfilelists executes assignments with
943         statements like:
944
945             FOO=$(some_function)
946
947         where "some_function" return a string by echoing it. E.g.
948
949             some_function()
950             {
951                 echo "Hello, World"
952             }
953
954         This is a common idiom, but it has a problem if "some_function" needs
955         to call "exit" in an attempt to halt the entire script right then and
956         there. Since "some_function" is called inside of $(), it's being
957         executed in a sub-shell. Calling exit in that sub-shell simply exits
958         that shell; it doesn't not exit the outer shell in which the main part
959         of the script is still running. As such, the main script keeps
960         executing when the intent was for the script to halt.
961
962         The solution to this is to use a different idiom for returning
963         strings. The one we now is to pass in the name of the variable to
964         receive the string result:
965
966             some_function()
967             {
968                 variable_name=$1
969                 eval $variable_name ="Hello, World"
970             }
971
972         The call site now looks like
973
974             some_function FOO
975
976         Because there's no invocation of a sub-shell, some_function can now
977         call "exit" if it wants to, and the entire script will exit at that
978         point.
979
980         * Scripts/generate-xcfilelists:
981
982 2019-03-26  Chris Dumez  <cdumez@apple.com>
983
984         Add basic layout test coverage for File Picker on iOS
985         https://bugs.webkit.org/show_bug.cgi?id=196265
986
987         Reviewed by Wenson Hsieh.
988
989         Add layout test infrastructure to test the file picker on iOS.
990
991         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
992         (WTR::UIScriptController::dismissFilePicker):
993         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
994         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
995         (WTR::UIScriptController::dismissFilePicker):
996         * TestRunnerShared/UIScriptContext/UIScriptController.h:
997         * WebKitTestRunner/TestController.cpp:
998         (WTR::TestController::createWebViewWithOptions):
999         (WTR::updateTestOptionsFromTestHeader):
1000         * WebKitTestRunner/TestOptions.h:
1001         (WTR::TestOptions::hasSameInitializationOptions const):
1002         * WebKitTestRunner/ios/TestControllerIOS.mm:
1003         (overridePresentViewController):
1004         (WTR::TestController::platformInitialize):
1005         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1006         (WTR::UIScriptController::dismissFilePicker):
1007
1008 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1009
1010         Implement async paste method on UIWKInteractionViewProtocol
1011         https://bugs.webkit.org/show_bug.cgi?id=196267
1012         <rdar://problem/49236346>
1013
1014         Reviewed by Tim Horton.
1015
1016         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1017         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1018         are now a part of all iOS 12 internal SDKs.
1019
1020         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1021
1022         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1023         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1024
1025         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1026         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1027         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1028         * TestWebKitAPI/ios/UIKitSPI.h:
1029
1030 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1031
1032         [ews-build] Use PostgreSQL for ews.webkit.org database
1033         https://bugs.webkit.org/show_bug.cgi?id=196270
1034
1035         Reviewed by Lucas Forschler.
1036
1037         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1038
1039 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1040
1041         [ews] Reset simctl states on reboot
1042         https://bugs.webkit.org/show_bug.cgi?id=196260
1043
1044         Rubber-stamped by Aakash Jain.
1045
1046         * EWSTools/start-queue-mac.sh:
1047
1048 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1049
1050         [ews-build] Use PostgreSQL for ews-build database
1051         https://bugs.webkit.org/show_bug.cgi?id=196229
1052
1053         Reviewed by Lucas Forschler.
1054
1055         * BuildSlaveSupport/ews-build/master.cfg:
1056
1057 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1058
1059         [ews-build] Get master_hostname dynamically in master.cfg
1060         https://bugs.webkit.org/show_bug.cgi?id=196255
1061
1062         Reviewed by Lucas Forschler.
1063
1064         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1065         send events data in test mode.
1066
1067 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1068
1069         [ews-app] Set db_constraint to False for Foreign Keys
1070         https://bugs.webkit.org/show_bug.cgi?id=196252
1071
1072         Reviewed by Lucas Forschler.
1073
1074         * BuildSlaveSupport/ews-app/ews/models/build.py:
1075         * BuildSlaveSupport/ews-app/ews/models/step.py:
1076
1077 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1078
1079         [ews-build] is_test_mode_enabled should default to True
1080         https://bugs.webkit.org/show_bug.cgi?id=196248
1081
1082         Reviewed by Lucas Forschler.
1083
1084         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1085
1086 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1087
1088         [ews-app] Add webkitperl to ENABLED_QUEUES
1089         https://bugs.webkit.org/show_bug.cgi?id=196253
1090
1091         Reviewed by Lucas Forschler.
1092
1093         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1094
1095 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1096
1097         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1098         https://bugs.webkit.org/show_bug.cgi?id=196211
1099         rdar://problem/49110552
1100
1101         Reviewed by Tim Horton.
1102
1103         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1104         Make sure that EventSenderProxy always exists when running tests. We used to create
1105         it when resetting before the first test, which is a bit too late.
1106
1107         * WebKitTestRunner/TestController.h:
1108         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1109         (WTR::TestController::platformCreateWebView):
1110         (WTR::TestController::platformCreateOtherPage):
1111         (WTR::TestController::finishCreatingPlatformWebView):
1112         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1113         (WTR::PlatformWebView::PlatformWebView):
1114         Moved some code that made NSWindow use NSEvent during web view creation. We may
1115         need to move more if some other case us found, but this is enough for now.
1116
1117 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1118
1119         Unreviewed. Fix typo in GLib geolocation API after r243285.
1120
1121         gelocation -> geolocation.
1122
1123         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1124         (testGeolocationManagerWatchPosition):
1125
1126 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1127
1128         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1129         https://bugs.webkit.org/show_bug.cgi?id=196213
1130
1131         Reviewed by Geoff Garen.
1132
1133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1134         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1135         (credentialWithIdentityAndKeychainPath):
1136         (-[ChallengeDelegate webView:didFinishNavigation:]):
1137         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1138         (TestWebKitAPI::TEST):
1139
1140 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1141
1142         Expected shouldn't assume its contained types are copyable
1143         https://bugs.webkit.org/show_bug.cgi?id=195986
1144
1145         Reviewed by JF Bastien.
1146
1147         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1148         (TestWebKitAPI::NonCopyable::operator== const):
1149         (TestWebKitAPI::NonCopyable::operator!= const):
1150         (TestWebKitAPI::TEST):
1151
1152 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1153
1154         Remove some now-unnecessary dynamic class lookup
1155         https://bugs.webkit.org/show_bug.cgi?id=196237
1156
1157         Reviewed by Simon Fraser.
1158
1159         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1160         (makeRequest):
1161         (TEST):
1162
1163 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1164
1165         Unreviewed, rolling out r243450.
1166
1167         AppleWin and WinCairo port builds get broken.
1168
1169         Reverted changeset:
1170
1171         "Add test for fix of #196095"
1172         https://bugs.webkit.org/show_bug.cgi?id=196097
1173         https://trac.webkit.org/changeset/243450
1174
1175 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1176
1177         Unreviewed, rolling out r243465.
1178         https://bugs.webkit.org/show_bug.cgi?id=196226
1179
1180         the test doesn't build (Requested by thorton on #webkit).
1181
1182         Reverted changeset:
1183
1184         "Do not terminate the NetworkProcess if a third party
1185         application sends a NSCredential with a SecIdentityRef"
1186         https://bugs.webkit.org/show_bug.cgi?id=196213
1187         https://trac.webkit.org/changeset/243465
1188
1189 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1190
1191         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1192         https://bugs.webkit.org/show_bug.cgi?id=196213
1193
1194         Reviewed by Geoff Garen.
1195
1196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1197         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1198         (credentialWithIdentityAndKeychainPath):
1199         (-[ChallengeDelegate webView:didFinishNavigation:]):
1200         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1201         (TestWebKitAPI::TEST):
1202
1203 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1204
1205         [ews-build] Gracefully handle missing patch_id in events
1206         https://bugs.webkit.org/show_bug.cgi?id=196216
1207
1208         Reviewed by Lucas Forschler.
1209
1210         * BuildSlaveSupport/ews-build/events.py:
1211
1212 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1213
1214         [ews-build] use lz4 compression for improving buildbot performance
1215         https://bugs.webkit.org/show_bug.cgi?id=196155
1216
1217         Reviewed by Lucas Forschler.
1218
1219         * BuildSlaveSupport/ews-build/master.cfg:
1220
1221 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1222
1223         Pull some API testing helper methods out of TestWKWebView
1224         https://bugs.webkit.org/show_bug.cgi?id=196212
1225
1226         Reviewed by Tim Horton.
1227
1228         Refactor some more API testing utility methods, so that they can be used in
1229         tests that do not use TestWKWebView.
1230
1231         * TestWebKitAPI/cocoa/TestWKWebView.h:
1232         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1233         (-[WKWebView loadTestPageNamed:]):
1234         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1235         (-[WKWebView synchronouslyLoadHTMLString:]):
1236         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1237         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1238         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1239         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1240         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1241
1242 2019-03-25  Jer Noble  <jer.noble@apple.com>
1243
1244         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1245         https://bugs.webkit.org/show_bug.cgi?id=196097
1246
1247         Reviewed by Eric Carlson.
1248
1249         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1250
1251         * DumpRenderTree/mac/DumpRenderTree.mm:
1252         (resetWebPreferencesToConsistentValues):
1253         * WebKitTestRunner/TestController.cpp:
1254         (WTR::TestController::resetPreferencesToConsistentValues):
1255
1256 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1257
1258         Pull IPadUserInterfaceSwizzler out into a separate header file
1259         https://bugs.webkit.org/show_bug.cgi?id=196193
1260
1261         Reviewed by Anders Carlsson.
1262
1263         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1264         be used in other API tests.
1265
1266         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1267         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1268         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1269         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1270         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1271         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1272         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1273
1274 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1275
1276         Remove NavigatorContentUtils in WebCore/Modules
1277         https://bugs.webkit.org/show_bug.cgi?id=196070
1278
1279         Reviewed by Alex Christensen.
1280
1281         NavigatorContentUtils was to support the custom scheme spec [1].
1282         However, in WebKit side, no port has supported the feature in
1283         WebKit layer after EFL port was removed. So there has been the
1284         only IDL implementation of the NavigatorContentUtils in WebCore.
1285         So we don't need to keep the implementation in WebCore anymore.
1286
1287         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1288
1289         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1290
1291 2019-03-24  Andy Estes  <aestes@apple.com>
1292
1293         [watchOS] Remove unused Proximity Networking code
1294         https://bugs.webkit.org/show_bug.cgi?id=196188
1295
1296         Reviewed by Tim Horton.
1297
1298         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1299         (TEST):
1300
1301 2019-03-23  Keith Miller  <keith_miller@apple.com>
1302
1303         Refactor clz/ctz and fix getLSBSet.
1304         https://bugs.webkit.org/show_bug.cgi?id=196162
1305
1306         Reviewed by Saam Barati.
1307
1308         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1309
1310         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1311         (TestWebKitAPI::TEST):
1312
1313 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1314
1315         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1316         https://bugs.webkit.org/show_bug.cgi?id=196143
1317
1318         Reviewed by Michael Catanzaro.
1319
1320         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1321         directories.
1322
1323         * Scripts/webkitpy/style/checkers/cpp.py:
1324         (check_identifier_name_in_declaration):
1325         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1326         (WebKitStyleTest.test_names):
1327
1328 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1329
1330         [Flatpak] Manifest expanding fails for qt WPE extension
1331         https://bugs.webkit.org/show_bug.cgi?id=196148
1332
1333         Reviewed by Alex Christensen.
1334
1335         * flatpak/flatpakutils.py:
1336         (expand_submodules_recurse): The last recurse manifest expand
1337         iteration might lead to a single module so take it into account
1338         and don't try to recurse further.
1339
1340 2019-03-22  Chris Dumez  <cdumez@apple.com>
1341
1342         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1343         https://bugs.webkit.org/show_bug.cgi?id=195348
1344         <rdar://problem/48622090>
1345
1346         Reviewed by Alex Christensen.
1347
1348         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1349         to NO when test.options().shouldIgnoreMetaViewport is false.
1350
1351         * WebKitTestRunner/ios/TestControllerIOS.mm:
1352         (WTR::TestController::platformConfigureViewForTest):
1353
1354 2019-03-22  Chris Dumez  <cdumez@apple.com>
1355
1356         Prewarmed processes should be usable with any website data store
1357         https://bugs.webkit.org/show_bug.cgi?id=196104
1358
1359         Reviewed by Alex Christensen.
1360
1361         Add API test coverage.
1362
1363         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1364         (runInitialWarmedProcessUsedTest):
1365         (TEST):
1366
1367 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1368
1369         Back out local changes to Alex's Subversion working directory
1370
1371         They were accidentally committed.
1372
1373         * Scripts/webkitpy/common/system/abstractexecutive.py:
1374         (AbstractExecutive.wait_newest):
1375         * Scripts/webkitpy/common/system/executive.py:
1376         (Executive.running_pids):
1377         * Scripts/webkitpy/common/system/executive_mock.py:
1378         (MockExecutive.running_pids):
1379         * Scripts/webkitpy/common/system/executive_unittest.py:
1380         (ExecutiveTest.serial_test_running_pids):
1381         * Scripts/webkitpy/port/darwin.py:
1382         (DarwinPort.check_for_leaks):
1383         * Scripts/webkitpy/port/leakdetector.py:
1384         (LeakDetector.check_for_leaks):
1385         - This was the hack attached to Bug 193772.
1386
1387         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1388         (+[WebKitTestRunnerEvent mouseLocation]):
1389         - This works around a crash on an internal build.
1390
1391 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1392
1393         Fix the build after r243354
1394         https://bugs.webkit.org/show_bug.cgi?id=196138
1395         <rdar://problem/49145951>
1396
1397         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1398         (TEST):
1399         * TestWebKitAPI/ios/UIKitSPI.h:
1400
1401 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1402
1403         Adopt UIWKDocumentContext
1404         https://bugs.webkit.org/show_bug.cgi?id=196040
1405         <rdar://problem/48642440>
1406
1407         Reviewed by Ryosuke Niwa.
1408
1409         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1410         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1411         (makeRequest):
1412         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1413         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1414         (applyStyle):
1415         (TEST):
1416         Add tests for UIWKDocumentContext.
1417
1418         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1419         (TEST):
1420         (recursiveFindWKContentView): Deleted.
1421         * TestWebKitAPI/cocoa/TestWKWebView.h:
1422         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1423         (recursiveFindWKContentView):
1424         (-[TestWKWebView wkContentView]):
1425         * TestWebKitAPI/ios/UIKitSPI.h:
1426         Share the WKContentView finding code between tests.
1427
1428 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1429
1430         [iOS WK2] Turn on async overflow scrolling by default
1431         https://bugs.webkit.org/show_bug.cgi?id=196011
1432         rdar://problem/48453859
1433
1434         Reviewed by Antti Koivisto.
1435         
1436         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1437         since so many basic layout tests have different results when compositing is triggered for
1438         overflow.
1439         
1440         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1441
1442         * WebKitTestRunner/TestController.cpp:
1443         (WTR::TestController::resetPreferencesToConsistentValues):
1444
1445 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1446
1447         [ews-build] Retry API test in case of failures
1448         https://bugs.webkit.org/show_bug.cgi?id=196004
1449
1450         Reviewed by Lucas Forschler.
1451
1452         * BuildSlaveSupport/ews-build/steps.py:
1453         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1454         (CompileWebKitToT.doStepIf): Ditto.
1455         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1456         (ReRunAPITests): Re-run API tests.
1457         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1458         (RunAPITestsWithoutPatch): Run API tests without patch.
1459         (RunAPITestsWithoutPatch.doStepIf):
1460         (RunAPITestsWithoutPatch.hideStepIf):
1461         (RunAPITestsWithoutPatch.evaluateCommand):
1462         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1463         (AnalyzeAPITestsResults.start):
1464         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1465         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1466         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1467         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1468
1469 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1470
1471         [ews-build] Update queues configurations
1472         https://bugs.webkit.org/show_bug.cgi?id=196074
1473
1474         Reviewed by Dewei Zhu.
1475
1476         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1477         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1478
1479 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1480
1481         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1482         https://bugs.webkit.org/show_bug.cgi?id=195680
1483         <rdar://problem/48903534>
1484
1485         Unreviewed infrastructure fix.
1486
1487         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1488         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1489
1490 2019-03-21  Andy Estes  <aestes@apple.com>
1491
1492         [iOS] Apple Pay should be available in documents with no user agent scripts
1493         https://bugs.webkit.org/show_bug.cgi?id=196061
1494         <rdar://problem/48649391>
1495
1496         Reviewed by Brady Eidson.
1497
1498         Added API tests and related infrastructure.
1499
1500         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1501         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1502         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1503         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1504         (TestWebKitAPI::TEST):
1505         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1506         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1507         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1508         * TestWebKitAPI/cocoa/TestProtocol.mm:
1509         (-[TestProtocol startLoading]):
1510         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1511         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1512         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1513         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1514
1515 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1516
1517         REGRESSSION (r243297): webkitpy tests broken
1518         https://bugs.webkit.org/show_bug.cgi?id=196108
1519
1520         Reviewed by Aakash Jain.
1521
1522         r243297 updated contributors.json, which broke a few unit tests.
1523
1524         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1525         (IRCCommandTest.test_whois):
1526         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1527
1528 2019-03-21  Chris Dumez  <cdumez@apple.com>
1529
1530         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1531         https://bugs.webkit.org/show_bug.cgi?id=196041
1532         <rdar://problem/49083230>
1533
1534         Reviewed by Alex Christensen.
1535
1536         Add API test coverage.
1537
1538         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1539         (TEST):
1540
1541 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1542
1543         Add SPI to inform applications of WKContentRuleList actions
1544         https://bugs.webkit.org/show_bug.cgi?id=195965
1545         <rdar://problem/42664365>
1546
1547         Reviewed by Geoff Garen.
1548
1549         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1550         (TestWebKitAPI::allActionsForResourceLoad):
1551         (TestWebKitAPI::testRequest):
1552         (TestWebKitAPI::TEST_F):
1553         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1554         (Notification::description):
1555         (Notification::operator== const):
1556         (toVector):
1557         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1558         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1559         (makeContentRuleList):
1560         (TEST):
1561         (makeWarnContentRuleList): Deleted.
1562
1563 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1564
1565         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1566         https://bugs.webkit.org/show_bug.cgi?id=196088
1567
1568         Reviewed by Brian Burg.
1569
1570         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1571         Support checks when only one platform is specified. Also deprecate macosx() and
1572         force the use of macos() instead.
1573
1574         * Scripts/webkitpy/style/checkers/cpp.py:
1575         (check_min_versions_of_wk_api_available):
1576         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1577         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1578
1579 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1580
1581         Update status inactive committers' status to 'contributor'.
1582
1583         * Scripts/webkitpy/common/config/contributors.json:
1584
1585 2019-03-21  Xan Lopez  <xan@igalia.com>
1586
1587         [JSC][x86] Drop support for x87 floating point
1588         https://bugs.webkit.org/show_bug.cgi?id=194853
1589
1590         Reviewed by Don Olmstead.
1591
1592         Force SSE2 on x86/32bit builds.
1593
1594         * Scripts/webkitdirs.pm:
1595         (generateBuildSystemFromCMakeProject):
1596
1597 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1598
1599         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1600         https://bugs.webkit.org/show_bug.cgi?id=196073
1601
1602         Reviewed by Michael Catanzaro.
1603
1604         Add test cases to check functions and constructors with no arguments but receiving user data.
1605
1606         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1607         (checkUserData):
1608         (testJSCFunction):
1609         (fooCreateWithUserData):
1610         (testJSCClass):
1611
1612 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1613
1614         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1615
1616         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1617
1618         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1619
1620 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1621
1622         [GTK][WPE] Add API to provide geolocation information
1623         https://bugs.webkit.org/show_bug.cgi?id=195940
1624
1625         Reviewed by Michael Catanzaro.
1626
1627         Add a new test to check the new API.
1628
1629         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1630         (testGeolocationManagerCurrentPosition):
1631         (testGeolocationManagerWatchPosition):
1632         (beforeAll):
1633         (afterAll):
1634         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1635         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1636         (beforeAll): Ditto.
1637         * TestWebKitAPI/glib/CMakeLists.txt:
1638
1639 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1640
1641         [GLib] Returning G_TYPE_OBJECT from a method does not work
1642         https://bugs.webkit.org/show_bug.cgi?id=195574
1643
1644         Reviewed by Michael Catanzaro.
1645
1646         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1647
1648         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1649         (getGFile):
1650         (getParent):
1651         (createGString):
1652         (getGString):
1653         (getGStringCopyWillRaise):
1654         (getGStringCopy):
1655         (getGStringStr):
1656         (getGStringLen):
1657         (freeGString):
1658         (testJSCClass):
1659
1660 2019-03-20  Saam Barati  <sbarati@apple.com>
1661
1662         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1663         https://bugs.webkit.org/show_bug.cgi?id=195721
1664
1665         Reviewed by Filip Pizlo.
1666
1667         * Scripts/run-javascriptcore-tests:
1668
1669 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1670
1671         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1672         https://bugs.webkit.org/show_bug.cgi?id=196049
1673
1674         Reviewed by Tim Horton.
1675
1676         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1677         overflow scrolling in general, so rename it.
1678
1679         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1680
1681 2019-03-20  Daniel Bates  <dabates@apple.com>
1682
1683         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1684         https://bugs.webkit.org/show_bug.cgi?id=196031
1685         <rdar://problem/49078172>
1686
1687         Reviewed by Tim Horton.
1688
1689         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1690         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1691         same code path used when the Done button is pressed to dismiss the <select> picker.
1692
1693         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1694         (TestWebKitAPI::TEST):
1695
1696 2019-03-20  Chris Dumez  <cdumez@apple.com>
1697
1698         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1699         https://bugs.webkit.org/show_bug.cgi?id=196029
1700         <rdar://problem/48954651>
1701
1702         Reviewed by Tim Horton.
1703
1704         Add API test coverage.
1705
1706         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1707
1708 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1709
1710         [ews-build] Improve failure summary string for ApplyPatch step
1711         https://bugs.webkit.org/show_bug.cgi?id=195995
1712
1713         Reviewed by Alexey Proskuryakov.
1714
1715         * BuildSlaveSupport/ews-build/steps.py:
1716         (ApplyPatch.getResultSummary): Override getResultSummary.
1717
1718 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1719
1720         AX: Implement support for new meter ARIA role
1721         https://bugs.webkit.org/show_bug.cgi?id=195966
1722
1723         Reviewed by Chris Fleizach.
1724
1725         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1726         to AXLevelIndicator.
1727
1728         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1729
1730 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1731
1732         [WebAuthN] Implement FIDO AppID extension
1733         https://bugs.webkit.org/show_bug.cgi?id=143491
1734         <rdar://problem/48298273>
1735
1736         Reviewed by Brent Fulgham.
1737
1738         Add a test that covers the new flag of convertToU2fSignCommand.
1739
1740         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1741         (TestWebKitAPI::TEST):
1742         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1743         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1744         (TestWebKitAPI::TEST):
1745
1746 2019-03-19  Keith Rollin  <krollin@apple.com>
1747
1748         Add support for more platforms to generate-xcfilelists
1749         https://bugs.webkit.org/show_bug.cgi?id=195977
1750
1751         Reviewed by Alexey Proskuryakov.
1752
1753         generate-xcfilelists incorrectly complains when involved with building
1754         WebKit for iphonesimulator:
1755
1756             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1757             …
1758             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1759
1760         Address this by teaching generate-xcfilelists about more platforms.
1761
1762         * Scripts/generate-xcfilelists:
1763
1764 2019-03-19  John Wilander  <wilander@apple.com>
1765
1766         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1767         https://bugs.webkit.org/show_bug.cgi?id=195923
1768         <rdar://problem/49001272>
1769
1770         Reviewed by Alex Christensen.
1771
1772         This patch does the following to the TestRunner:
1773         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1774         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1775         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1776
1777         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1778         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1779         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1780         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1781         * WebKitTestRunner/TestController.cpp:
1782         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1783         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1784         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1785         * WebKitTestRunner/TestController.h:
1786         * WebKitTestRunner/TestInvocation.cpp:
1787         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1788
1789 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1790
1791         [CMake] Support more clang and gcc sanitizers
1792         https://bugs.webkit.org/show_bug.cgi?id=195956
1793
1794         Reviewed by Michael Catanzaro.
1795
1796         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1797
1798 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1799
1800         [ews-build] Improve summary for PrintConfiguration step
1801         https://bugs.webkit.org/show_bug.cgi?id=195945
1802
1803         Reviewed by Lucas Forschler.
1804
1805         * BuildSlaveSupport/ews-build/steps.py:
1806         (PrintConfiguration.getResultSummary): Override getResultSummary.
1807
1808 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1809
1810         [ews-build] Improve summary for CheckOutSource step
1811         https://bugs.webkit.org/show_bug.cgi?id=195963
1812
1813         Reviewed by Lucas Forschler.
1814
1815         * BuildSlaveSupport/ews-build/steps.py:
1816         (CheckOutSource.getResultSummary):
1817
1818 2019-03-19  Daniel Bates  <dabates@apple.com>
1819
1820         [iOS] Focus not preserved when switching between tabs
1821         https://bugs.webkit.org/show_bug.cgi?id=195820
1822         <rdar://problem/43614450>
1823
1824         Reviewed by Brent Fulgham.
1825
1826         Add tests to ensure that we restore focus when resigning and becoming first responder.
1827
1828         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1829         (TestWebKitAPI::TEST):
1830
1831 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1832
1833         Make WTFLogChannelState and WTFLogLevel enum classes
1834         https://bugs.webkit.org/show_bug.cgi?id=195904
1835
1836         Reviewed by Eric Carlson.
1837
1838         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1839         (TestWebKitAPI::TEST_F):
1840
1841 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1842
1843         [GStreamer][EME] Backported mssdemux protection data crash fix
1844         https://bugs.webkit.org/show_bug.cgi?id=195918
1845
1846         Reviewed by Philippe Normand.
1847
1848         * gstreamer/jhbuild.modules:
1849         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1850
1851 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1852
1853         Unreviewed, rolling out r243132.
1854
1855         Broke GTK build
1856
1857         Reverted changeset:
1858
1859         "Make WTFLogChannelState and WTFLogLevel enum classes"
1860         https://bugs.webkit.org/show_bug.cgi?id=195904
1861         https://trac.webkit.org/changeset/243132
1862
1863 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1864
1865         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1866
1867         * Scripts/webkitdirs.pm:
1868         (builtDylibPathForName): Adjust the shared library name that's changed
1869         with the API version bump in r243073.
1870
1871 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1872
1873         Make WTFLogChannelState and WTFLogLevel enum classes
1874         https://bugs.webkit.org/show_bug.cgi?id=195904
1875
1876         Reviewed by Eric Carlson.
1877
1878         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1879         (TestWebKitAPI::TEST_F):
1880
1881 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1882
1883         Disable flaky test added in r2431100
1884         https://webkit.org/b/195785
1885
1886         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1887         (TestWebKitAPI::TEST):
1888         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1889
1890 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1891
1892         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1893         https://bugs.webkit.org/show_bug.cgi?id=195916
1894
1895         Reviewed by Tim Horton.
1896
1897         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1898         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1899
1900 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1901
1902         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1903
1904         * Scripts/webkitpy/common/config/contributors.json:
1905
1906 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1907
1908         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1909         https://bugs.webkit.org/show_bug.cgi?id=195785
1910
1911         Reviewed by Geoffrey Garen.
1912
1913         * TestWebKitAPI/TCPServer.cpp: Added.
1914         (TestWebKitAPI::TCPServer::TCPServer):
1915         (TestWebKitAPI::TCPServer::~TCPServer):
1916         (TestWebKitAPI::TCPServer::socketBindListen):
1917         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1918         * TestWebKitAPI/TCPServer.h: Added.
1919         (TestWebKitAPI::TCPServer::port const):
1920         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1921         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1922         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1923         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1924         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1925         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1926         (TestWebKitAPI::respondSlowly):
1927         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1928         (TestWebKitAPI::downloadAtRate):
1929         (TestWebKitAPI::TEST):
1930
1931 2019-03-18  Saam Barati  <sbarati@apple.com>
1932
1933         Add a plan file for JetStream 2
1934         https://bugs.webkit.org/show_bug.cgi?id=190734
1935
1936         Reviewed by Mark Lam.
1937
1938         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1939
1940 2019-03-18  Chris Dumez  <cdumez@apple.com>
1941
1942         Delay WebProcess launch until a load is triggered in a Web view
1943         https://bugs.webkit.org/show_bug.cgi?id=195758
1944         <rdar://problem/48126013>
1945
1946         Reviewed by Geoff Garen.
1947
1948         Add API test coverage. Also update some existing API tests to not expect
1949         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1950
1951         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1952         (TestWebKitAPI::TEST):
1953         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1954         (TestWebKitAPI::TEST):
1955         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1956         (TEST):
1957         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1958         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1959         (TEST):
1960         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1961         (TEST):
1962         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1963
1964 2019-03-18  Xan Lopez  <xan@igalia.com>
1965
1966         [CMake] Prevent potential warning when determining $architecture
1967         https://bugs.webkit.org/show_bug.cgi?id=195891
1968
1969         Reviewed by Michael Catanzaro.
1970
1971         It's possible for generateBuildSystemForCMakeProject to be called
1972         before determineArchitecture() is ever called. This will make the
1973         first eq check with $architecture to be bogus (and print a
1974         warning). Change that to an eq check with architecture(), which
1975         implicitly calls determineArchitecture() if needed, and change all
1976         the other similar cases in the method in the same way to prevent
1977         future bugs like this one.
1978
1979         * Scripts/webkitdirs.pm:
1980         (generateBuildSystemFromCMakeProject):
1981
1982 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1983
1984         [WPE] Tarballs generated with “make dist” cannot build documentation
1985         https://bugs.webkit.org/show_bug.cgi?id=195885
1986
1987         Reviewed by Carlos Garcia Campos.
1988
1989         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1990
1991 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1992
1993         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1994         https://bugs.webkit.org/show_bug.cgi?id=195883
1995
1996         Reviewed by Carlos Garcia Campos.
1997
1998         * gtkdoc/gtkdoc.py:
1999         (GTKDoc._run_command): When commands fail to run, include the full command line for
2000         the program invocation and the output it has generated on the standard error stream.
2001
2002 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2003
2004         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2005         https://bugs.webkit.org/show_bug.cgi?id=195786
2006
2007         Reviewed by Philippe Normand.
2008
2009         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2010         * wpe/jhbuild.modules: Ditto.
2011
2012 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2013
2014         [ews-build] Don't run clean builds on EWS builders
2015         https://bugs.webkit.org/show_bug.cgi?id=195851
2016
2017         Reviewed by Geoffrey Garen.
2018
2019         * BuildSlaveSupport/ews-build/factories.py:
2020
2021 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2022
2023         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2024         https://bugs.webkit.org/show_bug.cgi?id=195849
2025
2026         Reviewed by Chris Dumez.
2027
2028         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2029
2030         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2031         (runWebsiteDataStoreCustomPaths):
2032
2033 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2034
2035         webkitpy: Upload test results
2036         https://bugs.webkit.org/show_bug.cgi?id=195755
2037         <rdar://problem/48896182>
2038
2039         Reviewed by Aakash Jain.
2040
2041         Establish a new format for uploading results that is not tied to layout tests, apply
2042         that format to webkitpy tests.
2043
2044         * Scripts/webkitpy/common/checkout/scm/git.py:
2045         (Git.native_branch): Return what branch the current checkout is on.
2046         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2047         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2048         * Scripts/webkitpy/common/checkout/scm/svn.py:
2049         (SVN.native_branch): Ditto.
2050         * Scripts/webkitpy/common/system/platforminfo.py:
2051         (PlatformInfo.build_version): Return a build version for Mac.
2052         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2053         (MockPlatformInfo.__init__):
2054         (MockPlatformInfo.build_version):
2055         * Scripts/webkitpy/results: Added.
2056         * Scripts/webkitpy/results/__init__.py: Added.
2057         * Scripts/webkitpy/results/options.py: Added.
2058         (upload_options): OptParse list for upload options.
2059         * Scripts/webkitpy/results/upload.py: Added.
2060         (Upload): Class which enforces the upload format expected by the results server.
2061         (Upload.Expectations):
2062         (Upload.create_configuration):
2063         (Upload.create_commit):
2064         (Upload.create_details):
2065         (Upload.create_run_stats):
2066         (Upload.create_test_result):
2067         (Upload.__init__):
2068         (Upload.Encoder): Encode Upload object as json.
2069         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2070         * Scripts/webkitpy/results/upload_unittest.py: Added.
2071         * Scripts/webkitpy/test/main.py:
2072         (Tester._parse_args): Add upload arguments.
2073         (Tester._run_tests): Allow results to be uploaded.
2074         * Scripts/webkitpy/test/runner.py:
2075         (Runner.__init__): Record which tests were run, rather than just counting them.
2076         (Runner.handle):
2077         * Scripts/webkitpy/test/runner_unittest.py:
2078         (RunnerTest.test_run):
2079         * Scripts/webkitpy/thirdparty/__init__.py:
2080         (AutoinstallImportHook.find_module): Add requests auto-install.
2081         (AutoinstallImportHook._install_requests):
2082         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2083         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2084
2085 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2086
2087         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2088         https://bugs.webkit.org/show_bug.cgi?id=195810
2089
2090         Reviewed by Tim Horton.
2091
2092         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2093         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2094         ending certain layout tests.
2095
2096         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2097         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2098         (-[TestRunnerWKWebView dealloc]):
2099         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2100
2101         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2102         helper method when destroying the web view, and when resetting state between tests.
2103
2104         * WebKitTestRunner/ios/TestControllerIOS.mm:
2105         (WTR::TestController::platformResetStateToConsistentValues):
2106
2107         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2108
2109 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2110
2111         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2112         https://bugs.webkit.org/show_bug.cgi?id=190350
2113         <rdar://problem/45089503>
2114
2115         Reviewed by Geoffrey Garen.
2116
2117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2118         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2119         (TEST):
2120         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2121         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2122         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2123         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2124         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2125         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2126         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2127         (runTest):
2128         (createDirectories):
2129         (TEST):
2130         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2131         (TEST):
2132         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2133         (TEST):
2134
2135 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2136
2137         Add support to WebPage for getting the contents as an attributed string.
2138         https://bugs.webkit.org/show_bug.cgi?id=195636
2139         rdar://problem/45055697
2140
2141         Reviewed by Tim Horton.
2142
2143         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2144         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2145
2146 2019-03-15  Chris Dumez  <cdumez@apple.com>
2147
2148         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2149         https://bugs.webkit.org/show_bug.cgi?id=195747
2150
2151         Reviewed by Geoff Garen.
2152
2153         Add API test coverage.
2154
2155         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2156
2157 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2158
2159         Unreviewed, rolling out r242952.
2160
2161         Causing API failures on iOS Simulator
2162
2163         Reverted changeset:
2164
2165         "[PSON] Make sure the WebProcessCache is leverage when
2166         relaunching a process after termination"
2167         https://bugs.webkit.org/show_bug.cgi?id=195747
2168         https://trac.webkit.org/changeset/242952
2169
2170 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2171
2172         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2173         https://bugs.webkit.org/show_bug.cgi?id=195740
2174
2175         Reviewed by Ross Kirsling.
2176
2177         window.open doesn't work for WebKitBrowserWindow because it is not
2178         implemented yet.
2179
2180         1. Implemented createNewPage callback of WKPageUIClient.
2181         2. Changed MainWindow to take a BrowserWindow factory function
2182           instead of BrowserWindowType to be flexible to create
2183           BrowserWindow with extra settings.
2184         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2185           because it is not relevant with MainWindow anymore.
2186
2187         * MiniBrowser/win/Common.cpp:
2188         (parseCommandLine):
2189         * MiniBrowser/win/Common.h:
2190         (CommandLineOptions::CommandLineOptions):
2191         * MiniBrowser/win/MainWindow.cpp:
2192         (MainWindow::MainWindow):
2193         (MainWindow::create):
2194         (MainWindow::init):
2195         (MainWindow::WndProc):
2196         * MiniBrowser/win/MainWindow.h:
2197         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2198         (PrintWebUIDelegate::createWebViewWithRequest):
2199         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2200         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2201         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2202         (WebKitBrowserWindow::updateProxySettings):
2203         (WebKitBrowserWindow::createNewPage):
2204         * MiniBrowser/win/WebKitBrowserWindow.h:
2205         * MiniBrowser/win/WinMain.cpp:
2206         (wWinMain):
2207
2208 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2209
2210         Make it possible to test scrolling tree layer manipulation more easily
2211         https://bugs.webkit.org/show_bug.cgi?id=195780
2212
2213         Reviewed by Tim Horton.
2214         
2215         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2216         cuts off communication of scrolling tree scrolls back to the web process
2217         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2218         allows tests to trigger scrolls which run the scrolling tree layer positioning
2219         logic, but never get another commit from the web process that might mask
2220         scrolling tree bugs.
2221         
2222         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2223         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2224         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2225
2226         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2227         (WTR::UIScriptController::scrollUpdatesDisabled const):
2228         (WTR::UIScriptController::setScrollUpdatesDisabled):
2229         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2230         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2231         (WTR::UIScriptController::scrollUpdatesDisabled const):
2232         (WTR::UIScriptController::setScrollUpdatesDisabled):
2233         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2234         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2235         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2236         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2237         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2238         * WebKitTestRunner/ios/TestControllerIOS.mm:
2239         (WTR::TestController::platformResetStateToConsistentValues):
2240         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2241         (WTR::UIScriptController::scrollUpdatesDisabled const):
2242         (WTR::UIScriptController::setScrollUpdatesDisabled):
2243
2244 2019-03-14  Youenn Fablet  <youenn@apple.com>
2245
2246         Move IDB storage in private browsing mode to NetworkProcess
2247         https://bugs.webkit.org/show_bug.cgi?id=195602
2248
2249         Reviewed by Brady Eidson.
2250
2251         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2252         (TEST):
2253
2254 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2255
2256         [ews-build] Make descriptionDone messages more readable
2257         https://bugs.webkit.org/show_bug.cgi?id=195760
2258
2259         Reviewed by Lucas Forschler.
2260
2261         * BuildSlaveSupport/ews-build/steps.py:
2262         * BuildSlaveSupport/ews-build/steps_unittest.py:
2263
2264 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2265
2266         [ews-build] Generate status-bubble hover-over messages
2267         https://bugs.webkit.org/show_bug.cgi?id=195680
2268
2269         Reviewed by Lucas Forschler.
2270
2271         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2272         (StatusBubble):
2273         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2274         on hover-over.
2275         (StatusBubble._iso_time):
2276         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2277         hover-over message.
2278         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2279
2280 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2281
2282         [ews-app] Gracefully handle the case when state_string is None
2283         https://bugs.webkit.org/show_bug.cgi?id=195753
2284
2285         Reviewed by Lucas Forschler.
2286
2287         * BuildSlaveSupport/ews-app/ews/models/build.py:
2288         * BuildSlaveSupport/ews-app/ews/models/step.py:
2289
2290 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2291
2292         [ews-app] Status bubble display pending for currently running build step
2293         https://bugs.webkit.org/show_bug.cgi?id=195744
2294
2295         Reviewed by Lucas Forschler.
2296
2297         * BuildSlaveSupport/ews-build/events.py:
2298         (Events.stepStarted): If state_string is pending, replace it with step name.
2299
2300 2019-03-14  Chris Dumez  <cdumez@apple.com>
2301
2302         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2303         https://bugs.webkit.org/show_bug.cgi?id=195750
2304
2305         Reviewed by Geoffrey Garen.
2306
2307         Add API test coverage.
2308
2309         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2310         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2311         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2312         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2313
2314 2019-03-14  Chris Dumez  <cdumez@apple.com>
2315
2316         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2317         https://bugs.webkit.org/show_bug.cgi?id=195747
2318
2319         Reviewed by Geoff Garen.
2320
2321         Add API test coverage.
2322
2323         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2324
2325 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2326
2327         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2328         https://bugs.webkit.org/show_bug.cgi?id=195725
2329         <rdar://problem/48545062>
2330
2331         Reviewed by Tim Horton.
2332
2333         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2334         handler is nil.
2335
2336         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2337         (TestWebKitAPI::TEST):
2338
2339 2019-03-13  Sam Weinig  <sam@webkit.org>
2340
2341         Add utility function to allow easy reverse range-based iteration of a container
2342         https://bugs.webkit.org/show_bug.cgi?id=195542
2343
2344         Reviewed by Antti Koivisto.
2345
2346         * TestWebKitAPI/CMakeLists.txt:
2347         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2348         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2349         (TestWebKitAPI::TEST):
2350         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2351
2352 2019-03-13  Chris Dumez  <cdumez@apple.com>
2353
2354         Use a ServiceWorker process per registrable domain
2355         https://bugs.webkit.org/show_bug.cgi?id=195649
2356
2357         Reviewed by Youenn Fablet.
2358
2359         Update API test coverage.
2360
2361         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2362
2363 2019-03-13  Chris Dumez  <cdumez@apple.com>
2364
2365         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2366         https://bugs.webkit.org/show_bug.cgi?id=195684
2367         <rdar://problem/48294714>
2368
2369         Reviewed by Antti Koivisto.
2370
2371         Add API test coverage.
2372
2373         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2374
2375 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2376
2377         [ews-app] Remove unused patch view
2378         https://bugs.webkit.org/show_bug.cgi?id=195669
2379
2380         Reviewed by Lucas Forschler.
2381
2382         * BuildSlaveSupport/ews-app/ews/urls.py:
2383         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2384
2385 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2386
2387         [ews-app] Use Buildbot result code variables
2388         https://bugs.webkit.org/show_bug.cgi?id=195668
2389
2390         Reviewed by Alexey Proskuryakov.
2391
2392         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2393         (Buildbot): Added Buildbot result code variables.
2394         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2395         (StatusBubble._build_bubble): Used Buildbot result code variables.
2396
2397 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2398
2399         [Flatpak] Expand submodule recursively
2400         https://bugs.webkit.org/show_bug.cgi?id=195672
2401
2402         Building WPE with flatpak was impossible without that as it was raising an exception.
2403         Also update wpebackend-fdo to match what is built in jhbuild
2404
2405         Reviewed by Philippe Normand.
2406
2407         * flatpak/flatpakutils.py:
2408         (expand_submodules_recurse):
2409         (expand_manifest):
2410         * flatpak/org.webkit.WPEModules.yaml:
2411
2412 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2413
2414         [ews-app] status bubble should be hidden for certain builds
2415         https://bugs.webkit.org/show_bug.cgi?id=194597
2416
2417         Reviewed by Dewei Zhu.
2418
2419         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2420         (StatusBubble._build_bubble):
2421         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2422         because the patch didn't have relevant changes.
2423         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2424         in production yet.
2425
2426 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2427
2428         [Win] Fix a slew of simple clang-cl warnings.
2429         https://bugs.webkit.org/show_bug.cgi?id=195652
2430
2431         Reviewed by Don Olmstead.
2432
2433         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2434         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2435
2436 2019-03-12  Justin Fan  <justin_fan@apple.com>
2437
2438         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2439         https://bugs.webkit.org/show_bug.cgi?id=195518
2440         <rdar://problem/46322356>
2441
2442         Reviewed by Myles C. Maxfield.
2443
2444         * DumpRenderTree/DerivedSources-input.xcfilelist:
2445         * DumpRenderTree/DerivedSources-output.xcfilelist:
2446
2447 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2448
2449         Unreviewed, rolling out r242825.
2450         https://bugs.webkit.org/show_bug.cgi?id=195648
2451
2452         "Broke webkitpy tests with my change to
2453         lldb_dump_class_layout.py" (Requested by rmorisset on
2454         #webkit).
2455
2456         Reverted changeset:
2457
2458         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2459         classes with suspicious padding"
2460         https://bugs.webkit.org/show_bug.cgi?id=195573
2461         https://trac.webkit.org/changeset/242825
2462
2463 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2464
2465         [ews-build] Show status bubbles while the patch is waiting in queue
2466         https://bugs.webkit.org/show_bug.cgi?id=195618
2467
2468         Reviewed by Lucas Forschler.
2469
2470         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2471         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2472         enabled in initial deployment.
2473         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2474         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2475         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2476         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2477         (StatusBubble._build_bubbles_for_patch):
2478
2479 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2480
2481         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2482         https://bugs.webkit.org/show_bug.cgi?id=195573
2483
2484         Reviewed by Simon Fraser.
2485
2486         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2487
2488         * Scripts/dump-class-layout:
2489         (main):
2490         * lldb/lldb_dump_class_layout.py:
2491         (ClassLayout.__init__):
2492         (ClassLayout._compute_padding_recursive):
2493         (LLDBDebuggerInstance.dump_layout_for_classname):
2494         (LLDBDebuggerInstance):
2495         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2496         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2497
2498 2019-03-12  Chris Dumez  <cdumez@apple.com>
2499
2500         Device Orientation access permission should be denied unless explicitly granted by the client
2501         https://bugs.webkit.org/show_bug.cgi?id=195625
2502
2503         Reviewed by Youenn Fablet.
2504
2505         add API test coverage.
2506
2507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2508         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2509         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2510         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2511         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2512         (runDeviceOrientationTest):
2513         (TEST):
2514         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2515         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2516
2517 2019-03-12  Jer Noble  <jer.noble@apple.com>
2518
2519         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2520         https://bugs.webkit.org/show_bug.cgi?id=195137
2521         <rdar://problem/48810307>
2522
2523         Reviewed by Eric Carlson.
2524
2525         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2526         (TestWebKitAPI::TEST):
2527
2528 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2529
2530         [ews-build] Change urls from uat to production
2531         https://bugs.webkit.org/show_bug.cgi?id=195566
2532
2533         Reviewed by Lucas Forschler.
2534
2535         * BuildSlaveSupport/ews-app/ews/config.py:
2536         * BuildSlaveSupport/ews-build/events.py:
2537         * BuildSlaveSupport/ews-build/steps.py:
2538
2539 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2540
2541         [ews-build] change max_builds for local-worker to 1
2542         https://bugs.webkit.org/show_bug.cgi?id=195568
2543
2544         Reviewed by Lucas Forschler.
2545
2546         * BuildSlaveSupport/ews-build/loadConfig.py:
2547
2548 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2549
2550         Fix the build
2551
2552         * TestRunnerShared/spi/PencilKitTestSPI.h:
2553         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2554
2555 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2556
2557         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2558         https://bugs.webkit.org/show_bug.cgi?id=194131
2559
2560         Reviewed by Michael Catanzaro.
2561
2562         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2563         (uriChanged):
2564         (testUnfinishedSubresourceLoad):
2565         (serverCallback):
2566         (beforeAll):
2567
2568 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2569
2570         WTF::Expected should use std::addressof instead of operator&
2571         https://bugs.webkit.org/show_bug.cgi?id=195604
2572
2573         Reviewed by Myles Maxfield.
2574
2575         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2576         (TestWebKitAPI::Unique::Unique):
2577         (TestWebKitAPI::Unique::operator&):
2578         (TestWebKitAPI::TEST):
2579
2580 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2581
2582         Add Optional to Forward.h.
2583         https://bugs.webkit.org/show_bug.cgi?id=195586
2584
2585         Reviewed by Darin Adler.
2586
2587         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2588         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2589         Remove unnecessary includes from headers.
2590
2591 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2592
2593         Add testing API to hit-test and scroll overflow scrollers
2594         https://bugs.webkit.org/show_bug.cgi?id=195278
2595
2596         Reviewed by Antti Koivisto.
2597         
2598         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2599         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2600         
2601         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2602
2603         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2604         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2605         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2606         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2607         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2608         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2609         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2610         (WTR::enclosingScrollViewIncludingSelf):
2611         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2612
2613 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2614
2615         API test WebKit.RequestTextInputContext fails on iOS
2616         https://bugs.webkit.org/show_bug.cgi?id=195585
2617
2618         Reviewed by Wenson Hsieh and Simon Fraser.
2619
2620         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2621         (applyStyle):
2622         (TEST):
2623         Add a viewport, so that the coordinates match up on iOS.
2624         Scroll by moving the UIScrollView's contentOffset.
2625
2626 2019-03-11  Chris Dumez  <cdumez@apple.com>
2627
2628         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2629         https://bugs.webkit.org/show_bug.cgi?id=195506
2630         <rdar://problem/48733477>
2631
2632         Reviewed by Alex Christensen.
2633
2634         Add API test coverage.
2635
2636         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2637
2638 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2639
2640         Adding myself to contributors.json
2641
2642         Unreviewed, addming myself to contributors.json .
2643
2644         * Scripts/webkitpy/common/config/contributors.json:
2645
2646 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2647
2648         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2649         https://bugs.webkit.org/show_bug.cgi?id=195511
2650         <rdar://problem/44873269>
2651
2652         Reviewed by Darin Adler.
2653
2654         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2655         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2656         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2657         (TEST_F):
2658
2659 2019-03-11  Chris Dumez  <cdumez@apple.com>
2660
2661         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2662         https://bugs.webkit.org/show_bug.cgi?id=195561
2663
2664         Reviewed by Youenn Fablet.
2665
2666         Make sure the JS in the test requests for permission to receive device orientation events.
2667
2668         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2669
2670 2019-03-11  Youenn Fablet  <youenn@apple.com>
2671
2672         Allow storage quota increase by default in WTR
2673         https://bugs.webkit.org/show_bug.cgi?id=195541
2674
2675         Reviewed by Geoffrey Garen.
2676
2677         Allow storage quota increase by default in WTR.
2678         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2679         Use this for tests that explicitly need cache increase.
2680
2681         Instead of increasing quota by 2, make sure the next request is
2682         granted by adding all given parameters.
2683
2684         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2685         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2686         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2687         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2688         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2689         * WebKitTestRunner/TestController.cpp:
2690         (WTR::TestController::setAllowStorageQuotaIncrease):
2691         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2692         * WebKitTestRunner/TestController.h:
2693         * WebKitTestRunner/TestInvocation.cpp:
2694         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2695         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2696         (WTR::TestController::cocoaResetStateToConsistentValues):
2697         (WTR::TestController::setAllowStorageQuotaIncrease):
2698         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2699         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2700         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2701
2702 2019-03-11  Xan Lopez  <xan@igalia.com>
2703
2704         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2705         https://bugs.webkit.org/show_bug.cgi?id=194147
2706
2707         Reviewed by Michael Saboff.
2708
2709         To make --32-bit work correctly on Linux/64bit we need to:
2710
2711         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2712         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2713         unfortunately CMake only allows us to do this during
2714         crosscompilation, which is overkill here.
2715         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2716         pkg-config detection module uses the x86 .pc files instead of the
2717         x86_64 ones.
2718         - Set the -m32 flags for the compiler.
2719
2720         * Scripts/webkitdirs.pm:
2721         (generateBuildSystemFromCMakeProject):
2722
2723 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2724
2725         Add MotionMark-1.1 plan file for run-benchmark script.
2726         https://bugs.webkit.org/show_bug.cgi?id=195481
2727
2728         Rubber-stamped by Darin Adler.
2729
2730         Run-benchmark script should support MontionMark-1.1.
2731
2732         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2733
2734 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2735
2736         [ews-app] Add support for submit-to-ews url
2737         https://bugs.webkit.org/show_bug.cgi?id=195477
2738
2739         Reviewed by Lucas Forschler.
2740
2741         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2742         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2743         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2744         * BuildSlaveSupport/ews-app/ews/urls.py:
2745         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2746
2747 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2748
2749         Unreviewed, rolling out r242688, r242643, r242624.
2750
2751         Caused multiple layout test failures and crashes on iOS and macOS.
2752
2753         Reverted changeset:
2754
2755         "requestAnimationFrame should execute before the next frame"
2756         https://bugs.webkit.org/show_bug.cgi?id=177484
2757         https://trac.webkit.org/changeset/242624/webkit
2758
2759         * Tracing/SystemTracePoints.plist:
2760
2761 2019-03-11  John Wilander  <wilander@apple.com>
2762
2763         Resource Load Statistics: Make it possible exclude localhost from classification
2764         https://bugs.webkit.org/show_bug.cgi?id=195474
2765         <rdar://problem/47520577>
2766
2767         Reviewed by Brent Fulgham.
2768
2769         This patch allows for localhost to be excluded from classification and
2770         treatment as a prevalent resource.
2771
2772         The WebKit Tools change adds a new function called
2773         testRunner.setStatisticsIsRunningTest() which can be used to control this
2774         behavior.
2775
2776         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2777         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2778         (WTR::TestRunner::setStatisticsIsRunningTest):
2779         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2780         * WebKitTestRunner/TestController.cpp:
2781         (WTR::TestController::setStatisticsIsRunningTest):
2782         * WebKitTestRunner/TestController.h:
2783         * WebKitTestRunner/TestInvocation.cpp:
2784         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2785
2786 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2787
2788         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2789         https://bugs.webkit.org/show_bug.cgi?id=195560
2790
2791         Reviewed by Lucas Forschler.
2792
2793         * BuildSlaveSupport/ews-build/master.cfg:
2794
2795 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2796
2797         Unreviewed, rolling out r242698.
2798
2799         API test crashes on bots.
2800
2801         Reverted changeset:
2802
2803         "Add a WKContentRuleList variant that uses copied memory
2804         instead of mmap'd shared memory for class A containerized
2805         apps"
2806         https://bugs.webkit.org/show_bug.cgi?id=195511
2807         https://trac.webkit.org/changeset/242698
2808
2809 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2810
2811         [WPE] Enable web process sandbox
2812         https://bugs.webkit.org/show_bug.cgi?id=195169
2813
2814         Reviewed by Daniel Bates.
2815
2816         * wpe/install-dependencies:
2817         * wpe/jhbuild.modules:
2818
2819 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2820
2821         [ews-app] Use port 17000 for worker communication
2822         https://bugs.webkit.org/show_bug.cgi?id=195558
2823
2824         Reviewed by Lucas Forschler.
2825
2826         * BuildSlaveSupport/ews-build/master.cfg:
2827
2828 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2829
2830         [ews-build] unit-tests fail when passwords.json is missing
2831         https://bugs.webkit.org/show_bug.cgi?id=195557
2832
2833         Reviewed by Lucas Forschler.
2834
2835         * BuildSlaveSupport/ews-build/loadConfig.py:
2836         (loadBuilderConfig):
2837         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2838         (ConfigDotJSONTest.test_configuration):
2839         * BuildSlaveSupport/ews-build/master.cfg:
2840
2841 2019-03-11  Truitt Savell  <tsavell@apple.com>
2842
2843         Unreviewed, rolling out r242702.
2844
2845         Broke High Sierra builders.
2846
2847         Reverted changeset:
2848
2849         "Add utility function to allow easy reverse range-based
2850         iteration of a container"
2851         https://bugs.webkit.org/show_bug.cgi?id=195542
2852         https://trac.webkit.org/changeset/242702
2853
2854 2019-03-11  Sam Weinig  <sam@webkit.org>
2855
2856         Add utility function to allow easy reverse range-based iteration of a container
2857         https://bugs.webkit.org/show_bug.cgi?id=195542
2858
2859         Reviewed by Antti Koivisto.
2860
2861         * TestWebKitAPI/CMakeLists.txt:
2862         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2863         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2864         (TestWebKitAPI::TEST):
2865         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2866
2867 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2868
2869         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2870         https://bugs.webkit.org/show_bug.cgi?id=195511
2871         <rdar://problem/44873269>
2872
2873         Reviewed by Darin Adler.
2874
2875         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2876         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2877         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2878         (TEST_F):
2879
2880 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2881
2882         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2883         https://bugs.webkit.org/show_bug.cgi?id=195499
2884
2885         Reviewed by Darin Adler.
2886
2887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2888         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2889         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2890         (-[WKWebView synchronouslyFocusTextInputContext:]):
2891         (applyStyle):
2892         (applyIframe):
2893         (TEST):
2894         Add some tests for this SPI.
2895
2896 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2897
2898         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2899         https://bugs.webkit.org/show_bug.cgi?id=181151
2900
2901         Reviewed by Don Olmstead.
2902
2903         * TestWebKitAPI/CMakeLists.txt:
2904         * TestWebKitAPI/PlatformWin.cmake:
2905         Enable TestWTF RunLoop tests in all platforms.
2906
2907         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2908         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2909         (TestWebKitAPI::DerivedOneShotTimer::fired):
2910         (TestWebKitAPI::TEST):
2911         Only a few platforms support nested RunLoop.
2912
2913         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2914         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2915
2916 2019-03-10  David Quesada  <david_quesada@apple.com>
2917
2918         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2919         https://bugs.webkit.org/show_bug.cgi?id=152480
2920
2921         Reviewed by Chris Dumez.
2922
2923         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2924         there are no additional references to the process pool besides the one held by
2925         the download, waits for the download to finish (in the sense that the
2926         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2927         measure, also check that the process pool has been deallocated at the end of the
2928         test. The test wouldn't be meaningful if the process pool were still alive.
2929
2930         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2931         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2932         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2933             The download will be canceled because the delegate does not implement the
2934             method to decide the download's destination, so this is where we know the
2935             DownloadProxyMap is done with the DownloadProxy.
2936         (TEST):
2937
2938 2019-03-08  Chris Dumez  <cdumez@apple.com>
2939
2940         Add support for Device Orientation / Motion permission API
2941         https://bugs.webkit.org/show_bug.cgi?id=195329
2942         <rdar://problem/47645367>
2943
2944         Reviewed by Geoffrey Garen.
2945
2946         Add test infrastructure to help test the Device Orientation / Motion permission API.
2947
2948         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2949         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2950         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2951         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2952         * WebKitTestRunner/TestController.cpp:
2953         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2954         (WTR::TestController::createWebViewWithOptions):
2955         (WTR::TestController::resetStateToConsistentValues):
2956         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2957         * WebKitTestRunner/TestController.h:
2958         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2959         * WebKitTestRunner/TestInvocation.cpp:
2960         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2961
2962 2019-03-08  Saam barati  <sbarati@apple.com>
2963
2964         Add a compare-results script to compare benchmark results
2965         https://bugs.webkit.org/show_bug.cgi?id=195486
2966         <rdar://problem/48723397>
2967
2968         Reviewed by Geoffrey Garen.
2969
2970         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2971         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2972         to extend it to learn about our other benchmarks.
2973
2974         * Scripts/compare-results: Added.
2975         (readJSONFile):
2976         (detectJetStream2):
2977         (JetStream2Results):
2978         (detectSpeedometer2):
2979         (Speedometer2Results):
2980         (detectPLT5):
2981         (PLT5Results):
2982         (detectBenchmark):
2983         (biggerIsBetter):
2984         (ttest):
2985         (getOptions):
2986         (main):
2987
2988 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2989
2990         Ensure old tab state is cleared between iterations of run-benchmark
2991         https://bugs.webkit.org/show_bug.cgi?id=195393
2992         <rdar://problem/46885583>
2993
2994         Reviewed by Dewei Zhu.
2995
2996         a) ensure the default to restore state is not set
2997         b) terminate Safari correctly
2998         c) Set the system default to ignore Persistent State in Safari
2999
3000         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3001         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3002         (OSXBrowserDriver.prepare_env): 
3003         (OSXBrowserDriver.restore_env):
3004         (OSXBrowserDriver.close_browsers):
3005         (OSXBrowserDriver._terminate_processes):
3006         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3007         (OSXChromeDriver):
3008         (OSXChromeCanaryDriver):
3009         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3010         (OSXFirefoxDriver):
3011         (OSXFirefoxNightlyDriver):
3012         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3013         (OSXSafariDriver):
3014         (OSXSafariDriver.prepare_env):
3015
3016 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3017
3018         [GTK] Several InputMethodFilter tests are failing
3019         https://bugs.webkit.org/show_bug.cgi?id=195408
3020
3021         Reviewed by Carlos Garcia Campos.
3022
3023         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3024         Regressed in r241751.
3025         Hexadecimal values of keycodes are expressed now in upper letters.
3026         Composited characters should be cast to UTF8 strings.
3027
3028         (TestWebKitAPI::TEST):
3029
3030 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3031
3032         [GTK] Make Tools/gtkdoc python3 compatible
3033         https://bugs.webkit.org/show_bug.cgi?id=195359
3034
3035         Reviewed by Carlos Garcia Campos.
3036
3037         * gtkdoc/generate-gtkdoc:
3038         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3039         work with Python 2 and 3.
3040         (get_gtkdoc_module_paths):
3041         The iteritems() was removed in Python 3, so let's use items() that's
3042         available in Python 2 and 3.
3043         (get_generator_for_config):
3044         * gtkdoc/gtkdoc.py:
3045         (GTKDoc._run_command):
3046         The sys.stdout.write() is expecting str in Python 3 and not bytes
3047         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3048         for passing the bytes there.
3049
3050 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3051
3052         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3053         https://bugs.webkit.org/show_bug.cgi?id=195346
3054         <rdar://problem/48667048>
3055
3056         Unreviewed build fix for clang-cl.
3057
3058         * DumpRenderTree/win/DumpRenderTree.cpp:
3059         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3060
3061 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3062
3063         requestAnimationFrame should execute before the next frame
3064         https://bugs.webkit.org/show_bug.cgi?id=177484
3065
3066         Reviewed by Simon Fraser.
3067
3068         Add trace points for the page RenderingUpdate.
3069
3070         * Tracing/SystemTracePoints.plist:
3071
3072 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3073
3074         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3075         https://bugs.webkit.org/show_bug.cgi?id=195353
3076         <rdar://problem/48626394>
3077
3078         Reviewed by Simon Fraser.
3079
3080         * WebKitTestRunner/ios/TestControllerIOS.mm:
3081         (WTR::TestController::platformResetPreferencesToConsistentValues):
3082
3083 2019-03-07  John Wilander  <wilander@apple.com>
3084
3085         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3086         https://bugs.webkit.org/show_bug.cgi?id=195383
3087         <rdar://problem/48570136>
3088
3089         Reviewed by Brent Fulgham.
3090
3091         This patch adds test infrastructure to purge only script-accessible cookies,
3092         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3093
3094         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3095         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3096         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3097         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3098         * WebKitTestRunner/TestController.cpp:
3099         (WTR::TestController::statisticsDeleteCookiesForHost):
3100         * WebKitTestRunner/TestController.h:
3101         * WebKitTestRunner/TestInvocation.cpp:
3102         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3103
3104 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3105
3106         Unreviewed, rolling out r242354.
3107         https://bugs.webkit.org/show_bug.cgi?id=195402
3108
3109         breaks layout tests in all configurations (Requested by
3110         zdobersek on #webkit).
3111
3112         Reverted changeset:
3113
3114         "[WPE] Enable web process sandbox"
3115         https://bugs.webkit.org/show_bug.cgi?id=195169
3116         https://trac.webkit.org/changeset/242354
3117
3118 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3119
3120         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3121         https://bugs.webkit.org/show_bug.cgi?id=195346
3122
3123         Reviewed by Fujii Hironori.
3124
3125         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3126         (TestWebKitAPI::TEST):
3127         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3128
3129         * DumpRenderTree/win/DumpRenderTree.cpp:
3130         (findFontFallback):
3131         (addFontFallbackIfPresent):
3132         (removeFontFallbackIfPresent):
3133         (main):
3134         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3135         (TestWebKitAPI::Util::moduleDirectory):
3136         (TestWebKitAPI::Util::createInjectedBundlePath):
3137         Use wchar helpers as needed.
3138
3139 2019-03-06  Rob Buis  <rbuis@igalia.com>
3140
3141         Consider supporting the `referrerpolicy` attribute.
3142         https://bugs.webkit.org/show_bug.cgi?id=179053
3143
3144         Reviewed by Darin Adler.
3145
3146         Add a runtime flag for referrerpolicy attribute.
3147
3148         * DumpRenderTree/mac/DumpRenderTree.mm:
3149         (enableExperimentalFeatures):
3150
3151 2019-03-05  Daniel Bates  <dabates@apple.com>
3152
3153         Update expected API test result following r242379
3154         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3155
3156         Update expected x-coordinate of selection rect now that the left padding of
3157         a textarea is sized in ems (so dependent on the font size) just like the left
3158         padding of a text field.
3159
3160         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3161         (TestWebKitAPI::TEST):
3162
3163 2019-03-05  David Quesada  <david_quesada@apple.com>
3164
3165         [WK2] It should be possible to follow links with 'download' attributes
3166         https://bugs.webkit.org/show_bug.cgi?id=195145
3167         rdar://problem/48462642
3168
3169         Reviewed by Alex Christensen.
3170
3171         Add a unit test to verify that activating links with 'download' attributes now
3172         navigates to the linked resource, rather than starts downloading it. Add another
3173         to verify that it is still possible to explicitly download the link via the
3174         'Download' navigation action policy.
3175
3176         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3177         (-[DownloadAttributeTestDelegate init]):
3178         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3179         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3180         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3181         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3182         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3183         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3184         (TEST):
3185         * WebKitTestRunner/TestController.cpp:
3186         (WTR::TestController::decidePolicyForNavigationAction):
3187         * WebKitTestRunner/TestController.h:
3188
3189 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3190
3191         [Curl] Implement Cookie Accept Policy.
3192         https://bugs.webkit.org/show_bug.cgi?id=191645
3193
3194         Reviewed by Fujii Hironori.
3195
3196         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3197         (TestWebKitAPI::Curl::TEST_F):
3198
3199 2019-03-05  Youenn Fablet  <youenn@apple.com>
3200
3201         Rename requestCacheStorageSpace to requestStorageSpace
3202         https://bugs.webkit.org/show_bug.cgi?id=195282
3203
3204         Reviewed by Chris Dumez.
3205
3206         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3207         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3208         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3209
3210 2019-03-05  Brady Eidson  <beidson@apple.com>
3211
3212         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3213         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3214
3215         Reviewed by Tim Horton.
3216
3217         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3218         different directory into that same WKWebView should work.
3219
3220         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3221         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3222
3223 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3224
3225         Add WeakHashSet
3226         https://bugs.webkit.org/show_bug.cgi?id=195152
3227
3228         Reviewed by Antti Koivisto.
3229
3230         Added tests for WeakHashSet.
3231
3232         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3233         (TestWebKitAPI::Base::Base): Moved.
3234         (TestWebKitAPI::Derived::foo): Moved.
3235         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3236         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3237         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3238         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3239
3240 2019-03-04  Chris Dumez  <cdumez@apple.com>
3241
3242         Do not share WebProcesses between private and regular sessions
3243         https://bugs.webkit.org/show_bug.cgi?id=195189
3244         <rdar://problem/48421064>
3245
3246         Reviewed by Alex Christensen.
3247
3248         Add API test coverage.
3249
3250         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3251         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3252
3253 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3254
3255         [WPE] Enable web process sandbox
3256         https://bugs.webkit.org/show_bug.cgi?id=195169
3257
3258         Reviewed by Daniel Bates.
3259
3260         * wpe/install-dependencies:
3261         * wpe/jhbuild.modules:
3262
3263 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3264
3265         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3266         https://bugs.webkit.org/show_bug.cgi?id=195206
3267
3268         Reviewed by Žan Doberšek.
3269
3270         Add a new test case.
3271
3272         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3273         (testJSCClass):
3274
3275 2019-03-04  Charlie Turner  <cturner@igalia.com>
3276
3277         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3278         https://bugs.webkit.org/show_bug.cgi?id=194898
3279
3280         Reviewed by Žan Doberšek.
3281
3282         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3283         a GCC extension that permits arithmetic on void* pointer. Inline
3284         the macro until this issue is fixed upstream.
3285
3286 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3287
3288         Rid the world of WK_API_ENABLED
3289         https://bugs.webkit.org/show_bug.cgi?id=195263
3290
3291         Reviewed by Dan Bernstein.
3292
3293         List of changed files elided because it's useless.
3294
3295 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3296
3297         Unreviewed follow-up to r242292.
3298
3299         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3300
3301         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3302         (TestWebKitAPI::testStrip): Renamed from strip.
3303         (TestWebKitAPI::TEST):
3304
3305 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3306
3307         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3308
3309         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3310         and bug #194272 for details.
3311
3312         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3313
3314 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3315
3316         Remove some more unused 32-bit code
3317         https://bugs.webkit.org/show_bug.cgi?id=195255
3318
3319         Reviewed by Darin Adler.
3320
3321         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3322         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3323         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3324         (NPP_New):
3325         (NPP_HandleEvent):
3326         (handleEventCarbon): Deleted.
3327
3328 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3329
3330         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3331
3332         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3333         (TestWebKitAPI::TEST):
3334
3335 2019-03-01  Darin Adler  <darin@apple.com>
3336
3337         Finish removing String::format
3338         https://bugs.webkit.org/show_bug.cgi?id=194893
3339
3340         Reviewed by Daniel Bates.
3341 '
3342         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3343
3344 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3345
3346         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3347         https://bugs.webkit.org/show_bug.cgi?id=195229
3348         <rdar://problem/48520362>
3349
3350         Reviewed by Chris Dumez.
3351
3352         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3353         (TEST):
3354
3355 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3356
3357         Add a system trace scope for event region building
3358         https://bugs.webkit.org/show_bug.cgi?id=195226
3359
3360         Reviewed by Jon Lee.
3361
3362         This trace scope measures the time spend converting element rects into Region objects,
3363         which can be large on some pages.
3364
3365         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3366
3367         * Tracing/SystemTracePoints.plist:
3368
3369 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3370
3371         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3372         https://bugs.webkit.org/show_bug.cgi?id=194612
3373
3374         Reviewed by Alex Christensen.
3375
3376         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3377         Just test the new string-processing function and don't touch the actual environment.
3378         (Test cases are all as before, but based on operator== instead of strcmp.)
3379
3380 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3381
3382         [ews-app] Update primary keys for handling multiple Buildbot instances
3383         https://bugs.webkit.org/show_bug.cgi?id=195120
3384
3385         Reviewed by Stephanie Lewis.
3386
3387         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3388         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3389         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3390
3391         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3392         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3393         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3394         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3395         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3396         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3397
3398 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3399
3400         [WinCairo] Enable service worker
3401         https://bugs.webkit.org/show_bug.cgi?id=188318
3402
3403         Reviewed by Youenn Fablet.
3404
3405         * DumpRenderTree/DumpRenderTreePrefix.h:
3406         * TestWebKitAPI/PlatformWin.cmake:
3407         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3408         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3409         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3410
3411 2019-03-01  Justin Fan  <justin_fan@apple.com>
3412
3413         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3414         https://bugs.webkit.org/show_bug.cgi?id=195191
3415
3416         Rubber-stamped by Dean Jackson.
3417
3418         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3419
3420         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3421
3422 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3423
3424         Unreviewed, fix lldb webkitpy tests
3425         https://bugs.webkit.org/show_bug.cgi?id=194375
3426
3427         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3428
3429         * lldb/lldb_webkit.py:
3430         (WTFStringImplProvider.is_8bit):
3431
3432 2019-02-28  David Quesada  <david_quesada@apple.com>
3433
3434         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3435         https://bugs.webkit.org/show_bug.cgi?id=195121
3436         rdar://problem/48450302
3437
3438         Reviewed by Alex Christensen.
3439
3440         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3441         configurations where the 'download' attribute is absent, blank, or populated
3442         with a filename, and where the anchor element is same-origin or cross-origin
3443         (meaning the 'download' attribute shouldn't be honored).
3444
3445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3446         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3447         (-[NavigationActionTestDelegate init]):
3448         (-[NavigationActionTestDelegate navigationAction]):
3449         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3450         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3451         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3452         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3453         (TEST):
3454
3455 2019-02-28  Antoine Quint  <graouts@apple.com>
3456
3457         Enable the Pointer Events runtime flag by default
3458         https://bugs.webkit.org/show_bug.cgi?id=195156
3459
3460         Reviewed by Dean Jackson.
3461
3462         * DumpRenderTree/mac/DumpRenderTree.mm:
3463         (enableExperimentalFeatures):
3464
3465 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3466
3467         Several PasteImage API tests are flaky
3468         https://bugs.webkit.org/show_bug.cgi?id=195160
3469
3470         Reviewed by Tim Horton.
3471
3472         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3473         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3474         listening for a "load" event after image load is already complete.
3475
3476         To address this, make these tests first register a "load" event handler, then run script to insert an image
3477         element into the document, and finally wait until the load event is observed before checking image size.
3478
3479         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3480
3481 2019-02-28  Chris Dumez  <cdumez@apple.com>
3482
3483         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3484         https://bugs.webkit.org/show_bug.cgi?id=195107
3485
3486         Reviewed by Alex Christensen.
3487
3488         Give some time for the zoom level to get restored.
3489
3490         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3491
3492 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3493
3494         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3495         https://bugs.webkit.org/show_bug.cgi?id=194958
3496
3497         Reviewed by Geoffrey Garen.
3498
3499         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3500         (TEST):
3501
3502 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3503
3504         [ews-app] Update method to save build to handle builder_display_name
3505         https://bugs.webkit.org/show_bug.cgi?id=195047
3506
3507         Reviewed by Dewei Zhu.
3508
3509         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3510         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3511
3512 2019-02-28  Justin Fan  <justin_fan@apple.com>
3513
3514         [Web GPU] Enable Web GPU only on 64-bit
3515         https://bugs.webkit.org/show_bug.cgi?id=195139
3516
3517         Because Metal is only supported on 64 bit apps.
3518
3519         Unreviewed build fix.
3520
3521         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3522
3523 2019-02-27  Youenn Fablet  <youenn@apple.com>
3524
3525         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3526         https://bugs.webkit.org/show_bug.cgi?id=194959
3527
3528         Reviewed by Chris Dumez.
3529
3530         Spin loop until getting the condition to remove flakiness.
3531
3532         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3533
3534 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3535
3536         [ews-build] Buildbot should include builder_display_name in the build events
3537         https://bugs.webkit.org/show_bug.cgi?id=195045
3538
3539         Reviewed by Dewei Zhu.
3540
3541         * BuildSlaveSupport/ews-build/events.py:
3542         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3543         buildername to builder_name to be consistent in naming style.
3544         (Events.buildFinished): Ditto.
3545
3546 2019-02-27  Chris Dumez  <cdumez@apple.com>
3547
3548         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3549         https://bugs.webkit.org/show_bug.cgi?id=194480
3550
3551         Reviewed by Brady Eidson.
3552
3553         Update existing API test to make it more likely to reproduce the issue.
3554
3555         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3556
3557 2019-02-27  Brady Eidson  <beidson@apple.com>
3558
3559         Universal links from Google search results pages don't open the app.
3560         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3561
3562         Reviewed by Geoffrey Garen.
3563
3564         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3565         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3566         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3567         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3568
3569 2019-02-27  Chris Dumez  <cdumez@apple.com>
3570
3571         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3572         https://bugs.webkit.org/show_bug.cgi?id=195102
3573
3574         Reviewed by Geoffrey Garen.
3575
3576         If the number of processes is not yet what we expect, wait a bit and check again to give
3577         processes some time to exit.
3578
3579         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3580
3581 2019-02-27  Chris Dumez  <cdumez@apple.com>
3582
3583         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3584         https://bugs.webkit.org/show_bug.cgi?id=194545
3585
3586         Reviewed by Brady Eidson.
3587
3588         Make sure the test navigates forward and then back only once. Previously, navigating
3589         back would trigger a navigation again in a timer.
3590
3591         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3592
3593 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3594
3595         High Sierra Debug JSC test queue should use faster hardware
3596         https://bugs.webkit.org/show_bug.cgi?id=194603
3597
3598         Rubber-stamped by Alexey Proskuryakov.
3599
3600         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3601
3602         * BuildSlaveSupport/build.webkit.org-config/config.json:
3603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3604         (BubbleQueueServer):
3605         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3606         (WebKitBuildbot):
3607         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3608         * QueueStatusServer/config/queues.py:
3609         * Scripts/webkitpy/common/config/ews.json:
3610         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3611         (test_ews_name):
3612
3613 2019-02-27  John Wilander  <wilander@apple.com>
3614
3615         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3616         https://bugs.webkit.org/show_bug.cgi?id=195071
3617         <rdar://problem/48417690>
3618
3619         Reviewed by Alex Christensen and Brent Fulgham.
3620
3621         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3622         (TestWebKitAPI::createURL):
3623             Convenience function.
3624         (TestWebKitAPI::TEST):
3625             WebCore::AdClickAttribution now takes a URL when creating Source and
3626             Destination.
3627         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3628         (TestWebKitAPI::TEST):
3629             WebCore::AdClickAttribution now takes a URL when creating Source and
3630             Destination.
3631
3632 2019-02-27  Antoine Quint  <graouts@apple.com>
3633
3634         Support Pointer Events on macOS
3635         https://bugs.webkit.org/show_bug.cgi?id=195008
3636         <rdar://problem/47454419>
3637
3638         Reviewed by Dean Jackson.
3639
3640         * DumpRenderTree/mac/DumpRenderTree.mm:
3641         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3642         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3643
3644 2019-02-26  Mark Lam  <mark.lam@apple.com>
3645
3646         Remove remaining poisoning code.
3647         https://bugs.webkit.org/show_bug.cgi?id=194138
3648
3649         Reviewed by Saam Barati.
3650
3651         * TestWebKitAPI/CMakeLists.txt:
3652         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3653         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3654         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3655         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3656         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3657         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3658         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3659
3660 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3661
3662         Move ephemeral local storage from WebProcess to UIProcess
3663         https://bugs.webkit.org/show_bug.cgi?id=195074
3664         <rdar://problem/47937975>
3665
3666         Reviewed by Geoff Garen.
3667
3668         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3669
3670 2019-02-20  Jer Noble  <jer.noble@apple.com>
3671
3672         [Cocoa] Media elements will restart network buffering just before suspending
3673         https://bugs.webkit.org/show_bug.cgi?id=193691
3674
3675         Reviewed by Eric Carlson.
3676
3677         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3678         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3679         (TEST):
3680
3681 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3682
3683         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3684         https://bugs.webkit.org/show_bug.cgi?id=191652
3685
3686         Reviewed by Alex Christensen.
3687
3688         Fix WinCairo MiniBrowser behavior of authentication dialog.
3689
3690         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3691         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3692
3693 2019-02-26  Youenn Fablet  <youenn@apple.com>
3694
3695         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3696         https://bugs.webkit.org/show_bug.cgi?id=195028
3697         <rdar://problem/48243733>
3698
3699         Reviewed by Eric Carlson.
3700
3701         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3702
3703 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3704
3705         [WPE] Add API for webview background color configuration
3706         https://bugs.webkit.org/show_bug.cgi?id=192305
3707
3708         Reviewed by Michael Catanzaro.
3709
3710         * MiniBrowser/wpe/main.cpp:
3711         (main): Add a new option to configure the webview background
3712         color. Example: --bg-color=transparent.
3713         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3714         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3715         (beforeAll): Ditto.
3716
3717 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3718
3719         scalableNativeWebpageParameters() is not preserved on new page navigation.
3720         https://bugs.webkit.org/show_bug.cgi?id=194892
3721         <rdar://problem/47538280>
3722
3723         Reviewed by Wenson Hsieh.
3724         
3725         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3726
3727         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3728         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3729         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3730         (WTR::UIScriptController::allowsViewportShrinkToFit):
3731         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3732         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3733         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3734         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3735         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3736         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3737
3738 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3739
3740         [ews-app] Add model for handling multiple Buildbot instances
3741         https://bugs.webkit.org/show_bug.cgi?id=194863
3742
3743         Reviewed by Stephanie Lewis.
3744
3745         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3746
3747 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3748
3749         [ews-app] Remove BuilderMapping table
3750         https://bugs.webkit.org/show_bug.cgi?id=194961
3751
3752         Reviewed by Stephanie Lewis.
3753
3754         Store builder name directly in build table, instead of having a separate
3755         table for it.
3756
3757         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3758         * BuildSlaveSupport/ews-app/ews/models/build.py:
3759         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3760         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3761
3762 2019-02-25  John Wilander  <wilander@apple.com>
3763
3764         Introduce and adopt new class RegistrableDomain for eTLD+1
3765         https://bugs.webkit.org/show_bug.cgi?id=194791
3766         <rdar://problem/48179240>
3767
3768         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3769
3770         This patch adds an API test and replaces two instances of
3771         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3772
3773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3774         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3775         (TestWebKitAPI::TEST):
3776             Changed two strings to make sure the registrable domains are still considered
3777             invalid and pass the test.
3778         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3779         (TestWebKitAPI::TEST):
3780         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3781         (WTR::InjectedBundle::didReceiveMessageToPage):
3782
3783 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3784
3785         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3786         https://bugs.webkit.org/show_bug.cgi?id=195001
3787
3788         Reviewed by Carlos Garcia Campos.
3789
3790         API version 1.0 always includes the functionality previously guarded with
3791         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3792         unconditionally.
3793
3794         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3795         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3796         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3797         (WebViewTest::showInWindow): Ditto.
3798         (WebViewTest::hideView): Ditto.
3799         * wpe/backends/HeadlessViewBackend.cpp:
3800         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3801         * wpe/backends/ViewBackend.cpp:
3802         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3803         * wpe/backends/WindowViewBackend.cpp:
3804         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3805         WPE_BACKEND_CHECK_VERSION().
3806         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3807
3808 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3809
3810         [Flatpak] Add support for flatpak > 1.1.2
3811         https://bugs.webkit.org/show_bug.cgi?id=194088
3812
3813         Flatpak 1.2 is now out so we need to support that
3814         version now.
3815
3816         Reviewed by Michael Catanzaro.
3817
3818         * flatpak/flatpakutils.py:
3819         (check_flatpak):
3820         (FlatpakPackages.__init__):
3821         (FlatpakPackages.__detect_packages):
3822         (FlatpakPackages.__detect_packages.in):
3823         (FlatpakRepos.update):
3824
3825 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3826
3827         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3828         https://bugs.webkit.org/show_bug.cgi?id=194998
3829
3830         Reviewed by Carlos Garcia Campos.
3831
3832         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3833         to a Git checkout and using the latest commit containing various fixes
3834         and improvements.
3835
3836 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3837
3838         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3839         https://bugs.webkit.org/show_bug.cgi?id=194981
3840
3841         Reviewed by Žan Doberšek.
3842
3843         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3844         (TestWebKitAPI::TEST):
3845
3846 2019-02-23  Keith Miller  <keith_miller@apple.com>
3847
3848         Add new mac target numbers
3849         https://bugs.webkit.org/show_bug.cgi?id=194955
3850
3851         Reviewed by Tim Horton.
3852
3853         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3854         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3855         * MiniBrowser/Configurations/Base.xcconfig:
3856         * TestWebKitAPI/Configurations/Base.xcconfig:
3857         * WebKitTestRunner/Configurations/Base.xcconfig:
3858
3859 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3860
3861         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3862         https://bugs.webkit.org/show_bug.cgi?id=194846
3863
3864         Reviewed by Don Olmstead.
3865
3866         Added _search_paths() and _port_specific_expectations_files() for
3867         WinCairoPort.
3868
3869         * Scripts/webkitpy/port/win.py:
3870         (WinCairoPort.default_baseline_search_path):
3871         (WinCairoPort):
3872         (WinCairoPort._port_specific_expectations_files):
3873         (WinCairoPort._search_paths):
3874
3875 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3876
3877         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3878         https://bugs.webkit.org/show_bug.cgi?id=194963
3879
3880         Reviewed by Dean Jackson.
3881
3882         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3883         Do a `contains` check instead of `equals`, because in debug builds we
3884         put the GraphicsLayer pointer in a prefix.
3885
3886 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3887
3888         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3889         https://bugs.webkit.org/show_bug.cgi?id=194873
3890         <rdar://problem/46701974>
3891
3892         Reviewed by Tim Horton.
3893
3894         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3895
3896         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3897         (WTR::UIScriptController::menuRect const):
3898         (WTR::UIScriptController::isShowingMenu const):
3899         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3900         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3901         (WTR::UIScriptController::menuRect const):
3902
3903         Add a function to query the bounds of the callout menu in content coordinates.
3904
3905         (WTR::UIScriptController::isShowingMenu const):
3906
3907         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3908
3909         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3910         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3911         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3912         (WTR::UIScriptController::rectForMenuAction const):
3913         (WTR::UIScriptController::menuRect const):
3914         (WTR::UIScriptController::isShowingMenu const):
3915         (WTR::findViewInHierarchyOfType): Deleted.
3916
3917 2019-02-22  Chris Dumez  <cdumez@apple.com>
3918
3919         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3920         https://bugs.webkit.org/show_bug.cgi?id=194954
3921         <rdar://problem/48127957>
3922
3923         Reviewed by Alex Christensen.
3924
3925         Add API test coverage.
3926
3927         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3928         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3929         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3930         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3931
3932 2019-02-22  Chris Dumez  <cdumez@apple.com>
3933
3934         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3935         https://bugs.webkit.org/show_bug.cgi?id=194924
3936         <rdar://problem/48216125>
3937
3938         Reviewed by Geoffrey Garen.
3939
3940         Add API test coverage.
3941
3942         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3943
3944 2019-02-22  Chris Dumez  <cdumez@apple.com>
3945
3946         Unreviewed, disable API test added in r241928 on iOS.
3947
3948         The cache is not enabled on devices with less than 3GB of RAM.
3949
3950         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3951
3952 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3953
3954         Hardcode Visual Viewports on everywhere except iOS WK1
3955         https://bugs.webkit.org/show_bug.cgi?id=194928
3956
3957         Reviewed by Zalan Bujtas.
3958
3959         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3960         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3961         set it to false. The setting has shipped for several years and there's no need to turn
3962         it off now.
3963
3964         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3965         Visual Viewports are not enabled.
3966         
3967         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3968         that only runs in WK2
3969
3970         * MiniBrowser/mac/SettingsController.h:
3971         * MiniBrowser/mac/SettingsController.m:
3972         (-[SettingsController init]):
3973         (-[SettingsController _populateMenu]):
3974         (-[SettingsController validateMenuItem:]):
3975         (-[SettingsController visualViewportEnabled]): Deleted.
3976         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3977         * MiniBrowser/mac/WK1BrowserWindowController.m:
3978         (-[WK1BrowserWindowController didChangeSettings]):
3979         * MiniBrowser/mac/WK2BrowserWindowController.m:
3980         (-[WK2BrowserWindowController didChangeSettings]):
3981
3982 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3983
3984         Discard cached processes when clearing website data store
3985         https://bugs.webkit.org/show_bug.cgi?id=194894
3986
3987         Reviewed by Chris Dumez.
3988
3989         Added a test case.
3990
3991         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3992         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3993
3994 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3995
3996         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3997         https://bugs.webkit.org/show_bug.cgi?id=194914
3998         <rdar://problem/47586889>
3999
4000         Reviewed by Geoffrey Garen.
4001
4002         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4003         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4004         (TEST):
4005         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4006
4007 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4008
4009         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4010         <https://webkit.org/b/194761>
4011
4012         Reviewed by Myles Maxfield.
4013
4014         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4015         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4016         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4017         to use ARC-compliant cast.
4018         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4019         ARC-compliant cast.
4020         (WTR::installFakeHelvetica): Log `error` to console if
4021         CTFontManagerRegisterFontsForURL() fails, but only on supported
4022         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4023         Call CFRelease() on `error` to fix the leak.  Update to use
4024         ARC-compliant cast.
4025         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4026         cast.
4027
4028 2019-02-21  Chris Dumez  <cdumez@apple.com>
4029
4030         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4031         https://bugs.webkit.org/show_bug.cgi?id=194481
4032
4033         Reviewed by Alex Christensen.
4034
4035         Give the processes a chance to shutdown and wait until we reached the expected number
4036         of processes.
4037
4038         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4039
4040 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4041
4042         Fix the macOS build
4043
4044         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4045
4046 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4047
4048         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4049
4050         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4051         I am a backwards.
4052
4053 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4054
4055         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4056
4057         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4058         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4059         We could force on UI-side compositing, but I feel like the test might be more
4060         valuable exercising the normal path on each platform (though the original
4061         bug was also UI-side specific). Though we can't validate that the overlay
4062         layer was installed successfully, there are layout tests that do that.
4063
4064 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4065
4066         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4067         https://bugs.webkit.org/show_bug.cgi?id=194845
4068         <rdar://problem/47944579>
4069
4070         Reviewed by Antti Koivisto.
4071
4072         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4073         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4074
4075 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4076
4077         [LFC][Floats] Add support for placing formatting roots in-between floats.
4078         https://bugs.webkit.org/show_bug.cgi?id=194902
4079
4080         Reviewed by Antti Koivisto.
4081
4082         * LayoutReloaded/misc/LFC-passing-tests.txt:
4083
4084 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4085
4086         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4087         https://bugs.webkit.org/show_bug.cgi?id=194901
4088
4089         Unreviewed build fix.
4090
4091         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4092         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4093         WPEBackend-fdo-0.1 as library name.
4094
4095 2019-02-21  Rob Buis  <rbuis@igalia.com>
4096
4097         Update MIME type parser
4098         https://bugs.webkit.org/show_bug.cgi?id=180526
4099
4100         Reviewed by Darin Adler.
4101
4102         Add tests involving leading and trailing whitespace, non-token
4103         characters and quoted strings.
4104
4105         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4106         (TestWebKitAPI::TEST):
4107
4108 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4109
4110         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4111         https://bugs.webkit.org/show_bug.cgi?id=194884
4112
4113         Reviewed by Michael Catanzaro.
4114
4115         * PlatformWin.cmake:
4116
4117 2019-02-20  Chris Dumez  <cdumez@apple.com>
4118
4119         Add API test for <rdar://problem/47471222>
4120         https://bugs.webkit.org/show_bug.cgi?id=194847
4121
4122         Reviewed by Alex Christensen.
4123
4124         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4125
4126 2019-02-20  Chris Dumez  <cdumez@apple.com>
4127
4128         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4129         https://bugs.webkit.org/show_bug.cgi?id=194872
4130         <rdar://problem/47924500>
4131
4132         Reviewed by Alex Christensen.
4133
4134         Add API test coverage.
4135
4136         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4137
4138 2019-02-20  Jer Noble  <jer.noble@apple.com>
4139
4140         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4141         https://bugs.webkit.org/show_bug.cgi?id=191332
4142
4143         Reviewed by Dean Jackson.
4144
4145         * Scripts/git-is-in-range: Added.
4146
4147 2019-02-20  Andy Estes  <aestes@apple.com>
4148
4149         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4150         https://bugs.webkit.org/show_bug.cgi?id=194869
4151
4152         Rubber-stamped by Jer Noble.
4153
4154         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4155         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4156         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4157         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4159         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4160
4161 2019-02-20  Chris Dumez  <cdumez@apple.com>
4162
4163         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4164         https://bugs.webkit.org/show_bug.cgi?id=194857
4165         <rdar://problem/47759323>
4166
4167         Reviewed by Alex Christensen.
4168
4169         Add API test coverage.
4170
4171         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4172
4173 2019-02-20  Chris Dumez  <cdumez@apple.com>
4174
4175         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4176         https://bugs.webkit.org/show_bug.cgi?id=194829
4177         <rdar://problem/47889906>
4178
4179         Reviewed by Alexey Proskuryakov.
4180
4181         Every time the TestOptions were changing we were creating both a new Web view and
4182         a new WKContext, which would start a new Network process. In most cases, we only
4183         need to contruct a new Web view and we do can keep reusing the same WKContext.
4184         This patch implements this optimization and thus avoids spinning a lot of new
4185         Network processes while running the layout tests.
4186
4187         * WebKitTestRunner/TestController.cpp:
4188         (WTR::TestController::generateContextConfiguration const):
4189         (WTR::TestController::generatePageConfiguration):
4190         (WTR::TestController::createWebViewWithOptions):
4191         (WTR::TestController::resetPreferencesToConsistentValues):
4192         (WTR::updateTestOptionsFromTestHeader):
4193         * WebKitTestRunner/TestController.h:
4194         * WebKitTestRunner/TestOptions.h:
4195         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4196         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4197         (WTR::TestOptions::hasSameInitializationOptions const):
4198         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4199         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4200         (WTR::TestController::platformAddTestOptions const):
4201
4202 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4203
4204         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4205         https://bugs.webkit.org/show_bug.cgi?id=167941
4206
4207         Reviewed by Carlos Garcia Campos.
4208
4209         * MiniBrowser/gtk/main.c:
4210         (filterSavedCallback): Added.
4211         (main): Support loading a JSON rule set file for content filtering.
4212         * MiniBrowser/wpe/main.cpp:
4213         (filterSavedCallback): Added.
4214         (main): Support loading a JSON rule set file for content filtering.
4215         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4216         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4217         (WTF::derefGPtr): Ditto.
4218         (testEmptyStore):
4219         (testSaveInvalidFilter):
4220         (testSaveLoadFilter):
4221         (testSavedFilterIdentifierMatch):
4222         (testRemoveFilter):
4223         (testSaveMultipleFilters):
4224         (testSaveFilterFromFile):
4225         (testFilterPersistence):
4226         (beforeAll):
4227         (afterAll):
4228         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4229         (removeOldInjectedContentAndResetLists): Also reset content filters.
4230         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4231         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4232         the element affected by the style sheet.
4233         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4234         and returns it to be used by tests.
4235         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4236         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4237         (serverCallback): Add support for serving a CSS style sheet for testing.
4238         (beforeAll): Add call to testUserContentManagerContentFilter().
4239         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4240
4241 2019-02-19  Keith Rollin  <krollin@apple.com>
4242
4243         Add timing information to build output
4244         https://bugs.webkit.org/show_bug.cgi?id=194839
4245         <rdar://problem/48219609>
4246
4247         Reviewed by Alexey Proskuryakov.
4248
4249         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4250         emit each project's build time to its output. E.g.,
4251
4252             ** BUILD SUCCEEDED ** [0.132 sec]
4253
4254         * Scripts/webkitdirs.pm:
4255         (XcodeOptions):
4256
4257 2019-02-19  Truitt Savell  <tsavell@apple.com>
4258
4259         Unreviewed, rolling out r241784.
4260
4261         Broke all OpenSource builds.
4262
4263         Reverted changeset:
4264
4265         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4266         instances view"
4267         https://bugs.webkit.org/show_bug.cgi?id=172848
4268         https://trac.webkit.org/changeset/241784
4269
4270 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4271
4272         [LFC][Floats] Remove redundant intersecting logic
4273         https://bugs.webkit.org/show_bug.cgi?id=194804
4274
4275         Reviewed by Antti Koivisto.
4276
4277         * LayoutReloaded/misc/LFC-passing-tests.txt:
4278
4279 2019-02-19  Dean Jackson  <dino@apple.com>
4280
4281         Clean-up output from generate-xcfilelists so it can be filtered
4282         https://bugs.webkit.org/show_bug.cgi?id=194795
4283
4284         Reviewed by Joseph Pecoraro (and Keith Rollin).
4285
4286         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4287         make a slight tweak to filter-build-webkit so such lines are marked
4288         as plain.
4289
4290         * Scripts/filter-build-webkit:
4291         * Scripts/generate-xcfilelists:
4292
4293 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4294
4295         pytest is not correctly auto-installed
4296         https://bugs.webkit.org/show_bug.cgi?id=194707
4297
4298         Reviewed by Carlos Garcia Campos.
4299
4300         * Scripts/webkitpy/thirdparty/__init__.py:
4301         (AutoinstallImportHook._install_pytest):
4302
4303 2019-02-18  Chris Dumez  <cdumez@apple.com>
4304
4305         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4306         https://bugs.webkit.org/show_bug.cgi?id=194797
4307         <rdar://problem/48055151>
4308
4309         Reviewed by Geoffrey Garen.
4310
4311         Add API test coverage.
4312
4313         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4314
4315 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4316
4317         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4318         https://bugs.webkit.org/show_bug.cgi?id=194670
4319         <rdar://problem/39066529>
4320
4321         Reviewed by Tim Horton.
4322
4323         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4324         pasted in an editable area as attachment elements.
4325
4326         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4327         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4328         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4329         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4330         (TestWebKitAPI::TEST):
4331         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4332         (WTR::InjectedBundlePage::InjectedBundlePage):
4333
4334 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4335
4336         Fix API test after r241728
4337        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4338
4339         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4340         (TEST):
4341         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4342
4343 2019-02-18  Daniel Bates  <dabates@apple.com>
4344
4345         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4346         https://bugs.webkit.org/show_bug.cgi?id=192824
4347         <rdar://problem/47100332>
4348
4349         Reviewed by Wenson Hsieh.
4350
4351         Fix a bug where the wrong usage code was used for F13 thru F24.
4352
4353         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4354         (keyCodeForDOMFunctionKey):
4355
4356 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4357
4358         Bytecode cache should a have a boot-specific validation
4359         https://bugs.webkit.org/show_bug.cgi?id=194769
4360         <rdar://problem/48149509>
4361
4362         Reviewed by Keith Miller.
4363