Add a unit test to test BuildbotQueueView._appendPendingRevisionCount. https://bugs...
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-14  Jason Marcell  <jmarcell@apple.com>
2
3         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
4         https://bugs.webkit.org/show_bug.cgi?id=152910
5
6         Reviewed by Daniel Bates.
7
8         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
9         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
10         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
11         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
12         the need to talk to a real Buildbot server.
13         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
14         without the need to talk to a real Buildbot server.
15         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
16         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
17         server.
18         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
19         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
20         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
21         trying to talk to Trac.
22         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
23         QUnit unit tests.
24         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
25
26 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
27
28         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
29         https://bugs.webkit.org/show_bug.cgi?id=132599
30
31         Reviewed by Michael Catanzaro.
32
33         Check if cmake Ninja generators are installed.
34
35         * Scripts/webkitdirs.pm:
36         (canUseNinjaGenerator):
37         (canUseEclipseNinjaGenerator):
38         (generateBuildSystemFromCMakeProject):
39         (canUseEclipse): Deleted.
40
41 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
42
43         [Cocoa] Testing with font family name "System Font" is unused
44         https://bugs.webkit.org/show_bug.cgi?id=153073
45         <rdar://problem/24091683>
46
47         Reviewed by Brent Fulgham.
48
49         * DumpRenderTree/mac/DumpRenderTree.mm:
50         (allowedFontFamilySet): Deleted.
51         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
52         (WTR::allowedFontFamilySet): Deleted.
53         * WebKitTestRunner/mac/TestControllerMac.mm:
54         (WTR::allowedFontFamilySet): Deleted.
55
56 2016-01-13  Daniel Bates  <dabates@apple.com>
57
58         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
59         https://bugs.webkit.org/show_bug.cgi?id=152871
60
61         Reviewed by Brent Fulgham.
62
63         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
64         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
65
66         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
67
68 2016-01-08  Andy Estes  <aestes@apple.com>
69
70         [Content Filtering] Lazily load platform frameworks
71         https://bugs.webkit.org/show_bug.cgi?id=152881
72         rdar://problem/23270886
73
74         Reviewed by Brady Eidson.
75
76         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
77         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
78         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
79         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
80         is loaded after an HTTPS request.
81
82         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
83         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
84         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
85         also re-enabled on iOS after mistakenly being disabled by r188892.
86
87         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
88         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
89         (TestWebKitAPI::TEST):
90         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
91         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
92         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
93         (TEST):
94         (downloadTest):
95         (-[LazilyLoadPlatformFrameworksController init]):
96         (-[LazilyLoadPlatformFrameworksController webView]):
97         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
98         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
99         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
100         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
101         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
102         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
103         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
104         (TestWebKitAPI::TEST):
105         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
106         (TestWebKitAPI::TEST): Deleted.
107         * TestWebKitAPI/cocoa/TestProtocol.h:
108         * TestWebKitAPI/cocoa/TestProtocol.mm:
109         (+[TestProtocol registerWithScheme:]):
110         (+[TestProtocol unregister]):
111
112 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
113
114         Fix the Sunpider converage in slow device.
115         https://bugs.webkit.org/show_bug.cgi?id=152938
116         <rdar://problem/22511411>
117
118         Reviewed by Ryosuke Niwa.
119
120         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
121
122         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
123
124 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
125
126         Add a build flag for custom element
127         https://bugs.webkit.org/show_bug.cgi?id=153005
128
129         Reviewed by Alex Christensen.
130
131         Added --custom-elements option to enable custom elements support.
132
133         * Scripts/webkitperl/FeatureList.pm:
134
135 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
136
137         [JSC] Add a help message when run-jsc-stress-tests fails
138         https://bugs.webkit.org/show_bug.cgi?id=153014
139
140         Reviewed by Csaba Osztrogonác.
141
142         * Scripts/run-jsc-stress-tests:
143
144 2016-01-11  Saam barati  <sbarati@apple.com>
145
146         run-jsc-stress-tests should try to figure out a JSC path
147         https://bugs.webkit.org/show_bug.cgi?id=152971
148
149         Reviewed by Yusuke Suzuki.
150
151         This patch now allows run-jsc-stress-tests to be run
152         without a "--jsc <jsc-path>" argument. It tries
153         to take its best guess at a <jsc-path> automagically.
154         
155         This makes it much easier to just run run-jsc-stress-tests
156         with a directory or a yaml file as an argument.
157         You now just do this:
158         `run-jsc-stress-tests <path-to-yaml>`
159         or
160         `run-jsc-stress-tests <path-to-directory-of-js-files>`
161         
162         I wrote this patch because I'd often find myself hacking the 
163         run-javascriptcore-tests file just to run a particular subset of tests.
164         Because I always forget the arguments to run-jsc-stress-tests (which means
165         I always forgot to provide a --jsc argument), I always found it easier to 
166         just hack on that file instead of calling run-jsc-stress-tests directly.
167         No longer is this true!
168
169         * Scripts/run-jsc-stress-tests:
170
171 2016-01-09  Andy Estes  <aestes@apple.com>
172
173         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
174         https://bugs.webkit.org/show_bug.cgi?id=152950
175         rdar://problem/24066652
176
177         Reviewed by Tim Horton.
178
179         Added an API test.
180
181         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
182         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
183         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
184         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
185         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
186         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
187         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
188         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
189         (TEST):
190
191 2016-01-11  Commit Queue  <commit-queue@webkit.org>
192
193         Unreviewed, rolling out r194866.
194         https://bugs.webkit.org/show_bug.cgi?id=152986
195
196         This change broke the mac build (Requested by ryanhaddad on
197         #webkit).
198
199         Reverted changeset:
200
201         "[Cocoa] Add SPI to opt out a URL scheme from the memory
202         cache"
203         https://bugs.webkit.org/show_bug.cgi?id=152950
204         http://trac.webkit.org/changeset/194866
205
206 2016-01-11  Andy Estes  <aestes@apple.com>
207
208         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
209         https://bugs.webkit.org/show_bug.cgi?id=152950
210         rdar://problem/24066652
211
212         Reviewed by Tim Horton.
213
214         Added an API test.
215
216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
217         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
218         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
219         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
220         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
221         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
222         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
223         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
224         (TEST):
225
226 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
227
228         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
229         https://bugs.webkit.org/show_bug.cgi?id=152959
230
231         Reviewed by Brent Fulgham.
232
233         * Scripts/webkitdirs.pm:
234         (determineArchitecture):
235
236 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
237
238         [GTK] W3C CSS2.1 anonymous table tests are failing
239         https://bugs.webkit.org/show_bug.cgi?id=152455
240
241         Reviewed by Mario Sanchez Prada.
242
243         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
244         tests. Add upstream patches to fix detection of XHTML files.
245
246         * gtk/jhbuild.modules:
247         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
248         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
249
250 2016-01-10  Saam barati  <sbarati@apple.com>
251
252         Implement a sampling profiler
253         https://bugs.webkit.org/show_bug.cgi?id=151713
254
255         Reviewed by Filip Pizlo.
256
257         * Scripts/run-jsc-stress-tests:
258
259 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
260
261         [webkitdirs] Try arch and uname commands on non-windows OS
262         https://bugs.webkit.org/show_bug.cgi?id=152958
263
264         Reviewed by Michael Catanzaro.
265
266         Right now, determineArchitecture()  uses `arch` and `uname -m`
267         commands to determine architecture in case of condition (isGtk() ||
268         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
269         instead, because this code is applicable to any non-windows OS WebKit
270         supports (even Haiku which once was supported is moderately
271         POSIX-compliant and has uname command).
272
273         * Scripts/webkitdirs.pm:
274         (determineArchitecture):
275
276 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
277
278         run-webkit-tests mis-counts totals when there are other crashes
279         https://bugs.webkit.org/show_bug.cgi?id=152894
280         <rdar://problem/24098697>
281
282         Reviewed by Alexey Proskuryakov.
283
284         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
285         (TestRunResults.add): Do not update result counters for other crashes.
286
287 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
288
289         webkit-patch build-and-test should have an option to iterate over new tests
290         https://bugs.webkit.org/show_bug.cgi?id=143093
291
292         Reviewed by Michael Catanzaro.
293
294         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
295         It allows running run-webkit-tests on modified or new paths in LayoutTests.
296         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
297         It implements the translation of -expected.* paths to their related tests.
298         It also implements the removal of skipped tests.
299
300         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
301         (LayoutTestFinder.find_touched_tests):
302         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
303         (MockPort):
304         (MockPort.__init__):
305         (MockPort.tests):
306         (LayoutTestFinderTests):
307         (LayoutTestFinderTests.touched_files):
308         (LayoutTestFinderTests.test_touched_test):
309         (LayoutTestFinderTests.test_expected_touched_test):
310         (LayoutTestFinderTests.test_platform_expected_touched_test):
311         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
312         (LayoutTestFinderTests.test_touched_but_skipped_test):
313         * Scripts/webkitpy/port/base.py:
314         (Port.potential_test_names_from_expected_file):
315         * Scripts/webkitpy/tool/commands/download_unittest.py:
316         (DownloadCommandsTest._default_options):
317         * Scripts/webkitpy/tool/steps/options.py:
318         (Options):
319         * Scripts/webkitpy/tool/steps/runtests.py:
320         (RunTests.options):
321         (RunTests.run):
322         (RunTests):
323         (RunTests._new_or_modified_tests):
324         (RunTests._run_webkit_tests):
325         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
326         (RunTestsTest.test_webkit_run_unit_tests):
327         * Scripts/webkitpy/tool/steps/steps_unittest.py:
328         (StepsTest._step_options):
329
330 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
331
332         prepare-ChangeLog should include radar number
333         https://bugs.webkit.org/show_bug.cgi?id=152839
334         <rdar://problem/24093563>
335
336         Reviewed by Daniel Bates.
337
338         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
339         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
340         in the ChangeLog description after the bug URL.
341
342         * Scripts/prepare-ChangeLog:
343         (main): Update signatures.
344         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
345         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
346         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
347         (generateNewChangeLogs): Include radar URL if we found one.
348
349         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
350         Tests for the radar URL extraction.
351
352 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
353
354         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
355         https://bugs.webkit.org/show_bug.cgi?id=152390
356         <rdar://problem/23948321>
357
358         Reviewed by Simon Fraser.
359
360         Fix two use-after-frees.
361
362         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
363         but we may have already progressed to another test by the time the callback fires,
364         having destroyed the TestInvocation.
365         2. UIScriptController is a RefCounted object, but it has a raw pointer to
366         UIScriptContext which has the same lifetime as a TestInvocation.
367         As a result, completion blocks of UIScriptController actions would use a destroyed
368         TestInvocation.
369
370         * WebKitTestRunner/TestInvocation.cpp:
371         (WTR::TestInvocation::~TestInvocation):
372         (WTR::TestInvocation::url):
373         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
374         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
375         (WTR::TestInvocation::runUISideScript):
376         * WebKitTestRunner/TestInvocation.h:
377         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
378         (UIScriptContext::UIScriptContext):
379         (UIScriptContext::~UIScriptContext):
380         (UIScriptContext::runUIScript):
381         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
382         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
383         (WTR::UIScriptController::UIScriptController):
384         (WTR::UIScriptController::contextDestroyed):
385         (WTR::UIScriptController::makeWindowObject):
386         (WTR::UIScriptController::setWillBeginZoomingCallback):
387         (WTR::UIScriptController::willBeginZoomingCallback):
388         (WTR::UIScriptController::setDidEndZoomingCallback):
389         (WTR::UIScriptController::didEndZoomingCallback):
390         (WTR::UIScriptController::setDidEndScrollingCallback):
391         (WTR::UIScriptController::didEndScrollingCallback):
392         (WTR::UIScriptController::setDidShowKeyboardCallback):
393         (WTR::UIScriptController::didShowKeyboardCallback):
394         (WTR::UIScriptController::setDidHideKeyboardCallback):
395         (WTR::UIScriptController::didHideKeyboardCallback):
396         (WTR::UIScriptController::uiScriptComplete):
397         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
398         (WTR::UIScriptController::create):
399         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
400         (WTR::UIScriptController::doAsyncTask):
401         (WTR::UIScriptController::zoomToScale):
402         (WTR::UIScriptController::singleTapAtPoint):
403         (WTR::UIScriptController::doubleTapAtPoint):
404         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
405         (WTR::UIScriptController::contentVisibleRect):
406         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
407         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
408         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
409         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
410         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
411         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
412         (WTR::UIScriptController::doAsyncTask):
413
414 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
415
416         [buildbot] clean-build script should remove untracked files and revert local changes too
417         https://bugs.webkit.org/show_bug.cgi?id=142400
418
419         Reviewed by Ryosuke Niwa.
420
421         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
422         A helper routine SCM.discard_untracked_files is added for that purpose.
423
424         * BuildSlaveSupport/clean-build:
425         (main): Making call to Scripts/clean-webkit
426         * Scripts/clean-webkit: Added.
427         (main): Revert changes and delete untracked files.
428         * Scripts/webkitpy/common/checkout/scm/scm.py:
429         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
430         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
431         (SCMTest._shared_test_discard_untracked_files):
432         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
433
434 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
435
436         Add a setting and preferences to enable display-list drawing. Does nothing yet.
437         https://bugs.webkit.org/show_bug.cgi?id=152807
438
439         Reviewed by Zalan Bujtas.
440         
441         Add an item to the Settings menu to toggle display-list drawing.
442
443         * MiniBrowser/mac/SettingsController.h:
444         * MiniBrowser/mac/SettingsController.m:
445         (-[SettingsController _populateMenu]):
446         (-[SettingsController validateMenuItem:]):
447         (-[SettingsController toggleDisplayListDrawingEnabled:]):
448         (-[SettingsController displayListDrawingEnabled]):
449         * MiniBrowser/mac/WK2BrowserWindowController.m:
450         (-[WK2BrowserWindowController didChangeSettings]):
451
452 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
453
454         Python SCM should be able to retrieve untracked files - Add GIT support
455         https://bugs.webkit.org/show_bug.cgi?id=143135
456
457         Reviewed by Michael Catanzaro.
458
459         * Scripts/webkitpy/common/checkout/scm/git.py:
460         (Git.untracked_files): Adding support for git.
461         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
462         (GitTest.setUp):
463         (GitTest.test_untracked_files): Adding test.
464
465 2016-01-05  Mark Lam  <mark.lam@apple.com>
466
467         Rename badly named JSC_timeout env var to JSCTEST_timeout.
468         https://bugs.webkit.org/show_bug.cgi?id=152748
469
470         Reviewed by Geoffrey Garen.
471
472         Now that we validate JSC options, the badly named JSC_timeout env var causes the
473         bots to have a bad time.
474
475         * Scripts/run-javascriptcore-tests:
476         * Scripts/run-jsc-stress-tests:
477
478 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
479
480         [GTK] Allow to save and restore session
481         https://bugs.webkit.org/show_bug.cgi?id=115600
482
483         Reviewed by Michael Catanzaro.
484
485         Add test case to check the new session API.
486
487         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
488         (testWebKitWebViewSessionState):
489         (testWebKitWebViewSessionStateWithFormData):
490         (beforeAll):
491
492 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
493
494         [EFL] Bump EFL version to 1.16.1
495         https://bugs.webkit.org/show_bug.cgi?id=152688
496
497         Reviewed by Gyuyoung Kim.
498
499         * efl/jhbuild.modules:
500
501 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
502
503         error running layout tests on iOS simulator on latest build
504         https://bugs.webkit.org/show_bug.cgi?id=152719
505         <rdar://problem/24009549>
506
507         Reviewed by Alexey Proskuryakov.
508
509         * Scripts/webkitpy/xcode/simulator.py:
510         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
511           before running simctl spawn command.
512
513 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
514
515         Unreviewed, move Frédéric Wang to committers list
516
517         He seems to be on the contributors list by accident. He has been landing his own commits for
518         about two years now.
519
520         * Scripts/webkitpy/common/config/contributors.json:
521
522 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
523
524         Unreviewed, move Sebastian Dröge to committers list harder
525
526         He accidentally added himself to the reviewers list because the file is confusing. Then I
527         accidentially moved him to the contributors list because the file is confusing, even though
528         I knew the contributors list existed in this file and was attempting to add him to the
529         committers list. Really move him to the committers list now.
530
531         * Scripts/webkitpy/common/config/contributors.json:
532
533 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
534
535         Python SCM should be able to retrieve untracked files - Add SVN support
536         https://bugs.webkit.org/show_bug.cgi?id=152546
537
538         Reviewed by Michael Catanzaro.
539
540         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
541         (test_untracked_files): Activating test for SVN.
542         * Scripts/webkitpy/common/checkout/scm/svn.py:
543         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
544
545 2015-12-31  Andy Estes  <aestes@apple.com>
546
547         Replace WTF::move with WTFMove
548         https://bugs.webkit.org/show_bug.cgi?id=152601
549
550         Reviewed by Brady Eidson.
551
552         * DumpRenderTree/TestRunner.h:
553         (TestRunner::setAllowedHosts):
554         * DumpRenderTree/win/DRTDataObject.cpp:
555         (DRTDataObject::SetData):
556         * TestWebKitAPI/Tests/WTF/Deque.cpp:
557         (TestWebKitAPI::TEST):
558         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
559         (TestWebKitAPI::TEST):
560         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
561         (TestWebKitAPI::TEST):
562         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
563         (TestWebKitAPI::TEST):
564         * TestWebKitAPI/Tests/WTF/Ref.cpp:
565         (TestWebKitAPI::passWithRef):
566         (TestWebKitAPI::TEST):
567         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
568         (TestWebKitAPI::TEST):
569         * TestWebKitAPI/Tests/WTF/Vector.cpp:
570         (TestWebKitAPI::TEST):
571         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
572         (TestWebKitAPI::TEST):
573         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
574         (TestWebKitAPI::TEST):
575         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
576         (TestWebKitAPI::createTestValue):
577         (TestWebKitAPI::TEST):
578         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
579         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
580         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
581         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
582         (TestWebKitAPI::createNFAs):
583         (TestWebKitAPI::TEST_F):
584         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
585         (TestWebKitAPI::combine):
586         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
587         (TestWebKitAPI::createNFAs):
588         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
589         (TEST):
590         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
591         (WebProcessTest::add):
592
593 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
594
595         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
596         https://bugs.webkit.org/show_bug.cgi?id=152634
597
598         Reviewed by Carlos Garcia Campos.
599
600         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
601         (testLoadFromGResource): Added test.
602         (beforeAll):
603         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
604         (registerGResource): Added.
605         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
606         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
607         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
608
609 2015-12-31  David Kilzer  <ddkilzer@apple.com>
610
611         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
612         <https://bugs.webkit.org/show_bug.cgi?id=152601>
613
614         Ignore unknown pragmas on older clangs.  Fixes the following
615         build failure:
616
617             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
618             #pragma clang diagnostic ignored "-Wself-move"
619                                              ^
620             1 error generated.
621
622         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
623         (TestWebKitAPI::TEST):
624         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
625         (TestWebKitAPI::TEST):
626
627 2015-12-31  Andy Estes  <aestes@apple.com>
628
629         Update the style checker to advise using WTFMove() instead of WTF::move()
630         https://bugs.webkit.org/show_bug.cgi?id=152601
631
632         Reviewed by Daniel Bates.
633
634         * Scripts/webkitpy/style/checkers/cpp.py:
635         (check_wtf_move):
636         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
637         (WebKitStyleTest.test_wtf_move):
638
639 2015-12-31  Andy Estes  <aestes@apple.com>
640
641         Fix warnings uncovered by migrating to WTF_MOVE
642         https://bugs.webkit.org/show_bug.cgi?id=152601
643
644         Reviewed by Daniel Bates.
645
646         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
647         self-move, even if doing so would trigger a warning.
648
649         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
650         (TestWebKitAPI::TEST):
651         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
652         (TestWebKitAPI::TEST):
653
654 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
655
656         [GTK] The install-dependencies script has a syntax error
657         https://bugs.webkit.org/show_bug.cgi?id=152613
658
659         Reviewed by Michael Catanzaro.
660
661         * gtk/install-dependencies: Add the missing 'then.'
662
663 2015-12-30  Philippe Normand  <pnormand@igalia.com>
664
665         [Mac][GTK] Jhbuild support for OSX
666         https://bugs.webkit.org/show_bug.cgi?id=150799
667
668         Reviewed by Michael Catanzaro.
669
670         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
671         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
672         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
673         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
674
675 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
676
677         Unreviewed, move Sebastian Dröge to committers list
678
679         He accidentally added himself to the reviewers list because the file is confusing.
680
681         * Scripts/webkitpy/common/config/contributors.json:
682
683 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
684
685         Remove the unused #define _USE_MATH_DEFINES
686         https://bugs.webkit.org/show_bug.cgi?id=152034
687
688         Reviewed by Tim Horton.
689         
690         Update this test to use piDouble from MathExtras.h, and
691         std::numeric_limits<>.
692
693         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
694
695 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
696
697         Python SCM should be able to retrieve untracked files - Generic changes
698         https://bugs.webkit.org/show_bug.cgi?id=152536
699
700         Reviewed by Brent Fulgham.
701
702         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
703         No support is yet added to GIT and SVN specific implementations.
704
705         * Scripts/webkitpy/common/checkout/scm/scm.py:
706         (SCM.untracked_files):
707         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
708         (SCMTest._shared_test_untracked_files):
709
710 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
711
712         SVN checkout used by RunBenchmark should be non-interactive
713         https://bugs.webkit.org/show_bug.cgi?id=152542
714
715         Reviewed by Ryosuke Niwa.
716
717         RunBenchmark should not require user interaction while running.
718
719         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
720         (BenchmarkBuilder._checkout_with_subversion):
721
722 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
723
724         Web Inspector: add support for running protocol-test.js tests on Windows
725         https://bugs.webkit.org/show_bug.cgi?id=148037
726         <rdar://problem/22292237>
727
728         Reviewed by Simon Fraser.
729
730         * DumpRenderTree/win/TestRunnerWin.cpp:
731         (TestRunner::inspectorTestStubURL): Provide implementation.
732
733 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
734
735         [MediaStream] MediaDeviceInfo.label must be empty in some situations
736         https://bugs.webkit.org/show_bug.cgi?id=152000
737
738         Reviewed by Brent Fulgham.
739
740         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
741         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
742         (WTR::InjectedBundle::setUserMediaPermission):
743         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
744         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
745
746         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
747         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
748         * WebKitTestRunner/InjectedBundle/TestRunner.h:
749
750         * WebKitTestRunner/TestController.cpp:
751         (WTR::TestController::setUserMediaPermissionForOrigin):
752         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
753         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
754           persistent permission for origin, that can be done from script now.
755         * WebKitTestRunner/TestController.h:
756
757         * WebKitTestRunner/TestInvocation.cpp:
758         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
759           SetUserMediaPermissionForOrigin.
760
761 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
762
763         [Win] Unreviewed build fix: Recognize Windows 10 variants.
764
765         * Scripts/webkitpy/common/system/platforminfo.py:
766         (PlatformInfo._determine_win_version):
767
768 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
769
770         Content blockers should be able to promote http to https
771         https://bugs.webkit.org/show_bug.cgi?id=148966
772
773         Reviewed by Benjamin Poulain.
774
775         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
776         (WebCore::ContentExtensions::operator<<):
777         (TestWebKitAPI::TEST_F):
778
779 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
780
781         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
782         https://bugs.webkit.org/show_bug.cgi?id=152516
783
784         Reviewed by Gyuyoung Kim.
785
786         * MiniBrowser/efl/main.c:
787
788 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
789
790         Unreviewed: Add John Wilander as a contributor.
791
792         * Scripts/webkitpy/common/config/contributors.json:
793
794 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
795
796         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
797         https://bugs.webkit.org/show_bug.cgi?id=152482
798
799         Reviewed by Brent Fulgham.
800
801         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
802         for the same property. On WK2, the element returned will not be valid, but is still present and
803         that can lead to looping.
804
805         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
806         (AccessibilityUIElement::horizontalScrollbar):
807         (AccessibilityUIElement::verticalScrollbar):
808         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
809         (WTR::AccessibilityUIElement::horizontalScrollbar):
810         (WTR::AccessibilityUIElement::verticalScrollbar):
811
812 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
813
814         Unreviewed.
815
816         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
817
818 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
819
820         [EFL] test_ewk2_context failed after r192808
821         https://bugs.webkit.org/show_bug.cgi?id=151846
822
823         Reviewed by Gyuyoung Kim.
824
825         Used the added ewk_context_web_process_count_limit_set api
826         instead of the deprecated ewk_context_process_model_set.
827
828         * MiniBrowser/efl/main.c:
829         (elm_main):
830
831 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
832
833         Unreviewed, move myself to reviewer list.
834
835         * Scripts/webkitpy/common/config/contributors.json:
836
837 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
838
839         Unreviewed, add myself to the committers list.
840
841         * Scripts/webkitpy/common/config/contributors.json:
842
843 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
844
845         [GTK] jquery.min.js violates DFSG
846         https://bugs.webkit.org/show_bug.cgi?id=152428
847
848         Reviewed by Joseph Pecoraro.
849
850         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
851         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
852
853         * gtk/manifest.txt.in:
854
855 2015-12-19  Dan Bernstein  <mitz@apple.com>
856
857         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
858         https://bugs.webkit.org/show_bug.cgi?id=152462
859
860         Reviewed by Alexey Proskuryakov.
861
862         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
863           OS X 10.9:
864
865         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
866         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
867         * MiniBrowser/Configurations/DebugRelease.xcconfig:
868         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
869         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
870
871         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
872           never getting compiled:
873
874         * DumpRenderTree/mac/TextInputController.m:
875         * MiniBrowser/mac/BrowserWindowController.m:
876         * TestWebKitAPI/Tests/mac/AttributedString.mm:
877         * WebKitTestRunner/mac/EventSenderProxy.mm:
878
879 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
880
881         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
882
883         This is to make it easy to CC it on Bugzilla.
884
885         * Scripts/webkitpy/common/config/contributors.json:
886
887 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
888
889         Pasteboard get messed up after running kill-old-processes
890         https://bugs.webkit.org/show_bug.cgi?id=152426
891
892         Reviewed by Alexey Proskuryakov.
893
894         * BuildSlaveSupport/kill-old-processes:
895         (main): Do not kill pasteboard anymore.
896
897 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
898
899         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
900         https://bugs.webkit.org/show_bug.cgi?id=152157
901         <rdar://problem/23851817>
902
903         Reviewed by Alexey Proskuryakov.
904
905         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
906         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
907         * Scripts/webkitpy/layout_tests/controllers/manager.py:
908         (Manager._get_test_inputs): Common method to calculate test_inputs.
909         (Manager._update_worker_count): Calculate and update required number of workers.
910
911 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
912
913         run-webkit-tests fails to delete Simulator device during cleanup
914         https://bugs.webkit.org/show_bug.cgi?id=152363
915
916         Reviewed by Alexey Proskuryakov.
917
918         * Scripts/webkitpy/xcode/simulator.py:
919         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
920
921 2015-12-16  Tim Horton  <timothy_horton@apple.com>
922
923         [mac-wk2] fast/events force click tests crashing
924         https://bugs.webkit.org/show_bug.cgi?id=152339
925
926         Reviewed by Beth Dakin.
927
928         * WebKitTestRunner/mac/EventSenderProxy.mm:
929         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
930         Set the NSEvent's _type member in addition to overriding -type,
931         because there are assertions in touch event handling code that depend on it.
932
933 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
934
935         Enforce temporarily bots to sync WebKit and WPT testharness.js
936         https://bugs.webkit.org/show_bug.cgi?id=152334
937
938         Reviewed by Darin Adler.
939
940         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
941         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
942
943 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
944
945         [Fetch API] Add fetch API compile time flag
946         https://bugs.webkit.org/show_bug.cgi?id=152254
947
948         Reviewed by Darin Adler.
949
950         * Scripts/webkitperl/FeatureList.pm:
951
952 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
953
954         Unreviewed.
955
956         Added files that have impact in building Streams API to the watchlist.
957
958         * Scripts/webkitpy/common/config/watchlist:
959
960 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
961
962         Unreviewed.
963
964         Added imported tests to Streams API watchlist.
965
966         * Scripts/webkitpy/common/config/watchlist:
967
968 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
969
970         Remove default copy of wpt testharness.js when launching wpt server
971         https://bugs.webkit.org/show_bug.cgi?id=152298
972
973         Reviewed by Darin Adler.
974
975         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
976         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
977
978 2015-12-15  David Kilzer  <ddkilzer@apple.com>
979
980         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
981         <http://webkit.org/b/152314>
982
983         Reviewed by Daniel Bates.
984
985         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
986         code path to exit immediately when calling main().
987         Unfortunately, DumpRenderTreeMain.mm was used for both
988         DumpRenderTree command-line binary and DumpRenderTree.app, which
989         meant that the app would exit immediately with no error code
990         when run!
991
992         The workaround is to introduce a separate source file called
993         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
994         already does.
995
996         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
997         DumpRenderTreeAppMain.mm to the project.  Make it the only
998         compiled source for the DumpRenderTree.app target.
999         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1000         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1001         case someone tries mistakenly to use the app.
1002         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1003         Link to JavaScriptCore.framework on iOS for the assert.
1004         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1005         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1006         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1007         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1008         (main): Add assert for iOS so that a crash occurs if someone
1009         tries to run the wrong command.
1010
1011 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1012
1013         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1014         https://bugs.webkit.org/show_bug.cgi?id=152266
1015         <rdar://problem/22092676>
1016
1017         Reviewed by Simon Fraser.
1018
1019         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1020         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1021         Add a test that crashed before this change, and doesn't crash after.
1022
1023 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1024
1025         AX: iOS: Text field variations do not have the correct traits
1026         https://bugs.webkit.org/show_bug.cgi?id=152237
1027
1028         Reviewed by Mario Sanchez Prada.
1029
1030         Add iOS calls for determing if an object is a search field or a text area.
1031
1032         * DumpRenderTree/AccessibilityUIElement.cpp:
1033         (getIsSearchFieldCallback):
1034         (getIsTextAreaCallback):
1035         (stringForSelectionCallback):
1036         (AccessibilityUIElement::getJSClass):
1037         * DumpRenderTree/AccessibilityUIElement.h:
1038         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1039         (AccessibilityUIElement::identifier):
1040         (AccessibilityUIElement::isTextArea):
1041         (AccessibilityUIElement::isSearchField):
1042         (AccessibilityUIElement::traits):
1043         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1044         (WTR::AccessibilityUIElement::scrollPageRight):
1045         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1046         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1047         (WTR::AccessibilityUIElement::isSearchField):
1048         (WTR::AccessibilityUIElement::isTextArea):
1049         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1050         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1051         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1052         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1053         (WTR::AccessibilityUIElement::isTextArea):
1054         (WTR::AccessibilityUIElement::isSearchField):
1055         (WTR::AccessibilityUIElement::rowCount):
1056
1057 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1058
1059         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1060         https://bugs.webkit.org/show_bug.cgi?id=152252
1061
1062         Reviewed by Sergio Villar Senin.
1063
1064         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1065         for building the JHBuild on Debian systems.
1066
1067 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1068
1069         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1070         https://bugs.webkit.org/show_bug.cgi?id=152156
1071
1072         Reviewed by Dan Bernstein.
1073
1074         Our frameworks should appropriately prefix all ObjC classes,
1075         not just external symbols.
1076
1077         * Scripts/check-for-inappropriate-objc-class-names:
1078         Remove the -g switch to check all ObjC class names.
1079
1080 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1081
1082         [MediaStream] Expose media capture devices persistent permissions to WebCore
1083         https://bugs.webkit.org/show_bug.cgi?id=152087
1084
1085         Add support for the new user media permission checker page UI client method.
1086
1087         Reviewed by Chris Dumez.
1088
1089         * WebKitTestRunner/TestController.cpp:
1090         (WTR::decidePolicyForUserMediaPermissionRequest):
1091         (WTR::checkUserMediaPermissionForOrigin):
1092         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1093         (WTR::TestController::createWebViewWithOptions): Ditto.
1094         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1095         (WTR::originUserVisibleName): New, create a string for the origin.
1096         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1097           according to the state of the origin permission map.
1098         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1099           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1100         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1101           origin permission map.
1102         * WebKitTestRunner/TestController.h:
1103
1104 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1105
1106         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1107         https://bugs.webkit.org/show_bug.cgi?id=152022
1108         rdar://problem/23763584
1109
1110         Reviewed by Darin Adler.
1111
1112         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1113         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1114         (WTR::InjectedBundlePage::willSendRequestForFrame):
1115         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1116         (WTR::TestRunner::setWillSendRequestReturnsNull):
1117         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1118         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1119         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1120         (WTR::TestRunner::willSendRequestHTTPBody):
1121         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1122
1123 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1124
1125         Remove additional simulator checks before running layout-tests
1126         https://bugs.webkit.org/show_bug.cgi?id=152146
1127
1128         Reviewed by Darin Adler.
1129
1130         * Scripts/webkitpy/port/ios.py:
1131         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1132         * Scripts/webkitpy/xcode/simulator.py:
1133         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1134         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1135
1136 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1137
1138         Run atleast one simulator even if max process limit is low
1139         https://bugs.webkit.org/show_bug.cgi?id=152081
1140         <rdar://problem/23819694>
1141
1142         Reviewed by Alexey Proskuryakov.
1143
1144 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1145
1146         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1147         https://bugs.webkit.org/show_bug.cgi?id=144262
1148
1149         Reviewed by Carlos Garcia Campos.
1150
1151         Added new unit test to check the additional scenarios we now
1152         handle for custom URI schemes.
1153
1154         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1155         (generateHTMLContent): New helper function to generate big enough content.
1156         (testWebContextURIScheme): New unit test.
1157
1158 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1159
1160         [EFL] Fix unhandled web process message when launching MiniBrowser
1161         https://bugs.webkit.org/show_bug.cgi?id=152048
1162
1163         Reviewed by Gyuyoung Kim.
1164
1165         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1166         (TestWebKitAPI::TEST):
1167
1168 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1169
1170         [GTK] Add API to handle beforeunload events
1171         https://bugs.webkit.org/show_bug.cgi?id=139090
1172
1173         Reviewed by Gustavo Noronha Silva.
1174
1175         * MiniBrowser/gtk/BrowserWindow.c:
1176         (browserWindowConstructed):
1177         (browserWindowDeleteEvent):
1178         (browser_window_class_init):
1179         Handle delete-event to prevent the window from being closed when
1180         the page has beforeunload handlers. Use
1181         webkit_web_view_try_close() when the window is requested to be
1182         closed.
1183         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1184         (testWebViewJavaScriptDialogs):
1185         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1186         script dialog type.
1187
1188 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1189
1190         Refactored initialization code in LoadTrackingTest.
1191
1192         Rubber-stamped by Carlos Garcia Campos.
1193
1194         Small refactoring to make sure that the state of a LoadTrackingTest
1195         gets properly reset before loading new web content.
1196
1197         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1198         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1199         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1200         functions and reset the remaining local variables.
1201         (LoadTrackingTest::loadURI): Call reset();
1202         (LoadTrackingTest::loadHtml): Ditto.
1203         (LoadTrackingTest::loadPlainText): Ditto.
1204         (LoadTrackingTest::loadBytes): Ditto.
1205         (LoadTrackingTest::loadRequest): Ditto.
1206         (LoadTrackingTest::reload): Ditto.
1207         (LoadTrackingTest::goBack): Ditto.
1208         (LoadTrackingTest::goForward): Ditto.
1209
1210 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1211
1212         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1213         https://bugs.webkit.org/show_bug.cgi?id=151942
1214
1215         Reviewed by Darin Adler.
1216
1217         * MiniBrowser/efl/main.c:
1218         (window_create): Enable offline web application cache feature on MiniBrowser.
1219         (elm_main):
1220
1221 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1222
1223         https://bugs.webkit.org/show_bug.cgi?id=151243
1224         <rdar://problem/22955197>
1225
1226         Reviewed by Alexey Proskuryakov.
1227
1228         * LayoutTestRelay/LayoutTestRelay/main.m:
1229         (getTestingSimDevice): Use separate testing device for each worker.
1230         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1231         (Manager.run): Perform cleanup even if setup fails.
1232         * Scripts/webkitpy/port/ios.py:
1233         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1234         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1235         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1236         (IOSSimulatorPort._quit_ios_simulator): Same
1237         (IOSSimulatorPort.clean_up_test_run): Same
1238         (IOSSimulatorPort.check_sys_deps): Same
1239         (IOSSimulatorPort.testing_device): Same
1240         (IOSSimulatorPort.reset_preferences): Same
1241         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1242         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1243         * Scripts/webkitpy/xcode/simulator.py:
1244         (Device.delete): Delete the simulator device.
1245         (Simulator.delete_device): Same
1246         (Simulator.wait_until_device_is_booted): Wait for device booting.
1247
1248 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1249
1250         [EFL] Add API to provide preferences before creating ewk_view
1251         https://bugs.webkit.org/show_bug.cgi?id=151587
1252
1253         Reviewed by Gyuyoung Kim.
1254
1255         * MiniBrowser/efl/main.c:
1256         (on_key_down):
1257         (quit):
1258         (window_create):
1259         Moved settings related code to configuration() not to update settings
1260         whenever ewk_view is created.
1261         (configuration):
1262         (elm_main):
1263
1264 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1265
1266         Unreviewed. Fix GTK+ API tests after r193639.
1267
1268         The new jhbuild version needs some more variables ot be present in
1269         the builtin dict, even if they are set to None.
1270
1271         * jhbuild/jhbuildutils.py:
1272         (enter_jhbuild_environment_if_available):
1273
1274 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1275
1276         [GTK] Notify WebCore when notification is clicked
1277         https://bugs.webkit.org/show_bug.cgi?id=151951
1278
1279         Reviewed by Carlos Garcia Campos.
1280
1281         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1282         (testWebViewNotification): test the new API.
1283
1284 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1285
1286         'jhbuild build' should fail immediately when building any module fails
1287         https://bugs.webkit.org/show_bug.cgi?id=145697
1288
1289         Reviewed by Carlos Garcia Campos.
1290
1291         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1292         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1293         Everything is placed under lib instead of lib64 now.
1294         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1295         --exit-on-error when running 'jhbuild build'.
1296         * jhbuild/jhbuildrc_common.py:
1297         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1298         jhbuild should be able to handle these for us without breaking things....
1299
1300 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1301
1302         Add support to import w3c tests from a repository with a different root that the main repo dir
1303         https://bugs.webkit.org/show_bug.cgi?id=151751
1304
1305         Reviewed by Ryosuke Niwa and Youenn Fablet.
1306
1307         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1308         in a different directory than the repository root.
1309
1310         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1311         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1312         requires having the copy_path lists including tuples of origin and destination directories.
1313
1314         * Scripts/webkitpy/w3c/test_downloader.py:
1315         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1316         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1317         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1318         (TestImporterTest.test_tests_directory): Test.
1319
1320 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1321
1322         Mock TestRepositories in W3C importer tests
1323         https://bugs.webkit.org/show_bug.cgi?id=151938
1324
1325         Reviewed by Youenn Fablet.
1326
1327         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1328         is because the test repository method reading the file was using the filesystem directly instead of taking the
1329         host one. This patch changes that.
1330
1331         * Scripts/webkitpy/w3c/test_downloader.py:
1332         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1333         default one.
1334         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1335         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1336         (TestImporterTest.test_harnesslinks_conversion):
1337         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1338
1339 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1340
1341         TestNetscapePlugIn: Address review comment on 193607
1342         <http://webkit.org/b/151881>
1343
1344         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1345         (testSetStatus): Initializing std::unique_ptr<char[]> with
1346         nullptr is redundant.
1347
1348 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1349
1350         [GTK] Add webkit_uri_request_get_http_method
1351         https://bugs.webkit.org/show_bug.cgi?id=151601
1352
1353         Reviewed by Martin Robinson.
1354
1355         Add test case to check HTTP method of WebKitURIRequest.
1356
1357         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1358         (testURIRequestHTTPMethod):
1359         (serverCallback):
1360         (beforeAll):
1361         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1362         (sendRequestCallback):
1363
1364 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1365
1366         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1367         https://bugs.webkit.org/show_bug.cgi?id=79918
1368
1369         Reviewed by Gustavo Noronha Silva.
1370
1371         Add unit tests to check the different console messages.
1372
1373         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1374         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1375         (ConsoleMessageTest::ConsoleMessage::operator==):
1376         (ConsoleMessageTest::consoleMessageReceivedCallback):
1377         (ConsoleMessageTest::ConsoleMessageTest):
1378         (ConsoleMessageTest::~ConsoleMessageTest):
1379         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1380         (testWebKitConsoleMessageConsoleAPI):
1381         (testWebKitConsoleMessageJavaScriptException):
1382         (testWebKitConsoleMessageNetworkError):
1383         (testWebKitConsoleMessageSecurityError):
1384         (beforeAll):
1385         (afterAll):
1386         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1387         (consoleMessageSentCallback):
1388         (pageCreatedCallback):
1389
1390 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1391
1392         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1393         https://bugs.webkit.org/show_bug.cgi?id=151934
1394
1395         Reviewed by Csaba Osztrogonác.
1396
1397         * MiniBrowser/efl/main.c:
1398         (on_window_deletion): Revert the changes of r192767.
1399
1400 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1401
1402         [GTK] update-webkitgtk-libs cannot build mesa
1403         https://bugs.webkit.org/show_bug.cgi?id=151535
1404
1405         Reviewed by Martin Robinson.
1406
1407         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1408         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1409         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1410         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1411         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1412         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1413
1414         * gtk/jhbuild.modules:
1415
1416 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1417
1418         [GTK][Mac] libWebExtensionTest link error
1419         https://bugs.webkit.org/show_bug.cgi?id=150802
1420
1421         Reviewed by Carlos Garcia Campos.
1422
1423         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1424
1425 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1426
1427         TestNetscapePlugIn: Fix leaks found by static analyzer
1428         <http://webkit.org/b/151881>
1429
1430         Reviewed by Darin Adler.
1431
1432         Fixes the following leaks found by the static analyzer:
1433             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1434                     return false;
1435                            ^~~~~
1436             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1437                     return false;
1438                            ^~~~~
1439             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1440                     return false;
1441                            ^~~~~
1442
1443         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1444         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1445         early return if allocation fails.
1446         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1447         Make sure to call fclose() on filehandle, even for an early
1448         return.
1449         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1450
1451 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1452
1453         prepare-ChangeLog: Fix some warning messages when using svn
1454         <http://webkit.org/b/151914>
1455
1456         Reviewed by Daniel Bates.
1457
1458         * Scripts/prepare-ChangeLog:
1459         (generateFunctionLists): Simplify logic so that we never call
1460         normalizePath() with an undefined value.
1461         (attributeCommand): Quote $subPath for the shell so that we
1462         don't try to run "svn propget" on invalid paths.
1463
1464 2015-12-04  David Kilzer  <ddkilzer@apple.com>
1465
1466         TestNetscapePlugIn: Fix remaining static analyzer warnings
1467         <http://webkit.org/b/151888>
1468
1469         Reviewed by Alexey Proskuryakov.
1470
1471         Fixes the following static analyzer warnings:
1472             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1473                     CRASH();
1474                     ^~~~~~~
1475             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1476                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1477                 ^~~~~~~~~~~~~~~~
1478             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1479                 return obj->pluginTest->NPP_SetWindow(window);
1480                        ^~~~~~~~~~~~~~~
1481             2 warnings generated.
1482
1483         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1484         (CRASH): Use __builtin_trap() for gcc/clang.
1485         (NPP_SetWindow): Add early return if obj is nullptr.
1486
1487 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1488
1489         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1490         https://bugs.webkit.org/show_bug.cgi?id=151797
1491
1492         Reviewed by Martin Robinson.
1493
1494         Since we switched to use the network process to run the unit tests
1495         the test /webkit2/WebKitWebResource/get-data sometimes fails and
1496         sometimes passes. We are now also getting the notification for the
1497         css image. Since we wait for 3 resources, sometimes the css image
1498         is loaded before and then checkResourceData is called for it, but
1499         not handled. When the css image is the last one loaded the test
1500         passes. So, we just need to wait for the 4 resources.
1501
1502         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1503         (testWebResourceGetData):
1504
1505 2015-12-03  David Kilzer  <ddkilzer@apple.com>
1506
1507         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1508         <http://webkit.org/b/151845>
1509
1510         Reviewed by Simon Fraser.
1511
1512         Fixes the following static analyzer warning:
1513             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1514                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1515                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1516
1517         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1518         (createBitmapContext): Free 'buffer' after using it in logging
1519         to fix the use-after-free.  Assign a value of nullptr to buffer
1520         so we don't return with it set to a freed address.
1521
1522 2015-12-03  Jer Noble  <jer.noble@apple.com>
1523
1524         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1525         https://bugs.webkit.org/show_bug.cgi?id=151830
1526
1527         Reviewed by Anders Carlsson.
1528
1529         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1530
1531         * DumpRenderTree/mac/DumpRenderTree.mm:
1532         (resetWebPreferencesToConsistentValues):
1533         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1534         (WTR::initializeWebViewConfiguration):
1535
1536 2015-12-03  Anders Carlsson  <andersca@apple.com>
1537
1538         Remove Objective-C GC support
1539         https://bugs.webkit.org/show_bug.cgi?id=151819
1540         rdar://problem/23746991
1541
1542         Reviewed by Dan Bernstein.
1543
1544         * asan/asan.xcconfig:
1545
1546 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1547
1548         Allow nil for unspecified benchmark pathes
1549         https://bugs.webkit.org/show_bug.cgi?id=151784
1550
1551         Reviewed by Filip Pizlo.
1552
1553         `Pathname.new(nil)` will raise an error.
1554         Only generate Pathname if the benchmark path is specified.
1555
1556         * Scripts/run-jsc-benchmarks:
1557
1558 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1559
1560         [Win] Run non-http tests without Cygwin
1561         https://bugs.webkit.org/show_bug.cgi?id=151721
1562
1563         Reviewed by Andy Estes.
1564
1565         Support native 32-bit and 64-bit Python (and Perl) builds
1566         for running tests:
1567
1568         1. Use "startswith('win')", rather than "== 'win32'" to support
1569         various Windows build types.
1570         2. Supply full path for some native Windows utilities, since the
1571         path environment does not always have the specified, and they are
1572         guaranteed to exist in those specific locations.
1573         3. Make sure native Windows Python test runs pass proper environment
1574         variables to run programs.
1575         4. Append 'exe' suffix when running Windows executables.
1576         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1577         command doesn't exist.
1578         
1579         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1580         the current Perl executable, rather than requiring a new path search.
1581         * Scripts/webkitpy/common/find_files_unittest.py:
1582         (TestWinNormalize.test_win): Use startswith('win').
1583         * Scripts/webkitpy/common/prettypatch_unittest.py:
1584         (test_pretty_diff_encodings): Ditto.
1585         * Scripts/webkitpy/common/system/executive.py:
1586         (Executive._should_close_fds): Ditto.
1587         (Executive.shell_command_for_script): Use startswith('win').
1588         (Executive.kill_process): Use full path to killall executable.
1589         (Executive.check_running_pid): Use startswith('win').
1590         (Executive.running_pids): Ditto.
1591         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1592         running under native Windows Python.
1593         (Executive._child_process_encoding): Use startswith('win').
1594         (Executive._should_encode_child_process_arguments): Ditto.
1595         (Executive.popen): Recognize proper script engine on Windows, since it
1596         does not support the shebang syntax.
1597         (Executive.run_in_parallel): Use startswith('win').
1598         * Scripts/webkitpy/common/system/executive_unittest.py:
1599         (never_ending_command): Ditto.
1600         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1601         (ExecutiveTest.serial_test_kill_process): Ditto.
1602         (ExecutiveTest.serial_test_kill_all): Ditto.
1603         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1604         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1605         (main): Ditto.
1606         * Scripts/webkitpy/common/system/file_lock.py:
1607         (FileLock._create_lock): Ditto.
1608         (FileLock._remove_lock): Ditto.
1609         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1610         (RealFileSystemTest.test_chdir): Ditto.
1611         (RealFileSystemTest.test_chdir__notexists): Ditto.
1612         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1613         * Scripts/webkitpy/common/system/path_unittest.py:
1614         (AbspathTest.test_abspath_to_uri_win): Ditto.
1615         * Scripts/webkitpy/common/system/platforminfo.py:
1616         (PlatformInfo._determine_os_name): Ditto.
1617         * Scripts/webkitpy/common/system/user.py: Ditto.
1618         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1619         (ManagerTest.integration_test_needs_servers): Ditto.
1620         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1621         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1622         driver letters.
1623         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1624         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1625         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1626         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1627         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1628         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1629         (TestHttpServer.test_start_cmd): Ditto.
1630         * Scripts/webkitpy/port/base.py:
1631         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1632         and 'SYSTEMROOT' in environment passed to test runners.
1633         (Port._apache_config_file_name_for_platform): Use startswith('win').
1634         (Port._build_path): Ditto.
1635         (Port._path_to_driver): Include 'exe' suffix when running under native
1636         Windows.
1637         * Scripts/webkitpy/port/driver.py:
1638         (Driver._setup_environ_for_driver): Explicitly make some environment
1639         variables strings.
1640         * Scripts/webkitpy/port/server_process.py:
1641         (ServerProcess.__init__): Use startswith('win').
1642         * Scripts/webkitpy/port/win.py:
1643         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1644         registry key formats.
1645         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1646         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1647         and regtool on Cygwin.
1648         (WinPort.write_registry_value): Ditto.
1649         (WinPort.setup_crash_log_saving): Ditto.
1650         (WinPort.restore_crash_log_saving): Ditto.
1651         (WinPort.prevent_error_dialogs): Ditto.
1652         (WinPort.allow_error_dialogs): Ditto.
1653         (WinPort.find_system_pid): Revise to use Windows management
1654         infrastructure on native Windows, continue using 'ps' on Cygwin.
1655         (WinPort.read_registry_string): Deleted.
1656         (WinPort.write_registry_string): Deleted.
1657         * Scripts/webkitpy/test/main.py:
1658         (main): Use startswith('win').
1659         (Tester._parse_args): Ditto.
1660
1661 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1662
1663         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1664         https://bugs.webkit.org/show_bug.cgi?id=150792
1665
1666         Reviewed by Saam Barati.
1667
1668         * Scripts/webkitperl/FeatureList.pm:
1669
1670 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1671
1672         Unreviewed, rolling out r192914.
1673         https://bugs.webkit.org/show_bug.cgi?id=151734
1674
1675         JSC tests for this change are failing on 32 and 64-bit bots
1676         (Requested by ryanhaddad on #webkit).
1677
1678         Reverted changeset:
1679
1680         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1681         enable this feature"
1682         https://bugs.webkit.org/show_bug.cgi?id=150792
1683         http://trac.webkit.org/changeset/192914
1684
1685 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1686
1687         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1688         <http://webkit.org/b/151726>
1689
1690         Reviewed by Simon Fraser.
1691
1692         * WebKitTestRunner/mac/EventSenderProxy.mm:
1693         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1694         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1695
1696 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
1697
1698         Give String and AtomicString an existingHash() function
1699         https://bugs.webkit.org/show_bug.cgi?id=151717
1700
1701         Reviewed by Andreas Kling.
1702
1703         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1704         (TestWebKitAPI::TEST):
1705         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1706         (TestWebKitAPI::TEST):
1707
1708 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1709
1710         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1711         https://bugs.webkit.org/show_bug.cgi?id=150792
1712
1713         Reviewed by Saam Barati.
1714
1715         * Scripts/webkitperl/FeatureList.pm:
1716
1717 2015-12-01  Sam Weinig  <sam@webkit.org>
1718
1719         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1720         <rdar://problem/23320863>
1721         https://bugs.webkit.org/show_bug.cgi?id=151708
1722
1723         Reviewed by Anders Carlsson.
1724
1725         * WebKitTestRunner/TestController.cpp:
1726         (WTR::TestController::createOtherPage):
1727         (WTR::TestController::createWebViewWithOptions):
1728         Update for new WKPageUIClient.
1729
1730 2015-12-01  Anders Carlsson  <andersca@apple.com>
1731
1732         Remove WebKit2.framework
1733         https://bugs.webkit.org/show_bug.cgi?id=151715
1734
1735         Reviewed by Dan Bernstein.
1736
1737         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1738         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1739         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1740         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1741         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1742         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1743         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1744
1745 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
1746
1747         Unreviewed common typo fix "occurance" => "occurrence".
1748
1749         * Scripts/webkitpy/tool/commands/queries.py:
1750         (FindFlakyTests._print_statistics):
1751
1752 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1753
1754         Make ProcessModel always MultipleSecondaryProcesses
1755         https://bugs.webkit.org/show_bug.cgi?id=151662
1756
1757         Reviewed by Antti Koivisto.
1758
1759         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1760         (TestWebKitAPI::TEST):
1761         * WebKitTestRunner/TestController.cpp:
1762         (WTR::TestController::generatePageConfiguration):
1763
1764 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1765
1766         Make usesNetworkProcess always true
1767         https://bugs.webkit.org/show_bug.cgi?id=151580
1768
1769         Reviewed by Darin Adler.
1770
1771         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1772         (TestWebKitAPI::TEST):
1773         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1774         (TestWebKitAPI::TEST):
1775         * WebKitTestRunner/TestController.cpp:
1776         (WTR::TestController::generatePageConfiguration):
1777
1778 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1779
1780         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
1781
1782         Add a way to skip unit tests only for Debug or Release builds and
1783         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
1784
1785         * Scripts/run-gtk-tests:
1786         (SkippedTest):
1787         (SkippedTest.__init__):
1788         (SkippedTest.__str__):
1789         (SkippedTest.skip_entire_suite):
1790         (SkippedTest.skip_for_build_type):
1791         (TestRunner):
1792         (TestRunner.__init__):
1793
1794 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1795
1796         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
1797
1798         It's an assert hit because we are reloading a view loaded with
1799         HTML data which is not supported. Use loadURI instead.
1800
1801         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1802         (testWebViewCustomCharset):
1803
1804 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1805
1806         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
1807         https://bugs.webkit.org/show_bug.cgi?id=151633
1808
1809         Reviewed by Csaba Osztrogonác.
1810
1811         * TestWebKitAPI/PlatformGTK.cmake:
1812         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
1813
1814 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1815
1816         [GTK] Remove the remaining uses of GMainLoopSource
1817         https://bugs.webkit.org/show_bug.cgi?id=151632
1818
1819         Reviewed by Žan Doberšek.
1820
1821         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1822         (testWebViewSyncRequestOnMaxConns):
1823         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1824         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1825         (WTR::TestRunner::TestRunner):
1826         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1827         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1828         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1829         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1830         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1831         (WTR::timeoutSource):
1832         (WTR::TestController::notifyDone):
1833         (WTR::TestController::platformRunUntil):
1834
1835 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1836
1837         [cmake] Add testb3 to the build system
1838         https://bugs.webkit.org/show_bug.cgi?id=151619
1839
1840         Reviewed by Gyuyoung Kim.
1841
1842         * Scripts/build-jsc:
1843
1844 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1845
1846         [jhbuild] Fix pixman build with clang
1847         https://bugs.webkit.org/show_bug.cgi?id=151441
1848
1849         Reviewed by Carlos Garcia Campos.
1850
1851         * efl/jhbuild.modules:
1852         * gtk/jhbuild.modules:
1853
1854 2015-11-26  David Kilzer  <ddkilzer@apple.com>
1855
1856         Extract prependToEnvironmentVariableList
1857         <http://webkit.org/b/151536>
1858
1859         Reviewed by Daniel Bates.
1860
1861         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1862                webkitdirs_unittest/prependToEnvironmentVariableList.pl
1863
1864         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
1865         and prependToEnvironmentVariableList.
1866         (appendToEnvironmentVariableList): Simplify variable name.
1867         Switch to use $Config{path_sep}.
1868         (prependToEnvironmentVariableList): Add new method.
1869         (setupMacWebKitEnvironment): Switch to use
1870         prependToEnvironmentVariableList().
1871         (setupIOSWebKitEnvironment): Ditto.
1872
1873         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
1874         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
1875
1876 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1877
1878         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1879         https://bugs.webkit.org/show_bug.cgi?id=151567
1880
1881         Reviewed by Darin Adler.
1882
1883         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1884         (on_window_deletion):
1885
1886 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1887
1888         [GTK] Use the network process unconditionally
1889         https://bugs.webkit.org/show_bug.cgi?id=151541
1890
1891         Reviewed by Alex Christensen.
1892
1893         Fix TestInspectorServer test. Do not assume we already have the
1894         title we want when the page has been loaded, since the title is
1895         changed afterwards. So, check if the title has already been set,
1896         and if not wait for it.
1897
1898         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1899         (openRemoteDebuggingSession):
1900
1901 2015-11-23  Alex Christensen  <achristensen@webkit.org>
1902
1903         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
1904         https://bugs.webkit.org/show_bug.cgi?id=151532
1905
1906         Reviewed by Benjamin Poulain.
1907
1908         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1909         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1910         (TestWebKitAPI::TEST):
1911         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1912         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
1913         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
1914         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
1915         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
1916         so it was calling a function on a test object that had gone out of scope.
1917         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
1918         but that will become the default soon and that call will be removed.
1919
1920 2015-11-22  David Kilzer  <ddkilzer@apple.com>
1921
1922         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
1923         <http://webkit.org/b/151542>
1924
1925         Reviewed by Daniel Bates.
1926
1927         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1928         (base_url): Use the Port object (already passed in) to give us
1929         the path to the LayoutTests directory, which already checks for a
1930         --layout-tests-directory command-line switch.
1931         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
1932         argument since we can get this from the Port object already
1933         passed in via Port.results_directory().  Also switch to use
1934         Port.layout_tests_dir() to get the LayoutTests directory.
1935
1936         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1937         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
1938         Add test case for custom LayoutTests directory.
1939         (TestWebPlatformTestServer.test_previously_spawned_instance):
1940         Update Port object to set mock results directory as if it was
1941         set on the command-line.  Remove unneeded argument from
1942         WebPlatformTestServer constructor.
1943         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
1944
1945         * Scripts/webkitpy/port/base.py:
1946         (Port.to.start_web_platform_test_server): Remove unneeded
1947         argument from WebPlatformTestServer constuctor.
1948
1949 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1950
1951         [GTK] Some unit tests fail when using the network process
1952         https://bugs.webkit.org/show_bug.cgi?id=151490
1953
1954         Reviewed by Martin Robinson.
1955
1956         Run the soup server in a separate thread in TestResources test to
1957         avoid deadlocks.
1958
1959         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
1960         /webkit2/WebKitWebResource/get-data when using the network process.
1961
1962         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1963         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
1964         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1965         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
1966         present, create a WorkQueue to run the server.
1967         (WebKitTestServer::run): Run the server in the work queue if it
1968         has been created.
1969         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1970         type into server options as flags.
1971
1972 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1973
1974         [GTK] ImageDiff should normalize the diff image
1975         https://bugs.webkit.org/show_bug.cgi?id=151261
1976
1977         Reviewed by Sergio Villar Senin.
1978
1979         * ImageDiff/gtk/ImageDiff.cpp:
1980         (readPixbufFromStdin): Fix memory leak.
1981         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
1982         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
1983
1984 == Rolled over to ChangeLog-2015-11-21 ==