[ews-build] Add short name to config.json
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Add short name to config.json
4         https://bugs.webkit.org/show_bug.cgi?id=194456
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-build/config.json: Added short name.
9         * BuildSlaveSupport/ews-build/loadConfig.py:
10         (loadBuilderConfig): Set the short name as the builder description.
11
12 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
13
14         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
15         https://bugs.webkit.org/show_bug.cgi?id=194418
16
17         Reviewed by Lucas Forschler.
18
19         Do not include errors trying when finding crashlogs at the end of
20         a run-webkit-tests run since we don't process those errors.
21
22         * Scripts/webkitpy/port/darwin.py:
23         (DarwinPort._look_for_all_crash_logs_in_log_dir):
24         * Scripts/webkitpy/port/ios_device.py:
25         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
26         * Scripts/webkitpy/port/watch_device.py:
27         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
28
29 2019-02-08  Beth Dakin  <bdakin@apple.com>
30
31         Add afterScreenUpdates to WKSnapshotConfiguration
32         https://bugs.webkit.org/show_bug.cgi?id=194362
33         -and corresponding-
34         <rdar://problem/40655528> Please add an "after screen updates" property to 
35         WKSnapshotConfiguration (to solve blank snapshots)
36
37         Reviewed by Tim Horton.
38
39         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
40         (TEST):
41
42 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
43
44         clampTo(): do not convert the input to double when dealing with integers
45         https://bugs.webkit.org/show_bug.cgi?id=194263
46         <rdar://problem/47692312>
47
48         Reviewed by Darin Adler.
49
50         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
51         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
52         (TestWebKitAPI::testClampFloatingPointToInteger):
53         (TestWebKitAPI::testClampSameSignIntegers):
54         (TestWebKitAPI::testClampUnsignedToSigned):
55         (TestWebKitAPI::testClampSignedToUnsigned):
56
57 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
58
59         webkitpy: Respect --dedicated-simulators flag
60         https://bugs.webkit.org/show_bug.cgi?id=194416
61         <rdar://problem/47894722>
62
63         Reviewed by Lucas Forschler.
64
65         * Scripts/webkitpy/port/device_port.py:
66         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
67         available devices can be safely ignored.
68
69 2019-02-07  Keith Rollin  <krollin@apple.com>
70
71         Remove extra copy of 100x100-red.tga
72         https://bugs.webkit.org/show_bug.cgi?id=194371
73         <rdar://problem/47873465>
74
75         Reviewed by Said Abou-Hallawa.
76
77         In order to help it pass its tests, Bug 194190 added a second copy of
78         the file 100x100-red.tga. However, it turns out that this additional
79         file wasn't actually needed, and that that sole previous copy was
80         sufficient. At the same time, this second copy -- which was copied to
81         the same location in the build output as the first copy -- now caused
82         XCBuild to complain because there were two production rules for the
83         same output file. Address this by removing the newly-added extra copy.
84
85         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
86         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
87
88 2019-02-07  Alex Christensen  <achristensen@webkit.org>
89
90         Deprecate WKBundlePageSetDefersLoading
91         https://bugs.webkit.org/show_bug.cgi?id=191394
92
93         Reviewed by Dean Jackson.
94
95         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
96         (WTR::TestRunner::setDefersLoading):
97
98 2019-02-07  Zalan Bujtas  <zalan@apple.com>
99
100         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
101         https://bugs.webkit.org/show_bug.cgi?id=194391
102
103         Reviewed by Antti Koivisto.
104
105         * LayoutReloaded/misc/LFC-passing-tests.txt:
106
107 2019-02-06  Keith Rollin  <krollin@apple.com>
108
109         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
110         https://bugs.webkit.org/show_bug.cgi?id=193975
111         <rdar://problem/47643306>
112
113         Reviewed by Tim Horton.
114
115         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
116         the Info.plist file into the bundle. This step is not necessary as the
117         implicit "bundle up all the build products into a framework" build
118         phase does this already. Having the Copy Bundle Resources phase do
119         this causes a conflict under XCBuild, which objects to two build
120         phases producing the same file (Info.plist). Address this by removing
121         Info.plist from the Copy Bundle Resources phase.
122
123         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
124
125 2019-02-06  Keith Rollin  <krollin@apple.com>
126
127         Really enable the automatic checking and regenerations of .xcfilelists during builds
128         https://bugs.webkit.org/show_bug.cgi?id=194357
129         <rdar://problem/47861231>
130
131         Reviewed by Chris Dumez.
132
133         Bug 194124 was supposed to enable the automatic checking and
134         regenerating of .xcfilelist files during the build. While related
135         changes were included in that patch, the change to actually enable the
136         operation somehow was omitted. This patch actually enables the
137         operation. The check-xcfilelist.sh scripts now check
138         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
139         from the checking.
140
141         * DumpRenderTree/Scripts/check-xcfilelists.sh:
142         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
143
144 2019-02-06  David Kilzer  <ddkilzer@apple.com>
145
146         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
147         <https://webkit.org/b/194286>
148         <rdar://problem/47815558>
149
150         Reviewed by Alexey Proskuryakov.
151
152         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
153         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
154         WKRetainPtr<> to avoid leaking the WKDataRef.
155
156 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
157
158         Unreviewed, fix a typo
159
160         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
161
162 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
163
164         [GTK][WPE] force libpsl build to use ICU in jhbuild
165         https://bugs.webkit.org/show_bug.cgi?id=194288
166
167         Reviewed by Carlos Garcia Campos.
168
169         * gtk/jhbuild.modules:
170         Require ICU for libpsl build in jhbuild, like done in WPE.
171
172 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
173
174         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
175         https://bugs.webkit.org/show_bug.cgi?id=194209
176
177         Reviewed by Carlos Garcia Campos.
178
179         Enhance TestCookieManager to ensure this doesn't happen again.
180
181         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
182         (testCookieManagerPersistentStorage):
183         (beforeAll):
184
185 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
186
187         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
188         https://bugs.webkit.org/show_bug.cgi?id=194324
189
190         Reviewed by Andy Estes.
191
192         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
193         part of the name is already implicit, since this is in testing code in TestOptions.
194
195         * WebKitTestRunner/TestController.cpp:
196         (WTR::TestController::generateContextConfiguration const):
197         (WTR::updateTestOptionsFromTestHeader):
198         * WebKitTestRunner/TestOptions.h:
199         (WTR::TestOptions::hasSameInitializationOptions const):
200
201 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
202
203         [ews-build] Allow * as platform for builders and workers
204         https://bugs.webkit.org/show_bug.cgi?id=188533
205
206         Reviewed by Lucas Forschler.
207
208         * BuildSlaveSupport/ews-build/loadConfig.py:
209         (checkWorkersAndBuildersForConsistency):
210
211 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
212
213         [ews-build] Add few bots to config.json
214         https://bugs.webkit.org/show_bug.cgi?id=194304
215
216         Reviewed by Lucas Forschler.
217
218         * BuildSlaveSupport/ews-build/config.json:
219
220 2019-02-05  Keith Rollin  <krollin@apple.com>
221
222         Enable the automatic checking and regenerations of .xcfilelists during builds
223         https://bugs.webkit.org/show_bug.cgi?id=194124
224         <rdar://problem/47721277>
225
226         Reviewed by Tim Horton.
227
228         Bug 193790 add a facility for checking -- during build time -- that
229         any needed .xcfilelist files are up-to-date and for updating them if
230         they are not. This facility was initially opt-in by setting
231         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
232         the process seemed robust. Its now time to enable this facility and
233         make it opt-out. If there is a need to disable this facility, set and
234         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
235         running `make` or `build-webkit`, or before running Xcode from the
236         command line.
237
238         Additionally, remove the step that generates a list of source files
239         going into the UnifiedSources build step. It's only necessarily to
240         specify Sources.txt and SourcesCocoa.txt as inputs.
241
242         * Scripts/generate-xcfilelists:
243
244 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
245
246         [GTK][WPE] force libpsl build to use ICU in jhbuild
247         https://bugs.webkit.org/show_bug.cgi?id=194288
248
249         Reviewed by Philippe Normand.
250
251         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
252         This can cause build failures if libidn is detected but libunistring is not available.
253
254         Make sure that ICU is used for runtime and builtin PSL data.
255
256         * gtk/jhbuild.modules:
257         * wpe/jhbuild.modules:
258
259 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
260
261         [ews-app] Modified timestamp should be updated on updating data
262         https://bugs.webkit.org/show_bug.cgi?id=194295
263
264         Reviewed by Lucas Forschler.
265
266         * BuildSlaveSupport/ews-app/ews/models/build.py:
267         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
268         * BuildSlaveSupport/ews-app/ews/models/step.py:
269
270 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
271
272         Unreviewed, rolling out r240742.
273
274         Causes crashes on iOS simulator.
275
276         Reverted changeset:
277
278         "[iOS] Keyups for non-modifier keys identified as "Dead" when
279         not focused in a content-editable element"
280         https://bugs.webkit.org/show_bug.cgi?id=192824
281         https://trac.webkit.org/changeset/240742
282
283 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
284
285         run-webkit-tests emits message "...running None" when running tests
286         https://bugs.webkit.org/show_bug.cgi?id=194133
287         <rdar://problem/47724738>
288
289         Reviewed by Lucas Forschler.
290
291         * Scripts/webkitpy/xcode/device_type.py:
292         (DeviceType.__str__): Use both version mapping tables and use just the variant
293         name if no version name is available.
294         * Scripts/webkitpy/xcode/device_type_unittest.py:
295         (DeviceTypeTest):
296         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
297         an associated named.
298
299 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
300
301         [WPE] require python3-setuptools for meson build in jhbuild
302         https://bugs.webkit.org/show_bug.cgi?id=194287
303
304         Reviewed by Philippe Normand.
305
306         python3-setuptools is needed to build meson in jhbuild.
307         It is already required by the GTK port.
308
309         * wpe/install-dependencies:
310
311 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
312
313         [ews-app] Add method to save BuilderMapping to database
314         https://bugs.webkit.org/show_bug.cgi?id=194264
315
316         Reviewed by Lucas Forschler.
317
318         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
319         (BuilderMapping.__str__):
320         (BuilderMapping):
321         (BuilderMapping.save_mapping):
322         (BuilderMapping.update_mapping):
323         (BuilderMapping.get_existing_mapping):
324         (BuilderMapping.is_valid_mapping):
325
326 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
327
328         [ews-app] Add timestamp fields for BuilderMappings
329         https://bugs.webkit.org/show_bug.cgi?id=194266
330
331         Reviewed by Lucas Forschler.
332
333         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
334         (BuilderMapping):
335
336 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
337
338         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
339         https://bugs.webkit.org/show_bug.cgi?id=174816
340
341         Reviewed by Michael Catanzaro.
342
343         Add tests for webkit_uri_for_display().
344
345         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
346         (testURIForDisplayUnaffected):
347         (testURIForDisplayAffected):
348         (beforeAll):
349         (afterAll):
350         * TestWebKitAPI/glib/CMakeLists.txt:
351
352 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
353
354         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
355         https://bugs.webkit.org/show_bug.cgi?id=194158
356         <rdar://problem/47737268>
357
358         Rubber-stamped by Aakash Jain.
359
360         * Scripts/webkitpy/port/device_port.py:
361         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
362
363 2019-02-04  Said Abou-Hallawa  <said@apple.com>
364
365         [CG] Enable setAdditionalSupportedImageTypes for WK1
366         https://bugs.webkit.org/show_bug.cgi?id=194190
367
368         Reviewed by Tim Horton.
369
370         Add a test similar to the one under WebKit Cocoa but make it create a
371         WebView instead of a WKWebView.
372
373         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
374         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
375         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
376         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
377         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
378         (TestWebKitAPI::runTest):
379         (TestWebKitAPI::TEST):
380
381 2019-02-04  Zalan Bujtas  <zalan@apple.com>
382
383         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
384         https://bugs.webkit.org/show_bug.cgi?id=194168
385
386         Reviewed by Simon Fraser.
387
388         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
389
390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
391         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
392         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
393         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
394         (TEST):
395         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
396         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
397
398 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
399
400         REGRESSION (r237269): webkit-patch what-broke is broken 
401         https://bugs.webkit.org/show_bug.cgi?id=193025
402
403         Reviewed by Aakash Jain.
404
405         * Scripts/webkitpy/common/host.py:
406         (Host.buildbot):
407         (Host.bugzilla): Renamed to 'buildbot'.
408
409 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
410
411         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
412         https://bugs.webkit.org/show_bug.cgi?id=194207
413
414         Reviewed by Tim Horton.
415
416         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
417         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
418         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
419         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
420         start and delete forwards to remove the original attachment.
421
422         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
423         (TestWebKitAPI::TEST):
424
425 2019-02-04  Youenn Fablet  <youenn@apple.com>
426
427         Capture state should be managed consistently when doing process swapping
428         https://bugs.webkit.org/show_bug.cgi?id=194122
429         <rdar://problem/47609293>
430
431         Reviewed by Eric Carlson.
432
433         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
434         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
435         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
436         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
437         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
438         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
439         (WTR::TestRunner::isDoingMediaCapture const):
440         * WebKitTestRunner/InjectedBundle/TestRunner.h:
441         * WebKitTestRunner/TestController.cpp:
442         (WTR::TestController::isDoingMediaCapture const):
443         * WebKitTestRunner/TestController.h:
444         * WebKitTestRunner/TestInvocation.cpp:
445         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
446         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
447         (WTR::TestController::isDoingMediaCapture const):
448
449 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
450
451         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
452         https://bugs.webkit.org/show_bug.cgi?id=194142
453
454         Reviewed by Ross Kirsling.
455
456         There three 'separator' variables in TestController.cpp. Renamed
457         it 'pathSeparator', and unified them.
458
459         * WebKitTestRunner/TestController.cpp:
460         (WTR::TestController::generateContextConfiguration const):
461         (WTR::createTestURL):
462         (WTR::TestController::platformAdjustContext):
463
464 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
465
466         Make setNeedsLayout on the root more explicitly about triggering its side-effects
467         https://bugs.webkit.org/show_bug.cgi?id=194198
468
469         Reviewed by Antti Koivisto.
470
471         No need to set the banner heights on navigation now, since Page stores them.
472
473         * MiniBrowser/mac/WK2BrowserWindowController.m:
474         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
475
476 2019-02-03  John Wilander  <wilander@apple.com>
477
478         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
479         https://bugs.webkit.org/show_bug.cgi?id=194104
480         <rdar://problem/47649991>
481
482         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
483
484         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
485         (TestWebKitAPI::TEST):
486             Changed numeric types from unsigned short to uint32_t.
487
488 2019-02-02  David Kilzer  <ddkilzer@apple.com>
489
490         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
491         <https://webkit.org/b/194178>
492         <rdar://problem/47753473>
493
494         Reviewed by Alexey Proskuryakov.
495
496         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
497         (WTR::uninstallFakeHelvetica): Pass nullptr into
498         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
499
500 2019-02-02  Zalan Bujtas  <zalan@apple.com>
501
502         [LFC] Initialize ICB's style with fixed width/height.
503         https://bugs.webkit.org/show_bug.cgi?id=194188
504
505         Reviewed by Antti Koivisto.
506
507         * LayoutReloaded/misc/LFC-passing-tests.txt:
508
509 2019-02-02  Zalan Bujtas  <zalan@apple.com>
510
511         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
512         https://bugs.webkit.org/show_bug.cgi?id=194185
513
514         Reviewed by Antti Koivisto.
515
516         * LayoutReloaded/misc/LFC-passing-tests.txt:
517
518 2018-12-16  Darin Adler  <darin@apple.com>
519
520         Convert additional String::format clients to alternative approaches
521         https://bugs.webkit.org/show_bug.cgi?id=192746
522
523         Reviewed by Alexey Proskuryakov.
524
525         * WebKitTestRunner/TestController.cpp:
526         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
527         as an intermediate in code that ultimately constructs a WTF::String.
528         (WTR::userMediaOriginHash): Use makeString.
529         (WTR::TestController::didNavigateWithNavigationData): More of the same.
530         (WTR::TestController::didPerformClientRedirect): Ditto.
531         (WTR::TestController::didPerformServerRedirect): Ditto.
532         (WTR::TestController::didUpdateHistoryTitle): Ditto.
533
534 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
535
536         [ews-build] Add unit test to verify builder keys
537         https://bugs.webkit.org/show_bug.cgi?id=194152
538
539         Reviewed by Lucas Forschler.
540
541         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
542         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
543
544 2019-02-01  Zalan Bujtas  <zalan@apple.com>
545
546         [LFC] Expand tests coverage (12 new tests -> 787)
547
548         Unreviewed test gardening.
549
550         * LayoutReloaded/misc/LFC-passing-tests.txt:
551
552 2019-02-01  Zalan Bujtas  <zalan@apple.com>
553
554         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
555         https://bugs.webkit.org/show_bug.cgi?id=194163
556
557         Reviewed by Simon Fraser.
558
559         775
560
561         * LayoutReloaded/misc/LFC-passing-tests.txt:
562
563 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
564
565         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
566         https://bugs.webkit.org/show_bug.cgi?id=194140
567         <rdar://problem/47728098>
568
569         Reviewed by Tim Horton.
570
571         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
572         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
573         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
574
575         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
576         test to induce an IPC deadlock when presenting a modal alert during touch start.
577
578         * WebKitTestRunner/InjectedBundle/TestRunner.h:
579         * WebKitTestRunner/TestController.cpp:
580         (WTR::runJavaScriptAlert):
581
582         Add a client callback function for running JavaScript alerts.
583
584         (WTR::TestController::createOtherPage):
585         (WTR::TestController::generateContextConfiguration const):
586
587         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
588         the fix in this patch.
589
590         (WTR::TestController::createWebViewWithOptions):
591
592         Plumb TestOptions to generateContextConfiguration.
593
594         (WTR::TestController::resetPreferencesToConsistentValues):
595         (WTR::TestController::resetStateToConsistentValues):
596         (WTR::updateTestOptionsFromTestHeader):
597         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
598         (WTR::TestController::handleJavaScriptAlert):
599         * WebKitTestRunner/TestController.h:
600         * WebKitTestRunner/TestInvocation.cpp:
601         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
602         * WebKitTestRunner/TestOptions.h:
603         (WTR::TestOptions::hasSameInitializationOptions const):
604
605 2019-02-01  Chris Dumez  <cdumez@apple.com>
606
607         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
608         https://bugs.webkit.org/show_bug.cgi?id=193740
609         <rdar://problem/47527267>
610
611         Reviewed by Alex Christensen.
612
613         Add API test coverage.
614
615         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
616
617 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
618
619         [ews-app] Add display name field to BuilderMapping model
620         https://bugs.webkit.org/show_bug.cgi?id=194153
621
622         Reviewed by Lucas Forschler.
623
624         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
625         (BuilderMapping):
626
627 2019-02-01  Youenn Fablet  <youenn@apple.com>
628
629         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
630         https://bugs.webkit.org/show_bug.cgi?id=194155
631
632         Reviewed by Eric Carlson.
633
634         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
635         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
636         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
637
638 2019-02-01  Zalan Bujtas  <zalan@apple.com>
639
640         [LFC] Adjust replaced element's intrinsic ratio
641         https://bugs.webkit.org/show_bug.cgi?id=194154
642
643         Reviewed by Antti Koivisto.
644
645         761
646
647         * LayoutReloaded/misc/LFC-passing-tests.txt:
648
649 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
650
651         [WPE] Show test results in minibrowser
652         https://bugs.webkit.org/show_bug.cgi?id=194150
653
654         Reviewed by Žan Doberšek.
655
656         * Scripts/webkitpy/port/wpe.py:
657         (WPEPort.show_results_html_file):
658
659 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
660
661         [WPE] MiniBrowser: add ky bindings for back/forward navigation
662         https://bugs.webkit.org/show_bug.cgi?id=194151
663
664         Reviewed by Žan Doberšek.
665
666         ALT + <- go back
667         ALT + -> go forward
668
669         * MiniBrowser/wpe/main.cpp:
670         (main):
671
672 2019-02-01  Zalan Bujtas  <zalan@apple.com>
673
674         [LFC] Set intrinsic size on Layout::Replaced
675         https://bugs.webkit.org/show_bug.cgi?id=194139
676
677         Reviewed by Antti Koivisto.
678
679         744
680
681         * LayoutReloaded/misc/LFC-passing-tests.txt:
682
683 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
684
685         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
686         https://bugs.webkit.org/show_bug.cgi?id=194146
687
688         Reviewed by Xabier Rodriguez-Calvar.
689
690         It allows to open relative paths.
691
692         * MiniBrowser/wpe/main.cpp:
693         (main):
694
695 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
696
697         Update flakiness dashboard configuration after recent queue changes
698         https://bugs.webkit.org/show_bug.cgi?id=194127
699
700         Rubber-stamped by Aakash Jain.
701
702         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
703
704         * TestResultServer/static-dashboards/builders.jsonp:
705
706 2019-01-31  Youenn Fablet  <youenn@apple.com>
707
708         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
709         https://bugs.webkit.org/show_bug.cgi?id=194106
710         <rdar://problem/47676333>
711
712         Reviewed by Ryosuke Niwa.
713
714         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
715         (TestWebKitAPI::didFinishNavigation):
716         (TestWebKitAPI::TEST):
717         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
718
719 2019-01-31  Chris Dumez  <cdumez@apple.com>
720
721         Page zoom level is lost after a process swap or a crash
722         https://bugs.webkit.org/show_bug.cgi?id=194105
723         <rdar://problem/47610781>
724
725         Reviewed by Alex Christensen.
726
727         Add API test coverage.
728
729         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
730         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
731
732 2019-01-31  Alex Christensen  <achristensen@webkit.org>
733
734         Revert r238819 which is unneeded and caused a performance regression.
735         https://bugs.webkit.org/show_bug.cgi?id=192272
736         <rdar://problem/46664625>
737
738         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
739         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
740         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
741
742 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
743
744         Formalize WebKitAdditions mechanism of LoadOptimizer
745         https://bugs.webkit.org/show_bug.cgi?id=193886
746         <rdar://problem/47696809>
747
748         Reviewed by Brent Fulgham.
749
750         * MiniBrowser/MiniBrowser.entitlements:
751         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
752
753 2019-01-31  Zalan Bujtas  <zalan@apple.com>
754
755         [LFC] Margin before/after/start/end initial value is 0 and not auto.
756         https://bugs.webkit.org/show_bug.cgi?id=194090
757
758         Reviewed by Antti Koivisto.
759
760         * LayoutReloaded/misc/LFC-passing-tests.txt:
761
762 2019-01-31  Zalan Bujtas  <zalan@apple.com>
763
764         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
765         https://bugs.webkit.org/show_bug.cgi?id=194074
766
767         Reviewed by Antti Koivisto.
768
769         * LayoutReloaded/misc/LFC-passing-tests.txt:
770
771 2019-01-31  Zalan Bujtas  <zalan@apple.com>
772
773         [LFC][BFC] Add support for block level replaced box.
774         https://bugs.webkit.org/show_bug.cgi?id=194071
775
776         Reviewed by Antti Koivisto.
777
778         * LayoutReloaded/misc/LFC-passing-tests.txt:
779
780 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
781
782         Fix WebKitTestRunner's testPath with Windows full paths
783         https://bugs.webkit.org/show_bug.cgi?id=194012
784
785         Reviewed by Alex Christensen.
786
787         updateTestOptionsFromTestHeader failed to open test files because
788         testPath returned wrong file paths. It returned a path "/C:/..."
789         if a URL "file:///C:/..." was given.
790
791         * WebKitTestRunner/TestController.cpp:
792         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
793
794 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
795
796         [WPE] Bump font related dependencies to match the GTK+ port
797         https://bugs.webkit.org/show_bug.cgi?id=194017
798
799         Reviewed by Žan Doberšek.
800
801         * wpe/jhbuild.modules:
802         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
803         * wpe/patches/icudata-stdlibs.patch: Added.
804
805 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
806
807         Enable swipe tests on iOS
808         https://bugs.webkit.org/show_bug.cgi?id=194076
809
810         Reviewed by Geoffrey Garen.
811
812         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
813         it causes a debug assertion failure in runUIScript.
814
815         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
816         (WTR::UIScriptController::beginBackSwipe):
817         (WTR::UIScriptController::completeBackSwipe):
818
819 2019-01-30  Keith Rollin  <krollin@apple.com>
820
821         Use correct printf format specifier
822         https://bugs.webkit.org/show_bug.cgi?id=194062
823         <rdar://problem/47686167>
824
825         Reviewed by Alexey Proskuryakov.
826
827         LayoutTestSpellChecker.mm is trying to format a variable of type
828         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
829         actually an unsigned long long. Fix this by formatting with %llu.
830
831         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
832         (-[LayoutTestTextCheckingResult description]):
833
834 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
835
836         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
837         https://bugs.webkit.org/show_bug.cgi?id=193979
838
839         Reviewed by Wenson Hsieh.
840
841         Fix the test for iOS. Make the test work with iOS UA string.
842
843         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
844
845 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
846
847         Replace High Sierra LLINT CLoop bot due to hardware failure
848         https://bugs.webkit.org/show_bug.cgi?id=194066
849
850         Reviewed by Aakash Jain.
851
852         * BuildSlaveSupport/build.webkit.org-config/config.json:
853
854 2019-01-30  Keith Rollin  <krollin@apple.com>
855
856         [NSDragItem init] is unavailable
857         https://bugs.webkit.org/show_bug.cgi?id=194059
858         <rdar://problem/47685715>
859
860         Reviewed by Wenson Hsieh.
861
862         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
863         DumpRenderTree and TestWebKitAPI, which both try to create an
864         NSDragItem in a manner that invokes this method. Address this by using
865         -initWithPasteboardWriter instead.
866
867         Note that the parameter passed to initWithPasteboardWriter is likely
868         incorrect. In both cases, the object passed does not conform to
869         NSPasteboardWriting. However, with this fix, we're no worse off than
870         before, and can now perform builds with newer compilers and SDKs until
871         a real fix can be crafted. That work is tracked in
872         https://bugs.webkit.org/show_bug.cgi?id=194060
873
874         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
875         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
876         * TestWebKitAPI/mac/TestDraggingInfo.mm:
877         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
878
879 2019-01-30  Daniel Bates  <dabates@apple.com>
880
881         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
882         https://bugs.webkit.org/show_bug.cgi?id=192824
883         <rdar://problem/47100332>
884
885         Reviewed by Wenson Hsieh.
886
887         Fix a bug where the wrong usage code was used for F13 thru F24.
888
889         * WebKitTestRunner/ios/HIDEventGenerator.mm:
890         (keyCodeForDOMFunctionKey):
891
892 2019-01-30  Chris Dumez  <cdumez@apple.com>
893
894         Regression(PSON) Load hang can occur on history navigation
895         https://bugs.webkit.org/show_bug.cgi?id=194030
896         <rdar://problem/47656939>
897
898         Reviewed by Antti Koivisto.
899
900         Add API test coverage.
901
902         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
903
904 2019-01-30  Zalan Bujtas  <zalan@apple.com>
905
906         [LFC] Expand tests coverage.
907
908         Unreviewed test gardening.
909
910         * LayoutReloaded/misc/LFC-passing-tests.txt:
911
912 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
913
914         [Flatpak] Add openjpeg support
915         https://bugs.webkit.org/show_bug.cgi?id=194019
916
917         Reviewed by Michael Catanzaro.
918
919         * flatpak/org.webkit.CommonModules.yaml:
920
921 2019-01-30  Commit Queue  <commit-queue@webkit.org>
922
923         Unreviewed, rolling out r240708.
924         https://bugs.webkit.org/show_bug.cgi?id=194022
925
926         It broke WPE build (Requested by KaL on #webkit).
927
928         Reverted changeset:
929
930         "[WPE] Bump font related dependencies to match the GTK+ port"
931         https://bugs.webkit.org/show_bug.cgi?id=194017
932         https://trac.webkit.org/changeset/240708
933
934 2019-01-30  Zalan Bujtas  <zalan@apple.com>
935
936         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
937         https://bugs.webkit.org/show_bug.cgi?id=194001
938
939         Reviewed by Antti Koivisto.
940
941         * LayoutReloaded/misc/LFC-passing-tests.txt:
942
943 2019-01-30  Zalan Bujtas  <zalan@apple.com>
944
945         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
946         https://bugs.webkit.org/show_bug.cgi?id=194020
947
948         Reviewed by Antti Koivisto.
949
950         * LayoutReloaded/misc/LFC-passing-tests.txt:
951
952 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
953
954         AX: Support color well on iOS
955         https://bugs.webkit.org/show_bug.cgi?id=194010
956
957         Reviewed by Joanmarie Diggs.
958
959         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
960         (WTR::AccessibilityUIElement::stringAttributeValue):
961
962 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
963
964         [WPE] Bump font related dependencies to match the GTK+ port
965         https://bugs.webkit.org/show_bug.cgi?id=194017
966
967         Reviewed by Žan Doberšek.
968
969         * wpe/jhbuild.modules:
970         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
971         * wpe/patches/icudata-stdlibs.patch: Added.
972
973 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
974
975         [Mac] Update window scale API usage
976         https://bugs.webkit.org/show_bug.cgi?id=193991
977         rdar://problem/47614795
978
979         Reviewed by Tim Horton.
980
981         * DumpRenderTree/mac/DumpRenderTree.mm:
982         (changeWindowScaleIfNeeded):
983         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
984         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
985         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
986
987 2019-01-29  Chris Dumez  <cdumez@apple.com>
988
989         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
990         https://bugs.webkit.org/show_bug.cgi?id=193977
991         <rdar://problem/47643716>
992
993         Reviewed by Geoff Garen.
994
995         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
996         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
997         to the previous provisional committing *before* we make the last load. 
998
999         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1000
1001 2019-01-29  Youenn Fablet  <youenn@apple.com>
1002
1003         Adopt new SPI to evaluate server certificate trust
1004         https://bugs.webkit.org/show_bug.cgi?id=193355
1005
1006         Reviewed by Alex Christensen.
1007
1008         Add infrastructure to handle HTTPS server trust evaluation testing.
1009
1010         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1011         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1012         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1013         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1014         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1015         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1016         * WebKitTestRunner/TestController.cpp:
1017         (WTR::TestController::resetPreferencesToConsistentValues):
1018         (WTR::TestController::didReceiveAuthenticationChallenge):
1019         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1020         * WebKitTestRunner/TestController.h:
1021         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1022         * WebKitTestRunner/TestInvocation.cpp:
1023         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1024         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1025         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1026
1027 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1028
1029         [ews-build] Add build step to print bot Configuration
1030         https://bugs.webkit.org/show_bug.cgi?id=193887
1031
1032         Reviewed by Lucas Forschler.
1033
1034         * BuildSlaveSupport/ews-build/steps.py:
1035         (PrintConfiguration): Build step to print configuration.
1036         * BuildSlaveSupport/ews-build/factories.py:
1037
1038 2019-01-29  Chris Dumez  <cdumez@apple.com>
1039
1040         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1041         https://bugs.webkit.org/show_bug.cgi?id=193967
1042         <rdar://problem/47635348>
1043
1044         Reviewed by Alex Christensen.
1045
1046         Add API test coverage.
1047
1048         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1049         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1050
1051 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1052
1053         [ews-app] Handle incoming results data
1054         https://bugs.webkit.org/show_bug.cgi?id=193973
1055
1056         Reviewed by Lucas Forschler.
1057
1058         * BuildSlaveSupport/ews-app/ews/views/results.py:
1059
1060 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1061
1062         [ews-app] Make the results url generic
1063         https://bugs.webkit.org/show_bug.cgi?id=193928
1064
1065         Reviewed by Lucas Forschler.
1066
1067         * BuildSlaveSupport/ews-app/ews/urls.py:
1068
1069 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1070
1071         [ews-build] Configure buildbot to send events to ews-app
1072         https://bugs.webkit.org/show_bug.cgi?id=193968
1073
1074         Reviewed by Lucas Forschler.
1075
1076         * BuildSlaveSupport/ews-build/events.py: Added.
1077         * BuildSlaveSupport/ews-build/master.cfg:
1078
1079 2019-01-29  Keith Rollin  <krollin@apple.com>
1080
1081         Add .xcfilelists to Run Script build phases
1082         https://bugs.webkit.org/show_bug.cgi?id=193792
1083         <rdar://problem/47201785>
1084
1085         Reviewed by Alex Christensen.
1086
1087         As part of supporting XCBuild, update the necessary Run Script build
1088         phases in their Xcode projects to refer to their associated
1089         .xcfilelist files.
1090
1091         Note that the addition of these files bumps the Xcode project version
1092         number to something that's Xcode 10 compatible. This change means that
1093         older versions of the Xcode IDE can't read these projects. Nor can it
1094         fully load workspaces that refer to these projects (the updated
1095         projects are shown as non-expandable placeholders). `xcodebuild` can
1096         still build these projects; it's just that the IDE can't open them.
1097
1098         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1099         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1100
1101 2019-01-29  John Wilander  <wilander@apple.com>
1102
1103         Add data abstraction and validation for Ad Click Attribution
1104         https://bugs.webkit.org/show_bug.cgi?id=193916
1105         <rdar://problem/47603481>
1106
1107         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1108
1109         Ad click attribution has two steps. First, the storage of an ad
1110         campaign ID for a click that takes the user to a destination
1111         site. Second, a conversion on the destination site that can be
1112         attributed to the ad click.
1113
1114         This patch adds a class that represents a request for ad click
1115         attribution. Validation makes sure that the bits of entropy
1116         reported through this mechanism is limited.
1117
1118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1119         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1120         (TestWebKitAPI::TEST):
1121
1122 2019-01-29  Chris Dumez  <cdumez@apple.com>
1123
1124         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1125         https://bugs.webkit.org/show_bug.cgi?id=193932
1126         <rdar://problem/47598947>
1127
1128         Reviewed by Brady Eidson.
1129
1130         Add API test coverage.
1131
1132         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1133
1134 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1135
1136         Adding new passing LFC tests.
1137
1138         Unreviewed test gardening.
1139
1140         * LayoutReloaded/misc/LFC-passing-tests.txt:
1141
1142 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1143
1144         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1145         https://bugs.webkit.org/show_bug.cgi?id=193964
1146
1147         Reviewed by Antti Koivisto.
1148
1149         * LayoutReloaded/misc/LFC-passing-tests.txt:
1150
1151 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1152
1153         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1154         https://bugs.webkit.org/show_bug.cgi?id=193954
1155
1156         Reviewed by Antti Koivisto.
1157
1158         * LayoutReloaded/misc/LFC-passing-tests.txt:
1159
1160 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1161
1162         WebDriver: add support for running subtests
1163         https://bugs.webkit.org/show_bug.cgi?id=193904
1164
1165         Reviewed by Michael Catanzaro.
1166
1167         pytest already supports it by passing test.py::subtest, so we can do the same.
1168
1169         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1170         (get_item_name): Made this global.
1171         (CollectRecorder.__init__): Receive the parameter to ignore.
1172         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1173         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1174         (collect): Add parameter to ignore.
1175         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1176         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1177         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1178         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1179         (WebDriverTestRunnerSelenium.run): Ditto.
1180         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1181         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1182         (WebDriverTestRunnerW3C.run): Ditto.
1183
1184 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1185
1186         User agent string override for navigator.userAgent should be site specific quirks
1187         https://bugs.webkit.org/show_bug.cgi?id=193950
1188
1189         Reviewed by Brent Fulgham.
1190
1191         Updated per the _WKWebsitePolicies rename.
1192
1193         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1194         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1195
1196 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1197
1198         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1199         https://bugs.webkit.org/show_bug.cgi?id=193941
1200
1201         Reviewed by Alex Christensen.
1202
1203         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1204         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1205         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1206         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1207         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1208         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1209         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1210         * TestWebKitAPI/Tests/WTF/Time.cpp:
1211         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1212         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1213         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1214         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1215
1216 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1217
1218         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1219
1220         * Scripts/webkitpy/common/config/contributors.json:
1221
1222 2019-01-28  Andy Estes  <aestes@apple.com>
1223
1224         [watchOS] Enable Parental Controls content filtering
1225         https://bugs.webkit.org/show_bug.cgi?id=193939
1226         <rdar://problem/46641912>
1227
1228         Reviewed by Ryosuke Niwa.
1229
1230         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1231
1232 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1233
1234         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1235         <https://webkit.org/b/193884>
1236
1237         Reviewed by Jiewen Tan.
1238
1239         * Scripts/webkitpy/style/checkers/cpp.py:
1240         (check_language): Add LocalAuthentication to
1241         `frameworks_with_soft_links`.
1242
1243 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1244
1245         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1246         https://bugs.webkit.org/show_bug.cgi?id=193891
1247
1248         Reviewed by Ross Kirsling.
1249
1250         There were three problems in window sizes of WebView and the host window.
1251         1. The sizes of pixel image output were incorrect.
1252         2. The host window is going to appear after window.resize was invoked.
1253         3. window.resize resized only the host window, not WebView.
1254
1255         This change solves them with a following approach.
1256         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1257         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1258            as well as DumpRenderTree in order to match the client area and the window area.
1259         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1260         d. PlatformWebView::setWindowFrame changes both window sizes.
1261         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1262
1263         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1264         (WTR::PlatformWebView::PlatformWebView): Create the host window
1265         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1266         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1267         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1268
1269 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1270
1271         [ews-app] Add method to save Step data to database
1272         https://bugs.webkit.org/show_bug.cgi?id=193890
1273
1274         Reviewed by Lucas Forschler.
1275
1276         * BuildSlaveSupport/ews-app/ews/models/step.py:
1277         (Step.save_step): Method to save step data.
1278         (Step.update_step): Method to update step data.
1279         (Step.get_existing_step): Method to fetch existing step from database.
1280         (Step.is_valid_result): Method to validate valid step result.
1281
1282 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1283
1284         [ews-app] Add method to save Build data to database
1285         https://bugs.webkit.org/show_bug.cgi?id=193735
1286
1287         Reviewed by Lucas Forschler.
1288
1289         * BuildSlaveSupport/ews-app/ews/models/build.py:
1290         (Build.save_build): Method to save build information to database.
1291         (Build.get_existing_build): Method to fetch existing build from database.
1292         (Build.is_valid_result): Method to validate build result.
1293         * BuildSlaveSupport/ews-app/ews/common/util.py:
1294         (is_valid_int_id): Method to validate valid id.
1295
1296 2019-01-28  Chris Dumez  <cdumez@apple.com>
1297
1298         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1299         https://bugs.webkit.org/show_bug.cgi?id=193915
1300         <rdar://problem/47560907>
1301
1302         Reviewed by Alex Christensen.
1303
1304         Add API test coverage.
1305
1306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1307
1308 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1309
1310         [ews-app] Rename id variables
1311         https://bugs.webkit.org/show_bug.cgi?id=193883
1312
1313         Reviewed by Lucas Forschler.
1314
1315         * BuildSlaveSupport/ews-app/ews/models/build.py:
1316         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1317         * BuildSlaveSupport/ews-app/ews/models/step.py:
1318         * BuildSlaveSupport/ews-app/ews/urls.py:
1319         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1320         * BuildSlaveSupport/ews-app/ews/views/results.py:
1321         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1322
1323 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1324
1325         [ews-app] Allow certain fields to be empty
1326         https://bugs.webkit.org/show_bug.cgi?id=193892
1327
1328         Reviewed by Lucas Forschler.
1329
1330         * BuildSlaveSupport/ews-app/ews/models/build.py:
1331         * BuildSlaveSupport/ews-app/ews/models/step.py:
1332
1333 2019-01-28  Rob Buis  <rbuis@igalia.com>
1334
1335         Update MIME type parser
1336         https://bugs.webkit.org/show_bug.cgi?id=180526
1337
1338         Reviewed by Frédéric Wang.
1339
1340         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1341         (TestWebKitAPI::TEST):
1342
1343 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1344
1345         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1346         https://bugs.webkit.org/show_bug.cgi?id=193896
1347
1348         Reviewed by Antti Koivisto.
1349
1350         * LayoutReloaded/misc/LFC-passing-tests.txt:
1351
1352 2018-12-15  Darin Adler  <darin@apple.com>
1353
1354         Replace many uses of String::format with more type-safe alternatives
1355         https://bugs.webkit.org/show_bug.cgi?id=192742
1356
1357         Reviewed by Mark Lam.
1358
1359         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1360         (WTR::cacheTestRunnerCallback): Use makeString.
1361         * WebKitTestRunner/TestController.cpp:
1362         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1363         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1364
1365 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1366
1367         Use a load optimizer for some sites
1368         https://bugs.webkit.org/show_bug.cgi?id=193881
1369         <rdar://problem/46325455>
1370
1371         Reviewed by Brent Fulgham.
1372
1373         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1374         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1375
1376 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1377
1378         AX: Introduce a static accessibility tree
1379         https://bugs.webkit.org/show_bug.cgi?id=193348
1380         <rdar://problem/47203295>
1381
1382         Reviewed by Ryosuke Niwa.
1383
1384         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1385
1386 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1387
1388         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1389         https://bugs.webkit.org/show_bug.cgi?id=193867
1390
1391         Reviewed by Antti Koivisto.
1392
1393         * LayoutReloaded/misc/LFC-passing-tests.txt:
1394
1395 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1396
1397         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1398         https://bugs.webkit.org/show_bug.cgi?id=193865
1399
1400         Reviewed by Antti Koivisto.
1401
1402         * LayoutReloaded/misc/LFC-passing-tests.txt:
1403
1404 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1405
1406         Need a mechanism to override navigator.userAgent
1407         https://bugs.webkit.org/show_bug.cgi?id=193762
1408         <rdar://problem/47504939>
1409
1410         Reviewed by Brent Fulgham.
1411
1412         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1413
1414         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1415         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1416         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1417
1418 2019-01-25  Dean Jackson  <dino@apple.com>
1419
1420         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1421         https://bugs.webkit.org/show_bug.cgi?id=193831
1422         <rdar://problem/47399263>
1423
1424         Reviewed by Chris Dumez.
1425
1426         Two new tests that exercise cross-origin and same-origin System
1427         Previews.
1428
1429         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1430
1431 2019-01-25  Keith Rollin  <krollin@apple.com>
1432
1433         Update Xcode projects with "Check .xcfilelists" build phase
1434         https://bugs.webkit.org/show_bug.cgi?id=193790
1435         <rdar://problem/47201374>
1436
1437         Reviewed by Alex Christensen.
1438
1439         Support for XCBuild includes specifying inputs and outputs to various
1440         Run Script build phases. These inputs and outputs are specified as
1441         .xcfilelist files. Once created, these .xcfilelist files need to be
1442         kept up-to-date. In order to check that they are up-to-date or not,
1443         add an Xcode build step that invokes an external script that performs
1444         the checking. If the .xcfilelists are found to be out-of-date, update
1445         them, halt the build, and instruct the developer to restart the build
1446         with up-to-date files.
1447
1448         At this time, the checking and regenerating is performed only if the
1449         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1450         who want to use this facility can set this variable and test out the
1451         checking/regenerating. Once it seems like there are no egregious
1452         issues that upset a developer's workflow, we'll unconditionally enable
1453         this facility.
1454
1455         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1456         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1457         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1458         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1459
1460 2019-01-25  Keith Rollin  <krollin@apple.com>
1461
1462         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1463         https://bugs.webkit.org/show_bug.cgi?id=193781
1464         <rdar://problem/47201153>
1465
1466         Reviewed by Alex Christensen.
1467
1468         Part of generating the .xcfilelists used as part of adopting XCBuild
1469         includes running `make DerivedSources.make` from a standalone script.
1470         It’s important for this invocation to have the same environment as
1471         when the actual build invokes `make DerivedSources.make`. If the
1472         environments are different, then the two invocations will provide
1473         different results. In order to get the same environment in the
1474         standalone script, have the script launch xcodebuild targeting the
1475         "Apply Configuration to XCFileLists" build target, which will then
1476         re-invoke our standalone script. The script is now running again, this
1477         time in an environment with all workspace, project, target, xcconfig
1478         and other environment variables established.
1479
1480         The "Apply Configuration to XCFileLists" build target accomplishes
1481         this task via a small embedded shell script that consists only of:
1482
1483             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1484
1485         The process that invokes "Apply Configuration to XCFileLists" first
1486         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1487         evaluated and exports it into the shell environment. When xcodebuild
1488         is invoked, it inherits the value of this variable and can `eval` the
1489         contents of that variable. Our external standalone script can then set
1490         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1491         of command-line parameters needed to restart itself in the appropriate
1492         state.
1493
1494         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1495         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1496
1497 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1498
1499         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1500         https://bugs.webkit.org/show_bug.cgi?id=193802
1501         <rdar://problem/46010580>
1502
1503         Reviewed by Andy Estes.
1504
1505         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1506         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1507         (TEST):
1508
1509 2019-01-25  Daniel Bates  <dabates@apple.com>
1510
1511         [iOS] uiController.keyDown() does not translate Control modified key
1512         https://bugs.webkit.org/show_bug.cgi?id=192898
1513
1514         Reviewed by Wenson Hsieh.
1515
1516         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1517         key translation, as applicable. Among other cases, key translation occurs when performing
1518         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1519         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1520         human pressing down and releasing key(s) using a hardware keyboard.
1521
1522         * WebKitTestRunner/ios/HIDEventGenerator.h:
1523         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1524         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1525
1526         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1527         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1528         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1529         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1530         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1531         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1532         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1533         (-[HIDEventGenerator longPress:completionBlock:]):
1534         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1535         Update code for above renaming.
1536
1537         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1538         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1539
1540         (-[HIDEventGenerator keyDown:]): Added.
1541         (-[HIDEventGenerator keyUp:]): Added.
1542         (-[HIDEventGenerator keyPress:completionBlock:]):
1543         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1544         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1545         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1546         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1547         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1548         (WTR::parseModifier): Deleted.
1549
1550 2019-01-25  Keith Rollin  <krollin@apple.com>
1551
1552         Complete the implementation of generate-xcfilelists
1553         https://bugs.webkit.org/show_bug.cgi?id=193782
1554
1555         Reviewed by Alex Christensen.
1556
1557         A preliminary version of generate-xcfilelists was added in r238008.
1558         This patch updates that script in order to:
1559
1560         - Support checking of .xcfilelists
1561         - Perform better execution of `make DerivedSources.make` by
1562           relaunching generate-xcfilelists under xcodebuild
1563         - Support incremental generation and checking of .xcfilelists
1564         - Support supplementary .xcfilelists files from WebKitAdditions
1565         - Support being wrapped by parallel version of generate-xcfilelists in
1566           Internal that adds support for (re)generating WebKit projects in
1567           that repo.
1568         - Support builds that have been performed in WebKitBuild as well as
1569           ~/Library/Developer/code/DerivedData
1570         - Increase robustness and debugging facilities.
1571
1572         * Scripts/generate-xcfilelists:
1573
1574 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1575
1576         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1577         https://bugs.webkit.org/show_bug.cgi?id=193297
1578         <rdar://problem/47158841>
1579
1580         Unreviewed test case fix.
1581
1582         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1583         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1584
1585         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1586         (TEST):
1587
1588 2019-01-25  Keith Rollin  <krollin@apple.com>
1589
1590         Update existing .xcfilelists
1591         https://bugs.webkit.org/show_bug.cgi?id=193791
1592         <rdar://problem/47201706>
1593
1594         Reviewed by Alex Christensen.
1595
1596         Many .xcfilelist files were added in r238824 in order to support
1597         XCBuild. Update these with recent changes to the set of build files
1598         and with the current generate-xcfilelist script.
1599
1600         * DumpRenderTree/DerivedSources-input.xcfilelist:
1601         * DumpRenderTree/DerivedSources-output.xcfilelist:
1602         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1603         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1604
1605 2019-01-25  Keith Rollin  <krollin@apple.com>
1606
1607         Fix missing dependencies in extract-dependencies-from-makefile
1608         https://bugs.webkit.org/show_bug.cgi?id=193783
1609         <rdar://problem/47201571>
1610
1611         Reviewed by Alex Christensen.
1612
1613         The extract-dependencies-from-makefile script generates .xcfilelists
1614         for XCBuild by invoking a makefile in --debug mode, parsing the
1615         dependency information in the output, and extracting information
1616         regarding targets and dependents. However, the way `make` emits this
1617         dependency information is not rigorous, and so we need to determine
1618         what lines to look for and parse by trial and error. This approach
1619         didn't coriginally atch all the information we needed to collect, so
1620         update the script to look for the additional lines we now know to look
1621         for.
1622
1623         * Scripts/extract-dependencies-from-makefile:
1624         (Parser):
1625         (Parser.addTarget):
1626         (Parser.addPrereq):
1627         (Parser.doParse):
1628
1629 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1630
1631         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1632         https://bugs.webkit.org/show_bug.cgi?id=193297
1633         <rdar://problem/47158841>
1634
1635         Reviewed by Alex Christensen.
1636
1637         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1638             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1639         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1640         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1641         activating the message used to trigger the callback when it is set.
1642
1643 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1644
1645         WKWebView.goBack should reload if there is a safe browsing warning
1646         https://bugs.webkit.org/show_bug.cgi?id=193805
1647         <rdar://problem/46908216>
1648
1649         Reviewed by Geoff Garen.
1650
1651         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1652         (+[Simple3LookupContext sharedLookupContext]):
1653         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1654         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1655         (TEST):
1656
1657 2019-01-25  Chris Dumez  <cdumez@apple.com>
1658
1659         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1660         https://bugs.webkit.org/show_bug.cgi?id=193788
1661         <rdar://problem/47531231>
1662
1663         Reviewed by Alex Christensen.
1664
1665         Add API test coverage.
1666
1667         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1668         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1669
1670 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1671
1672         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1673         https://bugs.webkit.org/show_bug.cgi?id=193771
1674
1675         Unreviewed infrastructure fix.
1676
1677         * Scripts/webkitpy/port/darwin.py:
1678         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1679
1680 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1681
1682         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1683
1684 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1685
1686         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1687
1688         * Scripts/webkitpy/common/config/contributors.json:
1689
1690 2019-01-25  Chris Dumez  <cdumez@apple.com>
1691
1692         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1693         https://bugs.webkit.org/show_bug.cgi?id=193779
1694         <rdar://problem/46170903>
1695
1696         Reviewed by Antti Koivisto.
1697
1698         Add API test that quickly navigates forward to a previous process without waiting for it to
1699         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1700         the process' previous page when reconnecting the it for the forward navigation.
1701
1702         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1703
1704 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1705
1706         Need a way for JavaScript (or bundle) code to participate in undo
1707         https://bugs.webkit.org/show_bug.cgi?id=190009
1708         <rdar://problem/44807048>
1709
1710         Reviewed by Ryosuke Niwa.
1711
1712         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1713         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1714
1715         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1716         (WTR::UIScriptController::lastUndoLabel const):
1717         (WTR::UIScriptController::firstRedoLabel const):
1718         (WTR::UIScriptController::platformUndoManager const):
1719         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1720         (WTR::UIScriptController::lastUndoLabel const):
1721         (WTR::UIScriptController::firstRedoLabel const):
1722         (WTR::UIScriptController::platformUndoManager const):
1723         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1724         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1725         (WTR::UIScriptController::lastUndoLabel const):
1726         (WTR::UIScriptController::firstRedoLabel const):
1727         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1728         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1729         (WTR::UIScriptController::lastUndoLabel const):
1730         (WTR::UIScriptController::firstRedoLabel const):
1731         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1732         (WTR::UIScriptController::platformUndoManager const):
1733         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1734         (WTR::UIScriptController::platformUndoManager const):
1735
1736 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1737
1738         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1739         https://bugs.webkit.org/show_bug.cgi?id=193824
1740
1741         Reviewed by Antti Koivisto.
1742
1743         * LayoutReloaded/misc/LFC-passing-tests.txt:
1744
1745 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1746
1747         Update macOS JSC bot configurations
1748         https://bugs.webkit.org/show_bug.cgi?id=193739
1749
1750         Reviewed by Alexey Proskuryakov.
1751
1752         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1753         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1754         (BubbleQueueServer): Move JSC EWS to Mojave section.
1755         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1756         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1757         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1758
1759 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1760
1761         [Win][WebKitTestRunner] Implement EventSenderProxy
1762         https://bugs.webkit.org/show_bug.cgi?id=193755
1763
1764         Reviewed by Don Olmstead.
1765
1766         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1767         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1768         (WTR::EventSenderProxy::dispatchMessage):
1769         (WTR::EventSenderProxy::EventSenderProxy):
1770         (WTR::EventSenderProxy::mouseDown):
1771         (WTR::EventSenderProxy::mouseUp):
1772         (WTR::EventSenderProxy::mouseMoveTo):
1773         (WTR::EventSenderProxy::mouseScrollBy):
1774         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1775
1776 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1777
1778         Unreviewed fix for API test failure after r240437.
1779
1780         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1781
1782         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1783
1784 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1785
1786         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1787         https://bugs.webkit.org/show_bug.cgi?id=193787
1788         <rdar://problem/47497634>
1789
1790         Reviewed by Alexey Proskuryakov.
1791
1792         * Scripts/webkitdirs.pm:
1793         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1794
1795 2019-01-24  Truitt Savell  <tsavell@apple.com>
1796
1797         Unreviewed, rolling out r240446.
1798
1799         Casued 5 API failures
1800
1801         Reverted changeset:
1802
1803         "Activate the WebResourceLoadStatisticsStore in the
1804         NetworkProcess and deactivate it in the UIProcess."
1805         https://bugs.webkit.org/show_bug.cgi?id=193297
1806         https://trac.webkit.org/changeset/240446
1807
1808 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1809
1810         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1811         https://bugs.webkit.org/show_bug.cgi?id=193741
1812         <rdar://problem/47135030>
1813
1814         Reviewed by Antti Koivisto and Simon Fraser.
1815
1816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1817         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1818         (TestWebKitAPI::TEST):
1819
1820 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1821
1822         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1823         https://bugs.webkit.org/show_bug.cgi?id=193297
1824         <rdar://problem/47158841>
1825
1826         Reviewed by Alex Christensen.
1827
1828         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1829         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1830         activating the message used to trigger the callback when it is set.
1831
1832 2019-01-24  John Wilander  <wilander@apple.com>
1833
1834         Add Ad Click Attribution as an internal/experimental feature
1835         https://bugs.webkit.org/show_bug.cgi?id=193685
1836         <rdar://problem/47450399>
1837
1838         Reviewed by Brent Fulgham.
1839
1840         Added test option adClickAttributionEnabled.
1841
1842         * DumpRenderTree/TestOptions.cpp:
1843         (TestOptions::TestOptions):
1844         * DumpRenderTree/TestOptions.h:
1845         * DumpRenderTree/mac/DumpRenderTree.mm:
1846         (setWebPreferencesForTestOptions):
1847
1848 2019-01-24  Antti Koivisto  <antti@apple.com>
1849
1850         [PSON] Flash on back navigation on Mac
1851         https://bugs.webkit.org/show_bug.cgi?id=193716
1852         <rdar://problem/47148458>
1853
1854         Reviewed by Chris Dumez.
1855
1856         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1857
1858         Closing of the previous page is delayed so waiting for didFinishNavigation is
1859         not sufficient to guarantee we have received all the messages. Wait for them.
1860
1861 2019-01-24  Chris Dumez  <cdumez@apple.com>
1862
1863         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1864         https://bugs.webkit.org/show_bug.cgi?id=193761
1865         <rdar://problem/47456405>
1866
1867         Reviewed by Alex Christensen.
1868
1869         Add API test coverage.
1870
1871         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1872
1873 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1874
1875         webkitpy: Missing PID in crashlog name should not be fatal
1876         https://bugs.webkit.org/show_bug.cgi?id=193771
1877
1878         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1879         of raising an exception.
1880
1881         Reviewed by Lucas Forschler.
1882
1883         * Scripts/webkitpy/port/darwin.py:
1884         (DarwinPort._merge_crash_logs):
1885
1886 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1887
1888         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1889         https://bugs.webkit.org/show_bug.cgi?id=193746
1890
1891         Reviewed by Youenn Fablet.
1892
1893         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1894         so we'd best just not call it.
1895
1896         * Scripts/webkitpy/w3c/test_exporter.py:
1897         (WebPlatformTestExporter.create_branch_with_patch):
1898
1899 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1900
1901         Move FileSystem to WTF
1902         https://bugs.webkit.org/show_bug.cgi?id=193602
1903
1904         Reviewed by Yusuke Suzuki.
1905
1906         * DumpRenderTree/win/DumpRenderTree.cpp:
1907         * TestWebKitAPI/CMakeLists.txt:
1908         * TestWebKitAPI/PlatformGTK.cmake:
1909         * TestWebKitAPI/PlatformJSCOnly.cmake:
1910         * TestWebKitAPI/PlatformPlayStation.cmake:
1911         * TestWebKitAPI/PlatformWPE.cmake:
1912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1913         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1914         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1915         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1916         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1917         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1918         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1919         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1920         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1921         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1922
1923 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1924
1925         [WPE] Remove hard dependency on subprocess32 for the API tests
1926
1927         Rubber-stamped by Carlos Garcia Campos.
1928
1929         * glib/api_test_runner.py:
1930         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1931         its presence only when running WPEQt tests.
1932
1933 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1934
1935         [GLIB] Expose JavaScriptCore options in GLib public API
1936         https://bugs.webkit.org/show_bug.cgi?id=188742
1937
1938         Reviewed by Michael Catanzaro.
1939
1940         Add a test for the new API.
1941
1942         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1943         (testsJSCOptions):
1944         (main):
1945
1946 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1947
1948         [GTK][WPE] Support JPEG 2000 images
1949         https://bugs.webkit.org/show_bug.cgi?id=186272
1950
1951         Reviewed by Žan Doberšek.
1952
1953         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
1954
1955         * gtk/jhbuild.modules:
1956         * wpe/jhbuild.modules:
1957
1958 2019-01-23  David Kilzer  <ddkilzer@apple.com>
1959
1960         check-webkit-style should warn when using soft-linking macros in a header
1961         <https://webkit.org/b/193750>
1962
1963         Reviewed by Darin Adler.
1964
1965         * Scripts/webkitpy/style/checkers/cpp.py:
1966         (check_language): Add softlink/header check by refactoring the
1967         softlink/framework check.
1968         (CppChecker): Enable softlink/header check by default.
1969         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1970         (CppStyleTest.test_softlink_framework): Rename from
1971         CppStyleTest.test_softlink() and change test framework name in
1972         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
1973         files. Set file_name for macros that only appear in headers.
1974         (CppStyleTest.test_softlink_header): Add tests for using
1975         soft-link macros in headers.
1976
1977 2019-01-23  Chris Dumez  <cdumez@apple.com>
1978
1979         Deprecate API to limit the maximum number of WebProcesses
1980         https://bugs.webkit.org/show_bug.cgi?id=193725
1981         <rdar://problem/47464879>
1982
1983         Reviewed by Geoff Garen.
1984
1985         Update existing API tests to stop using deprecated API.
1986
1987         * MiniBrowser/mac/AppDelegate.m:
1988         (defaultConfiguration):
1989         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1990         (TestWebKitAPI::TEST):
1991         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
1992         (TestWebKitAPI::TEST):
1993         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1994         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1995         (TEST):
1996         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1997         (TEST):
1998
1999 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2000
2001         [ews-app] Rename ews model buildermappings to buildermapping
2002         https://bugs.webkit.org/show_bug.cgi?id=193729
2003
2004         Reviewed by Lucas Forschler.
2005
2006         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2007         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2008         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2009
2010 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2011
2012         [ews-app] Rename ews model steps to step
2013         https://bugs.webkit.org/show_bug.cgi?id=193697
2014
2015         Reviewed by Lucas Forschler.
2016
2017         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2018         (Step): Renamed Steps to Step.
2019
2020 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2021
2022         Clean up IndexedDB files between tests
2023         https://bugs.webkit.org/show_bug.cgi?id=192796
2024         <rdar://problem/46824999>
2025
2026         Reviewed by Geoffrey Garen.
2027
2028         * DumpRenderTree/mac/DumpRenderTree.mm:
2029         (runTest):
2030         * WebKitTestRunner/TestController.cpp:
2031         (WTR::TestController::resetStateToConsistentValues):
2032         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2033         (WTR::RemoveAllIndexedDatabasesCallback):
2034         (WTR::TestController::ClearIndexedDatabases):
2035         * WebKitTestRunner/TestController.h:
2036         * WebKitTestRunner/TestInvocation.cpp:
2037         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2038
2039 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2040
2041         [ews-app] Rename ews model Builds to Build
2042         https://bugs.webkit.org/show_bug.cgi?id=193695
2043
2044         Reviewed by Lucas Forschler.
2045
2046         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2047         (Build): Renamed Builds to Build.
2048
2049 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2050
2051         webkitpy: Wait longer when launching WebKitTestRunner
2052         https://bugs.webkit.org/show_bug.cgi?id=193734
2053
2054         Reviewed by Aakash Jain.
2055
2056         * Scripts/webkitpy/port/simulator_process.py:
2057         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2058
2059 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2060
2061         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2062         https://bugs.webkit.org/show_bug.cgi?id=193182
2063         <rdar://problem/47452154>
2064
2065         Reviewed by Tim Horton.
2066
2067         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2068         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2069         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2070
2071         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2072         preventing later tests from recognizing gestures.
2073
2074         * WebKitTestRunner/ios/TestControllerIOS.mm:
2075         (WTR::TestController::platformResetStateToConsistentValues):
2076
2077         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2078
2079 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2080
2081         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2082         https://bugs.webkit.org/show_bug.cgi?id=193722
2083         <rdar://problem/47481475>
2084
2085         Reviewed by Lucas Forschler.
2086
2087         iPhone and iPad ports should both use the iOS config.
2088
2089         * Scripts/webkitpy/port/ios_simulator.py:
2090         (IPhoneSimulatorPort.__init__):
2091         (IPadSimulatorPort.__init__):
2092
2093 2019-01-23  Rob Buis  <rbuis@igalia.com>
2094
2095         Update MIME type parser
2096         https://bugs.webkit.org/show_bug.cgi?id=180526
2097
2098         Reviewed by Frédéric Wang.
2099
2100         Add unit tests for both parse modes of ParsedContentType.
2101
2102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2103         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2104         (TestWebKitAPI::TEST):
2105
2106 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2107
2108         [ews-app] fetch loop should not stop on network issues
2109         https://bugs.webkit.org/show_bug.cgi?id=193666
2110
2111         Reviewed by Lucas Forschler.
2112
2113         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2114         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2115
2116 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2117
2118         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2119         https://bugs.webkit.org/show_bug.cgi?id=189165
2120         <rdar://problem/47433765>
2121
2122         Reviewed by Tim Horton.
2123
2124         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2125         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2126         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2127         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2128         would make its way to the UI process by the time the layer tree commit is finished.
2129
2130         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2131         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2132         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2133         will fail because it asks for -_autofillContext too early.
2134
2135         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2136         is handled in the UI process.
2137
2138         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2139
2140         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2141         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2142         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2143         input session.
2144
2145         (-[AutofillTestView textInputHasAutofillContext]):
2146
2147         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2148
2149         * TestWebKitAPI/cocoa/TestWKWebView.h:
2150         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2151         (nextInputSessionChangeCount):
2152
2153         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2154         This includes changing the focused element from one to another.
2155
2156         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2157         (-[TestWKWebView didStartFormControlInteraction]):
2158         (-[TestWKWebView didEndFormControlInteraction]):
2159         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2160
2161         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2162         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2163         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2164         that doesn't require an input session to one that doesn't.
2165
2166 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2167
2168         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2169         <https://webkit.org/b/193676>
2170
2171         Reviewed by Alexey Proskuryakov.
2172
2173         * Scripts/webkitpy/style/checkers/cpp.py:
2174         (check_member_initialization_list):
2175         - Don't report missing whitespace around colon if the colon at
2176           the start of the line is formatted correctly.
2177         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2178         (WebKitStyleTest.test_member_initialization_list):
2179         - Add a test for a missing permutation of existing tests.
2180         - Add a test this false-positive.
2181         - Add blank lines between subtests to make them easier to read.
2182
2183 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2184
2185         [build.webkit.org] Unit-test failure after r237113
2186         https://bugs.webkit.org/show_bug.cgi?id=193669
2187
2188         Reviewed by Michael Catanzaro.
2189
2190         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2191         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2192         multiple or zero flags.
2193
2194 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2195
2196         Cache bytecode to disk
2197         https://bugs.webkit.org/show_bug.cgi?id=192782
2198         <rdar://problem/46084932>
2199
2200         Reviewed by Keith Miller.
2201
2202         Add test helper to execute bytecode-cache tests: it executes each test
2203         twice, the first with JSC_diskCachePath set to a temporary directory
2204         and second with JSC_forceDiskCache=true (in addition to the cache path)
2205         to guarantee that only the disk cache is being used and no new
2206         UnlinkedCodeBlocks are being created.
2207
2208         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2209         * Scripts/run-jsc-stress-tests:
2210
2211 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2212
2213         [css-logical] Implement flow-relative margin, padding and border shorthands
2214         https://bugs.webkit.org/show_bug.cgi?id=188697
2215
2216         Reviewed by Simon Fraser and Antti Koivisto.
2217
2218         * DumpRenderTree/TestOptions.cpp:
2219         (TestOptions::TestOptions):
2220         * DumpRenderTree/TestOptions.h:
2221         * DumpRenderTree/mac/DumpRenderTree.mm:
2222         (setWebPreferencesForTestOptions):
2223         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2224
2225         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2226         (JSONCSSPropertiesChecker.check_codegen_properties):
2227         Allow CSS property definitions to have a 'runtime-flag' parameter which
2228         disables the property when the specified runtime flag is disabled.
2229
2230 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2231
2232         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2233         https://bugs.webkit.org/show_bug.cgi?id=193643
2234
2235         Reviewed by Michael Catanzaro.
2236
2237         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2238         * wpe/jhbuild.modules: Ditto.
2239
2240 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2241
2242         [LFC][Floats] Take float top position into account when computing containing block height.
2243         https://bugs.webkit.org/show_bug.cgi?id=193655
2244
2245         Reviewed by Antti Koivisto.
2246
2247         * LayoutReloaded/misc/LFC-passing-tests.txt:
2248
2249 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2250
2251         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2252         <https://webkit.org/b/193645>
2253         <rdar://problem/47421574>
2254
2255         Reviewed by Alex Christensen.
2256
2257         - Now checks for local soft-linking of all frameworks that have
2258           their own *SoftLinking.{cpp,h,mm} files.
2259         - Changes softlink/uikit warning to softlink/framework.
2260
2261         * Scripts/webkitpy/style/checkers/cpp.py:
2262         (check_language):
2263         (CppChecker):
2264         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2265         (CppStyleTest):
2266
2267 2019-01-20  Saam Barati  <sbarati@apple.com>
2268
2269         Rollout r240210: It broke tests on iOS
2270         https://bugs.webkit.org/show_bug.cgi?id=193640
2271
2272         Unreviewed.
2273
2274         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2275         * Scripts/run-jsc-stress-tests:
2276
2277 2019-01-20  chris fleizach  <cfleizach@apple.com>
2278
2279         AX: Support returning relative frames for accessibility
2280         https://bugs.webkit.org/show_bug.cgi?id=193414
2281         <rdar://problem/47268501>
2282
2283         Reviewed by Zalan Bujtas.
2284
2285         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2286         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2287         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2288         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2289         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2290         (WTR::attributesOfElement):
2291         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2292
2293 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2294
2295         Unreviewed, add my new email address
2296
2297         * Scripts/webkitpy/common/config/contributors.json:
2298
2299 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2300
2301         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2302         https://bugs.webkit.org/show_bug.cgi?id=193617
2303
2304         Reviewed by Antti Koivisto.
2305
2306         * LayoutReloaded/misc/LFC-passing-tests.txt:
2307
2308 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2309
2310         Unreviewed, rolling out r240209.
2311
2312         Broke GTK/WPE injected bundle
2313
2314         Reverted changeset:
2315
2316         "AX: Support returning relative frames for accessibility"
2317         https://bugs.webkit.org/show_bug.cgi?id=193414
2318         https://trac.webkit.org/changeset/240209
2319
2320 2019-01-12  Dan Bernstein  <mitz@apple.com>
2321
2322         [Cocoa] Avoid importing directly from subumbrella frameworks
2323         https://bugs.webkit.org/show_bug.cgi?id=186016
2324         <rdar://problem/40591038>
2325
2326         Reviewed by Sam Weinig.
2327
2328         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2329           LaunchServices header.
2330         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2331           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2332         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2333           when using SDKs earlier than 10.13.
2334         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2335           and OTHER_CPLUSPLUSFLAGS.
2336         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2337           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2338         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2339           LaunchServices header.
2340
2341 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2342
2343         Cache bytecode to disk
2344         https://bugs.webkit.org/show_bug.cgi?id=192782
2345         <rdar://problem/46084932>
2346
2347         Reviewed by Keith Miller.
2348
2349         Add test helper to execute bytecode-cache tests: it executes each test
2350         twice, the first with JSC_diskCachePath set to a temporary directory
2351         and second with JSC_forceDiskCache=true (in addition to the cache path)
2352         to guarantee that only the disk cache is being used and no new
2353         UnlinkedCodeBlocks are being created.
2354
2355         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2356         * Scripts/run-jsc-stress-tests:
2357
2358 2019-01-20  chris fleizach  <cfleizach@apple.com>
2359
2360         AX: Support returning relative frames for accessibility
2361         https://bugs.webkit.org/show_bug.cgi?id=193414
2362         <rdar://problem/47268501>
2363
2364         Reviewed by Zalan Bujtas.
2365
2366         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2367         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2368         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2369         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2370         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2371         (WTR::attributesOfElement):
2372         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2373
2374 2019-01-20  Antoine Quint  <graouts@apple.com>
2375
2376         Add a POINTER_EVENTS feature flag
2377         https://bugs.webkit.org/show_bug.cgi?id=193577
2378         <rdar://problem/47408511>
2379
2380         Unreviewed. Also enable Pointer Events for iosmac.
2381
2382         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2383
2384 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2385
2386         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2387         https://bugs.webkit.org/show_bug.cgi?id=193613
2388
2389         Reviewed by Antti Koivisto.
2390
2391         * LayoutReloaded/misc/LFC-passing-tests.txt:
2392
2393 2019-01-19  Antoine Quint  <graouts@apple.com>
2394
2395         Add a POINTER_EVENTS feature flag
2396         https://bugs.webkit.org/show_bug.cgi?id=193577
2397
2398         Reviewed by Dean Jackson.
2399
2400         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2401
2402 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2403
2404         Disable the run-jsc-stress-test remote host key check [second round].
2405         https://bugs.webkit.org/show_bug.cgi?id=192988
2406
2407         Reviewed by Dewei Zhu.
2408
2409         * Scripts/run-jsc-stress-tests:
2410
2411 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2412
2413         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2414         https://bugs.webkit.org/show_bug.cgi?id=193597
2415
2416         Reviewed by Lucas Forschler.
2417
2418         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2419
2420 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2421
2422         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2423         https://bugs.webkit.org/show_bug.cgi?id=193595
2424
2425         Reviewed by Lucas Forschler.
2426
2427         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2428         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2429         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2430
2431 2019-01-18  Chris Dumez  <cdumez@apple.com>
2432
2433         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2434         https://bugs.webkit.org/show_bug.cgi?id=193588
2435         <rdar://problem/47131566>
2436
2437         Reviewed by Alex Christensen.
2438
2439         Add layout test coverage.
2440
2441         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2442
2443 2019-01-18  Jer Noble  <jer.noble@apple.com>
2444
2445         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2446         https://bugs.webkit.org/show_bug.cgi?id=189553
2447
2448         Reviewed by Tim Horton.
2449
2450         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2451
2452         * ContentExtensionTester/Configurations/Base.xcconfig:
2453         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2454         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2455         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2456         * ImageDiff/cg/Configurations/Base.xcconfig:
2457         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2458         * MiniBrowser/Configurations/Base.xcconfig:
2459         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2460         * MobileMiniBrowser/Configurations/Base.xcconfig:
2461         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2462         * Scripts/webkitpy/style/checker.py:
2463         (_all_categories):
2464         (FileType):
2465         (CheckerDispatcher._file_type):
2466         (CheckerDispatcher._create_checker):
2467         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2468         (SDKVariantChecker):
2469         (SDKVariantChecker.__init__):
2470         (SDKVariantChecker.check):
2471         * TestWebKitAPI/Configurations/Base.xcconfig:
2472         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2473         * WebEditingTester/Configurations/Base.xcconfig:
2474         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2475         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2476         * WebKitTestRunner/Configurations/Base.xcconfig:
2477         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2478         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2479         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2480
2481 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2482
2483         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2484         <https://webkit.org/b/193568>
2485         <rdar://problem/47381130>
2486
2487         Reviewed by Alex Christensen.
2488
2489         Make sure no one re-introduces UIKit soft-linking by adding a
2490         style rule.
2491
2492         * Scripts/webkitpy/style/checkers/cpp.py:
2493         (check_language): Add softlink/uikit check.
2494         (CppChecker): Enable softlink/uikit check.
2495         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2496         (CppStyleTest): Add test for softlink/uikit.
2497
2498 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2499
2500         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2501         https://bugs.webkit.org/show_bug.cgi?id=193584
2502
2503         Change "-dev" to "-devel".
2504
2505         Reviewed by Michael Catanzaro.
2506
2507         * gtk/install-dependencies:
2508
2509 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2510
2511         webkitpy: Add iPhone and iPad ports
2512         https://bugs.webkit.org/show_bug.cgi?id=193537
2513         <rdar://problem/47353390>
2514
2515         Reviewed by Lucas Forschler.
2516
2517         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2518         ports. Note that this separation is optional, the --ios-simulator command remains.
2519
2520         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2521         (RunTest.test_device_type_test_division): Drive-by fix.
2522         (RunTest.test_device_type_specific_listing): Ditto.
2523         (RunTest.test_ipad_test_division):
2524         (RunTest):
2525         (RunTest.test_ipad_listing):
2526         * Scripts/webkitpy/port/factory.py:
2527         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2528         (PortFactory):
2529         * Scripts/webkitpy/port/ios_simulator.py:
2530         (IPhoneSimulatorPort):
2531         (IPadSimulatorPort):
2532
2533 2019-01-18  Chris Dumez  <cdumez@apple.com>
2534
2535         Regression(PSON) Scroll position is not always restored properly when navigating back
2536         https://bugs.webkit.org/show_bug.cgi?id=193578
2537         <rdar://problem/47386331>
2538
2539         Reviewed by Tim Horton.
2540
2541         Add API test coverage.
2542
2543         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2544
2545 2019-01-18  Youenn Fablet  <youenn@apple.com>
2546
2547         Add a new SPI to request for cache storage quota increase
2548         https://bugs.webkit.org/show_bug.cgi?id=193323
2549
2550         Reviewed by Alex Christensen.
2551
2552         Implement WebsiteDataStore quota delegate to handle quota requests.
2553         By default, do not update quota.
2554         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2555
2556         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2557         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2558         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2559         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2560         * WebKitTestRunner/TestController.cpp:
2561         (WTR::TestController::allowCacheStorageQuotaIncrease):
2562         * WebKitTestRunner/TestController.h:
2563         * WebKitTestRunner/TestInvocation.cpp:
2564         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2565         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2566         (-[CacheStorageQuotaManager init]):
2567         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2568         (WTR::initializeWebViewConfiguration):
2569         (WTR::TestController::cocoaResetStateToConsistentValues):
2570         (WTR::TestController::allowCacheStorageQuotaIncrease):
2571
2572 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2573
2574         [ews-build] Pass owner to the triggered builds
2575         https://bugs.webkit.org/show_bug.cgi?id=193574
2576
2577         Reviewed by Lucas Forschler.
2578
2579         * BuildSlaveSupport/ews-build/factories.py:
2580         (BuildFactory.propertiesToPassToTriggers):
2581
2582 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2583
2584         [ews-app] Send patch author as a build property
2585         https://bugs.webkit.org/show_bug.cgi?id=193560
2586
2587         Reviewed by Lucas Forschler.
2588
2589         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2590         (BugzillaPatchFetcher.fetch):
2591
2592 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2593
2594         webkitpy: Implement device type specific expected results (Follow-up fix)
2595         https://bugs.webkit.org/show_bug.cgi?id=192162
2596         <rdar://problem/46345449>
2597
2598         Unreviewed infrastructure fix.
2599
2600         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2601         (Manager.run): Don't boot a device if no tests are available to run on it.
2602
2603 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2604
2605         webkitpy: Implement device type specific expected results (Follow-up fix)
2606         https://bugs.webkit.org/show_bug.cgi?id=192162
2607         <rdar://problem/46345449>
2608
2609         Unreviewed infrastructure fix.
2610
2611         * Scripts/webkitpy/api_tests/manager.py:
2612         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2613
2614 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2615
2616         webkitpy: Implement device type specific expected results (Part 2)
2617         https://bugs.webkit.org/show_bug.cgi?id=192162
2618         <rdar://problem/46345449>
2619
2620         Rubber-stamped by Aakash Jain.
2621
2622         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2623         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2624         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2625
2626         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2627         (LayoutTestFinder.find_tests): Pass device_type through.
2628         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2629         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2630         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2631         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2632         (Manager._collect_tests): Pass device type to test finder.
2633         (Manager._needs_web_platform_test):
2634         (Manager._prepare_lists): Index _expectations by device type.
2635         (Manager._test_input_for_file):
2636         (Manager._test_is_slow): Ditto.
2637         (Manager._test_should_dump_jsconsolelog_in_stderr):
2638         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2639         (Manager._get_test_inputs):
2640         (Manager._update_worker_count):
2641         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2642         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2643         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2644         the one which runs the test.
2645         (Manager._run_test_subset):
2646         (Manager._run_tests): Index _expectations by current_device_type.
2647         (Manager._print_expectation_line_for_test): Ditto.
2648         (Manager._print_expectations_for_subset): Ditto.
2649         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2650         Unlike run, this function will behave the same regardless of what devices are available.
2651         (Manager._custom_device_for_test): Deleted.
2652         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2653         (ManagerTest.test_uses_custom_device): Deleted.
2654         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2655         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2656         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2657         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2658         all of the expectations.
2659         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2660         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2661         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2662         (TestExpectations.__init__): Allow device_type to be passed through.
2663         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2664         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2665         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2666         (summarize_results):
2667         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2668         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2669         a test ran with, one must check all expectations to find the first non-skip expectation.
2670         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2671         (RunTest.test_device_type_test_division):
2672         (RunTest):
2673         (RunTest.test_device_type_specific_listing):
2674         * Scripts/webkitpy/port/base.py:
2675         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2676         (Port.supported_device_types): The result of this function will change based on what devices are available.
2677         * Scripts/webkitpy/port/device_port.py:
2678         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2679         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2680         can be used.
2681         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2682         any, or the DEFAULT_DEVICE_TYPES of the port.
2683         * Scripts/webkitpy/port/ios.py:
2684         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2685         * Scripts/webkitpy/port/ios_simulator.py:
2686         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2687         * Scripts/webkitpy/port/watch.py:
2688         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2689         * Scripts/webkitpy/port/watch_simulator.py:
2690         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2691         * Scripts/webkitpy/xcode/device_type.py:
2692         (DeviceType):
2693         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2694
2695 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2696
2697         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2698         https://bugs.webkit.org/show_bug.cgi?id=193575
2699
2700         Reviewed by Michael Catanzaro.
2701
2702         Allow the script to run without explicit port argument because
2703         it's specific to the WPE port anyway.
2704
2705         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2706         and simplify the rest of the code accordingly.
2707
2708 2019-01-18  Charlie Turner  <cturner@igalia.com>
2709
2710         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2711         https://bugs.webkit.org/show_bug.cgi?id=192229
2712
2713         Reviewed by Xabier Rodriguez-Calvar.
2714
2715         * MiniBrowser/wpe/main.cpp:
2716         (main): Enable encrypted-media by default.
2717
2718 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2719
2720         [Flatpak] Missing KeyboardInterrupt exception handler
2721         https://bugs.webkit.org/show_bug.cgi?id=193570
2722
2723         Reviewed by Michael Catanzaro.
2724
2725         * flatpak/flatpakutils.py:
2726         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2727
2728 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2729
2730         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2731         https://bugs.webkit.org/show_bug.cgi?id=193564
2732
2733         Reviewed by Antti Koivisto.
2734
2735         * LayoutReloaded/misc/LFC-passing-tests.txt:
2736
2737 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2738
2739         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2740         https://bugs.webkit.org/show_bug.cgi?id=193562
2741
2742         Reviewed by Antti Koivisto.
2743
2744         * LayoutReloaded/misc/LFC-passing-tests.txt:
2745
2746 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2747
2748         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2749         https://bugs.webkit.org/show_bug.cgi?id=193555
2750
2751         Reviewed by Antti Koivisto.
2752
2753         * LayoutReloaded/misc/LFC-passing-tests.txt:
2754
2755 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2756
2757         [WPE] Add Qt extension
2758         https://bugs.webkit.org/show_bug.cgi?id=191464
2759
2760         Reviewed by Carlos Garcia Campos.
2761
2762         MiniBrowser and API tests for the WPE Qt API. To run the
2763         MiniBrowser a new script is introduced. Example invocation:
2764
2765         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2766
2767         Also note-worthy is the introduction of the python2-subprocess32
2768         dependency to run the GLib API tests.
2769
2770         * MiniBrowser/wpe/CMakeLists.txt:
2771         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2772         * MiniBrowser/wpe/qt/main.cpp: Added.
2773         (main):
2774         * MiniBrowser/wpe/qt/main.qml: Added.
2775         * MiniBrowser/wpe/qt/qml.qrc: Added.
2776         * Scripts/run-gtk-tests:
2777         (GtkTestRunner.is_google_test):
2778         (GtkTestRunner):
2779         (GtkTestRunner.is_qt_test):
2780         * Scripts/run-qt-wpe-minibrowser: Added.
2781         * Scripts/run-wpe-tests:
2782         (WPETestRunner):
2783         (WPETestRunner.is_google_test):
2784         (WPETestRunner.is_qt_test):
2785         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2786         (TestLoad::main):
2787         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2788         (TestLoadHtml::main):
2789         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2790         (TestLoadRequest::main):
2791         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2792         (TestRunJavaScript::main):
2793         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2794         (waitForSignal):
2795         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2796         (LoadSpy::LoadSpy):
2797         (LoadSpy::~LoadSpy):
2798         (LoadSpy::onLoadingChanged):
2799         (LoadStartedCatcher::LoadStartedCatcher):
2800         (LoadStartedCatcher::~LoadStartedCatcher):
2801         (LoadStartedCatcher::onLoadingChanged):
2802         (waitForLoadSucceeded):
2803         (waitForLoadFailed):
2804         * TestWebKitAPI/glib/CMakeLists.txt:
2805         * flatpak/flatpakutils.py:
2806         (WebkitFlatpak.load_from_args):
2807         (WebkitFlatpak.__init__):
2808         (WebkitFlatpak.clean_args):
2809         (WebkitFlatpak.run_in_sandbox):
2810         * flatpak/org.webkit.CommonModules.yaml:
2811         * flatpak/org.webkit.WPE.yaml:
2812         * flatpak/org.webkit.WPEModules.yaml:
2813         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2814         * flatpak/org.webkit.WebKit.yaml:
2815         * glib/api_test_runner.py:
2816         (TestRunner._run_test_qt):
2817         (TestRunner.is_qt_test):
2818         (TestRunner._run_test):
2819
2820 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2821
2822         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2823         https://bugs.webkit.org/show_bug.cgi?id=193494
2824         <rdar://problem/46859627>
2825
2826         Reviewed by Simon Fraser and Tim Horton.
2827
2828         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2829         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2830
2831         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2832         (WTR::UIScriptController::contentOffsetX const):
2833         (WTR::UIScriptController::contentOffsetY const):
2834         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2835         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2836         (WTR::UIScriptController::contentOffsetX const):
2837         (WTR::UIScriptController::contentOffsetY const):
2838         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2839
2840         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2841
2842         * WebKitTestRunner/TestController.cpp:
2843         (WTR::updateTestOptionsFromTestHeader):
2844         * WebKitTestRunner/TestOptions.h:
2845         (WTR::TestOptions::hasSameInitializationOptions const):
2846         * WebKitTestRunner/ios/TestControllerIOS.mm:
2847         (WTR::TestController::platformResetStateToConsistentValues):
2848         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2849         (WTR::UIScriptController::contentOffsetX const):
2850         (WTR::UIScriptController::contentOffsetY const):
2851
2852 2019-01-17  Truitt Savell  <tsavell@apple.com>
2853
2854         Unreviewed, rolling out r240124.
2855
2856         This commit broke an internal build.
2857
2858         Reverted changeset:
2859
2860         "SDK_VARIANT build destinations should be separate from non-
2861         SDK_VARIANT builds"
2862         https://bugs.webkit.org/show_bug.cgi?id=189553
2863         https://trac.webkit.org/changeset/240124
2864
2865 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2866
2867         Fix string concatenation API test after r239920
2868         https://bugs.webkit.org/show_bug.cgi?id=193551
2869         <rdar://problem/47359304>
2870
2871         Reviewed by Youenn Fablet.
2872
2873         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2874         (TestWebKitAPI::TEST):
2875         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2876         in WebKit's build configuration like it apparently is on Linux.
2877
2878 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2879
2880         [ews-build] validate-patch should handle the case when bug_id is None
2881         https://bugs.webkit.org/show_bug.cgi?id=193547
2882
2883         Reviewed by Lucas Forschler.
2884
2885         * BuildSlaveSupport/ews-build/steps.py:
2886         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2887         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2888
2889 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2890
2891         [ews-build] Add patch author information in build
2892         https://bugs.webkit.org/show_bug.cgi?id=193465
2893
2894         Reviewed by Lucas Forschler.
2895
2896         * BuildSlaveSupport/ews-build/steps.py:
2897         (ValidatePatch._is_patch_obsolete):
2898
2899 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2900
2901         [ews-build] Pass bug_id to the triggered builds
2902         https://bugs.webkit.org/show_bug.cgi?id=193548
2903
2904         Reviewed by Lucas Forschler.
2905
2906         * BuildSlaveSupport/ews-build/factories.py:
2907         (BuildFactory.propertiesToPassToTriggers):
2908
2909 2019-01-17  Jer Noble  <jer.noble@apple.com>
2910
2911         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2912         https://bugs.webkit.org/show_bug.cgi?id=189553
2913
2914         Reviewed by Tim Horton.
2915
2916         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2917
2918         * ContentExtensionTester/Configurations/Base.xcconfig:
2919         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2920         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2921         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2922         * ImageDiff/cg/Configurations/Base.xcconfig:
2923         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2924         * MiniBrowser/Configurations/Base.xcconfig:
2925         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2926         * MobileMiniBrowser/Configurations/Base.xcconfig:
2927         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2928         * Scripts/webkitpy/style/checker.py:
2929         (_all_categories):
2930         (FileType):
2931         (CheckerDispatcher._file_type):
2932         (CheckerDispatcher._create_checker):
2933         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2934         (SDKVariantChecker):
2935         (SDKVariantChecker.__init__):
2936         (SDKVariantChecker.check):
2937         * TestWebKitAPI/Configurations/Base.xcconfig:
2938         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2939         * WebEditingTester/Configurations/Base.xcconfig:
2940         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2941         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2942         * WebKitTestRunner/Configurations/Base.xcconfig:
2943         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2944         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2945         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2946
2947 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2948
2949         [LFC][BFC] An element with transform is a containing block for positioned descendants.
2950         https://bugs.webkit.org/show_bug.cgi?id=193534
2951
2952         Reviewed by Antti Koivisto.
2953
2954         * LayoutReloaded/misc/LFC-passing-tests.txt:
2955
2956 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2957
2958         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
2959         https://bugs.webkit.org/show_bug.cgi?id=193528
2960
2961         Reviewed by Antti Koivisto.
2962
2963         * LayoutReloaded/misc/LFC-passing-tests.txt:
2964
2965 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2966
2967         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
2968         https://bugs.webkit.org/show_bug.cgi?id=193520
2969
2970         Reviewed by Antti Koivisto.
2971
2972         * LayoutReloaded/misc/LFC-passing-tests.txt:
2973
2974 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2975
2976         [ews-build] unapply-patch step should not update source
2977         https://bugs.webkit.org/show_bug.cgi?id=193234
2978
2979         Reviewed by Lucas Forschler.
2980
2981         * BuildSlaveSupport/ews-build/steps.py:
2982         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
2983         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
2984
2985 2019-01-16  Youenn Fablet  <youenn@apple.com>
2986
2987         Add a new SPI for controlling getUserMedia
2988         https://bugs.webkit.org/show_bug.cgi?id=192793
2989
2990         Reviewed by Eric Carlson.
2991
2992         * MiniBrowser/mac/WK2BrowserWindowController.m:
2993         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
2994         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2995         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2996         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2997         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2998         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2999         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3000         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3001         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3002         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3003         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3004         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3005         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3006         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3007
3008 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3009
3010         [LFC][BFC] Inflow non-replaced used width should not be negative.
3011         https://bugs.webkit.org/show_bug.cgi?id=193495
3012
3013         Reviewed by Antti Koivisto.
3014
3015         * LayoutReloaded/misc/LFC-passing-tests.txt:
3016
3017 2019-01-16  Chris Dumez  <cdumez@apple.com>
3018
3019         Regression(PSON) View becomes blank after click a cross-site download link
3020         https://bugs.webkit.org/show_bug.cgi?id=193361
3021         <rdar://problem/47099573>
3022
3023         Reviewed by Geoffrey Garen.
3024
3025         Add API test coverage.
3026
3027         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3028         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3029
3030 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3031
3032         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3033         https://bugs.webkit.org/show_bug.cgi?id=193470
3034
3035         Reviewed by Antti Koivisto.
3036
3037         * LayoutReloaded/misc/LFC-passing-tests.txt:
3038
3039 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3040
3041         [LFC] Adjust margin box verification.
3042         https://bugs.webkit.org/show_bug.cgi?id=193482
3043
3044         Reviewed by Antti Koivisto.
3045
3046         * LayoutReloaded/misc/LFC-passing-tests.txt:
3047
3048 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3049
3050         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3051         https://bugs.webkit.org/show_bug.cgi?id=193451
3052
3053         Reviewed by Geoffrey Garen.
3054
3055         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3056         (TEST):
3057         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3058         (runWebsiteDataStoreCustomPaths):
3059
3060 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3061
3062         webkitpy: Support boolean simctl isAvailable
3063         https://bugs.webkit.org/show_bug.cgi?id=193472
3064         <rdar://problem/47296150>
3065
3066         Reviewed by Ryosuke Niwa.
3067
3068         * Scripts/webkitpy/xcode/simulated_device.py:
3069         (SimulatedDeviceManager._create_runtimes):
3070         (SimulatedDeviceManager._create_device_with_runtime):
3071
3072 2019-01-15  Chris Dumez  <cdumez@apple.com>
3073
3074         Unreviewed, rolling out r239993, r239995, r239997, and
3075         r239999.
3076
3077         Caused assertions under
3078         ViewGestureController::disconnectFromProcess()
3079
3080         Reverted changesets:
3081
3082         "Regression(PSON) View becomes blank after click a cross-site
3083         download link"
3084         https://bugs.webkit.org/show_bug.cgi?id=193361
3085         https://trac.webkit.org/changeset/239993
3086
3087         "Unreviewed iOS build fix after r239993."
3088         https://trac.webkit.org/changeset/239995
3089
3090         "Fix iOS build after r239993"
3091         https://bugs.webkit.org/show_bug.cgi?id=193361
3092         https://trac.webkit.org/changeset/239997
3093
3094         "Unreviewed, revert part of r239997 as it is not needed to fix
3095         the build."
3096         https://trac.webkit.org/changeset/239999
3097
3098 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3099
3100         Cannot tab out of WKWebView on macOS
3101         https://bugs.webkit.org/show_bug.cgi?id=161448
3102         <rdar://problem/28100085>
3103
3104         Reviewed by Dean Jackson.
3105
3106         Add a test that tabbing into and out of WKWebView works correctly.
3107
3108         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3109         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3110         (WebKit2_CommandBackForwardTest::SetUp):
3111         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3112         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3113         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3114         (-[FocusableView canBecomeKeyView]):
3115         (TEST):
3116         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3117         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3118         (-[OffscreenWindow initWithSize:]):
3119         (-[OffscreenWindow isKeyWindow]):
3120         (-[OffscreenWindow isVisible]):
3121         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3122         (TestWebKitAPI::PlatformWebView::initialize):
3123         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3124         (-[ActiveOffscreenWindow isVisible]): Deleted.
3125         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3126
3127 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3128
3129         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3130         https://bugs.webkit.org/show_bug.cgi?id=193459
3131
3132         Reviewed by Mark Lam.
3133
3134         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3135         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3136
3137 2019-01-15  Chris Dumez  <cdumez@apple.com>
3138
3139         Regression(PSON) View becomes blank after click a cross-site download link
3140         https://bugs.webkit.org/show_bug.cgi?id=193361
3141         <rdar://problem/47099573>
3142
3143         Reviewed by Geoff Garen.
3144
3145         Add API test coverage.
3146
3147         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3148         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3149
3150 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3151
3152         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3153         https://bugs.webkit.org/show_bug.cgi?id=193448
3154
3155         Reviewed by Antti Koivisto.
3156
3157         * LayoutReloaded/misc/LFC-passing-tests.txt:
3158
3159 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3160
3161         webkitpy: Implement device type specific expected results (Part 1)
3162         https://bugs.webkit.org/show_bug.cgi?id=192162
3163
3164         Reviewed by Lucas Forschler.
3165
3166         Device type specific expected results covers two related ideas. The first (covered by this change)
3167         is where to search for -expected.* files. The second is which tests to run based on the
3168         TestExpectations.txt file.
3169
3170         After this change, the baseline search path will be determined by the type of device running a
3171         test. Device type will be passed into any function which picks a file based on the baseline search
3172         path.
3173
3174         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3175         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3176         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3177         (Manager.run): Print baseline search path for each round of devices.
3178         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3179         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3180         (SingleTestRunner._expected_driver_output): Ditto.
3181         (SingleTestRunner._driver_input): Ditto.
3182         * Scripts/webkitpy/layout_tests/views/printing.py:
3183         (Printer.print_config): Move printing of baseline search path to a separate function.
3184         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3185         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3186         (Testprinter.test_print_config):
3187         (Testprinter.test_print_baseline_search_path):
3188         * Scripts/webkitpy/port/base.py:
3189         (Port.baseline_search_path): Pass device_type through.
3190         (Port._expected_baselines_for_suffixes): Ditto.
3191         (Port.expected_baselines): Ditto.
3192         (Port.expected_filename): Ditto.
3193         (Port.expected_checksum): Ditto.
3194         (Port.expected_image): Ditto.
3195         (Port.expected_audio): Ditto.
3196         (Port.expected_text): Ditto.
3197         (Port.reference_files): Ditto.
3198         (Port.tests): Ditto.
3199         (Port._expanded_paths): Ditto.
3200         (Port.skipped_layout_tests): Ditto.
3201         (Port.expectations_dict): Ditto.
3202         (Port._port_specific_expectations_files): Ditto.
3203         (Port.expectations_files): Ditto.
3204         (Port.test_search_path): Ditto.
3205         (Port._tests_for_other_platforms): Ditto.
3206         * Scripts/webkitpy/port/base_unittest.py:
3207         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3208         (PortTest.test_nonexistant_expectations): Ditto.
3209         (test_ref_tests_platform_directory): Ditto.
3210         * Scripts/webkitpy/port/darwin.py:
3211         (DarwinPort._port_specific_expectations_files): Accept device_type.
3212         * Scripts/webkitpy/port/driver.py:
3213         (DriverProxy):
3214         (DriverProxy.host): Expose _target_host for device_type information.
3215         * Scripts/webkitpy/port/gtk.py:
3216         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3217         * Scripts/webkitpy/port/ios.py:
3218         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3219         * Scripts/webkitpy/port/mac.py:
3220         (MacPort. default_baseline_search_path): Ditto.
3221         * Scripts/webkitpy/port/port_testcase.py:
3222         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3223         * Scripts/webkitpy/port/test.py:
3224         * Scripts/webkitpy/port/watch.py:
3225         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3226         * Scripts/webkitpy/port/win.py:
3227         (WinPort.test_search_path): Accept, but do not use, device_type.
3228         * Scripts/webkitpy/port/wpe.py:
3229         (WPEPort._port_specific_expectations_files): Ditto.
3230         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3231         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3232
3233 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3234
3235         [LFC] Use the containing block's padding box to position out-of-flow elements.
3236         https://bugs.webkit.org/show_bug.cgi?id=193431
3237
3238         Reviewed by Antti Koivisto.
3239
3240         * LayoutReloaded/misc/LFC-passing-tests.txt:
3241
3242 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3243
3244         Move a test implementation file that got misplaced in the Xcode project
3245
3246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3247
3248 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3249
3250         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3251         r239913, and r239914.
3252         https://bugs.webkit.org/show_bug.cgi?id=193407
3253
3254         These revisions caused an internal failure (Requested by
3255         Truitt on #webkit).
3256
3257         Reverted changesets:
3258
3259         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3260         https://bugs.webkit.org/show_bug.cgi?id=186016
3261         https://trac.webkit.org/changeset/239901
3262
3263         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3264         https://trac.webkit.org/changeset/239909
3265
3266         "Tried to fix the build."
3267         https://trac.webkit.org/changeset/239910
3268
3269         "Fixed iOS builds after r239910."
3270         https://trac.webkit.org/changeset/239912
3271
3272         "More build fixing."
3273         https://trac.webkit.org/changeset/239913
3274
3275         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3276         https://trac.webkit.org/changeset/239914
3277
3278 2019-01-14  Mark Lam  <mark.lam@apple.com>
3279
3280         Re-enable ability to build --cloop builds.
3281         https://bugs.webkit.org/show_bug.cgi?id=192955
3282         <rdar://problem/46882363>
3283
3284         Reviewed by Saam barati and Keith Miller.
3285
3286         The --cloop build option was being ignored this whole time since r236381.
3287         This patch makes it possible to build CLoop builds again.
3288
3289         * Scripts/build-jsc:
3290         * Scripts/webkitperl/FeatureList.pm:
3291         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3292
3293 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3294
3295         webkitpy: Expose device_type from host-like objects
3296         https://bugs.webkit.org/show_bug.cgi?id=193406
3297         <rdar://problem/47262305>
3298
3299         Reviewed by Lucas Forschler.
3300
3301         Devices should expose device_type. As a result, all host objects should
3302         provide a device_type property, even if they do not yet define a device_type.
3303
3304         * Scripts/webkitpy/common/system/systemhost.py:
3305         (SystemHost):
3306         (SystemHost.device_type):
3307         * Scripts/webkitpy/common/system/systemhost_mock.py:
3308         (MockSystemHost):
3309         (MockSystemHost.device_type):
3310         * Scripts/webkitpy/port/device.py:
3311         (Device):
3312         (Device.device_type):
3313         * Scripts/webkitpy/xcode/simulated_device.py:
3314         (SimulatedDeviceManager._find_exisiting_device_for_request):
3315         (SimulatedDeviceManager._disambiguate_device_type):
3316         (SimulatedDeviceManager._does_fulfill_request):
3317         (SimulatedDeviceManager.device_count_for_type):
3318         (SimulatedDeviceManager.initialize_devices):
3319         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3320         (test_available_devices):
3321         (test_swapping_devices):
3322
3323 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3324
3325         webkitpy: Support alternate simctl device list output (Follow-up fix)
3326         https://bugs.webkit.org/show_bug.cgi?id=193362
3327         <rdar://problem/47122965>
3328
3329         Rubber-stamped by Lucas Forschler.
3330
3331         * Scripts/webkitpy/xcode/simulated_device.py:
3332         (SimulatedDeviceManager.populate_available_devices):
3333
3334 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3335
3336         [iOS] Expose SPI to access the current sentence boundary and selection state
3337         https://bugs.webkit.org/show_bug.cgi?id=193398
3338         <rdar://problem/45893108>
3339
3340         Reviewed by Dean Jackson.
3341
3342         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3343         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3344         expected.
3345
3346         * TestWebKitAPI/EditingTestHarness.h:
3347         * TestWebKitAPI/EditingTestHarness.mm:
3348         (-[EditingTestHarness moveBackward]):
3349         (-[EditingTestHarness moveForward]):
3350         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3351
3352         Add a couple of new helper methods on EditingTestHarness.
3353
3354         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3355         (-[SelectionChangeObserver initWithWebView:]):
3356         (-[SelectionChangeObserver webView]):
3357         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3358         (-[SelectionChangeObserver currentSelectionAttributes]):
3359
3360 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3361
3362         [LFC][BFC] Add basic box-sizing support.
3363         https://bugs.webkit.org/show_bug.cgi?id=193392
3364
3365         Reviewed by Antti Koivisto.
3366
3367         * LayoutReloaded/misc/LFC-passing-tests.txt:
3368
3369 2019-01-14  Charlie Turner  <cturner@igalia.com>
3370
3371         [WPE] API test gardening
3372         https://bugs.webkit.org/show_bug.cgi?id=193319
3373
3374         Reviewed by Michael Catanzaro.
3375
3376         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3377         passing tests.
3378
3379 2019-01-14  Charlie Turner  <cturner@igalia.com>
3380
3381         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3382         https://bugs.webkit.org/show_bug.cgi?id=192977
3383
3384         Reviewed by Carlos Garcia Campos.
3385
3386         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3387         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3388         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3389         (TestWebKitAPI::GStreamerTest::SetUp):
3390         (TestWebKitAPI::GStreamerTest::TearDown):
3391         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3392         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3393         (TestWebKitAPI::TEST_F):
3394
3395 2019-01-14  Charlie Turner  <cturner@igalia.com>
3396
3397         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3398         https://bugs.webkit.org/show_bug.cgi?id=193332
3399
3400         Reviewed by Michael Catanzaro.
3401
3402         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3403         defined as a char16_t, which changed in ICU 59, the
3404         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3405         unsigned short. This test is relying on the behaviour that
3406         UChar=unsigned short, which doesn't hold across platforms and ICU
3407         library versions. The full fix would be a special syntax for
3408         literal characters so that these ambiguities do not arise. That
3409         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3410         (TestWebKitAPI::TEST):
3411
3412 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3413
3414         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3415
3416         * Scripts/make-dist:
3417         (Distcheck.configure):
3418
3419 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3420
3421         [ews-build] Update macOS queue configurations
3422         https://bugs.webkit.org/show_bug.cgi?id=193365
3423         <rdar://problem/47221073>
3424
3425         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3426
3427         * BuildSlaveSupport/ews-build/config.json:
3428
3429 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3430
3431         [LFC] Adjust assert for statically positioned fixed elements
3432         https://bugs.webkit.org/show_bug.cgi?id=193385
3433
3434         Reviewed by Antti Koivisto.
3435
3436         * LayoutReloaded/misc/LFC-passing-tests.txt:
3437
3438 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3439
3440         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3441         https://bugs.webkit.org/show_bug.cgi?id=193387
3442
3443         Reviewed by Carlos Garcia Campos.
3444
3445         * MiniBrowser/wpe/main.cpp:
3446         (main):
3447
3448 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3449
3450         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3451         https://bugs.webkit.org/show_bug.cgi?id=191655
3452         rdar://problem/46074680
3453
3454         Reviewed by Megan Gardner.
3455
3456         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3457         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3458
3459 2019-01-12  Dan Bernstein  <mitz@apple.com>
3460
3461         [Cocoa] Avoid importing directly from subumbrella frameworks
3462         https://bugs.webkit.org/show_bug.cgi?id=186016
3463         <rdar://problem/40591038>
3464
3465         Reviewed by Sam Weinig.
3466
3467         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3468           LaunchServices header.
3469         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3470           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3471         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3472           when using SDKs earlier than 10.13.
3473         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3474           and OTHER_CPLUSPLUSFLAGS.
3475         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3476           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3477         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3478           LaunchServices header.
3479
3480 2019-01-11  John Wilander  <wilander@apple.com>
3481
3482         Compile out Web API Statistics Collection
3483         https://bugs.webkit.org/show_bug.cgi?id=193370
3484         <rdar://problem/45388584>
3485
3486         Reviewed by Brent Fulgham.
3487
3488         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3489             Defined ENABLE_WEB_API_STATISTICS, off by default.
3490
3491 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3492
3493         [WPE] Add gtk-doc
3494         https://bugs.webkit.org/show_bug.cgi?id=178900
3495
3496         Reviewed by Michael Catanzaro.
3497
3498         Add Tools/gtkdoc to manifest.txt.in files.
3499         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3500
3501         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3502         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3503
3504 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3505
3506         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3507         https://bugs.webkit.org/show_bug.cgi?id=193364
3508         <rdar://problem/47214117>
3509
3510         Reviewed by Tim Horton.
3511
3512         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3513         precise, whereas dragging near the middle of the textarea does.
3514
3515         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3516         (TestWebKitAPI::TEST):
3517
3518 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3519
3520         webkitpy: Support alternate simctl device list output
3521         https://bugs.webkit.org/show_bug.cgi?id=193362
3522         <rdar://problem/47122965>
3523
3524         Reviewed by Lucas Forschler.
3525
3526         * Scripts/webkitpy/xcode/simulated_device.py:
3527         (SimulatedDeviceManager.populate_available_devices):
3528
3529 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3530
3531         [ews-build] Update macOS queue configurations
3532         https://bugs.webkit.org/show_bug.cgi?id=193365
3533
3534         Reviewed by Lucas Forschler.
3535
3536         * BuildSlaveSupport/ews-build/config.json:
3537
3538 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3539
3540         webkitpy: Incorporate device type into baseline search path
3541         https://bugs.webkit.org/show_bug.cgi?id=193356
3542         <rdar://problem/47215515>
3543
3544         Reviewed by Lucas Forschler.
3545
3546         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3547
3548         * Scripts/webkitpy/port/base.py:
3549         (Port.default_baseline_search_path): Allow device type to be passed in.
3550         * Scripts/webkitpy/port/gtk.py:
3551         (GtkPort.default_baseline_search_path): Ignore device type.
3552         * Scripts/webkitpy/port/ios.py:
3553         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3554         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3555         * Scripts/webkitpy/port/ios_device_unittest.py:
3556         (IOSDeviceTest):
3557         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3558         (IOSSimulatorTest):
3559         * Scripts/webkitpy/port/mac.py:
3560         (MacPort.default_baseline_search_path): Ignore device type.
3561         * Scripts/webkitpy/port/watch.py:
3562         (WatchPort.default_baseline_search_path): Ditto.
3563         * Scripts/webkitpy/port/win.py:
3564         (WinPort.default_baseline_search_path): Ditto.
3565         (WinCairoPort.default_baseline_search_path): Ditto.
3566         * Scripts/webkitpy/port/wpe.py:
3567         (WPEPort.default_baseline_search_path): Ditto.
3568
3569 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3570
3571         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3572         https://bugs.webkit.org/show_bug.cgi?id=193352
3573         <rdar://problem/47210736>
3574
3575         Reviewed by Lucas Forschler.
3576
3577         * Scripts/webkitpy/layout_tests/views/printing.py:
3578         (Printer.print_config): Print list on only baseline search paths which exist. 
3579         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3580         (Testprinter.test_print_config):
3581
3582 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3583
3584         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3585         https://bugs.webkit.org/show_bug.cgi?id=193340
3586
3587         Reviewed by David Kilzer.
3588
3589         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3590         (WTR::InjectedBundle::didReceiveMessageToPage):
3591         Pull the strings out into a WKRetainPtr.
3592
3593         * WebKitTestRunner/WebNotificationProvider.cpp:
3594         (WTR::WebNotificationProvider::closeWebNotification):
3595         Adopt the created value into the WKRetainPtr.
3596
3597         * WebKitTestRunner/mac/TestControllerMac.mm:
3598         (WTR::generateWhitelist):
3599         Immediately adopt a created value to avoid potential mistakes.
3600
3601 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3602
3603         Enable DFG on ARM/Linux again
3604         https://bugs.webkit.org/show_bug.cgi?id=192496
3605
3606         Reviewed by Yusuke Suzuki.
3607
3608         After changing the bytecode format DFG was disabled on all 32-bit
3609         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3610         on ARM by default.
3611
3612         * Scripts/run-jsc-stress-tests:
3613
3614 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3615
3616         Unreviewed, fix #ifdef in API test added in r239851.
3617         https://bugs.webkit.org/show_bug.cgi?id=193327
3618         rdar://problem/47093222
3619
3620         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3621
3622 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3623
3624         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3625         https://bugs.webkit.org/show_bug.cgi?id=193109
3626         <rdar://problem/44807048>
3627
3628         Reviewed by Ryosuke Niwa.
3629
3630         Introduce and respect a test option to enable the UndoManager API.
3631
3632         * WebKitTestRunner/TestController.cpp:
3633         (WTR::updateTestOptionsFromTestHeader):
3634         * WebKitTestRunner/TestOptions.h:
3635         (WTR::TestOptions::hasSameInitializationOptions const):
3636         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3637         (WTR::TestController::platformCreateWebView):
3638
3639 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3640
3641         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3642         https://bugs.webkit.org/show_bug.cgi?id=193346
3643
3644         Reviewed by Antti Koivisto.
3645
3646         * LayoutReloaded/misc/LFC-passing-tests.txt:
3647
3648 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3649
3650         Unreviewed, fix typo that breaks dashboard link.
3651
3652         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3653         (WebKitBuildbot):
3654
3655 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3656
3657         Update macOS queue configurations
3658         https://bugs.webkit.org/show_bug.cgi?id=193329
3659
3660         Reviewed by Alexey Proskuryakov.
3661
3662         * BuildSlaveSupport/build.webkit.org-config/config.json:
3663         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3664         (BubbleQueueServer):
3665         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3666         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3667         (WebKitBuildbot):
3668         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3669         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3670         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3671
3672 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3673
3674         MiniBrowser should be able to navigate to about:blank
3675         https://bugs.webkit.org/show_bug.cgi?id=193345
3676
3677         Reviewed by Simon Fraser.
3678
3679         * MiniBrowser/mac/BrowserWindowController.m:
3680         (-[BrowserWindowController addProtocolIfNecessary:]):
3681         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3682
3683         * MiniBrowser/mac/WK1BrowserWindowController.m:
3684         (-[WK1BrowserWindowController fetch:]):
3685         * MiniBrowser/mac/WK2BrowserWindowController.m:
3686         (-[WK2BrowserWindowController fetch:]):
3687         Clean up the code that uses this to match style.
3688
3689 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3690
3691         Remove MiniBrowser custom "Process Swap" menu item which does not work
3692         https://bugs.webkit.org/show_bug.cgi?id=193344
3693
3694         Reviewed by Simon Fraser.
3695
3696         There is a menu item under the Experimental menu that does work.
3697
3698         * MiniBrowser/mac/AppDelegate.m:
3699         (defaultConfiguration):
3700         * MiniBrowser/mac/SettingsController.h:
3701         * MiniBrowser/mac/SettingsController.m:
3702         (-[SettingsController _populateMenu]):
3703         (-[SettingsController validateMenuItem:]):
3704         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3705         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3706
3707 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3708
3709         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3710         https://bugs.webkit.org/show_bug.cgi?id=193327
3711         rdar://problem/47093222
3712
3713         Reviewed by Tim Horton.
3714
3715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3716         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3717         (TestWebKitAPI::didFinishNavigation):
3718         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3719         (TestWebKitAPI::TEST):
3720         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3721         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3722         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3723         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3724         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3725
3726 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3727
3728         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3729         https://bugs.webkit.org/show_bug.cgi?id=193338
3730         <rdar://problem/46664774>
3731
3732         Reviewed by David Kilzer.
3733
3734         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3735         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3736
3737 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3738
3739         Unreviewed, rolling out r239825.
3740         https://bugs.webkit.org/show_bug.cgi?id=193330
3741
3742         Broke tests on armv7/linux bots (Requested by guijemont on
3743         #webkit).
3744
3745         Reverted changeset:
3746
3747         "Enable DFG on ARM/Linux again"
3748         https://bugs.webkit.org/show_bug.cgi?id=192496
3749         https://trac.webkit.org/changeset/239825
3750
3751 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3752
3753         Disable the run-jsc-stress-test remote host key check.
3754         https://bugs.webkit.org/show_bug.cgi?id=192988
3755
3756         Reviewed by Alexey Proskuryakov.
3757
3758         * Scripts/run-jsc-stress-tests:
3759
3760 2019-01-10  John Wilander  <wilander@apple.com>
3761
3762         Override the session configuration for cookieAcceptPolicy
3763         https://bugs.webkit.org/show_bug.cgi?id=190925
3764         <rdar://problem/45497382>
3765
3766         Reviewed by Alexey Proskuryakov and Alex Christensen.
3767
3768         Test infrastructure for setting a first-party-only cookie policy.
3769
3770         * DumpRenderTree/TestRunner.cpp:
3771         (setOnlyAcceptFirstPartyCookiesCallback):
3772         (TestRunner::staticFunctions):
3773         * DumpRenderTree/TestRunner.h:
3774         * DumpRenderTree/mac/TestRunnerMac.mm:
3775         (TestRunner::setOnlyAcceptFirstPartyCookies):
3776         * DumpRenderTree/win/TestRunnerWin.cpp:
3777         (TestRunner::setOnlyAcceptFirstPartyCookies):
3778         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3779         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3780         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3781         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3782         * WebKitTestRunner/TestInvocation.cpp:
3783         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3784
3785 2019-01-09  Matt Rajca  <mrajca@apple.com>
3786
3787         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
3788         https://bugs.webkit.org/show_bug.cgi?id=193301
3789
3790         Reviewed by Jer Noble.
3791         
3792         Added API tests.
3793
3794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3795         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3796         (TEST):
3797         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
3798
3799 2019-01-10  Zalan Bujtas  <zalan@apple.com>
3800
3801         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
3802         https://bugs.webkit.org/show_bug.cgi?id=193310
3803
3804         Reviewed by Antti Koivisto.
3805
3806         * LayoutReloaded/misc/LFC-passing-tests.txt:
3807
3808 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
3809
3810         Enable DFG on ARM/Linux again
3811         https://bugs.webkit.org/show_bug.cgi?id=192496
3812
3813         Reviewed by Yusuke Suzuki.
3814
3815         After changing the bytecode format DFG was disabled on all 32-bit
3816         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3817         on ARM by default.
3818
3819         * Scripts/run-jsc-stress-tests:
3820
3821 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3822
3823         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
3824         https://bugs.webkit.org/show_bug.cgi?id=193271
3825
3826         Reviewed by Brent Fulgham.
3827
3828         BSTR is a special data structure created by SysAllocString, not a
3829         wchar_t null-terminated string.
3830
3831         * DumpRenderTree/win/TestRunnerWin.cpp:
3832         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
3833         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3834         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
3835         BSTR from wide string literals.
3836
3837 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
3838
3839         Tweak wording for build/version_check style checker error
3840         https://bugs.webkit.org/show_bug.cgi?id=193256
3841
3842         Reviewed by Tim Horton.
3843
3844         * Scripts/webkitpy/style/checkers/cpp.py:
3845         (check_os_version_checks):
3846         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3847         (WebKitStyleTest.test_os_version_checks):
3848
3849 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3850
3851         [ews-build] Add link to bug along with bug title
3852         https://bugs.webkit.org/show_bug.cgi?id=193293
3853
3854         Reviewed by Lucas Forschler.
3855
3856         * BuildSlaveSupport/ews-build/steps.py:
3857         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
3858         (ConfigureBuild.add_bug_id_url): Deleted.
3859         (ConfigureBuild.getBugURL): Deleted.
3860
3861 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3862
3863         [ews-build] Use https for ews-build server
3864         https://bugs.webkit.org/show_bug.cgi?id=193193
3865
3866         Reviewed by Lucas Forschler.
3867
3868         * BuildSlaveSupport/ews-build/steps.py:
3869
3870 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3871
3872         [ews-build] Parse and display number of style failures
3873         https://bugs.webkit.org/show_bug.cgi?id=193280
3874
3875         Reviewed by Lucas Forschler.
3876
3877         * BuildSlaveSupport/ews-build/steps.py:
3878         (CheckStyle): Use TestWithFailureCount as base class.
3879         (CheckStyle.countFailures): Count the number of style failures.
3880
3881 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3882
3883         [ews-build] use patch_id instead of ewspatchid
3884         https://bugs.webkit.org/show_bug.cgi?id=193235
3885
3886         Reviewed by Lucas Forschler.
3887
3888         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
3889         * BuildSlaveSupport/ews-build/steps.py: Ditto.
3890         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
3891
3892 2019-01-09  Zalan Bujtas  <zalan@apple.com>
3893
3894         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
3895         https://bugs.webkit.org/show_bug.cgi?id=192625
3896
3897         Reviewed by Antti Koivisto.
3898
3899         * LayoutReloaded/misc/LFC-passing-tests.txt:
3900
3901 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3902
3903         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
3904         https://bugs.webkit.org/show_bug.cgi?id=192841
3905
3906         Reviewed by Carlos Garcia Campos.
3907
3908         There are separate g_assert_*() macros for use in tests, which we use inconsistently
3909         currently. Use them always. We'll get nicer error messages now when tests fail, and the
3910         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
3911
3912         Note that the documentation of g_assert() says that it is not to be used when writing tests.
3913
3914         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3915         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3916         (WebKitWebEditorTest::testSelectionChanged):
3917         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3918         (WebKitFrameTest::testMainFrame):
3919         (WebKitFrameTest::testURI):
3920         (WebKitFrameTest::testJavaScriptContext):
3921         (WebKitFrameTest::testJavaScriptValues):
3922         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3923         (testWebViewAuthenticationRequest):
3924         (testWebViewAuthenticationLoadCancelled):
3925         (testWebViewAuthenticationFailure):
3926         (testWebViewAuthenticationStorage):
3927         (ProxyAuthenticationTest::ProxyAuthenticationTest):
3928         (testWebViewAuthenticationProxy):
3929         (testWebViewAuthenticationProxyHTTPS):
3930         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3931         (testAutomationSessionRequestSession):
3932         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3933         (testBackForwardListNavigation):
3934         (testWebKitWebViewSessionState):
3935         (testWebKitWebViewSessionStateWithFormData):
3936         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3937         (ConsoleMessageTest::consoleMessageReceivedCallback):
3938         (testWebKitConsoleMessageConsoleAPI):
3939         (testWebKitConsoleMessageJavaScriptException):
3940         (testWebKitConsoleMessageNetworkError):
3941         (testWebKitConsoleMessageSecurityError):
3942         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3943         (testCookieManagerAcceptPolicy):
3944         (testCookieManagerCookiesChanged):
3945         (testCookieManagerPersistentStorage):
3946         (testCookieManagerPersistentStorageDeleteAll):
3947         (testCookieManagerEphemeral):
3948         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
3949         (testWebKitDOMElementAutoFill):
3950         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3951         (downloadLocalFileSuccessfully):
3952         (createFileAtDestination):
3953         (testDownloadOverwriteDestinationDisallowed):
3954         (testDownloadLocalFileError):
3955         (testDownloadRemoteFile):
3956         (testDownloadRemoteFileError):
3957         (testWebViewDownloadURI):
3958         (testPolicyResponseDownload):
3959         (testPolicyResponseDownloadCancel):
3960         (testDownloadMIMEType):
3961         (contextMenuCallback):
3962         (testContextMenuDownloadActions):
3963         (testBlobDownload):
3964         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
3965         (testWebKitWebEditorSelectionChanged):
3966         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3967         (testWebKitFrameMainFrame):
3968         (testWebKitFrameURI):
3969         (testWebKitFrameJavaScriptContext):
3970         (testWebKitFrameJavaScriptValues):
3971         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3972         (LoadStopTrackingTest::loadFailed):
3973         (testWebViewTitle):
3974         (testURIRequestHTTPHeaders):
3975         (testURIRequestHTTPMethod):
3976         (testURIResponseHTTPHeaders):
3977         (testRedirectToDataURI):
3978         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3979         (testProcessPerWebView):
3980         (testWebProcessLimit):
3981         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3982         (testWebViewResources):
3983         (testWebResourceLoading):
3984         (testWebResourceSuggestedFilename):
3985         (testWebResourceGetData):
3986         (testWebResourceGetDataError):
3987         (testWebViewResourcesHistoryCache):
3988         (testWebResourceSendRequest):
3989         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3990         (testSSL):
3991         (testInsecureContent):
3992         (testTLSErrorsPolicy):
3993         (testTLSErrorsRedirect):
3994         (testTLSErrorsHTTPAuth):
3995         (testLoadFailedWithTLSErrors):
3996         (testSubresourceLoadFailedWithTLSErrors):
3997         (httpsServerCallback):
3998         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3999         (testWebViewCreateNavigationData):
4000         (testWebViewJavaScriptDialogs):
4001         (testWebViewWindowProperties):
4002         (testWebViewMouseTarget):
4003         (testWebViewFileChooserRequest):
4004         (testWebViewColorChooserRequest):
4005         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
4006         (testWebExtensionGetTitle):
4007         (testDocumentLoadedSignal):
4008         (testWebKitWebViewProcessCrashed):
4009         (testWebExtensionWindowObjectCleared):
4010         (testWebExtensionIsolatedWorld):
4011         (permissionRequestCallback):
4012         (didAssociateFormControlsCallback):
4013         (testWebExtensionFormControlsAssociated):
4014         (FormSubmissionTest::FormSubmissionTest):
4015         (FormSubmissionTest::testFormSubmissionResult):
4016         (testWebExtensionFormSubmissionSteps):
4017         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
4018         (testNotInitialized):
4019         (testClearDatabase):
4020         (testPrivateBrowsing):
4021         (testGetFavicon):
4022         (testWebViewFavicon):
4023         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
4024         (testFindControllerTextFound):
4025         (testFindControllerTextNotFound):
4026         (testFindControllerMatchCount):
4027         (testFindControllerMaxMatchCount):
4028         (testFindControllerNext):
4029         (testFindControllerPrevious):
4030         (testFindControllerCountedMatches):
4031         (testFindControllerOptions):
4032         (testFindControllerHide):
4033         (testFindControllerInstance):
4034         (testFindControllerGetters):
4035         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
4036         (testNavigationPolicy):
4037         (testResponsePolicy):
4038         (testNewWindowPolicy):
4039         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
4040         (testSecurityOriginBasicConstructor):
4041         (testSecurityOriginURIConstructor):
4042         (testSecurityOriginDefaultPort):
4043         (testSecurityOriginFileURI):
4044         (testOpaqueSecurityOrigin):
4045         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
4046         (testWebKitSettings):
4047         (testWebKitSettingsNewWithSettings):
4048         (testWebKitSettingsUserAgent):
4049         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4050         (testWebViewNewWithUserContentManager):
4051         (isStyleSheetInjectedForURLAtPath):
4052         (isScriptInjectedForURLAtPath):
4053         (testUserContentManagerInjectedStyleSheet):
4054         (testUserContentManagerInjectedScript):
4055         (UserScriptMessageTest::scriptMessageReceived):
4056         (UserScriptMessageTest::waitUntilMessageReceived):
4057         (UserScriptMessageTest::runJavaScriptFinished):
4058         (testUserContentManagerScriptMessageReceived):
4059         (testUserContentManagerScriptMessageInWorldReceived):
4060         (testUserContentManagerScriptMessageFromDOMBindings):
4061         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
4062         (testWebContextDefault):
4063         (testWebContextEphemeral):
4064         (testWebContextGetPlugins):
4065         (testWebContextURIScheme):
4066         (testWebContextSpellChecker):
4067         (testWebContextLanguages):
4068         (consoleMessageReceivedCallback):
4069         (testWebContextSecurityFileXHR):
4070         (ProxyTest::ProxyTest):
4071         (testWebContextProxySettings):
4072         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4073         (testWebViewWebContext):
4074         (testWebViewWebBackend):
4075         (testWebViewEphemeral):
4076         (testWebViewCustomCharset):
4077         (testWebViewSettings):
4078         (testWebViewRunJavaScript):
4079         (testWebViewCanShowMIMEType):
4080         (testWebViewSubmitForm):
4081         (testWebViewSave):
4082         (testWebViewPageVisibility):
4083         (testWebViewSnapshot):
4084         (testWebViewNotification):
4085         (testWebViewNotificationInitialPermissionAllowed):
4086         (testWebViewNotificationInitialPermissionDisallowed):
4087         (testWebViewIsPlayingAudio):
4088         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
4089         (WebsiteDataTest::WebsiteDataTest):
4090         (WebsiteDataTest::remove):
4091         (WebsiteDataTest::clear):
4092         (testWebsiteDataConfiguration):
4093         (testWebsiteDataEphemeral):
4094         (testWebsiteDataCache):
4095         (testWebsiteDataStorage):
4096         (testWebsiteDataDatabases):
4097         (testWebsiteDataAppcache):
4098         (testWebsiteDataCookies):
4099         (testWebsiteDataDeviceIdHashSalt):
4100         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
4101         (emitDocumentLoaded):
4102         (emitURIChanged):
4103         (sendRequestCallback):
4104         (contextMenuCallback):
4105         (consoleMessageSentCallback):
4106         (emitFormControlsAssociated):
4107         (formControlsAssociatedCallback):
4108         (emitFormSubmissionEvent):
4109         (willSubmitFormCallback):
4110         (windowObjectCleared):
4111         (methodCallCallback):
4112         (registerGResource):
4113         (webkit_web_extension_initialize_with_user_data):
4114         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
4115         (checkLeaks):
4116         (WebProcessTest::create):
4117         (runTest):
4118         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
4119         (AutocleanupsTest::testWebProcessAutocleanups):
4120         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
4121         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
4122         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
4123         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
4124         (WebKitDOMDOMWindowTest::testSignals):
4125         (WebKitDOMDOMWindowTest::testDispatchEvent):
4126         (WebKitDOMDOMWindowTest::testGetComputedStyle):
4127         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
4128         (WebKitDOMNodeFilterTest::testTreeWalker):
4129         (WebKitDOMNodeFilterTest::testNodeIterator):
4130         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
4131         (WebKitDOMNodeTest::testHierarchyNavigation):
4132         (WebKitDOMNodeTest::testInsertion):
4133         (WebKitDOMNodeTest::testTagNamesNodeList):
4134         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
4135         (WebKitDOMNodeTest::testDOMCache):
4136         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
4137         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
4138         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
4139         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
4140         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
4141         (testUIProcessAutocleanups):
4142         (testWebProcessAutocleanups):
4143         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
4144         (testContextMenuPopulateMenu):
4145         (testContextMenuDismissed):
4146         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
4147         (testWebKitDOMClientRectDivBoundingClientRectPosition):
4148         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
4149         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
4150         (testWebKitDOMDOMWindowSignals):
4151         (testWebKitDOMDOMWindowDispatchEvent):
4152         (testWebKitDOMDOMWindowGetComputedStyle):
4153         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
4154         (testWebKitDOMNodeHierarchyNavigation):
4155         (testWebKitDOMNodeInsertion):
4156         (testWebKitDOMNodeTagNamesNodeList):
4157         (testWebKitDOMNodeTagNamesHTMLCollection):
4158         (testWebKitDOMObjectCache):
4159         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
4160         (testWebKitDOMNodeFilterTreeWalker):
4161         (testWebKitDOMNodeFilterNodeIterator):
4162         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
4163         (testWebKitDOMXPathNSResolverNative):
4164         (testWebKitDOMXPathNSResolverCustom):
4165         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
4166         (testInspectorDefault):
4167         (testInspectorManualAttachDetach):
4168         (testInspectorCustomContainerDestroyed):
4169         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
4170         (startTestServer):
4171         (testInspectorServerPageList):
4172         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
4173         (OptionMenuTest::showOptionMenuCallback):
4174         (OptionMenuTest::menuCloseCallback):
4175         (OptionMenuTest::close):
4176         (OptionMenuTest::activateItem):
4177         (OptionMenuTest::selectItem):
4178         (testOptionMenuSimple):
4179         (testOptionMenuGroups):
4180         (testOptionMenuActivate):
4181         (testOptionMenuSelect):
4182         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
4183         (testPrintOperationPrintSettings):
4184         (webViewPrintCallback):
4185         (testPrintOperationPrint):
4186         (testPrintCustomWidget):
4187         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
4188         (checkAtspiAccessible):
4189         (testAtspiBasicHierarchy):
4190         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
4191         (testWebKitCheckVersion):
4192         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
4193         (testWebViewEditorCutCopyPasteNonEditable):
4194         (testWebViewEditorCutCopyPasteEditable):
4195         (testWebViewEditorSelectAllNonEditable):
4196         (testWebViewEditorSelectAllEditable):
4197         (loadContentsAndTryToCutSelection):
4198         (testWebViewEditorNonEditable):
4199         (testWebViewEditorEditable):
4200         (testWebViewEditorEditorStateTypingAttributes):
4201         (testWebViewEditorInsertImage):
4202         (testWebViewEditorCreateLink):
4203         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
4204         (loadChangedCallback):
4205         (loadFailedCallback):
4206         (loadFailedWithTLSErrorsCallback):
4207         (LoadTrackingTest::LoadTrackingTest):
4208         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4209         (registerGResource):
4210         (removeNonEmptyDirectory):
4211         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4212         (Test::adoptView):
4213         (Test::~Test):
4214         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4215         (WebKitTestBus::getOrCreateConnection):
4216         (WebKitTestBus::createProxy):
4217         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
4218         (WebKitTestServer::getWebSocketURIForPath const):
4219         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
4220         (WebViewTest::initializeWebView):
4221         (WebViewTest::loadURI):
4222         (WebViewTest::loadHtml):
4223         (WebViewTest::loadPlainText):
4224         (WebViewTest::loadBytes):
4225         (WebViewTest::loadRequest):
4226         (WebViewTest::loadAlternateHTML):
4227         (WebViewTest::goBack):
4228         (WebViewTest::goForward):
4229         (WebViewTest::goToBackForwardListItem):
4230         (resourceGetDataCallback):
4231         (WebViewTest::mainResourceData):
4232         (WebViewTest::javascriptResultToCString):
4233         (WebViewTest::javascriptResultToNumber):
4234         (WebViewTest::javascriptResultToBoolean):
4235         (WebViewTest::javascriptResultIsNull):
4236         (WebViewTest::javascriptResultIsUndefined):
4237         (onSnapshotReady):
4238         (WebViewTest::runWebProcessTest):
4239         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
4240         (WebViewTest::platformInitializeWebView):
4241         (WebViewTest::showInWindow):
4242         (WebViewTest::showInWindowAndWaitUntilMapped):
4243         (WebViewTest::mouseMoveTo):
4244         (WebViewTest::emitPopupMenuSignal):
4245         (WebViewTest::keyStroke):
4246         (WebViewTest::doMouseButtonEvent):
4247
4248 2019-01-09  Philippe Normand  <pnormand@igalia.com>
4249
4250         [WPE] API tests can't run in flatpak environment
4251         https://bugs.webkit.org/show_bug.cgi?id=193242
4252
4253         Reviewed by Michael Catanzaro.
4254
4255         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
4256         flatpakutils so that it knows which port it's dealing with.
4257         * glib/common.py: Remove build_dir globals so that subsequent
4258         calls actually take args into account.
4259         (library_build_path):
4260         (binary_build_path):
4261
4262 2019-01-08  Dean Jackson  <dino@apple.com>
4263
4264         Blob references for System Previews don't get a correct file extension
4265         https://bugs.webkit.org/show_bug.cgi?id=193268
4266         <rdar://problem/47133037>
4267
4268         Reviewed by Tim Horton.
4269
4270         New test that a Blob download of a USDZ file gets named correctly.
4271
4272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4273         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4274         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4275         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
4276         (TEST):
4277         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
4278
4279 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
4280
4281         [WebAuthN] Support U2F HID Authenticators on macOS
4282         https://bugs.webkit.org/show_bug.cgi?id=191535
4283         <rdar://problem/47102027>
4284
4285         Reviewed by Brent Fulgham.
4286
4287         This patch:
4288         1) adds support for U2F mocking mechanism;
4289         2) updates tests to reflect U2fCommandConstructor changes.
4290
4291         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
4292         (TestWebKitAPI::TEST):
4293         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
4294         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4295         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
4296
4297 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
4298
4299         [iOS] Dispatch a synthetic mousedown event prior to starting drags
4300         https://bugs.webkit.org/show_bug.cgi?id=193229
4301         <rdar://problem/46717097>
4302
4303         Reviewed by Tim Horton.
4304
4305         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
4306         prevents a drag from starting.
4307
4308         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
4309         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
4310
4311         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
4312
4313 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
4314   
4315         Layout test will generate a perf metric file to results dir.
4316         https://bugs.webkit.org/show_bug.cgi?id=192030
4317         <rdar://problem/32779516>
4318
4319         Reviewed by Aakash Jain.
4320
4321         Layout test running time will be collected to a perf metric file.
4322         For now, instead of outputing running time of all tests (which is huge),
4323         we aggregate them by test directories which are at most two level deep. 
4324
4325</