Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
2
3         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4         https://bugs.webkit.org/show_bug.cgi?id=194958
5
6         Reviewed by Geoffrey Garen.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
9         (TEST):
10
11 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
12
13         [ews-app] Update method to save build to handle builder_display_name
14         https://bugs.webkit.org/show_bug.cgi?id=195047
15
16         Reviewed by Dewei Zhu.
17
18         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
19         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
20
21 2019-02-28  Justin Fan  <justin_fan@apple.com>
22
23         [Web GPU] Enable Web GPU only on 64-bit
24         https://bugs.webkit.org/show_bug.cgi?id=195139
25
26         Because Metal is only supported on 64 bit apps.
27
28         Unreviewed build fix.
29
30         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
31
32 2019-02-27  Youenn Fablet  <youenn@apple.com>
33
34         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
35         https://bugs.webkit.org/show_bug.cgi?id=194959
36
37         Reviewed by Chris Dumez.
38
39         Spin loop until getting the condition to remove flakiness.
40
41         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
42
43 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
44
45         [ews-build] Buildbot should include builder_display_name in the build events
46         https://bugs.webkit.org/show_bug.cgi?id=195045
47
48         Reviewed by Dewei Zhu.
49
50         * BuildSlaveSupport/ews-build/events.py:
51         (Events.buildStarted): Included builder_display_name in event data. Also renamed
52         buildername to builder_name to be consistent in naming style.
53         (Events.buildFinished): Ditto.
54
55 2019-02-27  Chris Dumez  <cdumez@apple.com>
56
57         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
58         https://bugs.webkit.org/show_bug.cgi?id=194480
59
60         Reviewed by Brady Eidson.
61
62         Update existing API test to make it more likely to reproduce the issue.
63
64         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
65
66 2019-02-27  Brady Eidson  <beidson@apple.com>
67
68         Universal links from Google search results pages don't open the app.
69         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
70
71         Reviewed by Geoffrey Garen.
72
73         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
74         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
75         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
76         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
77
78 2019-02-27  Chris Dumez  <cdumez@apple.com>
79
80         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
81         https://bugs.webkit.org/show_bug.cgi?id=195102
82
83         Reviewed by Geoffrey Garen.
84
85         If the number of processes is not yet what we expect, wait a bit and check again to give
86         processes some time to exit.
87
88         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
89
90 2019-02-27  Chris Dumez  <cdumez@apple.com>
91
92         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
93         https://bugs.webkit.org/show_bug.cgi?id=194545
94
95         Reviewed by Brady Eidson.
96
97         Make sure the test navigates forward and then back only once. Previously, navigating
98         back would trigger a navigation again in a timer.
99
100         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
101
102 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
103
104         High Sierra Debug JSC test queue should use faster hardware
105         https://bugs.webkit.org/show_bug.cgi?id=194603
106
107         Rubber-stamped by Alexey Proskuryakov.
108
109         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
110
111         * BuildSlaveSupport/build.webkit.org-config/config.json:
112         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
113         (BubbleQueueServer):
114         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
115         (WebKitBuildbot):
116         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
117         * QueueStatusServer/config/queues.py:
118         * Scripts/webkitpy/common/config/ews.json:
119         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
120         (test_ews_name):
121
122 2019-02-27  John Wilander  <wilander@apple.com>
123
124         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
125         https://bugs.webkit.org/show_bug.cgi?id=195071
126         <rdar://problem/48417690>
127
128         Reviewed by Alex Christensen and Brent Fulgham.
129
130         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
131         (TestWebKitAPI::createURL):
132             Convenience function.
133         (TestWebKitAPI::TEST):
134             WebCore::AdClickAttribution now takes a URL when creating Source and
135             Destination.
136         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
137         (TestWebKitAPI::TEST):
138             WebCore::AdClickAttribution now takes a URL when creating Source and
139             Destination.
140
141 2019-02-27  Antoine Quint  <graouts@apple.com>
142
143         Support Pointer Events on macOS
144         https://bugs.webkit.org/show_bug.cgi?id=195008
145         <rdar://problem/47454419>
146
147         Reviewed by Dean Jackson.
148
149         * DumpRenderTree/mac/DumpRenderTree.mm:
150         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
151         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
152
153 2019-02-26  Mark Lam  <mark.lam@apple.com>
154
155         Remove remaining poisoning code.
156         https://bugs.webkit.org/show_bug.cgi?id=194138
157
158         Reviewed by Saam Barati.
159
160         * TestWebKitAPI/CMakeLists.txt:
161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
162         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
163         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
164         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
165         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
166         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
167         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
168
169 2019-02-26  Alex Christensen  <achristensen@webkit.org>
170
171         Move ephemeral local storage from WebProcess to UIProcess
172         https://bugs.webkit.org/show_bug.cgi?id=195074
173         <rdar://problem/47937975>
174
175         Reviewed by Geoff Garen.
176
177         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
178
179 2019-02-20  Jer Noble  <jer.noble@apple.com>
180
181         [Cocoa] Media elements will restart network buffering just before suspending
182         https://bugs.webkit.org/show_bug.cgi?id=193691
183
184         Reviewed by Eric Carlson.
185
186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
187         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
188         (TEST):
189
190 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
191
192         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
193         https://bugs.webkit.org/show_bug.cgi?id=191652
194
195         Reviewed by Alex Christensen.
196
197         Fix WinCairo MiniBrowser behavior of authentication dialog.
198
199         * MiniBrowser/win/WebKitBrowserWindow.cpp:
200         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
201
202 2019-02-26  Youenn Fablet  <youenn@apple.com>
203
204         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
205         https://bugs.webkit.org/show_bug.cgi?id=195028
206         <rdar://problem/48243733>
207
208         Reviewed by Eric Carlson.
209
210         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
211
212 2019-02-26  Philippe Normand  <pnormand@igalia.com>
213
214         [WPE] Add API for webview background color configuration
215         https://bugs.webkit.org/show_bug.cgi?id=192305
216
217         Reviewed by Michael Catanzaro.
218
219         * MiniBrowser/wpe/main.cpp:
220         (main): Add a new option to configure the webview background
221         color. Example: --bg-color=transparent.
222         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
223         (testWebViewBackgroundColor): Enable background color API tests for WPE.
224         (beforeAll): Ditto.
225
226 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
227
228         scalableNativeWebpageParameters() is not preserved on new page navigation.
229         https://bugs.webkit.org/show_bug.cgi?id=194892
230         <rdar://problem/47538280>
231
232         Reviewed by Wenson Hsieh.
233         
234         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
235
236         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
237         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
238         * DumpRenderTree/mac/UIScriptControllerMac.mm:
239         (WTR::UIScriptController::allowsViewportShrinkToFit):
240         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
241         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
242         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
243         * TestRunnerShared/UIScriptContext/UIScriptController.h:
244         * WebKitTestRunner/UIScriptControllerCocoa.mm:
245         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
246
247 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
248
249         [ews-app] Add model for handling multiple Buildbot instances
250         https://bugs.webkit.org/show_bug.cgi?id=194863
251
252         Reviewed by Stephanie Lewis.
253
254         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
255
256 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
257
258         [ews-app] Remove BuilderMapping table
259         https://bugs.webkit.org/show_bug.cgi?id=194961
260
261         Reviewed by Stephanie Lewis.
262
263         Store builder name directly in build table, instead of having a separate
264         table for it.
265
266         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
267         * BuildSlaveSupport/ews-app/ews/models/build.py:
268         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
269         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
270
271 2019-02-25  John Wilander  <wilander@apple.com>
272
273         Introduce and adopt new class RegistrableDomain for eTLD+1
274         https://bugs.webkit.org/show_bug.cgi?id=194791
275         <rdar://problem/48179240>
276
277         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
278
279         This patch adds an API test and replaces two instances of
280         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
281
282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
283         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
284         (TestWebKitAPI::TEST):
285             Changed two strings to make sure the registrable domains are still considered
286             invalid and pass the test.
287         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
288         (TestWebKitAPI::TEST):
289         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
290         (WTR::InjectedBundle::didReceiveMessageToPage):
291
292 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
293
294         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
295         https://bugs.webkit.org/show_bug.cgi?id=195001
296
297         Reviewed by Carlos Garcia Campos.
298
299         API version 1.0 always includes the functionality previously guarded with
300         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
301         unconditionally.
302
303         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
304         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
305         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
306         (WebViewTest::showInWindow): Ditto.
307         (WebViewTest::hideView): Ditto.
308         * wpe/backends/HeadlessViewBackend.cpp:
309         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
310         * wpe/backends/ViewBackend.cpp:
311         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
312         * wpe/backends/WindowViewBackend.cpp:
313         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
314         WPE_BACKEND_CHECK_VERSION().
315         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
316
317 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
318
319         [Flatpak] Add support for flatpak > 1.1.2
320         https://bugs.webkit.org/show_bug.cgi?id=194088
321
322         Flatpak 1.2 is now out so we need to support that
323         version now.
324
325         Reviewed by Michael Catanzaro.
326
327         * flatpak/flatpakutils.py:
328         (check_flatpak):
329         (FlatpakPackages.__init__):
330         (FlatpakPackages.__detect_packages):
331         (FlatpakPackages.__detect_packages.in):
332         (FlatpakRepos.update):
333
334 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
335
336         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
337         https://bugs.webkit.org/show_bug.cgi?id=194998
338
339         Reviewed by Carlos Garcia Campos.
340
341         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
342         to a Git checkout and using the latest commit containing various fixes
343         and improvements.
344
345 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
346
347         [WPE][GTK] Remove user agent quirk for washingtonpost.com
348         https://bugs.webkit.org/show_bug.cgi?id=194981
349
350         Reviewed by Žan Doberšek.
351
352         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
353         (TestWebKitAPI::TEST):
354
355 2019-02-23  Keith Miller  <keith_miller@apple.com>
356
357         Add new mac target numbers
358         https://bugs.webkit.org/show_bug.cgi?id=194955
359
360         Reviewed by Tim Horton.
361
362         * DumpRenderTree/mac/Configurations/Base.xcconfig:
363         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
364         * MiniBrowser/Configurations/Base.xcconfig:
365         * TestWebKitAPI/Configurations/Base.xcconfig:
366         * WebKitTestRunner/Configurations/Base.xcconfig:
367
368 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
369
370         [WinCairo] Enable wk1/wk2 suffix for platform search path.
371         https://bugs.webkit.org/show_bug.cgi?id=194846
372
373         Reviewed by Don Olmstead.
374
375         Added _search_paths() and _port_specific_expectations_files() for
376         WinCairoPort.
377
378         * Scripts/webkitpy/port/win.py:
379         (WinCairoPort.default_baseline_search_path):
380         (WinCairoPort):
381         (WinCairoPort._port_specific_expectations_files):
382         (WinCairoPort._search_paths):
383
384 2019-02-22  Tim Horton  <timothy_horton@apple.com>
385
386         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
387         https://bugs.webkit.org/show_bug.cgi?id=194963
388
389         Reviewed by Dean Jackson.
390
391         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
392         Do a `contains` check instead of `equals`, because in debug builds we
393         put the GraphicsLayer pointer in a prefix.
394
395 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
396
397         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
398         https://bugs.webkit.org/show_bug.cgi?id=194873
399         <rdar://problem/46701974>
400
401         Reviewed by Tim Horton.
402
403         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
404
405         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
406         (WTR::UIScriptController::menuRect const):
407         (WTR::UIScriptController::isShowingMenu const):
408         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
409         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
410         (WTR::UIScriptController::menuRect const):
411
412         Add a function to query the bounds of the callout menu in content coordinates.
413
414         (WTR::UIScriptController::isShowingMenu const):
415
416         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
417
418         * TestRunnerShared/UIScriptContext/UIScriptController.h:
419         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
420         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
421         (WTR::UIScriptController::rectForMenuAction const):
422         (WTR::UIScriptController::menuRect const):
423         (WTR::UIScriptController::isShowingMenu const):
424         (WTR::findViewInHierarchyOfType): Deleted.
425
426 2019-02-22  Chris Dumez  <cdumez@apple.com>
427
428         Regression(PSON) Unable to preview password-protected documents on iCloud.com
429         https://bugs.webkit.org/show_bug.cgi?id=194954
430         <rdar://problem/48127957>
431
432         Reviewed by Alex Christensen.
433
434         Add API test coverage.
435
436         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
437         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
438         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
439         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
440
441 2019-02-22  Chris Dumez  <cdumez@apple.com>
442
443         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
444         https://bugs.webkit.org/show_bug.cgi?id=194924
445         <rdar://problem/48216125>
446
447         Reviewed by Geoffrey Garen.
448
449         Add API test coverage.
450
451         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
452
453 2019-02-22  Chris Dumez  <cdumez@apple.com>
454
455         Unreviewed, disable API test added in r241928 on iOS.
456
457         The cache is not enabled on devices with less than 3GB of RAM.
458
459         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
460
461 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
462
463         Hardcode Visual Viewports on everywhere except iOS WK1
464         https://bugs.webkit.org/show_bug.cgi?id=194928
465
466         Reviewed by Zalan Bujtas.
467
468         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
469         change the default value of the Setting to 'true', and hardcode WebView on iOS to
470         set it to false. The setting has shipped for several years and there's no need to turn
471         it off now.
472
473         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
474         Visual Viewports are not enabled.
475         
476         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
477         that only runs in WK2
478
479         * MiniBrowser/mac/SettingsController.h:
480         * MiniBrowser/mac/SettingsController.m:
481         (-[SettingsController init]):
482         (-[SettingsController _populateMenu]):
483         (-[SettingsController validateMenuItem:]):
484         (-[SettingsController visualViewportEnabled]): Deleted.
485         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
486         * MiniBrowser/mac/WK1BrowserWindowController.m:
487         (-[WK1BrowserWindowController didChangeSettings]):
488         * MiniBrowser/mac/WK2BrowserWindowController.m:
489         (-[WK2BrowserWindowController didChangeSettings]):
490
491 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
492
493         Discard cached processes when clearing website data store
494         https://bugs.webkit.org/show_bug.cgi?id=194894
495
496         Reviewed by Chris Dumez.
497
498         Added a test case.
499
500         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
501         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
502
503 2019-02-21  Alex Christensen  <achristensen@webkit.org>
504
505         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
506         https://bugs.webkit.org/show_bug.cgi?id=194914
507         <rdar://problem/47586889>
508
509         Reviewed by Geoffrey Garen.
510
511         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
512         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
513         (TEST):
514         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
515
516 2019-02-21  David Kilzer  <ddkilzer@apple.com>
517
518         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
519         <https://webkit.org/b/194761>
520
521         Reviewed by Myles Maxfield.
522
523         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
524         (WTR::activateSystemCoreWebFonts): Log `error` to console if
525         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
526         to use ARC-compliant cast.
527         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
528         ARC-compliant cast.
529         (WTR::installFakeHelvetica): Log `error` to console if
530         CTFontManagerRegisterFontsForURL() fails, but only on supported
531         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
532         Call CFRelease() on `error` to fix the leak.  Update to use
533         ARC-compliant cast.
534         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
535         cast.
536
537 2019-02-21  Chris Dumez  <cdumez@apple.com>
538
539         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
540         https://bugs.webkit.org/show_bug.cgi?id=194481
541
542         Reviewed by Alex Christensen.
543
544         Give the processes a chance to shutdown and wait until we reached the expected number
545         of processes.
546
547         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
548
549 2019-02-21  Tim Horton  <timothy_horton@apple.com>
550
551         Fix the macOS build
552
553         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
554
555 2019-02-21  Tim Horton  <timothy_horton@apple.com>
556
557         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
558
559         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
560         I am a backwards.
561
562 2019-02-21  Tim Horton  <timothy_horton@apple.com>
563
564         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
565
566         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
567         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
568         We could force on UI-side compositing, but I feel like the test might be more
569         valuable exercising the normal path on each platform (though the original
570         bug was also UI-side specific). Though we can't validate that the overlay
571         layer was installed successfully, there are layout tests that do that.
572
573 2019-02-21  Tim Horton  <timothy_horton@apple.com>
574
575         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
576         https://bugs.webkit.org/show_bug.cgi?id=194845
577         <rdar://problem/47944579>
578
579         Reviewed by Antti Koivisto.
580
581         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
582         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
583
584 2019-02-21  Zalan Bujtas  <zalan@apple.com>
585
586         [LFC][Floats] Add support for placing formatting roots in-between floats.
587         https://bugs.webkit.org/show_bug.cgi?id=194902
588
589         Reviewed by Antti Koivisto.
590
591         * LayoutReloaded/misc/LFC-passing-tests.txt:
592
593 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
594
595         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
596         https://bugs.webkit.org/show_bug.cgi?id=194901
597
598         Unreviewed build fix.
599
600         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
601         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
602         WPEBackend-fdo-0.1 as library name.
603
604 2019-02-21  Rob Buis  <rbuis@igalia.com>
605
606         Update MIME type parser
607         https://bugs.webkit.org/show_bug.cgi?id=180526
608
609         Reviewed by Darin Adler.
610
611         Add tests involving leading and trailing whitespace, non-token
612         characters and quoted strings.
613
614         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
615         (TestWebKitAPI::TEST):
616
617 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
618
619         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
620         https://bugs.webkit.org/show_bug.cgi?id=194884
621
622         Reviewed by Michael Catanzaro.
623
624         * PlatformWin.cmake:
625
626 2019-02-20  Chris Dumez  <cdumez@apple.com>
627
628         Add API test for <rdar://problem/47471222>
629         https://bugs.webkit.org/show_bug.cgi?id=194847
630
631         Reviewed by Alex Christensen.
632
633         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
634
635 2019-02-20  Chris Dumez  <cdumez@apple.com>
636
637         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
638         https://bugs.webkit.org/show_bug.cgi?id=194872
639         <rdar://problem/47924500>
640
641         Reviewed by Alex Christensen.
642
643         Add API test coverage.
644
645         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
646
647 2019-02-20  Jer Noble  <jer.noble@apple.com>
648
649         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
650         https://bugs.webkit.org/show_bug.cgi?id=191332
651
652         Reviewed by Dean Jackson.
653
654         * Scripts/git-is-in-range: Added.
655
656 2019-02-20  Andy Estes  <aestes@apple.com>
657
658         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
659         https://bugs.webkit.org/show_bug.cgi?id=194869
660
661         Rubber-stamped by Jer Noble.
662
663         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
664         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
665         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
666         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
668         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
669
670 2019-02-20  Chris Dumez  <cdumez@apple.com>
671
672         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
673         https://bugs.webkit.org/show_bug.cgi?id=194857
674         <rdar://problem/47759323>
675
676         Reviewed by Alex Christensen.
677
678         Add API test coverage.
679
680         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
681
682 2019-02-20  Chris Dumez  <cdumez@apple.com>
683
684         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
685         https://bugs.webkit.org/show_bug.cgi?id=194829
686         <rdar://problem/47889906>
687
688         Reviewed by Alexey Proskuryakov.
689
690         Every time the TestOptions were changing we were creating both a new Web view and
691         a new WKContext, which would start a new Network process. In most cases, we only
692         need to contruct a new Web view and we do can keep reusing the same WKContext.
693         This patch implements this optimization and thus avoids spinning a lot of new
694         Network processes while running the layout tests.
695
696         * WebKitTestRunner/TestController.cpp:
697         (WTR::TestController::generateContextConfiguration const):
698         (WTR::TestController::generatePageConfiguration):
699         (WTR::TestController::createWebViewWithOptions):
700         (WTR::TestController::resetPreferencesToConsistentValues):
701         (WTR::updateTestOptionsFromTestHeader):
702         * WebKitTestRunner/TestController.h:
703         * WebKitTestRunner/TestOptions.h:
704         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
705         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
706         (WTR::TestOptions::hasSameInitializationOptions const):
707         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
708         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
709         (WTR::TestController::platformAddTestOptions const):
710
711 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
712
713         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
714         https://bugs.webkit.org/show_bug.cgi?id=167941
715
716         Reviewed by Carlos Garcia Campos.
717
718         * MiniBrowser/gtk/main.c:
719         (filterSavedCallback): Added.
720         (main): Support loading a JSON rule set file for content filtering.
721         * MiniBrowser/wpe/main.cpp:
722         (filterSavedCallback): Added.
723         (main): Support loading a JSON rule set file for content filtering.
724         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
725         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
726         (WTF::derefGPtr): Ditto.
727         (testEmptyStore):
728         (testSaveInvalidFilter):
729         (testSaveLoadFilter):
730         (testSavedFilterIdentifierMatch):
731         (testRemoveFilter):
732         (testSaveMultipleFilters):
733         (testSaveFilterFromFile):
734         (testFilterPersistence):
735         (beforeAll):
736         (afterAll):
737         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
738         (removeOldInjectedContentAndResetLists): Also reset content filters.
739         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
740         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
741         the element affected by the style sheet.
742         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
743         and returns it to be used by tests.
744         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
745         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
746         (serverCallback): Add support for serving a CSS style sheet for testing.
747         (beforeAll): Add call to testUserContentManagerContentFilter().
748         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
749
750 2019-02-19  Keith Rollin  <krollin@apple.com>
751
752         Add timing information to build output
753         https://bugs.webkit.org/show_bug.cgi?id=194839
754         <rdar://problem/48219609>
755
756         Reviewed by Alexey Proskuryakov.
757
758         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
759         emit each project's build time to its output. E.g.,
760
761             ** BUILD SUCCEEDED ** [0.132 sec]
762
763         * Scripts/webkitdirs.pm:
764         (XcodeOptions):
765
766 2019-02-19  Truitt Savell  <tsavell@apple.com>
767
768         Unreviewed, rolling out r241784.
769
770         Broke all OpenSource builds.
771
772         Reverted changeset:
773
774         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
775         instances view"
776         https://bugs.webkit.org/show_bug.cgi?id=172848
777         https://trac.webkit.org/changeset/241784
778
779 2019-02-19  Zalan Bujtas  <zalan@apple.com>
780
781         [LFC][Floats] Remove redundant intersecting logic
782         https://bugs.webkit.org/show_bug.cgi?id=194804
783
784         Reviewed by Antti Koivisto.
785
786         * LayoutReloaded/misc/LFC-passing-tests.txt:
787
788 2019-02-19  Dean Jackson  <dino@apple.com>
789
790         Clean-up output from generate-xcfilelists so it can be filtered
791         https://bugs.webkit.org/show_bug.cgi?id=194795
792
793         Reviewed by Joseph Pecoraro (and Keith Rollin).
794
795         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
796         make a slight tweak to filter-build-webkit so such lines are marked
797         as plain.
798
799         * Scripts/filter-build-webkit:
800         * Scripts/generate-xcfilelists:
801
802 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
803
804         pytest is not correctly auto-installed
805         https://bugs.webkit.org/show_bug.cgi?id=194707
806
807         Reviewed by Carlos Garcia Campos.
808
809         * Scripts/webkitpy/thirdparty/__init__.py:
810         (AutoinstallImportHook._install_pytest):
811
812 2019-02-18  Chris Dumez  <cdumez@apple.com>
813
814         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
815         https://bugs.webkit.org/show_bug.cgi?id=194797
816         <rdar://problem/48055151>
817
818         Reviewed by Geoffrey Garen.
819
820         Add API test coverage.
821
822         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
823
824 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
825
826         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
827         https://bugs.webkit.org/show_bug.cgi?id=194670
828         <rdar://problem/39066529>
829
830         Reviewed by Tim Horton.
831
832         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
833         pasted in an editable area as attachment elements.
834
835         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
836         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
837         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
838         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
839         (TestWebKitAPI::TEST):
840         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
841         (WTR::InjectedBundlePage::InjectedBundlePage):
842
843 2019-02-18  Alex Christensen  <achristensen@webkit.org>
844
845         Fix API test after r241728
846        ​https://bugs.webkit.org/show_bug.cgi?id=194723
847
848         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
849         (TEST):
850         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
851
852 2019-02-18  Daniel Bates  <dabates@apple.com>
853
854         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
855         https://bugs.webkit.org/show_bug.cgi?id=192824
856         <rdar://problem/47100332>
857
858         Reviewed by Wenson Hsieh.
859
860         Fix a bug where the wrong usage code was used for F13 thru F24.
861
862         * WebKitTestRunner/ios/HIDEventGenerator.mm:
863         (keyCodeForDOMFunctionKey):
864
865 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
866
867         Bytecode cache should a have a boot-specific validation
868         https://bugs.webkit.org/show_bug.cgi?id=194769
869         <rdar://problem/48149509>
870
871         Reviewed by Keith Miller.
872
873         Add test for WTF::bootSessionUUIDString()
874
875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
876         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
877         (TEST):
878
879 2019-02-18  Alex Christensen  <achristensen@webkit.org>
880
881         Disable safe browsing in WKWebView and remove its WKPreferences API
882         https://bugs.webkit.org/show_bug.cgi?id=194723
883         <rdar://problem/48122993>
884
885         Reviewed by Geoffrey Garen.
886
887         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
888         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
889         (TEST):
890         (safeBrowsingView):
891         Make tests use SPI instead of API.
892
893 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
894
895         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
896         https://bugs.webkit.org/show_bug.cgi?id=194586
897
898         Reviewed by Ross Kirsling.
899
900         * DumpRenderTree/win/DumpRenderTree.cpp:
901         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
902         * Scripts/webkitpy/port/driver.py:
903         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
904
905 2019-02-17  David Kilzer  <ddkilzer@apple.com>
906
907         Unreviewed, rolling out r241620.
908
909         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
910         (Requested by ddkilzer on #webkit.)
911
912         Reverted changeset:
913
914         "[WTF] Add environment variable helpers"
915         https://bugs.webkit.org/show_bug.cgi?id=192405
916         https://trac.webkit.org/changeset/241620
917
918 2019-02-16  Zalan Bujtas  <zalan@apple.com>
919
920         [LFC] RenderImage's default intrinsic size is 0.
921         https://bugs.webkit.org/show_bug.cgi?id=194745
922
923         Reviewed by Antti Koivisto.
924
925         * LayoutReloaded/misc/LFC-passing-tests.txt:
926
927 2019-02-16  Zalan Bujtas  <zalan@apple.com>
928
929         [LFC][BFC] Add support for block replaced intrinsic width.
930         https://bugs.webkit.org/show_bug.cgi?id=194705
931
932         Reviewed by Simon Fraser.
933
934         * LayoutReloaded/misc/LFC-passing-tests.txt:
935
936 2019-02-16  Zalan Bujtas  <zalan@apple.com>
937
938         [LFC] Apply min/max width constraints to preferred width computation
939         https://bugs.webkit.org/show_bug.cgi?id=194739
940
941         Reviewed by Simon Fraser.
942
943         * LayoutReloaded/misc/LFC-passing-tests.txt:
944
945 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
946
947         [WTF] Add environment variable helpers
948         https://bugs.webkit.org/show_bug.cgi?id=192405
949
950         Reviewed by Michael Catanzaro.
951
952         * DumpRenderTree/mac/DumpRenderTree.mm:
953         (libraryPathForDumpRenderTree):
954         * DumpRenderTree/win/DumpRenderTree.cpp:
955         (libraryPathForDumpRenderTree):
956         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
957         (setUpIOSLayoutTestCommunication):
958         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
959         (beforeAll):
960         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
961         (main):
962         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
963         (WebKitTestBus::run):
964         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
965         (WTR::getOutputDir):
966         (WTR::initializeFontConfigSetting):
967         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
968         (WTR::InjectedBundle::platformInitialize):
969         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
970         (WTR::topLevelPath):
971         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
972         (WTR::topLevelPath):
973         (WTR::getOutputDir):
974         (WTR::activateFonts):
975         * WebKitTestRunner/TestController.cpp:
976         (WTR::TestController::libraryPathForTesting):
977         (WTR::TestController::generateContextConfiguration const):
978         (WTR::TestController::generatePageConfiguration):
979         (WTR::TestController::decideDestinationWithSuggestedFilename):
980         (WTR::TestController::platformAdjustContext):
981         * WebKitTestRunner/TestController.h:
982         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
983         (WTR::TestController::cocoaPlatformInitialize):
984         (WTR::TestController::platformAdjustContext):
985         * WebKitTestRunner/gtk/main.cpp:
986         (main):
987         * WebKitTestRunner/mac/TestControllerMac.mm:
988         (WTR::TestController::configureContentExtensionForTest):
989         * WebKitTestRunner/wpe/main.cpp:
990         (main):
991         Utilize WTF::Environment where possible.
992
993 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
994
995         [iOS] WKWebView callout bar is missing Change Writing Direction item
996         https://bugs.webkit.org/show_bug.cgi?id=190015
997         <rdar://problem/44810366>
998
999         Reviewed by Tim Horton.
1000
1001         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1002         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1003
1004         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1005         (TestWebKitAPI::TEST):
1006
1007 2019-02-15  Chris Dumez  <cdumez@apple.com>
1008
1009         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1010         https://bugs.webkit.org/show_bug.cgi?id=194717
1011         <rdar://problem/47884404>
1012
1013         Reviewed by Brady Eidson.
1014
1015         Add API test coverage.
1016
1017         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1018
1019 2019-02-15  Youenn Fablet  <youenn@apple.com>
1020
1021         Make navigator.mediaDevices SecureContext
1022         https://bugs.webkit.org/show_bug.cgi?id=194666
1023
1024         Reviewed by Eric Carlson.
1025
1026         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1027         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1028         (TEST_F):
1029
1030 2019-02-15  Brian Burg  <bburg@apple.com>
1031
1032         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1033         https://bugs.webkit.org/show_bug.cgi?id=194411
1034         <rdar://problem/47787614>
1035
1036         Reviewed by Joseph Pecoraro.
1037
1038         Remove unnecessary soft linking macro usage.
1039
1040         * DumpRenderTree/mac/TestRunnerMac.mm:
1041         (TestRunner::inspectorTestStubURL):
1042         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1043         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1044         (WTR::TestRunner::inspectorTestStubURL):
1045
1046 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1047
1048         Unreviewed, rolling out r241559 and r241566.
1049         https://bugs.webkit.org/show_bug.cgi?id=194710
1050
1051         Causes layout test crashes under GuardMalloc (Requested by
1052         ryanhaddad on #webkit).
1053
1054         Reverted changesets:
1055
1056         "[WTF] Add environment variable helpers"
1057         https://bugs.webkit.org/show_bug.cgi?id=192405
1058         https://trac.webkit.org/changeset/241559
1059
1060         "Unreviewed build fix for WinCairo Debug after r241559."
1061         https://trac.webkit.org/changeset/241566
1062
1063 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1064
1065         [LFC] Out-of-flow box is never a float box
1066         https://bugs.webkit.org/show_bug.cgi?id=194704
1067
1068         Reviewed by Antti Koivisto.
1069
1070         * LayoutReloaded/misc/LFC-passing-tests.txt:
1071
1072 2019-02-10  Darin Adler  <darin@apple.com>
1073
1074         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1075         https://bugs.webkit.org/show_bug.cgi?id=194487
1076
1077         Reviewed by Daniel Bates.
1078
1079         * DumpRenderTree/win/DumpRenderTree.cpp:
1080         (applicationId): Use makeString instead of String::format.
1081         (main): Ditto.
1082         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1083         (TestWebKitAPI::Util::createURLForResource): Ditto.
1084         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1085         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1086
1087         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1088         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1089         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1090         (WTR::createStringWithAttributes): Use appendLiteral.
1091         (WTR::AccessibilityUIElement::helpText const): Ditto.
1092         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1093         directly instead of using String::format.
1094         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1095         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1096
1097 2019-02-15  Truitt Savell  <tsavell@apple.com>
1098
1099         Unreviewed, rolling out r241564.
1100
1101         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1102
1103         Reverted changeset:
1104
1105         "[Mac] WebInspectorUI.framework does not need to be soft-
1106         linked anymore"
1107         https://bugs.webkit.org/show_bug.cgi?id=194411
1108         https://trac.webkit.org/changeset/241564
1109
1110 2019-02-15  Saam barati  <sbarati@apple.com>
1111
1112         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1113         https://bugs.webkit.org/show_bug.cgi?id=194036
1114
1115         Reviewed by Yusuke Suzuki.
1116
1117         * Scripts/run-jsc-stress-tests:
1118
1119 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1120
1121         Fix the build.
1122
1123         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1124         (WTR::UIScriptController::drawSquareInEditableImage):
1125         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1126         (TestWebKitAPI::drawSquareInEditableImage):
1127
1128 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1129
1130         Fix the build.
1131
1132         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1133         (WTR::UIScriptController::drawSquareInEditableImage):
1134         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1135         (TestWebKitAPI::drawSquareInEditableImage):
1136
1137 2019-02-14  Brian Burg  <bburg@apple.com>
1138
1139         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1140         https://bugs.webkit.org/show_bug.cgi?id=194411
1141         <rdar://problem/47787614>
1142
1143         Reviewed by Joseph Pecoraro.
1144
1145         Remove unnecessary soft linking macro usage.
1146
1147         * DumpRenderTree/mac/TestRunnerMac.mm:
1148         (TestRunner::inspectorTestStubURL):
1149         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1150         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1151         (WTR::TestRunner::inspectorTestStubURL):
1152
1153 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1154
1155         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1156         https://bugs.webkit.org/show_bug.cgi?id=194599
1157
1158         Reviewed by Lucas Forschler.
1159
1160         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1161         (StatusBubble._build_bubble):
1162
1163 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1164
1165         [ews-app] Set Foreign Key in Django build model
1166         https://bugs.webkit.org/show_bug.cgi?id=194667
1167
1168         Reviewed by Lucas Forschler.
1169
1170         * BuildSlaveSupport/ews-app/ews/models/build.py:
1171         (Build):
1172
1173 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1174
1175         [WTF] Add environment variable helpers
1176         https://bugs.webkit.org/show_bug.cgi?id=192405
1177
1178         Reviewed by Michael Catanzaro.
1179
1180         * DumpRenderTree/mac/DumpRenderTree.mm:
1181         (libraryPathForDumpRenderTree):
1182         * DumpRenderTree/win/DumpRenderTree.cpp:
1183         (libraryPathForDumpRenderTree):
1184         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1185         (setUpIOSLayoutTestCommunication):
1186         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1187         (TestWebKitAPI::strip):
1188         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1189         (beforeAll):
1190         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1191         (main):
1192         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1193         (WebKitTestBus::run):
1194         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1195         (WTR::getOutputDir):
1196         (WTR::initializeFontConfigSetting):
1197         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1198         (WTR::InjectedBundle::platformInitialize):
1199         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1200         (WTR::topLevelPath):
1201         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1202         (WTR::topLevelPath):
1203         (WTR::getOutputDir):
1204         (WTR::activateFonts):
1205         * WebKitTestRunner/TestController.cpp:
1206         (WTR::TestController::libraryPathForTesting):
1207         (WTR::TestController::generateContextConfiguration const):
1208         (WTR::TestController::generatePageConfiguration):
1209         (WTR::TestController::decideDestinationWithSuggestedFilename):
1210         (WTR::TestController::platformAdjustContext):
1211         * WebKitTestRunner/TestController.h:
1212         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1213         (WTR::TestController::cocoaPlatformInitialize):
1214         (WTR::TestController::platformAdjustContext):
1215         * WebKitTestRunner/gtk/main.cpp:
1216         (main):
1217         * WebKitTestRunner/mac/TestControllerMac.mm:
1218         (WTR::TestController::configureContentExtensionForTest):
1219         * WebKitTestRunner/wpe/main.cpp:
1220         (main):
1221         Utilize WTF::Environment where possible.
1222
1223 2019-02-14  Chris Dumez  <cdumez@apple.com>
1224
1225         [PSON] Introduce a WebContent Process cache
1226         https://bugs.webkit.org/show_bug.cgi?id=194594
1227         <rdar://problem/46793397>
1228
1229         Reviewed by Geoff Garen.
1230
1231         Update API tests to turn on the WebContent Process cache.
1232
1233         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1234
1235 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1236
1237         Unreviewed, build fix after r241480
1238
1239         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1240         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1241         (-[DragAndDropSimulator initWithWebView:]):
1242
1243 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1244
1245         AX: ARIA Reflection was disabled in error
1246         https://bugs.webkit.org/show_bug.cgi?id=194647
1247         <rdar://problem/48068336>
1248
1249         Reviewed by Ryosuke Niwa.
1250
1251         Remove test override now that this feature should be enabled by default.
1252
1253         * WebKitTestRunner/TestController.cpp:
1254         (WTR::TestController::resetPreferencesToConsistentValues):
1255
1256 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1257
1258         Unreviewed, rolling out r241486.
1259         https://bugs.webkit.org/show_bug.cgi?id=194655
1260
1261         causing API failures in builds (Requested by ShawnRoberts on
1262         #webkit).
1263
1264         Reverted changeset:
1265
1266         "[Cocoa] Media elements will restart network buffering just
1267         before suspending"
1268         https://bugs.webkit.org/show_bug.cgi?id=193691
1269         https://trac.webkit.org/changeset/241486
1270
1271 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1272
1273         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1274         https://bugs.webkit.org/show_bug.cgi?id=194622
1275
1276         Reviewed by Antti Koivisto.
1277
1278         * LayoutReloaded/misc/LFC-passing-tests.txt:
1279
1280 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1281
1282         [LFC] Shrink-to-fit-width should be constrained by min/max width
1283         https://bugs.webkit.org/show_bug.cgi?id=194653
1284
1285         Reviewed by Antti Koivisto.
1286
1287         * LayoutReloaded/misc/LFC-passing-tests.txt:
1288
1289 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1290
1291         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1292         https://bugs.webkit.org/show_bug.cgi?id=194641
1293
1294         Reviewed by Geoffrey Garen.
1295
1296         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1297         so that the test would fail without this fix.
1298
1299         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1300         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1301
1302 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1303
1304         [ews-app] Change log level for a log statement
1305
1306         Unreviewed minor fix.
1307
1308         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1309         (Patch.save_patch):
1310
1311 2019-02-13  Jer Noble  <jer.noble@apple.com>
1312
1313         [Cocoa] Media elements will restart network buffering just before suspending
1314         https://bugs.webkit.org/show_bug.cgi?id=193691
1315
1316         Reviewed by Eric Carlson.
1317
1318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1319         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1320         (TEST):
1321
1322 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1323
1324         [ews-app] Fetch builder id to name mapping
1325         https://bugs.webkit.org/show_bug.cgi?id=194355
1326
1327         Reviewed by Lucas Forschler.
1328
1329         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1330         (Buildbot.get_builder_id_to_name_mapping):
1331         (Buildbot._get_display_name_from_builder_name):
1332
1333 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1334
1335         Further restricting webarchive loads
1336         https://bugs.webkit.org/show_bug.cgi?id=194567
1337         <rdar://problem/47610130>
1338
1339         Reviewed by Youenn Fablet.
1340
1341         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1342         navigations on drop.
1343
1344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1345         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1346         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1347         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1348         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1349         (TestWebKitAPI::TEST):
1350         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1351         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1352         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1353         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1354         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1355         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1356         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1357
1358 2019-02-13  John Wilander  <wilander@apple.com>
1359
1360         Store Ad Click Attribution requests in the network process
1361         https://bugs.webkit.org/show_bug.cgi?id=194510
1362         <rdar://problem/47650118>
1363
1364         Reviewed by Alex Christensen and Daniel Bates.
1365
1366         This patch adds two TestRunner functions:
1367         - dumpAdClickAttribution()
1368         - clearAdClickAttribution()
1369
1370         They call into the network process to dump and clear Ad Click
1371         Attribution state, respectively.
1372
1373         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1374         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1375         (WTR::TestRunner::dumpAdClickAttribution):
1376         (WTR::TestRunner::clearAdClickAttribution):
1377         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1378         * WebKitTestRunner/TestController.cpp:
1379         (WTR::TestController::resetStateToConsistentValues):
1380         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1381         (WTR::adClickAttributionStringResultCallback):
1382         (WTR::TestController::dumpAdClickAttribution):
1383         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1384         (WTR::adClickAttributionVoidCallback):
1385         (WTR::TestController::clearAdClickAttribution):
1386         * WebKitTestRunner/TestController.h:
1387         * WebKitTestRunner/TestInvocation.cpp:
1388         (WTR::TestInvocation::dumpResults):
1389         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1390         (WTR::TestInvocation::dumpAdClickAttribution):
1391         * WebKitTestRunner/TestInvocation.h:
1392
1393 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1394
1395         [ews-app] Generate status-bubble
1396         https://bugs.webkit.org/show_bug.cgi?id=194572
1397
1398         Reviewed by Lucas Forschler.
1399
1400         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1401         (StatusBubble._build_bubble):
1402         (StatusBubble._should_show_bubble_for):
1403         (StatusBubble._build_bubbles_for_patch):
1404
1405 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1406
1407         [ews-app] Add status bubble html template
1408         https://bugs.webkit.org/show_bug.cgi?id=194571
1409
1410         Reviewed by Lucas Forschler.
1411
1412         * BuildSlaveSupport/ews-app/ews/templates: Added.
1413         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1414
1415 2019-02-12  Chris Dumez  <cdumez@apple.com>
1416
1417         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1418         https://bugs.webkit.org/show_bug.cgi?id=194568
1419         <rdar://problem/47944490>
1420
1421         Reviewed by Ryosuke Niwa.
1422
1423         Add API test coverage.
1424
1425         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1426         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1427
1428 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1429
1430         webkitpy: Remove bug_dummy from parsed test expectations
1431         https://bugs.webkit.org/show_bug.cgi?id=194562
1432         <rdar://problem/47853999>
1433
1434         Reviewed by Lucas Forschler.
1435
1436         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1437         (TestExpectationParser):
1438         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1439         skipped tests.
1440         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1441
1442 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1443
1444         [ews-app] Add method to fetch patch
1445         https://bugs.webkit.org/show_bug.cgi?id=194518
1446
1447         Reviewed by Lucas Forschler.
1448
1449         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1450         (Patch.get_patch):
1451
1452 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1453
1454         [LFC] Expand tests coverage (60 new tests -> 860)
1455
1456         Unreviewed test gardening (run-singly, --child-processes=1).
1457
1458         * LayoutReloaded/misc/LFC-passing-tests.txt:
1459
1460 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1461
1462         Allow pages to trigger programmatic paste from script on iOS
1463         https://bugs.webkit.org/show_bug.cgi?id=194271
1464         <rdar://problem/47808810>
1465
1466         Reviewed by Tim Horton.
1467
1468         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1469
1470         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1471         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1472         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1473         (WTR::UIScriptController::rectForMenuAction const):
1474
1475         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1476         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1477         for when the menu is shown or hidden.
1478
1479         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1480         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1481         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1482         (WTR::UIScriptController::setDidShowMenuCallback):
1483         (WTR::UIScriptController::didShowMenuCallback const):
1484         (WTR::UIScriptController::setDidHideMenuCallback):
1485         (WTR::UIScriptController::didHideMenuCallback const):
1486         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1487         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1488         (WTR::UIScriptController::rectForMenuAction const):
1489         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1490         * WebKitTestRunner/TestController.cpp:
1491         (WTR::TestController::resetPreferencesToConsistentValues):
1492         (WTR::updateTestOptionsFromTestHeader):
1493         * WebKitTestRunner/TestOptions.h:
1494
1495         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1496         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1497
1498         (WTR::TestOptions::hasSameInitializationOptions const):
1499         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1500         (WTR::UIScriptController::calendarType const):
1501         (WTR::UIScriptController::platformUndoManager const):
1502         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1503         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1504         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1505         (-[TestRunnerWKWebView dealloc]):
1506         (-[TestRunnerWKWebView _didShowMenu]):
1507         (-[TestRunnerWKWebView _didHideMenu]):
1508
1509         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1510
1511         * WebKitTestRunner/ios/TestControllerIOS.mm:
1512         (WTR::handleMenuWillHideNotification):
1513         (WTR::handleMenuDidHideNotification):
1514         (WTR::TestController::platformInitialize):
1515         (WTR::TestController::platformDestroy):
1516         (WTR::TestController::platformResetStateToConsistentValues):
1517
1518         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1519         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1520
1521         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1522         (WTR::forEachViewInHierarchy):
1523         (WTR::findViewInHierarchyOfType):
1524
1525         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1526         functions that dig through a given view's hierarchy in search of a view of a given class.
1527
1528         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1529         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1530         (WTR::UIScriptController::selectionCaretViewRect const):
1531         (WTR::UIScriptController::selectionRangeViewRects const):
1532         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1533         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1534
1535         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1536
1537         (WTR::UIScriptController::rectForMenuAction const):
1538
1539         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1540         callout bar) whose label matches the given string.
1541
1542         (WTR::UIScriptController::platformContentView const):
1543
1544         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1545         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1546         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1547
1548         (WTR::UIScriptController::platformUndoManager const): Deleted.
1549         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1550         (WTR::UIScriptController::platformContentView const):
1551         (WTR::UIScriptController::platformUndoManager const): Deleted.
1552
1553 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1554
1555         webkitpy: No option to only show unexpected failures in results.html for iPad
1556         https://bugs.webkit.org/show_bug.cgi?id=194554
1557         <rdar://problem/47922442>
1558
1559         Rubber-stamped by Aakash Jain.
1560
1561         Just because a TestExpecations file does not exist for a specific platform does not mean that
1562         TestExpecations are not being used, given that platforms inherit test expectations.
1563
1564         * Scripts/webkitpy/port/base.py:
1565         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1566         * Scripts/webkitpy/port/base_unittest.py:
1567         (PortTest.test_uses_test_expectations_file):
1568
1569 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1570
1571         Remove setDefersLoading infrastructure from WebKit2
1572         https://bugs.webkit.org/show_bug.cgi?id=194506
1573
1574         Reviewed by Brady Eidson.
1575
1576         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1577         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1578         (WTR::TestRunner::setDefersLoading): Deleted.
1579         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1580
1581 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1582
1583         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1584         https://bugs.webkit.org/show_bug.cgi?id=194522
1585         <rdar://problem/47789393>
1586
1587         Reviewed by Chris Dumez.
1588
1589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1590         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1591         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1592         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1593
1594 2019-02-12  Andy Estes  <aestes@apple.com>
1595
1596         [iOSMac] Enable Parental Controls Content Filtering
1597         https://bugs.webkit.org/show_bug.cgi?id=194521
1598         <rdar://39732376>
1599
1600         Reviewed by Tim Horton.
1601
1602         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1603
1604 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1605
1606         [LFC][IFC] Add intrinsic width support for float boxes.
1607         https://bugs.webkit.org/show_bug.cgi?id=194528
1608
1609         Reviewed by Antti Koivisto.
1610
1611         Expand tests coverage (2 new tests -> 800).
1612         (This is the correct test ordering --runs-singly --child-processes=1)
1613
1614         * LayoutReloaded/misc/LFC-passing-tests.txt:
1615
1616 2019-02-12  Rob Buis  <rbuis@igalia.com>
1617
1618         Implement serializing in MIME type parser
1619         https://bugs.webkit.org/show_bug.cgi?id=193909
1620
1621         Reviewed by Darin Adler.
1622
1623         Add various tests involving upper case, non-ASCII, control/null characters,
1624         various HTTP whitespace, single quotes and an unpaired surrogate.
1625
1626         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1627         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1628         (TestWebKitAPI::serializeIfValid):
1629         (TestWebKitAPI::TEST):
1630
1631 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1632
1633         [Cocoa] Ask platform for generic font family mappings
1634         https://bugs.webkit.org/show_bug.cgi?id=187723
1635         <rdar://problem/41892438>
1636
1637         Reviewed by Brent Fulgham.
1638
1639         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1640
1641         * DumpRenderTree/mac/DumpRenderTree.mm:
1642         (allowedFontFamilySet):
1643         * WebKitTestRunner/mac/TestControllerMac.mm:
1644         (WTR::allowedFontFamilySet):
1645
1646 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1647
1648         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1649         https://bugs.webkit.org/show_bug.cgi?id=193622
1650
1651         Reviewed by Michael Catanzaro.
1652
1653         This adds support for loading content extension rule sets from the JSON files which
1654         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1655         of WKTR for this could be removed, but that is left for a follow-up patch with
1656         cleanups.
1657
1658         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1659         * WebKitTestRunner/TestController.cpp:
1660         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1661         avoid having the null-terminator copied into the result.
1662         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1663         part of the preparations to run a test.
1664         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1665         (WTR::contentExtensionStoreCallback): Added.
1666         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1667         used for content extensions test.
1668         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1669         extensions and compiling the JSON rule set for tests involving content extensions.
1670         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1671         testing and disables content extensions.
1672         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1673         resetContentExtensions().
1674         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1675         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1676         configureContentExtensionForTest(), and userContentController().
1677
1678 2019-02-11  Daniel Bates  <dabates@apple.com>
1679
1680         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1681         https://bugs.webkit.org/show_bug.cgi?id=191446
1682         <rdar://problem/45929460>
1683
1684         Reviewed by Tim Horton.
1685
1686         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1687
1688         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1689         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1690         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1691         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1692         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1693         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1694         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1695         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1696         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1697         (WTR::arrayLength):
1698         (WTR::parseModifierArray):
1699         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1700         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1701         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1702         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1703
1704 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1705
1706         Unreviewed, rolling out r241272 and r241276.
1707         https://bugs.webkit.org/show_bug.cgi?id=194514
1708
1709         Broke the Apple Internal build and the fix requires human
1710         intervention :( (Requested by dydz on #webkit).
1711
1712         Reverted changesets:
1713
1714         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1715         https://bugs.webkit.org/show_bug.cgi?id=191446
1716         https://trac.webkit.org/changeset/241272
1717
1718         "Fix internal iOS build after r241272"
1719         https://bugs.webkit.org/show_bug.cgi?id=191446
1720         https://trac.webkit.org/changeset/241276
1721
1722 2019-02-11  Truitt Savell  <tsavell@apple.com>
1723
1724         Unreviewed, rolling out r241269.
1725
1726         Caused 5 layout tests crashes on Mac WK1
1727
1728         Reverted changeset:
1729
1730         "DumpRenderTree should report unknown options"
1731         https://bugs.webkit.org/show_bug.cgi?id=191303
1732         https://trac.webkit.org/changeset/241269
1733
1734 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1735
1736         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1737         https://bugs.webkit.org/show_bug.cgi?id=194313
1738
1739         Reviewed by Tim Horton.
1740
1741         Add a helper to determine whether the web view is presenting modal UI.
1742
1743         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1744         (WTR::UIScriptController::isPresentingModally const):
1745         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1746         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1747         (WTR::UIScriptController::isPresentingModally const):
1748         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1749         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1750         (WTR::UIScriptController::calendarType const): Deleted.
1751         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1752         (WTR::UIScriptController::isPresentingModally const):
1753         (WTR::UIScriptController::calendarType const):
1754         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1755         (WTR::UIScriptController::calendarType const):
1756
1757 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1758
1759         GCHeapInspector: Show the retained sizes in more places
1760         https://bugs.webkit.org/show_bug.cgi?id=194464
1761
1762         Reviewed by Simon Fraser.
1763
1764         * GCHeapInspector/gc-heap-inspector.html:
1765         * GCHeapInspector/script/interface.js:
1766         (HeapInspectorUtils.humanReadableSize):
1767         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1768         (HeapInspectorUtils.spanForNode.span.span):
1769         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1770         (HeapSnapshotInspector.prototype.buildRoots):
1771
1772 2019-02-11  Daniel Bates  <dabates@apple.com>
1773
1774         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1775         https://bugs.webkit.org/show_bug.cgi?id=191446
1776         <rdar://problem/45929460>
1777
1778         Reviewed by Tim Horton.
1779
1780         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1781
1782         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1783         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1784         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1785         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1786         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1787         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1788         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1789         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1790         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1791         (WTR::arrayLength):
1792         (WTR::parseModifierArray):
1793         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1794         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1795         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1796         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1797
1798 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1799
1800         DumpRenderTree should report unknown options
1801         https://bugs.webkit.org/show_bug.cgi?id=191303
1802
1803         Reviewed by Frédéric Wang.
1804
1805         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1806         to report unknown options.
1807         Added and assigned test options which are currently used in tests.
1808
1809         * DumpRenderTree/TestOptions.cpp:
1810         (TestOptions::TestOptions):
1811
1812 2019-02-11  Truitt Savell  <tsavell@apple.com>
1813
1814         Unreviewed, rolling out r241229.
1815
1816         Revision broke internal builds for watchOS.
1817
1818         Reverted changeset:
1819
1820         "[Cocoa] Ask platform for generic font family mappings"
1821         https://bugs.webkit.org/show_bug.cgi?id=187723
1822         https://trac.webkit.org/changeset/241229
1823
1824 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1825
1826         [WinCairo][MiniBrowser] Basic authentication always fails.
1827         https://bugs.webkit.org/show_bug.cgi?id=194496
1828
1829         Reviewed by Don Olmstead.
1830
1831         * MiniBrowser/win/DialogHelper.h:
1832         (Dialog::getText):
1833
1834 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1835
1836         [GStreamer] GstMappedBuffer testsuite build fails
1837         https://bugs.webkit.org/show_bug.cgi?id=194495
1838
1839         Reviewed by Carlos Garcia Campos.
1840
1841         Fix the build by explicitely adding the gstreamer1.0-audio include
1842         directories to the include path.
1843
1844         * TestWebKitAPI/PlatformGTK.cmake:
1845         * TestWebKitAPI/PlatformWPE.cmake:
1846
1847 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1848
1849         [GTK][WPE] Add enable-javascript-markup setting
1850         https://bugs.webkit.org/show_bug.cgi?id=193439
1851
1852         Reviewed by Michael Catanzaro.
1853
1854         Add test cases to check the new setting.
1855
1856         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1857         (testWebKitSettings):
1858         (testWebKitSettingsJavaScriptMarkup):
1859         (beforeAll):
1860
1861 2019-02-10  Darin Adler  <darin@apple.com>
1862
1863         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1864         https://bugs.webkit.org/show_bug.cgi?id=194485
1865
1866         Reviewed by Daniel Bates.
1867
1868         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1869
1870 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1871
1872         Add more tests for clampTo<>()
1873         https://bugs.webkit.org/show_bug.cgi?id=194462
1874
1875         Reviewed by Geoffrey Garen.
1876
1877         Darin suggested to test the very last floating point number
1878         at the boundaries when truncating to integer.
1879         I added test for max/min and max-1/min-1.
1880
1881         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1882         (TestWebKitAPI::TEST):
1883
1884 2019-02-09  Darin Adler  <darin@apple.com>
1885
1886         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1887         https://bugs.webkit.org/show_bug.cgi?id=194021
1888
1889         Reviewed by Geoffrey Garen.
1890
1891         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1892         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1893         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1894
1895 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1896
1897         [LFC][IFC] Add intrinsic width support for basic inline containers
1898         https://bugs.webkit.org/show_bug.cgi?id=194473
1899
1900         Reviewed by Antti Koivisto.
1901
1902         Expand tests coverage (11 new tests -> 798)
1903
1904         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1905
1906 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1907
1908         Fix MiniBrowser's entitlements
1909         https://bugs.webkit.org/show_bug.cgi?id=192431
1910
1911         Reviewed by Joseph Pecoraro.
1912
1913         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1914         files, making it impossible to load any extension.
1915
1916         * MiniBrowser/MiniBrowser.entitlements:
1917
1918 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1919
1920         [Cocoa] Ask platform for generic font family mappings
1921         https://bugs.webkit.org/show_bug.cgi?id=187723
1922         <rdar://problem/41892438>
1923
1924         Reviewed by Brent Fulgham.
1925
1926         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1927
1928         * DumpRenderTree/mac/DumpRenderTree.mm:
1929         (allowedFontFamilySet):
1930         * WebKitTestRunner/mac/TestControllerMac.mm:
1931         (WTR::allowedFontFamilySet):
1932
1933 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1934
1935         [GTK] Implement back/forward touchpad gesture
1936         https://bugs.webkit.org/show_bug.cgi?id=193919
1937
1938         Reviewed by Michael Catanzaro.
1939
1940         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1941         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1942
1943 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1944
1945         Add SPI to use networking daemon instead of XPC service
1946         https://bugs.webkit.org/show_bug.cgi?id=194427
1947
1948         Reviewed by Geoffrey Garen
1949
1950         * MiniBrowser/MiniBrowser.entitlements:
1951
1952 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1953
1954         [ews-build] Ensure that every builder in config.json has short name
1955         https://bugs.webkit.org/show_bug.cgi?id=194461
1956
1957         Reviewed by Lucas Forschler.
1958
1959         * BuildSlaveSupport/ews-build/loadConfig.py:
1960         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1961
1962 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1963
1964         [ews-build] Add short name to config.json
1965         https://bugs.webkit.org/show_bug.cgi?id=194456
1966
1967         Reviewed by Lucas Forschler.
1968
1969         * BuildSlaveSupport/ews-build/config.json: Added short name.
1970         * BuildSlaveSupport/ews-build/loadConfig.py:
1971         (loadBuilderConfig): Set the short name as the builder description.
1972
1973 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1974
1975         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1976         https://bugs.webkit.org/show_bug.cgi?id=194418
1977
1978         Reviewed by Lucas Forschler.
1979
1980         Do not include errors trying when finding crashlogs at the end of
1981         a run-webkit-tests run since we don't process those errors.
1982
1983         * Scripts/webkitpy/port/darwin.py:
1984         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1985         * Scripts/webkitpy/port/ios_device.py:
1986         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1987         * Scripts/webkitpy/port/watch_device.py:
1988         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1989
1990 2019-02-08  Beth Dakin  <bdakin@apple.com>
1991
1992         Add afterScreenUpdates to WKSnapshotConfiguration
1993         https://bugs.webkit.org/show_bug.cgi?id=194362
1994         -and corresponding-
1995         <rdar://problem/40655528> Please add an "after screen updates" property to 
1996         WKSnapshotConfiguration (to solve blank snapshots)
1997
1998         Reviewed by Tim Horton.
1999
2000         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2001         (TEST):
2002
2003 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2004
2005         clampTo(): do not convert the input to double when dealing with integers
2006         https://bugs.webkit.org/show_bug.cgi?id=194263
2007         <rdar://problem/47692312>
2008
2009         Reviewed by Darin Adler.
2010
2011         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2012         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2013         (TestWebKitAPI::testClampFloatingPointToInteger):
2014         (TestWebKitAPI::testClampSameSignIntegers):
2015         (TestWebKitAPI::testClampUnsignedToSigned):
2016         (TestWebKitAPI::testClampSignedToUnsigned):
2017
2018 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2019
2020         webkitpy: Respect --dedicated-simulators flag
2021         https://bugs.webkit.org/show_bug.cgi?id=194416
2022         <rdar://problem/47894722>
2023
2024         Reviewed by Lucas Forschler.
2025
2026         * Scripts/webkitpy/port/device_port.py:
2027         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2028         available devices can be safely ignored.
2029
2030 2019-02-07  Keith Rollin  <krollin@apple.com>
2031
2032         Remove extra copy of 100x100-red.tga
2033         https://bugs.webkit.org/show_bug.cgi?id=194371
2034         <rdar://problem/47873465>
2035
2036         Reviewed by Said Abou-Hallawa.
2037
2038         In order to help it pass its tests, Bug 194190 added a second copy of
2039         the file 100x100-red.tga. However, it turns out that this additional
2040         file wasn't actually needed, and that that sole previous copy was
2041         sufficient. At the same time, this second copy -- which was copied to
2042         the same location in the build output as the first copy -- now caused
2043         XCBuild to complain because there were two production rules for the
2044         same output file. Address this by removing the newly-added extra copy.
2045
2046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2047         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2048
2049 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2050
2051         Deprecate WKBundlePageSetDefersLoading
2052         https://bugs.webkit.org/show_bug.cgi?id=191394
2053
2054         Reviewed by Dean Jackson.
2055
2056         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2057         (WTR::TestRunner::setDefersLoading):
2058
2059 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2060
2061         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2062         https://bugs.webkit.org/show_bug.cgi?id=194391
2063
2064         Reviewed by Antti Koivisto.
2065
2066         * LayoutReloaded/misc/LFC-passing-tests.txt:
2067
2068 2019-02-06  Keith Rollin  <krollin@apple.com>
2069
2070         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2071         https://bugs.webkit.org/show_bug.cgi?id=193975
2072         <rdar://problem/47643306>
2073
2074         Reviewed by Tim Horton.
2075
2076         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2077         the Info.plist file into the bundle. This step is not necessary as the
2078         implicit "bundle up all the build products into a framework" build
2079         phase does this already. Having the Copy Bundle Resources phase do
2080         this causes a conflict under XCBuild, which objects to two build
2081         phases producing the same file (Info.plist). Address this by removing
2082         Info.plist from the Copy Bundle Resources phase.
2083
2084         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2085
2086 2019-02-06  Keith Rollin  <krollin@apple.com>
2087
2088         Really enable the automatic checking and regenerations of .xcfilelists during builds
2089         https://bugs.webkit.org/show_bug.cgi?id=194357
2090         <rdar://problem/47861231>
2091
2092         Reviewed by Chris Dumez.
2093
2094         Bug 194124 was supposed to enable the automatic checking and
2095         regenerating of .xcfilelist files during the build. While related
2096         changes were included in that patch, the change to actually enable the
2097         operation somehow was omitted. This patch actually enables the
2098         operation. The check-xcfilelist.sh scripts now check
2099         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2100         from the checking.
2101
2102         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2103         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2104
2105 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2106
2107         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2108         <https://webkit.org/b/194286>
2109         <rdar://problem/47815558>
2110
2111         Reviewed by Alexey Proskuryakov.
2112
2113         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2114         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2115         WKRetainPtr<> to avoid leaking the WKDataRef.
2116
2117 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2118
2119         Unreviewed, fix a typo
2120
2121         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2122
2123 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2124
2125         [GTK][WPE] force libpsl build to use ICU in jhbuild
2126         https://bugs.webkit.org/show_bug.cgi?id=194288
2127
2128         Reviewed by Carlos Garcia Campos.
2129
2130         * gtk/jhbuild.modules:
2131         Require ICU for libpsl build in jhbuild, like done in WPE.
2132
2133 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2134
2135         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2136         https://bugs.webkit.org/show_bug.cgi?id=194209
2137
2138         Reviewed by Carlos Garcia Campos.
2139
2140         Enhance TestCookieManager to ensure this doesn't happen again.
2141
2142         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2143         (testCookieManagerPersistentStorage):
2144         (beforeAll):
2145
2146 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2147
2148         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2149         https://bugs.webkit.org/show_bug.cgi?id=194324
2150
2151         Reviewed by Andy Estes.
2152
2153         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2154         part of the name is already implicit, since this is in testing code in TestOptions.
2155
2156         * WebKitTestRunner/TestController.cpp:
2157         (WTR::TestController::generateContextConfiguration const):
2158         (WTR::updateTestOptionsFromTestHeader):
2159         * WebKitTestRunner/TestOptions.h:
2160         (WTR::TestOptions::hasSameInitializationOptions const):
2161
2162 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2163
2164         [ews-build] Allow * as platform for builders and workers
2165         https://bugs.webkit.org/show_bug.cgi?id=188533
2166
2167         Reviewed by Lucas Forschler.
2168
2169         * BuildSlaveSupport/ews-build/loadConfig.py:
2170         (checkWorkersAndBuildersForConsistency):
2171
2172 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2173
2174         [ews-build] Add few bots to config.json
2175         https://bugs.webkit.org/show_bug.cgi?id=194304
2176
2177         Reviewed by Lucas Forschler.
2178
2179         * BuildSlaveSupport/ews-build/config.json:
2180
2181 2019-02-05  Keith Rollin  <krollin@apple.com>
2182
2183         Enable the automatic checking and regenerations of .xcfilelists during builds
2184         https://bugs.webkit.org/show_bug.cgi?id=194124
2185         <rdar://problem/47721277>
2186
2187         Reviewed by Tim Horton.
2188
2189         Bug 193790 add a facility for checking -- during build time -- that
2190         any needed .xcfilelist files are up-to-date and for updating them if
2191         they are not. This facility was initially opt-in by setting
2192         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2193         the process seemed robust. Its now time to enable this facility and
2194         make it opt-out. If there is a need to disable this facility, set and
2195         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2196         running `make` or `build-webkit`, or before running Xcode from the
2197         command line.
2198
2199         Additionally, remove the step that generates a list of source files
2200         going into the UnifiedSources build step. It's only necessarily to
2201         specify Sources.txt and SourcesCocoa.txt as inputs.
2202
2203         * Scripts/generate-xcfilelists:
2204
2205 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2206
2207         [GTK][WPE] force libpsl build to use ICU in jhbuild
2208         https://bugs.webkit.org/show_bug.cgi?id=194288
2209
2210         Reviewed by Philippe Normand.
2211
2212         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2213         This can cause build failures if libidn is detected but libunistring is not available.
2214
2215         Make sure that ICU is used for runtime and builtin PSL data.
2216
2217         * gtk/jhbuild.modules:
2218         * wpe/jhbuild.modules:
2219
2220 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2221
2222         [ews-app] Modified timestamp should be updated on updating data
2223         https://bugs.webkit.org/show_bug.cgi?id=194295
2224
2225         Reviewed by Lucas Forschler.
2226
2227         * BuildSlaveSupport/ews-app/ews/models/build.py:
2228         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2229         * BuildSlaveSupport/ews-app/ews/models/step.py:
2230
2231 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2232
2233         Unreviewed, rolling out r240742.
2234
2235         Causes crashes on iOS simulator.
2236
2237         Reverted changeset:
2238
2239         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2240         not focused in a content-editable element"
2241         https://bugs.webkit.org/show_bug.cgi?id=192824
2242         https://trac.webkit.org/changeset/240742
2243
2244 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2245
2246         run-webkit-tests emits message "...running None" when running tests
2247         https://bugs.webkit.org/show_bug.cgi?id=194133
2248         <rdar://problem/47724738>
2249
2250         Reviewed by Lucas Forschler.
2251
2252         * Scripts/webkitpy/xcode/device_type.py:
2253         (DeviceType.__str__): Use both version mapping tables and use just the variant
2254         name if no version name is available.
2255         * Scripts/webkitpy/xcode/device_type_unittest.py:
2256         (DeviceTypeTest):
2257         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2258         an associated named.
2259
2260 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2261
2262         [WPE] require python3-setuptools for meson build in jhbuild
2263         https://bugs.webkit.org/show_bug.cgi?id=194287
2264
2265         Reviewed by Philippe Normand.
2266
2267         python3-setuptools is needed to build meson in jhbuild.
2268         It is already required by the GTK port.
2269
2270         * wpe/install-dependencies:
2271
2272 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2273
2274         [ews-app] Add method to save BuilderMapping to database
2275         https://bugs.webkit.org/show_bug.cgi?id=194264
2276
2277         Reviewed by Lucas Forschler.
2278
2279         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2280         (BuilderMapping.__str__):
2281         (BuilderMapping):
2282         (BuilderMapping.save_mapping):
2283         (BuilderMapping.update_mapping):
2284         (BuilderMapping.get_existing_mapping):
2285         (BuilderMapping.is_valid_mapping):
2286
2287 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2288
2289         [ews-app] Add timestamp fields for BuilderMappings
2290         https://bugs.webkit.org/show_bug.cgi?id=194266
2291
2292         Reviewed by Lucas Forschler.
2293
2294         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2295         (BuilderMapping):
2296
2297 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2298
2299         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2300         https://bugs.webkit.org/show_bug.cgi?id=174816
2301
2302         Reviewed by Michael Catanzaro.
2303
2304         Add tests for webkit_uri_for_display().
2305
2306         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2307         (testURIForDisplayUnaffected):
2308         (testURIForDisplayAffected):
2309         (beforeAll):
2310         (afterAll):
2311         * TestWebKitAPI/glib/CMakeLists.txt:
2312
2313 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2314
2315         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2316         https://bugs.webkit.org/show_bug.cgi?id=194158
2317         <rdar://problem/47737268>
2318
2319         Rubber-stamped by Aakash Jain.
2320
2321         * Scripts/webkitpy/port/device_port.py:
2322         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2323
2324 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2325
2326         [CG] Enable setAdditionalSupportedImageTypes for WK1
2327         https://bugs.webkit.org/show_bug.cgi?id=194190
2328
2329         Reviewed by Tim Horton.
2330
2331         Add a test similar to the one under WebKit Cocoa but make it create a
2332         WebView instead of a WKWebView.
2333
2334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2335         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2336         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2337         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2338         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2339         (TestWebKitAPI::runTest):
2340         (TestWebKitAPI::TEST):
2341
2342 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2343
2344         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2345         https://bugs.webkit.org/show_bug.cgi?id=194168
2346
2347         Reviewed by Simon Fraser.
2348
2349         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2350
2351         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2352         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2353         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2354         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2355         (TEST):
2356         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2357         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2358
2359 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2360
2361         REGRESSION (r237269): webkit-patch what-broke is broken 
2362         https://bugs.webkit.org/show_bug.cgi?id=193025
2363
2364         Reviewed by Aakash Jain.
2365
2366         * Scripts/webkitpy/common/host.py:
2367         (Host.buildbot):
2368         (Host.bugzilla): Renamed to 'buildbot'.
2369
2370 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2371
2372         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2373         https://bugs.webkit.org/show_bug.cgi?id=194207
2374
2375         Reviewed by Tim Horton.
2376
2377         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2378         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2379         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2380         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2381         start and delete forwards to remove the original attachment.
2382
2383         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2384         (TestWebKitAPI::TEST):
2385
2386 2019-02-04  Youenn Fablet  <youenn@apple.com>
2387
2388         Capture state should be managed consistently when doing process swapping
2389         https://bugs.webkit.org/show_bug.cgi?id=194122
2390         <rdar://problem/47609293>
2391
2392         Reviewed by Eric Carlson.
2393
2394         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2395         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2396         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2397         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2398         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2399         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2400         (WTR::TestRunner::isDoingMediaCapture const):
2401         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2402         * WebKitTestRunner/TestController.cpp:
2403         (WTR::TestController::isDoingMediaCapture const):
2404         * WebKitTestRunner/TestController.h:
2405         * WebKitTestRunner/TestInvocation.cpp:
2406         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2407         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2408         (WTR::TestController::isDoingMediaCapture const):
2409
2410 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2411
2412         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2413         https://bugs.webkit.org/show_bug.cgi?id=194142
2414
2415         Reviewed by Ross Kirsling.
2416
2417         There three 'separator' variables in TestController.cpp. Renamed
2418         it 'pathSeparator', and unified them.
2419
2420         * WebKitTestRunner/TestController.cpp:
2421         (WTR::TestController::generateContextConfiguration const):
2422         (WTR::createTestURL):
2423         (WTR::TestController::platformAdjustContext):
2424
2425 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2426
2427         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2428         https://bugs.webkit.org/show_bug.cgi?id=194198
2429
2430         Reviewed by Antti Koivisto.
2431
2432         No need to set the banner heights on navigation now, since Page stores them.
2433
2434         * MiniBrowser/mac/WK2BrowserWindowController.m:
2435         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2436
2437 2019-02-03  John Wilander  <wilander@apple.com>
2438
2439         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2440         https://bugs.webkit.org/show_bug.cgi?id=194104
2441         <rdar://problem/47649991>
2442
2443         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2444
2445         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2446         (TestWebKitAPI::TEST):
2447             Changed numeric types from unsigned short to uint32_t.
2448
2449 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2450
2451         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2452         <https://webkit.org/b/194178>
2453         <rdar://problem/47753473>
2454
2455         Reviewed by Alexey Proskuryakov.
2456
2457         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2458         (WTR::uninstallFakeHelvetica): Pass nullptr into
2459         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2460
2461 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2462
2463         [LFC] Initialize ICB's style with fixed width/height.
2464         https://bugs.webkit.org/show_bug.cgi?id=194188
2465
2466         Reviewed by Antti Koivisto.
2467
2468         * LayoutReloaded/misc/LFC-passing-tests.txt:
2469
2470 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2471
2472         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2473         https://bugs.webkit.org/show_bug.cgi?id=194185
2474
2475         Reviewed by Antti Koivisto.
2476
2477         * LayoutReloaded/misc/LFC-passing-tests.txt:
2478
2479 2018-12-16  Darin Adler  <darin@apple.com>
2480
2481         Convert additional String::format clients to alternative approaches
2482         https://bugs.webkit.org/show_bug.cgi?id=192746
2483
2484         Reviewed by Alexey Proskuryakov.
2485
2486         * WebKitTestRunner/TestController.cpp:
2487         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2488         as an intermediate in code that ultimately constructs a WTF::String.
2489         (WTR::userMediaOriginHash): Use makeString.
2490         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2491         (WTR::TestController::didPerformClientRedirect): Ditto.
2492         (WTR::TestController::didPerformServerRedirect): Ditto.
2493         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2494
2495 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2496
2497         [ews-build] Add unit test to verify builder keys
2498         https://bugs.webkit.org/show_bug.cgi?id=194152
2499
2500         Reviewed by Lucas Forschler.
2501
2502         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2503         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2504
2505 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2506
2507         [LFC] Expand tests coverage (12 new tests -> 787)
2508
2509         Unreviewed test gardening.
2510
2511         * LayoutReloaded/misc/LFC-passing-tests.txt:
2512
2513 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2514
2515         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2516         https://bugs.webkit.org/show_bug.cgi?id=194163
2517
2518         Reviewed by Simon Fraser.
2519
2520         775
2521
2522         * LayoutReloaded/misc/LFC-passing-tests.txt:
2523
2524 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2525
2526         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2527         https://bugs.webkit.org/show_bug.cgi?id=194140
2528         <rdar://problem/47728098>
2529
2530         Reviewed by Tim Horton.
2531
2532         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2533         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2534         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2535
2536         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2537         test to induce an IPC deadlock when presenting a modal alert during touch start.
2538
2539         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2540         * WebKitTestRunner/TestController.cpp:
2541         (WTR::runJavaScriptAlert):
2542
2543         Add a client callback function for running JavaScript alerts.
2544
2545         (WTR::TestController::createOtherPage):
2546         (WTR::TestController::generateContextConfiguration const):
2547
2548         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2549         the fix in this patch.
2550
2551         (WTR::TestController::createWebViewWithOptions):
2552
2553         Plumb TestOptions to generateContextConfiguration.
2554
2555         (WTR::TestController::resetPreferencesToConsistentValues):
2556         (WTR::TestController::resetStateToConsistentValues):
2557         (WTR::updateTestOptionsFromTestHeader):
2558         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2559         (WTR::TestController::handleJavaScriptAlert):
2560         * WebKitTestRunner/TestController.h:
2561         * WebKitTestRunner/TestInvocation.cpp:
2562         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2563         * WebKitTestRunner/TestOptions.h:
2564         (WTR::TestOptions::hasSameInitializationOptions const):
2565
2566 2019-02-01  Chris Dumez  <cdumez@apple.com>
2567
2568         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2569         https://bugs.webkit.org/show_bug.cgi?id=193740
2570         <rdar://problem/47527267>
2571
2572         Reviewed by Alex Christensen.
2573
2574         Add API test coverage.
2575
2576         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2577
2578 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2579
2580         [ews-app] Add display name field to BuilderMapping model
2581         https://bugs.webkit.org/show_bug.cgi?id=194153
2582
2583         Reviewed by Lucas Forschler.
2584
2585         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2586         (BuilderMapping):
2587
2588 2019-02-01  Youenn Fablet  <youenn@apple.com>
2589
2590         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2591         https://bugs.webkit.org/show_bug.cgi?id=194155
2592
2593         Reviewed by Eric Carlson.
2594
2595         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2596         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2597         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2598
2599 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2600
2601         [LFC] Adjust replaced element's intrinsic ratio
2602         https://bugs.webkit.org/show_bug.cgi?id=194154
2603
2604         Reviewed by Antti Koivisto.
2605
2606         761
2607
2608         * LayoutReloaded/misc/LFC-passing-tests.txt:
2609
2610 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2611
2612         [WPE] Show test results in minibrowser
2613         https://bugs.webkit.org/show_bug.cgi?id=194150
2614
2615         Reviewed by Žan Doberšek.
2616
2617         * Scripts/webkitpy/port/wpe.py:
2618         (WPEPort.show_results_html_file):
2619
2620 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2621
2622         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2623         https://bugs.webkit.org/show_bug.cgi?id=194151
2624
2625         Reviewed by Žan Doberšek.
2626
2627         ALT + <- go back
2628         ALT + -> go forward
2629
2630         * MiniBrowser/wpe/main.cpp:
2631         (main):
2632
2633 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2634
2635         [LFC] Set intrinsic size on Layout::Replaced
2636         https://bugs.webkit.org/show_bug.cgi?id=194139
2637
2638         Reviewed by Antti Koivisto.
2639
2640         744
2641
2642         * LayoutReloaded/misc/LFC-passing-tests.txt:
2643
2644 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2645
2646         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2647         https://bugs.webkit.org/show_bug.cgi?id=194146
2648
2649         Reviewed by Xabier Rodriguez-Calvar.
2650
2651         It allows to open relative paths.
2652
2653         * MiniBrowser/wpe/main.cpp:
2654         (main):
2655
2656 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2657
2658         Update flakiness dashboard configuration after recent queue changes
2659         https://bugs.webkit.org/show_bug.cgi?id=194127
2660
2661         Rubber-stamped by Aakash Jain.
2662
2663         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2664
2665         * TestResultServer/static-dashboards/builders.jsonp:
2666
2667 2019-01-31  Youenn Fablet  <youenn@apple.com>
2668
2669         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2670         https://bugs.webkit.org/show_bug.cgi?id=194106
2671         <rdar://problem/47676333>
2672
2673         Reviewed by Ryosuke Niwa.
2674
2675         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2676         (TestWebKitAPI::didFinishNavigation):
2677         (TestWebKitAPI::TEST):
2678         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2679
2680 2019-01-31  Chris Dumez  <cdumez@apple.com>
2681
2682         Page zoom level is lost after a process swap or a crash
2683         https://bugs.webkit.org/show_bug.cgi?id=194105
2684         <rdar://problem/47610781>
2685
2686         Reviewed by Alex Christensen.
2687
2688         Add API test coverage.
2689
2690         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2691         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2692
2693 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2694
2695         Revert r238819 which is unneeded and caused a performance regression.
2696         https://bugs.webkit.org/show_bug.cgi?id=192272
2697         <rdar://problem/46664625>
2698
2699         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2700         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2701         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2702
2703 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2704
2705         Formalize WebKitAdditions mechanism of LoadOptimizer
2706         https://bugs.webkit.org/show_bug.cgi?id=193886
2707         <rdar://problem/47696809>
2708
2709         Reviewed by Brent Fulgham.
2710
2711         * MiniBrowser/MiniBrowser.entitlements:
2712         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2713
2714 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2715
2716         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2717         https://bugs.webkit.org/show_bug.cgi?id=194090
2718
2719         Reviewed by Antti Koivisto.
2720
2721         * LayoutReloaded/misc/LFC-passing-tests.txt:
2722
2723 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2724
2725         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2726         https://bugs.webkit.org/show_bug.cgi?id=194074
2727
2728         Reviewed by Antti Koivisto.
2729
2730         * LayoutReloaded/misc/LFC-passing-tests.txt:
2731
2732 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2733
2734         [LFC][BFC] Add support for block level replaced box.
2735         https://bugs.webkit.org/show_bug.cgi?id=194071
2736
2737         Reviewed by Antti Koivisto.
2738
2739         * LayoutReloaded/misc/LFC-passing-tests.txt:
2740
2741 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2742
2743         Fix WebKitTestRunner's testPath with Windows full paths
2744         https://bugs.webkit.org/show_bug.cgi?id=194012
2745
2746         Reviewed by Alex Christensen.
2747
2748         updateTestOptionsFromTestHeader failed to open test files because
2749         testPath returned wrong file paths. It returned a path "/C:/..."
2750         if a URL "file:///C:/..." was given.
2751
2752         * WebKitTestRunner/TestController.cpp:
2753         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2754
2755 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2756
2757         [WPE] Bump font related dependencies to match the GTK+ port
2758         https://bugs.webkit.org/show_bug.cgi?id=194017
2759
2760         Reviewed by Žan Doberšek.
2761
2762         * wpe/jhbuild.modules:
2763         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2764         * wpe/patches/icudata-stdlibs.patch: Added.
2765
2766 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2767
2768         Enable swipe tests on iOS
2769         https://bugs.webkit.org/show_bug.cgi?id=194076
2770
2771         Reviewed by Geoffrey Garen.
2772
2773         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2774         it causes a debug assertion failure in runUIScript.
2775
2776         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2777         (WTR::UIScriptController::beginBackSwipe):
2778         (WTR::UIScriptController::completeBackSwipe):
2779
2780 2019-01-30  Keith Rollin  <krollin@apple.com>
2781
2782         Use correct printf format specifier
2783         https://bugs.webkit.org/show_bug.cgi?id=194062
2784         <rdar://problem/47686167>
2785
2786         Reviewed by Alexey Proskuryakov.
2787
2788         LayoutTestSpellChecker.mm is trying to format a variable of type
2789         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2790         actually an unsigned long long. Fix this by formatting with %llu.
2791
2792         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2793         (-[LayoutTestTextCheckingResult description]):
2794
2795 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2796
2797         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2798         https://bugs.webkit.org/show_bug.cgi?id=193979
2799
2800         Reviewed by Wenson Hsieh.
2801
2802         Fix the test for iOS. Make the test work with iOS UA string.
2803
2804         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2805
2806 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2807
2808         Replace High Sierra LLINT CLoop bot due to hardware failure
2809         https://bugs.webkit.org/show_bug.cgi?id=194066
2810
2811         Reviewed by Aakash Jain.
2812
2813         * BuildSlaveSupport/build.webkit.org-config/config.json:
2814
2815 2019-01-30  Keith Rollin  <krollin@apple.com>
2816
2817         [NSDragItem init] is unavailable
2818         https://bugs.webkit.org/show_bug.cgi?id=194059
2819         <rdar://problem/47685715>
2820
2821         Reviewed by Wenson Hsieh.
2822
2823         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2824         DumpRenderTree and TestWebKitAPI, which both try to create an
2825         NSDragItem in a manner that invokes this method. Address this by using
2826         -initWithPasteboardWriter instead.
2827
2828         Note that the parameter passed to initWithPasteboardWriter is likely
2829         incorrect. In both cases, the object passed does not conform to
2830         NSPasteboardWriting. However, with this fix, we're no worse off than
2831         before, and can now perform builds with newer compilers and SDKs until
2832         a real fix can be crafted. That work is tracked in
2833         https://bugs.webkit.org/show_bug.cgi?id=194060
2834
2835         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2836         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2837         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2838         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2839
2840 2019-01-30  Daniel Bates  <dabates@apple.com>
2841
2842         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2843         https://bugs.webkit.org/show_bug.cgi?id=192824
2844         <rdar://problem/47100332>
2845
2846         Reviewed by Wenson Hsieh.
2847
2848         Fix a bug where the wrong usage code was used for F13 thru F24.
2849
2850         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2851         (keyCodeForDOMFunctionKey):
2852
2853 2019-01-30  Chris Dumez  <cdumez@apple.com>
2854
2855         Regression(PSON) Load hang can occur on history navigation
2856         https://bugs.webkit.org/show_bug.cgi?id=194030
2857         <rdar://problem/47656939>
2858
2859         Reviewed by Antti Koivisto.
2860
2861         Add API test coverage.
2862
2863         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2864
2865 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2866
2867         [LFC] Expand tests coverage.
2868
2869         Unreviewed test gardening.
2870
2871         * LayoutReloaded/misc/LFC-passing-tests.txt:
2872
2873 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2874
2875         [Flatpak] Add openjpeg support
2876         https://bugs.webkit.org/show_bug.cgi?id=194019
2877
2878         Reviewed by Michael Catanzaro.
2879
2880         * flatpak/org.webkit.CommonModules.yaml:
2881
2882 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2883
2884         Unreviewed, rolling out r240708.
2885         https://bugs.webkit.org/show_bug.cgi?id=194022
2886
2887         It broke WPE build (Requested by KaL on #webkit).
2888
2889         Reverted changeset:
2890
2891         "[WPE] Bump font related dependencies to match the GTK+ port"
2892         https://bugs.webkit.org/show_bug.cgi?id=194017
2893         https://trac.webkit.org/changeset/240708
2894
2895 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2896
2897         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2898         https://bugs.webkit.org/show_bug.cgi?id=194001
2899
2900         Reviewed by Antti Koivisto.
2901
2902         * LayoutReloaded/misc/LFC-passing-tests.txt:
2903
2904 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2905
2906         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2907         https://bugs.webkit.org/show_bug.cgi?id=194020
2908
2909         Reviewed by Antti Koivisto.
2910
2911         * LayoutReloaded/misc/LFC-passing-tests.txt:
2912
2913 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2914
2915         AX: Support color well on iOS
2916         https://bugs.webkit.org/show_bug.cgi?id=194010
2917
2918         Reviewed by Joanmarie Diggs.
2919
2920         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2921         (WTR::AccessibilityUIElement::stringAttributeValue):
2922
2923 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2924
2925         [WPE] Bump font related dependencies to match the GTK+ port
2926         https://bugs.webkit.org/show_bug.cgi?id=194017
2927
2928         Reviewed by Žan Doberšek.
2929
2930         * wpe/jhbuild.modules:
2931         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2932         * wpe/patches/icudata-stdlibs.patch: Added.
2933
2934 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2935
2936         [Mac] Update window scale API usage
2937         https://bugs.webkit.org/show_bug.cgi?id=193991
2938         rdar://problem/47614795
2939
2940         Reviewed by Tim Horton.
2941
2942         * DumpRenderTree/mac/DumpRenderTree.mm:
2943         (changeWindowScaleIfNeeded):
2944         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2945         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2946         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2947
2948 2019-01-29  Chris Dumez  <cdumez@apple.com>
2949
2950         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2951         https://bugs.webkit.org/show_bug.cgi?id=193977
2952         <rdar://problem/47643716>
2953
2954         Reviewed by Geoff Garen.
2955
2956         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2957         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2958         to the previous provisional committing *before* we make the last load. 
2959
2960         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2961
2962 2019-01-29  Youenn Fablet  <youenn@apple.com>
2963
2964         Adopt new SPI to evaluate server certificate trust
2965         https://bugs.webkit.org/show_bug.cgi?id=193355
2966
2967         Reviewed by Alex Christensen.
2968
2969         Add infrastructure to handle HTTPS server trust evaluation testing.
2970
2971         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2972         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2973         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2974         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2975         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2976         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2977         * WebKitTestRunner/TestController.cpp:
2978         (WTR::TestController::resetPreferencesToConsistentValues):
2979         (WTR::TestController::didReceiveAuthenticationChallenge):
2980         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2981         * WebKitTestRunner/TestController.h:
2982         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2983         * WebKitTestRunner/TestInvocation.cpp:
2984         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2985         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2986         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2987
2988 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2989
2990         [ews-build] Add build step to print bot Configuration
2991         https://bugs.webkit.org/show_bug.cgi?id=193887
2992
2993         Reviewed by Lucas Forschler.
2994
2995         * BuildSlaveSupport/ews-build/steps.py:
2996         (PrintConfiguration): Build step to print configuration.
2997         * BuildSlaveSupport/ews-build/factories.py:
2998
2999 2019-01-29  Chris Dumez  <cdumez@apple.com>
3000
3001         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3002         https://bugs.webkit.org/show_bug.cgi?id=193967
3003         <rdar://problem/47635348>
3004
3005         Reviewed by Alex Christensen.
3006
3007         Add API test coverage.
3008
3009         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3010         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3011
3012 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3013
3014         [ews-app] Handle incoming results data
3015         https://bugs.webkit.org/show_bug.cgi?id=193973
3016
3017         Reviewed by Lucas Forschler.
3018
3019         * BuildSlaveSupport/ews-app/ews/views/results.py:
3020
3021 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3022
3023         [ews-app] Make the results url generic
3024         https://bugs.webkit.org/show_bug.cgi?id=193928
3025
3026         Reviewed by Lucas Forschler.
3027
3028         * BuildSlaveSupport/ews-app/ews/urls.py:
3029
3030 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3031
3032         [ews-build] Configure buildbot to send events to ews-app
3033         https://bugs.webkit.org/show_bug.cgi?id=193968
3034
3035         Reviewed by Lucas Forschler.
3036
3037         * BuildSlaveSupport/ews-build/events.py: Added.
3038         * BuildSlaveSupport/ews-build/master.cfg:
3039
3040 2019-01-29  Keith Rollin  <krollin@apple.com>
3041
3042         Add .xcfilelists to Run Script build phases
3043         https://bugs.webkit.org/show_bug.cgi?id=193792
3044         <rdar://problem/47201785>
3045
3046         Reviewed by Alex Christensen.
3047
3048         As part of supporting XCBuild, update the necessary Run Script build
3049         phases in their Xcode projects to refer to their associated
3050         .xcfilelist files.
3051
3052         Note that the addition of these files bumps the Xcode project version
3053         number to something that's Xcode 10 compatible. This change means that
3054         older versions of the Xcode IDE can't read these projects. Nor can it
3055         fully load workspaces that refer to these projects (the updated
3056         projects are shown as non-expandable placeholders). `xcodebuild` can
3057         still build these projects; it's just that the IDE can't open them.
3058
3059         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3060         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3061
3062 2019-01-29  John Wilander  <wilander@apple.com>
3063
3064         Add data abstraction and validation for Ad Click Attribution
3065         https://bugs.webkit.org/show_bug.cgi?id=193916
3066         <rdar://problem/47603481>
3067
3068         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3069
3070         Ad click attribution has two steps. First, the storage of an ad
3071         campaign ID for a click that takes the user to a destination
3072         site. Second, a conversion on the destination site that can be
3073         attributed to the ad click.
3074
3075         This patch adds a class that represents a request for ad click
3076         attribution. Validation makes sure that the bits of entropy
3077         reported through this mechanism is limited.
3078
3079         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3080         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3081         (TestWebKitAPI::TEST):
3082
3083 2019-01-29  Chris Dumez  <cdumez@apple.com>
3084
3085         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3086         https://bugs.webkit.org/show_bug.cgi?id=193932
3087         <rdar://problem/47598947>
3088
3089         Reviewed by Brady Eidson.
3090
3091         Add API test coverage.
3092
3093         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3094
3095 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3096
3097         Adding new passing LFC tests.
3098
3099         Unreviewed test gardening.
3100
3101         * LayoutReloaded/misc/LFC-passing-tests.txt:
3102
3103 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3104
3105         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3106         https://bugs.webkit.org/show_bug.cgi?id=193964
3107
3108         Reviewed by Antti Koivisto.
3109
3110         * LayoutReloaded/misc/LFC-passing-tests.txt:
3111
3112 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3113
3114         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3115         https://bugs.webkit.org/show_bug.cgi?id=193954
3116
3117         Reviewed by Antti Koivisto.
3118
3119         * LayoutReloaded/misc/LFC-passing-tests.txt:
3120
3121 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3122
3123         WebDriver: add support for running subtests
3124         https://bugs.webkit.org/show_bug.cgi?id=193904
3125
3126         Reviewed by Michael Catanzaro.
3127
3128         pytest already supports it by passing test.py::subtest, so we can do the same.
3129
3130         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3131         (get_item_name): Made this global.
3132         (CollectRecorder.__init__): Receive the parameter to ignore.
3133         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3134         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3135         (collect): Add parameter to ignore.
3136         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3137         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3138         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3139         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3140         (WebDriverTestRunnerSelenium.run): Ditto.
3141         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3142         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3143         (WebDriverTestRunnerW3C.run): Ditto.
3144
3145 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3146
3147         User agent string override for navigator.userAgent should be site specific quirks
3148         https://bugs.webkit.org/show_bug.cgi?id=193950
3149
3150         Reviewed by Brent Fulgham.
3151
3152         Updated per the _WKWebsitePolicies rename.
3153
3154         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3155         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3156
3157 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3158
3159         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3160         https://bugs.webkit.org/show_bug.cgi?id=193941
3161
3162         Reviewed by Alex Christensen.
3163
3164         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3165         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3166         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3167         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3168         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3169         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3170         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3171         * TestWebKitAPI/Tests/WTF/Time.cpp:
3172         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3173         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3174         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3175         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3176
3177 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3178
3179         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3180
3181         * Scripts/webkitpy/common/config/contributors.json:
3182
3183 2019-01-28  Andy Estes  <aestes@apple.com>
3184
3185         [watchOS] Enable Parental Controls content filtering
3186         https://bugs.webkit.org/show_bug.cgi?id=193939
3187         <rdar://problem/46641912>
3188
3189         Reviewed by Ryosuke Niwa.
3190
3191         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3192
3193 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3194
3195         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3196         <https://webkit.org/b/193884>
3197
3198         Reviewed by Jiewen Tan.
3199
3200         * Scripts/webkitpy/style/checkers/cpp.py:
3201         (check_language): Add LocalAuthentication to
3202         `frameworks_with_soft_links`.
3203
3204 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3205
3206         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3207         https://bugs.webkit.org/show_bug.cgi?id=193891
3208
3209         Reviewed by Ross Kirsling.
3210
3211         There were three problems in window sizes of WebView and the host window.
3212         1. The sizes of pixel image output were incorrect.
3213         2. The host window is going to appear after window.resize was invoked.
3214         3. window.resize resized only the host window, not WebView.
3215
3216         This change solves them with a following approach.
3217         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3218         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3219            as well as DumpRenderTree in order to match the client area and the window area.
3220         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3221         d. PlatformWebView::setWindowFrame changes both window sizes.
3222         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3223
3224         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3225         (WTR::PlatformWebView::PlatformWebView): Create the host window
3226         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3227         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3228         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3229
3230 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3231
3232         [ews-app] Add method to save Step data to database
3233         https://bugs.webkit.org/show_bug.cgi?id=193890
3234
3235         Reviewed by Lucas Forschler.
3236
3237         * BuildSlaveSupport/ews-app/ews/models/step.py:
3238         (Step.save_step): Method to save step data.
3239         (Step.update_step): Method to update step data.
3240         (Step.get_existing_step): Method to fetch existing step from database.
3241         (Step.is_valid_result): Method to validate valid step result.
3242
3243 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3244
3245         [ews-app] Add method to save Build data to database
3246         https://bugs.webkit.org/show_bug.cgi?id=193735
3247
3248         Reviewed by Lucas Forschler.
3249
3250         * BuildSlaveSupport/ews-app/ews/models/build.py:
3251         (Build.save_build): Method to save build information to database.
3252         (Build.get_existing_build): Method to fetch existing build from database.
3253         (Build.is_valid_result): Method to validate build result.
3254         * BuildSlaveSupport/ews-app/ews/common/util.py:
3255         (is_valid_int_id): Method to validate valid id.
3256
3257 2019-01-28  Chris Dumez  <cdumez@apple.com>
3258
3259         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3260         https://bugs.webkit.org/show_bug.cgi?id=193915
3261         <rdar://problem/47560907>
3262
3263         Reviewed by Alex Christensen.
3264
3265         Add API test coverage.
3266
3267         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3268
3269 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3270
3271         [ews-app] Rename id variables
3272         https://bugs.webkit.org/show_bug.cgi?id=193883
3273
3274         Reviewed by Lucas Forschler.
3275
3276         * BuildSlaveSupport/ews-app/ews/models/build.py:
3277         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3278         * BuildSlaveSupport/ews-app/ews/models/step.py:
3279         * BuildSlaveSupport/ews-app/ews/urls.py:
3280         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3281         * BuildSlaveSupport/ews-app/ews/views/results.py:
3282         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3283
3284 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3285
3286         [ews-app] Allow certain fields to be empty
3287         https://bugs.webkit.org/show_bug.cgi?id=193892
3288
3289         Reviewed by Lucas Forschler.
3290
3291         * BuildSlaveSupport/ews-app/ews/models/build.py:
3292         * BuildSlaveSupport/ews-app/ews/models/step.py:
3293
3294 2019-01-28  Rob Buis  <rbuis@igalia.com>
3295
3296         Update MIME type parser
3297         https://bugs.webkit.org/show_bug.cgi?id=180526
3298
3299         Reviewed by Frédéric Wang.
3300
3301         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3302         (TestWebKitAPI::TEST):
3303
3304 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3305
3306         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3307         https://bugs.webkit.org/show_bug.cgi?id=193896
3308
3309         Reviewed by Antti Koivisto.
3310
3311         * LayoutReloaded/misc/LFC-passing-tests.txt:
3312
3313 2018-12-15  Darin Adler  <darin@apple.com>
3314
3315         Replace many uses of String::format with more type-safe alternatives
3316         https://bugs.webkit.org/show_bug.cgi?id=192742
3317
3318         Reviewed by Mark Lam.
3319
3320         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3321         (WTR::cacheTestRunnerCallback): Use makeString.
3322         * WebKitTestRunner/TestController.cpp:
3323         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3324         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3325
3326 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3327
3328         Use a load optimizer for some sites
3329         https://bugs.webkit.org/show_bug.cgi?id=193881
3330         <rdar://problem/46325455>
3331
3332         Reviewed by Brent Fulgham.
3333
3334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3335         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3336
3337 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3338
3339         AX: Introduce a static accessibility tree
3340         https://bugs.webkit.org/show_bug.cgi?id=193348
3341         <rdar://problem/47203295>
3342
3343         Reviewed by Ryosuke Niwa.
3344
3345         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3346
3347 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3348
3349         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3350         https://bugs.webkit.org/show_bug.cgi?id=193867
3351
3352         Reviewed by Antti Koivisto.
3353
3354         * LayoutReloaded/misc/LFC-passing-tests.txt:
3355
3356 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3357
3358         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3359         https://bugs.webkit.org/show_bug.cgi?id=193865
3360
3361         Reviewed by Antti Koivisto.
3362
3363         * LayoutReloaded/misc/LFC-passing-tests.txt:
3364
3365 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3366
3367         Need a mechanism to override navigator.userAgent
3368         https://bugs.webkit.org/show_bug.cgi?id=193762
3369         <rdar://problem/47504939>
3370
3371         Reviewed by Brent Fulgham.
3372
3373         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3374
3375         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3376         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3377         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3378
3379 2019-01-25  Dean Jackson  <dino@apple.com>
3380
3381         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3382         https://bugs.webkit.org/show_bug.cgi?id=193831
3383         <rdar://problem/47399263>
3384
3385         Reviewed by Chris Dumez.
3386
3387         Two new tests that exercise cross-origin and same-origin System
3388         Previews.
3389
3390         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3391
3392 2019-01-25  Keith Rollin  <krollin@apple.com>
3393
3394         Update Xcode projects with "Check .xcfilelists" build phase
3395         https://bugs.webkit.org/show_bug.cgi?id=193790
3396         <rdar://problem/47201374>
3397
3398         Reviewed by Alex Christensen.
3399
3400         Support for XCBuild includes specifying inputs and outputs to various
3401         Run Script build phases. These inputs and outputs are specified as
3402         .xcfilelist files. Once created, these .xcfilelist files need to be
3403         kept up-to-date. In order to check that they are up-to-date or not,
3404         add an Xcode build step that invokes an external script that performs
3405         the checking. If the .xcfilelists are found to be out-of-date, update
3406         them, halt the build, and instruct the developer to restart the build
3407         with up-to-date files.
3408
3409         At this time, the checking and regenerating is performed only if the
3410         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3411         who want to use this facility can set this variable and test out the
3412         checking/regenerating. Once it seems like there are no egregious
3413         issues that upset a developer's workflow, we'll unconditionally enable
3414         this facility.
3415
3416         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3417         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3418         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3419         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3420
3421 2019-01-25  Keith Rollin  <krollin@apple.com>
3422
3423         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3424         https://bugs.webkit.org/show_bug.cgi?id=193781
3425         <rdar://problem/47201153>
3426
3427         Reviewed by Alex Christensen.
3428
3429         Part of generating the .xcfilelists used as part of adopting XCBuild
3430         includes running `make DerivedSources.make` from a standalone script.
3431         It’s important for this invocation to have the same environment as
3432         when the actual build invokes `make DerivedSources.make`. If the
3433         environments are different, then the two invocations will provide
3434         different results. In order to get the same environment in the
3435         standalone script, have the script launch xcodebuild targeting the
3436         "Apply Configuration to XCFileLists" build target, which will then
3437         re-invoke our standalone script. The script is now running again, this
3438         time in an environment with all workspace, project, target, xcconfig
3439         and other environment variables established.
3440
3441         The "Apply Configuration to XCFileLists" build target accomplishes
3442         this task via a small embedded shell script that consists only of:
3443
3444             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3445
3446         The process that invokes "Apply Configuration to XCFileLists" first
3447         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3448         evaluated and exports it into the shell environment. When xcodebuild
3449         is invoked, it inherits the value of this variable and can `eval` the
3450         contents of that variable. Our external standalone script can then set
3451         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3452         of command-line parameters needed to restart itself in the appropriate
3453         state.
3454
3455         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3456         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3457
3458 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3459
3460         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3461         https://bugs.webkit.org/show_bug.cgi?id=193802
3462         <rdar://problem/46010580>
3463
3464         Reviewed by Andy Estes.
3465
3466         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3467         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3468         (TEST):
3469
3470 2019-01-25  Daniel Bates  <dabates@apple.com>
3471
3472         [iOS] uiController.keyDown() does not translate Control modified key
3473         https://bugs.webkit.org/show_bug.cgi?id=192898
3474
3475         Reviewed by Wenson Hsieh.
3476
3477         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3478         key translation, as applicable. Among other cases, key translation occurs when performing
3479         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3480         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3481         human pressing down and releasing key(s) using a hardware keyboard.
3482
3483         * WebKitTestRunner/ios/HIDEventGenerator.h:
3484         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3485         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3486
3487         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3488         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3489         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3490         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3491         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3492         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3493         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3494         (-[HIDEventGenerator longPress:completionBlock:]):
3495         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3496         Update code for above renaming.
3497
3498         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3499         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3500
3501         (-[HIDEventGenerator keyDown:]): Added.
3502         (-[HIDEventGenerator keyUp:]): Added.
3503         (-[HIDEventGenerator keyPress:completionBlock:]):
3504         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3505         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3506         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3507         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3508         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3509         (WTR::parseModifier): Deleted.
3510
3511 2019-01-25  Keith Rollin  <krollin@apple.com>
3512
3513         Complete the implementation of generate-xcfilelists
3514         https://bugs.webkit.org/show_bug.cgi?id=193782
3515
3516         Reviewed by Alex Christensen.
3517
3518         A preliminary version of generate-xcfilelists was added in r238008.
3519         This patch updates that script in order to:
3520
3521         - Support checking of .xcfilelists
3522         - Perform better execution of `make DerivedSources.make` by
3523           relaunching generate-xcfilelists under xcodebuild
3524         - Support incremental generation and checking of .xcfilelists
3525         - Support supplementary .xcfilelists files from WebKitAdditions
3526         - Support being wrapped by parallel version of generate-xcfilelists in
3527           Internal that adds support for (re)generating WebKit projects in
3528           that repo.
3529         - Support builds that have been performed in WebKitBuild as well as
3530           ~/Library/Developer/code/DerivedData
3531         - Increase robustness and debugging facilities.
3532
3533         * Scripts/generate-xcfilelists:
3534
3535 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3536
3537         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3538         https://bugs.webkit.org/show_bug.cgi?id=193297
3539         <rdar://problem/47158841>
3540
3541         Unreviewed test case fix.
3542
3543         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3544         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3545
3546         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3547         (TEST):
3548
3549 2019-01-25  Keith Rollin  <krollin@apple.com>
3550
3551         Update existing .xcfilelists
3552         https://bugs.webkit.org/show_bug.cgi?id=193791
3553         <rdar://problem/47201706>
3554
3555         Reviewed by Alex Christensen.
3556
3557         Many .xcfilelist files were added in r238824 in order to support
3558         XCBuild. Update these with recent changes to the set of build files
3559         and with the current generate-xcfilelist script.
3560
3561         * DumpRenderTree/DerivedSources-input.xcfilelist:
3562         * DumpRenderTree/DerivedSources-output.xcfilelist:
3563         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3564         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3565
3566 2019-01-25  Keith Rollin  <krollin@apple.com>
3567
3568         Fix missing dependencies in extract-dependencies-from-makefile
3569         https://bugs.webkit.org/show_bug.cgi?id=193783
3570         <rdar://problem/47201571>
3571
3572         Reviewed by Alex Christensen.
3573
3574         The extract-dependencies-from-makefile script generates .xcfilelists
3575         for XCBuild by invoking a makefile in --debug mode, parsing the
3576         dependency information in the output, and extracting information
3577         regarding targets and dependents. However, the way `make` emits this
3578         dependency information is not rigorous, and so we need to determine
3579         what lines to look for and parse by trial and error. This approach
3580         didn't coriginally atch all the information we needed to collect, so
3581         update the script to look for the additional lines we now know to look
3582         for.
3583
3584         * Scripts/extract-dependencies-from-makefile:
3585         (Parser):
3586         (Parser.addTarget):
3587         (Parser.addPrereq):
3588         (Parser.doParse):
3589
3590 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3591
3592         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3593         https://bugs.webkit.org/show_bug.cgi?id=193297
3594         <rdar://problem/47158841>
3595
3596         Reviewed by Alex Christensen.
3597
3598         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3599             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3600         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3601         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3602         activating the message used to trigger the callback when it is set.
3603
3604 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3605
3606         WKWebView.goBack should reload if there is a safe browsing warning
3607         https://bugs.webkit.org/show_bug.cgi?id=193805
3608         <rdar://problem/46908216>
3609
3610         Reviewed by Geoff Garen.
3611
3612         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3613         (+[Simple3LookupContext sharedLookupContext]):
3614         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3615         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3616         (TEST):
3617
3618 2019-01-25  Chris Dumez  <cdumez@apple.com>
3619
3620         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3621         https://bugs.webkit.org/show_bug.cgi?id=193788
3622         <rdar://problem/47531231>
3623
3624         Reviewed by Alex Christensen.
3625
3626         Add API test coverage.
3627
3628         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3629         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3630
3631 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3632
3633         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3634         https://bugs.webkit.org/show_bug.cgi?id=193771
3635
3636         Unreviewed infrastructure fix.
3637
3638         * Scripts/webkitpy/port/darwin.py:
3639         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3640
3641 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3642
3643         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3644
3645 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3646
3647         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3648
3649         * Scripts/webkitpy/common/config/contributors.json:
3650
3651 2019-01-25  Chris Dumez  <cdumez@apple.com>
3652
3653         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3654         https://bugs.webkit.org/show_bug.cgi?id=193779
3655         <rdar://problem/46170903>
3656
3657         Reviewed by Antti Koivisto.
3658
3659         Add API test that quickly navigates forward to a previous process without waiting for it to
3660         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3661         the process' previous page when reconnecting the it for the forward navigation.
3662
3663         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3664
3665 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3666
3667         Need a way for JavaScript (or bundle) code to participate in undo
3668         https://bugs.webkit.org/show_bug.cgi?id=190009
3669         <rdar://problem/44807048>
3670
3671         Reviewed by Ryosuke Niwa.
3672
3673         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3674         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3675
3676         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3677         (WTR::UIScriptController::lastUndoLabel const):
3678         (WTR::UIScriptController::firstRedoLabel const):
3679         (WTR::UIScriptController::platformUndoManager const):
3680         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3681         (WTR::UIScriptController::lastUndoLabel const):
3682         (WTR::UIScriptController::firstRedoLabel const):
3683         (WTR::UIScriptController::platformUndoManager const):
3684         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3685         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3686         (WTR::UIScriptController::lastUndoLabel const):
3687         (WTR::UIScriptController::firstRedoLabel const):
3688         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3689         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3690         (WTR::UIScriptController::lastUndoLabel const):
3691         (WTR::UIScriptController::firstRedoLabel const):
3692         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3693         (WTR::UIScriptController::platformUndoManager const):
3694         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3695         (WTR::UIScriptController::platformUndoManager const):
3696
3697 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3698
3699         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3700         https://bugs.webkit.org/show_bug.cgi?id=193824
3701
3702         Reviewed by Antti Koivisto.
3703
3704         * LayoutReloaded/misc/LFC-passing-tests.txt:
3705
3706 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3707
3708         Update macOS JSC bot configurations
3709         https://bugs.webkit.org/show_bug.cgi?id=193739
3710
3711         Reviewed by Alexey Proskuryakov.
3712
3713         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3714         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3715         (BubbleQueueServer): Move JSC EWS to Mojave section.
3716         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3717         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3718         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3719
3720 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3721
3722         [Win][WebKitTestRunner] Implement EventSenderProxy
3723         https://bugs.webkit.org/show_bug.cgi?id=193755
3724
3725         Reviewed by Don Olmstead.
3726
3727         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3728         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3729         (WTR::EventSenderProxy::dispatchMessage):
3730         (WTR::EventSenderProxy::EventSenderProxy):
3731         (WTR::EventSenderProxy::mouseDown):
3732         (WTR::EventSenderProxy::mouseUp):
3733         (WTR::EventSenderProxy::mouseMoveTo):
3734         (WTR::EventSenderProxy::mouseScrollBy):
3735         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3736
3737 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3738
3739         Unreviewed fix for API test failure after r240437.
3740
3741         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3742
3743         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3744
3745 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3746
3747         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3748         https://bugs.webkit.org/show_bug.cgi?id=193787
3749         <rdar://problem/47497634>
3750
3751         Reviewed by Alexey Proskuryakov.
3752
3753         * Scripts/webkitdirs.pm:
3754         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3755
3756 2019-01-24  Truitt Savell  <tsavell@apple.com>
3757
3758         Unreviewed, rolling out r240446.
3759
3760         Casued 5 API failures
3761
3762         Reverted changeset:
3763
3764         "Activate the WebResourceLoadStatisticsStore in the
3765         NetworkProcess and deactivate it in the UIProcess."
3766         https://bugs.webkit.org/show_bug.cgi?id=193297
3767         https://trac.webkit.org/changeset/240446
3768
3769 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3770
3771         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3772         https://bugs.webkit.org/show_bug.cgi?id=193741
3773         <rdar://problem/47135030>
3774
3775         Reviewed by Antti Koivisto and Simon Fraser.
3776
3777         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3778         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3779         (TestWebKitAPI::TEST):
3780
3781 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3782
3783         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3784         https://bugs.webkit.org/show_bug.cgi?id=193297
3785         <rdar://problem/47158841>
3786
3787         Reviewed by Alex Christensen.
3788
3789         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3790         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3791         activating the message used to trigger the callback when it is set.
3792
3793 2019-01-24  John Wilander  <wilander@apple.com>
3794
3795         Add Ad Click Attribution as an internal/experimental feature
3796         https://bugs.webkit.org/show_bug.cgi?id=193685
3797         <rdar://problem/47450399>
3798
3799         Reviewed by Brent Fulgham.
3800
3801         Added test option adClickAttributionEnabled.
3802
3803         * DumpRenderTree/TestOptions.cpp:
3804         (TestOptions::TestOptions):
3805         * DumpRenderTree/TestOptions.h:
3806         * DumpRenderTree/mac/DumpRenderTree.mm:
3807         (setWebPreferencesForTestOptions):
3808
3809 2019-01-24  Antti Koivisto  <antti@apple.com>
3810
3811         [PSON] Flash on back navigation on Mac
3812         https://bugs.webkit.org/show_bug.cgi?id=193716
3813         <rdar://problem/47148458>
3814
3815         Reviewed by Chris Dumez.
3816
3817         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3818
3819         Closing of the previous page is delayed so waiting for didFinishNavigation is
3820         not sufficient to guarantee we have received all the messages. Wait for them.
3821
3822 2019-01-24  Chris Dumez  <cdumez@apple.com>
3823
3824         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3825         https://bugs.webkit.org/show_bug.cgi?id=193761
3826         <rdar://problem/47456405>
3827
3828         Reviewed by Alex Christensen.
3829
3830         Add API test coverage.
3831
3832         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3833
3834 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3835
3836         webkitpy: Missing PID in crashlog name should not be fatal
3837         https://bugs.webkit.org/show_bug.cgi?id=193771
3838
3839         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3840         of raising an exception.
3841
3842         Reviewed by Lucas Forschler.
3843
3844         * Scripts/webkitpy/port/darwin.py:
3845         (DarwinPort._merge_crash_logs):
3846
3847 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3848
3849         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3850         https://bugs.webkit.org/show_bug.cgi?id=193746
3851
3852         Reviewed by Youenn Fablet.
3853
3854         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3855         so we'd best just not call it.
3856
3857         * Scripts/webkitpy/w3c/test_exporter.py:
3858         (WebPlatformTestExporter.create_branch_with_patch):
3859
3860 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3861
3862         Move FileSystem to WTF
3863         https://bugs.webkit.org/show_bug.cgi?id=193602
3864
3865         Reviewed by Yusuke Suzuki.
3866
3867         * DumpRenderTree/win/DumpRenderTree.cpp:
3868         * TestWebKitAPI/CMakeLists.txt:
3869         * TestWebKitAPI/PlatformGTK.cmake:
3870         * TestWebKitAPI/PlatformJSCOnly.cmake:
3871         * TestWebKitAPI/PlatformPlayStation.cmake:
3872         * TestWebKitAPI/PlatformWPE.cmake:
3873         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3874         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3875         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3876         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3877         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3878         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3879         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3880         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3881         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3882         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3883
3884 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3885
3886         [WPE] Remove hard dependency on subprocess32 for the API tests
3887
3888         Rubber-stamped by Carlos Garcia Campos.
3889
3890         * glib/api_test_runner.py:
3891         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3892         its presence only when running WPEQt tests.
3893
3894 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3895
3896         [GLIB] Expose JavaScriptCore options in GLib public API
3897         https://bugs.webkit.org/show_bug.cgi?id=188742
3898
3899         Reviewed by Michael Catanzaro.
3900
3901         Add a test for the new API.
3902
3903         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3904         (testsJSCOptions):
3905         (main):
3906
3907 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3908
3909         [GTK][WPE] Support JPEG 2000 images
3910         https://bugs.webkit.org/show_bug.cgi?id=186272
3911
3912         Reviewed by Žan Doberšek.
3913
3914         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3915
3916         * gtk/jhbuild.modules:
3917         * wpe/jhbuild.modules:
3918
3919 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3920
3921         check-webkit-style should warn when using soft-linking macros in a header
3922         <https://webkit.org/b/193750>
3923
3924         Reviewed by Darin Adler.
3925
3926         * Scripts/webkitpy/style/checkers/cpp.py:
3927         (check_language): Add softlink/header check by refactoring the
3928         softlink/framework check.
3929         (CppChecker): Enable softlink/header check by default.
3930         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3931         (CppStyleTest.test_softlink_framework): Rename from
3932         CppStyleTest.test_softlink() and change test framework name in
3933         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3934         files. Set file_name for macros that only appear in headers.
3935         (CppStyleTest.test_softlink_header): Add tests for using
3936         soft-link macros in headers.
3937
3938 2019-01-23  Chris Dumez  <cdumez@apple.com>
3939
3940         Deprecate API to limit the maximum number of WebProcesses
3941         https://bugs.webkit.org/show_bug.cgi?id=193725
3942         <rdar://problem/47464879>
3943
3944         Reviewed by Geoff Garen.
3945
3946         Update existing API tests to stop using deprecated API.
3947
3948         * MiniBrowser/mac/AppDelegate.m:
3949         (defaultConfiguration):
3950         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3951         (TestWebKitAPI::TEST):
3952         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3953         (TestWebKitAPI::TEST):
3954         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3955         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3956         (TEST):
3957         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3958         (TEST):
3959
3960 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3961
3962         [ews-app] Rename ews model buildermappings to buildermapping
3963         https://bugs.webkit.org/show_bug.cgi?id=193729
3964
3965         Reviewed by Lucas Forschler.
3966
3967         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3968         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3969         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3970
3971 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3972
3973         [ews-app] Rename ews model steps to step
3974         https://bugs.webkit.org/show_bug.cgi?id=193697
3975
3976         Reviewed by Lucas Forschler.
3977
3978         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3979         (Step): Renamed Steps to Step.
3980
3981 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3982
3983         Clean up IndexedDB files between tests
3984         https://bugs.webkit.org/show_bug.cgi?id=192796
3985         <rdar://problem/46824999>
3986
3987         Reviewed by Geoffrey Garen.
3988
3989         * DumpRenderTree/mac/DumpRenderTree.mm:
3990         (runTest):
3991         * WebKitTestRunner/TestController.cpp:
3992         (WTR::TestController::resetStateToConsistentValues):
3993         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3994         (WTR::RemoveAllIndexedDatabasesCallback):
3995         (WTR::TestController::ClearIndexedDatabases):
3996         * WebKitTestRunner/TestController.h:
3997         * WebKitTestRunner/TestInvocation.cpp:
3998         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3999
4000 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4001
4002         [ews-app] Rename ews model Builds to Build
4003         https://bugs.webkit.org/show_bug.cgi?id=193695
4004
4005         Reviewed by Lucas Forschler.
4006
4007         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
4008         (Build): Renamed Builds to Build.
4009
4010 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
4011
4012         webkitpy: Wait longer when launching WebKitTestRunner
4013         https://bugs.webkit.org/show_bug.cgi?id=193734
4014
4015         Reviewed by Aakash Jain.
4016
4017         * Scripts/webkitpy/port/simulator_process.py:
4018         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
4019
4020 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
4021
4022         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
4023         https://bugs.webkit.org/show_bug.cgi?id=193182
4024         <rdar://problem/47452154>
4025
4026         Reviewed by Tim Horton.
4027
4028         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
4029         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
4030         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
4031
4032         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
4033         preventing later tests from recognizing gestures.
4034
4035         * WebKitTestRunner/ios/TestControllerIOS.mm:
4036         (WTR::TestController::platformResetStateToConsistentValues):
4037
4038         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
4039
4040 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
4041
4042         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
4043         https://bugs.webkit.org/show_bug.cgi?id=193722
4044         <rdar://problem/47481475>
4045
4046         Reviewed by Lucas Forschler.
4047
4048         iPhone and iPad ports should both use the iOS config.
4049
4050         * Scripts/webkitpy/port/ios_simulator.py:
4051         (IPhoneSimulatorPort.__init__):
4052         (IPadSimulatorPort.__init__):
4053
4054 2019-01-23  Rob Buis  <rbuis@igalia.com>
4055
4056         Update MIME type parser
4057         https://bugs.webkit.org/show_bug.cgi?id=180526
4058
4059         Reviewed by Frédéric Wang.
4060
4061         Add unit tests for both parse modes of ParsedContentType.
4062
4063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4064         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
4065         (TestWebKitAPI::TEST):
4066
4067 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
4068
4069         [ews-app] fetch loop should not stop on network issues
4070         https://bugs.webkit.org/show_bug.cgi?id=193666
4071
4072         Reviewed by Lucas Forschler.
4073
4074         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4075         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
4076
4077 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4078
4079         [iOS] Multiple WKWebViewAutofillTests are flaky failures
4080         https://bugs.webkit.org/show_bug.cgi?id=189165
4081         <rdar://problem/47433765>
4082
4083         Reviewed by Tim Horton.
4084
4085         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
4086         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
4087         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
4088         process in sufficient to ensure that any previous action that blurred the focused element in the web process
4089         would make its way to the UI process by the time the layer tree commit is finished.
4090
4091         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
4092         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
4093         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
4094         will fail because it asks for -_autofillContext too early.
4095
4096         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
4097         is handled in the UI process.
4098
4099         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
4100
4101         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
4102         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
4103         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
4104         input session.
4105
4106         (-[AutofillTestView textInputHasAutofillContext]):
4107
4108         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
4109
4110         * TestWebKitAPI/cocoa/TestWKWebView.h:
4111         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4112         (nextInputSessionChangeCount):
4113
4114         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
4115         This includes changing the focused element from one to another.
4116
4117         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
4118         (-[TestWKWebView didStartFormControlInteraction]):
4119         (-[TestWKWebView didEndFormControlInteraction]):
4120         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
4121
4122         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
4123         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
4124         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
4125         that doesn't require an input session to one that doesn't.
4126
4127 2019-01-22  David Kilzer  <ddkilzer@apple.com>
4128
4129         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
4130         <https://webkit.org/b/193676>
4131
4132         Reviewed by Alexey Proskuryakov.
4133
4134         * Scripts/webkitpy/style/checkers/cpp.py:
4135         (check_member_initialization_list):
4136         - Don't report missing whitespace around colon if the colon at
4137           the start of the line is formatted correctly.
4138         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4139         (WebKitStyleTest.test_member_initialization_list):
4140         - Add a test for a missing permutation of existing tests.
4141         - Add a test this false-positive.
4142         - Add blank lines between subtests to make them easier to read.
4143
4144 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
4145
4146         [build.webkit.org] Unit-test failure after r237113
4147         https://bugs.webkit.org/show_bug.cgi?id=193669
4148
4149         Reviewed by Michael Catanzaro.
4150
4151         * BuildSlaveSupport/build.webkit.org-config/factories.py:
4152         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
4153         multiple or zero flags.
4154
4155 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
4156
4157         Cache bytecode to disk
4158         https://bugs.webkit.org/show_bug.cgi?id=192782
4159         <rdar://problem/46084932>
4160
4161         Reviewed by Keith Miller.
4162
4163         Add test helper to execute bytecode-cache tests: it executes each test
4164         twice, the first with JSC_diskCachePath set to a temporary directory
4165         and second with JSC_forceDiskCache=true (in addition to the cache path)
4166         to guarantee that only the disk cache is being used and no new
4167         UnlinkedCodeBlocks are being created.
4168
4169         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
4170         * Scripts/run-jsc-stress-tests:
4171
4172 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
4173
4174         [css-logical] Implement flow-relative margin, padding and border shorthands
4175         https://bugs.webkit.org/show_bug.cgi?id=188697
4176
4177         Reviewed by Simon Fraser and Antti Koivisto.
4178
4179         * DumpRenderTree/TestOptions.cpp:
4180         (TestOptions::TestOptions):
4181         * DumpRenderTree/TestOptions.h:
4182         * DumpRenderTree/mac/DumpRenderTree.mm:
4183         (setWebPreferencesForTestOptions):
4184         Allow tests to enable the CSSLogicalEnabled flag in WK1.
4185
4186         * Scripts/webkitpy/style/checkers/jsonchecker.py:
4187         (JSONCSSPropertiesChecker.check_codegen_properties):
4188         Allow CSS property definitions to have a 'runtime-flag' parameter which
4189         disables the property when the specified runtime flag is disabled.
4190
4191 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
4192
4193         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
4194         https://bugs.webkit.org/show_bug.cgi?id=193643
4195
4196         Reviewed by Michael Catanzaro.
4197
4198         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
4199         * wpe/jhbuild.modules: Ditto.
4200
4201 2019-01-21  Zalan Bujtas  <zalan@apple.com>
4202
4203         [LFC][Floats] Take float top position into account when computing containing block height.
4204         https://bugs.webkit.org/show_bug.cgi?id=193655
4205
4206         Reviewed by Antti Koivisto.
4207
4208         * LayoutReloaded/misc/LFC-passing-tests.txt:
4209
4210 2019-01-21  David Kilzer  <ddkilzer@apple.com>
4211
4212         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
4213         <https://webkit.org/b/193645>
4214         <rdar://problem/47421574>
4215
4216         Reviewed by Alex Christensen.
4217
4218         - Now checks for local soft-linking of all frameworks that have
4219           their own *SoftLinking.{cpp,h,mm} files.
4220         - Changes softlink/uikit warning to softlink/framework.
4221
4222         * Scripts/webkitpy/style/checkers/cpp.py:
4223         (check_language):
4224         (CppChecker):
4225         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4226         (CppStyleTest):
4227
4228 2019-01-20  Saam Barati  <sbarati@apple.com>
4229
4230         Rollout r240210: It broke tests on iOS
4231         https://bugs.webkit.org/show_bug.cgi?id=193640
4232
4233         Unreviewed.
4234
4235         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
4236         * Scripts/run-jsc-stress-tests:
4237
4238 2019-01-20  chris fleizach  <cfleizach@apple.com>
4239
4240         AX: Support returning relative frames for accessibility
4241         https://bugs.webkit.org/show_bug.cgi?id=193414
4242         <rdar://problem/47268501>
4243
4244         Reviewed by Zalan Bujtas.
4245
4246         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4247         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4248         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4249         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4250         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4251         (WTR::attributesOfElement):
4252         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4253
4254 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
4255
4256         Unreviewed, add my new email address
4257
4258         * Scripts/webkitpy/common/config/contributors.json:
4259
4260 2019-01-19  Zalan Bujtas  <zalan@apple.com>
4261
4262         [LFC][BFC] <body>'s overflow property value is propagated to viewport
4263         https://bugs.webkit.org/show_bug.cgi?id=193617
4264
4265         Reviewed by Antti Koivisto.
4266
4267         * LayoutReloaded/misc/LFC-passing-tests.txt:
4268
4269 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
4270
4271         Unreviewed, rolling out r240209.
4272
4273         Broke GTK/WPE injected bundle
4274
4275         Reverted changeset:
4276
4277         "AX: Support returning relative frames for accessibility"
4278         https://bugs.webkit.org/show_bug.cgi?id=193414
4279         https://trac.webkit.org/changeset/240209
4280
4281 2019-01-12  Dan Bernstein  <mitz@apple.com>
4282
4283         [Cocoa] Avoid importing directly from subumbrella frameworks
4284         https://bugs.webkit.org/show_bug.cgi?id=186016
4285         <rdar://problem/40591038>
4286
4287         Reviewed by Sam Weinig.
4288
4289         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4290           LaunchServices header.
4291         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4292           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4293         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4294           when using SDKs earlier than 10.13.
4295         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4296           and OTHER_CPLUSPLUSFLAGS.
4297         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4298           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4299         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4300           LaunchServices header.
4301
4302 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
4303
4304         Cache bytecode to disk
4305         https://bugs.webkit.org/show_bug.cgi?id=192782
4306         <rdar://problem/46084932>
4307
4308         Reviewed by Keith Miller.
4309
4310         Add test helper to execute bytecode-cache tests: it executes each test
4311         twice, the first with JSC_diskCachePath set to a temporary directory
4312         and second with JSC_forceDiskCache=true (in addition to the cache path)
4313         to guarantee that only the disk cache is being used and no new
4314         UnlinkedCodeBlocks are being created.
4315
4316         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
4317         * Scripts/run-jsc-stress-tests:
4318
4319 2019-01-20  chris fleizach  <cfleizach@apple.com>
4320
4321         AX: Support returning relative frames for accessibility
4322         https://bugs.webkit.org/show_bug.cgi?id=193414
4323         <rdar://problem/47268501>
4324
4325         Reviewed by Zalan Bujtas.
4326
4327         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4328         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4329         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4330         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4331         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4332         (WTR::attributesOfElement):
4333         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4334
4335 2019-01-20  Antoine Quint  <graouts@apple.com>
4336
4337         Add a POINTER_EVENTS feature flag
4338         https://bugs.webkit.org/show_bug.cgi?id=193577
4339         <rdar://problem/47408511>
4340
4341         Unreviewed. Also enable Pointer Events for iosmac.
4342
4343         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4344
4345 2019-01-19  Zalan Bujtas  <zalan@apple.com>
4346
4347         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
4348         https://bugs.webkit.org/show_bug.cgi?id=193613
4349
4350         Reviewed by Antti Koivisto.
4351
4352         * LayoutReloaded/misc/LFC-passing-tests.txt:
4353
4354 2019-01-19  Antoine Quint  <graouts@apple.com>
4355
4356         Add a POINTER_EVENTS feature flag
4357         https://bugs.webkit.org/show_bug.cgi?id=193577
4358