Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2
3         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
4         <https://webkit.org/b/196499>
5
6         Reviewed by Alexey Proskuryakov.
7
8         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
9         ENABLE_ADDRESS_SANITIZER.
10
11 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
12
13         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
14         https://bugs.webkit.org/show_bug.cgi?id=182757
15
16         Reviewed by Don Olmstead.
17
18         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
19         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
20
21 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
22
23         run-api-tests: Upload test results
24         https://bugs.webkit.org/show_bug.cgi?id=196323
25         <rdar://problem/49356714>
26
27         Reviewed by Lucas Forschler.
28
29         * Scripts/webkitpy/api_tests/manager.py:
30         (Manager):
31         (Manager.run): Upload results to a results database.
32         * Scripts/webkitpy/api_tests/run_api_tests.py:
33         (parse_args): Add upload arguments.
34         * Scripts/webkitpy/port/base.py:
35         (Port):
36         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
37         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
38         with commits from any other associated repositories.
39         * Scripts/webkitpy/port/device.py:
40         (Device):
41         (Device.build_version): Access build_versoin of underlying platform device.
42         * Scripts/webkitpy/port/ios_simulator_unittest.py:
43         (IOSSimulatorTest):
44         (IOSSimulatorTest.test_configuration_for_upload):
45         * Scripts/webkitpy/port/device_port.py:
46         (DevicePort):
47         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
48         the same as the machine uploading results.
49         * Scripts/webkitpy/port/mac.py:
50         (MacPort):
51         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
52         * Scripts/webkitpy/port/mac_unittest.py:
53         (MacTest):
54         (MacTest.test_configuration_for_upload):
55         * Scripts/webkitpy/xcode/simulated_device.py:
56         (SimulatedDeviceManager._create_device_with_runtime):
57         (SimulatedDevice.__init__): Create simulated device with a build_version.
58         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
59         (test_existing_simulator):
60
61 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
62
63         Remove extra newline characters (Follow-up fix to r243707)
64
65         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
66
67 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
68
69         [ews-app] Use API_KEY to accept results data
70         https://bugs.webkit.org/show_bug.cgi?id=196461
71
72         Reviewed by Dewei Zhu.
73
74         * BuildSlaveSupport/ews-app/ews/views/results.py:
75         (Results.post): Validate EWS_API_KEY before accepting any data.
76         * BuildSlaveSupport/ews-build/events.py:
77         (Events.sendData): Send EWS_API_KEY if available along with event data.
78
79 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
80
81         Unable to copy and paste a PDF from Notes into Mail compose body
82         https://bugs.webkit.org/show_bug.cgi?id=196442
83         <rdar://problem/48573098>
84
85         Reviewed by Tim Horton.
86
87         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
88         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
89         to be specified on the item providers.
90
91         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
92         (TestWebKitAPI::mapItemForTesting):
93         (TestWebKitAPI::contactItemForTesting):
94
95 2019-04-01  Tim Horton  <timothy_horton@apple.com>
96
97         Make UIWKDocumentContext rects per-character instead of per-word
98         https://bugs.webkit.org/show_bug.cgi?id=196459
99
100         Reviewed by Wenson Hsieh.
101
102         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
103         (TEST):
104         Adjust test results due to switching to per-character rects.
105
106 2019-04-01  Chris Dumez  <cdumez@apple.com>
107
108         UIProcess crash when a prewarmed process is terminated
109         https://bugs.webkit.org/show_bug.cgi?id=196451
110         <rdar://problem/49245471>
111
112         Reviewed by Geoffrey Garen.
113
114         Add API test coverage.
115
116         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
117         (TEST):
118
119 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
120
121         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
122         https://bugs.webkit.org/show_bug.cgi?id=196449
123
124         Reviewed by Lucas Forschler.
125
126         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
127         (StatusBubble.get_os_details): Method to get OS and Xcode details.
128         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
129         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
130
131 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
132
133         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
134         https://bugs.webkit.org/show_bug.cgi?id=196444
135
136         Reviewed by Lucas Forschler.
137
138         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
139
140 2019-04-01  Alex Christensen  <achristensen@webkit.org>
141
142         Add SPI to canonicalize NSURLs with WTF::URL
143         https://bugs.webkit.org/show_bug.cgi?id=196415
144         <rdar://problem/44980271>
145
146         Reviewed by Darin Adler.
147
148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
149         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
150         (TestWebKitAPI::TEST):
151
152 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
153
154         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
155         https://bugs.webkit.org/show_bug.cgi?id=196441
156
157         Reviewed by Carlos Garcia Campos.
158
159         Don't cache the wpe_view_backend object that might not exist yet at the
160         time of EventSenderProxy constructor invocation, but instead retrieve
161         that object whenever it's required for event dispatching. This should
162         avoid crashes in this constructor now that it's invoked before any
163         PlatformWindow has been set up (as changed in r243496).
164
165         * WebKitTestRunner/EventSenderProxy.h:
166         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
167         (WTR::viewBackend):
168         (WTR::EventSenderProxy::EventSenderProxy):
169         (WTR::EventSenderProxy::mouseDown):
170         (WTR::EventSenderProxy::mouseUp):
171         (WTR::EventSenderProxy::mouseMoveTo):
172         (WTR::EventSenderProxy::mouseScrollBy):
173         (WTR::EventSenderProxy::keyDown):
174         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
175
176 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
177
178         [Win][WebKit] MiniBrowser should support high DPI display
179         https://bugs.webkit.org/show_bug.cgi?id=196391
180
181         Reviewed by Alex Christensen.
182
183         * MiniBrowser/win/WebKitBrowserWindow.cpp:
184         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
185         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
186         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
187
188 2019-03-31  Sam Weinig  <weinig@apple.com>
189
190         Remove more i386 specific configurations
191         https://bugs.webkit.org/show_bug.cgi?id=196430
192
193         Reviewed by Alexey Proskuryakov.
194
195         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
196         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
197
198 2019-03-31  Andy Estes  <aestes@apple.com>
199
200         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
201         https://bugs.webkit.org/show_bug.cgi?id=196433
202         <rdar://problem/49293305>
203
204         Reviewed by Tim Horton.
205
206         Enhanced API test coverage to include all navigation response policy decisions in both
207         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
208
209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
210         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
211         (TestWebKitAPI::TEST):
212         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
213         (readFile):
214         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
215         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
216         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
217         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
218         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
219         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
220         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
221         (-[QuickLookDelegate _downloadDidStart:]):
222         (-[QuickLookDelegate _download:didReceiveResponse:]):
223         (-[QuickLookDelegate _download:didReceiveData:]):
224         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
225         (-[QuickLookDelegate _downloadDidFinish:]):
226         (-[QuickLookDelegate _download:didFailWithError:]):
227         (-[QuickLookDelegate _downloadDidCancel:]):
228         (-[QuickLookDelegate verifyDownload]):
229         (runTest):
230         (runTestDecideBeforeLoading):
231         (runTestDecideAfterLoading):
232         (TEST):
233         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
234         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
235         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
236         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
237         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
238         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
239         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
240         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
241         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
242         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
243         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
244         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
245         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
246         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
247
248 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
249
250         [CMake] add testdfg as target with build-jsc
251         https://bugs.webkit.org/show_bug.cgi?id=196393
252
253         Reviewed by Saam Barati.
254
255         Added testdfg as one of the targets to build when
256         using CMake.
257
258         * Scripts/build-jsc:
259
260 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
261
262         Delete WebMetal implementation in favor of WebGPU
263         https://bugs.webkit.org/show_bug.cgi?id=195418
264
265         Reviewed by Dean Jackson.
266
267         * DumpRenderTree/mac/DumpRenderTree.mm:
268         (enableExperimentalFeatures):
269         (resetWebPreferencesToConsistentValues):
270         * Scripts/webkitperl/FeatureList.pm:
271         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
273         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
274         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
275         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
276         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
277         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
278         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
279         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
280         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
281         (WTR::InjectedBundle::beginTesting):
282         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
283         (WTR::TestRunner::setWebMetalEnabled): Deleted.
284         * WebKitTestRunner/InjectedBundle/TestRunner.h:
285
286 2019-03-29  Chris Dumez  <cdumez@apple.com>
287
288         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
289         https://bugs.webkit.org/show_bug.cgi?id=196405
290         <rdar://problem/49428130>
291
292         Reviewed by Wenson Hsieh.
293
294         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
295         the popover presentation methods to be no-ops. Use this in the new test added in
296         r243523 so that we do not swizzle those methods for all tests. This is needed because
297         those WatchOS tests rely on the popover getting presented and interactive.
298
299         * WebKitTestRunner/TestController.cpp:
300         (WTR::updateTestOptionsFromTestHeader):
301         * WebKitTestRunner/TestController.h:
302         * WebKitTestRunner/TestOptions.h:
303         (WTR::TestOptions::hasSameInitializationOptions const):
304         * WebKitTestRunner/ios/TestControllerIOS.mm:
305         (WTR::TestController::platformInitialize):
306         (WTR::TestController::platformResetStateToConsistentValues):
307
308 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
309
310         [Curl] Add Server Trust Evaluation Support.
311         https://bugs.webkit.org/show_bug.cgi?id=191646
312
313         Reviewed by Fujii Hironori.
314
315         Implemented MiniBrowser UI for asking if user trusts the server.
316
317         * MiniBrowser/win/Common.cpp:
318         (askServerTrustEvaluation):
319         (replaceString):
320         * MiniBrowser/win/Common.h:
321         * MiniBrowser/win/MiniBrowserLib.rc:
322         * MiniBrowser/win/MiniBrowserLibResource.h:
323         * MiniBrowser/win/WebKitBrowserWindow.cpp:
324         (createPEMString):
325         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
326         (WebKitBrowserWindow::canTrustServerCertificate):
327         * MiniBrowser/win/WebKitBrowserWindow.h:
328
329 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
330
331         Implement ResizeObserver.
332         https://bugs.webkit.org/show_bug.cgi?id=157743
333
334         Reviewed by Simon Fraser.
335
336         Support resizeObserverEnabled webPreferences.
337
338         * DumpRenderTree/TestOptions.cpp:
339         (TestOptions::TestOptions):
340         * DumpRenderTree/TestOptions.h:
341         * DumpRenderTree/mac/DumpRenderTree.mm:
342         (setWebPreferencesForTestOptions):
343         * DumpRenderTree/win/DumpRenderTree.cpp:
344         (enableExperimentalFeatures):
345         * Scripts/webkitperl/FeatureList.pm:
346         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
347
348 2019-03-28  John Wilander  <wilander@apple.com>
349
350         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
351         https://bugs.webkit.org/show_bug.cgi?id=196281
352         <rdar://problem/48938748>
353
354         Reviewed by Alex Christensen.
355
356         This patch adds the function isStatisticsHasLocalStorage() to the
357         TestRunner. With it, the page can query the WebsiteDataStore in the
358         UI process to make sure that it sees LocalStorage.
359
360         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
361         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
362         (WTR::TestRunner::isStatisticsHasLocalStorage):
363         * WebKitTestRunner/InjectedBundle/TestRunner.h:
364         * WebKitTestRunner/TestController.cpp:
365         (WTR::TestController::isStatisticsHasLocalStorage):
366         * WebKitTestRunner/TestController.h:
367         * WebKitTestRunner/TestInvocation.cpp:
368         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
369
370 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
371
372         API::Data::createWithoutCopying should do a null check before calling CFRelease
373         https://bugs.webkit.org/show_bug.cgi?id=196276
374         <rdar://problem/48059859>
375
376         Reviewed by Alex Christensen.
377
378         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
379
380         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
381         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
382         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
383         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
384         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
385         (TestWebKitAPI::TEST):
386
387 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
388
389         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
390         https://bugs.webkit.org/show_bug.cgi?id=186276
391
392         Reviewed by Carlos Garcia Campos.
393
394         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
395         (webViewLoadChanged):
396         (testWebResourceGetDataError):
397         (testWebResourceGetDataEmpty):
398         (beforeAll):
399         (webViewloadChanged): Deleted.
400
401 2019-03-27  Andy Estes  <aestes@apple.com>
402
403         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
404         https://bugs.webkit.org/show_bug.cgi?id=196317
405
406         Reviewed by Dan Bernstein.
407
408         package-root copies built products into a staging directory using ditto(1), which does not
409         follow symbolic links as it traverses a directory. Now that the files in
410         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
411         itself, these become broken links when ditto'd into the staging directory.
412
413         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
414
415         * Scripts/package-root:
416
417 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
418
419         [ews-app] Update display text of Submit for ews analysis
420         https://bugs.webkit.org/show_bug.cgi?id=196309
421
422         Reviewed by Dewei Zhu.
423
424         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
425
426 2019-03-27  David Kilzer  <ddkilzer@apple.com>
427
428         run-webkit-tests should check for leaks in WebKit processes
429         <https://webkit.org/b/193772>
430         <rdar://problem/46526680>
431
432         Reviewed by Ryosuke Niwa.
433
434         This works by doing the following:
435         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
436           The list of child processes are returned one per line:
437           process.name: pid
438         - Run the "#LIST CHILD PROCESSES" command just before the
439           "#CHECK FOR WORLD LEAKS" command, and store the list of child
440           processes on the ServerProcess object.
441         - When the `--leaks` switch is handled, run check_for_leaks() on
442           each child process after the main test harness.
443
444         * DumpRenderTree/mac/DumpRenderTree.mm:
445         (handleControlCommand):
446         - Use strncmp() instead of strcmp().
447         - Add support for handling "#LIST CHILD PROCESSES" command.
448
449         * Scripts/webkitpy/port/base.py:
450         (Port.check_for_leaks):
451         * Scripts/webkitpy/port/darwin.py:
452         (DarwinPort.check_for_leaks):
453         - Rename redundant 'process_pid' argument to 'process_id'.
454
455         * Scripts/webkitpy/port/driver.py:
456         (Driver.do_post_tests_work):
457         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
458           longer the only command this sends to WebKitTestRunner.
459         - If the `--leaks` switch is present, send the
460           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
461           result using Port.set_webkit_processes().
462         (Driver._parse_child_processes_output):
463         - Add helper method to parse list of child process names and
464           process IDs returned from WebKitTestRunner.
465
466         * Scripts/webkitpy/port/ios_device.py:
467         (IOSDevicePort.check_for_leaks):
468         - Rename redundant 'process_pid' argument to 'process_id'.
469
470         * Scripts/webkitpy/port/leakdetector.py:
471         (LeakDetector._parse_leaks_output):
472         - Return early if there is no leaks_output.
473         (LeakDetector.check_for_leaks):
474         - Rename redundant 'process_pid' argument to 'process_id'.
475
476         * Scripts/webkitpy/port/server_process.py:
477         (ServerProcess.__init__):
478         (ServerProcess.child_processes):
479         (ServerProcess.set_child_processes):
480         - Add instance variable to Port to store list of child process
481           names and process IDs returned from WebKitTestRunner.
482         (ServerProcess._start):
483         - Clear self._child_processes.
484         (ServerProcess.stop):
485         - If self._child_processes is set, call
486           self._port.check_for_leaks() for each child process.
487
488         * Scripts/webkitpy/port/server_process_unittest.py:
489         (TrivialMockPort.check_for_leaks):
490         - Rename redundant 'process_pid' argument to 'process_id'.
491
492         * Scripts/webkitpy/port/simulator_process.py:
493         (SimulatorProcess.stop):
494         - If self._child_processes is set, call
495           self._port.check_for_leaks() for each child process.
496
497         * Scripts/webkitpy/port/watch_device.py:
498         (WatchDevicePort.check_for_leaks):
499         - Rename redundant 'process_pid' argument to 'process_id'.
500
501         * WebKitTestRunner/TestController.cpp:
502         (WTR::TestController::dumpResponse):
503         - Extract method from findAndDumpWorldLeaks() so that it may be
504           reused by findAndDumpWebKitProcessIdentifiers().
505         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
506         - Add method to output process name and process ID of both the
507           WebContent and Networking processes.
508         (WTR::TestController::findAndDumpWorldLeaks):
509         - Fix missing newline in output when there were no abandoned
510           documents.
511         - Call dumpResponse() for extracted code.
512         (WTR::TestController::handleControlCommand):
513         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
514         - Use strncmp() instead of strcmp().
515         - Call findAndDumpWebKitProcessIdentifiers() when
516           "#LIST CHILD PROCESSES" command is sent.
517         * WebKitTestRunner/TestController.h:
518         (WTR::TestController::dumpResponse):
519         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
520         - Declare methods.
521
522 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
523
524         Unreviewed. Add GLib API test cases after r243434.
525
526         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
527         (testWebViewActiveURI):
528         (serverCallback):
529         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
530         (sendRequestCallback):
531
532 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
533
534         Geolocation request not complete when watch request was started in a different web process
535         https://bugs.webkit.org/show_bug.cgi?id=195996
536
537         Reviewed by Alex Christensen.
538
539         Add a test case.
540
541         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
542         (TestWebKitAPI::runJavaScriptAlert):
543         (TestWebKitAPI::TEST):
544
545 2019-03-26  Keith Rollin  <krollin@apple.com>
546
547         Update the way generate-xcfilelists returns strings from functions
548         https://bugs.webkit.org/show_bug.cgi?id=195975
549         <rdar://problem/49040807>
550
551         Reviewed by Dean Jackson.
552
553         There are places where generate-xcfilelists executes assignments with
554         statements like:
555
556             FOO=$(some_function)
557
558         where "some_function" return a string by echoing it. E.g.
559
560             some_function()
561             {
562                 echo "Hello, World"
563             }
564
565         This is a common idiom, but it has a problem if "some_function" needs
566         to call "exit" in an attempt to halt the entire script right then and
567         there. Since "some_function" is called inside of $(), it's being
568         executed in a sub-shell. Calling exit in that sub-shell simply exits
569         that shell; it doesn't not exit the outer shell in which the main part
570         of the script is still running. As such, the main script keeps
571         executing when the intent was for the script to halt.
572
573         The solution to this is to use a different idiom for returning
574         strings. The one we now is to pass in the name of the variable to
575         receive the string result:
576
577             some_function()
578             {
579                 variable_name=$1
580                 eval $variable_name ="Hello, World"
581             }
582
583         The call site now looks like
584
585             some_function FOO
586
587         Because there's no invocation of a sub-shell, some_function can now
588         call "exit" if it wants to, and the entire script will exit at that
589         point.
590
591         * Scripts/generate-xcfilelists:
592
593 2019-03-26  Chris Dumez  <cdumez@apple.com>
594
595         Add basic layout test coverage for File Picker on iOS
596         https://bugs.webkit.org/show_bug.cgi?id=196265
597
598         Reviewed by Wenson Hsieh.
599
600         Add layout test infrastructure to test the file picker on iOS.
601
602         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
603         (WTR::UIScriptController::dismissFilePicker):
604         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
605         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
606         (WTR::UIScriptController::dismissFilePicker):
607         * TestRunnerShared/UIScriptContext/UIScriptController.h:
608         * WebKitTestRunner/TestController.cpp:
609         (WTR::TestController::createWebViewWithOptions):
610         (WTR::updateTestOptionsFromTestHeader):
611         * WebKitTestRunner/TestOptions.h:
612         (WTR::TestOptions::hasSameInitializationOptions const):
613         * WebKitTestRunner/ios/TestControllerIOS.mm:
614         (overridePresentViewController):
615         (WTR::TestController::platformInitialize):
616         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
617         (WTR::UIScriptController::dismissFilePicker):
618
619 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
620
621         Implement async paste method on UIWKInteractionViewProtocol
622         https://bugs.webkit.org/show_bug.cgi?id=196267
623         <rdar://problem/49236346>
624
625         Reviewed by Tim Horton.
626
627         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
628         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
629         are now a part of all iOS 12 internal SDKs.
630
631         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
632
633         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
634         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
635
636         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
637         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
638         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
639         * TestWebKitAPI/ios/UIKitSPI.h:
640
641 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
642
643         [ews-build] Use PostgreSQL for ews.webkit.org database
644         https://bugs.webkit.org/show_bug.cgi?id=196270
645
646         Reviewed by Lucas Forschler.
647
648         * BuildSlaveSupport/ews-app/ews-app/settings.py:
649
650 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
651
652         [ews] Reset simctl states on reboot
653         https://bugs.webkit.org/show_bug.cgi?id=196260
654
655         Rubber-stamped by Aakash Jain.
656
657         * EWSTools/start-queue-mac.sh:
658
659 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
660
661         [ews-build] Use PostgreSQL for ews-build database
662         https://bugs.webkit.org/show_bug.cgi?id=196229
663
664         Reviewed by Lucas Forschler.
665
666         * BuildSlaveSupport/ews-build/master.cfg:
667
668 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
669
670         [ews-build] Get master_hostname dynamically in master.cfg
671         https://bugs.webkit.org/show_bug.cgi?id=196255
672
673         Reviewed by Lucas Forschler.
674
675         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
676         send events data in test mode.
677
678 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
679
680         [ews-app] Set db_constraint to False for Foreign Keys
681         https://bugs.webkit.org/show_bug.cgi?id=196252
682
683         Reviewed by Lucas Forschler.
684
685         * BuildSlaveSupport/ews-app/ews/models/build.py:
686         * BuildSlaveSupport/ews-app/ews/models/step.py:
687
688 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
689
690         [ews-build] is_test_mode_enabled should default to True
691         https://bugs.webkit.org/show_bug.cgi?id=196248
692
693         Reviewed by Lucas Forschler.
694
695         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
696
697 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
698
699         [ews-app] Add webkitperl to ENABLED_QUEUES
700         https://bugs.webkit.org/show_bug.cgi?id=196253
701
702         Reviewed by Lucas Forschler.
703
704         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
705
706 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
707
708         Address NSWindow sometimes using WebKitTestRunnerEvent too early
709         https://bugs.webkit.org/show_bug.cgi?id=196211
710         rdar://problem/49110552
711
712         Reviewed by Tim Horton.
713
714         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
715         Make sure that EventSenderProxy always exists when running tests. We used to create
716         it when resetting before the first test, which is a bit too late.
717
718         * WebKitTestRunner/TestController.h:
719         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
720         (WTR::TestController::platformCreateWebView):
721         (WTR::TestController::platformCreateOtherPage):
722         (WTR::TestController::finishCreatingPlatformWebView):
723         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
724         (WTR::PlatformWebView::PlatformWebView):
725         Moved some code that made NSWindow use NSEvent during web view creation. We may
726         need to move more if some other case us found, but this is enough for now.
727
728 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
729
730         Unreviewed. Fix typo in GLib geolocation API after r243285.
731
732         gelocation -> geolocation.
733
734         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
735         (testGeolocationManagerWatchPosition):
736
737 2019-03-25  Alex Christensen  <achristensen@webkit.org>
738
739         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
740         https://bugs.webkit.org/show_bug.cgi?id=196213
741
742         Reviewed by Geoff Garen.
743
744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
745         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
746         (credentialWithIdentityAndKeychainPath):
747         (-[ChallengeDelegate webView:didFinishNavigation:]):
748         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
749         (TestWebKitAPI::TEST):
750
751 2019-03-25  Alex Christensen  <achristensen@webkit.org>
752
753         Expected shouldn't assume its contained types are copyable
754         https://bugs.webkit.org/show_bug.cgi?id=195986
755
756         Reviewed by JF Bastien.
757
758         * TestWebKitAPI/Tests/WTF/Expected.cpp:
759         (TestWebKitAPI::NonCopyable::operator== const):
760         (TestWebKitAPI::NonCopyable::operator!= const):
761         (TestWebKitAPI::TEST):
762
763 2019-03-25  Tim Horton  <timothy_horton@apple.com>
764
765         Remove some now-unnecessary dynamic class lookup
766         https://bugs.webkit.org/show_bug.cgi?id=196237
767
768         Reviewed by Simon Fraser.
769
770         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
771         (makeRequest):
772         (TEST):
773
774 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
775
776         Unreviewed, rolling out r243450.
777
778         AppleWin and WinCairo port builds get broken.
779
780         Reverted changeset:
781
782         "Add test for fix of #196095"
783         https://bugs.webkit.org/show_bug.cgi?id=196097
784         https://trac.webkit.org/changeset/243450
785
786 2019-03-25  Commit Queue  <commit-queue@webkit.org>
787
788         Unreviewed, rolling out r243465.
789         https://bugs.webkit.org/show_bug.cgi?id=196226
790
791         the test doesn't build (Requested by thorton on #webkit).
792
793         Reverted changeset:
794
795         "Do not terminate the NetworkProcess if a third party
796         application sends a NSCredential with a SecIdentityRef"
797         https://bugs.webkit.org/show_bug.cgi?id=196213
798         https://trac.webkit.org/changeset/243465
799
800 2019-03-25  Alex Christensen  <achristensen@webkit.org>
801
802         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
803         https://bugs.webkit.org/show_bug.cgi?id=196213
804
805         Reviewed by Geoff Garen.
806
807         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
808         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
809         (credentialWithIdentityAndKeychainPath):
810         (-[ChallengeDelegate webView:didFinishNavigation:]):
811         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
812         (TestWebKitAPI::TEST):
813
814 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
815
816         [ews-build] Gracefully handle missing patch_id in events
817         https://bugs.webkit.org/show_bug.cgi?id=196216
818
819         Reviewed by Lucas Forschler.
820
821         * BuildSlaveSupport/ews-build/events.py:
822
823 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
824
825         [ews-build] use lz4 compression for improving buildbot performance
826         https://bugs.webkit.org/show_bug.cgi?id=196155
827
828         Reviewed by Lucas Forschler.
829
830         * BuildSlaveSupport/ews-build/master.cfg:
831
832 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
833
834         Pull some API testing helper methods out of TestWKWebView
835         https://bugs.webkit.org/show_bug.cgi?id=196212
836
837         Reviewed by Tim Horton.
838
839         Refactor some more API testing utility methods, so that they can be used in
840         tests that do not use TestWKWebView.
841
842         * TestWebKitAPI/cocoa/TestWKWebView.h:
843         * TestWebKitAPI/cocoa/TestWKWebView.mm:
844         (-[WKWebView loadTestPageNamed:]):
845         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
846         (-[WKWebView synchronouslyLoadHTMLString:]):
847         (-[WKWebView synchronouslyLoadTestPageNamed:]):
848         (-[TestWKWebView loadTestPageNamed:]): Deleted.
849         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
850         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
851         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
852
853 2019-03-25  Jer Noble  <jer.noble@apple.com>
854
855         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
856         https://bugs.webkit.org/show_bug.cgi?id=196097
857
858         Reviewed by Eric Carlson.
859
860         Drive-by bug fix: allow tests to play audio without a user gesture by default.
861
862         * DumpRenderTree/mac/DumpRenderTree.mm:
863         (resetWebPreferencesToConsistentValues):
864         * WebKitTestRunner/TestController.cpp:
865         (WTR::TestController::resetPreferencesToConsistentValues):
866
867 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
868
869         Pull IPadUserInterfaceSwizzler out into a separate header file
870         https://bugs.webkit.org/show_bug.cgi?id=196193
871
872         Reviewed by Anders Carlsson.
873
874         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
875         be used in other API tests.
876
877         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
878         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
879         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
880         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
881         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
882         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
883         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
884
885 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
886
887         Remove NavigatorContentUtils in WebCore/Modules
888         https://bugs.webkit.org/show_bug.cgi?id=196070
889
890         Reviewed by Alex Christensen.
891
892         NavigatorContentUtils was to support the custom scheme spec [1].
893         However, in WebKit side, no port has supported the feature in
894         WebKit layer after EFL port was removed. So there has been the
895         only IDL implementation of the NavigatorContentUtils in WebCore.
896         So we don't need to keep the implementation in WebCore anymore.
897
898         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
899
900         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
901
902 2019-03-24  Andy Estes  <aestes@apple.com>
903
904         [watchOS] Remove unused Proximity Networking code
905         https://bugs.webkit.org/show_bug.cgi?id=196188
906
907         Reviewed by Tim Horton.
908
909         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
910         (TEST):
911
912 2019-03-23  Keith Miller  <keith_miller@apple.com>
913
914         Refactor clz/ctz and fix getLSBSet.
915         https://bugs.webkit.org/show_bug.cgi?id=196162
916
917         Reviewed by Saam Barati.
918
919         Add tests for clz, ctz, getLSBSet, and getMSBSet.
920
921         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
922         (TestWebKitAPI::TEST):
923
924 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
925
926         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
927         https://bugs.webkit.org/show_bug.cgi?id=196143
928
929         Reviewed by Michael Catanzaro.
930
931         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
932         directories.
933
934         * Scripts/webkitpy/style/checkers/cpp.py:
935         (check_identifier_name_in_declaration):
936         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
937         (WebKitStyleTest.test_names):
938
939 2019-03-22  Philippe Normand  <pnormand@igalia.com>
940
941         [Flatpak] Manifest expanding fails for qt WPE extension
942         https://bugs.webkit.org/show_bug.cgi?id=196148
943
944         Reviewed by Alex Christensen.
945
946         * flatpak/flatpakutils.py:
947         (expand_submodules_recurse): The last recurse manifest expand
948         iteration might lead to a single module so take it into account
949         and don't try to recurse further.
950
951 2019-03-22  Chris Dumez  <cdumez@apple.com>
952
953         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
954         https://bugs.webkit.org/show_bug.cgi?id=195348
955         <rdar://problem/48622090>
956
957         Reviewed by Alex Christensen.
958
959         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
960         to NO when test.options().shouldIgnoreMetaViewport is false.
961
962         * WebKitTestRunner/ios/TestControllerIOS.mm:
963         (WTR::TestController::platformConfigureViewForTest):
964
965 2019-03-22  Chris Dumez  <cdumez@apple.com>
966
967         Prewarmed processes should be usable with any website data store
968         https://bugs.webkit.org/show_bug.cgi?id=196104
969
970         Reviewed by Alex Christensen.
971
972         Add API test coverage.
973
974         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
975         (runInitialWarmedProcessUsedTest):
976         (TEST):
977
978 2019-03-22  David Kilzer  <ddkilzer@apple.com>
979
980         Back out local changes to Alex's Subversion working directory
981
982         They were accidentally committed.
983
984         * Scripts/webkitpy/common/system/abstractexecutive.py:
985         (AbstractExecutive.wait_newest):
986         * Scripts/webkitpy/common/system/executive.py:
987         (Executive.running_pids):
988         * Scripts/webkitpy/common/system/executive_mock.py:
989         (MockExecutive.running_pids):
990         * Scripts/webkitpy/common/system/executive_unittest.py:
991         (ExecutiveTest.serial_test_running_pids):
992         * Scripts/webkitpy/port/darwin.py:
993         (DarwinPort.check_for_leaks):
994         * Scripts/webkitpy/port/leakdetector.py:
995         (LeakDetector.check_for_leaks):
996         - This was the hack attached to Bug 193772.
997
998         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
999         (+[WebKitTestRunnerEvent mouseLocation]):
1000         - This works around a crash on an internal build.
1001
1002 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1003
1004         Fix the build after r243354
1005         https://bugs.webkit.org/show_bug.cgi?id=196138
1006         <rdar://problem/49145951>
1007
1008         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1009         (TEST):
1010         * TestWebKitAPI/ios/UIKitSPI.h:
1011
1012 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1013
1014         Adopt UIWKDocumentContext
1015         https://bugs.webkit.org/show_bug.cgi?id=196040
1016         <rdar://problem/48642440>
1017
1018         Reviewed by Ryosuke Niwa.
1019
1020         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1021         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1022         (makeRequest):
1023         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1024         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1025         (applyStyle):
1026         (TEST):
1027         Add tests for UIWKDocumentContext.
1028
1029         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1030         (TEST):
1031         (recursiveFindWKContentView): Deleted.
1032         * TestWebKitAPI/cocoa/TestWKWebView.h:
1033         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1034         (recursiveFindWKContentView):
1035         (-[TestWKWebView wkContentView]):
1036         * TestWebKitAPI/ios/UIKitSPI.h:
1037         Share the WKContentView finding code between tests.
1038
1039 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1040
1041         [iOS WK2] Turn on async overflow scrolling by default
1042         https://bugs.webkit.org/show_bug.cgi?id=196011
1043         rdar://problem/48453859
1044
1045         Reviewed by Antti Koivisto.
1046         
1047         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1048         since so many basic layout tests have different results when compositing is triggered for
1049         overflow.
1050         
1051         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1052
1053         * WebKitTestRunner/TestController.cpp:
1054         (WTR::TestController::resetPreferencesToConsistentValues):
1055
1056 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1057
1058         [ews-build] Retry API test in case of failures
1059         https://bugs.webkit.org/show_bug.cgi?id=196004
1060
1061         Reviewed by Lucas Forschler.
1062
1063         * BuildSlaveSupport/ews-build/steps.py:
1064         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1065         (CompileWebKitToT.doStepIf): Ditto.
1066         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1067         (ReRunAPITests): Re-run API tests.
1068         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1069         (RunAPITestsWithoutPatch): Run API tests without patch.
1070         (RunAPITestsWithoutPatch.doStepIf):
1071         (RunAPITestsWithoutPatch.hideStepIf):
1072         (RunAPITestsWithoutPatch.evaluateCommand):
1073         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1074         (AnalyzeAPITestsResults.start):
1075         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1076         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1077         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1078         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1079
1080 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1081
1082         [ews-build] Update queues configurations
1083         https://bugs.webkit.org/show_bug.cgi?id=196074
1084
1085         Reviewed by Dewei Zhu.
1086
1087         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1088         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1089
1090 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1091
1092         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1093         https://bugs.webkit.org/show_bug.cgi?id=195680
1094         <rdar://problem/48903534>
1095
1096         Unreviewed infrastructure fix.
1097
1098         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1099         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1100
1101 2019-03-21  Andy Estes  <aestes@apple.com>
1102
1103         [iOS] Apple Pay should be available in documents with no user agent scripts
1104         https://bugs.webkit.org/show_bug.cgi?id=196061
1105         <rdar://problem/48649391>
1106
1107         Reviewed by Brady Eidson.
1108
1109         Added API tests and related infrastructure.
1110
1111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1112         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1113         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1114         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1115         (TestWebKitAPI::TEST):
1116         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1117         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1118         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1119         * TestWebKitAPI/cocoa/TestProtocol.mm:
1120         (-[TestProtocol startLoading]):
1121         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1122         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1123         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1124         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1125
1126 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1127
1128         REGRESSSION (r243297): webkitpy tests broken
1129         https://bugs.webkit.org/show_bug.cgi?id=196108
1130
1131         Reviewed by Aakash Jain.
1132
1133         r243297 updated contributors.json, which broke a few unit tests.
1134
1135         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1136         (IRCCommandTest.test_whois):
1137         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1138
1139 2019-03-21  Chris Dumez  <cdumez@apple.com>
1140
1141         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1142         https://bugs.webkit.org/show_bug.cgi?id=196041
1143         <rdar://problem/49083230>
1144
1145         Reviewed by Alex Christensen.
1146
1147         Add API test coverage.
1148
1149         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1150         (TEST):
1151
1152 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1153
1154         Add SPI to inform applications of WKContentRuleList actions
1155         https://bugs.webkit.org/show_bug.cgi?id=195965
1156         <rdar://problem/42664365>
1157
1158         Reviewed by Geoff Garen.
1159
1160         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1161         (TestWebKitAPI::allActionsForResourceLoad):
1162         (TestWebKitAPI::testRequest):
1163         (TestWebKitAPI::TEST_F):
1164         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1165         (Notification::description):
1166         (Notification::operator== const):
1167         (toVector):
1168         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1169         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1170         (makeContentRuleList):
1171         (TEST):
1172         (makeWarnContentRuleList): Deleted.
1173
1174 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1175
1176         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1177         https://bugs.webkit.org/show_bug.cgi?id=196088
1178
1179         Reviewed by Brian Burg.
1180
1181         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1182         Support checks when only one platform is specified. Also deprecate macosx() and
1183         force the use of macos() instead.
1184
1185         * Scripts/webkitpy/style/checkers/cpp.py:
1186         (check_min_versions_of_wk_api_available):
1187         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1188         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1189
1190 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1191
1192         Update status inactive committers' status to 'contributor'.
1193
1194         * Scripts/webkitpy/common/config/contributors.json:
1195
1196 2019-03-21  Xan Lopez  <xan@igalia.com>
1197
1198         [JSC][x86] Drop support for x87 floating point
1199         https://bugs.webkit.org/show_bug.cgi?id=194853
1200
1201         Reviewed by Don Olmstead.
1202
1203         Force SSE2 on x86/32bit builds.
1204
1205         * Scripts/webkitdirs.pm:
1206         (generateBuildSystemFromCMakeProject):
1207
1208 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1209
1210         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1211         https://bugs.webkit.org/show_bug.cgi?id=196073
1212
1213         Reviewed by Michael Catanzaro.
1214
1215         Add test cases to check functions and constructors with no arguments but receiving user data.
1216
1217         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1218         (checkUserData):
1219         (testJSCFunction):
1220         (fooCreateWithUserData):
1221         (testJSCClass):
1222
1223 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1224
1225         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1226
1227         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1228
1229         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1230
1231 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1232
1233         [GTK][WPE] Add API to provide geolocation information
1234         https://bugs.webkit.org/show_bug.cgi?id=195940
1235
1236         Reviewed by Michael Catanzaro.
1237
1238         Add a new test to check the new API.
1239
1240         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1241         (testGeolocationManagerCurrentPosition):
1242         (testGeolocationManagerWatchPosition):
1243         (beforeAll):
1244         (afterAll):
1245         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1246         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1247         (beforeAll): Ditto.
1248         * TestWebKitAPI/glib/CMakeLists.txt:
1249
1250 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1251
1252         [GLib] Returning G_TYPE_OBJECT from a method does not work
1253         https://bugs.webkit.org/show_bug.cgi?id=195574
1254
1255         Reviewed by Michael Catanzaro.
1256
1257         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1258
1259         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1260         (getGFile):
1261         (getParent):
1262         (createGString):
1263         (getGString):
1264         (getGStringCopyWillRaise):
1265         (getGStringCopy):
1266         (getGStringStr):
1267         (getGStringLen):
1268         (freeGString):
1269         (testJSCClass):
1270
1271 2019-03-20  Saam Barati  <sbarati@apple.com>
1272
1273         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1274         https://bugs.webkit.org/show_bug.cgi?id=195721
1275
1276         Reviewed by Filip Pizlo.
1277
1278         * Scripts/run-javascriptcore-tests:
1279
1280 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1281
1282         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1283         https://bugs.webkit.org/show_bug.cgi?id=196049
1284
1285         Reviewed by Tim Horton.
1286
1287         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1288         overflow scrolling in general, so rename it.
1289
1290         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1291
1292 2019-03-20  Daniel Bates  <dabates@apple.com>
1293
1294         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1295         https://bugs.webkit.org/show_bug.cgi?id=196031
1296         <rdar://problem/49078172>
1297
1298         Reviewed by Tim Horton.
1299
1300         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1301         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1302         same code path used when the Done button is pressed to dismiss the <select> picker.
1303
1304         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1305         (TestWebKitAPI::TEST):
1306
1307 2019-03-20  Chris Dumez  <cdumez@apple.com>
1308
1309         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1310         https://bugs.webkit.org/show_bug.cgi?id=196029
1311         <rdar://problem/48954651>
1312
1313         Reviewed by Tim Horton.
1314
1315         Add API test coverage.
1316
1317         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1318
1319 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1320
1321         [ews-build] Improve failure summary string for ApplyPatch step
1322         https://bugs.webkit.org/show_bug.cgi?id=195995
1323
1324         Reviewed by Alexey Proskuryakov.
1325
1326         * BuildSlaveSupport/ews-build/steps.py:
1327         (ApplyPatch.getResultSummary): Override getResultSummary.
1328
1329 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1330
1331         AX: Implement support for new meter ARIA role
1332         https://bugs.webkit.org/show_bug.cgi?id=195966
1333
1334         Reviewed by Chris Fleizach.
1335
1336         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1337         to AXLevelIndicator.
1338
1339         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1340
1341 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1342
1343         [WebAuthN] Implement FIDO AppID extension
1344         https://bugs.webkit.org/show_bug.cgi?id=143491
1345         <rdar://problem/48298273>
1346
1347         Reviewed by Brent Fulgham.
1348
1349         Add a test that covers the new flag of convertToU2fSignCommand.
1350
1351         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1352         (TestWebKitAPI::TEST):
1353         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1354         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1355         (TestWebKitAPI::TEST):
1356
1357 2019-03-19  Keith Rollin  <krollin@apple.com>
1358
1359         Add support for more platforms to generate-xcfilelists
1360         https://bugs.webkit.org/show_bug.cgi?id=195977
1361
1362         Reviewed by Alexey Proskuryakov.
1363
1364         generate-xcfilelists incorrectly complains when involved with building
1365         WebKit for iphonesimulator:
1366
1367             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1368             …
1369             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1370
1371         Address this by teaching generate-xcfilelists about more platforms.
1372
1373         * Scripts/generate-xcfilelists:
1374
1375 2019-03-19  John Wilander  <wilander@apple.com>
1376
1377         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1378         https://bugs.webkit.org/show_bug.cgi?id=195923
1379         <rdar://problem/49001272>
1380
1381         Reviewed by Alex Christensen.
1382
1383         This patch does the following to the TestRunner:
1384         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1385         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1386         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1387
1388         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1389         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1390         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1391         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1392         * WebKitTestRunner/TestController.cpp:
1393         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1394         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1395         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1396         * WebKitTestRunner/TestController.h:
1397         * WebKitTestRunner/TestInvocation.cpp:
1398         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1399
1400 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1401
1402         [CMake] Support more clang and gcc sanitizers
1403         https://bugs.webkit.org/show_bug.cgi?id=195956
1404
1405         Reviewed by Michael Catanzaro.
1406
1407         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1408
1409 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1410
1411         [ews-build] Improve summary for PrintConfiguration step
1412         https://bugs.webkit.org/show_bug.cgi?id=195945
1413
1414         Reviewed by Lucas Forschler.
1415
1416         * BuildSlaveSupport/ews-build/steps.py:
1417         (PrintConfiguration.getResultSummary): Override getResultSummary.
1418
1419 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1420
1421         [ews-build] Improve summary for CheckOutSource step
1422         https://bugs.webkit.org/show_bug.cgi?id=195963
1423
1424         Reviewed by Lucas Forschler.
1425
1426         * BuildSlaveSupport/ews-build/steps.py:
1427         (CheckOutSource.getResultSummary):
1428
1429 2019-03-19  Daniel Bates  <dabates@apple.com>
1430
1431         [iOS] Focus not preserved when switching between tabs
1432         https://bugs.webkit.org/show_bug.cgi?id=195820
1433         <rdar://problem/43614450>
1434
1435         Reviewed by Brent Fulgham.
1436
1437         Add tests to ensure that we restore focus when resigning and becoming first responder.
1438
1439         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1440         (TestWebKitAPI::TEST):
1441
1442 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1443
1444         Make WTFLogChannelState and WTFLogLevel enum classes
1445         https://bugs.webkit.org/show_bug.cgi?id=195904
1446
1447         Reviewed by Eric Carlson.
1448
1449         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1450         (TestWebKitAPI::TEST_F):
1451
1452 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1453
1454         [GStreamer][EME] Backported mssdemux protection data crash fix
1455         https://bugs.webkit.org/show_bug.cgi?id=195918
1456
1457         Reviewed by Philippe Normand.
1458
1459         * gstreamer/jhbuild.modules:
1460         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1461
1462 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1463
1464         Unreviewed, rolling out r243132.
1465
1466         Broke GTK build
1467
1468         Reverted changeset:
1469
1470         "Make WTFLogChannelState and WTFLogLevel enum classes"
1471         https://bugs.webkit.org/show_bug.cgi?id=195904
1472         https://trac.webkit.org/changeset/243132
1473
1474 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1475
1476         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1477
1478         * Scripts/webkitdirs.pm:
1479         (builtDylibPathForName): Adjust the shared library name that's changed
1480         with the API version bump in r243073.
1481
1482 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1483
1484         Make WTFLogChannelState and WTFLogLevel enum classes
1485         https://bugs.webkit.org/show_bug.cgi?id=195904
1486
1487         Reviewed by Eric Carlson.
1488
1489         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1490         (TestWebKitAPI::TEST_F):
1491
1492 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1493
1494         Disable flaky test added in r2431100
1495         https://webkit.org/b/195785
1496
1497         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1498         (TestWebKitAPI::TEST):
1499         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1500
1501 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1502
1503         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1504         https://bugs.webkit.org/show_bug.cgi?id=195916
1505
1506         Reviewed by Tim Horton.
1507
1508         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1509         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1510
1511 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1512
1513         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1514
1515         * Scripts/webkitpy/common/config/contributors.json:
1516
1517 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1518
1519         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1520         https://bugs.webkit.org/show_bug.cgi?id=195785
1521
1522         Reviewed by Geoffrey Garen.
1523
1524         * TestWebKitAPI/TCPServer.cpp: Added.
1525         (TestWebKitAPI::TCPServer::TCPServer):
1526         (TestWebKitAPI::TCPServer::~TCPServer):
1527         (TestWebKitAPI::TCPServer::socketBindListen):
1528         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1529         * TestWebKitAPI/TCPServer.h: Added.
1530         (TestWebKitAPI::TCPServer::port const):
1531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1532         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1533         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1534         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1535         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1536         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1537         (TestWebKitAPI::respondSlowly):
1538         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1539         (TestWebKitAPI::downloadAtRate):
1540         (TestWebKitAPI::TEST):
1541
1542 2019-03-18  Saam Barati  <sbarati@apple.com>
1543
1544         Add a plan file for JetStream 2
1545         https://bugs.webkit.org/show_bug.cgi?id=190734
1546
1547         Reviewed by Mark Lam.
1548
1549         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1550
1551 2019-03-18  Chris Dumez  <cdumez@apple.com>
1552
1553         Delay WebProcess launch until a load is triggered in a Web view
1554         https://bugs.webkit.org/show_bug.cgi?id=195758
1555         <rdar://problem/48126013>
1556
1557         Reviewed by Geoff Garen.
1558
1559         Add API test coverage. Also update some existing API tests to not expect
1560         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1561
1562         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1563         (TestWebKitAPI::TEST):
1564         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1565         (TestWebKitAPI::TEST):
1566         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1567         (TEST):
1568         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1569         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1570         (TEST):
1571         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1572         (TEST):
1573         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1574
1575 2019-03-18  Xan Lopez  <xan@igalia.com>
1576
1577         [CMake] Prevent potential warning when determining $architecture
1578         https://bugs.webkit.org/show_bug.cgi?id=195891
1579
1580         Reviewed by Michael Catanzaro.
1581
1582         It's possible for generateBuildSystemForCMakeProject to be called
1583         before determineArchitecture() is ever called. This will make the
1584         first eq check with $architecture to be bogus (and print a
1585         warning). Change that to an eq check with architecture(), which
1586         implicitly calls determineArchitecture() if needed, and change all
1587         the other similar cases in the method in the same way to prevent
1588         future bugs like this one.
1589
1590         * Scripts/webkitdirs.pm:
1591         (generateBuildSystemFromCMakeProject):
1592
1593 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1594
1595         [WPE] Tarballs generated with “make dist” cannot build documentation
1596         https://bugs.webkit.org/show_bug.cgi?id=195885
1597
1598         Reviewed by Carlos Garcia Campos.
1599
1600         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1601
1602 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1603
1604         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1605         https://bugs.webkit.org/show_bug.cgi?id=195883
1606
1607         Reviewed by Carlos Garcia Campos.
1608
1609         * gtkdoc/gtkdoc.py:
1610         (GTKDoc._run_command): When commands fail to run, include the full command line for
1611         the program invocation and the output it has generated on the standard error stream.
1612
1613 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1614
1615         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1616         https://bugs.webkit.org/show_bug.cgi?id=195786
1617
1618         Reviewed by Philippe Normand.
1619
1620         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1621         * wpe/jhbuild.modules: Ditto.
1622
1623 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1624
1625         [ews-build] Don't run clean builds on EWS builders
1626         https://bugs.webkit.org/show_bug.cgi?id=195851
1627
1628         Reviewed by Geoffrey Garen.
1629
1630         * BuildSlaveSupport/ews-build/factories.py:
1631
1632 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1633
1634         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1635         https://bugs.webkit.org/show_bug.cgi?id=195849
1636
1637         Reviewed by Chris Dumez.
1638
1639         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1640
1641         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1642         (runWebsiteDataStoreCustomPaths):
1643
1644 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1645
1646         webkitpy: Upload test results
1647         https://bugs.webkit.org/show_bug.cgi?id=195755
1648         <rdar://problem/48896182>
1649
1650         Reviewed by Aakash Jain.
1651
1652         Establish a new format for uploading results that is not tied to layout tests, apply
1653         that format to webkitpy tests.
1654
1655         * Scripts/webkitpy/common/checkout/scm/git.py:
1656         (Git.native_branch): Return what branch the current checkout is on.
1657         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1658         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1659         * Scripts/webkitpy/common/checkout/scm/svn.py:
1660         (SVN.native_branch): Ditto.
1661         * Scripts/webkitpy/common/system/platforminfo.py:
1662         (PlatformInfo.build_version): Return a build version for Mac.
1663         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1664         (MockPlatformInfo.__init__):
1665         (MockPlatformInfo.build_version):
1666         * Scripts/webkitpy/results: Added.
1667         * Scripts/webkitpy/results/__init__.py: Added.
1668         * Scripts/webkitpy/results/options.py: Added.
1669         (upload_options): OptParse list for upload options.
1670         * Scripts/webkitpy/results/upload.py: Added.
1671         (Upload): Class which enforces the upload format expected by the results server.
1672         (Upload.Expectations):
1673         (Upload.create_configuration):
1674         (Upload.create_commit):
1675         (Upload.create_details):
1676         (Upload.create_run_stats):
1677         (Upload.create_test_result):
1678         (Upload.__init__):
1679         (Upload.Encoder): Encode Upload object as json.
1680         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1681         * Scripts/webkitpy/results/upload_unittest.py: Added.
1682         * Scripts/webkitpy/test/main.py:
1683         (Tester._parse_args): Add upload arguments.
1684         (Tester._run_tests): Allow results to be uploaded.
1685         * Scripts/webkitpy/test/runner.py:
1686         (Runner.__init__): Record which tests were run, rather than just counting them.
1687         (Runner.handle):
1688         * Scripts/webkitpy/test/runner_unittest.py:
1689         (RunnerTest.test_run):
1690         * Scripts/webkitpy/thirdparty/__init__.py:
1691         (AutoinstallImportHook.find_module): Add requests auto-install.
1692         (AutoinstallImportHook._install_requests):
1693         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1694         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1695
1696 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1697
1698         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1699         https://bugs.webkit.org/show_bug.cgi?id=195810
1700
1701         Reviewed by Tim Horton.
1702
1703         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1704         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1705         ending certain layout tests.
1706
1707         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1708         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1709         (-[TestRunnerWKWebView dealloc]):
1710         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1711
1712         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1713         helper method when destroying the web view, and when resetting state between tests.
1714
1715         * WebKitTestRunner/ios/TestControllerIOS.mm:
1716         (WTR::TestController::platformResetStateToConsistentValues):
1717
1718         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1719
1720 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1721
1722         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1723         https://bugs.webkit.org/show_bug.cgi?id=190350
1724         <rdar://problem/45089503>
1725
1726         Reviewed by Geoffrey Garen.
1727
1728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1729         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1730         (TEST):
1731         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1732         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1733         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1734         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1735         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1736         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1737         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1738         (runTest):
1739         (createDirectories):
1740         (TEST):
1741         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1742         (TEST):
1743         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1744         (TEST):
1745
1746 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1747
1748         Add support to WebPage for getting the contents as an attributed string.
1749         https://bugs.webkit.org/show_bug.cgi?id=195636
1750         rdar://problem/45055697
1751
1752         Reviewed by Tim Horton.
1753
1754         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1755         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1756
1757 2019-03-15  Chris Dumez  <cdumez@apple.com>
1758
1759         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1760         https://bugs.webkit.org/show_bug.cgi?id=195747
1761
1762         Reviewed by Geoff Garen.
1763
1764         Add API test coverage.
1765
1766         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1767
1768 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1769
1770         Unreviewed, rolling out r242952.
1771
1772         Causing API failures on iOS Simulator
1773
1774         Reverted changeset:
1775
1776         "[PSON] Make sure the WebProcessCache is leverage when
1777         relaunching a process after termination"
1778         https://bugs.webkit.org/show_bug.cgi?id=195747
1779         https://trac.webkit.org/changeset/242952
1780
1781 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1782
1783         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1784         https://bugs.webkit.org/show_bug.cgi?id=195740
1785
1786         Reviewed by Ross Kirsling.
1787
1788         window.open doesn't work for WebKitBrowserWindow because it is not
1789         implemented yet.
1790
1791         1. Implemented createNewPage callback of WKPageUIClient.
1792         2. Changed MainWindow to take a BrowserWindow factory function
1793           instead of BrowserWindowType to be flexible to create
1794           BrowserWindow with extra settings.
1795         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1796           because it is not relevant with MainWindow anymore.
1797
1798         * MiniBrowser/win/Common.cpp:
1799         (parseCommandLine):
1800         * MiniBrowser/win/Common.h:
1801         (CommandLineOptions::CommandLineOptions):
1802         * MiniBrowser/win/MainWindow.cpp:
1803         (MainWindow::MainWindow):
1804         (MainWindow::create):
1805         (MainWindow::init):
1806         (MainWindow::WndProc):
1807         * MiniBrowser/win/MainWindow.h:
1808         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1809         (PrintWebUIDelegate::createWebViewWithRequest):
1810         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1811         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1812         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1813         (WebKitBrowserWindow::updateProxySettings):
1814         (WebKitBrowserWindow::createNewPage):
1815         * MiniBrowser/win/WebKitBrowserWindow.h:
1816         * MiniBrowser/win/WinMain.cpp:
1817         (wWinMain):
1818
1819 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1820
1821         Make it possible to test scrolling tree layer manipulation more easily
1822         https://bugs.webkit.org/show_bug.cgi?id=195780
1823
1824         Reviewed by Tim Horton.
1825         
1826         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1827         cuts off communication of scrolling tree scrolls back to the web process
1828         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1829         allows tests to trigger scrolls which run the scrolling tree layer positioning
1830         logic, but never get another commit from the web process that might mask
1831         scrolling tree bugs.
1832         
1833         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1834         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1835         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1836
1837         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1838         (WTR::UIScriptController::scrollUpdatesDisabled const):
1839         (WTR::UIScriptController::setScrollUpdatesDisabled):
1840         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1841         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1842         (WTR::UIScriptController::scrollUpdatesDisabled const):
1843         (WTR::UIScriptController::setScrollUpdatesDisabled):
1844         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1845         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1846         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1847         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1848         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1849         * WebKitTestRunner/ios/TestControllerIOS.mm:
1850         (WTR::TestController::platformResetStateToConsistentValues):
1851         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1852         (WTR::UIScriptController::scrollUpdatesDisabled const):
1853         (WTR::UIScriptController::setScrollUpdatesDisabled):
1854
1855 2019-03-14  Youenn Fablet  <youenn@apple.com>
1856
1857         Move IDB storage in private browsing mode to NetworkProcess
1858         https://bugs.webkit.org/show_bug.cgi?id=195602
1859
1860         Reviewed by Brady Eidson.
1861
1862         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1863         (TEST):
1864
1865 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1866
1867         [ews-build] Make descriptionDone messages more readable
1868         https://bugs.webkit.org/show_bug.cgi?id=195760
1869
1870         Reviewed by Lucas Forschler.
1871
1872         * BuildSlaveSupport/ews-build/steps.py:
1873         * BuildSlaveSupport/ews-build/steps_unittest.py:
1874
1875 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1876
1877         [ews-build] Generate status-bubble hover-over messages
1878         https://bugs.webkit.org/show_bug.cgi?id=195680
1879
1880         Reviewed by Lucas Forschler.
1881
1882         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1883         (StatusBubble):
1884         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1885         on hover-over.
1886         (StatusBubble._iso_time):
1887         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1888         hover-over message.
1889         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1890
1891 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1892
1893         [ews-app] Gracefully handle the case when state_string is None
1894         https://bugs.webkit.org/show_bug.cgi?id=195753
1895
1896         Reviewed by Lucas Forschler.
1897
1898         * BuildSlaveSupport/ews-app/ews/models/build.py:
1899         * BuildSlaveSupport/ews-app/ews/models/step.py:
1900
1901 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1902
1903         [ews-app] Status bubble display pending for currently running build step
1904         https://bugs.webkit.org/show_bug.cgi?id=195744
1905
1906         Reviewed by Lucas Forschler.
1907
1908         * BuildSlaveSupport/ews-build/events.py:
1909         (Events.stepStarted): If state_string is pending, replace it with step name.
1910
1911 2019-03-14  Chris Dumez  <cdumez@apple.com>
1912
1913         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1914         https://bugs.webkit.org/show_bug.cgi?id=195750
1915
1916         Reviewed by Geoffrey Garen.
1917
1918         Add API test coverage.
1919
1920         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1921         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1922         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1923         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1924
1925 2019-03-14  Chris Dumez  <cdumez@apple.com>
1926
1927         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1928         https://bugs.webkit.org/show_bug.cgi?id=195747
1929
1930         Reviewed by Geoff Garen.
1931
1932         Add API test coverage.
1933
1934         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1935
1936 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1937
1938         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1939         https://bugs.webkit.org/show_bug.cgi?id=195725
1940         <rdar://problem/48545062>
1941
1942         Reviewed by Tim Horton.
1943
1944         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1945         handler is nil.
1946
1947         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1948         (TestWebKitAPI::TEST):
1949
1950 2019-03-13  Sam Weinig  <sam@webkit.org>
1951
1952         Add utility function to allow easy reverse range-based iteration of a container
1953         https://bugs.webkit.org/show_bug.cgi?id=195542
1954
1955         Reviewed by Antti Koivisto.
1956
1957         * TestWebKitAPI/CMakeLists.txt:
1958         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1959         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1960         (TestWebKitAPI::TEST):
1961         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1962
1963 2019-03-13  Chris Dumez  <cdumez@apple.com>
1964
1965         Use a ServiceWorker process per registrable domain
1966         https://bugs.webkit.org/show_bug.cgi?id=195649
1967
1968         Reviewed by Youenn Fablet.
1969
1970         Update API test coverage.
1971
1972         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1973
1974 2019-03-13  Chris Dumez  <cdumez@apple.com>
1975
1976         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1977         https://bugs.webkit.org/show_bug.cgi?id=195684
1978         <rdar://problem/48294714>
1979
1980         Reviewed by Antti Koivisto.
1981
1982         Add API test coverage.
1983
1984         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1985
1986 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1987
1988         [ews-app] Remove unused patch view
1989         https://bugs.webkit.org/show_bug.cgi?id=195669
1990
1991         Reviewed by Lucas Forschler.
1992
1993         * BuildSlaveSupport/ews-app/ews/urls.py:
1994         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1995
1996 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1997
1998         [ews-app] Use Buildbot result code variables
1999         https://bugs.webkit.org/show_bug.cgi?id=195668
2000
2001         Reviewed by Alexey Proskuryakov.
2002
2003         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2004         (Buildbot): Added Buildbot result code variables.
2005         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2006         (StatusBubble._build_bubble): Used Buildbot result code variables.
2007
2008 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2009
2010         [Flatpak] Expand submodule recursively
2011         https://bugs.webkit.org/show_bug.cgi?id=195672
2012
2013         Building WPE with flatpak was impossible without that as it was raising an exception.
2014         Also update wpebackend-fdo to match what is built in jhbuild
2015
2016         Reviewed by Philippe Normand.
2017
2018         * flatpak/flatpakutils.py:
2019         (expand_submodules_recurse):
2020         (expand_manifest):
2021         * flatpak/org.webkit.WPEModules.yaml:
2022
2023 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2024
2025         [ews-app] status bubble should be hidden for certain builds
2026         https://bugs.webkit.org/show_bug.cgi?id=194597
2027
2028         Reviewed by Dewei Zhu.
2029
2030         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2031         (StatusBubble._build_bubble):
2032         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2033         because the patch didn't have relevant changes.
2034         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2035         in production yet.
2036
2037 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2038
2039         [Win] Fix a slew of simple clang-cl warnings.
2040         https://bugs.webkit.org/show_bug.cgi?id=195652
2041
2042         Reviewed by Don Olmstead.
2043
2044         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2045         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2046
2047 2019-03-12  Justin Fan  <justin_fan@apple.com>
2048
2049         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2050         https://bugs.webkit.org/show_bug.cgi?id=195518
2051         <rdar://problem/46322356>
2052
2053         Reviewed by Myles C. Maxfield.
2054
2055         * DumpRenderTree/DerivedSources-input.xcfilelist:
2056         * DumpRenderTree/DerivedSources-output.xcfilelist:
2057
2058 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2059
2060         Unreviewed, rolling out r242825.
2061         https://bugs.webkit.org/show_bug.cgi?id=195648
2062
2063         "Broke webkitpy tests with my change to
2064         lldb_dump_class_layout.py" (Requested by rmorisset on
2065         #webkit).
2066
2067         Reverted changeset:
2068
2069         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2070         classes with suspicious padding"
2071         https://bugs.webkit.org/show_bug.cgi?id=195573
2072         https://trac.webkit.org/changeset/242825
2073
2074 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2075
2076         [ews-build] Show status bubbles while the patch is waiting in queue
2077         https://bugs.webkit.org/show_bug.cgi?id=195618
2078
2079         Reviewed by Lucas Forschler.
2080
2081         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2082         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2083         enabled in initial deployment.
2084         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2085         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2086         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2087         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2088         (StatusBubble._build_bubbles_for_patch):
2089
2090 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2091
2092         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2093         https://bugs.webkit.org/show_bug.cgi?id=195573
2094
2095         Reviewed by Simon Fraser.
2096
2097         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2098
2099         * Scripts/dump-class-layout:
2100         (main):
2101         * lldb/lldb_dump_class_layout.py:
2102         (ClassLayout.__init__):
2103         (ClassLayout._compute_padding_recursive):
2104         (LLDBDebuggerInstance.dump_layout_for_classname):
2105         (LLDBDebuggerInstance):
2106         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2107         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2108
2109 2019-03-12  Chris Dumez  <cdumez@apple.com>
2110
2111         Device Orientation access permission should be denied unless explicitly granted by the client
2112         https://bugs.webkit.org/show_bug.cgi?id=195625
2113
2114         Reviewed by Youenn Fablet.
2115
2116         add API test coverage.
2117
2118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2119         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2120         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2121         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2122         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2123         (runDeviceOrientationTest):
2124         (TEST):
2125         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2126         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2127
2128 2019-03-12  Jer Noble  <jer.noble@apple.com>
2129
2130         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2131         https://bugs.webkit.org/show_bug.cgi?id=195137
2132         <rdar://problem/48810307>
2133
2134         Reviewed by Eric Carlson.
2135
2136         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2137         (TestWebKitAPI::TEST):
2138
2139 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2140
2141         [ews-build] Change urls from uat to production
2142         https://bugs.webkit.org/show_bug.cgi?id=195566
2143
2144         Reviewed by Lucas Forschler.
2145
2146         * BuildSlaveSupport/ews-app/ews/config.py:
2147         * BuildSlaveSupport/ews-build/events.py:
2148         * BuildSlaveSupport/ews-build/steps.py:
2149
2150 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2151
2152         [ews-build] change max_builds for local-worker to 1
2153         https://bugs.webkit.org/show_bug.cgi?id=195568
2154
2155         Reviewed by Lucas Forschler.
2156
2157         * BuildSlaveSupport/ews-build/loadConfig.py:
2158
2159 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2160
2161         Fix the build
2162
2163         * TestRunnerShared/spi/PencilKitTestSPI.h:
2164         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2165
2166 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2167
2168         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2169         https://bugs.webkit.org/show_bug.cgi?id=194131
2170
2171         Reviewed by Michael Catanzaro.
2172
2173         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2174         (uriChanged):
2175         (testUnfinishedSubresourceLoad):
2176         (serverCallback):
2177         (beforeAll):
2178
2179 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2180
2181         WTF::Expected should use std::addressof instead of operator&
2182         https://bugs.webkit.org/show_bug.cgi?id=195604
2183
2184         Reviewed by Myles Maxfield.
2185
2186         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2187         (TestWebKitAPI::Unique::Unique):
2188         (TestWebKitAPI::Unique::operator&):
2189         (TestWebKitAPI::TEST):
2190
2191 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2192
2193         Add Optional to Forward.h.
2194         https://bugs.webkit.org/show_bug.cgi?id=195586
2195
2196         Reviewed by Darin Adler.
2197
2198         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2199         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2200         Remove unnecessary includes from headers.
2201
2202 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2203
2204         Add testing API to hit-test and scroll overflow scrollers
2205         https://bugs.webkit.org/show_bug.cgi?id=195278
2206
2207         Reviewed by Antti Koivisto.
2208         
2209         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2210         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2211         
2212         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2213
2214         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2215         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2216         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2217         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2218         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2219         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2220         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2221         (WTR::enclosingScrollViewIncludingSelf):
2222         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2223
2224 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2225
2226         API test WebKit.RequestTextInputContext fails on iOS
2227         https://bugs.webkit.org/show_bug.cgi?id=195585
2228
2229         Reviewed by Wenson Hsieh and Simon Fraser.
2230
2231         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2232         (applyStyle):
2233         (TEST):
2234         Add a viewport, so that the coordinates match up on iOS.
2235         Scroll by moving the UIScrollView's contentOffset.
2236
2237 2019-03-11  Chris Dumez  <cdumez@apple.com>
2238
2239         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2240         https://bugs.webkit.org/show_bug.cgi?id=195506
2241         <rdar://problem/48733477>
2242
2243         Reviewed by Alex Christensen.
2244
2245         Add API test coverage.
2246
2247         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2248
2249 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2250
2251         Adding myself to contributors.json
2252
2253         Unreviewed, addming myself to contributors.json .
2254
2255         * Scripts/webkitpy/common/config/contributors.json:
2256
2257 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2258
2259         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2260         https://bugs.webkit.org/show_bug.cgi?id=195511
2261         <rdar://problem/44873269>
2262
2263         Reviewed by Darin Adler.
2264
2265         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2266         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2267         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2268         (TEST_F):
2269
2270 2019-03-11  Chris Dumez  <cdumez@apple.com>
2271
2272         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2273         https://bugs.webkit.org/show_bug.cgi?id=195561
2274
2275         Reviewed by Youenn Fablet.
2276
2277         Make sure the JS in the test requests for permission to receive device orientation events.
2278
2279         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2280
2281 2019-03-11  Youenn Fablet  <youenn@apple.com>
2282
2283         Allow storage quota increase by default in WTR
2284         https://bugs.webkit.org/show_bug.cgi?id=195541
2285
2286         Reviewed by Geoffrey Garen.
2287
2288         Allow storage quota increase by default in WTR.
2289         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2290         Use this for tests that explicitly need cache increase.
2291
2292         Instead of increasing quota by 2, make sure the next request is
2293         granted by adding all given parameters.
2294
2295         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2296         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2297         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2298         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2299         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2300         * WebKitTestRunner/TestController.cpp:
2301         (WTR::TestController::setAllowStorageQuotaIncrease):
2302         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2303         * WebKitTestRunner/TestController.h:
2304         * WebKitTestRunner/TestInvocation.cpp:
2305         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2306         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2307         (WTR::TestController::cocoaResetStateToConsistentValues):
2308         (WTR::TestController::setAllowStorageQuotaIncrease):
2309         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2310         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2311         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2312
2313 2019-03-11  Xan Lopez  <xan@igalia.com>
2314
2315         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2316         https://bugs.webkit.org/show_bug.cgi?id=194147
2317
2318         Reviewed by Michael Saboff.
2319
2320         To make --32-bit work correctly on Linux/64bit we need to:
2321
2322         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2323         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2324         unfortunately CMake only allows us to do this during
2325         crosscompilation, which is overkill here.
2326         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2327         pkg-config detection module uses the x86 .pc files instead of the
2328         x86_64 ones.
2329         - Set the -m32 flags for the compiler.
2330
2331         * Scripts/webkitdirs.pm:
2332         (generateBuildSystemFromCMakeProject):
2333
2334 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2335
2336         Add MotionMark-1.1 plan file for run-benchmark script.
2337         https://bugs.webkit.org/show_bug.cgi?id=195481
2338
2339         Rubber-stamped by Darin Adler.
2340
2341         Run-benchmark script should support MontionMark-1.1.
2342
2343         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2344
2345 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2346
2347         [ews-app] Add support for submit-to-ews url
2348         https://bugs.webkit.org/show_bug.cgi?id=195477
2349
2350         Reviewed by Lucas Forschler.
2351
2352         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2353         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2354         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2355         * BuildSlaveSupport/ews-app/ews/urls.py:
2356         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2357
2358 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2359
2360         Unreviewed, rolling out r242688, r242643, r242624.
2361
2362         Caused multiple layout test failures and crashes on iOS and macOS.
2363
2364         Reverted changeset:
2365
2366         "requestAnimationFrame should execute before the next frame"
2367         https://bugs.webkit.org/show_bug.cgi?id=177484
2368         https://trac.webkit.org/changeset/242624/webkit
2369
2370         * Tracing/SystemTracePoints.plist:
2371
2372 2019-03-11  John Wilander  <wilander@apple.com>
2373
2374         Resource Load Statistics: Make it possible exclude localhost from classification
2375         https://bugs.webkit.org/show_bug.cgi?id=195474
2376         <rdar://problem/47520577>
2377
2378         Reviewed by Brent Fulgham.
2379
2380         This patch allows for localhost to be excluded from classification and
2381         treatment as a prevalent resource.
2382
2383         The WebKit Tools change adds a new function called
2384         testRunner.setStatisticsIsRunningTest() which can be used to control this
2385         behavior.
2386
2387         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2388         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2389         (WTR::TestRunner::setStatisticsIsRunningTest):
2390         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2391         * WebKitTestRunner/TestController.cpp:
2392         (WTR::TestController::setStatisticsIsRunningTest):
2393         * WebKitTestRunner/TestController.h:
2394         * WebKitTestRunner/TestInvocation.cpp:
2395         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2396
2397 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2398
2399         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2400         https://bugs.webkit.org/show_bug.cgi?id=195560
2401
2402         Reviewed by Lucas Forschler.
2403
2404         * BuildSlaveSupport/ews-build/master.cfg:
2405
2406 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2407
2408         Unreviewed, rolling out r242698.
2409
2410         API test crashes on bots.
2411
2412         Reverted changeset:
2413
2414         "Add a WKContentRuleList variant that uses copied memory
2415         instead of mmap'd shared memory for class A containerized
2416         apps"
2417         https://bugs.webkit.org/show_bug.cgi?id=195511
2418         https://trac.webkit.org/changeset/242698
2419
2420 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2421
2422         [WPE] Enable web process sandbox
2423         https://bugs.webkit.org/show_bug.cgi?id=195169
2424
2425         Reviewed by Daniel Bates.
2426
2427         * wpe/install-dependencies:
2428         * wpe/jhbuild.modules:
2429
2430 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2431
2432         [ews-app] Use port 17000 for worker communication
2433         https://bugs.webkit.org/show_bug.cgi?id=195558
2434
2435         Reviewed by Lucas Forschler.
2436
2437         * BuildSlaveSupport/ews-build/master.cfg:
2438
2439 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2440
2441         [ews-build] unit-tests fail when passwords.json is missing
2442         https://bugs.webkit.org/show_bug.cgi?id=195557
2443
2444         Reviewed by Lucas Forschler.
2445
2446         * BuildSlaveSupport/ews-build/loadConfig.py:
2447         (loadBuilderConfig):
2448         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2449         (ConfigDotJSONTest.test_configuration):
2450         * BuildSlaveSupport/ews-build/master.cfg:
2451
2452 2019-03-11  Truitt Savell  <tsavell@apple.com>
2453
2454         Unreviewed, rolling out r242702.
2455
2456         Broke High Sierra builders.
2457
2458         Reverted changeset:
2459
2460         "Add utility function to allow easy reverse range-based
2461         iteration of a container"
2462         https://bugs.webkit.org/show_bug.cgi?id=195542
2463         https://trac.webkit.org/changeset/242702
2464
2465 2019-03-11  Sam Weinig  <sam@webkit.org>
2466
2467         Add utility function to allow easy reverse range-based iteration of a container
2468         https://bugs.webkit.org/show_bug.cgi?id=195542
2469
2470         Reviewed by Antti Koivisto.
2471
2472         * TestWebKitAPI/CMakeLists.txt:
2473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2474         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2475         (TestWebKitAPI::TEST):
2476         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2477
2478 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2479
2480         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2481         https://bugs.webkit.org/show_bug.cgi?id=195511
2482         <rdar://problem/44873269>
2483
2484         Reviewed by Darin Adler.
2485
2486         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2487         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2488         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2489         (TEST_F):
2490
2491 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2492
2493         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2494         https://bugs.webkit.org/show_bug.cgi?id=195499
2495
2496         Reviewed by Darin Adler.
2497
2498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2499         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2500         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2501         (-[WKWebView synchronouslyFocusTextInputContext:]):
2502         (applyStyle):
2503         (applyIframe):
2504         (TEST):
2505         Add some tests for this SPI.
2506
2507 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2508
2509         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2510         https://bugs.webkit.org/show_bug.cgi?id=181151
2511
2512         Reviewed by Don Olmstead.
2513
2514         * TestWebKitAPI/CMakeLists.txt:
2515         * TestWebKitAPI/PlatformWin.cmake:
2516         Enable TestWTF RunLoop tests in all platforms.
2517
2518         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2519         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2520         (TestWebKitAPI::DerivedOneShotTimer::fired):
2521         (TestWebKitAPI::TEST):
2522         Only a few platforms support nested RunLoop.
2523
2524         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2525         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2526
2527 2019-03-10  David Quesada  <david_quesada@apple.com>
2528
2529         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2530         https://bugs.webkit.org/show_bug.cgi?id=152480
2531
2532         Reviewed by Chris Dumez.
2533
2534         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2535         there are no additional references to the process pool besides the one held by
2536         the download, waits for the download to finish (in the sense that the
2537         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2538         measure, also check that the process pool has been deallocated at the end of the
2539         test. The test wouldn't be meaningful if the process pool were still alive.
2540
2541         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2542         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2543         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2544             The download will be canceled because the delegate does not implement the
2545             method to decide the download's destination, so this is where we know the
2546             DownloadProxyMap is done with the DownloadProxy.
2547         (TEST):
2548
2549 2019-03-08  Chris Dumez  <cdumez@apple.com>
2550
2551         Add support for Device Orientation / Motion permission API
2552         https://bugs.webkit.org/show_bug.cgi?id=195329
2553         <rdar://problem/47645367>
2554
2555         Reviewed by Geoffrey Garen.
2556
2557         Add test infrastructure to help test the Device Orientation / Motion permission API.
2558
2559         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2560         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2561         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2562         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2563         * WebKitTestRunner/TestController.cpp:
2564         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2565         (WTR::TestController::createWebViewWithOptions):
2566         (WTR::TestController::resetStateToConsistentValues):
2567         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2568         * WebKitTestRunner/TestController.h:
2569         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2570         * WebKitTestRunner/TestInvocation.cpp:
2571         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2572
2573 2019-03-08  Saam barati  <sbarati@apple.com>
2574
2575         Add a compare-results script to compare benchmark results
2576         https://bugs.webkit.org/show_bug.cgi?id=195486
2577         <rdar://problem/48723397>
2578
2579         Reviewed by Geoffrey Garen.
2580
2581         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2582         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2583         to extend it to learn about our other benchmarks.
2584
2585         * Scripts/compare-results: Added.
2586         (readJSONFile):
2587         (detectJetStream2):
2588         (JetStream2Results):
2589         (detectSpeedometer2):
2590         (Speedometer2Results):
2591         (detectPLT5):
2592         (PLT5Results):
2593         (detectBenchmark):
2594         (biggerIsBetter):
2595         (ttest):
2596         (getOptions):
2597         (main):
2598
2599 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2600
2601         Ensure old tab state is cleared between iterations of run-benchmark
2602         https://bugs.webkit.org/show_bug.cgi?id=195393
2603         <rdar://problem/46885583>
2604
2605         Reviewed by Dewei Zhu.
2606
2607         a) ensure the default to restore state is not set
2608         b) terminate Safari correctly
2609         c) Set the system default to ignore Persistent State in Safari
2610
2611         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2612         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2613         (OSXBrowserDriver.prepare_env): 
2614         (OSXBrowserDriver.restore_env):
2615         (OSXBrowserDriver.close_browsers):
2616         (OSXBrowserDriver._terminate_processes):
2617         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2618         (OSXChromeDriver):
2619         (OSXChromeCanaryDriver):
2620         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2621         (OSXFirefoxDriver):
2622         (OSXFirefoxNightlyDriver):
2623         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2624         (OSXSafariDriver):
2625         (OSXSafariDriver.prepare_env):
2626
2627 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2628
2629         [GTK] Several InputMethodFilter tests are failing
2630         https://bugs.webkit.org/show_bug.cgi?id=195408
2631
2632         Reviewed by Carlos Garcia Campos.
2633
2634         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2635         Regressed in r241751.
2636         Hexadecimal values of keycodes are expressed now in upper letters.
2637         Composited characters should be cast to UTF8 strings.
2638
2639         (TestWebKitAPI::TEST):
2640
2641 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2642
2643         [GTK] Make Tools/gtkdoc python3 compatible
2644         https://bugs.webkit.org/show_bug.cgi?id=195359
2645
2646         Reviewed by Carlos Garcia Campos.
2647
2648         * gtkdoc/generate-gtkdoc:
2649         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2650         work with Python 2 and 3.
2651         (get_gtkdoc_module_paths):
2652         The iteritems() was removed in Python 3, so let's use items() that's
2653         available in Python 2 and 3.
2654         (get_generator_for_config):
2655         * gtkdoc/gtkdoc.py:
2656         (GTKDoc._run_command):
2657         The sys.stdout.write() is expecting str in Python 3 and not bytes
2658         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2659         for passing the bytes there.
2660
2661 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2662
2663         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2664         https://bugs.webkit.org/show_bug.cgi?id=195346
2665         <rdar://problem/48667048>
2666
2667         Unreviewed build fix for clang-cl.
2668
2669         * DumpRenderTree/win/DumpRenderTree.cpp:
2670         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2671
2672 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2673
2674         requestAnimationFrame should execute before the next frame
2675         https://bugs.webkit.org/show_bug.cgi?id=177484
2676
2677         Reviewed by Simon Fraser.
2678
2679         Add trace points for the page RenderingUpdate.
2680
2681         * Tracing/SystemTracePoints.plist:
2682
2683 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2684
2685         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2686         https://bugs.webkit.org/show_bug.cgi?id=195353
2687         <rdar://problem/48626394>
2688
2689         Reviewed by Simon Fraser.
2690
2691         * WebKitTestRunner/ios/TestControllerIOS.mm:
2692         (WTR::TestController::platformResetPreferencesToConsistentValues):
2693
2694 2019-03-07  John Wilander  <wilander@apple.com>
2695
2696         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2697         https://bugs.webkit.org/show_bug.cgi?id=195383
2698         <rdar://problem/48570136>
2699
2700         Reviewed by Brent Fulgham.
2701
2702         This patch adds test infrastructure to purge only script-accessible cookies,
2703         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2704
2705         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2706         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2707         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2708         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2709         * WebKitTestRunner/TestController.cpp:
2710         (WTR::TestController::statisticsDeleteCookiesForHost):
2711         * WebKitTestRunner/TestController.h:
2712         * WebKitTestRunner/TestInvocation.cpp:
2713         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2714
2715 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2716
2717         Unreviewed, rolling out r242354.
2718         https://bugs.webkit.org/show_bug.cgi?id=195402
2719
2720         breaks layout tests in all configurations (Requested by
2721         zdobersek on #webkit).
2722
2723         Reverted changeset:
2724
2725         "[WPE] Enable web process sandbox"
2726         https://bugs.webkit.org/show_bug.cgi?id=195169
2727         https://trac.webkit.org/changeset/242354
2728
2729 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2730
2731         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2732         https://bugs.webkit.org/show_bug.cgi?id=195346
2733
2734         Reviewed by Fujii Hironori.
2735
2736         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2737         (TestWebKitAPI::TEST):
2738         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2739
2740         * DumpRenderTree/win/DumpRenderTree.cpp:
2741         (findFontFallback):
2742         (addFontFallbackIfPresent):
2743         (removeFontFallbackIfPresent):
2744         (main):
2745         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2746         (TestWebKitAPI::Util::moduleDirectory):
2747         (TestWebKitAPI::Util::createInjectedBundlePath):
2748         Use wchar helpers as needed.
2749
2750 2019-03-06  Rob Buis  <rbuis@igalia.com>
2751
2752         Consider supporting the `referrerpolicy` attribute.
2753         https://bugs.webkit.org/show_bug.cgi?id=179053
2754
2755         Reviewed by Darin Adler.
2756
2757         Add a runtime flag for referrerpolicy attribute.
2758
2759         * DumpRenderTree/mac/DumpRenderTree.mm:
2760         (enableExperimentalFeatures):
2761
2762 2019-03-05  Daniel Bates  <dabates@apple.com>
2763
2764         Update expected API test result following r242379
2765         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2766
2767         Update expected x-coordinate of selection rect now that the left padding of
2768         a textarea is sized in ems (so dependent on the font size) just like the left
2769         padding of a text field.
2770
2771         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2772         (TestWebKitAPI::TEST):
2773
2774 2019-03-05  David Quesada  <david_quesada@apple.com>
2775
2776         [WK2] It should be possible to follow links with 'download' attributes
2777         https://bugs.webkit.org/show_bug.cgi?id=195145
2778         rdar://problem/48462642
2779
2780         Reviewed by Alex Christensen.
2781
2782         Add a unit test to verify that activating links with 'download' attributes now
2783         navigates to the linked resource, rather than starts downloading it. Add another
2784         to verify that it is still possible to explicitly download the link via the
2785         'Download' navigation action policy.
2786
2787         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2788         (-[DownloadAttributeTestDelegate init]):
2789         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2790         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2791         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2792         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2793         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2794         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2795         (TEST):
2796         * WebKitTestRunner/TestController.cpp:
2797         (WTR::TestController::decidePolicyForNavigationAction):
2798         * WebKitTestRunner/TestController.h:
2799
2800 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2801
2802         [Curl] Implement Cookie Accept Policy.
2803         https://bugs.webkit.org/show_bug.cgi?id=191645
2804
2805         Reviewed by Fujii Hironori.
2806
2807         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2808         (TestWebKitAPI::Curl::TEST_F):
2809
2810 2019-03-05  Youenn Fablet  <youenn@apple.com>
2811
2812         Rename requestCacheStorageSpace to requestStorageSpace
2813         https://bugs.webkit.org/show_bug.cgi?id=195282
2814
2815         Reviewed by Chris Dumez.
2816
2817         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2818         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2819         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2820
2821 2019-03-05  Brady Eidson  <beidson@apple.com>
2822
2823         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2824         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2825
2826         Reviewed by Tim Horton.
2827
2828         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2829         different directory into that same WKWebView should work.
2830
2831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2832         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2833
2834 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2835
2836         Add WeakHashSet
2837         https://bugs.webkit.org/show_bug.cgi?id=195152
2838
2839         Reviewed by Antti Koivisto.
2840
2841         Added tests for WeakHashSet.
2842
2843         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2844         (TestWebKitAPI::Base::Base): Moved.
2845         (TestWebKitAPI::Derived::foo): Moved.
2846         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2847         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2848         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2849         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2850
2851 2019-03-04  Chris Dumez  <cdumez@apple.com>
2852
2853         Do not share WebProcesses between private and regular sessions
2854         https://bugs.webkit.org/show_bug.cgi?id=195189
2855         <rdar://problem/48421064>
2856
2857         Reviewed by Alex Christensen.
2858
2859         Add API test coverage.
2860
2861         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2862         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2863
2864 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2865
2866         [WPE] Enable web process sandbox
2867         https://bugs.webkit.org/show_bug.cgi?id=195169
2868
2869         Reviewed by Daniel Bates.
2870
2871         * wpe/install-dependencies:
2872         * wpe/jhbuild.modules:
2873
2874 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2875
2876         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2877         https://bugs.webkit.org/show_bug.cgi?id=195206
2878
2879         Reviewed by Žan Doberšek.
2880
2881         Add a new test case.
2882
2883         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2884         (testJSCClass):
2885
2886 2019-03-04  Charlie Turner  <cturner@igalia.com>
2887
2888         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2889         https://bugs.webkit.org/show_bug.cgi?id=194898
2890
2891         Reviewed by Žan Doberšek.
2892
2893         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2894         a GCC extension that permits arithmetic on void* pointer. Inline
2895         the macro until this issue is fixed upstream.
2896
2897 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2898
2899         Rid the world of WK_API_ENABLED
2900         https://bugs.webkit.org/show_bug.cgi?id=195263
2901
2902         Reviewed by Dan Bernstein.
2903
2904         List of changed files elided because it's useless.
2905
2906 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2907
2908         Unreviewed follow-up to r242292.
2909
2910         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2911
2912         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2913         (TestWebKitAPI::testStrip): Renamed from strip.
2914         (TestWebKitAPI::TEST):
2915
2916 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2917
2918         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2919
2920         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2921         and bug #194272 for details.
2922
2923         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2924
2925 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2926
2927         Remove some more unused 32-bit code
2928         https://bugs.webkit.org/show_bug.cgi?id=195255
2929
2930         Reviewed by Darin Adler.
2931
2932         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2933         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2934         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2935         (NPP_New):
2936         (NPP_HandleEvent):
2937         (handleEventCarbon): Deleted.
2938
2939 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2940
2941         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2942
2943         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2944         (TestWebKitAPI::TEST):
2945
2946 2019-03-01  Darin Adler  <darin@apple.com>
2947
2948         Finish removing String::format
2949         https://bugs.webkit.org/show_bug.cgi?id=194893
2950
2951         Reviewed by Daniel Bates.
2952 '
2953         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2954
2955 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2956
2957         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2958         https://bugs.webkit.org/show_bug.cgi?id=195229
2959         <rdar://problem/48520362>
2960
2961         Reviewed by Chris Dumez.
2962
2963         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2964         (TEST):
2965
2966 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2967
2968         Add a system trace scope for event region building
2969         https://bugs.webkit.org/show_bug.cgi?id=195226
2970
2971         Reviewed by Jon Lee.
2972
2973         This trace scope measures the time spend converting element rects into Region objects,
2974         which can be large on some pages.
2975
2976         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2977
2978         * Tracing/SystemTracePoints.plist:
2979
2980 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2981
2982         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2983         https://bugs.webkit.org/show_bug.cgi?id=194612
2984
2985         Reviewed by Alex Christensen.
2986
2987         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2988         Just test the new string-processing function and don't touch the actual environment.
2989         (Test cases are all as before, but based on operator== instead of strcmp.)
2990
2991 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2992
2993         [ews-app] Update primary keys for handling multiple Buildbot instances
2994         https://bugs.webkit.org/show_bug.cgi?id=195120
2995
2996         Reviewed by Stephanie Lewis.
2997
2998         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2999         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3000         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3001
3002         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3003         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3004         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3005         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3006         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3007         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3008
3009 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3010
3011         [WinCairo] Enable service worker
3012         https://bugs.webkit.org/show_bug.cgi?id=188318
3013
3014         Reviewed by Youenn Fablet.
3015
3016         * DumpRenderTree/DumpRenderTreePrefix.h:
3017         * TestWebKitAPI/PlatformWin.cmake:
3018         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3019         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3020         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3021
3022 2019-03-01  Justin Fan  <justin_fan@apple.com>
3023
3024         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3025         https://bugs.webkit.org/show_bug.cgi?id=195191
3026
3027         Rubber-stamped by Dean Jackson.
3028
3029         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3030
3031         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3032
3033 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3034
3035         Unreviewed, fix lldb webkitpy tests
3036         https://bugs.webkit.org/show_bug.cgi?id=194375
3037
3038         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3039
3040         * lldb/lldb_webkit.py:
3041         (WTFStringImplProvider.is_8bit):
3042
3043 2019-02-28  David Quesada  <david_quesada@apple.com>
3044
3045         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3046         https://bugs.webkit.org/show_bug.cgi?id=195121
3047         rdar://problem/48450302
3048
3049         Reviewed by Alex Christensen.
3050
3051         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3052         configurations where the 'download' attribute is absent, blank, or populated
3053         with a filename, and where the anchor element is same-origin or cross-origin
3054         (meaning the 'download' attribute shouldn't be honored).
3055
3056         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3057         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3058         (-[NavigationActionTestDelegate init]):
3059         (-[NavigationActionTestDelegate navigationAction]):
3060         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3061         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3062         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3063         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3064         (TEST):
3065
3066 2019-02-28  Antoine Quint  <graouts@apple.com>
3067
3068         Enable the Pointer Events runtime flag by default
3069         https://bugs.webkit.org/show_bug.cgi?id=195156
3070
3071         Reviewed by Dean Jackson.
3072
3073         * DumpRenderTree/mac/DumpRenderTree.mm:
3074         (enableExperimentalFeatures):
3075
3076 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3077
3078         Several PasteImage API tests are flaky
3079         https://bugs.webkit.org/show_bug.cgi?id=195160
3080
3081         Reviewed by Tim Horton.
3082
3083         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3084         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3085         listening for a "load" event after image load is already complete.
3086
3087         To address this, make these tests first register a "load" event handler, then run script to insert an image
3088         element into the document, and finally wait until the load event is observed before checking image size.
3089
3090         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3091
3092 2019-02-28  Chris Dumez  <cdumez@apple.com>
3093
3094         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3095         https://bugs.webkit.org/show_bug.cgi?id=195107
3096
3097         Reviewed by Alex Christensen.
3098
3099         Give some time for the zoom level to get restored.
3100
3101         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3102
3103 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3104
3105         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3106         https://bugs.webkit.org/show_bug.cgi?id=194958
3107
3108         Reviewed by Geoffrey Garen.
3109
3110         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3111         (TEST):
3112
3113 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3114
3115         [ews-app] Update method to save build to handle builder_display_name
3116         https://bugs.webkit.org/show_bug.cgi?id=195047
3117
3118         Reviewed by Dewei Zhu.
3119
3120         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3121         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3122
3123 2019-02-28  Justin Fan  <justin_fan@apple.com>
3124
3125         [Web GPU] Enable Web GPU only on 64-bit
3126         https://bugs.webkit.org/show_bug.cgi?id=195139
3127
3128         Because Metal is only supported on 64 bit apps.
3129
3130         Unreviewed build fix.
3131
3132         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3133
3134 2019-02-27  Youenn Fablet  <youenn@apple.com>
3135
3136         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3137         https://bugs.webkit.org/show_bug.cgi?id=194959
3138
3139         Reviewed by Chris Dumez.
3140
3141         Spin loop until getting the condition to remove flakiness.
3142
3143         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3144
3145 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3146
3147         [ews-build] Buildbot should include builder_display_name in the build events
3148         https://bugs.webkit.org/show_bug.cgi?id=195045
3149
3150         Reviewed by Dewei Zhu.
3151
3152         * BuildSlaveSupport/ews-build/events.py:
3153         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3154         buildername to builder_name to be consistent in naming style.
3155         (Events.buildFinished): Ditto.
3156
3157 2019-02-27  Chris Dumez  <cdumez@apple.com>
3158
3159         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3160         https://bugs.webkit.org/show_bug.cgi?id=194480
3161
3162         Reviewed by Brady Eidson.
3163
3164         Update existing API test to make it more likely to reproduce the issue.
3165
3166         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3167
3168 2019-02-27  Brady Eidson  <beidson@apple.com>
3169
3170         Universal links from Google search results pages don't open the app.
3171         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3172
3173         Reviewed by Geoffrey Garen.
3174
3175         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3176         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3177         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3178         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3179
3180 2019-02-27  Chris Dumez  <cdumez@apple.com>
3181
3182         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3183         https://bugs.webkit.org/show_bug.cgi?id=195102
3184
3185         Reviewed by Geoffrey Garen.
3186
3187         If the number of processes is not yet what we expect, wait a bit and check again to give
3188         processes some time to exit.
3189
3190         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3191
3192 2019-02-27  Chris Dumez  <cdumez@apple.com>
3193
3194         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3195         https://bugs.webkit.org/show_bug.cgi?id=194545
3196
3197         Reviewed by Brady Eidson.
3198
3199         Make sure the test navigates forward and then back only once. Previously, navigating
3200         back would trigger a navigation again in a timer.
3201
3202         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3203
3204 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3205
3206         High Sierra Debug JSC test queue should use faster hardware
3207         https://bugs.webkit.org/show_bug.cgi?id=194603
3208
3209         Rubber-stamped by Alexey Proskuryakov.
3210
3211         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3212
3213         * BuildSlaveSupport/build.webkit.org-config/config.json:
3214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3215         (BubbleQueueServer):
3216         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3217         (WebKitBuildbot):
3218         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3219         * QueueStatusServer/config/queues.py:
3220         * Scripts/webkitpy/common/config/ews.json:
3221         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3222         (test_ews_name):
3223
3224 2019-02-27  John Wilander  <wilander@apple.com>
3225
3226         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3227         https://bugs.webkit.org/show_bug.cgi?id=195071
3228         <rdar://problem/48417690>
3229
3230         Reviewed by Alex Christensen and Brent Fulgham.
3231
3232         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3233         (TestWebKitAPI::createURL):
3234             Convenience function.
3235         (TestWebKitAPI::TEST):
3236             WebCore::AdClickAttribution now takes a URL when creating Source and
3237             Destination.
3238         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3239         (TestWebKitAPI::TEST):
3240             WebCore::AdClickAttribution now takes a URL when creating Source and
3241             Destination.
3242
3243 2019-02-27  Antoine Quint  <graouts@apple.com>
3244
3245         Support Pointer Events on macOS
3246         https://bugs.webkit.org/show_bug.cgi?id=195008
3247         <rdar://problem/47454419>
3248
3249         Reviewed by Dean Jackson.
3250
3251         * DumpRenderTree/mac/DumpRenderTree.mm:
3252         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3253         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3254
3255 2019-02-26  Mark Lam  <mark.lam@apple.com>
3256
3257         Remove remaining poisoning code.
3258         https://bugs.webkit.org/show_bug.cgi?id=194138
3259
3260         Reviewed by Saam Barati.
3261
3262         * TestWebKitAPI/CMakeLists.txt:
3263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3264         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3265         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3266         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3267         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3268         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3269         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3270
3271 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3272
3273         Move ephemeral local storage from WebProcess to UIProcess
3274         https://bugs.webkit.org/show_bug.cgi?id=195074
3275         <rdar://problem/47937975>
3276
3277         Reviewed by Geoff Garen.
3278
3279         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3280
3281 2019-02-20  Jer Noble  <jer.noble@apple.com>
3282
3283         [Cocoa] Media elements will restart network buffering just before suspending
3284         https://bugs.webkit.org/show_bug.cgi?id=193691
3285
3286         Reviewed by Eric Carlson.
3287
3288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3289         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3290         (TEST):
3291
3292 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3293
3294         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3295         https://bugs.webkit.org/show_bug.cgi?id=191652
3296
3297         Reviewed by Alex Christensen.
3298
3299         Fix WinCairo MiniBrowser behavior of authentication dialog.
3300
3301         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3302         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3303
3304 2019-02-26  Youenn Fablet  <youenn@apple.com>
3305
3306         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3307         https://bugs.webkit.org/show_bug.cgi?id=195028
3308         <rdar://problem/48243733>
3309
3310         Reviewed by Eric Carlson.
3311
3312         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3313
3314 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3315
3316         [WPE] Add API for webview background color configuration
3317         https://bugs.webkit.org/show_bug.cgi?id=192305
3318
3319         Reviewed by Michael Catanzaro.
3320
3321         * MiniBrowser/wpe/main.cpp:
3322         (main): Add a new option to configure the webview background
3323         color. Example: --bg-color=transparent.
3324         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3325         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3326         (beforeAll): Ditto.
3327
3328 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3329
3330         scalableNativeWebpageParameters() is not preserved on new page navigation.
3331         https://bugs.webkit.org/show_bug.cgi?id=194892
3332         <rdar://problem/47538280>
3333
3334         Reviewed by Wenson Hsieh.
3335         
3336         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3337
3338         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3339         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3340         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3341         (WTR::UIScriptController::allowsViewportShrinkToFit):
3342         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3343         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3344         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3345         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3346         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3347         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3348
3349 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3350
3351         [ews-app] Add model for handling multiple Buildbot instances
3352         https://bugs.webkit.org/show_bug.cgi?id=194863
3353
3354         Reviewed by Stephanie Lewis.
3355
3356         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3357
3358 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3359
3360         [ews-app] Remove BuilderMapping table
3361         https://bugs.webkit.org/show_bug.cgi?id=194961
3362
3363         Reviewed by Stephanie Lewis.
3364
3365         Store builder name directly in build table, instead of having a separate
3366         table for it.
3367
3368         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3369         * BuildSlaveSupport/ews-app/ews/models/build.py:
3370         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3371         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3372
3373 2019-02-25  John Wilander  <wilander@apple.com>
3374
3375         Introduce and adopt new class RegistrableDomain for eTLD+1
3376         https://bugs.webkit.org/show_bug.cgi?id=194791
3377         <rdar://problem/48179240>
3378
3379         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3380
3381         This patch adds an API test and replaces two instances of
3382         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3383
3384         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3385         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3386         (TestWebKitAPI::TEST):
3387             Changed two strings to make sure the registrable domains are still considered
3388             invalid and pass the test.
3389         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3390         (TestWebKitAPI::TEST):
3391         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3392         (WTR::InjectedBundle::didReceiveMessageToPage):
3393
3394 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3395
3396         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3397         https://bugs.webkit.org/show_bug.cgi?id=195001
3398
3399         Reviewed by Carlos Garcia Campos.
3400
3401         API version 1.0 always includes the functionality previously guarded with
3402         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3403         unconditionally.
3404
3405         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3406         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3407         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3408         (WebViewTest::showInWindow): Ditto.
3409         (WebViewTest::hideView): Ditto.
3410         * wpe/backends/HeadlessViewBackend.cpp:
3411         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3412         * wpe/backends/ViewBackend.cpp:
3413         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3414         * wpe/backends/WindowViewBackend.cpp:
3415         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3416         WPE_BACKEND_CHECK_VERSION().
3417         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3418
3419 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3420
3421         [Flatpak] Add support for flatpak > 1.1.2
3422         https://bugs.webkit.org/show_bug.cgi?id=194088
3423
3424         Flatpak 1.2 is now out so we need to support that
3425         version now.
3426
3427         Reviewed by Michael Catanzaro.
3428
3429         * flatpak/flatpakutils.py:
3430         (check_flatpak):
3431         (FlatpakPackages.__init__):
3432         (FlatpakPackages.__detect_packages):
3433         (FlatpakPackages.__detect_packages.in):
3434         (FlatpakRepos.update):
3435
3436 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3437
3438         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3439         https://bugs.webkit.org/show_bug.cgi?id=194998
3440
3441         Reviewed by Carlos Garcia Campos.
3442
3443         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3444         to a Git checkout and using the latest commit containing various fixes
3445         and improvements.
3446
3447 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3448
3449         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3450         https://bugs.webkit.org/show_bug.cgi?id=194981
3451
3452         Reviewed by Žan Doberšek.
3453
3454         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3455         (TestWebKitAPI::TEST):
3456
3457 2019-02-23  Keith Miller  <keith_miller@apple.com>
3458
3459         Add new mac target numbers
3460         https://bugs.webkit.org/show_bug.cgi?id=194955
3461
3462         Reviewed by Tim Horton.
3463
3464         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3465         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3466         * MiniBrowser/Configurations/Base.xcconfig:
3467         * TestWebKitAPI/Configurations/Base.xcconfig:
3468         * WebKitTestRunner/Configurations/Base.xcconfig:
3469
3470 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3471
3472         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3473         https://bugs.webkit.org/show_bug.cgi?id=194846
3474
3475         Reviewed by Don Olmstead.
3476
3477         Added _search_paths() and _port_specific_expectations_files() for
3478         WinCairoPort.
3479
3480         * Scripts/webkitpy/port/win.py:
3481         (WinCairoPort.default_baseline_search_path):
3482         (WinCairoPort):
3483         (WinCairoPort._port_specific_expectations_files):
3484         (WinCairoPort._search_paths):
3485
3486 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3487
3488         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3489         https://bugs.webkit.org/show_bug.cgi?id=194963
3490
3491         Reviewed by Dean Jackson.
3492
3493         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3494         Do a `contains` check instead of `equals`, because in debug builds we
3495         put the GraphicsLayer pointer in a prefix.
3496
3497 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3498
3499         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3500         https://bugs.webkit.org/show_bug.cgi?id=194873
3501         <rdar://problem/46701974>
3502
3503         Reviewed by Tim Horton.
3504
3505         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3506
3507         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3508         (WTR::UIScriptController::menuRect const):
3509         (WTR::UIScriptController::isShowingMenu const):
3510         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3511         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3512         (WTR::UIScriptController::menuRect const):
3513
3514         Add a function to query the bounds of the callout menu in content coordinates.
3515
3516         (WTR::UIScriptController::isShowingMenu const):
3517
3518         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3519
3520         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3521         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3522         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3523         (WTR::UIScriptController::rectForMenuAction const):
3524         (WTR::UIScriptController::menuRect const):
3525         (WTR::UIScriptController::isShowingMenu const):
3526         (WTR::findViewInHierarchyOfType): Deleted.
3527
3528 2019-02-22  Chris Dumez  <cdumez@apple.com>
3529
3530         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3531         https://bugs.webkit.org/show_bug.cgi?id=194954
3532         <rdar://problem/48127957>
3533
3534         Reviewed by Alex Christensen.
3535
3536         Add API test coverage.
3537
3538         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3539         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3540         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3541         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3542
3543 2019-02-22  Chris Dumez  <cdumez@apple.com>
3544
3545         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3546         https://bugs.webkit.org/show_bug.cgi?id=194924
3547         <rdar://problem/48216125>
3548
3549         Reviewed by Geoffrey Garen.
3550
3551         Add API test coverage.
3552
3553         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3554
3555 2019-02-22  Chris Dumez  <cdumez@apple.com>
3556
3557         Unreviewed, disable API test added in r241928 on iOS.
3558
3559         The cache is not enabled on devices with less than 3GB of RAM.
3560
3561         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3562
3563 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3564
3565         Hardcode Visual Viewports on everywhere except iOS WK1
3566         https://bugs.webkit.org/show_bug.cgi?id=194928
3567
3568         Reviewed by Zalan Bujtas.
3569
3570         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3571         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3572         set it to false. The setting has shipped for several years and there's no need to turn
3573         it off now.
3574
3575         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3576         Visual Viewports are not enabled.
3577         
3578         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3579         that only runs in WK2
3580
3581         * MiniBrowser/mac/SettingsController.h:
3582         * MiniBrowser/mac/SettingsController.m:
3583         (-[SettingsController init]):
3584         (-[SettingsController _populateMenu]):
3585         (-[SettingsController validateMenuItem:]):
3586         (-[SettingsController visualViewportEnabled]): Deleted.
3587         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3588         * MiniBrowser/mac/WK1BrowserWindowController.m:
3589         (-[WK1BrowserWindowController didChangeSettings]):
3590         * MiniBrowser/mac/WK2BrowserWindowController.m:
3591         (-[WK2BrowserWindowController didChangeSettings]):
3592
3593 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3594
3595         Discard cached processes when clearing website data store
3596         https://bugs.webkit.org/show_bug.cgi?id=194894
3597
3598         Reviewed by Chris Dumez.
3599
3600         Added a test case.
3601
3602         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3603         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3604
3605 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3606
3607         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3608         https://bugs.webkit.org/show_bug.cgi?id=194914
3609         <rdar://problem/47586889>
3610
3611         Reviewed by Geoffrey Garen.
3612
3613         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3614         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3615         (TEST):
3616         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3617
3618 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3619
3620         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3621         <https://webkit.org/b/194761>
3622
3623         Reviewed by Myles Maxfield.
3624
3625         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3626         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3627         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3628         to use ARC-compliant cast.
3629         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3630         ARC-compliant cast.
3631         (WTR::installFakeHelvetica): Log `error` to console if
3632         CTFontManagerRegisterFontsForURL() fails, but only on supported
3633         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3634         Call CFRelease() on `error` to fix the leak.  Update to use
3635         ARC-compliant cast.
3636         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3637         cast.
3638
3639 2019-02-21  Chris Dumez  <cdumez@apple.com>
3640
3641         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3642         https://bugs.webkit.org/show_bug.cgi?id=194481
3643
3644         Reviewed by Alex Christensen.
3645
3646         Give the processes a chance to shutdown and wait until we reached the expected number
3647         of processes.
3648
3649         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3650
3651 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3652
3653         Fix the macOS build
3654
3655         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3656
3657 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3658
3659         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3660
3661         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3662         I am a backwards.
3663
3664 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3665
3666         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3667
3668         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3669         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3670         We could force on UI-side compositing, but I feel like the test might be more
3671         valuable exercising the normal path on each platform (though the original
3672         bug was also UI-side specific). Though we can't validate that the overlay
3673         layer was installed successfully, there are layout tests that do that.
3674
3675 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3676
3677         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3678         https://bugs.webkit.org/show_bug.cgi?id=194845
3679         <rdar://problem/47944579>
3680
3681         Reviewed by Antti Koivisto.
3682
3683         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3684         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3685
3686 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3687
3688         [LFC][Floats] Add support for placing formatting roots in-between floats.
3689         https://bugs.webkit.org/show_bug.cgi?id=194902
3690
3691         Reviewed by Antti Koivisto.
3692
3693         * LayoutReloaded/misc/LFC-passing-tests.txt:
3694
3695 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3696
3697         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3698         https://bugs.webkit.org/show_bug.cgi?id=194901
3699
3700         Unreviewed build fix.
3701
3702         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3703         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3704         WPEBackend-fdo-0.1 as library name.
3705
3706 2019-02-21  Rob Buis  <rbuis@igalia.com>
3707
3708         Update MIME type parser
3709         https://bugs.webkit.org/show_bug.cgi?id=180526
3710
3711         Reviewed by Darin Adler.
3712
3713         Add tests involving leading and trailing whitespace, non-token
3714         characters and quoted strings.
3715
3716         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3717         (TestWebKitAPI::TEST):
3718
3719 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3720
3721         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3722         https://bugs.webkit.org/show_bug.cgi?id=194884
3723
3724         Reviewed by Michael Catanzaro.
3725
3726         * PlatformWin.cmake:
3727
3728 2019-02-20  Chris Dumez  <cdumez@apple.com>
3729
3730         Add API test for <rdar://problem/47471222>
3731         https://bugs.webkit.org/show_bug.cgi?id=194847
3732
3733         Reviewed by Alex Christensen.
3734
3735         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3736
3737 2019-02-20  Chris Dumez  <cdumez@apple.com>
3738
3739         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3740         https://bugs.webkit.org/show_bug.cgi?id=194872
3741         <rdar://problem/47924500>
3742
3743         Reviewed by Alex Christensen.
3744
3745         Add API test coverage.
3746
3747         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3748
3749 2019-02-20  Jer Noble  <jer.noble@apple.com>
3750
3751         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3752         https://bugs.webkit.org/show_bug.cgi?id=191332
3753
3754         Reviewed by Dean Jackson.
3755
3756         * Scripts/git-is-in-range: Added.
3757
3758 2019-02-20  Andy Estes  <aestes@apple.com>
3759
3760         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3761         https://bugs.webkit.org/show_bug.cgi?id=194869
3762
3763         Rubber-stamped by Jer Noble.
3764
3765         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3766         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3767         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3768         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3769         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3770         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3771
3772 2019-02-20  Chris Dumez  <cdumez@apple.com>
3773
3774         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3775         https://bugs.webkit.org/show_bug.cgi?id=194857
3776         <rdar://problem/47759323>
3777
3778         Reviewed by Alex Christensen.
3779
3780         Add API test coverage.
3781
3782         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3783
3784 2019-02-20  Chris Dumez  <cdumez@apple.com>
3785
3786         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3787         https://bugs.webkit.org/show_bug.cgi?id=194829
3788         <rdar://problem/47889906>
3789
3790         Reviewed by Alexey Proskuryakov.
3791
3792         Every time the TestOptions were changing we were creating both a new Web view and
3793         a new WKContext, which would start a new Network process. In most cases, we only
3794         need to contruct a new Web view and we do can keep reusing the same WKContext.
3795         This patch implements this optimization and thus avoids spinning a lot of new
3796         Network processes while running the layout tests.
3797
3798         * WebKitTestRunner/TestController.cpp:
3799         (WTR::TestController::generateContextConfiguration const):
3800         (WTR::TestController::generatePageConfiguration):
3801         (WTR::TestController::createWebViewWithOptions):
3802         (WTR::TestController::resetPreferencesToConsistentValues):
3803         (WTR::updateTestOptionsFromTestHeader):
3804         * WebKitTestRunner/TestController.h:
3805         * WebKitTestRunner/TestOptions.h:
3806         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3807         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3808         (WTR::TestOptions::hasSameInitializationOptions const):
3809         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3810         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3811         (WTR::TestController::platformAddTestOptions const):
3812
3813 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3814
3815         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3816         https://bugs.webkit.org/show_bug.cgi?id=167941
3817
3818         Reviewed by Carlos Garcia Campos.
3819
3820         * MiniBrowser/gtk/main.c:
3821         (filterSavedCallback): Added.
3822         (main): Support loading a JSON rule set file for content filtering.
3823         * MiniBrowser/wpe/main.cpp:
3824         (filterSavedCallback): Added.
3825         (main): Support loading a JSON rule set file for content filtering.
3826         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3827         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3828         (WTF::derefGPtr): Ditto.
3829         (testEmptyStore):
3830         (testSaveInvalidFilter):
3831         (testSaveLoadFilter):
3832         (testSavedFilterIdentifierMatch):
3833         (testRemoveFilter):
3834         (testSaveMultipleFilters):
3835         (testSaveFilterFromFile):
3836         (testFilterPersistence):
3837         (beforeAll):
3838         (afterAll):
3839         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3840         (removeOldInjectedContentAndResetLists): Also reset content filters.
3841         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3842         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3843         the element affected by the style sheet.
3844         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3845         and returns it to be used by tests.
3846         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3847         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3848         (serverCallback): Add support for serving a CSS style sheet for testing.
3849         (beforeAll): Add call to testUserContentManagerContentFilter().
3850         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3851
3852 2019-02-19  Keith Rollin  <krollin@apple.com>
3853
3854         Add timing information to build output
3855         https://bugs.webkit.org/show_bug.cgi?id=194839
3856         <rdar://problem/48219609>
3857
3858         Reviewed by Alexey Proskuryakov.
3859
3860         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3861         emit each project's build time to its output. E.g.,
3862
3863             ** BUILD SUCCEEDED ** [0.132 sec]
3864
3865         * Scripts/webkitdirs.pm:
3866         (XcodeOptions):
3867
3868 2019-02-19  Truitt Savell  <tsavell@apple.com>
3869
3870         Unreviewed, rolling out r241784.
3871
3872         Broke all OpenSource builds.
3873
3874         Reverted changeset:
3875
3876         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3877         instances view"
3878         https://bugs.webkit.org/show_bug.cgi?id=172848
3879         https://trac.webkit.org/changeset/241784
3880
3881 2019-02-19  Zalan Bujtas  <zalan@apple.com>
3882
3883         [LFC][Floats] Remove redundant intersecting logic
3884         https://bugs.webkit.org/show_bug.cgi?id=194804
3885
3886         Reviewed by Antti Koivisto.
3887
3888         * LayoutReloaded/misc/LFC-passing-tests.txt:
3889
3890 2019-02-19  Dean Jackson  <dino@apple.com>
3891
3892         Clean-up output from generate-xcfilelists so it can be filtered
3893         https://bugs.webkit.org/show_bug.cgi?id=194795
3894
3895         Reviewed by Joseph Pecoraro (and Keith Rollin).
3896
3897         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
3898         make a slight tweak to filter-build-webkit so such lines are marked
3899         as plain.
3900
3901         * Scripts/filter-build-webkit:
3902         * Scripts/generate-xcfilelists:
3903
3904 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3905
3906         pytest is not correctly auto-installed
3907         https://bugs.webkit.org/show_bug.cgi?id=194707
3908
3909         Reviewed by Carlos Garcia Campos.
3910
3911         * Scripts/webkitpy/thirdparty/__init__.py:
3912         (AutoinstallImportHook._install_pytest):
3913
3914 2019-02-18  Chris Dumez  <cdumez@apple.com>
3915
3916         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
3917         https://bugs.webkit.org/show_bug.cgi?id=194797
3918         <rdar://problem/48055151>
3919
3920         Reviewed by Geoffrey Garen.
3921
3922         Add API test coverage.
3923
3924         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3925
3926 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3927
3928         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
3929         https://bugs.webkit.org/show_bug.cgi?id=194670
3930         <rdar://problem/39066529>
3931
3932         Reviewed by Tim Horton.
3933
3934         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
3935         pasted in an editable area as attachment elements.
3936
3937         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3938         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3939         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
3940         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3941         (TestWebKitAPI::TEST):
3942         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3943         (WTR::InjectedBundlePage::InjectedBundlePage):
3944
3945 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3946
3947         Fix API test after r241728
3948        ​https://bugs.webkit.org/show_bug.cgi?id=194723
3949
3950         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3951         (TEST):
3952         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
3953
3954 2019-02-18  Daniel Bates  <dabates@apple.com>
3955
3956         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3957         https://bugs.webkit.org/show_bug.cgi?id=192824
3958         <rdar://problem/47100332>
3959
3960         Reviewed by Wenson Hsieh.
3961
3962         Fix a bug where the wrong usage code was used for F13 thru F24.
3963
3964         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3965         (keyCodeForDOMFunctionKey):
3966
3967 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
3968
3969         Bytecode cache should a have a boot-specific validation
3970         https://bugs.webkit.org/show_bug.cgi?id=194769
3971         <rdar://problem/48149509>
3972
3973         Reviewed by Keith Miller.
3974
3975         Add test for WTF::bootSessionUUIDString()
3976
3977         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3978         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
3979         (TEST):
3980
3981 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3982
3983         Disable safe browsing in WKWebView and remove its WKPreferences API
3984         https://bugs.webkit.org/show_bug.cgi?id=194723
3985         <rdar://problem/48122993>
3986
3987         Reviewed by Geoffrey Garen.
3988
3989         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3990         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3991         (TEST):
3992         (safeBrowsingView):
3993         Make tests use SPI instead of API.
3994
3995 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3996
3997         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
3998         https://bugs.webkit.org/show_bug.cgi?id=194586
3999
4000         Reviewed by Ross Kirsling.
4001
4002         * DumpRenderTree/win/DumpRenderTree.cpp:
4003         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4004         * Scripts/webkitpy/port/driver.py:
4005         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4006
4007 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4008
4009         Unreviewed, rolling out r241620.
4010
4011         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
4012         (Requested by ddkilzer on #webkit.)
4013
4014         Reverted changeset:
4015
4016         "[WTF] Add environment variable helpers"
4017         https://bugs.webkit.org/show_bug.cgi?id=192405
4018         https://trac.webkit.org/changeset/241620
4019
4020 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4021
4022         [LFC] RenderImage's default intrinsic size is 0.
4023         https://bugs.webkit.org/show_bug.cgi?id=194745
4024
4025         Reviewed by Antti Koivisto.
4026
4027         * LayoutReloaded/misc/LFC-passing-tests.txt:
4028
4029 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4030
4031         [LFC][BFC] Add support for block replaced intrinsic width.
4032         https://bugs.webkit.org/show_bug.cgi?id=194705
4033
4034         Reviewed by Simon Fraser.
4035
4036         * LayoutReloaded/misc/LFC-passing-tests.txt:
4037
4038 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4039
4040         [LFC] Apply min/max width constraints to preferred width computation
4041         https://bugs.webkit.org/show_bug.cgi?id=194739
4042
4043         Reviewed by Simon Fraser.
4044
4045         * LayoutReloaded/misc/LFC-passing-tests.txt:
4046
4047 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
4048
4049         [WTF] Add environment variable helpers
4050         https://bugs.webkit.org/show_bug.cgi?id=192405
4051
4052         Reviewed by Michael Catanzaro.
4053
4054         * DumpRenderTree/mac/DumpRenderTree.mm:
4055         (libraryPathForDumpRenderTree):
4056         * DumpRenderTree/win/DumpRenderTree.cpp:
4057         (libraryPathForDumpRenderTree):
4058         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4059         (setUpIOSLayoutTestCommunication):
4060         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4061         (beforeAll):
4062         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4063         (main):
4064         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4065         (WebKitTestBus::run):
4066         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4067         (WTR::getOutputDir):
4068         (WTR::initializeFontConfigSetting):
4069         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4070         (WTR::InjectedBundle::platformInitialize):
4071         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4072         (WTR::topLevelPath):
4073         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4074         (WTR::topLevelPath):
4075         (WTR::getOutputDir):
4076         (WTR::activateFonts):
4077         * WebKitTestRunner/TestController.cpp:
4078         (WTR::TestController::libraryPathForTesting):
4079         (WTR::TestController::generateContextConfiguration const):
4080         (WTR::TestController::generatePageConfiguration):
4081         (WTR::TestController::decideDestinationWithSuggestedFilename):
4082         (WTR::TestController::platformAdjustContext):
4083         * WebKitTestRunner/TestController.h:
4084         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4085         (WTR::TestController::cocoaPlatformInitialize):
4086         (WTR::TestController::platformAdjustContext):
4087         * WebKitTestRunner/gtk/main.cpp:
4088         (main):
4089         * WebKitTestRunner/mac/TestControllerMac.mm:
4090         (WTR::TestController::configureContentExtensionForTest):
4091         * WebKitTestRunner/wpe/main.cpp:
4092         (main):
4093         Utilize WTF::Environment where possible.
4094
4095 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4096
4097         [iOS] WKWebView callout bar is missing Change Writing Direction item
4098         https://bugs.webkit.org/show_bug.cgi?id=190015
4099         <rdar://problem/44810366>
4100
4101         Reviewed by Tim Horton.
4102
4103         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
4104         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
4105
4106         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
4107         (TestWebKitAPI::TEST):
4108
4109 2019-02-15  Chris Dumez  <cdumez@apple.com>
4110
4111         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
4112         https://bugs.webkit.org/show_bug.cgi?id=194717
4113         <rdar://problem/47884404>
4114
4115         Reviewed by Brady Eidson.
4116
4117         Add API test coverage.
4118
4119         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4120
4121 2019-02-15  Youenn Fablet  <youenn@apple.com>
4122
4123         Make navigator.mediaDevices SecureContext
4124         https://bugs.webkit.org/show_bug.cgi?id=194666
4125
4126         Reviewed by Eric Carlson.
4127
4128         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4129         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4130         (TEST_F):
4131
4132 2019-02-15  Brian Burg  <bburg@apple.com>
4133
4134         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4135         https://bugs.webkit.org/show_bug.cgi?id=194411
4136         <rdar://problem/47787614>
4137
4138         Reviewed by Joseph Pecoraro.
4139
4140         Remove unnecessary soft linking macro usage.
4141
4142         * DumpRenderTree/mac/TestRunnerMac.mm:
4143         (TestRunner::inspectorTestStubURL):
4144         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4145         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4146         (WTR::TestRunner::inspectorTestStubURL):
4147
4148 2019-02-15  Commit Queue  <commit-queue@webkit.org>
4149
4150         Unreviewed, rolling out r241559 and r241566.
4151         https://bugs.webkit.org/show_bug.cgi?id=194710
4152
4153         Causes layout test crashes under GuardMalloc (Requested by
4154         ryanhaddad on #webkit).
4155
4156         Reverted changesets:
4157
4158         "[WTF] Add environment variable helpers"
4159         https://bugs.webkit.org/show_bug.cgi?id=192405
4160         https://trac.webkit.org/changeset/241559
4161
4162         "Unreviewed build fix for WinCairo Debug after r241559."
4163         https://trac.webkit.org/changeset/241566
4164
4165 2019-02-15  Zalan Bujtas  <zalan@apple.com>
4166
4167         [LFC] Out-of-flow box is never a float box
4168         https://bugs.webkit.org/show_bug.cgi?id=194704
4169
4170         Reviewed by Antti Koivisto.
4171
4172         * LayoutReloaded/misc/LFC-passing-tests.txt:
4173
4174 2019-02-10  Darin Adler  <darin@apple.com>
4175
4176         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
4177         https://bugs.webkit.org/show_bug.cgi?id=194487
4178
4179         Reviewed by Daniel Bates.
4180
4181         * DumpRenderTree/win/DumpRenderTree.cpp:
4182         (applicationId): Use makeString instead of String::format.
4183         (main): Ditto.
4184         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4185         (TestWebKitAPI::Util::createURLForResource): Ditto.
4186         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
4187         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
4188
4189         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4190         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
4191         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
4192         (WTR::createStringWithAttributes): Use appendLiteral.
4193         (WTR::AccessibilityUIElement::helpText const): Ditto.
4194         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
4195         directly instead of using String::format.
4196         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
4197         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
4198
4199 2019-02-15  Truitt Savell  <tsavell@apple.com>
4200
4201         Unreviewed, rolling out r241564.
4202
4203         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
4204
4205         Reverted changeset:
4206
4207         "[Mac] WebInspectorUI.framework does not need to be soft-
4208         linked anymore"
4209         https://bugs.webkit.org/show_bug.cgi?id=194411
4210         https://trac.webkit.org/changeset/241564
4211
4212 2019-02-15  Saam barati  <sbarati@apple.com>
4213
4214         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
4215         https://bugs.webkit.org/show_bug.cgi?id=194036
4216
4217         Reviewed by Yusuke Suzuki.
4218
4219         * Scripts/run-jsc-stress-tests:
4220
4221 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4222
4223         Fix the build.
4224
4225         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4226         (WTR::UIScriptController::drawSquareInEditableImage):
4227         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4228         (TestWebKitAPI::drawSquareInEditableImage):
4229
4230 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4231
4232         Fix the build.
4233
4234         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4235         (WTR::UIScriptController::drawSquareInEditableImage):
4236         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4237         (TestWebKitAPI::drawSquareInEditableImage):
4238
4239 2019-02-14  Brian Burg  <bburg@apple.com>
4240
4241         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4242         https://bugs.webkit.org/show_bug.cgi?id=194411
4243         <rdar://problem/47787614>
4244
4245         Reviewed by Joseph Pecoraro.
4246
4247         Remove unnecessary soft linking macro usage.
4248
4249         * DumpRenderTree/mac/TestRunnerMac.mm:
4250         (TestRunner::inspectorTestStubURL):
4251         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4252         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4253         (WTR::TestRunner::inspectorTestStubURL):
4254
4255 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
4256
4257         [ews-app] status bubble should fetch builder name info from BuilderMapping table
4258         https://bugs.webkit.org/show_bug.cgi?id=194599
4259
4260         Reviewed by Lucas Forschler.
4261
4262         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4263         (StatusBubble._build_bubble):
4264
4265 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
4266
4267         [ews-app] Set Foreign Key in Django build model
4268         https://bugs.webkit.org/show_bug.cgi?id=194667
4269
4270         Reviewed by Lucas Forschler.
4271
4272         * BuildSlaveSupport/ews-app/ews/models/build.py:
4273         (Build):
4274
4275 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
4276
4277         [WTF] Add environment variable helpers
4278         https://bugs.webkit.org/show_bug.cgi?id=192405
4279
4280         Reviewed by Michael Catanzaro.
4281
4282         * DumpRenderTree/mac/DumpRenderTree.mm:
4283         (libraryPathForDumpRenderTree):
4284         * DumpRenderTree/win/DumpRenderTree.cpp:
4285         (libraryPathForDumpRenderTree):
4286         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4287         (setUpIOSLayoutTestCommunication):
4288         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4289         (TestWebKitAPI::strip):
4290         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4291         (beforeAll):
4292         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4293         (main):
4294         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4295         (WebKitTestBus::run):
4296         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4297         (WTR::getOutputDir):
4298         (WTR::initializeFontConfigSetting):
4299         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4300         (WTR::InjectedBundle::platformInitialize):
4301         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4302         (WTR::topLevelPath):
4303         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4304         (WTR::topLevelPath):
4305         (WTR::getOutputDir):
4306         (WTR::activateFonts):
4307         * WebKitTestRunner/TestController.cpp:
4308         (WTR::TestController::libraryPathForTesting):
4309         (WTR::TestController::generateContextConfiguration const):
4310         (WTR::TestController::generatePageConfiguration):
4311         (WTR::TestController::decideDestinationWithSuggestedFilename):
4312         (WTR::TestController::platformAdjustContext):
4313         * WebKitTestRunner/TestController.h:
4314         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4315         (WTR::TestController::cocoaPlatformInitialize):
4316         (WTR::TestController::platformAdjustContext):
4317         * WebKitTestRunner/gtk/main.cpp:
4318         (main):
4319         * WebKitTestRunner/mac/TestControllerMac.mm:
4320         (WTR::TestController::configureContentExtensionForTest):
4321         * WebKitTestRunner/wpe/main.cpp:
4322         (main):
4323         Utilize WTF::Environment where possible.
4324
4325 2019-02-14  Chris Dumez  <cdumez@apple.com>
4326
4327         [PSON] Introduce a WebContent Process cache
4328         https://bugs.webkit.org/show_bug.cgi?id=194594
4329         <rdar://problem/46793397>
4330
4331         Reviewed by Geoff Garen.
4332
4333         Update API tests to turn on the WebContent Process cache.
4334
4335         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4336
4337 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
4338
4339         Unreviewed, build fix after r241480
4340
4341         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4342         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
4343         (-[DragAndDropSimulator initWithWebView:]):
4344
4345 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
4346
4347         AX: ARIA Reflection was disabled in error
4348         https://bugs.webkit.org/show_bug.cgi?id=194647
4349         <rdar://problem/48068336>
4350
4351         Reviewed by Ryosuke Niwa.
4352
4353         Remove test override now that this feature should be enabled by default.
4354
4355         * WebKitTestRunner/TestController.cpp:
4356         (WTR::TestController::resetPreferencesToConsistentValues):
4357
4358 2019-02-14  Commit Queue  <commit-queue@webkit.org>
4359