Add new u-szeged contributors.
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2
3         Add new u-szeged contributors.
4
5         Reviewed by Csaba Osztrogonác.
6
7         * Scripts/webkitpy/common/config/contributors.json:
8
9 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
10
11         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
12         https://bugs.webkit.org/show_bug.cgi?id=132736
13
14         Reviewed by Philippe Normand.
15
16         There are two problems, the path returned by common.library_build_path() is wrong when
17         common.binary_build_path() has previously been called, and the test is still looking for
18         the .la instead of .so
19
20         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
21         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
22         of .la as extension of the injected bundle library.
23         * gtk/common.py:
24         (binary_build_path): Remove unused global variable and add a new
25         one for binary_build_dir instead of sharing the same global
26         variable for library_build_path and binary_build_path.
27
28 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
29
30         [EFL] Enable MEDIA_STREAM for EFL port
31         https://bugs.webkit.org/show_bug.cgi?id=132648
32
33         Reviewed by Gyuyoung Kim.
34
35         Script modified to enable MEDIA_STREAM for EFL build.
36
37         * Scripts/webkitperl/FeatureList.pm: 
38
39 2014-05-08  David Farler  <dfarler@apple.com>
40
41         old-run-webkit-tests: update strings for simulator devices and app name
42         https://bugs.webkit.org/show_bug.cgi?id=132687
43
44         Reviewed by Darin Adler.
45
46         iPhone Retina (4-inch) -> iPhone 5
47         iPhone Retina (4-inch 64-bit) -> iPhone 5s
48
49         * Scripts/old-run-webkit-tests:
50         (installAndLaunchDumpToolAppUsingNotification):
51         (openIPhoneSimulator):
52         (quitIPhoneSimulator):
53         quit iOS Simulator, not iPhone Simulator.
54
55 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
56
57         REGRESSION(r168471): Update the builder names on the scheduler list.
58         https://bugs.webkit.org/show_bug.cgi?id=132699
59
60         Reviewed by Martin Robinson.
61
62         On r168471 I missed to update the builder names for the GTK build
63         bots on the AnyBranchScheduler type scheduler list of bots.
64
65         * BuildSlaveSupport/build.webkit.org-config/config.json:
66
67 2014-05-08  Brady Eidson  <beidson@apple.com>
68
69         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
70         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
71
72         Reviewed by Tim Horton.
73
74         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
75         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
76
77 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
78
79         REGRESSION(r168471): Duplicate builddirs broke the build master.
80         https://bugs.webkit.org/show_bug.cgi?id=132688
81
82         Reviewed by Carlos Garcia Campos.
83
84         Rename the builddirs of the new GTK bots introduced on r168471 to
85         be unique. Otherwise the master will break.
86
87         * BuildSlaveSupport/build.webkit.org-config/config.json:
88
89 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
90
91         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
92         https://bugs.webkit.org/show_bug.cgi?id=132674
93
94         Reviewed by Philippe Normand.
95
96         Only ignore mkdir failure when exception is raised because the
97         file already exists and it's a directory.
98
99         * gtk/webkitdom.py:
100         (write_doc_files):
101
102 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
103
104         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
105         https://bugs.webkit.org/show_bug.cgi?id=131358
106
107         Reviewed by Carlos Garcia Campos.
108
109         Current 64-bit GTK build bots (Release and Debug) not only test
110         the build, but run all tests. Split each one of the bots in
111         BuildOnly and TestWebKit2.
112
113         This will allow us to have a better overview of the status of
114         the GTK port.
115
116         Original patch from Sergio Villar Senin <svillar@igalia.com>
117
118         * BuildSlaveSupport/build.webkit.org-config/config.json:
119         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
120         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
121         (WebKitBuildbot):
122         * Scripts/webkitpy/port/builders.py:
123         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
124         (TestRebaselineTest.test_baseline_directory):
125         * TestResultServer/static-dashboards/builders.jsonp:
126         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
127         (resetGlobals):
128         * TestResultServer/static-dashboards/loader_unittests.js:
129
130 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
131
132         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
133         https://bugs.webkit.org/show_bug.cgi?id=126022
134
135         Reviewed by Benjamin Poulain.
136
137         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
138
139         Added an unit test case to check if scroll position and scale are restored properly.
140
141         * TestWebKitAPI/PlatformEfl.cmake:
142         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
143         (TestWebKitAPI::didFinishLoadForFrame):
144         (TestWebKitAPI::didChangeContentsPosition):
145         (TestWebKitAPI::TEST):
146         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
147         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
148
149 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
150
151         WebKit1 is flashy when compositing layers come and go
152         https://bugs.webkit.org/show_bug.cgi?id=132655
153         <rdar://problem/16830981&16788846>
154
155         Reviewed by Sam Weinig.
156         
157         Revert the change from r166117.
158
159         * DumpRenderTree/mac/DumpRenderTree.mm:
160         (updateDisplay):
161
162 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
163
164         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
165         https://bugs.webkit.org/show_bug.cgi?id=132622
166
167         Reviewed by Mario Sanchez Prada.
168
169         * DumpRenderTree/AccessibilityUIElement.cpp:
170         (selectTextWithCriteriaCallback):
171         (isEqualCallback):
172         * DumpRenderTree/AccessibilityUIElement.h:
173         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
174         (AccessibilityUIElement::selectTextWithCriteria):
175         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
176         (AccessibilityUIElement::selectTextWithCriteria):
177         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
178         (selectTextParameterizedAttributeForCriteria):
179         (AccessibilityUIElement::selectTextWithCriteria):
180         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
181         (AccessibilityUIElement::selectTextWithCriteria):
182         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
183         (WTR::AccessibilityUIElement::selectTextWithCriteria):
184         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
185         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
186         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
187         (WTR::AccessibilityUIElement::selectTextWithCriteria):
188         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
189         (WTR::AccessibilityUIElement::selectTextWithCriteria):
190         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
191         (WTR::selectTextParameterizedAttributeForCriteria):
192         (WTR::AccessibilityUIElement::selectTextWithCriteria):
193
194 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
195
196         [SOUP] TLSErrors do not cause page load to fail when not ignored
197         https://bugs.webkit.org/show_bug.cgi?id=121548
198
199         Reviewed by Sergio Villar Senin.
200
201         Add unit tests to check that the load fails with TLS errors in
202         case of a redirection.
203
204         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
205         (testTLSErrorsRedirect):
206         (httpsServerCallback):
207         (beforeAll):
208
209 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
210
211         [CSS Grid Layout] Remove runtime feature
212         https://bugs.webkit.org/show_bug.cgi?id=132382
213
214         Reviewed by Benjamin Poulain.
215
216         Remove cssGridLayoutEnabled setting usage.
217
218         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
219         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
220         * DumpRenderTree/efl/TestRunnerEfl.cpp:
221         (TestRunner::overridePreference):
222         * DumpRenderTree/mac/DumpRenderTree.mm:
223         (resetWebPreferencesToConsistentValues):
224
225 2014-05-06  David Kilzer  <ddkilzer@apple.com>
226
227         Add Makefile targets for copying static libraries (LLVM and WKSI)
228         <http://webkit.org/b/132619>
229
230         Reviewed by Mark Rowe.
231
232         * Scripts/copy-webkitlibraries-to-product-directory: Set a
233         sensible default for product directory if not specified on
234         either the command-line or in the environment (by Xcode) by
235         calling productDir() in webkitdirs.pm.
236
237 2014-05-06  Brady Eidson  <beidson@apple.com>
238
239         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
240         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
241
242         Reviewed by Sam Weinig.
243
244         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
245
246         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
247         (TestWebKitAPI::itemURLLastComponentIsString):
248         (TestWebKitAPI::didFinishLoadForFrame):
249         (TestWebKitAPI::willGoToBackForwardListItem):
250         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
251         (TestWebKitAPI::setPageLoaderClient):
252         (TestWebKitAPI::TEST):
253         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
254         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
255
256         * WebKitTestRunner/TestController.cpp:
257         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
258
259 2014-05-06  Darin Adler  <darin@apple.com>
260
261         Try to fix iOS build.
262
263         * DumpRenderTree/mac/TestRunnerMac.mm:
264         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
265         Updated since I changed testRunner into a pointer instead of a reference.
266         Updated argument names to avoid conflict with field names.
267         (-[APITestDelegateIPhone run]): Ditto.
268         (-[APITestDelegateIPhone _cleanUp]): Ditto.
269
270 2014-05-06  Commit Queue  <commit-queue@webkit.org>
271
272         Unreviewed, rolling out r168304.
273         https://bugs.webkit.org/show_bug.cgi?id=132607
274
275         Broke the build (Requested by KaL on #webkit).
276
277         Reverted changeset:
278
279         "[GTK][CMake] Unable to do make install"
280         https://bugs.webkit.org/show_bug.cgi?id=130188
281         http://trac.webkit.org/changeset/168304
282
283 2014-05-04  Darin Adler  <darin@apple.com>
284
285         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
286         https://bugs.webkit.org/show_bug.cgi?id=80222
287
288         Reviewed by Alexey Proskuryakov.
289
290         * DumpRenderTree/mac/TestRunnerMac.mm:
291         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
292         do more work here so we don't use RetainPtr local variables.
293         (-[APITestDelegateIPhone dealloc]): Added.
294         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
295         created. Updated for changes to member names and types.
296         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
297         updated for changes to member names and types. Changed to two word spelling.
298         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
299         name of _cleanUp method.
300         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
301         Ditto.
302         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
303
304 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
305
306         Clean up Image Document and tweak the layout and viewport
307         https://bugs.webkit.org/show_bug.cgi?id=132552
308
309         Reviewed by Anders Carlsson.
310
311         * DumpRenderTree/mac/DumpRenderTree.mm:
312         (resetWebPreferencesToConsistentValues):
313         Update the default settings to have something consistent with WebKit2.
314
315 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
316
317         [GTK][CMake] Unable to do make install
318         https://bugs.webkit.org/show_bug.cgi?id=130188
319
320         Reviewed by Carlos Garcia Campos.
321
322         * Scripts/webkitdirs.pm:
323         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
324         will give an early signal that a change has broken the documentation.
325
326 2014-05-05  Pratik Solanki  <psolanki@apple.com>
327
328         Update framework locations in package-root
329         https://bugs.webkit.org/show_bug.cgi?id=132571
330
331         Reviewed by Simon Fraser.
332
333         * Scripts/package-root:
334
335 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
336
337         [EFL][WK2] Refactor favicon database APIs
338         https://bugs.webkit.org/show_bug.cgi?id=132519
339
340         Reviewed by Gyuyoung Kim.
341
342         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
343         (update_view_favicon):
344         (on_icon_changed_cb):
345         (window_free):
346         (on_url_changed):
347         (window_create):
348         (on_view_favicon_changed): Deleted.
349
350 2014-05-02  Mark Rowe  <mrowe@apple.com>
351
352         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
353
354         Reviewed by Dan Bernstein.
355
356         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
357         when determining which LLVM archive to extract.
358
359 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
360
361         Add Jeremy as a committer.
362         https://bugs.webkit.org/show_bug.cgi?id=132492
363
364         Reviewed by Jer Noble.
365
366         Add myself as a committer.
367
368         * Scripts/webkitpy/common/config/contributors.json:
369
370 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
371
372         Add Jeremy as a committer.
373         https://bugs.webkit.org/show_bug.cgi?id=132492
374
375         Reviewed by Jer Noble.
376
377         Add Jeremy Jones to the committers file.
378
379         * Scripts/webkitpy/common/config/contributors.json:
380
381 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
382
383         Hard to figure out how to run a single test with run-api-tests
384         https://bugs.webkit.org/show_bug.cgi?id=116332
385
386         Reviewed by Alexey Proskuryakov.
387
388         * Scripts/run-api-tests: add two examples to the help message.
389
390 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
391
392         Fix several memory leaks found by code inspection
393         https://bugs.webkit.org/show_bug.cgi?id=132472
394
395         Reviewed by Geoffrey Garen.
396         
397         Fix memory leaks.
398
399         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
400         (TestWebKitAPI::TEST):
401         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
402         (WTR::InjectedBundlePage::willSendRequestForFrame):
403         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
404         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
405
406 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
407
408         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
409         https://bugs.webkit.org/show_bug.cgi?id=132446
410
411         Reviewed by Mark Hahnenberg.
412         
413         Test the FTL by default now that it's enabled by default.
414
415         * Scripts/run-javascriptcore-tests:
416
417 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
418
419         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
420         https://bugs.webkit.org/show_bug.cgi?id=132240
421
422         Reviewed by Anders Carlsson.
423
424         Removed ewk_view_setting_tiled_backingstore related code.
425
426         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
427         (DumpRenderTreeChrome::createView):
428         (shouldUseTiledBackingStore): Deleted.
429         * EWebLauncher/main.c:
430         (windowCreate):
431         (parseUserArguments):
432
433 2014-05-01  Anders Carlsson  <andersca@apple.com>
434
435         window.testRunner.keepWebHistory() should update the UI process state
436         https://bugs.webkit.org/show_bug.cgi?id=132440
437
438         Reviewed by Dan Bernstein.
439
440         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
441         (WTR::InjectedBundle::postSetAddsVisitedLinks):
442         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
443         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
444         (WTR::TestRunner::keepWebHistory):
445         * WebKitTestRunner/TestInvocation.cpp:
446         (WTR::TestInvocation::invoke):
447         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
448
449 2014-05-01  David Kilzer  <ddkilzer@apple.com>
450
451         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
452         <http://webkit.org/b/132432>
453
454         Reviewed by Tim Horton.
455
456         * Scripts/webkitperl/FeatureList.pm: Remove support for
457         --plugin-proxy-for-video switch.
458
459 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
460
461         Kernel sysctl interface hw.activecpu don't exists on Linux.
462         https://bugs.webkit.org/show_bug.cgi?id=132286
463
464         Reviewed by Filip Pizlo.
465
466         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
467         calling sysctl over hw.activecpu
468
469 2014-04-30  Anders Carlsson  <andersca@apple.com>
470
471         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
472         https://bugs.webkit.org/show_bug.cgi?id=132399
473         <rdar://problem/15920046>
474
475         Reviewed by Dan Bernstein.
476
477         * Scripts/check-for-webkit-framework-include-consistency:
478         Allos WAK headers in WebKitLegacy as well as WebKit.
479
480         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
481         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
482         Update header imports.
483
484 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
485
486         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
487         https://bugs.webkit.org/show_bug.cgi?id=131954
488
489         Reviewed by Darin Adler.
490         
491         WebKitTestRunner was adding application-specific information to crash reports
492         to log the test path, but only in the web process. Fix it to also do this
493         for the UI process, for both iOS and OS X.
494         
495         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
496         both iOS and OS X.
497         
498         Factored crash reprorter-related code into CrashReporterInfo, and call it from
499         a new TestController::platformWillRunTest() function on Mac and iOS.
500         
501         Also remove Xcode-added unit test junk from the project.
502
503         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
504         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
505         * WebKitTestRunner/TestController.cpp:
506         (WTR::TestController::runTest):
507         * WebKitTestRunner/TestController.h:
508         * WebKitTestRunner/TestInvocation.cpp:
509         (WTR::TestInvocation::url):
510         * WebKitTestRunner/TestInvocation.h:
511         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
512         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
513         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
514         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
515         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
516         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
517         (WTR::testPathFromURL):
518         (WTR::setCrashReportApplicationSpecificInformationToURL):
519         * WebKitTestRunner/efl/TestControllerEfl.cpp:
520         (WTR::TestController::platformWillRunTest):
521         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
522         (WTR::TestController::platformWillRunTest):
523         * WebKitTestRunner/ios/TestControllerIOS.mm:
524         (WTR::TestController::platformWillRunTest):
525         (WTR::TestController::setHidden):
526         * WebKitTestRunner/mac/TestControllerMac.mm:
527         (WTR::TestController::platformWillRunTest):
528
529 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
530
531         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
532
533         Reviewed by Tim Horton.
534
535         * DumpRenderTree/mac/DumpRenderTree.mm:
536         (resetWebPreferencesToConsistentValues):
537         (prepareConsistentTestingEnvironment):
538
539 2014-04-30  Anders Carlsson  <andersca@apple.com>
540
541         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
542         https://bugs.webkit.org/show_bug.cgi?id=132397
543
544         Reviewed by Dan Bernstein.
545
546         * Scripts/check-for-inappropriate-macros-in-external-headers:
547
548 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
549
550         [GTK] Make it easier to run CMake for downstreams
551         https://bugs.webkit.org/show_bug.cgi?id=132370
552
553         Reviewed by Carlos Garcia Campos.
554
555         * Scripts/webkitdirs.pm:
556         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
557         the GTK+ port.
558
559 2014-04-29  Stephanie Lewis  <slewis@apple.com>
560
561         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
562         
563         Rubber stamped by Jessie Berlin.
564
565         JSON.pm was removed from our tools setup.
566
567         * Scripts/generate-coverage-data:
568
569 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
570
571         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
572         https://bugs.webkit.org/show_bug.cgi?id=112840
573
574         Rubber stamped by Geoffrey Garen.
575
576         * Scripts/build-jsc: Enable it on Mac.
577         * Scripts/build-webkit: Enable it on Mac.
578         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
579
580 2014-04-28  Sam Weinig  <sam@webkit.org>
581
582         REGRESSION (r167751): svn-create-patch is very slow
583         https://bugs.webkit.org/show_bug.cgi?id=132300
584
585         Reviewed by Alexey Proskuryakov.
586
587         * Scripts/svn-create-patch:
588         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
589         by calling `svn-create-patch --style`.
590
591 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
592
593         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
594         https://bugs.webkit.org/show_bug.cgi?id=132190
595
596         Reviewed by Gustavo Noronha Silva.
597
598         * Scripts/webkitdirs.pm:
599         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
600             if ninja is in the path.
601         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
602             to the previous ninja generator if not.
603
604 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
605
606         check-webkit-style should understand --git-index
607         https://bugs.webkit.org/show_bug.cgi?id=125364
608
609         Reviewed by Csaba Osztrogonác.
610
611         * Scripts/webkitpy/common/checkout/scm/git.py:
612         (Git.create_patch): The command now supports the --cached option.
613         * Scripts/webkitpy/style/main.py:
614         (CheckWebKitStyle.main): Passing the --git-index option.
615         * Scripts/webkitpy/style/optparser.py:
616         (CommandOptionValues.__init__): The git-index option is switched off by default.
617         (CommandOptionValues.__eq__): Equality check for the new option.
618         (ArgumentParser._create_option_parser):Adding the --git-index option
619         (ArgumentParser.parse):
620         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
621         (CommandOptionValuesTest.test_init): 
622         (CommandOptionValuesTest.test_eq):
623
624 2014-04-28  Michael Saboff  <msaboff@apple.com>
625
626         Crash in platform/mac/accessibility/table-visible-rows.html
627         https://bugs.webkit.org/show_bug.cgi?id=132146
628
629         Reviewed by Filip Pizlo.
630
631         Instead of creating a local JSValueRef array on the stack and passing that to
632         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
633         values using the JSObjectSetPropertyAtIndex() API.
634
635         * DumpRenderTree/AccessibilityUIElement.cpp:
636         (elementsForRangeCallback):
637         (convertElementsToObjectArray):
638         * DumpRenderTree/mac/TestRunnerMac.mm:
639         (originsArrayToJS):
640         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
641         (WTR::EventSendingController::contextClick):
642         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
643         (WTR::stringArrayToJS):
644         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
645         (WTR::convertElementsToObjectArray):
646
647 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
648
649         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
650         "no-cjit" runs force the old-school threshold.
651
652         Rubber stamped by Mark Hahnenberg.
653
654         * Scripts/run-jsc-stress-tests:
655
656 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
657
658         [GTK] install-dependencies should also install ruby-json and ruby-highline
659         https://bugs.webkit.org/show_bug.cgi?id=132292
660
661         Reviewed by Philippe Normand.
662
663         * gtk/install-dependencies: Install ruby json and highline packages.
664
665 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
666
667         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
668         https://bugs.webkit.org/show_bug.cgi?id=132176
669
670         Reviewed by Gyuyoung Kim.
671
672         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
673         and turn off indexedDB feature until the sqlite implementation is introduced.
674
675         * Scripts/webkitperl/FeatureList.pm:
676
677 2014-04-25  James Craig  <jcraig@apple.com>
678
679         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
680         https://bugs.webkit.org/show_bug.cgi?id=132209
681
682         Reviewed by Daniel Bates.
683
684         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
685         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
686
687         * Scripts/prepare-ChangeLog:
688         (main): 
689
690 2014-04-25  Michael Saboff  <msaboff@apple.com>
691
692         Crash in platform/mac/accessibility/table-visible-rows.html
693         https://bugs.webkit.org/show_bug.cgi?id=132146
694
695         Reviewed by Mark Lam.
696
697         Changed to use a local JSValueRef array temporary instead of a
698         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
699         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
700         the temporary values could be collected.
701
702         * DumpRenderTree/AccessibilityUIElement.cpp:
703         (convertElementsToObjectArray):
704         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
705         (WTR::EventSendingController::contextClick):
706         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
707         (WTR::convertElementsToObjectArray):
708
709 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
710
711         Unreviewed GTK gardening
712
713         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
714         (TestRunner):
715
716 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
717
718         prepare-ChangeLog reports as deleted methods that has not been removed.
719         https://bugs.webkit.org/show_bug.cgi?id=131733
720
721         Reviewed by Ryosuke Niwa.
722
723         * Scripts/prepare-ChangeLog:
724         (originalFile): Set merge base to origin/master by default.
725
726 2014-04-23  James Craig  <jcraig@apple.com>
727
728         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
729         https://bugs.webkit.org/show_bug.cgi?id=131115
730
731         Reviewed by Daniel Bates.
732
733         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
734
735         * Scripts/commit-log-editor: Added --no-style.
736         * Scripts/prepare-ChangeLog: Primary patch.
737         (main): Primary patch.
738         (createPatchCommand): Added --no-style.
739         * Scripts/svn-create-patch: Primary patch.
740         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
741         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
742         (SVN.create_patch): Added --no-style.
743
744 2014-04-23  Anders Carlsson  <andersca@apple.com>
745
746         Try to fix iOS build.
747
748         * DumpRenderTree/mac/DumpRenderTree.mm:
749
750 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
751
752         Eliminate internals.setMockScrollbarsEnabled()
753         https://bugs.webkit.org/show_bug.cgi?id=132085
754
755         Reviewed by Tim Horton.
756
757         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
758         No need to reset the preference, there is no way it can change.
759
760 2014-04-23  James Craig  <jcraig@apple.com>
761
762         Unreviewed. Moving myself from Contributors to Committers list.
763
764         * Scripts/webkitpy/common/config/contributors.json:
765
766 2014-04-23  Tim Horton  <timothy_horton@apple.com>
767
768         Mock scrollbars don't always work in DumpRenderTree
769         https://bugs.webkit.org/show_bug.cgi?id=132082
770
771         Reviewed by Alexey Proskuryakov.
772
773         * DumpRenderTree/mac/DumpRenderTree.mm:
774         (prepareConsistentTestingEnvironment):
775         Set the mock scrollbar setting before creating the WebView, as this setting
776         cannot be dynamically changed, so any scrollbars that are created during
777         WebView initialization and are not replaced before snapshotting will end
778         up being platform scrollbars instead of mock ones.
779         WebKitTestRunner already sets this preference before creating WKViews,
780         so we're just matching its behavior.
781
782 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
783
784         [GTK] ShadowRoot API was removed in r164131
785         https://bugs.webkit.org/show_bug.cgi?id=132059
786
787         Reviewed by Gustavo Noronha Silva.
788
789         Add WebKitDOMShadowRoot to the list of deleted classes to generate
790         the API docs.
791
792         * gtk/webkitdom.py:
793         (WebKitDOMDocGenerator):
794
795 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
796
797         [GTK] run-webkit-tests script is failing to invoke run-launcher
798         https://bugs.webkit.org/show_bug.cgi?id=132051
799
800         Reviewed by Philippe Normand.
801
802         After the WK1 support was dropped, if run-webkit-tests is executed
803         without --no-show-results parameter, the launcher is being called
804         using a -2 parameter that is it causing the run-launcher to break.
805
806         * Scripts/webkitpy/port/gtk.py:
807         (GtkPort.show_results_html_file):
808
809 2014-04-22  Tim Horton  <timothy_horton@apple.com>
810
811         DumpRenderTree generates black snapshots on some platforms
812         https://bugs.webkit.org/show_bug.cgi?id=132029
813         <rdar://problem/16679363>
814
815         Reviewed by Simon Fraser.
816
817         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
818         (createBitmapContextFromWebView):
819         DRT checks with the WebView to determine whether it can use the window's
820         backing store directly or (because of compositing) needs to take a WindowServer
821         snapshot. However, on some platforms and in some situations, the window can
822         be layer backed without the WebView necessarily currently being composited.
823         We should check with the window in addition to the WebView before going
824         ahead and using its backing store.
825
826 2014-04-22  Tim Horton  <timothy_horton@apple.com>
827
828         DumpRenderTree generates white snapshots on some platforms
829         https://bugs.webkit.org/show_bug.cgi?id=132026
830         <rdar://problem/16679363>
831
832         Reviewed by Simon Fraser.
833
834         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
835         Link DRT against QuartzCore.
836
837         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
838         (createBitmapContextFromWebView):
839         Force CoreAnimation to synchronously update layers in a more explicit
840         way that doesn't depend on AppKit behavior. This is very similar to what
841         WebKitTestRunner does (indirectly) during its force repaint.
842
843 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
844
845         [Win] Support Python 2.7 in Cygwin
846         https://bugs.webkit.org/show_bug.cgi?id=132023
847
848         Reviewed by Michael Saboff.
849
850         * Scripts/webkitdirs.pm:
851         (checkInstalledTools): Remove check for Python 2.7, since
852         it now works properly.
853
854 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
855
856         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
857         https://bugs.webkit.org/show_bug.cgi?id=130867
858         <rdar://problem/16432456> 
859
860         Reviewed by Mark Hahnenberg.
861
862         * Scripts/build-webkit:
863         * Scripts/copy-webkitlibraries-to-product-directory:
864
865 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
866
867         [GTK] Fails to build documentation when output is redirected
868         https://bugs.webkit.org/show_bug.cgi?id=131178
869
870         Reviewed by Martin Robinson.
871
872         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
873         explicitly to avoid encoding issues when they are redirected.
874
875 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
876
877         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
878         https://bugs.webkit.org/show_bug.cgi?id=131911
879
880         Reviewed by Martin Robinson.
881
882         common.get_build_path returns release path even though Debug configuration
883         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
884
885         * gtk/ycm_extra_conf.py:
886         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
887         (FlagsForFile):
888
889 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
890
891         Unreviewed build fix.
892
893         * DumpRenderTree/mac/EventSendingController.mm:
894         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
895         Correct a typo that prevented tests from working properly.
896
897 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
898
899         [GTK] Should have the ability to output composited contents during layout testing
900         https://bugs.webkit.org/show_bug.cgi?id=131864
901
902         Reviewed by Philippe Normand.
903
904         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
905         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
906         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
907         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
908         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
909
910 2014-04-21  Sam Weinig  <sam@webkit.org>
911
912         Attempt to fix the tests.
913
914         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
915         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
916         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
917
918 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
919
920         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
921         being the same as a "quick run", which is meant for genuinely slow tests).
922
923         * Scripts/run-jsc-stress-tests:
924
925 2014-04-21  Darin Adler  <darin@apple.com>
926
927         Add HashSet::takeAny
928         https://bugs.webkit.org/show_bug.cgi?id=131928
929
930         Reviewed by Benjamin Poulain.
931
932         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
933
934 2014-04-20  Dan Bernstein  <mitz@apple.com>
935
936         Fixed a test timing out after r167572.
937
938         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
939         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
940         -webView:didFinishLoadingNavigation:.
941
942 2014-04-20  Commit Queue  <commit-queue@webkit.org>
943
944         Unreviewed, rolling out r167510.
945         https://bugs.webkit.org/show_bug.cgi?id=131915
946
947         broke GTK Debug bot (Requested by philn on #webkit).
948
949         Reverted changeset:
950
951         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
952         it when running layout tests"
953         https://bugs.webkit.org/show_bug.cgi?id=131472
954         http://trac.webkit.org/changeset/167510
955
956 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
957
958         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
959         https://bugs.webkit.org/show_bug.cgi?id=131472
960
961         Reviewed by Philippe Normand.
962
963         * Scripts/webkitpy/port/gtk.py:
964         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
965         when running WebKitTestRunner with run-webkit-tests.
966         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
967         installed.
968         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
969         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
970         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
971         deal.
972
973 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
974
975         DownloadDecideDestinationCrash API test uses an incorrect value for path
976         https://bugs.webkit.org/show_bug.cgi?id=131845
977         <rdar://problem/15925560>
978
979         Reviewed by Enrica Casucci.
980
981         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
982         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
983
984 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
985
986         [Mac] AttributedStringTest API tests fail with async text input
987         https://bugs.webkit.org/show_bug.cgi?id=131833
988
989         Reviewed by Enrica Casucci.
990
991         Don't run sync NSTextInputClient tests where we don't implement these calls.
992
993         * TestWebKitAPI/Tests/mac/AttributedString.mm:
994         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
995         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
996         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
997         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
998         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
999         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
1000
1001 2014-04-18  Philippe Normand  <pnormand@igalia.com>
1002
1003         Remove NETWORK_INFO support
1004         https://bugs.webkit.org/show_bug.cgi?id=131841
1005
1006         Reviewed by Gyuyoung Kim.
1007
1008         * Scripts/webkitperl/FeatureList.pm:
1009
1010 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
1011
1012         [GTK] YouCompleteMe doesn't work for cmake build system.
1013         https://bugs.webkit.org/show_bug.cgi?id=131591
1014
1015         Reviewed by Martin Robinson.
1016
1017         Add cmake build system support for YouCompleteMe. It should work regardless of
1018         using make or ninja. In addition, autotools related code is removed since it's
1019         not used anymore in WebKit.
1020
1021         * Scripts/webkitdirs.pm:
1022         (generateBuildSystemFromCMakeProject):
1023         * gtk/ycm_extra_conf.py:
1024         (transform_relative_paths_to_absolute_paths):
1025         (FlagsForFile):
1026
1027 2014-04-17  Anders Carlsson  <andersca@apple.com>
1028
1029         Fix build.
1030
1031         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1032         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1033         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1034
1035 2014-04-17  Anders Carlsson  <andersca@apple.com>
1036
1037         Remove unused API enums
1038         https://bugs.webkit.org/show_bug.cgi?id=131836
1039
1040         Reviewed by Tim Horton.
1041
1042         * MiniBrowser/mac/WK2BrowserWindowController.m:
1043         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
1044
1045 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
1046
1047         [Win] A few final cleanups to the DataObject classes.
1048         https://bugs.webkit.org/show_bug.cgi?id=131784
1049
1050         Reviewed by Anders Carlsson.
1051
1052         * DumpRenderTree/win/DRTDataObject.cpp:
1053         (DRTDataObject::clearData): Use 'last()' method.
1054         * DumpRenderTree/win/UIDelegate.cpp:
1055         (DRTUndoStack::pop): Use 'takeLast()' method.
1056
1057 2014-04-17  Andres Gomez  <agomez@igalia.com>
1058
1059         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
1060         https://bugs.webkit.org/show_bug.cgi?id=131365
1061
1062         Reviewed by Brent Fulgham.
1063
1064         The cygwin installer is now downloading the wanted versions for
1065         the local installation given to the setup wizard.
1066
1067         * CygwinDownloader/cygwin-downloader.py:
1068         * CygwinDownloader/cygwin-downloader.zip:
1069
1070 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
1071
1072         [GTK] Make run-webkit-tests always use WKTR
1073         https://bugs.webkit.org/show_bug.cgi?id=131737
1074
1075         Reviewed by Darin Adler.
1076
1077         Now that the GTK+ port only has support for WebKit2, instruct
1078         run-webkit-tests to always use WKTR. This avoids needing to pass
1079         flag "-2" every time.
1080
1081         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
1082         (_set_up_derived_options): Always set webkit_test_runner when
1083         the platform is GTK+.
1084
1085 2014-04-17  Brendan Long  <b.long@cablelabs.com>
1086
1087         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
1088         https://bugs.webkit.org/show_bug.cgi?id=131760
1089
1090         Reviewed by Philippe Normand.
1091
1092         * gtk/install-dependencies: Install ninja-build when it's available.
1093
1094 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
1095
1096         [Win] run-javascriptcore-tests fails to run.
1097         https://bugs.webkit.org/show_bug.cgi?id=131761
1098
1099         Reviewed by Brent Fulgham.
1100
1101         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
1102
1103 2014-04-16  Andres Gomez  <agomez@igalia.com>
1104
1105         [Win] Pass default parameters to cygwin setup wizard
1106         https://bugs.webkit.org/show_bug.cgi?id=131361
1107
1108         Reviewed by Brent Fulgham.
1109
1110         Added some parameters to the cygwin setup wizard so the user
1111         doesn't really have to do any interaction.
1112
1113         * CygwinDownloader/cygwin-downloader.py:
1114         * CygwinDownloader/cygwin-downloader.zip:
1115
1116 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
1117
1118         [Win] Eliminate use of deleteAllValues in Windows Files
1119         https://bugs.webkit.org/show_bug.cgi?id=131631
1120
1121         Reviewed by Darin Adler.
1122
1123         Switch to std::unique_ptr for memory lifetime. Get rid of
1124         deleteAllValues now that it is no longer needed. Use ranged
1125         for loops where possible.
1126
1127         * DumpRenderTree/win/DRTDataObject.cpp:
1128         (WCEnumFormatEtc::WCEnumFormatEtc):
1129         (DRTDataObject::~DRTDataObject):
1130         (DRTDataObject::GetData):
1131         (DRTDataObject::QueryGetData):
1132         (DRTDataObject::SetData):
1133         (DRTDataObject::clearData):
1134         * DumpRenderTree/win/DRTDataObject.h:
1135         * DumpRenderTree/win/UIDelegate.cpp:
1136         (DRTUndoObject::DRTUndoObject):
1137         (DRTUndoObject::~DRTUndoObject):
1138         (DRTUndoStack::~DRTUndoStack):
1139         (DRTUndoStack::clear):
1140         (DRTUndoStack::pop):
1141         (DRTUndoManager::DRTUndoManager):
1142         (DRTUndoManager::redo):
1143         (DRTUndoManager::undo):
1144         (UIDelegate::UIDelegate):
1145         (UIDelegate::resetUndoManager):
1146         * DumpRenderTree/win/UIDelegate.h:
1147
1148 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1149
1150         [GTK] Unreviewed GTK gardening.
1151
1152         Update list of skipped unit tests:
1153
1154           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
1155
1156           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
1157           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
1158
1159         * Scripts/run-gtk-tests:
1160         (TestRunner):
1161
1162 2014-04-16  Tim Horton  <timothy_horton@apple.com>
1163
1164         check-webkit-style doesn't check code style in .mm or .m files
1165         https://bugs.webkit.org/show_bug.cgi?id=131708
1166
1167         Reviewed by Darin Adler.
1168
1169         * Scripts/webkitpy/style/checker.py:
1170         * Scripts/webkitpy/style/checker_unittest.py:
1171         (CheckerDispatcherDispatchTest.test_cpp_paths):
1172         (CheckerDispatcherDispatchTest.test_text_paths):
1173         Check .mm and .m files as C++.
1174
1175         * Scripts/webkitpy/style/checkers/cpp.py:
1176         (check_spacing):
1177         Add an override for our ordinary "missing spaces around =" for @synthesize,
1178         which should look like "@synthesize propertyName=_varName;"
1179
1180         Add an override for "missing space before {" for blocks' "^{".
1181
1182         Don't follow the "extra space before [" rule for Objective-C, because
1183         it breaks this rule in a multitude of ways because of method calls.
1184
1185         (check_braces):
1186         Don't complain about { not being on the end of the previous line if
1187         the previous line starts with "- (" or "+ (", which would indicate a
1188         Objective-C method definition.
1189
1190 2014-04-16  Darin Adler  <darin@apple.com>
1191
1192         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
1193         https://bugs.webkit.org/show_bug.cgi?id=131735
1194
1195         Reviewed by Alexey Proskuryakov.
1196
1197         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
1198         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
1199         is on the right. This can be confusing since our JavaScript test framework does it the opposite
1200         way, but gtest works better this way.
1201
1202 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
1203
1204         [EFL] Fix problems with the pixel dump.
1205         https://bugs.webkit.org/show_bug.cgi?id=131265
1206
1207         Reviewed by Gyuyoung Kim.
1208
1209         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
1210         However pixel dump codes still call deprecated functions like ewk_view_paint(),
1211         which causes that nothing is drawn.
1212
1213         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
1214         One of new functions is AcceleratedCompositingContext::extractImageData(),
1215         which replaces deprecated function calls. Besides the extractImageData() is invoked by
1216         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
1217
1218         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1219         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
1220
1221 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
1222
1223         Update LLVM export scrpt to handle the build directory being different from the
1224         source directory.
1225
1226         Rubber stamped by Geoffrey Garen.
1227
1228         * Scripts/export-llvm-build:
1229
1230 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
1231
1232         Update the hyperlink to waterfall views of perf bots on build.webkit.org
1233         https://bugs.webkit.org/show_bug.cgi?id=131695
1234
1235         Reviewed by Antti Koivisto.
1236
1237         Updated.
1238
1239         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1240
1241 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1242
1243         [GTK] Reduce the binary size by compressing the text based web inspector resources
1244         https://bugs.webkit.org/show_bug.cgi?id=121545
1245
1246         Reviewed by Gustavo Noronha Silva.
1247
1248         Compress text based files when compiling inspector resources. It
1249         reduces the binary size in 3MB.
1250
1251         * gtk/generate-inspector-gresource-manifest.py:
1252         (find_all_files_in_directory):
1253         (is_compressible):
1254
1255 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1256
1257         Remove Gtk WebKit1 tester.
1258
1259         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
1260         results over and over as fast as it could.
1261
1262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1263         (WebKitBuildbot):
1264
1265 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1266
1267         Wrong link for webkitpy tests results in dashboard popover
1268         https://bugs.webkit.org/show_bug.cgi?id=131664
1269
1270         Reviewed by Timothy Hatcher.
1271
1272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1273         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
1274         Use a correct link.
1275
1276 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1277
1278         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
1279
1280         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
1281
1282         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1283         (CommitMessageForThisCommitTest):
1284
1285 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1286
1287         Fix commit-log-editor bug revealed by r165447
1288         https://bugs.webkit.org/show_bug.cgi?id=130676
1289
1290         Reviewed by Csaba Osztrogonác.
1291
1292         * Scripts/commit-log-editor:
1293         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
1294         Add \n before the first block too, because the longest common prefix now ends with only one newline.
1295         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
1296         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
1297
1298 2014-04-13  Darin Adler  <darin@apple.com>
1299
1300         userVisibleString should not try to "encode" host names
1301         https://bugs.webkit.org/show_bug.cgi?id=131587
1302         rdar://problem/14686849
1303
1304         Reviewed by Alexey Proskuryakov.
1305
1306         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
1307
1308         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
1309         Coverage is tiny at this point; we could add a lot more cases!
1310
1311 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1312
1313         Use #include instead of #import
1314         https://bugs.webkit.org/show_bug.cgi?id=131604
1315
1316         Reviewed by Darin Adler.
1317
1318         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
1319
1320         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1321
1322 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
1323
1324         Make slow-stress tests run faster by running fewer VM variants.
1325
1326         Rubber stamped by Geoffrey Garen.
1327
1328         * Scripts/run-javascriptcore-tests:
1329         * Scripts/run-jsc-stress-tests:
1330
1331 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
1332
1333         [CMake] Add missing WTF unit tests
1334         https://bugs.webkit.org/show_bug.cgi?id=131459
1335
1336         Reviewed by Martin Robinson.
1337
1338         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1339         that should be compiled into the TestWTF binary.
1340
1341 2014-04-10  Brendan Long  <b.long@cablelabs.com>
1342
1343         [Gtk] run-launcher doesn't work by default
1344         https://bugs.webkit.org/show_bug.cgi?id=131494
1345
1346         Reviewed by Philippe Normand.
1347
1348         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1349         * Scripts/webkitdirs.pm:
1350         (launcherName): Same.
1351         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1352         * gtk/common.py:
1353         (get_build_path.is_valid_build_directory): Same.
1354         * gtk/manifest.txt: Same.
1355
1356 2014-04-09  Commit Queue  <commit-queue@webkit.org>
1357
1358         Unreviewed, rolling out r167046.
1359         https://bugs.webkit.org/show_bug.cgi?id=131479
1360
1361         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1362         on #webkit).
1363
1364         Reverted changeset:
1365
1366         "Remove "System Font" from whitelisted DRT fonts and char
1367         width calculations"
1368         https://bugs.webkit.org/show_bug.cgi?id=131411
1369         http://trac.webkit.org/changeset/167046
1370
1371 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1372
1373         Remove "System Font" from whitelisted DRT fonts and char width calculations
1374         https://bugs.webkit.org/show_bug.cgi?id=131411
1375
1376         Reviewed by Tim Horton.
1377
1378         Covered by existing tests.
1379
1380         * DumpRenderTree/mac/DumpRenderTree.mm:
1381         (allowedFontFamilySet):
1382
1383 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1384
1385         systemHiddenFontFamilySet in DRT is unnecessary
1386         https://bugs.webkit.org/show_bug.cgi?id=131414
1387
1388         Reviewed by Tim Horton.
1389
1390         It doesn't seem to affect test results on my machine.
1391
1392         * DumpRenderTree/mac/DumpRenderTree.mm:
1393         (drt_NSFontManager_availableFonts):
1394         (systemHiddenFontFamilySet): Deleted.
1395
1396 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1397
1398         [Win] Unreviewed test fix: Don't double-release BSTR.
1399
1400         * DumpRenderTree/win/DumpRenderTree.cpp:
1401         (dump): Remove unneeded call to SysFreeString now that we are
1402         using _bstr_t for this variable.
1403
1404 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1405
1406         [Win] Various DumpRenderTree Fixes.
1407         https://bugs.webkit.org/show_bug.cgi?id=131446.
1408
1409         Reviewed by Tim Horton.
1410
1411         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1412         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1413         (AccessibilityUIElement::description): Ditto.
1414         (AccessibilityUIElement::helpText): Ditto.
1415         (AccessibilityUIElement::intValue): Ditto.
1416         (AccessibilityUIElement::isPressActionSupported): Ditto.
1417         (AccessibilityUIElement::accessibilityValue): Ditto.
1418         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1419         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1420         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1421         (DRTDesktopNotificationPresenter::Release): Ditto.
1422         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1423         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1424         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1425         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1426         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1427         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1428         * DumpRenderTree/win/DumpRenderTree.cpp:
1429         (dumpFrameScrollPosition): Ditto.
1430         (dumpFramesAsText): Ditto.
1431         (compareHistoryItems): Ditto.
1432         (dumpHistoryItem): Ditto.
1433         (dump): Ditto.
1434         (resetDefaultsToConsistentValues): Ditto.
1435         (resetWebViewToConsistentStateBeforeTesting): Ditto.
1436         (runTest): Ditto.
1437         (createWebViewAndOffscreenWindow): Ditto.
1438         * DumpRenderTree/win/EditingDelegate.cpp:
1439         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1440         (EditingDelegate::AddRef): Ditto.
1441         (EditingDelegate::Release): Ditto.
1442         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
1443         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
1444         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1445         (EditingDelegate::shouldInsertNode): Ditto.
1446         (EditingDelegate::shouldInsertText): Ditto.
1447         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1448         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1449         (EditingDelegate::shouldApplyStyle): Ditto.
1450         (EditingDelegate::shouldChangeTypingStyle): Ditto.
1451         (EditingDelegate::doPlatformCommand): Ditto.
1452         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1453         (EditingDelegate::webViewDidChange): Ditto.
1454         (EditingDelegate::webViewDidEndEditing): Ditto.
1455         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
1456         (EditingDelegate::webViewDidChangeSelection): Ditto.
1457         (EditingDelegate::checkSpellingOfString): Ditto.
1458         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1459         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1460         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
1461         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1462         (FrameLoadDelegate::AddRef): Ditto.
1463         (FrameLoadDelegate::Release): Ditto.
1464         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1465         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
1466         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
1467         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
1468         (FrameLoadDelegate::didReceiveTitle): Ditto.
1469         (FrameLoadDelegate::didChangeIcons): Ditto.
1470         (delegatesWithDelayedWork): Ditto.
1471         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
1472         (FrameLoadDelegate::didFailLoadWithError): Ditto.
1473         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
1474         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
1475         (FrameLoadDelegate::willCloseFrame): Ditto.
1476         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
1477         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
1478         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1479         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
1480         (FrameLoadDelegate::didRunInsecureContent): Ditto.
1481         * DumpRenderTree/win/FrameLoadDelegate.h:
1482         * DumpRenderTree/win/HistoryDelegate.cpp:
1483         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1484         (HistoryDelegate::updateHistoryTitle): Ditto.
1485         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
1486         * DumpRenderTree/win/PolicyDelegate.cpp:
1487         (dumpPath):
1488         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1489         (PolicyDelegate::AddRef): Ditto.
1490         (PolicyDelegate::Release): Ditto.
1491         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1492         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
1493         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1494         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1495         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1496         (ResourceLoadDelegate::AddRef): Ditto.
1497         (ResourceLoadDelegate::Release): Ditto.
1498         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1499         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
1500         (ResourceLoadDelegate::willSendRequest): Ditto.
1501         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
1502         (ResourceLoadDelegate::didReceiveResponse): Ditto.
1503         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
1504         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
1505         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1506         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1507         (TestRunner::setUserStyleSheetLocation): Ditto.
1508         (TestRunner::execCommand): Ditto.
1509         (TestRunner::overridePreference): Ditto.
1510         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
1511         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
1512         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1513         (TextInputController::insertText): Ditto.
1514         * DumpRenderTree/win/UIDelegate.cpp:
1515         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1516         (UIDelegate::AddRef): Ditto.
1517         (UIDelegate::Release): Ditto.
1518         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1519         (UIDelegate::trackCustomPopupMenu): Ditto.
1520         (UIDelegate::registerUndoWithTarget): Ditto.
1521         (UIDelegate::removeAllActionsWithTarget): Ditto.
1522         (UIDelegate::setActionTitle): Ditto.
1523         (UIDelegate::undo): Ditto.
1524         (UIDelegate::redo): Ditto.
1525         (UIDelegate::canUndo): Ditto.
1526         (UIDelegate::canRedo): Ditto.
1527         (UIDelegate::printFrame): Ditto.
1528         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
1529         (UIDelegate::webViewHeaderHeight): Ditto.
1530         (UIDelegate::webViewFooterHeight): Ditto.
1531         (UIDelegate::drawHeaderInRect): Ditto.
1532         (UIDelegate::drawFooterInRect): Ditto.
1533         (UIDelegate::webViewPrintingMarginRect): Ditto.
1534         (UIDelegate::canRunModal): Ditto.
1535         (UIDelegate::createModalDialog): Ditto.
1536         (UIDelegate::runModal): Ditto.
1537         (UIDelegate::isMenuBarVisible): Ditto.
1538         (UIDelegate::setMenuBarVisible): Ditto.
1539         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
1540         (UIDelegate::paintCustomScrollbar): Ditto.
1541         (UIDelegate::paintCustomScrollCorner): Ditto.
1542         (UIDelegate::setFrame): Ditto.
1543         (UIDelegate::webViewFrame): Ditto.
1544         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
1545         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1546         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1547         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1548         (UIDelegate::webViewAddMessageToConsole): Ditto.
1549         (UIDelegate::doDragDrop): Ditto.
1550         (UIDelegate::webViewGetDlgCode): Ditto.
1551         (UIDelegate::createWebViewWithRequest): Ditto.
1552         (UIDelegate::webViewClose): Ditto.
1553         (UIDelegate::webViewFocus): Ditto.
1554         (UIDelegate::webViewUnfocus): Ditto.
1555         (UIDelegate::webViewPainted): Ditto.
1556         (UIDelegate::exceededDatabaseQuota): Ditto.
1557         (UIDelegate::embeddedViewWithArguments): Ditto.
1558         (UIDelegate::webViewClosing): Ditto.
1559         (UIDelegate::webViewSetCursor): Ditto.
1560         (UIDelegate::webViewDidInvalidate): Ditto.
1561         (UIDelegate::setStatusText): Ditto.
1562         (UIDelegate::desktopNotificationsDelegate): Ditto.
1563         (UIDelegate::drawBackground): Ditto.
1564         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
1565         (UIDelegate::didPressMissingPluginButton): Ditto.
1566         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
1567         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
1568         (LoadHTMLStringItem::invoke): Ditto.
1569         (ScriptItem::invoke): Ditto.
1570
1571 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1572
1573         Stylechecker: False positive on inline asm code.
1574         https://bugs.webkit.org/show_bug.cgi?id=130570
1575
1576         Reviewed by Csaba Osztrogonác.
1577
1578         Disable stylechecking in asm blocks.
1579
1580         * Scripts/webkitpy/style/checkers/cpp.py:
1581         (process_line):
1582         (_InlineASMState):
1583         (_InlineASMState.__init__):
1584         (_InlineASMState.process_line):
1585         (_InlineASMState.isInside):
1586         (_process_lines):
1587         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1588         (WebKitStyleTest.test_member_initialization_list):
1589
1590 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1591
1592         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
1593         https://bugs.webkit.org/show_bug.cgi?id=131029
1594
1595         Reviewed by Philippe Normand.
1596
1597         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
1598         tests and remove the getWebKit1TestResoucesDir() method.
1599
1600         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1601         (testDownloadLocalFile): Use Test::getResourcesDir().
1602         (testDownloadLocalFileError): Ditto.
1603         (serverCallback): Ditto.
1604         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1605         (serverCallback): Ditto.
1606         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1607         (httpServerCallback): Ditto.
1608         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1609         (serverCallback): Ditto.
1610         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
1611         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
1612         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1613         (Test::getWebKit1TestResoucesDir): Deleted.
1614
1615 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1616
1617         [WK2] HTTP authentication regression tests fail
1618         https://bugs.webkit.org/show_bug.cgi?id=81627
1619         <rdar://problem/11079296>
1620
1621         Reviewed by Anders Carlsson.
1622
1623         * WebKitTestRunner/TestController.h:
1624         * WebKitTestRunner/TestController.cpp:
1625         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
1626         to pageLoaderClient structure.
1627         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
1628         for password based authentication (we do get server trust challenges on some tests,
1629         which WKTR can't handle).
1630         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
1631         calls won't be made, at least on CFNetwork based platforms.
1632         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
1633         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
1634         make sense to associate auth requests with individual resources - there can be
1635         multiple resources loading at once from the same protection space, so WebKit1 API
1636         that had a resource identifier was inherently racy.
1637
1638 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
1639
1640         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
1641         https://bugs.webkit.org/show_bug.cgi?id=131427
1642
1643         Reviewed by Gyuyoung Kim.
1644
1645         Since r166973, font path was changed.
1646
1647         * DumpRenderTree/PlatformEfl.cmake:
1648         * WebKitTestRunner/PlatformEfl.cmake:
1649
1650 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1651
1652         Fix the build-jsc build
1653         https://bugs.webkit.org/show_bug.cgi?id=131410
1654
1655         Reviewed by Michael Saboff.
1656
1657         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
1658         WTF depends on it.
1659
1660 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1661
1662         [GTK] Remove WebKit1 unit tests
1663         https://bugs.webkit.org/show_bug.cgi?id=131359
1664
1665         Reviewed by Anders Carlsson.
1666
1667         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
1668         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
1669         they were inadvertently left in http://trac.webkit.org/changeset/166504.
1670
1671         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
1672         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
1673         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
1674         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
1675         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
1676         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
1677         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
1678         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
1679         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
1680         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
1681         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
1682         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
1683         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
1684         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
1685         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
1686         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
1687         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
1688         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
1689         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
1690         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
1691         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
1692         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
1693         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
1694         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
1695         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
1696         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
1697         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
1698         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
1699         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
1700         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
1701         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
1702         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
1703         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
1704         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
1705         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
1706         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
1707         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
1708         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
1709
1710 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1711
1712         Unreviewed gardening (Take 2): Prevent users from attempting
1713         to build with known invalid cURL. 
1714
1715         * Scripts/webkitdirs.pm:
1716         (checkInstalledTools): Check for 7.34.0 (the broken version), not
1717         7.33.0 (the known good version).
1718
1719 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1720
1721         [GTK] Remove DumpRenderTree and GtkLauncher
1722         https://bugs.webkit.org/show_bug.cgi?id=131373
1723
1724         Reviewed by Andreas Kling.
1725
1726         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
1727         no longer necessary now that WebKit1 GTK+ will be removed.
1728
1729         * CMakeLists.txt:
1730         * DumpRenderTree/PlatformGTK.cmake: Removed.
1731         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
1732         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
1733         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
1734         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
1735         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
1736         * DumpRenderTree/gtk/EventSender.cpp: Removed.
1737         * DumpRenderTree/gtk/EventSender.h: Removed.
1738         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
1739         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
1740         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
1741         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
1742         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
1743         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
1744         * DumpRenderTree/gtk/TextInputController.h: Removed.
1745         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
1746         * GtkLauncher/CMakeLists.txt: Removed.
1747         * GtkLauncher/LauncherInspectorWindow.c: Removed.
1748         * GtkLauncher/LauncherInspectorWindow.h: Removed.
1749         * GtkLauncher/main.c: Removed.
1750         * GtkLauncher/simple.svg: Removed.
1751         * GtkLauncher/text.html: Removed.
1752         * WebKitTestRunner/PlatformGTK.cmake:
1753         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
1754         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
1755         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
1756
1757 2014-04-08  Mark Rowe  <mrowe@apple.com>
1758
1759         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
1760         <https://webkit.org/b/131388> / <rdar://problem/16291687>
1761
1762         Reviewed by Alexey Proskuryakov.
1763
1764         * Scripts/webkitdirs.pm:
1765         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
1766         (execMacWebKitAppForDebugging): Ditto.
1767
1768 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1769
1770         Build bmalloc on iOS too
1771         https://bugs.webkit.org/show_bug.cgi?id=131381
1772
1773         Reviewed by Andreas Kling.
1774
1775         * Scripts/build-webkit:
1776
1777 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1778
1779         Unreviewed gardening: Prevent users from attempting
1780         to build with known invalid cURL.
1781
1782         * Scripts/webkitdirs.pm:
1783         (checkInstalledTools): Block build attempts with bad
1784         Cygwin tool set.
1785
1786 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
1787
1788         Build bmalloc on Mac
1789         https://bugs.webkit.org/show_bug.cgi?id=131333
1790
1791         Reviewed by Mark Rowe.
1792
1793         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
1794         (Note: Just testing Mac is not good enough because in this
1795         script 'Mac' means 'Mac or iOS'.)
1796
1797 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
1798
1799         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
1800         https://bugs.webkit.org/show_bug.cgi?id=130951
1801
1802         Reviewed by Geoffrey Garen.
1803
1804         * Scripts/run-javascriptcore-tests:
1805
1806 2014-04-06  Darin Adler  <darin@apple.com>
1807
1808         Rework CSS calc logic, fixing some reference count mistakes in Length
1809         https://bugs.webkit.org/show_bug.cgi?id=131280
1810
1811         Reviewed by Andreas Kling.
1812
1813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
1814         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
1815
1816 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
1817
1818         Enable WEB_REPLAY for PLATFORM(MAC)
1819         https://bugs.webkit.org/show_bug.cgi?id=130700
1820
1821         Reviewed by Timothy Hatcher.
1822
1823         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
1824
1825 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1826
1827         [CMake] Include X11's include dirs in TestNetscapePlugin
1828         https://bugs.webkit.org/show_bug.cgi?id=131270
1829
1830         Reviewed by Martin Robinson.
1831
1832         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
1833         TestNetscapePlugin includes WebCore code that includes X headers.
1834
1835 2014-04-05  David Kilzer  <ddkilzer@apple.com>
1836
1837         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
1838         <http://webkit.org/b/130986>
1839
1840         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
1841         prefix to TileCache class names in exception list.
1842
1843 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1844
1845         [GTK] kill-old-processes should kill dbus-daemon processes
1846         https://bugs.webkit.org/show_bug.cgi?id=127352
1847
1848         Reviewed by Martin Robinson.
1849
1850         * BuildSlaveSupport/kill-old-processes:
1851         (main):
1852
1853 2014-04-04  Andres Gomez  <agomez@igalia.com>
1854
1855         [Win] Update obsolete packages in cygwin
1856         https://bugs.webkit.org/show_bug.cgi?id=126264
1857
1858         Reviewed by Brent Fulgham.
1859
1860         Removed "apache" and "minires" as the first has been replaced by
1861         "lighttpd" and the second is now integrated into
1862         "cygwin". Replaced the transitional and now obsolete "gcc" package
1863         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
1864         since the newer version available is "2.7.3" which breaks the
1865         build due to some funniness with environment variable handling.
1866
1867         * CygwinDownloader/cygwin-downloader.py:
1868         * CygwinDownloader/cygwin-downloader.zip:
1869
1870 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
1871
1872         check-webkit-style: Improve warnings on Objective-C @property syntax
1873         https://bugs.webkit.org/show_bug.cgi?id=131200
1874
1875         Reviewed by Dan Bernstein.
1876
1877         * Scripts/webkitpy/style/checkers/cpp.py:
1878         (check_spacing):
1879         (CppChecker):
1880         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1881         (CppStyleTest.test_spacing_in_objective_c_properties):
1882
1883 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1884
1885         Unreviewed. Moving my name to commiter section
1886
1887         * Scripts/webkitpy/common/config/contributors.json:
1888
1889 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1890
1891         Unreviewed. Add myself as a committer.
1892
1893         * Scripts/webkitpy/common/config/contributors.json:
1894
1895 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
1896
1897         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
1898         https://bugs.webkit.org/show_bug.cgi?id=130391
1899
1900         Reviewed by Gyuyoung Kim.
1901
1902         Change the implementation of the zoom functionality from ewk_view_scale_set
1903         to ewk_view_page_zoom_set.
1904
1905         * MiniBrowser/efl/main.c:
1906
1907 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1908
1909         [webkitpy] perf profiler does not understand --call-graph argument
1910         https://bugs.webkit.org/show_bug.cgi?id=131132
1911
1912         Reviewed by Ryosuke Niwa.
1913
1914         New versions of perf profiler have changed the argument from --call-graph to -g.
1915
1916         * Scripts/webkitpy/common/system/profiler.py:
1917         (Perf.wrapper_arguments): Use -g instead of --call-graph.
1918         * Scripts/webkitpy/port/driver_unittest.py:
1919         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
1920
1921 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1922
1923         Add EFL WK2 performance bot to build.webkit.org
1924         https://bugs.webkit.org/show_bug.cgi?id=131034
1925
1926         Fix after r166707, use "Perf" instead of "perf" for consistency.
1927
1928         Reviewed by Csaba Osztrogonác.
1929
1930         * BuildSlaveSupport/build.webkit.org-config/config.json:
1931
1932 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1933
1934         Add EFL WK2 performance bot to build.webkit.org
1935         https://bugs.webkit.org/show_bug.cgi?id=131034
1936
1937         Reviewed by Csaba Osztrogonác.
1938
1939         * BuildSlaveSupport/build.webkit.org-config/config.json:
1940
1941 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
1942
1943         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
1944         https://bugs.webkit.org/show_bug.cgi?id=131151
1945
1946         Reviewed by Gyuyoung Kim.
1947
1948         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
1949         (TouchEventInfo::TouchEventInfo):
1950         (sendTouchEvent):
1951         (addTouchPointCallback):
1952         (updateTouchPointCallback):
1953         (cancelTouchPointCallback):
1954         (releaseTouchPointCallback):
1955
1956 2014-04-02  David Kilzer  <ddkilzer@apple.com>
1957
1958         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
1959         <http://webkit.org/b/131045>
1960
1961         Reviewed by Daniel Bates.
1962
1963         * Scripts/filter-build-webkit:
1964         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
1965         of clang, plus debug data for all DVTAssertions.
1966
1967 2014-04-01  Dean Jackson  <dino@apple.com>
1968
1969         Load Media Controls js/css from bundle
1970         https://bugs.webkit.org/show_bug.cgi?id=131086
1971
1972         Reviewed by Eric Carlson.
1973
1974         We're now putting CSS files into the bundle, so remove the test for them.
1975
1976         * Scripts/check-for-inappropriate-files-in-framework:
1977
1978 2014-04-02  Martin Hock  <mhock@apple.com>
1979
1980         Unify private browsing with sessions.
1981         https://bugs.webkit.org/show_bug.cgi?id=130099
1982
1983         Reviewed by Alexey Proskuryakov.
1984
1985         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
1986         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1987         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1988         (TestWebKitAPI::didNavigateWithNavigationData):
1989         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1990         (TestWebKitAPI::TEST):
1991
1992         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
1993         (TestWebKitAPI::didNavigateWithoutNavigationData):
1994         (TestWebKitAPI::didNavigateWithNavigationData):
1995         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1996         (TestWebKitAPI::TEST):
1997
1998 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
1999
2000         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
2001         https://bugs.webkit.org/show_bug.cgi?id=130343
2002
2003         Reviewed by Gustavo Noronha Silva.
2004
2005         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
2006         of directories on the command line and look for all appropriate files in those directories for the
2007         GResource archive. Also make archive paths relative to those directories.
2008         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
2009         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
2010
2011 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2012
2013         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
2014         https://bugs.webkit.org/show_bug.cgi?id=131106
2015
2016         Reviewed by Csaba Osztrogonác.
2017
2018         * Scripts/webkitpy/tool/commands/download.py:
2019         (AbstractRolloutPrepCommand._prepare_state):
2020         * Scripts/webkitpy/tool/commands/download_unittest.py:
2021         (test_prepare_rollout):
2022         (test_create_rollout):
2023         (test_create_rollout_resolved):
2024         (test_rollout):
2025
2026 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
2027
2028         [EFL] Add option to use separate web process for new window in MiniBrowser
2029         https://bugs.webkit.org/show_bug.cgi?id=130190
2030
2031         Reviewed by Gyuyoung Kim.
2032
2033         New created window (CTRL + n) will be open in separated web process.
2034         This option is enabled by adding a flag (S/separate-process) with launching
2035         MiniBrowser.
2036
2037         * MiniBrowser/efl/main.c:
2038         (elm_main):
2039
2040 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2041
2042         [GTK] Move NEWS file to a new location
2043         https://bugs.webkit.org/show_bug.cgi?id=130901
2044
2045         Reviewed by Brent Fulgham.
2046
2047         * gtk/manifest.txt: Update the NEWS file path.
2048
2049 2014-04-01  Anders Carlsson  <andersca@apple.com>
2050
2051         Fix build.
2052
2053         * MiniBrowser/mac/WK2BrowserWindowController.m:
2054         (-[WK2BrowserWindowController awakeFromNib]):
2055         (-[WK2BrowserWindowController dealloc]):
2056         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2057
2058 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
2059
2060         Unreviewed test gardening.
2061
2062         * Scripts/webkitpy/port/base_unittest.py:
2063         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
2064
2065 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
2066
2067         [CSS Exclusions] Remove exclusions parsing support
2068         https://bugs.webkit.org/show_bug.cgi?id=131046
2069
2070         Reviewed by David Hyatt.
2071
2072         * Scripts/webkitperl/FeatureList.pm:
2073
2074 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2075
2076         [GTK] Remove last reference to GTK+ WK1 EWS
2077         https://bugs.webkit.org/show_bug.cgi?id=131058
2078
2079         Reviewed by Martin Robinson.
2080
2081         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
2082
2083         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
2084
2085 2014-04-01  Lucas Forschler  <lforschler@apple.com>
2086
2087         Add a 32bit JSC builder/tester.
2088         https://bugs.webkit.org/show_bug.cgi?id=131054
2089         
2090         Reviewed by Michael Saboff.
2091
2092         * BuildSlaveSupport/build.webkit.org-config/config.json:
2093         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2094         (Compile32bitJSC):
2095         (Run32bitJSCTests):
2096         (Run32bitJSCTests.countFailures):
2097         (BuildAndTest32bitJSCFactory):
2098         (BuildAndTest32bitJSCFactory.__init__):
2099
2100 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
2101
2102         [GTK] No longer build WebKit1 gtkdoc
2103         https://bugs.webkit.org/show_bug.cgi?id=130970
2104
2105         Reviewed by Anders Carlsson.
2106
2107         * gtk/common.py:
2108         (gtk_version_of_pkg_config_file): Deleted.
2109         * gtk/generate-gtkdoc:
2110         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
2111         was only applicable for WebKit1.
2112         (get_generator_for_config): No longer look for the WebKit1 configuration file.
2113
2114 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
2115
2116         [GTK] Running minibrowser with url crashes in debug build
2117         https://bugs.webkit.org/show_bug.cgi?id=130492
2118
2119         Reviewed by Martin Robinson.
2120
2121         Update "uri-scheme" test not to use invalid URIs in it, so we
2122         don't get a mistmatch when comparing the original URI stored in
2123         the test class with the one returned by the WebKitWebView.
2124
2125         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2126         (testWebContextURIScheme): Update the test.
2127
2128 2014-04-01  Mihai Tica  <mitica@adobe.com>
2129
2130         Unreviewed: Add myself as a commiter to the contributors list.
2131
2132         * Scripts/webkitpy/common/config/contributors.json:
2133
2134 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2135
2136         [EFL][WK2] Extract the control of page background out of color_set
2137         https://bugs.webkit.org/show_bug.cgi?id=127539
2138
2139         Reviewed by Gyuyoung Kim.
2140
2141         Added an option(C) to change background color.
2142
2143         * MiniBrowser/efl/main.c:
2144         (window_create):
2145         (elm_main):
2146
2147 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2148
2149         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
2150
2151         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
2152
2153 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2154
2155         Unreviewed test correction after r166530.
2156
2157         * DumpRenderTree/mac/DumpRenderTree.mm:
2158         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
2159         fine-grained setting for swipe tests. This prevents existing tests from breaking.
2160
2161 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2162
2163         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
2164         https://bugs.webkit.org/show_bug.cgi?id=130987
2165
2166         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
2167         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
2168
2169         Reviewed by Martin Robinson.
2170
2171         * BuildSlaveSupport/build.webkit.org-config/config.json:
2172
2173 2014-03-31  Dean Jackson  <dino@apple.com>
2174
2175         Remove WEB_ANIMATIONS
2176         https://bugs.webkit.org/show_bug.cgi?id=130989
2177
2178         Reviewed by Simon Fraser.
2179
2180         Remove this feature flag until we plan to implement.
2181
2182         * Scripts/webkitperl/FeatureList.pm:
2183
2184 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2185
2186         Reduced Latched Scroll Test Flakiness
2187         https://bugs.webkit.org/show_bug.cgi?id=130983
2188
2189         Reviewed by Darin Adler.
2190
2191         * DumpRenderTree/mac/DumpRenderTree.mm:
2192         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
2193         * DumpRenderTree/mac/EventSendingController.mm:
2194         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
2195         with high resolution flags turned on.
2196         * WebKitTestRunner/mac/EventSenderProxy.mm:
2197         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2198
2199 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2200
2201         run-webkit-tests should have a --no-timeout option
2202         https://bugs.webkit.org/show_bug.cgi?id=128286
2203
2204         Reviewed by Joseph Pecoraro.
2205
2206         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2207         (Worker._run_test): Renaming _run_test_with_timeout()
2208         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
2209         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
2210         (Worker._run_test_in_this_thread):
2211         (Worker._run_test_with_timeout): Deleted.
2212         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2213         (parse_args): Added the --no-timeout option
2214
2215 2014-03-31  Samuel White  <samuel_white@apple.com>
2216
2217         AX: Need ability to get line range for text marker.
2218         https://bugs.webkit.org/show_bug.cgi?id=130906
2219
2220         Reviewed by Chris Fleizach.
2221
2222         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
2223
2224         * DumpRenderTree/AccessibilityUIElement.cpp:
2225         (lineTextMarkerRangeForTextMarkerCallback):
2226         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2227         (AccessibilityUIElement::getJSClass):
2228         * DumpRenderTree/AccessibilityUIElement.h:
2229         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2230         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2231         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2232         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2233         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2234         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2235         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2236         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2237         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2238         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2239         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2240         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2241
2242 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
2243
2244         More validation for FTL inline caches
2245         https://bugs.webkit.org/show_bug.cgi?id=130948
2246
2247         Reviewed by Geoffrey Garen.
2248
2249         * Scripts/run-jsc-stress-tests:
2250
2251 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2252
2253         [GTK] Do not run WebKit1 unit tests by default
2254         https://bugs.webkit.org/show_bug.cgi?id=130968
2255
2256         Reviewed by Martin Robinson.
2257
2258         * Scripts/run-gtk-tests:
2259         (TestRunner):
2260
2261 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
2262
2263         [GTK] Remove scripts code only applicable to autotools
2264         https://bugs.webkit.org/show_bug.cgi?id=130841
2265
2266         Reviewed by Anders Carlsson.
2267
2268         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2269         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
2270         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
2271         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
2272         * gtk/find-make-dist-errors: Removed.
2273         * gtk/generate-feature-defines-files: Removed.
2274         * gtk/manifest.txt: No longer need to consider autotools files.
2275
2276 2014-03-30  Andy Estes  <aestes@apple.com>
2277
2278         Fix two failing layout tests on Mountain Lion after r166466.
2279
2280         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2281         (-[DownloadDelegate _downloadDidStart:]):
2282
2283 2014-03-30  Andy Estes  <aestes@apple.com>
2284
2285         [Cocoa] Add an originatingWebView property to _WKDownload
2286         https://bugs.webkit.org/show_bug.cgi?id=130945
2287
2288         Reviewed by Anders Carlsson.
2289
2290         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2291         (-[DownloadDelegate _downloadDidStart:]):
2292         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
2293         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2294         (TEST):
2295
2296 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
2297
2298         Land the stackmap register liveness glue with the uses of the liveness disabled
2299         https://bugs.webkit.org/show_bug.cgi?id=130924
2300
2301         Reviewed by Oliver Hunt.
2302
2303         * Scripts/run-jsc-stress-tests:
2304
2305 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
2306
2307         Update WebKit1.StringTruncator for Mountain Lion.
2308
2309         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
2310         due to different font metrics on 10.8.
2311
2312 2014-03-28  Darin Adler  <darin@apple.com>
2313
2314         Fix recently-introduced off-by-one error in centerTruncateToBuffer
2315         https://bugs.webkit.org/show_bug.cgi?id=130889
2316
2317         Reviewed by Alexey Proskuryakov.
2318
2319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
2320         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
2321         WebStringTruncator methods; should be good for a start. These are dependent on the
2322         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
2323
2324 2014-03-28  Martin Hock  <mhock@apple.com>
2325
2326         Unreviewed. Add myself as a committer.
2327
2328         * Scripts/webkitpy/common/config/contributors.json:
2329
2330 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
2331
2332         Remove WebKit1 GTK+ bots
2333         https://bugs.webkit.org/show_bug.cgi?id=130904
2334
2335         Reviewed by Anders Carlsson.
2336
2337         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2338         all bots are testing WebKit2 only.
2339         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2340         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2341         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2342         * Scripts/webkitpy/port/builders.py: Ditto.
2343         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2344         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2345
2346 2014-03-28  Timothy Hatcher  <timothy@apple.com>
2347
2348         Remove Brian Burg's apple.com email address.
2349
2350         * Scripts/webkitpy/common/config/contributors.json:
2351
2352 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2353
2354         bisect-builds should print Trac 'changeset' URL if only one build is detected
2355         <http://webkit.org/b/130903>
2356
2357         Reviewed by Dan Bernstein.
2358
2359         * Scripts/bisect-builds:
2360         (printTracLink): Print a direct link to the Trac 'changeset'
2361         URL if there is only one revision in the range.
2362
2363 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2364
2365         [EFL] Bump glib version from 2.36 to 2.38 
2366         https://bugs.webkit.org/show_bug.cgi?id=130886
2367
2368         Reviewed by Csaba Osztrogonác.
2369
2370         There is a build break on EFL port when using glib 2.36 ver. To fix it,
2371         we need to bump glib version up to 2.38 as gtk port.
2372
2373         * efl/jhbuild.modules:
2374
2375 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2376
2377         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2378
2379         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2380         the globalhistory directory.
2381
2382         Reviewed by Sam Weinig.
2383
2384         * WebKitTestRunner/TestController.cpp:
2385         (WTR::TestController::TestController):
2386         (WTR::TestController::initialize): Set the history client.
2387         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2388         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2389         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2390         and we don't yet have API to access the data in question.
2391         (WTR::TestController::didPerformClientRedirect):
2392         (WTR::TestController::didPerformServerRedirect):
2393         (WTR::TestController::didUpdateHistoryTitle):
2394         * WebKitTestRunner/TestController.h:
2395         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2396         * WebKitTestRunner/TestInvocation.cpp:
2397         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2398         (WTR::TestInvocation::invoke):
2399
2400 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2401
2402         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2403
2404         * Scripts/build-webkit:
2405         * Scripts/copy-webkitlibraries-to-product-directory:
2406
2407 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2408
2409         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2410         https://bugs.webkit.org/show_bug.cgi?id=130867
2411         <rdar://problem/16432456> 
2412
2413         Reviewed by Mark Hahnenberg.
2414
2415         * Scripts/build-webkit:
2416         * Scripts/copy-webkitlibraries-to-product-directory:
2417
2418 2014-03-26  Andy Estes  <aestes@apple.com>
2419
2420         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2421         https://bugs.webkit.org/show_bug.cgi?id=130805
2422
2423         Reviewed by Dan Bernstein.
2424
2425         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2426         (-[DownloadDelegate _download:didReceiveResponse:]):
2427         (-[DownloadDelegate _downloadDidFinish:]):
2428         (runTest):
2429         (TEST):
2430         (-[FailingDownloadDelegate _downloadDidFinish:]):
2431         (-[FailingDownloadDelegate _download:didFailWithError:]):
2432         (-[FailingDownloadDelegate _downloadDidCancel:]):
2433         (-[CancelledDownloadDelegate _downloadDidStart:]):
2434         (-[CancelledDownloadDelegate _downloadDidFinish:]):
2435         (-[CancelledDownloadDelegate _download:didFailWithError:]):
2436         (-[CancelledDownloadDelegate _downloadDidCancel:]):
2437         (-[DownloadDelegate initWithSourceURL:]): Deleted.
2438         (-[DownloadDelegate sourceURL]): Deleted.
2439         (runTestWithNavigationDelegate): Deleted.
2440
2441 2014-03-26  Anders Carlsson  <andersca@apple.com>
2442
2443         Change MiniBrowser to hold on to window controllers instead of windows
2444         https://bugs.webkit.org/show_bug.cgi?id=130797
2445
2446         Reviewed by Oliver Hunt.
2447
2448         * MiniBrowser/mac/AppDelegate.h:
2449         * MiniBrowser/mac/AppDelegate.m:
2450         (-[BrowserAppDelegate init]):
2451         (-[BrowserAppDelegate newWindow:]):
2452         (-[BrowserAppDelegate browserWindowWillClose:]):
2453         (-[BrowserAppDelegate applicationWillTerminate:]):
2454         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2455
2456 2014-03-26  Commit Queue  <commit-queue@webkit.org>
2457
2458         Unreviewed, rolling out r166264.
2459         https://bugs.webkit.org/show_bug.cgi?id=130785
2460
2461         Broke some window.opener tests for WK2 Mavericks (Requested by
2462         brrian__ on #webkit).
2463
2464         Reverted changeset:
2465
2466         "Web Replay: resource unique identifiers should be unique-per-
2467         frame, not globally"
2468         https://bugs.webkit.org/show_bug.cgi?id=130632
2469         http://trac.webkit.org/changeset/166264
2470
2471 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2472
2473         [CSS Shapes] Remove shape-inside support
2474         https://bugs.webkit.org/show_bug.cgi?id=130698
2475
2476         Reviewed by David Hyatt.
2477
2478         * Scripts/webkitperl/FeatureList.pm:
2479
2480 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
2481
2482         Unreviewed. Add myself as a committer.
2483
2484         * Scripts/webkitpy/common/config/contributors.json:
2485
2486 2014-03-26  Tomas Popela  <tpopela@redhat.com>
2487
2488         run-launcher is Perl script so use elsif and not elif
2489         https://bugs.webkit.org/show_bug.cgi?id=130771
2490
2491         Reviewed by Carlos Garcia Campos.
2492
2493         * Scripts/run-launcher:
2494
2495 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
2496
2497         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2498         https://bugs.webkit.org/show_bug.cgi?id=130575
2499
2500         Reviewed by Mario Sanchez Prada.
2501
2502         Change ATK version to 2.11.92. Adjust current implementation.
2503
2504         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2505         (AccessibilityUIElement::intValue):
2506         (AccessibilityUIElement::minValue):
2507         (AccessibilityUIElement::maxValue):
2508         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2509         (WTR::AccessibilityUIElement::intValue):
2510         (WTR::AccessibilityUIElement::minValue):
2511         (WTR::AccessibilityUIElement::maxValue):
2512         * efl/jhbuild.modules:
2513         * gtk/jhbuild.modules:
2514
2515 2014-03-12  Philippe Normand  <pnormand@igalia.com>
2516
2517         [GTK] The gnumake package is no longer needed in jhbuild
2518         https://bugs.webkit.org/show_bug.cgi?id=130121
2519
2520         Reviewed by Martin Robinson.
2521
2522         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
2523         for a debug build cmake/system-gnumake worked just fine for me.
2524
2525         * gtk/jhbuild.modules: Removed gnumake.
2526         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
2527         * gtk/patches/make-3.82-parallel-build.patch: Removed.
2528
2529 2014-03-25  Andy Estes  <aestes@apple.com>
2530
2531         Fix a failing API test on Mountain Lion and remove temporary debug logging.
2532
2533         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2534         (-[DownloadDelegate _download:didReceiveData:]):
2535         (-[DownloadDelegate _downloadDidFinish:]):
2536
2537 2014-03-25  Brian Burg  <bburg@apple.com>
2538
2539         Web Replay: resource unique identifiers should be unique-per-frame, not globally
2540         https://bugs.webkit.org/show_bug.cgi?id=130623
2541
2542         Reviewed by Timothy Hatcher.
2543
2544         The resource loader callback dumping routines assumed that resource identifiers
2545         were globally unique. Its map of resource identifiers to URLs must also track the
2546         frame associated with the resource.
2547
2548         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2549         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
2550         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
2551         stable as long as the frame is valid.
2552         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2553         (WTR::InjectedBundlePage::willSendRequestForFrame):
2554         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2555         (WTR::InjectedBundlePage::didFinishLoadForResource):
2556         (WTR::InjectedBundlePage::didFailLoadForResource):
2557
2558 2014-03-25  Andy Estes  <aestes@apple.com>
2559
2560         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
2561
2562         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2563         (-[DownloadDelegate _download:didReceiveResponse:]):
2564         (-[DownloadDelegate _download:didReceiveData:]):
2565
2566 2014-03-25  Andy Estes  <aestes@apple.com>
2567
2568         Add some debug logging to an API test that's failing on Mountain Lion.
2569
2570         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2571         (-[DownloadDelegate _download:didReceiveResponse:]):
2572         (-[DownloadDelegate _downloadDidFinish:]):
2573
2574 2014-03-25  Anders Carlsson  <andersca@apple.com>
2575
2576         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
2577         https://bugs.webkit.org/show_bug.cgi?id=130732
2578
2579         Reviewed by Tim Horton.
2580
2581         * MiniBrowser/mac/WK2BrowserWindowController.m:
2582         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2583
2584 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
2585
2586         [GTK] Remove the autotools build
2587         https://bugs.webkit.org/show_bug.cgi?id=130717
2588
2589         Reviewed by Anders Carlsson.
2590
2591         * DumpRenderTree/config.h: Remove references to the autotools configure file.
2592         * GNUmakefile.am: Removed.
2593         * GtkLauncher/GNUmakefile.am: Removed.
2594         * GtkLauncher/main.c: Remove references to the autotools configure file.
2595         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
2596         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
2597         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
2598         * MiniBrowser/gtk/GNUmakefile.am: Removed.
2599         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
2600         * Scripts/build-webkit: No longer handle autotools.
2601         * Scripts/run-gtk-tests: Ditto.
2602         (TestRunner._setup_testing_environment):
2603         * Scripts/run-launcher: Ditto.
2604         * Scripts/webkitdirs.pm: Ditto.
2605         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
2606         * Scripts/webkitpy/common/config/contributors.json: Ditto.
2607         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
2608         * Scripts/webkitpy/style/checker.py:
2609         * TestWebKitAPI/GNUmakefile.am: Removed.
2610         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
2611         * WebKitTestRunner/GNUmakefile.am: Removed.
2612         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
2613         * gtk/GNUmakefile.am: Removed.
2614         * gtk/common.py: Remove checks for the autotools build.
2615         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
2616
2617 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
2618
2619         prepare-ChangeLog throws false positive warnings for modified files.
2620         https://bugs.webkit.org/show_bug.cgi?id=130687
2621
2622         Reviewed by Darin Adler.
2623
2624         * Scripts/prepare-ChangeLog:
2625         (originalFile): Ignore git commit paremeter.
2626         We don't need this to get the unmodified file.
2627         (extractLineRangeBeforeChange):
2628         Simplify the if statement. Follow-up after r166189.
2629
2630 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
2631
2632         [EFL] Add ARM64 build support
2633         https://bugs.webkit.org/show_bug.cgi?id=130506
2634
2635         Rubber stamped by Gyuyoung Kim.
2636
2637         * Scripts/webkitdirs.pm:
2638         (isARM): Detect aarch64 as ARM.
2639
2640 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2641
2642         [webkitpy] Improve _parse_bug_description to recognize more descriptions
2643         https://bugs.webkit.org/show_bug.cgi?id=130137
2644
2645         Reviewed by Csaba Osztrogonác.
2646
2647         * Scripts/webkitpy/common/checkout/changelog.py:
2648         (ChangeLogEntry._parse_bug_description):
2649         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2650         (test_parse_log_entries_from_changelog):
2651         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2652         (CheckoutTest.test_commit_info_for_revision):
2653
2654 2014-03-24  Andy Estes  <aestes@apple.com>
2655
2656         Fix the iOS build of TestWebKitAPI.
2657
2658         * TestWebKitAPI/Configurations/Base.xcconfig:
2659         * TestWebKitAPI/PlatformUtilities.h:
2660
2661 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2662
2663         Fix prepare-ChangeLog after r166156.
2664         https://bugs.webkit.org/show_bug.cgi?id=130674
2665
2666         Reviewed by Darin Adler.
2667
2668         * Scripts/prepare-ChangeLog:
2669         (generateFunctionLists):
2670         (extractLineRangeBeforeChange):
2671
2672 2014-03-24  Andy Estes  <aestes@apple.com>
2673
2674         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2675         https://bugs.webkit.org/show_bug.cgi?id=129322
2676
2677         Reviewed by Anders Carlsson.
2678
2679         Add an API test suite for _WKDownload.
2680
2681         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2682         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
2683         (-[DownloadDelegate initWithSourceURL:]):
2684         (-[DownloadDelegate sourceURL]):
2685         (-[DownloadDelegate _downloadDidStart:]):
2686         (-[DownloadDelegate _download:didReceiveResponse:]):
2687         (-[DownloadDelegate _download:didReceiveData:]):
2688         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2689         (-[DownloadDelegate _downloadDidFinish:]):
2690         (TEST):
2691         (runTestWithNavigationDelegate):
2692         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2693         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2694
2695 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
2696
2697         filter-build-webkit: reduce unfiltered output
2698         https://bugs.webkit.org/show_bug.cgi?id=130485
2699
2700         Reviewed by Brent Fulgham.
2701
2702         * Scripts/filter-build-webkit:
2703         (shouldIgnoreLine):
2704
2705 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2706
2707         prepare-ChangeLog should list functions that have been removed too.
2708         https://bugs.webkit.org/show_bug.cgi?id=130508
2709
2710         Reviewed by Darin Adler.
2711
2712         The prepare-ChangeLog does not list the deleted functions in the Changelog.
2713         We have to read the functions and the line ranges of them from the source
2714         before the change, then search for overlaps between them and the changed
2715         line ranges from diff.
2716
2717         * Scripts/prepare-ChangeLog:
2718         (originalFile): Get original source command.
2719         (generateFunctionLists): Collect deleted functions too.
2720         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
2721         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
2722         deleted functions ranges too.
2723         (extractLineRange): Renamed to extractLineRangeAfterChange.
2724
2725 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
2726
2727         Move all EFL typedefs into EflTypedefs.h.
2728         https://bugs.webkit.org/show_bug.cgi?id=130511
2729
2730         Reviewed by Gyuyoung Kim.
2731
2732         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
2733         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2734         * WebKitTestRunner/PlatformWebView.h: Ditto.
2735
2736 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
2737
2738         Don't flush compositing layers within FrameView::willPaintContents()
2739         https://bugs.webkit.org/show_bug.cgi?id=130627
2740         <rdar://problem/16368869>
2741
2742         Reviewed by Sam Weinig.
2743         
2744         Fix DRT to correctly render tests with layers now that FrameView::paintContents
2745         does not flush.
2746         
2747         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
2748         into an explicit function called before dumping. 
2749         
2750         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
2751         are flushed to CA. They will be pushed to the window by snapshotting.
2752
2753         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2754         Fix weird path to IOKit.framework.
2755         * DumpRenderTree/mac/DumpRenderTree.mm:
2756         (updateDisplay):
2757         (dump):
2758         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2759         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
2760         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
2761
2762 2014-03-21  David Kilzer  <ddkilzer@apple.com>
2763
2764         fix-blink-patch: tool to fix up renamed directory paths in Blink
2765         <http://webkit.org/b/130609>
2766
2767         Reviewed by Ryosuke Niwa.
2768
2769         Usage: cat blink.patch | fix-blink-patch | svn-apply
2770
2771         * Scripts/fix-blink-patch: Added.
2772
2773 2014-03-21  Darin Adler  <darin@apple.com>
2774
2775         Remove use of deprecatedCharacters in WebKit API tests
2776         https://bugs.webkit.org/show_bug.cgi?id=130602
2777
2778         Reviewed by Antti Koivisto.
2779
2780         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2781         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
2782         (TestWebKitAPI::expectEmpty): Use characters8.
2783         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
2784
2785         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2786         Removed the test that is entirely about 16-bit conversion since that's basically a test of
2787         the deprecatedCharacters function itself, which we are about to delete.
2788
2789 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2790
2791         [webkitpy] Fix has_valid_reviewer()
2792         https://bugs.webkit.org/show_bug.cgi?id=130589
2793
2794         Reviewed by Csaba Osztrogonác.
2795
2796         * Scripts/webkitpy/common/checkout/changelog.py:
2797         (ChangeLogEntry.has_valid_reviewer):
2798         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2799         (test_has_valid_reviewer):
2800         * Scripts/webkitpy/common/config/committers.py:
2801         (CommitterList._reviewer_only):
2802         (CommitterList.committer_by_name):
2803         (CommitterList.reviewer_by_email):
2804         (CommitterList):
2805         (CommitterList.reviewer_by_name):
2806
2807 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2808
2809         Add cache support for jhbuild
2810         https://bugs.webkit.org/show_bug.cgi?id=130588
2811
2812         Reviewed by Csaba Osztrogonác.
2813
2814         * jhbuild/jhbuildrc_common.py:
2815         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
2816
2817 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2818
2819         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
2820         https://bugs.webkit.org/show_bug.cgi?id=130504
2821
2822         Reviewed by Martin Robinson.
2823
2824         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
2825         CMake if not specified.
2826         * Scripts/webkitdirs.pm:
2827         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
2828         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
2829
2830 2014-03-21  Andreas Kling  <akling@apple.com>
2831
2832         RetainPtr API test should use CFArray instead of CFString for testing.
2833         <rdar://problem/16384899>
2834
2835         Unreviewed bot fix.
2836
2837         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2838         (TestWebKitAPI::TEST):
2839         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2840         (TestWebKitAPI::TEST):
2841
2842 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
2843
2844         Move to using std::unique_ptr for EFL objects.
2845         https://bugs.webkit.org/show_bug.cgi?id=129853
2846
2847         Reviewed by Gyuyoung Kim.
2848
2849         EflUniquePtr is a template alias of std::unique_ptr
2850         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
2851         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
2852
2853         * DumpRenderTree/efl/DumpRenderTree.cpp:
2854         (main):
2855         * ImageDiff/efl/ImageDiff.cpp:
2856         (initEfl):
2857         (main):
2858
2859 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
2860
2861         Unreviewed buildfix after r165983 for non Cocoa platforms
2862
2863         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
2864
2865         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2866         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2867         * WebKitTestRunner/TestController.cpp:
2868
2869 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
2870
2871         [GTK][CMake] Add support for building with Clang
2872         https://bugs.webkit.org/show_bug.cgi?id=130260
2873
2874         Reviewed by Martin Robinson.
2875
2876         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
2877         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
2878         included GTest framework headers.
2879         * gtk/generate-gtkdoc:
2880         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
2881         in case of using Clang since that is now set by the CMake rule.
2882
2883 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
2884
2885         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
2886         https://bugs.webkit.org/show_bug.cgi?id=130476
2887
2888         Reviewed by Anders Carlsson.
2889         
2890         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
2891
2892         * MiniBrowser/mac/WK1BrowserWindowController.m:
2893         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2894         Remove log.
2895         * MiniBrowser/mac/WK2BrowserWindowController.m:
2896         (-[WK2BrowserWindowController awakeFromNib]):
2897         (-[WK2BrowserWindowController validateMenuItem:]):
2898         (-[WK2BrowserWindowController reload:]):
2899         Hook up reload.
2900         (-[WK2BrowserWindowController toggleZoomMode:]):
2901         (-[WK2BrowserWindowController resetZoom:]):
2902         (-[WK2BrowserWindowController canResetZoom]):
2903         (-[WK2BrowserWindowController currentZoomFactor]):
2904         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2905         (-[WK2BrowserWindowController canZoomIn]):
2906         (-[WK2BrowserWindowController canZoomOut]):
2907
2908 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
2909
2910         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2911         https://bugs.webkit.org/show_bug.cgi?id=130463
2912
2913         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
2914
2915 2014-03-18  Samuel White  <samuel_white@apple.com>
2916
2917         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
2918         https://bugs.webkit.org/show_bug.cgi?id=130250
2919
2920         Reviewed by Chris Fleizach.
2921
2922         Added ability to toggle enhanced accessibility on and off to support tests that require it.
2923
2924         * DumpRenderTree/AccessibilityController.cpp:
2925         (enableEnhancedAccessibilityCallback):
2926         (getEnhancedAccessibilityEnabledCallback):
2927         (AccessibilityController::getJSClass):
2928         * DumpRenderTree/AccessibilityController.h:
2929         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2930         (AccessibilityController::enableEnhancedAccessibility):
2931         (AccessibilityController::enhancedAccessibilityEnabled):
2932         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2933         (AccessibilityController::enableEnhancedAccessibility):
2934         (AccessibilityController::enhancedAccessibilityEnabled):
2935         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2936         (AccessibilityController::enableEnhancedAccessibility):
2937         (AccessibilityController::enhancedAccessibilityEnabled):
2938         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2939         (AccessibilityController::enableEnhancedAccessibility):
2940         (AccessibilityController::enhancedAccessibilityEnabled):
2941         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2942         (WTR::AccessibilityController::enableEnhancedAccessibility):
2943         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
2944         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2945         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2946
2947 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
2948
2949         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
2950         yet).
2951
2952         * Scripts/webkitpy/common/config/contributors.json:
2953
2954 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
2955
2956         Web Inspector: Remove stale ReportMemoryUsagePlugin
2957         https://bugs.webkit.org/show_bug.cgi?id=130405
2958
2959         Reviewed by Andreas Kling.
2960
2961         This clang plugin looks like it was used for the old Inspector memory
2962         instrumentation that was removed. So the tool can be removed.
2963
2964         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
2965         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
2966         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
2967         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
2968
2969 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2970
2971         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
2972         https://bugs.webkit.org/show_bug.cgi?id=130220
2973
2974         Reviewed by Csaba Osztrogonác.
2975
2976         * Scripts/webkitpy/common/checkout/changelog.py:
2977         (ChangeLog.set_reviewer):
2978         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2979         (test_set_reviewer):
2980
2981 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
2982
2983         More FTL enabling.
2984
2985         Rubber stamped by Dan Bernstein.
2986
2987         * Tools/Scripts/build-webkit:
2988
2989 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2990
2991         Renable pagination mode in WK2 MiniBrowser
2992         https://bugs.webkit.org/show_bug.cgi?id=130374
2993
2994         Reviewed by Anders Carlsson.
2995         
2996         Put the implementation of togglePaginationMode: back, and correctly
2997         enable the menu item.
2998
2999         * MiniBrowser/mac/WK2BrowserWindowController.m:
3000         (-[WK2BrowserWindowController validateMenuItem:]):
3001         (-[WK2BrowserWindowController isPaginated]):
3002         (-[WK2BrowserWindowController togglePaginationMode:]):
3003
3004 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3005
3006         Add --reset option to Tools/Scripts/set-webkit-configuration script
3007         https://bugs.webkit.org/show_bug.cgi?id=130401
3008
3009         Reviewed by Csaba Osztrogonác.
3010
3011         * Scripts/set-webkit-configuration:
3012
3013 2014-03-18  Alberto Garcia  <berto@igalia.com>
3014
3015         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
3016         https://bugs.webkit.org/show_bug.cgi?id=130388
3017
3018         Reviewed by Sergio Villar Senin.
3019
3020         * Scripts/webkitdirs.pm:
3021         (shouldRemoveCMakeCache): make sure that the build directory
3022         exists before attempting to create a file in it.
3023
3024 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
3025
3026         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
3027         https://bugs.webkit.org/show_bug.cgi?id=130336
3028
3029         Reviewed by Gyuyoung Kim.
3030
3031         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
3032         requires a space between literal and string macro [-Wliteral-suffix]'
3033         warning treated as error.
3034
3035         This patch applies a solution from r162448 to the EFL port.
3036
3037         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
3038         * efl/jhbuild.modules: Added appropriate patch section.
3039
3040 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3041
3042         webkitpy test rebaseline.
3043
3044         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3045         (MainTest.test_default_args):
3046
3047 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3048
3049         --profile should imply --test-runner-count=1 in run-perf-tests
3050         https://bugs.webkit.org/show_bug.cgi?id=130375
3051
3052         Reviewed by Benjamin Poulain.
3053
3054         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
3055
3056         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3057         (PerfTestsRunner._parse_args): Use -1 as the default value.
3058         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
3059         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
3060         should be 1.
3061
3062 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3063
3064         Address some style nits.
3065
3066         * MiniBrowser/mac/WK2BrowserWindowController.m:
3067
3068 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3069
3070         Add transparent window support back into MiniBrowser
3071         https://bugs.webkit.org/show_bug.cgi?id=130363
3072
3073         Reviewed by Anders Carlsson.
3074         
3075         Re-enable transparent window support for WK2.
3076
3077         * MiniBrowser/mac/WK2BrowserWindowController.m:
3078         (-[WK2BrowserWindowController validateMenuItem:]):
3079         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3080
3081 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3082
3083         Fix the 32-bit build; make the open panel make a WK1 window.
3084
3085         * MiniBrowser/mac/AppDelegate.m:
3086         (-[BrowserAppDelegate openDocument:]):
3087
3088 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3089
3090         Convert MiniBrowser to use WKWebView API
3091         https://bugs.webkit.org/show_bug.cgi?id=130061
3092
3093         Reviewed by Anders Carlsson.
3094         
3095         Convert the MiniBrowser WK2 window to use WebKit2 API as much
3096         as possible.
3097         
3098         Some functionality was removed temporarily:
3099             - text zoom, page zoom
3100             - reload
3101             - pagination mode
3102             - transparent window
3103             - dumping source
3104             - window.open support
3105             - beforeUnload panel
3106             - find in page
3107
3108         * MiniBrowser/mac/AppDelegate.h:
3109         * MiniBrowser/mac/AppDelegate.m:
3110         (-[BrowserAppDelegate init]):
3111         (-[BrowserAppDelegate newWindow:]):
3112         (-[BrowserAppDelegate applicationWillTerminate:]):
3113         (-[BrowserAppDelegate openDocument:]):
3114         * MiniBrowser/mac/WK2BrowserWindowController.h:
3115         * MiniBrowser/mac/WK2BrowserWindowController.m:
3116         (-[WK2BrowserWindowController awakeFromNib]):
3117         (-[WK2BrowserWindowController dealloc]):
3118         (-[WK2BrowserWindowController fetch:]):
3119         (-[WK2BrowserWindowController validateMenuItem:]):
3120         (-[WK2BrowserWindowController reload:]):
3121         (-[WK2BrowserWindowController goBack:]):
3122         (-[WK2BrowserWindowController goForward:]):
3123         (-[WK2BrowserWindowController toggleZoomMode:]):
3124         (-[WK2BrowserWindowController resetZoom:]):
3125         (-[WK2BrowserWindowController canResetZoom]):
3126         (-[WK2BrowserWindowController dumpSourceToConsole:]):
3127         (-[WK2BrowserWindowController togglePaginationMode:]):
3128         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3129         (-[WK2BrowserWindowController windowShouldClose:]):
3130         (-[WK2BrowserWindowController applicationTerminating]):
3131         (-[WK2BrowserWindowController currentZoomFactor]):
3132         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3133         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3134         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3135         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3136         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3137         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3138         (-[WK2BrowserWindowController find:]):
3139         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
3140         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
3141         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
3142         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
3143         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3144         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3145         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3146         * WebKitTestRunner/PlatformWebView.h:
3147         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3148         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3149
3150 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
3151
3152         Use RunLoop objects through references instead of pointers
3153         https://bugs.webkit.org/show_bug.cgi?id=130313
3154
3155         Reviewed by Andreas Kling.
3156
3157         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
3158         return RunLoop reference instead of a pointer.
3159
3160         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
3161         (loadedCallback):
3162         (clickedCallback):
3163
3164 2014-03-17  Tim Horton  <timothy_horton@apple.com>
3165
3166         sort-export-file --help doesn't work (missing 'use')
3167         https://bugs.webkit.org/show_bug.cgi?id=130338
3168
3169         Reviewed by Anders Carlsson.
3170
3171         * Scripts/sort-export-file:
3172         Add a missing 'use', and fix a typo in an error message.
3173
3174 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
3175
3176         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
3177         https://bugs.webkit.org/show_bug.cgi?id=130155
3178
3179         Reviewed by Philippe Normand.
3180
3181         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
3182
3183 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3184
3185         [GTK] MiniBrowser fails to load injected bundle lib
3186         https://bugs.webkit.org/show_bug.cgi?id=130332
3187
3188         Reviewed by Anders Carlsson.
3189
3190         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
3191
3192         * MiniBrowser/gtk/main.c:
3193         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
3194         process is spawn.
3195
3196 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
3197
3198         [EFL] Enable TOUCH_SLIDER macro
3199         https://bugs.webkit.org/show_bug.cgi?id=130185
3200
3201         Reviewed by Gyuyoung Kim.
3202
3203         * Scripts/webkitperl/FeatureList.pm:
3204
3205 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
3206
3207         [GTK][CMake] Build with -fno-rtti
3208         https://bugs.webkit.org/show_bug.cgi?id=130261
3209
3210         Reviewed by Martin Robinson.
3211
3212         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
3213         defined to 0 to prevent typeid use in included GTest headers.
3214
3215 2014-03-16  Brian Burg  <bburg@apple.com>
3216
3217         Web Inspector: vended backend commands file should be generated as part of the build
3218         https://bugs.webkit.org/show_bug.cgi?id=130110
3219
3220         Reviewed by Timothy Hatcher.
3221
3222         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
3223
3224 2014-03-16  Diego Pino García  <dpino@igalia.com>
3225
3226         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
3227         https://bugs.webkit.org/show_bug.cgi?id=128999
3228
3229         Reviewed by Philippe Normand.
3230
3231         * MiniBrowser/gtk/BrowserWindow.c:
3232         (reloadPage):
3233         (reloadPageIgnoringCache):
3234         (browser_window_init):
3235
3236 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
3237
3238         [GTK] Improve ninja detection in webkitdirs.pm
3239         https://bugs.webkit.org/show_bug.cgi?id=129902
3240
3241         Reviewed by Daniel Bates.
3242
3243         * Scripts/webkitdirs.pm:
3244         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
3245         us to look for ninja-build as well.
3246
3247 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
3248
3249         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
3250         https://bugs.webkit.org/show_bug.cgi?id=130276
3251         <rdar://problem/16266927>
3252         
3253         Reviewed by Simon Fraser.
3254
3255         * BuildSlaveSupport/build-launcher-app:
3256         * BuildSlaveSupport/build-launcher-dmg:
3257         * DumpRenderTree/DumpRenderTree.h:
3258         * DumpRenderTree/DumpRenderTreePrefix.h:
3259         * DumpRenderTree/GCController.cpp:
3260         * DumpRenderTree/GCController.h:
3261         * DumpRenderTree/JavaScriptThreading.cpp:
3262         * DumpRenderTree/JavaScriptThreading.h:
3263         * DumpRenderTree/PixelDumpSupport.cpp:
3264         * DumpRenderTree/PixelDumpSupport.h:
3265         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
3266         * DumpRenderTree/TestRunner.cpp:
3267         * DumpRenderTree/TestRunner.h:
3268         * DumpRenderTree/WorkQueue.cpp:
3269         * DumpRenderTree/WorkQueue.h:
3270         * DumpRenderTree/WorkQueueItem.h:
3271         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3272         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3273         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
3274         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3275         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3276         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3277         * DumpRenderTree/efl/EditingCallbacks.cpp:
3278         * DumpRenderTree/efl/EditingCallbacks.h:
3279         * DumpRenderTree/efl/EventSender.cpp:
3280         * DumpRenderTree/efl/EventSender.h:
3281         * DumpRenderTree/efl/GCControllerEfl.cpp:
3282         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3283         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3284         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3285         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3286         * DumpRenderTree/gtk/EditingCallbacks.cpp:
3287         * DumpRenderTree/gtk/EditingCallbacks.h:
3288         * DumpRenderTree/gtk/EventSender.cpp:
3289         * DumpRenderTree/gtk/EventSender.h:
3290         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3291         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3292         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
3293         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
3294         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3295         * DumpRenderTree/gtk/TextInputController.cpp:
3296         * DumpRenderTree/gtk/TextInputController.h:
3297         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
3298         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
3299         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3300         * DumpRenderTree/mac/AppleScriptController.h:
3301         * DumpRenderTree/mac/AppleScriptController.m:
3302         * DumpRenderTree/mac/CheckedMalloc.cpp:
3303         * DumpRenderTree/mac/CheckedMalloc.h:
3304         * DumpRenderTree/mac/DumpRenderTree.mm:
3305         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3306         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3307         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3308         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3309         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3310         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3311         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3312         * DumpRenderTree/mac/EditingDelegate.h:
3313         * DumpRenderTree/mac/EditingDelegate.mm:
3314         * DumpRenderTree/mac/EventSendingController.h:
3315         * DumpRenderTree/mac/EventSendingController.mm:
3316         * DumpRenderTree/mac/FrameLoadDelegate.h:
3317         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3318         * DumpRenderTree/mac/GCControllerMac.mm:
3319         * DumpRenderTree/mac/MockWebNotificationProvider.h:
3320         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3321         * DumpRenderTree/mac/NavigationController.h:
3322         * DumpRenderTree/mac/NavigationController.m:
3323         * DumpRenderTree/mac/ObjCController.h:
3324         * DumpRenderTree/mac/ObjCController.m:
3325         * DumpRenderTree/mac/ObjCPlugin.h:
3326         * DumpRenderTree/mac/ObjCPlugin.m:
3327         * DumpRenderTree/mac/ObjCPluginFunction.h:
3328         * DumpRenderTree/mac/ObjCPluginFunction.m:
3329         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3330         * DumpRenderTree/mac/PolicyDelegate.h:
3331         * DumpRenderTree/mac/PolicyDelegate.mm:
3332         * DumpRenderTree/mac/ResourceLoadDelegate.h:
3333         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3334         * DumpRenderTree/mac/TestRunnerMac.mm:
3335         * DumpRenderTree/mac/TextInputController.h:
3336         * DumpRenderTree/mac/TextInputController.m:
3337         * DumpRenderTree/mac/UIDelegate.h:
3338         * DumpRenderTree/mac/UIDelegate.mm:
3339         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3340         * DumpRenderTree/win/DRTDataObject.cpp:
3341         * DumpRenderTree/win/DRTDataObject.h:
3342         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3343         * DumpRenderTree/win/DRTDropSource.cpp:
3344         * DumpRenderTree/win/DRTDropSource.h:
3345         * DumpRenderTree/win/DraggingInfo.h:
3346         * DumpRenderTree/win/DumpRenderTree.cpp:
3347         * DumpRenderTree/win/DumpRenderTreeWin.h:
3348         * DumpRenderTree/win/EditingDelegate.cpp:
3349         * DumpRenderTree/win/EditingDelegate.h:
3350         * DumpRenderTree/win/EventSender.cpp:
3351         * DumpRenderTree/win/EventSender.h:
3352         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3353         * DumpRenderTree/win/FrameLoadDelegate.h:
3354         * DumpRenderTree/win/GCControllerWin.cpp:
3355         * DumpRenderTree/win/HistoryDelegate.cpp:
3356         * DumpRenderTree/win/HistoryDelegate.h:
3357         * DumpRenderTree/win/MD5.cpp:
3358         * DumpRenderTree/win/MD5.h:
3359         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3360         * DumpRenderTree/win/PolicyDelegate.cpp:
3361         * DumpRenderTree/win/PolicyDelegate.h:
3362         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3363         * DumpRenderTree/win/ResourceLoadDelegate.h:
3364         * DumpRenderTree/win/TestRunnerWin.cpp:
3365         * DumpRenderTree/win/TextInputController.cpp:
3366         * DumpRenderTree/win/TextInputController.h:
3367         * DumpRenderTree/win/TextInputControllerWin.cpp:
3368         * DumpRenderTree/win/UIDelegate.cpp:
3369         * DumpRenderTree/win/UIDelegate.h:
3370         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3371         * EWebLauncher/main.c:
3372         * GtkLauncher/main.c:
3373         * ImageDiff/efl/ImageDiff.cpp:
3374         * ImageDiff/gtk/ImageDiff.cpp:
3375         * MiniBrowser/gtk/main.c:
3376         * Scripts/SpacingHeuristics.pm:
3377         * Scripts/VCSUtils.pm:
3378         * Scripts/bisect-builds:
3379         * Scripts/build-dumprendertree:
3380         * Scripts/build-jsc:
3381         * Scripts/build-webkit:
3382         * Scripts/check-dom-results:
3383         * Scripts/check-for-exit-time-destructors:
3384         * Scripts/check-for-global-initializers:
3385         * Scripts/commit-log-editor:
3386         * Scripts/compare-timing-files:
3387         * Scripts/debug-minibrowser:
3388         * Scripts/debug-safari:
3389         * Scripts/do-file-rename:
3390         * Scripts/find-extra-includes:
3391         * Scripts/generate-coverage-data:
3392         * Scripts/make-script-test-wrappers:
3393         * Scripts/malloc-tree:
3394         * Scripts/old-run-webkit-tests:
3395         * Scripts/parse-malloc-history:
3396         * Scripts/report-include-statistics:
3397         * Scripts/resolve-ChangeLogs:
3398         * Scripts/run-bindings-tests:
3399         * Scripts/run-iexploder-tests:
3400         * Scripts/run-javascriptcore-tests:
3401         * Scripts/run-jsc:
3402         * Scripts/run-launcher:
3403         * Scripts/run-leaks:
3404         * Scripts/run-mangleme-tests:
3405         * Scripts/run-minibrowser:
3406         * Scripts/run-pageloadtest:
3407         * Scripts/run-regexp-tests:
3408         * Scripts/run-safari:
3409         * Scripts/run-sunspider:
3410         * Scripts/run-webkit-app:
3411         * Scripts/sampstat:
3412         * Scripts/set-webkit-configuration:
3413         * Scripts/sort-Xcode-project-file:
3414         * Scripts/sort-export-file:
3415         * Scripts/split-file-by-class:
3416         * Scripts/sunspider-compare-results:
3417         * Scripts/svn-apply:
3418         * Scripts/svn-create-patch:
3419         * Scripts/svn-unapply:
3420         * Scripts/test-webkit-scripts:
3421         * Scripts/update-javascriptcore-test-results:
3422         * Scripts/update-webkit:
3423         * Scripts/update-webkit-auxiliary-libs:
3424         * Scripts/update-webkit-dependency:
3425         * Scripts/update-webkit-localizable-strings:
3426         * Scripts/update-webkit-support-libs:
3427         * Scripts/update-webkit-wincairo-libs:
3428         * Scripts/webkit-build-directory:
3429         * Scripts/webkitdirs.pm:
3430         (installedSafariPath):
3431         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3432         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3433         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3434         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3435         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3436         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3437         * Scripts/webkitperl/features.pm:
3438         * Scripts/webkitperl/httpd.pm:
3439         * Scripts/webkitpy/bindings/main.py:
3440         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3441         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3442         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3443         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3444         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3445         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3446         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3447         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3448         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3449         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
3450         * WebKitTestRunner/PixelDumpSupport.cpp:
3451         * WebKitTestRunner/PixelDumpSupport.h:
3452         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3453         * WinLauncher/WinLauncher.cpp:
3454         * WinLauncher/WinLauncher.h:
3455         * WinLauncher/stdafx.cpp:
3456         * WinLauncher/stdafx.h:
3457
3458 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
3459
3460         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
3461         https://bugs.webkit.org/show_bug.cgi?id=130265
3462
3463         Reviewed by Michael Saboff.
3464
3465         * Scripts/build-webkit:
3466         * Scripts/copy-webkitlibraries-to-product-directory:
3467
3468 2014-03-14  Landry Breuil  <landry@openbsd.org>
3469
3470         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
3471         Also allow to set MAKE in the environment.
3472         https://bugs.webkit.org/show_bug.cgi?id=129991
3473
3474         Reviewed by Andreas Kling.
3475
3476         * Scripts/webkitdirs.pm:
3477         (determineArchitecture):
3478         (determineNumberOfCPUs):
3479         (isBSD):
3480         (buildAutotoolsProject):
3481         * Scripts/webkitpy/common/system/platforminfo.py:
3482         (PlatformInfo.__init__):
3483         (PlatformInfo.is_openbsd):
3484         (PlatformInfo):
3485         (PlatformInfo.is_netbsd):
3486         (PlatformInfo._determine_os_name):
3487
3488 2014-03-14  Dean Jackson  <dino@apple.com>
3489
3490         Remove libWebKitSystemInterfaceLion.a
3491         https://bugs.webkit.org/show_bug.cgi?id=130254
3492
3493         Reviewed by Geoffrey Garen and Andreas Kling.
3494
3495         No need to copy the Lion libraries into the build.
3496
3497         * Scripts/copy-webkitlibraries-to-product-directory:
3498
3499 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3500
3501         [EFL][MiniBrowser] Revise help messages of command line parameters
3502         https://bugs.webkit.org/show_bug.cgi?id=130222
3503
3504         Reviewed by Csaba Osztrogonác.
3505
3506         Correct the default value description and make help messages to be consistent.
3507
3508         * MiniBrowser/efl/main.c:
3509
3510 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
3511
3512         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
3513         https://bugs.webkit.org/show_bug.cgi?id=129612
3514
3515         Reviewed by Darin Adler.
3516
3517         For new code use static NeverDestroyed<T> instead.
3518
3519         * DumpRenderTree/JavaScriptThreading.cpp:
3520         (javaScriptThreadsMutex):
3521         (javaScriptThreads):
3522         * DumpRenderTree/efl/EventSender.cpp:
3523         (touchPointList):
3524         (delayedEventQueue):
3525         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3526         (delegatesWithDelayedWork):
3527         * Scripts/check-for-exit-time-destructors:
3528         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
3529         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3530         (testsMap):
3531
3532 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
3533
3534         [EFL][WK2] Fix compilation warning in Minibrowser
3535         https://bugs.webkit.org/show_bug.cgi?id=130132
3536
3537         Reviewed by Csaba Osztrogonác.
3538
3539         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
3540
3541         * MiniBrowser/efl/main.c:
3542         (on_download_request):
3543
3544 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
3545
3546         FTL should support IsBlah
3547         https://bugs.webkit.org/show_bug.cgi?id=130202
3548
3549         Reviewed by Geoffrey Garen.
3550         
3551         Running existing JSRegress tests with noInline gives us coverage for these
3552         changes. Chances are, this will also give coverage for other interesting things
3553         as well.
3554
3555         * Scripts/run-jsc-stress-tests:
3556
3557 2014-03-12  Brian Burg  <bburg@apple.com>
3558
3559         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
3560         https://bugs.webkit.org/show_bug.cgi?id=129744
3561
3562         Reviewed by Timothy Hatcher.
3563
3564         * DumpRenderTree/TestRunner.cpp:
3565         (evaluateInWebInspectorCallback):
3566         * DumpRenderTree/TestRunner.h:
3567         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3568         (TestRunner::evaluateInWebInspector):
3569         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3570         (TestRunner::evaluateInWebInspector):
3571         * DumpRenderTree/mac/TestRunnerMac.mm:
3572         (TestRunner::evaluateInWebInspector):
3573         * DumpRenderTree/win/TestRunnerWin.cpp:
3574         (TestRunner::evaluateInWebInspector):
3575         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3576         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3577         (WTR::TestRunner::evaluateInWebInspector):
3578         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3579
3580 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3581
3582         [GTK] build-webkit shouldn't show error message when ninja isn't installed
3583         https://bugs.webkit.org/show_bug.cgi?id=130129
3584
3585         Reviewed by Csaba Osztrogonác.
3586
3587         * Scripts/webkitdirs.pm:
3588         (canUseNinja): Redirecting stderr to /dev/null
3589
3590 2014-03-13  Andres Gomez  <agomez@igalia.com>
3591
3592         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
3593         https://bugs.webkit.org/show_bug.cgi?id=130092
3594
3595         Reviewed by Csaba Osztrogonác.
3596
3597         Added "python-dev" as dependency for deb based distros. It is
3598         already present for rpm based distros. This dependency will allow
3599         libxml2 to generate its python bindings, needed by gtk-doc.
3600
3601         * gtk/install-dependencies:
3602
3603 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3604
3605         Unreviewed. Fix GTK+ cmake build after r165488.
3606
3607         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
3608
3609 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3610
3611         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
3612         https://bugs.webkit.org/show_bug.cgi?id=130014
3613
3614         Reviewed by Martin Robinson.
3615
3616         Include cmake or autotools config header.
3617
3618         * MiniBrowser/gtk/BrowserDownloadsBar.c:
3619         * MiniBrowser/gtk/BrowserSearchBar.c:
3620         * MiniBrowser/gtk/BrowserWindow.c:
3621         * MiniBrowser/gtk/main.c:
3622
3623 2014-03-12  Commit Queue  <commit-queue@webkit.org>
3624
3625         Unreviewed, rolling out r165471.
3626         https://bugs.webkit.org/show_bug.cgi?id=130139
3627
3628         Didn't really fix the issue and broke another bot (Requested
3629         by mrobinson on #webkit).
3630
3631         Reverted changeset:
3632
3633         "[CMake] Newer versions of CMake cannot find older versions of
3634         Freetype"
3635         https://bugs.webkit.org/show_bug.cgi?id=130107
3636         http://trac.webkit.org/changeset/165471
3637
3638 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
3639
3640         It should be possible to build WebKit with FTL on iOS
3641         https://bugs.webkit.org/show_bug.cgi?id=130116
3642
3643         Reviewed by Dan Bernstein.
3644
3645         * Scripts/build-webkit:
3646         * Scripts/copy-webkitlibraries-to-product-directory:
3647
3648 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
3649
3650         [Win] Remove use of QTSDK
3651         https://bugs.webkit.org/show_bug.cgi?id=130049
3652
3653         Reviewed by Darin Adler.
3654
3655         * DumpRenderTree/win/DumpRenderTree.cpp:
3656         (initialize): Remove QuickTime code.
3657         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
3658         building QTMovieWin.
3659
3660 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
3661
3662         [GTK][CMAKE] Too verbose build output
3663         https://bugs.webkit.org/show_bug.cgi?id=130076
3664
3665         Reviewed by Carlos Garcia Campos.
3666
3667         Instead of building with cmake --build which isn't smart about pretty printing and
3668         colors, we build with a script which calls the proper build command.
3669
3670         * Scripts/webkitdirs.pm:
3671         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
3672         the CMake configuration pass.
3673
3674 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3675
3676         [CMake] Newer versions of CMake cannot find older versions of Freetype
3677         https://bugs.webkit.org/show_bug.cgi?id=130107
3678
3679         Reviewed by Gustavo Noronha Silva.
3680
3681         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
3682         to CMake during jhbuild initialization.
3683
3684 2014-03-12  Zalan Bujtas  <zalan@apple.com>
3685
3686         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
3687         https://bugs.webkit.org/show_bug.cgi?id=129961
3688
3689         Reviewed by Simon Fraser.
3690
3691         Now scaled content can go through the window capturing mechanism too for compositing content.
3692         AppleMagnifiedMode is redundant.
3693
3694         * DumpRenderTree/mac/DumpRenderTree.mm:
3695         (setDefaultsToConsistentValuesForTesting):
3696         (runTest):
3697         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3698         (createBitmapContextFromWebView):
3699         * WebKitTestRunner/PlatformWebView.h:
3700         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3701         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3702         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3703         (WTR::PlatformWebView::didInitializeClients):
3704         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3705         (WTR::PlatformWebView::forceWindowFramesChanged):
3706         * WebKitTestRunner/mac/main.mm:
3707         (setDefaultsToConsistentValuesForTesting):
3708
3709 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
3710
3711         Unreviewed. Add myself as a committer.
3712
3713         * Scripts/webkitpy/common/config/contributors.json:
3714
3715 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
3716
3717         Unreviewed build fix on the EFL port when used lower version of ATK
3718
3719         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3720         (WTR::AccessibilityUIElement::y): Fixed typo.
3721
3722 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3723
3724         Some images are blank in the rebaseline server UI
3725         https://bugs.webkit.org/show_bug.cgi?id=130104
3726
3727         Reviewed by Tim Horton.
3728
3729         Let the server check for images in the 'retries' directory
3730         if it can't find an image otherwise.
3731
3732         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3733         (RebaselineHTTPRequestHandler.test_result):
3734
3735 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3736
3737         [GTK][CMake] --update-gtk has no effect
3738         https://bugs.webkit.org/show_bug.cgi?id=130088
3739
3740         Reviewed by Philippe Normand.
3741
3742         * Scripts/webkitdirs.pm:
3743         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
3744         as an argument.
3745
3746 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3747
3748         Add "System Font" to the list of whitelisted DRT fonts
3749         https://bugs.webkit.org/show_bug.cgi?id=130046
3750
3751         Reviewed by Darin Adler.
3752
3753         * DumpRenderTree/mac/DumpRenderTree.mm:
3754         (allowedFontFamilySet):
3755         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3756
3757 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3758
3759         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
3760         https://bugs.webkit.org/show_bug.cgi?id=130064
3761
3762         Reviewed by Philippe Normand.
3763
3764         * efl/jhbuildrc: Remove duplicated code.
3765         * gtk/jhbuildrc: Remove duplicated code.
3766         * jhbuild/jhbuildrc_common.py:
3767         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
3768         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
3769         and is apparently necessary for GTK+.
3770
3771 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3772
3773         check-webkit-style failed to complain about missing braces
3774         https://bugs.webkit.org/show_bug.cgi?id=34189
3775
3776         Reviewed by Ryosuke Niwa.
3777
3778         * Scripts/webkitpy/style/checkers/cpp.py:
3779         (check_braces):
3780         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3781         (WebKitStyleTest.test_braces):
3782
3783 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3784
3785         Remove Qt cruft from style checker.
3786         https://bugs.webkit.org/show_bug.cgi?id=130085
3787
3788         Reviewed by Csaba Osztrogonác.
3789
3790         There is no 'foreach' keyword in c++. That was a Qt feature
3791         added in: http://trac.webkit.org/changeset/46113
3792         Qt was removed from WebKit, so we should remove the checks
3793         of this keyword from check-webkit-style scripts.
3794
3795         * Scripts/webkitpy/style/checkers/cpp.py:
3796         (check_spacing_for_function_call):
3797         (check_spacing):
3798         (check_braces):
3799         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3800         (CppStyleTest.test_mismatching_spaces_in_parens):
3801         (CppStyleTest.test_spacing_for_fncall):
3802         (WebKitStyleTest.test_braces):
3803
3804 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
3805
3806         [GTK] update-webkitgtk-libs needs itstool
3807         https://bugs.webkit.org/show_bug.cgi?id=130082
3808
3809         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
3810         itstool is a dependency of building gtk-doc from version 1.19, so it should
3811         be added to Tools/gtk/install-dependencies script, too.
3812
3813         Reviewed by Philippe Normand.
3814
3815         * gtk/install-dependencies:
3816
3817 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3818
3819         webkitbot rollout ChangeLogs should be nicer
3820         https://bugs.webkit.org/show_bug.cgi?id=122654
3821
3822         Reviewed by Csaba Osztrogonác.
3823
3824         Added bug urls and descriptions of rolled out patches to the rollout changelog
3825         if they are present in the original changelog. Additionally removed the list of
3826         changed files and functions.
3827
3828         * Scripts/webkitpy/common/checkout/changelog.py:
3829         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
3830         * Scripts/webkitpy/common/checkout/checkout.py:
3831         (Checkout._changelog_data_for_revision): Store bug description.
3832         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3833         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3834         (CheckoutTest.test_commit_info_for_revision):
3835         * Scripts/webkitpy/common/checkout/commitinfo.py:
3836         (CommitInfo.bug_description): Added.
3837         (CommitInfo.to_json):
3838         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3839         (CommitInfoTest.test_commit_info_creation):
3840         * Scripts/webkitpy/tool/commands/download.py:
3841         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
3842         out patches for creating rollout changelog.
3843         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
3844         caused the regression is stored in state["bug_blocked"] now.
3845         * Scripts/webkitpy/tool/commands/download_unittest.py:
3846         (test_prepare_rollout):
3847         (test_create_rollout_multiple_revision):
3848         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3849         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
3850         rolled out patches to the changelog.
3851         (PrepareChangeLogForRevert.run):
3852         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3853         (UpdateChangeLogsForRevertTest):
3854         (test_message_for_revert):
3855         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3856         (ReopenBugAfterRollout.run):
3857
3858 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3859
3860         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
3861         https://bugs.webkit.org/show_bug.cgi?id=130021
3862
3863         Reviewed by Mario Sanchez Prada.
3864
3865         Replace deprecated functions to use new API from ATK 2.11.90.
3866
3867         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3868         (AccessibilityUIElement::x):
3869         (AccessibilityUIElement::y):
3870         (AccessibilityUIElement::width):
3871         (AccessibilityUIElement::height):
3872         (AccessibilityUIElement::clickPointX):
3873         (AccessibilityUIElement::clickPointY):
3874         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3875         (WTR::AccessibilityUIElement::x):
3876         (WTR::AccessibilityUIElement::y):
3877         (WTR::AccessibilityUIElement::width):
3878         (WTR::AccessibilityUIElement::height):
3879         (WTR::AccessibilityUIElement::clickPointX):
3880         (WTR::AccessibilityUIElement::clickPointY):
3881
3882 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3883
3884         [ATK] Expose aria-posinset and aria-setsize through object attributes
3885         https://bugs.webkit.org/show_bug.cgi?id=130011
3886
3887         Reviewed by Chris Fleizach.
3888
3889         Added missing implementation of numberAttributeValue both to WKTR and DRT.
3890
3891         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3892         (AccessibilityUIElement::numberAttributeValue):
3893         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3894         (WTR::AccessibilityUIElement::numberAttributeValue):
3895
3896 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3897
3898         [Win] Unreviewed build fix.
3899
3900         Some bad Windows code was committed at some point that prevents the Apple Windows port
3901         from finding its runtime dependencies reliably.
3902
3903         * win/DLLLauncher/DLLLauncherMain.cpp:
3904         (appleApplicationSupportDirectory): Restored this function.
3905         (modifyPath): Update to use appleApplicationSupportDirectory function.
3906
3907 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
3908
3909         Let the user define the full address of the performance-site-server for uploading results
3910         https://bugs.webkit.org/show_bug.cgi?id=129819
3911
3912         Reviewed by Ryosuke Niwa.
3913
3914         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
3915         can be confusing. It's more straightforward, if you need to define explicitly the server's full
3916         address along with the protocol, when you're using this parameter. I added HTTPS as the default
3917         protocol for now, in order to avoid breaking the perf bots.
3918
3919         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3920         (_upload_json):
3921         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3922         (MainTest.test_upload_json):
3923
3924 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3925
3926         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
3927         https://bugs.webkit.org/show_bug.cgi?id=130023
3928
3929         Reviewed by Dean Jackson.
3930
3931         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
3932         /SAFESEH flag to DLL launcher process.
3933
3934 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3935
3936         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
3937         https://bugs.webkit.org/show_bug.cgi?id=129980
3938
3939         Reviewed by Carlos Garcia Campos.
3940
3941         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
3942
3943 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3944
3945         [GTK] Remove the WebView source-mode WebKit1 test
3946         https://bugs.webkit.org/show_bug.cgi?id=129976
3947
3948         Reviewed by Carlos Garcia Campos.
3949
3950         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
3951
3952 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
3953
3954         Unreviewed build fix for GTKbuild after the switch to CMake
3955
3956         * gtk/common.py:
3957         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
3958         test-only bot doesn't have any build files.
3959
3960 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3961
3962         [GTK] built-product-archive does not handle GTK+ CMake build
3963         https://bugs.webkit.org/show_bug.cgi?id=129941
3964
3965         * BuildSlaveSupport/built-product-archive:
3966         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
3967         the CMake build.
3968
3969 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
3970
3971         [GTK] Include CMake into install-dependencies script
3972         https://bugs.webkit.org/show_bug.cgi?id=129909
3973
3974         Reviewed by Martin Robinson.
3975
3976         As since r165267 buid-webkit uses CMake by default, the dependency
3977         with 'cmake' package should be introduced.
3978
3979         * gtk/install-dependencies: Ditto.
3980
3981 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3982
3983         REGRESSION(165267): Broke a webkitpy unit tests
3984         https://bugs.webkit.org/show_bug.cgi?id=129904
3985
3986         Reviewed by Jon Honeycutt.
3987
3988         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
3989         (GtkPort._is_cmake_build):
3990
3991 2014-03-07  Andres Gomez  <agomez@igalia.com>
3992
3993         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
3994         https://bugs.webkit.org/show_bug.cgi?id=129893
3995
3996         Reviewed by Martin Robinson.
3997
3998         Added "git-svn" as dependency for deb based distros and,
3999         additionally, "subversion" for rpm based distros.
4000
4001         * gtk/install-dependencies:
4002
4003 2014-03-07  Roger Fong  <roger_fong@apple.com>
4004
4005         Remove dummy setSystemWebGLLoadPolicy client method.
4006         https://bugs.webkit.org/show_bug.cgi?id=129873.
4007
4008         Reviewed by Dean Jackson.
4009
4010         * WebKitTestRunner/TestController.cpp:
4011         (WTR::TestController::createWebViewWithOptions):
4012
4013 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
4014
4015         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
4016         https://bugs.webkit.org/show_bug.cgi?id=129886
4017
4018         Reviewed by Mark Lam.
4019
4020         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
4021         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
4022         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
4023         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
4024         make it through when in non-verbose mode.
4025
4026 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
4027
4028         [GTK] buid-webkit should use CMake by default
4029         https://bugs.webkit.org/show_bug.cgi?id=129855
4030
4031         Reviewed by Carlos Garcia Campos.
4032
4033         Make the CMake build the default GTK+ build when using build-webkit. This will
4034         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
4035         so that we have --gtk and --gtkautotools.
4036
4037         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
4038         * Scripts/webkitpy/port/gtk.py: Ditto.
4039
4040 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
4041
4042         [CMake] [GTK] Build with ninja when it is available
4043         https://bugs.webkit.org/show_bug.cgi?id=129805
4044
4045         Reviewed by Philippe Normand.
4046
4047         * Scripts/webkitdirs.pm:
4048         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
4049         if it's available on the system.
4050         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
4051         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
4052
4053 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
4054
4055         If the FTL is build-time enabled then it should be run-time enabled.
4056
4057         Rubber stamped by Geoffrey Garen.
4058
4059         * Scripts/run-jsc-stress-tests:
4060
4061 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
4062
4063         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
4064         https://bugs.webkit.org/show_bug.cgi?id=129837
4065
4066         Reviewed by Michael Saboff.
4067
4068         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
4069         The fix is to use find instead of ls like we do in shell-runner.sh.
4070
4071         * Scripts/run-jsc-stress-tests:
4072
4073 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
4074
4075         filter-build-webkit should not strip .o
4076         https://bugs.webkit.org/show_bug.cgi?id=129614
4077
4078         Reviewed by Dean Jackson.
4079
4080         This makes it much easier to jump from the failing output at
4081         the end back up to the compile errors earlier in the output.
4082
4083         * Scripts/filter-build-webkit:
4084
4085 2014-03-06  Anders Carlsson  <andersca@apple.com>
4086
4087         Build WebKit2 before building WebKit
4088         https://bugs.webkit.org/show_bug.cgi?id=129831
4089         <rdar://problem/15920020>
4090
4091         Reviewed by Dan Bernstein.
4092
4093         * Scripts/build-webkit:
4094         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
4095
4096 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
4097
4098         make-3.82 fails to build on ARM/Linux
4099         https://bugs.webkit.org/show_bug.cgi?id=107926
4100
4101         Reviewed by Martin Robinson.
4102
4103         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
4104         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
4105         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
4106         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
4107
4108         * gtk/patches/make-3.82-arg-list-length.patch:
4109
4110 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4111
4112         [GTK] Close the page when the view is disposed instead of when finalized
4113         https://bugs.webkit.org/show_bug.cgi?id=129783
4114
4115         Reviewed by Sergio Villar Senin.
4116
4117         Add test case but disabled for now because it's affetected by bug #129684.
4118
4119         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
4120         (testProcessPerWebView):
4121
4122 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4123
4124         [GTK] MiniBrowser crashes when opening several urls passed as command line options
4125         https://bugs.webkit.org/show_bug.cgi?id=129738
4126
4127         Reviewed by Sergio Villar Senin.
4128
4129         The problem is that we are calling g_object_unref() for the
4130         WebKitWebSettings everytime we set it to a WebKitWebView, but the
4131         view only increases the reference counter when the settings is not
4132         the same it currently has. We should release our reference once.
4133
4134         * MiniBrowser/gtk/main.c:
4135         (createBrowserWindow):
4136         (main):
4137
4138 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4139
4140         [GTK][CMake] Tarball is created with wrong tarball paths
4141         https://bugs.webkit.org/show_bug.cgi?id=129496
4142
4143         Reviewed by Daniel Bates.
4144
4145         * gtk/make-dist.py:
4146         (Manifest.__init__): I inadvertently inverted the logic of these checks when
4147         landing the original patch with some suggestions from the reviewer. With the
4148         checks corrected, the tarball path is constructed properly.
4149
4150 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
4151
4152         Unreviewed. Update my email in contributors.json
4153
4154         * Scripts/webkitpy/common/config/contributors.json:
4155
4156 2014-03-05  Dean Jackson  <dino@apple.com>
4157
4158         [WebGL] Use WKSI to see what the system policy for WebGL is
4159         https://bugs.webkit.org/show_bug.cgi?id=129722
4160         <rdar://problem/15790542>
4161
4162         Reviewed by Tim Horton.
4163
4164         Dummy entry for setSystemWebGLLoadPolicy.
4165
4166         * WebKitTestRunner/TestController.cpp:
4167         (WTR::TestController::createWebViewWithOptions):
4168
4169 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
4170
4171         [GTK][CMake] Generate documentation for the DOM bindings
4172         https://bugs.webkit.org/show_bug.cgi?id=126211
4173
4174         Reviewed by Carlos Garcia Campos.
4175
4176         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
4177         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
4178         * gtk/generate-webkitdom-doc-files: Removed.
4179         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
4180         that it can be called by generate-gtkdoc.
4181
4182 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4183
4184         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
4185         https://bugs.webkit.org/show_bug.cgi?id=129380
4186
4187         Reviewed by Philippe Normand.
4188
4189         * Scripts/webkitdirs.pm:
4190         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
4191         skipping CMake execution.
4192
4193 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4194
4195         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
4196         https://bugs.webkit.org/show_bug.cgi?id=129651
4197
4198         Reviewed by Philippe Normand.
4199
4200         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
4201
4202 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4203
4204         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
4205         https://bugs.webkit.org/show_bug.cgi?id=129637
4206
4207         Reviewed by Carlos Garcia Campos.
4208
4209         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4210         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
4211         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
4212         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
4213         New API typically just requires a rebaseline and isn't necessarily a faiulre.
4214         (TestFactory.__init__): Add the test for GTK+.
4215         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
4216
4217 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
4218
4219         [ATK] Expose missing functionalities of AtkTableCell to AT
4220         https://bugs.webkit.org/show_bug.cgi?id=129492
4221
4222         Reviewed by Mario Sanchez Prada.
4223
4224         Reducing some code by using new API of AtkTableCell.
4225
4226         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4227         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4228
4229 2014-03-04  Alex Christensen  <achristensen@webkit.org>
4230
4231         Preparing to run layout tests on Wincairo.
4232         https://bugs.webkit.org/show_bug.cgi?id=129709
4233
4234         Reviewed by Brent Fulgham.
4235
4236         * Scripts/webkitdirs.pm:
4237         (setPathForRunningWebKitApp):
4238         Add GStreamer directory for WinCairo running layout tests.
4239         * win/DLLLauncher/DLLLauncherMain.cpp:
4240         (modifyPath):
4241         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
4242
4243 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
4244
4245         [GTK] Simplify the GObject DOM bindings API break check into one step
4246         https://bugs.webkit.org/show_bug.cgi?id=129571
4247
4248         Reviewed by Carlos Garcia Campos.
4249
4250         * GNUmakefile.am: Add the API break check to 'make check.'
4251         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
4252         * gtk/check-gdom-symbols: Removed.
4253         * gtk/webkitdom.py: Added.
4254         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
4255         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
4256
4257 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
4258
4259         Add Jeremy Jones to the contributors list as a contributor.
4260
4261         * Scripts/webkitpy/common/config/contributors.json:
4262
4263 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
4264
4265         Unreviewed. Update contact email.
4266         https://bugs.webkit.org/show_bug.cgi?id=129610
4267
4268         * Scripts/webkitpy/common/config/contributors.json:
4269
4270 2014-03-02  Brian Burg  <bburg@apple.com>
4271
4272         Web Inspector model tests load wrong inspector page under WebKitTestRunner
4273         https://bugs.webkit.org/show_bug.cgi?id=129460
4274
4275         Reviewed by Dan Bernstein.
4276
4277         Don't unconditionally open the inspector before running an inspector test.
4278         Instead, the test should request that the inspector open when it's ready.
4279
4280         This change was lost during a rebase, but is the same change made to
4281         DumpRenderTree.
4282
4283         * WebKitTestRunner/TestInvocation.cpp:
4284         (WTR::TestInvocation::invoke): 
4285
4286 2014-03-02  Darin Adler  <darin@apple.com>
4287
4288         Split TextIteratorBehavior into a separate header
4289         https://bugs.webkit.org/show_bug.cgi?id=129578
4290
4291         Reviewed by Sam Weinig.
4292
4293         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
4294         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
4295         task easy, but the remove is still a bit of a pain.
4296
4297 2014-03-02  Darin Adler  <darin@apple.com>
4298
4299         Sort Mac platform export files so they merge better
4300         https://bugs.webkit.org/show_bug.cgi?id=129581
4301
4302         Reviewed by Sam Weinig.
4303
4304         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
4305         Mac export files in a "canonical" order for this project.
4306
4307 2014-02-28  Zalan Bujtas  <zalan@apple.com>
4308
4309         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
4310         https://bugs.webkit.org/show_bug.cgi?id=129438
4311
4312         Reviewed by Simon Fraser.
4313
4314         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
4315         offscreen window. It makes testing subpixel rendering and positioning possible.
4316
4317         Both the offscreen window's and WebKit's scaling are set accordingly.
4318
4319         * DumpRenderTree/mac/DumpRenderTree.mm:
4320         (createWebViewAndOffscreenWindow): cleanup
4321         (destroyWebViewAndOffscreenWindow): cleanup
4322         (dumpRenderTree):
4323         (changeWindowScaleIfNeeded):
4324         (runTest):
4325         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
4326         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
4327         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
4328