Unreviewed, rolling out r211873.
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-08  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r211873.
4         https://bugs.webkit.org/show_bug.cgi?id=168001
5
6         It's in jhbuild for consistent layout tests (Requested by
7         mcatanzaro on #webkit).
8
9         Reverted changeset:
10
11         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
12         https://bugs.webkit.org/show_bug.cgi?id=167993
13         http://trac.webkit.org/changeset/211873
14
15 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
16
17         [GTK] Add icu packages to Tools/gtk/install-dependencies
18         https://bugs.webkit.org/show_bug.cgi?id=167993
19
20         Reviewed by Michael Catanzaro.
21
22         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
23         depending in the GNU/Linux distribution)
24
25 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
26
27         Update flakiness dashboard configuration.
28         https://bugs.webkit.org/show_bug.cgi?id=167957
29
30         Reviewed by Alexey Proskuryakov.
31
32         * TestResultServer/static-dashboards/builders.jsonp:
33
34 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
35
36         Replace a bot that has an incorrect configuration.
37         https://bugs.webkit.org/show_bug.cgi?id=167747
38
39         Rubber-stamped by Alexey Proskuryakov.
40
41         * BuildSlaveSupport/build.webkit.org-config/config.json:
42
43 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
44
45         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
46         https://bugs.webkit.org/show_bug.cgi?id=167927
47
48         Reviewed by Brent Fulgham.
49
50         Enable ComplexTextController API tests on the Win and GTK ports.
51
52         * TestWebKitAPI/PlatformGTK.cmake:
53         * TestWebKitAPI/PlatformWin.cmake:
54
55 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
56
57         File index appended to previous file in svn-create-patch with SVN 1.9
58         https://bugs.webkit.org/show_bug.cgi?id=167903
59         <rdar://problem/30387395>
60
61         Reviewed by Daniel Bates.
62
63         * Scripts/VCSUtils.pm:
64         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
65         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
66         trailing newline character from the expected result before comparing it to the actual result.
67
68 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
69
70         [webkitdirs] remove unused host_processor variable in determineArchitecture()
71         https://bugs.webkit.org/show_bug.cgi?id=167936
72
73         Reviewed by Michael Catanzaro.
74
75         * Scripts/webkitdirs.pm:
76         (determineArchitecture):
77         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
78         since r195083.
79
80 2017-02-07  Youenn Fablet  <youenn@apple.com>
81
82         Use a JSON file to define which WPT files/folders to import
83         https://bugs.webkit.org/show_bug.cgi?id=167923
84
85         Reviewed by Alex Christensen.
86
87         * Scripts/webkitpy/w3c/test_downloader.py:
88         (TestDownloader.__init__):
89         (TestDownloader._init_paths_from_expectations):
90         * Scripts/webkitpy/w3c/test_importer.py:
91         (parse_args):
92         * Scripts/webkitpy/w3c/test_importer_unittest.py:
93
94 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
95
96         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
97         https://bugs.webkit.org/show_bug.cgi?id=167916
98
99         Reviewed by Carlos Garcia Campos.
100
101         URL of mesa-11.0.6.tar.xz has been moved.
102
103         * gtk/jhbuild.modules: Fix the module path.
104
105 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
106
107         Static Analyzer: Address some leaks in MiniBrowser
108         https://bugs.webkit.org/show_bug.cgi?id=167897
109
110         Reviewed by Alexey Proskuryakov.
111
112         * MiniBrowser/mac/BrowserWindowController.m:
113         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
114         * MiniBrowser/mac/ExtensionManagerWindowController.m:
115         (-[ExtensionManagerWindowController add:]):
116         (-[ExtensionManagerWindowController remove:]):
117         * MiniBrowser/mac/SettingsController.m:
118         (-[SettingsController _populateMenu]):
119         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
120         Address obvious leaks caught by the static analyzer.
121
122 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
123
124         Migrate ComplexTextController to use platform-independent types
125         https://bugs.webkit.org/show_bug.cgi?id=167833
126
127         Reviewed by Brent Fulgham.
128
129         Migrate tests away from platform-dependent types.
130
131         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
132         (TestWebKitAPI::TEST_F):
133
134 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
135
136         Correct File Path Handling in SecurityOrigin and FileSystem
137         https://bugs.webkit.org/show_bug.cgi?id=167894
138         <rdar://problem/30380080>
139
140         Reviewed by Alexey Proskuryakov.
141
142         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
143         and perform same-volume checks using filesystem-compatible paths.        
144         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
145         filesystem paths, and perform validation of same-volume checks.
146         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
147         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
148         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
149         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
150
151 2017-02-06  Jer Noble  <jer.noble@apple.com>
152
153         Playback stalls when a SourceBuffer append causes frame eviction
154         https://bugs.webkit.org/show_bug.cgi?id=167834
155
156         Reviewed by Eric Carlson.
157
158         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
159         for the WTF::MediaTime class.
160
161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
162         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
163         (TestWebKitAPI::TEST):
164         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
165         (WTF::operator<<):
166         (TestWebKitAPI::TestSample::create):
167         (TestWebKitAPI::TestSample::TestSample):
168         (TestWebKitAPI::TEST_F):
169
170 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
171
172         Change capitalization in platform name after r211735.
173
174         Unreviewed dashboard fix.
175
176         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
177         (WebKitBuildbot):
178
179 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
180
181         Move the Leaks bot to Sierra
182         https://bugs.webkit.org/show_bug.cgi?id=167886
183
184         Reviewed by Daniel Bates.
185
186         * BuildSlaveSupport/build.webkit.org-config/config.json:
187         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
188         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
189         (LeaksViewer._displayURLPrompt):
190         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
191         (WebKitBuildbot):
192
193 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
194
195         Prevent app crash on launch during simctl install workaround
196         https://bugs.webkit.org/show_bug.cgi?id=167685
197
198         Reviewed by Daniel Bates.
199
200         * Scripts/webkitpy/port/simulator_process.py:
201         (SimulatorProcess.__init__): Pass environment to install.
202         * Scripts/webkitpy/xcode/simulator.py:
203         (Device.install_app): Accept environment, pass environment to launch.
204
205 2017-02-06  Alex Christensen  <achristensen@webkit.org>
206
207         Rebase API tests after r211638
208         https://bugs.webkit.org/show_bug.cgi?id=167779
209
210         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
211         (TestWebKitAPI::TEST_F):
212         URLs with non-special schemes and characters like % in the host now fail to parse,
213         more like their special counterparts and according to spec.
214
215 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
216
217         Unreviewed trivial fix after r211697.
218         https://bugs.webkit.org/show_bug.cgi?id=167863
219
220         * Scripts/run-javascriptcore-tests:
221         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
222
223 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
224
225         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
226         https://bugs.webkit.org/show_bug.cgi?id=167850
227
228         Reviewed by Tim Horton.
229
230         * DumpRenderTree/TestRunner.cpp:
231         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
232
233 2017-02-04  Andreas Kling  <akling@apple.com>
234
235         Plug some leaks in TestController and UIScriptContext.
236         <https://webkit.org/b/167839>
237
238         Reviewed by Alexey Proskuryakov.
239
240         Fix a couple of the leaks seen on the leaks bot.
241
242         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
243         (UIScriptContext::runUIScript):
244         * WebKitTestRunner/TestController.cpp:
245         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
246         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
247
248 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
249
250         WK1 mouse events are missing movementX and movementY for pointerlock.
251         https://bugs.webkit.org/show_bug.cgi?id=167775
252         rdar://problem/30343810
253
254         Reviewed by Alexey Proskuryakov.
255
256         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
257
258         * DumpRenderTree/mac/EventSendingController.mm:
259         (-[EventSendingController mouseMoveToX:Y:]):
260         * WebKitTestRunner/mac/EventSenderProxy.mm:
261         (WTR::EventSenderProxy::mouseMoveTo):
262
263 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
264
265         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
266         https://bugs.webkit.org/show_bug.cgi?id=167774
267
268         Reviewed by Tim Horton.
269
270         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
271         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
272         web process are async, so the callback fires after the web process gets the new state.
273
274         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
275         (WTR::UIScriptController::removeViewFromWindow):
276         (WTR::UIScriptController::addViewToWindow):
277         * DumpRenderTree/mac/DumpRenderTree.mm:
278         (createWebViewAndOffscreenWindow):
279         (resetWebViewToConsistentStateBeforeTesting):
280         * DumpRenderTree/mac/DumpRenderTreeMac.h:
281         * DumpRenderTree/mac/UIScriptControllerMac.mm:
282         (WTR::UIScriptController::removeViewFromWindow):
283         (WTR::UIScriptController::addViewToWindow):
284         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
285         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
286         (WTR::UIScriptController::removeViewFromWindow):
287         (WTR::UIScriptController::addViewToWindow):
288         * TestRunnerShared/UIScriptContext/UIScriptController.h:
289         * WebKitTestRunner/PlatformWebView.h:
290         * WebKitTestRunner/TestController.cpp:
291         (WTR::TestController::resetStateToConsistentValues):
292         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
293         (WTR::PlatformWebView::removeFromWindow):
294         (WTR::PlatformWebView::addToWindow):
295         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
296         (WTR::UIScriptController::removeViewFromWindow):
297         (WTR::UIScriptController::addViewToWindow):
298         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
299         (WTR::PlatformWebView::removeFromWindow):
300         (WTR::PlatformWebView::addToWindow):
301         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
302         (WTR::UIScriptController::removeViewFromWindow):
303         (WTR::UIScriptController::addViewToWindow):
304
305 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
306
307         Remove check for SkipSafariExecutableEntitlementChecks
308         https://bugs.webkit.org/show_bug.cgi?id=167762
309
310         Reviewed by Dan Bernstein.
311
312         Follow-up fix: don't break internal behavior.
313
314         * Scripts/webkitdirs.pm:
315         (safariPath):
316         (executableHasEntitlements): Deleted.
317         (safariPathFromSafariBundle): Deleted.
318         (installedSafariPath): Deleted.
319
320 2017-02-03  Daniel Bates  <dabates@apple.com>
321
322         [Mac][WK2] Add SPI to override the Content Security Policy of a page
323         https://bugs.webkit.org/show_bug.cgi?id=167810
324         <rdar://problem/30102568>
325
326         Reviewed by Anders Carlsson.
327
328         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
329
330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
331         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
332         (TEST):
333         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
334         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
335         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
336         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
337
338 2017-02-02  Alex Christensen  <achristensen@webkit.org>
339
340         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
341         https://bugs.webkit.org/show_bug.cgi?id=167773
342         <rdar://problem/30221102>
343
344         Reviewed by Ryosuke Niwa.
345
346         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
347         (TestWebKitAPI::TEST_F):
348
349 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
350
351         Remove check for SkipSafariExecutableEntitlementChecks
352         https://bugs.webkit.org/show_bug.cgi?id=167762
353         rdar://problem/22480673
354
355         Reviewed by Dan Bernstein.
356
357         * Scripts/webkitdirs.pm:
358         (safariPathFromSafariBundle):
359         (skipSafariExecutableEntitlementChecks): Deleted.
360
361 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
362
363         Undefined subroutine in svn-create-patch
364         https://bugs.webkit.org/show_bug.cgi?id=167742
365
366         Unreviewed build-fix after r211543.
367
368         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
369
370 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
371
372         Unreviewed. Fix jhbuild dependencies build.
373
374         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
375         Patch updated.
376
377 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
378
379         [EME][GStreamer] Fixed decryptor selection
380         https://bugs.webkit.org/show_bug.cgi?id=167588
381
382         Reviewed by Žan Doberšek.
383
384         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
385
386         * gtk/jhbuild.modules: Added patches to gstreamer and
387         gst-plugins-good packages.
388         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
389         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
390
391 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
392
393         Make run-benchmark script supports 'config' key in test plan.
394         https://bugs.webkit.org/show_bug.cgi?id=167715
395
396         Reviewed by Ryosuke Niwa.
397
398         Add support for 'config' key in test paln.
399         'config' key is a dictionary that specifies environment configurations while test is running.
400         Specifies orientation to be portrait in MotionMark benchmark.
401
402         * Scripts/webkitpy/benchmark_runner/README.md:
403         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
404         (BenchmarkRunner.__init__):
405         (BenchmarkRunner._run_benchmark):
406         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
407         (BrowserDriver.prepare_env):
408         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
409         (LinuxBrowserDriver.prepare_env):
410         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
411         (OSXBrowserDriver.prepare_env):
412         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
413         (OSXSafariDriver.prepare_env):
414         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
415
416 2017-02-01  Daniel Bates  <dabates@apple.com>
417
418         REGRESSION (r210820): svn-create-patch does not emit property change only diff
419         https://bugs.webkit.org/show_bug.cgi?id=167169
420
421         Reviewed by David Kilzer.
422
423         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
424         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
425         header from the output of "svn diff" on a file that was copied or moved.
426
427         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
428         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
429         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
430         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
431         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
432         of a file with only a property change also does not contain any chunk range lines. Therefore
433         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
434         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
435         we should directly test for the presence of a leading SVN diff header with an empty body and
436         remove such lines from the diff.
437
438         * Scripts/VCSUtils.pm:
439         (fixSVNPatchForAdditionWithHistory): Added.
440         * Scripts/svn-create-patch:
441         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
442         we have a non empty patch for an added file with history (i.e. a copied or moved file).
443         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
444
445 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
446
447         [Mac] Update CARingBuffer class
448         https://bugs.webkit.org/show_bug.cgi?id=167656
449
450         Reviewed by Jer Noble.
451
452         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
453         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
454         (TestWebKitAPI::CARingBufferTest::SetUp):
455         (TestWebKitAPI::CARingBufferTest::setup):
456         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
457         (TestWebKitAPI::CARingBufferTest::description):
458         (TestWebKitAPI::CARingBufferTest::bufferList):
459         (TestWebKitAPI::CARingBufferTest::ringBuffer):
460         (TestWebKitAPI::CARingBufferTest::capacity):
461         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
462         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
463         (TestWebKitAPI::TEST_F):
464         (TestWebKitAPI::MixingTest::run):
465
466 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
467
468         [Mac] TestWebKitAPI includes system frameworks incorrectly
469         https://bugs.webkit.org/show_bug.cgi?id=167703
470         rdar://problem/30301498
471
472         Reviewed by Ryosuke Niwa.
473
474         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
475         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
476
477         Also, reduced the number of subframework search paths, looks like we only need one now.
478
479         * TestWebKitAPI/Configurations/Base.xcconfig:
480
481 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
482
483         Correct "filesHaveSameVolume" predicate
484         https://bugs.webkit.org/show_bug.cgi?id=167696
485         <rdar://problem/30298722>
486
487         Reviewed by David Kilzer.
488
489         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
490         percent-escaped path inputs.
491
492         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
493         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
494         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
495         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
496         (TestWebKitAPI::TEST_F):
497
498 2017-02-01  Tomas Popela  <tpopela@redhat.com>
499
500         Unreviewed. Fix coding style in MiniBrowser
501
502         * MiniBrowser/gtk/BrowserWindow.c:
503         (editingCommandCallback):
504         (insertImageCommandCallback):
505         (insertLinkCommandCallback):
506
507 2017-02-01  Tomas Popela  <tpopela@redhat.com>
508
509         [GTK] Add an API to add a custom tab into the print dialog
510         https://bugs.webkit.org/show_bug.cgi?id=151998
511
512         Reviewed by Carlos Garcia Campos.
513
514         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
515         that is testing a newly added API.
516
517         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
518         (testPrintCustomWidget):
519         (beforeAll):
520
521 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
522
523         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
524         https://bugs.webkit.org/show_bug.cgi?id=166529
525
526         Reviewed by Xabier Rodriguez-Calvar.
527
528         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
529         New patch version accepted in GStreamer upstream.
530
531 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
532
533         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
534         https://bugs.webkit.org/show_bug.cgi?id=167498
535
536         Reviewed by Carlos Garcia Campos.
537
538         Depending on the distro version you can need either libxfont1-dev
539         or libfont-dev to build with jhbuild.
540
541         * gtk/install-dependencies:
542
543 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
544
545         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
546         https://bugs.webkit.org/show_bug.cgi?id=167594
547
548         Unreviewed test gardening.
549
550         Disabling this test while we investigate the cause of a timeout on ios-simulator.
551
552         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
553         (TEST):
554
555 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
556
557         Move slow-running microbenchmarks out of JSTests/microbenchmarks
558         https://bugs.webkit.org/show_bug.cgi?id=167676
559
560         Reviewed by Saam Barati.
561
562         * Scripts/run-javascriptcore-tests:
563         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
564
565 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
566
567         Make Dump Render Tree not crash
568         https://bugs.webkit.org/show_bug.cgi?id=167667
569
570         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
571         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
572         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
573         This does not fix any tests, it just fixes the crash.
574         
575         Reviewed by Simon Fraser.
576
577         * DumpRenderTree/TestRunner.cpp:
578         (TestRunner::callUIScriptCallback):
579
580 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
581
582         Workaround for simctl install failing to report install failure
583         https://bugs.webkit.org/show_bug.cgi?id=167654
584
585         Reviewed by Daniel Bates.
586
587         simctl install will sometimes report success even though install has failed.
588         To workaround this bug, we attempt an app launch after install to ensure
589         install has succeeded.
590
591         * Scripts/webkitpy/xcode/simulator.py:
592         (Device.install_app): Attempt app launch after install, retry install if launch fails.
593         (Device.launch_app): Correct comment.
594
595 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
596
597         Unreviewed webkitpy fix after r211405.
598
599         * Scripts/webkitpy/xcode/simulator.py:
600         (Device.launch_app): Remove @staticmethod on _log_debug_error.
601
602 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
603
604         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
605
606         * gtk/manifest.txt.in:
607
608 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
609
610         AX: enable search predication for iOS
611         https://bugs.webkit.org/show_bug.cgi?id=167558
612         <rdar://problem/30251367>
613
614         Reviewed by Joanmarie Diggs.
615
616         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
617         (AccessibilityUIElement::uiElementForSearchPredicate):
618         * DumpRenderTree/mac/AccessibilityCommonMac.h:
619         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
620         (searchPredicateParameterizedAttributeForSearchCriteria):
621         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
622         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
623         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
624         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
625         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
626         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
627         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
628         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
629         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
630         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
631         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
632
633 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
634
635         Workaround for simctl launch bug
636         https://bugs.webkit.org/show_bug.cgi?id=167613
637
638         Reviewed by Daniel Bates.
639
640         simctl launch will sometimes fail because of a race condition when many
641         simulators are being run simultaneously. These failures will always have
642         an exit code of 1. This change attempts to launch an app multiple times
643         before reporting a failure to workaround this bug.
644
645         * Scripts/webkitpy/xcode/simulator.py:
646         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
647
648 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
649
650         Commit queue fails to look at real name aliases for the reviewer
651         https://bugs.webkit.org/show_bug.cgi?id=167422
652
653         Reviewed by Joseph Pecoraro.
654
655         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
656         (test_has_valid_reviewer): Added tests.
657
658         * Scripts/webkitpy/common/config/committers.py:
659         (CommitterList._name_to_contributor_map):
660         Made _name_to_contributor_map include alias names.
661
662         * Scripts/webkitpy/common/config/committers_unittest.py:
663         (CommittersTest.test_contributors_by_fuzzy_match):
664         Removed subtests that are now obsolete, as these matches are strict. It is not
665         obvious if distance based fuzzy matching for names is useful at all, but we can
666         look into that some other time.
667
668 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
669
670         QueueStatusServer should have an explicit timeout for _fetch_url
671         https://bugs.webkit.org/show_bug.cgi?id=167467
672
673         Reviewed by Alexey Proskuryakov.
674
675         * Scripts/webkitpy/common/net/statusserver.py:
676         (StatusServer._fetch_url): Add an explicit timeout of 300s.
677
678 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
679
680         Add support for Trac instances that host multiple projects.
681         https://bugs.webkit.org/show_bug.cgi?id=167524
682
683         Reviewed by Alexey Proskuryakov.
684
685         When multiple projects are hosted on a single Trac instance, the current
686         behavior will retrieve changesets from all tracked projects.
687         This patch teaches Trac.js to get project-specific changesets from Trac.
688         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
689         when querying the Trac timeline.
690
691         To tell Trac to be aware of multi-project instances we leverage the 
692         `options` parameter when creating a new instance: 
693
694             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
695
696         If this option is not provided, the original behaviour will prevail.
697         Additionally, add corresponding tests.
698
699         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
700         (Trac): Reason about new optional parameter 'projectIdentifier'.
701         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
702         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
703         replace default parameter `changeset=on` with `repo-projectname=on`.
704         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
705         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
706         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
707         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
708         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
709         Add the following tests:
710             test("revisionURL")
711             test("revisionURL with Trac Identifier")
712             test("_xmlTimelineURL")
713             test("_xmlTimelineURL with Trac Identifier")
714         (this.view._latestProductiveIteration): Fix missing ';'.
715
716 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
717
718         Correct spacing regression on inter-element complex path shaping on some fonts
719         https://bugs.webkit.org/show_bug.cgi?id=166013
720
721         Reviewed by Simon Fraser.
722
723         Unskip existing tests and make some new tests:
724         - Testing complex text with no origins
725         - Testing initial expansions
726         - Testing the sign of vertical advances
727
728         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
729         (TestWebKitAPI::TEST_F):
730
731 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
732
733         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
734         https://bugs.webkit.org/show_bug.cgi?id=167596
735
736         Reviewed by Daniel Bates.
737
738         We avoid needing a thin directory by invoking the zip program with
739         the list of directories from the build directory to be zipped,
740         and by using the zip feature to exclude files matching a pattern.
741
742         * BuildSlaveSupport/built-product-archive:
743         (copyBuildFiles):
744         (createZipFromList):
745         (archiveBuiltProduct):
746
747 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
748
749         Use simctl instead of LayoutTestRelay
750         https://bugs.webkit.org/show_bug.cgi?id=165927
751
752         Reviewed by Daniel Bates.
753
754         Part 1
755
756         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
757         simulators through simctl (iOS 10 and later), use this functionality instead.
758
759         * Scripts/webkitpy/port/base.py:
760         (Port.__init__): Added _test_runner_process_constructor.
761         * Scripts/webkitpy/port/darwin.py:
762         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
763         * Scripts/webkitpy/port/driver.py:
764         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
765         (IOSSimulatorDriver): Deleted.
766         * Scripts/webkitpy/port/driver_unittest.py:
767         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
768         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
769         (DriverTest.test_start_actually_starts): Ditto.
770         * Scripts/webkitpy/port/ios.py:
771         (IOSSimulatorPort): Remove relay_name.
772         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
773         (IOSSimulatorPort._create_simulators): Formatting change.
774         (IOSSimulatorPort.relay_path): Deleted.
775         (IOSSimulatorPort._check_relay): Deleted.
776         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
777         (IOSSimulatorPort._build_relay): Deleted.
778         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
779         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
780         * Scripts/webkitpy/port/ios_unittest.py:
781         (iosTest.test_32bit): Update test.
782         (iosTest.test_64bit): Update test.
783         * Scripts/webkitpy/port/server_process.py:
784         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
785         (ServerProcess._set_file_nonblocking): Added to share common code.
786         * Scripts/webkitpy/port/server_process_mock.py:
787         (MockServerProcess.__init__): Added argument worker_number.
788         * Scripts/webkitpy/port/simulator_process.py: Added.
789         (SimulatorProcess): Added.
790         (SimulatorProcess.Popen): Added.
791         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
792         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
793         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
794         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
795         (SimulatorProcess._reset): Added. Unlink fifos.
796         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
797         (SimulatorProcess._kill): Added. Shutdown app on simulator.
798         * Scripts/webkitpy/xcode/simulator.py:
799         (Device.__init__): Accept host to run install/launch/terminate.
800         (Device.install_app): Install app to target Device.
801         (Device.launch_app): Launch app on target Device.
802         (Device.terminate_app): Shutdown app on target Device.
803         (Simulator._parse_devices): Pass host to Device.
804
805 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
806
807         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
808         https://bugs.webkit.org/show_bug.cgi?id=167411
809
810         Reviewed by Michael Catanzaro.
811
812         Disable the ARM iwMMXt fast path for pixman, because it triggers
813         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
814
815         * gtk/jhbuild.modules:
816
817 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
818
819         [GTK] Add API to handle the accelerated compositing policy
820         https://bugs.webkit.org/show_bug.cgi?id=167509
821
822         Reviewed by Michael Catanzaro.
823
824         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
825         as a special case. Also add test cases to the get/set API.
826
827         * MiniBrowser/gtk/BrowserSettingsDialog.c:
828         (hardwareAccelerationPolicyToString):
829         (stringToHardwareAccelerationPolicy):
830         (cellRendererChanged):
831         (browserSettingsDialogConstructed):
832         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
833         (testWebKitSettings):
834
835 2017-01-29  Andy Estes  <aestes@apple.com>
836
837         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
838         https://bugs.webkit.org/show_bug.cgi?id=167563
839         <rdar://problem/30253207>
840
841         Reviewed by Andreas Kling.
842
843         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
844         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
845         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
846         (runTest):
847         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
848         (TEST):
849
850 2017-01-29  Dan Bernstein  <mitz@apple.com>
851
852         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
853         https://bugs.webkit.org/show_bug.cgi?id=167565
854
855         Reviewed by Sam Weinig.
856
857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
858         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
859         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
860         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
861         (TEST):
862         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
863         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
864         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
865         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
866
867 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
868
869         Add Link Preload as an off-by-default experimental feature menu item.
870         https://bugs.webkit.org/show_bug.cgi?id=167201
871
872         Reviewed by Ryosuke Niwa.
873
874         * DumpRenderTree/mac/DumpRenderTree.mm:
875         (resetWebPreferencesToConsistentValues):
876         * DumpRenderTree/win/DumpRenderTree.cpp:
877         (resetWebPreferencesToConsistentValues):
878
879 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
880
881         Add User Timing Experimental Feature
882         https://bugs.webkit.org/show_bug.cgi?id=167542
883         <rdar://problem/22746307>
884
885         Reviewed by Ryosuke Niwa.
886
887         * DumpRenderTree/mac/DumpRenderTree.mm:
888         (enableExperimentalFeatures):
889         (resetWebPreferencesToConsistentValues):
890         * DumpRenderTree/win/DumpRenderTree.cpp:
891         (enableExperimentalFeatures):
892
893 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
894
895         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
896         https://bugs.webkit.org/show_bug.cgi?id=167519
897
898         Reviewed by Ryosuke Niwa.
899
900         * QueueStatusServer/templates/statusbubble.html:
901         To measure the bubbleContainer's width, it must not be wrapping based
902         on its parent container. So when measuring the width temporarily set
903         the parent to a very large width so as to not artificially wrap us.
904         Restore the parent's width after measuring.
905
906 2017-01-27  Andy Estes  <aestes@apple.com>
907
908         [iOS] Add a test for _WKNSFileManagerExtras
909         https://bugs.webkit.org/show_bug.cgi?id=167478
910
911         Reviewed by Andreas Kling.
912
913         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
914         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
915         (expectAttributes):
916         (TEST):
917
918 2017-01-27  Keith Miller  <keith_miller@apple.com>
919
920         run-benchmarks should make sure it passes the test url to the right application
921         https://bugs.webkit.org/show_bug.cgi?id=167533
922
923         Reviewed by Joseph Pecoraro.
924
925         This fixes an issue when trying to run-benchmark script with the
926         system default browser set to STP. Previously, it would run
927         the test in STP rather than the provided build. Now, it should run
928         in the provided build.
929
930         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
931         (OSXSafariDriver.launch_url):
932
933 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
934
935         [Cocoa] Prepare ComplexTextController for unit testing
936         https://bugs.webkit.org/show_bug.cgi?id=167493
937
938         Reviewed by Simon Fraser.
939
940         Addressing post-review comments from Simon Fraser.
941
942         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
943         (TestWebKitAPI::TEST_F):
944
945 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
946
947         [Cocoa] Prepare ComplexTextController for unit testing
948         https://bugs.webkit.org/show_bug.cgi?id=167493
949
950         Reviewed by Dean Jackson.
951
952         Create four unit tests.
953
954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
955         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
956         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
957         (TestWebKitAPI::TEST_F):
958
959 2017-01-26  Chris Dumez  <cdumez@apple.com>
960
961         Crash when navigating back to a page in PacheCache when one of its frames has been removed
962         https://bugs.webkit.org/show_bug.cgi?id=167421
963         <rdar://problem/30188490>
964
965         Reviewed by Darin Adler.
966
967         Add a new setting allowing layout tests to enable PageCache in a window
968         that has an opener, for convenience.
969
970         * DumpRenderTree/mac/DumpRenderTree.mm:
971         (resetWebPreferencesToConsistentValues):
972         * DumpRenderTree/win/DumpRenderTree.cpp:
973         (resetWebPreferencesToConsistentValues):
974         * WebKitTestRunner/TestController.cpp:
975         (WTR::TestController::resetPreferencesToConsistentValues):
976
977 2017-01-26  Keith Miller  <keith_miller@apple.com>
978
979         classInfo should take a VM so it is not materialized from the object on each call
980         https://bugs.webkit.org/show_bug.cgi?id=167424
981
982         Rubber Stamped by Michael Saboff.
983
984         Previously, classInfo() would get the VM from the target's
985         MarkedBlock.  Most callers already have a VM on hand, so it is
986         wasteful to compute the VM from the marked block every time. This
987         patch refactors some of the most common callers of classInfo(),
988         jsDynamicCast and inherits to take a VM as well.
989
990         * DumpRenderTree/TestRunner.cpp:
991         (setAudioResultCallback):
992
993 2017-01-26  Jer Noble  <jer.noble@apple.com>
994
995         Autoplay muted videos stop playback of any streaming app in the background
996         https://bugs.webkit.org/show_bug.cgi?id=163993
997         <rdar://problem/29020431>
998
999         Reviewed by Eric Carlson.
1000
1001         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1002         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1003         (TestWebKitAPI::TEST):
1004         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
1005
1006 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
1007
1008         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
1009         https://bugs.webkit.org/show_bug.cgi?id=167466
1010
1011         Unreviewed test gardening.
1012
1013         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1014         (TEST):
1015
1016 2017-01-26  Matt Rajca  <mrajca@apple.com>
1017
1018         Notify clients when the user plays media otherwise prevented from autoplaying
1019         https://bugs.webkit.org/show_bug.cgi?id=167390
1020
1021         Reviewed by Alex Christensen.
1022
1023         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1024         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1025         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1026         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1027         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1028         (TEST):
1029         * TestWebKitAPI/cocoa/TestWKWebView.h:
1030         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1031         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1032         (-[TestWKWebView waitForLoad]):
1033         (-[TestWKWebView mouseUpAtPoint:]):
1034         * WebKitTestRunner/TestController.cpp:
1035         (WTR::TestController::createOtherPage):
1036         (WTR::TestController::createWebViewWithOptions):
1037
1038 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1039
1040         Crash when setting custom scale factor.
1041         https://bugs.webkit.org/show_bug.cgi?id=167369
1042
1043         Reviewed by Sam Weinig.
1044
1045         Added API test.
1046
1047         * TestWebKitAPI/PlatformWin.cmake:
1048         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1049         (TestWebKitAPI::WebKitCreateInstance):
1050         (TestWebKitAPI::ScaleWebView::SetUp):
1051         (TestWebKitAPI::ScaleWebView::TearDown):
1052         (TestWebKitAPI::TEST_F):
1053
1054 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1055
1056         run-benchmark nests MotionMark results by the suite name twice
1057         https://bugs.webkit.org/show_bug.cgi?id=164948
1058
1059         Reviewed by Said Abou-Hallawa.
1060
1061         Use a single level MotionMark now that this is the name of the benchmark,
1062         and we no longer have tests that aren't part of the MotionMark suite.
1063
1064         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1065
1066 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1067
1068         Unreviewed, rolling out r211193.
1069
1070         This change broke internal builds.
1071
1072         Reverted changeset:
1073
1074         "Notify clients when the user plays media otherwise prevented
1075         from autoplaying"
1076         https://bugs.webkit.org/show_bug.cgi?id=167390
1077         http://trac.webkit.org/changeset/211193
1078
1079 2017-01-25  Matt Rajca  <mrajca@apple.com>
1080
1081         Notify clients when the user plays media otherwise prevented from autoplaying
1082         https://bugs.webkit.org/show_bug.cgi?id=167390
1083
1084         Reviewed by Alex Christensen.
1085
1086         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1087         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1088         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1089         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1090         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1091         (TEST):
1092         * TestWebKitAPI/cocoa/TestWKWebView.h:
1093         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1094         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1095         (-[TestWKWebView waitForLoad]):
1096         (-[TestWKWebView mouseUpAtPoint:]):
1097         * WebKitTestRunner/TestController.cpp:
1098         (WTR::TestController::createOtherPage):
1099         (WTR::TestController::createWebViewWithOptions):
1100
1101 2017-01-25  Matt Rajca  <mrajca@apple.com>
1102
1103         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1104         https://bugs.webkit.org/show_bug.cgi?id=167385
1105
1106         Reviewed by Alex Christensen.
1107
1108         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1109         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1110         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1111         (TEST): Allow inline (rather than full screen) media playback on iOS.
1112
1113 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1114
1115         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1116         https://bugs.webkit.org/show_bug.cgi?id=167414
1117
1118         Reviewed by Michael Catanzaro.
1119
1120         Add a test case to check ephemeral web views don't write favicons to the database.
1121
1122         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1123         (ephemeralViewLoadChanged):
1124         (testPrivateBrowsing):
1125         (testFaviconDatabase):
1126
1127 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1128
1129         [GTK] Add a private browsing mode to MiniBrowser
1130         https://bugs.webkit.org/show_bug.cgi?id=167413
1131
1132         Reviewed by Michael Catanzaro.
1133
1134         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1135         private windows, even on non-private instances.
1136
1137         * MiniBrowser/gtk/BrowserWindow.c:
1138         (webViewTitleChanged): Add [Private] to title window for private windows.
1139         (webViewCreate): Pass web context to browser_window_new.
1140         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1141         (browserWindowFinalize): Disconnect web context signal handlers.
1142         (browser_window_init): Add shortcut for opening private window.
1143         (browser_window_new): It now receives the context and connect to download-started here.
1144         (browser_window_get_web_context): Return the context.
1145         * MiniBrowser/gtk/BrowserWindow.h:
1146         * MiniBrowser/gtk/main.c:
1147         (createBrowserTab): Create the web view for the window web context.
1148         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1149         (aboutDataHandleRequest): Ditto.
1150         (aboutURISchemeRequestCallback): Ditto.
1151         (main): Create ephemeral web context if private command line option is used.
1152
1153 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1154
1155         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1156         https://bugs.webkit.org/show_bug.cgi?id=167409
1157
1158         Reviewed by Antti Koivisto.
1159
1160         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1161         as well as tests for the newly added matchingElementInFlatTree.
1162
1163         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1164         (TestWebKitAPI::runJavaScriptAlert):
1165         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1166         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1167         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1168
1169 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1170
1171         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1172         https://bugs.webkit.org/show_bug.cgi?id=167370
1173
1174         Reviewed by Michael Catanzaro.
1175
1176         Add several test cases of ephemeral web views.
1177
1178         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1179         (testWebViewAuthenticationStorage):
1180         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1181         (ephemeralViewloadChanged):
1182         (testCookieManagerEphemeral):
1183         (beforeAll):
1184         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1185         (testWebKitSettings):
1186         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1187         (testWebContextEphemeral):
1188         (ephemeralViewloadChanged):
1189         (testWebContextProxySettings):
1190         (beforeAll):
1191         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1192         (ephemeralViewloadChanged):
1193         (testWebViewEphemeral):
1194         (beforeAll):
1195         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1196         (ephemeralViewloadChanged):
1197         (testWebsiteDataEphemeral):
1198         (beforeAll):
1199
1200 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1201
1202         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1203         https://bugs.webkit.org/show_bug.cgi?id=167402
1204
1205         Reviewed by Ryosuke Niwa.
1206
1207         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1208         (TestWebKitAPI::TEST):
1209
1210 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1211
1212         Add simple line layout toggle to MiniBrowser
1213         https://bugs.webkit.org/show_bug.cgi?id=167405
1214
1215         Reviewed by Andreas Kling.
1216
1217         * MiniBrowser/mac/SettingsController.h:
1218         * MiniBrowser/mac/SettingsController.m:
1219         (-[SettingsController _populateMenu]):
1220         (-[SettingsController validateMenuItem:]):
1221         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1222         (-[SettingsController simpleLineLayoutEnabled]):
1223         * MiniBrowser/mac/WK1BrowserWindowController.m:
1224         (-[WK1BrowserWindowController didChangeSettings]):
1225         * MiniBrowser/mac/WK2BrowserWindowController.m:
1226         (-[WK2BrowserWindowController didChangeSettings]):
1227
1228 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1229
1230         WKR does not include my nick when commit-queue lands my patch
1231         https://bugs.webkit.org/show_bug.cgi?id=167388
1232
1233         Reviewed by Ryosuke Niwa.
1234
1235         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1236         (NewCommitBot._summarize_commit_log):
1237         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1238         Perform nickname insertion before grabbing "Patch by" details.
1239         This way we can include the nickname with the full name.
1240
1241 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1242
1243         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1244         https://bugs.webkit.org/show_bug.cgi?id=167394
1245
1246         Reviewed by Ryosuke Niwa.
1247
1248         * Scripts/webkitperl/FeatureList.pm:
1249         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1250
1251 2017-01-24  Youenn Fablet  <youenn@apple.com>
1252
1253         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1254         https://bugs.webkit.org/show_bug.cgi?id=167353
1255
1256         Reviewed by Alex Christensen.
1257
1258         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1259         (CMakeGenerator.initialize_targets):
1260
1261 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1262
1263         WKR should not confuse Miguel Gomez with Andres Gomez
1264         https://bugs.webkit.org/show_bug.cgi?id=167389
1265
1266         Reviewed by Lucas Forschler.
1267
1268         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1269         "mAndres Gomez". Fix this.
1270
1271         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1272         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1273         space on each side of the email address, so expect both spaces to be there before
1274         considering the email for replacement.
1275         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1276
1277 2017-01-24  Matt Rajca  <mrajca@apple.com>
1278
1279         Pass down website autoplay policies to media elements
1280         https://bugs.webkit.org/show_bug.cgi?id=167355
1281
1282         Reviewed by Alex Christensen.
1283
1284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1285         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1286         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1287         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1288         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1289         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1290         (TEST):
1291
1292 2017-01-24  Nan Wang  <n_wang@apple.com>
1293
1294         AX: Speak Selection does not work in an iframe
1295         https://bugs.webkit.org/show_bug.cgi?id=166794
1296         <rdar://problem/29913013>
1297
1298         Reviewed by Chris Fleizach.
1299
1300         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1301         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1302         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1303         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1304         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1305         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1306         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1307         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1308         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1309         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1310         (-[TestRunnerWKWebView dealloc]):
1311         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1312         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1313         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1314         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1315         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1316
1317 2017-01-24  Daniel Bates  <dabates@apple.com>
1318
1319         StringView.split() should use an iterator design pattern instead of allocating a Vector
1320         https://bugs.webkit.org/show_bug.cgi?id=163225
1321
1322         Reviewed by Darin Adler.
1323
1324         Add unit tests for StringView.split().
1325
1326         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1327         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1328         used in the StringView.split() unit tests.
1329         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1330         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1331         object to a Vector of String objects.
1332         (TestWebKitAPI::TEST): Added the following tests:
1333             - WTF.StringViewSplitEmptyAndNullStrings
1334             - WTF.StringViewSplitBasic
1335             - WTF.StringViewSplitWithConsecutiveSeparators
1336
1337 2017-01-23  Anders Carlsson  <andersca@apple.com>
1338
1339         The Score Esports crashes on launch
1340         https://bugs.webkit.org/show_bug.cgi?id=167338
1341         rdar://problem/29948645
1342
1343         Reviewed by Dan Bernstein.
1344
1345         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1346         (TestWebKitAPI::TEST):
1347         Add a test.
1348
1349 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1350
1351         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1352         https://bugs.webkit.org/show_bug.cgi?id=146589
1353
1354         Reviewed by Michael Catanzaro.
1355
1356         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1357         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1358
1359         * MiniBrowser/gtk/BrowserWindow.c:
1360         (webViewDecidePolicy):
1361         (newTabCallback):
1362         * MiniBrowser/gtk/main.c:
1363         (createBrowserTab):
1364         (aboutDataRequestFree):
1365         (aboutDataRequestNew):
1366         (aboutDataRequestForView):
1367         (websiteDataRemovedCallback):
1368         (websiteDataClearedCallback):
1369         (aboutDataScriptMessageReceivedCallback):
1370         (domainListFree):
1371         (aboutDataFillTable):
1372         (gotWebsiteDataCallback):
1373         (aboutDataHandleRequest):
1374         (aboutURISchemeRequestCallback):
1375         (main):
1376         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1377         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1378         (serverCallback):
1379         (beforeAll):
1380         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
1381         (serverCallback):
1382         (WebsiteDataTest::WebsiteDataTest):
1383         (WebsiteDataTest::~WebsiteDataTest):
1384         (WebsiteDataTest::fetch):
1385         (WebsiteDataTest::remove):
1386         (WebsiteDataTest::clear):
1387         (testWebsiteDataConfiguration):
1388         (testWebsiteDataCache):
1389         (testWebsiteDataStorage):
1390         (testWebsiteDataDatabases):
1391         (testWebsiteDataAppcache):
1392         (beforeAll):
1393         (afterAll):
1394
1395 2017-01-23  Commit Queue  <commit-queue@webkit.org>
1396
1397         Unreviewed, rolling out r211062.
1398         https://bugs.webkit.org/show_bug.cgi?id=167354
1399
1400         broke API tests (Requested by alexchristensen on #webkit).
1401
1402         Reverted changeset:
1403
1404         "Pass down website autoplay policies to media elements"
1405         https://bugs.webkit.org/show_bug.cgi?id=167132
1406         http://trac.webkit.org/changeset/211062
1407
1408 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1409
1410         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
1411         https://bugs.webkit.org/show_bug.cgi?id=167330
1412
1413         Reviewed by Tim Horton.
1414
1415         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1416         (TestWebKitAPI::TEST_F):
1417
1418 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1419
1420         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
1421         https://bugs.webkit.org/show_bug.cgi?id=167317
1422
1423         Reviewed by Sam Weinig.
1424
1425         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1426         (TestWebKitAPI::TEST_F):
1427
1428 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
1429
1430         svn-create-patch should emit properties when files are moved or copied
1431         https://bugs.webkit.org/show_bug.cgi?id=167264
1432
1433         Reviewed by Daniel Bates.
1434
1435         * Scripts/svn-create-patch:
1436         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
1437
1438 2017-01-23  Youenn Fablet  <youenn@apple.com>
1439
1440         [WebRTC] Filter libwebrtc link flags
1441         https://bugs.webkit.org/show_bug.cgi?id=167287
1442
1443         Reviewed by Alex Christensen.
1444
1445         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1446         (CMakeGenerator._compute_link_flags):
1447         (CMakeGenerator._compute_link_flags.keep_flag):
1448         (CMakeGenerator._generate_compile_target_options):
1449
1450 2017-01-23  Youenn Fablet  <youennf@gmail.com>
1451
1452         [WebRTC] Make VP8 optional in libwebrtc
1453         https://bugs.webkit.org/show_bug.cgi?id=167257
1454
1455         Reviewed by Darin Adler.
1456
1457         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1458         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
1459
1460 2017-01-23  Jer Noble  <jer.noble@apple.com>
1461
1462         Video details does not apear and missing scrubber in Control Center
1463         https://bugs.webkit.org/show_bug.cgi?id=167233
1464
1465         Reviewed by Alex Christensen.
1466
1467         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
1468         NowPlayingControlTests for iOS.
1469
1470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1471         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1472         (-[NowPlayingTestWebView setWindowVisible:]):
1473         (TestWebKitAPI::TEST):
1474         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1475         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1476         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1477         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
1478         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
1479         (SOFT_LINK_CLASS):
1480         (-[TestMessageHandler addMessage:withHandler:]):
1481         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1482         (__simulated_forceClickAssociatedEventsMask):
1483         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1484         (-[TestWKWebViewHostWindow isKeyWindow]):
1485         (-[TestWKWebViewHostWindow makeKeyWindow]):
1486         (-[TestWKWebViewHostWindow resignKeyWindow]):
1487         (-[TestWKWebView initWithFrame:]):
1488         (-[TestWKWebView initWithFrame:configuration:]):
1489         (-[TestWKWebView _setUpTestWindow:]):
1490         (-[TestWKWebView performAfterReceivingMessage:action:]):
1491         (-[TestWKWebView loadTestPageNamed:]):
1492         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1493         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1494         (-[TestWKWebView waitForMessage:]):
1495         (-[TestWKWebView performAfterLoading:]):
1496         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1497         (-[TestWKWebView typeCharacter:]):
1498
1499 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1500
1501         Unreviewed. Bring back gtk-doc error messages after r209981.
1502
1503         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
1504         impossible to know what's wrong.
1505
1506         * gtk/gtkdoc.py:
1507         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
1508
1509 2017-01-20  Youenn Fablet  <youennf@gmail.com>
1510
1511         [WebRTC] Update build system to make G711 optional in libwebrtc
1512         https://bugs.webkit.org/show_bug.cgi?id=167256
1513
1514         Reviewed by Alex Christensen.
1515
1516         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1517         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
1518
1519 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1520
1521         Cleanup RuntimeEnabledFeatures
1522         https://bugs.webkit.org/show_bug.cgi?id=167228
1523
1524         Reviewed by Simon Fraser.
1525
1526         * DumpRenderTree/mac/DumpRenderTree.mm:
1527         (enableExperimentalFeatures):
1528         (resetWebPreferencesToConsistentValues):
1529         (setWebPreferencesForTestOptions):
1530         (resetWebViewToConsistentStateBeforeTesting):
1531         * DumpRenderTree/win/DumpRenderTree.cpp:
1532         (enableExperimentalFeatures):
1533         (resetWebPreferencesToConsistentValues):
1534         More closely match WebKitTestRunner initialization of preferences
1535         for experimental features.
1536
1537 2017-01-20  Alex Christensen  <achristensen@webkit.org>
1538
1539         Build Fix for Windows DumpRenderTree after r210976
1540         https://bugs.webkit.org/show_bug.cgi?id=167115
1541
1542         * DumpRenderTree/win/DumpRenderTree.cpp:
1543         (resetWebPreferencesToConsistentValues):
1544
1545 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1546
1547         Remove outdated ENABLE(CSP_NEXT) build flag
1548         https://bugs.webkit.org/show_bug.cgi?id=167252
1549
1550         Reviewed by Brent Fulgham.
1551
1552         * Scripts/webkitperl/FeatureList.pm:
1553         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1554
1555 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1556
1557         Build Fix for Windows DumpRenderTree after r210976
1558
1559         * DumpRenderTree/win/DumpRenderTree.cpp:
1560         (resetWebPreferencesToConsistentValues):
1561
1562 2017-01-20  Antoine Quint  <graouts@apple.com>
1563
1564         Web Animations should be off by default and enabled as an experimental feature
1565         https://bugs.webkit.org/show_bug.cgi?id=167115
1566         <rdar://problem/30048963>
1567
1568         Reviewed by Joseph Pecoraro.
1569
1570         Turn Web Animations on in DRT.
1571
1572         * DumpRenderTree/mac/DumpRenderTree.mm:
1573         (resetWebPreferencesToConsistentValues):
1574         * DumpRenderTree/win/DumpRenderTree.cpp:
1575         (resetWebPreferencesToConsistentValues):
1576
1577 2017-01-20  Youenn Fablet  <youenn@apple.com>
1578
1579         [WebRTC] Add libwebrtc build infrastructure
1580         https://bugs.webkit.org/show_bug.cgi?id=167207
1581
1582         Reviewed by Alex Christensen.
1583
1584         Adding a script doing the libwebrtc project json to CMake file conversion.
1585
1586         * Scripts/generate-libwebrtc-cmake: Added.
1587         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
1588         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
1589
1590 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1591
1592         Mini Browser: Show tooltip for Experimental Features
1593         https://bugs.webkit.org/show_bug.cgi?id=167225
1594
1595         Reviewed by Alex Christensen.
1596
1597         * MiniBrowser/mac/SettingsController.m:
1598         (-[SettingsController _populateMenu]):
1599         Include the full details string as a tooltip.
1600
1601 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
1602
1603         [Win] Test output results should not be written twice.
1604         https://bugs.webkit.org/show_bug.cgi?id=167197
1605
1606         Reviewed by Brent Fulgham.
1607
1608         Prevent test output from being written twice by returning early from
1609         the dump() function, if it already has been called.
1610         This patch also adds a missing newline to a test output line. 
1611         
1612         * DumpRenderTree/win/DumpRenderTree.cpp:
1613         (dump):
1614
1615 2017-01-20  Antoine Quint  <graouts@apple.com>
1616
1617         [Modern Media Controls] Turn modern media controls on by default
1618         https://bugs.webkit.org/show_bug.cgi?id=165668
1619
1620         Reviewed by Dean Jackson.
1621
1622         Enabled modern media controls by default in test runners.
1623
1624         * DumpRenderTree/TestOptions.h:
1625         * WebKitTestRunner/TestOptions.h:
1626
1627 2017-01-19  Chris Dumez  <cdumez@apple.com>
1628
1629         iterable<> should be enabled on WK1
1630         https://bugs.webkit.org/show_bug.cgi?id=167221
1631         <rdar://problem/30108531>
1632
1633         Reviewed by Youenn Fablet.
1634
1635         * DumpRenderTree/mac/DumpRenderTree.mm:
1636         (resetWebPreferencesToConsistentValues):
1637         * DumpRenderTree/win/DumpRenderTree.cpp:
1638         (resetWebPreferencesToConsistentValues):
1639         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1640         (WTR::InjectedBundle::beginTesting):
1641         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1642         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
1643         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1644
1645 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
1646
1647         Ensure status server logs go to log file
1648         https://bugs.webkit.org/show_bug.cgi?id=167210
1649
1650         Reviewed by Alexey Proskuryakov.
1651
1652         * Scripts/webkitpy/common/net/statusserver.py:
1653         (StatusServer.next_work_item): Change log level from debug to info in
1654         order to facilitate deubgging issues.
1655         (StatusServer.update_work_items): Same.
1656
1657 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
1658
1659         Additional selection tests and interpolation fix
1660         https://bugs.webkit.org/show_bug.cgi?id=167171
1661
1662         Reviewed by Simon Fraser.
1663
1664         We weren't adding the final event when interpolating event streams.
1665
1666         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1667         (-[HIDEventGenerator interpolatedEvents:]):
1668
1669 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1670
1671         [Cocoa] Variation fonts are erroneously disabled on iOS
1672         https://bugs.webkit.org/show_bug.cgi?id=167172
1673
1674         Reviewed by Simon Fraser.
1675
1676         OpenSource builders don't seem to understand sdk=embedded*.
1677
1678         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1679
1680 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1681
1682         Unreviewed. Fix GTK+ unit tests failing since r210531.
1683
1684         Avoid using paths to files that don't actually exist.
1685
1686         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
1687         (testWebKitConsoleMessageNetworkError):
1688         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1689         (testContextMenuDefaultMenu):
1690         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
1691         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
1692         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
1693
1694 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1695
1696         [GTK] Provide API to set proxy settings
1697         https://bugs.webkit.org/show_bug.cgi?id=128674
1698
1699         Reviewed by Michael Catanzaro.
1700
1701         Add tests for new proxy settings API.
1702
1703         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1704         (serverCallback):
1705         (ProxyTest::ProxyTest):
1706         (ProxyTest::~ProxyTest):
1707         (ProxyTest::loadURIAndGetMainResourceData):
1708         (ProxyTest::proxyServerPortAsString):
1709         (testWebContextProxySettings):
1710         (beforeAll):
1711
1712 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1713
1714         Add back my old email address so old commits will still match it.
1715
1716         * Scripts/webkitpy/common/config/contributors.json:
1717
1718 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1719
1720         Remove my old email address from contributors.json and watchlist.
1721
1722         * Scripts/validate-committer-lists:
1723         (CommitterListFromGit): Change the mapping to the correct email.
1724         * Scripts/webkitpy/common/config/contributors.json:
1725         * Scripts/webkitpy/common/config/watchlist:
1726
1727 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1728
1729         Unreviewed, rolling out r210848.
1730
1731         This change introduced media-related LayoutTest failures and
1732         crashes on macOS.
1733
1734         Reverted changeset:
1735
1736         "[Modern Media Controls] Turn modern media controls on by
1737         default"
1738         https://bugs.webkit.org/show_bug.cgi?id=165668
1739         http://trac.webkit.org/changeset/210848
1740
1741 2017-01-18  Andreas Kling  <akling@apple.com>
1742
1743         Document::securityOrigin() should return a reference.
1744         <https://webkit.org/b/167124>
1745
1746         Reviewed by Sam Weinig.
1747
1748         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1749         (TestWebKitAPI::TEST_F):
1750
1751 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
1752
1753         [Win] Clipboard tests are flaky.
1754         https://bugs.webkit.org/show_bug.cgi?id=167088
1755
1756         Reviewed by Brent Fulgham.
1757
1758         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
1759         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
1760
1761         * DumpRenderTree/win/DumpRenderTree.cpp:
1762         (main):
1763
1764 2017-01-18  Antoine Quint  <graouts@apple.com>
1765
1766         [Modern Media Controls] Turn modern media controls on by default
1767         https://bugs.webkit.org/show_bug.cgi?id=165668
1768
1769         Reviewed by Dean Jackson.
1770
1771         Enabled modern media controls by default in test runners. 
1772
1773         * DumpRenderTree/TestOptions.h:
1774         * WebKitTestRunner/TestOptions.h:
1775
1776 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1777
1778         Unreviewed, rolling out r210834
1779         https://bugs.webkit.org/show_bug.cgi?id=165668
1780
1781         It introduced dozens of test timeouts.
1782
1783         Reverted changeset:
1784         "[Modern Media Controls] Turn modern media controls on by default"
1785         https://bugs.webkit.org/show_bug.cgi?id=165668
1786         http://trac.webkit.org/changeset/210834
1787
1788 2017-01-17  Antoine Quint  <graouts@apple.com>
1789
1790         [Modern Media Controls] Turn modern media controls on by default
1791         https://bugs.webkit.org/show_bug.cgi?id=165668
1792
1793         Reviewed by Dean Jackson.
1794
1795         Enabled modern media controls by default in test runners. 
1796
1797         * DumpRenderTree/TestOptions.h:
1798         * WebKitTestRunner/TestOptions.h:
1799
1800 2017-01-17  Chris Dumez  <cdumez@apple.com>
1801
1802         Document title changed twice when setting document.title
1803         https://bugs.webkit.org/show_bug.cgi?id=167065
1804
1805         Reviewed by Darin Adler.
1806
1807         Add WebKit2GTK API test that was written by Michael Catanzaro.
1808
1809         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1810         (testWebViewTitleChange):
1811         (beforeAll):
1812
1813 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1814
1815         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
1816         https://bugs.webkit.org/show_bug.cgi?id=116551
1817         <rdar://problem/13949830>
1818
1819         Reviewed by Alex Christensen.
1820
1821         * Scripts/webkitperl/FeatureList.pm:
1822         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
1823         that is part of the existing WEB_TIMING feature.
1824
1825         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1826
1827 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
1828
1829         'webkit-patch post' no longer works with moved/copied files
1830         https://bugs.webkit.org/show_bug.cgi?id=166914
1831         <rdar://problem/29979707>
1832
1833         Reviewed by Daniel Bates.
1834
1835         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
1836         file outputs only the "Index:" line with an empty body.  This workaround
1837         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
1838         public email list tracking this bug is below.
1839         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
1840         
1841
1842         * Scripts/svn-create-patch:
1843         (generateDiff): Ignore an "Index:" line with an empty body.
1844
1845 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
1846
1847         Remove the REQUEST_ANIMATION_FRAME flag
1848         https://bugs.webkit.org/show_bug.cgi?id=156980
1849         <rdar://problem/25906849>
1850
1851         Reviewed by Simon Fraser.
1852
1853         * Scripts/webkitperl/FeatureList.pm:
1854         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1855
1856 2017-01-15  Sam Weinig  <sam@webkit.org>
1857
1858         Add the ability to use numbers in makeString()
1859         https://bugs.webkit.org/show_bug.cgi?id=167087
1860
1861         Reviewed by Darin Adler.
1862
1863         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1864         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
1865         Add tests for StringConcatenate, focusing on new numeric additions.
1866
1867 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1868
1869         Unreviewed, remove stale comment.
1870
1871         This test was fixed by r163173.
1872
1873         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1874
1875 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1876
1877         Annotate large string tests with largeHeap
1878         https://bugs.webkit.org/show_bug.cgi?id=167054
1879
1880         Reviewed by Filip Pizlo.
1881
1882         * Scripts/run-javascriptcore-tests:
1883         * Scripts/run-jsc-stress-tests:
1884
1885 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
1886
1887         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
1888         https://bugs.webkit.org/show_bug.cgi?id=167043
1889
1890         Reviewed by Darin Adler.
1891
1892         * Scripts/webkitperl/FeatureList.pm:
1893
1894 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
1895
1896         Remove ENABLE(DETAILS_ELEMENT) guards
1897         https://bugs.webkit.org/show_bug.cgi?id=167042
1898
1899         Reviewed by Alex Christensen.
1900
1901         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1902
1903 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
1904
1905         26 MotionMark performance tests failing
1906         https://bugs.webkit.org/show_bug.cgi?id=166854
1907
1908         Reviewed by Ryosuke Niwa.
1909
1910         Unrelated change. This is the last place that we need to rename Animometer
1911         to MotionMark.
1912
1913         * Scripts/webkitpy/common/config/watchlist:
1914
1915 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
1916
1917         run-jsc-benchmarks' echo should have -e option
1918         https://bugs.webkit.org/show_bug.cgi?id=167009
1919
1920         Reviewed by Sam Weinig.
1921
1922         echo requires `-e` option to use escape sequence.
1923         Without it, in some environment (in my Fedora 25), the escape sequence is not
1924         recognized and just dumped as `\c` etc.
1925
1926         * Scripts/run-jsc-benchmarks:
1927
1928 2017-01-12  Chris Dumez  <cdumez@apple.com>
1929
1930         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1931         https://bugs.webkit.org/show_bug.cgi?id=166995
1932
1933         Reviewed by Jer Noble.
1934
1935         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1936         as some people are having trouble building without it.
1937
1938         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1939
1940 2017-01-12  Sam Weinig  <sam@webkit.org>
1941
1942         Add the ability to filter the set of bindings tests you want to run
1943         https://bugs.webkit.org/show_bug.cgi?id=166977
1944
1945         Reviewed by Tim Horton.
1946
1947         Allows doing things like:
1948             run-bindings-tests TestObj* TestCEReactions*
1949         
1950         to run only those tests that match the patterns.
1951
1952         * Scripts/run-bindings-tests:
1953         (main):
1954         Switch to using optparse and pass the remaining args as the filters.
1955
1956         * Scripts/webkitpy/bindings/main.py:
1957         (BindingsTests.__init__):
1958         Store the pattens.
1959
1960         (BindingsTests.test_matches_patterns):
1961         Add helper predicate to determine if a test should be run. When no
1962         patterns are present, all tests should run.
1963
1964         (BindingsTests.run_tests):
1965         Filter tests using the passed in patterns.
1966
1967 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
1968
1969         Followup fix after r210503.
1970         https://bugs.webkit.org/show_bug.cgi?id=166887
1971
1972         Reviewed by Alex Christensen.
1973
1974         After <http://trac.webkit.org/changeset/210503>, test results are written to a
1975         duplicated file handle on Windows. This patch fixes the remaining call sites.
1976
1977         * DumpRenderTree/PixelDumpSupport.cpp:
1978         * DumpRenderTree/TestRunner.cpp:
1979         (TestRunner::waitToDumpWatchdogTimerFired):
1980         * DumpRenderTree/TestRunner.h:
1981         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1982         * DumpRenderTree/win/DumpRenderTree.cpp:
1983         * DumpRenderTree/win/DumpRenderTreeWin.h:
1984         * DumpRenderTree/win/TestRunnerWin.cpp:
1985         (TestRunner::setSpellCheckerLoggingEnabled):
1986
1987 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
1988
1989         Add committer status for Megan
1990         https://bugs.webkit.org/show_bug.cgi?id=166954
1991
1992         Reviewed by Tim Horton.
1993
1994         Add committer status for Megan Gardner
1995
1996         * Scripts/webkitpy/common/config/contributors.json:
1997
1998 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1999
2000         Unreviewed test fix after r210599.
2001
2002         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2003         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
2004
2005 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2006
2007         Unreviewed build fix after r210599.
2008
2009         Add missing files.
2010
2011         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2012         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2013
2014 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2015
2016         File scheme should not allow access of a resource on a different volume.
2017         https://bugs.webkit.org/show_bug.cgi?id=158552
2018         <rdar://problem/15307582>
2019
2020         Reviewed by Alex Christensen.
2021
2022         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2023         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2024         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2025
2026 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2027
2028         Unreviewed, rolling out r210571.
2029
2030         This change broke the 32-bit macOS build and caused LayoutTest
2031         failures.
2032
2033         Reverted changeset:
2034
2035         "File scheme should not allow access of a resource on a
2036         different volume."
2037         https://bugs.webkit.org/show_bug.cgi?id=158552
2038         http://trac.webkit.org/changeset/210571
2039
2040 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2041
2042         [GTK] install-dependencies script misses gdb
2043         https://bugs.webkit.org/show_bug.cgi?id=166917
2044
2045         Reviewed by Michael Catanzaro.
2046
2047         gdb is needed for generating the crash logs.
2048
2049         * gtk/install-dependencies:
2050
2051 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2052
2053         [GTK] No way for applications to set notification permissions without waiting for permission request
2054         https://bugs.webkit.org/show_bug.cgi?id=163366
2055
2056         Reviewed by Carlos Garcia Campos.
2057
2058         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2059         (testWebViewNotification):
2060         (setInitialNotificationPermissionsAllowedCallback):
2061         (setInitialNotificationPermissionsDisallowedCallback):
2062         (testWebViewNotificationInitialPermissionAllowed):
2063         (testWebViewNotificationInitialPermissionDisallowed):
2064         (beforeAll):
2065         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2066         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2067         (WebViewTest::WebViewTest):
2068         (WebViewTest::initializeWebView):
2069         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2070
2071 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2072
2073         MobileMiniBrowser tests don't work by default
2074         https://bugs.webkit.org/show_bug.cgi?id=166910
2075
2076         Reviewed by Alex Christensen.
2077
2078         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2079         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2080
2081 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2082
2083         File scheme should not allow access of a resource on a different volume.
2084         https://bugs.webkit.org/show_bug.cgi?id=158552
2085         <rdar://problem/15307582>
2086
2087         Reviewed by Alex Christensen.
2088
2089         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2090         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2091         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2092
2093 2017-01-10  Mark Lam  <mark.lam@apple.com>
2094
2095         Reverting run-jsc-stress-tests' $buildType to use string values.
2096         https://bugs.webkit.org/show_bug.cgi?id=166912
2097
2098         Rubber stamped by Filip Pizlo.
2099
2100         This is so that we can test for it in the tests e.g.
2101         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2102
2103         * Scripts/run-jsc-stress-tests:
2104
2105 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2106
2107         Temporarily add back the file removed in r210463 to unbreak internal bots.
2108
2109         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2110
2111 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2112
2113         svn-apply failed to apply a patch (deleting file with svn property)
2114         https://bugs.webkit.org/show_bug.cgi?id=165953
2115
2116         Reviewed by Daniel Bates.
2117
2118         * Scripts/VCSUtils.pm:
2119         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2120         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2121
2122 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2123
2124         Update flakiness dashboard configuration.
2125         https://bugs.webkit.org/show_bug.cgi?id=166869
2126
2127         Reviewed by Alexey Proskuryakov.
2128
2129         * TestResultServer/static-dashboards/builders.jsonp:
2130         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2131
2132 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2133
2134         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2135         https://bugs.webkit.org/show_bug.cgi?id=165232
2136
2137         Unreviewed follow-up patch after r210539 and r210523.
2138
2139         Instead of using that environment variable, the argument
2140         --display-server=xorg should be passed now.
2141
2142         The GTK+ performance bot was the only bot using this, and is
2143         already passing --display-server=xorg after r210539.
2144
2145         * Scripts/webkitpy/port/gtk.py:
2146         (GtkPort._driver_class):
2147
2148 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2149
2150         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2151         https://bugs.webkit.org/show_bug.cgi?id=166872
2152
2153         Reviewed by Michael Catanzaro.
2154
2155         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2156         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2157         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2158         The step RunWebKitTests already has support for it.
2159
2160         * BuildSlaveSupport/build.webkit.org-config/config.json:
2161         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2162         (RunGtkAPITests.start):
2163         (RunAndUploadPerfTests.start):
2164         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2165
2166 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2167
2168         Unreviewed, rolling out r210531.
2169
2170         This change broke the 32-bit macOS build and caused LayoutTest
2171         failures.
2172
2173         Reverted changeset:
2174
2175         "File scheme should not allow access of a resource on a
2176         different volume."
2177         https://bugs.webkit.org/show_bug.cgi?id=158552
2178         http://trac.webkit.org/changeset/210531
2179
2180 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2181
2182         File scheme should not allow access of a resource on a different volume.
2183         https://bugs.webkit.org/show_bug.cgi?id=158552
2184         <rdar://problem/15307582>
2185
2186         Reviewed by Alex Christensen.
2187
2188         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2189         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2190         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2191
2192 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2193
2194         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2195         https://bugs.webkit.org/show_bug.cgi?id=165232
2196
2197         Reviewed by Michael Catanzaro.
2198
2199         Add a new WaylandDriver to run the tests in the user current wayland session.
2200
2201         Also merge all the configuration options for selecting the display server inside one
2202         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2203
2204         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2205
2206         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2207         (TestRunner._create_driver):
2208         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2209         (parse_args):
2210         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2211         (PerfTestsRunner._parse_args):
2212         * Scripts/webkitpy/port/gtk.py:
2213         (GtkPort.__init__):
2214         (GtkPort._driver_class):
2215         (GtkPort._search_paths):
2216         * Scripts/webkitpy/port/waylanddriver.py: Added.
2217         (WaylandDriver):
2218         (WaylandDriver.check_driver):
2219         (WaylandDriver._setup_environ_for_test):
2220         (WaylandDriver._start):
2221
2222 2017-01-09  Andy Estes  <aestes@apple.com>
2223
2224         [QuickLook] Add a layout test for webkit.org/b/135651
2225         https://bugs.webkit.org/show_bug.cgi?id=166855
2226
2227         Reviewed by Andreas Kling.
2228
2229         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2230         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2231         errors with code WebKitErrorCannotShowURL.
2232         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2233         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2234         not specific to WebKit2 error codes.
2235
2236 2017-01-09  Antoine Quint  <graouts@apple.com>
2237
2238         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2239         https://bugs.webkit.org/show_bug.cgi?id=166837
2240
2241         Reviewed by Alex Christensen.
2242
2243         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2244         the provided value when trying to determine the path to the test file. Failing
2245         that, we use the computed URL or the raw path provided to cover all cases.
2246         
2247         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2248         by applying this patch and seeing the number test failures dramatically reduced
2249         with WK1 due to the option to turn modern media controls off for older media controls
2250         tests.
2251
2252         * DumpRenderTree/DumpRenderTree.h:
2253         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2254         (parseInputLine):
2255         * DumpRenderTree/TestOptions.h:
2256         * DumpRenderTree/TestOptions.mm:
2257         (TestOptions::TestOptions):
2258         * DumpRenderTree/mac/DumpRenderTree.mm:
2259         (runTest):
2260
2261 2017-01-09  Milan Crha  <mcrha@redhat.com>
2262
2263         prepare-ChangeLog: Correct help string for --style option
2264         https://bugs.webkit.org/show_bug.cgi?id=166725
2265
2266         Reviewed by Alexey Proskuryakov.
2267
2268         * Scripts/prepare-ChangeLog:
2269         (main):
2270
2271 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2272
2273         https://bugs.webkit.org/show_bug.cgi?id=166839
2274         Add php7 support for macOS.
2275         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2276
2277         Reviewed by Alexey Proskuryakov.
2278
2279         * Scripts/webkitpy/port/base.py:
2280         (Port._is_darwin_php_version_7):
2281         (Port._debian_php_version):
2282         (Port):
2283         (Port._darwin_php_version):
2284         (Port._apache_config_file_name_for_platform):
2285
2286 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2287
2288         [GTK] Should support key and code properties on keyboard events
2289         https://bugs.webkit.org/show_bug.cgi?id=166759
2290
2291         Reviewed by Carlos Garcia Campos.
2292
2293         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2294         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2295         on tests.
2296
2297 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2298
2299         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2300         https://bugs.webkit.org/show_bug.cgi?id=166760
2301
2302         Reviewed by Darin Adler.
2303
2304         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2305         We can work around that by duplicating and redirecting stdout.
2306
2307         * DumpRenderTree/PixelDumpSupport.cpp:
2308         (dumpWebViewAsPixelsAndCompareWithExpected):
2309         (printPNG):
2310         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2311         (logEventProc):
2312         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2313         (DRTDesktopNotificationPresenter::showDesktopNotification):
2314         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2315         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2316         * DumpRenderTree/win/DumpRenderTree.cpp:
2317         (dumpFrameScrollPosition):
2318         (dumpHistoryItem):
2319         (dumpBackForwardList):
2320         (dump):
2321         (runTest):
2322         (main):
2323         * DumpRenderTree/win/DumpRenderTreeWin.h:
2324         * DumpRenderTree/win/EditingDelegate.cpp:
2325         (EditingDelegate::shouldBeginEditingInDOMRange):
2326         (EditingDelegate::shouldEndEditingInDOMRange):
2327         (EditingDelegate::shouldInsertNode):
2328         (EditingDelegate::shouldInsertText):
2329         (EditingDelegate::shouldDeleteDOMRange):
2330         (EditingDelegate::shouldChangeSelectedDOMRange):
2331         (EditingDelegate::shouldApplyStyle):
2332         (EditingDelegate::shouldChangeTypingStyle):
2333         (EditingDelegate::doPlatformCommand):
2334         (EditingDelegate::webViewDidBeginEditing):
2335         (EditingDelegate::webViewDidChange):
2336         (EditingDelegate::webViewDidEndEditing):
2337         (EditingDelegate::webViewDidChangeTypingStyle):
2338         (EditingDelegate::webViewDidChangeSelection):
2339         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2340         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2341         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2342         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2343         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2344         (FrameLoadDelegate::didCommitLoadForFrame):
2345         (FrameLoadDelegate::didReceiveTitle):
2346         (FrameLoadDelegate::didFinishLoadForFrame):
2347         (FrameLoadDelegate::didFailLoadWithError):
2348         (FrameLoadDelegate::willPerformClientRedirectToURL):
2349         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2350         (FrameLoadDelegate::windowScriptObjectAvailable):
2351         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2352         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2353         (FrameLoadDelegate::didDisplayInsecureContent):
2354         (FrameLoadDelegate::didRunInsecureContent):
2355         (FrameLoadDelegate::webViewProgressFinishedNotification):
2356         * DumpRenderTree/win/HistoryDelegate.cpp:
2357         (HistoryDelegate::didNavigateWithNavigationData):
2358         (HistoryDelegate::didPerformClientRedirectFromURL):
2359         (HistoryDelegate::didPerformServerRedirectFromURL):
2360         (HistoryDelegate::updateHistoryTitle):
2361         (HistoryDelegate::populateVisitedLinksForWebView):
2362         * DumpRenderTree/win/PolicyDelegate.cpp:
2363         (PolicyDelegate::decidePolicyForNavigationAction):
2364         (PolicyDelegate::unableToImplementPolicyWithError):
2365         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2366         (ResourceLoadDelegate::willSendRequest):
2367         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2368         (ResourceLoadDelegate::didReceiveResponse):
2369         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2370         (ResourceLoadDelegate::didFailLoadingWithError):
2371         * DumpRenderTree/win/TestRunnerWin.cpp:
2372         (TestRunner::addDisallowedURL):
2373         (TestRunner::originsWithApplicationCache):
2374         (TestRunner::setStorageDatabaseIdleInterval):
2375         (TestRunner::closeIdleLocalStorageDatabases):
2376         (TestRunner::copyDecodedHostName):
2377         (TestRunner::copyEncodedHostName):
2378         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2379         (TestRunner::isGeolocationProviderActive):
2380         (TestRunner::pathToLocalResource):
2381         (TestRunner::setMockDeviceOrientation):
2382         (TestRunner::setMockGeolocationPosition):
2383         (TestRunner::setMockGeolocationPositionUnavailableError):
2384         (TestRunner::setSpatialNavigationEnabled):
2385         (TestRunner::setAutomaticLinkDetectionEnabled):
2386         (TestRunner::isCommandEnabled):
2387         (TestRunner::authenticateSession):
2388         (TestRunner::addChromeInputField):
2389         (TestRunner::removeChromeInputField):
2390         (TestRunner::focusWebView):
2391         (TestRunner::grantWebNotificationPermission):
2392         (TestRunner::denyWebNotificationPermission):
2393         (TestRunner::removeAllWebNotificationPermissions):
2394         (TestRunner::simulateWebNotificationClick):
2395         (TestRunner::imageCountInGeneralPasteboard):
2396         * DumpRenderTree/win/UIDelegate.cpp:
2397         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2398         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2399         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2400         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2401         (UIDelegate::webViewAddMessageToConsole):
2402         (UIDelegate::exceededDatabaseQuota):
2403         (UIDelegate::setStatusText):
2404         (UIDelegate::didPressMissingPluginButton):
2405
2406 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2407
2408         Add a setting to create editable MiniBrowser windows by default
2409         https://bugs.webkit.org/show_bug.cgi?id=166806
2410
2411         Reviewed by Beth Dakin.
2412
2413         * MiniBrowser/mac/AppDelegate.m:
2414         (-[BrowserAppDelegate createBrowserWindowController:]):
2415         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2416         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2417         * MiniBrowser/mac/SettingsController.h:
2418         * MiniBrowser/mac/SettingsController.m:
2419         (-[SettingsController _populateMenu]):
2420         (-[SettingsController validateMenuItem:]):
2421         (-[SettingsController toggleCreateEditorByDefault:]):
2422         (-[SettingsController createEditorByDefault]):
2423         Add a setting and update the key equivalents accordingly.
2424         Also make sure to make the right kind of window on launch.
2425
2426 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2427
2428         Fix the 32-bit build.
2429
2430         * MiniBrowser/mac/BrowserWindowController.h:
2431         * MiniBrowser/mac/BrowserWindowController.m:
2432
2433 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2434
2435         Fix the 32-bit build.
2436
2437         * MiniBrowser/mac/BrowserWindowController.m:
2438
2439 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2440
2441         Make it possible to drop HTML files on the MiniBrowser icon
2442         https://bugs.webkit.org/show_bug.cgi?id=166802
2443
2444         Reviewed by Simon Fraser.
2445
2446         * MiniBrowser/mac/AppDelegate.m:
2447         (-[BrowserAppDelegate application:openFile:]):
2448         * MiniBrowser/mac/Info.plist:
2449         If you're using an editable window, the usual trick of dropping on the
2450         window doesn't work anymore (it makes an <attachment> instead).
2451
2452 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2453
2454         MiniBrowser window gets smaller each time it is instantiated
2455         https://bugs.webkit.org/show_bug.cgi?id=166807
2456
2457         Reviewed by Andy Estes.
2458
2459         * MiniBrowser/mac/BrowserWindowController.m:
2460         (-[BrowserWindowController windowDidLoad]):
2461         * MiniBrowser/mac/BrowserWindow.xib:
2462         Turn on full-window content view support with IB, instead of waiting
2463         until after the views have been loaded. This seems to resolve the
2464         longstanding ever-shrinking-window problem.
2465
2466 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2467
2468         Add indent/outdent items to MiniBrowser's new format menu
2469         https://bugs.webkit.org/show_bug.cgi?id=166805
2470
2471         Reviewed by Dan Bernstein.
2472
2473         * MiniBrowser/mac/MainMenu.xib:
2474
2475 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2476
2477         Add a stock Format menu to MiniBrowser
2478         https://bugs.webkit.org/show_bug.cgi?id=166804
2479
2480         Reviewed by Andy Estes.
2481
2482         * MiniBrowser/mac/MainMenu.xib:
2483         Many of the features automatically work with editable web views.
2484         However, this seems to expose a bug where none of the font-related features
2485         (Cmd-B, for example) work until the first time the font panel is shown,
2486         per process, which will need to be investigated separately.
2487
2488 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2489
2490         Remove unused applicationWillTerminate methods from MiniBrowser
2491         https://bugs.webkit.org/show_bug.cgi?id=166803
2492
2493         Reviewed by Andy Estes.
2494
2495         * MiniBrowser/mac/AppDelegate.m:
2496         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
2497         * MiniBrowser/mac/BrowserWindowController.h:
2498         * MiniBrowser/mac/BrowserWindowController.m:
2499         (-[BrowserWindowController applicationTerminating]): Deleted.
2500         * MiniBrowser/mac/WK1BrowserWindowController.m:
2501         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
2502         * MiniBrowser/mac/WK2BrowserWindowController.m:
2503         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
2504
2505 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2506
2507         Add the ability to create empty contentEditable windows in MiniBrowser
2508         https://bugs.webkit.org/show_bug.cgi?id=166801
2509
2510         Reviewed by Wenson Hsieh.
2511
2512         * MiniBrowser/mac/AppDelegate.h:
2513         * MiniBrowser/mac/AppDelegate.m:
2514         (-[BrowserAppDelegate createBrowserWindowController:]):
2515         (-[BrowserAppDelegate newWindow:]):
2516         (-[BrowserAppDelegate newEditorWindow:]):
2517         (-[BrowserAppDelegate openDocument:]):
2518         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2519         * MiniBrowser/mac/BrowserWindowController.h:
2520         * MiniBrowser/mac/BrowserWindowController.m:
2521         (-[BrowserWindowController loadHTMLString:]):
2522         (-[BrowserWindowController toggleEditable:]):
2523         * MiniBrowser/mac/MainMenu.xib:
2524         * MiniBrowser/mac/WK1BrowserWindowController.m:
2525         (-[WK1BrowserWindowController awakeFromNib]):
2526         (-[WK1BrowserWindowController loadHTMLString:]):
2527         (-[WK1BrowserWindowController validateMenuItem:]):
2528         (-[WK1BrowserWindowController setEditable:]):
2529         (-[WK1BrowserWindowController updateTitle:]):
2530         * MiniBrowser/mac/WK2BrowserWindowController.m:
2531         (-[WK2BrowserWindowController awakeFromNib]):
2532         (-[WK2BrowserWindowController validateMenuItem:]):
2533         (-[WK2BrowserWindowController setEditable:]):
2534         (-[WK2BrowserWindowController updateTitle:]):
2535         (-[WK2BrowserWindowController loadHTMLString:]):
2536         Merge more functionality from WebEditingTester.
2537         Add two menu items for creating empty editable WebKit1/2 windows.
2538         Add a menu item to the Edit menu to toggle editability on any window.
2539
2540 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2541
2542         Implement find-in-page in MiniBrowser
2543         https://bugs.webkit.org/show_bug.cgi?id=166799
2544
2545         Reviewed by Andy Estes.
2546
2547         * MiniBrowser/mac/BrowserWindow.xib:
2548         * MiniBrowser/mac/BrowserWindowController.h:
2549         * MiniBrowser/mac/BrowserWindowController.m:
2550         (-[BrowserWindowController find:]): Deleted.
2551         * MiniBrowser/mac/MainMenu.xib:
2552         * MiniBrowser/mac/WK1BrowserWindowController.m:
2553         (-[WK1BrowserWindowController toggleShrinkToFit:]):
2554         (-[WK1BrowserWindowController find:]): Deleted.
2555         * MiniBrowser/mac/WK2BrowserWindowController.m:
2556         (-[WK2BrowserWindowController awakeFromNib]):
2557         (-[WK2BrowserWindowController dealloc]):
2558         (-[WK2BrowserWindowController validateMenuItem:]):
2559         (-[WK2BrowserWindowController performTextFinderAction:]):
2560         (-[WK2BrowserWindowController findBarView]):
2561         (-[WK2BrowserWindowController setFindBarView:]):
2562         (-[WK2BrowserWindowController isFindBarVisible]):
2563         (-[WK2BrowserWindowController setFindBarVisible:]):
2564         (-[WK2BrowserWindowController contentView]):
2565         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
2566         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
2567         (-[WK2BrowserWindowController find:]): Deleted.
2568         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
2569         protocol. At first glance, it's pretty broken, but vaguely works.
2570
2571 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2572
2573         Share the implementation of MiniBrowser view hiding functionality
2574         https://bugs.webkit.org/show_bug.cgi?id=166800
2575
2576         Reviewed by Andy Estes.
2577
2578         * MiniBrowser/mac/BrowserWindowController.m:
2579         (-[BrowserWindowController showHideWebView:]):
2580         (-[BrowserWindowController removeReinsertWebView:]):
2581         * MiniBrowser/mac/WK1BrowserWindowController.m:
2582         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
2583         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
2584         * MiniBrowser/mac/WK2BrowserWindowController.m:
2585         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
2586         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
2587         Move the implementation of these two things to the shared superclass,
2588         since they don't depend on WebKit-specific things.
2589         Also, there was no reason to retain the (WK)WebView while it was unparented,
2590         as the BrowserWindowController maintains a reference the entire time.
2591
2592 2017-01-06  Andy Estes  <aestes@apple.com>
2593
2594         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
2595         https://bugs.webkit.org/show_bug.cgi?id=166789
2596
2597         Reviewed by Alex Christensen.
2598
2599         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2600         * DumpRenderTree/PlatformMac.cmake:
2601         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
2602         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
2603         * DumpRenderTree/mac/DumpRenderTree.mm:
2604         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2605         createXMLStringFromWebArchiveData().
2606         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
2607         * WebKitTestRunner/Configurations/Base.xcconfig:
2608         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
2609         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2610         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2611         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2612         createXMLStringFromWebArchiveData().
2613         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
2614         * WebKitTestRunner/PlatformMac.cmake:
2615         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2616         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
2617
2618 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2619
2620         Minor cleanups to IndentOutdentCommand and related code
2621         https://bugs.webkit.org/show_bug.cgi?id=166791
2622
2623         Reviewed by Simon Fraser.
2624
2625         * WebEditingTester/EditingOperations.m:
2626         (editingOperations):
2627         Add the outdent operation to WebEditingTester.
2628
2629 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
2630
2631         Create a plan and a patch files for MotionMark and delete the Animometer's ones
2632         https://bugs.webkit.org/show_bug.cgi?id=166785
2633
2634         Reviewed by Ryosuke Niwa.
2635
2636         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2637         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
2638
2639 2017-01-06  Antoine Quint  <graouts@apple.com>
2640
2641         Support webkit-test-runner key-value pairs in http tests
2642         https://bugs.webkit.org/show_bug.cgi?id=149812
2643
2644         Reviewed by Alex Christensen.
2645
2646         We pass the absolute path for a test through to WKTR so that we can parse
2647         tests that are running as URLs for webkit-test-runner options.
2648
2649         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2650         (parseInputLine):
2651
2652         Explicitly skip the --absolute-path option in DRT or else we'd crash.
2653
2654         * Scripts/webkitpy/port/driver.py:
2655         (Driver._command_from_driver_input):
2656
2657         Pass the absolute path to the file through the CLI.
2658
2659         * WebKitTestRunner/TestController.cpp:
2660         (WTR::updateTestOptionsFromTestHeader):
2661         (WTR::TestController::testOptionsForTest):
2662         (WTR::parseInputLine):
2663         (WTR::TestController::runTest):
2664         * WebKitTestRunner/TestController.h:
2665
2666 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2667
2668         Warning about unconnectable outlets when opening a MiniBrowser window
2669         https://bugs.webkit.org/show_bug.cgi?id=166756
2670
2671         Reviewed by Dan Bernstein.
2672
2673         * MiniBrowser/mac/BrowserWindow.xib:
2674         When launching MiniBrowser, it says:
2675         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
2676             (MBToolbarItem): missing setter or instance variable
2677         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
2678             (NSButtonCell): missing setter or instance variable.
2679
2680         It looks like someone added the connection from the share button
2681         to the BrowserWindowController three times; only one of the connections
2682         is valid. Remove the other two.
2683
2684 2017-01-05  Keith Rollin  <krollin@apple.com>
2685
2686         Add WebCore::URL::protocolHostAndPort
2687         https://bugs.webkit.org/show_bug.cgi?id=166426
2688
2689         Reviewed by Alex Christensen.
2690
2691         Add test for protocolHostAndPort.
2692
2693         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2694         (TestWebKitAPI::TEST_F):
2695
2696 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
2697
2698         [Win] Archive test result is failing.
2699         https://bugs.webkit.org/show_bug.cgi?id=166720
2700
2701         Reviewed by Alex Christensen.
2702
2703         Deleting the layout test result folder is sometimes failing
2704         on Windows. This is not a critical error.
2705
2706         * BuildSlaveSupport/test-result-archive:
2707         (archiveTestResults):
2708
2709 2017-01-04  Tomas Popela  <tpopela@redhat.com>
2710
2711         [GTK] Minibrowser: Add printing support
2712         https://bugs.webkit.org/show_bug.cgi?id=165298
2713
2714         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
2715         an error during the print, it's printed on the console.
2716
2717         Reviewed by Michael Catanzaro.
2718
2719         * MiniBrowser/gtk/BrowserWindow.c:
2720         (webKitPrintOperationFailedCallback):
2721         (printPage):
2722         (browser_window_init):
2723
2724 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
2725
2726         [css-grid] Fix crash clamping grid lines
2727         https://bugs.webkit.org/show_bug.cgi?id=166637
2728
2729         Reviewed by Darin Adler.
2730
2731         Creates new unit test to verify that the maximum tracks limit
2732         is used in GridPosition too.
2733
2734         * TestWebKitAPI/PlatformEfl.cmake:
2735         * TestWebKitAPI/PlatformGTK.cmake:
2736         * TestWebKitAPI/PlatformWin.cmake:
2737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2738         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
2739         (TestWebKitAPI::TEST):
2740
2741 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2742
2743         Move editing history scripts to WebCore PrivateHeaders
2744         https://bugs.webkit.org/show_bug.cgi?id=166709
2745         <rdar://problem/29876612>
2746
2747         Reviewed by Dan Bernstein.
2748
2749         Update references to editing script files in WebCore that were moved.
2750
2751         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
2752
2753 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2754
2755         Unreviewed, build fix after r210313 part 2
2756         https://bugs.webkit.org/show_bug.cgi?id=166676
2757
2758         Add 'U' suffix.
2759
2760         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2761         (TestWebKitAPI::TEST):
2762         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2763         (TestWebKitAPI::TEST):
2764
2765 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2766
2767         Limit thread name appropriately
2768         https://bugs.webkit.org/show_bug.cgi?id=166676
2769
2770         Reviewed by Sam Weinig.
2771
2772         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2773         (TestWebKitAPI::TEST):
2774         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2775         (TestWebKitAPI::TEST):
2776
2777 2017-01-04  Andy Estes  <aestes@apple.com>
2778
2779         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
2780         https://bugs.webkit.org/show_bug.cgi?id=166696
2781
2782         Reviewed by Tim Horton.
2783
2784         * TestWebKitAPI/PlatformGTK.cmake:
2785         * TestWebKitAPI/PlatformWin.cmake:
2786         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2787         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
2788         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
2789         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
2790         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
2791         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
2792         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
2793
2794 2017-01-03  Brian Burg  <bburg@apple.com>
2795
2796         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
2797         https://bugs.webkit.org/show_bug.cgi?id=166003
2798         <rdar://problem/28718990>
2799
2800         Reviewed by Joseph Pecoraro.
2801
2802         Teach run-inspector-generator-tests to generate test output using the platform name
2803         derived from the directory that the test is in. For example, tests in the /generic/
2804         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
2805
2806         * Scripts/webkitpy/inspector/main.py:
2807         (InspectorGeneratorTests.generate_from_json):
2808         (InspectorGeneratorTests.run_tests):
2809         (InspectorGeneratorTests.main):
2810
2811 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
2812
2813         Unreviewed cmake buildfix after r210266.
2814
2815         * DumpRenderTree/PlatformMac.cmake:
2816
2817 2017-01-04  Tim Horton  <timothy_horton@apple.com>
2818
2819         Provide a setting for clients to always prefer low-power WebGL
2820         https://bugs.webkit.org/show_bug.cgi?id=166675
2821         <rdar://problem/29834093>
2822
2823         Reviewed by Dan Bernstein.
2824
2825         * MiniBrowser/mac/Info.plist:
2826         Have MiniBrowser claim to be a modern app that supports
2827         automatic graphics switching. WebKit needs to support automatic
2828         graphics switching, so our test app might as well. Without this
2829         Info.plist parameter, this change has no effect, and bringing up
2830         a WebGL context still brings up the discrete GPU (also true of the
2831         existing web-exposed preferLowPowerToHighPerformance API).
2832
2833 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
2834
2835         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
2836         https://bugs.webkit.org/show_bug.cgi?id=166645
2837
2838         Reviewed by Carlos Garcia Campos.
2839
2840         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2841         (TestWebKitAPI::TEST):
2842
2843 2017-01-03  Andy Estes  <aestes@apple.com>
2844
2845         Place all the Cocoa WebCore API tests in the same directory
2846         https://bugs.webkit.org/show_bug.cgi?id=166673
2847
2848         Reviewed by Michael Catanzaro.
2849
2850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2851         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
2852         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
2853         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
2854
2855 2017-01-03  Tim Horton  <timothy_horton@apple.com>
2856
2857         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
2858         https://bugs.webkit.org/show_bug.cgi?id=166450
2859         <rdar://problem/29447824>
2860
2861         Reviewed by Darin Adler.
2862
2863         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2864         * DumpRenderTree/TestRunner.cpp:
2865         (TestRunner::staticFunctions):
2866         * DumpRenderTree/mac/TestRunnerMac.mm:
2867         (setSpellCheckerLoggingEnabledCallback):
2868         * DumpRenderTree/win/TestRunnerWin.cpp:
2869         (setSpellCheckerLoggingEnabledCallback):
2870         * DumpRenderTree/mac/DumpRenderTree.mm:
2871         (resetWebViewToConsistentStateBeforeTesting):
2872         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
2873         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
2874         (stringForCorrectionResponse):
2875         (drt_NSSpellChecker_recordResponseToCorrection):
2876         (swizzleNSSpellCheckerMethodsIfNeeded):
2877         (setSpellCheckerLoggingEnabled):
2878         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
2879         set to true, logs to stdout (which ends up in the test result) whenever
2880         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
2881         is called, and then calls the original method. It is reset to false between tests.
2882
2883 2017-01-03  Sam Weinig  <sam@webkit.org>
2884
2885         Make WTF::Expected support Ref template parameters
2886         https://bugs.webkit.org/show_bug.cgi?id=166662
2887
2888         Reviewed by Alex Christensen.
2889
2890         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2891         (TestWebKitAPI::TEST):
2892         Add tests for using Ref with Expected.
2893
2894 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2895
2896         [GTK] Expose WebKitSecurityOrigin API
2897         https://bugs.webkit.org/show_bug.cgi?id=166632
2898
2899         Reviewed by Carlos Garcia Campos.
2900
2901         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2902         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
2903         (testSecurityOriginBasicConstructor):
2904         (testSecurityOriginURIConstructor):
2905         (testSecurityOriginDefaultPort):
2906         (testSecurityOriginFileURI):
2907         (testSecurityOriginDataURI):
2908         (beforeAll):
2909         (afterAll):
2910
2911 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2912
2913         [GTK] HTTP auth layout tests are flaky
2914         https://bugs.webkit.org/show_bug.cgi?id=158919
2915
2916         Reviewed by Michael Catanzaro.
2917
2918         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
2919         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
2920         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
2921         missing valac in the bots.
2922
2923 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2924
2925         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
2926         https://bugs.webkit.org/show_bug.cgi?id=165797
2927
2928         Reviewed by Michael Catanzaro.
2929
2930         Move directory ruleset after all exclude rules of Source rulset.
2931
2932         * gtk/manifest.txt.in:
2933
2934 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2935
2936         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
2937         https://bugs.webkit.org/show_bug.cgi?id=166636
2938
2939         Reviewed by Darin Adler.
2940
2941         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2942         (TestWebKitAPI::TEST):
2943
2944 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
2945
2946         [GTK] WebCore/CSSParser unit test is not being built
2947         https://bugs.webkit.org/show_bug.cgi?id=166492
2948
2949         Reviewed by Michael Catanzaro.
2950
2951         This test was introduced in r175930, but we were not building
2952         it on GTK+ port since r176015.
2953         This patch marks the test to be built again on GTK+.
2954         JFTR, the test is passing right now.
2955
2956         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
2957         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
2958
2959 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
2960
2961         AX: Expose block quote level to iOS API
2962         https://bugs.webkit.org/show_bug.cgi?id=166629
2963         <rdar://problem/29834793>
2964
2965         Reviewed by Darin Adler.
2966
2967         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2968         (AccessibilityUIElement::numberAttributeValue):
2969         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2970         (WTR::AccessibilityUIElement::numberAttributeValue):
2971
2972 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
2973
2974         SecurityOrigin::create triplet constructor does not canonicalize port
2975         https://bugs.webkit.org/show_bug.cgi?id=166624
2976
2977         Reviewed by Daniel Bates.
2978
2979         * TestWebKitAPI/PlatformGTK.cmake:
2980         * TestWebKitAPI/PlatformWin.cmake:
2981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2982         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
2983         (TestWebKitAPI::SecurityOriginTest::SetUp):
2984         (TestWebKitAPI::TEST_F):
2985
2986 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2987
2988         [GTK] Improve user agent construction
2989         https://bugs.webkit.org/show_bug.cgi?id=142074
2990
2991         Reviewed by Carlos Garcia Campos.
2992
2993         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2994         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
2995         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2996         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
2997         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
2998         (TestWebKitAPI::TEST):
2999
3000 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3001
3002         [GTK] Improve user agent construction
3003         https://bugs.webkit.org/show_bug.cgi?id=142074
3004
3005         Reviewed by Carlos Garcia Campos.
3006
3007         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3008         (TestWebKitAPI::TEST):
3009
3010 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
3011
3012         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
3013         https://bugs.webkit.org/show_bug.cgi?id=166472
3014         rdar://problem/29675551
3015
3016         Reviewed by Tim Horton.
3017
3018         These changes are necessary to allow the mouse to leave the WTR window while
3019         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
3020         (which DRT does); we'd always go through mouseMoved, which hits an early return
3021         in WebViewImpl::mouseMoved() when the point is outside the view.
3022
3023         * WebKitTestRunner/mac/EventSenderProxy.mm:
3024         (WTR::EventSenderProxy::mouseMoveTo):
3025
3026 2016-12-23  Andy Estes  <aestes@apple.com>
3027
3028         [iOS] Fix some crashing webarchive tests
3029         https://bugs.webkit.org/show_bug.cgi?id=166470
3030
3031         Reviewed by Andreas Kling.
3032
3033         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
3034         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
3035         so this change uses that on both platforms.
3036
3037         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
3038         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
3039         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
3040         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
3041         * WebKitTestRunner/PlatformMac.cmake:
3042         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3043         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3044
3045 2016-12-22  Saam Barati  <sbarati@apple.com>
3046
3047         WebAssembly: Silence the output of the spec-tests
3048         https://bugs.webkit.org/show_bug.cgi?id=166417
3049
3050         Reviewed by Mark Lam.
3051
3052         * Scripts/run-jsc-stress-tests:
3053
3054 2016-12-22  Zhuo Li  <zachli@apple.com>
3055
3056         [Cocoa] SPI for setloadsImagesAutomatically.
3057         https://bugs.webkit.org/show_bug.cgi?id=166401.
3058
3059         Reviewed by Darin Adler.
3060
3061         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3062         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3063         _loadsImagesAutomatically returns YES.
3064
3065 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3066
3067         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3068         https://bugs.webkit.org/show_bug.cgi?id=161328
3069         <rdar://problem/28475977>
3070
3071         Reviewed by Darin Adler.
3072
3073         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3074         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3075         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3076         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3077         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3078         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3079         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3080         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3081         we finish running a test and before we load the next test.
3082
3083         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3084         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3085         previous test started zooming and then finished before zooming completed. Since this happens before the next
3086         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3087
3088         * WebKitTestRunner/ios/TestControllerIOS.mm:
3089         (WTR::TestController::platformResetStateToConsistentValues):
3090
3091 2016-12-22  Jer Noble  <jer.noble@apple.com>
3092
3093         Muted media element playback should not interrupt other audio playback
3094         https://bugs.webkit.org/show_bug.cgi?id=166347
3095
3096         Reviewed by Eric Carlson.
3097
3098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3099         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3100         (TestWebKitAPI::TEST):
3101         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3102
3103 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3104
3105         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3106         https://bugs.webkit.org/show_bug.cgi?id=166346
3107
3108         Reviewed by Carlos Garcia Campos.
3109
3110         Enable WebRTC by default to simplify testing.
3111
3112         * MiniBrowser/gtk/main.c:
3113         (main):
3114
3115 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3116
3117         REGRESSION: API test failure: WKWebView.LocalStorageClear
3118         https://bugs.webkit.org/show_bug.cgi?id=166032
3119         <rdar://problem/29758423>
3120
3121         Reviewed by Simon Fraser.
3122
3123         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3124         to ensure that the view is destroyed before the callback fires.
3125
3126         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3127         (TEST):
3128
3129 2016-12-21  Saam Barati  <sbarati@apple.com>
3130
3131         WebAssembly: Import spec tests
3132         https://bugs.webkit.org/show_bug.cgi?id=166395
3133
3134         Rubber stamped by Keith Miller.
3135
3136         * Scripts/run-jsc-stress-tests:
3137
3138 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3139
3140         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3141         https://bugs.webkit.org/show_bug.cgi?id=166033
3142         <rdar://problem/29758428>
3143
3144         Reviewed by Simon Fraser.
3145
3146         Add an @autoreleasepool around the code that allocates the WKWebView, 
3147         so that it can be destroyed by removing the last reference in _downloadDidStart.
3148
3149         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3150         (TEST):
3151
3152 2016-12-21  Daniel Bates  <dabates@apple.com>
3153
3154         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3155         https://bugs.webkit.org/show_bug.cgi?id=166356
3156
3157         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3158         as a means to allow a test to explicit allow an embedding client to open a new windows
3159         such that the default behavior is for the embedding client to forbid such an action.
3160         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3161         it is currently skipped on WebKit2 because questions were raised in the patch for
3162         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3163         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3164         this test.
3165
3166         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3167         (WTR::TestRunner::setCanOpenWindows):
3168
3169 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3170
3171         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3172         https://bugs.webkit.org/show_bug.cgi?id=166031
3173
3174         Reviewed by Tim Horton.
3175         
3176         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3177         to ensure that the view is destroyed before the callback fires.
3178
3179         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3180
3181 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3182
3183         Throw Exception when test doesn't clean up HID Events properly
3184         https://bugs.webkit.org/show_bug.cgi?id=166271
3185
3186         Reviewed by Simon Fraser.
3187
3188         Add in a check when UIScriptController is deleted to make sure that the HID event
3189         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3190         the program to crash without any good information. Crashes are race-y, and will still
3191         happen with malformed test, but the information will be much more helpful. 
3192
3193         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3194         (WTR::UIScriptController::checkForClean):
3195         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3196         (UIScriptContext::~UIScriptContext):
3197         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3198         (WTR::UIScriptController::checkForClean):
3199         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3200         * WebKitTestRunner/ios/HIDEventGenerator.h:
3201         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3202         (-[HIDEventGenerator checkHIDCallbacksClear]):
3203         * WebKitTestRunner/ios/TestControllerIOS.mm:
3204         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3205         (WTR::UIScriptController::checkForClean):
3206
3207 2016-12-20  Andy Estes  <aestes@apple.com>
3208
3209         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3210         https://bugs.webkit.org/show_bug.cgi?id=165992
3211
3212         Reviewed by Brady Eidson.
3213
3214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3215         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3216         (expectException):
3217         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3218         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3219         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3220         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3221         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3222         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3223         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3224         (TEST):
3225         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3226
3227 2016-12-20  Dean Jackson  <dino@apple.com>
3228
3229         Remove INDIE_UI
3230         https://bugs.webkit.org/show_bug.cgi?id=165881
3231         <rdar://problem/29672532>
3232
3233         Reviewed by Simon Fraser.
3234
3235         The Indie UI work has been discontinued.
3236
3237         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3238
3239 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3240
3241         [ES6] Enable ES6 Modules
3242         https://bugs.webkit.org/show_bug.cgi?id=165849
3243
3244         Reviewed by Geoffrey Garen.
3245
3246         * DumpRenderTree/mac/DumpRenderTree.mm:
3247         (resetWebPreferencesToConsistentValues):
3248         * DumpRenderTree/win/DumpRenderTree.cpp:
3249         (resetWebPreferencesToConsistentValues):
3250         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3251         (WTR::InjectedBundle::beginTesting):
3252         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3253         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3254         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3255
3256 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3257
3258         Repurpose bots and clean up dashboard.
3259         https://bugs.webkit.org/show_bug.cgi?id=166045
3260
3261         Reviewed by Lucas Forschler.
3262
3263         * BuildSlaveSupport/build.webkit.org-config/config.json:
3264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3265         (BubbleQueueServer):
3266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3268         (WebKitBuildbot):
3269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3270         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3271
3272 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3273
3274         [CMake] TestWebKitAPIBase links to itself
3275         https://bugs.webkit.org/show_bug.cgi?id=165985
3276
3277         Reviewed by Alex Christensen.
3278
3279         Fix CMake warning about a target linking to itself, which makes no sense.
3280
3281         * TestWebKitAPI/CMakeLists.txt:
3282
3283 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3284
3285         [GTK] GtkDoc build should be quieter
3286         https://bugs.webkit.org/show_bug.cgi?id=165994
3287
3288         Reviewed by Carlos Garcia Campos.
3289
3290         Make it not print by default.
3291
3292         * gtk/generate-gtkdoc:
3293         (get_generator_for_config):
3294         (generate_doc):
3295         * gtk/gtkdoc.py:
3296         (GTKDoc._run_command):
3297         (GTKDoc._copy_doc_files_to_output_dir):
3298
3299 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3300
3301         Expose a way for MiniBrowser to simulate header and footer banners
3302         https://bugs.webkit.org/show_bug.cgi?id=166005
3303
3304         Reviewed by Wenson Hsieh.
3305         
3306         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3307         banners. This only works in WebKit2.
3308         
3309         We need to reset these on each navigation, since newly created FrameViews
3310         don't re-fetch the header and footer height stored on Page.
3311         
3312         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3313         as well as fixing webViewWebContentProcessDidTerminate:
3314
3315         * MiniBrowser/mac/SettingsController.h:
3316         * MiniBrowser/mac/SettingsController.m:
3317         (-[SettingsController _populateMenu]):
3318         (-[SettingsController validateMenuItem:]):
3319         (-[SettingsController toggleReserveSpaceForBanners:]):
3320         (-[SettingsController isSpaceReservedForBanners]):
3321         * MiniBrowser/mac/WK2BrowserWindowController.m:
3322         (-[WK2BrowserWindowController didChangeSettings]):
3323         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3324         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3325         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3326         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3327
3328 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3329
3330         Fix iOS test results after r209967.
3331         
3332         Subtracting out the status bar height was erroneously happening for all tests,
3333         not just for flexible viewport tests.
3334         
3335         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3336
3337         * WebKitTestRunner/PlatformWebView.h:
3338         * WebKitTestRunner/TestController.cpp:
3339         (WTR::TestController::resetStateToConsistentValues):
3340         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3341         (WTR::PlatformWebView::resizeTo):
3342         (WTR::PlatformWebView::setWindowFrame):
3343         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3344         (WTR::PlatformWebView::resizeTo):
3345         (WTR::PlatformWebView::setWindowFrame):
3346         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3347         (WTR::PlatformWebView::resizeTo):
3348         (WTR::PlatformWebView::setWindowFrame):
3349         * WebKitTestRunner/ios/TestControllerIOS.mm:
3350         (WTR::TestController::platformConfigureViewForTest):
3351         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3352         (WTR::PlatformWebView::resizeTo):
3353         (WTR::PlatformWebView::setWindowFrame):
3354
3355 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3356
3357         [EFL] bump EFL version to 1.18.4
3358         https://bugs.webkit.org/show_bug.cgi?id=166004
3359
3360         Reviewed by Gyuyoung Kim.
3361
3362         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3363
3364 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3365
3366         Visual viewports: bottom fixed elements disappear behind the keyboard
3367         https://bugs.webkit.org/show_bug.cgi?id=165983
3368         <rdar://problem/29409852>
3369
3370         Reviewed by Simon Fraser.
3371
3372         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
3373         the keyboard when it is up.
3374
3375         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3376         (WTR::UIScriptController::inputViewBounds):
3377         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3378         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3379         (WTR::UIScriptController::inputViewBounds):
3380         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3381         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3382         (WTR::viewRectForWindowRect):
3383
3384         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
3385         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
3386         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
3387
3388         (WTR::PlatformWebView::PlatformWebView):
3389         (WTR::PlatformWebView::setWindowFrame):
3390         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3391         (WTR::UIScriptController::inputViewBounds):
3392
3393 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3394
3395         Deleting a character converted from pinyin after an image causes a Safari crash
3396         https://bugs.webkit.org/show_bug.cgi?id=165839
3397         <rdar://problem/27951933>
3398
3399         Reviewed by Wenson Hsieh.
3400
3401         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
3402         while the proposed range contains an image. This should not cause a WebProcess to crash
3403         or send an invalid message to the UIProcess.
3404
3405         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3406         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
3407         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
3408         (TestWebKitAPI::didFinishLoadForFrame):
3409         (TestWebKitAPI::processDidCrash):
3410         (TestWebKitAPI::invalidMessageFunction):
3411         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
3412
3413 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3414
3415         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
3416         https://bugs.webkit.org/show_bug.cgi?id=165767
3417         <rdar://problem/29602382>
3418
3419         Reviewed by Simon Fraser.
3420
3421         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
3422         WebKit2 ChangeLog for more details.
3423
3424         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3425         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3426         (WTR::UIScriptController::textSelectionCaretRect):
3427         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3428         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3429         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3430         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3431         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3432         (WTR::UIScriptController::textSelectionCaretRect):
3433         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3434         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3435         (-[TestRunnerWKWebView _setStableStateOverride:]):
3436
3437         Force the WKWebView to update its visible content rects when changing the stable state override.
3438
3439         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3440         (WTR::toNSDictionary):
3441         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3442         (WTR::UIScriptController::selectionRangeViewRects):
3443         (WTR::UIScriptController::textSelectionCaretRect):
3444         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3445         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3446
3447 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
3448
3449         Arguments called in wrong order
3450         https://bugs.webkit.org/show_bug.cgi?id=165923
3451
3452         Reviewed by Simon Fraser.
3453
3454         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
3455         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
3456
3457         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3458         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
3459         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
3460
3461 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
3462
3463         [EFL] Disable non-srcdir builds for failing libraries
3464         https://bugs.webkit.org/show_bug.cgi?id=165896
3465
3466         Reviewed by Gyuyoung Kim.
3467
3468         * efl/jhbuild.modules: Set non srcdir builds to no
3469
3470 2016-12-15  Daniel Bates  <dabates@apple.com>
3471
3472         check-style should not complain about code in icu directories
3473         https://bugs.webkit.org/show_bug.cgi?id=53929
3474
3475         Reviewed by Darin Adler.
3476
3477         Skip style checking of imported ICU headers to avoid a deluge of style issues
3478         as they do not conform to the WebKit Code Style guideline. We want to preserve
3479         the formatting of these headers so as to make it straightforward to merge
3480         changes to them, if necessary.
3481
3482         * Scripts/webkitpy/style/checker.py:
3483
3484 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
3485
3486         Move JSC testers from Yosemite to Sierra
3487         https://bugs.webkit.org/show_bug.cgi?id=165925
3488
3489         Reviewed by Lucas Forschler.
3490
3491         * BuildSlaveSupport/build.webkit.org-config/config.json:
3492         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3493         (WebKitBuildbot):
3494
3495 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
3496
3497         Add coordinate space to event streams and streamline tests
3498         https://bugs.webkit.org/show_bug.cgi?id=165119
3499
3500         Reviewed by Simon Fraser.
3501
3502         Update event streams to allow for both content and global coordinate space.
3503         Update example script to more accurately show all the available options.
3504
3505         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3506         * WebKitTestRunner/ios/HIDEventGenerator.h:
3507         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3508         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3509         (WTR::convertCoordinates):
3510         (WTR::UIScriptController::sendEventStream):
3511
3512 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
3513
3514         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
3515         https://bugs.webkit.org/show_bug.cgi?id=165855
3516
3517         Reviewed by Philippe Normand.
3518
3519         GStreamer's autogen.sh enables gtk-doc always so we end up building
3520         docs even if we disable them. Use the configure script instead, since
3521         we build from packages and these include it already.
3522
3523         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
3524         upstream gstreamer packages.
3525
3526 2016-12-15  Alex Christensen  <achristensen@webkit.org>
3527
3528         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
3529         https://bugs.webkit.org/show_bug.cgi?id=165885
3530         <rdar://problem/29476917>
3531
3532         Reviewed by Darin Adler.
3533
3534         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3535         (TestWebKitAPI::utf16String): Deleted.
3536         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
3537         (TestWebKitAPI::TEST_F):
3538         * TestWebKitAPI/WTFStringUtilities.h:
3539         (utf16String):
3540         Moved from URLParser to share with other tests.
3541
3542 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3543
3544         iOS: An element with tabindex is not focusable unless there is no mouse event handler
3545         https://bugs.webkit.org/show_bug.cgi?id=165843
3546
3547         Reviewed by Antti Koivisto.
3548
3549         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
3550         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
3551         and DumpRenderTree's runUIScript would hit an assertion :(
3552
3553         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3554         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3555         (WTR::TestRunner::isWebKit2):
3556
3557 2016-12-14  Brady Eidson  <beidson@apple.com>
3558
3559         IndexedDB 2.0: Massively speedup IDBIndex.get().
3560         https://bugs.webkit.org/show_bug.cgi?id=165802
3561
3562         Reviewed by Alex Christensen.
3563
3564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3565         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
3566         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
3567         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
3568         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
3569
3570 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3571
3572         [GTK][EFL] Update the JHBuild version.
3573         https://bugs.webkit.org/show_bug.cgi?id=165838
3574
3575         Reviewed by Michael Catanzaro.
3576
3577         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
3578         usage of the JHBUILD_MIRROR feature with git repositories.
3579
3580 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3581
3582         [GTK] Yasm is needed for building the JHBuild after r208940
3583         https://bugs.webkit.org/show_bug.cgi?id=165837
3584
3585         Reviewed by Alejandro G. Castro.
3586
3587         * gtk/install-dependencies: Yasm is needed for building libvpx.
3588
3589 2016-12-14  Youenn Fablet  <youenn@apple.com>
3590
3591         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
3592         https://bugs.webkit.org/show_bug.cgi?id=161310
3593
3594         Reviewed by Ryosuke Niwa.
3595
3596         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
3597         When set, WTR and DRT output JS console log in the stderr and not the test output.
3598         This allows removing potentially flaky information while still being able to read it for investigation.
3599
3600         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
3601
3602         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
3603         This test should have this option when fetch API will start logging resource loader errors.
3604
3605         * DumpRenderTree/DumpRenderTree.h:
3606         (TestCommand::TestCommand): Deleted.
3607         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3608         (parseInputLine):
3609         * DumpRenderTree/TestRunner.h:
3610         (TestRunner::setDumpJSConsoleLogInStdErr):
3611         (TestRunner::dumpJSConsoleLogInStdErr):
3612         * DumpRenderTree/mac/DumpRenderTree.mm:
3613         (runTest):
3614         * DumpRenderTree/mac/UIDelegate.mm:
3615         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3616         * DumpRenderTree/win/DumpRenderTree.cpp:
3617         (runTest):
3618         * DumpRenderTree/win/UIDelegate.cpp:
3619         (UIDelegate::webViewAddMessageToConsole):
3620         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3621         (TestExpectationParser._tokenize_line):
3622         * Scripts/webkitpy/port/driver.py:
3623         (Driver._command_from_driver_input):
3624         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3625         (WTR::InjectedBundle::didReceiveMessageToPage):
3626         (WTR::InjectedBundle::dumpToStdErr):
3627         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3628         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
3629         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3630         (WTR::InjectedBundlePage::willAddMessageToConsole):
3631         * WebKitTestRunner/TestController.cpp:
3632         (WTR::parseInputLine):
3633         (WTR::TestController::runTest):
3634         (WTR::TestCommand::TestCommand): Deleted.
3635         * WebKitTestRunner/TestInvocation.cpp:
3636         (WTR::TestInvocation::invoke):
3637         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3638         * WebKitTestRunner/TestInvocation.h:
3639         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
3640
3641
3642 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
3643
3644         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
3645         https://bugs.webkit.org/show_bug.cgi?id=164022
3646
3647         Reviewed by Xabier Rodriguez-Calvar.
3648
3649         * Scripts/webkitperl/FeatureList.pm:
3650           Re-enable MEDIA_SOURCE for the GTK+ port.
3651
3652 2016-12-13  Alex Christensen  <achristensen@webkit.org>
3653
3654         Fix CMake build.
3655
3656         * DumpRenderTree/PlatformMac.cmake:
3657         Define NS_RETURNS_RETAINED as nothing for now.
3658
3659 2016-12-13  Jer Noble  <jer.noble@apple.com>
3660
3661         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
3662         https://bugs.webkit.org/show_bug.cgi?id=165697
3663
3664         Reviewed by Tim Horton.
3665
3666         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
3667         (TestWebKitAPI::TEST):
3668
3669 2016-12-13  Andy Estes  <aestes@apple.com>
3670
3671         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
3672         https://bugs.webkit.org/show_bug.cgi?id=165785
3673         <rdar://problem/26929398>
3674
3675         Reviewed by Darin Adler.
3676
3677         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3678         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
3679         expectations for the text, range, and action.
3680         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
3681         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
3682         plain-text string to the pasteboard, executed a paste action, and verified that the selected
3683         text in the web view did not change.
3684         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
3685         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
3686         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
3687         parameter.
3688         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
3689         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
3690         and returned the value of _editingDelegateShouldInsertText.
3691         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
3692         -shouldInsertText:replacingRange:givenAction:.
3693
3694 2016-12-13  Chris Dumez  <cdumez@apple.com>
3695
3696         Unreviewed, rolling out r209544.
3697
3698         Looks like r209489 did not cause the performance regression
3699         after all
3700
3701         Reverted changeset:
3702
3703         "Unreviewed, rolling out r209489."
3704         https://bugs.webkit.org/show_bug.cgi?id=165550
3705         http://trac.webkit.org/changeset/209544
3706
3707 2016-12-12  Sam Weinig  <sam@webkit.org>
3708
3709         [WebIDL] Remove use of Dictionary in ApplePaySession
3710         https://bugs.webkit.org/show_bug.cgi?id=165787
3711
3712         Reviewed by Anders Carlsson.
3713
3714         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3715         (WTR::initializeWebViewConfiguration):
3716         (WTR::TestController::platformCreateWebView):
3717         Enable ApplePay for the tests (where supported).
3718
3719 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
3720
3721         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3722         https://bugs.webkit.org/show_bug.cgi?id=165251
3723
3724         Reviewed by Youenn Fablet.
3725
3726         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
3727         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
3728         the preferences have been set.
3729
3730 2016-12-08  Antti Koivisto  <antti@apple.com>
3731
3732         Enable network cache speculative revalidation in MiniBrowser
3733         https://bugs.webkit.org/show_bug.cgi?id=165616
3734
3735         Reviewed by Darin Adler.
3736
3737         Match Safari. Also add a menu item to disable it.
3738
3739         * MiniBrowser/mac/AppDelegate.m:
3740         (defaultConfiguration):
3741         * MiniBrowser/mac/SettingsController.h:
3742         * MiniBrowser/mac/SettingsController.m:
3743         (-[SettingsController _populateMenu]):
3744         (-[SettingsController validateMenuItem:]):
3745         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
3746         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
3747
3748 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
3749
3750         ChangeLogs become readonly after resolving a conflict
3751         https://bugs.webkit.org/show_bug.cgi?id=165440
3752         rdar://problem/29491002
3753
3754         Reviewed by Darin Adler.
3755
3756         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
3757         moving the file.
3758
3759 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
3760
3761         Re-enable collectContinuously since it doesn't crash anymore
3762
3763         Rubber stamped by Michael Saboff.
3764
3765         * Scripts/run-jsc-stress-tests:
3766
3767 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
3768
3769         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
3770         https://bugs.webkit.org/show_bug.cgi?id=165686
3771
3772         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
3773         so that right config.h comes first in include path.
3774
3775 2016-12-11  Dave Hyatt  <hyatt@apple.com>
3776
3777         [CSS Parser] Make sure content extensions initialize AtomicString
3778         https://bugs.webkit.org/show_bug.cgi?id=165737
3779
3780         Reviewed by Darin Adler.
3781
3782         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3783         (TestWebKitAPI::makeBackend):
3784
3785 2016-12-08  Dave Hyatt  <hyatt@apple.com>
3786
3787         [CSS Parser] Remove the old CSS Parser
3788         https://bugs.webkit.org/show_bug.cgi?id=165645
3789
3790         Reviewed by Daniel Bates.
3791
3792         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
3793         (TestWebKitAPI::TEST):
3794
3795 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
3796
3797         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
3798         https://bugs.webkit.org/show_bug.cgi?id=165686
3799
3800         Reviewed by Michael Catanzaro.
3801
3802         This change reduces duplication of include path lists between modules,
3803         and reduces future need for fixes like r209605 (broken build because of
3804         WebCore header suddenly becoming used in WebKit2).
3805
3806         * DumpRenderTree/CMakeLists.txt:
3807         * DumpRenderTree/PlatformMac.cmake:
3808         * ImageDiff/CMakeLists.txt:
3809         * MiniBrowser/gtk/CMakeLists.txt:
3810         * MiniBrowser/mac/CMakeLists.txt:
3811         * MiniBrowser/win/CMakeLists.txt:
3812         * TestWebKitAPI/CMakeLists.txt:
3813         * TestWebKitAPI/PlatformEfl.cmake:
3814         * TestWebKitAPI/PlatformJSCOnly.cmake:
3815         * TestWebKitAPI/PlatformMac.cmake:
3816         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3817         * WebKitTestRunner/CMakeLists.txt:
3818         * WebKitTestRunner/PlatformGTK.cmake:
3819         * WebKitTestRunner/PlatformMac.cmake:
3820
3821 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
3822
3823         Unreviewed buildfix after r209630.
3824
3825         * Scripts/build-jsc: Remove building the non-existing testWASM.
3826
3827 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
3828
3829         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3830         https://bugs.webkit.org/show_bug.cgi?id=165251
3831
3832         Reviewed by Dean Jackson.
3833
3834         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
3835
3836         * DumpRenderTree/mac/DumpRenderTree.mm:
3837         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
3838
3839         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3840         (WTR::InjectedBundle::beginTesting): Ditto.
3841
3842         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3843         (WTR::TestRunner::setMediaStreamEnabled): New.
3844         (WTR::TestRunner::setPeerConnectionEnabled): New.
3845         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3846
3847 2016-12-09  Brady Eidson  <beidson@apple.com> 
3848  
3849         Re-landing:
3850         Add _WKIconLoadingDelegate SPI. 
3851         https://bugs.webkit.org/show_bug.cgi?id=164894 
3852  
3853         Reviewed by Alex Christensen. 
3854         
3855         Add MiniBrowser support for this new SPI, configurable with a setting. 
3856  
3857         * MiniBrowser/mac/SettingsController.h: 
3858         * MiniBrowser/mac/SettingsController.m: 
3859         (-[SettingsController _populateMenu]): 
3860         (-[SettingsController validateMenuItem:]): 
3861         (-[SettingsController loadsAllSiteIcons]): 
3862         (-[SettingsController toggleLoadsAllSiteIcons:]): 
3863         * MiniBrowser/mac/WK2BrowserWindowController.m: 
3864         (-[WK2BrowserWindowController awakeFromNib]): 
3865         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
3866
3867 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3868
3869         Fix the 32-bit build.
3870
3871         Unreviewed build fix.
3872
3873         * MiniBrowser/mac/SettingsController.h:
3874
3875 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3876
3877         Fedora also needs a PHP7 config file alternative
3878         https://bugs.webkit.org/show_bug.cgi?id=165606
3879
3880         Reviewed by Michael Catanzaro.
3881
3882         * Scripts/webkitpy/port/base.py:
3883         (Port._is_fedora_php_version_7): check for the php7 library.
3884         (Port._fedora_php_version): get the appropriate filename for Fedora.
3885         (Port._apache_config_file_name_for_platform):
3886
3887 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3888
3889         Complete the revert of r208865.
3890         https://bugs.webkit.org/show_bug.cgi?id=164894
3891
3892         Unreviewed build fix.
3893
3894         * MiniBrowser/mac/SettingsController.h:
3895         * MiniBrowser/mac/SettingsController.m:
3896         (-[SettingsController _populateMenu]):
3897         (-[SettingsController validateMenuItem:]):
3898         (-[SettingsController loadsAllSiteIcons]): Deleted.
3899         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
3900         * MiniBrowser/mac/WK2BrowserWindowController.m:
3901         (-[WK2BrowserWindowController awakeFromNib]):
3902         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
3903
3904 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3905
3906         [GTK] Force GDK backend to x11 when running with XvfbDriver
3907         https://bugs.webkit.org/show_bug.cgi?id=165612
3908
3909         Reviewed by Michael Catanzaro.
3910
3911         When the developer is running a Wayland session, GDK may get confused
3912         and try to use its Wayland backend (which is higher priority) instead.
3913         This ensures it will use the appropriate backend when running under
3914         Xvfb.
3915
3916         * Scripts/webkitpy/port/gtk.py:
3917         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
3918         force GDK_BACKEND to x11.
3919
3920 2016-12-08  Keith Miller  <keith_miller@apple.com>
3921
3922         Add 64-bit signed LEB decode method
3923         https://bugs.webkit.org/show_bug.cgi?id=165630
3924
3925         Reviewed by Ryosuke Niwa.
3926
3927         Add tests for LEB int64 and uint64 decode since I guess
3928         I forgot to add tests before.
3929
3930         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
3931         (TestWebKitAPI::testUInt32LEBDecode):
3932         (TestWebKitAPI::TEST):
3933         (TestWebKitAPI::testUInt64LEBDecode):
3934         (TestWebKitAPI::testInt32LEBDecode):
3935         (TestWebKitAPI::testInt64LEBDecode):
3936         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
3937
3938 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3939
3940         Make it easy to enable --force-collectContinuously
3941         https://bugs.webkit.org/show_bug.cgi?id=165638
3942
3943         Reviewed by Keith Miller.
3944
3945         * Scripts/run-javascriptcore-tests:
3946         (runJSCStressTests):
3947
3948 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3949
3950         Disable the collectContinuously mode until I investigate failures.
3951
3952         Rubber stamped by Keith Miller.
3953         
3954         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
3955         while I investigate.
3956
3957         * Scripts/run-jsc-stress-tests:
3958
3959 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3960
3961         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
3962         https://bugs.webkit.org/show_bug.cgi?id=165621
3963
3964         Reviewed by Dan Bernstein.
3965
3966         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3967         (TestWebKitAPI::TEST_F):
3968
3969 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
3970
3971         Concurrent GC should be stable enough to land enabled
3972         https://bugs.webkit.org/show_bug.cgi?id=164990
3973
3974         Reviewed by Geoffrey Garen.
3975         
3976         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
3977         
3978         It's clear that this works just fine in release, but I'm still trying to figure out if it's
3979         safe for debug. It might be too slow for debug.
3980
3981         * Scripts/run-jsc-stress-tests:
3982
3983 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3984
3985         Add SPI for sending WebsiteSettings to WebProcess during navigation
3986         https://bugs.webkit.org/show_bug.cgi?id=165517
3987         <rdar://29341068>
3988
3989         Reviewed by Anders Carlsson.
3990
3991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3992         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
3993         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
3994         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3995         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3996         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3997         (TEST):
3998
3999 2016-12-08  Chris Dumez  <cdumez@apple.com>
4000
4001         Unreviewed, rolling out r209489.
4002
4003         Likely caused large regressions on JetStream, Sunspider and
4004         Speedometer
4005
4006         Reverted changeset:
4007
4008         "Add system trace points for JavaScript VM entry/exit"
4009         https://bugs.webkit.org/show_bug.cgi?id=165550
4010         http://trac.webkit.org/changeset/209489
4011
4012 2016-12-08  Keith Miller  <keith_miller@apple.com>
4013
4014         Move LEB tests to API tests
4015         https://bugs.webkit.org/show_bug.cgi?id=165586
4016
4017         Reviewed by Saam Barati.
4018
4019         Move the tests from testWasm.cpp and make them functions
4020         rather than macros.
4021
4022         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4023         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
4024         (TestWebKitAPI::testUnsignedLEBDecode):
4025         (TestWebKitAPI::TEST):
4026         (TestWebKitAPI::testInt32LEBDecode):
4027
4028 2016-12-08  Chris Dumez  <cdumez@apple.com>
4029
4030         Support running the layout tests offline
4031         https://bugs.webkit.org/show_bug.cgi?id=165534
4032
4033         Reviewed by Ryosuke Niwa.
4034
4035         * Scripts/webkitpy/common/system/autoinstall.py:
4036         (AutoInstaller._download_to_stream):
4037         getcode() returns None for file URLs so handle this.
4038
4039         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
4040         (WebPlatformTestServer._install_modules):
4041         Deal with local path in the json file and resolve them into file URLs
4042         before using AutoInstall.
4043
4044 2016-12-08  Alex Christensen  <achristensen@webkit.org>
4045
4046         Fix CMake build.
4047
4048         * DumpRenderTree/PlatformMac.cmake:
4049         Remove CheckedMalloc.cpp after r209516.
4050
4051 2016-12-07  Mark Lam  <mark.lam@apple.com>
4052
4053         DumpRenderTree should stop using CheckedMalloc.
4054         https://bugs.webkit.org/show_bug.cgi?id=165563
4055         <rdar://problem/28945820>
4056
4057         Reviewed by Geoffrey Garen.
4058
4059         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
4060            in CheckedMalloc.
4061         2. bmalloc does not honor the settings of CheckedMalloc.
4062
4063         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
4064         malloc.  As a result, DRT exhibits different behavior from the normal way we run
4065         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
4066         with WKTR.
4067
4068         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4069         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
4070         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
4071         * DumpRenderTree/mac/DumpRenderTree.mm:
4072         (prepareConsistentTestingEnvironment):
4073
4074 2016-12-07  Dean Jackson  <dino@apple.com>
4075
4076         Remove runtime toggle for pointer-lock
4077         https://bugs.webkit.org/show_bug.cgi?id=165577
4078         <rdar://problems/29566996>
4079
4080         Reviewed by Jon Lee.
4081
4082         Remove any runtime calls to check if pointer-lock is enabled. It's
4083         either compiled in or out.
4084
4085         * DumpRenderTree/mac/DumpRenderTree.mm:
4086         (resetWebPreferencesToConsistentValues):
4087         * WebKitTestRunner/TestController.cpp:
4088         (WTR::TestController::resetPreferencesToConsistentValues):
4089
4090 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
4091
4092         [MediaStream][Mac] Revoke sandbox extensions when capture ends
4093         https://bugs.webkit.org/show_bug.cgi?id=165476
4094
4095         Reviewed by Brady Eidson.
4096         
4097         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
4098         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
4099         is reset and recreated when a web page exits and is reloaded.
4100
4101         * TestWebKitAPI/PlatformGTK.cmake:
4102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4103         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
4104         (TestWebKitAPI::checkUserMediaPermissionCallback):
4105         (TestWebKitAPI::TEST):
4106         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
4107
4108 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
4109
4110         One esc to exit fullscreen and pointer lock
4111         https://bugs.webkit.org/show_bug.cgi?id=165416
4112         rdar://problem/29430711
4113
4114         Reviewed by Jer Noble.
4115
4116         Implement WKPageUIClientV8 for pointer lock support.
4117         Add "escape" key support in EventSenderProxy.
4118
4119         * WebKitTestRunner/TestController.cpp:
4120         (WTR::requestPointerLock):
4121         (WTR::TestController::createOtherPage):
4122         (WTR::TestController::createWebViewWithOptions):
4123         * WebKitTestRunner/mac/EventSenderProxy.mm:
4124         (WTR::EventSenderProxy::keyDown):
4125
4126 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
4127
4128         Add system trace points for JavaScript VM entry/exit
4129         https://bugs.webkit.org/show_bug.cgi?id=165550
4130
4131         Reviewed by Tim Horton.
4132
4133         Add trace points for entry/exit into/out of the JS VM.
4134
4135         * Tracing/SystemTracePoints.plist:
4136
4137 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
4138
4139         [GTK] Cannot build GTK+ with CUPS 2.* versions
4140         https://bugs.webkit.org/show_bug.cgi?id=163591
4141
4142         Reviewed by Michael Catanzaro.
4143
4144         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
4145         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
4146         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
4147         old gtk+ since it requires not only bumping up glib accordingly and its consequence
4148         causes many printing test failures. So, I propose to fix the configuration issue by
4149         applying the change to the configure file directly. By doing this, we don't need to
4150         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
4151
4152         * gtk/jhbuild.modules:
4153         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
4154
4155 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
4156
4157         Fix use of enum in a WK2 C SPI header.
4158         rdar://problem/28725583
4159
4160         Followup to correctly prefix the enum values.
4161
4162         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4163         (WTR::InjectedBundlePage::prepare):
4164
4165 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
4166
4167         Fix use of enum in a WK2 C SPI header.
4168         rdar://problem/28725583
4169
4170         Reviewed by Dan Bernstein.
4171
4172         Use correct enum style for a C SPI header and fix the callers.
4173
4174         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4175         (WTR::InjectedBundlePage::prepare):
4176
4177 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
4178
4179         Add a new project for recording and playing back editing commands in editable web content
4180         https://bugs.webkit.org/show_bug.cgi?id=165114
4181         <rdar://problem/29408135>
4182
4183         Reviewed by Beth Dakin.
4184
4185         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
4186         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
4187         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
4188         then be dragged into the playback test harness.
4189
4190         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
4191         steps:
4192
4193         1. Load the capture harness and perform test-specific editing on the web view.
4194         2. Let originalState be a dump of the DOM at this point in time.
4195         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
4196         4. Rewind all editing to the beginning.
4197         5. Playback all editing to the end.
4198         6. Dump the state of the DOM. This should be identical to originalState.
4199
4200         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
4201         * EditingHistory/EditingHistory/Info.plist: Added.
4202         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
4203         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
4204         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
4205         * EditingHistory/EditingHistory/TestRunner.h: Added.
4206         * EditingHistory/EditingHistory/TestRunner.m: Added.
4207         (injectedMessageEventHandlerScript):
4208         (-[TestRunner init]):
4209         (-[TestRunner deleteBackwards:]):
4210         (-[TestRunner typeString:]):
4211         (-[TestRunner bodyElementSubtree]):
4212         (-[TestRunner bodyTextContent]):
4213         (-[TestRunner editingHistoryJSON]):
4214         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
4215         (-[TestRunner numberOfUpdates]):
4216         (-[TestRunner jumpToUpdateIndex:]):
4217         (-[TestRunner expectEvents:afterPerforming:]):
4218         (-[TestRunner loadCaptureTestHarness]):
4219         (-[TestRunner setTextObfuscationEnabled:]):
4220         (-[TestRunner isDoneWaitingForPendingEvents]):
4221         (-[TestRunner userContentController:didReceiveScriptMessage:]):
4222
4223         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
4224         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
4225
4226         * EditingHistory/EditingHistory/TestUtil.h: Added.
4227         * EditingHistory/EditingHistory/TestUtil.m: Added.
4228         (waitUntilWithTimeout):
4229         (waitUntil):
4230
4231         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
4232
4233         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
4234         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
4235         (-[WKWebView loadPageFromBundleNamed:]):
4236         (-[WKWebView typeCharacter:]):
4237         (-[WKWebView keyPressWithCharacters:keyCode:]):
4238         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
4239
4240         Provides utilities for simulating interaction in a web view.
4241
4242         * EditingHistory/EditingHistory/main.m: Added.
4243         (main):
4244         * EditingHistory/EditingHistoryTests/Info.plist: Added.
4245         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
4246         (-[RewindAndPlaybackTests setUp]):
4247         (-[RewindAndPlaybackTests tearDown]):
4248         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
4249         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
4250         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
4251         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
4252         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
4253
4254 2016-12-07  Philippe Normand  <pnormand@igalia.com>
4255
4256         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
4257         https://bugs.webkit.org/show_bug.cgi?id=165525
4258
4259         Reviewed by Carlos Garcia Campos.
4260
4261         * gtk/jhbuild.modules: gst-plugins-good should depend on the
4262         libvpx package built within jhbuild.
4263
4264 2016-12-07  Philippe Normand  <pnormand@igalia.com>
4265
4266         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
4267         https://bugs.webkit.org/show_bug.cgi?id=165520
4268
4269         Reviewed by Carlos Garcia Campos.
4270
4271         * gtk/jhbuild.modules: Added missing dependency on openh264 in
4272         gst-plugins-bad, along with 2 upstream patches fixing the build
4273         against OpenSSL 1.1.0.
4274         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
4275         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
4276
4277 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
4278
4279         Correct SDKROOT values in xcconfig files
4280         https://bugs.webkit.org/show_bug.cgi?id=165487
4281         rdar://problem/29539209
4282
4283         Reviewed by Dan Bernstein.
4284
4285         Fix suggested by Dan Bernstein.
4286
4287         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
4288         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4289         * MiniBrowser/Configurations/DebugRelease.xcconfig:
4290         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
4291         * WebEditingTester/Configurations/DebugRelease.xcconfig:
4292         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4293
4294 2016-12-06  Daniel Bates  <dabates@apple.com>
4295
4296         WebKitTestRunner: Plugins are disabled in new windows
4297         https://bugs.webkit.org/show_bug.cgi?id=165410
4298
4299         Reviewed by Alex Christensen.
4300
4301         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
4302         a new window and loads a plugin will fail. We should enable plugins in all windows by
4303         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
4304
4305         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
4306         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
4307         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
4308
4309         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4310         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
4311         WKBundleSetPluginsEnabled().
4312         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4313         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()