Add enum traits and use them in the IPC::Decoder
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-23  Anders Carlsson  <andersca@apple.com>
2
3         Add enum traits and use them in the IPC::Decoder
4         https://bugs.webkit.org/show_bug.cgi?id=161103
5
6         Reviewed by Sam Weinig.
7
8         Add API test.
9
10         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11         * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
12         (TestWebKitAPI::TEST):
13
14 2016-08-24  Filip Pizlo  <fpizlo@apple.com>
15
16         Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
17
18         * DumpRenderTree/TestRunner.cpp:
19         * DumpRenderTree/mac/DumpRenderTree.mm:
20         (DumpRenderTreeMain):
21         * Scripts/run-jsc-stress-tests:
22         * TestWebKitAPI/Tests/WTF/Vector.cpp:
23         (TestWebKitAPI::TEST):
24
25 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
26
27         Try to fix Production builds.
28         
29         PRODUCTION_FRAMEWORKS_DIR was undefined here.
30
31         * DumpRenderTree/mac/Configurations/Base.xcconfig:
32
33 2016-08-24  Dan Bernstein  <mitz@apple.com>
34
35         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
36         https://bugs.webkit.org/show_bug.cgi?id=161152
37
38         Reviewed by Anders Carlsson.
39
40         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
41         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
42         (TestWebKitAPI::didFinishLoadForFrame):
43         (TestWebKitAPI::TEST):
44
45 2016-08-24  Nan Wang  <n_wang@apple.com>
46
47         AX: Add test for line text marker range on iOS
48         https://bugs.webkit.org/show_bug.cgi?id=161108
49         <rdar://problem/27976405>
50
51         Reviewed by Chris Fleizach.
52
53         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
54         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
55         (AccessibilityUIElement::textMarkerRangeForElement):
56         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
57         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
58         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
59
60 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
61
62         [Win] Warning fixes.
63         https://bugs.webkit.org/show_bug.cgi?id=161079
64
65         Reviewed by Brent Fulgham.
66
67         * MiniBrowser/win/WebDownloadDelegate.cpp:
68         * MiniBrowser/win/WinMain.cpp:
69         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
70         (TestWebKitAPI::TEST):
71
72 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
73
74         Fix Windows DRT build.
75
76         * DumpRenderTree/win/TestRunnerWin.cpp:
77         (TestRunner::mainFrameJSContext):
78
79 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
80
81         Try to fix Windows build.
82         
83         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
84         so that perl finds CodeGeneratorDumpRenderTree.pm.
85
86         * DumpRenderTree/CMakeLists.txt:
87
88 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
89
90         Hook up UIScriptController in DumpRenderTree
91         https://bugs.webkit.org/show_bug.cgi?id=161064
92
93         Reviewed by Sam Weinig.
94
95         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
96         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
97         in fast/harness which test this.
98
99         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
100
101         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
102         WK2-isms. Fix the makefiles to refer to the new location.
103
104         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
105         by ID and firing them once they are complete.
106
107         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
108         * DumpRenderTree/CMakeLists.txt:
109         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
110         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
111         * DumpRenderTree/TestRunner.cpp:
112         (runUIScriptCallback):
113         (TestRunner::staticFunctions):
114         (TestRunner::cacheTestRunnerCallback):
115         (TestRunner::callTestRunnerCallback):
116         (TestRunner::clearTestRunnerCallbacks):
117         (nextUIScriptCallbackID):
118         (TestRunner::runUIScript):
119         (TestRunner::callUIScriptCallback):
120         (TestRunner::uiScriptDidComplete):
121         (TestRunner::cleanup):
122         * DumpRenderTree/TestRunner.h:
123         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
124         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
125         * DumpRenderTree/mac/DumpRenderTree.mm:
126         (runTest):
127         * DumpRenderTree/mac/TestRunnerMac.mm:
128         (TestRunner::mainFrameJSContext):
129         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
130         (WTR::UIScriptController::doAsyncTask):
131         * DumpRenderTree/win/DumpRenderTree.cpp:
132         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
133         (WTR::JSWrappable::~JSWrappable):
134         (WTR::JSValueMakeStringOrNull):
135         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
136         (WTR::JSWrapper::wrap):
137         (WTR::JSWrapper::unwrap):
138         (WTR::unwrapObject):
139         (WTR::JSWrapper::initialize):
140         (WTR::JSWrapper::finalize):
141         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
142         (WTR::toJS):
143         (WTR::setProperty):
144         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
145         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
146         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
147         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
148         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
149         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
150         * WebKitTestRunner/CMakeLists.txt:
151         * WebKitTestRunner/DerivedSources.make:
152         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
153         (WTR::JSWrappable::~JSWrappable): Deleted.
154         (WTR::JSValueMakeStringOrNull): Deleted.
155         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
156         (WTR::JSWrapper::wrap): Deleted.
157         (WTR::JSWrapper::unwrap): Deleted.
158         (WTR::unwrapObject): Deleted.
159         (WTR::JSWrapper::initialize): Deleted.
160         (WTR::JSWrapper::finalize): Deleted.
161         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
162         (WTR::toJS): Deleted.
163         (WTR::setProperty): Deleted.
164         * WebKitTestRunner/TestInvocation.cpp:
165         (WTR::TestInvocation::runUISideScript):
166         (WTR::TestInvocation::uiScriptDidComplete):
167         * WebKitTestRunner/TestInvocation.h:
168         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
169         * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
170         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
171         * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
172         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
173         * WebKitTestRunner/config.h:
174         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
175         (WTR::UIScriptController::contentVisibleRect):
176
177 2016-08-23  Saam Barati  <sbarati@apple.com>
178
179         JSC should have a "microbenchmarks" directory instead of "regress" directory
180         https://bugs.webkit.org/show_bug.cgi?id=161096
181
182         Rubber stamped by Mark Lam.
183
184         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
185         directory and removes all the related html and txt files. I did this because
186         that directory was only there for microbenchmarks, and not for "regression"
187         tests. I also changed the various scripts to point to it.
188
189         * Scripts/run-javascriptcore-tests:
190         (runJSCStressTests):
191         * Scripts/run-jsc-benchmarks:
192
193 2016-08-23  Alex Christensen  <achristensen@webkit.org>
194
195         Fix EFL build.
196
197         * TestWebKitAPI/CMakeLists.txt:
198         Include new directory.
199
200 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
201
202         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
203         https://bugs.webkit.org/show_bug.cgi?id=160125
204
205         Reviewed by Geoffrey Garen.
206
207         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
208         * Scripts/run-jsc-stress-tests: New test flag!
209
210 2016-08-23  Brady Eidson  <beidson@apple.com>
211
212         WK2 Gamepad layout test support.
213         https://bugs.webkit.org/show_bug.cgi?id=134671
214
215         Reviewed by Alex Christensen.
216         
217         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then 
218         feed back into the UIGamepadProvider.
219         
220         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
221         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
222
223         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
224         
225         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
226         (WTR::TestRunner::setMockGamepadDetails):
227         (WTR::TestRunner::setMockGamepadAxisValue):
228         (WTR::TestRunner::setMockGamepadButtonValue):
229         
230         * WebKitTestRunner/PlatformWebView.h:
231         
232         * WebKitTestRunner/TestController.cpp:
233         (WTR::TestController::initialize):
234         
235         * WebKitTestRunner/TestInvocation.cpp:
236         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
237         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
238         
239         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
240         
241         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
242         (-[WebKitTestRunnerWindow initWithFrame:]):
243         (-[WebKitTestRunnerWindow dealloc]):
244         (WTR::PlatformWebView::keyWindow):
245         
246         * WebKitTestRunner/ios/TestControllerIOS.mm:
247         (WTR::wtr_NSApplication_keyWindow):
248         (WTR::TestController::platformInitialize):
249         
250         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
251         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
252         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
253         (-[WebKitTestRunnerWindow dealloc]):
254         (WTR::PlatformWebView::keyWindow):
255         
256         * WebKitTestRunner/mac/TestControllerMac.mm:
257         (WTR::wtr_NSApplication_keyWindow):
258         (WTR::TestController::platformInitialize):
259         * WebKitTestRunner/mac/main.mm:
260
261 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
262
263         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
264         https://bugs.webkit.org/show_bug.cgi?id=161047
265         rdar://problem/27434307
266
267         Reviewed by Lucas Forschler.
268
269         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
270
271 2016-08-23  Chris Dumez  <cdumez@apple.com>
272
273         Unreviewed, rolling out r204243.
274
275         Caused some layout test failures
276
277         Reverted changeset:
278
279         "Write API test to cover crash fix in r204135"
280         https://bugs.webkit.org/show_bug.cgi?id=160587
281         http://trac.webkit.org/changeset/204243
282
283 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
284
285         Order feature option list in FeatureList.pm
286         https://bugs.webkit.org/show_bug.cgi?id=161074
287
288         Reviewed by Michael Catanzaro.
289
290         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
291
292         * Scripts/webkitperl/FeatureList.pm:
293
294 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
295
296         Stop python icon bouncing in the dock while running browser benchmarks.
297         https://bugs.webkit.org/show_bug.cgi?id=161066
298
299         Reviewed by Ryosuke Niwa.
300
301         Bouncing python icon may impact browser benchmark results.
302         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
303         (OSXBrowserDriver.prepare_env):
304         (OSXBrowserDriver.restore_env):
305
306 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
307
308         <select> menu on iPad causes shifting of hit-testing areas
309         https://bugs.webkit.org/show_bug.cgi?id=150079
310
311         Reviewed by Tim Horton.
312
313         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
314         so when it changes we have to update visible rects. We were doing this on focus, but failing
315         to do it on blur.
316
317         Added the ability to test by:
318         1. Making it possible to initiate an animated scroll in the UI process
319         2. Adding callbacks for starting and ending interaction with a form control. Sadly
320         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
321         have no way currently to know when the dimming view behind the popover animates out,
322         so for now the test keeps trying to tap a button.
323
324         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
325         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
326         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
327         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
328         (WTR::UIScriptController::didStartFormControlInteractionCallback):
329         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
330         (WTR::UIScriptController::didEndFormControlInteractionCallback):
331         (WTR::UIScriptController::scrollToOffset):
332         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
333         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
334         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
335         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
336         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
337         (-[TestRunnerWKWebView dealloc]):
338         (-[TestRunnerWKWebView didStartFormControlInteraction]):
339         (-[TestRunnerWKWebView didEndFormControlInteraction]):
340         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
341         (WTR::contentOffsetBoundedInValidRange):
342         (WTR::UIScriptController::scrollToOffset):
343         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
344         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
345
346 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
347
348         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
349         https://bugs.webkit.org/show_bug.cgi?id=160927
350
351         Reviewed by Daniel Bates.
352
353         * Scripts/process-linux-coredump: Removed.
354         * Scripts/webkitpy/port/efl.py:
355         (EflPort._get_crash_log):
356         * Scripts/webkitpy/port/gtk.py:
357         (GtkPort._get_crash_log):
358         * Scripts/webkitpy/port/linux_get_crash_log.py:
359         (GDBCrashLogGenerator.__init__):
360         (GDBCrashLogGenerator.generate_crash_log):
361         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
362         (GDBCrashLogGeneratorTest.test_generate_crash_log):
363
364 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
365
366         check-webkit-style does not work with Lambda functions in C++
367         https://bugs.webkit.org/show_bug.cgi?id=160910
368
369         Reviewed by Darin Adler.
370
371         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
372
373         * Scripts/webkitpy/style/checkers/cpp.py:
374         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
375         (check_for_non_standard_constructs): Added lambda function check.
376         (check_spacing_for_function_call): Added lambda function check.
377         (check_braces): Added lambda function check.
378         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
379         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
380
381 2016-08-21  Alex Christensen  <achristensen@webkit.org>
382
383         URLParser should parse IPv4 addresses
384         https://bugs.webkit.org/show_bug.cgi?id=161023
385
386         Reviewed by Darin Adler.
387
388         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
389         (TestWebKitAPI::TEST_F):
390         (TestWebKitAPI::checkURLDifferences):
391         We are already getting differences between the old URL::parse and the new URLParser.
392         (TestWebKitAPI::shouldFail):
393
394 2016-08-21  Daniel Bates  <dabates@apple.com>
395
396         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
397         https://bugs.webkit.org/show_bug.cgi?id=148437
398
399         Reviewed by Dan Bernstein.
400
401         * Scripts/prepare-ChangeLog:
402         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
403         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
404         assumes that its line ranges were from a unified diff without any context lines.
405         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
406         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
407         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
408         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
409         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
410         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
411         to /dev/null for the duration of the function call.
412
413 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
414
415         [EFL] Remove unnecessary a patch to mute ecore warnings
416         https://bugs.webkit.org/show_bug.cgi?id=160997
417
418         Reviewed by Darin Adler.
419
420         There is no warning messages during the layout test and perf test
421         after bumping efl version from 1.17 to 1.18. Remove it.
422
423         * efl/patches/ecore_remove_warnings.patch: Removed.
424
425 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
426
427         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
428         https://bugs.webkit.org/show_bug.cgi?id=160985
429
430         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
431         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
432         with that.
433
434         * Scripts/webkitpy/layout_tests/views/printing.py:
435         (Printer.print_config):
436         * Scripts/webkitpy/port/base.py:
437         (Port.driver_cmd_line_for_logging):
438         (Port.driver_cmd_line): Deleted.
439         * Scripts/webkitpy/port/driver.py:
440         (IOSSimulatorDriver.cmd_line):
441         * Scripts/webkitpy/port/ios.py:
442         (IOSSimulatorPort.__init__):
443         (IOSSimulatorPort.driver_cmd_line_for_logging):
444         (IOSSimulatorPort._create_simulators):
445         (IOSSimulatorPort.setup_test_run):
446         (IOSSimulatorPort._quit_ios_simulator):
447         (IOSSimulatorPort.clean_up_test_run):
448         (IOSSimulatorPort._create_device):
449         (IOSSimulatorPort):
450         (IOSSimulatorPort._remove_device):
451         (IOSSimulatorPort._testing_device):
452         (IOSSimulatorPort.device_id_for_worker_number):
453         (IOSSimulatorPort._set_device_class): Deleted.
454         (IOSSimulatorPort.testing_device): Deleted.
455         * Scripts/webkitpy/port/port_testcase.py:
456         (PortTestCase.test_driver_cmd_line):
457         * Scripts/webkitpy/xcode/simulator.py:
458         (Device.shutdown):
459         (Device):
460         (Device.delete):
461         (Device.reset):
462         (Simulator):
463         (Simulator.create_device):
464         (Simulator.remove_device):
465         (Simulator.device_number):
466         (Simulator.device_state_description):
467         (Simulator.wait_until_device_is_in_state):
468
469 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
470
471         Unreviewed, rolling out r204659.
472
473         This change appears to have caused ios-simulator LayoutTests
474         to fail when shutting down the simulator
475
476         Reverted changeset:
477
478         "REGRESSION (r204477): Running LayoutTests on ios-simulator
479         became ~15 minutes slower"
480         https://bugs.webkit.org/show_bug.cgi?id=160985
481         http://trac.webkit.org/changeset/204659
482
483 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
484
485         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
486         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
487
488 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
489
490         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
491         https://bugs.webkit.org/show_bug.cgi?id=160985
492
493         Reviewed by Alexey Proskuryakov.
494         
495         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
496         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
497         must not be @memoized, because their return value depends on the value of simulator_device_type().
498         
499         Fix by adding some global state in simulator.py that tracks the created devices 
500         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
501         and delete them in clean_up_test_run().
502         
503         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
504         that killing the Simulator apps isn't enough.
505         
506         Simulator tracks the devices in a global dictionary, since state needs to persist
507         across different instances of IOSSimulatorPort.
508         
509         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
510         any setup. Rather than implicitly creating a device here (which the old code did),
511         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
512         and set flag to say that device_id_for_worker_number() doesn't need to return a real
513         device id.
514
515         * Scripts/webkitpy/layout_tests/views/printing.py:
516         (print_options):
517         (Printer.print_config):
518         * Scripts/webkitpy/port/base.py:
519         (Port.driver_cmd_line_for_logging):
520         (Port.driver_cmd_line): Deleted.
521         * Scripts/webkitpy/port/driver.py:
522         (IOSSimulatorDriver.cmd_line):
523         * Scripts/webkitpy/port/ios.py:
524         (IOSSimulatorPort.__init__):
525         (IOSSimulatorPort.driver_cmd_line_for_logging):
526         (IOSSimulatorPort._create_simulators):
527         (IOSSimulatorPort.setup_test_run):
528         (IOSSimulatorPort.clean_up_test_run):
529         (IOSSimulatorPort._create_device):
530         (IOSSimulatorPort):
531         (IOSSimulatorPort._remove_device):
532         (IOSSimulatorPort._testing_device):
533         (IOSSimulatorPort.device_id_for_worker_number):
534         (IOSSimulatorPort._set_device_class): Deleted.
535         (IOSSimulatorPort.testing_device): Deleted.
536         * Scripts/webkitpy/port/port_testcase.py:
537         (PortTestCase.test_driver_cmd_line):
538         * Scripts/webkitpy/xcode/simulator.py:
539         (Device.shutdown):
540         (Device.delete):
541         (Device.reset):
542         (Simulator.create_device):
543         (Simulator.remove_device):
544         (Simulator.device_number):
545         (Simulator.device_state_description):
546         (Simulator.wait_until_device_is_in_state):
547
548 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
549
550         Adopt SimServiceContext in LayoutTestRelay
551         https://bugs.webkit.org/show_bug.cgi?id=161000
552         <rdar://problem/25765594>
553
554         Reviewed by Daniel Bates.
555
556         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
557         * LayoutTestRelay/LayoutTestRelay/main.m:
558
559 2016-08-19  Lucas Forschler  <lforschler@apple.com>
560
561         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
562
563         Reviewed by Kocsen Chung.
564
565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
566         (WebKitBuildbot):
567
568 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
569
570         Partial revert of r203811 - this key is not needed.
571
572         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
573
574 2016-08-19  Daniel Bates  <dabates@apple.com>
575
576         Another attempt to fix the iOS 9.3 build
577
578         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
579
580         * DumpRenderTree/mac/Configurations/Base.xcconfig:
581         * WebKitTestRunner/Configurations/Base.xcconfig:
582
583 2016-08-19  Lucas Forschler  <lforschler@apple.com>
584
585         Remove Yosemite Leaks bot from config.json
586         
587         Reviewed by Alexey Proskuryakov.
588
589         * BuildSlaveSupport/build.webkit.org-config/config.json:
590
591 2016-08-18  Dan Bernstein  <mitz@apple.com>
592
593         [Cocoa] API::Number needs to be wrapped by an NSNumber
594         https://bugs.webkit.org/show_bug.cgi?id=160977
595         <rdar://problem/27877735>
596
597         Reviewed by Anders Carlsson.
598
599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
600         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
601         (TestWebKitAPI::TEST):
602
603 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
604
605         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
606         https://bugs.webkit.org/show_bug.cgi?id=160895
607
608         Reviewed by Dean Jackson.
609
610         Link to the existing CoreText framework.
611
612         * DumpRenderTree/PlatformWin.cmake:
613         * TestWebKitAPI/PlatformWin.cmake:
614
615 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
616
617         [Win] Remove old libraries from build inputs
618         https://bugs.webkit.org/show_bug.cgi?id=160949
619
620         Reviewed by Dean Jackson.
621
622         Modify the download script to remove the old 'icuuc.lib' and
623         'icuin.lib' files for Windows builds.
624
625         * Scripts/update-webkit-auxiliary-libs:
626
627 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
628
629         Extra logging for crash reason
630         https://bugs.webkit.org/show_bug.cgi?id=160943
631
632         Reviewed by Alexey Proskuryakov.
633
634         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
635
636         * Scripts/webkitpy/port/server_process.py:
637         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
638         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
639         (ServerProcess.has_crashed): Ditto.
640
641 2016-08-17  Dan Bernstein  <mitz@apple.com>
642
643         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
644         https://bugs.webkit.org/show_bug.cgi?id=160938
645         <rdar://problem/27876652>
646
647         Reviewed by Anders Carlsson.
648
649         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
650         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
651         (TestWebKitAPI::TEST):
652
653 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
654
655         AX: Support abbreviations in iOS
656         https://bugs.webkit.org/show_bug.cgi?id=160907
657
658         Reviewed by Joanmarie Diggs.
659
660         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
661         (AccessibilityUIElement::stringAttributeValue):
662         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
663         (WTR::AccessibilityUIElement::stringAttributeValue):
664
665 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
666
667         [EFL] Bump efl version from 1.17 to 1.18
668         https://bugs.webkit.org/show_bug.cgi?id=160899
669
670         Reviewed by Antonio Gomes.
671
672         To use efl-1.18, EFL port needs to update install dependencies as well.
673
674         * efl/install-dependencies:
675         * efl/jhbuild.modules:
676
677 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
678
679         [Win] Add tests for linked fonts.
680         https://bugs.webkit.org/show_bug.cgi?id=160898
681
682         Reviewed by Brent Fulgham.
683
684         Add tests for https://trac.webkit.org/changeset/204502.
685
686         * TestWebKitAPI/PlatformWin.cmake:
687         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
688         (TestWebKitAPI::TEST):
689
690 2016-08-16  Daniel Bates  <dabates@apple.com>
691
692         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
693         https://bugs.webkit.org/show_bug.cgi?id=160924
694
695         Reviewed by Stephanie Lewis.
696
697         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
698         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
699         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
700         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
701         object that mocks out the file system and SCM operations.
702
703         * Scripts/VCSUtils.pm:
704         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
705         * Scripts/prepare-ChangeLog:
706         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
707         abstracting the logic to query the file system and SCM into functions on a delegate object that
708         we pass to it.
709         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
710         (diffHeaderFormat): Deleted.
711
712 2016-08-16  Alex Christensen  <achristensen@webkit.org>
713
714         URLParser should parse URLs without credentials
715         https://bugs.webkit.org/show_bug.cgi?id=160913
716
717         Reviewed by Brady Eidson.
718
719         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
720         (TestWebKitAPI::s):
721         (TestWebKitAPI::checkURL):
722         (TestWebKitAPI::TEST_F):
723
724 2016-08-16  Anders Carlsson  <andersca@apple.com>
725
726         Add WTF::ScopeExit
727         https://bugs.webkit.org/show_bug.cgi?id=160908
728
729         Reviewed by Geoffrey Garen.
730
731         * TestWebKitAPI/CMakeLists.txt:
732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
733         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
734         (TestWebKitAPI::TEST):
735
736 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
737
738         EWS logs file are rotated too quickly
739         https://bugs.webkit.org/show_bug.cgi?id=160724
740
741         Reviewed by Daniel Bates.
742
743         Currently we are rotating the log file after 10 iterations of queue. If the queue
744         doesn't have any pending patches, these iterations result in very small amount of 
745         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
746         This results in a lot of log files in a day. This patch ensures that we rotate the
747         log file when its file size is greater than or equal to 100 KB.
748
749         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
750
751 2016-08-16  Daniel Bates  <dabates@apple.com>
752
753         WKSI static library should be named by major iOS revision, not individual updates
754         https://bugs.webkit.org/show_bug.cgi?id=160727
755         <rdar://problem/22274848>
756
757         Reviewed by Alexey Proskuryakov.
758
759         * DumpRenderTree/mac/Configurations/Base.xcconfig:
760         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
761         * Scripts/copy-webkitlibraries-to-product-directory:
762         * WebKitTestRunner/Configurations/Base.xcconfig:
763         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
764
765 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
766
767         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
768         https://bugs.webkit.org/show_bug.cgi?id=160909
769
770         Reviewed by Enrica Casucci.
771         
772         Add functions to UIScriptController to dismiss the form accessory view for iOS,
773         and to programmatically pick a row from a <select> picker.
774
775         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
776         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
777         (WTR::UIScriptController::dismissFormAccessoryView):
778         (WTR::UIScriptController::selectFormAccessoryPickerRow):
779         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
780         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
781         (WTR::UIScriptController::dismissFormAccessoryView):
782         (WTR::UIScriptController::selectFormAccessoryPickerRow):
783
784 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
785
786         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
787         https://bugs.webkit.org/show_bug.cgi?id=160878
788
789         Reviewed by Tim Horton.
790         
791         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
792         now that we have the ability to run tests in the iPad simulator.
793
794         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
795         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
796         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
797         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
798         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
799         * WebKitTestRunner/ios/TestControllerIOS.mm:
800         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
801         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
802         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
803         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
804
805 2016-08-15  Anders Carlsson  <andersca@apple.com>
806
807         Add an address-of operator to RetainPtr
808         https://bugs.webkit.org/show_bug.cgi?id=160879
809
810         Reviewed by Tim Horton.
811
812         Test HashMap and HashSet with an object whose operator& is deleted.
813
814         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
815         Sort the Xcode project.
816
817         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
818         (DeletedAddressOfOperator::DeletedAddressOfOperator):
819         (DeletedAddressOfOperator::value):
820         (DeletedAddressOfOperator::operator==):
821         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
822         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
823         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
824         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
825         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
826         (TestWebKitAPI::TEST):
827         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
828         (TestWebKitAPI::TEST):
829
830 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
831
832         False crashes in fast/text/emoji-gender-* tests
833         https://bugs.webkit.org/show_bug.cgi?id=160779
834
835         Reviewed by Alexey Proskuryakov.
836
837         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
838
839         * Scripts/webkitpy/port/driver.py:
840         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
841         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
842         * Scripts/webkitpy/port/server_process.py:
843         (ServerProcess.write): Allow caller to disable crash flag on exception.
844
845 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
846
847         webkitpy error in TestRunResults.merge()
848         https://bugs.webkit.org/show_bug.cgi?id=160882
849
850         Reviewed by Daniel Bates.
851         
852         The argument to TestRunResults.merge() can be None if there are no device-specifc
853         initial results or retry results in Manager.run(), so just return early in that case.
854
855         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
856         (TestRunResults.merge):
857
858 2016-08-15  Sam Weinig  <sam@webkit.org>
859
860         Speed up compile times by not including wtf/Variant.h so much
861         https://bugs.webkit.org/show_bug.cgi?id=160847
862
863         Reviewed by Alex Christensen and Saam Barati.
864
865         * TestWebKitAPI/Tests/WTF/Variant.cpp:
866         (TestWebKitAPI::TEST):
867         Explicitly use std::experimental::variant.
868
869 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
870
871         Allow a port to run tests with a custom device setup
872         https://bugs.webkit.org/show_bug.cgi?id=160833
873
874         Reviewed by Daniel Bates.
875
876         These changes allow the IOSSimulator port to run tests in iPad mode.
877
878         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
879         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
880         a custom device will be collected into a set, and run in that device's environment after
881         the other tests have run.
882
883         * Scripts/webkitpy/layout_tests/controllers/manager.py:
884         (Manager._custom_device_for_test): If the test contains a directory matching a
885         custom device suffix, return that custom device.
886         (Manager._set_up_run): Push the custom device class, if any, into options so
887         that the Worker can get to it.
888         (Manager.run): Go through the list of tests, and break it down into device-generic
889         tests, and tests for each device class. _run_test_subset is then called for
890         each collection of tests, and the results merged.
891         (Manager._run_test_subset): Some lines unwrapped.
892         (Manager._end_test_run):
893         (Manager._run_tests):
894         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
895         (SingleTestRunner.__init__): Unwrapped a line.
896         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
897         (TestRunResults.merge): Add this function to merge TestRunResults
898         * Scripts/webkitpy/layout_tests/views/printing.py:
899         (Printer.print_workers_and_shards): Print the custom device, if any.
900         * Scripts/webkitpy/port/base.py:
901         (Port): Base port has empty array of custom devices.
902         (Port.setup_test_run): Add device_class argument.
903         * Scripts/webkitpy/port/driver.py:
904         (DriverInput.__repr__):
905         (Driver.check_driver.implementation):
906         * Scripts/webkitpy/port/efl.py:
907         (EflPort.setup_test_run):
908         * Scripts/webkitpy/port/gtk.py:
909         (GtkPort.setup_test_run):
910         * Scripts/webkitpy/port/ios.py:
911         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
912         (IOSSimulatorPort.__init__):
913         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
914         based on the custom device class.
915         (IOSSimulatorPort._set_device_class):
916         (IOSSimulatorPort._create_simulators): Factor some code into this function.
917         (IOSSimulatorPort.setup_test_run):
918         (IOSSimulatorPort.testing_device):
919         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
920         seemed wrong for this function. That was moved to setup_test_run().
921         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
922         but this happened too early, before we knew which kind of devices to create. Devices
923         are now created in setup_test_run().
924         * Scripts/webkitpy/port/win.py:
925         (WinPort.setup_test_run):
926
927 2016-08-15  Daniel Bates  <dabates@apple.com>
928
929         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
930         private frameworks and libraries
931         https://bugs.webkit.org/show_bug.cgi?id=155931
932         <rdar://problem/25807989>
933
934         Reviewed by Dan Bernstein.
935
936         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
937         where X is the major version of the active iOS SDK.
938
939         * DumpRenderTree/mac/Configurations/Base.xcconfig:
940         * WebKitTestRunner/Configurations/Base.xcconfig:
941
942 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
943
944         Add a setting and preferences to enable visual viewport mode
945         https://bugs.webkit.org/show_bug.cgi?id=160843
946
947         Reviewed by Sam Weinig.
948         
949         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
950
951         * MiniBrowser/mac/SettingsController.h:
952         * MiniBrowser/mac/SettingsController.m:
953         (-[SettingsController _populateMenu]):
954         (-[SettingsController validateMenuItem:]):
955         (-[SettingsController visualViewportEnabled]):
956         (-[SettingsController toggleVisualViewportEnabled:]):
957         * MiniBrowser/mac/WK1BrowserWindowController.m:
958         (-[WK1BrowserWindowController didChangeSettings]):
959         * MiniBrowser/mac/WK2BrowserWindowController.m:
960         (-[WK2BrowserWindowController didChangeSettings]):
961
962 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
963
964         Allow using make-dist with non-GTK ports
965         https://bugs.webkit.org/show_bug.cgi?id=160842
966
967         Reviewed by Michael Catanzaro.
968
969         This patch adds support for setting base name of tarball and argument
970         passed to cmake's -DPORT= via command line arguments.
971
972         * gtk/make-dist.py:
973         (Distcheck.configure):
974         (Distcheck.check):
975         (get_tarball_root_and_output_filename_from_arguments):
976
977 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
978
979         [GTK] Install script lacks gstreamer related dependencies
980         https://bugs.webkit.org/show_bug.cgi?id=160814
981
982         Reviewed by Carlos Garcia Campos.
983
984         * gtk/install-dependencies: Fedora case had already listed this dependencies,
985         but both Arch and Debian/Ubuntu were missing them.
986
987 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
988
989         make-dist.py should not allow unknown rules in manifest
990         https://bugs.webkit.org/show_bug.cgi?id=160841
991
992         Reviewed by Carlos Garcia Campos.
993
994         * gtk/make-dist.py:
995         (Manifest.process_line):
996
997 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
998
999         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
1000         https://bugs.webkit.org/show_bug.cgi?id=160809
1001
1002         Reviewed by Carlos Garcia Campos.
1003
1004         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
1005         case, and use it also for the new package names of libpng and libgeoclue.
1006         * gtk/install-dependencies: Ditto.
1007
1008 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1009
1010         Skip to check directories existence in build-webkit
1011         https://bugs.webkit.org/show_bug.cgi?id=160691
1012
1013         Reviewed by Alex Christensen.
1014
1015         CMake checks if directories are there itself. So CMake ports
1016         don't need to check it in the build-webkit script.
1017
1018         * Scripts/build-webkit:
1019         * Scripts/webkitdirs.pm:
1020         (determineSourceDir):
1021         (isCMakeBuild):
1022
1023 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1024
1025         Make URLParser work with URLs missing URL parts
1026         https://bugs.webkit.org/show_bug.cgi?id=160824
1027
1028         Reviewed by Brady Eidson.
1029
1030         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1031         (TestWebKitAPI::s):
1032         (TestWebKitAPI::checkURL):
1033         (TestWebKitAPI::TEST_F):
1034         (TestWebKitAPI::eq): Deleted.
1035
1036 2016-08-12  John Wilander  <wilander@apple.com>
1037
1038         Add HashCountedSet API tests to TestWTFLibrary target
1039         https://bugs.webkit.org/show_bug.cgi?id=160815
1040
1041         Reviewed by Alex Christensen.
1042
1043         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1044             Added HashCountedSet.cpp and sorted the file reference section
1045             according to UNIX sort.
1046
1047 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
1048
1049         run-benchmark should run JetStream 1.1 instead of 1.0.1
1050         https://bugs.webkit.org/show_bug.cgi?id=160816
1051
1052         Reviewed by Filip Pizlo.
1053
1054         Use the latest JetStream 1.1 in run-benchmark.
1055
1056         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1057         (BenchmarkBuilder.__exit__):
1058         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
1059         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
1060         change to JetStream directory.
1061
1062 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1063
1064         Initial URLParser implementation
1065         https://bugs.webkit.org/show_bug.cgi?id=160811
1066
1067         Reviewed by Brady Eidson.
1068
1069         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1070         (TestWebKitAPI::eq):
1071         (TestWebKitAPI::checkURL):
1072         (TestWebKitAPI::TEST_F):
1073
1074 2016-08-12  Brady Eidson  <beidson@apple.com>
1075
1076         Fix the 32-bit Mac build after:
1077         Add WK2 ExperimentalFeature support to MiniBrowser
1078         https://bugs.webkit.org/show_bug.cgi?id=160788
1079
1080         Unreviewed.
1081
1082         Sprinkle "#if WK_API_ENABLED"s liberally.
1083         
1084         * MiniBrowser/mac/AppDelegate.m:
1085         (defaultConfiguration):
1086         * MiniBrowser/mac/SettingsController.m:
1087         (-[SettingsController _populateMenu]):
1088         (-[SettingsController validateMenuItem:]):
1089
1090 2016-08-12  Philippe Normand  <pnormand@igalia.com>
1091
1092         [GStreamer][OWR] Video rendering fixes
1093         https://bugs.webkit.org/show_bug.cgi?id=160764
1094
1095         Reviewed by Xabier Rodriguez-Calvar.
1096
1097         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
1098
1099 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
1100
1101         Add missing return statement in convertFast function added in r204376.
1102
1103         Unreviewed.
1104
1105         * Scripts/webkitpy/common/system/path.py:
1106         (_CygPath.convertFast):
1107
1108 2016-08-11  Brady Eidson  <beidson@apple.com>
1109
1110         Add WK2 ExperimentalFeature support to MiniBrowser.
1111         https://bugs.webkit.org/show_bug.cgi?id=160788
1112
1113         Reviewed by Alex Christensen.
1114
1115         * MiniBrowser/mac/AppDelegate.h:
1116         * MiniBrowser/mac/AppDelegate.m:
1117         (defaultConfiguration):
1118         (defaultPreferences):
1119         
1120         * MiniBrowser/mac/SettingsController.m:
1121         (-[SettingsController _populateMenu]):
1122         (-[SettingsController validateMenuItem:]):
1123         (-[SettingsController toggleExperimentalFeature:]):
1124
1125 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1126
1127         Keep EWS logs for longer
1128         https://bugs.webkit.org/show_bug.cgi?id=160776
1129
1130         Reviewed by Daniel Bates.
1131
1132         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
1133
1134 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
1135
1136         iOS DRT/WTR project cleanup
1137         https://bugs.webkit.org/show_bug.cgi?id=160778
1138
1139         Reviewed by Tim Horton.
1140
1141         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
1142
1143         Remove AppDelegate.* which were unused.
1144
1145         Exclude ios/Launch.storyboard on more platforms.
1146
1147         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1148         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1149         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1150         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1151         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
1152         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
1153         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
1154
1155 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1156
1157         Fix Yosemite bots' cookie accept policies after r204365.
1158         https://bugs.webkit.org/show_bug.cgi?id=160758
1159
1160         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1161         (TEST):
1162         This makes the test fully clean up after itself.
1163
1164 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1165
1166         Fix Yosemite bots' cookie accept policies after r204365.
1167         https://bugs.webkit.org/show_bug.cgi?id=160758
1168
1169         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1170         (TEST):
1171         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
1172         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
1173         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
1174         causing any problems because there are no other API tests that do anything with cookies.
1175         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
1176         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
1177         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
1178
1179 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1180
1181         EWS should check if the patch is still valid before executing every major step
1182         https://bugs.webkit.org/show_bug.cgi?id=160739
1183         rdar://problem/27768813
1184
1185         Reviewed by Alexey Proskuryakov.
1186
1187         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1188         (CommitQueueTask.run): validate method is now executed in base class.
1189         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1190         (EarlyWarningSystemTask.run): validate method is now executed in base class.
1191         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1192         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
1193         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1194         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
1195         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
1196         * Scripts/webkitpy/tool/commands/perfalizer.py:
1197         (PerfalizerTask.validate): Added.
1198         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1199         (test_manual_reject_during_processing): Updated test case.
1200
1201 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1202
1203         Add URLParser stub
1204         https://bugs.webkit.org/show_bug.cgi?id=160770
1205
1206         Reviewed by Sam Weinig.
1207
1208         * TestWebKitAPI/PlatformGTK.cmake:
1209         * TestWebKitAPI/PlatformWin.cmake:
1210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1211         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
1212         (TestWebKitAPI::TEST_F):
1213
1214 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1215
1216         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
1217         https://bugs.webkit.org/show_bug.cgi?id=160761
1218
1219         Reviewed by Tim Horton.
1220
1221         Give iOS DRT a Launch storyboard.
1222
1223         Have it use a UIViewController so future forms testing works correctly.
1224
1225         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
1226         can run in iPad mode.
1227
1228         Remove empty InfoPlist.strings files.
1229
1230         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1231         * DumpRenderTree/ios/Info.plist:
1232         * DumpRenderTree/ios/Launch.storyboard: Added.
1233         * DumpRenderTree/mac/DumpRenderTree.mm:
1234         (createWebViewAndOffscreenWindow):
1235         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1236         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
1237         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1238         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
1239
1240 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
1241
1242         [Win] Unable to reliably run tests in parallel
1243         https://bugs.webkit.org/show_bug.cgi?id=140914
1244
1245         Reviewed by Brent Fulgham.
1246
1247         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1248         processes. We can use string replacement to convert the Cygwin path to a Windows path
1249         instead.
1250
1251         * Scripts/webkitpy/common/system/path.py:
1252         (cygpathFast):
1253         * Scripts/webkitpy/port/driver.py:
1254         (Driver._command_from_driver_input):
1255
1256 2016-08-10  Alex Christensen  <achristensen@webkit.org>
1257
1258         Fix crash when changing cookie accept policy after r204327
1259         https://bugs.webkit.org/show_bug.cgi?id=160758
1260
1261         Reviewed by Simon Fraser.
1262
1263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1264         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
1265         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
1266         (TEST):
1267         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
1268
1269 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1270
1271         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
1272         https://bugs.webkit.org/show_bug.cgi?id=160757
1273
1274         Reviewed by Tim Horton.
1275
1276         When programmatically creating the test UIWindow, make a root UIViewController and parent
1277         the WKWebView in its view. This makes the app more like a normal UIKit application.
1278         
1279         Move the WKWebView down 20px to avoid the status bar.
1280         
1281         Give the UIWindow a gray background so it's obvious where the window and view positioned.
1282
1283         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
1284         
1285         Remove duplicate references to Launch.storyboard.
1286
1287         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1288         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
1289         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
1290         (-[AppDelegate applicationWillResignActive:]): Deleted.
1291         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
1292         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
1293         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
1294         (-[AppDelegate applicationWillTerminate:]): Deleted.
1295         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1296         (WTR::viewRectForWindowRect):
1297         (WTR::PlatformWebView::PlatformWebView):
1298         (WTR::PlatformWebView::setWindowFrame):
1299
1300 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1301
1302         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
1303         https://bugs.webkit.org/show_bug.cgi?id=160748
1304
1305         Reviewed by Tim Horton.
1306         
1307         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
1308         opens the door for tests using other device sizes.
1309
1310         * WebKitTestRunner/ios/TestControllerIOS.mm:
1311         (WTR::TestController::platformConfigureViewForTest):
1312
1313 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1314
1315         Sort the feature flags in the FEATURE_DEFINES lines
1316         https://bugs.webkit.org/show_bug.cgi?id=160742
1317
1318         Reviewed by Anders Carlsson.
1319         
1320         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1321
1322 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
1323
1324         Logging and other minor improvements to iOS webkitpy
1325         https://bugs.webkit.org/show_bug.cgi?id=160722
1326
1327         Reviewed by Dan Bates.
1328
1329         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
1330         to make it easier to debug launching issues.
1331
1332         Have reset_preferences() reset the device, rather than just nuking the data
1333         directory (which broke some versions of the simulator).
1334
1335         Make the Simulator.app launch in the background with open -g.
1336
1337         Wait for the simulator device to be in a known state in some more places.
1338
1339         * Scripts/webkitpy/port/ios.py:
1340         (IOSSimulatorPort.setup_test_run):
1341         (IOSSimulatorPort._quit_ios_simulator):
1342         (IOSSimulatorPort.clean_up_test_run):
1343         (IOSSimulatorPort.setup_environ_for_server):
1344         (IOSSimulatorPort.reset_preferences):
1345         * Scripts/webkitpy/xcode/simulator.py:
1346         (Device.create):
1347         (Device.delete):
1348         (Device):
1349         (Device.reset):
1350         (Simulator.wait_until_device_is_booted):
1351         (Simulator.wait_until_device_is_in_state):
1352         (Simulator):
1353         (Simulator.delete_device):
1354         (Simulator.reset_device):
1355         (Simulator.lookup_or_create_device):
1356
1357 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1358
1359         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
1360         https://bugs.webkit.org/show_bug.cgi?id=160697
1361
1362         Reviewed by Antonio Gomes.
1363
1364         * Scripts/webkitpy/port/base.py:
1365         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
1366         list of environment variables to copy.
1367
1368 2016-08-09  George Ruan  <gruan@apple.com>
1369
1370         Implement functionality of media capture on iOS
1371         https://bugs.webkit.org/show_bug.cgi?id=158945
1372         <rdar://problem/26893343>
1373
1374         Reviewed by Tim Horton.
1375
1376         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
1377         Capture feature on iOS.
1378
1379 2016-08-09  Saam Barati  <sbarati@apple.com>
1380
1381         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
1382         https://bugs.webkit.org/show_bug.cgi?id=160671
1383         <rdar://problem/27756112>
1384
1385         Reviewed by Mark Lam.
1386
1387         * Scripts/run-jsc-stress-tests:
1388
1389 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
1390
1391         Make directory reading code in iOSSimulatorDevices() more strict
1392         https://bugs.webkit.org/show_bug.cgi?id=160702
1393
1394         Reviewed by Tim Horton.
1395
1396         * Scripts/webkitdirs.pm:
1397         (iOSSimulatorDevices):
1398
1399 2016-08-06  Sam Weinig  <sam@webkit.org>
1400
1401         Replace NodeOrString with std::variant<RefPtr<Node>, String>
1402         https://bugs.webkit.org/show_bug.cgi?id=160638
1403
1404         Reviewed by Anders Carlsson.
1405
1406         * TestWebKitAPI/CMakeLists.txt:
1407         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1408         Add additional tests for the initial state of std::variant and using
1409         makeVisitor for visiting.
1410
1411 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
1412
1413         EWS logging should ensure the logging to file is stopped on queue termination
1414         https://bugs.webkit.org/show_bug.cgi?id=160698
1415         rdar://problem/24464570
1416
1417         Reviewed by Daniel Bates.
1418
1419         * Scripts/webkitpy/tool/bot/queueengine.py:
1420         (QueueEngine._stopping): Stop logging to file on queue termination.
1421         (QueueEngine._begin_logging): Configure the Python logger to log to file.
1422         * Scripts/webkitpy/common/system/logutils.py:
1423         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
1424         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1425         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
1426         * Scripts/webkitpy/tool/commands/queues.py:
1427         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
1428         (AbstractQueue.queue_log_path): Same.
1429         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
1430         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
1431         which moved to QueueEngine now.
1432         (PatchProcessingQueue.__init__): Same.
1433         (CommitQueue.__init__): Same.
1434         (AbstractReviewQueue.__init__): Same.
1435         (StyleQueue.__init__): Same.
1436         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1437         (TestCommitQueue): Removed host parameter.
1438         (TestCommitQueue.__init__): Same.
1439         (AbstractPatchQueueTest.test_next_patch): Same.
1440         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1441         (test_commit_queue_failure): Same.
1442         (mock_run_webkit_patch):
1443         (MockCommitQueueTask.results_from_patch_test_run): Same.
1444         (test_rollout_lands): Same.
1445         (test_non_valid_patch): Same.
1446         (test_auto_retry): Same.
1447         (test_style_queue_with_watch_list_exception): Same.
1448         (TestQueue.__init__): Deleted.
1449         (TestReviewQueue.__init__): Deleted.
1450         (TestFeederQueue.__init__): Deleted.
1451
1452 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
1453
1454         webkit-gtk tarball fails to build due to missing files
1455         https://bugs.webkit.org/show_bug.cgi?id=160684
1456
1457         Reviewed by Alex Christensen.
1458
1459         * gtk/manifest.txt.in: Added back spi directories.
1460
1461 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1462
1463         [GTK] Build the jhbuild with -O2 optimization level by default
1464         https://bugs.webkit.org/show_bug.cgi?id=160544
1465
1466         Reviewed by Michael Catanzaro.
1467
1468         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
1469         which don't increases the required disk space significatively and
1470         provides better debug information than no passing it.
1471
1472 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
1473
1474         Allow more --cmakeargs option in build-jsc and build-webkit
1475         https://bugs.webkit.org/show_bug.cgi?id=160340
1476
1477         Reviewed by Michael Catanzaro.
1478
1479         * Scripts/build-jsc:
1480         * Scripts/build-webkit:
1481
1482 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1483
1484         Do not check if WebKitLibraries folder exists on EFL and GTK
1485         https://bugs.webkit.org/show_bug.cgi?id=160659
1486
1487         Reviewed by Csaba Osztrogonác.
1488
1489         Though WebKitLibraries is only needed by mac and win ports,
1490         EFL and GTK ports have checked whether it exists.
1491
1492         * Scripts/build-webkit:
1493
1494 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
1495
1496         Some EWS console logs doesn't go to log file
1497         https://bugs.webkit.org/show_bug.cgi?id=160585
1498         rdar://problem/24464570
1499
1500         Reviewed by Daniel Bates.
1501
1502         * Scripts/webkitpy/common/system/logutils.py:
1503         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
1504         any possible overwriting.
1505         * Scripts/webkitpy/common/system/filesystem.py:
1506         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
1507         * Scripts/webkitpy/common/system/filesystem_mock.py:
1508         (MockFileSystem.open_text_file_for_writing): Same.
1509         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1510         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
1511         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
1512         * Scripts/webkitpy/tool/commands/queues.py:
1513         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
1514         This will ensure that all the sub-modules inside webkitpy will log to file.
1515
1516 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
1517
1518         Have the iOS platform interit from the Apple platform in webkitpy
1519         https://bugs.webkit.org/show_bug.cgi?id=160672
1520
1521         Reviewed by Dan Bates.
1522         
1523         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
1524         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
1525         ApplePort.
1526         
1527         Since WinPort also inherits from ApplePort, it needs to stub out some things
1528         that are unavailable on Windows (leaks, sampling).
1529         
1530         Some SnowLeopard-related code and the associated test were removed.
1531
1532         * Scripts/webkitpy/port/apple.py:
1533         (ApplePort.__init__):
1534         (ApplePort):
1535         (ApplePort._make_leak_detector):
1536         (ApplePort.default_timeout_ms):
1537         (ApplePort.supports_per_test_timeout):
1538         (ApplePort.should_retry_crashes):
1539         (ApplePort._generate_all_test_configurations):
1540         (ApplePort.check_for_leaks):
1541         (ApplePort.print_leaks_summary):
1542         (ApplePort._path_to_webcore_library):
1543         (ApplePort.show_results_html_file):
1544         (ApplePort._merge_crash_logs):
1545         (ApplePort._look_for_all_crash_logs_in_log_dir):
1546         (ApplePort._get_crash_log):
1547         (ApplePort.look_for_new_crash_logs):
1548         (ApplePort.sample_process):
1549         (ApplePort.sample_file_path):
1550         (ApplePort.look_for_new_samples):
1551         (ApplePort._path_to_helper):
1552         (ApplePort.determine_full_port_name): Deleted.
1553         * Scripts/webkitpy/port/ios.py:
1554         (IOSSimulatorPort):
1555         (IOSSimulatorPort.__init__):
1556         (IOSSimulatorPort.default_timeout_ms): Deleted.
1557         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
1558         (IOSSimulatorPort.should_retry_crashes): Deleted.
1559         (IOSSimulatorPort.check_for_leaks): Deleted.
1560         (IOSSimulatorPort.print_leaks_summary): Deleted.
1561         (IOSSimulatorPort._path_to_webcore_library): Deleted.
1562         (IOSSimulatorPort.show_results_html_file): Deleted.
1563         (IOSSimulatorPort.sample_file_path): Deleted.
1564         (IOSSimulatorPort._merge_crash_logs): Deleted.
1565         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
1566         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
1567         (IOSSimulatorPort.look_for_new_samples): Deleted.
1568         (IOSSimulatorPort.sample_process): Deleted.
1569         (IOSSimulatorPort._path_to_helper): Deleted.
1570         (IOSSimulatorPort.make_command): Deleted.
1571         * Scripts/webkitpy/port/mac.py:
1572         (MacPort.__init__):
1573         (MacPort.make_command):
1574         (MacPort._build_java_test_support):
1575         (MacPort): Deleted.
1576         (MacPort.default_timeout_ms): Deleted.
1577         (MacPort.supports_per_test_timeout): Deleted.
1578         (MacPort.should_retry_crashes): Deleted.
1579         (MacPort.default_child_processes): Deleted.
1580         (MacPort.check_for_leaks): Deleted.
1581         (MacPort.print_leaks_summary): Deleted.
1582         (MacPort._path_to_webcore_library): Deleted.
1583         (MacPort.show_results_html_file): Deleted.
1584         (MacPort.sample_file_path): Deleted.
1585         (MacPort._merge_crash_logs): Deleted.
1586         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
1587         (MacPort.look_for_new_crash_logs): Deleted.
1588         (MacPort.look_for_new_samples): Deleted.
1589         (MacPort.sample_process): Deleted.
1590         (MacPort._path_to_helper): Deleted.
1591         * Scripts/webkitpy/port/mac_unittest.py:
1592         (MacTest.test_default_child_processes): Deleted.
1593         * Scripts/webkitpy/port/win.py:
1594         (WinPort.look_for_new_samples):
1595         (WinPort):
1596         (WinPort.sample_process):
1597         (WinPort._make_leak_detector):
1598         (WinPort.check_for_leaks):
1599         (WinPort.print_leaks_summary):
1600         (WinPort._path_to_webcore_library):
1601
1602 2016-08-08  Matt Baker  <mattbaker@apple.com>
1603
1604         Unreviewed: moved myself to the reviewers list.
1605
1606         * Scripts/webkitpy/common/config/contributors.json:
1607
1608 2016-08-08  Chris Dumez  <cdumez@apple.com>
1609
1610         Update API tests in mac/SetDocumentURI.mm after r204247
1611         https://bugs.webkit.org/show_bug.cgi?id=160660
1612
1613         Reviewed by Alex Christensen.
1614
1615         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1616         (TestWebKitAPI::TEST):
1617
1618 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
1619
1620         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
1621         https://bugs.webkit.org/show_bug.cgi?id=159827
1622
1623         Reviewed by Daniel Bates.
1624
1625         This change was spurred by a process hang which occurred between tests and did
1626         not produce a meaningful crashlog.
1627
1628         * Scripts/webkitpy/port/driver.py:
1629         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
1630
1631          * Scripts/webkitpy/port/ios.py:
1632         (IOSSimulatorPort):
1633         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
1634         * Scripts/webkitpy/port/mac.py:
1635         (MacPort):
1636         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
1637
1638         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
1639         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1640
1641         * WebKitTestRunner/TestController.h:
1642         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1643         * WebKitTestRunner/TestInvocation.cpp:
1644         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1645
1646 2016-08-07  Dan Bernstein  <mitz@apple.com>
1647
1648         [Cocoa] Reply block leaks if the remote object doesn’t call it
1649         https://bugs.webkit.org/show_bug.cgi?id=160642
1650
1651         Reviewed by Sam Weinig.
1652
1653         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
1654         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1655         (TEST): Added a test case that checks that the reply block is released even when it’s not
1656           called.
1657         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1658         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
1659           calling the completion handler.
1660
1661 2016-08-07  Chris Dumez  <cdumez@apple.com>
1662
1663         Write API test to cover crash fix in r204135
1664         https://bugs.webkit.org/show_bug.cgi?id=160587
1665
1666         Reviewed by Darin Adler.
1667
1668         Add API test to cover crash fix in r204135. This reproduces the crash
1669         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1670         callback.
1671
1672         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1673         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1674         (TEST):
1675
1676 2016-08-06  Chris Dumez  <cdumez@apple.com>
1677
1678         Unreviewed, rolling out r204226.
1679
1680         Broke some API tests
1681
1682         Reverted changeset:
1683
1684         "Write API test to cover crash fix in r204135"
1685         https://bugs.webkit.org/show_bug.cgi?id=160587
1686         http://trac.webkit.org/changeset/204226
1687
1688 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
1689
1690         EWS Style Queue fails to process patches which fails validation
1691         https://bugs.webkit.org/show_bug.cgi?id=160632
1692
1693         Reviewed by Alexey Proskuryakov.
1694
1695         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1696         (StyleQueueTask.validate): Add more information about validation failure.
1697         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1698         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1699         (test_non_valid_patch): Add a unit test to test the above code path.
1700
1701 2016-08-06  Sam Weinig  <sam@webkit.org>
1702
1703         WTF needs a variant implementation
1704         https://bugs.webkit.org/show_bug.cgi?id=160618
1705
1706         Reviewed by Darin Adler.
1707
1708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1709         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
1710         Add tests for the variant implementation.
1711
1712 2016-08-06  Chris Dumez  <cdumez@apple.com>
1713
1714         Write API test to cover crash fix in r204135
1715         https://bugs.webkit.org/show_bug.cgi?id=160587
1716
1717         Reviewed by Darin Adler.
1718
1719         Add API test to cover crash fix in r204135. This reproduces the crash
1720         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1721         callback.
1722
1723         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1724         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1725         (TEST):
1726
1727 2016-08-05  Tim Horton  <timothy_horton@apple.com>
1728
1729         run-api-tests should use a headed simulator
1730         https://bugs.webkit.org/show_bug.cgi?id=160611
1731
1732         Reviewed by Sam Weinig.
1733
1734         CADisplayLink doesn't work in a headless simulator, but is
1735         vital for the proper functioning of WebKit2 painting on iOS.
1736         So, we should not use a headless simulator.
1737
1738         * Scripts/run-api-tests:
1739         Launch a simulator app, don't just boot the simulator.
1740
1741         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1742         Re-enable a test that works now.
1743
1744 2016-08-05  Dan Bernstein  <mitz@apple.com>
1745
1746         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
1747         https://bugs.webkit.org/show_bug.cgi?id=160589
1748
1749         Reviewed by Tim Horton.
1750
1751         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1752         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
1753           blocks, which wasn’t caught because the test wasn’t run correctly.
1754         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1755         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
1756           added a test that sends over an NSRange.
1757         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1758         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
1759           handler with the range‘s location and length.
1760
1761 2016-08-05  Enrica Casucci  <enrica@apple.com>
1762
1763         Fixing tests failing after r204175.
1764
1765         Unreviewed.
1766
1767         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
1768
1769 2016-08-05  Enrica Casucci  <enrica@apple.com>
1770
1771         Build fix after 204053.
1772
1773         Unreviewed.
1774
1775         * TestWebKitAPI/Configurations/Base.xcconfig:
1776         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1777         (-[MockContentFilterEnabler initWithCoder:]):
1778         (-[MockContentFilterEnabler dealloc]):
1779
1780 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
1781
1782         Print test name in "Last character read from DRT..." error message.
1783         https://bugs.webkit.org/show_bug.cgi?id=160559
1784
1785         Reviewed by Michael Catanzaro.
1786
1787         * Scripts/webkitpy/port/driver.py:
1788         (Driver.run_test):
1789         (Driver._read_first_block):
1790         (Driver._read_optional_image_block):
1791         (Driver._read_block):
1792         * Scripts/webkitpy/port/driver_unittest.py:
1793         (DriverTest.test_read_block):
1794         (DriverTest.test_read_binary_block):
1795         (DriverTest.test_read_base64_block):
1796
1797 2016-08-05  Commit Queue  <commit-queue@webkit.org>
1798
1799         Unreviewed, rolling out r204123.
1800         https://bugs.webkit.org/show_bug.cgi?id=160597
1801
1802         Caused layout test timeouts on Windows. (Requested by perarne
1803         on #webkit).
1804
1805         Reverted changeset:
1806
1807         "[Win] Unable to reliably run tests in parallel"
1808         https://bugs.webkit.org/show_bug.cgi?id=140914
1809         http://trac.webkit.org/changeset/204123
1810
1811 2016-08-04  Saam Barati  <sbarati@apple.com>
1812
1813         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1814         https://bugs.webkit.org/show_bug.cgi?id=151241
1815
1816         Reviewed by Benjamin Poulain.
1817
1818         * Scripts/run-jsc-stress-tests:
1819
1820 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1821
1822         UI improvements to Flakiness Dashboard.
1823         https://bugs.webkit.org/show_bug.cgi?id=153295
1824
1825         Reviewed by Alexey Proskuryakov.
1826
1827         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1828         (td.options-container): Center text in most fields.
1829         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1830         (createBugHTML): Text/Grammar updates.
1831         (tableHeaders): Ditto.
1832         (htmlForSingleTestRow): Ditto.
1833         (headerForTestTableHtml): Ditto.
1834         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1835         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1836
1837 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1838
1839         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1840         https://bugs.webkit.org/show_bug.cgi?id=160518
1841
1842         Reviewed by Michael Catanzaro.
1843
1844         * Scripts/webkitpy/thirdparty/__init__.py:
1845         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1846         * gtk/install-dependencies:
1847
1848 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1849
1850         Optimize bot watcher's dashboard a little
1851         https://bugs.webkit.org/show_bug.cgi?id=160515
1852         rdar://problem/26096900
1853
1854         Reviewed by Lucas Forschler.
1855
1856         Made re-sorting after loading an iteration more efficient.
1857
1858         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1859         (BuildbotIteration.prototype._updateWithData):
1860         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1861         (BuildbotQueue.prototype.updateIterationPosition):
1862
1863 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1864
1865         [Win] Unable to reliably run tests in parallel
1866         https://bugs.webkit.org/show_bug.cgi?id=140914
1867
1868         Reviewed by Brent Fulgham.
1869
1870         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1871         processes. We can use string replacement to convert the Cygwin path to a Windows path
1872         instead.
1873  
1874         * Scripts/webkitpy/common/system/path.py:
1875         (cygpathFast):
1876         * Scripts/webkitpy/port/driver.py:
1877         (Driver._command_from_driver_input):
1878
1879 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1880
1881         Document instructions for increasing process and file limits
1882         https://bugs.webkit.org/show_bug.cgi?id=160528
1883         rdar://problem/24777576
1884
1885         Reviewed by Alexey Proskuryakov.
1886
1887         * Scripts/webkitpy/port/ios.py:
1888         (IOSSimulatorPort.default_child_processes):
1889
1890 2016-08-03  Anders Carlsson  <andersca@apple.com>
1891
1892         Remove the Objective-C bindings generator
1893         https://bugs.webkit.org/show_bug.cgi?id=160526
1894
1895         Reviewed by Sam Weinig.
1896
1897         * Scripts/run-bindings-tests:
1898         Update test.
1899
1900 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1901
1902         Revise a TestWebKitAPI comment to mention the actual underlying problem
1903
1904         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1905         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1906
1907 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1908
1909         Benchmark test content-animation timeouts always
1910         https://bugs.webkit.org/show_bug.cgi?id=160057
1911
1912         Reviewed by Simon Fraser.
1913
1914         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1915         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1916         (start):
1917
1918 2016-08-02  Nan Wang  <n_wang@apple.com>
1919
1920         AX: Simulated touch events are not working on iOS
1921         https://bugs.webkit.org/show_bug.cgi?id=160395
1922         <rdar://problem/27633597>
1923
1924         Reviewed by Chris Fleizach.
1925
1926         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1927         (WTR::AccessibilityUIElement::press):
1928         (WTR::AccessibilityUIElement::setSelectedChild):
1929
1930 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1931
1932         run-javascriptcore-tests should accept multiple --extra-tests
1933         https://bugs.webkit.org/show_bug.cgi?id=160486
1934
1935         Reviewed by Saam Barati.
1936         
1937         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1938         test suites. This does it by using GetOpt::Long's array support.
1939
1940         * Scripts/run-javascriptcore-tests:
1941         (runJSCStressTests):
1942
1943 2016-08-02  Enrica Casucci  <enrica@apple.com>
1944
1945         Allow building with content filtering disabled.
1946         https://bugs.webkit.org/show_bug.cgi?id=160454
1947
1948         Reviewed by Simon Fraser.
1949
1950         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1951
1952 2016-08-02  Brady Eidson  <beidson@apple.com>
1953
1954         Removing IndexedDB WebsiteData can fail for some users.
1955         https://bugs.webkit.org/show_bug.cgi?id=160463
1956
1957         Reviewed by Alex Christensen.
1958
1959         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1960
1961 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1962
1963         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1964         https://bugs.webkit.org/show_bug.cgi?id=160437
1965         <rdar://problem/27578272>
1966
1967         Reviewed by Brady Eidson.
1968
1969         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1970         (-[DownloadDelegate _download:didReceiveResponse:]):
1971         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1972         (runTest):
1973         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1974
1975 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1976
1977         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1978         https://bugs.webkit.org/show_bug.cgi?id=160414
1979
1980         Reviewed by Michael Catanzaro.
1981
1982         * Scripts/webkitpy/port/linux_get_crash_log.py:
1983         (GDBCrashLogGenerator._wait_for_corefile):
1984
1985 2016-08-01  Youenn Fablet  <youenn@apple.com>
1986
1987         Make wpt server generate its certificates in layout test results folder
1988         https://bugs.webkit.org/show_bug.cgi?id=160422
1989
1990         Reviewed by Chris Dumez.
1991
1992         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1993         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1994
1995 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1996
1997         Function Call on NULL Object
1998         https://bugs.webkit.org/show_bug.cgi?id=160325
1999
2000         Reviewed by Darin Adler.
2001
2002         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2003         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
2004         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
2005
2006 2016-08-01  Keith Miller  <keith_miller@apple.com>
2007
2008         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
2009         https://bugs.webkit.org/show_bug.cgi?id=160372
2010
2011         Rubber stamped by Geoffrey Garen.
2012
2013         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
2014         a new top level directory, JSTests. Having the tests in the Source directory
2015         was both confusing an inconvenient for people that just want to checkout the
2016         source code of WebKit. Since there is no other obvious place to put all the
2017         JavaScript tests a new top level directory seemed the most sensible.
2018
2019         * Scripts/import-test262-tests:
2020         * Scripts/run-javascriptcore-tests:
2021         * Scripts/update-javascriptcore-test-res:
2022
2023 2016-07-31  Nan Wang  <n_wang@apple.com>
2024
2025         AX: Add a check for touch event listener on iOS accessibility object
2026         https://bugs.webkit.org/show_bug.cgi?id=160388
2027
2028         Reviewed by Chris Fleizach.
2029
2030         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2031         (AccessibilityUIElement::boolAttributeValue):
2032         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2033         (WTR::AccessibilityUIElement::boolAttributeValue):
2034
2035 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
2036
2037         Unreviewed: add myself to the reviewers list.
2038
2039         * Scripts/webkitpy/common/config/contributors.json:
2040
2041 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
2042
2043         Undo r203939, and copy over a rule that clips the logos.
2044
2045         Sierra wasn't the only logo without transparency.
2046
2047         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2048         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2049         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2050
2051 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
2052
2053         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
2054         https://bugs.webkit.org/show_bug.cgi?id=160377
2055
2056         Reviewed by Brian Weinstein.
2057
2058         Update assets to remove the white background and use a transparent background instead.
2059
2060         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2061         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2062
2063 2016-07-29  David Kilzer  <ddkilzer@apple.com>
2064
2065         Ignore most check-webkit-style checks for ANGLE project
2066         <https://webkit.org/b/160333>
2067
2068         Reviewed by Daniel Bates.
2069
2070         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
2071         - No tabs.
2072         - No spaces at the end of lines.
2073         - No carriage returns (DOS line endings).
2074
2075 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2076
2077         Media controls are not displayed for some autoplaying videos at certain browser dimensions
2078         https://bugs.webkit.org/show_bug.cgi?id=160360
2079         <rdar://problem/27179484>
2080
2081         Reviewed by Myles C. Maxfield.
2082
2083         Adds two tests verifying that videos may be considered main content as long as they
2084         are large enough and cover a majority of the mainframe's viewport.
2085
2086         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2087         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2088         (TestWebKitAPI::TEST):
2089         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
2090         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
2091
2092 2016-07-29  Mark Lam  <mark.lam@apple.com>
2093
2094         Gardening: removed unused variable.
2095
2096         Not reviewed.
2097
2098         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2099         (TestWebKitAPI::TEST):
2100
2101 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2102
2103         Add TestWebKitAPI support for interacting with media controls
2104         https://bugs.webkit.org/show_bug.cgi?id=160342
2105         <rdar://problem/27610246>
2106
2107         Reviewed by Beth Dakin.
2108
2109         Adds support for testing interaction with some media controls, as well as a basic test
2110         verifying that media control teardown after interaction does not result in a crash.
2111
2112         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2113         (-[WKWebView mouseDownAtPoint:]):
2114         (-[WKWebView performAfterLoading:]):
2115         (TestWebKitAPI::TEST):
2116
2117 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
2118
2119         Crash Log Clobbering on Unbound Crashes
2120         https://bugs.webkit.org/show_bug.cgi?id=160198
2121         <rdar://problem/27472618>
2122
2123         Reviewed by Alexey Proskuryakov.
2124
2125         * Scripts/webkitpy/common/system/crashlogs.py:
2126         (CrashLogs): Fix header order.
2127         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2128         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
2129
2130 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2131
2132         Update for contributors.json
2133         https://bugs.webkit.org/show_bug.cgi?id=160294
2134
2135         * Scripts/webkitpy/common/config/contributors.json:
2136
2137 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
2138
2139         Remove deprecated SPI for video inline / fullscreen controls
2140         https://bugs.webkit.org/show_bug.cgi?id=160318
2141
2142         Reviewed by Tim Horton.
2143
2144         * DumpRenderTree/mac/DumpRenderTree.mm:
2145         (setDefaultsToConsistentValuesForTesting): Deleted.
2146         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2147         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2148         * WebKitTestRunner/TestController.cpp:
2149         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2150         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2151         (WTR::initializeWebViewConfiguration): Deleted.
2152
2153 2016-07-28  Daniel Bates  <dabates@apple.com>
2154
2155         [iOS] TestWebKitAPI bundle targets are not code signed
2156         https://bugs.webkit.org/show_bug.cgi?id=160328
2157         <rdar://problem/27409246>
2158
2159         Reviewed by Andy Estes.
2160
2161         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
2162         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
2163         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
2164
2165         * TestWebKitAPI/Configurations/Base.xcconfig:
2166
2167 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2168
2169         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
2170
2171         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2172         (animatedResizeWebView):
2173         (TEST):
2174         This test times out only when run in the WebKit Testing simulator environment,
2175         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
2176
2177 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2178
2179         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
2180         https://bugs.webkit.org/show_bug.cgi?id=160289
2181         <rdar://problem/27553464>
2182
2183         Reviewed by Simon Fraser.
2184
2185         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2187         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
2188         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
2189         (-[AnimatedResizeWebView _endAnimatedResize]):
2190         (animatedResizeWebView):
2191         (TEST):
2192         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
2193         Add two tests that ensure that hidden-content and animated resizes
2194         don't cause unnecessary synchronous waits. Only the hidden-content
2195         one fails before my patch, but it seemed reasonable to add both anyway.
2196
2197 2016-07-28  David Kilzer  <ddkilzer@apple.com>
2198
2199         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
2200         <https://webkit.org/b/83342>
2201
2202         Reviewed by Ryosuke Niwa.
2203
2204         * Scripts/webkitpy/common/checkout/scm/git.py:
2205         (Git.revisions_changing_file): Remove code to raise an exception
2206         when the file doesn't exist.  If a file was moved or renamed,
2207         then this caused the script to terminate, which was very
2208         frustrating when you wanted a list of reviewers.
2209         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2210         (SCMTest._shared_test_revisions_changing_file): Update test
2211         expectation to return an empty list of revisions.
2212         (test_create_patch_is_full_patch): Drive-by fix when running all
2213         webkitpy tests (including scm tests).
2214         * Scripts/webkitpy/common/checkout/scm/svn.py:
2215         (SVN.revisions_changing_file): Catch ScriptError exceptions and
2216         return an empty array of revisions if this occurs.
2217
2218 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
2219
2220         EWS error message "Error: * did not process patch" should include explanation
2221         https://bugs.webkit.org/show_bug.cgi?id=159903
2222         <rdar://problem/27410788>
2223
2224         Reviewed by Alexey Proskuryakov.
2225
2226         * QueueStatusServer/handlers/statusbubble.py:
2227         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
2228         is not processed.
2229         * QueueStatusServer/handlers/processingtimesjson.py:
2230         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
2231         of the code.
2232         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2233         (CommitQueueTask.validate): Add more information about validation failure.
2234         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2235         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2236         (EarlyWarningSystemTask.validate): Add more information about validation failure.
2237         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
2238         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2239         (PatchIsNotValid.__init__): Add the failure_message argument.
2240         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2241         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
2242         failure details.
2243         * Scripts/webkitpy/tool/commands/queues.py:
2244         (CommitQueue.process_work_item): Same.
2245         (StyleQueue.review_patch): Same.
2246         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2247         (test_non_valid_patch): Updated test-cases messages to match the above changes.
2248
2249 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
2250
2251         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
2252         https://bugs.webkit.org/show_bug.cgi?id=160262
2253
2254         Reviewed by Daniel Bates.
2255
2256         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2257         (-[LTRelayController installApp]):
2258
2259 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
2260
2261         Disable WebCoreNSURLSessionTest API tests on ios-simulator
2262         https://bugs.webkit.org/show_bug.cgi?id=160225
2263
2264         Reviewed by Alexey Proskuryakov.
2265
2266         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2267
2268 2016-07-27  Miguel Gomez  <magomez@igalia.com>
2269
2270         [GTK] Fix some video/canvas tests that should be passing
2271         https://bugs.webkit.org/show_bug.cgi?id=160023
2272
2273         Reviewed by Carlos Garcia Campos.
2274
2275         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
2276         EFL or GTK platforms.
2277
2278         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2279         (WTR::TestController::platformConfigureViewForTest):
2280         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2281         (WTR::TestController::platformConfigureViewForTest):
2282
2283 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2284
2285         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
2286         https://bugs.webkit.org/show_bug.cgi?id=160247
2287
2288         Reviewed by Michael Catanzaro.
2289
2290         * BuildSlaveSupport/built-product-archive:
2291         (createZip):
2292         (dirContainsdwo):
2293         (archiveBuiltProduct):
2294
2295 2016-07-26  Alex Christensen  <achristensen@webkit.org>
2296
2297         Fix tests after r203743.
2298         https://bugs.webkit.org/show_bug.cgi?id=156947
2299
2300         * WebKitTestRunner/TestController.cpp:
2301         (WTR::TestController::resetStateToConsistentValues):
2302         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
2303
2304 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
2305
2306         [iPhone] Playing a video on tudou.com plays only sound, no video
2307         https://bugs.webkit.org/show_bug.cgi?id=160178
2308         <rdar://problem/27535468>
2309
2310         Reviewed by Dan Bernstein.
2311
2312         * DumpRenderTree/mac/DumpRenderTree.mm:
2313         (setDefaultsToConsistentValuesForTesting):
2314         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2315         (RequiresUserActionForPlaybackTest::SetUp):
2316         * WebKitTestRunner/TestController.cpp:
2317         (WTR::TestController::resetPreferencesToConsistentValues):
2318         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2319         (WTR::initializeWebViewConfiguration):
2320
2321 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2322
2323         Allow LOG macros to be used outside the namespace, and other logging cleanup
2324         https://bugs.webkit.org/show_bug.cgi?id=160216
2325
2326         Reviewed by Anders Carlsson.
2327         
2328         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
2329
2330         * DumpRenderTree/TestRunner.cpp:
2331         * DumpRenderTree/mac/DumpRenderTree.mm:
2332         (resetWebViewToConsistentStateBeforeTesting):
2333
2334 2016-07-26  David Kilzer <ddkilzer@apple.com>
2335
2336         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
2337         https://bugs.webkit.org/show_bug.cgi?id=156947
2338         <rdar://problem/23325160>
2339
2340         Reviewed by Alex Christensen.
2341
2342         * DumpRenderTree/TestRunner.cpp:
2343         (TestRunner::TestRunner):
2344         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
2345         * DumpRenderTree/TestRunner.h:
2346         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2347         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2348         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2349         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2350         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2351         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2352         (WTR::TestRunner::queueNonLoadingScript):
2353         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2354         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2355         * WebKitTestRunner/TestController.cpp:
2356         (WTR::TestController::didReceiveAuthenticationChallenge):
2357         * WebKitTestRunner/TestController.h:
2358         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2359         * WebKitTestRunner/TestInvocation.cpp:
2360         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2361         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
2362
2363 2016-07-26  David Kilzer  <ddkilzer@apple.com>
2364
2365         check-for-exit-time-destructors should be usable outside Xcode
2366         <https://webkit.org/b/160195>
2367
2368         Reviewed by Darin Adler.
2369
2370         * Scripts/check-for-exit-time-destructors: Update to parse
2371         -h|--help switch, or to take one argument to a binary to check
2372         for exit time destructors on the command-line.  The clang
2373         compiler will find these at compile-time with the
2374         -Wexit-time-destructors switch, but this script will check for
2375         them after-the-fact.
2376
2377 2016-07-26  Lucas Forschler  <lforschler@apple.com>
2378
2379         Test svn.webkit.org functionality after maintenance.
2380
2381 2016-07-25  Brady Eidson  <beidson@apple.com>
2382
2383         Modern IDB: Make sure IndexedDB works from file:// url documents by default
2384         https://bugs.webkit.org/show_bug.cgi?id=153783
2385
2386         Reviewed by Alex Christensen.
2387
2388         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
2389         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
2390         
2391         As of https://trac.webkit.org/changeset/203695 this is no longer required.
2392         
2393         Change the relevant API tests to make sure this continues to be no longer required.
2394
2395         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2396         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2397         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2398         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2399         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2400         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2401
2402 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2403
2404         Media controls should not be displayed for a video until it starts playing
2405         https://bugs.webkit.org/show_bug.cgi?id=160092
2406         <rdar://problem/26986673>
2407
2408         Reviewed by Beth Dakin.
2409
2410         Verify that multiple videos do or don't show the media controller depending on whether videos
2411         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
2412         passing because we were always showing media controls for large videos with audio, even if they
2413         had not played back yet. This change ensures that large videos with audio show media controls
2414         only after they begin to play back, and not by virtue of being large enough for main content.
2415
2416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2417         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2418         (TestWebKitAPI::TEST):
2419         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
2420         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
2421         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
2422
2423 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2424
2425         Media controls on apple.com don't disappear when movie finishes playing
2426         https://bugs.webkit.org/show_bug.cgi?id=160068
2427         <rdar://problem/26668526>
2428
2429         Reviewed by Darin Adler.
2430
2431         Adds new API tests. Please see WebCore ChangeLog for more details.
2432
2433         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2434         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2435         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
2436         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2437         (TestWebKitAPI::TEST):
2438         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
2439         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2440         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
2441         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
2442         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
2443
2444 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2445
2446         Unreviewed, fix test-webkitpy after r203674.
2447
2448         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2449         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2450
2451 2016-07-24  Philippe Normand  <pnormand@igalia.com>
2452
2453         Unreviewed, forgot to commit this file in r203674.
2454
2455         * Scripts/process-linux-coredump: Added.
2456         (main):
2457
2458 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2459
2460         Improve GDB backtrace generation for GTK/EFL
2461         https://bugs.webkit.org/show_bug.cgi?id=128928
2462
2463         Reviewed by Carlos Garcia Campos.
2464
2465         The PID of the crashed process is now correctly supplied to the
2466         crash log reporter. The kernel core_pattern needs to be updated
2467         after this change to something like:
2468
2469         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
2470
2471         * Scripts/process-linux-coredump: Added.
2472         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
2473         * Scripts/webkitpy/port/efl.py:
2474         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
2475         * Scripts/webkitpy/port/gtk.py:
2476         (GtkPort._get_crash_log): Ditto.
2477         * Scripts/webkitpy/port/linux_get_crash_log.py:
2478         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
2479         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
2480         (GDBCrashLogGenerator): Deleted.
2481         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2482         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
2483         * WebKitTestRunner/TestController.cpp:
2484         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
2485         (WTR::TestController::databaseProcessDidCrash): Ditto.
2486         (WTR::TestController::processDidCrash): Ditto.
2487
2488 2016-07-23  Youenn Fablet  <youenn@apple.com>
2489
2490         WPT stash server should be kept running when launching wpt server
2491         https://bugs.webkit.org/show_bug.cgi?id=160052
2492
2493         Reviewed by Sam Weinig.
2494
2495         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2496         (main): waiting to read stdin while stash server is started.
2497
2498 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2499
2500         Media controls should be displayed for media in media documents
2501         https://bugs.webkit.org/show_bug.cgi?id=160104
2502         <rdar://problem/27438936>
2503
2504         Reviewed by Myles C. Maxfield.
2505
2506         Verifies that even a small video with audio in a media document gets media controls.
2507
2508         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2509         (TestWebKitAPI::TEST):
2510
2511 2016-07-22  Michael Saboff  <msaboff@apple.com>
2512
2513         REGRESSION(203616): no FTL testing was inadvertently removed
2514         https://bugs.webkit.org/show_bug.cgi?id=160100
2515
2516         Rubber-stamped by Filip Pizlo.
2517
2518         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
2519         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
2520         logic for the runLayout and runNoisy variants to match the run test logic,
2521         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
2522         enabled platforms.
2523
2524         * Scripts/run-jsc-stress-tests:
2525
2526 2016-07-22  Brady Eidson  <beidson@apple.com>
2527
2528         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
2529         https://bugs.webkit.org/show_bug.cgi?id=160089
2530
2531         Reviewed by Darin Adler.
2532
2533         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2534         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
2535         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
2536
2537 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
2538
2539         [GTK] Improved exclusion patterns in make-dist.py manifest.
2540         https://bugs.webkit.org/show_bug.cgi?id=160094
2541
2542         Reviewed by Michael Catanzaro.
2543
2544         * gtk/manifest.txt.in:
2545         Exclude Platform*.cmake files for more ports.
2546         Removed obsolete .gyp and .pro.user patterns.
2547         Exclude 'Configurations' and 'spi' directories.
2548         Exclude CMakeLists.txt.user (Qt Creator IDE).
2549
2550 2016-07-22  Michael Saboff  <msaboff@apple.com>
2551
2552         Don't run FTL related JSC stress tests on non-FTL platforms
2553         https://bugs.webkit.org/show_bug.cgi?id=160033
2554
2555         Reviewed by Mark Lam.
2556
2557         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
2558         Refactored several of the runXXX test methods to always runXXXDefault and made those
2559         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
2560         doesn't cause a problem.
2561
2562         * Scripts/run-jsc-stress-tests:
2563
2564 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
2565
2566         IWebView::mainFrame crashes if called after IWebView::close
2567         https://bugs.webkit.org/show_bug.cgi?id=32868
2568
2569         Reviewed by Brent Fulgham.
2570
2571         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2572         (TestWebKitAPI::TEST_F): Added test.
2573
2574 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2575
2576         [GTK] Enable threaded compositor by default
2577         https://bugs.webkit.org/show_bug.cgi?id=160079
2578
2579         Reviewed by Žan Doberšek.
2580
2581         * Scripts/webkitperl/FeatureList.pm:
2582
2583 2016-07-22  Youenn Fablet  <youenn@apple.com>
2584
2585         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
2586         https://bugs.webkit.org/show_bug.cgi?id=159921
2587
2588         Reviewed by Brian Burg.
2589
2590         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
2591
2592         * Scripts/webkitpy/codegen/main.py:
2593         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
2594         (BuiltinsGeneratorTests):
2595         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
2596         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
2597         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
2598         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
2599
2600 2016-07-21  Dan Bernstein  <mitz@apple.com>
2601
2602         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
2603         https://bugs.webkit.org/show_bug.cgi?id=160072
2604
2605         Reviewed by Andy Estes.
2606
2607         * Scripts/webkitdirs.pm:
2608         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
2609           for old Xcode versions.
2610         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
2611           to readXcodeUserDefault.
2612         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
2613           debugger.
2614         (determineDebugger): Ditto.
2615         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
2616           7.0.
2617         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
2618           switches.
2619         (execMacWebKitAppForDebugging): Removed support for GDB.
2620
2621 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2622
2623         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2624         https://bugs.webkit.org/show_bug.cgi?id=160066
2625
2626         Reviewed by Dean Jackson.
2627
2628         * DumpRenderTree/mac/DumpRenderTree.mm:
2629         (setDefaultsToConsistentValuesForTesting): Deleted.
2630         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2631         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2632         * WebKitTestRunner/TestController.cpp:
2633         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2634         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2635         (WTR::initializeWebViewConfiguration): Deleted.
2636
2637 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
2638
2639         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2640         https://bugs.webkit.org/show_bug.cgi?id=159980
2641         rdar://problem/27450825
2642
2643         Reviewed by Dan Bernstein.
2644
2645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2646         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2647         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2648         when our delegate has hit -dealloc.
2649         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
2650         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
2651         will not be messaged.
2652
2653 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2654
2655         Follow-up patch to r203520
2656         https://bugs.webkit.org/show_bug.cgi?id=159967
2657         <rdar://problem/26964090>
2658
2659         Unreviewed.
2660
2661         * DumpRenderTree/mac/DumpRenderTree.mm:
2662         (setDefaultsToConsistentValuesForTesting):
2663         * WebKitTestRunner/TestController.cpp:
2664         (WTR::TestController::resetPreferencesToConsistentValues):
2665
2666 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2667
2668         [iPhone] Playing a video on tudou.com plays only sound, no video
2669         https://bugs.webkit.org/show_bug.cgi?id=159967
2670         <rdar://problem/26964090>
2671
2672         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2673
2674         Migrate tests to use new SPI.
2675
2676         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2677         (RequiresUserActionForPlaybackTest::SetUp):
2678         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2679         (WTR::initializeWebViewConfiguration):
2680
2681 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
2682
2683         Clarify testing mode names in run-jsc-stress-tests
2684         https://bugs.webkit.org/show_bug.cgi?id=160021
2685
2686         Reviewed by Mark Lam.
2687
2688         Default should mean really default, not default with disabled FTL, renamed
2689         - runMozillaTestDefault to runMozillaTestNoFTL
2690         - runMozillaTestDefaultFTL to runMozillaTestDefault
2691         - runDefault to runNoFTL
2692         - runDefaultFTL to runDefault
2693         - runLayoutTestDefault to runLayoutTestNoFTL
2694         - runLayoutTestDefaultFTL to runLayoutTestDefault
2695         - runNoisyTestDefault to runNoisyTestNoFTL
2696         - runNoisyTestDefaultFTL to runNoisyTestDefault
2697
2698         * Scripts/run-jsc-stress-tests:
2699
2700 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
2701
2702         WebBackForwardList's currentIndex could get out of bounds when filtering items.
2703         https://bugs.webkit.org/show_bug.cgi?id=159986
2704
2705         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
2706         to 0.
2707
2708         Reviewed by Dan Bernstein.
2709
2710         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2711         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
2712         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
2713         (TEST):
2714
2715 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2716
2717         [GTK] Web view background colors don't work in accelerated compositing mode
2718         https://bugs.webkit.org/show_bug.cgi?id=159455
2719
2720         Reviewed by Michael Catanzaro.
2721
2722         Set always RGBA visual to the view widget when setting a background color.
2723
2724         * MiniBrowser/gtk/BrowserWindow.c:
2725         (browser_window_set_background_color):
2726
2727 2016-07-20  Youenn Fablet  <youenn@apple.com>
2728
2729         Bots should run built-ins generator tests
2730         https://bugs.webkit.org/show_bug.cgi?id=159971
2731
2732         Reviewed by Alexey Proskuryakov.
2733
2734         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2735         (RunBuiltinsTests): New step to run built-in generator tests.
2736         (TestFactory.__init__): Adding an additional step for bultin generator tests.
2737         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
2738         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
2739
2740 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2741
2742         Revert temporary fix r203417
2743         https://bugs.webkit.org/show_bug.cgi?id=160001
2744
2745         Reviewed by Alexey Proskuryakov.
2746
2747         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
2748
2749 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2750
2751         REGRESSION(r148588): ews classes might get garbage collected
2752         https://bugs.webkit.org/show_bug.cgi?id=159990
2753
2754         Reviewed by Ryosuke Niwa.
2755
2756         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
2757         in a variable so that they do not get garbage collected.
2758
2759 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
2760
2761         Add API test for layout constraints after exit fullscreen
2762         https://bugs.webkit.org/show_bug.cgi?id=159900
2763
2764         Reviewed by Jon Lee.
2765
2766         Added Fullscreen.LaytoutConstraints API test. 
2767         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
2768
2769         This test compares layout constraints on the web view before and after fullscreen to make sure 
2770         they are preserved.
2771
2772         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
2773         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
2774         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2775         (TestWebKitAPI::TEST):
2776
2777 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
2778
2779         Disable two failing API tests.
2780
2781         Unreviewed test gardening.
2782
2783         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2784         (TestWebKitAPI::TEST):
2785
2786 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2787
2788         Unreviewed iOS build fix.
2789
2790         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
2791
2792 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2793
2794         Media controls don't appear when pausing a small autoplaying video
2795         https://bugs.webkit.org/show_bug.cgi?id=159972
2796         <rdar://problem/27180657>
2797
2798         Reviewed by Beth Dakin.
2799
2800         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
2801         for simulating basic user interaction in VideoControlsManager.
2802
2803         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2804         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2805         (-[WKWebView mouseDownAtPoint:]):
2806         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2807         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2808         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2809         (TestWebKitAPI::TEST):
2810         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2811
2812 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2813
2814         [Win] MathML fonts are not found.
2815         https://bugs.webkit.org/show_bug.cgi?id=159920
2816
2817         Reviewed by Alex Christensen.
2818
2819         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2820         for a specific registry key value.
2821
2822         * Scripts/webkitdirs.pm:
2823         (fontExists):
2824
2825 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2826
2827         Improve prepare-ChangeLog for @media blocks
2828         https://bugs.webkit.org/show_bug.cgi?id=159907
2829
2830         Reviewed by Timothy Hatcher.
2831
2832         * Scripts/prepare-ChangeLog:
2833         (get_selector_line_ranges_for_css):
2834         Get a range for @media blocks just like a selector.
2835             Start Line = line with '{'
2836             End line = line with '}'
2837             Name = "@media ..."
2838
2839         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2840         Improved error messages for unbalanced portions.
2841
2842         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2843         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2844         (.media-query::before):
2845         (@media only screen and (max-width: 980px)):
2846         (.media-query a):
2847         (@media (-webkit-min-device-pixel-ratio: 2)):
2848         (.both a):
2849         (.both b):
2850         (.media-query b):
2851         (.media-query::after):
2852
2853 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2854
2855         Fix expectedFailErrorHandler in run-jsc-stress-tests
2856         https://bugs.webkit.org/show_bug.cgi?id=159811
2857
2858         Reviewed by Yusuke Suzuki.
2859
2860         * Scripts/run-jsc-stress-tests:
2861
2862 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2863
2864         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2865
2866         * TestWebKitAPI/PlatformMac.cmake:
2867
2868 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2869
2870         The default testing mode should not involve disabling the FTL JIT
2871         https://bugs.webkit.org/show_bug.cgi?id=159929
2872
2873         Rubber stamped by Mark Lam and Saam Barati.
2874         
2875         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2876         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2877         FTL was not the default. You had to enable it with an option.
2878         
2879         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2880         all of the major ports. This has become a serious pain. For example, it's useful to be able
2881         to say that a test should only run in the default config that is representative of what a
2882         normal user would see if they ran JSC. Clearly, this would be a config that does not
2883         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2884         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2885         
2886         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2887         try to fix it, because:
2888         
2889         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2890           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2891           doesn't do anything. The code is not really structured to allow this.
2892         
2893         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2894           disabled in testing. On the other hand there are already build bots that do FTL tests
2895           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2896           preserving this broken feature, we should create something that (a) acknowledges the fact
2897           that the FTL is the default on those platforms that support it and (b) avoids running
2898           no-ftl tests on precisely those platforms that don't have FTL.
2899         
2900         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2901           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2902           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2903           pretending that the FTL JIT is not the default just because some bots used that as an
2904           optimization.
2905         
2906         This change allows me to speed up some debug tests and paint some bots green.
2907
2908         * Scripts/run-javascriptcore-tests:
2909         (runJSCStressTests):
2910         * Scripts/run-jsc-stress-tests:
2911
2912 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2913
2914         Fix API test after r203426.
2915         https://bugs.webkit.org/show_bug.cgi?id=159949
2916
2917         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2918         (TEST):
2919         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2920         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2921
2922 2016-07-19  Andy Estes  <aestes@apple.com>
2923
2924         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2925         https://bugs.webkit.org/show_bug.cgi?id=159956
2926
2927         Reviewed by Dan Bernstein.
2928
2929         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2930         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2931         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2932         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2933
2934 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2935
2936         Add regression test for r203392
2937         https://bugs.webkit.org/show_bug.cgi?id=159949
2938
2939         Reviewed by Brady Eidson.
2940
2941         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2942         (fileSize):
2943         (swizzledBundleIdentifierWebBookmarksD):
2944         (defaultApplicationCacheDirectory):
2945         (TEST):
2946         (swizzledBundleIdentifierMobileSafari): Deleted.
2947         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2948         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2949         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2950
2951 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2952
2953         Add regression test for r203392
2954         https://bugs.webkit.org/show_bug.cgi?id=159949
2955
2956         Reviewed by Brady Eidson.
2957
2958         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2959         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2960         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2961         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2962         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2963         (TEST):
2964         (fileSize):
2965         (swizzledBundleIdentifierMobileSafari):
2966         (swizzledBundleIdentifierWebBookmarksD):
2967         (defaultApplicationCacheDirectory):
2968         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2969         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2970         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2971         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2972
2973 2016-07-19  Keith Miller  <keith_miller@apple.com>
2974
2975         Test262 should have a file with the revision and url
2976         https://bugs.webkit.org/show_bug.cgi?id=159937
2977
2978         Reviewed by Mark Lam.
2979
2980         The import script should update the information from
2981         the path to the test262 repository it gets.
2982
2983         * Scripts/import-test262-tests:
2984
2985 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2986
2987         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2988         To be deleted once the root cause is found and addressed.
2989
2990         * EWSTools/start-queue-mac.sh:
2991
2992 2016-07-19  Frederic Wang  <fwang@igalia.com>
2993
2994         [win] Fixup the register name for STIX Math and Latin Modern Math
2995
2996         Unreviewed follow-up of r203406
2997
2998         * Scripts/webkitdirs.pm:
2999         (checkInstalledTools):
3000
3001 2016-07-19  Frederic Wang  <fwang@igalia.com>
3002
3003         [win] Update the list of MathML fonts
3004         https://bugs.webkit.org/show_bug.cgi?id=156838
3005
3006         The set of recommended math fonts is now described at
3007         https://trac.webkit.org/wiki/MathML/Fonts
3008         We update the Perl script to use the latest list of fonts.
3009
3010         Reviewed by Brent Fulgham.
3011
3012         * Scripts/webkitdirs.pm:
3013         (checkInstalledTools):
3014
3015 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
3016
3017         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
3018         https://bugs.webkit.org/show_bug.cgi?id=159342
3019
3020         Reviewed by Darin Adler.
3021
3022         Implement required functions in event sender.
3023
3024         * DumpRenderTree/PlatformWin.cmake:
3025         * DumpRenderTree/win/EventSender.cpp:
3026         (monitorWheelEvents): Added.
3027         (callAfterScrollingCompletes): Added.
3028
3029 2016-07-19  Youenn Fablet  <youenn@apple.com>
3030
3031         Add new aliases to http test server
3032         https://bugs.webkit.org/show_bug.cgi?id=159878
3033
3034         Reviewed by Darin Adler.
3035
3036         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
3037         Adding explicitly these links to perl script.
3038         Extracting default alias in an aliases.json file.
3039         Reading that file from python scripts to initialize aliases from that file.
3040
3041         Python script changes covered by unit tests and changed layout test.
3042
3043         * Scripts/webkitperl/httpd.pm:
3044         (getDefaultConfigForTestDirectory): Adding 3 new aliases
3045         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
3046         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3047         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3048         Adding -c directives for each alias.
3049         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3050         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
3051         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3052         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3053         Adding alias directive for each alias.
3054         (Lighttpd._prepare_config):
3055         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3056         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
3057         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
3058         layout tests directory.
3059         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3060         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
3061         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
3062
3063 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
3064
3065         EWS console logs doesn't go to log file
3066         https://bugs.webkit.org/show_bug.cgi?id=159539
3067         <rdar://problem/24464570>
3068
3069         Reviewed by David Kilzer.
3070
3071         * Scripts/webkitpy/common/system/logutils.py:
3072         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
3073         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
3074         to filesystem. It also supports passing MockFilesystem.
3075         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
3076         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
3077         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3078         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
3079         (_test_ews): Same.
3080         * Scripts/webkitpy/tool/commands/queues.py:
3081         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
3082         (AbstractQueue._log_directory): Using filesystem object instead of os.
3083         (AbstractQueue.queue_log_path): Same.
3084         (AbstractQueue.__init__): Passed host parameter.
3085         (PatchProcessingQueue.__init__): Same.
3086         (CommitQueue.__init__): Same.
3087         (AbstractReviewQueue.__init__): Same.
3088         (StyleQueue.__init__): Same.
3089         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3090         (TestCommitQueue): Passed MockHost() as host.
3091         (TestCommitQueue.__init__): Same.
3092         (TestQueue.__init__): Same.
3093         (TestReviewQueue.__init__): Same.
3094         (TestFeederQueue.__init__): Same.
3095         (AbstractPatchQueueTest.test_next_patch): Same.
3096         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
3097         (test_commit_queue_failure): Same.
3098         (MockCommitQueueTask.results_from_patch_test_run): Same.
3099         (test_rollout_lands): Same.
3100         (test_non_valid_patch): Same.
3101         (test_auto_retry): Same.
3102         (test_style_queue_with_watch_list_exception): Same.
3103
3104 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
3105
3106         WTF::Lock should be fair eventually
3107         https://bugs.webkit.org/show_bug.cgi?id=159384
3108
3109         Reviewed by Geoffrey Garen.
3110
3111         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3112
3113 2016-07-17  Sam Weinig  <sam@webkit.org>
3114
3115         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
3116         <rdar://problem/26554137>
3117         https://bugs.webkit.org/show_bug.cgi?id=159856
3118
3119         Reviewed by Dan Bernstein.
3120
3121         * MiniBrowser/mac/WK2BrowserWindowController.m:
3122         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3123         Add basic window.open implementation.
3124
3125         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
3126         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
3127         to open a single non-web URL, all others are dropped.
3128
3129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3130         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
3131         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
3132         Add API for the new SPI.
3133
3134 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
3135
3136         [JSC] Enable test262 module tests
3137         https://bugs.webkit.org/show_bug.cgi?id=159854
3138
3139         Reviewed by Saam Barati.
3140
3141         Use --module-file instead.
3142
3143         * Scripts/run-jsc-stress-tests:
3144
3145 2016-07-16  Chris Dumez  <cdumez@apple.com>
3146
3147         Unreviewed, rolling out r203318.
3148
3149         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
3150         SunSpider)
3151
3152         Reverted changeset:
3153
3154         "[JSC] Change some parameters based on a random search"
3155         https://bugs.webkit.org/show_bug.cgi?id=158514
3156         http://trac.webkit.org/changeset/203318
3157
3158 2016-07-16  Chris Dumez  <cdumez@apple.com>
3159
3160         Add move constructor / assignment operator to ListHashSet
3161         https://bugs.webkit.org/show_bug.cgi?id=159837
3162
3163         Reviewed by Darin Adler.
3164
3165         Add API tests.
3166
3167         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3168         (TestWebKitAPI::TEST):
3169
3170 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
3171
3172         [JSC] Change some parameters based on a random search
3173         https://bugs.webkit.org/show_bug.cgi?id=158514
3174
3175         Reviewed by Saam Barati.
3176
3177         * Scripts/run-jsc-stress-tests:
3178
3179 2016-07-15  Jon Davis  <jond@apple.com>
3180
3181         Changed the start page URL for WebKit Nightly builds.
3182         https://bugs.webkit.org/show_bug.cgi?id=159816
3183
3184         Reviewed by Timothy Hatcher.
3185
3186         * WebKitLauncher/start.html:
3187
3188 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
3189
3190         Uninitialized variable in DIBPixelData can cause a dangerous memory write
3191         https://bugs.webkit.org/show_bug.cgi?id=159414
3192
3193         Reviewed by Brent Fulgham.
3194
3195         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
3196         when the HDC parameter is invalid.
3197
3198         * TestWebKitAPI/PlatformWin.cmake:
3199         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
3200         (TestWebKitAPI::TEST):
3201
3202 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3203
3204         [GTK] Add basic tabs support to MiniBrowser
3205         https://bugs.webkit.org/show_bug.cgi?id=159803
3206
3207         Reviewed by Sergio Villar Senin.
3208
3209         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
3210         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
3211
3212         * MiniBrowser/gtk/BrowserTab.c: Added.
3213         (titleChanged):
3214         (isLoadingChanged):
3215         (decidePolicy):
3216         (removeChildIfInfoBar):
3217         (loadChanged):
3218         (createInfoBarQuestionMessage):
3219         (tlsErrorsDialogResponse):
3220         (loadFailedWithTLSerrors):
3221         (permissionRequestDialogResponse):
3222         (decidePermissionRequest):
3223         (colorChooserRGBAChanged):
3224         (popoverColorClosed):
3225         (colorChooserRequestFinished):
3226         (runColorChooserCallback):
3227         (inspectorOpenedInWindow):
3228         (inspectorClosed):
3229         (browserTabSetProperty):
3230         (browserTabFinalize):
3231         (browser_tab_init):
3232         (browserTabConstructed):
3233         (browser_tab_class_init):
3234         (getInternalURI):
3235         (browser_tab_new):
3236         (browser_tab_get_web_view):
3237         (browser_tab_load_uri):
3238         (browser_tab_get_title_widget):
3239         (browser_tab_set_status_text):
3240         (browser_tab_toggle_inspector):
3241         (browser_tab_start_search):
3242         (browser_tab_stop_search):
3243         (browser_tab_add_accelerators):
3244         (fullScreenMessageTimeoutCallback):
3245         (browser_tab_enter_fullscreen):
3246         (browser_tab_leave_fullscreen):
3247         * MiniBrowser/gtk/BrowserTab.h: Added.
3248         * MiniBrowser/gtk/BrowserWindow.c:
3249         (getExternalURI):
3250         (browserWindowSetStatusText):
3251         (reloadOrStopCallback):
3252         (goBackCallback):
3253         (goForwardCallback):
3254         (settingsCallback):
3255         (webViewURIChanged):
3256         (browserWindowHistoryItemActivated):
3257         (browserWindowUpdateNavigationActions):
3258         (webViewCreate):
3259         (webViewEnterFullScreen):
3260         (webViewLeaveFullScreen):
3261         (webViewDecidePolicy):
3262         (browserWindowCanZoomIn):
3263         (browserWindowCanZoomOut):
3264         (browserWindowZoomIn):
3265         (browserWindowZoomOut):
3266         (scrollEventCallback):
3267         (faviconChanged):
3268         (webViewIsLoadingChanged):
3269         (defaultZoomCallback):
3270         (searchCallback):
3271         (newTabCallback):
3272         (toggleWebInspector):
3273         (reloadPage):
3274         (reloadPageIgnoringCache):
3275         (stopPageLoad):
3276         (loadHomePage):
3277         (editingCommandCallback):
3278         (insertImageCommandCallback):
3279         (insertLinkCommandCallback):
3280         (browserWindowSetupEditorToolbar):
3281         (browserWindowSwitchTab):
3282         (browserWindowTabAddedOrRemoved):
3283         (browser_window_init):
3284         (browserWindowConstructed):
3285         (browserWindowSaveSession):
3286         (browserWindowDeleteEvent):
3287         (browser_window_new):
3288         (browser_window_append_view):
3289         (browser_window_load_uri):
3290         (browser_window_load_session):
3291         (browser_window_set_background_color):
3292         (resetStatusText): Deleted.
3293         (activateUriEntryCallback): Deleted.
3294         (webViewTitleChanged): Deleted.
3295         (resetEntryProgress): Deleted.
3296         (browserWindowCreateBackForwardMenu): Deleted.
3297         (webViewReadyToShow): Deleted.
3298         (webViewLoadFailed): Deleted.
3299         (webViewMouseTargetChanged): Deleted.
3300         (browserWindowUpdateZoomActions): Deleted.
3301         (webViewZoomLevelChanged): Deleted.
3302         (updateUriEntryIcon): Deleted.
3303         (zoomInCallback): Deleted.
3304         (zoomOutCallback): Deleted.
3305         (toggleFullScreen): Deleted.
3306         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
3307         (browserWindowFinalize): Deleted.
3308         (browser_window_class_init): Deleted.
3309         * MiniBrowser/gtk/BrowserWindow.h:
3310         * MiniBrowser/gtk/CMakeLists.txt:
3311         * MiniBrowser/gtk/main.c:
3312         (createBrowserTab):
3313         (aboutURISchemeRequestCallback):
3314         (main):
3315         (parseBackgroundColor): Deleted.
3316
3317 2016-07-14  Alex Christensen  <achristensen@webkit.org>
3318
3319         Allow RefPtrs of const RefCounted types
3320         https://bugs.webkit.org/show_bug.cgi?id=158269
3321
3322         Reviewed by Anders Carlsson.
3323
3324         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3325         (TestWebKitAPI::TEST):
3326         (TestWebKitAPI::ConstRefCounted::create):
3327         (TestWebKitAPI::returnConstRefCountedRef):
3328         (TestWebKitAPI::returnRefCountedRef):
3329
3330 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3331
3332         Test WTF.StringViewIterators is crashing since r203119
3333         https://bugs.webkit.org/show_bug.cgi?id=159710
3334
3335         Reviewed by Darin Adler.
3336
3337         There are two problems in the test case added in r203119. First is that it's testing
3338         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
3339         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
3340         const reference to the string view member of the deleted CodePoints object.
3341
3342         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3343         (TestWebKitAPI::TEST):
3344
3345 2016-07-13  Daniel Bates  <dabates@apple.com>
3346
3347         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
3348         https://bugs.webkit.org/show_bug.cgi?id=159738
3349         <rdar://problem/27304649>
3350
3351         Reviewed by Dan Bernstein.
3352
3353         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
3354         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
3355         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
3356         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
3357
3358         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3359         * WebKitTestRunner/ios/TestControllerIOS.mm:
3360         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
3361         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
3362
3363 2016-07-13  Beth Dakin  <bdakin@apple.com>
3364
3365         Attempted build fix.
3366
3367         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3368
3369 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
3370
3371         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
3372         https://bugs.webkit.org/show_bug.cgi?id=159686
3373
3374         Reviewed by Chris Dumez.
3375
3376         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
3377
3378         * WebKitTestRunner/TestController.cpp:
3379         (WTR::runOpenPanel):
3380         (WTR::TestController::createOtherPage):
3381         (WTR::TestController::createWebViewWithOptions):
3382
3383 2016-07-13  Beth Dakin  <bdakin@apple.com>
3384
3385         Add more candidate tests
3386         https://bugs.webkit.org/show_bug.cgi?id=159730
3387
3388         Reviewed by Tim Horton.
3389
3390         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
3391         two new tests to that file.
3392         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3393         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
3394         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
3395         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
3396         (TestWebKitAPI::TEST):
3397         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
3398
3399 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
3400
3401         AX: [ATK] spinbutton-crash.html fails
3402         https://bugs.webkit.org/show_bug.cgi?id=159723
3403
3404         Reviewed by Chris Fleizach.
3405
3406         Implement support for AXDecrementButton and AXIncrementButton in
3407         ATK's AccessibilityUIElement::uiElementAttributeValue().
3408
3409         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3410         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3411
3412 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3413
3414         [EFL] [GTK] Enable back crypto subtle on development builds.
3415         https://bugs.webkit.org/show_bug.cgi?id=159260
3416
3417         Reviewed by Carlos Garcia Campos.
3418
3419         * Scripts/webkitperl/FeatureList.pm:
3420
3421 2016-07-12  Mark Lam  <mark.lam@apple.com>
3422
3423         We should use different stack limits for stack checks from JS and host code.
3424         https://bugs.webkit.org/show_bug.cgi?id=159442
3425         <rdar://problem/26889188>
3426
3427         Reviewed by Geoffrey Garen.
3428
3429         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
3430         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
3431         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
3432         order to keep the js/regress-139548.html test happy with this patch.
3433
3434         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
3435         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
3436
3437         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3438         (-[LTRelayController _environmentVariables]):
3439         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3440         (main):
3441
3442 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
3443
3444         platformUserPreferredLanguages on Mac should not try to put the region into the language
3445         https://bugs.webkit.org/show_bug.cgi?id=159693
3446
3447         Rubber stamped by Alexey Proskuryakov.
3448         
3449         Revert the test change in r200105.
3450
3451         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
3452         (TestWebKitAPI::languageForSystemLanguage):
3453
3454 2016-07-12  Chris Dumez  <cdumez@apple.com>
3455
3456         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
3457         https://bugs.webkit.org/show_bug.cgi?id=159663
3458         <rdar://problem/18995873>
3459
3460         Reviewed by Benjamin Poulain.
3461
3462         Add API test coverage.
3463
3464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3465         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
3466         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
3467         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
3468         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
3469         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
3470         (TEST):
3471
3472 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
3473
3474         Relax ordering requirements on StringView::CodePoints iterator
3475         https://bugs.webkit.org/show_bug.cgi?id=159609
3476
3477         Reviewed by Darin Adler.
3478
3479         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3480         (TestWebKitAPI::TEST):
3481
3482 2016-07-12  Youenn Fablet  <youenn@apple.com>
3483
3484         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
3485         https://bugs.webkit.org/show_bug.cgi?id=159564
3486
3487         Reviewed by Brian Burg.
3488
3489         * Scripts/webkitpy/codegen/main.py:
3490         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
3491
3492 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3493
3494         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
3495         https://bugs.webkit.org/show_bug.cgi?id=159671
3496
3497         Reviewed by Csaba Osztrogonác.
3498
3499         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
3500         https://bugs.webkit.org/show_bug.cgi?id=89235
3501
3502         So this guard can be removed in build scripts.
3503
3504         * Scripts/webkitperl/FeatureList.pm:
3505         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3506
3507 2016-07-11  Jason Marcell  <jmarcell@apple.com>
3508
3509         SVN.create_patch should find svn-create-patch relative to the WebKit root.
3510         https://bugs.webkit.org/show_bug.cgi?id=159652
3511
3512         Reviewed by Daniel Bates.
3513
3514         * Scripts/webkitpy/common/checkout/scm/svn.py:
3515         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
3516
3517 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
3518
3519         Implement grapheme cluster iterator on StringView
3520         https://bugs.webkit.org/show_bug.cgi?id=159598
3521
3522         Reviewed by Anders Carlsson.
3523
3524         This is in preparation for honoring the second argument to FontFaceSet.load().
3525
3526         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3527         (TestWebKitAPI::compareLoopIterations):
3528         (TestWebKitAPI::TEST):
3529
3530 2016-07-11  Nan Wang  <n_wang@apple.com>
3531
3532         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
3533         https://bugs.webkit.org/show_bug.cgi?id=158364
3534
3535         Reviewed by Anders Carlsson.
3536
3537         Added a function in TestRunner so that we can toggle the ignoring viewport
3538         scale limits setting. Also added a test option for that in order to change the 
3539         configuration of the webview in test.
3540
3541         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3542         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3543         (WTR::TestRunner::setNavigationGesturesEnabled):
3544         (WTR::TestRunner::setIgnoresViewportScaleLimits):
3545         (WTR::nextUIScriptCallbackID):
3546         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3547         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3548         * WebKitTestRunner/TestController.cpp:
3549         (WTR::TestController::resetStateToConsistentValues):
3550         (WTR::updateTestOptionsFromTestHeader):
3551         (WTR::TestController::setNavigationGesturesEnabled):
3552         (WTR::TestController::setIgnoresViewportScaleLimits):
3553         (WTR::TestController::platformWillRunTest):
3554         * WebKitTestRunner/TestController.h:
3555         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3556         * WebKitTestRunner/TestInvocation.cpp:
3557         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3558         * WebKitTestRunner/TestOptions.h:
3559         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3560         (WTR::TestController::platformCreateWebView):
3561
3562 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
3563
3564         [GTK] install-dependencies should not install packages built by jhbuild.
3565         https://bugs.webkit.org/show_bug.cgi?id=159628
3566
3567         Reviewed by Michael Catanzaro.
3568
3569         * gtk/install-dependencies:
3570         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
3571
3572 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
3573
3574         System proxy settings not used when building deps with jhbuild
3575         https://bugs.webkit.org/show_bug.cgi?id=159567
3576
3577         Reviewed by Michael Catanzaro.
3578
3579         This adds the gsettings-desktop-schemas-devel build dep to enable
3580         the libgiognomeproxy.so gio module in glib-networking, which uses
3581         GSettings on org.gnome.system.proxy.
3582         This is needed to query system proxy settings for Gnome desktops.
3583
3584         dconf can be manually added to jhbuild to build the
3585         libdconfsettings.so gio module for GSettings, so that
3586         libgiognomeproxy.so can access system settings.
3587           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
3588
3589         As an alternative to dconf settings, this commit also adds the
3590         libproxy-devel build dep to enable the libgiolibproxy.so module in
3591         glib-networking (suggested by Fujii Hironori).
3592
3593         It is useful to read proxy settings from environment variables.
3594         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
3595         environment variable to force using the envvar module in libproxy.
3596
3597         * gtk/install-dependencies:
3598
3599 2016-07-11  Mark Lam  <mark.lam@apple.com>
3600
3601         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
3602         https://bugs.webkit.org/show_bug.cgi?id=159524
3603
3604         Reviewed by Michael Saboff.
3605
3606         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
3607         Also fixed up some tests to behave better to work with this new limit.  This
3608         should make stack overflow tests complete sooner.
3609
3610         * Scripts/run-jsc-stress-tests:
3611         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3612         (main):
3613
3614 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3615
3616         [GTK] Whitespace fixes in install-dependencies script
3617
3618         Unreviewed.
3619
3620         * gtk/install-dependencies:
3621
3622 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3623
3624         [GTK] Install missing Fedora dependencies
3625
3626         Unreviewed.
3627
3628         * gtk/install-dependencies:
3629
3630 2016-07-09  Dan Bernstein  <mitz@apple.com>
3631
3632         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
3633         https://bugs.webkit.org/show_bug.cgi?id=159600
3634
3635         Reviewed by Daniel Bates.
3636
3637         * Scripts/git-add-reviewer:
3638         Added the -s|--rubber-stamp option.
3639         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
3640           new option.
3641
3642 2016-07-08  Andy Estes  <aestes@apple.com>
3643
3644         [Content Filtering] Load blocked pages more like other error pages are loaded
3645         https://bugs.webkit.org/show_bug.cgi?id=159485
3646         <rdar://problem/26014076>
3647
3648         Reviewed by Brady Eidson.
3649
3650         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3651         to a content filtering provisional navigation failure is ignored in preference of
3652         ContentFilter's own error page.
3653
3654         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3655         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3656         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3657         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3658         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3659         (loadAlternateTest):
3660         (TEST):
3661         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3662         (-[MockContentFilterEnabler initWithCoder:]):
3663         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3664         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3665         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3666         (TestWebKitAPI::loadAlternateTest):
3667         (TestWebKitAPI::TEST):
3668
3669 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3670
3671         Unreviewed, rolling out r202944.
3672         https://bugs.webkit.org/show_bug.cgi?id=159570
3673
3674         caused some tests to crash under GuardMalloc (Requested by
3675         estes on #webkit).
3676
3677         Reverted changeset:
3678
3679         "[Content Filtering] Load blocked pages more like other error
3680         pages are loaded"
3681         https://bugs.webkit.org/show_bug.cgi?id=159485
3682         http://trac.webkit.org/changeset/202944
3683
3684 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
3685
3686         Remove mrobinson from the MathML watchlist
3687         https://bugs.webkit.org/show_bug.cgi?id=159559
3688
3689         Reviewed by Philippe Normand.
3690
3691         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
3692
3693 2016-07-08  Brady Eidson  <beidson@apple.com>
3694
3695         Clearing LocalStorage doesn't also delete -wal and -shm files.
3696         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
3697
3698         Reviewed by Brent Fulgham.
3699         Also helpfully picked over by Andy "Never Forgets" Estes.
3700
3701         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3702         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
3703         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
3704
3705 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
3706
3707         Removed Qt leftovers from Tools.
3708         https://bugs.webkit.org/show_bug.cgi?id=159557
3709
3710         Reviewed by Csaba Osztrogonác.
3711
3712         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3713         Removed 'qt' platform config.
3714         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3715         Deleted non-functional e-mail address.
3716
3717 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3718
3719         Unreviewed, rolling out r202967.
3720         https://bugs.webkit.org/show_bug.cgi?id=159556
3721
3722         This patch caused crashes in https tests on Windows (Requested
3723         by perarne on #webkit).
3724
3725         Reverted changeset:
3726
3727         "[Win] The test http/tests/security/contentSecurityPolicy
3728         /upgrade-insecure-requests/basic-upgrade.https.html is
3729         failing."
3730         https://bugs.webkit.org/show_bug.cgi?id=159510
3731         http://trac.webkit.org/changeset/202967
3732
3733 2016-07-08  Youenn Fablet  <youenn@apple.com>
3734
3735         Generate WebCore builtin wrapper files
3736         https://bugs.webkit.org/show_bug.cgi?id=159461
3737
3738         Reviewed by Brian Burg.
3739
3740         * Scripts/webkitpy/codegen/main.py:
3741         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
3742         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
3743
3744 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
3745
3746         [EFL] Fix build when media-stream is enabled.
3747         https://bugs.webkit.org/show_bug.cgi?id=159206
3748
3749         Bump up the openwebrtc to find the correct package.
3750
3751         Reviewed by Gyuyoung Kim.
3752
3753         * efl/jhbuild.modules:
3754         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
3755
3756 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3757
3758         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
3759         https://bugs.webkit.org/show_bug.cgi?id=159510
3760
3761         Reviewed by Brent Fulgham.
3762
3763         Allow any https certificate when running tests.
3764
3765         * DumpRenderTree/win/DumpRenderTree.cpp:
3766         (runTest):
3767
3768 2016-07-07  Beth Dakin  <bdakin@apple.com>
3769
3770         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3771         https://bugs.webkit.org/show_bug.cgi?id=159532
3772         -and corresponding-
3773         rdar://problem/27177179
3774
3775         Reviewed by Tim Horton.
3776
3777         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
3778         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
3779
3780 2016-07-07  Andy Estes  <aestes@apple.com>
3781
3782         [Content Filtering] Load blocked pages more like other error pages are loaded
3783         https://bugs.webkit.org/show_bug.cgi?id=159485
3784         <rdar://problem/26014076>
3785
3786         Reviewed by Brady Eidson.
3787
3788         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3789         to a content filtering provisional navigation failure is ignored in preference of
3790         ContentFilter's own error page.
3791
3792         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3793         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3794         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3795         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3796         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3797         (loadAlternateTest):
3798         (TEST):
3799         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3800         (-[MockContentFilterEnabler initWithCoder:]):
3801         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3802         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3803         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3804         (TestWebKitAPI::loadAlternateTest):
3805         (TestWebKitAPI::TEST):
3806
3807 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3808
3809         Unreviewed: add myself to the reviewers list.
3810
3811         * Scripts/webkitpy/common/config/contributors.json:
3812
3813 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3814
3815         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
3816         https://bugs.webkit.org/show_bug.cgi?id=159509
3817
3818         Reviewed by Alex Christensen.
3819
3820         We should always insert the url in the url map when identifierForInitialRequest
3821         is called. Otherwise we can end up with identifiers not having an entry in the
3822         url map when urls are written to the test output file. 
3823
3824         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3825         (ResourceLoadDelegate::identifierForInitialRequest):
3826
3827 2016-07-06  Tim Horton  <timothy_horton@apple.com>
3828
3829         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3830         https://bugs.webkit.org/show_bug.cgi?id=159498
3831         <rdar://problem/26719903>
3832
3833         Reviewed by Sam Weinig.
3834
3835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3836         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3837         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3838         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3839         (expectLinkCount):
3840         (TEST):
3841         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3842         when deciding what to linkify.
3843
3844 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3845
3846         Build fix - work around rdar://problem/27196668.
3847
3848         * LayoutTestRelay/Configurations/Base.xcconfig:
3849
3850 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3851
3852         Enhance Windows DRT implementation to support platform scroll wheel events.
3853         https://bugs.webkit.org/show_bug.cgi?id=36002
3854
3855         Reviewed by Brent Fulgham.
3856
3857         Implement function continuousMouseScrollBy in Windows event sender.
3858
3859         * DumpRenderTree/win/EventSender.cpp:
3860         (mouseScrollBy):
3861         (continuousMouseScrollBy):
3862
3863 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3864
3865         [Sierra] Rebaseline tests to use un-mocked system font metrics
3866         https://bugs.webkit.org/show_bug.cgi?id=159311
3867         <rdar://problem/24138411>
3868
3869         Reviewed in person by Alexey Proskuryakov.
3870
3871         Stop mocking the system font on Sierra.
3872
3873         * DumpRenderTree/mac/DumpRenderTree.mm:
3874         (setDefaultsToConsistentValuesForTesting):
3875         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3876         (WTR::InjectedBundle::platformInitialize):
3877
3878 2016-07-05  Brady Eidson  <beidson@apple.com>
3879
3880         Database process crashes deleting a corrupt SQLite database file (null deref).
3881         https://bugs.webkit.org/show_bug.cgi?id=155506.
3882
3883         Reviewed by Alex Christensen.
3884
3885         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3886         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3887         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3888         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3889         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3890         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3891
3892 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3893
3894         run-webkit-tests should print more complete baseline search paths
3895         https://bugs.webkit.org/show_bug.cgi?id=159354
3896
3897         Reviewed by Daniel Bates.
3898
3899         run-webkit-tests used to only print directory names in baseline search paths.
3900         This was ok in basic usage, but quickly got confusing when using
3901         --additional-platform-directory flags.
3902
3903         * Scripts/webkitpy/layout_tests/views/printing.py:
3904         (Printer.print_config):
3905         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3906         (Testprinter.test_print_config):
3907         (Testprinter.test_print_one_line_summary):
3908
3909 2016-07-04  Brady Eidson  <beidson@apple.com>
3910
3911         WebProcesses don't handle DatabaseProcess going away uncleanly..
3912         https://bugs.webkit.org/show_bug.cgi?id=159371
3913
3914         Reviewed by Alex Christensen.
3915
3916         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3917         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3918         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3919         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3920         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3921
3922 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3923
3924         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3925         https://bugs.webkit.org/show_bug.cgi?id=158141
3926
3927         Rubber-stamped by Michael Catanzaro.
3928
3929         Instead of checking for an specific Ubuntu version, query the apt
3930         database to see which version of PHP is available.
3931
3932         * efl/install-dependencies:
3933         * gtk/install-dependencies:
3934
3935 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3936
3937         webkit-patch failure-reason always raises TypeError
3938         https://bugs.webkit.org/show_bug.cgi?id=159394
3939
3940         Reviewed by Benjamin Poulain.
3941
3942         In r170637 (Bug 133067), the first and second arguments of
3943         pluralize were swapped.
3944
3945         * Scripts/webkitpy/tool/commands/queries.py:
3946         (FailureReason._builder_to_explain): Swap the first and second
3947         arguments of pluralize.
3948
3949 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3950
3951         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3952         https://bugs.webkit.org/show_bug.cgi?id=152486
3953
3954         Reviewed by Daniel Bates.
3955
3956         Add launch of web-platform-tests server by run-webkit-httpd.
3957         Add two options to disable starting httpd and web-platform-tests servers.
3958
3959         * Scripts/run-webkit-httpd:
3960         (parse_args):
3961         (main):
3962
3963 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3964
3965         REGRESSION(r189668): Notification tests are flakey
3966         https://bugs.webkit.org/show_bug.cgi?id=159375
3967         <rdar://problem/22760990>
3968
3969         Reviewed by Alexey Proskuryakov.
3970
3971         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3972         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3973         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3974         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3975
3976         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3977         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3978         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3979         global notification ID mapping, causing the wrong notification to be investigated.
3980
3981         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3982         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3983         notification is created or destroyed. However, because this object is implemented outside WebKit,
3984         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3985         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3986         WebNotificationProvider can properly map between the different IDs.
3987
3988         * WebKitTestRunner/TestController.cpp:
3989         (WTR::TestController::runTestingServerLoop):
3990         (WTR::TestController::simulateWebNotificationClick):
3991         * WebKitTestRunner/WebNotificationProvider.cpp:
3992         (WTR::WebNotificationProvider::showWebNotification):
3993         (WTR::removeGlobalIDFromIDMap):
3994         (WTR::WebNotificationProvider::closeWebNotification):
3995         (WTR::WebNotificationProvider::removeNotificationManager):
3996         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3997         (WTR::WebNotificationProvider::reset):
3998         * WebKitTestRunner/WebNotificationProvider.h:
3999
4000 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
4001
4002         Simplify LayoutTestRelay
4003         https://bugs.webkit.org/show_bug.cgi?id=159353
4004
4005         Reviewed by Daniel Bates.
4006
4007         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
4008         by name and runtime makes no sense.
4009         2. Removed code to create devices, webkitpy always does this in advance.
4010         3. Don't create copies of testing apps - we can install the same one into
4011         each simulator, now that we don't run multiple tester processes in a single simulator.
4012         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
4013         5. Removed code that kept testing apps alive in the background.
4014         6. Slightly updated coding style in functions that I touched.
4015
4016         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
4017         Updated for what we acually use at this point.
4018
4019         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
4020         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
4021         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
4022         (-[LTRelayController ipcIdentifier]):
4023         (-[LTRelayController processName]):
4024         (-[LTRelayController didReceiveStdoutData:]):
4025         (-[LTRelayController didCrashWithMessage:]):
4026         (-[LTRelayController installApp]):
4027         (-[LTRelayController _environmentVariables]):
4028         (-[LTRelayController launchApp]):
4029         (-[LTRelayController start]):
4030         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
4031         (-[LTRelayController uniqueAppPath]): Deleted.
4032         (-[LTRelayController uniqueAppURL]): Deleted.
4033         (-[LTRelayController uniqueAppIdentifier]): Deleted.
4034         (-[LTRelayController createUniqueApp]): Deleted.
4035         * LayoutTestRelay/LayoutTestRelay/main.m:
4036         (usage):
4037         (getRequiredStringArgument):
4038         (main):
4039         (getTestingSimDevice): Deleted.
4040         * Scripts/webkitpy/port/driver.py:
4041         (IOSSimulatorDriver.cmd_line):
4042         * WebKitTestRunner/ios/TestControllerIOS.mm:
4043         (WTR::TestController::platformInitialize):
4044         * WebKitTestRunner/ios/mainIOS.mm:
4045         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
4046         * DumpRenderTree/mac/DumpRenderTree.mm:
4047         (dumpRenderTree):
4048         (-[DumpRenderTree applicationDidEnterBackground:]):
4049
4050 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
4051
4052         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
4053         https://bugs.webkit.org/show_bug.cgi?id=159344
4054
4055         Reviewed by Alex Christensen.
4056
4057         * DumpRenderTree/CMakeLists.txt:
4058
4059 2016-07-01  Youenn Fablet  <youennf@gmail.com>
4060
4061         Add a runtime flag for DOM iterators
4062         https://bugs.webkit.org/show_bug.cgi?id=159300
4063
4064         Reviewed by Alex Christensen.
4065
4066         * DumpRenderTree/mac/DumpRenderTree.mm:
4067         (resetWebPreferencesToConsistentValues):
4068         * DumpRenderTree/win/DumpRenderTree.cpp:
4069         (resetWebPreferencesToConsistentValues):
4070         * Scripts/webkitperl/FeatureList.pm:
4071         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4072         (WTR::InjectedBundle::beginTesting):
4073         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4074         (WTR::TestRunner::setDOMIteratorEnabled):
4075         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4076
4077 2016-06-30  Tina Liu  <iting_liu@apple.com>
4078
4079         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
4080         https://bugs.webkit.org/show_bug.cgi?id=159326
4081
4082         Reviewed by Brady Eidson.
4083
4084         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4085         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
4086         (TestWebKitAPI::didFinishLoadForFrame):
4087         (TestWebKitAPI::didChangeBackForwardListForPage):
4088         (TestWebKitAPI::setPageLoaderClient):
4089         Set the page loader client and register for didFinishLoadForFrame and
4090         didChangeBackForwardList callbacks.
4091         (TestWebKitAPI::createSessionStateData):
4092         Load a webpage ("simple.html") and return the session state for this page.
4093         (TestWebKitAPI::TEST):
4094         Restore the page session state with that of "simple.html" without navigation.
4095         Verify that the committed URL is NULL since there's no navigation involved.
4096         Verify that the current item in the back forward list, which should be what
4097         we restored from the session state, has the expected URL.
4098
4099 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
4100
4101         Generators violate bytecode liveness validation
4102         https://bugs.webkit.org/show_bug.cgi?id=159279
4103
4104         Reviewed by Yusuke Suzuki.
4105         
4106         Add Basic to our test harness.
4107
4108         * Scripts/run-javascriptcore-tests:
4109         (runJSCStressTests):
4110
4111 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
4112
4113         [Win][Debug] Assertion fails in TestWTF.
4114         https://bugs.webkit.org/show_bug.cgi?id=159299
4115
4116         Reviewed by Alex Christensen.
4117
4118         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
4119         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
4120         the assertion failure. Since the variable is actually used, there is no need to use the
4121         UNUSED_PARAM macro.
4122
4123         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
4124         (TestWebKitAPI::TEST):
4125
4126 2016-06-30  Youenn Fablet  <youennf@gmail.com>
4127
4128         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
4129         https://bugs.webkit.org/show_bug.cgi?id=159166
4130         <rdar://problem/27051759>
4131
4132         Reviewed by Alexey Proskuryakov.
4133
4134         Setting the certificate directory to the copied config.json.
4135
4136         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
4137         (WebPlatformTestServer._copy_webkit_test_files):
4138
4139 2016-06-29  Mark Lam  <mark.lam@apple.com>
4140
4141         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
4142         https://bugs.webkit.org/show_bug.cgi?id=159274
4143
4144         Reviewed by Keith Miller.
4145
4146         * DumpRenderTree/mac/DumpRenderTree.mm:
4147         (DumpRenderTreeMain):
4148
4149 2016-06-29  Alex Christensen  <achristensen@webkit.org>
4150
4151         WKWebView should ask WKNavigationDelegate about bad ssl certificates
4152         https://bugs.webkit.org/show_bug.cgi?id=159176
4153
4154         Reviewed by Sam Weinig.
4155
4156         * MiniBrowser/mac/WK2BrowserWindowController.m:
4157         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
4158         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
4159         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
4160
4161 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4162
4163         [GTK] Add missing install dependency after r202619
4164         https://bugs.webkit.org/show_bug.cgi?id=156716
4165
4166         Unreviewed.
4167
4168         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
4169
4170 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4171
4172         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
4173         https://bugs.webkit.org/show_bug.cgi?id=156716
4174
4175         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
4176
4177         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
4178         (parse_args):
4179         * Scripts/webkitpy/port/gtk.py:
4180         (GtkPort.__init__):
4181         (GtkPort._driver_class):
4182         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
4183         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
4184         platform directory for storing the wayland specific layout test results and expectations for ${port}.
4185         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
4186         test expectations file on the GTK port when running the tests with the --wayland command line switch.
4187         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
4188         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
4189         (WestonDriver.check_driver):
4190         (WestonDriver.__init__):
4191         (WestonDriver._start):
4192         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
4193         (WestonXvfbDriverDisplayTest):
4194         (WestonXvfbDriverDisplayTest.__init__):
4195         (WestonXvfbDriverDisplayTest._xvfb_run):
4196         (WestonDriverTest.make_driver):
4197         (WestonDriverTest.test_start):
4198         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
4199         or to satisfy the pkg-config check of the new added modules in JHBuild.
4200         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
4201         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
4202         provided by the system are already new enough.
4203         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
4204         It was the only way to get the software EGL rasterizer working without depending on user drivers.
4205         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
4206         feature to avoid building libdrm when the one provided by the system is new enough.
4207         * gtk/jhbuildrc:
4208         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
4209         Xorg had no support for searching the DRI drivers on a custom path at runtime.
4210         This patch implements support for that reusing the same variable that we use with Mesa to set the
4211         custom path for the DRI drivers path.
4212
4213 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
4214
4215         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
4216         https://bugs.webkit.org/show_bug.cgi?id=159256
4217
4218         Reviewed by Philippe Normand.
4219
4220         We need the last fixes in the repository to make the scream queue
4221         work with apprtc.
4222
4223         * gtk/jhbuild.modules:
4224
4225 2016-06-28  Commit Queue  <commit-queue@webkit.org>
4226
4227         Unreviewed, rolling out r202580.
4228         https://bugs.webkit.org/show_bug.cgi?id=159245
4229
4230         Caused all WKTR tests to fail on GuardMalloc and Production
4231         only for unknown reasons, investigating offline. (Requested by
4232         brrian on #webkit).
4233
4234         Reverted changeset:
4235
4236         "RunLoop::Timer should use constructor templates instead of
4237         class templates"
4238         https://bugs.webkit.org/show_bug.cgi?id=159153
4239         http://trac.webkit.org/changeset/202580
4240
4241 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
4242
4243         Use a regex to check if a test step is for JavaScriptCore
4244         https://bugs.webkit.org/show_bug.cgi?id=159224
4245
4246         Reviewed by Geoffrey Garen.
4247
4248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
4249         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
4250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4251         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
4252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
4253         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
4254
4255 2016-06-28  Michael Saboff  <msaboff@apple.com>
4256
4257         btjs no longer accepts optional frame count argument
4258         https://bugs.webkit.org/show_bug.cgi?id=159235
4259
4260         Reviewed by Saam Barati.
4261
4262         Fix the detection of optional backtrace-depth parameter to use the length
4263         of the command.
4264
4265         * lldb/lldb_webkit.py:
4266         (btjs):
4267
4268 2016-06-28  Jon Lee  <jonlee@apple.com>