Remove unused test pages in TestWebKitAPI
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Remove unused test pages in TestWebKitAPI
4         https://bugs.webkit.org/show_bug.cgi?id=168462
5
6         Reviewed by Anders Carlsson.
7
8         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
10         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
11         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
12         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
13         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
14
15 2017-02-16  Alex Christensen  <achristensen@webkit.org>
16
17         Special URLs without a host are invalid
18         https://bugs.webkit.org/show_bug.cgi?id=168461
19
20         Reviewed by Tim Horton.
21
22         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
23         (TestWebKitAPI::TEST_F):
24
25 2017-02-10  Filip Pizlo  <fpizlo@apple.com>
26
27         The collector thread should only start when the mutator doesn't have heap access
28         https://bugs.webkit.org/show_bug.cgi?id=167737
29
30         Reviewed by Keith Miller.
31         
32         Make more tests collect continuously.
33
34         * Scripts/run-jsc-stress-tests:
35
36 2017-02-16  Tim Horton  <timothy_horton@apple.com>
37
38         WKWebView inside a UICollectionView flashes when items are inserted above it
39         https://bugs.webkit.org/show_bug.cgi?id=168376
40         <rdar://problem/29322051>
41
42         Reviewed by Simon Fraser.
43
44         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
45         (-[TestRunnerWKWebView _setStableStateOverride:]):
46         Update the one external caller of this internal method...
47
48         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
49         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
50         * DumpRenderTree/mac/UIScriptControllerMac.mm:
51         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
52         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
53         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
54         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
55         * TestRunnerShared/UIScriptContext/UIScriptController.h:
56         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
57         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
58         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
59         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
60         Expose doAfterVisibleContentRectUpdate to DRT and WKTR. It is called
61         back after we dispatch a visible content rect update from the UI process
62         to the Web Content process, so any messages sent from the block will arrive
63         after the visible content rect update.
64
65 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
66
67         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS.
68         https://bugs.webkit.org/show_bug.cgi?id=168321
69
70         This bots should be added to the trunk build scheduler.
71         Unreviewed fix after r212429.
72
73         * BuildSlaveSupport/build.webkit.org-config/config.json:
74
75 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
76
77         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS
78         https://bugs.webkit.org/show_bug.cgi?id=168321
79
80         Reviewed by Michael Catanzaro.
81
82         The additionalArgument --default-cmake-features is used both to
83         skip the JHBuild (InstallGtkDependencies) build step and to build
84         with the default features from the CMake config.
85
86         * BuildSlaveSupport/build.webkit.org-config/config.json:
87         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
88         (Factory.__init__):
89         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
90
91 2017-02-15  Lucas Forschler  <lforschler@apple.com>
92
93         https://bugs.webkit.org/show_bug.cgi?id=168386
94         Remove EFL from build.webkit.org
95
96         Reviewed by Alex Christensen
97
98         * BuildSlaveSupport/build.webkit.org-config/config.json:
99         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
100         (DeleteStaleBuildFiles.start):
101         (appendCustomBuildFlags):
102         (RunWebKitTests.start):
103         (RunBuiltinsTests):
104         (Factory.__init__):
105         (TestFactory.__init__):
106         (loadBuilderConfig):
107         (InstallEflDependencies): Deleted.
108         (RunEflAPITests): Deleted.
109         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
112         (BubbleQueueServer):
113         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
114         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
115         (Analyzer.prototype._triggeringQueue):
116         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
117         (WebKitBuildbot):
118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
119         (table.queue-grid tr.platform.linux-efl img.logo): Deleted.
120         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
121         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
122         (_should_file_trigger_build):
123
124 2017-02-15  Alex Christensen  <achristensen@webkit.org>
125
126         Unreviewed, rolling out r212169.
127
128         Broke iOS WebInspector
129
130         Reverted changeset:
131
132         "WebInspector: refactor RemoteInspector to move cocoa specific
133         code to their own files"
134         https://bugs.webkit.org/show_bug.cgi?id=166681
135         http://trac.webkit.org/changeset/212169
136
137 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
138
139         webkitpy: Fix DarwinPort._get_crash_log()
140         https://bugs.webkit.org/show_bug.cgi?id=168372
141         <rdar://problem/30535156>
142
143         Reviewed by Daniel Bates.
144
145         Callers of _get_crash_log expect a pair to be returned and do not check it's return value.  
146         DarwinPort should return the expected return value for _get_crash_log.
147
148         * Scripts/webkitpy/port/darwin.py:
149         (DarwinPort._get_crash_log): Call parent class's implementation of _get_crash_log.
150
151 2017-02-15  Chris Dumez  <cdumez@apple.com>
152
153         [iOS] Form Validation Bubble should be sensitive to Dynamic Type
154         https://bugs.webkit.org/show_bug.cgi?id=168291
155         <rdar://problem/30508593>
156
157         Reviewed by Tim Horton.
158
159         Drop overridePreference() implementation in iOS's UIScriptController
160         as it was only used for the minimum font size setting and this setting
161         is not exposed on iOS.
162
163         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
164         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
165         (WTR::UIScriptController::overridePreference):
166         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
167
168 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
169
170         webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
171         https://bugs.webkit.org/show_bug.cgi?id=168329
172         <rdar://problem/30518832>
173
174         Reviewed by Daniel Bates.
175
176         When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
177         never change given the same input arguments.  Memoize function for efficiency.
178
179         * Scripts/webkitpy/port/darwin.py: Add memoized import.
180         (DarwinPort):
181         (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.
182         
183
184 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
185
186         webkitpy: Remove unused import from darwin.py
187         https://bugs.webkit.org/show_bug.cgi?id=168371
188
189         Reviewed by Alex Christensen.
190
191         * Scripts/webkitpy/port/darwin.py: Remove unused 'time' module.
192
193 2017-02-15  Carlos Garcia Campos  <cgarcia@igalia.com>
194
195         [SOUP] Credentials stored by libsoup are used even StoredCredentials policy is DoNotAllowStoredCredentials
196         https://bugs.webkit.org/show_bug.cgi?id=168364
197
198         Reviewed by Michael Catanzaro.
199
200         This can happen if a previous load with allowed to use stored credentials authenticated successfully, saving the
201         credentials in libsoup. It's actually a libsoup bug, but since it's causing layout test failures and we have
202         patches for them, let's patch out jhbuild until we have a new libsoup version to depend on.
203
204         Fixes: http/tests/security/credentials-from-different-domains.html
205                http/tests/xmlhttprequest/cross-origin-no-authorization.html
206
207         * gtk/jhbuild.modules:
208         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Added.
209         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Added.
210
211 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
212
213         [GTK] Update cookie manager API to properly work with ephemeral sessions
214         https://bugs.webkit.org/show_bug.cgi?id=168230
215
216         Reviewed by Michael Catanzaro.
217
218         Update unit tests and add new cases for the new API.
219
220         * MiniBrowser/gtk/main.c:
221         (gotWebsiteDataCallback):
222         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
223         (testCookieManagerEphemeral):
224         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
225         (testWebContextEphemeral):
226         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
227         (testWebViewEphemeral):
228         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
229         (serverCallback):
230         (testWebsiteDataEphemeral):
231         (testWebsiteDataCookies):
232         (beforeAll):
233
234 2017-02-14  Wenson Hsieh  <wenson_hsieh@apple.com>
235
236         [WK2] Support data interaction on links
237         https://bugs.webkit.org/show_bug.cgi?id=168331
238         <rdar://problem/30200837>
239
240         Reviewed by Tim Horton.
241
242         Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
243         editable area results in the link URL being inserted.
244
245         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
246         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
247         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
248         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
249         (TestWebKitAPI::TEST):
250
251 2017-02-14  Jason Rinn  <jrinn@apple.com>
252
253         Add a test for new WebKit Cocoa API, _getContentsAsString.
254         https://bugs.webkit.org/show_bug.cgi?id=168147
255         <rdar://problem/30502539>
256
257         Reviewed by Tim Horton.
258
259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
260         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.
261         (TEST):
262
263 2017-02-14  Matt Rajca  <mrajca@apple.com>
264
265         Website policies: iframes should respect the autoplay policy of the top-level document
266         https://bugs.webkit.org/show_bug.cgi?id=168333
267
268         Reviewed by Alex Christensen.
269
270         * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
271         * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
272         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
273         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
274         (TEST):
275
276 2017-02-14  Chris Dumez  <cdumez@apple.com>
277
278         HTML Form Validation bubble should take minimum font size setting into consideration
279         https://bugs.webkit.org/show_bug.cgi?id=168271
280         <rdar://problem/29869869>
281
282         Reviewed by Simon Fraser.
283
284         Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
285         font size of the validation bubble.
286
287         Add an overridePreference() method to UIScriptController. This is currently
288         used to override the value of the minimumFontSize setting. testRunner's
289         overridePreference() is not usable on WK2 because it does not update the
290         value of the preference on the UIProcess side.
291
292         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
293         (WTR::UIScriptController::overridePreference):
294         * DumpRenderTree/mac/UIScriptControllerMac.mm:
295         (WTR::UIScriptController::overridePreference):
296         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
297         * TestRunnerShared/UIScriptContext/UIScriptController.h:
298         * WebKitTestRunner/TestController.cpp:
299         (WTR::TestController::resetPreferencesToConsistentValues):
300         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
301         (WTR::UIScriptController::overridePreference):
302         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
303         (WTR::UIScriptController::contentsOfUserInterfaceItem):
304         (WTR::UIScriptController::overridePreference):
305
306 2017-02-14  Florian Bruhin  <git@the-compiler.org>
307
308         Use a set instead of a list for tests when parsing expectations
309         https://bugs.webkit.org/show_bug.cgi?id=168304
310
311         In _collect_matching_tests, a lot of membership tests are done on a giant list
312         of strings. By making it a set instead, we can make those much faster, and
313         there's no reason for it to be a list.
314
315         With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
316         to 3s on my machine.
317
318         Reviewed by Ryosuke Niwa.
319
320         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
321         (TestExpectationParser.__init__):
322         (TestExpectationParser._collect_matching_tests):
323
324 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
325
326         Unreviewed build-fix after r212297.
327
328         * Scripts/webkitpy/port/simulator_process.py:
329         (SimulatorProcess.stop): Should return value of the ServerProcess's stop.
330
331 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
332
333         [CMake] build-webkit should allow building with the default cmake configuration
334         https://bugs.webkit.org/show_bug.cgi?id=168323
335
336         Reviewed by Michael Catanzaro.
337
338         Add a --default-cmake-features switch that makes the script pass
339         no value for any of the features defined by build-webkit, that
340         way the default values from the port cmake config will be used.
341
342         * Scripts/build-webkit:
343         (cMakeArgsFromFeatures):
344
345 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
346
347         Unreviewed build-fix after r212297.
348
349         * Scripts/webkitpy/port/simulator_process.py:
350         (SimulatorProcess.stop): Handle case where there is no process to kill.
351
352 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
353
354         [CMake] build-webkit should print the cmake command executed
355         https://bugs.webkit.org/show_bug.cgi?id=168318
356
357         Reviewed by Michael Catanzaro.
358
359         Run the cmake commands to configure or start the build through
360         a wrapper that prints the command before executing it.
361
362         * Scripts/webkitdirs.pm:
363         (systemVerbose):
364         (generateBuildSystemFromCMakeProject):
365         (buildCMakeGeneratedProject):
366         (cleanCMakeGeneratedProject):
367
368 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
369
370         run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
371         https://bugs.webkit.org/show_bug.cgi?id=168150
372
373         Reviewed by Alexey Proskuryakov.
374
375         * Scripts/webkitpy/port/simulator_process.py:
376         (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
377         (SimulatorProcess._kill): Move closing of app into stop().
378         * Scripts/webkitpy/xcode/simulator.py:
379         (Device.launch_app):
380         (Device.terminate_app): Deleted.
381
382 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
383
384         REGRESSION(r212192): [GTK] Broke downloads API tests
385         https://bugs.webkit.org/show_bug.cgi?id=168193
386
387         Unreviewed. Update test expectations after r212192.
388
389         The suggested filename now includes a file extensions if the MIME type is known.
390
391         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
392         (testDownloadRemoteFile):
393         (testDownloadMIMEType):
394
395 2017-02-14  Commit Queue  <commit-queue@webkit.org>
396
397         Unreviewed, rolling out r212237.
398         https://bugs.webkit.org/show_bug.cgi?id=168298
399
400         This was a wrong fix (Requested by rniwa on #webkit).
401
402         Reverted changeset:
403
404         "Nwtr unexpectedly passes mismatch ref test if the hashes
405         doesn't match but no diff"
406         https://bugs.webkit.org/show_bug.cgi?id=168221
407         http://trac.webkit.org/changeset/212237
408
409 2017-02-13  Alex Christensen  <achristensen@webkit.org>
410
411         URLs with an invalid IPv4 address should be invalid
412         https://bugs.webkit.org/show_bug.cgi?id=168260
413
414         Reviewed by Tim Horton.
415
416         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
417         (TestWebKitAPI::TEST_F):
418         Update tests to reflect new correct behavior.
419
420 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
421
422         [WinCairo] Add Build Slave
423         https://bugs.webkit.org/show_bug.cgi?id=168263
424
425         Reviewed by Lucas Forschler.
426
427         * BuildSlaveSupport/build.webkit.org-config/config.json:
428
429 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
430
431         Fix the build after r212254
432
433         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
434         (-[DataInteractionSimulator _currentLocation]):
435
436 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
437
438         [WK2] Add test infrastructure and unit tests for data interaction
439         https://bugs.webkit.org/show_bug.cgi?id=168159
440         <rdar://problem/30477634>
441
442         Reviewed by Tim Horton.
443
444         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
445         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
446         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
447         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
448         gesture has already been recognized) at regular intervals over the course of the test.
449
450         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
451         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
452         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
453         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
454
455         New test pages for data interaction.
456
457         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
458         (TestWebKitAPI::runTestsExpectingToObserveEvents):
459         (TestWebKitAPI::TEST):
460         * TestWebKitAPI/cocoa/TestWKWebView.mm:
461         (-[TestWKWebView stringByEvaluatingJavaScript:]):
462         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
463         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
464         (-[MockLongPressGestureRecognizer initWithWindow:]):
465         (-[MockLongPressGestureRecognizer locationInView:]):
466         (-[MockLongPressGestureRecognizer state]):
467         (-[MockLongPressGestureRecognizer numberOfTouches]):
468         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
469         (-[DataInteractionSimulator dealloc]):
470         (-[DataInteractionSimulator run]):
471
472         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
473         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
474         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
475
476         (-[DataInteractionSimulator _advanceProgress]):
477
478         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
479         completed, and calls _finishDataInteraction when progress is at 1.
480
481         (-[DataInteractionSimulator _finishDataInteraction]):
482         (-[DataInteractionSimulator _currentLocation]):
483         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
484         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
485         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
486         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
487         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
488
489 2017-02-13  Alex Christensen  <achristensen@webkit.org>
490
491         Percent should be allowed in non-special URL hosts
492         https://bugs.webkit.org/show_bug.cgi?id=168255
493
494         Reviewed by Tim Horton.
495
496         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
497         (TestWebKitAPI::TEST_F):
498
499 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
500
501         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
502         https://bugs.webkit.org/show_bug.cgi?id=168221
503
504         Reviewed by Ryosuke Niwa.
505
506         There is a logic error in comparing mismatch ref test images. In
507         mismatch ref tests, it should be failed if two images has no diff.
508         But, if the hashes are different, nwtr unexpectedly pass the
509         mismatch ref test.
510
511         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
512         (SingleTestRunner._compare_output_with_reference): Fail the
513         mismatch ref test if hashes of two images are equal. Invoke
514         ImageDiff if the hashes don't match.
515
516 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
517
518         Update custom line breaking iterators to the latest version of Unicode
519         https://bugs.webkit.org/show_bug.cgi?id=168182
520
521         Reviewed by Zalan Bujtas.
522
523         Treat the system's ICU as the source of truth to compare breaking positions against.
524
525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
526         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
527         (generateJavaScriptForTest):
528         (breakingLocationsFromICU):
529         (testAFewStrings):
530         (TEST):
531         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
532         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
533
534 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
535
536         [GTK] Several failing WebViewEditor API tests
537         https://bugs.webkit.org/show_bug.cgi?id=161608
538
539         Reviewed by Carlos Garcia Campos.
540
541         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
542         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
543         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
544         except the first one, which is still broken due to unrelated bug #151654.
545
546         * Scripts/run-gtk-tests:
547         (TestRunner):
548         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
549
550 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
551
552         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
553
554         * Scripts/run-gtk-tests:
555         (TestRunner):
556
557 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
558
559         Unreviewed, skip flaky form-controls-associated-signal test
560
561         * Scripts/run-gtk-tests:
562         (TestRunner):
563
564 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
565
566         [GTK] Handle caps lock indicator in event modifiers
567         https://bugs.webkit.org/show_bug.cgi?id=168186
568
569         Reviewed by Michael Catanzaro.
570
571         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
572         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
573
574 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
575
576         MiniBrowser WK1 fails to update URL for within-page navigations
577         https://bugs.webkit.org/show_bug.cgi?id=168173
578
579         Reviewed by Tim Horton.
580         
581         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
582         anchors updates the URL field.
583
584         * MiniBrowser/mac/WK1BrowserWindowController.m:
585         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
586
587 2017-02-10  John Wilander  <wilander@apple.com>
588
589         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
590         https://bugs.webkit.org/show_bug.cgi?id=167474
591         <rdar://problem/24681808>
592         <rdar://problem/24703286>
593         <rdar://problem/30290270>
594
595         This patch adds test infrastructure to allow testing 
596         of the various rules in place for data records removal.
597
598         Reviewed by Andy Estes.
599
600         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
601         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
602         (WTR::InjectedBundle::didReceiveMessageToPage):
603             Callback mechanism to tell pages that a website data store
604             scan has happened.
605         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
606         (WTR::TestRunner::setStatisticsPrevalentResource):
607         (WTR::TestRunner::isStatisticsPrevalentResource):
608         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
609         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
610         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
611         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
612         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
613         (WTR::TestRunner::statisticsFireDataModificationHandler):
614         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
615         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
616         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
617         (WTR::TestRunner::statisticsResetToConsistentState):
618         * WebKitTestRunner/InjectedBundle/TestRunner.h:
619         * WebKitTestRunner/TestController.cpp:
620         (WTR::TestController::setStatisticsPrevalentResource):
621         (WTR::TestController::isStatisticsPrevalentResource):
622         (WTR::TestController::setStatisticsHasHadUserInteraction):
623         (WTR::TestController::isStatisticsHasHadUserInteraction):
624         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
625         (WTR::TestController::statisticsFireDataModificationHandler):
626         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
627         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
628         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
629         (WTR::TestController::statisticsResetToConsistentState):
630         * WebKitTestRunner/TestController.h:
631             These are all configuration and test functions.
632         * WebKitTestRunner/TestInvocation.cpp:
633         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
634
635 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
636
637         REGRESSION(r182916) run-perf-tests never timeouts
638         https://bugs.webkit.org/show_bug.cgi?id=167626
639
640         Reviewed by Ryosuke Niwa.
641
642         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
643         was beeing ignored because the driver was created with no_timeout=True
644         unconditionally.
645         This adds a new parameter --no-timeout (disabled by default), that
646         allows to use the driver with the expected timeout values.
647         It also passes --no-timeout to DRT/WTR to ensure that timeouts
648         are always controlled by the Python Driver.
649
650         * Scripts/webkitpy/performance_tests/perftest.py:
651         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
652         (PerfTest.run): Disabling timeout should be done when the Driver is created.
653         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
654         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
655         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
656         (_run_tests_set): Pass the no-timeout parameter.
657         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
658         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
659         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
660         (MainTest.test_parse_args): Test that the argument no-timeout.
661
662 2017-02-10  Daniel Bates  <dabates@apple.com>
663
664         Detach frame from document when entering page cache
665         https://bugs.webkit.org/show_bug.cgi?id=166774
666         <rdar://problem/29904368>
667
668         Reviewed by Chris Dumez.
669
670         * DumpRenderTree/mac/DumpRenderTree.mm:
671         (resetWebPreferencesToConsistentValues):
672         * DumpRenderTree/win/DumpRenderTree.cpp:
673         (resetWebPreferencesToConsistentValues):
674         * WebKitTestRunner/TestController.cpp:
675         (WTR::TestController::resetPreferencesToConsistentValues):
676
677 2017-02-10  Tim Horton  <timothy_horton@apple.com>
678
679         Infinite UI process hang under ensurePositionInformationIsUpToDate
680         https://bugs.webkit.org/show_bug.cgi?id=168154
681         <rdar://problem/30428673>
682
683         Reviewed by Simon Fraser.
684
685         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
686         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
687         (recursiveFindHighlightLongPressRecognizer):
688         (TEST):
689         Add a somewhat nasty test that does an async interaction information update, but
690         kills the Web process before it arrives, and then does a sync interaction
691         information update, which will wait for the oustanding async interaction
692         information update if we still think it's coming. Before the patch, this
693         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
694
695 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
696
697         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
698         https://bugs.webkit.org/show_bug.cgi?id=168127
699         rdar://problem/30467120
700
701         Reviewed by Tim Horton.
702
703         Reparent the web view before we try to fetch it via:
704             [[[window contentView] subviews] objectAtIndex:0];
705         which would throw an exception if the test unparented it.
706
707         * DumpRenderTree/mac/DumpRenderTree.mm:
708         (resetWebViewToConsistentStateBeforeTesting):
709         (runTest):
710
711 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
712
713         [Resource Timing] Enable Resource Timing by default in Tests
714         https://bugs.webkit.org/show_bug.cgi?id=168145
715
716         Reviewed by Ryosuke Niwa.
717
718         * DumpRenderTree/mac/DumpRenderTree.mm:
719         (resetWebPreferencesToConsistentValues):
720         * DumpRenderTree/win/DumpRenderTree.cpp:
721         (resetWebPreferencesToConsistentValues):
722         * WebKitTestRunner/TestController.cpp:
723         (WTR::TestController::resetPreferencesToConsistentValues):
724
725 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
726
727         Removing LayoutTestRelay
728         https://bugs.webkit.org/show_bug.cgi?id=165927
729
730         Reviewed by Daniel Bates.
731         Part 2
732
733         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
734         simulators through simctl (iOS 10 and later), use this functionality instead.
735
736         * BuildSlaveSupport/built-product-archive:
737         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
738         Added a FIXME that we will need to implement similar archiving machinery once we build
739         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
740         * BuildSlaveSupport/kill-old-processes:
741         (main): Remove LayoutTestRelay from list of processes.
742         * LayoutTestRelay: Removed LayoutTestRelay.
743         * Makefile:
744         * Scripts/build-layouttestrelay: Removed.
745         * Scripts/build-webkit: Removed LayoutTestRelay references.
746
747 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
748
749         [WebCrypto] Add WebCryptoAPI to watchlist
750         https://bugs.webkit.org/show_bug.cgi?id=168138
751
752         Reviewed by Youenn Fablet.
753
754         * Scripts/webkitpy/common/config/watchlist:
755
756 2017-02-10  Brady Eidson  <beidson@apple.com>
757
758         Replace all WebKit Library Version checks in WK2 with SDK version checks.
759         https://bugs.webkit.org/show_bug.cgi?id=168124
760
761         Reviewed by Geoffrey Garen.
762
763         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
764         
765         * MiniBrowser/mac/main.m:
766         (main):
767         * MobileMiniBrowser/MobileMiniBrowser/main.m:
768         (main):
769         * TestWebKitAPI/ios/mainIOS.mm:
770         (main):
771         * TestWebKitAPI/mac/mainMac.mm:
772         (main):
773         * WebKitTestRunner/ios/mainIOS.mm:
774         (main):
775         * WebKitTestRunner/mac/main.mm:
776         (setDefaultsToConsistentValuesForTesting):
777
778 2017-02-10  Alex Christensen  <achristensen@webkit.org>
779
780         Fix El Capitan build.
781
782         * Scripts/build-webkit:
783         Don't build libwebrtc anywhere for now.
784
785 2017-02-10  Andy Estes  <aestes@apple.com>
786
787         Move two MiniBrowserBundle settings out of the .pbxproj
788         https://bugs.webkit.org/show_bug.cgi?id=168106
789
790         Reviewed by Tim Horton.
791
792         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
793         the project file. This removes the project file override.
794
795         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
796
797         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
798         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
799
800 2017-02-10  Alex Christensen  <achristensen@webkit.org>
801
802         Fix 32-and-64-bit build on El Capitan.
803
804         * Scripts/build-webkit:
805         Somebody's building with something like this:
806         build-webkit ARCHS="i386 x86_64"
807         We want this to also not build libwebrtc for now.
808
809 2017-02-10  Alex Christensen  <achristensen@webkit.org>
810
811         Fix 32-bit build on El Capitan.
812
813         * Scripts/build-webkit:
814         The bot uses ARCHS=i386 instead of --32-bit.
815         This is a hack, but it should fix the bot until I can do a better fix in the morning.
816
817 2017-02-10  Alex Christensen  <achristensen@webkit.org>
818
819         Fix 32-bit build on El Capitan.
820
821         * Scripts/build-webkit:
822         Don't build i386 libwebrtc.
823
824 2017-02-09  Alex Christensen  <achristensen@webkit.org>
825
826         Unreviewed, rolling out r212040.
827
828         Broke build.  I'm not surprised
829
830         Reverted changeset:
831
832         "[WebRTC][Mac] Activate libwebrtc"
833         https://bugs.webkit.org/show_bug.cgi?id=167293
834         http://trac.webkit.org/changeset/212040
835
836 2017-02-09  Alex Christensen  <achristensen@webkit.org>
837
838         Build libwebrtc on bots without using it yet
839         https://bugs.webkit.org/show_bug.cgi?id=168062
840
841         Reviewed by Brent Fulgham.
842
843         * Scripts/build-webkit:
844
845 2017-02-09  Alex Christensen  <achristensen@webkit.org>
846
847         Don't build libwebrtc.
848
849         * Scripts/build-webkit:
850         Not ready yet.  It broke El Capitan and iOS.
851
852 2017-02-09  Alex Christensen  <achristensen@webkit.org>
853
854         Build libwebrtc on bots without using it yet
855         https://bugs.webkit.org/show_bug.cgi?id=168062
856
857         Reviewed by Brent Fulgham.
858
859         * Scripts/build-webkit:
860
861 2017-02-09  Alex Christensen  <achristensen@webkit.org>
862
863         Rename isAppleMacWebKit to isAppleCocoaWebKit
864         https://bugs.webkit.org/show_bug.cgi?id=168075
865
866         Reviewed by Geoffrey Garen.
867
868         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
869
870         * Scripts/build-api-tests:
871         * Scripts/build-dumprendertree:
872         * Scripts/build-jsc:
873         (buildMyProject):
874         * Scripts/build-layouttestrelay:
875         * Scripts/build-webkit:
876         * Scripts/build-webkittestrunner:
877         * Scripts/run-api-tests:
878         (isSupportedPlatform):
879         (runTest):
880         (listAllTests):
881         (prepareEnvironmentForRunningTestTool):
882         * Scripts/run-content-extension-tester:
883         * Scripts/run-javascriptcore-tests:
884         * Scripts/run-minibrowser:
885         * Scripts/show-pretty-diff:
886         * Scripts/webkitdirs.pm:
887         (determineBaseProductDir):
888         (determineArchitecture):
889         (determinePassedArchitecture):
890         (safariPath):
891         (builtDylibPathForName):
892         (checkFrameworks):
893         (isAppleWebKit):
894         (isAppleCocoaWebKit):
895         (determineNmPath):
896         (launcherName):
897         (wrapperPrefixIfNeeded):
898         (isCMakeBuild):
899         (mobileSafariBundle):
900         (debugSafari):
901         (runSafari):
902         (runMiniBrowser):
903         (debugMiniBrowser):
904         (runWebKitTestRunner):
905         (debugWebKitTestRunner):
906         (isAppleMacWebKit): Deleted.
907         * Scripts/webkitperl/FeatureList.pm:
908
909 2017-02-09  Alex Christensen  <achristensen@webkit.org>
910
911         Revert r211991
912         https://bugs.webkit.org/show_bug.cgi?id=168062
913
914         * Scripts/build-webkit:
915         Not quite ready yet.
916
917 2017-02-09  Alex Christensen  <achristensen@webkit.org>
918
919         Build libwebrtc on bots without using it yet
920         https://bugs.webkit.org/show_bug.cgi?id=168062
921
922         Reviewed by Brent Fulgham.
923
924         * Scripts/build-webkit:
925         Build libwebrtc on Mac when we build ANGLE.
926
927 2017-02-09  Youenn Fablet  <youenn@apple.com>
928
929         Improve W3C importer command line options
930         https://bugs.webkit.org/show_bug.cgi?id=167448
931
932         Reviewed by Ryosuke Niwa.
933
934         Making the list of test paths to import the main arguments of the script.
935         Allow passing the source directory to import as a -s option.
936         Adding a warning when given test paths are skipped by default in ImportExpectations.
937
938         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
939         Link conversion rules do not change when imported tests are downloaded by the script.
940
941         * Scripts/webkitpy/w3c/test_importer.py:
942         (main):
943         (parse_args):
944         (TestImporter.__init__):
945         (TestImporter.do_import):
946         (TestImporter):
947         (TestImporter.check_imported_expectations):
948
949 2017-02-08  Chris Dumez  <cdumez@apple.com>
950
951         Update web-platform-tests resources
952         https://bugs.webkit.org/show_bug.cgi?id=168026
953
954         Reviewed by Youenn Fablet.
955
956         Stop copying testharness.js from resources/ to web-platform-tests/resources.
957
958         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
959         (WebPlatformTestServer._copy_webkit_test_files):
960
961 2017-02-08  Andy Estes  <aestes@apple.com>
962
963         Custom protocols should not continue loading after a network process crash
964         https://bugs.webkit.org/show_bug.cgi?id=168028
965         <rdar://problem/27607520>
966
967         Reviewed by Brady Eidson.
968
969         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
970         (processGroup):
971         (-[CloseWhileStartingProtocol startLoading]):
972         (-[CloseWhileStartingProtocol stopLoading]):
973         (TestWebKitAPI::runTest):
974         (TestWebKitAPI::TEST):
975
976 2017-02-08  Dan Bernstein  <mitz@apple.com>
977
978         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
979         https://bugs.webkit.org/show_bug.cgi?id=168031
980
981         Reviewed by Tim Horton.
982
983         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
984         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
985         (TEST):
986         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
987         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
988
989 2017-02-08  Chris Dumez  <cdumez@apple.com>
990
991         Use smaller tiles in windows that are not active to facilitate App Napping
992         https://bugs.webkit.org/show_bug.cgi?id=167997
993         <rdar://problem/30358835>
994
995         Reviewed by Simon Fraser.
996
997         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
998         (WTR::PlatformWebView::setWindowIsKey):
999         Actually update windowIsKey state of NSWindow so the WebView
1000         properly updates its activity state.
1001
1002 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1003
1004         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
1005         https://bugs.webkit.org/show_bug.cgi?id=167942
1006         <rdar://problem/30315079>
1007
1008         Reviewed by Tim Horton.
1009
1010         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
1011         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
1012         contenteditable in these cases.
1013
1014         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
1015         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
1016         performDragOperation:) directly.
1017
1018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1019         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
1020         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
1021         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
1022         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
1023         (-[DragSource draggingSourceOperationMaskForLocal:]):
1024         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
1025         (-[DragInfo lastMousePosition]):
1026         (-[DragInfo setLastMousePosition:]):
1027         (-[DragInfo draggingDestinationWindow]):
1028         (-[DragInfo draggingSourceOperationMask]):
1029         (-[DragInfo draggingLocation]):
1030         (-[DragInfo draggedImageLocation]):
1031         (-[DragInfo draggedImage]):
1032         (-[DragInfo draggingPasteboard]):
1033         (-[DragInfo draggingSource]):
1034         (-[DragInfo draggingSequenceNumber]):
1035         (-[DragInfo slideDraggedImageTo:]):
1036         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
1037         (-[DragInfo draggingFormation]):
1038         (-[DragInfo setDraggingFormation:]):
1039         (-[DragInfo animatesToDestination]):
1040         (-[DragInfo setAnimatesToDestination:]):
1041         (-[DragInfo numberOfValidItemsForDrop]):
1042         (-[DragInfo setNumberOfValidItemsForDrop:]):
1043         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1044         (-[DragInfo springLoadingHighlight]):
1045         (-[DragInfo resetSpringLoading]):
1046         (TestWebKitAPI::getTestImage):
1047         (TestWebKitAPI::webViewAfterPerformingDragOperation):
1048         (TestWebKitAPI::TEST):
1049         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
1050
1051 2017-02-08  Jer Noble  <jer.noble@apple.com>
1052
1053         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
1054         https://bugs.webkit.org/show_bug.cgi?id=168007
1055
1056         Reviewed by Alex Christensen.
1057
1058         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1059         (didFinishLoadForFrame):
1060         (TestWebKitAPI::TEST):
1061
1062 2017-02-08  Commit Queue  <commit-queue@webkit.org>
1063
1064         Unreviewed, rolling out r211873.
1065         https://bugs.webkit.org/show_bug.cgi?id=168001
1066
1067         It's in jhbuild for consistent layout tests (Requested by
1068         mcatanzaro on #webkit).
1069
1070         Reverted changeset:
1071
1072         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
1073         https://bugs.webkit.org/show_bug.cgi?id=167993
1074         http://trac.webkit.org/changeset/211873
1075
1076 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
1077
1078         [GTK] Add icu packages to Tools/gtk/install-dependencies
1079         https://bugs.webkit.org/show_bug.cgi?id=167993
1080
1081         Reviewed by Michael Catanzaro.
1082
1083         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
1084         depending in the GNU/Linux distribution)
1085
1086 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1087
1088         Update flakiness dashboard configuration.
1089         https://bugs.webkit.org/show_bug.cgi?id=167957
1090
1091         Reviewed by Alexey Proskuryakov.
1092
1093         * TestResultServer/static-dashboards/builders.jsonp:
1094
1095 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1096
1097         Replace a bot that has an incorrect configuration.
1098         https://bugs.webkit.org/show_bug.cgi?id=167747
1099
1100         Rubber-stamped by Alexey Proskuryakov.
1101
1102         * BuildSlaveSupport/build.webkit.org-config/config.json:
1103
1104 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
1105
1106         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
1107         https://bugs.webkit.org/show_bug.cgi?id=167927
1108
1109         Reviewed by Brent Fulgham.
1110
1111         Enable ComplexTextController API tests on the Win and GTK ports.
1112
1113         * TestWebKitAPI/PlatformGTK.cmake:
1114         * TestWebKitAPI/PlatformWin.cmake:
1115
1116 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
1117
1118         File index appended to previous file in svn-create-patch with SVN 1.9
1119         https://bugs.webkit.org/show_bug.cgi?id=167903
1120         <rdar://problem/30387395>
1121
1122         Reviewed by Daniel Bates.
1123
1124         * Scripts/VCSUtils.pm:
1125         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
1126         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
1127         trailing newline character from the expected result before comparing it to the actual result.
1128
1129 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
1130
1131         [webkitdirs] remove unused host_processor variable in determineArchitecture()
1132         https://bugs.webkit.org/show_bug.cgi?id=167936
1133
1134         Reviewed by Michael Catanzaro.
1135
1136         * Scripts/webkitdirs.pm:
1137         (determineArchitecture):
1138         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
1139         since r195083.
1140
1141 2017-02-07  Youenn Fablet  <youenn@apple.com>
1142
1143         Use a JSON file to define which WPT files/folders to import
1144         https://bugs.webkit.org/show_bug.cgi?id=167923
1145
1146         Reviewed by Alex Christensen.
1147
1148         * Scripts/webkitpy/w3c/test_downloader.py:
1149         (TestDownloader.__init__):
1150         (TestDownloader._init_paths_from_expectations):
1151         * Scripts/webkitpy/w3c/test_importer.py:
1152         (parse_args):
1153         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1154
1155 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1156
1157         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
1158         https://bugs.webkit.org/show_bug.cgi?id=167916
1159
1160         Reviewed by Carlos Garcia Campos.
1161
1162         URL of mesa-11.0.6.tar.xz has been moved.
1163
1164         * gtk/jhbuild.modules: Fix the module path.
1165
1166 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
1167
1168         Static Analyzer: Address some leaks in MiniBrowser
1169         https://bugs.webkit.org/show_bug.cgi?id=167897
1170
1171         Reviewed by Alexey Proskuryakov.
1172
1173         * MiniBrowser/mac/BrowserWindowController.m:
1174         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
1175         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1176         (-[ExtensionManagerWindowController add:]):
1177         (-[ExtensionManagerWindowController remove:]):
1178         * MiniBrowser/mac/SettingsController.m:
1179         (-[SettingsController _populateMenu]):
1180         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
1181         Address obvious leaks caught by the static analyzer.
1182
1183 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
1184
1185         Migrate ComplexTextController to use platform-independent types
1186         https://bugs.webkit.org/show_bug.cgi?id=167833
1187
1188         Reviewed by Brent Fulgham.
1189
1190         Migrate tests away from platform-dependent types.
1191
1192         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1193         (TestWebKitAPI::TEST_F):
1194
1195 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
1196
1197         Correct File Path Handling in SecurityOrigin and FileSystem
1198         https://bugs.webkit.org/show_bug.cgi?id=167894
1199         <rdar://problem/30380080>
1200
1201         Reviewed by Alexey Proskuryakov.
1202
1203         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
1204         and perform same-volume checks using filesystem-compatible paths.        
1205         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
1206         filesystem paths, and perform validation of same-volume checks.
1207         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
1208         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
1209         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
1210         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
1211
1212 2017-02-06  Jer Noble  <jer.noble@apple.com>
1213
1214         Playback stalls when a SourceBuffer append causes frame eviction
1215         https://bugs.webkit.org/show_bug.cgi?id=167834
1216
1217         Reviewed by Eric Carlson.
1218
1219         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
1220         for the WTF::MediaTime class.
1221
1222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1223         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1224         (TestWebKitAPI::TEST):
1225         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
1226         (WTF::operator<<):
1227         (TestWebKitAPI::TestSample::create):
1228         (TestWebKitAPI::TestSample::TestSample):
1229         (TestWebKitAPI::TEST_F):
1230
1231 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
1232
1233         Change capitalization in platform name after r211735.
1234
1235         Unreviewed dashboard fix.
1236
1237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1238         (WebKitBuildbot):
1239
1240 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
1241
1242         Move the Leaks bot to Sierra
1243         https://bugs.webkit.org/show_bug.cgi?id=167886
1244
1245         Reviewed by Daniel Bates.
1246
1247         * BuildSlaveSupport/build.webkit.org-config/config.json:
1248         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1249         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1250         (LeaksViewer._displayURLPrompt):
1251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1252         (WebKitBuildbot):
1253
1254 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
1255
1256         Prevent app crash on launch during simctl install workaround
1257         https://bugs.webkit.org/show_bug.cgi?id=167685
1258
1259         Reviewed by Daniel Bates.
1260
1261         * Scripts/webkitpy/port/simulator_process.py:
1262         (SimulatorProcess.__init__): Pass environment to install.
1263         * Scripts/webkitpy/xcode/simulator.py:
1264         (Device.install_app): Accept environment, pass environment to launch.
1265
1266 2017-02-06  Alex Christensen  <achristensen@webkit.org>
1267
1268         Rebase API tests after r211638
1269         https://bugs.webkit.org/show_bug.cgi?id=167779
1270
1271         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1272         (TestWebKitAPI::TEST_F):
1273         URLs with non-special schemes and characters like % in the host now fail to parse,
1274         more like their special counterparts and according to spec.
1275
1276 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
1277
1278         Unreviewed trivial fix after r211697.
1279         https://bugs.webkit.org/show_bug.cgi?id=167863
1280
1281         * Scripts/run-javascriptcore-tests:
1282         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
1283
1284 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
1285
1286         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
1287         https://bugs.webkit.org/show_bug.cgi?id=167850
1288
1289         Reviewed by Tim Horton.
1290
1291         * DumpRenderTree/TestRunner.cpp:
1292         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
1293
1294 2017-02-04  Andreas Kling  <akling@apple.com>
1295
1296         Plug some leaks in TestController and UIScriptContext.
1297         <https://webkit.org/b/167839>
1298
1299         Reviewed by Alexey Proskuryakov.
1300
1301         Fix a couple of the leaks seen on the leaks bot.
1302
1303         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1304         (UIScriptContext::runUIScript):
1305         * WebKitTestRunner/TestController.cpp:
1306         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1307         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1308
1309 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
1310
1311         WK1 mouse events are missing movementX and movementY for pointerlock.
1312         https://bugs.webkit.org/show_bug.cgi?id=167775
1313         rdar://problem/30343810
1314
1315         Reviewed by Alexey Proskuryakov.
1316
1317         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
1318
1319         * DumpRenderTree/mac/EventSendingController.mm:
1320         (-[EventSendingController mouseMoveToX:Y:]):
1321         * WebKitTestRunner/mac/EventSenderProxy.mm:
1322         (WTR::EventSenderProxy::mouseMoveTo):
1323
1324 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
1325
1326         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
1327         https://bugs.webkit.org/show_bug.cgi?id=167774
1328
1329         Reviewed by Tim Horton.
1330
1331         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
1332         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
1333         web process are async, so the callback fires after the web process gets the new state.
1334
1335         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1336         (WTR::UIScriptController::removeViewFromWindow):
1337         (WTR::UIScriptController::addViewToWindow):
1338         * DumpRenderTree/mac/DumpRenderTree.mm:
1339         (createWebViewAndOffscreenWindow):
1340         (resetWebViewToConsistentStateBeforeTesting):
1341         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1342         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1343         (WTR::UIScriptController::removeViewFromWindow):
1344         (WTR::UIScriptController::addViewToWindow):
1345         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1346         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1347         (WTR::UIScriptController::removeViewFromWindow):
1348         (WTR::UIScriptController::addViewToWindow):
1349         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1350         * WebKitTestRunner/PlatformWebView.h:
1351         * WebKitTestRunner/TestController.cpp:
1352         (WTR::TestController::resetStateToConsistentValues):
1353         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1354         (WTR::PlatformWebView::removeFromWindow):
1355         (WTR::PlatformWebView::addToWindow):
1356         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1357         (WTR::UIScriptController::removeViewFromWindow):
1358         (WTR::UIScriptController::addViewToWindow):
1359         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1360         (WTR::PlatformWebView::removeFromWindow):
1361         (WTR::PlatformWebView::addToWindow):
1362         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1363         (WTR::UIScriptController::removeViewFromWindow):
1364         (WTR::UIScriptController::addViewToWindow):
1365
1366 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
1367
1368         Remove check for SkipSafariExecutableEntitlementChecks
1369         https://bugs.webkit.org/show_bug.cgi?id=167762
1370
1371         Reviewed by Dan Bernstein.
1372
1373         Follow-up fix: don't break internal behavior.
1374
1375         * Scripts/webkitdirs.pm:
1376         (safariPath):
1377         (executableHasEntitlements): Deleted.
1378         (safariPathFromSafariBundle): Deleted.
1379         (installedSafariPath): Deleted.
1380
1381 2017-02-03  Daniel Bates  <dabates@apple.com>
1382
1383         [Mac][WK2] Add SPI to override the Content Security Policy of a page
1384         https://bugs.webkit.org/show_bug.cgi?id=167810
1385         <rdar://problem/30102568>
1386
1387         Reviewed by Anders Carlsson.
1388
1389         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
1390
1391         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1392         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
1393         (TEST):
1394         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
1395         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
1396         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
1397         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
1398
1399 2017-02-02  Alex Christensen  <achristensen@webkit.org>
1400
1401         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
1402         https://bugs.webkit.org/show_bug.cgi?id=167773
1403         <rdar://problem/30221102>
1404
1405         Reviewed by Ryosuke Niwa.
1406
1407         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1408         (TestWebKitAPI::TEST_F):
1409
1410 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
1411
1412         Remove check for SkipSafariExecutableEntitlementChecks
1413         https://bugs.webkit.org/show_bug.cgi?id=167762
1414         rdar://problem/22480673
1415
1416         Reviewed by Dan Bernstein.
1417
1418         * Scripts/webkitdirs.pm:
1419         (safariPathFromSafariBundle):
1420         (skipSafariExecutableEntitlementChecks): Deleted.
1421
1422 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
1423
1424         Undefined subroutine in svn-create-patch
1425         https://bugs.webkit.org/show_bug.cgi?id=167742
1426
1427         Unreviewed build-fix after r211543.
1428
1429         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
1430
1431 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1432
1433         Unreviewed. Fix jhbuild dependencies build.
1434
1435         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1436         Patch updated.
1437
1438 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1439
1440         [EME][GStreamer] Fixed decryptor selection
1441         https://bugs.webkit.org/show_bug.cgi?id=167588
1442
1443         Reviewed by Žan Doberšek.
1444
1445         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
1446
1447         * gtk/jhbuild.modules: Added patches to gstreamer and
1448         gst-plugins-good packages.
1449         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1450         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1451
1452 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
1453
1454         Make run-benchmark script supports 'config' key in test plan.
1455         https://bugs.webkit.org/show_bug.cgi?id=167715
1456
1457         Reviewed by Ryosuke Niwa.
1458
1459         Add support for 'config' key in test paln.
1460         'config' key is a dictionary that specifies environment configurations while test is running.
1461         Specifies orientation to be portrait in MotionMark benchmark.
1462
1463         * Scripts/webkitpy/benchmark_runner/README.md:
1464         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1465         (BenchmarkRunner.__init__):
1466         (BenchmarkRunner._run_benchmark):
1467         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1468         (BrowserDriver.prepare_env):
1469         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1470         (LinuxBrowserDriver.prepare_env):
1471         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1472         (OSXBrowserDriver.prepare_env):
1473         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1474         (OSXSafariDriver.prepare_env):
1475         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1476
1477 2017-02-01  Daniel Bates  <dabates@apple.com>
1478
1479         REGRESSION (r210820): svn-create-patch does not emit property change only diff
1480         https://bugs.webkit.org/show_bug.cgi?id=167169
1481
1482         Reviewed by David Kilzer.
1483
1484         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
1485         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
1486         header from the output of "svn diff" on a file that was copied or moved.
1487
1488         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
1489         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
1490         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
1491         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
1492         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
1493         of a file with only a property change also does not contain any chunk range lines. Therefore
1494         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
1495         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
1496         we should directly test for the presence of a leading SVN diff header with an empty body and
1497         remove such lines from the diff.
1498
1499         * Scripts/VCSUtils.pm:
1500         (fixSVNPatchForAdditionWithHistory): Added.
1501         * Scripts/svn-create-patch:
1502         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
1503         we have a non empty patch for an added file with history (i.e. a copied or moved file).
1504         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
1505
1506 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
1507
1508         [Mac] Update CARingBuffer class
1509         https://bugs.webkit.org/show_bug.cgi?id=167656
1510
1511         Reviewed by Jer Noble.
1512
1513         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1514         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
1515         (TestWebKitAPI::CARingBufferTest::SetUp):
1516         (TestWebKitAPI::CARingBufferTest::setup):
1517         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
1518         (TestWebKitAPI::CARingBufferTest::description):
1519         (TestWebKitAPI::CARingBufferTest::bufferList):
1520         (TestWebKitAPI::CARingBufferTest::ringBuffer):
1521         (TestWebKitAPI::CARingBufferTest::capacity):
1522         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
1523         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
1524         (TestWebKitAPI::TEST_F):
1525         (TestWebKitAPI::MixingTest::run):
1526
1527 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
1528
1529         [Mac] TestWebKitAPI includes system frameworks incorrectly
1530         https://bugs.webkit.org/show_bug.cgi?id=167703
1531         rdar://problem/30301498
1532
1533         Reviewed by Ryosuke Niwa.
1534
1535         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
1536         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
1537
1538         Also, reduced the number of subframework search paths, looks like we only need one now.
1539
1540         * TestWebKitAPI/Configurations/Base.xcconfig:
1541
1542 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
1543
1544         Correct "filesHaveSameVolume" predicate
1545         https://bugs.webkit.org/show_bug.cgi?id=167696
1546         <rdar://problem/30298722>
1547
1548         Reviewed by David Kilzer.
1549
1550         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
1551         percent-escaped path inputs.
1552
1553         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
1554         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
1555         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
1556         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
1557         (TestWebKitAPI::TEST_F):
1558
1559 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1560
1561         Unreviewed. Fix coding style in MiniBrowser
1562
1563         * MiniBrowser/gtk/BrowserWindow.c:
1564         (editingCommandCallback):
1565         (insertImageCommandCallback):
1566         (insertLinkCommandCallback):
1567
1568 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1569
1570         [GTK] Add an API to add a custom tab into the print dialog
1571         https://bugs.webkit.org/show_bug.cgi?id=151998
1572
1573         Reviewed by Carlos Garcia Campos.
1574
1575         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
1576         that is testing a newly added API.
1577
1578         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1579         (testPrintCustomWidget):
1580         (beforeAll):
1581
1582 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
1583
1584         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
1585         https://bugs.webkit.org/show_bug.cgi?id=166529
1586
1587         Reviewed by Xabier Rodriguez-Calvar.
1588
1589         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
1590         New patch version accepted in GStreamer upstream.
1591
1592 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1593
1594         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
1595         https://bugs.webkit.org/show_bug.cgi?id=167498
1596
1597         Reviewed by Carlos Garcia Campos.
1598
1599         Depending on the distro version you can need either libxfont1-dev
1600         or libfont-dev to build with jhbuild.
1601
1602         * gtk/install-dependencies:
1603
1604 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1605
1606         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
1607         https://bugs.webkit.org/show_bug.cgi?id=167594
1608
1609         Unreviewed test gardening.
1610
1611         Disabling this test while we investigate the cause of a timeout on ios-simulator.
1612
1613         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1614         (TEST):
1615
1616 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
1617
1618         Move slow-running microbenchmarks out of JSTests/microbenchmarks
1619         https://bugs.webkit.org/show_bug.cgi?id=167676
1620
1621         Reviewed by Saam Barati.
1622
1623         * Scripts/run-javascriptcore-tests:
1624         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
1625
1626 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
1627
1628         Make Dump Render Tree not crash
1629         https://bugs.webkit.org/show_bug.cgi?id=167667
1630
1631         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
1632         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
1633         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
1634         This does not fix any tests, it just fixes the crash.
1635         
1636         Reviewed by Simon Fraser.
1637
1638         * DumpRenderTree/TestRunner.cpp:
1639         (TestRunner::callUIScriptCallback):
1640
1641 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1642
1643         Workaround for simctl install failing to report install failure
1644         https://bugs.webkit.org/show_bug.cgi?id=167654
1645
1646         Reviewed by Daniel Bates.
1647
1648         simctl install will sometimes report success even though install has failed.
1649         To workaround this bug, we attempt an app launch after install to ensure
1650         install has succeeded.
1651
1652         * Scripts/webkitpy/xcode/simulator.py:
1653         (Device.install_app): Attempt app launch after install, retry install if launch fails.
1654         (Device.launch_app): Correct comment.
1655
1656 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1657
1658         Unreviewed webkitpy fix after r211405.
1659
1660         * Scripts/webkitpy/xcode/simulator.py:
1661         (Device.launch_app): Remove @staticmethod on _log_debug_error.
1662
1663 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1664
1665         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
1666
1667         * gtk/manifest.txt.in:
1668
1669 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
1670
1671         AX: enable search predication for iOS
1672         https://bugs.webkit.org/show_bug.cgi?id=167558
1673         <rdar://problem/30251367>
1674
1675         Reviewed by Joanmarie Diggs.
1676
1677         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1678         (AccessibilityUIElement::uiElementForSearchPredicate):
1679         * DumpRenderTree/mac/AccessibilityCommonMac.h:
1680         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1681         (searchPredicateParameterizedAttributeForSearchCriteria):
1682         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1683         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1684         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1685         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1686         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1687         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
1688         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1689         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1690         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1691         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1692         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1693
1694 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1695
1696         Workaround for simctl launch bug
1697         https://bugs.webkit.org/show_bug.cgi?id=167613
1698
1699         Reviewed by Daniel Bates.
1700
1701         simctl launch will sometimes fail because of a race condition when many
1702         simulators are being run simultaneously. These failures will always have
1703         an exit code of 1. This change attempts to launch an app multiple times
1704         before reporting a failure to workaround this bug.
1705
1706         * Scripts/webkitpy/xcode/simulator.py:
1707         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
1708
1709 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
1710
1711         Commit queue fails to look at real name aliases for the reviewer
1712         https://bugs.webkit.org/show_bug.cgi?id=167422
1713
1714         Reviewed by Joseph Pecoraro.
1715
1716         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1717         (test_has_valid_reviewer): Added tests.
1718
1719         * Scripts/webkitpy/common/config/committers.py:
1720         (CommitterList._name_to_contributor_map):
1721         Made _name_to_contributor_map include alias names.
1722
1723         * Scripts/webkitpy/common/config/committers_unittest.py:
1724         (CommittersTest.test_contributors_by_fuzzy_match):
1725         Removed subtests that are now obsolete, as these matches are strict. It is not
1726         obvious if distance based fuzzy matching for names is useful at all, but we can
1727         look into that some other time.
1728
1729 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
1730
1731         QueueStatusServer should have an explicit timeout for _fetch_url
1732         https://bugs.webkit.org/show_bug.cgi?id=167467
1733
1734         Reviewed by Alexey Proskuryakov.
1735
1736         * Scripts/webkitpy/common/net/statusserver.py:
1737         (StatusServer._fetch_url): Add an explicit timeout of 300s.
1738
1739 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
1740
1741         Add support for Trac instances that host multiple projects.
1742         https://bugs.webkit.org/show_bug.cgi?id=167524
1743
1744         Reviewed by Alexey Proskuryakov.
1745
1746         When multiple projects are hosted on a single Trac instance, the current
1747         behavior will retrieve changesets from all tracked projects.
1748         This patch teaches Trac.js to get project-specific changesets from Trac.
1749         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
1750         when querying the Trac timeline.
1751
1752         To tell Trac to be aware of multi-project instances we leverage the 
1753         `options` parameter when creating a new instance: 
1754
1755             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
1756
1757         If this option is not provided, the original behaviour will prevail.
1758         Additionally, add corresponding tests.
1759
1760         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1761         (Trac): Reason about new optional parameter 'projectIdentifier'.
1762         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
1763         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
1764         replace default parameter `changeset=on` with `repo-projectname=on`.
1765         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
1766         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1767         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
1768         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1769         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
1770         Add the following tests:
1771             test("revisionURL")
1772             test("revisionURL with Trac Identifier")
1773             test("_xmlTimelineURL")
1774             test("_xmlTimelineURL with Trac Identifier")
1775         (this.view._latestProductiveIteration): Fix missing ';'.
1776
1777 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
1778
1779         Correct spacing regression on inter-element complex path shaping on some fonts
1780         https://bugs.webkit.org/show_bug.cgi?id=166013
1781
1782         Reviewed by Simon Fraser.
1783
1784         Unskip existing tests and make some new tests:
1785         - Testing complex text with no origins
1786         - Testing initial expansions
1787         - Testing the sign of vertical advances
1788
1789         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1790         (TestWebKitAPI::TEST_F):
1791
1792 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1793
1794         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1795         https://bugs.webkit.org/show_bug.cgi?id=167596
1796
1797         Reviewed by Daniel Bates.
1798
1799         We avoid needing a thin directory by invoking the zip program with
1800         the list of directories from the build directory to be zipped,
1801         and by using the zip feature to exclude files matching a pattern.
1802
1803         * BuildSlaveSupport/built-product-archive:
1804         (copyBuildFiles):
1805         (createZipFromList):
1806         (archiveBuiltProduct):
1807
1808 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1809
1810         Use simctl instead of LayoutTestRelay
1811         https://bugs.webkit.org/show_bug.cgi?id=165927
1812
1813         Reviewed by Daniel Bates.
1814
1815         Part 1
1816
1817         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1818         simulators through simctl (iOS 10 and later), use this functionality instead.
1819
1820         * Scripts/webkitpy/port/base.py:
1821         (Port.__init__): Added _test_runner_process_constructor.
1822         * Scripts/webkitpy/port/darwin.py:
1823         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1824         * Scripts/webkitpy/port/driver.py:
1825         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1826         (IOSSimulatorDriver): Deleted.
1827         * Scripts/webkitpy/port/driver_unittest.py:
1828         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1829         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1830         (DriverTest.test_start_actually_starts): Ditto.
1831         * Scripts/webkitpy/port/ios.py:
1832         (IOSSimulatorPort): Remove relay_name.
1833         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1834         (IOSSimulatorPort._create_simulators): Formatting change.
1835         (IOSSimulatorPort.relay_path): Deleted.
1836         (IOSSimulatorPort._check_relay): Deleted.
1837         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1838         (IOSSimulatorPort._build_relay): Deleted.
1839         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1840         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1841         * Scripts/webkitpy/port/ios_unittest.py:
1842         (iosTest.test_32bit): Update test.
1843         (iosTest.test_64bit): Update test.
1844         * Scripts/webkitpy/port/server_process.py:
1845         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1846         (ServerProcess._set_file_nonblocking): Added to share common code.
1847         * Scripts/webkitpy/port/server_process_mock.py:
1848         (MockServerProcess.__init__): Added argument worker_number.
1849         * Scripts/webkitpy/port/simulator_process.py: Added.
1850         (SimulatorProcess): Added.
1851         (SimulatorProcess.Popen): Added.
1852         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1853         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1854         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1855         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1856         (SimulatorProcess._reset): Added. Unlink fifos.
1857         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1858         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1859         * Scripts/webkitpy/xcode/simulator.py:
1860         (Device.__init__): Accept host to run install/launch/terminate.
1861         (Device.install_app): Install app to target Device.
1862         (Device.launch_app): Launch app on target Device.
1863         (Device.terminate_app): Shutdown app on target Device.
1864         (Simulator._parse_devices): Pass host to Device.
1865
1866 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1867
1868         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1869         https://bugs.webkit.org/show_bug.cgi?id=167411
1870
1871         Reviewed by Michael Catanzaro.
1872
1873         Disable the ARM iwMMXt fast path for pixman, because it triggers
1874         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1875
1876         * gtk/jhbuild.modules:
1877
1878 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1879
1880         [GTK] Add API to handle the accelerated compositing policy
1881         https://bugs.webkit.org/show_bug.cgi?id=167509
1882
1883         Reviewed by Michael Catanzaro.
1884
1885         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1886         as a special case. Also add test cases to the get/set API.
1887
1888         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1889         (hardwareAccelerationPolicyToString):
1890         (stringToHardwareAccelerationPolicy):
1891         (cellRendererChanged):
1892         (browserSettingsDialogConstructed):
1893         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1894         (testWebKitSettings):
1895
1896 2017-01-29  Andy Estes  <aestes@apple.com>
1897
1898         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1899         https://bugs.webkit.org/show_bug.cgi?id=167563
1900         <rdar://problem/30253207>
1901
1902         Reviewed by Andreas Kling.
1903
1904         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1905         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1906         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1907         (runTest):
1908         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1909         (TEST):
1910
1911 2017-01-29  Dan Bernstein  <mitz@apple.com>
1912
1913         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
1914         https://bugs.webkit.org/show_bug.cgi?id=167565
1915
1916         Reviewed by Sam Weinig.
1917
1918         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1919         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
1920         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
1921         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
1922         (TEST):
1923         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
1924         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1925         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1926         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
1927
1928 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1929
1930         Add Link Preload as an off-by-default experimental feature menu item.
1931         https://bugs.webkit.org/show_bug.cgi?id=167201
1932
1933         Reviewed by Ryosuke Niwa.
1934
1935         * DumpRenderTree/mac/DumpRenderTree.mm:
1936         (resetWebPreferencesToConsistentValues):
1937         * DumpRenderTree/win/DumpRenderTree.cpp:
1938         (resetWebPreferencesToConsistentValues):
1939
1940 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1941
1942         Add User Timing Experimental Feature
1943         https://bugs.webkit.org/show_bug.cgi?id=167542
1944         <rdar://problem/22746307>
1945
1946         Reviewed by Ryosuke Niwa.
1947
1948         * DumpRenderTree/mac/DumpRenderTree.mm:
1949         (enableExperimentalFeatures):
1950         (resetWebPreferencesToConsistentValues):
1951         * DumpRenderTree/win/DumpRenderTree.cpp:
1952         (enableExperimentalFeatures):
1953
1954 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1955
1956         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
1957         https://bugs.webkit.org/show_bug.cgi?id=167519
1958
1959         Reviewed by Ryosuke Niwa.
1960
1961         * QueueStatusServer/templates/statusbubble.html:
1962         To measure the bubbleContainer's width, it must not be wrapping based
1963         on its parent container. So when measuring the width temporarily set
1964         the parent to a very large width so as to not artificially wrap us.
1965         Restore the parent's width after measuring.
1966
1967 2017-01-27  Andy Estes  <aestes@apple.com>
1968
1969         [iOS] Add a test for _WKNSFileManagerExtras
1970         https://bugs.webkit.org/show_bug.cgi?id=167478
1971
1972         Reviewed by Andreas Kling.
1973
1974         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1975         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
1976         (expectAttributes):
1977         (TEST):
1978
1979 2017-01-27  Keith Miller  <keith_miller@apple.com>
1980
1981         run-benchmarks should make sure it passes the test url to the right application
1982         https://bugs.webkit.org/show_bug.cgi?id=167533
1983
1984         Reviewed by Joseph Pecoraro.
1985
1986         This fixes an issue when trying to run-benchmark script with the
1987         system default browser set to STP. Previously, it would run
1988         the test in STP rather than the provided build. Now, it should run
1989         in the provided build.
1990
1991         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1992         (OSXSafariDriver.launch_url):
1993
1994 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1995
1996         [Cocoa] Prepare ComplexTextController for unit testing
1997         https://bugs.webkit.org/show_bug.cgi?id=167493
1998
1999         Reviewed by Simon Fraser.
2000
2001         Addressing post-review comments from Simon Fraser.
2002
2003         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2004         (TestWebKitAPI::TEST_F):
2005
2006 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2007
2008         [Cocoa] Prepare ComplexTextController for unit testing
2009         https://bugs.webkit.org/show_bug.cgi?id=167493
2010
2011         Reviewed by Dean Jackson.
2012
2013         Create four unit tests.
2014
2015         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2016         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
2017         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2018         (TestWebKitAPI::TEST_F):
2019
2020 2017-01-26  Chris Dumez  <cdumez@apple.com>
2021
2022         Crash when navigating back to a page in PacheCache when one of its frames has been removed
2023         https://bugs.webkit.org/show_bug.cgi?id=167421
2024         <rdar://problem/30188490>
2025
2026         Reviewed by Darin Adler.
2027
2028         Add a new setting allowing layout tests to enable PageCache in a window
2029         that has an opener, for convenience.
2030
2031         * DumpRenderTree/mac/DumpRenderTree.mm:
2032         (resetWebPreferencesToConsistentValues):
2033         * DumpRenderTree/win/DumpRenderTree.cpp:
2034         (resetWebPreferencesToConsistentValues):
2035         * WebKitTestRunner/TestController.cpp:
2036         (WTR::TestController::resetPreferencesToConsistentValues):
2037
2038 2017-01-26  Keith Miller  <keith_miller@apple.com>
2039
2040         classInfo should take a VM so it is not materialized from the object on each call
2041         https://bugs.webkit.org/show_bug.cgi?id=167424
2042
2043         Rubber Stamped by Michael Saboff.
2044
2045         Previously, classInfo() would get the VM from the target's
2046         MarkedBlock.  Most callers already have a VM on hand, so it is
2047         wasteful to compute the VM from the marked block every time. This
2048         patch refactors some of the most common callers of classInfo(),
2049         jsDynamicCast and inherits to take a VM as well.
2050
2051         * DumpRenderTree/TestRunner.cpp:
2052         (setAudioResultCallback):
2053
2054 2017-01-26  Jer Noble  <jer.noble@apple.com>
2055
2056         Autoplay muted videos stop playback of any streaming app in the background
2057         https://bugs.webkit.org/show_bug.cgi?id=163993
2058         <rdar://problem/29020431>
2059
2060         Reviewed by Eric Carlson.
2061
2062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2063         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2064         (TestWebKitAPI::TEST):
2065         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
2066
2067 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
2068
2069         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
2070         https://bugs.webkit.org/show_bug.cgi?id=167466
2071
2072         Unreviewed test gardening.
2073
2074         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2075         (TEST):
2076
2077 2017-01-26  Matt Rajca  <mrajca@apple.com>
2078
2079         Notify clients when the user plays media otherwise prevented from autoplaying
2080         https://bugs.webkit.org/show_bug.cgi?id=167390
2081
2082         Reviewed by Alex Christensen.
2083
2084         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2085         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2086         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2087         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2088         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2089         (TEST):
2090         * TestWebKitAPI/cocoa/TestWKWebView.h:
2091         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2092         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2093         (-[TestWKWebView waitForLoad]):
2094         (-[TestWKWebView mouseUpAtPoint:]):
2095         * WebKitTestRunner/TestController.cpp:
2096         (WTR::TestController::createOtherPage):
2097         (WTR::TestController::createWebViewWithOptions):
2098
2099 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2100
2101         Crash when setting custom scale factor.
2102         https://bugs.webkit.org/show_bug.cgi?id=167369
2103
2104         Reviewed by Sam Weinig.
2105
2106         Added API test.
2107
2108         * TestWebKitAPI/PlatformWin.cmake:
2109         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
2110         (TestWebKitAPI::WebKitCreateInstance):
2111         (TestWebKitAPI::ScaleWebView::SetUp):
2112         (TestWebKitAPI::ScaleWebView::TearDown):
2113         (TestWebKitAPI::TEST_F):
2114
2115 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2116
2117         run-benchmark nests MotionMark results by the suite name twice
2118         https://bugs.webkit.org/show_bug.cgi?id=164948
2119
2120         Reviewed by Said Abou-Hallawa.
2121
2122         Use a single level MotionMark now that this is the name of the benchmark,
2123         and we no longer have tests that aren't part of the MotionMark suite.
2124
2125         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
2126
2127 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
2128
2129         Unreviewed, rolling out r211193.
2130
2131         This change broke internal builds.
2132
2133         Reverted changeset:
2134
2135         "Notify clients when the user plays media otherwise prevented
2136         from autoplaying"
2137         https://bugs.webkit.org/show_bug.cgi?id=167390
2138         http://trac.webkit.org/changeset/211193
2139
2140 2017-01-25  Matt Rajca  <mrajca@apple.com>
2141
2142         Notify clients when the user plays media otherwise prevented from autoplaying
2143         https://bugs.webkit.org/show_bug.cgi?id=167390
2144
2145         Reviewed by Alex Christensen.
2146
2147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2148         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2149         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2150         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2151         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2152         (TEST):
2153         * TestWebKitAPI/cocoa/TestWKWebView.h:
2154         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2155         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2156         (-[TestWKWebView waitForLoad]):
2157         (-[TestWKWebView mouseUpAtPoint:]):
2158         * WebKitTestRunner/TestController.cpp:
2159         (WTR::TestController::createOtherPage):
2160         (WTR::TestController::createWebViewWithOptions):
2161
2162 2017-01-25  Matt Rajca  <mrajca@apple.com>
2163
2164         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
2165         https://bugs.webkit.org/show_bug.cgi?id=167385
2166
2167         Reviewed by Alex Christensen.
2168
2169         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
2170         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
2171         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2172         (TEST): Allow inline (rather than full screen) media playback on iOS.
2173
2174 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2175
2176         [GTK] Icon Database should be in private browsing mode for ephemeral web views
2177         https://bugs.webkit.org/show_bug.cgi?id=167414
2178
2179         Reviewed by Michael Catanzaro.
2180
2181         Add a test case to check ephemeral web views don't write favicons to the database.
2182
2183         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2184         (ephemeralViewLoadChanged):
2185         (testPrivateBrowsing):
2186         (testFaviconDatabase):
2187
2188 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2189
2190         [GTK] Add a private browsing mode to MiniBrowser
2191         https://bugs.webkit.org/show_bug.cgi?id=167413
2192
2193         Reviewed by Michael Catanzaro.
2194
2195         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
2196         private windows, even on non-private instances.
2197
2198         * MiniBrowser/gtk/BrowserWindow.c:
2199         (webViewTitleChanged): Add [Private] to title window for private windows.
2200         (webViewCreate): Pass web context to browser_window_new.
2201         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
2202         (browserWindowFinalize): Disconnect web context signal handlers.
2203         (browser_window_init): Add shortcut for opening private window.
2204         (browser_window_new): It now receives the context and connect to download-started here.
2205         (browser_window_get_web_context): Return the context.
2206         * MiniBrowser/gtk/BrowserWindow.h:
2207         * MiniBrowser/gtk/main.c:
2208         (createBrowserTab): Create the web view for the window web context.
2209         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
2210         (aboutDataHandleRequest): Ditto.
2211         (aboutURISchemeRequestCallback): Ditto.
2212         (main): Create ephemeral web context if private command line option is used.
2213
2214 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2215
2216         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
2217         https://bugs.webkit.org/show_bug.cgi?id=167409
2218
2219         Reviewed by Antti Koivisto.
2220
2221         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
2222         as well as tests for the newly added matchingElementInFlatTree.
2223
2224         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
2225         (TestWebKitAPI::runJavaScriptAlert):
2226         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2227         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2228         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
2229
2230 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2231
2232         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
2233         https://bugs.webkit.org/show_bug.cgi?id=167370
2234
2235         Reviewed by Michael Catanzaro.
2236
2237         Add several test cases of ephemeral web views.
2238
2239         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2240         (testWebViewAuthenticationStorage):
2241         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2242         (ephemeralViewloadChanged):
2243         (testCookieManagerEphemeral):
2244         (beforeAll):
2245         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2246         (testWebKitSettings):
2247         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2248         (testWebContextEphemeral):
2249         (ephemeralViewloadChanged):
2250         (testWebContextProxySettings):
2251         (beforeAll):
2252         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2253         (ephemeralViewloadChanged):
2254         (testWebViewEphemeral):
2255         (beforeAll):
2256         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
2257         (ephemeralViewloadChanged):
2258         (testWebsiteDataEphemeral):
2259         (beforeAll):
2260
2261 2017-01-24  Alex Christensen  <achristensen@webkit.org>
2262
2263         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
2264         https://bugs.webkit.org/show_bug.cgi?id=167402
2265
2266         Reviewed by Ryosuke Niwa.
2267
2268         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2269         (TestWebKitAPI::TEST):
2270
2271 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2272
2273         Add simple line layout toggle to MiniBrowser
2274         https://bugs.webkit.org/show_bug.cgi?id=167405
2275
2276         Reviewed by Andreas Kling.
2277
2278         * MiniBrowser/mac/SettingsController.h:
2279         * MiniBrowser/mac/SettingsController.m:
2280         (-[SettingsController _populateMenu]):
2281         (-[SettingsController validateMenuItem:]):
2282         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
2283         (-[SettingsController simpleLineLayoutEnabled]):
2284         * MiniBrowser/mac/WK1BrowserWindowController.m:
2285         (-[WK1BrowserWindowController didChangeSettings]):
2286         * MiniBrowser/mac/WK2BrowserWindowController.m:
2287         (-[WK2BrowserWindowController didChangeSettings]):
2288
2289 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2290
2291         WKR does not include my nick when commit-queue lands my patch
2292         https://bugs.webkit.org/show_bug.cgi?id=167388
2293
2294         Reviewed by Ryosuke Niwa.
2295
2296         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2297         (NewCommitBot._summarize_commit_log):
2298         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2299         Perform nickname insertion before grabbing "Patch by" details.
2300         This way we can include the nickname with the full name.
2301
2302 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2303
2304         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
2305         https://bugs.webkit.org/show_bug.cgi?id=167394
2306
2307         Reviewed by Ryosuke Niwa.
2308
2309         * Scripts/webkitperl/FeatureList.pm:
2310         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2311
2312 2017-01-24  Youenn Fablet  <youenn@apple.com>
2313
2314         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
2315         https://bugs.webkit.org/show_bug.cgi?id=167353
2316
2317         Reviewed by Alex Christensen.
2318
2319         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2320         (CMakeGenerator.initialize_targets):
2321
2322 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2323
2324         WKR should not confuse Miguel Gomez with Andres Gomez
2325         https://bugs.webkit.org/show_bug.cgi?id=167389
2326
2327         Reviewed by Lucas Forschler.
2328
2329         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
2330         "mAndres Gomez". Fix this.
2331
2332         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2333         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
2334         space on each side of the email address, so expect both spaces to be there before
2335         considering the email for replacement.
2336         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
2337
2338 2017-01-24  Matt Rajca  <mrajca@apple.com>
2339
2340         Pass down website autoplay policies to media elements
2341         https://bugs.webkit.org/show_bug.cgi?id=167355
2342
2343         Reviewed by Alex Christensen.
2344
2345         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2346         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
2347         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
2348         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
2349         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2350         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2351         (TEST):
2352
2353 2017-01-24  Nan Wang  <n_wang@apple.com>
2354
2355         AX: Speak Selection does not work in an iframe
2356         https://bugs.webkit.org/show_bug.cgi?id=166794
2357         <rdar://problem/29913013>
2358
2359         Reviewed by Chris Fleizach.
2360
2361         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2362         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2363         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2364         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2365         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2366         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2367         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2368         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2369         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2370         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2371         (-[TestRunnerWKWebView dealloc]):
2372         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
2373         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
2374         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2375         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2376         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2377
2378 2017-01-24  Daniel Bates  <dabates@apple.com>
2379
2380         StringView.split() should use an iterator design pattern instead of allocating a Vector
2381         https://bugs.webkit.org/show_bug.cgi?id=163225
2382
2383         Reviewed by Darin Adler.
2384
2385         Add unit tests for StringView.split().
2386
2387         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2388         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
2389         used in the StringView.split() unit tests.
2390         (TestWebKitAPI::stringViewFromUTF8): Ditto.
2391         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
2392         object to a Vector of String objects.
2393         (TestWebKitAPI::TEST): Added the following tests:
2394             - WTF.StringViewSplitEmptyAndNullStrings
2395             - WTF.StringViewSplitBasic
2396             - WTF.StringViewSplitWithConsecutiveSeparators
2397
2398 2017-01-23  Anders Carlsson  <andersca@apple.com>
2399
2400         The Score Esports crashes on launch
2401         https://bugs.webkit.org/show_bug.cgi?id=167338
2402         rdar://problem/29948645
2403
2404         Reviewed by Dan Bernstein.
2405
2406         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2407         (TestWebKitAPI::TEST):
2408         Add a test.
2409
2410 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2411
2412         [GTK] Add API to WebKitWebsiteDataManager to handle website data
2413         https://bugs.webkit.org/show_bug.cgi?id=146589
2414
2415         Reviewed by Michael Catanzaro.
2416
2417         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
2418         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
2419
2420         * MiniBrowser/gtk/BrowserWindow.c:
2421         (webViewDecidePolicy):
2422         (newTabCallback):
2423         * MiniBrowser/gtk/main.c:
2424         (createBrowserTab):
2425         (aboutDataRequestFree):
2426         (aboutDataRequestNew):
2427         (aboutDataRequestForView):
2428         (websiteDataRemovedCallback):
2429         (websiteDataClearedCallback):
2430         (aboutDataScriptMessageReceivedCallback):
2431         (domainListFree):
2432         (aboutDataFillTable):
2433         (gotWebsiteDataCallback):
2434         (aboutDataHandleRequest):
2435         (aboutURISchemeRequestCallback):
2436         (main):
2437         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2438         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2439         (serverCallback):
2440         (beforeAll):
2441         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
2442         (serverCallback):
2443         (WebsiteDataTest::WebsiteDataTest):
2444         (WebsiteDataTest::~WebsiteDataTest):
2445         (WebsiteDataTest::fetch):
2446         (WebsiteDataTest::remove):
2447         (WebsiteDataTest::clear):
2448         (testWebsiteDataConfiguration):
2449         (testWebsiteDataCache):
2450         (testWebsiteDataStorage):
2451         (testWebsiteDataDatabases):
2452         (testWebsiteDataAppcache):
2453         (beforeAll):
2454         (afterAll):
2455
2456 2017-01-23  Commit Queue  <commit-queue@webkit.org>
2457
2458         Unreviewed, rolling out r211062.
2459         https://bugs.webkit.org/show_bug.cgi?id=167354
2460
2461         broke API tests (Requested by alexchristensen on #webkit).
2462
2463         Reverted changeset:
2464
2465         "Pass down website autoplay policies to media elements"
2466         https://bugs.webkit.org/show_bug.cgi?id=167132
2467         http://trac.webkit.org/changeset/211062
2468
2469 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2470
2471         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
2472         https://bugs.webkit.org/show_bug.cgi?id=167330
2473
2474         Reviewed by Tim Horton.
2475
2476         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2477         (TestWebKitAPI::TEST_F):
2478
2479 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2480
2481         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
2482         https://bugs.webkit.org/show_bug.cgi?id=167317
2483
2484         Reviewed by Sam Weinig.
2485
2486         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2487         (TestWebKitAPI::TEST_F):
2488
2489 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
2490
2491         svn-create-patch should emit properties when files are moved or copied
2492         https://bugs.webkit.org/show_bug.cgi?id=167264
2493
2494         Reviewed by Daniel Bates.
2495
2496         * Scripts/svn-create-patch:
2497         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
2498
2499 2017-01-23  Youenn Fablet  <youenn@apple.com>
2500
2501         [WebRTC] Filter libwebrtc link flags
2502         https://bugs.webkit.org/show_bug.cgi?id=167287
2503
2504         Reviewed by Alex Christensen.
2505
2506         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2507         (CMakeGenerator._compute_link_flags):
2508         (CMakeGenerator._compute_link_flags.keep_flag):
2509         (CMakeGenerator._generate_compile_target_options):
2510
2511 2017-01-23  Youenn Fablet  <youennf@gmail.com>
2512
2513         [WebRTC] Make VP8 optional in libwebrtc
2514         https://bugs.webkit.org/show_bug.cgi?id=167257
2515
2516         Reviewed by Darin Adler.
2517
2518         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2519         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
2520
2521 2017-01-23  Jer Noble  <jer.noble@apple.com>
2522
2523         Video details does not apear and missing scrubber in Control Center
2524         https://bugs.webkit.org/show_bug.cgi?id=167233
2525
2526         Reviewed by Alex Christensen.
2527
2528         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
2529         NowPlayingControlTests for iOS.
2530
2531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2532         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2533         (-[NowPlayingTestWebView setWindowVisible:]):
2534         (TestWebKitAPI::TEST):
2535         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
2536         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2537         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2538         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
2539         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
2540         (SOFT_LINK_CLASS):
2541         (-[TestMessageHandler addMessage:withHandler:]):
2542         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
2543         (__simulated_forceClickAssociatedEventsMask):
2544         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
2545         (-[TestWKWebViewHostWindow isKeyWindow]):
2546         (-[TestWKWebViewHostWindow makeKeyWindow]):
2547         (-[TestWKWebViewHostWindow resignKeyWindow]):
2548         (-[TestWKWebView initWithFrame:]):
2549         (-[TestWKWebView initWithFrame:configuration:]):
2550         (-[TestWKWebView _setUpTestWindow:]):
2551         (-[TestWKWebView performAfterReceivingMessage:action:]):
2552         (-[TestWKWebView loadTestPageNamed:]):
2553         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
2554         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2555         (-[TestWKWebView waitForMessage:]):
2556         (-[TestWKWebView performAfterLoading:]):
2557         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2558         (-[TestWKWebView typeCharacter:]):
2559
2560 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2561
2562         Unreviewed. Bring back gtk-doc error messages after r209981.
2563
2564         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
2565         impossible to know what's wrong.
2566
2567         * gtk/gtkdoc.py:
2568         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
2569
2570 2017-01-20  Youenn Fablet  <youennf@gmail.com>
2571
2572         [WebRTC] Update build system to make G711 optional in libwebrtc
2573         https://bugs.webkit.org/show_bug.cgi?id=167256
2574
2575         Reviewed by Alex Christensen.
2576
2577         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2578         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
2579
2580 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2581
2582         Cleanup RuntimeEnabledFeatures
2583         https://bugs.webkit.org/show_bug.cgi?id=167228
2584
2585         Reviewed by Simon Fraser.
2586
2587         * DumpRenderTree/mac/DumpRenderTree.mm:
2588         (enableExperimentalFeatures):
2589         (resetWebPreferencesToConsistentValues):
2590         (setWebPreferencesForTestOptions):
2591         (resetWebViewToConsistentStateBeforeTesting):
2592         * DumpRenderTree/win/DumpRenderTree.cpp:
2593         (enableExperimentalFeatures):
2594         (resetWebPreferencesToConsistentValues):
2595         More closely match WebKitTestRunner initialization of preferences
2596         for experimental features.
2597
2598 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2599
2600         Build Fix for Windows DumpRenderTree after r210976
2601         https://bugs.webkit.org/show_bug.cgi?id=167115
2602
2603         * DumpRenderTree/win/DumpRenderTree.cpp:
2604         (resetWebPreferencesToConsistentValues):
2605
2606 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2607
2608         Remove outdated ENABLE(CSP_NEXT) build flag
2609         https://bugs.webkit.org/show_bug.cgi?id=167252
2610
2611         Reviewed by Brent Fulgham.
2612
2613         * Scripts/webkitperl/FeatureList.pm:
2614         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2615
2616 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2617
2618         Build Fix for Windows DumpRenderTree after r210976
2619
2620         * DumpRenderTree/win/DumpRenderTree.cpp:
2621         (resetWebPreferencesToConsistentValues):
2622
2623 2017-01-20  Antoine Quint  <graouts@apple.com>
2624
2625         Web Animations should be off by default and enabled as an experimental feature
2626         https://bugs.webkit.org/show_bug.cgi?id=167115
2627         <rdar://problem/30048963>
2628
2629         Reviewed by Joseph Pecoraro.
2630
2631         Turn Web Animations on in DRT.
2632
2633         * DumpRenderTree/mac/DumpRenderTree.mm:
2634         (resetWebPreferencesToConsistentValues):
2635         * DumpRenderTree/win/DumpRenderTree.cpp:
2636         (resetWebPreferencesToConsistentValues):
2637
2638 2017-01-20  Youenn Fablet  <youenn@apple.com>
2639
2640         [WebRTC] Add libwebrtc build infrastructure
2641         https://bugs.webkit.org/show_bug.cgi?id=167207
2642
2643         Reviewed by Alex Christensen.
2644
2645         Adding a script doing the libwebrtc project json to CMake file conversion.
2646
2647         * Scripts/generate-libwebrtc-cmake: Added.
2648         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
2649         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
2650
2651 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2652
2653         Mini Browser: Show tooltip for Experimental Features
2654         https://bugs.webkit.org/show_bug.cgi?id=167225
2655
2656         Reviewed by Alex Christensen.
2657
2658         * MiniBrowser/mac/SettingsController.m:
2659         (-[SettingsController _populateMenu]):
2660         Include the full details string as a tooltip.
2661
2662 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
2663
2664         [Win] Test output results should not be written twice.
2665         https://bugs.webkit.org/show_bug.cgi?id=167197
2666
2667         Reviewed by Brent Fulgham.
2668
2669         Prevent test output from being written twice by returning early from
2670         the dump() function, if it already has been called.
2671         This patch also adds a missing newline to a test output line. 
2672         
2673         * DumpRenderTree/win/DumpRenderTree.cpp:
2674         (dump):
2675
2676 2017-01-20  Antoine Quint  <graouts@apple.com>
2677
2678         [Modern Media Controls] Turn modern media controls on by default
2679         https://bugs.webkit.org/show_bug.cgi?id=165668
2680
2681         Reviewed by Dean Jackson.
2682
2683         Enabled modern media controls by default in test runners.
2684
2685         * DumpRenderTree/TestOptions.h:
2686         * WebKitTestRunner/TestOptions.h:
2687
2688 2017-01-19  Chris Dumez  <cdumez@apple.com>
2689
2690         iterable<> should be enabled on WK1
2691         https://bugs.webkit.org/show_bug.cgi?id=167221
2692         <rdar://problem/30108531>
2693
2694         Reviewed by Youenn Fablet.
2695
2696         * DumpRenderTree/mac/DumpRenderTree.mm:
2697         (resetWebPreferencesToConsistentValues):
2698         * DumpRenderTree/win/DumpRenderTree.cpp:
2699         (resetWebPreferencesToConsistentValues):
2700         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2701         (WTR::InjectedBundle::beginTesting):
2702         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2703         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
2704         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2705
2706 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
2707
2708         Ensure status server logs go to log file
2709         https://bugs.webkit.org/show_bug.cgi?id=167210
2710
2711         Reviewed by Alexey Proskuryakov.
2712
2713         * Scripts/webkitpy/common/net/statusserver.py:
2714         (StatusServer.next_work_item): Change log level from debug to info in
2715         order to facilitate deubgging issues.
2716         (StatusServer.update_work_items): Same.
2717
2718 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
2719
2720         Additional selection tests and interpolation fix
2721         https://bugs.webkit.org/show_bug.cgi?id=167171
2722
2723         Reviewed by Simon Fraser.
2724
2725         We weren't adding the final event when interpolating event streams.
2726
2727         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2728         (-[HIDEventGenerator interpolatedEvents:]):
2729
2730 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2731
2732         [Cocoa] Variation fonts are erroneously disabled on iOS
2733         https://bugs.webkit.org/show_bug.cgi?id=167172
2734
2735         Reviewed by Simon Fraser.
2736
2737         OpenSource builders don't seem to understand sdk=embedded*.
2738
2739         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2740
2741 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2742
2743         Unreviewed. Fix GTK+ unit tests failing since r210531.
2744
2745         Avoid using paths to files that don't actually exist.
2746
2747         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2748         (testWebKitConsoleMessageNetworkError):
2749         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2750         (testContextMenuDefaultMenu):
2751         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
2752         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
2753         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
2754
2755 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2756
2757         [GTK] Provide API to set proxy settings
2758         https://bugs.webkit.org/show_bug.cgi?id=128674
2759
2760         Reviewed by Michael Catanzaro.
2761
2762         Add tests for new proxy settings API.
2763
2764         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2765         (serverCallback):
2766         (ProxyTest::ProxyTest):
2767         (ProxyTest::~ProxyTest):
2768         (ProxyTest::loadURIAndGetMainResourceData):
2769         (ProxyTest::proxyServerPortAsString):
2770         (testWebContextProxySettings):
2771         (beforeAll):
2772
2773 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2774
2775         Add back my old email address so old commits will still match it.
2776
2777         * Scripts/webkitpy/common/config/contributors.json:
2778
2779 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2780
2781         Remove my old email address from contributors.json and watchlist.
2782
2783         * Scripts/validate-committer-lists:
2784         (CommitterListFromGit): Change the mapping to the correct email.
2785         * Scripts/webkitpy/common/config/contributors.json:
2786         * Scripts/webkitpy/common/config/watchlist:
2787
2788 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2789
2790         Unreviewed, rolling out r210848.
2791
2792         This change introduced media-related LayoutTest failures and
2793         crashes on macOS.
2794
2795         Reverted changeset:
2796
2797         "[Modern Media Controls] Turn modern media controls on by
2798         default"
2799         https://bugs.webkit.org/show_bug.cgi?id=165668
2800         http://trac.webkit.org/changeset/210848
2801
2802 2017-01-18  Andreas Kling  <akling@apple.com>
2803
2804         Document::securityOrigin() should return a reference.
2805         <https://webkit.org/b/167124>
2806
2807         Reviewed by Sam Weinig.
2808
2809         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2810         (TestWebKitAPI::TEST_F):
2811
2812 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2813
2814         [Win] Clipboard tests are flaky.
2815         https://bugs.webkit.org/show_bug.cgi?id=167088
2816
2817         Reviewed by Brent Fulgham.
2818
2819         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2820         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2821
2822         * DumpRenderTree/win/DumpRenderTree.cpp:
2823         (main):
2824
2825 2017-01-18  Antoine Quint  <graouts@apple.com>
2826
2827         [Modern Media Controls] Turn modern media controls on by default
2828         https://bugs.webkit.org/show_bug.cgi?id=165668
2829
2830         Reviewed by Dean Jackson.
2831
2832         Enabled modern media controls by default in test runners. 
2833
2834         * DumpRenderTree/TestOptions.h:
2835         * WebKitTestRunner/TestOptions.h:
2836
2837 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2838
2839         Unreviewed, rolling out r210834
2840         https://bugs.webkit.org/show_bug.cgi?id=165668
2841
2842         It introduced dozens of test timeouts.
2843
2844         Reverted changeset:
2845         "[Modern Media Controls] Turn modern media controls on by default"
2846         https://bugs.webkit.org/show_bug.cgi?id=165668
2847         http://trac.webkit.org/changeset/210834
2848
2849 2017-01-17  Antoine Quint  <graouts@apple.com>
2850
2851         [Modern Media Controls] Turn modern media controls on by default
2852         https://bugs.webkit.org/show_bug.cgi?id=165668
2853
2854         Reviewed by Dean Jackson.
2855
2856         Enabled modern media controls by default in test runners. 
2857
2858         * DumpRenderTree/TestOptions.h:
2859         * WebKitTestRunner/TestOptions.h:
2860
2861 2017-01-17  Chris Dumez  <cdumez@apple.com>
2862
2863         Document title changed twice when setting document.title
2864         https://bugs.webkit.org/show_bug.cgi?id=167065
2865
2866         Reviewed by Darin Adler.
2867
2868         Add WebKit2GTK API test that was written by Michael Catanzaro.
2869
2870         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2871         (testWebViewTitleChange):
2872         (beforeAll):
2873
2874 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2875
2876         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2877         https://bugs.webkit.org/show_bug.cgi?id=116551
2878         <rdar://problem/13949830>
2879
2880         Reviewed by Alex Christensen.
2881
2882         * Scripts/webkitperl/FeatureList.pm:
2883         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2884         that is part of the existing WEB_TIMING feature.
2885
2886         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2887
2888 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
2889
2890         'webkit-patch post' no longer works with moved/copied files
2891         https://bugs.webkit.org/show_bug.cgi?id=166914
2892         <rdar://problem/29979707>
2893
2894         Reviewed by Daniel Bates.
2895
2896         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
2897         file outputs only the "Index:" line with an empty body.  This workaround
2898         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
2899         public email list tracking this bug is below.
2900         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
2901         
2902
2903         * Scripts/svn-create-patch:
2904         (generateDiff): Ignore an "Index:" line with an empty body.
2905
2906 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2907
2908         Remove the REQUEST_ANIMATION_FRAME flag
2909         https://bugs.webkit.org/show_bug.cgi?id=156980
2910         <rdar://problem/25906849>
2911
2912         Reviewed by Simon Fraser.
2913
2914         * Scripts/webkitperl/FeatureList.pm:
2915         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2916
2917 2017-01-15  Sam Weinig  <sam@webkit.org>
2918
2919         Add the ability to use numbers in makeString()
2920         https://bugs.webkit.org/show_bug.cgi?id=167087
2921
2922         Reviewed by Darin Adler.
2923
2924         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2925         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
2926         Add tests for StringConcatenate, focusing on new numeric additions.
2927
2928 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2929
2930         Unreviewed, remove stale comment.
2931
2932         This test was fixed by r163173.
2933
2934         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2935
2936 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2937
2938         Annotate large string tests with largeHeap
2939         https://bugs.webkit.org/show_bug.cgi?id=167054
2940
2941         Reviewed by Filip Pizlo.
2942
2943         * Scripts/run-javascriptcore-tests:
2944         * Scripts/run-jsc-stress-tests:
2945
2946 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
2947
2948         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
2949         https://bugs.webkit.org/show_bug.cgi?id=167043
2950
2951         Reviewed by Darin Adler.
2952
2953         * Scripts/webkitperl/FeatureList.pm:
2954
2955 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2956
2957         Remove ENABLE(DETAILS_ELEMENT) guards
2958         https://bugs.webkit.org/show_bug.cgi?id=167042
2959
2960         Reviewed by Alex Christensen.
2961
2962         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2963
2964 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
2965
2966         26 MotionMark performance tests failing
2967         https://bugs.webkit.org/show_bug.cgi?id=166854
2968
2969         Reviewed by Ryosuke Niwa.
2970
2971         Unrelated change. This is the last place that we need to rename Animometer
2972         to MotionMark.
2973
2974         * Scripts/webkitpy/common/config/watchlist:
2975
2976 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2977
2978         run-jsc-benchmarks' echo should have -e option
2979         https://bugs.webkit.org/show_bug.cgi?id=167009
2980
2981         Reviewed by Sam Weinig.
2982
2983         echo requires `-e` option to use escape sequence.
2984         Without it, in some environment (in my Fedora 25), the escape sequence is not
2985         recognized and just dumped as `\c` etc.
2986
2987         * Scripts/run-jsc-benchmarks:
2988
2989 2017-01-12  Chris Dumez  <cdumez@apple.com>
2990
2991         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2992         https://bugs.webkit.org/show_bug.cgi?id=166995
2993
2994         Reviewed by Jer Noble.
2995
2996         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2997         as some people are having trouble building without it.
2998
2999         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3000
3001 2017-01-12  Sam Weinig  <sam@webkit.org>
3002
3003         Add the ability to filter the set of bindings tests you want to run
3004         https://bugs.webkit.org/show_bug.cgi?id=166977
3005
3006         Reviewed by Tim Horton.
3007
3008         Allows doing things like:
3009             run-bindings-tests TestObj* TestCEReactions*
3010         
3011         to run only those tests that match the patterns.
3012
3013         * Scripts/run-bindings-tests:
3014         (main):
3015         Switch to using optparse and pass the remaining args as the filters.
3016
3017         * Scripts/webkitpy/bindings/main.py:
3018         (BindingsTests.__init__):
3019         Store the pattens.
3020
3021         (BindingsTests.test_matches_patterns):
3022         Add helper predicate to determine if a test should be run. When no
3023         patterns are present, all tests should run.
3024
3025         (BindingsTests.run_tests):
3026         Filter tests using the passed in patterns.
3027
3028 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
3029
3030         Followup fix after r210503.
3031         https://bugs.webkit.org/show_bug.cgi?id=166887
3032
3033         Reviewed by Alex Christensen.
3034
3035         After <http://trac.webkit.org/changeset/210503>, test results are written to a
3036         duplicated file handle on Windows. This patch fixes the remaining call sites.
3037
3038         * DumpRenderTree/PixelDumpSupport.cpp:
3039         * DumpRenderTree/TestRunner.cpp:
3040         (TestRunner::waitToDumpWatchdogTimerFired):
3041         * DumpRenderTree/TestRunner.h:
3042         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3043         * DumpRenderTree/win/DumpRenderTree.cpp:
3044         * DumpRenderTree/win/DumpRenderTreeWin.h:
3045         * DumpRenderTree/win/TestRunnerWin.cpp:
3046         (TestRunner::setSpellCheckerLoggingEnabled):
3047
3048 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
3049
3050         Add committer status for Megan
3051         https://bugs.webkit.org/show_bug.cgi?id=166954
3052
3053         Reviewed by Tim Horton.
3054
3055         Add committer status for Megan Gardner
3056
3057         * Scripts/webkitpy/common/config/contributors.json:
3058
3059 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3060
3061         Unreviewed test fix after r210599.
3062
3063         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3064         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
3065
3066 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3067
3068         Unreviewed build fix after r210599.
3069
3070         Add missing files.
3071
3072         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3073         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3074
3075 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3076
3077         File scheme should not allow access of a resource on a different volume.
3078         https://bugs.webkit.org/show_bug.cgi?id=158552
3079         <rdar://problem/15307582>
3080
3081         Reviewed by Alex Christensen.
3082
3083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3084         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3085         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3086
3087 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
3088
3089         Unreviewed, rolling out r210571.
3090
3091         This change broke the 32-bit macOS build and caused LayoutTest
3092         failures.
3093
3094         Reverted changeset:
3095
3096         "File scheme should not allow access of a resource on a
3097         different volume."
3098         https://bugs.webkit.org/show_bug.cgi?id=158552
3099         http://trac.webkit.org/changeset/210571
3100
3101 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3102
3103         [GTK] install-dependencies script misses gdb
3104         https://bugs.webkit.org/show_bug.cgi?id=166917
3105
3106         Reviewed by Michael Catanzaro.
3107
3108         gdb is needed for generating the crash logs.
3109
3110         * gtk/install-dependencies:
3111
3112 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3113
3114         [GTK] No way for applications to set notification permissions without waiting for permission request
3115         https://bugs.webkit.org/show_bug.cgi?id=163366
3116
3117         Reviewed by Carlos Garcia Campos.
3118
3119         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3120         (testWebViewNotification):
3121         (setInitialNotificationPermissionsAllowedCallback):
3122         (setInitialNotificationPermissionsDisallowedCallback):
3123         (testWebViewNotificationInitialPermissionAllowed):
3124         (testWebViewNotificationInitialPermissionDisallowed):
3125         (beforeAll):
3126         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3127         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3128         (WebViewTest::WebViewTest):
3129         (WebViewTest::initializeWebView):
3130         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3131
3132 2017-01-10  Tim Horton  <timothy_horton@apple.com>
3133
3134         MobileMiniBrowser tests don't work by default
3135         https://bugs.webkit.org/show_bug.cgi?id=166910
3136
3137         Reviewed by Alex Christensen.
3138
3139         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
3140         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
3141
3142 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
3143
3144         File scheme should not allow access of a resource on a different volume.
3145         https://bugs.webkit.org/show_bug.cgi?id=158552
3146         <rdar://problem/15307582>
3147
3148         Reviewed by Alex Christensen.
3149
3150         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3151         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3152         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3153
3154 2017-01-10  Mark Lam  <mark.lam@apple.com>
3155
3156         Reverting run-jsc-stress-tests' $buildType to use string values.
3157         https://bugs.webkit.org/show_bug.cgi?id=166912
3158
3159         Rubber stamped by Filip Pizlo.
3160
3161         This is so that we can test for it in the tests e.g.
3162         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
3163
3164         * Scripts/run-jsc-stress-tests:
3165
3166 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3167
3168         Temporarily add back the file removed in r210463 to unbreak internal bots.
3169
3170         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3171
3172 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
3173
3174         svn-apply failed to apply a patch (deleting file with svn property)
3175         https://bugs.webkit.org/show_bug.cgi?id=165953
3176
3177         Reviewed by Daniel Bates.
3178
3179         * Scripts/VCSUtils.pm:
3180         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
3181         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
3182
3183 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3184
3185         Update flakiness dashboard configuration.
3186         https://bugs.webkit.org/show_bug.cgi?id=166869
3187
3188         Reviewed by Alexey Proskuryakov.
3189
3190         * TestResultServer/static-dashboards/builders.jsonp:
3191         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3192
3193 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3194
3195         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
3196         https://bugs.webkit.org/show_bug.cgi?id=165232
3197
3198         Unreviewed follow-up patch after r210539 and r210523.
3199
3200         Instead of using that environment variable, the argument
3201         --display-server=xorg should be passed now.
3202
3203         The GTK+ performance bot was the only bot using this, and is
3204         already passing --display-server=xorg after r210539.
3205
3206         * Scripts/webkitpy/port/gtk.py:
3207         (GtkPort._driver_class):
3208
3209 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3210
3211         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
3212         https://bugs.webkit.org/show_bug.cgi?id=166872
3213
3214         Reviewed by Michael Catanzaro.
3215
3216         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
3217         Define the required "--display-server=driver" in the bot additionalArguments config entry.
3218         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
3219         The step RunWebKitTests already has support for it.
3220
3221         * BuildSlaveSupport/build.webkit.org-config/config.json:
3222         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3223         (RunGtkAPITests.start):
3224         (RunAndUploadPerfTests.start):
3225         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3226
3227 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
3228
3229         Unreviewed, rolling out r210531.
3230
3231         This change broke the 32-bit macOS build and caused LayoutTest
3232         failures.
3233
3234         Reverted changeset:
3235
3236         "File scheme should not allow access of a resource on a
3237         different volume."
3238         https://bugs.webkit.org/show_bug.cgi?id=158552
3239         http://trac.webkit.org/changeset/210531
3240
3241 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
3242
3243         File scheme should not allow access of a resource on a different volume.
3244         https://bugs.webkit.org/show_bug.cgi?id=158552
3245         <rdar://problem/15307582>
3246
3247         Reviewed by Alex Christensen.
3248
3249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3250         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3251         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3252
3253 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3254
3255         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
3256         https://bugs.webkit.org/show_bug.cgi?id=165232
3257
3258         Reviewed by Michael Catanzaro.
3259
3260         Add a new WaylandDriver to run the tests in the user current wayland session.
3261
3262         Also merge all the configuration options for selecting the display server inside one
3263         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
3264
3265         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
3266
3267         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
3268         (TestRunner._create_driver):
3269         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3270         (parse_args):
3271         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3272         (PerfTestsRunner._parse_args):
3273         * Scripts/webkitpy/port/gtk.py:
3274         (GtkPort.__init__):
3275         (GtkPort._driver_class):
3276         (GtkPort._search_paths):
3277         * Scripts/webkitpy/port/waylanddriver.py: Added.
3278         (WaylandDriver):
3279         (WaylandDriver.check_driver):
3280         (WaylandDriver._setup_environ_for_test):
3281         (WaylandDriver._start):
3282
3283 2017-01-09  Andy Estes  <aestes@apple.com>
3284
3285         [QuickLook] Add a layout test for webkit.org/b/135651
3286         https://bugs.webkit.org/show_bug.cgi?id=166855
3287
3288         Reviewed by Andreas Kling.
3289
3290         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3291         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
3292         errors with code WebKitErrorCannotShowURL.
3293         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3294         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
3295         not specific to WebKit2 error codes.
3296
3297 2017-01-09  Antoine Quint  <graouts@apple.com>
3298
3299         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
3300         https://bugs.webkit.org/show_bug.cgi?id=166837
3301
3302         Reviewed by Alex Christensen.
3303
3304         We now correctly handle the --absolutePath argument in DumpRenderTree and use
3305         the provided value when trying to determine the path to the test file. Failing
3306         that, we use the computed URL or the raw path provided to cover all cases.
3307         
3308         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
3309         by applying this patch and seeing the number test failures dramatically reduced
3310         with WK1 due to the option to turn modern media controls off for older media controls
3311         tests.
3312
3313         * DumpRenderTree/DumpRenderTree.h:
3314         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3315         (parseInputLine):
3316         * DumpRenderTree/TestOptions.h:
3317         * DumpRenderTree/TestOptions.mm:
3318         (TestOptions::TestOptions):
3319         * DumpRenderTree/mac/DumpRenderTree.mm:
3320         (runTest):
3321
3322 2017-01-09  Milan Crha  <mcrha@redhat.com>
3323
3324         prepare-ChangeLog: Correct help string for --style option
3325         https://bugs.webkit.org/show_bug.cgi?id=166725
3326
3327         Reviewed by Alexey Proskuryakov.
3328
3329         * Scripts/prepare-ChangeLog:
3330         (main):
3331
3332 2017-01-09  Lucas Forschler  <lforschler@apple.com>
3333
3334         https://bugs.webkit.org/show_bug.cgi?id=166839
3335         Add php7 support for macOS.
3336         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
3337
3338         Reviewed by Alexey Proskuryakov.
3339
3340         * Scripts/webkitpy/port/base.py:
3341         (Port._is_darwin_php_version_7):
3342         (Port._debian_php_version):
3343         (Port):
3344         (Port._darwin_php_version):
3345         (Port._apache_config_file_name_for_platform):
3346
3347 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3348
3349         [GTK] Should support key and code properties on keyboard events
3350         https://bugs.webkit.org/show_bug.cgi?id=166759
3351
3352         Reviewed by Carlos Garcia Campos.
3353
3354         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3355         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
3356         on tests.
3357
3358 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
3359
3360         [Win] Some tests are flaky because certain DLLs are writing to stdout.
3361         https://bugs.webkit.org/show_bug.cgi?id=166760
3362
3363         Reviewed by Darin Adler.
3364
3365         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
3366         We can work around that by duplicating and redirecting stdout.
3367
3368         * DumpRenderTree/PixelDumpSupport.cpp:
3369         (dumpWebViewAsPixelsAndCompareWithExpected):
3370         (printPNG):
3371         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3372         (logEventProc):
3373         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3374         (DRTDesktopNotificationPresenter::showDesktopNotification):
3375         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
3376         (DRTDesktopNotificationPresenter::requestNotificationPermission):
3377         * DumpRenderTree/win/DumpRenderTree.cpp:
3378         (dumpFrameScrollPosition):
3379         (dumpHistoryItem):
3380         (dumpBackForwardList):
3381         (dump):
3382         (runTest):
3383         (main):
3384         * DumpRenderTree/win/DumpRenderTreeWin.h:
3385         * DumpRenderTree/win/EditingDelegate.cpp:
3386         (EditingDelegate::shouldBeginEditingInDOMRange):
3387         (EditingDelegate::shouldEndEditingInDOMRange):
3388         (EditingDelegate::shouldInsertNode):
3389         (EditingDelegate::shouldInsertText):
3390         (EditingDelegate::shouldDeleteDOMRange):
3391         (EditingDelegate::shouldChangeSelectedDOMRange):
3392         (EditingDelegate::shouldApplyStyle):
3393         (EditingDelegate::shouldChangeTypingStyle):
3394         (EditingDelegate::doPlatformCommand):
3395         (EditingDelegate::webViewDidBeginEditing):
3396         (EditingDelegate::webViewDidChange):
3397         (EditingDelegate::webViewDidEndEditing):
3398         (EditingDelegate::webViewDidChangeTypingStyle):
3399         (EditingDelegate::webViewDidChangeSelection):
3400         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3401         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3402         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
3403         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
3404         (FrameLoadDelegate::didFailProvisionalLoadWithError):
3405         (FrameLoadDelegate::didCommitLoadForFrame):
3406         (FrameLoadDelegate::didReceiveTitle):
3407         (FrameLoadDelegate::didFinishLoadForFrame):
3408         (FrameLoadDelegate::didFailLoadWithError):
3409         (FrameLoadDelegate::willPerformClientRedirectToURL):
3410         (FrameLoadDelegate::didCancelClientRedirectForFrame):
3411         (FrameLoadDelegate::windowScriptObjectAvailable):
3412         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3413         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
3414         (FrameLoadDelegate::didDisplayInsecureContent):
3415         (FrameLoadDelegate::didRunInsecureContent):
3416         (FrameLoadDelegate::webViewProgressFinishedNotification):
3417         * DumpRenderTree/win/HistoryDelegate.cpp:
3418         (HistoryDelegate::didNavigateWithNavigationData):
3419         (HistoryDelegate::didPerformClientRedirectFromURL):
3420         (HistoryDelegate::didPerformServerRedirectFromURL):
3421         (HistoryDelegate::updateHistoryTitle):
3422         (HistoryDelegate::populateVisitedLinksForWebView):
3423         * DumpRenderTree/win/PolicyDelegate.cpp:
3424         (PolicyDelegate::decidePolicyForNavigationAction):
3425         (PolicyDelegate::unableToImplementPolicyWithError):
3426         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3427         (ResourceLoadDelegate::willSendRequest):
3428         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3429         (ResourceLoadDelegate::didReceiveResponse):
3430         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3431         (ResourceLoadDelegate::didFailLoadingWithError):
3432         * DumpRenderTree/win/TestRunnerWin.cpp:
3433         (TestRunner::addDisallowedURL):
3434         (TestRunner::originsWithApplicationCache):
3435         (TestRunner::setStorageDatabaseIdleInterval):
3436         (TestRunner::closeIdleLocalStorageDatabases):
3437         (TestRunner::copyDecodedHostName):
3438         (TestRunner::copyEncodedHostName):
3439         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3440         (TestRunner::isGeolocationProviderActive):
3441         (TestRunner::pathToLocalResource):
3442         (TestRunner::setMockDeviceOrientation):
3443         (TestRunner::setMockGeolocationPosition):
3444         (TestRunner::setMockGeolocationPositionUnavailableError):
3445         (TestRunner::setSpatialNavigationEnabled):
3446         (TestRunner::setAutomaticLinkDetectionEnabled):
3447         (TestRunner::isCommandEnabled):
3448         (TestRunner::authenticateSession):
3449         (TestRunner::addChromeInputField):
3450         (TestRunner::removeChromeInputField):
3451         (TestRunner::focusWebView):
3452         (TestRunner::grantWebNotificationPermission):
3453         (TestRunner::denyWebNotificationPermission):
3454         (TestRunner::removeAllWebNotificationPermissions):
3455         (TestRunner::simulateWebNotificationClick):
3456         (TestRunner::imageCountInGeneralPasteboard):
3457         * DumpRenderTree/win/UIDelegate.cpp:
3458         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3459         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3460         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3461         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3462         (UIDelegate::webViewAddMessageToConsole):
3463         (UIDelegate::exceededDatabaseQuota):
3464         (UIDelegate::setStatusText):
3465         (UIDelegate::didPressMissingPluginButton):
3466
3467 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3468
3469         Add a setting to create editable MiniBrowser windows by default
3470         https://bugs.webkit.org/show_bug.cgi?id=166806
3471
3472         Reviewed by Beth Dakin.
3473
3474         * MiniBrowser/mac/AppDelegate.m:
3475         (-[BrowserAppDelegate createBrowserWindowController:]):
3476         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3477         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3478         * MiniBrowser/mac/SettingsController.h:
3479         * MiniBrowser/mac/SettingsController.m:
3480         (-[SettingsController _populateMenu]):
3481         (-[SettingsController validateMenuItem:]):
3482         (-[SettingsController toggleCreateEditorByDefault:]):
3483         (-[SettingsController createEditorByDefault]):
3484         Add a setting and update the key equivalents accordingly.
3485         Also make sure to make the right kind of window on launch.
3486
3487 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3488
3489         Fix the 32-bit build.
3490
3491         * MiniBrowser/mac/BrowserWindowController.h:
3492         * MiniBrowser/mac/BrowserWindowController.m:
3493
3494 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3495
3496         Fix the 32-bit build.
3497
3498         * MiniBrowser/mac/BrowserWindowController.m:
3499
3500 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3501
3502         Make it possible to drop HTML files on the MiniBrowser icon
3503         https://bugs.webkit.org/show_bug.cgi?id=166802
3504
3505         Reviewed by Simon Fraser.
3506
3507         * MiniBrowser/mac/AppDelegate.m:
3508         (-[BrowserAppDelegate application:openFile:]):
3509         * MiniBrowser/mac/Info.plist:
3510         If you're using an editable window, the usual trick of dropping on the
3511         window doesn't work anymore (it makes an <attachment> instead).
3512
3513 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3514
3515         MiniBrowser window gets smaller each time it is instantiated
3516         https://bugs.webkit.org/show_bug.cgi?id=166807
3517
3518         Reviewed by Andy Estes.
3519
3520         * MiniBrowser/mac/BrowserWindowController.m:
3521         (-[BrowserWindowController windowDidLoad]):
3522         * MiniBrowser/mac/BrowserWindow.xib:
3523         Turn on full-window content view support with IB, instead of waiting
3524         until after the views have been loaded. This seems to resolve the
3525         longstanding ever-shrinking-window problem.
3526
3527 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3528
3529         Add indent/outdent items to MiniBrowser's new format menu
3530         https://bugs.webkit.org/show_bug.cgi?id=166805
3531
3532         Reviewed by Dan Bernstein.
3533
3534         * MiniBrowser/mac/MainMenu.xib:
3535
3536 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3537
3538         Add a stock Format menu to MiniBrowser
3539         https://bugs.webkit.org/show_bug.cgi?id=166804
3540
3541         Reviewed by Andy Estes.
3542
3543         * MiniBrowser/mac/MainMenu.xib:
3544         Many of the features automatically work with editable web views.
3545         However, this seems to expose a bug where none of the font-related features
3546         (Cmd-B, for example) work until the first time the font panel is shown,
3547         per process, which will need to be investigated separately.
3548
3549 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3550
3551         Remove unused applicationWillTerminate methods from MiniBrowser
3552         https://bugs.webkit.org/show_bug.cgi?id=166803
3553
3554         Reviewed by Andy Estes.
3555
3556         * MiniBrowser/mac/AppDelegate.m:
3557         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
3558         * MiniBrowser/mac/BrowserWindowController.h:
3559         * MiniBrowser/mac/BrowserWindowController.m:
3560         (-[BrowserWindowController applicationTerminating]): Deleted.
3561         * MiniBrowser/mac/WK1BrowserWindowController.m:
3562         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
3563         * MiniBrowser/mac/WK2BrowserWindowController.m:
3564         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
3565
3566 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3567
3568         Add the ability to create empty contentEditable windows in MiniBrowser
3569         https://bugs.webkit.org/show_bug.cgi?id=166801
3570
3571         Reviewed by Wenson Hsieh.
3572
3573         * MiniBrowser/mac/AppDelegate.h:
3574         * MiniBrowser/mac/AppDelegate.m:
3575         (-[BrowserAppDelegate createBrowserWindowController:]):
3576         (-[BrowserAppDelegate newWindow:]):
3577         (-[BrowserAppDelegate newEditorWindow:]):
3578         (-[BrowserAppDelegate openDocument:]):
3579         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3580         * MiniBrowser/mac/BrowserWindowController.h:
3581         * MiniBrowser/mac/BrowserWindowController.m:
3582         (-[BrowserWindowController loadHTMLString:]):
3583         (-[BrowserWindowController toggleEditable:]):
3584         * MiniBrowser/mac/MainMenu.xib:
3585         * MiniBrowser/mac/WK1BrowserWindowController.m:
3586         (-[WK1BrowserWindowController awakeFromNib]):
3587         (-[WK1BrowserWindowController loadHTMLString:]):
3588         (-[WK1BrowserWindowController validateMenuItem:]):
3589         (-[WK1BrowserWindowController setEditable:]):
3590         (-[WK1BrowserWindowController updateTitle:]):
3591         * MiniBrowser/mac/WK2BrowserWindowController.m:
3592         (-[WK2BrowserWindowController awakeFromNib]):
3593         (-[WK2BrowserWindowController validateMenuItem:]):
3594         (-[WK2BrowserWindowController setEditable:]):
3595         (-[WK2BrowserWindowController updateTitle:]):
3596         (-[WK2BrowserWindowController loadHTMLString:]):
3597         Merge more functionality from WebEditingTester.
3598         Add two menu items for creating empty editable WebKit1/2 windows.
3599         Add a menu item to the Edit menu to toggle editability on any window.
3600
3601 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3602
3603         Implement find-in-page in MiniBrowser
3604         https://bugs.webkit.org/show_bug.cgi?id=166799
3605
3606         Reviewed by Andy Estes.
3607
3608         * MiniBrowser/mac/BrowserWindow.xib:
3609         * MiniBrowser/mac/BrowserWindowController.h:
3610         * MiniBrowser/mac/BrowserWindowController.m:
3611         (-[BrowserWindowController find:]): Deleted.
3612         * MiniBrowser/mac/MainMenu.xib:
3613         * MiniBrowser/mac/WK1BrowserWindowController.m:
3614         (-[WK1BrowserWindowController toggleShrinkToFit:]):
3615         (-[WK1BrowserWindowController find:]): Deleted.
3616         * MiniBrowser/mac/WK2BrowserWindowController.m:
3617         (-[WK2BrowserWindowController awakeFromNib]):
3618         (-[WK2BrowserWindowController dealloc]):
3619         (-[WK2BrowserWindowController validateMenuItem:]):
3620         (-[WK2BrowserWindowController performTextFinderAction:]):
3621         (-[WK2BrowserWindowController findBarView]):
3622         (-[WK2BrowserWindowController setFindBarView:]):
3623         (-[WK2BrowserWindowController isFindBarVisible]):
3624         (-[WK2BrowserWindowController setFindBarVisible:]):
3625         (-[WK2BrowserWindowController contentView]):
3626         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
3627         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
3628         (-[WK2BrowserWindowController find:]): Deleted.
3629         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
3630         protocol. At first glance, it's pretty broken, but vaguely works.
3631
3632 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3633
3634         Share the implementation of MiniBrowser view hiding functionality
3635         https://bugs.webkit.org/show_bug.cgi?id=166800
3636
3637         Reviewed by Andy Estes.
3638
3639         * MiniBrowser/mac/BrowserWindowController.m:
3640         (-[BrowserWindowController showHideWebView:]):
3641         (-[BrowserWindowController removeReinsertWebView:]):
3642         * MiniBrowser/mac/WK1BrowserWindowController.m:
3643         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
3644         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
3645         * MiniBrowser/mac/WK2BrowserWindowController.m:
3646         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
3647         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
3648         Move the implementation of these two things to the shared superclass,
3649         since they don't depend on WebKit-specific things.
3650         Also, there was no reason to retain the (WK)WebView while it was unparented,
3651         as the BrowserWindowController maintains a reference the entire time.
3652
3653 2017-01-06  Andy Estes  <aestes@apple.com>
3654
3655         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
3656         https://bugs.webkit.org/show_bug.cgi?id=166789
3657
3658         Reviewed by Alex Christensen.
3659
3660         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3661         * DumpRenderTree/PlatformMac.cmake:
3662         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
3663         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
3664         * DumpRenderTree/mac/DumpRenderTree.mm:
3665         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3666         createXMLStringFromWebArchiveData().
3667         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
3668         * WebKitTestRunner/Configurations/Base.xcconfig:
3669         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
3670         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3671         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3672         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3673         createXMLStringFromWebArchiveData().
3674         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
3675         * WebKitTestRunner/PlatformMac.cmake:
3676         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3677         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
3678
3679 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3680
3681         Minor cleanups to IndentOutdentCommand and related code
3682         https://bugs.webkit.org/show_bug.cgi?id=166791
3683
3684         Reviewed by Simon Fraser.
3685
3686         * WebEditingTester/EditingOperations.m:
3687         (editingOperations):
3688         Add the outdent operation to WebEditingTester.
3689
3690 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3691
3692         Create a plan and a patch files for MotionMark and delete the Animometer's ones
3693         https://bugs.webkit.org/show_bug.cgi?id=166785
3694
3695         Reviewed by Ryosuke Niwa.
3696
3697         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3698         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
3699
3700 2017-01-06  Antoine Quint  <graouts@apple.com>
3701
3702         Support webkit-test-runner key-value pairs in http tests
3703         https://bugs.webkit.org/show_bug.cgi?id=149812
3704
3705         Reviewed by Alex Christensen.
3706
3707         We pass the absolute path for a test through to WKTR so that we can parse
3708         tests that are running as URLs for webkit-test-runner options.
3709
3710         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3711         (parseInputLine):
3712
3713         Explicitly skip the --absolute-path option in DRT or else we'd crash.
3714
3715         * Scripts/webkitpy/port/driver.py:
3716         (Driver._command_from_driver_input):
3717
3718         Pass the absolute path to the file through the CLI.
3719
3720         * WebKitTestRunner/TestController.cpp:
3721         (WTR::updateTestOptionsFromTestHeader):
3722         (WTR::TestController::testOptionsForTest):
3723         (WTR::parseInputLine):
3724         (WTR::TestController::runTest):
3725         * WebKitTestRunner/TestController.h:
3726
3727 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3728
3729         Warning about unconnectable outlets when opening a MiniBrowser window
3730         https://bugs.webkit.org/show_bug.cgi?id=166756
3731
3732         Reviewed by Dan Bernstein.
3733
3734         * MiniBrowser/mac/BrowserWindow.xib:
3735         When launching MiniBrowser, it says:
3736         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
3737             (MBToolbarItem): missing setter or instance variable
3738         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
3739             (NSButtonCell): missing setter or instance variable.
3740
3741         It looks like someone added the connection from the share button
3742         to the BrowserWindowController three times; only one of the connections
3743         is valid. Remove the other two.
3744
3745 2017-01-05  Keith Rollin  <krollin@apple.com>
3746
3747         Add WebCore::URL::protocolHostAndPort
3748         https://bugs.webkit.org/show_bug.cgi?id=166426
3749
3750         Reviewed by Alex Christensen.
3751
3752         Add test for protocolHostAndPort.
3753
3754         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3755         (TestWebKitAPI::TEST_F):
3756
3757 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
3758
3759         [Win] Archive test result is failing.
3760         https://bugs.webkit.org/show_bug.cgi?id=166720
3761
3762         Reviewed by Alex Christensen.
3763
3764         Deleting the layout test result folder is sometimes failing
3765         on Windows. This is not a critical error.
3766
3767         * BuildSlaveSupport/test-result-archive:
3768         (archiveTestResults):
3769
3770 2017-01-04  Tomas Popela  <tpopela@redhat.com>
3771
3772         [GTK] Minibrowser: Add printing support
3773         https://bugs.webkit.org/show_bug.cgi?id=165298
3774
3775         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
3776         an error during the print, it's printed on the console.
3777
3778         Reviewed by Michael Catanzaro.
3779
3780         * MiniBrowser/gtk/BrowserWindow.c:
3781         (webKitPrintOperationFailedCallback):
3782         (printPage):
3783         (browser_window_init):
3784
3785 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
3786
3787         [css-grid] Fix crash clamping grid lines
3788         https://bugs.webkit.org/show_bug.cgi?id=166637
3789
3790         Reviewed by Darin Adler.
3791
3792         Creates new unit test to verify that the maximum tracks limit
3793         is used in GridPosition too.
3794
3795         * TestWebKitAPI/PlatformEfl.cmake:
3796         * TestWebKitAPI/PlatformGTK.cmake:
3797         * TestWebKitAPI/PlatformWin.cmake:
3798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3799         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
3800         (TestWebKitAPI::TEST):
3801
3802 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3803
3804         Move editing history scripts to WebCore PrivateHeaders
3805         https://bugs.webkit.org/show_bug.cgi?id=166709
3806         <rdar://problem/29876612>
3807
3808         Reviewed by Dan Bernstein.
3809
3810         Update references to editing script files in WebCore that were moved.
3811
3812         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
3813
3814 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3815
3816         Unreviewed, build fix after r210313 part 2
3817         https://bugs.webkit.org/show_bug.cgi?id=166676
3818
3819         Add 'U' suffix.
3820
3821         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3822         (TestWebKitAPI::TEST):
3823         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3824         (TestWebKitAPI::TEST):
3825
3826 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3827
3828         Limit thread name appropriately
3829         https://bugs.webkit.org/show_bug.cgi?id=166676
3830
3831         Reviewed by Sam Weinig.
3832
3833         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3834         (TestWebKitAPI::TEST):
3835         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3836         (TestWebKitAPI::TEST):
3837
3838 2017-01-04  Andy Estes  <aestes@apple.com>
3839
3840         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
3841         https://bugs.webkit.org/show_bug.cgi?id=166696
3842
3843         Reviewed by Tim Horton.
3844
3845         * TestWebKitAPI/PlatformGTK.cmake:
3846         * TestWebKitAPI/PlatformWin.cmake:
3847         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3848         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
3849         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
3850         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
3851         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
3852         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
3853         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
3854
3855 2017-01-03  Brian Burg  <bburg@apple.com>
3856
3857         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
3858         https://bugs.webkit.org/show_bug.cgi?id=166003
3859         <rdar://problem/28718990>
3860
3861         Reviewed by Joseph Pecoraro.
3862
3863         Teach run-inspector-generator-tests to generate test output using the platform name
3864         derived from the directory that the test is in. For example, tests in the /generic/
3865         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
3866
3867         * Scripts/webkitpy/inspector/main.py:
3868         (InspectorGeneratorTests.generate_from_json):
3869         (InspectorGeneratorTests.run_tests):
3870         (InspectorGeneratorTests.main):
3871
3872 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3873
3874         Unreviewed cmake buildfix after r210266.
3875
3876         * DumpRenderTree/PlatformMac.cmake:
3877
3878 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3879
3880         Provide a setting for clients to always prefer low-power WebGL
3881         https://bugs.webkit.org/show_bug.cgi?id=166675
3882         <rdar://problem/29834093>
3883
3884         Reviewed by Dan Bernstein.
3885
3886         * MiniBrowser/mac/Info.plist:
3887         Have MiniBrowser claim to be a modern app that supports
3888         automatic graphics switching. WebKit needs to support automatic
3889         graphics switching, so our test app might as well. Without this
3890         Info.plist parameter, this change has no effect, and bringing up
3891         a WebGL context still brings up the discrete GPU (also true of the
3892         existing web-exposed preferLowPowerToHighPerformance API).
3893
3894 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3895
3896         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
3897         https://bugs.webkit.org/show_bug.cgi?id=166645
3898
3899         Reviewed by Carlos Garcia Campos.
3900
3901         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3902         (TestWebKitAPI::TEST):
3903
3904 2017-01-03  Andy Estes  <aestes@apple.com>
3905
3906         Place all the Cocoa WebCore API tests in the same directory
3907         https://bugs.webkit.org/show_bug.cgi?id=166673
3908
3909         Reviewed by Michael Catanzaro.
3910
3911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3912         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
3913         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
3914         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
3915
3916 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3917
3918         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3919         https://bugs.webkit.org/show_bug.cgi?id=166450
3920         <rdar://problem/29447824>
3921
3922         Reviewed by Darin Adler.
3923
3924         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3925         * DumpRenderTree/TestRunner.cpp:
3926         (TestRunner::staticFunctions):
3927         * DumpRenderTree/mac/TestRunnerMac.mm:
3928         (setSpellCheckerLoggingEnabledCallback):
3929         * DumpRenderTree/win/TestRunnerWin.cpp:
3930         (setSpellCheckerLoggingEnabledCallback):
3931         * DumpRenderTree/mac/DumpRenderTree.mm:
3932         (resetWebViewToConsistentStateBeforeTesting):
3933         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
3934         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
3935         (stringForCorrectionResponse):
3936         (drt_NSSpellChecker_recordResponseToCorrection):
3937         (swizzleNSSpellCheckerMethodsIfNeeded):
3938         (setSpellCheckerLoggingEnabled):
3939         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
3940         set to true, logs to stdout (which ends up in the test result) whenever
3941         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3942         is called, and then calls the original method. It is reset to false between tests.
3943
3944 2017-01-03  Sam Weinig  <sam@webkit.org>
3945
3946         Make WTF::Expected support Ref template parameters
3947         https://bugs.webkit.org/show_bug.cgi?id=166662
3948
3949         Reviewed by Alex Christensen.
3950
3951         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3952         (TestWebKitAPI::TEST):
3953         Add tests for using Ref with Expected.
3954
3955 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3956
3957         [GTK] Expose WebKitSecurityOrigin API
3958         https://bugs.webkit.org/show_bug.cgi?id=166632
3959
3960         Reviewed by Carlos Garcia Campos.
3961
3962         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3963         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
3964         (testSecurityOriginBasicConstructor):
3965         (testSecurityOriginURIConstructor):
3966         (testSecurityOriginDefaultPort):
3967         (testSecurityOriginFileURI):
3968         (testSecurityOriginDataURI):
3969         (beforeAll):
3970         (afterAll):
3971
3972 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3973
3974         [GTK] HTTP auth layout tests are flaky
3975         https://bugs.webkit.org/show_bug.cgi?id=158919
3976
3977         Reviewed by Michael Catanzaro.
3978
3979         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
3980         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
3981         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
3982         missing valac in the bots.
3983
3984 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3985
3986         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
3987         https://bugs.webkit.org/show_bug.cgi?id=165797
3988
3989         Reviewed by Michael Catanzaro.
3990
3991         Move directory ruleset after all exclude rules of Source rulset.
3992
3993         * gtk/manifest.txt.in:
3994
3995 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3996
3997         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
3998         https://bugs.webkit.org/show_bug.cgi?id=166636
3999
4000         Reviewed by Darin Adler.
4001
4002         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4003         (TestWebKitAPI::TEST):
4004
4005 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
4006
4007         [GTK] WebCore/CSSParser unit test is not being built
4008         https://bugs.webkit.org/show_bug.cgi?id=166492
4009
4010         Reviewed by Michael Catanzaro.
4011
4012         This test was introduced in r175930, but we were not building
4013         it on GTK+ port since r176015.
4014         This patch marks the test to be built again on GTK+.
4015         JFTR, the test is passing right now.
4016
4017         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
4018         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
4019
4020 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
4021
4022         AX: Expose block quote level to iOS API
4023         https://bugs.webkit.org/show_bug.cgi?id=166629
4024         <rdar://problem/29834793>
4025
4026         Reviewed by Darin Adler.
4027
4028         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
4029         (AccessibilityUIElement::numberAttributeValue):
4030         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4031         (WTR::AccessibilityUIElement::numberAttributeValue):
4032
4033 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
4034
4035         SecurityOrigin::create triplet constructor does not canonicalize port
4036         https://bugs.webkit.org/show_bug.cgi?id=166624
4037
4038         Reviewed by Daniel Bates.
4039
4040         * TestWebKitAPI/PlatformGTK.cmake:
4041         * TestWebKitAPI/PlatformWin.cmake:
4042         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4043         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
4044         (TestWebKitAPI::SecurityOriginTest::SetUp):
4045         (TestWebKitAPI::TEST_F):
4046
4047 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
4048
4049         [GTK] Improve user agent construction
4050         https://bugs.webkit.org/show_bug.cgi?id=142074
4051
4052         Reviewed by Carlos Garcia Campos.
4053
4054         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4055         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
4056         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
4057         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
4058         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
4059         (TestWebKitAPI::TEST):
4060
4061 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
4062
4063         [GTK] Improve user agent construction
4064         https://bugs.webkit.org/show_bug.cgi?id=142074
4065
4066         Reviewed by Carlos Garcia Campos.
4067
4068         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4069         (TestWebKitAPI::TEST):
4070
4071 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
4072
4073         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
4074         https://bugs.webkit.org/show_bug.cgi?id=166472
4075         rdar://problem/29675551
4076
4077         Reviewed by Tim Horton.
4078
4079         These changes are necessary to allow the mouse to leave the WTR window while
4080         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
4081         (which DRT does); we'd always go through mouseMoved, which hits an early return
4082         in WebViewImpl::mouseMoved() when the point is outside the view.
4083
4084         * WebKitTestRunner/mac/EventSenderProxy.mm:
4085         (WTR::EventSenderProxy::mouseMoveTo):
4086
4087 2016-12-23  Andy Estes  <aestes@apple.com>
4088
4089         [iOS] Fix some crashing webarchive tests
4090         https://bugs.webkit.org/show_bug.cgi?id=166470
4091
4092         Reviewed by Andreas Kling.
4093
4094         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
4095         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
4096         so this change uses that on both platforms.
4097
4098         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
4099         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
4100         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
4101         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
4102         * WebKitTestRunner/PlatformMac.cmake:
4103         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4104         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
4105
4106 2016-12-22  Saam Barati  <sbarati@apple.com>
4107
4108         WebAssembly: Silence the output of the spec-tests
4109         https://bugs.webkit.org/show_bug.cgi?id=166417
4110
4111         Reviewed by Mark Lam.
4112
4113         * Scripts/run-jsc-stress-tests:
4114
4115 2016-12-22  Zhuo Li  <zachli@apple.com>
4116
4117         [Cocoa] SPI for setloadsImagesAutomatically.
4118         https://bugs.webkit.org/show_bug.cgi?id=166401.
4119
4120         Reviewed by Darin Adler.
4121
4122         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
4123         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
4124         _loadsImagesAutomatically returns YES.
4125
4126 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4127
4128         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
4129         https://bugs.webkit.org/show_bug.cgi?id=161328
4130         <rdar://problem/28475977>
4131
4132         Reviewed by Darin Adler.
4133
4134         Running a test that scales the viewport and listens to a didEndZooming callback (such as
4135         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
4136         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
4137         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
4138         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
4139         load, should prevent this from happening, but from reading documentation and code inspection, this is not
4140         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
4141         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
4142         we finish running a test and before we load the next test.
4143
4144         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
4145         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
4146         previous test started zooming and then finished before zooming completed. Since this happens before the next
4147         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
4148
4149         * WebKitTestRunner/ios/TestControllerIOS.mm:
4150         (WTR::TestController::platformResetStateToConsistentValues):
4151
4152 2016-12-22  Jer Noble  <jer.noble@apple.com>
4153
4154         Muted media element playback should not interrupt other audio playback
4155         https://bugs.webkit.org/show_bug.cgi?id=166347
4156
4157         Reviewed by Eric Carlson.
4158
4159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4160         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
4161         (TestWebKitAPI::TEST):
4162         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
4163
4164 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
4165
4166         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
4167         https://bugs.webkit.org/show_bug.cgi?id=166346
4168
4169         Reviewed by Carlos Garcia Campos.
4170
4171         Enable WebRTC by default to simplify testing.
4172
4173         * MiniBrowser/gtk/main.c:
4174         (main):
4175
4176 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
4177
4178         REGRESSION: API test failure: WKWebView.LocalStorageClear
4179         https://bugs.webkit.org/show_bug.cgi?id=166032
4180         <rdar://problem/29758423>
4181
4182         Reviewed by Simon Fraser.
4183
4184         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
4185         to ensure that the view is destroyed before the callback fires.
4186
4187         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
4188         (TEST):
4189
4190 2016-12-21  Saam Barati  <sbarati@apple.com>
4191
4192         WebAssembly: Import spec tests
4193         https://bugs.webkit.org/show_bug.cgi?id=166395
4194
4195         Rubber stamped by Keith Miller.
4196
4197         * Scripts/run-jsc-stress-tests:
4198
4199 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
4200
4201         REGRESSION: API test failure: _WKDownload.OriginatingWebView
4202         https://bugs.webkit.org/show_bug.cgi?id=166033
4203         <rdar://problem/29758428>
4204
4205         Reviewed by Simon Fraser.
4206
4207         Add an @autoreleasepool around the code that allocates the WKWebView, 
4208         so that it can be destroyed by removing the last reference in _downloadDidStart.
4209
4210         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
4211         (TEST):
4212
4213 2016-12-21  Daniel Bates  <dabates@apple.com>
4214
4215         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
4216         https://bugs.webkit.org/show_bug.cgi?id=166356
4217
4218         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
4219         as a means to allow a test to explicit allow an embedding client to open a new windows
4220         such that the default behavior is for the embedding client to forbid such an action.
4221         The test plugins/get-url-with-blank-target.html assumes this default behavior though
4222         it is currently skipped on WebKit2 because questions were raised in the patch for
4223         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
4224         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
4225         this test.
4226
4227         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4228         (WTR::TestRunner::setCanOpenWindows):
4229
4230 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
4231
4232         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
4233         https://bugs.webkit.org/show_bug.cgi?id=166031
4234
4235         Reviewed by Tim Horton.
4236         
4237         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
4238         to ensure that the view is destroyed before the callback fires.
4239
4240         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
4241
4242 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
4243
4244         Throw Exception when test doesn't clean up HID Events properly
4245         https://bugs.webkit.org/show_bug.cgi?id=166271
4246
4247         Reviewed by Simon Fraser.
4248
4249         Add in a check when UIScriptController is deleted to make sure that the HID event
4250         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
4251         the program to crash without any good information. Crashes are race-y, and will still
4252         happen with malformed test, but the information will be much more helpful. 
4253
4254         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4255         (WTR::UIScriptController::checkForClean):
4256         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
4257         (UIScriptContext::~UIScriptContext):
4258         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4259         (WTR::UIScriptController::checkForClean):
4260         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4261         * WebKitTestRunner/ios/HIDEventGenerator.h:
4262         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4263         (-[HIDEventGenerator checkHIDCallbacksClear]):
4264         * WebKitTestRunner/ios/TestControllerIOS.mm:
4265         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4266         (WTR::UIScriptController::checkForClean):
4267
4268 2016-12-20  Andy Estes  <aestes@apple.com>
4269
4270         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
4271         https://bugs.webkit.org/show_bug.cgi?id=165992
4272
4273         Reviewed by Brady Eidson.
4274
4275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4276         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
4277         (expectException):
4278         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4279         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4280         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4281         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
4282         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
4283         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
4284         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
4285         (TEST):
4286         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
4287
4288 2016-12-20  Dean Jackson  <dino@apple.com>
4289
4290         Remove INDIE_UI
4291         https://bugs.webkit.org/show_bug.cgi?id=165881
4292         <rdar://problem/29672532>
4293
4294         Reviewed by Simon Fraser.
4295
4296         The Indie UI work has been discontinued.
4297
4298         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4299
4300 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
4301
4302         [ES6] Enable ES6 Modules
4303         https://bugs.webkit.org/show_bug.cgi?id=165849
4304
4305         Reviewed by Geoffrey Garen.
4306
4307         * DumpRenderTree/mac/DumpRenderTree.mm:
4308         (resetWebPreferencesToConsistentValues):
4309         * DumpRenderTree/win/DumpRenderTree.cpp:
4310         (resetWebPreferencesToConsistentValues):
4311         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4312         (WTR::InjectedBundle::beginTesting):
4313         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4314         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
4315         * WebKitTestRunner/InjectedBundle/TestRunner.h: