[CMake][WinCairo] Separate copied headers into different directories
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2
3         [CMake][WinCairo] Separate copied headers into different directories
4         https://bugs.webkit.org/show_bug.cgi?id=196655
5
6         Reviewed by Michael Catanzaro.
7
8         * DumpRenderTree/CMakeLists.txt:
9         * MiniBrowser/win/CMakeLists.txt:
10         * TestWebKitAPI/CMakeLists.txt:
11         * TestWebKitAPI/PlatformWin.cmake:
12
13 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
14
15         Log stack-trace for run-webkit-tests when interrupted
16         https://bugs.webkit.org/show_bug.cgi?id=176393
17         <rdar://problem/34262310>
18
19         Reviewed by Lucas Forschler.
20
21         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
22         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
23         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
24         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
25         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
26         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
27         (main): Set handlers to log stack trace on interruption.
28
29 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
30
31         AX: Support API: accessibilityReplaceRange:withText
32         https://bugs.webkit.org/show_bug.cgi?id=196636
33
34         Unreviewed build fix for Windows port.
35
36         * DumpRenderTree/AccessibilityUIElement.cpp:
37         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
38
39 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
40
41         [ews-build] Scripts using Buildbot API have CORS error
42         https://bugs.webkit.org/show_bug.cgi?id=196709
43
44         Reviewed by Alexey Proskuryakov.
45
46         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
47
48 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
49
50         AX: Support API: accessibilityReplaceRange:withText
51         https://bugs.webkit.org/show_bug.cgi?id=196636
52
53         Reviewed by Daniel Bates.
54
55         * DumpRenderTree/AccessibilityUIElement.cpp:
56         (replaceTextInRangeCallback):
57         (AccessibilityUIElement::replaceTextInRange):
58         (AccessibilityUIElement::getJSClass):
59         * DumpRenderTree/AccessibilityUIElement.h:
60         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
61         (AccessibilityUIElement::replaceTextInRange):
62         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
63         (AccessibilityUIElement::replaceTextInRange):
64         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
65         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
66         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
67         (WTR::AccessibilityUIElement::replaceTextInRange):
68         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
69         (WTR::AccessibilityUIElement::replaceTextInRange):
70
71 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
72
73         [iOS] Do not allow starting selection drags when selection views are not visible
74         https://bugs.webkit.org/show_bug.cgi?id=196686
75         <rdar://problem/49399192>
76
77         Reviewed by Tim Horton.
78
79         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
80         also add some new API tests to cover scenarios where the web view is not first responder.
81
82         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
83         (TestWebKitAPI::TEST):
84         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
85
86         Add a switch to optionally make the web view first responder when starting the simulated drag.
87
88         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
89         (-[DragAndDropSimulator initWithWebView:]):
90         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
91
92 2019-04-08  Justin Fan  <justin_fan@apple.com>
93
94         [Web GPU] Fix Web GPU experimental feature on iOS
95         https://bugs.webkit.org/show_bug.cgi?id=196632
96
97         Reviewed by Myles C. Maxfield.
98
99         Properly make Web GPU available on iOS 11+.
100
101         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
102
103 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
104
105         [ews-build] Do not upload archive when Compile Fails
106         https://bugs.webkit.org/show_bug.cgi?id=196674
107
108         Reviewed by Alexey Proskuryakov.
109
110         * BuildSlaveSupport/ews-build/factories.py:
111         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
112         * BuildSlaveSupport/ews-build/steps.py:
113         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
114         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
115         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
116
117 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
118
119         Enable DFG on MIPS
120         https://bugs.webkit.org/show_bug.cgi?id=196689
121
122         Reviewed by Žan Doberšek.
123
124         Since the bytecode change, we enabled the baseline JIT on mips in
125         r240432, but DFG is still missing. With this change, all tests are
126         passing on a ci20 board.
127
128         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
129
130 2019-04-08  Philippe Normand  <pnormand@igalia.com>
131
132         [Flatpak] Second run update-webkitwpe-flatpak fails
133         https://bugs.webkit.org/show_bug.cgi?id=192702
134
135         Reviewed by Carlos Garcia Campos.
136
137         * flatpak/flatpakutils.py:
138         (FlatpakObject.flatpak): Fix typo.
139         (FlatpakPackage.install): When installing, also update to the configured remote commit.
140         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
141
142 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
143
144         [GTK][WPE] outlook.live.com displays old-fashioned UI
145         https://bugs.webkit.org/show_bug.cgi?id=196642
146
147         Reviewed by Carlos Garcia Campos.
148
149         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
150         (TestWebKitAPI::TEST): New Mac platform quirk test.
151
152 2019-04-07  Commit Queue  <commit-queue@webkit.org>
153
154         Unreviewed, rolling out r243956.
155         https://bugs.webkit.org/show_bug.cgi?id=196688
156
157         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
158         by aakashjain on #webkit).
159
160         Reverted changeset:
161
162         "Clicking "Go Back" from a safe browsing warning from an
163         iframe should navigate the WKWebView back to the previous
164         page"
165         https://bugs.webkit.org/show_bug.cgi?id=196665
166         https://trac.webkit.org/changeset/243956
167
168 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
169
170         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
171         https://bugs.webkit.org/show_bug.cgi?id=196669
172
173         Reviewed by Geoffrey Garen.
174
175         Added three new unit tests for WeakHashSet.
176
177         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
178         (WTF_WeakPtr.WeakHashSetConstObjects):
179         (WTF_WeakPtr.WeakHashSetComputesEmpty):
180         (WTF_WeakPtr.WeakHashSetComputeSize):
181
182 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
183
184         Hide next and previous form control buttons when WKWebView is editable
185         https://bugs.webkit.org/show_bug.cgi?id=196672
186         <rdar://problem/35625321>
187
188         Reviewed by Tim Horton.
189
190         Add a new API test.
191
192         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
193         (-[TestWKWebView lastTrailingBarButtonGroup]):
194         (TestWebKitAPI::TEST):
195         * TestWebKitAPI/ios/UIKitSPI.h:
196
197 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
198
199         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
200         https://bugs.webkit.org/show_bug.cgi?id=196077
201         <rdar://problem/49108202>
202
203         Reviewed by Chris Dumez.
204
205         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
206         on new web view.
207
208         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
209
210 2019-04-05  Saam Barati  <sbarati@apple.com>
211
212         Make compare-results understand MotionMark
213         https://bugs.webkit.org/show_bug.cgi?id=196666
214
215         Reviewed by Yusuke Suzuki.
216
217         * Scripts/compare-results:
218         (PLT5Results):
219         (detectMotionMark):
220         (detectMotionMark1_1):
221         (motionMarkResults):
222         (motionMark1_1Results):
223         (detectBenchmark):
224         (biggerIsBetter):
225         (main):
226
227 2019-04-05  Alex Christensen  <achristensen@webkit.org>
228
229         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
230         https://bugs.webkit.org/show_bug.cgi?id=196665
231         <rdar://45115669>
232
233         Reviewed by Geoff Garen.
234
235         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
236         (goBack):
237         (+[SimpleLookupContext sharedLookupContext]):
238         (-[SimpleLookupContext lookUpURL:completionHandler:]):
239         (TEST):
240         (+[Simple3LookupContext sharedLookupContext]): Deleted.
241         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
242
243 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
244
245         [ews-build] Add configuration and architecture for windows builders
246         https://bugs.webkit.org/show_bug.cgi?id=196660
247
248         Reviewed by Lucas Forschler.
249
250         * BuildSlaveSupport/ews-build/config.json:
251
252 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
253
254         webkitpy: Don't run subsequent rounds if interrupted
255         https://bugs.webkit.org/show_bug.cgi?id=196646
256
257         Reviewed by Aakash Jain.
258
259         * Scripts/webkitpy/layout_tests/controllers/manager.py:
260         (Manager.run): Bail out if interrupted.
261
262 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
263
264         Test sessionStorage in PSON private browsing mode
265         https://bugs.webkit.org/show_bug.cgi?id=196561
266
267         Reviewed by Alex Christensen.
268
269         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
270
271 2019-04-05  Commit Queue  <commit-queue@webkit.org>
272
273         Unreviewed, rolling out r243833.
274         https://bugs.webkit.org/show_bug.cgi?id=196645
275
276         This change breaks build of WPE and GTK ports (Requested by
277         annulen on #webkit).
278
279         Reverted changeset:
280
281         "[CMake][WTF] Mirror XCode header directories"
282         https://bugs.webkit.org/show_bug.cgi?id=191662
283         https://trac.webkit.org/changeset/243833
284
285 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
286
287         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
288         https://bugs.webkit.org/show_bug.cgi?id=196635
289
290         Reviewed by Antti Koivisto.
291         
292         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
293         for a test to enable async frame scrolling via:
294             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
295         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
296         
297         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
298
299         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
300         (WTR::InjectedBundle::beginTesting):
301         * WebKitTestRunner/TestController.cpp:
302         (WTR::TestController::resetPreferencesToConsistentValues):
303
304 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
305
306         Use a correct LC_RPATH when building with ASan
307         https://bugs.webkit.org/show_bug.cgi?id=196576
308
309         Reviewed by David Kilzer.
310
311         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
312         so that ../Frameworks is checked. This is simpler and more reliable than updating
313         each SPC service xcconfig.
314
315 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
316
317         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
318         https://bugs.webkit.org/show_bug.cgi?id=196629
319
320         Reviewed by Lucas Forschler.
321
322         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
323
324 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
325
326         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
327         https://bugs.webkit.org/show_bug.cgi?id=196618
328
329         Reviewed by Lucas Forschler.
330
331         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
332         (StatusBubble): Added QUEUE_TRIGGERS.
333         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
334         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
335         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
336         its parent(builder).
337
338 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
339
340         [ews-app] Status-bubble steps are sometimes displayed in reverse order
341         https://bugs.webkit.org/show_bug.cgi?id=196625
342
343         Reviewed by Lucas Forschler.
344
345         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
346         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
347
348 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
349
350         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
351         https://bugs.webkit.org/show_bug.cgi?id=196630
352
353         Reviewed by Wenson Hsieh.
354
355         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
356
357 2019-04-04  Youenn Fablet  <youenn@apple.com>
358
359         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
360         https://bugs.webkit.org/show_bug.cgi?id=196543
361
362         Reviewed by Alex Christensen.
363
364         * WebKitTestRunner/TestController.cpp:
365         (WTR::TestController::generatePageConfiguration):
366
367 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
368
369         [ews-app] Status bubble should not display skipped buildbot steps
370         https://bugs.webkit.org/show_bug.cgi?id=196584
371
372         Reviewed by Lucas Forschler.
373
374         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
375
376 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
377
378         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
379         https://bugs.webkit.org/show_bug.cgi?id=196620
380
381         Reviewed by Lucas Forschler.
382
383         * BuildSlaveSupport/ews-app/ews/config.py:
384
385 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
386
387         [Win] DumpRenderTreeWatchDog.py is not checked into source
388         https://bugs.webkit.org/show_bug.cgi?id=196567
389         <rdar://problem/49525901>
390
391         Reviewed by Lucas Forschler.
392
393         This script is used on Win EWS bots to terminate hanging DRT processes.
394
395         * EWSTools/dumprendertreewatchdog.py: Added.
396
397 2019-04-04  Chris Dumez  <cdumez@apple.com>
398
399         Unreviewed, roll out r243858 which made tests time out.
400
401         Disable new API tests on Windows instead.
402
403         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
404         (TestWebKitAPI::TEST):
405
406 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
407
408         [ATK] Cleanup WebPageAccessibilityObjectAtk
409         https://bugs.webkit.org/show_bug.cgi?id=196537
410
411         Reviewed by Michael Catanzaro.
412
413         Also consider files under atk directories as exceptions for GObject conventions.
414
415         * Scripts/webkitpy/style/checkers/cpp.py:
416         (check_identifier_name_in_declaration):
417
418 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
419
420         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
421         https://bugs.webkit.org/show_bug.cgi?id=196588
422         <rdar://problem/49365787>
423
424         Unreviewed build fix for Windows port.
425
426         error C3861: 'kill': identifier not found
427
428         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
429         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
430
431 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
432
433         [ews-build] Cancel build and similar operations should have authentication
434         https://bugs.webkit.org/show_bug.cgi?id=196520
435
436         Reviewed by Dewei Zhu.
437
438         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
439         environment variables.
440
441 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
442
443         [ews-build] Do not trigger queues which are not in production yet
444         https://bugs.webkit.org/show_bug.cgi?id=196581
445
446         Reviewed by Dewei Zhu.
447
448         * BuildSlaveSupport/ews-build/config.json:
449
450 2019-04-03  Chris Dumez  <cdumez@apple.com>
451
452         Unreviewed, fix typo in the name of API test added in r243848.
453
454         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
455         (TestWebKitAPI::TEST):
456
457 2019-04-03  Chris Dumez  <cdumez@apple.com>
458
459         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
460         https://bugs.webkit.org/show_bug.cgi?id=196588
461         <rdar://problem/49365787>
462
463         Reviewed by Ryosuke Niwa.
464
465         Add API test coverage.
466
467         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
468         (TestWebKitAPI::nullJavaScriptCallback):
469         (TestWebKitAPI::didCrashCheckFrames):
470         (TestWebKitAPI::TEST):
471
472 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
473
474         run-webkit-tests: Upload test results (new results database)
475         https://bugs.webkit.org/show_bug.cgi?id=196577
476         <rdar://problem/34841155>
477
478         Reviewed by Lucas Forschler.
479
480         * Scripts/webkitpy/layout_tests/controllers/manager.py:
481         (Manager.run): Upload results after each device shard, since the configuration will be
482         different for each device.
483         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
484         uploaded to a results database.
485         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
486         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
487
488 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
489
490         -apple-trailing-word is needed for browser detection
491         https://bugs.webkit.org/show_bug.cgi?id=196575
492
493         Unreviewed.
494
495         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
496
497 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
498
499         [CMake][WTF] Mirror XCode header directories
500         https://bugs.webkit.org/show_bug.cgi?id=191662
501
502         Reviewed by Konstantin Tokarev.
503
504         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
505         builds.
506
507         * CMakeLists.txt:
508         * DumpRenderTree/CMakeLists.txt:
509         * DumpRenderTree/PlatformWin.cmake:
510         * MiniBrowser/win/CMakeLists.txt:
511         * TestWebKitAPI/CMakeLists.txt:
512         * TestWebKitAPI/PlatformWin.cmake:
513         * WebKitTestRunner/PlatformGTK.cmake:
514         * WebKitTestRunner/PlatformWin.cmake:
515
516 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
517
518         [ews-app] Status bubble should not display certain infrastructure status messages
519         https://bugs.webkit.org/show_bug.cgi?id=196550
520
521         Reviewed by Lucas Forschler.
522
523         Do not display the steps which are un-needed for end-user. This information is still avaiable
524         if the user click on the bubble and look at the Buildbot build.
525         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
526         (StatusBubble._steps_messages):
527         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
528
529 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
530
531         [ews-build] Use https for sending data to ews-app
532         https://bugs.webkit.org/show_bug.cgi?id=196492
533
534         Reviewed by Lucas Forschler.
535
536         * BuildSlaveSupport/ews-build/events.py:
537
538 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
539
540         Remove support for -apple-trailing-word
541         https://bugs.webkit.org/show_bug.cgi?id=196525
542
543         Reviewed by Zalan Bujtas.
544
545         This CSS property is nonstandard and not used.
546
547         * Scripts/webkitperl/FeatureList.pm:
548         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
549
550 2019-04-03  Youenn Fablet  <youenn@apple.com>
551
552         Add a test for DOMCache on multiple browsing in case of private browsing
553         https://bugs.webkit.org/show_bug.cgi?id=196524
554
555         Reviewed by Alex Christensen.
556
557         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
558         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
559
560 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
561
562         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
563         https://bugs.webkit.org/show_bug.cgi?id=196540
564
565         Reviewed by Aakash Jain.
566
567         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
568
569 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
570
571         Add plumbing for a compatibility mode preference in WebKit
572         https://bugs.webkit.org/show_bug.cgi?id=196005
573
574         Reviewed by Tim Horton.
575
576         Add new API tests.
577
578         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
579         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
580
581 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
582
583         [WPE][GTK] Update libsrtp dependency package for Debian
584         https://bugs.webkit.org/show_bug.cgi?id=196528
585
586         Reviewed by Frédéric Wang.
587
588         * gtk/install-dependencies:
589         * wpe/install-dependencies:
590
591 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
592
593         [WK2] Add support for Window's beforeprint / afterprint events
594         https://bugs.webkit.org/show_bug.cgi?id=196478
595         <rdar://problem/49535124>
596
597         Unreviewed build fix for MSVC.
598
599         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
600
601         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
602
603         * WebKitTestRunner/TestController.cpp:
604         (WTR::printFrame): Use int and float literals.
605
606 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
607
608         [ews-build] Reassign bots to queues
609
610         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
611
612 2019-04-02  Chris Dumez  <cdumez@apple.com>
613
614         [WK2] Add support for Window's beforeprint / afterprint events
615         https://bugs.webkit.org/show_bug.cgi?id=196478
616
617         Reviewed by Alex Christensen.
618
619         Add minimal implementation for printFrame in WebKitTestRunner.
620
621         * WebKitTestRunner/TestController.cpp:
622         (WTR::printFrame):
623         (WTR::TestController::createOtherPage):
624         (WTR::TestController::createWebViewWithOptions):
625
626 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
627
628         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
629         https://bugs.webkit.org/show_bug.cgi?id=196491
630
631         Reviewed by Lucas Forschler.
632
633         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
634
635 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
636
637         [ews-build] Configure buildbot try credentials in environment variables
638         https://bugs.webkit.org/show_bug.cgi?id=196501
639
640         Reviewed by Lucas Forschler.
641
642         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
643         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
644         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
645
646 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
647
648         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
649         https://bugs.webkit.org/show_bug.cgi?id=196496
650         <rdar://problem/49521634>
651
652         Reviewed by Chris Dumez.
653
654         Add new API tests (see WebKit ChangeLog for more detail).
655
656         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
657         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
658         (TEST):
659
660 2019-04-02  David Kilzer  <ddkilzer@apple.com>
661
662         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
663         <https://webkit.org/b/196499>
664
665         Reviewed by Alexey Proskuryakov.
666
667         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
668         ENABLE_ADDRESS_SANITIZER.
669
670 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
671
672         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
673         https://bugs.webkit.org/show_bug.cgi?id=182757
674
675         Reviewed by Don Olmstead.
676
677         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
678         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
679
680 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
681
682         run-api-tests: Upload test results
683         https://bugs.webkit.org/show_bug.cgi?id=196323
684         <rdar://problem/49356714>
685
686         Reviewed by Lucas Forschler.
687
688         * Scripts/webkitpy/api_tests/manager.py:
689         (Manager):
690         (Manager.run): Upload results to a results database.
691         * Scripts/webkitpy/api_tests/run_api_tests.py:
692         (parse_args): Add upload arguments.
693         * Scripts/webkitpy/port/base.py:
694         (Port):
695         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
696         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
697         with commits from any other associated repositories.
698         * Scripts/webkitpy/port/device.py:
699         (Device):
700         (Device.build_version): Access build_versoin of underlying platform device.
701         * Scripts/webkitpy/port/ios_simulator_unittest.py:
702         (IOSSimulatorTest):
703         (IOSSimulatorTest.test_configuration_for_upload):
704         * Scripts/webkitpy/port/device_port.py:
705         (DevicePort):
706         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
707         the same as the machine uploading results.
708         * Scripts/webkitpy/port/mac.py:
709         (MacPort):
710         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
711         * Scripts/webkitpy/port/mac_unittest.py:
712         (MacTest):
713         (MacTest.test_configuration_for_upload):
714         * Scripts/webkitpy/xcode/simulated_device.py:
715         (SimulatedDeviceManager._create_device_with_runtime):
716         (SimulatedDevice.__init__): Create simulated device with a build_version.
717         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
718         (test_existing_simulator):
719
720 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
721
722         Remove extra newline characters (Follow-up fix to r243707)
723
724         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
725
726 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
727
728         [ews-app] Use API_KEY to accept results data
729         https://bugs.webkit.org/show_bug.cgi?id=196461
730
731         Reviewed by Dewei Zhu.
732
733         * BuildSlaveSupport/ews-app/ews/views/results.py:
734         (Results.post): Validate EWS_API_KEY before accepting any data.
735         * BuildSlaveSupport/ews-build/events.py:
736         (Events.sendData): Send EWS_API_KEY if available along with event data.
737
738 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
739
740         Unable to copy and paste a PDF from Notes into Mail compose body
741         https://bugs.webkit.org/show_bug.cgi?id=196442
742         <rdar://problem/48573098>
743
744         Reviewed by Tim Horton.
745
746         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
747         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
748         to be specified on the item providers.
749
750         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
751         (TestWebKitAPI::mapItemForTesting):
752         (TestWebKitAPI::contactItemForTesting):
753
754 2019-04-01  Tim Horton  <timothy_horton@apple.com>
755
756         Make UIWKDocumentContext rects per-character instead of per-word
757         https://bugs.webkit.org/show_bug.cgi?id=196459
758
759         Reviewed by Wenson Hsieh.
760
761         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
762         (TEST):
763         Adjust test results due to switching to per-character rects.
764
765 2019-04-01  Chris Dumez  <cdumez@apple.com>
766
767         UIProcess crash when a prewarmed process is terminated
768         https://bugs.webkit.org/show_bug.cgi?id=196451
769         <rdar://problem/49245471>
770
771         Reviewed by Geoffrey Garen.
772
773         Add API test coverage.
774
775         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
776         (TEST):
777
778 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
779
780         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
781         https://bugs.webkit.org/show_bug.cgi?id=196449
782
783         Reviewed by Lucas Forschler.
784
785         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
786         (StatusBubble.get_os_details): Method to get OS and Xcode details.
787         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
788         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
789
790 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
791
792         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
793         https://bugs.webkit.org/show_bug.cgi?id=196444
794
795         Reviewed by Lucas Forschler.
796
797         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
798
799 2019-04-01  Alex Christensen  <achristensen@webkit.org>
800
801         Add SPI to canonicalize NSURLs with WTF::URL
802         https://bugs.webkit.org/show_bug.cgi?id=196415
803         <rdar://problem/44980271>
804
805         Reviewed by Darin Adler.
806
807         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
808         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
809         (TestWebKitAPI::TEST):
810
811 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
812
813         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
814         https://bugs.webkit.org/show_bug.cgi?id=196441
815
816         Reviewed by Carlos Garcia Campos.
817
818         Don't cache the wpe_view_backend object that might not exist yet at the
819         time of EventSenderProxy constructor invocation, but instead retrieve
820         that object whenever it's required for event dispatching. This should
821         avoid crashes in this constructor now that it's invoked before any
822         PlatformWindow has been set up (as changed in r243496).
823
824         * WebKitTestRunner/EventSenderProxy.h:
825         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
826         (WTR::viewBackend):
827         (WTR::EventSenderProxy::EventSenderProxy):
828         (WTR::EventSenderProxy::mouseDown):
829         (WTR::EventSenderProxy::mouseUp):
830         (WTR::EventSenderProxy::mouseMoveTo):
831         (WTR::EventSenderProxy::mouseScrollBy):
832         (WTR::EventSenderProxy::keyDown):
833         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
834
835 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
836
837         [Win][WebKit] MiniBrowser should support high DPI display
838         https://bugs.webkit.org/show_bug.cgi?id=196391
839
840         Reviewed by Alex Christensen.
841
842         * MiniBrowser/win/WebKitBrowserWindow.cpp:
843         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
844         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
845         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
846
847 2019-03-31  Sam Weinig  <weinig@apple.com>
848
849         Remove more i386 specific configurations
850         https://bugs.webkit.org/show_bug.cgi?id=196430
851
852         Reviewed by Alexey Proskuryakov.
853
854         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
855         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
856
857 2019-03-31  Andy Estes  <aestes@apple.com>
858
859         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
860         https://bugs.webkit.org/show_bug.cgi?id=196433
861         <rdar://problem/49293305>
862
863         Reviewed by Tim Horton.
864
865         Enhanced API test coverage to include all navigation response policy decisions in both
866         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
867
868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
869         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
870         (TestWebKitAPI::TEST):
871         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
872         (readFile):
873         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
874         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
875         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
876         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
877         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
878         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
879         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
880         (-[QuickLookDelegate _downloadDidStart:]):
881         (-[QuickLookDelegate _download:didReceiveResponse:]):
882         (-[QuickLookDelegate _download:didReceiveData:]):
883         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
884         (-[QuickLookDelegate _downloadDidFinish:]):
885         (-[QuickLookDelegate _download:didFailWithError:]):
886         (-[QuickLookDelegate _downloadDidCancel:]):
887         (-[QuickLookDelegate verifyDownload]):
888         (runTest):
889         (runTestDecideBeforeLoading):
890         (runTestDecideAfterLoading):
891         (TEST):
892         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
893         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
894         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
895         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
896         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
897         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
898         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
899         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
900         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
901         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
902         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
903         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
904         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
905         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
906
907 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
908
909         [CMake] add testdfg as target with build-jsc
910         https://bugs.webkit.org/show_bug.cgi?id=196393
911
912         Reviewed by Saam Barati.
913
914         Added testdfg as one of the targets to build when
915         using CMake.
916
917         * Scripts/build-jsc:
918
919 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
920
921         Delete WebMetal implementation in favor of WebGPU
922         https://bugs.webkit.org/show_bug.cgi?id=195418
923
924         Reviewed by Dean Jackson.
925
926         * DumpRenderTree/mac/DumpRenderTree.mm:
927         (enableExperimentalFeatures):
928         (resetWebPreferencesToConsistentValues):
929         * Scripts/webkitperl/FeatureList.pm:
930         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
932         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
933         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
934         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
935         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
936         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
937         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
938         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
939         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
940         (WTR::InjectedBundle::beginTesting):
941         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
942         (WTR::TestRunner::setWebMetalEnabled): Deleted.
943         * WebKitTestRunner/InjectedBundle/TestRunner.h:
944
945 2019-03-29  Chris Dumez  <cdumez@apple.com>
946
947         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
948         https://bugs.webkit.org/show_bug.cgi?id=196405
949         <rdar://problem/49428130>
950
951         Reviewed by Wenson Hsieh.
952
953         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
954         the popover presentation methods to be no-ops. Use this in the new test added in
955         r243523 so that we do not swizzle those methods for all tests. This is needed because
956         those WatchOS tests rely on the popover getting presented and interactive.
957
958         * WebKitTestRunner/TestController.cpp:
959         (WTR::updateTestOptionsFromTestHeader):
960         * WebKitTestRunner/TestController.h:
961         * WebKitTestRunner/TestOptions.h:
962         (WTR::TestOptions::hasSameInitializationOptions const):
963         * WebKitTestRunner/ios/TestControllerIOS.mm:
964         (WTR::TestController::platformInitialize):
965         (WTR::TestController::platformResetStateToConsistentValues):
966
967 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
968
969         [Curl] Add Server Trust Evaluation Support.
970         https://bugs.webkit.org/show_bug.cgi?id=191646
971
972         Reviewed by Fujii Hironori.
973
974         Implemented MiniBrowser UI for asking if user trusts the server.
975
976         * MiniBrowser/win/Common.cpp:
977         (askServerTrustEvaluation):
978         (replaceString):
979         * MiniBrowser/win/Common.h:
980         * MiniBrowser/win/MiniBrowserLib.rc:
981         * MiniBrowser/win/MiniBrowserLibResource.h:
982         * MiniBrowser/win/WebKitBrowserWindow.cpp:
983         (createPEMString):
984         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
985         (WebKitBrowserWindow::canTrustServerCertificate):
986         * MiniBrowser/win/WebKitBrowserWindow.h:
987
988 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
989
990         Implement ResizeObserver.
991         https://bugs.webkit.org/show_bug.cgi?id=157743
992
993         Reviewed by Simon Fraser.
994
995         Support resizeObserverEnabled webPreferences.
996
997         * DumpRenderTree/TestOptions.cpp:
998         (TestOptions::TestOptions):
999         * DumpRenderTree/TestOptions.h:
1000         * DumpRenderTree/mac/DumpRenderTree.mm:
1001         (setWebPreferencesForTestOptions):
1002         * DumpRenderTree/win/DumpRenderTree.cpp:
1003         (enableExperimentalFeatures):
1004         * Scripts/webkitperl/FeatureList.pm:
1005         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1006
1007 2019-03-28  John Wilander  <wilander@apple.com>
1008
1009         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1010         https://bugs.webkit.org/show_bug.cgi?id=196281
1011         <rdar://problem/48938748>
1012
1013         Reviewed by Alex Christensen.
1014
1015         This patch adds the function isStatisticsHasLocalStorage() to the
1016         TestRunner. With it, the page can query the WebsiteDataStore in the
1017         UI process to make sure that it sees LocalStorage.
1018
1019         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1020         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1021         (WTR::TestRunner::isStatisticsHasLocalStorage):
1022         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1023         * WebKitTestRunner/TestController.cpp:
1024         (WTR::TestController::isStatisticsHasLocalStorage):
1025         * WebKitTestRunner/TestController.h:
1026         * WebKitTestRunner/TestInvocation.cpp:
1027         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1028
1029 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1030
1031         API::Data::createWithoutCopying should do a null check before calling CFRelease
1032         https://bugs.webkit.org/show_bug.cgi?id=196276
1033         <rdar://problem/48059859>
1034
1035         Reviewed by Alex Christensen.
1036
1037         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1038
1039         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1040         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1041         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1042         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1043         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1044         (TestWebKitAPI::TEST):
1045
1046 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1047
1048         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1049         https://bugs.webkit.org/show_bug.cgi?id=186276
1050
1051         Reviewed by Carlos Garcia Campos.
1052
1053         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1054         (webViewLoadChanged):
1055         (testWebResourceGetDataError):
1056         (testWebResourceGetDataEmpty):
1057         (beforeAll):
1058         (webViewloadChanged): Deleted.
1059
1060 2019-03-27  Andy Estes  <aestes@apple.com>
1061
1062         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1063         https://bugs.webkit.org/show_bug.cgi?id=196317
1064
1065         Reviewed by Dan Bernstein.
1066
1067         package-root copies built products into a staging directory using ditto(1), which does not
1068         follow symbolic links as it traverses a directory. Now that the files in
1069         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1070         itself, these become broken links when ditto'd into the staging directory.
1071
1072         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1073
1074         * Scripts/package-root:
1075
1076 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1077
1078         [ews-app] Update display text of Submit for ews analysis
1079         https://bugs.webkit.org/show_bug.cgi?id=196309
1080
1081         Reviewed by Dewei Zhu.
1082
1083         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1084
1085 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1086
1087         run-webkit-tests should check for leaks in WebKit processes
1088         <https://webkit.org/b/193772>
1089         <rdar://problem/46526680>
1090
1091         Reviewed by Ryosuke Niwa.
1092
1093         This works by doing the following:
1094         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1095           The list of child processes are returned one per line:
1096           process.name: pid
1097         - Run the "#LIST CHILD PROCESSES" command just before the
1098           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1099           processes on the ServerProcess object.
1100         - When the `--leaks` switch is handled, run check_for_leaks() on
1101           each child process after the main test harness.
1102
1103         * DumpRenderTree/mac/DumpRenderTree.mm:
1104         (handleControlCommand):
1105         - Use strncmp() instead of strcmp().
1106         - Add support for handling "#LIST CHILD PROCESSES" command.
1107
1108         * Scripts/webkitpy/port/base.py:
1109         (Port.check_for_leaks):
1110         * Scripts/webkitpy/port/darwin.py:
1111         (DarwinPort.check_for_leaks):
1112         - Rename redundant 'process_pid' argument to 'process_id'.
1113
1114         * Scripts/webkitpy/port/driver.py:
1115         (Driver.do_post_tests_work):
1116         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1117           longer the only command this sends to WebKitTestRunner.
1118         - If the `--leaks` switch is present, send the
1119           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1120           result using Port.set_webkit_processes().
1121         (Driver._parse_child_processes_output):
1122         - Add helper method to parse list of child process names and
1123           process IDs returned from WebKitTestRunner.
1124
1125         * Scripts/webkitpy/port/ios_device.py:
1126         (IOSDevicePort.check_for_leaks):
1127         - Rename redundant 'process_pid' argument to 'process_id'.
1128
1129         * Scripts/webkitpy/port/leakdetector.py:
1130         (LeakDetector._parse_leaks_output):
1131         - Return early if there is no leaks_output.
1132         (LeakDetector.check_for_leaks):
1133         - Rename redundant 'process_pid' argument to 'process_id'.
1134
1135         * Scripts/webkitpy/port/server_process.py:
1136         (ServerProcess.__init__):
1137         (ServerProcess.child_processes):
1138         (ServerProcess.set_child_processes):
1139         - Add instance variable to Port to store list of child process
1140           names and process IDs returned from WebKitTestRunner.
1141         (ServerProcess._start):
1142         - Clear self._child_processes.
1143         (ServerProcess.stop):
1144         - If self._child_processes is set, call
1145           self._port.check_for_leaks() for each child process.
1146
1147         * Scripts/webkitpy/port/server_process_unittest.py:
1148         (TrivialMockPort.check_for_leaks):
1149         - Rename redundant 'process_pid' argument to 'process_id'.
1150
1151         * Scripts/webkitpy/port/simulator_process.py:
1152         (SimulatorProcess.stop):
1153         - If self._child_processes is set, call
1154           self._port.check_for_leaks() for each child process.
1155
1156         * Scripts/webkitpy/port/watch_device.py:
1157         (WatchDevicePort.check_for_leaks):
1158         - Rename redundant 'process_pid' argument to 'process_id'.
1159
1160         * WebKitTestRunner/TestController.cpp:
1161         (WTR::TestController::dumpResponse):
1162         - Extract method from findAndDumpWorldLeaks() so that it may be
1163           reused by findAndDumpWebKitProcessIdentifiers().
1164         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1165         - Add method to output process name and process ID of both the
1166           WebContent and Networking processes.
1167         (WTR::TestController::findAndDumpWorldLeaks):
1168         - Fix missing newline in output when there were no abandoned
1169           documents.
1170         - Call dumpResponse() for extracted code.
1171         (WTR::TestController::handleControlCommand):
1172         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1173         - Use strncmp() instead of strcmp().
1174         - Call findAndDumpWebKitProcessIdentifiers() when
1175           "#LIST CHILD PROCESSES" command is sent.
1176         * WebKitTestRunner/TestController.h:
1177         (WTR::TestController::dumpResponse):
1178         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1179         - Declare methods.
1180
1181 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1182
1183         Unreviewed. Add GLib API test cases after r243434.
1184
1185         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1186         (testWebViewActiveURI):
1187         (serverCallback):
1188         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1189         (sendRequestCallback):
1190
1191 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1192
1193         Geolocation request not complete when watch request was started in a different web process
1194         https://bugs.webkit.org/show_bug.cgi?id=195996
1195
1196         Reviewed by Alex Christensen.
1197
1198         Add a test case.
1199
1200         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1201         (TestWebKitAPI::runJavaScriptAlert):
1202         (TestWebKitAPI::TEST):
1203
1204 2019-03-26  Keith Rollin  <krollin@apple.com>
1205
1206         Update the way generate-xcfilelists returns strings from functions
1207         https://bugs.webkit.org/show_bug.cgi?id=195975
1208         <rdar://problem/49040807>
1209
1210         Reviewed by Dean Jackson.
1211
1212         There are places where generate-xcfilelists executes assignments with
1213         statements like:
1214
1215             FOO=$(some_function)
1216
1217         where "some_function" return a string by echoing it. E.g.
1218
1219             some_function()
1220             {
1221                 echo "Hello, World"
1222             }
1223
1224         This is a common idiom, but it has a problem if "some_function" needs
1225         to call "exit" in an attempt to halt the entire script right then and
1226         there. Since "some_function" is called inside of $(), it's being
1227         executed in a sub-shell. Calling exit in that sub-shell simply exits
1228         that shell; it doesn't not exit the outer shell in which the main part
1229         of the script is still running. As such, the main script keeps
1230         executing when the intent was for the script to halt.
1231
1232         The solution to this is to use a different idiom for returning
1233         strings. The one we now is to pass in the name of the variable to
1234         receive the string result:
1235
1236             some_function()
1237             {
1238                 variable_name=$1
1239                 eval $variable_name ="Hello, World"
1240             }
1241
1242         The call site now looks like
1243
1244             some_function FOO
1245
1246         Because there's no invocation of a sub-shell, some_function can now
1247         call "exit" if it wants to, and the entire script will exit at that
1248         point.
1249
1250         * Scripts/generate-xcfilelists:
1251
1252 2019-03-26  Chris Dumez  <cdumez@apple.com>
1253
1254         Add basic layout test coverage for File Picker on iOS
1255         https://bugs.webkit.org/show_bug.cgi?id=196265
1256
1257         Reviewed by Wenson Hsieh.
1258
1259         Add layout test infrastructure to test the file picker on iOS.
1260
1261         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1262         (WTR::UIScriptController::dismissFilePicker):
1263         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1264         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1265         (WTR::UIScriptController::dismissFilePicker):
1266         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1267         * WebKitTestRunner/TestController.cpp:
1268         (WTR::TestController::createWebViewWithOptions):
1269         (WTR::updateTestOptionsFromTestHeader):
1270         * WebKitTestRunner/TestOptions.h:
1271         (WTR::TestOptions::hasSameInitializationOptions const):
1272         * WebKitTestRunner/ios/TestControllerIOS.mm:
1273         (overridePresentViewController):
1274         (WTR::TestController::platformInitialize):
1275         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1276         (WTR::UIScriptController::dismissFilePicker):
1277
1278 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1279
1280         Implement async paste method on UIWKInteractionViewProtocol
1281         https://bugs.webkit.org/show_bug.cgi?id=196267
1282         <rdar://problem/49236346>
1283
1284         Reviewed by Tim Horton.
1285
1286         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1287         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1288         are now a part of all iOS 12 internal SDKs.
1289
1290         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1291
1292         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1293         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1294
1295         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1296         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1297         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1298         * TestWebKitAPI/ios/UIKitSPI.h:
1299
1300 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1301
1302         [ews-build] Use PostgreSQL for ews.webkit.org database
1303         https://bugs.webkit.org/show_bug.cgi?id=196270
1304
1305         Reviewed by Lucas Forschler.
1306
1307         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1308
1309 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1310
1311         [ews] Reset simctl states on reboot
1312         https://bugs.webkit.org/show_bug.cgi?id=196260
1313
1314         Rubber-stamped by Aakash Jain.
1315
1316         * EWSTools/start-queue-mac.sh:
1317
1318 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1319
1320         [ews-build] Use PostgreSQL for ews-build database
1321         https://bugs.webkit.org/show_bug.cgi?id=196229
1322
1323         Reviewed by Lucas Forschler.
1324
1325         * BuildSlaveSupport/ews-build/master.cfg:
1326
1327 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1328
1329         [ews-build] Get master_hostname dynamically in master.cfg
1330         https://bugs.webkit.org/show_bug.cgi?id=196255
1331
1332         Reviewed by Lucas Forschler.
1333
1334         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1335         send events data in test mode.
1336
1337 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1338
1339         [ews-app] Set db_constraint to False for Foreign Keys
1340         https://bugs.webkit.org/show_bug.cgi?id=196252
1341
1342         Reviewed by Lucas Forschler.
1343
1344         * BuildSlaveSupport/ews-app/ews/models/build.py:
1345         * BuildSlaveSupport/ews-app/ews/models/step.py:
1346
1347 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1348
1349         [ews-build] is_test_mode_enabled should default to True
1350         https://bugs.webkit.org/show_bug.cgi?id=196248
1351
1352         Reviewed by Lucas Forschler.
1353
1354         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1355
1356 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1357
1358         [ews-app] Add webkitperl to ENABLED_QUEUES
1359         https://bugs.webkit.org/show_bug.cgi?id=196253
1360
1361         Reviewed by Lucas Forschler.
1362
1363         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1364
1365 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1366
1367         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1368         https://bugs.webkit.org/show_bug.cgi?id=196211
1369         rdar://problem/49110552
1370
1371         Reviewed by Tim Horton.
1372
1373         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1374         Make sure that EventSenderProxy always exists when running tests. We used to create
1375         it when resetting before the first test, which is a bit too late.
1376
1377         * WebKitTestRunner/TestController.h:
1378         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1379         (WTR::TestController::platformCreateWebView):
1380         (WTR::TestController::platformCreateOtherPage):
1381         (WTR::TestController::finishCreatingPlatformWebView):
1382         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1383         (WTR::PlatformWebView::PlatformWebView):
1384         Moved some code that made NSWindow use NSEvent during web view creation. We may
1385         need to move more if some other case us found, but this is enough for now.
1386
1387 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1388
1389         Unreviewed. Fix typo in GLib geolocation API after r243285.
1390
1391         gelocation -> geolocation.
1392
1393         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1394         (testGeolocationManagerWatchPosition):
1395
1396 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1397
1398         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1399         https://bugs.webkit.org/show_bug.cgi?id=196213
1400
1401         Reviewed by Geoff Garen.
1402
1403         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1404         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1405         (credentialWithIdentityAndKeychainPath):
1406         (-[ChallengeDelegate webView:didFinishNavigation:]):
1407         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1408         (TestWebKitAPI::TEST):
1409
1410 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1411
1412         Expected shouldn't assume its contained types are copyable
1413         https://bugs.webkit.org/show_bug.cgi?id=195986
1414
1415         Reviewed by JF Bastien.
1416
1417         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1418         (TestWebKitAPI::NonCopyable::operator== const):
1419         (TestWebKitAPI::NonCopyable::operator!= const):
1420         (TestWebKitAPI::TEST):
1421
1422 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1423
1424         Remove some now-unnecessary dynamic class lookup
1425         https://bugs.webkit.org/show_bug.cgi?id=196237
1426
1427         Reviewed by Simon Fraser.
1428
1429         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1430         (makeRequest):
1431         (TEST):
1432
1433 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1434
1435         Unreviewed, rolling out r243450.
1436
1437         AppleWin and WinCairo port builds get broken.
1438
1439         Reverted changeset:
1440
1441         "Add test for fix of #196095"
1442         https://bugs.webkit.org/show_bug.cgi?id=196097
1443         https://trac.webkit.org/changeset/243450
1444
1445 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1446
1447         Unreviewed, rolling out r243465.
1448         https://bugs.webkit.org/show_bug.cgi?id=196226
1449
1450         the test doesn't build (Requested by thorton on #webkit).
1451
1452         Reverted changeset:
1453
1454         "Do not terminate the NetworkProcess if a third party
1455         application sends a NSCredential with a SecIdentityRef"
1456         https://bugs.webkit.org/show_bug.cgi?id=196213
1457         https://trac.webkit.org/changeset/243465
1458
1459 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1460
1461         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1462         https://bugs.webkit.org/show_bug.cgi?id=196213
1463
1464         Reviewed by Geoff Garen.
1465
1466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1467         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1468         (credentialWithIdentityAndKeychainPath):
1469         (-[ChallengeDelegate webView:didFinishNavigation:]):
1470         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1471         (TestWebKitAPI::TEST):
1472
1473 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1474
1475         [ews-build] Gracefully handle missing patch_id in events
1476         https://bugs.webkit.org/show_bug.cgi?id=196216
1477
1478         Reviewed by Lucas Forschler.
1479
1480         * BuildSlaveSupport/ews-build/events.py:
1481
1482 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1483
1484         [ews-build] use lz4 compression for improving buildbot performance
1485         https://bugs.webkit.org/show_bug.cgi?id=196155
1486
1487         Reviewed by Lucas Forschler.
1488
1489         * BuildSlaveSupport/ews-build/master.cfg:
1490
1491 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1492
1493         Pull some API testing helper methods out of TestWKWebView
1494         https://bugs.webkit.org/show_bug.cgi?id=196212
1495
1496         Reviewed by Tim Horton.
1497
1498         Refactor some more API testing utility methods, so that they can be used in
1499         tests that do not use TestWKWebView.
1500
1501         * TestWebKitAPI/cocoa/TestWKWebView.h:
1502         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1503         (-[WKWebView loadTestPageNamed:]):
1504         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1505         (-[WKWebView synchronouslyLoadHTMLString:]):
1506         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1507         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1508         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1509         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1510         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1511
1512 2019-03-25  Jer Noble  <jer.noble@apple.com>
1513
1514         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1515         https://bugs.webkit.org/show_bug.cgi?id=196097
1516
1517         Reviewed by Eric Carlson.
1518
1519         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1520
1521         * DumpRenderTree/mac/DumpRenderTree.mm:
1522         (resetWebPreferencesToConsistentValues):
1523         * WebKitTestRunner/TestController.cpp:
1524         (WTR::TestController::resetPreferencesToConsistentValues):
1525
1526 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1527
1528         Pull IPadUserInterfaceSwizzler out into a separate header file
1529         https://bugs.webkit.org/show_bug.cgi?id=196193
1530
1531         Reviewed by Anders Carlsson.
1532
1533         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1534         be used in other API tests.
1535
1536         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1537         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1538         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1539         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1540         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1541         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1542         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1543
1544 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1545
1546         Remove NavigatorContentUtils in WebCore/Modules
1547         https://bugs.webkit.org/show_bug.cgi?id=196070
1548
1549         Reviewed by Alex Christensen.
1550
1551         NavigatorContentUtils was to support the custom scheme spec [1].
1552         However, in WebKit side, no port has supported the feature in
1553         WebKit layer after EFL port was removed. So there has been the
1554         only IDL implementation of the NavigatorContentUtils in WebCore.
1555         So we don't need to keep the implementation in WebCore anymore.
1556
1557         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1558
1559         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1560
1561 2019-03-24  Andy Estes  <aestes@apple.com>
1562
1563         [watchOS] Remove unused Proximity Networking code
1564         https://bugs.webkit.org/show_bug.cgi?id=196188
1565
1566         Reviewed by Tim Horton.
1567
1568         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1569         (TEST):
1570
1571 2019-03-23  Keith Miller  <keith_miller@apple.com>
1572
1573         Refactor clz/ctz and fix getLSBSet.
1574         https://bugs.webkit.org/show_bug.cgi?id=196162
1575
1576         Reviewed by Saam Barati.
1577
1578         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1579
1580         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1581         (TestWebKitAPI::TEST):
1582
1583 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1584
1585         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1586         https://bugs.webkit.org/show_bug.cgi?id=196143
1587
1588         Reviewed by Michael Catanzaro.
1589
1590         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1591         directories.
1592
1593         * Scripts/webkitpy/style/checkers/cpp.py:
1594         (check_identifier_name_in_declaration):
1595         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1596         (WebKitStyleTest.test_names):
1597
1598 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1599
1600         [Flatpak] Manifest expanding fails for qt WPE extension
1601         https://bugs.webkit.org/show_bug.cgi?id=196148
1602
1603         Reviewed by Alex Christensen.
1604
1605         * flatpak/flatpakutils.py:
1606         (expand_submodules_recurse): The last recurse manifest expand
1607         iteration might lead to a single module so take it into account
1608         and don't try to recurse further.
1609
1610 2019-03-22  Chris Dumez  <cdumez@apple.com>
1611
1612         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1613         https://bugs.webkit.org/show_bug.cgi?id=195348
1614         <rdar://problem/48622090>
1615
1616         Reviewed by Alex Christensen.
1617
1618         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1619         to NO when test.options().shouldIgnoreMetaViewport is false.
1620
1621         * WebKitTestRunner/ios/TestControllerIOS.mm:
1622         (WTR::TestController::platformConfigureViewForTest):
1623
1624 2019-03-22  Chris Dumez  <cdumez@apple.com>
1625
1626         Prewarmed processes should be usable with any website data store
1627         https://bugs.webkit.org/show_bug.cgi?id=196104
1628
1629         Reviewed by Alex Christensen.
1630
1631         Add API test coverage.
1632
1633         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1634         (runInitialWarmedProcessUsedTest):
1635         (TEST):
1636
1637 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1638
1639         Back out local changes to Alex's Subversion working directory
1640
1641         They were accidentally committed.
1642
1643         * Scripts/webkitpy/common/system/abstractexecutive.py:
1644         (AbstractExecutive.wait_newest):
1645         * Scripts/webkitpy/common/system/executive.py:
1646         (Executive.running_pids):
1647         * Scripts/webkitpy/common/system/executive_mock.py:
1648         (MockExecutive.running_pids):
1649         * Scripts/webkitpy/common/system/executive_unittest.py:
1650         (ExecutiveTest.serial_test_running_pids):
1651         * Scripts/webkitpy/port/darwin.py:
1652         (DarwinPort.check_for_leaks):
1653         * Scripts/webkitpy/port/leakdetector.py:
1654         (LeakDetector.check_for_leaks):
1655         - This was the hack attached to Bug 193772.
1656
1657         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1658         (+[WebKitTestRunnerEvent mouseLocation]):
1659         - This works around a crash on an internal build.
1660
1661 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1662
1663         Fix the build after r243354
1664         https://bugs.webkit.org/show_bug.cgi?id=196138
1665         <rdar://problem/49145951>
1666
1667         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1668         (TEST):
1669         * TestWebKitAPI/ios/UIKitSPI.h:
1670
1671 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1672
1673         Adopt UIWKDocumentContext
1674         https://bugs.webkit.org/show_bug.cgi?id=196040
1675         <rdar://problem/48642440>
1676
1677         Reviewed by Ryosuke Niwa.
1678
1679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1680         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1681         (makeRequest):
1682         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1683         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1684         (applyStyle):
1685         (TEST):
1686         Add tests for UIWKDocumentContext.
1687
1688         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1689         (TEST):
1690         (recursiveFindWKContentView): Deleted.
1691         * TestWebKitAPI/cocoa/TestWKWebView.h:
1692         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1693         (recursiveFindWKContentView):
1694         (-[TestWKWebView wkContentView]):
1695         * TestWebKitAPI/ios/UIKitSPI.h:
1696         Share the WKContentView finding code between tests.
1697
1698 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1699
1700         [iOS WK2] Turn on async overflow scrolling by default
1701         https://bugs.webkit.org/show_bug.cgi?id=196011
1702         rdar://problem/48453859
1703
1704         Reviewed by Antti Koivisto.
1705         
1706         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1707         since so many basic layout tests have different results when compositing is triggered for
1708         overflow.
1709         
1710         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1711
1712         * WebKitTestRunner/TestController.cpp:
1713         (WTR::TestController::resetPreferencesToConsistentValues):
1714
1715 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1716
1717         [ews-build] Retry API test in case of failures
1718         https://bugs.webkit.org/show_bug.cgi?id=196004
1719
1720         Reviewed by Lucas Forschler.
1721
1722         * BuildSlaveSupport/ews-build/steps.py:
1723         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1724         (CompileWebKitToT.doStepIf): Ditto.
1725         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1726         (ReRunAPITests): Re-run API tests.
1727         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1728         (RunAPITestsWithoutPatch): Run API tests without patch.
1729         (RunAPITestsWithoutPatch.doStepIf):
1730         (RunAPITestsWithoutPatch.hideStepIf):
1731         (RunAPITestsWithoutPatch.evaluateCommand):
1732         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1733         (AnalyzeAPITestsResults.start):
1734         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1735         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1736         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1737         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1738
1739 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1740
1741         [ews-build] Update queues configurations
1742         https://bugs.webkit.org/show_bug.cgi?id=196074
1743
1744         Reviewed by Dewei Zhu.
1745
1746         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1747         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1748
1749 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1750
1751         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1752         https://bugs.webkit.org/show_bug.cgi?id=195680
1753         <rdar://problem/48903534>
1754
1755         Unreviewed infrastructure fix.
1756
1757         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1758         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1759
1760 2019-03-21  Andy Estes  <aestes@apple.com>
1761
1762         [iOS] Apple Pay should be available in documents with no user agent scripts
1763         https://bugs.webkit.org/show_bug.cgi?id=196061
1764         <rdar://problem/48649391>
1765
1766         Reviewed by Brady Eidson.
1767
1768         Added API tests and related infrastructure.
1769
1770         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1771         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1772         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1773         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1774         (TestWebKitAPI::TEST):
1775         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1776         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1777         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1778         * TestWebKitAPI/cocoa/TestProtocol.mm:
1779         (-[TestProtocol startLoading]):
1780         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1781         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1782         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1783         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1784
1785 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1786
1787         REGRESSSION (r243297): webkitpy tests broken
1788         https://bugs.webkit.org/show_bug.cgi?id=196108
1789
1790         Reviewed by Aakash Jain.
1791
1792         r243297 updated contributors.json, which broke a few unit tests.
1793
1794         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1795         (IRCCommandTest.test_whois):
1796         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1797
1798 2019-03-21  Chris Dumez  <cdumez@apple.com>
1799
1800         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1801         https://bugs.webkit.org/show_bug.cgi?id=196041
1802         <rdar://problem/49083230>
1803
1804         Reviewed by Alex Christensen.
1805
1806         Add API test coverage.
1807
1808         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1809         (TEST):
1810
1811 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1812
1813         Add SPI to inform applications of WKContentRuleList actions
1814         https://bugs.webkit.org/show_bug.cgi?id=195965
1815         <rdar://problem/42664365>
1816
1817         Reviewed by Geoff Garen.
1818
1819         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1820         (TestWebKitAPI::allActionsForResourceLoad):
1821         (TestWebKitAPI::testRequest):
1822         (TestWebKitAPI::TEST_F):
1823         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1824         (Notification::description):
1825         (Notification::operator== const):
1826         (toVector):
1827         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1828         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1829         (makeContentRuleList):
1830         (TEST):
1831         (makeWarnContentRuleList): Deleted.
1832
1833 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1834
1835         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1836         https://bugs.webkit.org/show_bug.cgi?id=196088
1837
1838         Reviewed by Brian Burg.
1839
1840         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1841         Support checks when only one platform is specified. Also deprecate macosx() and
1842         force the use of macos() instead.
1843
1844         * Scripts/webkitpy/style/checkers/cpp.py:
1845         (check_min_versions_of_wk_api_available):
1846         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1847         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1848
1849 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1850
1851         Update status inactive committers' status to 'contributor'.
1852
1853         * Scripts/webkitpy/common/config/contributors.json:
1854
1855 2019-03-21  Xan Lopez  <xan@igalia.com>
1856
1857         [JSC][x86] Drop support for x87 floating point
1858         https://bugs.webkit.org/show_bug.cgi?id=194853
1859
1860         Reviewed by Don Olmstead.
1861
1862         Force SSE2 on x86/32bit builds.
1863
1864         * Scripts/webkitdirs.pm:
1865         (generateBuildSystemFromCMakeProject):
1866
1867 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1868
1869         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1870         https://bugs.webkit.org/show_bug.cgi?id=196073
1871
1872         Reviewed by Michael Catanzaro.
1873
1874         Add test cases to check functions and constructors with no arguments but receiving user data.
1875
1876         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1877         (checkUserData):
1878         (testJSCFunction):
1879         (fooCreateWithUserData):
1880         (testJSCClass):
1881
1882 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1883
1884         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1885
1886         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1887
1888         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1889
1890 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1891
1892         [GTK][WPE] Add API to provide geolocation information
1893         https://bugs.webkit.org/show_bug.cgi?id=195940
1894
1895         Reviewed by Michael Catanzaro.
1896
1897         Add a new test to check the new API.
1898
1899         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1900         (testGeolocationManagerCurrentPosition):
1901         (testGeolocationManagerWatchPosition):
1902         (beforeAll):
1903         (afterAll):
1904         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1905         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1906         (beforeAll): Ditto.
1907         * TestWebKitAPI/glib/CMakeLists.txt:
1908
1909 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1910
1911         [GLib] Returning G_TYPE_OBJECT from a method does not work
1912         https://bugs.webkit.org/show_bug.cgi?id=195574
1913
1914         Reviewed by Michael Catanzaro.
1915
1916         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1917
1918         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1919         (getGFile):
1920         (getParent):
1921         (createGString):
1922         (getGString):
1923         (getGStringCopyWillRaise):
1924         (getGStringCopy):
1925         (getGStringStr):
1926         (getGStringLen):
1927         (freeGString):
1928         (testJSCClass):
1929
1930 2019-03-20  Saam Barati  <sbarati@apple.com>
1931
1932         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1933         https://bugs.webkit.org/show_bug.cgi?id=195721
1934
1935         Reviewed by Filip Pizlo.
1936
1937         * Scripts/run-javascriptcore-tests:
1938
1939 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1940
1941         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1942         https://bugs.webkit.org/show_bug.cgi?id=196049
1943
1944         Reviewed by Tim Horton.
1945
1946         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1947         overflow scrolling in general, so rename it.
1948
1949         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1950
1951 2019-03-20  Daniel Bates  <dabates@apple.com>
1952
1953         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1954         https://bugs.webkit.org/show_bug.cgi?id=196031
1955         <rdar://problem/49078172>
1956
1957         Reviewed by Tim Horton.
1958
1959         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1960         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1961         same code path used when the Done button is pressed to dismiss the <select> picker.
1962
1963         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1964         (TestWebKitAPI::TEST):
1965
1966 2019-03-20  Chris Dumez  <cdumez@apple.com>
1967
1968         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1969         https://bugs.webkit.org/show_bug.cgi?id=196029
1970         <rdar://problem/48954651>
1971
1972         Reviewed by Tim Horton.
1973
1974         Add API test coverage.
1975
1976         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1977
1978 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1979
1980         [ews-build] Improve failure summary string for ApplyPatch step
1981         https://bugs.webkit.org/show_bug.cgi?id=195995
1982
1983         Reviewed by Alexey Proskuryakov.
1984
1985         * BuildSlaveSupport/ews-build/steps.py:
1986         (ApplyPatch.getResultSummary): Override getResultSummary.
1987
1988 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1989
1990         AX: Implement support for new meter ARIA role
1991         https://bugs.webkit.org/show_bug.cgi?id=195966
1992
1993         Reviewed by Chris Fleizach.
1994
1995         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1996         to AXLevelIndicator.
1997
1998         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1999
2000 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2001
2002         [WebAuthN] Implement FIDO AppID extension
2003         https://bugs.webkit.org/show_bug.cgi?id=143491
2004         <rdar://problem/48298273>
2005
2006         Reviewed by Brent Fulgham.
2007
2008         Add a test that covers the new flag of convertToU2fSignCommand.
2009
2010         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2011         (TestWebKitAPI::TEST):
2012         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2013         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2014         (TestWebKitAPI::TEST):
2015
2016 2019-03-19  Keith Rollin  <krollin@apple.com>
2017
2018         Add support for more platforms to generate-xcfilelists
2019         https://bugs.webkit.org/show_bug.cgi?id=195977
2020
2021         Reviewed by Alexey Proskuryakov.
2022
2023         generate-xcfilelists incorrectly complains when involved with building
2024         WebKit for iphonesimulator:
2025
2026             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2027             …
2028             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2029
2030         Address this by teaching generate-xcfilelists about more platforms.
2031
2032         * Scripts/generate-xcfilelists:
2033
2034 2019-03-19  John Wilander  <wilander@apple.com>
2035
2036         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2037         https://bugs.webkit.org/show_bug.cgi?id=195923
2038         <rdar://problem/49001272>
2039
2040         Reviewed by Alex Christensen.
2041
2042         This patch does the following to the TestRunner:
2043         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2044         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2045         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2046
2047         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2048         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2049         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2050         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2051         * WebKitTestRunner/TestController.cpp:
2052         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2053         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2054         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2055         * WebKitTestRunner/TestController.h:
2056         * WebKitTestRunner/TestInvocation.cpp:
2057         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2058
2059 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2060
2061         [CMake] Support more clang and gcc sanitizers
2062         https://bugs.webkit.org/show_bug.cgi?id=195956
2063
2064         Reviewed by Michael Catanzaro.
2065
2066         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2067
2068 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2069
2070         [ews-build] Improve summary for PrintConfiguration step
2071         https://bugs.webkit.org/show_bug.cgi?id=195945
2072
2073         Reviewed by Lucas Forschler.
2074
2075         * BuildSlaveSupport/ews-build/steps.py:
2076         (PrintConfiguration.getResultSummary): Override getResultSummary.
2077
2078 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2079
2080         [ews-build] Improve summary for CheckOutSource step
2081         https://bugs.webkit.org/show_bug.cgi?id=195963
2082
2083         Reviewed by Lucas Forschler.
2084
2085         * BuildSlaveSupport/ews-build/steps.py:
2086         (CheckOutSource.getResultSummary):
2087
2088 2019-03-19  Daniel Bates  <dabates@apple.com>
2089
2090         [iOS] Focus not preserved when switching between tabs
2091         https://bugs.webkit.org/show_bug.cgi?id=195820
2092         <rdar://problem/43614450>
2093
2094         Reviewed by Brent Fulgham.
2095
2096         Add tests to ensure that we restore focus when resigning and becoming first responder.
2097
2098         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2099         (TestWebKitAPI::TEST):
2100
2101 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2102
2103         Make WTFLogChannelState and WTFLogLevel enum classes
2104         https://bugs.webkit.org/show_bug.cgi?id=195904
2105
2106         Reviewed by Eric Carlson.
2107
2108         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2109         (TestWebKitAPI::TEST_F):
2110
2111 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2112
2113         [GStreamer][EME] Backported mssdemux protection data crash fix
2114         https://bugs.webkit.org/show_bug.cgi?id=195918
2115
2116         Reviewed by Philippe Normand.
2117
2118         * gstreamer/jhbuild.modules:
2119         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2120
2121 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2122
2123         Unreviewed, rolling out r243132.
2124
2125         Broke GTK build
2126
2127         Reverted changeset:
2128
2129         "Make WTFLogChannelState and WTFLogLevel enum classes"
2130         https://bugs.webkit.org/show_bug.cgi?id=195904
2131         https://trac.webkit.org/changeset/243132
2132
2133 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2134
2135         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2136
2137         * Scripts/webkitdirs.pm:
2138         (builtDylibPathForName): Adjust the shared library name that's changed
2139         with the API version bump in r243073.
2140
2141 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2142
2143         Make WTFLogChannelState and WTFLogLevel enum classes
2144         https://bugs.webkit.org/show_bug.cgi?id=195904
2145
2146         Reviewed by Eric Carlson.
2147
2148         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2149         (TestWebKitAPI::TEST_F):
2150
2151 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2152
2153         Disable flaky test added in r2431100
2154         https://webkit.org/b/195785
2155
2156         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2157         (TestWebKitAPI::TEST):
2158         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2159
2160 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2161
2162         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2163         https://bugs.webkit.org/show_bug.cgi?id=195916
2164
2165         Reviewed by Tim Horton.
2166
2167         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2168         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2169
2170 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2171
2172         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2173
2174         * Scripts/webkitpy/common/config/contributors.json:
2175
2176 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2177
2178         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2179         https://bugs.webkit.org/show_bug.cgi?id=195785
2180
2181         Reviewed by Geoffrey Garen.
2182
2183         * TestWebKitAPI/TCPServer.cpp: Added.
2184         (TestWebKitAPI::TCPServer::TCPServer):
2185         (TestWebKitAPI::TCPServer::~TCPServer):
2186         (TestWebKitAPI::TCPServer::socketBindListen):
2187         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2188         * TestWebKitAPI/TCPServer.h: Added.
2189         (TestWebKitAPI::TCPServer::port const):
2190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2191         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2192         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2193         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2194         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2195         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2196         (TestWebKitAPI::respondSlowly):
2197         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2198         (TestWebKitAPI::downloadAtRate):
2199         (TestWebKitAPI::TEST):
2200
2201 2019-03-18  Saam Barati  <sbarati@apple.com>
2202
2203         Add a plan file for JetStream 2
2204         https://bugs.webkit.org/show_bug.cgi?id=190734
2205
2206         Reviewed by Mark Lam.
2207
2208         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2209
2210 2019-03-18  Chris Dumez  <cdumez@apple.com>
2211
2212         Delay WebProcess launch until a load is triggered in a Web view
2213         https://bugs.webkit.org/show_bug.cgi?id=195758
2214         <rdar://problem/48126013>
2215
2216         Reviewed by Geoff Garen.
2217
2218         Add API test coverage. Also update some existing API tests to not expect
2219         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2220
2221         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2222         (TestWebKitAPI::TEST):
2223         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2224         (TestWebKitAPI::TEST):
2225         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2226         (TEST):
2227         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2228         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2229         (TEST):
2230         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2231         (TEST):
2232         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2233
2234 2019-03-18  Xan Lopez  <xan@igalia.com>
2235
2236         [CMake] Prevent potential warning when determining $architecture
2237         https://bugs.webkit.org/show_bug.cgi?id=195891
2238
2239         Reviewed by Michael Catanzaro.
2240
2241         It's possible for generateBuildSystemForCMakeProject to be called
2242         before determineArchitecture() is ever called. This will make the
2243         first eq check with $architecture to be bogus (and print a
2244         warning). Change that to an eq check with architecture(), which
2245         implicitly calls determineArchitecture() if needed, and change all
2246         the other similar cases in the method in the same way to prevent
2247         future bugs like this one.
2248
2249         * Scripts/webkitdirs.pm:
2250         (generateBuildSystemFromCMakeProject):
2251
2252 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2253
2254         [WPE] Tarballs generated with “make dist” cannot build documentation
2255         https://bugs.webkit.org/show_bug.cgi?id=195885
2256
2257         Reviewed by Carlos Garcia Campos.
2258
2259         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2260
2261 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2262
2263         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2264         https://bugs.webkit.org/show_bug.cgi?id=195883
2265
2266         Reviewed by Carlos Garcia Campos.
2267
2268         * gtkdoc/gtkdoc.py:
2269         (GTKDoc._run_command): When commands fail to run, include the full command line for
2270         the program invocation and the output it has generated on the standard error stream.
2271
2272 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2273
2274         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2275         https://bugs.webkit.org/show_bug.cgi?id=195786
2276
2277         Reviewed by Philippe Normand.
2278
2279         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2280         * wpe/jhbuild.modules: Ditto.
2281
2282 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2283
2284         [ews-build] Don't run clean builds on EWS builders
2285         https://bugs.webkit.org/show_bug.cgi?id=195851
2286
2287         Reviewed by Geoffrey Garen.
2288
2289         * BuildSlaveSupport/ews-build/factories.py:
2290
2291 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2292
2293         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2294         https://bugs.webkit.org/show_bug.cgi?id=195849
2295
2296         Reviewed by Chris Dumez.
2297
2298         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2299
2300         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2301         (runWebsiteDataStoreCustomPaths):
2302
2303 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2304
2305         webkitpy: Upload test results
2306         https://bugs.webkit.org/show_bug.cgi?id=195755
2307         <rdar://problem/48896182>
2308
2309         Reviewed by Aakash Jain.
2310
2311         Establish a new format for uploading results that is not tied to layout tests, apply
2312         that format to webkitpy tests.
2313
2314         * Scripts/webkitpy/common/checkout/scm/git.py:
2315         (Git.native_branch): Return what branch the current checkout is on.
2316         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2317         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2318         * Scripts/webkitpy/common/checkout/scm/svn.py:
2319         (SVN.native_branch): Ditto.
2320         * Scripts/webkitpy/common/system/platforminfo.py:
2321         (PlatformInfo.build_version): Return a build version for Mac.
2322         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2323         (MockPlatformInfo.__init__):
2324         (MockPlatformInfo.build_version):
2325         * Scripts/webkitpy/results: Added.
2326         * Scripts/webkitpy/results/__init__.py: Added.
2327         * Scripts/webkitpy/results/options.py: Added.
2328         (upload_options): OptParse list for upload options.
2329         * Scripts/webkitpy/results/upload.py: Added.
2330         (Upload): Class which enforces the upload format expected by the results server.
2331         (Upload.Expectations):
2332         (Upload.create_configuration):
2333         (Upload.create_commit):
2334         (Upload.create_details):
2335         (Upload.create_run_stats):
2336         (Upload.create_test_result):
2337         (Upload.__init__):
2338         (Upload.Encoder): Encode Upload object as json.
2339         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2340         * Scripts/webkitpy/results/upload_unittest.py: Added.
2341         * Scripts/webkitpy/test/main.py:
2342         (Tester._parse_args): Add upload arguments.
2343         (Tester._run_tests): Allow results to be uploaded.
2344         * Scripts/webkitpy/test/runner.py:
2345         (Runner.__init__): Record which tests were run, rather than just counting them.
2346         (Runner.handle):
2347         * Scripts/webkitpy/test/runner_unittest.py:
2348         (RunnerTest.test_run):
2349         * Scripts/webkitpy/thirdparty/__init__.py:
2350         (AutoinstallImportHook.find_module): Add requests auto-install.
2351         (AutoinstallImportHook._install_requests):
2352         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2353         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2354
2355 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2356
2357         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2358         https://bugs.webkit.org/show_bug.cgi?id=195810
2359
2360         Reviewed by Tim Horton.
2361
2362         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2363         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2364         ending certain layout tests.
2365
2366         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2367         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2368         (-[TestRunnerWKWebView dealloc]):
2369         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2370
2371         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2372         helper method when destroying the web view, and when resetting state between tests.
2373
2374         * WebKitTestRunner/ios/TestControllerIOS.mm:
2375         (WTR::TestController::platformResetStateToConsistentValues):
2376
2377         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2378
2379 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2380
2381         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2382         https://bugs.webkit.org/show_bug.cgi?id=190350
2383         <rdar://problem/45089503>
2384
2385         Reviewed by Geoffrey Garen.
2386
2387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2388         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2389         (TEST):
2390         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2391         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2392         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2393         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2394         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2395         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2396         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2397         (runTest):
2398         (createDirectories):
2399         (TEST):
2400         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2401         (TEST):
2402         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2403         (TEST):
2404
2405 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2406
2407         Add support to WebPage for getting the contents as an attributed string.
2408         https://bugs.webkit.org/show_bug.cgi?id=195636
2409         rdar://problem/45055697
2410
2411         Reviewed by Tim Horton.
2412
2413         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2414         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2415
2416 2019-03-15  Chris Dumez  <cdumez@apple.com>
2417
2418         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2419         https://bugs.webkit.org/show_bug.cgi?id=195747
2420
2421         Reviewed by Geoff Garen.
2422
2423         Add API test coverage.
2424
2425         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2426
2427 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2428
2429         Unreviewed, rolling out r242952.
2430
2431         Causing API failures on iOS Simulator
2432
2433         Reverted changeset:
2434
2435         "[PSON] Make sure the WebProcessCache is leverage when
2436         relaunching a process after termination"
2437         https://bugs.webkit.org/show_bug.cgi?id=195747
2438         https://trac.webkit.org/changeset/242952
2439
2440 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2441
2442         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2443         https://bugs.webkit.org/show_bug.cgi?id=195740
2444
2445         Reviewed by Ross Kirsling.
2446
2447         window.open doesn't work for WebKitBrowserWindow because it is not
2448         implemented yet.
2449
2450         1. Implemented createNewPage callback of WKPageUIClient.
2451         2. Changed MainWindow to take a BrowserWindow factory function
2452           instead of BrowserWindowType to be flexible to create
2453           BrowserWindow with extra settings.
2454         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2455           because it is not relevant with MainWindow anymore.
2456
2457         * MiniBrowser/win/Common.cpp:
2458         (parseCommandLine):
2459         * MiniBrowser/win/Common.h:
2460         (CommandLineOptions::CommandLineOptions):
2461         * MiniBrowser/win/MainWindow.cpp:
2462         (MainWindow::MainWindow):
2463         (MainWindow::create):
2464         (MainWindow::init):
2465         (MainWindow::WndProc):
2466         * MiniBrowser/win/MainWindow.h:
2467         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2468         (PrintWebUIDelegate::createWebViewWithRequest):
2469         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2470         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2471         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2472         (WebKitBrowserWindow::updateProxySettings):
2473         (WebKitBrowserWindow::createNewPage):
2474         * MiniBrowser/win/WebKitBrowserWindow.h:
2475         * MiniBrowser/win/WinMain.cpp:
2476         (wWinMain):
2477
2478 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2479
2480         Make it possible to test scrolling tree layer manipulation more easily
2481         https://bugs.webkit.org/show_bug.cgi?id=195780
2482
2483         Reviewed by Tim Horton.
2484         
2485         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2486         cuts off communication of scrolling tree scrolls back to the web process
2487         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2488         allows tests to trigger scrolls which run the scrolling tree layer positioning
2489         logic, but never get another commit from the web process that might mask
2490         scrolling tree bugs.
2491         
2492         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2493         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2494         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2495
2496         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2497         (WTR::UIScriptController::scrollUpdatesDisabled const):
2498         (WTR::UIScriptController::setScrollUpdatesDisabled):
2499         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2500         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2501         (WTR::UIScriptController::scrollUpdatesDisabled const):
2502         (WTR::UIScriptController::setScrollUpdatesDisabled):
2503         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2504         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2505         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2506         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2507         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2508         * WebKitTestRunner/ios/TestControllerIOS.mm:
2509         (WTR::TestController::platformResetStateToConsistentValues):
2510         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2511         (WTR::UIScriptController::scrollUpdatesDisabled const):
2512         (WTR::UIScriptController::setScrollUpdatesDisabled):
2513
2514 2019-03-14  Youenn Fablet  <youenn@apple.com>
2515
2516         Move IDB storage in private browsing mode to NetworkProcess
2517         https://bugs.webkit.org/show_bug.cgi?id=195602
2518
2519         Reviewed by Brady Eidson.
2520
2521         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2522         (TEST):
2523
2524 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2525
2526         [ews-build] Make descriptionDone messages more readable
2527         https://bugs.webkit.org/show_bug.cgi?id=195760
2528
2529         Reviewed by Lucas Forschler.
2530
2531         * BuildSlaveSupport/ews-build/steps.py:
2532         * BuildSlaveSupport/ews-build/steps_unittest.py:
2533
2534 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2535
2536         [ews-build] Generate status-bubble hover-over messages
2537         https://bugs.webkit.org/show_bug.cgi?id=195680
2538
2539         Reviewed by Lucas Forschler.
2540
2541         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2542         (StatusBubble):
2543         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2544         on hover-over.
2545         (StatusBubble._iso_time):
2546         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2547         hover-over message.
2548         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2549
2550 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2551
2552         [ews-app] Gracefully handle the case when state_string is None
2553         https://bugs.webkit.org/show_bug.cgi?id=195753
2554
2555         Reviewed by Lucas Forschler.
2556
2557         * BuildSlaveSupport/ews-app/ews/models/build.py:
2558         * BuildSlaveSupport/ews-app/ews/models/step.py:
2559
2560 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2561
2562         [ews-app] Status bubble display pending for currently running build step
2563         https://bugs.webkit.org/show_bug.cgi?id=195744
2564
2565         Reviewed by Lucas Forschler.
2566
2567         * BuildSlaveSupport/ews-build/events.py:
2568         (Events.stepStarted): If state_string is pending, replace it with step name.
2569
2570 2019-03-14  Chris Dumez  <cdumez@apple.com>
2571
2572         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2573         https://bugs.webkit.org/show_bug.cgi?id=195750
2574
2575         Reviewed by Geoffrey Garen.
2576
2577         Add API test coverage.
2578
2579         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2580         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2581         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2582         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2583
2584 2019-03-14  Chris Dumez  <cdumez@apple.com>
2585
2586         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2587         https://bugs.webkit.org/show_bug.cgi?id=195747
2588
2589         Reviewed by Geoff Garen.
2590
2591         Add API test coverage.
2592
2593         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2594
2595 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2596
2597         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2598         https://bugs.webkit.org/show_bug.cgi?id=195725
2599         <rdar://problem/48545062>
2600
2601         Reviewed by Tim Horton.
2602
2603         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2604         handler is nil.
2605
2606         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2607         (TestWebKitAPI::TEST):
2608
2609 2019-03-13  Sam Weinig  <sam@webkit.org>
2610
2611         Add utility function to allow easy reverse range-based iteration of a container
2612         https://bugs.webkit.org/show_bug.cgi?id=195542
2613
2614         Reviewed by Antti Koivisto.
2615
2616         * TestWebKitAPI/CMakeLists.txt:
2617         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2618         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2619         (TestWebKitAPI::TEST):
2620         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2621
2622 2019-03-13  Chris Dumez  <cdumez@apple.com>
2623
2624         Use a ServiceWorker process per registrable domain
2625         https://bugs.webkit.org/show_bug.cgi?id=195649
2626
2627         Reviewed by Youenn Fablet.
2628
2629         Update API test coverage.
2630
2631         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2632
2633 2019-03-13  Chris Dumez  <cdumez@apple.com>
2634
2635         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2636         https://bugs.webkit.org/show_bug.cgi?id=195684
2637         <rdar://problem/48294714>
2638
2639         Reviewed by Antti Koivisto.
2640
2641         Add API test coverage.
2642
2643         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2644
2645 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2646
2647         [ews-app] Remove unused patch view
2648         https://bugs.webkit.org/show_bug.cgi?id=195669
2649
2650         Reviewed by Lucas Forschler.
2651
2652         * BuildSlaveSupport/ews-app/ews/urls.py:
2653         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2654
2655 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2656
2657         [ews-app] Use Buildbot result code variables
2658         https://bugs.webkit.org/show_bug.cgi?id=195668
2659
2660         Reviewed by Alexey Proskuryakov.
2661
2662         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2663         (Buildbot): Added Buildbot result code variables.
2664         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2665         (StatusBubble._build_bubble): Used Buildbot result code variables.
2666
2667 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2668
2669         [Flatpak] Expand submodule recursively
2670         https://bugs.webkit.org/show_bug.cgi?id=195672
2671
2672         Building WPE with flatpak was impossible without that as it was raising an exception.
2673         Also update wpebackend-fdo to match what is built in jhbuild
2674
2675         Reviewed by Philippe Normand.
2676
2677         * flatpak/flatpakutils.py:
2678         (expand_submodules_recurse):
2679         (expand_manifest):
2680         * flatpak/org.webkit.WPEModules.yaml:
2681
2682 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2683
2684         [ews-app] status bubble should be hidden for certain builds
2685         https://bugs.webkit.org/show_bug.cgi?id=194597
2686
2687         Reviewed by Dewei Zhu.
2688
2689         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2690         (StatusBubble._build_bubble):
2691         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2692         because the patch didn't have relevant changes.
2693         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2694         in production yet.
2695
2696 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2697
2698         [Win] Fix a slew of simple clang-cl warnings.
2699         https://bugs.webkit.org/show_bug.cgi?id=195652
2700
2701         Reviewed by Don Olmstead.
2702
2703         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2704         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2705
2706 2019-03-12  Justin Fan  <justin_fan@apple.com>
2707
2708         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2709         https://bugs.webkit.org/show_bug.cgi?id=195518
2710         <rdar://problem/46322356>
2711
2712         Reviewed by Myles C. Maxfield.
2713
2714         * DumpRenderTree/DerivedSources-input.xcfilelist:
2715         * DumpRenderTree/DerivedSources-output.xcfilelist:
2716
2717 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2718
2719         Unreviewed, rolling out r242825.
2720         https://bugs.webkit.org/show_bug.cgi?id=195648
2721
2722         "Broke webkitpy tests with my change to
2723         lldb_dump_class_layout.py" (Requested by rmorisset on
2724         #webkit).
2725
2726         Reverted changeset:
2727
2728         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2729         classes with suspicious padding"
2730         https://bugs.webkit.org/show_bug.cgi?id=195573
2731         https://trac.webkit.org/changeset/242825
2732
2733 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2734
2735         [ews-build] Show status bubbles while the patch is waiting in queue
2736         https://bugs.webkit.org/show_bug.cgi?id=195618
2737
2738         Reviewed by Lucas Forschler.
2739
2740         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2741         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2742         enabled in initial deployment.
2743         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2744         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2745         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2746         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2747         (StatusBubble._build_bubbles_for_patch):
2748
2749 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2750
2751         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2752         https://bugs.webkit.org/show_bug.cgi?id=195573
2753
2754         Reviewed by Simon Fraser.
2755
2756         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2757
2758         * Scripts/dump-class-layout:
2759         (main):
2760         * lldb/lldb_dump_class_layout.py:
2761         (ClassLayout.__init__):
2762         (ClassLayout._compute_padding_recursive):
2763         (LLDBDebuggerInstance.dump_layout_for_classname):
2764         (LLDBDebuggerInstance):
2765         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2766         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2767
2768 2019-03-12  Chris Dumez  <cdumez@apple.com>
2769
2770         Device Orientation access permission should be denied unless explicitly granted by the client
2771         https://bugs.webkit.org/show_bug.cgi?id=195625
2772
2773         Reviewed by Youenn Fablet.
2774
2775         add API test coverage.
2776
2777         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2778         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2779         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2780         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2781         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2782         (runDeviceOrientationTest):
2783         (TEST):
2784         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2785         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2786
2787 2019-03-12  Jer Noble  <jer.noble@apple.com>
2788
2789         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2790         https://bugs.webkit.org/show_bug.cgi?id=195137
2791         <rdar://problem/48810307>
2792
2793         Reviewed by Eric Carlson.
2794
2795         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2796         (TestWebKitAPI::TEST):
2797
2798 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2799
2800         [ews-build] Change urls from uat to production
2801         https://bugs.webkit.org/show_bug.cgi?id=195566
2802
2803         Reviewed by Lucas Forschler.
2804
2805         * BuildSlaveSupport/ews-app/ews/config.py:
2806         * BuildSlaveSupport/ews-build/events.py:
2807         * BuildSlaveSupport/ews-build/steps.py:
2808
2809 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2810
2811         [ews-build] change max_builds for local-worker to 1
2812         https://bugs.webkit.org/show_bug.cgi?id=195568
2813
2814         Reviewed by Lucas Forschler.
2815
2816         * BuildSlaveSupport/ews-build/loadConfig.py:
2817
2818 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2819
2820         Fix the build
2821
2822         * TestRunnerShared/spi/PencilKitTestSPI.h:
2823         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2824
2825 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2826
2827         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2828         https://bugs.webkit.org/show_bug.cgi?id=194131
2829
2830         Reviewed by Michael Catanzaro.
2831
2832         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2833         (uriChanged):
2834         (testUnfinishedSubresourceLoad):
2835         (serverCallback):
2836         (beforeAll):
2837
2838 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2839
2840         WTF::Expected should use std::addressof instead of operator&
2841         https://bugs.webkit.org/show_bug.cgi?id=195604
2842
2843         Reviewed by Myles Maxfield.
2844
2845         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2846         (TestWebKitAPI::Unique::Unique):
2847         (TestWebKitAPI::Unique::operator&):
2848         (TestWebKitAPI::TEST):
2849
2850 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2851
2852         Add Optional to Forward.h.
2853         https://bugs.webkit.org/show_bug.cgi?id=195586
2854
2855         Reviewed by Darin Adler.
2856
2857         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2858         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2859         Remove unnecessary includes from headers.
2860
2861 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2862
2863         Add testing API to hit-test and scroll overflow scrollers
2864         https://bugs.webkit.org/show_bug.cgi?id=195278
2865
2866         Reviewed by Antti Koivisto.
2867         
2868         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2869         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2870         
2871         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2872
2873         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2874         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2875         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2876         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2877         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2878         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2879         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2880         (WTR::enclosingScrollViewIncludingSelf):
2881         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2882
2883 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2884
2885         API test WebKit.RequestTextInputContext fails on iOS
2886         https://bugs.webkit.org/show_bug.cgi?id=195585
2887
2888         Reviewed by Wenson Hsieh and Simon Fraser.
2889
2890         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2891         (applyStyle):
2892         (TEST):
2893         Add a viewport, so that the coordinates match up on iOS.
2894         Scroll by moving the UIScrollView's contentOffset.
2895
2896 2019-03-11  Chris Dumez  <cdumez@apple.com>
2897
2898         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2899         https://bugs.webkit.org/show_bug.cgi?id=195506
2900         <rdar://problem/48733477>
2901
2902         Reviewed by Alex Christensen.
2903
2904         Add API test coverage.
2905
2906         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2907
2908 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2909
2910         Adding myself to contributors.json
2911
2912         Unreviewed, addming myself to contributors.json .
2913
2914         * Scripts/webkitpy/common/config/contributors.json:
2915
2916 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2917
2918         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2919         https://bugs.webkit.org/show_bug.cgi?id=195511
2920         <rdar://problem/44873269>
2921
2922         Reviewed by Darin Adler.
2923
2924         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2925         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2926         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2927         (TEST_F):
2928
2929 2019-03-11  Chris Dumez  <cdumez@apple.com>
2930
2931         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2932         https://bugs.webkit.org/show_bug.cgi?id=195561
2933
2934         Reviewed by Youenn Fablet.
2935
2936         Make sure the JS in the test requests for permission to receive device orientation events.
2937
2938         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2939
2940 2019-03-11  Youenn Fablet  <youenn@apple.com>
2941
2942         Allow storage quota increase by default in WTR
2943         https://bugs.webkit.org/show_bug.cgi?id=195541
2944
2945         Reviewed by Geoffrey Garen.
2946
2947         Allow storage quota increase by default in WTR.
2948         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2949         Use this for tests that explicitly need cache increase.
2950
2951         Instead of increasing quota by 2, make sure the next request is
2952         granted by adding all given parameters.
2953
2954         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2955         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2956         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2957         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2958         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2959         * WebKitTestRunner/TestController.cpp:
2960         (WTR::TestController::setAllowStorageQuotaIncrease):
2961         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2962         * WebKitTestRunner/TestController.h:
2963         * WebKitTestRunner/TestInvocation.cpp:
2964         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2965         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2966         (WTR::TestController::cocoaResetStateToConsistentValues):
2967         (WTR::TestController::setAllowStorageQuotaIncrease):
2968         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2969         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2970         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2971
2972 2019-03-11  Xan Lopez  <xan@igalia.com>
2973
2974         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2975         https://bugs.webkit.org/show_bug.cgi?id=194147
2976
2977         Reviewed by Michael Saboff.
2978
2979         To make --32-bit work correctly on Linux/64bit we need to:
2980
2981         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2982         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2983         unfortunately CMake only allows us to do this during
2984         crosscompilation, which is overkill here.
2985         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2986         pkg-config detection module uses the x86 .pc files instead of the
2987         x86_64 ones.
2988         - Set the -m32 flags for the compiler.
2989
2990         * Scripts/webkitdirs.pm:
2991         (generateBuildSystemFromCMakeProject):
2992
2993 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2994
2995         Add MotionMark-1.1 plan file for run-benchmark script.
2996         https://bugs.webkit.org/show_bug.cgi?id=195481
2997
2998         Rubber-stamped by Darin Adler.
2999
3000         Run-benchmark script should support MontionMark-1.1.
3001
3002         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3003
3004 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3005
3006         [ews-app] Add support for submit-to-ews url
3007         https://bugs.webkit.org/show_bug.cgi?id=195477
3008
3009         Reviewed by Lucas Forschler.
3010
3011         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3012         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3013         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3014         * BuildSlaveSupport/ews-app/ews/urls.py:
3015         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3016
3017 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3018
3019         Unreviewed, rolling out r242688, r242643, r242624.
3020
3021         Caused multiple layout test failures and crashes on iOS and macOS.
3022
3023         Reverted changeset:
3024
3025         "requestAnimationFrame should execute before the next frame"
3026         https://bugs.webkit.org/show_bug.cgi?id=177484
3027         https://trac.webkit.org/changeset/242624/webkit
3028
3029         * Tracing/SystemTracePoints.plist:
3030
3031 2019-03-11  John Wilander  <wilander@apple.com>
3032
3033         Resource Load Statistics: Make it possible exclude localhost from classification
3034         https://bugs.webkit.org/show_bug.cgi?id=195474
3035         <rdar://problem/47520577>
3036
3037         Reviewed by Brent Fulgham.
3038
3039         This patch allows for localhost to be excluded from classification and
3040         treatment as a prevalent resource.
3041
3042         The WebKit Tools change adds a new function called
3043         testRunner.setStatisticsIsRunningTest() which can be used to control this
3044         behavior.
3045
3046         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3047         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3048         (WTR::TestRunner::setStatisticsIsRunningTest):
3049         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3050         * WebKitTestRunner/TestController.cpp:
3051         (WTR::TestController::setStatisticsIsRunningTest):
3052         * WebKitTestRunner/TestController.h:
3053         * WebKitTestRunner/TestInvocation.cpp:
3054         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3055
3056 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3057
3058         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3059         https://bugs.webkit.org/show_bug.cgi?id=195560
3060
3061         Reviewed by Lucas Forschler.
3062
3063         * BuildSlaveSupport/ews-build/master.cfg:
3064
3065 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3066
3067         Unreviewed, rolling out r242698.
3068
3069         API test crashes on bots.
3070
3071         Reverted changeset:
3072
3073         "Add a WKContentRuleList variant that uses copied memory
3074         instead of mmap'd shared memory for class A containerized
3075         apps"
3076         https://bugs.webkit.org/show_bug.cgi?id=195511
3077         https://trac.webkit.org/changeset/242698
3078
3079 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3080
3081         [WPE] Enable web process sandbox
3082         https://bugs.webkit.org/show_bug.cgi?id=195169
3083
3084         Reviewed by Daniel Bates.
3085
3086         * wpe/install-dependencies:
3087         * wpe/jhbuild.modules:
3088
3089 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3090
3091         [ews-app] Use port 17000 for worker communication
3092         https://bugs.webkit.org/show_bug.cgi?id=195558
3093
3094         Reviewed by Lucas Forschler.
3095
3096         * BuildSlaveSupport/ews-build/master.cfg:
3097
3098 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3099
3100         [ews-build] unit-tests fail when passwords.json is missing
3101         https://bugs.webkit.org/show_bug.cgi?id=195557
3102
3103         Reviewed by Lucas Forschler.
3104
3105         * BuildSlaveSupport/ews-build/loadConfig.py:
3106         (loadBuilderConfig):
3107         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3108         (ConfigDotJSONTest.test_configuration):
3109         * BuildSlaveSupport/ews-build/master.cfg:
3110
3111 2019-03-11  Truitt Savell  <tsavell@apple.com>
3112
3113         Unreviewed, rolling out r242702.
3114
3115         Broke High Sierra builders.
3116
3117         Reverted changeset:
3118
3119         "Add utility function to allow easy reverse range-based
3120         iteration of a container"
3121         https://bugs.webkit.org/show_bug.cgi?id=195542
3122         https://trac.webkit.org/changeset/242702
3123
3124 2019-03-11  Sam Weinig  <sam@webkit.org>
3125
3126         Add utility function to allow easy reverse range-based iteration of a container
3127         https://bugs.webkit.org/show_bug.cgi?id=195542
3128
3129         Reviewed by Antti Koivisto.
3130
3131         * TestWebKitAPI/CMakeLists.txt:
3132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3133         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3134         (TestWebKitAPI::TEST):
3135         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3136
3137 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3138
3139         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3140         https://bugs.webkit.org/show_bug.cgi?id=195511
3141         <rdar://problem/44873269>
3142
3143         Reviewed by Darin Adler.
3144
3145         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3146         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3147         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3148         (TEST_F):
3149
3150 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3151
3152         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3153         https://bugs.webkit.org/show_bug.cgi?id=195499
3154
3155         Reviewed by Darin Adler.
3156
3157         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3158         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3159         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3160         (-[WKWebView synchronouslyFocusTextInputContext:]):
3161         (applyStyle):
3162         (applyIframe):
3163         (TEST):
3164         Add some tests for this SPI.
3165
3166 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3167
3168         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3169         https://bugs.webkit.org/show_bug.cgi?id=181151
3170
3171         Reviewed by Don Olmstead.
3172
3173         * TestWebKitAPI/CMakeLists.txt:
3174         * TestWebKitAPI/PlatformWin.cmake:
3175         Enable TestWTF RunLoop tests in all platforms.
3176
3177         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3178         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3179         (TestWebKitAPI::DerivedOneShotTimer::fired):
3180         (TestWebKitAPI::TEST):
3181         Only a few platforms support nested RunLoop.
3182
3183         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3184         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3185
3186 2019-03-10  David Quesada  <david_quesada@apple.com>
3187
3188         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3189         https://bugs.webkit.org/show_bug.cgi?id=152480
3190
3191         Reviewed by Chris Dumez.
3192
3193         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3194         there are no additional references to the process pool besides the one held by
3195         the download, waits for the download to finish (in the sense that the
3196         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3197         measure, also check that the process pool has been deallocated at the end of the
3198         test. The test wouldn't be meaningful if the process pool were still alive.
3199
3200         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3201         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3202         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3203             The download will be canceled because the delegate does not implement the
3204             method to decide the download's destination, so this is where we know the
3205             DownloadProxyMap is done with the DownloadProxy.
3206         (TEST):
3207
3208 2019-03-08  Chris Dumez  <cdumez@apple.com>
3209
3210         Add support for Device Orientation / Motion permission API
3211         https://bugs.webkit.org/show_bug.cgi?id=195329
3212         <rdar://problem/47645367>
3213
3214         Reviewed by Geoffrey Garen.
3215
3216         Add test infrastructure to help test the Device Orientation / Motion permission API.
3217
3218         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3219         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3220         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3221         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3222         * WebKitTestRunner/TestController.cpp:
3223         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3224         (WTR::TestController::createWebViewWithOptions):
3225         (WTR::TestController::resetStateToConsistentValues):
3226         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3227         * WebKitTestRunner/TestController.h:
3228         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3229         * WebKitTestRunner/TestInvocation.cpp:
3230         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3231
3232 2019-03-08  Saam barati  <sbarati@apple.com>
3233
3234         Add a compare-results script to compare benchmark results
3235         https://bugs.webkit.org/show_bug.cgi?id=195486
3236         <rdar://problem/48723397>
3237
3238         Reviewed by Geoffrey Garen.
3239
3240         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3241         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3242         to extend it to learn about our other benchmarks.
3243
3244         * Scripts/compare-results: Added.
3245         (readJSONFile):
3246         (detectJetStream2):
3247         (JetStream2Results):
3248         (detectSpeedometer2):
3249         (Speedometer2Results):
3250         (detectPLT5):
3251         (PLT5Results):
3252         (detectBenchmark):
3253         (biggerIsBetter):
3254         (ttest):
3255         (getOptions):
3256         (main):
3257
3258 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3259
3260         Ensure old tab state is cleared between iterations of run-benchmark
3261         https://bugs.webkit.org/show_bug.cgi?id=195393
3262         <rdar://problem/46885583>
3263
3264         Reviewed by Dewei Zhu.
3265
3266         a) ensure the default to restore state is not set
3267         b) terminate Safari correctly
3268         c) Set the system default to ignore Persistent State in Safari
3269
3270         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3271         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3272         (OSXBrowserDriver.prepare_env): 
3273         (OSXBrowserDriver.restore_env):
3274         (OSXBrowserDriver.close_browsers):
3275         (OSXBrowserDriver._terminate_processes):
3276         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3277         (OSXChromeDriver):
3278         (OSXChromeCanaryDriver):
3279         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3280         (OSXFirefoxDriver):
3281         (OSXFirefoxNightlyDriver):
3282         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3283         (OSXSafariDriver):
3284         (OSXSafariDriver.prepare_env):
3285
3286 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3287
3288         [GTK] Several InputMethodFilter tests are failing
3289         https://bugs.webkit.org/show_bug.cgi?id=195408
3290
3291         Reviewed by Carlos Garcia Campos.
3292
3293         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3294         Regressed in r241751.
3295         Hexadecimal values of keycodes are expressed now in upper letters.
3296         Composited characters should be cast to UTF8 strings.
3297
3298         (TestWebKitAPI::TEST):
3299
3300 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3301
3302         [GTK] Make Tools/gtkdoc python3 compatible
3303         https://bugs.webkit.org/show_bug.cgi?id=195359
3304
3305         Reviewed by Carlos Garcia Campos.
3306
3307         * gtkdoc/generate-gtkdoc:
3308         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3309         work with Python 2 and 3.
3310         (get_gtkdoc_module_paths):
3311         The iteritems() was removed in Python 3, so let's use items() that's
3312         available in Python 2 and 3.
3313         (get_generator_for_config):
3314         * gtkdoc/gtkdoc.py:
3315         (GTKDoc._run_command):
3316         The sys.stdout.write() is expecting str in Python 3 and not bytes
3317         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3318         for passing the bytes there.
3319
3320 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3321
3322         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3323         https://bugs.webkit.org/show_bug.cgi?id=195346
3324         <rdar://problem/48667048>
3325
3326         Unreviewed build fix for clang-cl.
3327
3328         * DumpRenderTree/win/DumpRenderTree.cpp:
3329         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3330
3331 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3332
3333         requestAnimationFrame should execute before the next frame
3334         https://bugs.webkit.org/show_bug.cgi?id=177484
3335
3336         Reviewed by Simon Fraser.
3337
3338         Add trace points for the page RenderingUpdate.
3339
3340         * Tracing/SystemTracePoints.plist:
3341
3342 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3343
3344         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3345         https://bugs.webkit.org/show_bug.cgi?id=195353
3346         <rdar://problem/48626394>
3347
3348         Reviewed by Simon Fraser.
3349
3350         * WebKitTestRunner/ios/TestControllerIOS.mm:
3351         (WTR::TestController::platformResetPreferencesToConsistentValues):
3352
3353 2019-03-07  John Wilander  <wilander@apple.com>
3354
3355         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3356         https://bugs.webkit.org/show_bug.cgi?id=195383
3357         <rdar://problem/48570136>
3358
3359         Reviewed by Brent Fulgham.
3360
3361         This patch adds test infrastructure to purge only script-accessible cookies,
3362         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3363
3364         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3365         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3366         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3367         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3368         * WebKitTestRunner/TestController.cpp:
3369         (WTR::TestController::statisticsDeleteCookiesForHost):
3370         * WebKitTestRunner/TestController.h:
3371         * WebKitTestRunner/TestInvocation.cpp:
3372         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3373
3374 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3375
3376         Unreviewed, rolling out r242354.
3377         https://bugs.webkit.org/show_bug.cgi?id=195402
3378
3379         breaks layout tests in all configurations (Requested by
3380         zdobersek on #webkit).
3381
3382         Reverted changeset:
3383
3384         "[WPE] Enable web process sandbox"
3385         https://bugs.webkit.org/show_bug.cgi?id=195169
3386         https://trac.webkit.org/changeset/242354
3387
3388 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3389
3390         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3391         https://bugs.webkit.org/show_bug.cgi?id=195346
3392
3393         Reviewed by Fujii Hironori.
3394
3395         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3396         (TestWebKitAPI::TEST):
3397         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3398
3399         * DumpRenderTree/win/DumpRenderTree.cpp:
3400         (findFontFallback):
3401         (addFontFallbackIfPresent):
3402         (removeFontFallbackIfPresent):
3403         (main):
3404         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3405         (TestWebKitAPI::Util::moduleDirectory):
3406         (TestWebKitAPI::Util::createInjectedBundlePath):
3407         Use wchar helpers as needed.
3408
3409 2019-03-06  Rob Buis  <rbuis@igalia.com>
3410
3411         Consider supporting the `referrerpolicy` attribute.
3412         https://bugs.webkit.org/show_bug.cgi?id=179053
3413
3414         Reviewed by Darin Adler.
3415
3416         Add a runtime flag for referrerpolicy attribute.
3417
3418         * DumpRenderTree/mac/DumpRenderTree.mm:
3419         (enableExperimentalFeatures):
3420
3421 2019-03-05  Daniel Bates  <dabates@apple.com>
3422
3423         Update expected API test result following r242379
3424         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3425
3426         Update expected x-coordinate of selection rect now that the left padding of
3427         a textarea is sized in ems (so dependent on the font size) just like the left
3428         padding of a text field.
3429
3430         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3431         (TestWebKitAPI::TEST):
3432
3433 2019-03-05  David Quesada  <david_quesada@apple.com>
3434
3435         [WK2] It should be possible to follow links with 'download' attributes
3436         https://bugs.webkit.org/show_bug.cgi?id=195145
3437         rdar://problem/48462642
3438
3439         Reviewed by Alex Christensen.
3440
3441         Add a unit test to verify that activating links with 'download' attributes now
3442         navigates to the linked resource, rather than starts downloading it. Add another
3443         to verify that it is still possible to explicitly download the link via the
3444         'Download' navigation action policy.
3445
3446         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3447         (-[DownloadAttributeTestDelegate init]):
3448         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3449         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3450         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3451         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3452         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3453         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3454         (TEST):
3455         * WebKitTestRunner/TestController.cpp:
3456         (WTR::TestController::decidePolicyForNavigationAction):
3457         * WebKitTestRunner/TestController.h:
3458
3459 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3460
3461         [Curl] Implement Cookie Accept Policy.
3462         https://bugs.webkit.org/show_bug.cgi?id=191645
3463
3464         Reviewed by Fujii Hironori.
3465
3466         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3467         (TestWebKitAPI::Curl::TEST_F):
3468
3469 2019-03-05  Youenn Fablet  <youenn@apple.com>
3470
3471         Rename requestCacheStorageSpace to requestStorageSpace
3472         https://bugs.webkit.org/show_bug.cgi?id=195282
3473
3474         Reviewed by Chris Dumez.
3475
3476         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3477         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3478         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3479
3480 2019-03-05  Brady Eidson  <beidson@apple.com>
3481
3482         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3483         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3484
3485         Reviewed by Tim Horton.
3486
3487         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3488         different directory into that same WKWebView should work.
3489
3490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3491         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3492
3493 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3494
3495         Add WeakHashSet
3496         https://bugs.webkit.org/show_bug.cgi?id=195152
3497
3498         Reviewed by Antti Koivisto.
3499
3500         Added tests for WeakHashSet.
3501
3502         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3503         (TestWebKitAPI::Base::Base): Moved.
3504         (TestWebKitAPI::Derived::foo): Moved.
3505         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3506         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3507         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3508         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3509
3510 2019-03-04  Chris Dumez  <cdumez@apple.com>
3511
3512         Do not share WebProcesses between private and regular sessions
3513         https://bugs.webkit.org/show_bug.cgi?id=195189
3514         <rdar://problem/48421064>
3515
3516         Reviewed by Alex Christensen.
3517
3518         Add API test coverage.
3519
3520         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3521         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3522
3523 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3524
3525         [WPE] Enable web process sandbox
3526         https://bugs.webkit.org/show_bug.cgi?id=195169
3527
3528         Reviewed by Daniel Bates.
3529
3530         * wpe/install-dependencies:
3531         * wpe/jhbuild.modules:
3532
3533 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3534
3535         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3536         https://bugs.webkit.org/show_bug.cgi?id=195206
3537
3538         Reviewed by Žan Doberšek.
3539
3540         Add a new test case.
3541
3542         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3543         (testJSCClass):
3544
3545 2019-03-04  Charlie Turner  <cturner@igalia.com>
3546
3547         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3548         https://bugs.webkit.org/show_bug.cgi?id=194898
3549
3550         Reviewed by Žan Doberšek.
3551
3552         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3553         a GCC extension that permits arithmetic on void* pointer. Inline
3554         the macro until this issue is fixed upstream.
3555
3556 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3557
3558         Rid the world of WK_API_ENABLED
3559         https://bugs.webkit.org/show_bug.cgi?id=195263
3560
3561         Reviewed by Dan Bernstein.
3562
3563         List of changed files elided because it's useless.
3564
3565 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3566
3567         Unreviewed follow-up to r242292.
3568
3569         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3570
3571         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3572         (TestWebKitAPI::testStrip): Renamed from strip.
3573         (TestWebKitAPI::TEST):
3574
3575 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3576
3577         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3578
3579         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3580         and bug #194272 for details.
3581
3582         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3583
3584 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3585
3586         Remove some more unused 32-bit code
3587         https://bugs.webkit.org/show_bug.cgi?id=195255
3588
3589         Reviewed by Darin Adler.
3590
3591         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3592         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3593         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3594         (NPP_New):
3595         (NPP_HandleEvent):
3596         (handleEventCarbon): Deleted.
3597
3598 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3599
3600         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3601
3602         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3603         (TestWebKitAPI::TEST):
3604
3605 2019-03-01  Darin Adler  <darin@apple.com>
3606
3607         Finish removing String::format
3608         https://bugs.webkit.org/show_bug.cgi?id=194893
3609
3610         Reviewed by Daniel Bates.
3611 '
3612         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3613
3614 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3615
3616         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3617         https://bugs.webkit.org/show_bug.cgi?id=195229
3618         <rdar://problem/48520362>
3619
3620         Reviewed by Chris Dumez.
3621
3622         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3623         (TEST):
3624
3625 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3626
3627         Add a system trace scope for event region building
3628         https://bugs.webkit.org/show_bug.cgi?id=195226
3629
3630         Reviewed by Jon Lee.
3631
3632         This trace scope measures the time spend converting element rects into Region objects,
3633         which can be large on some pages.
3634
3635         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3636
3637         * Tracing/SystemTracePoints.plist:
3638
3639 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3640
3641         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3642         https://bugs.webkit.org/show_bug.cgi?id=194612
3643
3644         Reviewed by Alex Christensen.
3645
3646         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3647         Just test the new string-processing function and don't touch the actual environment.
3648         (Test cases are all as before, but based on operator== instead of strcmp.)
3649
3650 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3651
3652         [ews-app] Update primary keys for handling multiple Buildbot instances
3653         https://bugs.webkit.org/show_bug.cgi?id=195120
3654
3655         Reviewed by Stephanie Lewis.
3656
3657         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3658         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3659         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3660
3661         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3662         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3663         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3664         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3665         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3666         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3667
3668 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3669
3670         [WinCairo] Enable service worker
3671         https://bugs.webkit.org/show_bug.cgi?id=188318
3672
3673         Reviewed by Youenn Fablet.
3674
3675         * DumpRenderTree/DumpRenderTreePrefix.h:
3676         * TestWebKitAPI/PlatformWin.cmake:
3677         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3678         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3679         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3680
3681 2019-03-01  Justin Fan  <justin_fan@apple.com>
3682
3683         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3684         https://bugs.webkit.org/show_bug.cgi?id=195191
3685
3686         Rubber-stamped by Dean Jackson.
3687
3688         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3689
3690         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3691
3692 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3693
3694         Unreviewed, fix lldb webkitpy tests
3695         https://bugs.webkit.org/show_bug.cgi?id=194375
3696
3697         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3698
3699         * lldb/lldb_webkit.py:
3700         (WTFStringImplProvider.is_8bit):
3701
3702 2019-02-28  David Quesada  <david_quesada@apple.com>
3703
3704         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3705         https://bugs.webkit.org/show_bug.cgi?id=195121
3706         rdar://problem/48450302
3707
3708         Reviewed by Alex Christensen.
3709
3710         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3711         configurations where the 'download' attribute is absent, blank, or populated
3712         with a filename, and where the anchor element is same-origin or cross-origin
3713         (meaning the 'download' attribute shouldn't be honored).
3714
3715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3716         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3717         (-[NavigationActionTestDelegate init]):
3718         (-[NavigationActionTestDelegate navigationAction]):
3719         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3720         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3721         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3722         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3723         (TEST):
3724
3725 2019-02-28  Antoine Quint  <graouts@apple.com>
3726
3727         Enable the Pointer Events runtime flag by default
3728         https://bugs.webkit.org/show_bug.cgi?id=195156
3729
3730         Reviewed by Dean Jackson.
3731
3732         * DumpRenderTree/mac/DumpRenderTree.mm:
3733         (enableExperimentalFeatures):
3734
3735 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3736
3737         Several PasteImage API tests are flaky
3738         https://bugs.webkit.org/show_bug.cgi?id=195160
3739
3740         Reviewed by Tim Horton.
3741
3742         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3743         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3744         listening for a "load" event after image load is already complete.
3745
3746         To address this, make these tests first register a "load" event handler, then run script to insert an image
3747         element into the document, and finally wait until the load event is observed before checking image size.
3748
3749         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3750
3751 2019-02-28  Chris Dumez  <cdumez@apple.com>
3752
3753         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3754         https://bugs.webkit.org/show_bug.cgi?id=195107
3755
3756         Reviewed by Alex Christensen.
3757
3758         Give some time for the zoom level to get restored.
3759
3760         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3761
3762 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3763
3764         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3765         https://bugs.webkit.org/show_bug.cgi?id=194958
3766
3767         Reviewed by Geoffrey Garen.
3768
3769         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3770         (TEST):
3771
3772 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3773
3774         [ews-app] Update method to save build to handle builder_display_name
3775         https://bugs.webkit.org/show_bug.cgi?id=195047
3776
3777         Reviewed by Dewei Zhu.
3778
3779         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3780         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3781
3782 2019-02-28  Justin Fan  <justin_fan@apple.com>
3783
3784         [Web GPU] Enable Web GPU only on 64-bit
3785         https://bugs.webkit.org/show_bug.cgi?id=195139
3786
3787         Because Metal is only supported on 64 bit apps.
3788
3789         Unreviewed build fix.
3790
3791         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3792
3793 2019-02-27  Youenn Fablet  <youenn@apple.com>
3794
3795         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3796         https://bugs.webkit.org/show_bug.cgi?id=194959
3797
3798         Reviewed by Chris Dumez.
3799
3800         Spin loop until getting the condition to remove flakiness.
3801
3802         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3803
3804 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3805
3806         [ews-build] Buildbot should include builder_display_name in the build events
3807         https://bugs.webkit.org/show_bug.cgi?id=195045
3808
3809         Reviewed by Dewei Zhu.
3810
3811         * BuildSlaveSupport/ews-build/events.py:
3812         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3813         buildername to builder_name to be consistent in naming style.
3814         (Events.buildFinished): Ditto.
3815
3816 2019-02-27  Chris Dumez  <cdumez@apple.com>
3817
3818         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3819         https://bugs.webkit.org/show_bug.cgi?id=194480
3820
3821         Reviewed by Brady Eidson.
3822
3823         Update existing API test to make it more likely to reproduce the issue.
3824
3825         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3826
3827 2019-02-27  Brady Eidson  <beidson@apple.com>
3828
3829         Universal links from Google search results pages don't open the app.
3830         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3831
3832         Reviewed by Geoffrey Garen.
3833
3834         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3835         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3836         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3837         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3838
3839 2019-02-27  Chris Dumez  <cdumez@apple.com>
3840
3841         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3842         https://bugs.webkit.org/show_bug.cgi?id=195102
3843
3844         Reviewed by Geoffrey Garen.
3845
3846         If the number of processes is not yet what we expect, wait a bit and check again to give
3847         processes some time to exit.
3848
3849         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3850
3851 2019-02-27  Chris Dumez  <cdumez@apple.com>
3852
3853         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3854         https://bugs.webkit.org/show_bug.cgi?id=194545
3855
3856         Reviewed by Brady Eidson.
3857
3858         Make sure the test navigates forward and then back only once. Previously, navigating
3859         back would trigger a navigation again in a timer.
3860
3861         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3862
3863 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3864
3865         High Sierra Debug JSC test queue should use faster hardware
3866         https://bugs.webkit.org/show_bug.cgi?id=194603
3867
3868         Rubber-stamped by Alexey Proskuryakov.
3869
3870         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3871
3872         * BuildSlaveSupport/build.webkit.org-config/config.json:
3873         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3874         (BubbleQueueServer):
3875         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3876         (WebKitBuildbot):
3877         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3878         * QueueStatusServer/config/queues.py:
3879         * Scripts/webkitpy/common/config/ews.json:
3880         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3881         (test_ews_name):
3882
3883 2019-02-27  John Wilander  <wilander@apple.com>
3884
3885         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3886         https://bugs.webkit.org/show_bug.cgi?id=195071
3887         <rdar://problem/48417690>
3888
3889         Reviewed by Alex Christensen and Brent Fulgham.
3890
3891         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3892         (TestWebKitAPI::createURL):
3893             Convenience function.
3894         (TestWebKitAPI::TEST):
3895             WebCore::AdClickAttribution now takes a URL when creating Source and
3896             Destination.
3897         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3898         (TestWebKitAPI::TEST):
3899             WebCore::AdClickAttribution now takes a URL when creating Source and
3900             Destination.
3901
3902 2019-02-27  Antoine Quint  <graouts@apple.com>
3903
3904         Support Pointer Events on macOS
3905         https://bugs.webkit.org/show_bug.cgi?id=195008
3906         <rdar://problem/47454419>
3907
3908         Reviewed by Dean Jackson.
3909
3910         * DumpRenderTree/mac/DumpRenderTree.mm:
3911         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3912         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3913
3914 2019-02-26  Mark Lam  <mark.lam@apple.com>
3915
3916         Remove remaining poisoning code.
3917         https://bugs.webkit.org/show_bug.cgi?id=194138
3918
3919         Reviewed by Saam Barati.
3920
3921         * TestWebKitAPI/CMakeLists.txt:
3922         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3923         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3924         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3925         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3926         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3927         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3928         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3929
3930 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3931
3932         Move ephemeral local storage from WebProcess to UIProcess
3933         https://bugs.webkit.org/show_bug.cgi?id=195074
3934         <rdar://problem/47937975>
3935
3936         Reviewed by Geoff Garen.
3937
3938         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3939
3940 2019-02-20  Jer Noble  <jer.noble@apple.com>
3941
3942         [Cocoa] Media elements will restart network buffering just before suspending
3943         https://bugs.webkit.org/show_bug.cgi?id=193691
3944
3945         Reviewed by Eric Carlson.
3946
3947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3948         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3949         (TEST):
3950
3951 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3952
3953         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3954         https://bugs.webkit.org/show_bug.cgi?id=191652
3955
3956         Reviewed by Alex Christensen.
3957
3958         Fix WinCairo MiniBrowser behavior of authentication dialog.
3959
3960         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3961         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3962
3963 2019-02-26  Youenn Fablet  <youenn@apple.com>
3964
3965         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3966         https://bugs.webkit.org/show_bug.cgi?id=195028
3967         <rdar://problem/48243733>
3968
3969         Reviewed by Eric Carlson.
3970
3971         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3972
3973 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3974
3975         [WPE] Add API for webview background color configuration
3976         https://bugs.webkit.org/show_bug.cgi?id=192305
3977
3978         Reviewed by Michael Catanzaro.
3979
3980         * MiniBrowser/wpe/main.cpp:
3981         (main): Add a new option to configure the webview background
3982         color. Example: --bg-color=transparent.
3983         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3984         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3985         (beforeAll): Ditto.
3986
3987 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3988
3989         scalableNativeWebpageParameters() is not preserved on new page navigation.
3990         https://bugs.webkit.org/show_bug.cgi?id=194892
3991         <rdar://problem/47538280>
3992
3993         Reviewed by Wenson Hsieh.
3994         
3995         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3996
3997         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3998         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3999         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4000         (WTR::UIScriptController::allowsViewportShrinkToFit):
4001         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4002         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4003         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4004         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4005         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4006         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4007
4008 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4009
4010         [ews-app] Add model for handling multiple Buildbot instances
4011         https://bugs.webkit.org/show_bug.cgi?id=194863
4012
4013         Reviewed by Stephanie Lewis.
4014
4015         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4016
4017 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4018
4019         [ews-app] Remove BuilderMapping table
4020         https://bugs.webkit.org/show_bug.cgi?id=194961
4021
4022         Reviewed by Stephanie Lewis.
4023
4024         Store builder name directly in build table, instead of having a separate
4025         table for it.
4026
4027         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4028         * BuildSlaveSupport/ews-app/ews/models/build.py:
4029         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4030         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4031
4032 2019-02-25  John Wilander  <wilander@apple.com>
4033
4034         Introduce and adopt new class RegistrableDomain for eTLD+1
4035         https://bugs.webkit.org/show_bug.cgi?id=194791
4036         <rdar://problem/48179240>
4037
4038         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4039
4040         This patch adds an API test and replaces two instances of
4041         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4042
4043         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4044         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4045         (TestWebKitAPI::TEST):
4046             Changed two strings to make sure the registrable domains are still considered
4047             invalid and pass the test.
4048         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4049         (TestWebKitAPI::TEST):
4050         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4051         (WTR::InjectedBundle::didReceiveMessageToPage):
4052
4053 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4054
4055         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4056         https://bugs.webkit.org/show_bug.cgi?id=195001
4057
4058         Reviewed by Carlos Garcia Campos.
4059
4060         API version 1.0 always includes the functionality previously guarded with
4061         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4062         unconditionally.
4063
4064         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4065         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4066         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4067         (WebViewTest::showInWindow): Ditto.
4068         (WebViewTest::hideView): Ditto.
4069         * wpe/backends/HeadlessViewBackend.cpp:
4070         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4071         * wpe/backends/ViewBackend.cpp:
4072         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4073         * wpe/backends/WindowViewBackend.cpp:
4074         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4075         WPE_BACKEND_CHECK_VERSION().
4076         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4077
4078 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4079
4080         [Flatpak] Add support for flatpak > 1.1.2
4081         https://bugs.webkit.org/show_bug.cgi?id=194088
4082
4083         Flatpak 1.2 is now out so we need to support that
4084         version now.
4085
4086         Reviewed by Michael Catanzaro.
4087
4088         * flatpak/flatpakutils.py:
4089         (check_flatpak):
4090         (FlatpakPackages.__init__):
4091         (FlatpakPackages.__detect_packages):
4092         (FlatpakPackages.__detect_packages.in):
4093         (FlatpakRepos.update):
4094
4095 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4096
4097         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4098         https://bugs.webkit.org/show_bug.cgi?id=194998
4099
4100         Reviewed by Carlos Garcia Campos.
4101
4102         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4103         to a Git checkout and using the latest commit containing various fixes
4104         and improvements.
4105
4106 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4107
4108         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4109         https://bugs.webkit.org/show_bug.cgi?id=194981
4110
4111         Reviewed by Žan Doberšek.
4112
4113         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4114         (TestWebKitAPI::TEST):
4115
4116 2019-02-23  Keith Miller  <keith_miller@apple.com>
4117
4118         Add new mac target numbers
4119         https://bugs.webkit.org/show_bug.cgi?id=194955
4120
4121         Reviewed by Tim Horton.
4122
4123         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4124         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4125         * MiniBrowser/Configurations/Base.xcconfig:
4126         * TestWebKitAPI/Configurations/Base.xcconfig:
4127         * WebKitTestRunner/Configurations/Base.xcconfig:
4128
4129 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4130
4131         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4132         https://bugs.webkit.org/show_bug.cgi?id=194846
4133
4134         Reviewed by Don Olmstead.
4135
4136         Added _search_paths() and _port_specific_expectations_files() for
4137         WinCairoPort.
4138
4139         * Scripts/webkitpy/port/win.py:
4140         (WinCairoPort.default_baseline_search_path):
4141         (WinCairoPort):
4142         (WinCairoPort._port_specific_expectations_files):
4143         (WinCairoPort._search_paths):
4144
4145 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4146
4147         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4148         https://bugs.webkit.org/show_bug.cgi?id=194963
4149
4150         Reviewed by Dean Jackson.
4151
4152         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4153         Do a `contains` check instead of `equals`, because in debug builds we
4154         put the GraphicsLayer pointer in a prefix.
4155
4156 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4157
4158         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4159         https://bugs.webkit.org/show_bug.cgi?id=194873
4160         <rdar://problem/46701974>
4161
4162         Reviewed by Tim Horton.
4163
4164         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4165
4166         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4167         (WTR::UIScriptController::menuRect const):
4168         (WTR::UIScriptController::isShowingMenu const):
4169         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4170         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4171         (WTR::UIScriptController::menuRect const):
4172
4173         Add a function to query the bounds of the callout menu in content coordinates.
4174
4175         (WTR::UIScriptController::isShowingMenu const):
4176
4177         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4178
4179         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4180         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4181         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4182         (WTR::UIScriptController::rectForMenuAction const):
4183         (WTR::UIScriptController::menuRect const):
4184         (WTR::UIScriptController::isShowingMenu const):
4185         (WTR::findViewInHierarchyOfType): Deleted.
4186
4187 2019-02-22  Chris Dumez  <cdumez@apple.com>
4188
4189         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4190         https://bugs.webkit.org/show_bug.cgi?id=194954
4191         <rdar://problem/48127957>
4192
4193         Reviewed by Alex Christensen.
4194
4195         Add API test coverage.
4196
4197         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4198         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4199         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4200         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4201
4202 2019-02-22  Chris Dumez  <cdumez@apple.com>
4203
4204         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4205         https://bugs.webkit.org/show_bug.cgi?id=194924
4206         <rdar://problem/48216125>
4207
4208         Reviewed by Geoffrey Garen.
4209
4210         Add API test coverage.
4211
4212         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4213
4214 2019-02-22  Chris Dumez  <cdumez@apple.com>
4215
4216         Unreviewed, disable API test added in r241928 on iOS.
4217
4218         The cache is not enabled on devices with less than 3GB of RAM.
4219
4220         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4221
4222 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4223
4224         Hardcode Visual Viewports on everywhere except iOS WK1
4225         https://bugs.webkit.org/show_bug.cgi?id=194928
4226
4227         Reviewed by Zalan Bujtas.
4228
4229         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4230         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4231         set it to false. The setting has shipped for several years and there's no need to turn
4232         it off now.
4233
4234         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4235         Visual Viewports are not enabled.
4236         
4237         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4238         that only runs in WK2
4239
4240         * MiniBrowser/mac/SettingsController.h:
4241         * MiniBrowser/mac/SettingsController.m:
4242         (-[SettingsController init]):
4243         (-[SettingsController _populateMenu]):
4244         (-[SettingsController validateMenuItem:]):
4245         (-[SettingsController visualViewportEnabled]): Deleted.
4246         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4247         * MiniBrowser/mac/WK1BrowserWindowController.m:
4248         (-[WK1BrowserWindowController didChangeSettings]):
4249         * MiniBrowser/mac/WK2BrowserWindowController.m:
4250         (-[WK2BrowserWindowController didChangeSettings]):
4251
4252 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4253
4254         Discard cached processes when clearing website data store
4255         https://bugs.webkit.org/show_bug.cgi?id=194894
4256
4257         Reviewed by Chris Dumez.
4258
4259         Added a test case.
4260
4261         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4262         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4263
4264 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4265
4266         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4267         https://bugs.webkit.org/show_bug.cgi?id=194914
4268         <rdar://problem/47586889>
4269
4270         Reviewed by Geoffrey Garen.
4271
4272         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4273         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4274         (TEST):
4275         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4276
4277 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4278
4279         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4280         <https://webkit.org/b/194761>
4281
4282         Reviewed by Myles Maxfield.
4283
4284         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4285         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4286         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4287         to use ARC-compliant cast.
4288         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4289         ARC-compliant cast.
4290         (WTR::installFakeHelvetica): Log `error` to console if
4291         CTFontManagerRegisterFontsForURL() fails, but only on supported
4292         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4293         Call CFRelease() on `error` to fix the leak.  Update to use
4294         ARC-compliant cast.
4295         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4296         cast.
4297
4298 2019-02-21  Chris Dumez  <cdumez@apple.com>
4299
4300         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4301         https://bugs.webkit.org/show_bug.cgi?id=194481
4302
4303         Reviewed by Alex Christensen.
4304
4305         Give the processes a chance to shutdown and wait until we reached the expected number
4306         of processes.
4307
4308         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4309
4310 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4311
4312         Fix the macOS build
4313
4314         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4315
4316 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4317
4318         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4319
4320         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4321         I am a backwards.
4322
4323 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4324
4325         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4326
4327         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4328         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4329         We could force on UI-side compositing, but I feel like the test might be more
4330         valuable exercising the normal path on each platform (though the original
4331         bug was also UI-side specific). Though we can't validate that the overlay
4332         layer was installed successfully, there are layout tests that do that.
4333
4334 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4335
4336         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4337         https://bugs.webkit.org/show_bug.cgi?id=194845
4338         <rdar://problem/47944579>
4339
4340         Reviewed by Antti Koivisto.
4341
4342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4343         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4344
4345 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4346
4347         [LFC][Floats] Add support for placing formatting roots in-between floats.
4348         https://bugs.webkit.org/show_bug.cgi?id=194902
4349
4350         Reviewed by Antti Koivisto.
4351
4352         * LayoutReloaded/misc/LFC-passing-tests.txt:
4353
4354 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4355
4356         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4357         https://bugs.webkit.org/show_bug.cgi?id=194901
4358
4359         Unreviewed build fix.
4360
4361         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4362         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4363         WPEBackend-fdo-0.1 as library name.
4364
4365 2019-02-21  Rob Buis  <rbuis@igalia.com>
4366
<