Unreviewed build maintenance -- update .xcfilelists.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-09  Keith Rollin  <krollin@apple.com>
2
3         Unreviewed build maintenance -- update .xcfilelists.
4
5         * DumpRenderTree/DerivedSources-input.xcfilelist:
6         * DumpRenderTree/DerivedSources-output.xcfilelist:
7
8 2019-04-09  Zalan Bujtas  <zalan@apple.com>
9
10         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
11         https://bugs.webkit.org/show_bug.cgi?id=196743
12         <rdar://problem/43897551>
13
14         Reviewed by Tim Horton.
15
16         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
17         (TEST):
18
19 2019-04-09  Youenn Fablet  <youenn@apple.com>
20
21         Close service worker database on network process suspension
22         https://bugs.webkit.org/show_bug.cgi?id=196623
23         <rdar://problem/48930869>
24
25         Reviewed by Alex Christensen.
26
27         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
28
29 2019-04-09  Daniel Bates  <dabates@apple.com>
30
31         [iPad] Should open popover when the spacebar is pressed
32         https://bugs.webkit.org/show_bug.cgi?id=196360
33         <rdar://problem/49389129>
34
35         Reviewed by Brent Fulgham.
36
37         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
38
39         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
40         (WTR::UIScriptController::isShowingPopover const): Added.
41         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
42         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
43         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
44         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
45         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
46         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
47         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
48         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
49         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
50         (WTR::UIScriptController::isShowingPopover const): Added.
51         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
52         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
53         * TestRunnerShared/UIScriptContext/UIScriptController.h:
54         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
55         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
56         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
57         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
58         (-[TestRunnerWKWebView _willPresentPopover]): Added.
59         (-[TestRunnerWKWebView _didDismissPopover]): Added.
60         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
61         (WTR::UIScriptController::isShowingPopover const): Added.
62         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
63         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
64
65 2019-04-09  Alex Christensen  <achristensen@webkit.org>
66
67         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
68         https://bugs.webkit.org/show_bug.cgi?id=196665
69         <rdar://45115669>
70
71         Reviewed by Geoff Garen.
72
73         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
74         (goBack):
75         (+[SimpleLookupContext sharedLookupContext]):
76         (-[SimpleLookupContext lookUpURL:completionHandler:]):
77         (TEST):
78         (+[Simple3LookupContext sharedLookupContext]): Deleted.
79         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
80
81 2019-04-09  John Wilander  <wilander@apple.com>
82
83         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
84         https://bugs.webkit.org/show_bug.cgi?id=196558
85         <rdar://problem/47650245>
86
87         Reviewed by Youenn Fablet.
88
89         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
90         (TestWebKitAPI::TEST):
91             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
92
93 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
94
95         [CMake] Apple builds should use ICU_INCLUDE_DIRS
96         https://bugs.webkit.org/show_bug.cgi?id=196720
97
98         Reviewed by Konstantin Tokarev.
99
100         * TestWebKitAPI/PlatformMac.cmake:
101
102 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
103
104         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
105         https://bugs.webkit.org/show_bug.cgi?id=196694
106         <rdar://problem/48388734>
107
108         Rubber-stamped by Aakash Jain.
109
110         * Scripts/webkitpy/port/image_diff.py:
111         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
112         * Scripts/webkitpy/port/server_process.py:
113         (ServerProcess.has_available_stdout): Check if stdout has data in it.
114         (ServerProcess._wait_for_data_and_update_buffers_using_select):
115         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
116         * Scripts/webkitpy/port/server_process_mock.py:
117         (MockServerProcess.has_available_stdout):
118         * Scripts/webkitpy/port/server_process_unittest.py:
119         (TestServerProcess.serial_test_basic):
120
121 2019-04-09  Jer Noble  <jer.noble@apple.com>
122
123         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
124         https://bugs.webkit.org/show_bug.cgi?id=196097
125
126         Reviewed by Eric Carlson.
127
128         Drive-by bug fix: allow tests to play audio without a user gesture by default.
129
130         * DumpRenderTree/mac/DumpRenderTree.mm:
131         (resetWebPreferencesToConsistentValues):
132         * WebKitTestRunner/TestController.cpp:
133         (WTR::TestController::resetPreferencesToConsistentValues):
134
135 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
136
137         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
138         https://bugs.webkit.org/show_bug.cgi?id=196690
139
140         Reviewed by Michael Catanzaro.
141
142         * QueueStatusServer/config/queues.py:
143         * Scripts/webkitpy/common/config/ews.json:
144         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
145         (test_ews_name):
146
147 2019-04-09  Chris Dumez  <cdumez@apple.com>
148
149         Loads using loadHTMLString() cause flashing when process-swapping
150         https://bugs.webkit.org/show_bug.cgi?id=196714
151         <rdar://problem/49637354>
152
153         Reviewed by Antti Koivisto.
154
155         Add API test coverage.
156
157         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
158
159 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
160
161         Unreviewed. Fix ATK accessibility tests after r244059.
162
163         We are failing to load the injected bundle due to undefined symbol
164         AccessibilityUIElement::replaceTextInRange().
165
166         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
167         (WTR::AccessibilityUIElement::replaceTextInRange):
168
169 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
170
171         AX: Support API: accessibilityReplaceRange:withText
172         https://bugs.webkit.org/show_bug.cgi?id=196636
173
174         Unreviewed build fix for Windows port.
175
176         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
177         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
178
179 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
180
181         [CMake][WinCairo] Separate copied headers into different directories
182         https://bugs.webkit.org/show_bug.cgi?id=196655
183
184         Reviewed by Michael Catanzaro.
185
186         * DumpRenderTree/CMakeLists.txt:
187         * MiniBrowser/win/CMakeLists.txt:
188         * TestWebKitAPI/CMakeLists.txt:
189         * TestWebKitAPI/PlatformWin.cmake:
190
191 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
192
193         Log stack-trace for run-webkit-tests when interrupted
194         https://bugs.webkit.org/show_bug.cgi?id=176393
195         <rdar://problem/34262310>
196
197         Reviewed by Lucas Forschler.
198
199         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
200         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
201         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
202         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
203         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
204         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
205         (main): Set handlers to log stack trace on interruption.
206
207 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
208
209         AX: Support API: accessibilityReplaceRange:withText
210         https://bugs.webkit.org/show_bug.cgi?id=196636
211
212         Unreviewed build fix for Windows port.
213
214         * DumpRenderTree/AccessibilityUIElement.cpp:
215         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
216
217 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
218
219         [ews-build] Scripts using Buildbot API have CORS error
220         https://bugs.webkit.org/show_bug.cgi?id=196709
221
222         Reviewed by Alexey Proskuryakov.
223
224         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
225
226 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
227
228         AX: Support API: accessibilityReplaceRange:withText
229         https://bugs.webkit.org/show_bug.cgi?id=196636
230
231         Reviewed by Daniel Bates.
232
233         * DumpRenderTree/AccessibilityUIElement.cpp:
234         (replaceTextInRangeCallback):
235         (AccessibilityUIElement::replaceTextInRange):
236         (AccessibilityUIElement::getJSClass):
237         * DumpRenderTree/AccessibilityUIElement.h:
238         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
239         (AccessibilityUIElement::replaceTextInRange):
240         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
241         (AccessibilityUIElement::replaceTextInRange):
242         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
243         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
244         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
245         (WTR::AccessibilityUIElement::replaceTextInRange):
246         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
247         (WTR::AccessibilityUIElement::replaceTextInRange):
248
249 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
250
251         [iOS] Do not allow starting selection drags when selection views are not visible
252         https://bugs.webkit.org/show_bug.cgi?id=196686
253         <rdar://problem/49399192>
254
255         Reviewed by Tim Horton.
256
257         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
258         also add some new API tests to cover scenarios where the web view is not first responder.
259
260         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
261         (TestWebKitAPI::TEST):
262         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
263
264         Add a switch to optionally make the web view first responder when starting the simulated drag.
265
266         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
267         (-[DragAndDropSimulator initWithWebView:]):
268         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
269
270 2019-04-08  Justin Fan  <justin_fan@apple.com>
271
272         [Web GPU] Fix Web GPU experimental feature on iOS
273         https://bugs.webkit.org/show_bug.cgi?id=196632
274
275         Reviewed by Myles C. Maxfield.
276
277         Properly make Web GPU available on iOS 11+.
278
279         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
280
281 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
282
283         [ews-build] Do not upload archive when Compile Fails
284         https://bugs.webkit.org/show_bug.cgi?id=196674
285
286         Reviewed by Alexey Proskuryakov.
287
288         * BuildSlaveSupport/ews-build/factories.py:
289         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
290         * BuildSlaveSupport/ews-build/steps.py:
291         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
292         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
293         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
294
295 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
296
297         Enable DFG on MIPS
298         https://bugs.webkit.org/show_bug.cgi?id=196689
299
300         Reviewed by Žan Doberšek.
301
302         Since the bytecode change, we enabled the baseline JIT on mips in
303         r240432, but DFG is still missing. With this change, all tests are
304         passing on a ci20 board.
305
306         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
307
308 2019-04-08  Philippe Normand  <pnormand@igalia.com>
309
310         [Flatpak] Second run update-webkitwpe-flatpak fails
311         https://bugs.webkit.org/show_bug.cgi?id=192702
312
313         Reviewed by Carlos Garcia Campos.
314
315         * flatpak/flatpakutils.py:
316         (FlatpakObject.flatpak): Fix typo.
317         (FlatpakPackage.install): When installing, also update to the configured remote commit.
318         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
319
320 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
321
322         [GTK][WPE] outlook.live.com displays old-fashioned UI
323         https://bugs.webkit.org/show_bug.cgi?id=196642
324
325         Reviewed by Carlos Garcia Campos.
326
327         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
328         (TestWebKitAPI::TEST): New Mac platform quirk test.
329
330 2019-04-07  Commit Queue  <commit-queue@webkit.org>
331
332         Unreviewed, rolling out r243956.
333         https://bugs.webkit.org/show_bug.cgi?id=196688
334
335         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
336         by aakashjain on #webkit).
337
338         Reverted changeset:
339
340         "Clicking "Go Back" from a safe browsing warning from an
341         iframe should navigate the WKWebView back to the previous
342         page"
343         https://bugs.webkit.org/show_bug.cgi?id=196665
344         https://trac.webkit.org/changeset/243956
345
346 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
347
348         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
349         https://bugs.webkit.org/show_bug.cgi?id=196669
350
351         Reviewed by Geoffrey Garen.
352
353         Added three new unit tests for WeakHashSet.
354
355         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
356         (WTF_WeakPtr.WeakHashSetConstObjects):
357         (WTF_WeakPtr.WeakHashSetComputesEmpty):
358         (WTF_WeakPtr.WeakHashSetComputeSize):
359
360 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
361
362         Hide next and previous form control buttons when WKWebView is editable
363         https://bugs.webkit.org/show_bug.cgi?id=196672
364         <rdar://problem/35625321>
365
366         Reviewed by Tim Horton.
367
368         Add a new API test.
369
370         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
371         (-[TestWKWebView lastTrailingBarButtonGroup]):
372         (TestWebKitAPI::TEST):
373         * TestWebKitAPI/ios/UIKitSPI.h:
374
375 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
376
377         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
378         https://bugs.webkit.org/show_bug.cgi?id=196077
379         <rdar://problem/49108202>
380
381         Reviewed by Chris Dumez.
382
383         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
384         on new web view.
385
386         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
387
388 2019-04-05  Saam Barati  <sbarati@apple.com>
389
390         Make compare-results understand MotionMark
391         https://bugs.webkit.org/show_bug.cgi?id=196666
392
393         Reviewed by Yusuke Suzuki.
394
395         * Scripts/compare-results:
396         (PLT5Results):
397         (detectMotionMark):
398         (detectMotionMark1_1):
399         (motionMarkResults):
400         (motionMark1_1Results):
401         (detectBenchmark):
402         (biggerIsBetter):
403         (main):
404
405 2019-04-05  Alex Christensen  <achristensen@webkit.org>
406
407         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
408         https://bugs.webkit.org/show_bug.cgi?id=196665
409         <rdar://45115669>
410
411         Reviewed by Geoff Garen.
412
413         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
414         (goBack):
415         (+[SimpleLookupContext sharedLookupContext]):
416         (-[SimpleLookupContext lookUpURL:completionHandler:]):
417         (TEST):
418         (+[Simple3LookupContext sharedLookupContext]): Deleted.
419         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
420
421 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
422
423         [ews-build] Add configuration and architecture for windows builders
424         https://bugs.webkit.org/show_bug.cgi?id=196660
425
426         Reviewed by Lucas Forschler.
427
428         * BuildSlaveSupport/ews-build/config.json:
429
430 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
431
432         webkitpy: Don't run subsequent rounds if interrupted
433         https://bugs.webkit.org/show_bug.cgi?id=196646
434
435         Reviewed by Aakash Jain.
436
437         * Scripts/webkitpy/layout_tests/controllers/manager.py:
438         (Manager.run): Bail out if interrupted.
439
440 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
441
442         Test sessionStorage in PSON private browsing mode
443         https://bugs.webkit.org/show_bug.cgi?id=196561
444
445         Reviewed by Alex Christensen.
446
447         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
448
449 2019-04-05  Commit Queue  <commit-queue@webkit.org>
450
451         Unreviewed, rolling out r243833.
452         https://bugs.webkit.org/show_bug.cgi?id=196645
453
454         This change breaks build of WPE and GTK ports (Requested by
455         annulen on #webkit).
456
457         Reverted changeset:
458
459         "[CMake][WTF] Mirror XCode header directories"
460         https://bugs.webkit.org/show_bug.cgi?id=191662
461         https://trac.webkit.org/changeset/243833
462
463 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
464
465         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
466         https://bugs.webkit.org/show_bug.cgi?id=196635
467
468         Reviewed by Antti Koivisto.
469         
470         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
471         for a test to enable async frame scrolling via:
472             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
473         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
474         
475         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
476
477         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
478         (WTR::InjectedBundle::beginTesting):
479         * WebKitTestRunner/TestController.cpp:
480         (WTR::TestController::resetPreferencesToConsistentValues):
481
482 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
483
484         Use a correct LC_RPATH when building with ASan
485         https://bugs.webkit.org/show_bug.cgi?id=196576
486
487         Reviewed by David Kilzer.
488
489         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
490         so that ../Frameworks is checked. This is simpler and more reliable than updating
491         each SPC service xcconfig.
492
493 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
494
495         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
496         https://bugs.webkit.org/show_bug.cgi?id=196629
497
498         Reviewed by Lucas Forschler.
499
500         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
501
502 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
503
504         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
505         https://bugs.webkit.org/show_bug.cgi?id=196618
506
507         Reviewed by Lucas Forschler.
508
509         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
510         (StatusBubble): Added QUEUE_TRIGGERS.
511         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
512         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
513         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
514         its parent(builder).
515
516 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
517
518         [ews-app] Status-bubble steps are sometimes displayed in reverse order
519         https://bugs.webkit.org/show_bug.cgi?id=196625
520
521         Reviewed by Lucas Forschler.
522
523         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
524         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
525
526 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
527
528         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
529         https://bugs.webkit.org/show_bug.cgi?id=196630
530
531         Reviewed by Wenson Hsieh.
532
533         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
534
535 2019-04-04  Youenn Fablet  <youenn@apple.com>
536
537         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
538         https://bugs.webkit.org/show_bug.cgi?id=196543
539
540         Reviewed by Alex Christensen.
541
542         * WebKitTestRunner/TestController.cpp:
543         (WTR::TestController::generatePageConfiguration):
544
545 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
546
547         [ews-app] Status bubble should not display skipped buildbot steps
548         https://bugs.webkit.org/show_bug.cgi?id=196584
549
550         Reviewed by Lucas Forschler.
551
552         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
553
554 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
555
556         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
557         https://bugs.webkit.org/show_bug.cgi?id=196620
558
559         Reviewed by Lucas Forschler.
560
561         * BuildSlaveSupport/ews-app/ews/config.py:
562
563 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
564
565         [Win] DumpRenderTreeWatchDog.py is not checked into source
566         https://bugs.webkit.org/show_bug.cgi?id=196567
567         <rdar://problem/49525901>
568
569         Reviewed by Lucas Forschler.
570
571         This script is used on Win EWS bots to terminate hanging DRT processes.
572
573         * EWSTools/dumprendertreewatchdog.py: Added.
574
575 2019-04-04  Chris Dumez  <cdumez@apple.com>
576
577         Unreviewed, roll out r243858 which made tests time out.
578
579         Disable new API tests on Windows instead.
580
581         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
582         (TestWebKitAPI::TEST):
583
584 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
585
586         [ATK] Cleanup WebPageAccessibilityObjectAtk
587         https://bugs.webkit.org/show_bug.cgi?id=196537
588
589         Reviewed by Michael Catanzaro.
590
591         Also consider files under atk directories as exceptions for GObject conventions.
592
593         * Scripts/webkitpy/style/checkers/cpp.py:
594         (check_identifier_name_in_declaration):
595
596 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
597
598         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
599         https://bugs.webkit.org/show_bug.cgi?id=196588
600         <rdar://problem/49365787>
601
602         Unreviewed build fix for Windows port.
603
604         error C3861: 'kill': identifier not found
605
606         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
607         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
608
609 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
610
611         [ews-build] Cancel build and similar operations should have authentication
612         https://bugs.webkit.org/show_bug.cgi?id=196520
613
614         Reviewed by Dewei Zhu.
615
616         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
617         environment variables.
618
619 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
620
621         [ews-build] Do not trigger queues which are not in production yet
622         https://bugs.webkit.org/show_bug.cgi?id=196581
623
624         Reviewed by Dewei Zhu.
625
626         * BuildSlaveSupport/ews-build/config.json:
627
628 2019-04-03  Chris Dumez  <cdumez@apple.com>
629
630         Unreviewed, fix typo in the name of API test added in r243848.
631
632         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
633         (TestWebKitAPI::TEST):
634
635 2019-04-03  Chris Dumez  <cdumez@apple.com>
636
637         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
638         https://bugs.webkit.org/show_bug.cgi?id=196588
639         <rdar://problem/49365787>
640
641         Reviewed by Ryosuke Niwa.
642
643         Add API test coverage.
644
645         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
646         (TestWebKitAPI::nullJavaScriptCallback):
647         (TestWebKitAPI::didCrashCheckFrames):
648         (TestWebKitAPI::TEST):
649
650 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
651
652         run-webkit-tests: Upload test results (new results database)
653         https://bugs.webkit.org/show_bug.cgi?id=196577
654         <rdar://problem/34841155>
655
656         Reviewed by Lucas Forschler.
657
658         * Scripts/webkitpy/layout_tests/controllers/manager.py:
659         (Manager.run): Upload results after each device shard, since the configuration will be
660         different for each device.
661         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
662         uploaded to a results database.
663         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
664         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
665
666 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
667
668         -apple-trailing-word is needed for browser detection
669         https://bugs.webkit.org/show_bug.cgi?id=196575
670
671         Unreviewed.
672
673         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
674
675 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
676
677         [CMake][WTF] Mirror XCode header directories
678         https://bugs.webkit.org/show_bug.cgi?id=191662
679
680         Reviewed by Konstantin Tokarev.
681
682         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
683         builds.
684
685         * CMakeLists.txt:
686         * DumpRenderTree/CMakeLists.txt:
687         * DumpRenderTree/PlatformWin.cmake:
688         * MiniBrowser/win/CMakeLists.txt:
689         * TestWebKitAPI/CMakeLists.txt:
690         * TestWebKitAPI/PlatformWin.cmake:
691         * WebKitTestRunner/PlatformGTK.cmake:
692         * WebKitTestRunner/PlatformWin.cmake:
693
694 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
695
696         [ews-app] Status bubble should not display certain infrastructure status messages
697         https://bugs.webkit.org/show_bug.cgi?id=196550
698
699         Reviewed by Lucas Forschler.
700
701         Do not display the steps which are un-needed for end-user. This information is still avaiable
702         if the user click on the bubble and look at the Buildbot build.
703         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
704         (StatusBubble._steps_messages):
705         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
706
707 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
708
709         [ews-build] Use https for sending data to ews-app
710         https://bugs.webkit.org/show_bug.cgi?id=196492
711
712         Reviewed by Lucas Forschler.
713
714         * BuildSlaveSupport/ews-build/events.py:
715
716 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
717
718         Remove support for -apple-trailing-word
719         https://bugs.webkit.org/show_bug.cgi?id=196525
720
721         Reviewed by Zalan Bujtas.
722
723         This CSS property is nonstandard and not used.
724
725         * Scripts/webkitperl/FeatureList.pm:
726         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
727
728 2019-04-03  Youenn Fablet  <youenn@apple.com>
729
730         Add a test for DOMCache on multiple browsing in case of private browsing
731         https://bugs.webkit.org/show_bug.cgi?id=196524
732
733         Reviewed by Alex Christensen.
734
735         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
736         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
737
738 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
739
740         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
741         https://bugs.webkit.org/show_bug.cgi?id=196540
742
743         Reviewed by Aakash Jain.
744
745         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
746
747 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
748
749         Add plumbing for a compatibility mode preference in WebKit
750         https://bugs.webkit.org/show_bug.cgi?id=196005
751
752         Reviewed by Tim Horton.
753
754         Add new API tests.
755
756         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
757         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
758
759 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
760
761         [WPE][GTK] Update libsrtp dependency package for Debian
762         https://bugs.webkit.org/show_bug.cgi?id=196528
763
764         Reviewed by Frédéric Wang.
765
766         * gtk/install-dependencies:
767         * wpe/install-dependencies:
768
769 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
770
771         [WK2] Add support for Window's beforeprint / afterprint events
772         https://bugs.webkit.org/show_bug.cgi?id=196478
773         <rdar://problem/49535124>
774
775         Unreviewed build fix for MSVC.
776
777         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
778
779         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
780
781         * WebKitTestRunner/TestController.cpp:
782         (WTR::printFrame): Use int and float literals.
783
784 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
785
786         [ews-build] Reassign bots to queues
787
788         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
789
790 2019-04-02  Chris Dumez  <cdumez@apple.com>
791
792         [WK2] Add support for Window's beforeprint / afterprint events
793         https://bugs.webkit.org/show_bug.cgi?id=196478
794
795         Reviewed by Alex Christensen.
796
797         Add minimal implementation for printFrame in WebKitTestRunner.
798
799         * WebKitTestRunner/TestController.cpp:
800         (WTR::printFrame):
801         (WTR::TestController::createOtherPage):
802         (WTR::TestController::createWebViewWithOptions):
803
804 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
805
806         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
807         https://bugs.webkit.org/show_bug.cgi?id=196491
808
809         Reviewed by Lucas Forschler.
810
811         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
812
813 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
814
815         [ews-build] Configure buildbot try credentials in environment variables
816         https://bugs.webkit.org/show_bug.cgi?id=196501
817
818         Reviewed by Lucas Forschler.
819
820         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
821         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
822         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
823
824 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
825
826         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
827         https://bugs.webkit.org/show_bug.cgi?id=196496
828         <rdar://problem/49521634>
829
830         Reviewed by Chris Dumez.
831
832         Add new API tests (see WebKit ChangeLog for more detail).
833
834         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
835         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
836         (TEST):
837
838 2019-04-02  David Kilzer  <ddkilzer@apple.com>
839
840         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
841         <https://webkit.org/b/196499>
842
843         Reviewed by Alexey Proskuryakov.
844
845         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
846         ENABLE_ADDRESS_SANITIZER.
847
848 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
849
850         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
851         https://bugs.webkit.org/show_bug.cgi?id=182757
852
853         Reviewed by Don Olmstead.
854
855         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
856         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
857
858 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
859
860         run-api-tests: Upload test results
861         https://bugs.webkit.org/show_bug.cgi?id=196323
862         <rdar://problem/49356714>
863
864         Reviewed by Lucas Forschler.
865
866         * Scripts/webkitpy/api_tests/manager.py:
867         (Manager):
868         (Manager.run): Upload results to a results database.
869         * Scripts/webkitpy/api_tests/run_api_tests.py:
870         (parse_args): Add upload arguments.
871         * Scripts/webkitpy/port/base.py:
872         (Port):
873         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
874         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
875         with commits from any other associated repositories.
876         * Scripts/webkitpy/port/device.py:
877         (Device):
878         (Device.build_version): Access build_versoin of underlying platform device.
879         * Scripts/webkitpy/port/ios_simulator_unittest.py:
880         (IOSSimulatorTest):
881         (IOSSimulatorTest.test_configuration_for_upload):
882         * Scripts/webkitpy/port/device_port.py:
883         (DevicePort):
884         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
885         the same as the machine uploading results.
886         * Scripts/webkitpy/port/mac.py:
887         (MacPort):
888         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
889         * Scripts/webkitpy/port/mac_unittest.py:
890         (MacTest):
891         (MacTest.test_configuration_for_upload):
892         * Scripts/webkitpy/xcode/simulated_device.py:
893         (SimulatedDeviceManager._create_device_with_runtime):
894         (SimulatedDevice.__init__): Create simulated device with a build_version.
895         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
896         (test_existing_simulator):
897
898 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
899
900         Remove extra newline characters (Follow-up fix to r243707)
901
902         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
903
904 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
905
906         [ews-app] Use API_KEY to accept results data
907         https://bugs.webkit.org/show_bug.cgi?id=196461
908
909         Reviewed by Dewei Zhu.
910
911         * BuildSlaveSupport/ews-app/ews/views/results.py:
912         (Results.post): Validate EWS_API_KEY before accepting any data.
913         * BuildSlaveSupport/ews-build/events.py:
914         (Events.sendData): Send EWS_API_KEY if available along with event data.
915
916 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
917
918         Unable to copy and paste a PDF from Notes into Mail compose body
919         https://bugs.webkit.org/show_bug.cgi?id=196442
920         <rdar://problem/48573098>
921
922         Reviewed by Tim Horton.
923
924         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
925         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
926         to be specified on the item providers.
927
928         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
929         (TestWebKitAPI::mapItemForTesting):
930         (TestWebKitAPI::contactItemForTesting):
931
932 2019-04-01  Tim Horton  <timothy_horton@apple.com>
933
934         Make UIWKDocumentContext rects per-character instead of per-word
935         https://bugs.webkit.org/show_bug.cgi?id=196459
936
937         Reviewed by Wenson Hsieh.
938
939         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
940         (TEST):
941         Adjust test results due to switching to per-character rects.
942
943 2019-04-01  Chris Dumez  <cdumez@apple.com>
944
945         UIProcess crash when a prewarmed process is terminated
946         https://bugs.webkit.org/show_bug.cgi?id=196451
947         <rdar://problem/49245471>
948
949         Reviewed by Geoffrey Garen.
950
951         Add API test coverage.
952
953         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
954         (TEST):
955
956 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
957
958         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
959         https://bugs.webkit.org/show_bug.cgi?id=196449
960
961         Reviewed by Lucas Forschler.
962
963         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
964         (StatusBubble.get_os_details): Method to get OS and Xcode details.
965         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
966         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
967
968 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
969
970         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
971         https://bugs.webkit.org/show_bug.cgi?id=196444
972
973         Reviewed by Lucas Forschler.
974
975         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
976
977 2019-04-01  Alex Christensen  <achristensen@webkit.org>
978
979         Add SPI to canonicalize NSURLs with WTF::URL
980         https://bugs.webkit.org/show_bug.cgi?id=196415
981         <rdar://problem/44980271>
982
983         Reviewed by Darin Adler.
984
985         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
986         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
987         (TestWebKitAPI::TEST):
988
989 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
990
991         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
992         https://bugs.webkit.org/show_bug.cgi?id=196441
993
994         Reviewed by Carlos Garcia Campos.
995
996         Don't cache the wpe_view_backend object that might not exist yet at the
997         time of EventSenderProxy constructor invocation, but instead retrieve
998         that object whenever it's required for event dispatching. This should
999         avoid crashes in this constructor now that it's invoked before any
1000         PlatformWindow has been set up (as changed in r243496).
1001
1002         * WebKitTestRunner/EventSenderProxy.h:
1003         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1004         (WTR::viewBackend):
1005         (WTR::EventSenderProxy::EventSenderProxy):
1006         (WTR::EventSenderProxy::mouseDown):
1007         (WTR::EventSenderProxy::mouseUp):
1008         (WTR::EventSenderProxy::mouseMoveTo):
1009         (WTR::EventSenderProxy::mouseScrollBy):
1010         (WTR::EventSenderProxy::keyDown):
1011         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1012
1013 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1014
1015         [Win][WebKit] MiniBrowser should support high DPI display
1016         https://bugs.webkit.org/show_bug.cgi?id=196391
1017
1018         Reviewed by Alex Christensen.
1019
1020         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1021         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1022         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1023         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1024
1025 2019-03-31  Sam Weinig  <weinig@apple.com>
1026
1027         Remove more i386 specific configurations
1028         https://bugs.webkit.org/show_bug.cgi?id=196430
1029
1030         Reviewed by Alexey Proskuryakov.
1031
1032         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1033         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1034
1035 2019-03-31  Andy Estes  <aestes@apple.com>
1036
1037         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1038         https://bugs.webkit.org/show_bug.cgi?id=196433
1039         <rdar://problem/49293305>
1040
1041         Reviewed by Tim Horton.
1042
1043         Enhanced API test coverage to include all navigation response policy decisions in both
1044         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1045
1046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1047         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1048         (TestWebKitAPI::TEST):
1049         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1050         (readFile):
1051         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1052         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1053         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1054         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1055         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1056         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1057         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1058         (-[QuickLookDelegate _downloadDidStart:]):
1059         (-[QuickLookDelegate _download:didReceiveResponse:]):
1060         (-[QuickLookDelegate _download:didReceiveData:]):
1061         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1062         (-[QuickLookDelegate _downloadDidFinish:]):
1063         (-[QuickLookDelegate _download:didFailWithError:]):
1064         (-[QuickLookDelegate _downloadDidCancel:]):
1065         (-[QuickLookDelegate verifyDownload]):
1066         (runTest):
1067         (runTestDecideBeforeLoading):
1068         (runTestDecideAfterLoading):
1069         (TEST):
1070         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1071         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1072         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1073         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1074         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1075         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1076         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1077         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1078         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1079         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1080         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1081         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1082         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1083         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1084
1085 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1086
1087         [CMake] add testdfg as target with build-jsc
1088         https://bugs.webkit.org/show_bug.cgi?id=196393
1089
1090         Reviewed by Saam Barati.
1091
1092         Added testdfg as one of the targets to build when
1093         using CMake.
1094
1095         * Scripts/build-jsc:
1096
1097 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1098
1099         Delete WebMetal implementation in favor of WebGPU
1100         https://bugs.webkit.org/show_bug.cgi?id=195418
1101
1102         Reviewed by Dean Jackson.
1103
1104         * DumpRenderTree/mac/DumpRenderTree.mm:
1105         (enableExperimentalFeatures):
1106         (resetWebPreferencesToConsistentValues):
1107         * Scripts/webkitperl/FeatureList.pm:
1108         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1109         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1110         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1111         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1112         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1113         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1114         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1115         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1116         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1117         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1118         (WTR::InjectedBundle::beginTesting):
1119         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1120         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1121         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1122
1123 2019-03-29  Chris Dumez  <cdumez@apple.com>
1124
1125         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1126         https://bugs.webkit.org/show_bug.cgi?id=196405
1127         <rdar://problem/49428130>
1128
1129         Reviewed by Wenson Hsieh.
1130
1131         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1132         the popover presentation methods to be no-ops. Use this in the new test added in
1133         r243523 so that we do not swizzle those methods for all tests. This is needed because
1134         those WatchOS tests rely on the popover getting presented and interactive.
1135
1136         * WebKitTestRunner/TestController.cpp:
1137         (WTR::updateTestOptionsFromTestHeader):
1138         * WebKitTestRunner/TestController.h:
1139         * WebKitTestRunner/TestOptions.h:
1140         (WTR::TestOptions::hasSameInitializationOptions const):
1141         * WebKitTestRunner/ios/TestControllerIOS.mm:
1142         (WTR::TestController::platformInitialize):
1143         (WTR::TestController::platformResetStateToConsistentValues):
1144
1145 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1146
1147         [Curl] Add Server Trust Evaluation Support.
1148         https://bugs.webkit.org/show_bug.cgi?id=191646
1149
1150         Reviewed by Fujii Hironori.
1151
1152         Implemented MiniBrowser UI for asking if user trusts the server.
1153
1154         * MiniBrowser/win/Common.cpp:
1155         (askServerTrustEvaluation):
1156         (replaceString):
1157         * MiniBrowser/win/Common.h:
1158         * MiniBrowser/win/MiniBrowserLib.rc:
1159         * MiniBrowser/win/MiniBrowserLibResource.h:
1160         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1161         (createPEMString):
1162         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1163         (WebKitBrowserWindow::canTrustServerCertificate):
1164         * MiniBrowser/win/WebKitBrowserWindow.h:
1165
1166 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1167
1168         Implement ResizeObserver.
1169         https://bugs.webkit.org/show_bug.cgi?id=157743
1170
1171         Reviewed by Simon Fraser.
1172
1173         Support resizeObserverEnabled webPreferences.
1174
1175         * DumpRenderTree/TestOptions.cpp:
1176         (TestOptions::TestOptions):
1177         * DumpRenderTree/TestOptions.h:
1178         * DumpRenderTree/mac/DumpRenderTree.mm:
1179         (setWebPreferencesForTestOptions):
1180         * DumpRenderTree/win/DumpRenderTree.cpp:
1181         (enableExperimentalFeatures):
1182         * Scripts/webkitperl/FeatureList.pm:
1183         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1184
1185 2019-03-28  John Wilander  <wilander@apple.com>
1186
1187         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1188         https://bugs.webkit.org/show_bug.cgi?id=196281
1189         <rdar://problem/48938748>
1190
1191         Reviewed by Alex Christensen.
1192
1193         This patch adds the function isStatisticsHasLocalStorage() to the
1194         TestRunner. With it, the page can query the WebsiteDataStore in the
1195         UI process to make sure that it sees LocalStorage.
1196
1197         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1198         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1199         (WTR::TestRunner::isStatisticsHasLocalStorage):
1200         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1201         * WebKitTestRunner/TestController.cpp:
1202         (WTR::TestController::isStatisticsHasLocalStorage):
1203         * WebKitTestRunner/TestController.h:
1204         * WebKitTestRunner/TestInvocation.cpp:
1205         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1206
1207 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1208
1209         API::Data::createWithoutCopying should do a null check before calling CFRelease
1210         https://bugs.webkit.org/show_bug.cgi?id=196276
1211         <rdar://problem/48059859>
1212
1213         Reviewed by Alex Christensen.
1214
1215         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1216
1217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1218         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1219         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1220         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1221         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1222         (TestWebKitAPI::TEST):
1223
1224 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1225
1226         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1227         https://bugs.webkit.org/show_bug.cgi?id=186276
1228
1229         Reviewed by Carlos Garcia Campos.
1230
1231         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1232         (webViewLoadChanged):
1233         (testWebResourceGetDataError):
1234         (testWebResourceGetDataEmpty):
1235         (beforeAll):
1236         (webViewloadChanged): Deleted.
1237
1238 2019-03-27  Andy Estes  <aestes@apple.com>
1239
1240         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1241         https://bugs.webkit.org/show_bug.cgi?id=196317
1242
1243         Reviewed by Dan Bernstein.
1244
1245         package-root copies built products into a staging directory using ditto(1), which does not
1246         follow symbolic links as it traverses a directory. Now that the files in
1247         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1248         itself, these become broken links when ditto'd into the staging directory.
1249
1250         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1251
1252         * Scripts/package-root:
1253
1254 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1255
1256         [ews-app] Update display text of Submit for ews analysis
1257         https://bugs.webkit.org/show_bug.cgi?id=196309
1258
1259         Reviewed by Dewei Zhu.
1260
1261         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1262
1263 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1264
1265         run-webkit-tests should check for leaks in WebKit processes
1266         <https://webkit.org/b/193772>
1267         <rdar://problem/46526680>
1268
1269         Reviewed by Ryosuke Niwa.
1270
1271         This works by doing the following:
1272         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1273           The list of child processes are returned one per line:
1274           process.name: pid
1275         - Run the "#LIST CHILD PROCESSES" command just before the
1276           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1277           processes on the ServerProcess object.
1278         - When the `--leaks` switch is handled, run check_for_leaks() on
1279           each child process after the main test harness.
1280
1281         * DumpRenderTree/mac/DumpRenderTree.mm:
1282         (handleControlCommand):
1283         - Use strncmp() instead of strcmp().
1284         - Add support for handling "#LIST CHILD PROCESSES" command.
1285
1286         * Scripts/webkitpy/port/base.py:
1287         (Port.check_for_leaks):
1288         * Scripts/webkitpy/port/darwin.py:
1289         (DarwinPort.check_for_leaks):
1290         - Rename redundant 'process_pid' argument to 'process_id'.
1291
1292         * Scripts/webkitpy/port/driver.py:
1293         (Driver.do_post_tests_work):
1294         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1295           longer the only command this sends to WebKitTestRunner.
1296         - If the `--leaks` switch is present, send the
1297           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1298           result using Port.set_webkit_processes().
1299         (Driver._parse_child_processes_output):
1300         - Add helper method to parse list of child process names and
1301           process IDs returned from WebKitTestRunner.
1302
1303         * Scripts/webkitpy/port/ios_device.py:
1304         (IOSDevicePort.check_for_leaks):
1305         - Rename redundant 'process_pid' argument to 'process_id'.
1306
1307         * Scripts/webkitpy/port/leakdetector.py:
1308         (LeakDetector._parse_leaks_output):
1309         - Return early if there is no leaks_output.
1310         (LeakDetector.check_for_leaks):
1311         - Rename redundant 'process_pid' argument to 'process_id'.
1312
1313         * Scripts/webkitpy/port/server_process.py:
1314         (ServerProcess.__init__):
1315         (ServerProcess.child_processes):
1316         (ServerProcess.set_child_processes):
1317         - Add instance variable to Port to store list of child process
1318           names and process IDs returned from WebKitTestRunner.
1319         (ServerProcess._start):
1320         - Clear self._child_processes.
1321         (ServerProcess.stop):
1322         - If self._child_processes is set, call
1323           self._port.check_for_leaks() for each child process.
1324
1325         * Scripts/webkitpy/port/server_process_unittest.py:
1326         (TrivialMockPort.check_for_leaks):
1327         - Rename redundant 'process_pid' argument to 'process_id'.
1328
1329         * Scripts/webkitpy/port/simulator_process.py:
1330         (SimulatorProcess.stop):
1331         - If self._child_processes is set, call
1332           self._port.check_for_leaks() for each child process.
1333
1334         * Scripts/webkitpy/port/watch_device.py:
1335         (WatchDevicePort.check_for_leaks):
1336         - Rename redundant 'process_pid' argument to 'process_id'.
1337
1338         * WebKitTestRunner/TestController.cpp:
1339         (WTR::TestController::dumpResponse):
1340         - Extract method from findAndDumpWorldLeaks() so that it may be
1341           reused by findAndDumpWebKitProcessIdentifiers().
1342         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1343         - Add method to output process name and process ID of both the
1344           WebContent and Networking processes.
1345         (WTR::TestController::findAndDumpWorldLeaks):
1346         - Fix missing newline in output when there were no abandoned
1347           documents.
1348         - Call dumpResponse() for extracted code.
1349         (WTR::TestController::handleControlCommand):
1350         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1351         - Use strncmp() instead of strcmp().
1352         - Call findAndDumpWebKitProcessIdentifiers() when
1353           "#LIST CHILD PROCESSES" command is sent.
1354         * WebKitTestRunner/TestController.h:
1355         (WTR::TestController::dumpResponse):
1356         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1357         - Declare methods.
1358
1359 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1360
1361         Unreviewed. Add GLib API test cases after r243434.
1362
1363         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1364         (testWebViewActiveURI):
1365         (serverCallback):
1366         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1367         (sendRequestCallback):
1368
1369 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1370
1371         Geolocation request not complete when watch request was started in a different web process
1372         https://bugs.webkit.org/show_bug.cgi?id=195996
1373
1374         Reviewed by Alex Christensen.
1375
1376         Add a test case.
1377
1378         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1379         (TestWebKitAPI::runJavaScriptAlert):
1380         (TestWebKitAPI::TEST):
1381
1382 2019-03-26  Keith Rollin  <krollin@apple.com>
1383
1384         Update the way generate-xcfilelists returns strings from functions
1385         https://bugs.webkit.org/show_bug.cgi?id=195975
1386         <rdar://problem/49040807>
1387
1388         Reviewed by Dean Jackson.
1389
1390         There are places where generate-xcfilelists executes assignments with
1391         statements like:
1392
1393             FOO=$(some_function)
1394
1395         where "some_function" return a string by echoing it. E.g.
1396
1397             some_function()
1398             {
1399                 echo "Hello, World"
1400             }
1401
1402         This is a common idiom, but it has a problem if "some_function" needs
1403         to call "exit" in an attempt to halt the entire script right then and
1404         there. Since "some_function" is called inside of $(), it's being
1405         executed in a sub-shell. Calling exit in that sub-shell simply exits
1406         that shell; it doesn't not exit the outer shell in which the main part
1407         of the script is still running. As such, the main script keeps
1408         executing when the intent was for the script to halt.
1409
1410         The solution to this is to use a different idiom for returning
1411         strings. The one we now is to pass in the name of the variable to
1412         receive the string result:
1413
1414             some_function()
1415             {
1416                 variable_name=$1
1417                 eval $variable_name ="Hello, World"
1418             }
1419
1420         The call site now looks like
1421
1422             some_function FOO
1423
1424         Because there's no invocation of a sub-shell, some_function can now
1425         call "exit" if it wants to, and the entire script will exit at that
1426         point.
1427
1428         * Scripts/generate-xcfilelists:
1429
1430 2019-03-26  Chris Dumez  <cdumez@apple.com>
1431
1432         Add basic layout test coverage for File Picker on iOS
1433         https://bugs.webkit.org/show_bug.cgi?id=196265
1434
1435         Reviewed by Wenson Hsieh.
1436
1437         Add layout test infrastructure to test the file picker on iOS.
1438
1439         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1440         (WTR::UIScriptController::dismissFilePicker):
1441         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1442         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1443         (WTR::UIScriptController::dismissFilePicker):
1444         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1445         * WebKitTestRunner/TestController.cpp:
1446         (WTR::TestController::createWebViewWithOptions):
1447         (WTR::updateTestOptionsFromTestHeader):
1448         * WebKitTestRunner/TestOptions.h:
1449         (WTR::TestOptions::hasSameInitializationOptions const):
1450         * WebKitTestRunner/ios/TestControllerIOS.mm:
1451         (overridePresentViewController):
1452         (WTR::TestController::platformInitialize):
1453         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1454         (WTR::UIScriptController::dismissFilePicker):
1455
1456 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1457
1458         Implement async paste method on UIWKInteractionViewProtocol
1459         https://bugs.webkit.org/show_bug.cgi?id=196267
1460         <rdar://problem/49236346>
1461
1462         Reviewed by Tim Horton.
1463
1464         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1465         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1466         are now a part of all iOS 12 internal SDKs.
1467
1468         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1469
1470         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1471         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1472
1473         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1474         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1475         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1476         * TestWebKitAPI/ios/UIKitSPI.h:
1477
1478 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1479
1480         [ews-build] Use PostgreSQL for ews.webkit.org database
1481         https://bugs.webkit.org/show_bug.cgi?id=196270
1482
1483         Reviewed by Lucas Forschler.
1484
1485         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1486
1487 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1488
1489         [ews] Reset simctl states on reboot
1490         https://bugs.webkit.org/show_bug.cgi?id=196260
1491
1492         Rubber-stamped by Aakash Jain.
1493
1494         * EWSTools/start-queue-mac.sh:
1495
1496 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1497
1498         [ews-build] Use PostgreSQL for ews-build database
1499         https://bugs.webkit.org/show_bug.cgi?id=196229
1500
1501         Reviewed by Lucas Forschler.
1502
1503         * BuildSlaveSupport/ews-build/master.cfg:
1504
1505 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1506
1507         [ews-build] Get master_hostname dynamically in master.cfg
1508         https://bugs.webkit.org/show_bug.cgi?id=196255
1509
1510         Reviewed by Lucas Forschler.
1511
1512         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1513         send events data in test mode.
1514
1515 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1516
1517         [ews-app] Set db_constraint to False for Foreign Keys
1518         https://bugs.webkit.org/show_bug.cgi?id=196252
1519
1520         Reviewed by Lucas Forschler.
1521
1522         * BuildSlaveSupport/ews-app/ews/models/build.py:
1523         * BuildSlaveSupport/ews-app/ews/models/step.py:
1524
1525 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1526
1527         [ews-build] is_test_mode_enabled should default to True
1528         https://bugs.webkit.org/show_bug.cgi?id=196248
1529
1530         Reviewed by Lucas Forschler.
1531
1532         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1533
1534 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1535
1536         [ews-app] Add webkitperl to ENABLED_QUEUES
1537         https://bugs.webkit.org/show_bug.cgi?id=196253
1538
1539         Reviewed by Lucas Forschler.
1540
1541         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1542
1543 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1544
1545         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1546         https://bugs.webkit.org/show_bug.cgi?id=196211
1547         rdar://problem/49110552
1548
1549         Reviewed by Tim Horton.
1550
1551         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1552         Make sure that EventSenderProxy always exists when running tests. We used to create
1553         it when resetting before the first test, which is a bit too late.
1554
1555         * WebKitTestRunner/TestController.h:
1556         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1557         (WTR::TestController::platformCreateWebView):
1558         (WTR::TestController::platformCreateOtherPage):
1559         (WTR::TestController::finishCreatingPlatformWebView):
1560         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1561         (WTR::PlatformWebView::PlatformWebView):
1562         Moved some code that made NSWindow use NSEvent during web view creation. We may
1563         need to move more if some other case us found, but this is enough for now.
1564
1565 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1566
1567         Unreviewed. Fix typo in GLib geolocation API after r243285.
1568
1569         gelocation -> geolocation.
1570
1571         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1572         (testGeolocationManagerWatchPosition):
1573
1574 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1575
1576         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1577         https://bugs.webkit.org/show_bug.cgi?id=196213
1578
1579         Reviewed by Geoff Garen.
1580
1581         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1582         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1583         (credentialWithIdentityAndKeychainPath):
1584         (-[ChallengeDelegate webView:didFinishNavigation:]):
1585         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1586         (TestWebKitAPI::TEST):
1587
1588 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1589
1590         Expected shouldn't assume its contained types are copyable
1591         https://bugs.webkit.org/show_bug.cgi?id=195986
1592
1593         Reviewed by JF Bastien.
1594
1595         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1596         (TestWebKitAPI::NonCopyable::operator== const):
1597         (TestWebKitAPI::NonCopyable::operator!= const):
1598         (TestWebKitAPI::TEST):
1599
1600 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1601
1602         Remove some now-unnecessary dynamic class lookup
1603         https://bugs.webkit.org/show_bug.cgi?id=196237
1604
1605         Reviewed by Simon Fraser.
1606
1607         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1608         (makeRequest):
1609         (TEST):
1610
1611 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1612
1613         Unreviewed, rolling out r243450.
1614
1615         AppleWin and WinCairo port builds get broken.
1616
1617         Reverted changeset:
1618
1619         "Add test for fix of #196095"
1620         https://bugs.webkit.org/show_bug.cgi?id=196097
1621         https://trac.webkit.org/changeset/243450
1622
1623 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1624
1625         Unreviewed, rolling out r243465.
1626         https://bugs.webkit.org/show_bug.cgi?id=196226
1627
1628         the test doesn't build (Requested by thorton on #webkit).
1629
1630         Reverted changeset:
1631
1632         "Do not terminate the NetworkProcess if a third party
1633         application sends a NSCredential with a SecIdentityRef"
1634         https://bugs.webkit.org/show_bug.cgi?id=196213
1635         https://trac.webkit.org/changeset/243465
1636
1637 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1638
1639         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1640         https://bugs.webkit.org/show_bug.cgi?id=196213
1641
1642         Reviewed by Geoff Garen.
1643
1644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1645         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1646         (credentialWithIdentityAndKeychainPath):
1647         (-[ChallengeDelegate webView:didFinishNavigation:]):
1648         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1649         (TestWebKitAPI::TEST):
1650
1651 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1652
1653         [ews-build] Gracefully handle missing patch_id in events
1654         https://bugs.webkit.org/show_bug.cgi?id=196216
1655
1656         Reviewed by Lucas Forschler.
1657
1658         * BuildSlaveSupport/ews-build/events.py:
1659
1660 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1661
1662         [ews-build] use lz4 compression for improving buildbot performance
1663         https://bugs.webkit.org/show_bug.cgi?id=196155
1664
1665         Reviewed by Lucas Forschler.
1666
1667         * BuildSlaveSupport/ews-build/master.cfg:
1668
1669 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1670
1671         Pull some API testing helper methods out of TestWKWebView
1672         https://bugs.webkit.org/show_bug.cgi?id=196212
1673
1674         Reviewed by Tim Horton.
1675
1676         Refactor some more API testing utility methods, so that they can be used in
1677         tests that do not use TestWKWebView.
1678
1679         * TestWebKitAPI/cocoa/TestWKWebView.h:
1680         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1681         (-[WKWebView loadTestPageNamed:]):
1682         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1683         (-[WKWebView synchronouslyLoadHTMLString:]):
1684         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1685         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1686         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1687         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1688         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1689
1690 2019-03-25  Jer Noble  <jer.noble@apple.com>
1691
1692         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1693         https://bugs.webkit.org/show_bug.cgi?id=196097
1694
1695         Reviewed by Eric Carlson.
1696
1697         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1698
1699         * DumpRenderTree/mac/DumpRenderTree.mm:
1700         (resetWebPreferencesToConsistentValues):
1701         * WebKitTestRunner/TestController.cpp:
1702         (WTR::TestController::resetPreferencesToConsistentValues):
1703
1704 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1705
1706         Pull IPadUserInterfaceSwizzler out into a separate header file
1707         https://bugs.webkit.org/show_bug.cgi?id=196193
1708
1709         Reviewed by Anders Carlsson.
1710
1711         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1712         be used in other API tests.
1713
1714         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1715         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1716         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1717         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1718         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1719         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1720         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1721
1722 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1723
1724         Remove NavigatorContentUtils in WebCore/Modules
1725         https://bugs.webkit.org/show_bug.cgi?id=196070
1726
1727         Reviewed by Alex Christensen.
1728
1729         NavigatorContentUtils was to support the custom scheme spec [1].
1730         However, in WebKit side, no port has supported the feature in
1731         WebKit layer after EFL port was removed. So there has been the
1732         only IDL implementation of the NavigatorContentUtils in WebCore.
1733         So we don't need to keep the implementation in WebCore anymore.
1734
1735         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1736
1737         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1738
1739 2019-03-24  Andy Estes  <aestes@apple.com>
1740
1741         [watchOS] Remove unused Proximity Networking code
1742         https://bugs.webkit.org/show_bug.cgi?id=196188
1743
1744         Reviewed by Tim Horton.
1745
1746         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1747         (TEST):
1748
1749 2019-03-23  Keith Miller  <keith_miller@apple.com>
1750
1751         Refactor clz/ctz and fix getLSBSet.
1752         https://bugs.webkit.org/show_bug.cgi?id=196162
1753
1754         Reviewed by Saam Barati.
1755
1756         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1757
1758         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1759         (TestWebKitAPI::TEST):
1760
1761 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1762
1763         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1764         https://bugs.webkit.org/show_bug.cgi?id=196143
1765
1766         Reviewed by Michael Catanzaro.
1767
1768         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1769         directories.
1770
1771         * Scripts/webkitpy/style/checkers/cpp.py:
1772         (check_identifier_name_in_declaration):
1773         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1774         (WebKitStyleTest.test_names):
1775
1776 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1777
1778         [Flatpak] Manifest expanding fails for qt WPE extension
1779         https://bugs.webkit.org/show_bug.cgi?id=196148
1780
1781         Reviewed by Alex Christensen.
1782
1783         * flatpak/flatpakutils.py:
1784         (expand_submodules_recurse): The last recurse manifest expand
1785         iteration might lead to a single module so take it into account
1786         and don't try to recurse further.
1787
1788 2019-03-22  Chris Dumez  <cdumez@apple.com>
1789
1790         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1791         https://bugs.webkit.org/show_bug.cgi?id=195348
1792         <rdar://problem/48622090>
1793
1794         Reviewed by Alex Christensen.
1795
1796         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1797         to NO when test.options().shouldIgnoreMetaViewport is false.
1798
1799         * WebKitTestRunner/ios/TestControllerIOS.mm:
1800         (WTR::TestController::platformConfigureViewForTest):
1801
1802 2019-03-22  Chris Dumez  <cdumez@apple.com>
1803
1804         Prewarmed processes should be usable with any website data store
1805         https://bugs.webkit.org/show_bug.cgi?id=196104
1806
1807         Reviewed by Alex Christensen.
1808
1809         Add API test coverage.
1810
1811         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1812         (runInitialWarmedProcessUsedTest):
1813         (TEST):
1814
1815 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1816
1817         Back out local changes to Alex's Subversion working directory
1818
1819         They were accidentally committed.
1820
1821         * Scripts/webkitpy/common/system/abstractexecutive.py:
1822         (AbstractExecutive.wait_newest):
1823         * Scripts/webkitpy/common/system/executive.py:
1824         (Executive.running_pids):
1825         * Scripts/webkitpy/common/system/executive_mock.py:
1826         (MockExecutive.running_pids):
1827         * Scripts/webkitpy/common/system/executive_unittest.py:
1828         (ExecutiveTest.serial_test_running_pids):
1829         * Scripts/webkitpy/port/darwin.py:
1830         (DarwinPort.check_for_leaks):
1831         * Scripts/webkitpy/port/leakdetector.py:
1832         (LeakDetector.check_for_leaks):
1833         - This was the hack attached to Bug 193772.
1834
1835         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1836         (+[WebKitTestRunnerEvent mouseLocation]):
1837         - This works around a crash on an internal build.
1838
1839 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1840
1841         Fix the build after r243354
1842         https://bugs.webkit.org/show_bug.cgi?id=196138
1843         <rdar://problem/49145951>
1844
1845         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1846         (TEST):
1847         * TestWebKitAPI/ios/UIKitSPI.h:
1848
1849 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1850
1851         Adopt UIWKDocumentContext
1852         https://bugs.webkit.org/show_bug.cgi?id=196040
1853         <rdar://problem/48642440>
1854
1855         Reviewed by Ryosuke Niwa.
1856
1857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1858         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1859         (makeRequest):
1860         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1861         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1862         (applyStyle):
1863         (TEST):
1864         Add tests for UIWKDocumentContext.
1865
1866         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1867         (TEST):
1868         (recursiveFindWKContentView): Deleted.
1869         * TestWebKitAPI/cocoa/TestWKWebView.h:
1870         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1871         (recursiveFindWKContentView):
1872         (-[TestWKWebView wkContentView]):
1873         * TestWebKitAPI/ios/UIKitSPI.h:
1874         Share the WKContentView finding code between tests.
1875
1876 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1877
1878         [iOS WK2] Turn on async overflow scrolling by default
1879         https://bugs.webkit.org/show_bug.cgi?id=196011
1880         rdar://problem/48453859
1881
1882         Reviewed by Antti Koivisto.
1883         
1884         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1885         since so many basic layout tests have different results when compositing is triggered for
1886         overflow.
1887         
1888         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1889
1890         * WebKitTestRunner/TestController.cpp:
1891         (WTR::TestController::resetPreferencesToConsistentValues):
1892
1893 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1894
1895         [ews-build] Retry API test in case of failures
1896         https://bugs.webkit.org/show_bug.cgi?id=196004
1897
1898         Reviewed by Lucas Forschler.
1899
1900         * BuildSlaveSupport/ews-build/steps.py:
1901         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1902         (CompileWebKitToT.doStepIf): Ditto.
1903         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1904         (ReRunAPITests): Re-run API tests.
1905         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1906         (RunAPITestsWithoutPatch): Run API tests without patch.
1907         (RunAPITestsWithoutPatch.doStepIf):
1908         (RunAPITestsWithoutPatch.hideStepIf):
1909         (RunAPITestsWithoutPatch.evaluateCommand):
1910         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1911         (AnalyzeAPITestsResults.start):
1912         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1913         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1914         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1915         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1916
1917 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1918
1919         [ews-build] Update queues configurations
1920         https://bugs.webkit.org/show_bug.cgi?id=196074
1921
1922         Reviewed by Dewei Zhu.
1923
1924         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1925         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1926
1927 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1928
1929         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1930         https://bugs.webkit.org/show_bug.cgi?id=195680
1931         <rdar://problem/48903534>
1932
1933         Unreviewed infrastructure fix.
1934
1935         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1936         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1937
1938 2019-03-21  Andy Estes  <aestes@apple.com>
1939
1940         [iOS] Apple Pay should be available in documents with no user agent scripts
1941         https://bugs.webkit.org/show_bug.cgi?id=196061
1942         <rdar://problem/48649391>
1943
1944         Reviewed by Brady Eidson.
1945
1946         Added API tests and related infrastructure.
1947
1948         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1949         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1950         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1951         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1952         (TestWebKitAPI::TEST):
1953         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1954         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1955         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1956         * TestWebKitAPI/cocoa/TestProtocol.mm:
1957         (-[TestProtocol startLoading]):
1958         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1959         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1960         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1961         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1962
1963 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1964
1965         REGRESSSION (r243297): webkitpy tests broken
1966         https://bugs.webkit.org/show_bug.cgi?id=196108
1967
1968         Reviewed by Aakash Jain.
1969
1970         r243297 updated contributors.json, which broke a few unit tests.
1971
1972         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1973         (IRCCommandTest.test_whois):
1974         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1975
1976 2019-03-21  Chris Dumez  <cdumez@apple.com>
1977
1978         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1979         https://bugs.webkit.org/show_bug.cgi?id=196041
1980         <rdar://problem/49083230>
1981
1982         Reviewed by Alex Christensen.
1983
1984         Add API test coverage.
1985
1986         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1987         (TEST):
1988
1989 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1990
1991         Add SPI to inform applications of WKContentRuleList actions
1992         https://bugs.webkit.org/show_bug.cgi?id=195965
1993         <rdar://problem/42664365>
1994
1995         Reviewed by Geoff Garen.
1996
1997         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1998         (TestWebKitAPI::allActionsForResourceLoad):
1999         (TestWebKitAPI::testRequest):
2000         (TestWebKitAPI::TEST_F):
2001         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2002         (Notification::description):
2003         (Notification::operator== const):
2004         (toVector):
2005         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2006         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2007         (makeContentRuleList):
2008         (TEST):
2009         (makeWarnContentRuleList): Deleted.
2010
2011 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2012
2013         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2014         https://bugs.webkit.org/show_bug.cgi?id=196088
2015
2016         Reviewed by Brian Burg.
2017
2018         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2019         Support checks when only one platform is specified. Also deprecate macosx() and
2020         force the use of macos() instead.
2021
2022         * Scripts/webkitpy/style/checkers/cpp.py:
2023         (check_min_versions_of_wk_api_available):
2024         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2025         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2026
2027 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2028
2029         Update status inactive committers' status to 'contributor'.
2030
2031         * Scripts/webkitpy/common/config/contributors.json:
2032
2033 2019-03-21  Xan Lopez  <xan@igalia.com>
2034
2035         [JSC][x86] Drop support for x87 floating point
2036         https://bugs.webkit.org/show_bug.cgi?id=194853
2037
2038         Reviewed by Don Olmstead.
2039
2040         Force SSE2 on x86/32bit builds.
2041
2042         * Scripts/webkitdirs.pm:
2043         (generateBuildSystemFromCMakeProject):
2044
2045 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2046
2047         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2048         https://bugs.webkit.org/show_bug.cgi?id=196073
2049
2050         Reviewed by Michael Catanzaro.
2051
2052         Add test cases to check functions and constructors with no arguments but receiving user data.
2053
2054         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2055         (checkUserData):
2056         (testJSCFunction):
2057         (fooCreateWithUserData):
2058         (testJSCClass):
2059
2060 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2061
2062         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2063
2064         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2065
2066         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2067
2068 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2069
2070         [GTK][WPE] Add API to provide geolocation information
2071         https://bugs.webkit.org/show_bug.cgi?id=195940
2072
2073         Reviewed by Michael Catanzaro.
2074
2075         Add a new test to check the new API.
2076
2077         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2078         (testGeolocationManagerCurrentPosition):
2079         (testGeolocationManagerWatchPosition):
2080         (beforeAll):
2081         (afterAll):
2082         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2083         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2084         (beforeAll): Ditto.
2085         * TestWebKitAPI/glib/CMakeLists.txt:
2086
2087 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2088
2089         [GLib] Returning G_TYPE_OBJECT from a method does not work
2090         https://bugs.webkit.org/show_bug.cgi?id=195574
2091
2092         Reviewed by Michael Catanzaro.
2093
2094         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2095
2096         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2097         (getGFile):
2098         (getParent):
2099         (createGString):
2100         (getGString):
2101         (getGStringCopyWillRaise):
2102         (getGStringCopy):
2103         (getGStringStr):
2104         (getGStringLen):
2105         (freeGString):
2106         (testJSCClass):
2107
2108 2019-03-20  Saam Barati  <sbarati@apple.com>
2109
2110         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2111         https://bugs.webkit.org/show_bug.cgi?id=195721
2112
2113         Reviewed by Filip Pizlo.
2114
2115         * Scripts/run-javascriptcore-tests:
2116
2117 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2118
2119         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2120         https://bugs.webkit.org/show_bug.cgi?id=196049
2121
2122         Reviewed by Tim Horton.
2123
2124         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2125         overflow scrolling in general, so rename it.
2126
2127         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2128
2129 2019-03-20  Daniel Bates  <dabates@apple.com>
2130
2131         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2132         https://bugs.webkit.org/show_bug.cgi?id=196031
2133         <rdar://problem/49078172>
2134
2135         Reviewed by Tim Horton.
2136
2137         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2138         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2139         same code path used when the Done button is pressed to dismiss the <select> picker.
2140
2141         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2142         (TestWebKitAPI::TEST):
2143
2144 2019-03-20  Chris Dumez  <cdumez@apple.com>
2145
2146         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2147         https://bugs.webkit.org/show_bug.cgi?id=196029
2148         <rdar://problem/48954651>
2149
2150         Reviewed by Tim Horton.
2151
2152         Add API test coverage.
2153
2154         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2155
2156 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2157
2158         [ews-build] Improve failure summary string for ApplyPatch step
2159         https://bugs.webkit.org/show_bug.cgi?id=195995
2160
2161         Reviewed by Alexey Proskuryakov.
2162
2163         * BuildSlaveSupport/ews-build/steps.py:
2164         (ApplyPatch.getResultSummary): Override getResultSummary.
2165
2166 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2167
2168         AX: Implement support for new meter ARIA role
2169         https://bugs.webkit.org/show_bug.cgi?id=195966
2170
2171         Reviewed by Chris Fleizach.
2172
2173         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2174         to AXLevelIndicator.
2175
2176         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2177
2178 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2179
2180         [WebAuthN] Implement FIDO AppID extension
2181         https://bugs.webkit.org/show_bug.cgi?id=143491
2182         <rdar://problem/48298273>
2183
2184         Reviewed by Brent Fulgham.
2185
2186         Add a test that covers the new flag of convertToU2fSignCommand.
2187
2188         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2189         (TestWebKitAPI::TEST):
2190         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2191         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2192         (TestWebKitAPI::TEST):
2193
2194 2019-03-19  Keith Rollin  <krollin@apple.com>
2195
2196         Add support for more platforms to generate-xcfilelists
2197         https://bugs.webkit.org/show_bug.cgi?id=195977
2198
2199         Reviewed by Alexey Proskuryakov.
2200
2201         generate-xcfilelists incorrectly complains when involved with building
2202         WebKit for iphonesimulator:
2203
2204             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2205             …
2206             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2207
2208         Address this by teaching generate-xcfilelists about more platforms.
2209
2210         * Scripts/generate-xcfilelists:
2211
2212 2019-03-19  John Wilander  <wilander@apple.com>
2213
2214         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2215         https://bugs.webkit.org/show_bug.cgi?id=195923
2216         <rdar://problem/49001272>
2217
2218         Reviewed by Alex Christensen.
2219
2220         This patch does the following to the TestRunner:
2221         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2222         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2223         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2224
2225         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2226         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2227         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2228         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2229         * WebKitTestRunner/TestController.cpp:
2230         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2231         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2232         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2233         * WebKitTestRunner/TestController.h:
2234         * WebKitTestRunner/TestInvocation.cpp:
2235         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2236
2237 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2238
2239         [CMake] Support more clang and gcc sanitizers
2240         https://bugs.webkit.org/show_bug.cgi?id=195956
2241
2242         Reviewed by Michael Catanzaro.
2243
2244         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2245
2246 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2247
2248         [ews-build] Improve summary for PrintConfiguration step
2249         https://bugs.webkit.org/show_bug.cgi?id=195945
2250
2251         Reviewed by Lucas Forschler.
2252
2253         * BuildSlaveSupport/ews-build/steps.py:
2254         (PrintConfiguration.getResultSummary): Override getResultSummary.
2255
2256 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2257
2258         [ews-build] Improve summary for CheckOutSource step
2259         https://bugs.webkit.org/show_bug.cgi?id=195963
2260
2261         Reviewed by Lucas Forschler.
2262
2263         * BuildSlaveSupport/ews-build/steps.py:
2264         (CheckOutSource.getResultSummary):
2265
2266 2019-03-19  Daniel Bates  <dabates@apple.com>
2267
2268         [iOS] Focus not preserved when switching between tabs
2269         https://bugs.webkit.org/show_bug.cgi?id=195820
2270         <rdar://problem/43614450>
2271
2272         Reviewed by Brent Fulgham.
2273
2274         Add tests to ensure that we restore focus when resigning and becoming first responder.
2275
2276         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2277         (TestWebKitAPI::TEST):
2278
2279 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2280
2281         Make WTFLogChannelState and WTFLogLevel enum classes
2282         https://bugs.webkit.org/show_bug.cgi?id=195904
2283
2284         Reviewed by Eric Carlson.
2285
2286         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2287         (TestWebKitAPI::TEST_F):
2288
2289 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2290
2291         [GStreamer][EME] Backported mssdemux protection data crash fix
2292         https://bugs.webkit.org/show_bug.cgi?id=195918
2293
2294         Reviewed by Philippe Normand.
2295
2296         * gstreamer/jhbuild.modules:
2297         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2298
2299 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2300
2301         Unreviewed, rolling out r243132.
2302
2303         Broke GTK build
2304
2305         Reverted changeset:
2306
2307         "Make WTFLogChannelState and WTFLogLevel enum classes"
2308         https://bugs.webkit.org/show_bug.cgi?id=195904
2309         https://trac.webkit.org/changeset/243132
2310
2311 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2312
2313         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2314
2315         * Scripts/webkitdirs.pm:
2316         (builtDylibPathForName): Adjust the shared library name that's changed
2317         with the API version bump in r243073.
2318
2319 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2320
2321         Make WTFLogChannelState and WTFLogLevel enum classes
2322         https://bugs.webkit.org/show_bug.cgi?id=195904
2323
2324         Reviewed by Eric Carlson.
2325
2326         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2327         (TestWebKitAPI::TEST_F):
2328
2329 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2330
2331         Disable flaky test added in r2431100
2332         https://webkit.org/b/195785
2333
2334         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2335         (TestWebKitAPI::TEST):
2336         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2337
2338 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2339
2340         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2341         https://bugs.webkit.org/show_bug.cgi?id=195916
2342
2343         Reviewed by Tim Horton.
2344
2345         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2346         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2347
2348 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2349
2350         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2351
2352         * Scripts/webkitpy/common/config/contributors.json:
2353
2354 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2355
2356         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2357         https://bugs.webkit.org/show_bug.cgi?id=195785
2358
2359         Reviewed by Geoffrey Garen.
2360
2361         * TestWebKitAPI/TCPServer.cpp: Added.
2362         (TestWebKitAPI::TCPServer::TCPServer):
2363         (TestWebKitAPI::TCPServer::~TCPServer):
2364         (TestWebKitAPI::TCPServer::socketBindListen):
2365         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2366         * TestWebKitAPI/TCPServer.h: Added.
2367         (TestWebKitAPI::TCPServer::port const):
2368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2369         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2370         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2371         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2372         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2373         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2374         (TestWebKitAPI::respondSlowly):
2375         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2376         (TestWebKitAPI::downloadAtRate):
2377         (TestWebKitAPI::TEST):
2378
2379 2019-03-18  Saam Barati  <sbarati@apple.com>
2380
2381         Add a plan file for JetStream 2
2382         https://bugs.webkit.org/show_bug.cgi?id=190734
2383
2384         Reviewed by Mark Lam.
2385
2386         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2387
2388 2019-03-18  Chris Dumez  <cdumez@apple.com>
2389
2390         Delay WebProcess launch until a load is triggered in a Web view
2391         https://bugs.webkit.org/show_bug.cgi?id=195758
2392         <rdar://problem/48126013>
2393
2394         Reviewed by Geoff Garen.
2395
2396         Add API test coverage. Also update some existing API tests to not expect
2397         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2398
2399         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2400         (TestWebKitAPI::TEST):
2401         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2402         (TestWebKitAPI::TEST):
2403         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2404         (TEST):
2405         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2406         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2407         (TEST):
2408         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2409         (TEST):
2410         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2411
2412 2019-03-18  Xan Lopez  <xan@igalia.com>
2413
2414         [CMake] Prevent potential warning when determining $architecture
2415         https://bugs.webkit.org/show_bug.cgi?id=195891
2416
2417         Reviewed by Michael Catanzaro.
2418
2419         It's possible for generateBuildSystemForCMakeProject to be called
2420         before determineArchitecture() is ever called. This will make the
2421         first eq check with $architecture to be bogus (and print a
2422         warning). Change that to an eq check with architecture(), which
2423         implicitly calls determineArchitecture() if needed, and change all
2424         the other similar cases in the method in the same way to prevent
2425         future bugs like this one.
2426
2427         * Scripts/webkitdirs.pm:
2428         (generateBuildSystemFromCMakeProject):
2429
2430 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2431
2432         [WPE] Tarballs generated with “make dist” cannot build documentation
2433         https://bugs.webkit.org/show_bug.cgi?id=195885
2434
2435         Reviewed by Carlos Garcia Campos.
2436
2437         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2438
2439 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2440
2441         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2442         https://bugs.webkit.org/show_bug.cgi?id=195883
2443
2444         Reviewed by Carlos Garcia Campos.
2445
2446         * gtkdoc/gtkdoc.py:
2447         (GTKDoc._run_command): When commands fail to run, include the full command line for
2448         the program invocation and the output it has generated on the standard error stream.
2449
2450 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2451
2452         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2453         https://bugs.webkit.org/show_bug.cgi?id=195786
2454
2455         Reviewed by Philippe Normand.
2456
2457         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2458         * wpe/jhbuild.modules: Ditto.
2459
2460 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2461
2462         [ews-build] Don't run clean builds on EWS builders
2463         https://bugs.webkit.org/show_bug.cgi?id=195851
2464
2465         Reviewed by Geoffrey Garen.
2466
2467         * BuildSlaveSupport/ews-build/factories.py:
2468
2469 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2470
2471         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2472         https://bugs.webkit.org/show_bug.cgi?id=195849
2473
2474         Reviewed by Chris Dumez.
2475
2476         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2477
2478         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2479         (runWebsiteDataStoreCustomPaths):
2480
2481 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2482
2483         webkitpy: Upload test results
2484         https://bugs.webkit.org/show_bug.cgi?id=195755
2485         <rdar://problem/48896182>
2486
2487         Reviewed by Aakash Jain.
2488
2489         Establish a new format for uploading results that is not tied to layout tests, apply
2490         that format to webkitpy tests.
2491
2492         * Scripts/webkitpy/common/checkout/scm/git.py:
2493         (Git.native_branch): Return what branch the current checkout is on.
2494         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2495         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2496         * Scripts/webkitpy/common/checkout/scm/svn.py:
2497         (SVN.native_branch): Ditto.
2498         * Scripts/webkitpy/common/system/platforminfo.py:
2499         (PlatformInfo.build_version): Return a build version for Mac.
2500         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2501         (MockPlatformInfo.__init__):
2502         (MockPlatformInfo.build_version):
2503         * Scripts/webkitpy/results: Added.
2504         * Scripts/webkitpy/results/__init__.py: Added.
2505         * Scripts/webkitpy/results/options.py: Added.
2506         (upload_options): OptParse list for upload options.
2507         * Scripts/webkitpy/results/upload.py: Added.
2508         (Upload): Class which enforces the upload format expected by the results server.
2509         (Upload.Expectations):
2510         (Upload.create_configuration):
2511         (Upload.create_commit):
2512         (Upload.create_details):
2513         (Upload.create_run_stats):
2514         (Upload.create_test_result):
2515         (Upload.__init__):
2516         (Upload.Encoder): Encode Upload object as json.
2517         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2518         * Scripts/webkitpy/results/upload_unittest.py: Added.
2519         * Scripts/webkitpy/test/main.py:
2520         (Tester._parse_args): Add upload arguments.
2521         (Tester._run_tests): Allow results to be uploaded.
2522         * Scripts/webkitpy/test/runner.py:
2523         (Runner.__init__): Record which tests were run, rather than just counting them.
2524         (Runner.handle):
2525         * Scripts/webkitpy/test/runner_unittest.py:
2526         (RunnerTest.test_run):
2527         * Scripts/webkitpy/thirdparty/__init__.py:
2528         (AutoinstallImportHook.find_module): Add requests auto-install.
2529         (AutoinstallImportHook._install_requests):
2530         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2531         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2532
2533 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2534
2535         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2536         https://bugs.webkit.org/show_bug.cgi?id=195810
2537
2538         Reviewed by Tim Horton.
2539
2540         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2541         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2542         ending certain layout tests.
2543
2544         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2545         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2546         (-[TestRunnerWKWebView dealloc]):
2547         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2548
2549         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2550         helper method when destroying the web view, and when resetting state between tests.
2551
2552         * WebKitTestRunner/ios/TestControllerIOS.mm:
2553         (WTR::TestController::platformResetStateToConsistentValues):
2554
2555         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2556
2557 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2558
2559         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2560         https://bugs.webkit.org/show_bug.cgi?id=190350
2561         <rdar://problem/45089503>
2562
2563         Reviewed by Geoffrey Garen.
2564
2565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2566         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2567         (TEST):
2568         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2569         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2570         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2571         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2572         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2573         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2574         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2575         (runTest):
2576         (createDirectories):
2577         (TEST):
2578         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2579         (TEST):
2580         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2581         (TEST):
2582
2583 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2584
2585         Add support to WebPage for getting the contents as an attributed string.
2586         https://bugs.webkit.org/show_bug.cgi?id=195636
2587         rdar://problem/45055697
2588
2589         Reviewed by Tim Horton.
2590
2591         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2592         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2593
2594 2019-03-15  Chris Dumez  <cdumez@apple.com>
2595
2596         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2597         https://bugs.webkit.org/show_bug.cgi?id=195747
2598
2599         Reviewed by Geoff Garen.
2600
2601         Add API test coverage.
2602
2603         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2604
2605 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2606
2607         Unreviewed, rolling out r242952.
2608
2609         Causing API failures on iOS Simulator
2610
2611         Reverted changeset:
2612
2613         "[PSON] Make sure the WebProcessCache is leverage when
2614         relaunching a process after termination"
2615         https://bugs.webkit.org/show_bug.cgi?id=195747
2616         https://trac.webkit.org/changeset/242952
2617
2618 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2619
2620         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2621         https://bugs.webkit.org/show_bug.cgi?id=195740
2622
2623         Reviewed by Ross Kirsling.
2624
2625         window.open doesn't work for WebKitBrowserWindow because it is not
2626         implemented yet.
2627
2628         1. Implemented createNewPage callback of WKPageUIClient.
2629         2. Changed MainWindow to take a BrowserWindow factory function
2630           instead of BrowserWindowType to be flexible to create
2631           BrowserWindow with extra settings.
2632         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2633           because it is not relevant with MainWindow anymore.
2634
2635         * MiniBrowser/win/Common.cpp:
2636         (parseCommandLine):
2637         * MiniBrowser/win/Common.h:
2638         (CommandLineOptions::CommandLineOptions):
2639         * MiniBrowser/win/MainWindow.cpp:
2640         (MainWindow::MainWindow):
2641         (MainWindow::create):
2642         (MainWindow::init):
2643         (MainWindow::WndProc):
2644         * MiniBrowser/win/MainWindow.h:
2645         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2646         (PrintWebUIDelegate::createWebViewWithRequest):
2647         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2648         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2649         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2650         (WebKitBrowserWindow::updateProxySettings):
2651         (WebKitBrowserWindow::createNewPage):
2652         * MiniBrowser/win/WebKitBrowserWindow.h:
2653         * MiniBrowser/win/WinMain.cpp:
2654         (wWinMain):
2655
2656 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2657
2658         Make it possible to test scrolling tree layer manipulation more easily
2659         https://bugs.webkit.org/show_bug.cgi?id=195780
2660
2661         Reviewed by Tim Horton.
2662         
2663         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2664         cuts off communication of scrolling tree scrolls back to the web process
2665         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2666         allows tests to trigger scrolls which run the scrolling tree layer positioning
2667         logic, but never get another commit from the web process that might mask
2668         scrolling tree bugs.
2669         
2670         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2671         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2672         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2673
2674         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2675         (WTR::UIScriptController::scrollUpdatesDisabled const):
2676         (WTR::UIScriptController::setScrollUpdatesDisabled):
2677         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2678         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2679         (WTR::UIScriptController::scrollUpdatesDisabled const):
2680         (WTR::UIScriptController::setScrollUpdatesDisabled):
2681         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2682         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2683         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2684         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2685         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2686         * WebKitTestRunner/ios/TestControllerIOS.mm:
2687         (WTR::TestController::platformResetStateToConsistentValues):
2688         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2689         (WTR::UIScriptController::scrollUpdatesDisabled const):
2690         (WTR::UIScriptController::setScrollUpdatesDisabled):
2691
2692 2019-03-14  Youenn Fablet  <youenn@apple.com>
2693
2694         Move IDB storage in private browsing mode to NetworkProcess
2695         https://bugs.webkit.org/show_bug.cgi?id=195602
2696
2697         Reviewed by Brady Eidson.
2698
2699         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2700         (TEST):
2701
2702 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2703
2704         [ews-build] Make descriptionDone messages more readable
2705         https://bugs.webkit.org/show_bug.cgi?id=195760
2706
2707         Reviewed by Lucas Forschler.
2708
2709         * BuildSlaveSupport/ews-build/steps.py:
2710         * BuildSlaveSupport/ews-build/steps_unittest.py:
2711
2712 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2713
2714         [ews-build] Generate status-bubble hover-over messages
2715         https://bugs.webkit.org/show_bug.cgi?id=195680
2716
2717         Reviewed by Lucas Forschler.
2718
2719         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2720         (StatusBubble):
2721         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2722         on hover-over.
2723         (StatusBubble._iso_time):
2724         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2725         hover-over message.
2726         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2727
2728 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2729
2730         [ews-app] Gracefully handle the case when state_string is None
2731         https://bugs.webkit.org/show_bug.cgi?id=195753
2732
2733         Reviewed by Lucas Forschler.
2734
2735         * BuildSlaveSupport/ews-app/ews/models/build.py:
2736         * BuildSlaveSupport/ews-app/ews/models/step.py:
2737
2738 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2739
2740         [ews-app] Status bubble display pending for currently running build step
2741         https://bugs.webkit.org/show_bug.cgi?id=195744
2742
2743         Reviewed by Lucas Forschler.
2744
2745         * BuildSlaveSupport/ews-build/events.py:
2746         (Events.stepStarted): If state_string is pending, replace it with step name.
2747
2748 2019-03-14  Chris Dumez  <cdumez@apple.com>
2749
2750         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2751         https://bugs.webkit.org/show_bug.cgi?id=195750
2752
2753         Reviewed by Geoffrey Garen.
2754
2755         Add API test coverage.
2756
2757         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2758         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2759         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2760         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2761
2762 2019-03-14  Chris Dumez  <cdumez@apple.com>
2763
2764         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2765         https://bugs.webkit.org/show_bug.cgi?id=195747
2766
2767         Reviewed by Geoff Garen.
2768
2769         Add API test coverage.
2770
2771         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2772
2773 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2774
2775         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2776         https://bugs.webkit.org/show_bug.cgi?id=195725
2777         <rdar://problem/48545062>
2778
2779         Reviewed by Tim Horton.
2780
2781         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2782         handler is nil.
2783
2784         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2785         (TestWebKitAPI::TEST):
2786
2787 2019-03-13  Sam Weinig  <sam@webkit.org>
2788
2789         Add utility function to allow easy reverse range-based iteration of a container
2790         https://bugs.webkit.org/show_bug.cgi?id=195542
2791
2792         Reviewed by Antti Koivisto.
2793
2794         * TestWebKitAPI/CMakeLists.txt:
2795         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2796         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2797         (TestWebKitAPI::TEST):
2798         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2799
2800 2019-03-13  Chris Dumez  <cdumez@apple.com>
2801
2802         Use a ServiceWorker process per registrable domain
2803         https://bugs.webkit.org/show_bug.cgi?id=195649
2804
2805         Reviewed by Youenn Fablet.
2806
2807         Update API test coverage.
2808
2809         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2810
2811 2019-03-13  Chris Dumez  <cdumez@apple.com>
2812
2813         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2814         https://bugs.webkit.org/show_bug.cgi?id=195684
2815         <rdar://problem/48294714>
2816
2817         Reviewed by Antti Koivisto.
2818
2819         Add API test coverage.
2820
2821         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2822
2823 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2824
2825         [ews-app] Remove unused patch view
2826         https://bugs.webkit.org/show_bug.cgi?id=195669
2827
2828         Reviewed by Lucas Forschler.
2829
2830         * BuildSlaveSupport/ews-app/ews/urls.py:
2831         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2832
2833 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2834
2835         [ews-app] Use Buildbot result code variables
2836         https://bugs.webkit.org/show_bug.cgi?id=195668
2837
2838         Reviewed by Alexey Proskuryakov.
2839
2840         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2841         (Buildbot): Added Buildbot result code variables.
2842         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2843         (StatusBubble._build_bubble): Used Buildbot result code variables.
2844
2845 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2846
2847         [Flatpak] Expand submodule recursively
2848         https://bugs.webkit.org/show_bug.cgi?id=195672
2849
2850         Building WPE with flatpak was impossible without that as it was raising an exception.
2851         Also update wpebackend-fdo to match what is built in jhbuild
2852
2853         Reviewed by Philippe Normand.
2854
2855         * flatpak/flatpakutils.py:
2856         (expand_submodules_recurse):
2857         (expand_manifest):
2858         * flatpak/org.webkit.WPEModules.yaml:
2859
2860 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2861
2862         [ews-app] status bubble should be hidden for certain builds
2863         https://bugs.webkit.org/show_bug.cgi?id=194597
2864
2865         Reviewed by Dewei Zhu.
2866
2867         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2868         (StatusBubble._build_bubble):
2869         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2870         because the patch didn't have relevant changes.
2871         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2872         in production yet.
2873
2874 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2875
2876         [Win] Fix a slew of simple clang-cl warnings.
2877         https://bugs.webkit.org/show_bug.cgi?id=195652
2878
2879         Reviewed by Don Olmstead.
2880
2881         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2882         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2883
2884 2019-03-12  Justin Fan  <justin_fan@apple.com>
2885
2886         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2887         https://bugs.webkit.org/show_bug.cgi?id=195518
2888         <rdar://problem/46322356>
2889
2890         Reviewed by Myles C. Maxfield.
2891
2892         * DumpRenderTree/DerivedSources-input.xcfilelist:
2893         * DumpRenderTree/DerivedSources-output.xcfilelist:
2894
2895 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2896
2897         Unreviewed, rolling out r242825.
2898         https://bugs.webkit.org/show_bug.cgi?id=195648
2899
2900         "Broke webkitpy tests with my change to
2901         lldb_dump_class_layout.py" (Requested by rmorisset on
2902         #webkit).
2903
2904         Reverted changeset:
2905
2906         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2907         classes with suspicious padding"
2908         https://bugs.webkit.org/show_bug.cgi?id=195573
2909         https://trac.webkit.org/changeset/242825
2910
2911 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2912
2913         [ews-build] Show status bubbles while the patch is waiting in queue
2914         https://bugs.webkit.org/show_bug.cgi?id=195618
2915
2916         Reviewed by Lucas Forschler.
2917
2918         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2919         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2920         enabled in initial deployment.
2921         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2922         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2923         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2924         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2925         (StatusBubble._build_bubbles_for_patch):
2926
2927 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2928
2929         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2930         https://bugs.webkit.org/show_bug.cgi?id=195573
2931
2932         Reviewed by Simon Fraser.
2933
2934         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2935
2936         * Scripts/dump-class-layout:
2937         (main):
2938         * lldb/lldb_dump_class_layout.py:
2939         (ClassLayout.__init__):
2940         (ClassLayout._compute_padding_recursive):
2941         (LLDBDebuggerInstance.dump_layout_for_classname):
2942         (LLDBDebuggerInstance):
2943         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2944         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2945
2946 2019-03-12  Chris Dumez  <cdumez@apple.com>
2947
2948         Device Orientation access permission should be denied unless explicitly granted by the client
2949         https://bugs.webkit.org/show_bug.cgi?id=195625
2950
2951         Reviewed by Youenn Fablet.
2952
2953         add API test coverage.
2954
2955         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2956         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2957         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2958         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2959         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2960         (runDeviceOrientationTest):
2961         (TEST):
2962         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2963         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2964
2965 2019-03-12  Jer Noble  <jer.noble@apple.com>
2966
2967         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2968         https://bugs.webkit.org/show_bug.cgi?id=195137
2969         <rdar://problem/48810307>
2970
2971         Reviewed by Eric Carlson.
2972
2973         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2974         (TestWebKitAPI::TEST):
2975
2976 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2977
2978         [ews-build] Change urls from uat to production
2979         https://bugs.webkit.org/show_bug.cgi?id=195566
2980
2981         Reviewed by Lucas Forschler.
2982
2983         * BuildSlaveSupport/ews-app/ews/config.py:
2984         * BuildSlaveSupport/ews-build/events.py:
2985         * BuildSlaveSupport/ews-build/steps.py:
2986
2987 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2988
2989         [ews-build] change max_builds for local-worker to 1
2990         https://bugs.webkit.org/show_bug.cgi?id=195568
2991
2992         Reviewed by Lucas Forschler.
2993
2994         * BuildSlaveSupport/ews-build/loadConfig.py:
2995
2996 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2997
2998         Fix the build
2999
3000         * TestRunnerShared/spi/PencilKitTestSPI.h:
3001         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3002
3003 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3004
3005         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3006         https://bugs.webkit.org/show_bug.cgi?id=194131
3007
3008         Reviewed by Michael Catanzaro.
3009
3010         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3011         (uriChanged):
3012         (testUnfinishedSubresourceLoad):
3013         (serverCallback):
3014         (beforeAll):
3015
3016 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3017
3018         WTF::Expected should use std::addressof instead of operator&
3019         https://bugs.webkit.org/show_bug.cgi?id=195604
3020
3021         Reviewed by Myles Maxfield.
3022
3023         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3024         (TestWebKitAPI::Unique::Unique):
3025         (TestWebKitAPI::Unique::operator&):
3026         (TestWebKitAPI::TEST):
3027
3028 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3029
3030         Add Optional to Forward.h.
3031         https://bugs.webkit.org/show_bug.cgi?id=195586
3032
3033         Reviewed by Darin Adler.
3034
3035         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3036         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3037         Remove unnecessary includes from headers.
3038
3039 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3040
3041         Add testing API to hit-test and scroll overflow scrollers
3042         https://bugs.webkit.org/show_bug.cgi?id=195278
3043
3044         Reviewed by Antti Koivisto.
3045         
3046         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3047         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3048         
3049         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3050
3051         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3052         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3053         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3054         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3055         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3056         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3057         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3058         (WTR::enclosingScrollViewIncludingSelf):
3059         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3060
3061 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3062
3063         API test WebKit.RequestTextInputContext fails on iOS
3064         https://bugs.webkit.org/show_bug.cgi?id=195585
3065
3066         Reviewed by Wenson Hsieh and Simon Fraser.
3067
3068         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3069         (applyStyle):
3070         (TEST):
3071         Add a viewport, so that the coordinates match up on iOS.
3072         Scroll by moving the UIScrollView's contentOffset.
3073
3074 2019-03-11  Chris Dumez  <cdumez@apple.com>
3075
3076         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3077         https://bugs.webkit.org/show_bug.cgi?id=195506
3078         <rdar://problem/48733477>
3079
3080         Reviewed by Alex Christensen.
3081
3082         Add API test coverage.
3083
3084         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3085
3086 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3087
3088         Adding myself to contributors.json
3089
3090         Unreviewed, addming myself to contributors.json .
3091
3092         * Scripts/webkitpy/common/config/contributors.json:
3093
3094 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3095
3096         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3097         https://bugs.webkit.org/show_bug.cgi?id=195511
3098         <rdar://problem/44873269>
3099
3100         Reviewed by Darin Adler.
3101
3102         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3103         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3104         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3105         (TEST_F):
3106
3107 2019-03-11  Chris Dumez  <cdumez@apple.com>
3108
3109         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3110         https://bugs.webkit.org/show_bug.cgi?id=195561
3111
3112         Reviewed by Youenn Fablet.
3113
3114         Make sure the JS in the test requests for permission to receive device orientation events.
3115
3116         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3117
3118 2019-03-11  Youenn Fablet  <youenn@apple.com>
3119
3120         Allow storage quota increase by default in WTR
3121         https://bugs.webkit.org/show_bug.cgi?id=195541
3122
3123         Reviewed by Geoffrey Garen.
3124
3125         Allow storage quota increase by default in WTR.
3126         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3127         Use this for tests that explicitly need cache increase.
3128
3129         Instead of increasing quota by 2, make sure the next request is
3130         granted by adding all given parameters.
3131
3132         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3133         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3134         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3135         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3136         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3137         * WebKitTestRunner/TestController.cpp:
3138         (WTR::TestController::setAllowStorageQuotaIncrease):
3139         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3140         * WebKitTestRunner/TestController.h:
3141         * WebKitTestRunner/TestInvocation.cpp:
3142         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3143         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3144         (WTR::TestController::cocoaResetStateToConsistentValues):
3145         (WTR::TestController::setAllowStorageQuotaIncrease):
3146         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3147         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3148         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3149
3150 2019-03-11  Xan Lopez  <xan@igalia.com>
3151
3152         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3153         https://bugs.webkit.org/show_bug.cgi?id=194147
3154
3155         Reviewed by Michael Saboff.
3156
3157         To make --32-bit work correctly on Linux/64bit we need to:
3158
3159         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3160         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3161         unfortunately CMake only allows us to do this during
3162         crosscompilation, which is overkill here.
3163         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3164         pkg-config detection module uses the x86 .pc files instead of the
3165         x86_64 ones.
3166         - Set the -m32 flags for the compiler.
3167
3168         * Scripts/webkitdirs.pm:
3169         (generateBuildSystemFromCMakeProject):
3170
3171 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3172
3173         Add MotionMark-1.1 plan file for run-benchmark script.
3174         https://bugs.webkit.org/show_bug.cgi?id=195481
3175
3176         Rubber-stamped by Darin Adler.
3177
3178         Run-benchmark script should support MontionMark-1.1.
3179
3180         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3181
3182 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3183
3184         [ews-app] Add support for submit-to-ews url
3185         https://bugs.webkit.org/show_bug.cgi?id=195477
3186
3187         Reviewed by Lucas Forschler.
3188
3189         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3190         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3191         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3192         * BuildSlaveSupport/ews-app/ews/urls.py:
3193         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3194
3195 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3196
3197         Unreviewed, rolling out r242688, r242643, r242624.
3198
3199         Caused multiple layout test failures and crashes on iOS and macOS.
3200
3201         Reverted changeset:
3202
3203         "requestAnimationFrame should execute before the next frame"
3204         https://bugs.webkit.org/show_bug.cgi?id=177484
3205         https://trac.webkit.org/changeset/242624/webkit
3206
3207         * Tracing/SystemTracePoints.plist:
3208
3209 2019-03-11  John Wilander  <wilander@apple.com>
3210
3211         Resource Load Statistics: Make it possible exclude localhost from classification
3212         https://bugs.webkit.org/show_bug.cgi?id=195474
3213         <rdar://problem/47520577>
3214
3215         Reviewed by Brent Fulgham.
3216
3217         This patch allows for localhost to be excluded from classification and
3218         treatment as a prevalent resource.
3219
3220         The WebKit Tools change adds a new function called
3221         testRunner.setStatisticsIsRunningTest() which can be used to control this
3222         behavior.
3223
3224         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3225         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3226         (WTR::TestRunner::setStatisticsIsRunningTest):
3227         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3228         * WebKitTestRunner/TestController.cpp:
3229         (WTR::TestController::setStatisticsIsRunningTest):
3230         * WebKitTestRunner/TestController.h:
3231         * WebKitTestRunner/TestInvocation.cpp:
3232         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3233
3234 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3235
3236         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3237         https://bugs.webkit.org/show_bug.cgi?id=195560
3238
3239         Reviewed by Lucas Forschler.
3240
3241         * BuildSlaveSupport/ews-build/master.cfg:
3242
3243 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3244
3245         Unreviewed, rolling out r242698.
3246
3247         API test crashes on bots.
3248
3249         Reverted changeset:
3250
3251         "Add a WKContentRuleList variant that uses copied memory
3252         instead of mmap'd shared memory for class A containerized
3253         apps"
3254         https://bugs.webkit.org/show_bug.cgi?id=195511
3255         https://trac.webkit.org/changeset/242698
3256
3257 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3258
3259         [WPE] Enable web process sandbox
3260         https://bugs.webkit.org/show_bug.cgi?id=195169
3261
3262         Reviewed by Daniel Bates.
3263
3264         * wpe/install-dependencies:
3265         * wpe/jhbuild.modules:
3266
3267 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3268
3269         [ews-app] Use port 17000 for worker communication
3270         https://bugs.webkit.org/show_bug.cgi?id=195558
3271
3272         Reviewed by Lucas Forschler.
3273
3274         * BuildSlaveSupport/ews-build/master.cfg:
3275
3276 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3277
3278         [ews-build] unit-tests fail when passwords.json is missing
3279         https://bugs.webkit.org/show_bug.cgi?id=195557
3280
3281         Reviewed by Lucas Forschler.
3282
3283         * BuildSlaveSupport/ews-build/loadConfig.py:
3284         (loadBuilderConfig):
3285         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3286         (ConfigDotJSONTest.test_configuration):
3287         * BuildSlaveSupport/ews-build/master.cfg:
3288
3289 2019-03-11  Truitt Savell  <tsavell@apple.com>
3290
3291         Unreviewed, rolling out r242702.
3292
3293         Broke High Sierra builders.
3294
3295         Reverted changeset:
3296
3297         "Add utility function to allow easy reverse range-based
3298         iteration of a container"
3299         https://bugs.webkit.org/show_bug.cgi?id=195542
3300         https://trac.webkit.org/changeset/242702
3301
3302 2019-03-11  Sam Weinig  <sam@webkit.org>
3303
3304         Add utility function to allow easy reverse range-based iteration of a container
3305         https://bugs.webkit.org/show_bug.cgi?id=195542
3306
3307         Reviewed by Antti Koivisto.
3308
3309         * TestWebKitAPI/CMakeLists.txt:
3310         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3311         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3312         (TestWebKitAPI::TEST):
3313         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3314
3315 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3316
3317         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3318         https://bugs.webkit.org/show_bug.cgi?id=195511
3319         <rdar://problem/44873269>
3320
3321         Reviewed by Darin Adler.
3322
3323         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3324         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3325         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3326         (TEST_F):
3327
3328 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3329
3330         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3331         https://bugs.webkit.org/show_bug.cgi?id=195499
3332
3333         Reviewed by Darin Adler.
3334
3335         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3336         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3337         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3338         (-[WKWebView synchronouslyFocusTextInputContext:]):
3339         (applyStyle):
3340         (applyIframe):
3341         (TEST):
3342         Add some tests for this SPI.
3343
3344 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3345
3346         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3347         https://bugs.webkit.org/show_bug.cgi?id=181151
3348
3349         Reviewed by Don Olmstead.
3350
3351         * TestWebKitAPI/CMakeLists.txt:
3352         * TestWebKitAPI/PlatformWin.cmake:
3353         Enable TestWTF RunLoop tests in all platforms.
3354
3355         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3356         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3357         (TestWebKitAPI::DerivedOneShotTimer::fired):
3358         (TestWebKitAPI::TEST):
3359         Only a few platforms support nested RunLoop.
3360
3361         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3362         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3363
3364 2019-03-10  David Quesada  <david_quesada@apple.com>
3365
3366         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3367         https://bugs.webkit.org/show_bug.cgi?id=152480
3368
3369         Reviewed by Chris Dumez.
3370
3371         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3372         there are no additional references to the process pool besides the one held by
3373         the download, waits for the download to finish (in the sense that the
3374         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3375         measure, also check that the process pool has been deallocated at the end of the
3376         test. The test wouldn't be meaningful if the process pool were still alive.
3377
3378         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3379         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3380         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3381             The download will be canceled because the delegate does not implement the
3382             method to decide the download's destination, so this is where we know the
3383             DownloadProxyMap is done with the DownloadProxy.
3384         (TEST):
3385
3386 2019-03-08  Chris Dumez  <cdumez@apple.com>
3387
3388         Add support for Device Orientation / Motion permission API
3389         https://bugs.webkit.org/show_bug.cgi?id=195329
3390         <rdar://problem/47645367>
3391
3392         Reviewed by Geoffrey Garen.
3393
3394         Add test infrastructure to help test the Device Orientation / Motion permission API.
3395
3396         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3397         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3398         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3399         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3400         * WebKitTestRunner/TestController.cpp:
3401         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3402         (WTR::TestController::createWebViewWithOptions):
3403         (WTR::TestController::resetStateToConsistentValues):
3404         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3405         * WebKitTestRunner/TestController.h:
3406         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3407         * WebKitTestRunner/TestInvocation.cpp:
3408         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3409
3410 2019-03-08  Saam barati  <sbarati@apple.com>
3411
3412         Add a compare-results script to compare benchmark results
3413         https://bugs.webkit.org/show_bug.cgi?id=195486
3414         <rdar://problem/48723397>
3415
3416         Reviewed by Geoffrey Garen.
3417
3418         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3419         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3420         to extend it to learn about our other benchmarks.
3421
3422         * Scripts/compare-results: Added.
3423         (readJSONFile):
3424         (detectJetStream2):
3425         (JetStream2Results):
3426         (detectSpeedometer2):
3427         (Speedometer2Results):
3428         (detectPLT5):
3429         (PLT5Results):
3430         (detectBenchmark):
3431         (biggerIsBetter):
3432         (ttest):
3433         (getOptions):
3434         (main):
3435
3436 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3437
3438         Ensure old tab state is cleared between iterations of run-benchmark
3439         https://bugs.webkit.org/show_bug.cgi?id=195393
3440         <rdar://problem/46885583>
3441
3442         Reviewed by Dewei Zhu.
3443
3444         a) ensure the default to restore state is not set
3445         b) terminate Safari correctly
3446         c) Set the system default to ignore Persistent State in Safari
3447
3448         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3449         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3450         (OSXBrowserDriver.prepare_env): 
3451         (OSXBrowserDriver.restore_env):
3452         (OSXBrowserDriver.close_browsers):
3453         (OSXBrowserDriver._terminate_processes):
3454         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3455         (OSXChromeDriver):
3456         (OSXChromeCanaryDriver):
3457         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3458         (OSXFirefoxDriver):
3459         (OSXFirefoxNightlyDriver):
3460         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3461         (OSXSafariDriver):
3462         (OSXSafariDriver.prepare_env):
3463
3464 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3465
3466         [GTK] Several InputMethodFilter tests are failing
3467         https://bugs.webkit.org/show_bug.cgi?id=195408
3468
3469         Reviewed by Carlos Garcia Campos.
3470
3471         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3472         Regressed in r241751.
3473         Hexadecimal values of keycodes are expressed now in upper letters.
3474         Composited characters should be cast to UTF8 strings.
3475
3476         (TestWebKitAPI::TEST):
3477
3478 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3479
3480         [GTK] Make Tools/gtkdoc python3 compatible
3481         https://bugs.webkit.org/show_bug.cgi?id=195359
3482
3483         Reviewed by Carlos Garcia Campos.
3484
3485         * gtkdoc/generate-gtkdoc:
3486         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3487         work with Python 2 and 3.
3488         (get_gtkdoc_module_paths):
3489         The iteritems() was removed in Python 3, so let's use items() that's
3490         available in Python 2 and 3.
3491         (get_generator_for_config):
3492         * gtkdoc/gtkdoc.py:
3493         (GTKDoc._run_command):
3494         The sys.stdout.write() is expecting str in Python 3 and not bytes
3495         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3496         for passing the bytes there.
3497
3498 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3499
3500         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3501         https://bugs.webkit.org/show_bug.cgi?id=195346
3502         <rdar://problem/48667048>
3503
3504         Unreviewed build fix for clang-cl.
3505
3506         * DumpRenderTree/win/DumpRenderTree.cpp:
3507         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3508
3509 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3510
3511         requestAnimationFrame should execute before the next frame
3512         https://bugs.webkit.org/show_bug.cgi?id=177484
3513
3514         Reviewed by Simon Fraser.
3515
3516         Add trace points for the page RenderingUpdate.
3517
3518         * Tracing/SystemTracePoints.plist:
3519
3520 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3521
3522         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3523         https://bugs.webkit.org/show_bug.cgi?id=195353
3524         <rdar://problem/48626394>
3525
3526         Reviewed by Simon Fraser.
3527
3528         * WebKitTestRunner/ios/TestControllerIOS.mm:
3529         (WTR::TestController::platformResetPreferencesToConsistentValues):
3530
3531 2019-03-07  John Wilander  <wilander@apple.com>
3532
3533         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3534         https://bugs.webkit.org/show_bug.cgi?id=195383
3535         <rdar://problem/48570136>
3536
3537         Reviewed by Brent Fulgham.
3538
3539         This patch adds test infrastructure to purge only script-accessible cookies,
3540         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3541
3542         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3543         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3544         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3545         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3546         * WebKitTestRunner/TestController.cpp:
3547         (WTR::TestController::statisticsDeleteCookiesForHost):
3548         * WebKitTestRunner/TestController.h:
3549         * WebKitTestRunner/TestInvocation.cpp:
3550         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3551
3552 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3553
3554         Unreviewed, rolling out r242354.
3555         https://bugs.webkit.org/show_bug.cgi?id=195402
3556
3557         breaks layout tests in all configurations (Requested by
3558         zdobersek on #webkit).
3559
3560         Reverted changeset:
3561
3562         "[WPE] Enable web process sandbox"
3563         https://bugs.webkit.org/show_bug.cgi?id=195169
3564         https://trac.webkit.org/changeset/242354
3565
3566 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3567
3568         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3569         https://bugs.webkit.org/show_bug.cgi?id=195346
3570
3571         Reviewed by Fujii Hironori.
3572
3573         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3574         (TestWebKitAPI::TEST):
3575         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3576
3577         * DumpRenderTree/win/DumpRenderTree.cpp:
3578         (findFontFallback):
3579         (addFontFallbackIfPresent):
3580         (removeFontFallbackIfPresent):
3581         (main):
3582         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3583         (TestWebKitAPI::Util::moduleDirectory):
3584         (TestWebKitAPI::Util::createInjectedBundlePath):
3585         Use wchar helpers as needed.
3586
3587 2019-03-06  Rob Buis  <rbuis@igalia.com>
3588
3589         Consider supporting the `referrerpolicy` attribute.
3590         https://bugs.webkit.org/show_bug.cgi?id=179053
3591
3592         Reviewed by Darin Adler.
3593
3594         Add a runtime flag for referrerpolicy attribute.
3595
3596         * DumpRenderTree/mac/DumpRenderTree.mm:
3597         (enableExperimentalFeatures):
3598
3599 2019-03-05  Daniel Bates  <dabates@apple.com>
3600
3601         Update expected API test result following r242379
3602         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3603
3604         Update expected x-coordinate of selection rect now that the left padding of
3605         a textarea is sized in ems (so dependent on the font size) just like the left
3606         padding of a text field.
3607
3608         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3609         (TestWebKitAPI::TEST):
3610
3611 2019-03-05  David Quesada  <david_quesada@apple.com>
3612
3613         [WK2] It should be possible to follow links with 'download' attributes
3614         https://bugs.webkit.org/show_bug.cgi?id=195145
3615         rdar://problem/48462642
3616
3617         Reviewed by Alex Christensen.
3618
3619         Add a unit test to verify that activating links with 'download' attributes now
3620         navigates to the linked resource, rather than starts downloading it. Add another
3621         to verify that it is still possible to explicitly download the link via the
3622         'Download' navigation action policy.
3623
3624         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3625         (-[DownloadAttributeTestDelegate init]):
3626         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3627         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3628         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3629         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3630         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3631         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3632         (TEST):
3633         * WebKitTestRunner/TestController.cpp:
3634         (WTR::TestController::decidePolicyForNavigationAction):
3635         * WebKitTestRunner/TestController.h:
3636
3637 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3638
3639         [Curl] Implement Cookie Accept Policy.
3640         https://bugs.webkit.org/show_bug.cgi?id=191645
3641
3642         Reviewed by Fujii Hironori.
3643
3644         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3645         (TestWebKitAPI::Curl::TEST_F):
3646
3647 2019-03-05  Youenn Fablet  <youenn@apple.com>
3648
3649         Rename requestCacheStorageSpace to requestStorageSpace
3650         https://bugs.webkit.org/show_bug.cgi?id=195282
3651
3652         Reviewed by Chris Dumez.
3653
3654         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3655         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3656         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3657
3658 2019-03-05  Brady Eidson  <beidson@apple.com>
3659
3660         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3661         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3662
3663         Reviewed by Tim Horton.
3664
3665         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3666         different directory into that same WKWebView should work.
3667
3668         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3669         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3670
3671 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3672
3673         Add WeakHashSet
3674         https://bugs.webkit.org/show_bug.cgi?id=195152
3675
3676         Reviewed by Antti Koivisto.
3677
3678         Added tests for WeakHashSet.
3679
3680         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3681         (TestWebKitAPI::Base::Base): Moved.
3682         (TestWebKitAPI::Derived::foo): Moved.
3683         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3684         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3685         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3686         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3687
3688 2019-03-04  Chris Dumez  <cdumez@apple.com>
3689
3690         Do not share WebProcesses between private and regular sessions
3691         https://bugs.webkit.org/show_bug.cgi?id=195189
3692         <rdar://problem/48421064>
3693
3694         Reviewed by Alex Christensen.
3695
3696         Add API test coverage.
3697
3698         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3699         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3700
3701 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3702
3703         [WPE] Enable web process sandbox
3704         https://bugs.webkit.org/show_bug.cgi?id=195169
3705
3706         Reviewed by Daniel Bates.
3707
3708         * wpe/install-dependencies:
3709         * wpe/jhbuild.modules:
3710
3711 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3712
3713         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3714         https://bugs.webkit.org/show_bug.cgi?id=195206
3715
3716         Reviewed by Žan Doberšek.
3717
3718         Add a new test case.
3719
3720         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3721         (testJSCClass):
3722
3723 2019-03-04  Charlie Turner  <cturner@igalia.com>
3724
3725         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3726         https://bugs.webkit.org/show_bug.cgi?id=194898
3727
3728         Reviewed by Žan Doberšek.
3729
3730         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3731         a GCC extension that permits arithmetic on void* pointer. Inline
3732         the macro until this issue is fixed upstream.
3733
3734 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3735
3736         Rid the world of WK_API_ENABLED
3737         https://bugs.webkit.org/show_bug.cgi?id=195263
3738
3739         Reviewed by Dan Bernstein.
3740
3741         List of changed files elided because it's useless.
3742
3743 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3744
3745         Unreviewed follow-up to r242292.
3746
3747         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3748
3749         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3750         (TestWebKitAPI::testStrip): Renamed from strip.
3751         (TestWebKitAPI::TEST):
3752
3753 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3754
3755         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3756
3757         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3758         and bug #194272 for details.
3759
3760         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3761
3762 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3763
3764         Remove some more unused 32-bit code
3765         https://bugs.webkit.org/show_bug.cgi?id=195255
3766
3767         Reviewed by Darin Adler.
3768
3769         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3770         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3771         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3772         (NPP_New):
3773         (NPP_HandleEvent):
3774         (handleEventCarbon): Deleted.
3775
3776 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3777
3778         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3779
3780         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3781         (TestWebKitAPI::TEST):
3782
3783 2019-03-01  Darin Adler  <darin@apple.com>
3784
3785         Finish removing String::format
3786         https://bugs.webkit.org/show_bug.cgi?id=194893
3787
3788         Reviewed by Daniel Bates.
3789 '
3790         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3791
3792 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3793
3794         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3795         https://bugs.webkit.org/show_bug.cgi?id=195229
3796         <rdar://problem/48520362>
3797
3798         Reviewed by Chris Dumez.
3799
3800         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3801         (TEST):
3802
3803 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3804
3805         Add a system trace scope for event region building
3806         https://bugs.webkit.org/show_bug.cgi?id=195226
3807
3808         Reviewed by Jon Lee.
3809
3810         This trace scope measures the time spend converting element rects into Region objects,
3811         which can be large on some pages.
3812
3813         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3814
3815         * Tracing/SystemTracePoints.plist:
3816
3817 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3818
3819         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3820         https://bugs.webkit.org/show_bug.cgi?id=194612
3821
3822         Reviewed by Alex Christensen.
3823
3824         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3825         Just test the new string-processing function and don't touch the actual environment.
3826         (Test cases are all as before, but based on operator== instead of strcmp.)
3827
3828 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3829
3830         [ews-app] Update primary keys for handling multiple Buildbot instances
3831         https://bugs.webkit.org/show_bug.cgi?id=195120
3832
3833         Reviewed by Stephanie Lewis.
3834
3835         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3836         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3837         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3838
3839         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3840         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3841         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3842         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3843         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3844         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3845
3846 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3847
3848         [WinCairo] Enable service worker
3849         https://bugs.webkit.org/show_bug.cgi?id=188318
3850
3851         Reviewed by Youenn Fablet.
3852
3853         * DumpRenderTree/DumpRenderTreePrefix.h:
3854         * TestWebKitAPI/PlatformWin.cmake:
3855         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3856         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3857         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3858
3859 2019-03-01  Justin Fan  <justin_fan@apple.com>
3860
3861         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3862         https://bugs.webkit.org/show_bug.cgi?id=195191
3863
3864         Rubber-stamped by Dean Jackson.
3865
3866         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3867
3868         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3869
3870 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3871
3872         Unreviewed, fix lldb webkitpy tests
3873         https://bugs.webkit.org/show_bug.cgi?id=194375
3874
3875         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3876
3877         * lldb/lldb_webkit.py:
3878         (WTFStringImplProvider.is_8bit):
3879
3880 2019-02-28  David Quesada  <david_quesada@apple.com>
3881
3882         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3883         https://bugs.webkit.org/show_bug.cgi?id=195121
3884         rdar://problem/48450302
3885
3886         Reviewed by Alex Christensen.
3887
3888         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3889         configurations where the 'download' attribute is absent, blank, or populated
3890         with a filename, and where the anchor element is same-origin or cross-origin
3891         (meaning the 'download' attribute shouldn't be honored).
3892
3893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3894         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3895         (-[NavigationActionTestDelegate init]):
3896         (-[NavigationActionTestDelegate navigationAction]):
3897         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3898         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3899         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3900         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3901         (TEST):
3902
3903 2019-02-28  Antoine Quint  <graouts@apple.com>
3904
3905         Enable the Pointer Events runtime flag by default
3906         https://bugs.webkit.org/show_bug.cgi?id=195156
3907
3908         Reviewed by Dean Jackson.
3909
3910         * DumpRenderTree/mac/DumpRenderTree.mm:
3911         (enableExperimentalFeatures):
3912
3913 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3914
3915         Several PasteImage API tests are flaky
3916         https://bugs.webkit.org/show_bug.cgi?id=195160
3917
3918         Reviewed by Tim Horton.
3919
3920         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3921         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3922         listening for a "load" event after image load is already complete.
3923
3924         To address this, make these tests first register a "load" event handler, then run script to insert an image
3925         element into the document, and finally wait until the load event is observed before checking image size.
3926
3927         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3928
3929 2019-02-28  Chris Dumez  <cdumez@apple.com>
3930
3931         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3932         https://bugs.webkit.org/show_bug.cgi?id=195107
3933
3934         Reviewed by Alex Christensen.
3935
3936         Give some time for the zoom level to get restored.
3937
3938         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3939
3940 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3941
3942         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3943         https://bugs.webkit.org/show_bug.cgi?id=194958
3944
3945         Reviewed by Geoffrey Garen.
3946
3947         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3948         (TEST):
3949
3950 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3951
3952         [ews-app] Update method to save build to handle builder_display_name
3953         https://bugs.webkit.org/show_bug.cgi?id=195047
3954
3955         Reviewed by Dewei Zhu.
3956
3957         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3958         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3959
3960 2019-02-28  Justin Fan  <justin_fan@apple.com>
3961
3962         [Web GPU] Enable Web GPU only on 64-bit
3963         https://bugs.webkit.org/show_bug.cgi?id=195139
3964
3965         Because Metal is only supported on 64 bit apps.
3966
3967         Unreviewed build fix.
3968
3969         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3970
3971 2019-02-27  Youenn Fablet  <youenn@apple.com>
3972
3973         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3974         https://bugs.webkit.org/show_bug.cgi?id=194959
3975
3976         Reviewed by Chris Dumez.
3977
3978         Spin loop until getting the condition to remove flakiness.
3979
3980         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3981
3982 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3983
3984         [ews-build] Buildbot should include builder_display_name in the build events
3985         https://bugs.webkit.org/show_bug.cgi?id=195045
3986
3987         Reviewed by Dewei Zhu.
3988
3989         * BuildSlaveSupport/ews-build/events.py:
3990         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3991         buildername to builder_name to be consistent in naming style.
3992         (Events.buildFinished): Ditto.
3993
3994 2019-02-27  Chris Dumez  <cdumez@apple.com>
3995
3996         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3997         https://bugs.webkit.org/show_bug.cgi?id=194480
3998
3999         Reviewed by Brady Eidson.
4000
4001         Update existing API test to make it more likely to reproduce the issue.
4002
4003         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4004
4005 2019-02-27  Brady Eidson  <beidson@apple.com>
4006
4007         Universal links from Google search results pages don't open the app.
4008         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4009
4010         Reviewed by Geoffrey Garen.
4011
4012         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4013         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4014         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4015         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4016
4017 2019-02-27  Chris Dumez  <cdumez@apple.com>
4018
4019         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4020         https://bugs.webkit.org/show_bug.cgi?id=195102
4021
4022         Reviewed by Geoffrey Garen.
4023
4024         If the number of processes is not yet what we expect, wait a bit and check again to give
4025         processes some time to exit.
4026
4027         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4028
4029 2019-02-27  Chris Dumez  <cdumez@apple.com>
4030
4031         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4032         https://bugs.webkit.org/show_bug.cgi?id=194545
4033
4034         Reviewed by Brady Eidson.
4035
4036         Make sure the test navigates forward and then back only once. Previously, navigating
4037         back would trigger a navigation again in a timer.
4038
4039         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4040
4041 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4042
4043         High Sierra Debug JSC test queue should use faster hardware
4044         https://bugs.webkit.org/show_bug.cgi?id=194603
4045
4046         Rubber-stamped by Alexey Proskuryakov.
4047
4048         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4049
4050         * BuildSlaveSupport/build.webkit.org-config/config.json:
4051         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4052         (BubbleQueueServer):
4053         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4054         (WebKitBuildbot):
4055         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4056         * QueueStatusServer/config/queues.py:
4057         * Scripts/webkitpy/common/config/ews.json:
4058         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4059         (test_ews_name):
4060
4061 2019-02-27  John Wilander  <wilander@apple.com>
4062
4063         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4064         https://bugs.webkit.org/show_bug.cgi?id=195071
4065         <rdar://problem/48417690>
4066
4067         Reviewed by Alex Christensen and Brent Fulgham.
4068
4069         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4070         (TestWebKitAPI::createURL):
4071             Convenience function.
4072         (TestWebKitAPI::TEST):
4073             WebCore::AdClickAttribution now takes a URL when creating Source and
4074             Destination.
4075         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4076         (TestWebKitAPI::TEST):
4077             WebCore::AdClickAttribution now takes a URL when creating Source and
4078             Destination.
4079
4080 2019-02-27  Antoine Quint  <graouts@apple.com>
4081
4082         Support Pointer Events on macOS
4083         https://bugs.webkit.org/show_bug.cgi?id=195008
4084         <rdar://problem/47454419>
4085
4086         Reviewed by Dean Jackson.
4087
4088         * DumpRenderTree/mac/DumpRenderTree.mm:
4089         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4090         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4091
4092 2019-02-26  Mark Lam  <mark.lam@apple.com>
4093
4094         Remove remaining poisoning code.
4095         https://bugs.webkit.org/show_bug.cgi?id=194138
4096
4097         Reviewed by Saam Barati.
4098
4099         * TestWebKitAPI/CMakeLists.txt:
4100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4101         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4102         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4103         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4104         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4105         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4106         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4107
4108 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4109
4110         Move ephemeral local storage from WebProcess to UIProcess
4111         https://bugs.webkit.org/show_bug.cgi?id=195074
4112         <rdar://problem/47937975>
4113
4114         Reviewed by Geoff Garen.
4115
4116         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4117
4118 2019-02-20  Jer Noble  <jer.noble@apple.com>
4119
4120         [Cocoa] Media elements will restart network buffering just before suspending
4121         https://bugs.webkit.org/show_bug.cgi?id=193691
4122
4123         Reviewed by Eric Carlson.
4124
4125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4126         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4127         (TEST):
4128
4129 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4130
4131         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4132         https://bugs.webkit.org/show_bug.cgi?id=191652
4133
4134         Reviewed by Alex Christensen.
4135
4136         Fix WinCairo MiniBrowser behavior of authentication dialog.
4137
4138         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4139         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4140
4141 2019-02-26  Youenn Fablet  <youenn@apple.com>
4142
4143         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4144         https://bugs.webkit.org/show_bug.cgi?id=195028
4145         <rdar://problem/48243733>
4146
4147         Reviewed by Eric Carlson.
4148
4149         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4150
4151 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4152
4153         [WPE] Add API for webview background color configuration
4154         https://bugs.webkit.org/show_bug.cgi?id=192305
4155
4156         Reviewed by Michael Catanzaro.
4157
4158         * MiniBrowser/wpe/main.cpp:
4159         (main): Add a new option to configure the webview background
4160         color. Example: --bg-color=transparent.
4161         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4162         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4163         (beforeAll): Ditto.
4164
4165 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4166
4167         scalableNativeWebpageParameters() is not preserved on new page navigation.
4168         https://bugs.webkit.org/show_bug.cgi?id=194892
4169         <rdar://problem/47538280>
4170
4171         Reviewed by Wenson Hsieh.
4172         
4173         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4174
4175         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4176         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4177         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4178         (WTR::UIScriptController::allowsViewportShrinkToFit):
4179         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4180         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4181         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4182         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4183         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4184         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4185
4186 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4187
4188         [ews-app] Add model for handling multiple Buildbot instances
4189         https://bugs.webkit.org/show_bug.cgi?id=194863
4190
4191         Reviewed by Stephanie Lewis.
4192
4193         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4194
4195 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4196
4197         [ews-app] Remove BuilderMapping table
4198         https://bugs.webkit.org/show_bug.cgi?id=194961
4199
4200         Reviewed by Stephanie Lewis.
4201
4202         Store builder name directly in build table, instead of having a separate
4203         table for it.
4204
4205         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4206         * BuildSlaveSupport/ews-app/ews/models/build.py:
4207         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4208         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4209
4210 2019-02-25  John Wilander  <wilander@apple.com>
4211
4212         Introduce and adopt new class RegistrableDomain for eTLD+1
4213         https://bugs.webkit.org/show_bug.cgi?id=194791
4214         <rdar://problem/48179240>
4215
4216         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4217
4218         This patch adds an API test and replaces two instances of
4219         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4220
4221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4222         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4223         (TestWebKitAPI::TEST):
4224             Changed two strings to make sure the registrable domains are still considered
4225             invalid and pass the test.
4226         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4227         (TestWebKitAPI::TEST):
4228         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4229         (WTR::InjectedBundle::didReceiveMessageToPage):
4230
4231 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4232
4233         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4234         https://bugs.webkit.org/show_bug.cgi?id=195001
4235
4236         Reviewed by Carlos Garcia Campos.
4237
4238         API version 1.0 always includes the functionality previously guarded with
4239         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4240         unconditionally.
4241
4242         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4243         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4244         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4245         (WebViewTest::showInWindow): Ditto.
4246         (WebViewTest::hideView): Ditto.
4247         * wpe/backends/HeadlessViewBackend.cpp:
4248         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4249         * wpe/backends/ViewBackend.cpp:
4250         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4251         * wpe/backends/WindowViewBackend.cpp:
4252         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4253         WPE_BACKEND_CHECK_VERSION().
4254         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4255
4256 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4257
4258         [Flatpak] Add support for flatpak > 1.1.2
4259         https://bugs.webkit.org/show_bug.cgi?id=194088
4260
4261         Flatpak 1.2 is now out so we need to support that
4262         version now.
4263
4264         Reviewed by Michael Catanzaro.
4265
4266         * flatpak/flatpakutils.py:
4267         (check_flatpak):
4268         (FlatpakPackages.__init__):
4269         (FlatpakPackages.__detect_packages):
4270         (FlatpakPackages.__detect_packages.in):
4271         (FlatpakRepos.update):
4272
4273 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4274
4275         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4276         https://bugs.webkit.org/show_bug.cgi?id=194998
4277
4278         Reviewed by Carlos Garcia Campos.
4279
4280         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4281         to a Git checkout and using the latest commit containing various fixes
4282         and improvements.
4283
4284 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4285
4286         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4287         https://bugs.webkit.org/show_bug.cgi?id=194981
4288
4289         Reviewed by Žan Doberšek.
4290
4291         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4292         (TestWebKitAPI::TEST):
4293
4294 2019-02-23  Keith Miller  <keith_miller@apple.com>
4295
4296         Add new mac target numbers
4297         https://bugs.webkit.org/show_bug.cgi?id=194955
4298
4299         Reviewed by Tim Horton.
4300
4301         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4302         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4303         * MiniBrowser/Configurations/Base.xcconfig:
4304         * TestWebKitAPI/Configurations/Base.xcconfig:
4305         * WebKitTestRunner/Configurations/Base.xcconfig:
4306
4307 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4308
4309         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4310         https://bugs.webkit.org/show_bug.cgi?id=194846
4311
4312         Reviewed by Don Olmstead.
4313
4314         Added _search_paths() and _port_specific_expectations_files() for
4315         WinCairoPort.
4316
4317         * Scripts/webkitpy/port/win.py:
4318         (WinCairoPort.default_baseline_search_path):
4319         (WinCairoPort):
4320         (WinCairoPort._port_specific_expectations_files):
4321         (WinCairoPort._search_paths):
4322
4323 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4324
4325         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4326         https://bugs.webkit.org/show_bug.cgi?id=194963
4327
4328         Reviewed by Dean Jackson.
4329
4330         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4331         Do a `contains` check instead of `equals`, because in debug builds we
4332         put the GraphicsLayer pointer in a prefix.
4333
4334 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4335
4336         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4337         https://bugs.webkit.org/show_bug.cgi?id=194873
4338         <rdar://problem/46701974>
4339
4340         Reviewed by Tim Horton.
4341
4342         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4343
4344         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4345         (WTR::UIScriptController::menuRect const):
4346         (WTR::UIScriptController::isShowingMenu const):
4347         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4348         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4349         (WTR::UIScriptController::menuRect const):
4350
4351         Add a function to query the bounds of the callout menu in content coordinates.
4352
4353         (WTR::UIScriptController::isShowingMenu const):
4354
4355         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4356
4357         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4358         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4359         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4360         (WTR::UIScriptController::rectForMenuAction const):
4361         (WTR::UIScriptController::menuRect const):
4362         (WTR::UIScriptController::isShowingMenu const):
4363         (WTR::findViewInHierarchyOfType): Deleted.
4364
4365 2019-02-22  Chris Dumez  <cdumez@apple.com>
4366
4367         Regression(PSON) Unable to preview password-