Add modern API for overriding the page's specified viewport configuration
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2
3         Add modern API for overriding the page's specified viewport configuration
4         https://bugs.webkit.org/show_bug.cgi?id=167734
5         <rdar://problem/30331795>
6
7         Reviewed by Simon Fraser.
8
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
11
12 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
13
14         Add support for incremental bytecode cache updates
15         https://bugs.webkit.org/show_bug.cgi?id=195000
16
17         Reviewed by Filip Pizlo.
18
19         Exit when the initial run to generate bytecode fails.
20
21         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
22
23 2019-04-10  Alex Christensen  <achristensen@webkit.org>
24
25         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
26         https://bugs.webkit.org/show_bug.cgi?id=196744
27         <rdar://49415309>
28
29         Reviewed by Chris Dumez.
30
31         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
32         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
33
34 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
35
36         Add a way to opt into modern compatibility mode in layout tests
37         https://bugs.webkit.org/show_bug.cgi?id=196770
38         <rdar://problem/49777550>
39
40         Reviewed by Antoine Quint.
41
42         Add a new test option to enable modern compatibility mode in layout tests.
43
44         * WebKitTestRunner/TestController.cpp:
45         (WTR::updateTestOptionsFromTestHeader):
46         * WebKitTestRunner/TestController.h:
47         * WebKitTestRunner/TestOptions.h:
48         (WTR::TestOptions::hasSameInitializationOptions const):
49         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
50         (WTR::TestController::platformCreateWebView):
51         (WTR::TestController::enableModernCompatibilityMode):
52
53 2019-04-10  Andy Estes  <aestes@apple.com>
54
55         Try to fix the 32-bit watchOS build.
56
57         * TestWebKitAPI/cocoa/TestWKWebView.mm:
58         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
59
60 2019-04-10  Antoine Quint  <graouts@apple.com>
61
62         Enable Pointer Events on watchOS
63         https://bugs.webkit.org/show_bug.cgi?id=196771
64         <rdar://problem/49040909>
65
66         Reviewed by Dean Jackson.
67
68         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
69
70 2019-04-10  Philippe Normand  <pnormand@igalia.com>
71
72         Unreviewed. Fix WPE accessibility tests after r244059.
73
74         We are failing to load the injected bundle due to undefined symbol
75         AccessibilityUIElement::replaceTextInRange().
76
77         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
78         (WTR::AccessibilityUIElement::replaceTextInRange):
79
80 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
81
82         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
83         https://bugs.webkit.org/show_bug.cgi?id=196727
84
85         Reviewed by Fujii Hironori.
86
87         * MiniBrowser/win/WebKitBrowserWindow.cpp:
88         (WebKitBrowserWindow::create):
89
90 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
91
92         [ews-build] Add unit tests for PrintConfiguration
93         https://bugs.webkit.org/show_bug.cgi?id=196752
94
95         Reviewed by Dewei Zhu.
96
97         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
98
99 2019-04-09  Keith Rollin  <krollin@apple.com>
100
101         Unreviewed build maintenance -- update .xcfilelists.
102
103         * DumpRenderTree/DerivedSources-input.xcfilelist:
104         * DumpRenderTree/DerivedSources-output.xcfilelist:
105
106 2019-04-09  Zalan Bujtas  <zalan@apple.com>
107
108         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
109         https://bugs.webkit.org/show_bug.cgi?id=196743
110         <rdar://problem/43897551>
111
112         Reviewed by Tim Horton.
113
114         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
115         (TEST):
116
117 2019-04-09  Youenn Fablet  <youenn@apple.com>
118
119         Close service worker database on network process suspension
120         https://bugs.webkit.org/show_bug.cgi?id=196623
121         <rdar://problem/48930869>
122
123         Reviewed by Alex Christensen.
124
125         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
126
127 2019-04-09  Daniel Bates  <dabates@apple.com>
128
129         [iPad] Should open popover when the spacebar is pressed
130         https://bugs.webkit.org/show_bug.cgi?id=196360
131         <rdar://problem/49389129>
132
133         Reviewed by Brent Fulgham.
134
135         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
136
137         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
138         (WTR::UIScriptController::isShowingPopover const): Added.
139         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
140         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
141         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
142         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
143         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
144         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
145         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
146         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
147         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
148         (WTR::UIScriptController::isShowingPopover const): Added.
149         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
150         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
151         * TestRunnerShared/UIScriptContext/UIScriptController.h:
152         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
153         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
154         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
155         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
156         (-[TestRunnerWKWebView _willPresentPopover]): Added.
157         (-[TestRunnerWKWebView _didDismissPopover]): Added.
158         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
159         (WTR::UIScriptController::isShowingPopover const): Added.
160         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
161         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
162
163 2019-04-09  Alex Christensen  <achristensen@webkit.org>
164
165         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
166         https://bugs.webkit.org/show_bug.cgi?id=196665
167         <rdar://45115669>
168
169         Reviewed by Geoff Garen.
170
171         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
172         (goBack):
173         (+[SimpleLookupContext sharedLookupContext]):
174         (-[SimpleLookupContext lookUpURL:completionHandler:]):
175         (TEST):
176         (+[Simple3LookupContext sharedLookupContext]): Deleted.
177         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
178
179 2019-04-09  John Wilander  <wilander@apple.com>
180
181         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
182         https://bugs.webkit.org/show_bug.cgi?id=196558
183         <rdar://problem/47650245>
184
185         Reviewed by Youenn Fablet.
186
187         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
188         (TestWebKitAPI::TEST):
189             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
190
191 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
192
193         [CMake] Apple builds should use ICU_INCLUDE_DIRS
194         https://bugs.webkit.org/show_bug.cgi?id=196720
195
196         Reviewed by Konstantin Tokarev.
197
198         * TestWebKitAPI/PlatformMac.cmake:
199
200 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
201
202         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
203         https://bugs.webkit.org/show_bug.cgi?id=196694
204         <rdar://problem/48388734>
205
206         Rubber-stamped by Aakash Jain.
207
208         * Scripts/webkitpy/port/image_diff.py:
209         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
210         * Scripts/webkitpy/port/server_process.py:
211         (ServerProcess.has_available_stdout): Check if stdout has data in it.
212         (ServerProcess._wait_for_data_and_update_buffers_using_select):
213         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
214         * Scripts/webkitpy/port/server_process_mock.py:
215         (MockServerProcess.has_available_stdout):
216         * Scripts/webkitpy/port/server_process_unittest.py:
217         (TestServerProcess.serial_test_basic):
218
219 2019-04-09  Jer Noble  <jer.noble@apple.com>
220
221         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
222         https://bugs.webkit.org/show_bug.cgi?id=196097
223
224         Reviewed by Eric Carlson.
225
226         Drive-by bug fix: allow tests to play audio without a user gesture by default.
227
228         * DumpRenderTree/mac/DumpRenderTree.mm:
229         (resetWebPreferencesToConsistentValues):
230         * WebKitTestRunner/TestController.cpp:
231         (WTR::TestController::resetPreferencesToConsistentValues):
232
233 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
234
235         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
236         https://bugs.webkit.org/show_bug.cgi?id=196690
237
238         Reviewed by Michael Catanzaro.
239
240         * QueueStatusServer/config/queues.py:
241         * Scripts/webkitpy/common/config/ews.json:
242         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
243         (test_ews_name):
244
245 2019-04-09  Chris Dumez  <cdumez@apple.com>
246
247         Loads using loadHTMLString() cause flashing when process-swapping
248         https://bugs.webkit.org/show_bug.cgi?id=196714
249         <rdar://problem/49637354>
250
251         Reviewed by Antti Koivisto.
252
253         Add API test coverage.
254
255         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
256
257 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
258
259         Unreviewed. Fix ATK accessibility tests after r244059.
260
261         We are failing to load the injected bundle due to undefined symbol
262         AccessibilityUIElement::replaceTextInRange().
263
264         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
265         (WTR::AccessibilityUIElement::replaceTextInRange):
266
267 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
268
269         AX: Support API: accessibilityReplaceRange:withText
270         https://bugs.webkit.org/show_bug.cgi?id=196636
271
272         Unreviewed build fix for Windows port.
273
274         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
275         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
276
277 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
278
279         [CMake][WinCairo] Separate copied headers into different directories
280         https://bugs.webkit.org/show_bug.cgi?id=196655
281
282         Reviewed by Michael Catanzaro.
283
284         * DumpRenderTree/CMakeLists.txt:
285         * MiniBrowser/win/CMakeLists.txt:
286         * TestWebKitAPI/CMakeLists.txt:
287         * TestWebKitAPI/PlatformWin.cmake:
288
289 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
290
291         Log stack-trace for run-webkit-tests when interrupted
292         https://bugs.webkit.org/show_bug.cgi?id=176393
293         <rdar://problem/34262310>
294
295         Reviewed by Lucas Forschler.
296
297         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
298         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
299         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
300         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
301         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
302         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
303         (main): Set handlers to log stack trace on interruption.
304
305 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
306
307         AX: Support API: accessibilityReplaceRange:withText
308         https://bugs.webkit.org/show_bug.cgi?id=196636
309
310         Unreviewed build fix for Windows port.
311
312         * DumpRenderTree/AccessibilityUIElement.cpp:
313         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
314
315 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
316
317         [ews-build] Scripts using Buildbot API have CORS error
318         https://bugs.webkit.org/show_bug.cgi?id=196709
319
320         Reviewed by Alexey Proskuryakov.
321
322         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
323
324 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
325
326         AX: Support API: accessibilityReplaceRange:withText
327         https://bugs.webkit.org/show_bug.cgi?id=196636
328
329         Reviewed by Daniel Bates.
330
331         * DumpRenderTree/AccessibilityUIElement.cpp:
332         (replaceTextInRangeCallback):
333         (AccessibilityUIElement::replaceTextInRange):
334         (AccessibilityUIElement::getJSClass):
335         * DumpRenderTree/AccessibilityUIElement.h:
336         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
337         (AccessibilityUIElement::replaceTextInRange):
338         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
339         (AccessibilityUIElement::replaceTextInRange):
340         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
341         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
342         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
343         (WTR::AccessibilityUIElement::replaceTextInRange):
344         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
345         (WTR::AccessibilityUIElement::replaceTextInRange):
346
347 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
348
349         [iOS] Do not allow starting selection drags when selection views are not visible
350         https://bugs.webkit.org/show_bug.cgi?id=196686
351         <rdar://problem/49399192>
352
353         Reviewed by Tim Horton.
354
355         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
356         also add some new API tests to cover scenarios where the web view is not first responder.
357
358         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
359         (TestWebKitAPI::TEST):
360         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
361
362         Add a switch to optionally make the web view first responder when starting the simulated drag.
363
364         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
365         (-[DragAndDropSimulator initWithWebView:]):
366         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
367
368 2019-04-08  Justin Fan  <justin_fan@apple.com>
369
370         [Web GPU] Fix Web GPU experimental feature on iOS
371         https://bugs.webkit.org/show_bug.cgi?id=196632
372
373         Reviewed by Myles C. Maxfield.
374
375         Properly make Web GPU available on iOS 11+.
376
377         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
378
379 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
380
381         [ews-build] Do not upload archive when Compile Fails
382         https://bugs.webkit.org/show_bug.cgi?id=196674
383
384         Reviewed by Alexey Proskuryakov.
385
386         * BuildSlaveSupport/ews-build/factories.py:
387         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
388         * BuildSlaveSupport/ews-build/steps.py:
389         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
390         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
391         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
392
393 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
394
395         Enable DFG on MIPS
396         https://bugs.webkit.org/show_bug.cgi?id=196689
397
398         Reviewed by Žan Doberšek.
399
400         Since the bytecode change, we enabled the baseline JIT on mips in
401         r240432, but DFG is still missing. With this change, all tests are
402         passing on a ci20 board.
403
404         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
405
406 2019-04-08  Philippe Normand  <pnormand@igalia.com>
407
408         [Flatpak] Second run update-webkitwpe-flatpak fails
409         https://bugs.webkit.org/show_bug.cgi?id=192702
410
411         Reviewed by Carlos Garcia Campos.
412
413         * flatpak/flatpakutils.py:
414         (FlatpakObject.flatpak): Fix typo.
415         (FlatpakPackage.install): When installing, also update to the configured remote commit.
416         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
417
418 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
419
420         [GTK][WPE] outlook.live.com displays old-fashioned UI
421         https://bugs.webkit.org/show_bug.cgi?id=196642
422
423         Reviewed by Carlos Garcia Campos.
424
425         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
426         (TestWebKitAPI::TEST): New Mac platform quirk test.
427
428 2019-04-07  Commit Queue  <commit-queue@webkit.org>
429
430         Unreviewed, rolling out r243956.
431         https://bugs.webkit.org/show_bug.cgi?id=196688
432
433         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
434         by aakashjain on #webkit).
435
436         Reverted changeset:
437
438         "Clicking "Go Back" from a safe browsing warning from an
439         iframe should navigate the WKWebView back to the previous
440         page"
441         https://bugs.webkit.org/show_bug.cgi?id=196665
442         https://trac.webkit.org/changeset/243956
443
444 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
445
446         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
447         https://bugs.webkit.org/show_bug.cgi?id=196669
448
449         Reviewed by Geoffrey Garen.
450
451         Added three new unit tests for WeakHashSet.
452
453         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
454         (WTF_WeakPtr.WeakHashSetConstObjects):
455         (WTF_WeakPtr.WeakHashSetComputesEmpty):
456         (WTF_WeakPtr.WeakHashSetComputeSize):
457
458 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
459
460         Hide next and previous form control buttons when WKWebView is editable
461         https://bugs.webkit.org/show_bug.cgi?id=196672
462         <rdar://problem/35625321>
463
464         Reviewed by Tim Horton.
465
466         Add a new API test.
467
468         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
469         (-[TestWKWebView lastTrailingBarButtonGroup]):
470         (TestWebKitAPI::TEST):
471         * TestWebKitAPI/ios/UIKitSPI.h:
472
473 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
474
475         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
476         https://bugs.webkit.org/show_bug.cgi?id=196077
477         <rdar://problem/49108202>
478
479         Reviewed by Chris Dumez.
480
481         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
482         on new web view.
483
484         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
485
486 2019-04-05  Saam Barati  <sbarati@apple.com>
487
488         Make compare-results understand MotionMark
489         https://bugs.webkit.org/show_bug.cgi?id=196666
490
491         Reviewed by Yusuke Suzuki.
492
493         * Scripts/compare-results:
494         (PLT5Results):
495         (detectMotionMark):
496         (detectMotionMark1_1):
497         (motionMarkResults):
498         (motionMark1_1Results):
499         (detectBenchmark):
500         (biggerIsBetter):
501         (main):
502
503 2019-04-05  Alex Christensen  <achristensen@webkit.org>
504
505         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
506         https://bugs.webkit.org/show_bug.cgi?id=196665
507         <rdar://45115669>
508
509         Reviewed by Geoff Garen.
510
511         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
512         (goBack):
513         (+[SimpleLookupContext sharedLookupContext]):
514         (-[SimpleLookupContext lookUpURL:completionHandler:]):
515         (TEST):
516         (+[Simple3LookupContext sharedLookupContext]): Deleted.
517         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
518
519 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
520
521         [ews-build] Add configuration and architecture for windows builders
522         https://bugs.webkit.org/show_bug.cgi?id=196660
523
524         Reviewed by Lucas Forschler.
525
526         * BuildSlaveSupport/ews-build/config.json:
527
528 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
529
530         webkitpy: Don't run subsequent rounds if interrupted
531         https://bugs.webkit.org/show_bug.cgi?id=196646
532
533         Reviewed by Aakash Jain.
534
535         * Scripts/webkitpy/layout_tests/controllers/manager.py:
536         (Manager.run): Bail out if interrupted.
537
538 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
539
540         Test sessionStorage in PSON private browsing mode
541         https://bugs.webkit.org/show_bug.cgi?id=196561
542
543         Reviewed by Alex Christensen.
544
545         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
546
547 2019-04-05  Commit Queue  <commit-queue@webkit.org>
548
549         Unreviewed, rolling out r243833.
550         https://bugs.webkit.org/show_bug.cgi?id=196645
551
552         This change breaks build of WPE and GTK ports (Requested by
553         annulen on #webkit).
554
555         Reverted changeset:
556
557         "[CMake][WTF] Mirror XCode header directories"
558         https://bugs.webkit.org/show_bug.cgi?id=191662
559         https://trac.webkit.org/changeset/243833
560
561 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
562
563         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
564         https://bugs.webkit.org/show_bug.cgi?id=196635
565
566         Reviewed by Antti Koivisto.
567         
568         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
569         for a test to enable async frame scrolling via:
570             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
571         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
572         
573         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
574
575         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
576         (WTR::InjectedBundle::beginTesting):
577         * WebKitTestRunner/TestController.cpp:
578         (WTR::TestController::resetPreferencesToConsistentValues):
579
580 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
581
582         Use a correct LC_RPATH when building with ASan
583         https://bugs.webkit.org/show_bug.cgi?id=196576
584
585         Reviewed by David Kilzer.
586
587         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
588         so that ../Frameworks is checked. This is simpler and more reliable than updating
589         each SPC service xcconfig.
590
591 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
592
593         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
594         https://bugs.webkit.org/show_bug.cgi?id=196629
595
596         Reviewed by Lucas Forschler.
597
598         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
599
600 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
601
602         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
603         https://bugs.webkit.org/show_bug.cgi?id=196618
604
605         Reviewed by Lucas Forschler.
606
607         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
608         (StatusBubble): Added QUEUE_TRIGGERS.
609         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
610         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
611         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
612         its parent(builder).
613
614 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
615
616         [ews-app] Status-bubble steps are sometimes displayed in reverse order
617         https://bugs.webkit.org/show_bug.cgi?id=196625
618
619         Reviewed by Lucas Forschler.
620
621         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
622         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
623
624 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
625
626         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
627         https://bugs.webkit.org/show_bug.cgi?id=196630
628
629         Reviewed by Wenson Hsieh.
630
631         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
632
633 2019-04-04  Youenn Fablet  <youenn@apple.com>
634
635         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
636         https://bugs.webkit.org/show_bug.cgi?id=196543
637
638         Reviewed by Alex Christensen.
639
640         * WebKitTestRunner/TestController.cpp:
641         (WTR::TestController::generatePageConfiguration):
642
643 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
644
645         [ews-app] Status bubble should not display skipped buildbot steps
646         https://bugs.webkit.org/show_bug.cgi?id=196584
647
648         Reviewed by Lucas Forschler.
649
650         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
651
652 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
653
654         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
655         https://bugs.webkit.org/show_bug.cgi?id=196620
656
657         Reviewed by Lucas Forschler.
658
659         * BuildSlaveSupport/ews-app/ews/config.py:
660
661 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
662
663         [Win] DumpRenderTreeWatchDog.py is not checked into source
664         https://bugs.webkit.org/show_bug.cgi?id=196567
665         <rdar://problem/49525901>
666
667         Reviewed by Lucas Forschler.
668
669         This script is used on Win EWS bots to terminate hanging DRT processes.
670
671         * EWSTools/dumprendertreewatchdog.py: Added.
672
673 2019-04-04  Chris Dumez  <cdumez@apple.com>
674
675         Unreviewed, roll out r243858 which made tests time out.
676
677         Disable new API tests on Windows instead.
678
679         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
680         (TestWebKitAPI::TEST):
681
682 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
683
684         [ATK] Cleanup WebPageAccessibilityObjectAtk
685         https://bugs.webkit.org/show_bug.cgi?id=196537
686
687         Reviewed by Michael Catanzaro.
688
689         Also consider files under atk directories as exceptions for GObject conventions.
690
691         * Scripts/webkitpy/style/checkers/cpp.py:
692         (check_identifier_name_in_declaration):
693
694 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
695
696         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
697         https://bugs.webkit.org/show_bug.cgi?id=196588
698         <rdar://problem/49365787>
699
700         Unreviewed build fix for Windows port.
701
702         error C3861: 'kill': identifier not found
703
704         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
705         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
706
707 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
708
709         [ews-build] Cancel build and similar operations should have authentication
710         https://bugs.webkit.org/show_bug.cgi?id=196520
711
712         Reviewed by Dewei Zhu.
713
714         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
715         environment variables.
716
717 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
718
719         [ews-build] Do not trigger queues which are not in production yet
720         https://bugs.webkit.org/show_bug.cgi?id=196581
721
722         Reviewed by Dewei Zhu.
723
724         * BuildSlaveSupport/ews-build/config.json:
725
726 2019-04-03  Chris Dumez  <cdumez@apple.com>
727
728         Unreviewed, fix typo in the name of API test added in r243848.
729
730         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
731         (TestWebKitAPI::TEST):
732
733 2019-04-03  Chris Dumez  <cdumez@apple.com>
734
735         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
736         https://bugs.webkit.org/show_bug.cgi?id=196588
737         <rdar://problem/49365787>
738
739         Reviewed by Ryosuke Niwa.
740
741         Add API test coverage.
742
743         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
744         (TestWebKitAPI::nullJavaScriptCallback):
745         (TestWebKitAPI::didCrashCheckFrames):
746         (TestWebKitAPI::TEST):
747
748 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
749
750         run-webkit-tests: Upload test results (new results database)
751         https://bugs.webkit.org/show_bug.cgi?id=196577
752         <rdar://problem/34841155>
753
754         Reviewed by Lucas Forschler.
755
756         * Scripts/webkitpy/layout_tests/controllers/manager.py:
757         (Manager.run): Upload results after each device shard, since the configuration will be
758         different for each device.
759         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
760         uploaded to a results database.
761         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
762         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
763
764 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
765
766         -apple-trailing-word is needed for browser detection
767         https://bugs.webkit.org/show_bug.cgi?id=196575
768
769         Unreviewed.
770
771         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
772
773 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
774
775         [CMake][WTF] Mirror XCode header directories
776         https://bugs.webkit.org/show_bug.cgi?id=191662
777
778         Reviewed by Konstantin Tokarev.
779
780         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
781         builds.
782
783         * CMakeLists.txt:
784         * DumpRenderTree/CMakeLists.txt:
785         * DumpRenderTree/PlatformWin.cmake:
786         * MiniBrowser/win/CMakeLists.txt:
787         * TestWebKitAPI/CMakeLists.txt:
788         * TestWebKitAPI/PlatformWin.cmake:
789         * WebKitTestRunner/PlatformGTK.cmake:
790         * WebKitTestRunner/PlatformWin.cmake:
791
792 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
793
794         [ews-app] Status bubble should not display certain infrastructure status messages
795         https://bugs.webkit.org/show_bug.cgi?id=196550
796
797         Reviewed by Lucas Forschler.
798
799         Do not display the steps which are un-needed for end-user. This information is still avaiable
800         if the user click on the bubble and look at the Buildbot build.
801         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
802         (StatusBubble._steps_messages):
803         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
804
805 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
806
807         [ews-build] Use https for sending data to ews-app
808         https://bugs.webkit.org/show_bug.cgi?id=196492
809
810         Reviewed by Lucas Forschler.
811
812         * BuildSlaveSupport/ews-build/events.py:
813
814 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
815
816         Remove support for -apple-trailing-word
817         https://bugs.webkit.org/show_bug.cgi?id=196525
818
819         Reviewed by Zalan Bujtas.
820
821         This CSS property is nonstandard and not used.
822
823         * Scripts/webkitperl/FeatureList.pm:
824         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
825
826 2019-04-03  Youenn Fablet  <youenn@apple.com>
827
828         Add a test for DOMCache on multiple browsing in case of private browsing
829         https://bugs.webkit.org/show_bug.cgi?id=196524
830
831         Reviewed by Alex Christensen.
832
833         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
834         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
835
836 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
837
838         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
839         https://bugs.webkit.org/show_bug.cgi?id=196540
840
841         Reviewed by Aakash Jain.
842
843         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
844
845 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
846
847         Add plumbing for a compatibility mode preference in WebKit
848         https://bugs.webkit.org/show_bug.cgi?id=196005
849
850         Reviewed by Tim Horton.
851
852         Add new API tests.
853
854         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
855         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
856
857 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
858
859         [WPE][GTK] Update libsrtp dependency package for Debian
860         https://bugs.webkit.org/show_bug.cgi?id=196528
861
862         Reviewed by Frédéric Wang.
863
864         * gtk/install-dependencies:
865         * wpe/install-dependencies:
866
867 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
868
869         [WK2] Add support for Window's beforeprint / afterprint events
870         https://bugs.webkit.org/show_bug.cgi?id=196478
871         <rdar://problem/49535124>
872
873         Unreviewed build fix for MSVC.
874
875         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
876
877         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
878
879         * WebKitTestRunner/TestController.cpp:
880         (WTR::printFrame): Use int and float literals.
881
882 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
883
884         [ews-build] Reassign bots to queues
885
886         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
887
888 2019-04-02  Chris Dumez  <cdumez@apple.com>
889
890         [WK2] Add support for Window's beforeprint / afterprint events
891         https://bugs.webkit.org/show_bug.cgi?id=196478
892
893         Reviewed by Alex Christensen.
894
895         Add minimal implementation for printFrame in WebKitTestRunner.
896
897         * WebKitTestRunner/TestController.cpp:
898         (WTR::printFrame):
899         (WTR::TestController::createOtherPage):
900         (WTR::TestController::createWebViewWithOptions):
901
902 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
903
904         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
905         https://bugs.webkit.org/show_bug.cgi?id=196491
906
907         Reviewed by Lucas Forschler.
908
909         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
910
911 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
912
913         [ews-build] Configure buildbot try credentials in environment variables
914         https://bugs.webkit.org/show_bug.cgi?id=196501
915
916         Reviewed by Lucas Forschler.
917
918         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
919         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
920         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
921
922 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
923
924         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
925         https://bugs.webkit.org/show_bug.cgi?id=196496
926         <rdar://problem/49521634>
927
928         Reviewed by Chris Dumez.
929
930         Add new API tests (see WebKit ChangeLog for more detail).
931
932         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
933         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
934         (TEST):
935
936 2019-04-02  David Kilzer  <ddkilzer@apple.com>
937
938         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
939         <https://webkit.org/b/196499>
940
941         Reviewed by Alexey Proskuryakov.
942
943         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
944         ENABLE_ADDRESS_SANITIZER.
945
946 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
947
948         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
949         https://bugs.webkit.org/show_bug.cgi?id=182757
950
951         Reviewed by Don Olmstead.
952
953         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
954         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
955
956 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
957
958         run-api-tests: Upload test results
959         https://bugs.webkit.org/show_bug.cgi?id=196323
960         <rdar://problem/49356714>
961
962         Reviewed by Lucas Forschler.
963
964         * Scripts/webkitpy/api_tests/manager.py:
965         (Manager):
966         (Manager.run): Upload results to a results database.
967         * Scripts/webkitpy/api_tests/run_api_tests.py:
968         (parse_args): Add upload arguments.
969         * Scripts/webkitpy/port/base.py:
970         (Port):
971         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
972         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
973         with commits from any other associated repositories.
974         * Scripts/webkitpy/port/device.py:
975         (Device):
976         (Device.build_version): Access build_versoin of underlying platform device.
977         * Scripts/webkitpy/port/ios_simulator_unittest.py:
978         (IOSSimulatorTest):
979         (IOSSimulatorTest.test_configuration_for_upload):
980         * Scripts/webkitpy/port/device_port.py:
981         (DevicePort):
982         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
983         the same as the machine uploading results.
984         * Scripts/webkitpy/port/mac.py:
985         (MacPort):
986         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
987         * Scripts/webkitpy/port/mac_unittest.py:
988         (MacTest):
989         (MacTest.test_configuration_for_upload):
990         * Scripts/webkitpy/xcode/simulated_device.py:
991         (SimulatedDeviceManager._create_device_with_runtime):
992         (SimulatedDevice.__init__): Create simulated device with a build_version.
993         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
994         (test_existing_simulator):
995
996 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
997
998         Remove extra newline characters (Follow-up fix to r243707)
999
1000         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1001
1002 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1003
1004         [ews-app] Use API_KEY to accept results data
1005         https://bugs.webkit.org/show_bug.cgi?id=196461
1006
1007         Reviewed by Dewei Zhu.
1008
1009         * BuildSlaveSupport/ews-app/ews/views/results.py:
1010         (Results.post): Validate EWS_API_KEY before accepting any data.
1011         * BuildSlaveSupport/ews-build/events.py:
1012         (Events.sendData): Send EWS_API_KEY if available along with event data.
1013
1014 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1015
1016         Unable to copy and paste a PDF from Notes into Mail compose body
1017         https://bugs.webkit.org/show_bug.cgi?id=196442
1018         <rdar://problem/48573098>
1019
1020         Reviewed by Tim Horton.
1021
1022         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1023         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1024         to be specified on the item providers.
1025
1026         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1027         (TestWebKitAPI::mapItemForTesting):
1028         (TestWebKitAPI::contactItemForTesting):
1029
1030 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1031
1032         Make UIWKDocumentContext rects per-character instead of per-word
1033         https://bugs.webkit.org/show_bug.cgi?id=196459
1034
1035         Reviewed by Wenson Hsieh.
1036
1037         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1038         (TEST):
1039         Adjust test results due to switching to per-character rects.
1040
1041 2019-04-01  Chris Dumez  <cdumez@apple.com>
1042
1043         UIProcess crash when a prewarmed process is terminated
1044         https://bugs.webkit.org/show_bug.cgi?id=196451
1045         <rdar://problem/49245471>
1046
1047         Reviewed by Geoffrey Garen.
1048
1049         Add API test coverage.
1050
1051         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1052         (TEST):
1053
1054 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1055
1056         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1057         https://bugs.webkit.org/show_bug.cgi?id=196449
1058
1059         Reviewed by Lucas Forschler.
1060
1061         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1062         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1063         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1064         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1065
1066 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1067
1068         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1069         https://bugs.webkit.org/show_bug.cgi?id=196444
1070
1071         Reviewed by Lucas Forschler.
1072
1073         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1074
1075 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1076
1077         Add SPI to canonicalize NSURLs with WTF::URL
1078         https://bugs.webkit.org/show_bug.cgi?id=196415
1079         <rdar://problem/44980271>
1080
1081         Reviewed by Darin Adler.
1082
1083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1084         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1085         (TestWebKitAPI::TEST):
1086
1087 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1088
1089         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1090         https://bugs.webkit.org/show_bug.cgi?id=196441
1091
1092         Reviewed by Carlos Garcia Campos.
1093
1094         Don't cache the wpe_view_backend object that might not exist yet at the
1095         time of EventSenderProxy constructor invocation, but instead retrieve
1096         that object whenever it's required for event dispatching. This should
1097         avoid crashes in this constructor now that it's invoked before any
1098         PlatformWindow has been set up (as changed in r243496).
1099
1100         * WebKitTestRunner/EventSenderProxy.h:
1101         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1102         (WTR::viewBackend):
1103         (WTR::EventSenderProxy::EventSenderProxy):
1104         (WTR::EventSenderProxy::mouseDown):
1105         (WTR::EventSenderProxy::mouseUp):
1106         (WTR::EventSenderProxy::mouseMoveTo):
1107         (WTR::EventSenderProxy::mouseScrollBy):
1108         (WTR::EventSenderProxy::keyDown):
1109         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1110
1111 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1112
1113         [Win][WebKit] MiniBrowser should support high DPI display
1114         https://bugs.webkit.org/show_bug.cgi?id=196391
1115
1116         Reviewed by Alex Christensen.
1117
1118         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1119         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1120         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1121         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1122
1123 2019-03-31  Sam Weinig  <weinig@apple.com>
1124
1125         Remove more i386 specific configurations
1126         https://bugs.webkit.org/show_bug.cgi?id=196430
1127
1128         Reviewed by Alexey Proskuryakov.
1129
1130         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1131         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1132
1133 2019-03-31  Andy Estes  <aestes@apple.com>
1134
1135         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1136         https://bugs.webkit.org/show_bug.cgi?id=196433
1137         <rdar://problem/49293305>
1138
1139         Reviewed by Tim Horton.
1140
1141         Enhanced API test coverage to include all navigation response policy decisions in both
1142         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1143
1144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1145         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1146         (TestWebKitAPI::TEST):
1147         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1148         (readFile):
1149         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1150         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1151         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1152         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1153         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1154         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1155         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1156         (-[QuickLookDelegate _downloadDidStart:]):
1157         (-[QuickLookDelegate _download:didReceiveResponse:]):
1158         (-[QuickLookDelegate _download:didReceiveData:]):
1159         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1160         (-[QuickLookDelegate _downloadDidFinish:]):
1161         (-[QuickLookDelegate _download:didFailWithError:]):
1162         (-[QuickLookDelegate _downloadDidCancel:]):
1163         (-[QuickLookDelegate verifyDownload]):
1164         (runTest):
1165         (runTestDecideBeforeLoading):
1166         (runTestDecideAfterLoading):
1167         (TEST):
1168         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1169         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1170         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1171         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1172         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1173         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1174         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1175         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1176         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1177         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1178         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1179         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1180         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1181         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1182
1183 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1184
1185         [CMake] add testdfg as target with build-jsc
1186         https://bugs.webkit.org/show_bug.cgi?id=196393
1187
1188         Reviewed by Saam Barati.
1189
1190         Added testdfg as one of the targets to build when
1191         using CMake.
1192
1193         * Scripts/build-jsc:
1194
1195 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1196
1197         Delete WebMetal implementation in favor of WebGPU
1198         https://bugs.webkit.org/show_bug.cgi?id=195418
1199
1200         Reviewed by Dean Jackson.
1201
1202         * DumpRenderTree/mac/DumpRenderTree.mm:
1203         (enableExperimentalFeatures):
1204         (resetWebPreferencesToConsistentValues):
1205         * Scripts/webkitperl/FeatureList.pm:
1206         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1208         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1209         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1210         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1211         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1212         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1213         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1214         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1215         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1216         (WTR::InjectedBundle::beginTesting):
1217         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1218         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1219         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1220
1221 2019-03-29  Chris Dumez  <cdumez@apple.com>
1222
1223         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1224         https://bugs.webkit.org/show_bug.cgi?id=196405
1225         <rdar://problem/49428130>
1226
1227         Reviewed by Wenson Hsieh.
1228
1229         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1230         the popover presentation methods to be no-ops. Use this in the new test added in
1231         r243523 so that we do not swizzle those methods for all tests. This is needed because
1232         those WatchOS tests rely on the popover getting presented and interactive.
1233
1234         * WebKitTestRunner/TestController.cpp:
1235         (WTR::updateTestOptionsFromTestHeader):
1236         * WebKitTestRunner/TestController.h:
1237         * WebKitTestRunner/TestOptions.h:
1238         (WTR::TestOptions::hasSameInitializationOptions const):
1239         * WebKitTestRunner/ios/TestControllerIOS.mm:
1240         (WTR::TestController::platformInitialize):
1241         (WTR::TestController::platformResetStateToConsistentValues):
1242
1243 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1244
1245         [Curl] Add Server Trust Evaluation Support.
1246         https://bugs.webkit.org/show_bug.cgi?id=191646
1247
1248         Reviewed by Fujii Hironori.
1249
1250         Implemented MiniBrowser UI for asking if user trusts the server.
1251
1252         * MiniBrowser/win/Common.cpp:
1253         (askServerTrustEvaluation):
1254         (replaceString):
1255         * MiniBrowser/win/Common.h:
1256         * MiniBrowser/win/MiniBrowserLib.rc:
1257         * MiniBrowser/win/MiniBrowserLibResource.h:
1258         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1259         (createPEMString):
1260         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1261         (WebKitBrowserWindow::canTrustServerCertificate):
1262         * MiniBrowser/win/WebKitBrowserWindow.h:
1263
1264 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1265
1266         Implement ResizeObserver.
1267         https://bugs.webkit.org/show_bug.cgi?id=157743
1268
1269         Reviewed by Simon Fraser.
1270
1271         Support resizeObserverEnabled webPreferences.
1272
1273         * DumpRenderTree/TestOptions.cpp:
1274         (TestOptions::TestOptions):
1275         * DumpRenderTree/TestOptions.h:
1276         * DumpRenderTree/mac/DumpRenderTree.mm:
1277         (setWebPreferencesForTestOptions):
1278         * DumpRenderTree/win/DumpRenderTree.cpp:
1279         (enableExperimentalFeatures):
1280         * Scripts/webkitperl/FeatureList.pm:
1281         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1282
1283 2019-03-28  John Wilander  <wilander@apple.com>
1284
1285         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1286         https://bugs.webkit.org/show_bug.cgi?id=196281
1287         <rdar://problem/48938748>
1288
1289         Reviewed by Alex Christensen.
1290
1291         This patch adds the function isStatisticsHasLocalStorage() to the
1292         TestRunner. With it, the page can query the WebsiteDataStore in the
1293         UI process to make sure that it sees LocalStorage.
1294
1295         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1296         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1297         (WTR::TestRunner::isStatisticsHasLocalStorage):
1298         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1299         * WebKitTestRunner/TestController.cpp:
1300         (WTR::TestController::isStatisticsHasLocalStorage):
1301         * WebKitTestRunner/TestController.h:
1302         * WebKitTestRunner/TestInvocation.cpp:
1303         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1304
1305 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1306
1307         API::Data::createWithoutCopying should do a null check before calling CFRelease
1308         https://bugs.webkit.org/show_bug.cgi?id=196276
1309         <rdar://problem/48059859>
1310
1311         Reviewed by Alex Christensen.
1312
1313         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1314
1315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1316         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1317         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1318         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1319         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1320         (TestWebKitAPI::TEST):
1321
1322 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1323
1324         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1325         https://bugs.webkit.org/show_bug.cgi?id=186276
1326
1327         Reviewed by Carlos Garcia Campos.
1328
1329         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1330         (webViewLoadChanged):
1331         (testWebResourceGetDataError):
1332         (testWebResourceGetDataEmpty):
1333         (beforeAll):
1334         (webViewloadChanged): Deleted.
1335
1336 2019-03-27  Andy Estes  <aestes@apple.com>
1337
1338         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1339         https://bugs.webkit.org/show_bug.cgi?id=196317
1340
1341         Reviewed by Dan Bernstein.
1342
1343         package-root copies built products into a staging directory using ditto(1), which does not
1344         follow symbolic links as it traverses a directory. Now that the files in
1345         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1346         itself, these become broken links when ditto'd into the staging directory.
1347
1348         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1349
1350         * Scripts/package-root:
1351
1352 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1353
1354         [ews-app] Update display text of Submit for ews analysis
1355         https://bugs.webkit.org/show_bug.cgi?id=196309
1356
1357         Reviewed by Dewei Zhu.
1358
1359         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1360
1361 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1362
1363         run-webkit-tests should check for leaks in WebKit processes
1364         <https://webkit.org/b/193772>
1365         <rdar://problem/46526680>
1366
1367         Reviewed by Ryosuke Niwa.
1368
1369         This works by doing the following:
1370         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1371           The list of child processes are returned one per line:
1372           process.name: pid
1373         - Run the "#LIST CHILD PROCESSES" command just before the
1374           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1375           processes on the ServerProcess object.
1376         - When the `--leaks` switch is handled, run check_for_leaks() on
1377           each child process after the main test harness.
1378
1379         * DumpRenderTree/mac/DumpRenderTree.mm:
1380         (handleControlCommand):
1381         - Use strncmp() instead of strcmp().
1382         - Add support for handling "#LIST CHILD PROCESSES" command.
1383
1384         * Scripts/webkitpy/port/base.py:
1385         (Port.check_for_leaks):
1386         * Scripts/webkitpy/port/darwin.py:
1387         (DarwinPort.check_for_leaks):
1388         - Rename redundant 'process_pid' argument to 'process_id'.
1389
1390         * Scripts/webkitpy/port/driver.py:
1391         (Driver.do_post_tests_work):
1392         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1393           longer the only command this sends to WebKitTestRunner.
1394         - If the `--leaks` switch is present, send the
1395           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1396           result using Port.set_webkit_processes().
1397         (Driver._parse_child_processes_output):
1398         - Add helper method to parse list of child process names and
1399           process IDs returned from WebKitTestRunner.
1400
1401         * Scripts/webkitpy/port/ios_device.py:
1402         (IOSDevicePort.check_for_leaks):
1403         - Rename redundant 'process_pid' argument to 'process_id'.
1404
1405         * Scripts/webkitpy/port/leakdetector.py:
1406         (LeakDetector._parse_leaks_output):
1407         - Return early if there is no leaks_output.
1408         (LeakDetector.check_for_leaks):
1409         - Rename redundant 'process_pid' argument to 'process_id'.
1410
1411         * Scripts/webkitpy/port/server_process.py:
1412         (ServerProcess.__init__):
1413         (ServerProcess.child_processes):
1414         (ServerProcess.set_child_processes):
1415         - Add instance variable to Port to store list of child process
1416           names and process IDs returned from WebKitTestRunner.
1417         (ServerProcess._start):
1418         - Clear self._child_processes.
1419         (ServerProcess.stop):
1420         - If self._child_processes is set, call
1421           self._port.check_for_leaks() for each child process.
1422
1423         * Scripts/webkitpy/port/server_process_unittest.py:
1424         (TrivialMockPort.check_for_leaks):
1425         - Rename redundant 'process_pid' argument to 'process_id'.
1426
1427         * Scripts/webkitpy/port/simulator_process.py:
1428         (SimulatorProcess.stop):
1429         - If self._child_processes is set, call
1430           self._port.check_for_leaks() for each child process.
1431
1432         * Scripts/webkitpy/port/watch_device.py:
1433         (WatchDevicePort.check_for_leaks):
1434         - Rename redundant 'process_pid' argument to 'process_id'.
1435
1436         * WebKitTestRunner/TestController.cpp:
1437         (WTR::TestController::dumpResponse):
1438         - Extract method from findAndDumpWorldLeaks() so that it may be
1439           reused by findAndDumpWebKitProcessIdentifiers().
1440         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1441         - Add method to output process name and process ID of both the
1442           WebContent and Networking processes.
1443         (WTR::TestController::findAndDumpWorldLeaks):
1444         - Fix missing newline in output when there were no abandoned
1445           documents.
1446         - Call dumpResponse() for extracted code.
1447         (WTR::TestController::handleControlCommand):
1448         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1449         - Use strncmp() instead of strcmp().
1450         - Call findAndDumpWebKitProcessIdentifiers() when
1451           "#LIST CHILD PROCESSES" command is sent.
1452         * WebKitTestRunner/TestController.h:
1453         (WTR::TestController::dumpResponse):
1454         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1455         - Declare methods.
1456
1457 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1458
1459         Unreviewed. Add GLib API test cases after r243434.
1460
1461         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1462         (testWebViewActiveURI):
1463         (serverCallback):
1464         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1465         (sendRequestCallback):
1466
1467 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1468
1469         Geolocation request not complete when watch request was started in a different web process
1470         https://bugs.webkit.org/show_bug.cgi?id=195996
1471
1472         Reviewed by Alex Christensen.
1473
1474         Add a test case.
1475
1476         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1477         (TestWebKitAPI::runJavaScriptAlert):
1478         (TestWebKitAPI::TEST):
1479
1480 2019-03-26  Keith Rollin  <krollin@apple.com>
1481
1482         Update the way generate-xcfilelists returns strings from functions
1483         https://bugs.webkit.org/show_bug.cgi?id=195975
1484         <rdar://problem/49040807>
1485
1486         Reviewed by Dean Jackson.
1487
1488         There are places where generate-xcfilelists executes assignments with
1489         statements like:
1490
1491             FOO=$(some_function)
1492
1493         where "some_function" return a string by echoing it. E.g.
1494
1495             some_function()
1496             {
1497                 echo "Hello, World"
1498             }
1499
1500         This is a common idiom, but it has a problem if "some_function" needs
1501         to call "exit" in an attempt to halt the entire script right then and
1502         there. Since "some_function" is called inside of $(), it's being
1503         executed in a sub-shell. Calling exit in that sub-shell simply exits
1504         that shell; it doesn't not exit the outer shell in which the main part
1505         of the script is still running. As such, the main script keeps
1506         executing when the intent was for the script to halt.
1507
1508         The solution to this is to use a different idiom for returning
1509         strings. The one we now is to pass in the name of the variable to
1510         receive the string result:
1511
1512             some_function()
1513             {
1514                 variable_name=$1
1515                 eval $variable_name ="Hello, World"
1516             }
1517
1518         The call site now looks like
1519
1520             some_function FOO
1521
1522         Because there's no invocation of a sub-shell, some_function can now
1523         call "exit" if it wants to, and the entire script will exit at that
1524         point.
1525
1526         * Scripts/generate-xcfilelists:
1527
1528 2019-03-26  Chris Dumez  <cdumez@apple.com>
1529
1530         Add basic layout test coverage for File Picker on iOS
1531         https://bugs.webkit.org/show_bug.cgi?id=196265
1532
1533         Reviewed by Wenson Hsieh.
1534
1535         Add layout test infrastructure to test the file picker on iOS.
1536
1537         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1538         (WTR::UIScriptController::dismissFilePicker):
1539         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1540         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1541         (WTR::UIScriptController::dismissFilePicker):
1542         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1543         * WebKitTestRunner/TestController.cpp:
1544         (WTR::TestController::createWebViewWithOptions):
1545         (WTR::updateTestOptionsFromTestHeader):
1546         * WebKitTestRunner/TestOptions.h:
1547         (WTR::TestOptions::hasSameInitializationOptions const):
1548         * WebKitTestRunner/ios/TestControllerIOS.mm:
1549         (overridePresentViewController):
1550         (WTR::TestController::platformInitialize):
1551         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1552         (WTR::UIScriptController::dismissFilePicker):
1553
1554 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1555
1556         Implement async paste method on UIWKInteractionViewProtocol
1557         https://bugs.webkit.org/show_bug.cgi?id=196267
1558         <rdar://problem/49236346>
1559
1560         Reviewed by Tim Horton.
1561
1562         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1563         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1564         are now a part of all iOS 12 internal SDKs.
1565
1566         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1567
1568         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1569         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1570
1571         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1572         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1573         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1574         * TestWebKitAPI/ios/UIKitSPI.h:
1575
1576 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1577
1578         [ews-build] Use PostgreSQL for ews.webkit.org database
1579         https://bugs.webkit.org/show_bug.cgi?id=196270
1580
1581         Reviewed by Lucas Forschler.
1582
1583         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1584
1585 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1586
1587         [ews] Reset simctl states on reboot
1588         https://bugs.webkit.org/show_bug.cgi?id=196260
1589
1590         Rubber-stamped by Aakash Jain.
1591
1592         * EWSTools/start-queue-mac.sh:
1593
1594 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1595
1596         [ews-build] Use PostgreSQL for ews-build database
1597         https://bugs.webkit.org/show_bug.cgi?id=196229
1598
1599         Reviewed by Lucas Forschler.
1600
1601         * BuildSlaveSupport/ews-build/master.cfg:
1602
1603 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1604
1605         [ews-build] Get master_hostname dynamically in master.cfg
1606         https://bugs.webkit.org/show_bug.cgi?id=196255
1607
1608         Reviewed by Lucas Forschler.
1609
1610         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1611         send events data in test mode.
1612
1613 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1614
1615         [ews-app] Set db_constraint to False for Foreign Keys
1616         https://bugs.webkit.org/show_bug.cgi?id=196252
1617
1618         Reviewed by Lucas Forschler.
1619
1620         * BuildSlaveSupport/ews-app/ews/models/build.py:
1621         * BuildSlaveSupport/ews-app/ews/models/step.py:
1622
1623 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1624
1625         [ews-build] is_test_mode_enabled should default to True
1626         https://bugs.webkit.org/show_bug.cgi?id=196248
1627
1628         Reviewed by Lucas Forschler.
1629
1630         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1631
1632 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1633
1634         [ews-app] Add webkitperl to ENABLED_QUEUES
1635         https://bugs.webkit.org/show_bug.cgi?id=196253
1636
1637         Reviewed by Lucas Forschler.
1638
1639         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1640
1641 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1642
1643         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1644         https://bugs.webkit.org/show_bug.cgi?id=196211
1645         rdar://problem/49110552
1646
1647         Reviewed by Tim Horton.
1648
1649         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1650         Make sure that EventSenderProxy always exists when running tests. We used to create
1651         it when resetting before the first test, which is a bit too late.
1652
1653         * WebKitTestRunner/TestController.h:
1654         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1655         (WTR::TestController::platformCreateWebView):
1656         (WTR::TestController::platformCreateOtherPage):
1657         (WTR::TestController::finishCreatingPlatformWebView):
1658         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1659         (WTR::PlatformWebView::PlatformWebView):
1660         Moved some code that made NSWindow use NSEvent during web view creation. We may
1661         need to move more if some other case us found, but this is enough for now.
1662
1663 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1664
1665         Unreviewed. Fix typo in GLib geolocation API after r243285.
1666
1667         gelocation -> geolocation.
1668
1669         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1670         (testGeolocationManagerWatchPosition):
1671
1672 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1673
1674         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1675         https://bugs.webkit.org/show_bug.cgi?id=196213
1676
1677         Reviewed by Geoff Garen.
1678
1679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1680         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1681         (credentialWithIdentityAndKeychainPath):
1682         (-[ChallengeDelegate webView:didFinishNavigation:]):
1683         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1684         (TestWebKitAPI::TEST):
1685
1686 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1687
1688         Expected shouldn't assume its contained types are copyable
1689         https://bugs.webkit.org/show_bug.cgi?id=195986
1690
1691         Reviewed by JF Bastien.
1692
1693         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1694         (TestWebKitAPI::NonCopyable::operator== const):
1695         (TestWebKitAPI::NonCopyable::operator!= const):
1696         (TestWebKitAPI::TEST):
1697
1698 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1699
1700         Remove some now-unnecessary dynamic class lookup
1701         https://bugs.webkit.org/show_bug.cgi?id=196237
1702
1703         Reviewed by Simon Fraser.
1704
1705         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1706         (makeRequest):
1707         (TEST):
1708
1709 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1710
1711         Unreviewed, rolling out r243450.
1712
1713         AppleWin and WinCairo port builds get broken.
1714
1715         Reverted changeset:
1716
1717         "Add test for fix of #196095"
1718         https://bugs.webkit.org/show_bug.cgi?id=196097
1719         https://trac.webkit.org/changeset/243450
1720
1721 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1722
1723         Unreviewed, rolling out r243465.
1724         https://bugs.webkit.org/show_bug.cgi?id=196226
1725
1726         the test doesn't build (Requested by thorton on #webkit).
1727
1728         Reverted changeset:
1729
1730         "Do not terminate the NetworkProcess if a third party
1731         application sends a NSCredential with a SecIdentityRef"
1732         https://bugs.webkit.org/show_bug.cgi?id=196213
1733         https://trac.webkit.org/changeset/243465
1734
1735 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1736
1737         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1738         https://bugs.webkit.org/show_bug.cgi?id=196213
1739
1740         Reviewed by Geoff Garen.
1741
1742         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1743         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1744         (credentialWithIdentityAndKeychainPath):
1745         (-[ChallengeDelegate webView:didFinishNavigation:]):
1746         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1747         (TestWebKitAPI::TEST):
1748
1749 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1750
1751         [ews-build] Gracefully handle missing patch_id in events
1752         https://bugs.webkit.org/show_bug.cgi?id=196216
1753
1754         Reviewed by Lucas Forschler.
1755
1756         * BuildSlaveSupport/ews-build/events.py:
1757
1758 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1759
1760         [ews-build] use lz4 compression for improving buildbot performance
1761         https://bugs.webkit.org/show_bug.cgi?id=196155
1762
1763         Reviewed by Lucas Forschler.
1764
1765         * BuildSlaveSupport/ews-build/master.cfg:
1766
1767 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1768
1769         Pull some API testing helper methods out of TestWKWebView
1770         https://bugs.webkit.org/show_bug.cgi?id=196212
1771
1772         Reviewed by Tim Horton.
1773
1774         Refactor some more API testing utility methods, so that they can be used in
1775         tests that do not use TestWKWebView.
1776
1777         * TestWebKitAPI/cocoa/TestWKWebView.h:
1778         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1779         (-[WKWebView loadTestPageNamed:]):
1780         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1781         (-[WKWebView synchronouslyLoadHTMLString:]):
1782         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1783         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1784         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1785         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1786         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1787
1788 2019-03-25  Jer Noble  <jer.noble@apple.com>
1789
1790         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1791         https://bugs.webkit.org/show_bug.cgi?id=196097
1792
1793         Reviewed by Eric Carlson.
1794
1795         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1796
1797         * DumpRenderTree/mac/DumpRenderTree.mm:
1798         (resetWebPreferencesToConsistentValues):
1799         * WebKitTestRunner/TestController.cpp:
1800         (WTR::TestController::resetPreferencesToConsistentValues):
1801
1802 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1803
1804         Pull IPadUserInterfaceSwizzler out into a separate header file
1805         https://bugs.webkit.org/show_bug.cgi?id=196193
1806
1807         Reviewed by Anders Carlsson.
1808
1809         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1810         be used in other API tests.
1811
1812         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1813         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1814         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1815         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1816         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1817         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1818         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1819
1820 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1821
1822         Remove NavigatorContentUtils in WebCore/Modules
1823         https://bugs.webkit.org/show_bug.cgi?id=196070
1824
1825         Reviewed by Alex Christensen.
1826
1827         NavigatorContentUtils was to support the custom scheme spec [1].
1828         However, in WebKit side, no port has supported the feature in
1829         WebKit layer after EFL port was removed. So there has been the
1830         only IDL implementation of the NavigatorContentUtils in WebCore.
1831         So we don't need to keep the implementation in WebCore anymore.
1832
1833         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1834
1835         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1836
1837 2019-03-24  Andy Estes  <aestes@apple.com>
1838
1839         [watchOS] Remove unused Proximity Networking code
1840         https://bugs.webkit.org/show_bug.cgi?id=196188
1841
1842         Reviewed by Tim Horton.
1843
1844         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1845         (TEST):
1846
1847 2019-03-23  Keith Miller  <keith_miller@apple.com>
1848
1849         Refactor clz/ctz and fix getLSBSet.
1850         https://bugs.webkit.org/show_bug.cgi?id=196162
1851
1852         Reviewed by Saam Barati.
1853
1854         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1855
1856         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1857         (TestWebKitAPI::TEST):
1858
1859 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1860
1861         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1862         https://bugs.webkit.org/show_bug.cgi?id=196143
1863
1864         Reviewed by Michael Catanzaro.
1865
1866         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1867         directories.
1868
1869         * Scripts/webkitpy/style/checkers/cpp.py:
1870         (check_identifier_name_in_declaration):
1871         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1872         (WebKitStyleTest.test_names):
1873
1874 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1875
1876         [Flatpak] Manifest expanding fails for qt WPE extension
1877         https://bugs.webkit.org/show_bug.cgi?id=196148
1878
1879         Reviewed by Alex Christensen.
1880
1881         * flatpak/flatpakutils.py:
1882         (expand_submodules_recurse): The last recurse manifest expand
1883         iteration might lead to a single module so take it into account
1884         and don't try to recurse further.
1885
1886 2019-03-22  Chris Dumez  <cdumez@apple.com>
1887
1888         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1889         https://bugs.webkit.org/show_bug.cgi?id=195348
1890         <rdar://problem/48622090>
1891
1892         Reviewed by Alex Christensen.
1893
1894         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1895         to NO when test.options().shouldIgnoreMetaViewport is false.
1896
1897         * WebKitTestRunner/ios/TestControllerIOS.mm:
1898         (WTR::TestController::platformConfigureViewForTest):
1899
1900 2019-03-22  Chris Dumez  <cdumez@apple.com>
1901
1902         Prewarmed processes should be usable with any website data store
1903         https://bugs.webkit.org/show_bug.cgi?id=196104
1904
1905         Reviewed by Alex Christensen.
1906
1907         Add API test coverage.
1908
1909         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1910         (runInitialWarmedProcessUsedTest):
1911         (TEST):
1912
1913 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1914
1915         Back out local changes to Alex's Subversion working directory
1916
1917         They were accidentally committed.
1918
1919         * Scripts/webkitpy/common/system/abstractexecutive.py:
1920         (AbstractExecutive.wait_newest):
1921         * Scripts/webkitpy/common/system/executive.py:
1922         (Executive.running_pids):
1923         * Scripts/webkitpy/common/system/executive_mock.py:
1924         (MockExecutive.running_pids):
1925         * Scripts/webkitpy/common/system/executive_unittest.py:
1926         (ExecutiveTest.serial_test_running_pids):
1927         * Scripts/webkitpy/port/darwin.py:
1928         (DarwinPort.check_for_leaks):
1929         * Scripts/webkitpy/port/leakdetector.py:
1930         (LeakDetector.check_for_leaks):
1931         - This was the hack attached to Bug 193772.
1932
1933         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1934         (+[WebKitTestRunnerEvent mouseLocation]):
1935         - This works around a crash on an internal build.
1936
1937 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1938
1939         Fix the build after r243354
1940         https://bugs.webkit.org/show_bug.cgi?id=196138
1941         <rdar://problem/49145951>
1942
1943         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1944         (TEST):
1945         * TestWebKitAPI/ios/UIKitSPI.h:
1946
1947 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1948
1949         Adopt UIWKDocumentContext
1950         https://bugs.webkit.org/show_bug.cgi?id=196040
1951         <rdar://problem/48642440>
1952
1953         Reviewed by Ryosuke Niwa.
1954
1955         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1956         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1957         (makeRequest):
1958         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1959         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1960         (applyStyle):
1961         (TEST):
1962         Add tests for UIWKDocumentContext.
1963
1964         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1965         (TEST):
1966         (recursiveFindWKContentView): Deleted.
1967         * TestWebKitAPI/cocoa/TestWKWebView.h:
1968         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1969         (recursiveFindWKContentView):
1970         (-[TestWKWebView wkContentView]):
1971         * TestWebKitAPI/ios/UIKitSPI.h:
1972         Share the WKContentView finding code between tests.
1973
1974 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1975
1976         [iOS WK2] Turn on async overflow scrolling by default
1977         https://bugs.webkit.org/show_bug.cgi?id=196011
1978         rdar://problem/48453859
1979
1980         Reviewed by Antti Koivisto.
1981         
1982         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1983         since so many basic layout tests have different results when compositing is triggered for
1984         overflow.
1985         
1986         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1987
1988         * WebKitTestRunner/TestController.cpp:
1989         (WTR::TestController::resetPreferencesToConsistentValues):
1990
1991 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1992
1993         [ews-build] Retry API test in case of failures
1994         https://bugs.webkit.org/show_bug.cgi?id=196004
1995
1996         Reviewed by Lucas Forschler.
1997
1998         * BuildSlaveSupport/ews-build/steps.py:
1999         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2000         (CompileWebKitToT.doStepIf): Ditto.
2001         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2002         (ReRunAPITests): Re-run API tests.
2003         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2004         (RunAPITestsWithoutPatch): Run API tests without patch.
2005         (RunAPITestsWithoutPatch.doStepIf):
2006         (RunAPITestsWithoutPatch.hideStepIf):
2007         (RunAPITestsWithoutPatch.evaluateCommand):
2008         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2009         (AnalyzeAPITestsResults.start):
2010         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2011         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2012         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2013         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2014
2015 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2016
2017         [ews-build] Update queues configurations
2018         https://bugs.webkit.org/show_bug.cgi?id=196074
2019
2020         Reviewed by Dewei Zhu.
2021
2022         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2023         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2024
2025 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2026
2027         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2028         https://bugs.webkit.org/show_bug.cgi?id=195680
2029         <rdar://problem/48903534>
2030
2031         Unreviewed infrastructure fix.
2032
2033         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2034         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2035
2036 2019-03-21  Andy Estes  <aestes@apple.com>
2037
2038         [iOS] Apple Pay should be available in documents with no user agent scripts
2039         https://bugs.webkit.org/show_bug.cgi?id=196061
2040         <rdar://problem/48649391>
2041
2042         Reviewed by Brady Eidson.
2043
2044         Added API tests and related infrastructure.
2045
2046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2047         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2048         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2049         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2050         (TestWebKitAPI::TEST):
2051         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2052         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2053         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2054         * TestWebKitAPI/cocoa/TestProtocol.mm:
2055         (-[TestProtocol startLoading]):
2056         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2057         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2058         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2059         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2060
2061 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2062
2063         REGRESSSION (r243297): webkitpy tests broken
2064         https://bugs.webkit.org/show_bug.cgi?id=196108
2065
2066         Reviewed by Aakash Jain.
2067
2068         r243297 updated contributors.json, which broke a few unit tests.
2069
2070         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2071         (IRCCommandTest.test_whois):
2072         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2073
2074 2019-03-21  Chris Dumez  <cdumez@apple.com>
2075
2076         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2077         https://bugs.webkit.org/show_bug.cgi?id=196041
2078         <rdar://problem/49083230>
2079
2080         Reviewed by Alex Christensen.
2081
2082         Add API test coverage.
2083
2084         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2085         (TEST):
2086
2087 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2088
2089         Add SPI to inform applications of WKContentRuleList actions
2090         https://bugs.webkit.org/show_bug.cgi?id=195965
2091         <rdar://problem/42664365>
2092
2093         Reviewed by Geoff Garen.
2094
2095         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2096         (TestWebKitAPI::allActionsForResourceLoad):
2097         (TestWebKitAPI::testRequest):
2098         (TestWebKitAPI::TEST_F):
2099         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2100         (Notification::description):
2101         (Notification::operator== const):
2102         (toVector):
2103         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2104         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2105         (makeContentRuleList):
2106         (TEST):
2107         (makeWarnContentRuleList): Deleted.
2108
2109 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2110
2111         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2112         https://bugs.webkit.org/show_bug.cgi?id=196088
2113
2114         Reviewed by Brian Burg.
2115
2116         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2117         Support checks when only one platform is specified. Also deprecate macosx() and
2118         force the use of macos() instead.
2119
2120         * Scripts/webkitpy/style/checkers/cpp.py:
2121         (check_min_versions_of_wk_api_available):
2122         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2123         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2124
2125 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2126
2127         Update status inactive committers' status to 'contributor'.
2128
2129         * Scripts/webkitpy/common/config/contributors.json:
2130
2131 2019-03-21  Xan Lopez  <xan@igalia.com>
2132
2133         [JSC][x86] Drop support for x87 floating point
2134         https://bugs.webkit.org/show_bug.cgi?id=194853
2135
2136         Reviewed by Don Olmstead.
2137
2138         Force SSE2 on x86/32bit builds.
2139
2140         * Scripts/webkitdirs.pm:
2141         (generateBuildSystemFromCMakeProject):
2142
2143 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2144
2145         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2146         https://bugs.webkit.org/show_bug.cgi?id=196073
2147
2148         Reviewed by Michael Catanzaro.
2149
2150         Add test cases to check functions and constructors with no arguments but receiving user data.
2151
2152         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2153         (checkUserData):
2154         (testJSCFunction):
2155         (fooCreateWithUserData):
2156         (testJSCClass):
2157
2158 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2159
2160         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2161
2162         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2163
2164         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2165
2166 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2167
2168         [GTK][WPE] Add API to provide geolocation information
2169         https://bugs.webkit.org/show_bug.cgi?id=195940
2170
2171         Reviewed by Michael Catanzaro.
2172
2173         Add a new test to check the new API.
2174
2175         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2176         (testGeolocationManagerCurrentPosition):
2177         (testGeolocationManagerWatchPosition):
2178         (beforeAll):
2179         (afterAll):
2180         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2181         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2182         (beforeAll): Ditto.
2183         * TestWebKitAPI/glib/CMakeLists.txt:
2184
2185 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2186
2187         [GLib] Returning G_TYPE_OBJECT from a method does not work
2188         https://bugs.webkit.org/show_bug.cgi?id=195574
2189
2190         Reviewed by Michael Catanzaro.
2191
2192         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2193
2194         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2195         (getGFile):
2196         (getParent):
2197         (createGString):
2198         (getGString):
2199         (getGStringCopyWillRaise):
2200         (getGStringCopy):
2201         (getGStringStr):
2202         (getGStringLen):
2203         (freeGString):
2204         (testJSCClass):
2205
2206 2019-03-20  Saam Barati  <sbarati@apple.com>
2207
2208         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2209         https://bugs.webkit.org/show_bug.cgi?id=195721
2210
2211         Reviewed by Filip Pizlo.
2212
2213         * Scripts/run-javascriptcore-tests:
2214
2215 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2216
2217         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2218         https://bugs.webkit.org/show_bug.cgi?id=196049
2219
2220         Reviewed by Tim Horton.
2221
2222         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2223         overflow scrolling in general, so rename it.
2224
2225         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2226
2227 2019-03-20  Daniel Bates  <dabates@apple.com>
2228
2229         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2230         https://bugs.webkit.org/show_bug.cgi?id=196031
2231         <rdar://problem/49078172>
2232
2233         Reviewed by Tim Horton.
2234
2235         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2236         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2237         same code path used when the Done button is pressed to dismiss the <select> picker.
2238
2239         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2240         (TestWebKitAPI::TEST):
2241
2242 2019-03-20  Chris Dumez  <cdumez@apple.com>
2243
2244         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2245         https://bugs.webkit.org/show_bug.cgi?id=196029
2246         <rdar://problem/48954651>
2247
2248         Reviewed by Tim Horton.
2249
2250         Add API test coverage.
2251
2252         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2253
2254 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2255
2256         [ews-build] Improve failure summary string for ApplyPatch step
2257         https://bugs.webkit.org/show_bug.cgi?id=195995
2258
2259         Reviewed by Alexey Proskuryakov.
2260
2261         * BuildSlaveSupport/ews-build/steps.py:
2262         (ApplyPatch.getResultSummary): Override getResultSummary.
2263
2264 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2265
2266         AX: Implement support for new meter ARIA role
2267         https://bugs.webkit.org/show_bug.cgi?id=195966
2268
2269         Reviewed by Chris Fleizach.
2270
2271         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2272         to AXLevelIndicator.
2273
2274         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2275
2276 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2277
2278         [WebAuthN] Implement FIDO AppID extension
2279         https://bugs.webkit.org/show_bug.cgi?id=143491
2280         <rdar://problem/48298273>
2281
2282         Reviewed by Brent Fulgham.
2283
2284         Add a test that covers the new flag of convertToU2fSignCommand.
2285
2286         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2287         (TestWebKitAPI::TEST):
2288         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2289         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2290         (TestWebKitAPI::TEST):
2291
2292 2019-03-19  Keith Rollin  <krollin@apple.com>
2293
2294         Add support for more platforms to generate-xcfilelists
2295         https://bugs.webkit.org/show_bug.cgi?id=195977
2296
2297         Reviewed by Alexey Proskuryakov.
2298
2299         generate-xcfilelists incorrectly complains when involved with building
2300         WebKit for iphonesimulator:
2301
2302             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2303             …
2304             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2305
2306         Address this by teaching generate-xcfilelists about more platforms.
2307
2308         * Scripts/generate-xcfilelists:
2309
2310 2019-03-19  John Wilander  <wilander@apple.com>
2311
2312         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2313         https://bugs.webkit.org/show_bug.cgi?id=195923
2314         <rdar://problem/49001272>
2315
2316         Reviewed by Alex Christensen.
2317
2318         This patch does the following to the TestRunner:
2319         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2320         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2321         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2322
2323         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2324         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2325         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2326         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2327         * WebKitTestRunner/TestController.cpp:
2328         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2329         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2330         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2331         * WebKitTestRunner/TestController.h:
2332         * WebKitTestRunner/TestInvocation.cpp:
2333         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2334
2335 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2336
2337         [CMake] Support more clang and gcc sanitizers
2338         https://bugs.webkit.org/show_bug.cgi?id=195956
2339
2340         Reviewed by Michael Catanzaro.
2341
2342         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2343
2344 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2345
2346         [ews-build] Improve summary for PrintConfiguration step
2347         https://bugs.webkit.org/show_bug.cgi?id=195945
2348
2349         Reviewed by Lucas Forschler.
2350
2351         * BuildSlaveSupport/ews-build/steps.py:
2352         (PrintConfiguration.getResultSummary): Override getResultSummary.
2353
2354 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2355
2356         [ews-build] Improve summary for CheckOutSource step
2357         https://bugs.webkit.org/show_bug.cgi?id=195963
2358
2359         Reviewed by Lucas Forschler.
2360
2361         * BuildSlaveSupport/ews-build/steps.py:
2362         (CheckOutSource.getResultSummary):
2363
2364 2019-03-19  Daniel Bates  <dabates@apple.com>
2365
2366         [iOS] Focus not preserved when switching between tabs
2367         https://bugs.webkit.org/show_bug.cgi?id=195820
2368         <rdar://problem/43614450>
2369
2370         Reviewed by Brent Fulgham.
2371
2372         Add tests to ensure that we restore focus when resigning and becoming first responder.
2373
2374         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2375         (TestWebKitAPI::TEST):
2376
2377 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2378
2379         Make WTFLogChannelState and WTFLogLevel enum classes
2380         https://bugs.webkit.org/show_bug.cgi?id=195904
2381
2382         Reviewed by Eric Carlson.
2383
2384         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2385         (TestWebKitAPI::TEST_F):
2386
2387 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2388
2389         [GStreamer][EME] Backported mssdemux protection data crash fix
2390         https://bugs.webkit.org/show_bug.cgi?id=195918
2391
2392         Reviewed by Philippe Normand.
2393
2394         * gstreamer/jhbuild.modules:
2395         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2396
2397 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2398
2399         Unreviewed, rolling out r243132.
2400
2401         Broke GTK build
2402
2403         Reverted changeset:
2404
2405         "Make WTFLogChannelState and WTFLogLevel enum classes"
2406         https://bugs.webkit.org/show_bug.cgi?id=195904
2407         https://trac.webkit.org/changeset/243132
2408
2409 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2410
2411         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2412
2413         * Scripts/webkitdirs.pm:
2414         (builtDylibPathForName): Adjust the shared library name that's changed
2415         with the API version bump in r243073.
2416
2417 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2418
2419         Make WTFLogChannelState and WTFLogLevel enum classes
2420         https://bugs.webkit.org/show_bug.cgi?id=195904
2421
2422         Reviewed by Eric Carlson.
2423
2424         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2425         (TestWebKitAPI::TEST_F):
2426
2427 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2428
2429         Disable flaky test added in r2431100
2430         https://webkit.org/b/195785
2431
2432         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2433         (TestWebKitAPI::TEST):
2434         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2435
2436 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2437
2438         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2439         https://bugs.webkit.org/show_bug.cgi?id=195916
2440
2441         Reviewed by Tim Horton.
2442
2443         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2444         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2445
2446 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2447
2448         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2449
2450         * Scripts/webkitpy/common/config/contributors.json:
2451
2452 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2453
2454         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2455         https://bugs.webkit.org/show_bug.cgi?id=195785
2456
2457         Reviewed by Geoffrey Garen.
2458
2459         * TestWebKitAPI/TCPServer.cpp: Added.
2460         (TestWebKitAPI::TCPServer::TCPServer):
2461         (TestWebKitAPI::TCPServer::~TCPServer):
2462         (TestWebKitAPI::TCPServer::socketBindListen):
2463         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2464         * TestWebKitAPI/TCPServer.h: Added.
2465         (TestWebKitAPI::TCPServer::port const):
2466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2467         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2468         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2469         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2470         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2471         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2472         (TestWebKitAPI::respondSlowly):
2473         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2474         (TestWebKitAPI::downloadAtRate):
2475         (TestWebKitAPI::TEST):
2476
2477 2019-03-18  Saam Barati  <sbarati@apple.com>
2478
2479         Add a plan file for JetStream 2
2480         https://bugs.webkit.org/show_bug.cgi?id=190734
2481
2482         Reviewed by Mark Lam.
2483
2484         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2485
2486 2019-03-18  Chris Dumez  <cdumez@apple.com>
2487
2488         Delay WebProcess launch until a load is triggered in a Web view
2489         https://bugs.webkit.org/show_bug.cgi?id=195758
2490         <rdar://problem/48126013>
2491
2492         Reviewed by Geoff Garen.
2493
2494         Add API test coverage. Also update some existing API tests to not expect
2495         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2496
2497         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2498         (TestWebKitAPI::TEST):
2499         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2500         (TestWebKitAPI::TEST):
2501         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2502         (TEST):
2503         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2504         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2505         (TEST):
2506         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2507         (TEST):
2508         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2509
2510 2019-03-18  Xan Lopez  <xan@igalia.com>
2511
2512         [CMake] Prevent potential warning when determining $architecture
2513         https://bugs.webkit.org/show_bug.cgi?id=195891
2514
2515         Reviewed by Michael Catanzaro.
2516
2517         It's possible for generateBuildSystemForCMakeProject to be called
2518         before determineArchitecture() is ever called. This will make the
2519         first eq check with $architecture to be bogus (and print a
2520         warning). Change that to an eq check with architecture(), which
2521         implicitly calls determineArchitecture() if needed, and change all
2522         the other similar cases in the method in the same way to prevent
2523         future bugs like this one.
2524
2525         * Scripts/webkitdirs.pm:
2526         (generateBuildSystemFromCMakeProject):
2527
2528 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2529
2530         [WPE] Tarballs generated with “make dist” cannot build documentation
2531         https://bugs.webkit.org/show_bug.cgi?id=195885
2532
2533         Reviewed by Carlos Garcia Campos.
2534
2535         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2536
2537 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2538
2539         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2540         https://bugs.webkit.org/show_bug.cgi?id=195883
2541
2542         Reviewed by Carlos Garcia Campos.
2543
2544         * gtkdoc/gtkdoc.py:
2545         (GTKDoc._run_command): When commands fail to run, include the full command line for
2546         the program invocation and the output it has generated on the standard error stream.
2547
2548 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2549
2550         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2551         https://bugs.webkit.org/show_bug.cgi?id=195786
2552
2553         Reviewed by Philippe Normand.
2554
2555         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2556         * wpe/jhbuild.modules: Ditto.
2557
2558 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2559
2560         [ews-build] Don't run clean builds on EWS builders
2561         https://bugs.webkit.org/show_bug.cgi?id=195851
2562
2563         Reviewed by Geoffrey Garen.
2564
2565         * BuildSlaveSupport/ews-build/factories.py:
2566
2567 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2568
2569         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2570         https://bugs.webkit.org/show_bug.cgi?id=195849
2571
2572         Reviewed by Chris Dumez.
2573
2574         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2575
2576         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2577         (runWebsiteDataStoreCustomPaths):
2578
2579 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2580
2581         webkitpy: Upload test results
2582         https://bugs.webkit.org/show_bug.cgi?id=195755
2583         <rdar://problem/48896182>
2584
2585         Reviewed by Aakash Jain.
2586
2587         Establish a new format for uploading results that is not tied to layout tests, apply
2588         that format to webkitpy tests.
2589
2590         * Scripts/webkitpy/common/checkout/scm/git.py:
2591         (Git.native_branch): Return what branch the current checkout is on.
2592         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2593         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2594         * Scripts/webkitpy/common/checkout/scm/svn.py:
2595         (SVN.native_branch): Ditto.
2596         * Scripts/webkitpy/common/system/platforminfo.py:
2597         (PlatformInfo.build_version): Return a build version for Mac.
2598         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2599         (MockPlatformInfo.__init__):
2600         (MockPlatformInfo.build_version):
2601         * Scripts/webkitpy/results: Added.
2602         * Scripts/webkitpy/results/__init__.py: Added.
2603         * Scripts/webkitpy/results/options.py: Added.
2604         (upload_options): OptParse list for upload options.
2605         * Scripts/webkitpy/results/upload.py: Added.
2606         (Upload): Class which enforces the upload format expected by the results server.
2607         (Upload.Expectations):
2608         (Upload.create_configuration):
2609         (Upload.create_commit):
2610         (Upload.create_details):
2611         (Upload.create_run_stats):
2612         (Upload.create_test_result):
2613         (Upload.__init__):
2614         (Upload.Encoder): Encode Upload object as json.
2615         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2616         * Scripts/webkitpy/results/upload_unittest.py: Added.
2617         * Scripts/webkitpy/test/main.py:
2618         (Tester._parse_args): Add upload arguments.
2619         (Tester._run_tests): Allow results to be uploaded.
2620         * Scripts/webkitpy/test/runner.py:
2621         (Runner.__init__): Record which tests were run, rather than just counting them.
2622         (Runner.handle):
2623         * Scripts/webkitpy/test/runner_unittest.py:
2624         (RunnerTest.test_run):
2625         * Scripts/webkitpy/thirdparty/__init__.py:
2626         (AutoinstallImportHook.find_module): Add requests auto-install.
2627         (AutoinstallImportHook._install_requests):
2628         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2629         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2630
2631 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2632
2633         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2634         https://bugs.webkit.org/show_bug.cgi?id=195810
2635
2636         Reviewed by Tim Horton.
2637
2638         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2639         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2640         ending certain layout tests.
2641
2642         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2643         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2644         (-[TestRunnerWKWebView dealloc]):
2645         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2646
2647         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2648         helper method when destroying the web view, and when resetting state between tests.
2649
2650         * WebKitTestRunner/ios/TestControllerIOS.mm:
2651         (WTR::TestController::platformResetStateToConsistentValues):
2652
2653         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2654
2655 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2656
2657         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2658         https://bugs.webkit.org/show_bug.cgi?id=190350
2659         <rdar://problem/45089503>
2660
2661         Reviewed by Geoffrey Garen.
2662
2663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2664         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2665         (TEST):
2666         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2667         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2668         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2669         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2670         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2671         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2672         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2673         (runTest):
2674         (createDirectories):
2675         (TEST):
2676         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2677         (TEST):
2678         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2679         (TEST):
2680
2681 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2682
2683         Add support to WebPage for getting the contents as an attributed string.
2684         https://bugs.webkit.org/show_bug.cgi?id=195636
2685         rdar://problem/45055697
2686
2687         Reviewed by Tim Horton.
2688
2689         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2690         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2691
2692 2019-03-15  Chris Dumez  <cdumez@apple.com>
2693
2694         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2695         https://bugs.webkit.org/show_bug.cgi?id=195747
2696
2697         Reviewed by Geoff Garen.
2698
2699         Add API test coverage.
2700
2701         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2702
2703 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2704
2705         Unreviewed, rolling out r242952.
2706
2707         Causing API failures on iOS Simulator
2708
2709         Reverted changeset:
2710
2711         "[PSON] Make sure the WebProcessCache is leverage when
2712         relaunching a process after termination"
2713         https://bugs.webkit.org/show_bug.cgi?id=195747
2714         https://trac.webkit.org/changeset/242952
2715
2716 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2717
2718         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2719         https://bugs.webkit.org/show_bug.cgi?id=195740
2720
2721         Reviewed by Ross Kirsling.
2722
2723         window.open doesn't work for WebKitBrowserWindow because it is not
2724         implemented yet.
2725
2726         1. Implemented createNewPage callback of WKPageUIClient.
2727         2. Changed MainWindow to take a BrowserWindow factory function
2728           instead of BrowserWindowType to be flexible to create
2729           BrowserWindow with extra settings.
2730         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2731           because it is not relevant with MainWindow anymore.
2732
2733         * MiniBrowser/win/Common.cpp:
2734         (parseCommandLine):
2735         * MiniBrowser/win/Common.h:
2736         (CommandLineOptions::CommandLineOptions):
2737         * MiniBrowser/win/MainWindow.cpp:
2738         (MainWindow::MainWindow):
2739         (MainWindow::create):
2740         (MainWindow::init):
2741         (MainWindow::WndProc):
2742         * MiniBrowser/win/MainWindow.h:
2743         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2744         (PrintWebUIDelegate::createWebViewWithRequest):
2745         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2746         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2747         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2748         (WebKitBrowserWindow::updateProxySettings):
2749         (WebKitBrowserWindow::createNewPage):
2750         * MiniBrowser/win/WebKitBrowserWindow.h:
2751         * MiniBrowser/win/WinMain.cpp:
2752         (wWinMain):
2753
2754 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2755
2756         Make it possible to test scrolling tree layer manipulation more easily
2757         https://bugs.webkit.org/show_bug.cgi?id=195780
2758
2759         Reviewed by Tim Horton.
2760         
2761         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2762         cuts off communication of scrolling tree scrolls back to the web process
2763         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2764         allows tests to trigger scrolls which run the scrolling tree layer positioning
2765         logic, but never get another commit from the web process that might mask
2766         scrolling tree bugs.
2767         
2768         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2769         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2770         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2771
2772         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2773         (WTR::UIScriptController::scrollUpdatesDisabled const):
2774         (WTR::UIScriptController::setScrollUpdatesDisabled):
2775         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2776         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2777         (WTR::UIScriptController::scrollUpdatesDisabled const):
2778         (WTR::UIScriptController::setScrollUpdatesDisabled):
2779         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2780         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2781         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2782         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2783         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2784         * WebKitTestRunner/ios/TestControllerIOS.mm:
2785         (WTR::TestController::platformResetStateToConsistentValues):
2786         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2787         (WTR::UIScriptController::scrollUpdatesDisabled const):
2788         (WTR::UIScriptController::setScrollUpdatesDisabled):
2789
2790 2019-03-14  Youenn Fablet  <youenn@apple.com>
2791
2792         Move IDB storage in private browsing mode to NetworkProcess
2793         https://bugs.webkit.org/show_bug.cgi?id=195602
2794
2795         Reviewed by Brady Eidson.
2796
2797         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2798         (TEST):
2799
2800 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2801
2802         [ews-build] Make descriptionDone messages more readable
2803         https://bugs.webkit.org/show_bug.cgi?id=195760
2804
2805         Reviewed by Lucas Forschler.
2806
2807         * BuildSlaveSupport/ews-build/steps.py:
2808         * BuildSlaveSupport/ews-build/steps_unittest.py:
2809
2810 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2811
2812         [ews-build] Generate status-bubble hover-over messages
2813         https://bugs.webkit.org/show_bug.cgi?id=195680
2814
2815         Reviewed by Lucas Forschler.
2816
2817         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2818         (StatusBubble):
2819         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2820         on hover-over.
2821         (StatusBubble._iso_time):
2822         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2823         hover-over message.
2824         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2825
2826 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2827
2828         [ews-app] Gracefully handle the case when state_string is None
2829         https://bugs.webkit.org/show_bug.cgi?id=195753
2830
2831         Reviewed by Lucas Forschler.
2832
2833         * BuildSlaveSupport/ews-app/ews/models/build.py:
2834         * BuildSlaveSupport/ews-app/ews/models/step.py:
2835
2836 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2837
2838         [ews-app] Status bubble display pending for currently running build step
2839         https://bugs.webkit.org/show_bug.cgi?id=195744
2840
2841         Reviewed by Lucas Forschler.
2842
2843         * BuildSlaveSupport/ews-build/events.py:
2844         (Events.stepStarted): If state_string is pending, replace it with step name.
2845
2846 2019-03-14  Chris Dumez  <cdumez@apple.com>
2847
2848         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2849         https://bugs.webkit.org/show_bug.cgi?id=195750
2850
2851         Reviewed by Geoffrey Garen.
2852
2853         Add API test coverage.
2854
2855         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2856         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2857         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2858         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2859
2860 2019-03-14  Chris Dumez  <cdumez@apple.com>
2861
2862         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2863         https://bugs.webkit.org/show_bug.cgi?id=195747
2864
2865         Reviewed by Geoff Garen.
2866
2867         Add API test coverage.
2868
2869         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2870
2871 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2872
2873         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2874         https://bugs.webkit.org/show_bug.cgi?id=195725
2875         <rdar://problem/48545062>
2876
2877         Reviewed by Tim Horton.
2878
2879         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2880         handler is nil.
2881
2882         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2883         (TestWebKitAPI::TEST):
2884
2885 2019-03-13  Sam Weinig  <sam@webkit.org>
2886
2887         Add utility function to allow easy reverse range-based iteration of a container
2888         https://bugs.webkit.org/show_bug.cgi?id=195542
2889
2890         Reviewed by Antti Koivisto.
2891
2892         * TestWebKitAPI/CMakeLists.txt:
2893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2894         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2895         (TestWebKitAPI::TEST):
2896         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2897
2898 2019-03-13  Chris Dumez  <cdumez@apple.com>
2899
2900         Use a ServiceWorker process per registrable domain
2901         https://bugs.webkit.org/show_bug.cgi?id=195649
2902
2903         Reviewed by Youenn Fablet.
2904
2905         Update API test coverage.
2906
2907         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2908
2909 2019-03-13  Chris Dumez  <cdumez@apple.com>
2910
2911         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2912         https://bugs.webkit.org/show_bug.cgi?id=195684
2913         <rdar://problem/48294714>
2914
2915         Reviewed by Antti Koivisto.
2916
2917         Add API test coverage.
2918
2919         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2920
2921 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2922
2923         [ews-app] Remove unused patch view
2924         https://bugs.webkit.org/show_bug.cgi?id=195669
2925
2926         Reviewed by Lucas Forschler.
2927
2928         * BuildSlaveSupport/ews-app/ews/urls.py:
2929         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2930
2931 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2932
2933         [ews-app] Use Buildbot result code variables
2934         https://bugs.webkit.org/show_bug.cgi?id=195668
2935
2936         Reviewed by Alexey Proskuryakov.
2937
2938         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2939         (Buildbot): Added Buildbot result code variables.
2940         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2941         (StatusBubble._build_bubble): Used Buildbot result code variables.
2942
2943 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2944
2945         [Flatpak] Expand submodule recursively
2946         https://bugs.webkit.org/show_bug.cgi?id=195672
2947
2948         Building WPE with flatpak was impossible without that as it was raising an exception.
2949         Also update wpebackend-fdo to match what is built in jhbuild
2950
2951         Reviewed by Philippe Normand.
2952
2953         * flatpak/flatpakutils.py:
2954         (expand_submodules_recurse):
2955         (expand_manifest):
2956         * flatpak/org.webkit.WPEModules.yaml:
2957
2958 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2959
2960         [ews-app] status bubble should be hidden for certain builds
2961         https://bugs.webkit.org/show_bug.cgi?id=194597
2962
2963         Reviewed by Dewei Zhu.
2964
2965         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2966         (StatusBubble._build_bubble):
2967         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2968         because the patch didn't have relevant changes.
2969         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2970         in production yet.
2971
2972 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2973
2974         [Win] Fix a slew of simple clang-cl warnings.
2975         https://bugs.webkit.org/show_bug.cgi?id=195652
2976
2977         Reviewed by Don Olmstead.
2978
2979         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2980         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2981
2982 2019-03-12  Justin Fan  <justin_fan@apple.com>
2983
2984         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2985         https://bugs.webkit.org/show_bug.cgi?id=195518
2986         <rdar://problem/46322356>
2987
2988         Reviewed by Myles C. Maxfield.
2989
2990         * DumpRenderTree/DerivedSources-input.xcfilelist:
2991         * DumpRenderTree/DerivedSources-output.xcfilelist:
2992
2993 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2994
2995         Unreviewed, rolling out r242825.
2996         https://bugs.webkit.org/show_bug.cgi?id=195648
2997
2998         "Broke webkitpy tests with my change to
2999         lldb_dump_class_layout.py" (Requested by rmorisset on
3000         #webkit).
3001
3002         Reverted changeset:
3003
3004         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3005         classes with suspicious padding"
3006         https://bugs.webkit.org/show_bug.cgi?id=195573
3007         https://trac.webkit.org/changeset/242825
3008
3009 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3010
3011         [ews-build] Show status bubbles while the patch is waiting in queue
3012         https://bugs.webkit.org/show_bug.cgi?id=195618
3013
3014         Reviewed by Lucas Forschler.
3015
3016         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3017         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3018         enabled in initial deployment.
3019         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3020         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3021         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3022         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3023         (StatusBubble._build_bubbles_for_patch):
3024
3025 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3026
3027         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3028         https://bugs.webkit.org/show_bug.cgi?id=195573
3029
3030         Reviewed by Simon Fraser.
3031
3032         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3033
3034         * Scripts/dump-class-layout:
3035         (main):
3036         * lldb/lldb_dump_class_layout.py:
3037         (ClassLayout.__init__):
3038         (ClassLayout._compute_padding_recursive):
3039         (LLDBDebuggerInstance.dump_layout_for_classname):
3040         (LLDBDebuggerInstance):
3041         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3042         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3043
3044 2019-03-12  Chris Dumez  <cdumez@apple.com>
3045
3046         Device Orientation access permission should be denied unless explicitly granted by the client
3047         https://bugs.webkit.org/show_bug.cgi?id=195625
3048
3049         Reviewed by Youenn Fablet.
3050
3051         add API test coverage.
3052
3053         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3054         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3055         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3056         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3057         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3058         (runDeviceOrientationTest):
3059         (TEST):
3060         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3061         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3062
3063 2019-03-12  Jer Noble  <jer.noble@apple.com>
3064
3065         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3066         https://bugs.webkit.org/show_bug.cgi?id=195137
3067         <rdar://problem/48810307>
3068
3069         Reviewed by Eric Carlson.
3070
3071         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3072         (TestWebKitAPI::TEST):
3073
3074 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3075
3076         [ews-build] Change urls from uat to production
3077         https://bugs.webkit.org/show_bug.cgi?id=195566
3078
3079         Reviewed by Lucas Forschler.
3080
3081         * BuildSlaveSupport/ews-app/ews/config.py:
3082         * BuildSlaveSupport/ews-build/events.py:
3083         * BuildSlaveSupport/ews-build/steps.py:
3084
3085 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3086
3087         [ews-build] change max_builds for local-worker to 1
3088         https://bugs.webkit.org/show_bug.cgi?id=195568
3089
3090         Reviewed by Lucas Forschler.
3091
3092         * BuildSlaveSupport/ews-build/loadConfig.py:
3093
3094 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3095
3096         Fix the build
3097
3098         * TestRunnerShared/spi/PencilKitTestSPI.h:
3099         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3100
3101 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3102
3103         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3104         https://bugs.webkit.org/show_bug.cgi?id=194131
3105
3106         Reviewed by Michael Catanzaro.
3107
3108         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3109         (uriChanged):
3110         (testUnfinishedSubresourceLoad):
3111         (serverCallback):
3112         (beforeAll):
3113
3114 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3115
3116         WTF::Expected should use std::addressof instead of operator&
3117         https://bugs.webkit.org/show_bug.cgi?id=195604
3118
3119         Reviewed by Myles Maxfield.
3120
3121         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3122         (TestWebKitAPI::Unique::Unique):
3123         (TestWebKitAPI::Unique::operator&):
3124         (TestWebKitAPI::TEST):
3125
3126 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3127
3128         Add Optional to Forward.h.
3129         https://bugs.webkit.org/show_bug.cgi?id=195586
3130
3131         Reviewed by Darin Adler.
3132
3133         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3134         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3135         Remove unnecessary includes from headers.
3136
3137 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3138
3139         Add testing API to hit-test and scroll overflow scrollers
3140         https://bugs.webkit.org/show_bug.cgi?id=195278
3141
3142         Reviewed by Antti Koivisto.
3143         
3144         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3145         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3146         
3147         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3148
3149         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3150         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3151         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3152         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3153         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3154         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3155         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3156         (WTR::enclosingScrollViewIncludingSelf):
3157         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3158
3159 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3160
3161         API test WebKit.RequestTextInputContext fails on iOS
3162         https://bugs.webkit.org/show_bug.cgi?id=195585
3163
3164         Reviewed by Wenson Hsieh and Simon Fraser.
3165
3166         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3167         (applyStyle):
3168         (TEST):
3169         Add a viewport, so that the coordinates match up on iOS.
3170         Scroll by moving the UIScrollView's contentOffset.
3171
3172 2019-03-11  Chris Dumez  <cdumez@apple.com>
3173
3174         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3175         https://bugs.webkit.org/show_bug.cgi?id=195506
3176         <rdar://problem/48733477>
3177
3178         Reviewed by Alex Christensen.
3179
3180         Add API test coverage.
3181
3182         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3183
3184 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3185
3186         Adding myself to contributors.json
3187
3188         Unreviewed, addming myself to contributors.json .
3189
3190         * Scripts/webkitpy/common/config/contributors.json:
3191
3192 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3193
3194         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3195         https://bugs.webkit.org/show_bug.cgi?id=195511
3196         <rdar://problem/44873269>
3197
3198         Reviewed by Darin Adler.
3199
3200         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3201         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3202         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3203         (TEST_F):
3204
3205 2019-03-11  Chris Dumez  <cdumez@apple.com>
3206
3207         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3208         https://bugs.webkit.org/show_bug.cgi?id=195561
3209
3210         Reviewed by Youenn Fablet.
3211
3212         Make sure the JS in the test requests for permission to receive device orientation events.
3213
3214         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3215
3216 2019-03-11  Youenn Fablet  <youenn@apple.com>
3217
3218         Allow storage quota increase by default in WTR
3219         https://bugs.webkit.org/show_bug.cgi?id=195541
3220
3221         Reviewed by Geoffrey Garen.
3222
3223         Allow storage quota increase by default in WTR.
3224         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3225         Use this for tests that explicitly need cache increase.
3226
3227         Instead of increasing quota by 2, make sure the next request is
3228         granted by adding all given parameters.
3229
3230         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3231         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3232         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3233         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3234         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3235         * WebKitTestRunner/TestController.cpp:
3236         (WTR::TestController::setAllowStorageQuotaIncrease):
3237         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3238         * WebKitTestRunner/TestController.h:
3239         * WebKitTestRunner/TestInvocation.cpp:
3240         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3241         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3242         (WTR::TestController::cocoaResetStateToConsistentValues):
3243         (WTR::TestController::setAllowStorageQuotaIncrease):
3244         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3245         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3246         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3247
3248 2019-03-11  Xan Lopez  <xan@igalia.com>
3249
3250         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3251         https://bugs.webkit.org/show_bug.cgi?id=194147
3252
3253         Reviewed by Michael Saboff.
3254
3255         To make --32-bit work correctly on Linux/64bit we need to:
3256
3257         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3258         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3259         unfortunately CMake only allows us to do this during
3260         crosscompilation, which is overkill here.
3261         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3262         pkg-config detection module uses the x86 .pc files instead of the
3263         x86_64 ones.
3264         - Set the -m32 flags for the compiler.
3265
3266         * Scripts/webkitdirs.pm:
3267         (generateBuildSystemFromCMakeProject):
3268
3269 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3270
3271         Add MotionMark-1.1 plan file for run-benchmark script.
3272         https://bugs.webkit.org/show_bug.cgi?id=195481
3273
3274         Rubber-stamped by Darin Adler.
3275
3276         Run-benchmark script should support MontionMark-1.1.
3277
3278         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3279
3280 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3281
3282         [ews-app] Add support for submit-to-ews url
3283         https://bugs.webkit.org/show_bug.cgi?id=195477
3284
3285         Reviewed by Lucas Forschler.
3286
3287         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3288         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3289         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3290         * BuildSlaveSupport/ews-app/ews/urls.py:
3291         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3292
3293 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3294
3295         Unreviewed, rolling out r242688, r242643, r242624.
3296
3297         Caused multiple layout test failures and crashes on iOS and macOS.
3298
3299         Reverted changeset:
3300
3301         "requestAnimationFrame should execute before the next frame"
3302         https://bugs.webkit.org/show_bug.cgi?id=177484
3303         https://trac.webkit.org/changeset/242624/webkit
3304
3305         * Tracing/SystemTracePoints.plist:
3306
3307 2019-03-11  John Wilander  <wilander@apple.com>
3308
3309         Resource Load Statistics: Make it possible exclude localhost from classification
3310         https://bugs.webkit.org/show_bug.cgi?id=195474
3311         <rdar://problem/47520577>
3312
3313         Reviewed by Brent Fulgham.
3314
3315         This patch allows for localhost to be excluded from classification and
3316         treatment as a prevalent resource.
3317
3318         The WebKit Tools change adds a new function called
3319         testRunner.setStatisticsIsRunningTest() which can be used to control this
3320         behavior.
3321
3322         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3323         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3324         (WTR::TestRunner::setStatisticsIsRunningTest):
3325         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3326         * WebKitTestRunner/TestController.cpp:
3327         (WTR::TestController::setStatisticsIsRunningTest):
3328         * WebKitTestRunner/TestController.h:
3329         * WebKitTestRunner/TestInvocation.cpp:
3330         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3331
3332 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3333
3334         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3335         https://bugs.webkit.org/show_bug.cgi?id=195560
3336
3337         Reviewed by Lucas Forschler.
3338
3339         * BuildSlaveSupport/ews-build/master.cfg:
3340
3341 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3342
3343         Unreviewed, rolling out r242698.
3344
3345         API test crashes on bots.
3346
3347         Reverted changeset:
3348
3349         "Add a WKContentRuleList variant that uses copied memory
3350         instead of mmap'd shared memory for class A containerized
3351         apps"
3352         https://bugs.webkit.org/show_bug.cgi?id=195511
3353         https://trac.webkit.org/changeset/242698
3354
3355 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3356
3357         [WPE] Enable web process sandbox
3358         https://bugs.webkit.org/show_bug.cgi?id=195169
3359
3360         Reviewed by Daniel Bates.
3361
3362         * wpe/install-dependencies:
3363         * wpe/jhbuild.modules:
3364
3365 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3366
3367         [ews-app] Use port 17000 for worker communication
3368         https://bugs.webkit.org/show_bug.cgi?id=195558
3369
3370         Reviewed by Lucas Forschler.
3371
3372         * BuildSlaveSupport/ews-build/master.cfg:
3373
3374 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3375
3376         [ews-build] unit-tests fail when passwords.json is missing
3377         https://bugs.webkit.org/show_bug.cgi?id=195557
3378
3379         Reviewed by Lucas Forschler.
3380
3381         * BuildSlaveSupport/ews-build/loadConfig.py:
3382         (loadBuilderConfig):
3383         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3384         (ConfigDotJSONTest.test_configuration):
3385         * BuildSlaveSupport/ews-build/master.cfg:
3386
3387 2019-03-11  Truitt Savell  <tsavell@apple.com>
3388
3389         Unreviewed, rolling out r242702.
3390
3391         Broke High Sierra builders.
3392
3393         Reverted changeset:
3394
3395         "Add utility function to allow easy reverse range-based
3396         iteration of a container"
3397         https://bugs.webkit.org/show_bug.cgi?id=195542
3398         https://trac.webkit.org/changeset/242702
3399
3400 2019-03-11  Sam Weinig  <sam@webkit.org>
3401
3402         Add utility function to allow easy reverse range-based iteration of a container
3403         https://bugs.webkit.org/show_bug.cgi?id=195542
3404
3405         Reviewed by Antti Koivisto.
3406
3407         * TestWebKitAPI/CMakeLists.txt:
3408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3409         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3410         (TestWebKitAPI::TEST):
3411         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3412
3413 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3414
3415         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3416         https://bugs.webkit.org/show_bug.cgi?id=195511
3417         <rdar://problem/44873269>
3418
3419         Reviewed by Darin Adler.
3420
3421         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3422         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3423         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3424         (TEST_F):
3425
3426 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3427
3428         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3429         https://bugs.webkit.org/show_bug.cgi?id=195499
3430
3431         Reviewed by Darin Adler.
3432
3433         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3434         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3435         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3436         (-[WKWebView synchronouslyFocusTextInputContext:]):
3437         (applyStyle):
3438         (applyIframe):
3439         (TEST):
3440         Add some tests for this SPI.
3441
3442 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3443
3444         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3445         https://bugs.webkit.org/show_bug.cgi?id=181151
3446
3447         Reviewed by Don Olmstead.
3448
3449         * TestWebKitAPI/CMakeLists.txt:
3450         * TestWebKitAPI/PlatformWin.cmake:
3451         Enable TestWTF RunLoop tests in all platforms.
3452
3453         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3454         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3455         (TestWebKitAPI::DerivedOneShotTimer::fired):
3456         (TestWebKitAPI::TEST):
3457         Only a few platforms support nested RunLoop.
3458
3459         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3460         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3461
3462 2019-03-10  David Quesada  <david_quesada@apple.com>
3463
3464         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3465         https://bugs.webkit.org/show_bug.cgi?id=152480
3466
3467         Reviewed by Chris Dumez.
3468
3469         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3470         there are no additional references to the process pool besides the one held by
3471         the download, waits for the download to finish (in the sense that the
3472         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3473         measure, also check that the process pool has been deallocated at the end of the
3474         test. The test wouldn't be meaningful if the process pool were still alive.
3475
3476         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3477         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3478         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3479             The download will be canceled because the delegate does not implement the
3480             method to decide the download's destination, so this is where we know the
3481             DownloadProxyMap is done with the DownloadProxy.
3482         (TEST):
3483
3484 2019-03-08  Chris Dumez  <cdumez@apple.com>
3485
3486         Add support for Device Orientation / Motion permission API
3487         https://bugs.webkit.org/show_bug.cgi?id=195329
3488         <rdar://problem/47645367>
3489
3490         Reviewed by Geoffrey Garen.
3491
3492         Add test infrastructure to help test the Device Orientation / Motion permission API.
3493
3494         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3495         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3496         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3497         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3498         * WebKitTestRunner/TestController.cpp:
3499         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3500         (WTR::TestController::createWebViewWithOptions):
3501         (WTR::TestController::resetStateToConsistentValues):
3502         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3503         * WebKitTestRunner/TestController.h:
3504         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3505         * WebKitTestRunner/TestInvocation.cpp:
3506         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3507
3508 2019-03-08  Saam barati  <sbarati@apple.com>
3509
3510         Add a compare-results script to compare benchmark results
3511         https://bugs.webkit.org/show_bug.cgi?id=195486
3512         <rdar://problem/48723397>
3513
3514         Reviewed by Geoffrey Garen.
3515
3516         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3517         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3518         to extend it to learn about our other benchmarks.
3519
3520         * Scripts/compare-results: Added.
3521         (readJSONFile):
3522         (detectJetStream2):
3523         (JetStream2Results):
3524         (detectSpeedometer2):
3525         (Speedometer2Results):
3526         (detectPLT5):
3527         (PLT5Results):
3528         (detectBenchmark):
3529         (biggerIsBetter):
3530         (ttest):
3531         (getOptions):
3532         (main):
3533
3534 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3535
3536         Ensure old tab state is cleared between iterations of run-benchmark
3537         https://bugs.webkit.org/show_bug.cgi?id=195393
3538         <rdar://problem/46885583>
3539
3540         Reviewed by Dewei Zhu.
3541
3542         a) ensure the default to restore state is not set
3543         b) terminate Safari correctly
3544         c) Set the system default to ignore Persistent State in Safari
3545
3546         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3547         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3548         (OSXBrowserDriver.prepare_env): 
3549         (OSXBrowserDriver.restore_env):
3550         (OSXBrowserDriver.close_browsers):
3551         (OSXBrowserDriver._terminate_processes):
3552         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3553         (OSXChromeDriver):
3554         (OSXChromeCanaryDriver):
3555         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3556         (OSXFirefoxDriver):
3557         (OSXFirefoxNightlyDriver):
3558         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3559         (OSXSafariDriver):
3560         (OSXSafariDriver.prepare_env):
3561
3562 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3563
3564         [GTK] Several InputMethodFilter tests are failing
3565         https://bugs.webkit.org/show_bug.cgi?id=195408
3566
3567         Reviewed by Carlos Garcia Campos.
3568
3569         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3570         Regressed in r241751.
3571         Hexadecimal values of keycodes are expressed now in upper letters.
3572         Composited characters should be cast to UTF8 strings.
3573
3574         (TestWebKitAPI::TEST):
3575
3576 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3577
3578         [GTK] Make Tools/gtkdoc python3 compatible
3579         https://bugs.webkit.org/show_bug.cgi?id=195359
3580
3581         Reviewed by Carlos Garcia Campos.
3582
3583         * gtkdoc/generate-gtkdoc:
3584         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3585         work with Python 2 and 3.
3586         (get_gtkdoc_module_paths):
3587         The iteritems() was removed in Python 3, so let's use items() that's
3588         available in Python 2 and 3.
3589         (get_generator_for_config):
3590         * gtkdoc/gtkdoc.py:
3591         (GTKDoc._run_command):
3592         The sys.stdout.write() is expecting str in Python 3 and not bytes
3593         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3594         for passing the bytes there.
3595
3596 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3597
3598         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3599         https://bugs.webkit.org/show_bug.cgi?id=195346
3600         <rdar://problem/48667048>
3601
3602         Unreviewed build fix for clang-cl.
3603
3604         * DumpRenderTree/win/DumpRenderTree.cpp:
3605         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3606
3607 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3608
3609         requestAnimationFrame should execute before the next frame
3610         https://bugs.webkit.org/show_bug.cgi?id=177484
3611
3612         Reviewed by Simon Fraser.
3613
3614         Add trace points for the page RenderingUpdate.
3615
3616         * Tracing/SystemTracePoints.plist:
3617
3618 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3619
3620         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3621         https://bugs.webkit.org/show_bug.cgi?id=195353
3622         <rdar://problem/48626394>
3623
3624         Reviewed by Simon Fraser.
3625
3626         * WebKitTestRunner/ios/TestControllerIOS.mm:
3627         (WTR::TestController::platformResetPreferencesToConsistentValues):
3628
3629 2019-03-07  John Wilander  <wilander@apple.com>
3630
3631         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3632         https://bugs.webkit.org/show_bug.cgi?id=195383
3633         <rdar://problem/48570136>
3634
3635         Reviewed by Brent Fulgham.
3636
3637         This patch adds test infrastructure to purge only script-accessible cookies,
3638         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3639
3640         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3641         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3642         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3643         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3644         * WebKitTestRunner/TestController.cpp:
3645         (WTR::TestController::statisticsDeleteCookiesForHost):
3646         * WebKitTestRunner/TestController.h:
3647         * WebKitTestRunner/TestInvocation.cpp:
3648         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3649
3650 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3651
3652         Unreviewed, rolling out r242354.
3653         https://bugs.webkit.org/show_bug.cgi?id=195402
3654
3655         breaks layout tests in all configurations (Requested by
3656         zdobersek on #webkit).
3657
3658         Reverted changeset:
3659
3660         "[WPE] Enable web process sandbox"
3661         https://bugs.webkit.org/show_bug.cgi?id=195169
3662         https://trac.webkit.org/changeset/242354
3663
3664 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3665
3666         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3667         https://bugs.webkit.org/show_bug.cgi?id=195346
3668
3669         Reviewed by Fujii Hironori.
3670
3671         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3672         (TestWebKitAPI::TEST):
3673         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3674
3675         * DumpRenderTree/win/DumpRenderTree.cpp:
3676         (findFontFallback):
3677         (addFontFallbackIfPresent):
3678         (removeFontFallbackIfPresent):
3679         (main):
3680         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3681         (TestWebKitAPI::Util::moduleDirectory):
3682         (TestWebKitAPI::Util::createInjectedBundlePath):
3683         Use wchar helpers as needed.
3684
3685 2019-03-06  Rob Buis  <rbuis@igalia.com>
3686
3687         Consider supporting the `referrerpolicy` attribute.
3688         https://bugs.webkit.org/show_bug.cgi?id=179053
3689
3690         Reviewed by Darin Adler.
3691
3692         Add a runtime flag for referrerpolicy attribute.
3693
3694         * DumpRenderTree/mac/DumpRenderTree.mm:
3695         (enableExperimentalFeatures):
3696
3697 2019-03-05  Daniel Bates  <dabates@apple.com>
3698
3699         Update expected API test result following r242379
3700         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3701
3702         Update expected x-coordinate of selection rect now that the left padding of
3703         a textarea is sized in ems (so dependent on the font size) just like the left
3704         padding of a text field.
3705
3706         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3707         (TestWebKitAPI::TEST):
3708
3709 2019-03-05  David Quesada  <david_quesada@apple.com>
3710
3711         [WK2] It should be possible to follow links with 'download' attributes
3712         https://bugs.webkit.org/show_bug.cgi?id=195145
3713         rdar://problem/48462642
3714
3715         Reviewed by Alex Christensen.
3716
3717         Add a unit test to verify that activating links with 'download' attributes now
3718         navigates to the linked resource, rather than starts downloading it. Add another
3719         to verify that it is still possible to explicitly download the link via the
3720         'Download' navigation action policy.
3721
3722         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3723         (-[DownloadAttributeTestDelegate init]):
3724         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3725         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3726         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3727         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3728         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3729         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3730         (TEST):
3731         * WebKitTestRunner/TestController.cpp:
3732         (WTR::TestController::decidePolicyForNavigationAction):
3733         * WebKitTestRunner/TestController.h:
3734
3735 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3736
3737         [Curl] Implement Cookie Accept Policy.
3738         https://bugs.webkit.org/show_bug.cgi?id=191645
3739
3740         Reviewed by Fujii Hironori.
3741
3742         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3743         (TestWebKitAPI::Curl::TEST_F):
3744
3745 2019-03-05  Youenn Fablet  <youenn@apple.com>
3746
3747         Rename requestCacheStorageSpace to requestStorageSpace
3748         https://bugs.webkit.org/show_bug.cgi?id=195282
3749
3750         Reviewed by Chris Dumez.
3751
3752         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3753         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3754         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3755
3756 2019-03-05  Brady Eidson  <beidson@apple.com>
3757
3758         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3759         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3760
3761         Reviewed by Tim Horton.
3762
3763         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3764         different directory into that same WKWebView should work.
3765
3766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3767         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3768
3769 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3770
3771         Add WeakHashSet
3772         https://bugs.webkit.org/show_bug.cgi?id=195152
3773
3774         Reviewed by Antti Koivisto.
3775
3776         Added tests for WeakHashSet.
3777
3778         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3779         (TestWebKitAPI::Base::Base): Moved.
3780         (TestWebKitAPI::Derived::foo): Moved.
3781         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3782         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3783         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3784         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3785
3786 2019-03-04  Chris Dumez  <cdumez@apple.com>
3787
3788         Do not share WebProcesses between private and regular sessions
3789         https://bugs.webkit.org/show_bug.cgi?id=195189
3790         <rdar://problem/48421064>
3791
3792         Reviewed by Alex Christensen.
3793
3794         Add API test coverage.
3795
3796         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3797         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3798
3799 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3800
3801         [WPE] Enable web process sandbox
3802         https://bugs.webkit.org/show_bug.cgi?id=195169
3803
3804         Reviewed by Daniel Bates.
3805
3806         * wpe/install-dependencies:
3807         * wpe/jhbuild.modules:
3808
3809 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3810
3811         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3812         https://bugs.webkit.org/show_bug.cgi?id=195206
3813
3814         Reviewed by Žan Doberšek.
3815
3816         Add a new test case.
3817
3818         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3819         (testJSCClass):
3820
3821 2019-03-04  Charlie Turner  <cturner@igalia.com>
3822
3823         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3824         https://bugs.webkit.org/show_bug.cgi?id=194898
3825
3826         Reviewed by Žan Doberšek.
3827
3828         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3829         a GCC extension that permits arithmetic on void* pointer. Inline
3830         the macro until this issue is fixed upstream.
3831
3832 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3833
3834         Rid the world of WK_API_ENABLED
3835         https://bugs.webkit.org/show_bug.cgi?id=195263
3836
3837         Reviewed by Dan Bernstein.
3838
3839         List of changed files elided because it's useless.
3840
3841 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3842
3843         Unreviewed follow-up to r242292.
3844
3845         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3846
3847         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3848         (TestWebKitAPI::testStrip): Renamed from strip.
3849         (TestWebKitAPI::TEST):
3850
3851 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3852
3853         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3854
3855         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3856         and bug #194272 for details.
3857
3858         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3859
3860 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3861
3862         Remove some more unused 32-bit code
3863         https://bugs.webkit.org/show_bug.cgi?id=195255
3864
3865         Reviewed by Darin Adler.
3866
3867         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3868         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3869         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3870         (NPP_New):
3871         (NPP_HandleEvent):
3872         (handleEventCarbon): Deleted.
3873
3874 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3875
3876         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3877
3878         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3879         (TestWebKitAPI::TEST):
3880
3881 2019-03-01  Darin Adler  <darin@apple.com>
3882
3883         Finish removing String::format
3884         https://bugs.webkit.org/show_bug.cgi?id=194893
3885
3886         Reviewed by Daniel Bates.
3887 '
3888         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3889
3890 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3891
3892         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3893         https://bugs.webkit.org/show_bug.cgi?id=195229
3894         <rdar://problem/48520362>
3895
3896         Reviewed by Chris Dumez.
3897
3898         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3899         (TEST):
3900
3901 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3902
3903         Add a system trace scope for event region building
3904         https://bugs.webkit.org/show_bug.cgi?id=195226
3905
3906         Reviewed by Jon Lee.
3907
3908         This trace scope measures the time spend converting element rects into Region objects,
3909         which can be large on some pages.
3910
3911         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3912
3913         * Tracing/SystemTracePoints.plist:
3914
3915 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3916
3917         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3918         https://bugs.webkit.org/show_bug.cgi?id=194612
3919
3920         Reviewed by Alex Christensen.
3921
3922         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3923         Just test the new string-processing function and don't touch the actual environment.
3924         (Test cases are all as before, but based on operator== instead of strcmp.)
3925
3926 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3927
3928         [ews-app] Update primary keys for handling multiple Buildbot instances
3929         https://bugs.webkit.org/show_bug.cgi?id=195120
3930
3931         Reviewed by Stephanie Lewis.
3932
3933         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3934         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3935         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3936
3937         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3938         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3939         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3940         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3941         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3942         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3943
3944 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3945
3946         [WinCairo] Enable service worker
3947         https://bugs.webkit.org/show_bug.cgi?id=188318
3948
3949         Reviewed by Youenn Fablet.
3950
3951         * DumpRenderTree/DumpRenderTreePrefix.h:
3952         * TestWebKitAPI/PlatformWin.cmake:
3953         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3954         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3955         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3956
3957 2019-03-01  Justin Fan  <justin_fan@apple.com>
3958
3959         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3960         https://bugs.webkit.org/show_bug.cgi?id=195191
3961
3962         Rubber-stamped by Dean Jackson.
3963
3964         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3965
3966         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3967
3968 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3969
3970         Unreviewed, fix lldb webkitpy tests
3971         https://bugs.webkit.org/show_bug.cgi?id=194375
3972
3973         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3974
3975         * lldb/lldb_webkit.py:
3976         (WTFStringImplProvider.is_8bit):
3977
3978 2019-02-28  David Quesada  <david_quesada@apple.com>
3979
3980         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3981         https://bugs.webkit.org/show_bug.cgi?id=195121
3982         rdar://problem/48450302
3983
3984         Reviewed by Alex Christensen.
3985
3986         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3987         configurations where the 'download' attribute is absent, blank, or populated
3988         with a filename, and where the anchor element is same-origin or cross-origin
3989         (meaning the 'download' attribute shouldn't be honored).
3990
3991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3992         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3993         (-[NavigationActionTestDelegate init]):
3994         (-[NavigationActionTestDelegate navigationAction]):
3995         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3996         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3997         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3998         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3999         (TEST):
4000
4001 2019-02-28  Antoine Quint  <graouts@apple.com>
4002
4003         Enable the Pointer Events runtime flag by default
4004         https://bugs.webkit.org/show_bug.cgi?id=195156
4005
4006         Reviewed by Dean Jackson.
4007
4008         * DumpRenderTree/mac/DumpRenderTree.mm:
4009         (enableExperimentalFeatures):
4010
4011 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4012
4013         Several PasteImage API tests are flaky
4014         https://bugs.webkit.org/show_bug.cgi?id=195160
4015
4016         Reviewed by Tim Horton.
4017
4018         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4019         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4020         listening for a "load" event after image load is already complete.
4021
4022         To address this, make these tests first register a "load" event handler, then run script to insert an image
4023         element into the document, and finally wait until the load event is observed before checking image size.
4024
4025         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4026
4027 2019-02-28  Chris Dumez  <cdumez@apple.com>
4028
4029         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4030         https://bugs.webkit.org/show_bug.cgi?id=195107
4031
4032         Reviewed by Alex Christensen.
4033
4034         Give some time for the zoom level to get restored.
4035
4036         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4037
4038 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4039
4040         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4041         https://bugs.webkit.org/show_bug.cgi?id=194958
4042
4043         Reviewed by Geoffrey Garen.
4044
4045         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4046         (TEST):
4047
4048 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4049
4050         [ews-app] Update method to save build to handle builder_display_name
4051         https://bugs.webkit.org/show_bug.cgi?id=195047
4052
4053         Reviewed by Dewei Zhu.
4054
4055         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4056         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4057
4058 2019-02-28  Justin Fan  <justin_fan@apple.com>
4059
4060         [Web GPU] Enable Web GPU only on 64-bit
4061         https://bugs.webkit.org/show_bug.cgi?id=195139
4062
4063         Because Metal is only supported on 64 bit apps.
4064
4065         Unreviewed build fix.
4066
4067         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4068
4069 2019-02-27  Youenn Fablet  <youenn@apple.com>
4070
4071         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4072         https://bugs.webkit.org/show_bug.cgi?id=194959
4073
4074         Reviewed by Chris Dumez.
4075
4076         Spin loop until getting the condition to remove flakiness.
4077
4078         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4079
4080 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4081
4082         [ews-build] Buildbot should include builder_display_name in the build events
4083         https://bugs.webkit.org/show_bug.cgi?id=195045
4084
4085         Reviewed by Dewei Zhu.
4086
4087         * BuildSlaveSupport/ews-build/events.py:
4088         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4089         buildername to builder_name to be consistent in naming style.
4090         (Events.buildFinished): Ditto.
4091
4092 2019-02-27  Chris Dumez  <cdumez@apple.com>
4093
4094         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4095         https://bugs.webkit.org/show_bug.cgi?id=194480
4096
4097         Reviewed by Brady Eidson.
4098
4099         Update existing API test to make it more likely to reproduce the issue.
4100
4101         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4102
4103 2019-02-27  Brady Eidson  <beidson@apple.com>
4104
4105         Universal links from Google search results pages don't open the app.
4106         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4107
4108         Reviewed by Geoffrey Garen.
4109
4110         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4111         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4112         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4113         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4114
4115 2019-02-27  Chris Dumez  <cdumez@apple.com>
4116
4117         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4118         https://bugs.webkit.org/show_bug.cgi?id=195102
4119
4120         Reviewed by Geoffrey Garen.
4121
4122         If the number of processes is not yet what we expect, wait a bit and check again to give
4123         processes some time to exit.
4124
4125         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4126
4127 2019-02-27  Chris Dumez  <cdumez@apple.com>
4128
4129         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4130         https://bugs.webkit.org/show_bug.cgi?id=194545
4131
4132         Reviewed by Brady Eidson.
4133
4134         Make sure the test navigates forward and then back only once. Previously, navigating
4135         back would trigger a navigation again in a timer.
4136
4137         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4138
4139 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4140
4141         High Sierra Debug JSC test queue should use faster hardware
4142         https://bugs.webkit.org/show_bug.cgi?id=194603
4143
4144         Rubber-stamped by Alexey Proskuryakov.
4145
4146         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4147
4148         * BuildSlaveSupport/build.webkit.org-config/config.json:
4149         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4150         (BubbleQueueServer):
4151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4152         (WebKitBuildbot):
4153         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4154         * QueueStatusServer/config/queues.py:
4155         * Scripts/webkitpy/common/config/ews.json:
4156         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4157         (test_ews_name):
4158
4159 2019-02-27  John Wilander  <wilander@apple.com>
4160
4161         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4162         https://bugs.webkit.org/show_bug.cgi?id=195071
4163         <rdar://problem/48417690>
4164
4165         Reviewed by Alex Christensen and Brent Fulgham.
4166
4167         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4168         (TestWebKitAPI::createURL):
4169             Convenience function.
4170         (TestWebKitAPI::TEST):
4171             WebCore::AdClickAttribution now takes a URL when creating Source and
4172             Destination.
4173         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4174         (TestWebKitAPI::TEST):
4175             WebCore::AdClickAttribution now takes a URL when creating Source and
4176             Destination.
4177
4178 2019-02-27  Antoine Quint  <graouts@apple.com>
4179
4180         Support Pointer Events on macOS
4181         https://bugs.webkit.org/show_bug.cgi?id=195008
4182         <rdar://problem/47454419>
4183
4184         Reviewed by Dean Jackson.
4185
4186         * DumpRenderTree/mac/DumpRenderTree.mm:
4187         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4188         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4189
4190 2019-02-26  Mark Lam  <mark.lam@apple.com>
4191
4192         Remove remaining poisoning code.
4193         https://bugs.webkit.org/show_bug.cgi?id=194138
4194
4195         Reviewed by Saam Barati.
4196
4197         * TestWebKitAPI/CMakeLists.txt:
4198         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4199         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4200         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4201         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4202         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4203         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4204         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4205
4206 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4207
4208         Move ephemeral local storage from WebProcess to UIProcess
4209         https://bugs.webkit.org/show_bug.cgi?id=195074
4210         <rdar://problem/47937975>
4211
4212         Reviewed by Geoff Garen.
4213
4214         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4215
4216 2019-02-20  Jer Noble  <jer.noble@apple.com>
4217
4218         [Cocoa] Media elements will restart network buffering just before suspending
4219         https://bugs.webkit.org/show_bug.cgi?id=193691
4220
4221         Reviewed by Eric Carlson.
4222
4223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4224         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4225         (TEST):
4226
4227 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4228
4229         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4230         https://bugs.webkit.org/show_bug.cgi?id=191652
4231
4232         Reviewed by Alex Christensen.
4233
4234         Fix WinCairo MiniBrowser behavior of authentication dialog.
4235
4236         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4237         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4238
4239 2019-02-26  Youenn Fablet  <youenn@apple.com>
4240
4241         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4242         https://bugs.webkit.org/show_bug.cgi?id=195028
4243         <rdar://problem/48243733>
4244
4245         Reviewed by Eric Carlson.
4246
4247         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4248
4249 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4250
4251         [WPE] Add API for webview background color configuration
4252         https://bugs.webkit.org/show_bug.cgi?id=192305
4253
4254         Reviewed by Michael Catanzaro.
4255
4256         * MiniBrowser/wpe/main.cpp:
4257         (main): Add a new option to configure the webview background
4258         color. Example: --bg-color=transparent.
4259         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4260         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4261         (beforeAll): Ditto.
4262
4263 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4264
4265         scalableNativeWebpageParameters() is not preserved on new page navigation.
4266         https://bugs.webkit.org/show_bug.cgi?id=194892
4267         <rdar://problem/47538280>
4268
4269         Reviewed by Wenson Hsieh.
4270         
4271         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4272
4273         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4274         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4275         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4276         (WTR::UIScriptController::allowsViewportShrinkToFit):
4277         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4278         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4279         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4280         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4281         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4282         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4283
4284 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4285
4286         [ews-app] Add model for handling multiple Buildbot instances
4287         https://bugs.webkit.org/show_bug.cgi?id=194863
4288
4289         Reviewed by Stephanie Lewis.
4290
4291         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4292
4293 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4294
4295         [ews-app] Remove BuilderMapping table
4296         https://bugs.webkit.org/show_bug.cgi?id=194961
4297
4298         Reviewed by Stephanie Lewis.
4299
4300         Store builder name directly in build table, instead of having a separate
4301         table for it.
4302
4303         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4304         * BuildSlaveSupport/ews-app/ews/models/build.py:
4305         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4306         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4307
4308 2019-02-25  John Wilander  <wilander@apple.com>
4309
4310         Introduce and adopt new class RegistrableDomain for eTLD+1
4311         https://bugs.webkit.org/show_bug.cgi?id=194791
4312         <rdar://problem/48179240>
4313
4314         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4315
4316         This patch adds an API test and replaces two instances of
4317         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4318
4319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4320         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4321         (TestWebKitAPI::TEST):
4322             Changed two strings to make sure the registrable domains are still considered
4323             invalid and pass the test.
4324         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4325         (TestWebKitAPI::TEST):
4326         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4327         (WTR::InjectedBundle::didReceiveMessageToPage):
4328
4329 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4330
4331         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4332         https://bugs.webkit.org/show_bug.cgi?id=195001
4333
4334         Reviewed by Carlos Garcia Campos.
4335
4336         API version 1.0 always includes the functionality previously guarded with
4337         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4338         unconditionally.
4339
4340         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4341         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4342         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4343         (WebViewTest::showInWindow): Ditto.
4344         (WebViewTest::hideView): Ditto.
4345         * wpe/backends/HeadlessViewBackend.cpp:
4346         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4347         * wpe/backends/ViewBackend.cpp:
4348         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4349         * wpe/backends/WindowViewBackend.cpp:
4350         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4351         WPE_BACKEND_CHECK_VERSION().
4352         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4353
4354 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4355
4356         [Flatpak] Add support for flatpak > 1.1.2
4357         https://bugs.webkit.org/show_bug.cgi?id=194088
4358
4359         Flatpak 1.2 is now out so we need to support that
4360         version now.
4361
4362         Reviewed by Michael Catanzaro.
4363
4364         * flatpak/flatpakutils.py:
4365         (check_flatpak):
4366         (FlatpakPackages.__init__):
4367         (FlatpakPackages.__detect_packages):
4368         (FlatpakPackages.__detect_packages.in):
4369         (FlatpakRepos.update):