[Mac] WebKit contains dead source code for OS X Mavericks and earlier
[WebKit-https.git] / Tools / ChangeLog
1 2015-12-19  Dan Bernstein  <mitz@apple.com>
2
3         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
4         https://bugs.webkit.org/show_bug.cgi?id=152462
5
6         Reviewed by Alexey Proskuryakov.
7
8         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
9           OS X 10.9:
10
11         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
12         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
13         * MiniBrowser/Configurations/DebugRelease.xcconfig:
14         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
15         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
16
17         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
18           never getting compiled:
19
20         * DumpRenderTree/mac/TextInputController.m:
21         * MiniBrowser/mac/BrowserWindowController.m:
22         * TestWebKitAPI/Tests/mac/AttributedString.mm:
23         * WebKitTestRunner/mac/EventSenderProxy.mm:
24
25 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
26
27         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
28
29         This is to make it easy to CC it on Bugzilla.
30
31         * Scripts/webkitpy/common/config/contributors.json:
32
33 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
34
35         Pasteboard get messed up after running kill-old-processes
36         https://bugs.webkit.org/show_bug.cgi?id=152426
37
38         Reviewed by Alexey Proskuryakov.
39
40         * BuildSlaveSupport/kill-old-processes:
41         (main): Do not kill pasteboard anymore.
42
43 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
44
45         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
46         https://bugs.webkit.org/show_bug.cgi?id=152157
47         <rdar://problem/23851817>
48
49         Reviewed by Alexey Proskuryakov.
50
51         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
52         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
53         * Scripts/webkitpy/layout_tests/controllers/manager.py:
54         (Manager._get_test_inputs): Common method to calculate test_inputs.
55         (Manager._update_worker_count): Calculate and update required number of workers.
56
57 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
58
59         run-webkit-tests fails to delete Simulator device during cleanup
60         https://bugs.webkit.org/show_bug.cgi?id=152363
61
62         Reviewed by Alexey Proskuryakov.
63
64         * Scripts/webkitpy/xcode/simulator.py:
65         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
66
67 2015-12-16  Tim Horton  <timothy_horton@apple.com>
68
69         [mac-wk2] fast/events force click tests crashing
70         https://bugs.webkit.org/show_bug.cgi?id=152339
71
72         Reviewed by Beth Dakin.
73
74         * WebKitTestRunner/mac/EventSenderProxy.mm:
75         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
76         Set the NSEvent's _type member in addition to overriding -type,
77         because there are assertions in touch event handling code that depend on it.
78
79 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
80
81         Enforce temporarily bots to sync WebKit and WPT testharness.js
82         https://bugs.webkit.org/show_bug.cgi?id=152334
83
84         Reviewed by Darin Adler.
85
86         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
87         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
88
89 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
90
91         [Fetch API] Add fetch API compile time flag
92         https://bugs.webkit.org/show_bug.cgi?id=152254
93
94         Reviewed by Darin Adler.
95
96         * Scripts/webkitperl/FeatureList.pm:
97
98 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
99
100         Unreviewed.
101
102         Added files that have impact in building Streams API to the watchlist.
103
104         * Scripts/webkitpy/common/config/watchlist:
105
106 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
107
108         Unreviewed.
109
110         Added imported tests to Streams API watchlist.
111
112         * Scripts/webkitpy/common/config/watchlist:
113
114 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
115
116         Remove default copy of wpt testharness.js when launching wpt server
117         https://bugs.webkit.org/show_bug.cgi?id=152298
118
119         Reviewed by Darin Adler.
120
121         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
122         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
123
124 2015-12-15  David Kilzer  <ddkilzer@apple.com>
125
126         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
127         <http://webkit.org/b/152314>
128
129         Reviewed by Daniel Bates.
130
131         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
132         code path to exit immediately when calling main().
133         Unfortunately, DumpRenderTreeMain.mm was used for both
134         DumpRenderTree command-line binary and DumpRenderTree.app, which
135         meant that the app would exit immediately with no error code
136         when run!
137
138         The workaround is to introduce a separate source file called
139         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
140         already does.
141
142         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
143         DumpRenderTreeAppMain.mm to the project.  Make it the only
144         compiled source for the DumpRenderTree.app target.
145         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
146         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
147         case someone tries mistakenly to use the app.
148         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
149         Link to JavaScriptCore.framework on iOS for the assert.
150         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
151         Link to JavaScriptCore.framework on OS X for the assert.  Remove
152         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
153         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
154         (main): Add assert for iOS so that a crash occurs if someone
155         tries to run the wrong command.
156
157 2015-12-14  Tim Horton  <timothy_horton@apple.com>
158
159         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
160         https://bugs.webkit.org/show_bug.cgi?id=152266
161         <rdar://problem/22092676>
162
163         Reviewed by Simon Fraser.
164
165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
166         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
167         Add a test that crashed before this change, and doesn't crash after.
168
169 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
170
171         AX: iOS: Text field variations do not have the correct traits
172         https://bugs.webkit.org/show_bug.cgi?id=152237
173
174         Reviewed by Mario Sanchez Prada.
175
176         Add iOS calls for determing if an object is a search field or a text area.
177
178         * DumpRenderTree/AccessibilityUIElement.cpp:
179         (getIsSearchFieldCallback):
180         (getIsTextAreaCallback):
181         (stringForSelectionCallback):
182         (AccessibilityUIElement::getJSClass):
183         * DumpRenderTree/AccessibilityUIElement.h:
184         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
185         (AccessibilityUIElement::identifier):
186         (AccessibilityUIElement::isTextArea):
187         (AccessibilityUIElement::isSearchField):
188         (AccessibilityUIElement::traits):
189         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
190         (WTR::AccessibilityUIElement::scrollPageRight):
191         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
192         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
193         (WTR::AccessibilityUIElement::isSearchField):
194         (WTR::AccessibilityUIElement::isTextArea):
195         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
196         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
197         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
198         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
199         (WTR::AccessibilityUIElement::isTextArea):
200         (WTR::AccessibilityUIElement::isSearchField):
201         (WTR::AccessibilityUIElement::rowCount):
202
203 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
204
205         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
206         https://bugs.webkit.org/show_bug.cgi?id=152252
207
208         Reviewed by Sergio Villar Senin.
209
210         * gtk/install-dependencies: Add libtool-bin to the list of packages required
211         for building the JHBuild on Debian systems.
212
213 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
214
215         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
216         https://bugs.webkit.org/show_bug.cgi?id=152156
217
218         Reviewed by Dan Bernstein.
219
220         Our frameworks should appropriately prefix all ObjC classes,
221         not just external symbols.
222
223         * Scripts/check-for-inappropriate-objc-class-names:
224         Remove the -g switch to check all ObjC class names.
225
226 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
227
228         [MediaStream] Expose media capture devices persistent permissions to WebCore
229         https://bugs.webkit.org/show_bug.cgi?id=152087
230
231         Add support for the new user media permission checker page UI client method.
232
233         Reviewed by Chris Dumez.
234
235         * WebKitTestRunner/TestController.cpp:
236         (WTR::decidePolicyForUserMediaPermissionRequest):
237         (WTR::checkUserMediaPermissionForOrigin):
238         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
239         (WTR::TestController::createWebViewWithOptions): Ditto.
240         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
241         (WTR::originUserVisibleName): New, create a string for the origin.
242         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
243           according to the state of the origin permission map.
244         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
245           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
246         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
247           origin permission map.
248         * WebKitTestRunner/TestController.h:
249
250 2015-12-10  Alex Christensen  <achristensen@webkit.org>
251
252         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
253         https://bugs.webkit.org/show_bug.cgi?id=152022
254         rdar://problem/23763584
255
256         Reviewed by Darin Adler.
257
258         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
259         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
260         (WTR::InjectedBundlePage::willSendRequestForFrame):
261         * WebKitTestRunner/InjectedBundle/TestRunner.h:
262         (WTR::TestRunner::setWillSendRequestReturnsNull):
263         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
264         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
265         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
266         (WTR::TestRunner::willSendRequestHTTPBody):
267         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
268
269 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
270
271         Remove additional simulator checks before running layout-tests
272         https://bugs.webkit.org/show_bug.cgi?id=152146
273
274         Reviewed by Darin Adler.
275
276         * Scripts/webkitpy/port/ios.py:
277         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
278         * Scripts/webkitpy/xcode/simulator.py:
279         (Simulator._boot_and_shutdown_simulator_device): Deleted.
280         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
281
282 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
283
284         Run atleast one simulator even if max process limit is low
285         https://bugs.webkit.org/show_bug.cgi?id=152081
286         <rdar://problem/23819694>
287
288         Reviewed by Alexey Proskuryakov.
289
290 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
291
292         [GTK] Crash in WebProcess when loading large content with custom URI schemes
293         https://bugs.webkit.org/show_bug.cgi?id=144262
294
295         Reviewed by Carlos Garcia Campos.
296
297         Added new unit test to check the additional scenarios we now
298         handle for custom URI schemes.
299
300         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
301         (generateHTMLContent): New helper function to generate big enough content.
302         (testWebContextURIScheme): New unit test.
303
304 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
305
306         [EFL] Fix unhandled web process message when launching MiniBrowser
307         https://bugs.webkit.org/show_bug.cgi?id=152048
308
309         Reviewed by Gyuyoung Kim.
310
311         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
312         (TestWebKitAPI::TEST):
313
314 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
315
316         [GTK] Add API to handle beforeunload events
317         https://bugs.webkit.org/show_bug.cgi?id=139090
318
319         Reviewed by Gustavo Noronha Silva.
320
321         * MiniBrowser/gtk/BrowserWindow.c:
322         (browserWindowConstructed):
323         (browserWindowDeleteEvent):
324         (browser_window_class_init):
325         Handle delete-event to prevent the window from being closed when
326         the page has beforeunload handlers. Use
327         webkit_web_view_try_close() when the window is requested to be
328         closed.
329         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
330         (testWebViewJavaScriptDialogs):
331         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
332         script dialog type.
333
334 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
335
336         Refactored initialization code in LoadTrackingTest.
337
338         Rubber-stamped by Carlos Garcia Campos.
339
340         Small refactoring to make sure that the state of a LoadTrackingTest
341         gets properly reset before loading new web content.
342
343         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
344         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
345         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
346         functions and reset the remaining local variables.
347         (LoadTrackingTest::loadURI): Call reset();
348         (LoadTrackingTest::loadHtml): Ditto.
349         (LoadTrackingTest::loadPlainText): Ditto.
350         (LoadTrackingTest::loadBytes): Ditto.
351         (LoadTrackingTest::loadRequest): Ditto.
352         (LoadTrackingTest::reload): Ditto.
353         (LoadTrackingTest::goBack): Ditto.
354         (LoadTrackingTest::goForward): Ditto.
355
356 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
357
358         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
359         https://bugs.webkit.org/show_bug.cgi?id=151942
360
361         Reviewed by Darin Adler.
362
363         * MiniBrowser/efl/main.c:
364         (window_create): Enable offline web application cache feature on MiniBrowser.
365         (elm_main):
366
367 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
368
369         https://bugs.webkit.org/show_bug.cgi?id=151243
370         <rdar://problem/22955197>
371
372         Reviewed by Alexey Proskuryakov.
373
374         * LayoutTestRelay/LayoutTestRelay/main.m:
375         (getTestingSimDevice): Use separate testing device for each worker.
376         * Scripts/webkitpy/layout_tests/controllers/manager.py:
377         (Manager.run): Perform cleanup even if setup fails.
378         * Scripts/webkitpy/port/ios.py:
379         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
380         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
381         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
382         (IOSSimulatorPort._quit_ios_simulator): Same
383         (IOSSimulatorPort.clean_up_test_run): Same
384         (IOSSimulatorPort.check_sys_deps): Same
385         (IOSSimulatorPort.testing_device): Same
386         (IOSSimulatorPort.reset_preferences): Same
387         (IOSSimulatorPort.get_simulator_path): Return simulator path.
388         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
389         * Scripts/webkitpy/xcode/simulator.py:
390         (Device.delete): Delete the simulator device.
391         (Simulator.delete_device): Same
392         (Simulator.wait_until_device_is_booted): Wait for device booting.
393
394 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
395
396         [EFL] Add API to provide preferences before creating ewk_view
397         https://bugs.webkit.org/show_bug.cgi?id=151587
398
399         Reviewed by Gyuyoung Kim.
400
401         * MiniBrowser/efl/main.c:
402         (on_key_down):
403         (quit):
404         (window_create):
405         Moved settings related code to configuration() not to update settings
406         whenever ewk_view is created.
407         (configuration):
408         (elm_main):
409
410 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
411
412         Unreviewed. Fix GTK+ API tests after r193639.
413
414         The new jhbuild version needs some more variables ot be present in
415         the builtin dict, even if they are set to None.
416
417         * jhbuild/jhbuildutils.py:
418         (enter_jhbuild_environment_if_available):
419
420 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
421
422         [GTK] Notify WebCore when notification is clicked
423         https://bugs.webkit.org/show_bug.cgi?id=151951
424
425         Reviewed by Carlos Garcia Campos.
426
427         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
428         (testWebViewNotification): test the new API.
429
430 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
431
432         'jhbuild build' should fail immediately when building any module fails
433         https://bugs.webkit.org/show_bug.cgi?id=145697
434
435         Reviewed by Carlos Garcia Campos.
436
437         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
438         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
439         Everything is placed under lib instead of lib64 now.
440         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
441         --exit-on-error when running 'jhbuild build'.
442         * jhbuild/jhbuildrc_common.py:
443         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
444         jhbuild should be able to handle these for us without breaking things....
445
446 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
447
448         Add support to import w3c tests from a repository with a different root that the main repo dir
449         https://bugs.webkit.org/show_bug.cgi?id=151751
450
451         Reviewed by Ryosuke Niwa and Youenn Fablet.
452
453         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
454         in a different directory than the repository root.
455
456         This patch introduces a new parameter tests_directory that we will use as root directory to search for
457         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
458         requires having the copy_path lists including tuples of origin and destination directories.
459
460         * Scripts/webkitpy/w3c/test_downloader.py:
461         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
462         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
463         * Scripts/webkitpy/w3c/test_importer_unittest.py:
464         (TestImporterTest.test_tests_directory): Test.
465
466 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
467
468         Mock TestRepositories in W3C importer tests
469         https://bugs.webkit.org/show_bug.cgi?id=151938
470
471         Reviewed by Youenn Fablet.
472
473         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
474         is because the test repository method reading the file was using the filesystem directly instead of taking the
475         host one. This patch changes that.
476
477         * Scripts/webkitpy/w3c/test_downloader.py:
478         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
479         default one.
480         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
481         * Scripts/webkitpy/w3c/test_importer_unittest.py:
482         (TestImporterTest.test_harnesslinks_conversion):
483         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
484
485 2015-12-07  David Kilzer  <ddkilzer@apple.com>
486
487         TestNetscapePlugIn: Address review comment on 193607
488         <http://webkit.org/b/151881>
489
490         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
491         (testSetStatus): Initializing std::unique_ptr<char[]> with
492         nullptr is redundant.
493
494 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
495
496         [GTK] Add webkit_uri_request_get_http_method
497         https://bugs.webkit.org/show_bug.cgi?id=151601
498
499         Reviewed by Martin Robinson.
500
501         Add test case to check HTTP method of WebKitURIRequest.
502
503         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
504         (testURIRequestHTTPMethod):
505         (serverCallback):
506         (beforeAll):
507         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
508         (sendRequestCallback):
509
510 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
511
512         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
513         https://bugs.webkit.org/show_bug.cgi?id=79918
514
515         Reviewed by Gustavo Noronha Silva.
516
517         Add unit tests to check the different console messages.
518
519         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
520         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
521         (ConsoleMessageTest::ConsoleMessage::operator==):
522         (ConsoleMessageTest::consoleMessageReceivedCallback):
523         (ConsoleMessageTest::ConsoleMessageTest):
524         (ConsoleMessageTest::~ConsoleMessageTest):
525         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
526         (testWebKitConsoleMessageConsoleAPI):
527         (testWebKitConsoleMessageJavaScriptException):
528         (testWebKitConsoleMessageNetworkError):
529         (testWebKitConsoleMessageSecurityError):
530         (beforeAll):
531         (afterAll):
532         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
533         (consoleMessageSentCallback):
534         (pageCreatedCallback):
535
536 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
537
538         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
539         https://bugs.webkit.org/show_bug.cgi?id=151934
540
541         Reviewed by Csaba Osztrogonác.
542
543         * MiniBrowser/efl/main.c:
544         (on_window_deletion): Revert the changes of r192767.
545
546 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
547
548         [GTK] update-webkitgtk-libs cannot build mesa
549         https://bugs.webkit.org/show_bug.cgi?id=151535
550
551         Reviewed by Martin Robinson.
552
553         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
554         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
555         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
556         does not have a stable API and we cannot expect mesa to be buildable unless we control the
557         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
558         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
559
560         * gtk/jhbuild.modules:
561
562 2015-12-07  Philippe Normand  <pnormand@igalia.com>
563
564         [GTK][Mac] libWebExtensionTest link error
565         https://bugs.webkit.org/show_bug.cgi?id=150802
566
567         Reviewed by Carlos Garcia Campos.
568
569         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
570
571 2015-12-06  David Kilzer  <ddkilzer@apple.com>
572
573         TestNetscapePlugIn: Fix leaks found by static analyzer
574         <http://webkit.org/b/151881>
575
576         Reviewed by Darin Adler.
577
578         Fixes the following leaks found by the static analyzer:
579             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
580                     return false;
581                            ^~~~~
582             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
583                     return false;
584                            ^~~~~
585             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
586                     return false;
587                            ^~~~~
588
589         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
590         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
591         early return if allocation fails.
592         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
593         Make sure to call fclose() on filehandle, even for an early
594         return.
595         (testSetStatus): Switch to using std::unique_ptr<char[]>.
596
597 2015-12-05  David Kilzer  <ddkilzer@apple.com>
598
599         prepare-ChangeLog: Fix some warning messages when using svn
600         <http://webkit.org/b/151914>
601
602         Reviewed by Daniel Bates.
603
604         * Scripts/prepare-ChangeLog:
605         (generateFunctionLists): Simplify logic so that we never call
606         normalizePath() with an undefined value.
607         (attributeCommand): Quote $subPath for the shell so that we
608         don't try to run "svn propget" on invalid paths.
609
610 2015-12-04  David Kilzer  <ddkilzer@apple.com>
611
612         TestNetscapePlugIn: Fix remaining static analyzer warnings
613         <http://webkit.org/b/151888>
614
615         Reviewed by Alexey Proskuryakov.
616
617         Fixes the following static analyzer warnings:
618             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
619                     CRASH();
620                     ^~~~~~~
621             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
622                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
623                 ^~~~~~~~~~~~~~~~
624             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
625                 return obj->pluginTest->NPP_SetWindow(window);
626                        ^~~~~~~~~~~~~~~
627             2 warnings generated.
628
629         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
630         (CRASH): Use __builtin_trap() for gcc/clang.
631         (NPP_SetWindow): Add early return if obj is nullptr.
632
633 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
634
635         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
636         https://bugs.webkit.org/show_bug.cgi?id=151797
637
638         Reviewed by Martin Robinson.
639
640         Since we switched to use the network process to run the unit tests
641         the test /webkit2/WebKitWebResource/get-data sometimes fails and
642         sometimes passes. We are now also getting the notification for the
643         css image. Since we wait for 3 resources, sometimes the css image
644         is loaded before and then checkResourceData is called for it, but
645         not handled. When the css image is the last one loaded the test
646         passes. So, we just need to wait for the 4 resources.
647
648         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
649         (testWebResourceGetData):
650
651 2015-12-03  David Kilzer  <ddkilzer@apple.com>
652
653         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
654         <http://webkit.org/b/151845>
655
656         Reviewed by Simon Fraser.
657
658         Fixes the following static analyzer warning:
659             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
660                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
661                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
662
663         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
664         (createBitmapContext): Free 'buffer' after using it in logging
665         to fix the use-after-free.  Assign a value of nullptr to buffer
666         so we don't return with it set to a freed address.
667
668 2015-12-03  Jer Noble  <jer.noble@apple.com>
669
670         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
671         https://bugs.webkit.org/show_bug.cgi?id=151830
672
673         Reviewed by Anders Carlsson.
674
675         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
676
677         * DumpRenderTree/mac/DumpRenderTree.mm:
678         (resetWebPreferencesToConsistentValues):
679         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
680         (WTR::initializeWebViewConfiguration):
681
682 2015-12-03  Anders Carlsson  <andersca@apple.com>
683
684         Remove Objective-C GC support
685         https://bugs.webkit.org/show_bug.cgi?id=151819
686         rdar://problem/23746991
687
688         Reviewed by Dan Bernstein.
689
690         * asan/asan.xcconfig:
691
692 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
693
694         Allow nil for unspecified benchmark pathes
695         https://bugs.webkit.org/show_bug.cgi?id=151784
696
697         Reviewed by Filip Pizlo.
698
699         `Pathname.new(nil)` will raise an error.
700         Only generate Pathname if the benchmark path is specified.
701
702         * Scripts/run-jsc-benchmarks:
703
704 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
705
706         [Win] Run non-http tests without Cygwin
707         https://bugs.webkit.org/show_bug.cgi?id=151721
708
709         Reviewed by Andy Estes.
710
711         Support native 32-bit and 64-bit Python (and Perl) builds
712         for running tests:
713
714         1. Use "startswith('win')", rather than "== 'win32'" to support
715         various Windows build types.
716         2. Supply full path for some native Windows utilities, since the
717         path environment does not always have the specified, and they are
718         guaranteed to exist in those specific locations.
719         3. Make sure native Windows Python test runs pass proper environment
720         variables to run programs.
721         4. Append 'exe' suffix when running Windows executables.
722         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
723         command doesn't exist.
724         
725         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
726         the current Perl executable, rather than requiring a new path search.
727         * Scripts/webkitpy/common/find_files_unittest.py:
728         (TestWinNormalize.test_win): Use startswith('win').
729         * Scripts/webkitpy/common/prettypatch_unittest.py:
730         (test_pretty_diff_encodings): Ditto.
731         * Scripts/webkitpy/common/system/executive.py:
732         (Executive._should_close_fds): Ditto.
733         (Executive.shell_command_for_script): Use startswith('win').
734         (Executive.kill_process): Use full path to killall executable.
735         (Executive.check_running_pid): Use startswith('win').
736         (Executive.running_pids): Ditto.
737         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
738         running under native Windows Python.
739         (Executive._child_process_encoding): Use startswith('win').
740         (Executive._should_encode_child_process_arguments): Ditto.
741         (Executive.popen): Recognize proper script engine on Windows, since it
742         does not support the shebang syntax.
743         (Executive.run_in_parallel): Use startswith('win').
744         * Scripts/webkitpy/common/system/executive_unittest.py:
745         (never_ending_command): Ditto.
746         (ExecutiveTest.test_run_command_with_unicode): Ditto.
747         (ExecutiveTest.serial_test_kill_process): Ditto.
748         (ExecutiveTest.serial_test_kill_all): Ditto.
749         (ExecutiveTest.serial_test_check_running_pid): Ditto.
750         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
751         (main): Ditto.
752         * Scripts/webkitpy/common/system/file_lock.py:
753         (FileLock._create_lock): Ditto.
754         (FileLock._remove_lock): Ditto.
755         * Scripts/webkitpy/common/system/filesystem_unittest.py:
756         (RealFileSystemTest.test_chdir): Ditto.
757         (RealFileSystemTest.test_chdir__notexists): Ditto.
758         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
759         * Scripts/webkitpy/common/system/path_unittest.py:
760         (AbspathTest.test_abspath_to_uri_win): Ditto.
761         * Scripts/webkitpy/common/system/platforminfo.py:
762         (PlatformInfo._determine_os_name): Ditto.
763         * Scripts/webkitpy/common/system/user.py: Ditto.
764         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
765         (ManagerTest.integration_test_needs_servers): Ditto.
766         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
767         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
768         driver letters.
769         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
770         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
771         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
772         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
773         (HttpServerBase._check_that_all_ports_are_available): Ditto.
774         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
775         (TestHttpServer.test_start_cmd): Ditto.
776         * Scripts/webkitpy/port/base.py:
777         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
778         and 'SYSTEMROOT' in environment passed to test runners.
779         (Port._apache_config_file_name_for_platform): Use startswith('win').
780         (Port._build_path): Ditto.
781         (Port._path_to_driver): Include 'exe' suffix when running under native
782         Windows.
783         * Scripts/webkitpy/port/driver.py:
784         (Driver._setup_environ_for_driver): Explicitly make some environment
785         variables strings.
786         * Scripts/webkitpy/port/server_process.py:
787         (ServerProcess.__init__): Use startswith('win').
788         * Scripts/webkitpy/port/win.py:
789         (WinPort): Use the win32 registry utilities on Windows, and appropriate
790         registry key formats.
791         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
792         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
793         and regtool on Cygwin.
794         (WinPort.write_registry_value): Ditto.
795         (WinPort.setup_crash_log_saving): Ditto.
796         (WinPort.restore_crash_log_saving): Ditto.
797         (WinPort.prevent_error_dialogs): Ditto.
798         (WinPort.allow_error_dialogs): Ditto.
799         (WinPort.find_system_pid): Revise to use Windows management
800         infrastructure on native Windows, continue using 'ps' on Cygwin.
801         (WinPort.read_registry_string): Deleted.
802         (WinPort.write_registry_string): Deleted.
803         * Scripts/webkitpy/test/main.py:
804         (main): Use startswith('win').
805         (Tester._parse_args): Ditto.
806
807 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
808
809         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
810         https://bugs.webkit.org/show_bug.cgi?id=150792
811
812         Reviewed by Saam Barati.
813
814         * Scripts/webkitperl/FeatureList.pm:
815
816 2015-12-01  Commit Queue  <commit-queue@webkit.org>
817
818         Unreviewed, rolling out r192914.
819         https://bugs.webkit.org/show_bug.cgi?id=151734
820
821         JSC tests for this change are failing on 32 and 64-bit bots
822         (Requested by ryanhaddad on #webkit).
823
824         Reverted changeset:
825
826         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
827         enable this feature"
828         https://bugs.webkit.org/show_bug.cgi?id=150792
829         http://trac.webkit.org/changeset/192914
830
831 2015-12-01  David Kilzer  <ddkilzer@apple.com>
832
833         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
834         <http://webkit.org/b/151726>
835
836         Reviewed by Simon Fraser.
837
838         * WebKitTestRunner/mac/EventSenderProxy.mm:
839         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
840         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
841
842 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
843
844         Give String and AtomicString an existingHash() function
845         https://bugs.webkit.org/show_bug.cgi?id=151717
846
847         Reviewed by Andreas Kling.
848
849         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
850         (TestWebKitAPI::TEST):
851         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
852         (TestWebKitAPI::TEST):
853
854 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
855
856         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
857         https://bugs.webkit.org/show_bug.cgi?id=150792
858
859         Reviewed by Saam Barati.
860
861         * Scripts/webkitperl/FeatureList.pm:
862
863 2015-12-01  Sam Weinig  <sam@webkit.org>
864
865         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
866         <rdar://problem/23320863>
867         https://bugs.webkit.org/show_bug.cgi?id=151708
868
869         Reviewed by Anders Carlsson.
870
871         * WebKitTestRunner/TestController.cpp:
872         (WTR::TestController::createOtherPage):
873         (WTR::TestController::createWebViewWithOptions):
874         Update for new WKPageUIClient.
875
876 2015-12-01  Anders Carlsson  <andersca@apple.com>
877
878         Remove WebKit2.framework
879         https://bugs.webkit.org/show_bug.cgi?id=151715
880
881         Reviewed by Dan Bernstein.
882
883         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
884         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
885         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
886         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
887         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
888         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
889         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
890
891 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
892
893         Unreviewed common typo fix "occurance" => "occurrence".
894
895         * Scripts/webkitpy/tool/commands/queries.py:
896         (FindFlakyTests._print_statistics):
897
898 2015-11-30  Alex Christensen  <achristensen@webkit.org>
899
900         Make ProcessModel always MultipleSecondaryProcesses
901         https://bugs.webkit.org/show_bug.cgi?id=151662
902
903         Reviewed by Antti Koivisto.
904
905         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
906         (TestWebKitAPI::TEST):
907         * WebKitTestRunner/TestController.cpp:
908         (WTR::TestController::generatePageConfiguration):
909
910 2015-11-30  Alex Christensen  <achristensen@webkit.org>
911
912         Make usesNetworkProcess always true
913         https://bugs.webkit.org/show_bug.cgi?id=151580
914
915         Reviewed by Darin Adler.
916
917         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
918         (TestWebKitAPI::TEST):
919         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
920         (TestWebKitAPI::TEST):
921         * WebKitTestRunner/TestController.cpp:
922         (WTR::TestController::generatePageConfiguration):
923
924 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
925
926         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
927
928         Add a way to skip unit tests only for Debug or Release builds and
929         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
930
931         * Scripts/run-gtk-tests:
932         (SkippedTest):
933         (SkippedTest.__init__):
934         (SkippedTest.__str__):
935         (SkippedTest.skip_entire_suite):
936         (SkippedTest.skip_for_build_type):
937         (TestRunner):
938         (TestRunner.__init__):
939
940 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
941
942         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
943
944         It's an assert hit because we are reloading a view loaded with
945         HTML data which is not supported. Use loadURI instead.
946
947         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
948         (testWebViewCustomCharset):
949
950 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
951
952         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
953         https://bugs.webkit.org/show_bug.cgi?id=151633
954
955         Reviewed by Csaba Osztrogonác.
956
957         * TestWebKitAPI/PlatformGTK.cmake:
958         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
959
960 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
961
962         [GTK] Remove the remaining uses of GMainLoopSource
963         https://bugs.webkit.org/show_bug.cgi?id=151632
964
965         Reviewed by Žan Doberšek.
966
967         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
968         (testWebViewSyncRequestOnMaxConns):
969         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
970         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
971         (WTR::TestRunner::TestRunner):
972         * WebKitTestRunner/InjectedBundle/TestRunner.h:
973         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
974         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
975         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
976         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
977         (WTR::timeoutSource):
978         (WTR::TestController::notifyDone):
979         (WTR::TestController::platformRunUntil):
980
981 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
982
983         [cmake] Add testb3 to the build system
984         https://bugs.webkit.org/show_bug.cgi?id=151619
985
986         Reviewed by Gyuyoung Kim.
987
988         * Scripts/build-jsc:
989
990 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
991
992         [jhbuild] Fix pixman build with clang
993         https://bugs.webkit.org/show_bug.cgi?id=151441
994
995         Reviewed by Carlos Garcia Campos.
996
997         * efl/jhbuild.modules:
998         * gtk/jhbuild.modules:
999
1000 2015-11-26  David Kilzer  <ddkilzer@apple.com>
1001
1002         Extract prependToEnvironmentVariableList
1003         <http://webkit.org/b/151536>
1004
1005         Reviewed by Daniel Bates.
1006
1007         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1008                webkitdirs_unittest/prependToEnvironmentVariableList.pl
1009
1010         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
1011         and prependToEnvironmentVariableList.
1012         (appendToEnvironmentVariableList): Simplify variable name.
1013         Switch to use $Config{path_sep}.
1014         (prependToEnvironmentVariableList): Add new method.
1015         (setupMacWebKitEnvironment): Switch to use
1016         prependToEnvironmentVariableList().
1017         (setupIOSWebKitEnvironment): Ditto.
1018
1019         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
1020         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
1021
1022 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1023
1024         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1025         https://bugs.webkit.org/show_bug.cgi?id=151567
1026
1027         Reviewed by Darin Adler.
1028
1029         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1030         (on_window_deletion):
1031
1032 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1033
1034         [GTK] Use the network process unconditionally
1035         https://bugs.webkit.org/show_bug.cgi?id=151541
1036
1037         Reviewed by Alex Christensen.
1038
1039         Fix TestInspectorServer test. Do not assume we already have the
1040         title we want when the page has been loaded, since the title is
1041         changed afterwards. So, check if the title has already been set,
1042         and if not wait for it.
1043
1044         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1045         (openRemoteDebuggingSession):
1046
1047 2015-11-23  Alex Christensen  <achristensen@webkit.org>
1048
1049         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
1050         https://bugs.webkit.org/show_bug.cgi?id=151532
1051
1052         Reviewed by Benjamin Poulain.
1053
1054         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1055         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1056         (TestWebKitAPI::TEST):
1057         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1058         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
1059         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
1060         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
1061         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
1062         so it was calling a function on a test object that had gone out of scope.
1063         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
1064         but that will become the default soon and that call will be removed.
1065
1066 2015-11-22  David Kilzer  <ddkilzer@apple.com>
1067
1068         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
1069         <http://webkit.org/b/151542>
1070
1071         Reviewed by Daniel Bates.
1072
1073         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1074         (base_url): Use the Port object (already passed in) to give us
1075         the path to the LayoutTests directory, which already checks for a
1076         --layout-tests-directory command-line switch.
1077         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
1078         argument since we can get this from the Port object already
1079         passed in via Port.results_directory().  Also switch to use
1080         Port.layout_tests_dir() to get the LayoutTests directory.
1081
1082         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1083         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
1084         Add test case for custom LayoutTests directory.
1085         (TestWebPlatformTestServer.test_previously_spawned_instance):
1086         Update Port object to set mock results directory as if it was
1087         set on the command-line.  Remove unneeded argument from
1088         WebPlatformTestServer constructor.
1089         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
1090
1091         * Scripts/webkitpy/port/base.py:
1092         (Port.to.start_web_platform_test_server): Remove unneeded
1093         argument from WebPlatformTestServer constuctor.
1094
1095 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1096
1097         [GTK] Some unit tests fail when using the network process
1098         https://bugs.webkit.org/show_bug.cgi?id=151490
1099
1100         Reviewed by Martin Robinson.
1101
1102         Run the soup server in a separate thread in TestResources test to
1103         avoid deadlocks.
1104
1105         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
1106         /webkit2/WebKitWebResource/get-data when using the network process.
1107
1108         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1109         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
1110         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1111         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
1112         present, create a WorkQueue to run the server.
1113         (WebKitTestServer::run): Run the server in the work queue if it
1114         has been created.
1115         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1116         type into server options as flags.
1117
1118 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1119
1120         [GTK] ImageDiff should normalize the diff image
1121         https://bugs.webkit.org/show_bug.cgi?id=151261
1122
1123         Reviewed by Sergio Villar Senin.
1124
1125         * ImageDiff/gtk/ImageDiff.cpp:
1126         (readPixbufFromStdin): Fix memory leak.
1127         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
1128         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
1129
1130 == Rolled over to ChangeLog-2015-11-21 ==