Fix builds on 10.8; -firstObject isn't declared on NSArray there.
[WebKit-https.git] / Tools / ChangeLog
1 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
2
3         Fix builds on 10.8; -firstObject isn't declared on NSArray there.
4
5         * DumpRenderTree/mac/DumpRenderTree.mm:
6         (createWebViewAndOffscreenWindow):
7         * DumpRenderTree/mac/EventSendingController.mm:
8         (-[EventSendingController mouseScrollByX:andY:continuously:]):
9         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
10         * WebKitTestRunner/mac/EventSenderProxy.mm:
11         (WTR::EventSenderProxy::mouseScrollBy):
12         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
13
14 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
15
16         Latched scrolling tests are flakey on Mavericks
17         https://bugs.webkit.org/show_bug.cgi?id=133578
18         <rdar://problem/17180591>
19
20         Reviewed by Brent Fulgham.
21         
22         The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
23         be wrong on machines with more than one screen. This is because we use
24         [NSScreen mainScreen] when computing the global coordinates of the events, but
25         [NSScreen mainScreen] returns the screen with the key window, not the first screen.
26         
27         So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
28         add comments clarifying why the coordinate math works (which is not obvious given
29         the events have no target window).
30         
31         Some scrolling tests also dispatched events outside the 800x600 test window, so
32         fix those tests, and add logging that will appear in test output when this happens.
33
34         * DumpRenderTree/mac/DumpRenderTree.mm:
35         (createWebViewAndOffscreenWindow):
36         * DumpRenderTree/mac/EventSendingController.mm:
37         (-[EventSendingController mouseScrollByX:andY:continuously:]):
38         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
39         * WebKitTestRunner/mac/EventSenderProxy.mm:
40         (WTR::EventSenderProxy::mouseMoveTo):
41         (WTR::EventSenderProxy::mouseScrollBy):
42         (WTR::EventSenderProxy::continuousMouseScrollBy):
43         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
44
45 2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
46
47         [GTK] run-perf-tests should run the tests inside the jhbuild shell.
48         https://bugs.webkit.org/show_bug.cgi?id=133533
49
50         Reviewed by Carlos Garcia Campos.
51
52         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
53         (run): Remove the jhbuild-wrapper wrapper from here. It should be
54         on Scripts/webkitpy/port/gtk.py.
55         * Scripts/webkitpy/port/base.py:
56         (Port.set_option): Add a set_option(name, value) function to set
57         the optparse parameter "name" to the value "value", even if the
58         parameter "name" is already initialized.
59         * Scripts/webkitpy/port/gtk.py:
60         (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
61         If another wrapper is specified via the option "-l --wrapper=x",
62         then prepend the jhbuild-wrapper to the one specified.
63
64 2014-06-04  David Farler  <dfarler@apple.com>
65
66         Build ASan WebKit for iOS Simulator
67         https://bugs.webkit.org/show_bug.cgi?id=133489
68
69         Reviewed by Darin Adler.
70
71         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
72         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
73         - Add missing ASan LDFLAGS.
74         * asan/asan.xcconfig:
75         - Split compiler-rt linker flags for OS X and iOS Simulator
76
77 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
78
79         Add myself (yoav@yoav.ws) to contributors.json
80         https://bugs.webkit.org/show_bug.cgi?id=133492
81
82         * Scripts/webkitpy/common/config/contributors.json:
83
84 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
85
86         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
87         https://bugs.webkit.org/show_bug.cgi?id=133149
88
89         Reviewed by Csaba Osztrogonác.
90
91         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
92
93 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
94
95         Add a verbose flag to binding tests
96         https://bugs.webkit.org/show_bug.cgi?id=122303
97
98         Reviewed by Csaba Osztrogonác.
99
100         This patch will:
101         - Add a verbose keyword argument to the BindingsTests constructor,
102         - Add --no-verbose option to the run-bindigs-test.
103         Verbose mode, which is on by default, prints positive results to stdout as before.
104         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
105
106         Original patch from Matthew Hanson <matthew_hanson@apple.com>
107
108         * Scripts/run-bindings-tests:
109         (main):
110         * Scripts/webkitpy/bindings/main.py:
111         (BindingsTests.__init__):
112         (BindingsTests.detect_changes):
113
114 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
115
116         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
117         https://bugs.webkit.org/show_bug.cgi?id=133455
118
119         Reviewed by Timothy Hatcher.
120
121         Since the perf. dashboard doesn't support following renamed benchmarks,
122         keep reporting Speedometer results as DoYouEvenBench results.
123
124         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
125         (_generate_results_dict):
126
127 2014-05-31  Darin Adler  <darin@apple.com>
128
129         Viewport percentage tests that resize the viewport are flaky
130         https://bugs.webkit.org/show_bug.cgi?id=133351
131
132         Reviewed by Anders Carlsson.
133
134         * DumpRenderTree/mac/DumpRenderTree.mm:
135         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
136         happens to be stored in the UI delegate object. This is part of resetting the
137         window position.
138
139         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
140         a frame rectangle. The size is stored in the size of the web view itself.
141         * DumpRenderTree/mac/UIDelegate.mm:
142         (-[UIDelegate resetWindowOrigin]): Added.
143         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
144         old version would store the frame, but not resize the web view!
145         (-[UIDelegate webViewFrame:]): Get the size from the web view.
146
147         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
148         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
149
150         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
151         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
152         the window.
153
154         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
155         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
156         window gets resized too, not just the web view.
157         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
158
159         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
160         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
161         window gets resized too, not just the web view.
162         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
163
164 2014-05-30  Michael Saboff  <msaboff@apple.com>
165
166         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
167         https://bugs.webkit.org/show_bug.cgi?id=133409
168
169         Reviewed by Filip Pizlo.
170
171         Handle creating a tarball the same way as running remote when processing
172         paths in prepareBundle.
173
174         * Scripts/run-jsc-stress-tests:
175
176 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
177
178         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
179         https://bugs.webkit.org/show_bug.cgi?id=132280
180
181         Reviewed by Chris Fleizach.
182
183         Remove implementation of logAccessibilityEvents() for ATK based
184         ports, as this has proved to be a flaky method of checking that
185         ATK events are being properly emitted. Instead, it's better to use
186         the addNotificationListener() functions and provide a JS callback
187         to check that the right events are being emmitted from the tests.
188
189         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
190         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
191         with dummy implementation.
192         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
193         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
194
195 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
196
197         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
198         https://bugs.webkit.org/show_bug.cgi?id=132280
199
200         Rubber stamped by Carlos Garcia Campos.
201
202         Fix two small issues with previous patch (r169483), that caused some tests to break.
203
204         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
205         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
206         duplicated entry.
207         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
208         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
209
210 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
211
212         [ATK] Added new accessibility signal: text-caret-moved.
213         Make AccessibilityUIElement.setSelectedTextRange work
214         as atk_text_set_caret_offset when given offset == 0.
215         https://bugs.webkit.org/show_bug.cgi?id=132527
216
217         Reviewed by Mario Sanchez Prada.
218
219         text-caret-moved signal in accessibilityController is needed to
220         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
221         as LayoutTests. Add the signal to the controller.
222
223         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
224         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
225         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
226         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
227         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
228         (setSelectedTextRange): Change return type to bool.
229         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
230         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
231         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
232         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
233         for extra arguments passed to handler and use it for text-caret-moved offset.
234         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
235         Connect callback to new listener for ATK:AtkText:text-caret-moved.
236         Refactor so that failures be reported.
237         Initialize atk interfaces before trying to connect to them, see
238         https://bugzilla.gnome.org/show_bug.cgi?id=729922
239         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
240         Simplify code by using a vector in place of dozen variables.
241         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
242         Comment about not synchronizing with accessibilityController.
243
244 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
245
246         [GTK] Add a WebKit2 Performance bot.
247         https://bugs.webkit.org/show_bug.cgi?id=132862
248
249         Reviewed by Csaba Osztrogonác.
250
251         This adds a GTK WebKit2 perf bot.
252
253         * BuildSlaveSupport/build.webkit.org-config/config.json:
254
255 2014-05-29  Dan Bernstein  <mitz@apple.com>
256
257         Fixed the WebKitTestRunner build after r169452.
258
259         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
260         (WTR::InjectedBundle::initialize):
261
262 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
263
264         Unreviewed. Update my email addresses in contributors.json.
265
266         * Scripts/webkitpy/common/config/contributors.json:
267
268 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
269
270         Need an API test for bug #133193 (r169315)
271         <https://bugs.webkit.org/show_bug.cgi?id=133324>
272
273         This adds an API test that ensures that calling "stop loading" during a
274         "did fail provisional load" callback doesn't crash.
275
276         Reviewed by Andy Estes.
277
278         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
279         Add new files to project.
280
281         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
282         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
283         If the message is the "test done" message, record that.
284         (TestWebKitAPI::setInjectedBundleClient):
285         Register a function for the "did receive message from injected bundle"
286         callback.
287         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
288         Assert that we received the message from the injected bundle, and set
289         'done' to finish the test.
290         (TestWebKitAPI::TEST):
291         Create a WebView, register a page loader client for the "did fail
292         provisional load" callback, and load a non-existent resource.
293
294         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
295         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
296         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
297         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
298         provisional load failed.
299         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
300         Register a page loader client for the "did fail provisional load"
301         callback.
302         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
303         Call WKBundlePageStopLoading() during the callback. This not crashing
304         is what we're ensuring with this test.
305
306 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
307
308         [GTK] Make it possible to build with FTL enabled
309         https://bugs.webkit.org/show_bug.cgi?id=133219
310
311         Reviewed by Philippe Normand.
312
313         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
314         same revision than mac.
315
316 2014-05-27  Michael Saboff  <msaboff@apple.com>
317
318         REGRESSION(r169265): sh: line 0: cd: ../.vm
319         https://bugs.webkit.org/show_bug.cgi?id=133242
320
321         Rubber stamped by Oliver Hunt.
322
323         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
324         array since the command may contain character escapes that don't work with the
325         array form of system().
326
327         * Scripts/run-jsc-stress-tests:
328
329 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
330
331         [EFL] Change download url of freetype6
332         https://bugs.webkit.org/show_bug.cgi?id=133303
333
334         Reviewed by Csaba Osztrogonác.
335
336         freetype6 tarball isn't downloaded in Korea. So, we need to
337         change the url for now.
338
339         * efl/jhbuild.modules:
340
341 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
342
343         Remove BLOB guards
344         https://bugs.webkit.org/show_bug.cgi?id=132863
345
346         Reviewed by Csaba Osztrogonác.
347
348         * Scripts/webkitperl/FeatureList.pm:
349
350 2014-05-27  Alberto Garcia  <berto@igalia.com>
351
352         Remove leftover comment from r165182.
353
354         Rubber stamped by Carlos Garcia Campos.
355
356         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
357
358 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
359
360         [EFL] Add LLVM as optional jhbuild module for FTL developers
361         https://bugs.webkit.org/show_bug.cgi?id=133216
362
363         Reviewed by Gyuyoung Kim.
364
365         * efl/jhbuild.modules:
366
367 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
368
369         Fix test failures on python test
370         https://bugs.webkit.org/show_bug.cgi?id=133297
371
372         Reviewed by Dirk Schulze.
373
374         2 tests are failing because of unbounded local variable reference in test_importer.py.
375
376         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
377         (TestImporter.import_tests):
378
379 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
380
381         [GTK] GObject DOM bindings API break test fails in the tests bots
382         https://bugs.webkit.org/show_bug.cgi?id=133211
383
384         Reviewed by Martin Robinson.
385
386         When generating the built product archive on platform GTK, we need
387         to copy also the file gtkdoc-webkitdom.cfg and the directory
388         DerivedSources/webkitdom.
389
390         * BuildSlaveSupport/built-product-archive:
391         (archiveBuiltProduct):
392
393 2014-05-26  Commit Queue  <commit-queue@webkit.org>
394
395         Unreviewed, rolling out r169122.
396         https://bugs.webkit.org/show_bug.cgi?id=133288
397
398         Broke CJK font fallback (Requested by ap on #webkit).
399
400         Reverted changeset:
401
402         "[Mac] WebProcess doesn't follow localization of UI process
403         when run as a service"
404         https://bugs.webkit.org/show_bug.cgi?id=133126
405         http://trac.webkit.org/changeset/169122
406
407 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
408
409         [GTK] WebProcess leaked when closing pages with network process enabled
410         https://bugs.webkit.org/show_bug.cgi?id=129684
411
412         Reviewed by Anders Carlsson.
413
414         Enable the test to check that web processes finish when the web
415         view is destroyed.
416
417         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
418
419 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
420
421         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
422         https://bugs.webkit.org/show_bug.cgi?id=133279
423
424         Reviewed by Philippe Normand.
425
426         generator.saw_warnings is only set by GTKDoc::generate(), so it
427         should only be used after generate.
428
429         * gtk/generate-gtkdoc:
430         (generate_documentation_for_config): Do not check
431         generator.saw_warnings again, simply return the value returned by
432         generate_doc() which is generator.saw_warnings. When rebasing,
433         returns always False since there aren't warnings.
434
435 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
436
437         W3C test importer should catch exceptions coming from HTML/CSS conversion
438         https://bugs.webkit.org/show_bug.cgi?id=133176
439
440         Reviewed by Darin Adler.
441
442         Exceptions raised when converting HTML/CSS are caught.
443         Files for which conversion failed are still copied to the target directory.
444         Each individual conversion failure is logged.
445         Total conversion failure number is logged at the end of the import process.
446
447         * Scripts/webkitpy/w3c/test_importer.py:
448         (TestImporter.import_tests):
449
450 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
451
452         [GTK] Allow to run the tests on the native X display.
453         https://bugs.webkit.org/show_bug.cgi?id=133157
454
455         Reviewed by Benjamin Poulain.
456
457         This adds a new driver (xorgdriver) that runs the tests on the
458         X display referenced by the environment variable DISPLAY.
459
460         This new driver will be activated only if the environment variable
461         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
462         tests and performance tests.
463
464         This patch also makes the script run-perf-tests to check the
465         system dependencies before starting the tests. Previously this
466         was not checked, and if the system dependencies were not met,
467         the script tried to execute the tests anyway, causing massive
468         failures. For example, if you had Xvfb not installed and you
469         wanted to use the Xvfb driver (the default on GTK and EFL),
470         run-perf-tests would not abort.
471
472         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
473         (PerfTestsRunner._parse_args): Check the system dependencies of
474         the driver before starting the tests.
475         * Scripts/webkitpy/port/driver.py:
476         (Driver): Implement generic check_driver method.
477         (Driver.check_driver):
478         (Driver.check_driver.implementation):
479         * Scripts/webkitpy/port/gtk.py:
480         (GtkPort._driver_class): Check for environment variable
481         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
482         * Scripts/webkitpy/port/xorgdriver.py: Added.
483         (XorgDriver): Implement Xorg driver.
484         (XorgDriver.check_driver):
485         (XorgDriver._start):
486
487 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
488
489         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
490         https://bugs.webkit.org/show_bug.cgi?id=133215
491
492         Reviewed by Csaba Osztrogonác.
493
494         This reverts r166798.
495
496         * BuildSlaveSupport/kill-old-processes:
497         (main):
498
499 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
500
501         [EFL] Turn on ENABLE_CSS_FILTERS in build script
502         https://bugs.webkit.org/show_bug.cgi?id=133278
503
504         Reviewed by Gyuyoung Kim.
505
506         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
507
508 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
509
510         run-javascriptcore-tests warning fix on non Mac platforms
511         https://bugs.webkit.org/show_bug.cgi?id=133260
512
513         Reviewed by Darin Adler.
514
515         * Scripts/webkitdirs.pm:
516         (argumentsForConfiguration):
517
518 2014-05-23  Michael Saboff  <msaboff@apple.com>
519
520         REGRESSION(r169265): sh: line 0: cd: ../.vm
521         https://bugs.webkit.org/show_bug.cgi?id=133242
522
523         Rubber stamped by Geoffrey Garen.
524
525         Added missing shell escapes '\' required as part of previous fix.
526
527         * Scripts/run-jsc-stress-tests:
528
529 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
530
531         Revert the erroneous change committed in r169286.
532
533         * Scripts/webkitpy/performance_tests/perftest.py:
534         (PerfTest._run_with_driver):
535
536 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
537
538         run-perf-tests should ignore whitespace lines when snarfing test output
539         https://bugs.webkit.org/show_bug.cgi?id=133238
540
541         Reviewed by Ryosuke Niwa.
542
543         Required for PerformanceTests/Canvas/terrain.html.
544
545         * Scripts/webkitpy/performance_tests/perftest.py:
546         (PerfTest._run_with_driver):
547         (PerfTest):
548
549 2014-05-23  Michael Saboff  <msaboff@apple.com>
550
551         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
552         https://bugs.webkit.org/show_bug.cgi?id=133223
553
554         Reviewed by Geoffrey Garen.
555
556         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
557         string before calling IO.popen() to work with older versions of ruby.
558         Changed the remote path in runShellTestRunner to quote the command
559         string we want to run via ssh so that it will work correctly with array
560         to string conversion needed for popen.
561
562         * Scripts/run-jsc-stress-tests:
563
564 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
565
566         Remove 'css-shaders' option from the build-webkit
567         https://bugs.webkit.org/show_bug.cgi?id=133212
568
569         Reviewed by Daniel Bates.
570
571         Original CSS shaders removed in r162644.
572
573         * Scripts/webkitperl/FeatureList.pm:
574
575 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
576
577         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
578         https://bugs.webkit.org/show_bug.cgi?id=133209
579
580         Reviewed by Sergio Villar Senin.
581
582         Return FAILURE when the command failed to run.
583
584         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
585         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
586
587 2014-05-23  Alberto Garcia  <berto@igalia.com>
588
589         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
590         https://bugs.webkit.org/show_bug.cgi?id=133210
591
592         Reviewed by Carlos Garcia Campos.
593
594         * gtk/install-dependencies:
595
596 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
597
598         Add Yusuke Suzuki to the list of contributors (for real)
599
600         Wrong section...
601
602         * Scripts/webkitpy/common/config/contributors.json:
603
604 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
605
606         Add Yusuke Suzuki to the list of contributors
607
608         * Scripts/webkitpy/common/config/contributors.json:
609
610 2014-05-22  Michael Saboff  <msaboff@apple.com>
611
612         Eliminate n/total progress update from run-jsc-stress-tests output to file
613         https://bugs.webkit.org/show_bug.cgi?id=133191
614
615         Reviewed by Geoffrey Garen.
616
617         Changed progressMeter setting to be based on stdout being a tty instead of
618         stdin.  Unified the processing of output from the shell runner to match the
619         same processing as is used by the makefile runner.  As part of this, the 
620         shell runner script was simplified.  It now forwards the output of each
621         test_script just like the Makefile and doesn't provide its own progress.
622
623         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
624         * Scripts/run-jsc-stress-tests:
625
626 2014-05-22  Michael Saboff  <msaboff@apple.com>
627
628         Add option to run-jsc-stress-tests to use installed jsc
629         https://bugs.webkit.org/show_bug.cgi?id=133102
630
631         Reviewed by Geoffrey Garen.
632
633         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
634         provied with the --jsc option.
635
636         * Scripts/run-jsc-stress-tests:
637
638 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
639
640         [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
641         https://bugs.webkit.org/show_bug.cgi?id=132907
642
643         Reviewed by Gyuyoung Kim.
644
645         We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
646         in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
647
648         * efl/install-dependencies:
649
650 2014-05-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
651
652         REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
653         https://bugs.webkit.org/show_bug.cgi?id=133145
654
655         Reviewed by Csaba Osztrogonác.
656
657         * Scripts/run-jsc-stress-tests:
658
659 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
660
661         [Mac] WebProcess doesn't follow localization of UI process when run as a service
662         https://bugs.webkit.org/show_bug.cgi?id=133126
663         <rdar://problem/13396515>
664         <rdar://problem/16561084>
665
666         Reviewed by Sam Weinig and Tim Horton.
667
668         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
669         (WTR::InjectedBundle::platformInitialize): It was too late to override language
670         here, and it's not necessary any more. Keeping the code for older OS versions in
671         case it did have effect in some code paths.
672
673 2014-05-19  David Farler  <dfarler@apple.com>
674
675         Move WebKitTestRunner to std::unique_ptr
676         https://bugs.webkit.org/show_bug.cgi?id=133081
677
678         Reviewed by Daniel Bates.
679
680         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
681         (WTR::InjectedBundle::didCreatePage):
682         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
683         * WebKitTestRunner/TestController.cpp:
684         (WTR::TestController::initialize):
685         (WTR::TestController::createWebViewWithOptions):
686         (WTR::TestController::resetStateToConsistentValues):
687         (WTR::TestController::runTest):
688         * WebKitTestRunner/TestController.h:
689         * WebKitTestRunner/TestInvocation.cpp:
690         * WebKitTestRunner/TestInvocation.h:
691         * WebKitTestRunner/WorkQueueManager.cpp:
692         (WTR::WorkQueueManager::processWorkQueue):
693         (WTR::WorkQueueManager::enqueue):
694         * WebKitTestRunner/WorkQueueManager.h:
695
696 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
697
698         [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
699         https://bugs.webkit.org/show_bug.cgi?id=133119
700
701         Reviewed by Sergio Villar Senin.
702
703         Check that redirect response parameter of
704         WebKitWebPage::send-request signal is NULL when not redirecting
705         and a valid WebKitURIResponse object when redirecting.
706
707         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
708         (testWebResourceSendRequest):
709         (serverCallback):
710         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
711         (sendRequestCallback):
712
713 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
714
715         REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
716         https://bugs.webkit.org/show_bug.cgi?id=133117
717
718         Reviewed by Philippe Normand.
719
720         Bring back missing tests to the build.
721
722         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
723
724 2014-05-19  Filip Pizlo  <fpizlo@apple.com>
725
726         Take care of some ARM64 test failures
727         https://bugs.webkit.org/show_bug.cgi?id=133090
728
729         Reviewed by Geoffrey Garen.
730
731         * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
732
733 2014-05-19  David Kilzer  <ddkilzer@apple.com>
734
735         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
736         <http://webkit.org/b/133089>
737
738         Reviewed by Darin Adler.
739
740         * Scripts/webkitdirs.pm:
741         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
742         specified on the command line, we would remove the '--sdk'
743         arguments, but leave '--sim', potentially passing it along to
744         xcodebuild causing a build failure.  This happens when
745         'old-run-webkit-tests --release --sim' invokes
746         build-dumprendertree when DumpRenderTree hasn't been built yet.
747
748 2014-05-19  David Farler  <dfarler@apple.com>
749
750         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
751         https://bugs.webkit.org/show_bug.cgi?id=133086
752
753         Reviewed by Daniel Bates.
754
755         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
756
757 2014-05-19  David Kilzer  <ddkilzer@apple.com>
758
759         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
760         <http://webkit.org/b/132954>
761
762         * Scripts/webkitdirs.pm:
763         (sharedCommandLineOptionsUsage): Remove the prototype for the
764         subroutine.  Older perls don't like the "+@" syntax.
765
766 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
767
768         run-javascriptcore-tests should sort the list of failing stress tests
769         https://bugs.webkit.org/show_bug.cgi?id=132989
770
771         Reviewed by Csaba Osztrogonác.
772
773         * Scripts/run-javascriptcore-tests:
774
775 2014-05-19  David Kilzer  <ddkilzer@apple.com>
776
777         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
778         <http://webkit.org/b/132954>
779
780         Reviewed by Darin Adler.
781
782         Extract code into setupMacWebKitEnvironment() for setting up
783         common environment variables so it may be shared.  Sets
784         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
785         using guardmalloc to some scripts.
786
787         Also adds support for parsing shared (common) command-line
788         switches, initially just -g|--guard-malloc.
789
790         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
791         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
792         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
793         local copy of %ENV when launching Safari so we don't have to
794         restore variables.
795
796         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
797         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
798         Check result of GetOptions() to catch invalid command-line
799         switches.
800         (runTest): Use a local copy of %ENV when running tests so we
801         don't have to restore variables.
802         (prepareEnvironmentForRunningTestTool): Call
803         setupMacWebKitEnvironment().
804
805         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
806         using sharedCommandLineOptions() and
807         sharedCommandLineOptionsUsage().  Call
808         setupMacWebKitEnvironment().
809
810         * Scripts/webkitdirs.pm:
811         (sharedCommandLineOptions): Return array of common switches to
812         pass to Getopt::Long::GetOptions().
813         (sharedCommandLineOptionsUsage): Return formatted string of
814         common switches for printing usage help text.
815         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
816         guardmalloc.
817         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
818         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
819         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
820         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
821         local copy of %ENV when launching Safari so we don't have to
822         restore variables.
823         (execMacWebKitAppForDebugging): Call
824         setupMacWebKitEnvironment().
825
826 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
827
828         support for navigator.hardwareConcurrency
829         https://bugs.webkit.org/show_bug.cgi?id=132588
830
831         Reviewed by Filip Pizlo.
832
833         * Scripts/webkitperl/FeatureList.pm:
834
835 2014-05-18  Anders Carlsson  <andersca@apple.com>
836
837         Implement Navigations for all methods declared returning one
838         https://bugs.webkit.org/show_bug.cgi?id=133048
839         <rdar://problem/16830064>
840
841         Reviewed by Sam Weinig.
842
843         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
844         Import WebKit.h.
845         
846         * MiniBrowser/mac/WK2BrowserWindowController.m:
847         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
848         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
849         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
850         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
851         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
852         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
853         Print out the navigations.
854
855 2014-05-17  Zalan Bujtas  <zalan@apple.com>
856
857         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
858         https://bugs.webkit.org/show_bug.cgi?id=133029
859
860         Reviewed by Simon Fraser.
861
862         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
863         toggling it on a WK2 window needs restart.
864         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
865         the WebPreferences just to support this temporary toggle.
866
867         * MiniBrowser/mac/BrowserWindowController.h:
868         * MiniBrowser/mac/MainMenu.xib:
869         * MiniBrowser/mac/WK1BrowserWindowController.m:
870         (-[WK1BrowserWindowController validateMenuItem:]):
871         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
872         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
873         * MiniBrowser/mac/WK2BrowserWindowController.m:
874         (-[WK2BrowserWindowController validateMenuItem:]):
875         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
876         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
877
878 2014-05-17  Anders Carlsson  <andersca@apple.com>
879
880         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
881         https://bugs.webkit.org/show_bug.cgi?id=133033
882         <rdar://problem/16830143>
883
884         Reviewed by Sam Weinig.
885
886         Set up the WebSQL and IndexedDB directories.
887
888         * WebKitTestRunner/TestController.cpp:
889         (WTR::TestController::initialize):
890
891 2014-05-16  Martin Hock  <mhock@apple.com>
892
893         MemoryCache::addImageToCache should return the result of add().
894         https://bugs.webkit.org/show_bug.cgi?id=132928
895         <rdar://problem/16651547>
896
897         Reviewed by Alexey Proskuryakov.
898
899         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
900         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
901         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
902         (TestWebKitAPI::TEST):
903
904 2014-05-15  David Farler  <dfarler@apple.com>
905
906         old-run-webkit-tests: allow specifying a simulator app path
907         https://bugs.webkit.org/show_bug.cgi?id=132975
908
909         Reviewed by Anders Carlsson.
910
911         * Scripts/old-run-webkit-tests:
912         (openIPhoneSimulator):
913         Add new --simulator-app command line parameter for specifying the
914         absolute path to the simulator app to launch before starting a
915         session.
916
917 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
918
919         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
920         https://bugs.webkit.org/show_bug.cgi?id=131363
921
922         Reviewed by Csaba Osztrogonác.
923
924         * Scripts/webkitpy/common/checkout/checkout_mock.py:
925         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
926         (MockBugzilla):
927         * Scripts/webkitpy/tool/commands/download_unittest.py:
928         (test_create_rollout_multiple_revision_with_one_resolved):
929         (test_create_rollout_multiple_resolved):
930         (test_rollout_two_revisions):
931         (test_rollout_multiple_revisions):
932         (test_rollout_multiple_revisions_with_a_missing_bug_id):
933         * Scripts/webkitpy/tool/steps/createbug.py:
934         (CreateBug.run):
935         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
936         (ReopenBugAfterRollout.run):
937
938 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
939
940         [WK2] Change the remaining framework includes from WebKit2 to WebKit
941         https://bugs.webkit.org/show_bug.cgi?id=132956
942
943         Reviewed by Sam Weinig.
944
945         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
946         * MiniBrowser/mac/AppDelegate.m:
947         * MiniBrowser/mac/WK2BrowserWindowController.m:
948         * TestWebKitAPI/InjectedBundleController.h:
949         * TestWebKitAPI/InjectedBundleMain.cpp:
950         * TestWebKitAPI/JavaScriptTest.cpp:
951         * TestWebKitAPI/PlatformUtilities.h:
952         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
953         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
954         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
955         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
956         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
957         (TestWebKitAPI::TEST):
958         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
959         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
960         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
961         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
962         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
963         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
964         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
965         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
966         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
967         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
968         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
969         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
970         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
971         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
972         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
973         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
974         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
975         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
976         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
977         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
978         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
979         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
980         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
981         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
982         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
983         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
984         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
985         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
986         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
987         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
988         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
989         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
990         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
991         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
992         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
993         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
994         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
995         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
996         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
997         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
998         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
999         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
1000         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
1001         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1002         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1003         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1004         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1005         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1006         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1007         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1008         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1009         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1010         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1011         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1012         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1013         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1014         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1015         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1016         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1017         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1018         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1019         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1020         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1021         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1022         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1023         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1024         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
1025         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1026         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1027         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
1028         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1029         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1030         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1031         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1032         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1033         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
1034         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1035         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
1036         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1037         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1038         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1039         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1040         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1041         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1042         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1043         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1044         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1045         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1046         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1047         * TestWebKitAPI/config.h:
1048         * TestWebKitAPI/efl/PlatformWebView.cpp:
1049         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1050         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1051         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1052         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1053         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1054         * WebKitTestRunner/EventSenderProxy.h:
1055         * WebKitTestRunner/GeolocationProviderMock.cpp:
1056         * WebKitTestRunner/GeolocationProviderMock.h:
1057         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1058         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1059         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1060         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1061         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1062         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1063         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1064         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1065         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1066         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1067         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1068         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1069         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1070         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1071         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1072         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1073         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1074         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
1075         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1076         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1077         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1078         * WebKitTestRunner/PlatformWebView.h:
1079         * WebKitTestRunner/StringFunctions.h:
1080         * WebKitTestRunner/TestController.cpp:
1081         * WebKitTestRunner/TestController.h:
1082         * WebKitTestRunner/TestInvocation.cpp:
1083         * WebKitTestRunner/TestInvocation.h:
1084         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1085         * WebKitTestRunner/WebNotificationProvider.cpp:
1086         * WebKitTestRunner/WebNotificationProvider.h:
1087         * WebKitTestRunner/WorkQueueManager.cpp:
1088         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1089         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1090         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1091         * WebKitTestRunner/config.h:
1092         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1093         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1094         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1095         * WebKitTestRunner/ios/TestControllerIOS.mm:
1096         * WebKitTestRunner/mac/EventSenderProxy.mm:
1097         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1098         * WebKitTestRunner/mac/TestControllerMac.mm:
1099
1100 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1101
1102         [EFL][WK2] Skip failing unit tests
1103         https://bugs.webkit.org/show_bug.cgi?id=132979
1104
1105         Reviewed by Daniel Bates.
1106
1107         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
1108
1109 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1110
1111         [iOS] Support TestWebKitAPI in the iOS Simulator
1112         <http://webkit.org/b/129535>
1113         <rdar://problem/16203529>
1114
1115         Reviewed by Daniel Bates.
1116
1117         * Scripts/run-api-tests:
1118         (runTest):
1119         (listAllTests):
1120         - Extract common arguments into local variable.
1121         - Use xcrun to find the sim tool in order to invoke
1122         TestWebKitAPI properly in the iOS Simulator. 
1123
1124         * Scripts/webkitdirs.pm:
1125         (argumentsForConfiguration): Set --device or --sim as
1126         appropriate to fix buildTestTool() in run-api-tests.
1127
1128 2014-05-15  Tim Horton  <timothy_horton@apple.com>
1129
1130         Fix a logging typo in copy-webkitlibraries-to-product-directory
1131
1132         Reviewed by Dean Jackson.
1133
1134         * Scripts/copy-webkitlibraries-to-product-directory:
1135
1136 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1137
1138         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
1139         <http://webkit.org/b/132959>
1140
1141         Reviewed by Dan Bernstein.
1142
1143         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1144         Cocoa directory to project and move URLExtras.mm into it.
1145         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
1146
1147 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1148
1149         [GTK] Compile all installed resources as GResources
1150         https://bugs.webkit.org/show_bug.cgi?id=131099
1151
1152         Reviewed by Philippe Normand.
1153
1154         * Scripts/webkitpy/port/gtk.py:
1155         (GtkPort.setup_environ_for_server): Removed now unneeded
1156         AUDIO_RESOURCES_PATH env var.
1157
1158 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1159
1160         Remove CSS_STICKY_POSITION guards
1161         https://bugs.webkit.org/show_bug.cgi?id=132676
1162
1163         Reviewed by Simon Fraser.
1164
1165         * Scripts/webkitperl/FeatureList.pm:
1166
1167 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1168
1169         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
1170         https://bugs.webkit.org/show_bug.cgi?id=132686
1171
1172         Reviewed by Philippe Normand.
1173
1174         Bring back InputMethodFilter test to the build and compile it into
1175         a single binary TestWebCore with the other WebCore tests. Also
1176         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
1177
1178         * Scripts/run-gtk-tests:
1179         (TestRunner): Remove WebCoreGtk from the list of test directories.
1180         * TestWebKitAPI/PlatformGTK.cmake:
1181         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
1182
1183 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1184
1185         [EFL] Make XVFBDriver optional
1186         https://bugs.webkit.org/show_bug.cgi?id=131036
1187
1188         Reviewed by Gyuyoung Kim.
1189
1190         * Scripts/webkitpy/port/efl.py:
1191         (EflPort._driver_class):
1192
1193 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1194
1195         Flakiness dashboard contains outdated list of bots on builders.jsonp
1196         https://bugs.webkit.org/show_bug.cgi?id=132874
1197
1198         Reviewed by Darin Adler.
1199
1200         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
1201         file by changing to the directory Tools/TestResultServer and executing
1202         the script generate_builders_json.py
1203
1204 2014-05-11  Anders Carlsson  <andersca@apple.com>
1205
1206         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
1207         https://bugs.webkit.org/show_bug.cgi?id=132809
1208
1209         Reviewed by Dan Bernstein.
1210
1211         * WebKitTestRunner/TestController.cpp:
1212         (WTR::TestController::initialize):
1213         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
1214
1215 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1216
1217         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
1218         https://bugs.webkit.org/show_bug.cgi?id=132739
1219
1220         Reviewed Anders Carlsson.
1221
1222         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
1223         the JSC unit tests.
1224         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
1225
1226 2014-05-11  Anders Carlsson  <andersca@apple.com>
1227
1228         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
1229         https://bugs.webkit.org/show_bug.cgi?id=132806
1230
1231         Reviewed by Beth Dakin.
1232
1233         Migrate to WKContextConfiguration.
1234
1235         * WebKitTestRunner/TestController.cpp:
1236         (WTR::TestController::initialize):
1237
1238 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1239
1240         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
1241         https://bugs.webkit.org/show_bug.cgi?id=132685
1242
1243         Reviewed by Martin Robinson.
1244
1245         Use a single TestWebKit2 binary for all WebKit2 C API tests.
1246
1247         * TestWebKitAPI/PlatformGTK.cmake:
1248
1249 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
1250
1251         [iOS] Switch geolocation to an explicit authorization query model
1252         https://bugs.webkit.org/show_bug.cgi?id=132717
1253
1254         Reviewed by Sam Weinig.
1255
1256         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1257         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
1258         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
1259
1260 2014-05-09  David Farler  <dfarler@apple.com>
1261
1262         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
1263         https://bugs.webkit.org/show_bug.cgi?id=132718
1264
1265         Reviewed by David Kilzer.
1266
1267         The simulator may not be able to look up runtimes by SDK paths
1268         and instead will map SDK versions to runtimes instead. In
1269         com.apple.iphonesimulator.startSession notifications,
1270         'runtimeIdentifier' (SDK version string) is preferred over
1271         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
1272         when creating a new DRT or WKTR simulator session.
1273
1274         IPhoneSimulatorNotification.pm filters out keys for this
1275         notification's userInfo with a hard-coded list. There's no harm
1276         in including extra key-value pairs in an NSNotification userInfo
1277         dictionary anyway and the simulator may again change its
1278         userInfo schema for this notification.
1279
1280         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
1281         (postStartSessionNotification):
1282         * Scripts/old-run-webkit-tests:
1283         (installAndLaunchDumpToolAppUsingNotification):
1284
1285 2014-05-09  Anders Carlsson  <andersca@apple.com>
1286
1287         Another build fix.
1288
1289         * Scripts/build-webkit:
1290         WebKit2 should always be built for OS X and iOS.
1291
1292 2014-05-09  Anders Carlsson  <andersca@apple.com>
1293
1294         Follow-up build fix.
1295
1296         * Scripts/build-webkit:
1297         WebKit2 should no longer be built before WebKit.
1298
1299 2014-05-09  Anders Carlsson  <andersca@apple.com>
1300
1301         Rename WebKit2.framework to WebKit.framework
1302         https://bugs.webkit.org/show_bug.cgi?id=132743
1303         <rdar://problem/15920046>
1304
1305         Reviewed by Dan Bernstein.
1306
1307         * Scripts/check-for-inappropriate-files-in-framework:
1308         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
1309         Change WebKit2 to WebKit.
1310
1311         * Scripts/check-for-webkit-framework-include-consistency:
1312         Change WebKit to WebKitLegacy.
1313
1314 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
1315
1316         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
1317         https://bugs.webkit.org/show_bug.cgi?id=132732
1318
1319         Reviewed by Alexey Proskuryakov.
1320
1321         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
1322
1323         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1324         (EWS): Remove GTK+ WK1 EWS.
1325
1326 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1327
1328         Add new u-szeged contributors.
1329
1330         Reviewed by Csaba Osztrogonác.
1331
1332         * Scripts/webkitpy/common/config/contributors.json:
1333
1334 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1335
1336         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
1337         https://bugs.webkit.org/show_bug.cgi?id=132736
1338
1339         Reviewed by Philippe Normand.
1340
1341         There are two problems, the path returned by common.library_build_path() is wrong when
1342         common.binary_build_path() has previously been called, and the test is still looking for
1343         the .la instead of .so
1344
1345         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1346         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
1347         of .la as extension of the injected bundle library.
1348         * gtk/common.py:
1349         (binary_build_path): Remove unused global variable and add a new
1350         one for binary_build_dir instead of sharing the same global
1351         variable for library_build_path and binary_build_path.
1352
1353 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
1354
1355         [EFL] Enable MEDIA_STREAM for EFL port
1356         https://bugs.webkit.org/show_bug.cgi?id=132648
1357
1358         Reviewed by Gyuyoung Kim.
1359
1360         Script modified to enable MEDIA_STREAM for EFL build.
1361
1362         * Scripts/webkitperl/FeatureList.pm: 
1363
1364 2014-05-08  David Farler  <dfarler@apple.com>
1365
1366         old-run-webkit-tests: update strings for simulator devices and app name
1367         https://bugs.webkit.org/show_bug.cgi?id=132687
1368
1369         Reviewed by Darin Adler.
1370
1371         iPhone Retina (4-inch) -> iPhone 5
1372         iPhone Retina (4-inch 64-bit) -> iPhone 5s
1373
1374         * Scripts/old-run-webkit-tests:
1375         (installAndLaunchDumpToolAppUsingNotification):
1376         (openIPhoneSimulator):
1377         (quitIPhoneSimulator):
1378         quit iOS Simulator, not iPhone Simulator.
1379
1380 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1381
1382         REGRESSION(r168471): Update the builder names on the scheduler list.
1383         https://bugs.webkit.org/show_bug.cgi?id=132699
1384
1385         Reviewed by Martin Robinson.
1386
1387         On r168471 I missed to update the builder names for the GTK build
1388         bots on the AnyBranchScheduler type scheduler list of bots.
1389
1390         * BuildSlaveSupport/build.webkit.org-config/config.json:
1391
1392 2014-05-08  Brady Eidson  <beidson@apple.com>
1393
1394         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
1395         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
1396
1397         Reviewed by Tim Horton.
1398
1399         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
1400         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1401
1402 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1403
1404         REGRESSION(r168471): Duplicate builddirs broke the build master.
1405         https://bugs.webkit.org/show_bug.cgi?id=132688
1406
1407         Reviewed by Carlos Garcia Campos.
1408
1409         Rename the builddirs of the new GTK bots introduced on r168471 to
1410         be unique. Otherwise the master will break.
1411
1412         * BuildSlaveSupport/build.webkit.org-config/config.json:
1413
1414 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1415
1416         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
1417         https://bugs.webkit.org/show_bug.cgi?id=132674
1418
1419         Reviewed by Philippe Normand.
1420
1421         Only ignore mkdir failure when exception is raised because the
1422         file already exists and it's a directory.
1423
1424         * gtk/webkitdom.py:
1425         (write_doc_files):
1426
1427 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1428
1429         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
1430         https://bugs.webkit.org/show_bug.cgi?id=131358
1431
1432         Reviewed by Carlos Garcia Campos.
1433
1434         Current 64-bit GTK build bots (Release and Debug) not only test
1435         the build, but run all tests. Split each one of the bots in
1436         BuildOnly and TestWebKit2.
1437
1438         This will allow us to have a better overview of the status of
1439         the GTK port.
1440
1441         Original patch from Sergio Villar Senin <svillar@igalia.com>
1442
1443         * BuildSlaveSupport/build.webkit.org-config/config.json:
1444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1446         (WebKitBuildbot):
1447         * Scripts/webkitpy/port/builders.py:
1448         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1449         (TestRebaselineTest.test_baseline_directory):
1450         * TestResultServer/static-dashboards/builders.jsonp:
1451         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1452         (resetGlobals):
1453         * TestResultServer/static-dashboards/loader_unittests.js:
1454
1455 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1456
1457         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
1458         https://bugs.webkit.org/show_bug.cgi?id=126022
1459
1460         Reviewed by Benjamin Poulain.
1461
1462         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
1463
1464         Added an unit test case to check if scroll position and scale are restored properly.
1465
1466         * TestWebKitAPI/PlatformEfl.cmake:
1467         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
1468         (TestWebKitAPI::didFinishLoadForFrame):
1469         (TestWebKitAPI::didChangeContentsPosition):
1470         (TestWebKitAPI::TEST):
1471         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
1472         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
1473
1474 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
1475
1476         WebKit1 is flashy when compositing layers come and go
1477         https://bugs.webkit.org/show_bug.cgi?id=132655
1478         <rdar://problem/16830981&16788846>
1479
1480         Reviewed by Sam Weinig.
1481         
1482         Revert the change from r166117.
1483
1484         * DumpRenderTree/mac/DumpRenderTree.mm:
1485         (updateDisplay):
1486
1487 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
1488
1489         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
1490         https://bugs.webkit.org/show_bug.cgi?id=132622
1491
1492         Reviewed by Mario Sanchez Prada.
1493
1494         * DumpRenderTree/AccessibilityUIElement.cpp:
1495         (selectTextWithCriteriaCallback):
1496         (isEqualCallback):
1497         * DumpRenderTree/AccessibilityUIElement.h:
1498         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1499         (AccessibilityUIElement::selectTextWithCriteria):
1500         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1501         (AccessibilityUIElement::selectTextWithCriteria):
1502         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1503         (selectTextParameterizedAttributeForCriteria):
1504         (AccessibilityUIElement::selectTextWithCriteria):
1505         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1506         (AccessibilityUIElement::selectTextWithCriteria):
1507         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1508         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1509         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1510         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1511         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1512         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1513         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1514         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1515         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1516         (WTR::selectTextParameterizedAttributeForCriteria):
1517         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1518
1519 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1520
1521         [SOUP] TLSErrors do not cause page load to fail when not ignored
1522         https://bugs.webkit.org/show_bug.cgi?id=121548
1523
1524         Reviewed by Sergio Villar Senin.
1525
1526         Add unit tests to check that the load fails with TLS errors in
1527         case of a redirection.
1528
1529         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1530         (testTLSErrorsRedirect):
1531         (httpsServerCallback):
1532         (beforeAll):
1533
1534 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
1535
1536         [CSS Grid Layout] Remove runtime feature
1537         https://bugs.webkit.org/show_bug.cgi?id=132382
1538
1539         Reviewed by Benjamin Poulain.
1540
1541         Remove cssGridLayoutEnabled setting usage.
1542
1543         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1544         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1545         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1546         (TestRunner::overridePreference):
1547         * DumpRenderTree/mac/DumpRenderTree.mm:
1548         (resetWebPreferencesToConsistentValues):
1549
1550 2014-05-06  David Kilzer  <ddkilzer@apple.com>
1551
1552         Add Makefile targets for copying static libraries (LLVM and WKSI)
1553         <http://webkit.org/b/132619>
1554
1555         Reviewed by Mark Rowe.
1556
1557         * Scripts/copy-webkitlibraries-to-product-directory: Set a
1558         sensible default for product directory if not specified on
1559         either the command-line or in the environment (by Xcode) by
1560         calling productDir() in webkitdirs.pm.
1561
1562 2014-05-06  Brady Eidson  <beidson@apple.com>
1563
1564         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
1565         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
1566
1567         Reviewed by Sam Weinig.
1568
1569         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1570
1571         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
1572         (TestWebKitAPI::itemURLLastComponentIsString):
1573         (TestWebKitAPI::didFinishLoadForFrame):
1574         (TestWebKitAPI::willGoToBackForwardListItem):
1575         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1576         (TestWebKitAPI::setPageLoaderClient):
1577         (TestWebKitAPI::TEST):
1578         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
1579         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
1580
1581         * WebKitTestRunner/TestController.cpp:
1582         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
1583
1584 2014-05-06  Darin Adler  <darin@apple.com>
1585
1586         Try to fix iOS build.
1587
1588         * DumpRenderTree/mac/TestRunnerMac.mm:
1589         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
1590         Updated since I changed testRunner into a pointer instead of a reference.
1591         Updated argument names to avoid conflict with field names.
1592         (-[APITestDelegateIPhone run]): Ditto.
1593         (-[APITestDelegateIPhone _cleanUp]): Ditto.
1594
1595 2014-05-06  Commit Queue  <commit-queue@webkit.org>
1596
1597         Unreviewed, rolling out r168304.
1598         https://bugs.webkit.org/show_bug.cgi?id=132607
1599
1600         Broke the build (Requested by KaL on #webkit).
1601
1602         Reverted changeset:
1603
1604         "[GTK][CMake] Unable to do make install"
1605         https://bugs.webkit.org/show_bug.cgi?id=130188
1606         http://trac.webkit.org/changeset/168304
1607
1608 2014-05-04  Darin Adler  <darin@apple.com>
1609
1610         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
1611         https://bugs.webkit.org/show_bug.cgi?id=80222
1612
1613         Reviewed by Alexey Proskuryakov.
1614
1615         * DumpRenderTree/mac/TestRunnerMac.mm:
1616         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
1617         do more work here so we don't use RetainPtr local variables.
1618         (-[APITestDelegateIPhone dealloc]): Added.
1619         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
1620         created. Updated for changes to member names and types.
1621         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
1622         updated for changes to member names and types. Changed to two word spelling.
1623         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
1624         name of _cleanUp method.
1625         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
1626         Ditto.
1627         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
1628
1629 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
1630
1631         Clean up Image Document and tweak the layout and viewport
1632         https://bugs.webkit.org/show_bug.cgi?id=132552
1633
1634         Reviewed by Anders Carlsson.
1635
1636         * DumpRenderTree/mac/DumpRenderTree.mm:
1637         (resetWebPreferencesToConsistentValues):
1638         Update the default settings to have something consistent with WebKit2.
1639
1640 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
1641
1642         [GTK][CMake] Unable to do make install
1643         https://bugs.webkit.org/show_bug.cgi?id=130188
1644
1645         Reviewed by Carlos Garcia Campos.
1646
1647         * Scripts/webkitdirs.pm:
1648         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
1649         will give an early signal that a change has broken the documentation.
1650
1651 2014-05-05  Pratik Solanki  <psolanki@apple.com>
1652
1653         Update framework locations in package-root
1654         https://bugs.webkit.org/show_bug.cgi?id=132571
1655
1656         Reviewed by Simon Fraser.
1657
1658         * Scripts/package-root:
1659
1660 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
1661
1662         [EFL][WK2] Refactor favicon database APIs
1663         https://bugs.webkit.org/show_bug.cgi?id=132519
1664
1665         Reviewed by Gyuyoung Kim.
1666
1667         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
1668         (update_view_favicon):
1669         (on_icon_changed_cb):
1670         (window_free):
1671         (on_url_changed):
1672         (window_create):
1673         (on_view_favicon_changed): Deleted.
1674
1675 2014-05-02  Mark Rowe  <mrowe@apple.com>
1676
1677         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
1678
1679         Reviewed by Dan Bernstein.
1680
1681         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
1682         when determining which LLVM archive to extract.
1683
1684 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1685
1686         Add Jeremy as a committer.
1687         https://bugs.webkit.org/show_bug.cgi?id=132492
1688
1689         Reviewed by Jer Noble.
1690
1691         Add myself as a committer.
1692
1693         * Scripts/webkitpy/common/config/contributors.json:
1694
1695 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1696
1697         Add Jeremy as a committer.
1698         https://bugs.webkit.org/show_bug.cgi?id=132492
1699
1700         Reviewed by Jer Noble.
1701
1702         Add Jeremy Jones to the committers file.
1703
1704         * Scripts/webkitpy/common/config/contributors.json:
1705
1706 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
1707
1708         Hard to figure out how to run a single test with run-api-tests
1709         https://bugs.webkit.org/show_bug.cgi?id=116332
1710
1711         Reviewed by Alexey Proskuryakov.
1712
1713         * Scripts/run-api-tests: add two examples to the help message.
1714
1715 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
1716
1717         Fix several memory leaks found by code inspection
1718         https://bugs.webkit.org/show_bug.cgi?id=132472
1719
1720         Reviewed by Geoffrey Garen.
1721         
1722         Fix memory leaks.
1723
1724         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
1725         (TestWebKitAPI::TEST):
1726         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1727         (WTR::InjectedBundlePage::willSendRequestForFrame):
1728         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1729         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1730
1731 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
1732
1733         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
1734         https://bugs.webkit.org/show_bug.cgi?id=132446
1735
1736         Reviewed by Mark Hahnenberg.
1737         
1738         Test the FTL by default now that it's enabled by default.
1739
1740         * Scripts/run-javascriptcore-tests:
1741
1742 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
1743
1744         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
1745         https://bugs.webkit.org/show_bug.cgi?id=132240
1746
1747         Reviewed by Anders Carlsson.
1748
1749         Removed ewk_view_setting_tiled_backingstore related code.
1750
1751         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1752         (DumpRenderTreeChrome::createView):
1753         (shouldUseTiledBackingStore): Deleted.
1754         * EWebLauncher/main.c:
1755         (windowCreate):
1756         (parseUserArguments):
1757
1758 2014-05-01  Anders Carlsson  <andersca@apple.com>
1759
1760         window.testRunner.keepWebHistory() should update the UI process state
1761         https://bugs.webkit.org/show_bug.cgi?id=132440
1762
1763         Reviewed by Dan Bernstein.
1764
1765         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1766         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1767         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1768         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1769         (WTR::TestRunner::keepWebHistory):
1770         * WebKitTestRunner/TestInvocation.cpp:
1771         (WTR::TestInvocation::invoke):
1772         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1773
1774 2014-05-01  David Kilzer  <ddkilzer@apple.com>
1775
1776         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
1777         <http://webkit.org/b/132432>
1778
1779         Reviewed by Tim Horton.
1780
1781         * Scripts/webkitperl/FeatureList.pm: Remove support for
1782         --plugin-proxy-for-video switch.
1783
1784 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1785
1786         Kernel sysctl interface hw.activecpu don't exists on Linux.
1787         https://bugs.webkit.org/show_bug.cgi?id=132286
1788
1789         Reviewed by Filip Pizlo.
1790
1791         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
1792         calling sysctl over hw.activecpu
1793
1794 2014-04-30  Anders Carlsson  <andersca@apple.com>
1795
1796         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
1797         https://bugs.webkit.org/show_bug.cgi?id=132399
1798         <rdar://problem/15920046>
1799
1800         Reviewed by Dan Bernstein.
1801
1802         * Scripts/check-for-webkit-framework-include-consistency:
1803         Allos WAK headers in WebKitLegacy as well as WebKit.
1804
1805         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1806         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1807         Update header imports.
1808
1809 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1810
1811         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
1812         https://bugs.webkit.org/show_bug.cgi?id=131954
1813
1814         Reviewed by Darin Adler.
1815         
1816         WebKitTestRunner was adding application-specific information to crash reports
1817         to log the test path, but only in the web process. Fix it to also do this
1818         for the UI process, for both iOS and OS X.
1819         
1820         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
1821         both iOS and OS X.
1822         
1823         Factored crash reprorter-related code into CrashReporterInfo, and call it from
1824         a new TestController::platformWillRunTest() function on Mac and iOS.
1825         
1826         Also remove Xcode-added unit test junk from the project.
1827
1828         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1829         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1830         * WebKitTestRunner/TestController.cpp:
1831         (WTR::TestController::runTest):
1832         * WebKitTestRunner/TestController.h:
1833         * WebKitTestRunner/TestInvocation.cpp:
1834         (WTR::TestInvocation::url):
1835         * WebKitTestRunner/TestInvocation.h:
1836         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1837         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
1838         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
1839         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
1840         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1841         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
1842         (WTR::testPathFromURL):
1843         (WTR::setCrashReportApplicationSpecificInformationToURL):
1844         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1845         (WTR::TestController::platformWillRunTest):
1846         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1847         (WTR::TestController::platformWillRunTest):
1848         * WebKitTestRunner/ios/TestControllerIOS.mm:
1849         (WTR::TestController::platformWillRunTest):
1850         (WTR::TestController::setHidden):
1851         * WebKitTestRunner/mac/TestControllerMac.mm:
1852         (WTR::TestController::platformWillRunTest):
1853
1854 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1855
1856         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
1857
1858         Reviewed by Tim Horton.
1859
1860         * DumpRenderTree/mac/DumpRenderTree.mm:
1861         (resetWebPreferencesToConsistentValues):
1862         (prepareConsistentTestingEnvironment):
1863
1864 2014-04-30  Anders Carlsson  <andersca@apple.com>
1865
1866         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
1867         https://bugs.webkit.org/show_bug.cgi?id=132397
1868
1869         Reviewed by Dan Bernstein.
1870
1871         * Scripts/check-for-inappropriate-macros-in-external-headers:
1872
1873 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
1874
1875         [GTK] Make it easier to run CMake for downstreams
1876         https://bugs.webkit.org/show_bug.cgi?id=132370
1877
1878         Reviewed by Carlos Garcia Campos.
1879
1880         * Scripts/webkitdirs.pm:
1881         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
1882         the GTK+ port.
1883
1884 2014-04-29  Stephanie Lewis  <slewis@apple.com>
1885
1886         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
1887         
1888         Rubber stamped by Jessie Berlin.
1889
1890         JSON.pm was removed from our tools setup.
1891
1892         * Scripts/generate-coverage-data:
1893
1894 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
1895
1896         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
1897         https://bugs.webkit.org/show_bug.cgi?id=112840
1898
1899         Rubber stamped by Geoffrey Garen.
1900
1901         * Scripts/build-jsc: Enable it on Mac.
1902         * Scripts/build-webkit: Enable it on Mac.
1903         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
1904
1905 2014-04-28  Sam Weinig  <sam@webkit.org>
1906
1907         REGRESSION (r167751): svn-create-patch is very slow
1908         https://bugs.webkit.org/show_bug.cgi?id=132300
1909
1910         Reviewed by Alexey Proskuryakov.
1911
1912         * Scripts/svn-create-patch:
1913         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
1914         by calling `svn-create-patch --style`.
1915
1916 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
1917
1918         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
1919         https://bugs.webkit.org/show_bug.cgi?id=132190
1920
1921         Reviewed by Gustavo Noronha Silva.
1922
1923         * Scripts/webkitdirs.pm:
1924         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
1925             if ninja is in the path.
1926         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
1927             to the previous ninja generator if not.
1928
1929 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1930
1931         check-webkit-style should understand --git-index
1932         https://bugs.webkit.org/show_bug.cgi?id=125364
1933
1934         Reviewed by Csaba Osztrogonác.
1935
1936         * Scripts/webkitpy/common/checkout/scm/git.py:
1937         (Git.create_patch): The command now supports the --cached option.
1938         * Scripts/webkitpy/style/main.py:
1939         (CheckWebKitStyle.main): Passing the --git-index option.
1940         * Scripts/webkitpy/style/optparser.py:
1941         (CommandOptionValues.__init__): The git-index option is switched off by default.
1942         (CommandOptionValues.__eq__): Equality check for the new option.
1943         (ArgumentParser._create_option_parser):Adding the --git-index option
1944         (ArgumentParser.parse):
1945         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
1946         (CommandOptionValuesTest.test_init): 
1947         (CommandOptionValuesTest.test_eq):
1948
1949 2014-04-28  Michael Saboff  <msaboff@apple.com>
1950
1951         Crash in platform/mac/accessibility/table-visible-rows.html
1952         https://bugs.webkit.org/show_bug.cgi?id=132146
1953
1954         Reviewed by Filip Pizlo.
1955
1956         Instead of creating a local JSValueRef array on the stack and passing that to
1957         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
1958         values using the JSObjectSetPropertyAtIndex() API.
1959
1960         * DumpRenderTree/AccessibilityUIElement.cpp:
1961         (elementsForRangeCallback):
1962         (convertElementsToObjectArray):
1963         * DumpRenderTree/mac/TestRunnerMac.mm:
1964         (originsArrayToJS):
1965         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1966         (WTR::EventSendingController::contextClick):
1967         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1968         (WTR::stringArrayToJS):
1969         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1970         (WTR::convertElementsToObjectArray):
1971
1972 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
1973
1974         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
1975         "no-cjit" runs force the old-school threshold.
1976
1977         Rubber stamped by Mark Hahnenberg.
1978
1979         * Scripts/run-jsc-stress-tests:
1980
1981 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1982
1983         [GTK] install-dependencies should also install ruby-json and ruby-highline
1984         https://bugs.webkit.org/show_bug.cgi?id=132292
1985
1986         Reviewed by Philippe Normand.
1987
1988         * gtk/install-dependencies: Install ruby json and highline packages.
1989
1990 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
1991
1992         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
1993         https://bugs.webkit.org/show_bug.cgi?id=132176
1994
1995         Reviewed by Gyuyoung Kim.
1996
1997         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
1998         and turn off indexedDB feature until the sqlite implementation is introduced.
1999
2000         * Scripts/webkitperl/FeatureList.pm:
2001
2002 2014-04-25  James Craig  <jcraig@apple.com>
2003
2004         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
2005         https://bugs.webkit.org/show_bug.cgi?id=132209
2006
2007         Reviewed by Daniel Bates.
2008
2009         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
2010         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
2011
2012         * Scripts/prepare-ChangeLog:
2013         (main): 
2014
2015 2014-04-25  Michael Saboff  <msaboff@apple.com>
2016
2017         Crash in platform/mac/accessibility/table-visible-rows.html
2018         https://bugs.webkit.org/show_bug.cgi?id=132146
2019
2020         Reviewed by Mark Lam.
2021
2022         Changed to use a local JSValueRef array temporary instead of a
2023         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
2024         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
2025         the temporary values could be collected.
2026
2027         * DumpRenderTree/AccessibilityUIElement.cpp:
2028         (convertElementsToObjectArray):
2029         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2030         (WTR::EventSendingController::contextClick):
2031         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2032         (WTR::convertElementsToObjectArray):
2033
2034 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
2035
2036         Unreviewed GTK gardening
2037
2038         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
2039         (TestRunner):
2040
2041 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
2042
2043         prepare-ChangeLog reports as deleted methods that has not been removed.
2044         https://bugs.webkit.org/show_bug.cgi?id=131733
2045
2046         Reviewed by Ryosuke Niwa.
2047
2048         * Scripts/prepare-ChangeLog:
2049         (originalFile): Set merge base to origin/master by default.
2050
2051 2014-04-23  James Craig  <jcraig@apple.com>
2052
2053         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
2054         https://bugs.webkit.org/show_bug.cgi?id=131115
2055
2056         Reviewed by Daniel Bates.
2057
2058         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
2059
2060         * Scripts/commit-log-editor: Added --no-style.
2061         * Scripts/prepare-ChangeLog: Primary patch.
2062         (main): Primary patch.
2063         (createPatchCommand): Added --no-style.
2064         * Scripts/svn-create-patch: Primary patch.
2065         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
2066         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
2067         (SVN.create_patch): Added --no-style.
2068
2069 2014-04-23  Anders Carlsson  <andersca@apple.com>
2070
2071         Try to fix iOS build.
2072
2073         * DumpRenderTree/mac/DumpRenderTree.mm:
2074
2075 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
2076
2077         Eliminate internals.setMockScrollbarsEnabled()
2078         https://bugs.webkit.org/show_bug.cgi?id=132085
2079
2080         Reviewed by Tim Horton.
2081
2082         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
2083         No need to reset the preference, there is no way it can change.
2084
2085 2014-04-23  James Craig  <jcraig@apple.com>
2086
2087         Unreviewed. Moving myself from Contributors to Committers list.
2088
2089         * Scripts/webkitpy/common/config/contributors.json:
2090
2091 2014-04-23  Tim Horton  <timothy_horton@apple.com>
2092
2093         Mock scrollbars don't always work in DumpRenderTree
2094         https://bugs.webkit.org/show_bug.cgi?id=132082
2095
2096         Reviewed by Alexey Proskuryakov.
2097
2098         * DumpRenderTree/mac/DumpRenderTree.mm:
2099         (prepareConsistentTestingEnvironment):
2100         Set the mock scrollbar setting before creating the WebView, as this setting
2101         cannot be dynamically changed, so any scrollbars that are created during
2102         WebView initialization and are not replaced before snapshotting will end
2103         up being platform scrollbars instead of mock ones.
2104         WebKitTestRunner already sets this preference before creating WKViews,
2105         so we're just matching its behavior.
2106
2107 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2108
2109         [GTK] ShadowRoot API was removed in r164131
2110         https://bugs.webkit.org/show_bug.cgi?id=132059
2111
2112         Reviewed by Gustavo Noronha Silva.
2113
2114         Add WebKitDOMShadowRoot to the list of deleted classes to generate
2115         the API docs.
2116
2117         * gtk/webkitdom.py:
2118         (WebKitDOMDocGenerator):
2119
2120 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
2121
2122         [GTK] run-webkit-tests script is failing to invoke run-launcher
2123         https://bugs.webkit.org/show_bug.cgi?id=132051
2124
2125         Reviewed by Philippe Normand.
2126
2127         After the WK1 support was dropped, if run-webkit-tests is executed
2128         without --no-show-results parameter, the launcher is being called
2129         using a -2 parameter that is it causing the run-launcher to break.
2130
2131         * Scripts/webkitpy/port/gtk.py:
2132         (GtkPort.show_results_html_file):
2133
2134 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2135
2136         DumpRenderTree generates black snapshots on some platforms
2137         https://bugs.webkit.org/show_bug.cgi?id=132029
2138         <rdar://problem/16679363>
2139
2140         Reviewed by Simon Fraser.
2141
2142         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2143         (createBitmapContextFromWebView):
2144         DRT checks with the WebView to determine whether it can use the window's
2145         backing store directly or (because of compositing) needs to take a WindowServer
2146         snapshot. However, on some platforms and in some situations, the window can
2147         be layer backed without the WebView necessarily currently being composited.
2148         We should check with the window in addition to the WebView before going
2149         ahead and using its backing store.
2150
2151 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2152
2153         DumpRenderTree generates white snapshots on some platforms
2154         https://bugs.webkit.org/show_bug.cgi?id=132026
2155         <rdar://problem/16679363>
2156
2157         Reviewed by Simon Fraser.
2158
2159         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2160         Link DRT against QuartzCore.
2161
2162         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2163         (createBitmapContextFromWebView):
2164         Force CoreAnimation to synchronously update layers in a more explicit
2165         way that doesn't depend on AppKit behavior. This is very similar to what
2166         WebKitTestRunner does (indirectly) during its force repaint.
2167
2168 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
2169
2170         [Win] Support Python 2.7 in Cygwin
2171         https://bugs.webkit.org/show_bug.cgi?id=132023
2172
2173         Reviewed by Michael Saboff.
2174
2175         * Scripts/webkitdirs.pm:
2176         (checkInstalledTools): Remove check for Python 2.7, since
2177         it now works properly.
2178
2179 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
2180
2181         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2182         https://bugs.webkit.org/show_bug.cgi?id=130867
2183         <rdar://problem/16432456> 
2184
2185         Reviewed by Mark Hahnenberg.
2186
2187         * Scripts/build-webkit:
2188         * Scripts/copy-webkitlibraries-to-product-directory:
2189
2190 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
2191
2192         [GTK] Fails to build documentation when output is redirected
2193         https://bugs.webkit.org/show_bug.cgi?id=131178
2194
2195         Reviewed by Martin Robinson.
2196
2197         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
2198         explicitly to avoid encoding issues when they are redirected.
2199
2200 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
2201
2202         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
2203         https://bugs.webkit.org/show_bug.cgi?id=131911
2204
2205         Reviewed by Martin Robinson.
2206
2207         common.get_build_path returns release path even though Debug configuration
2208         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
2209
2210         * gtk/ycm_extra_conf.py:
2211         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
2212         (FlagsForFile):
2213
2214 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
2215
2216         Unreviewed build fix.
2217
2218         * DumpRenderTree/mac/EventSendingController.mm:
2219         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2220         Correct a typo that prevented tests from working properly.
2221
2222 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
2223
2224         [GTK] Should have the ability to output composited contents during layout testing
2225         https://bugs.webkit.org/show_bug.cgi?id=131864
2226
2227         Reviewed by Philippe Normand.
2228
2229         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2230         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
2231         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
2232         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2233         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
2234
2235 2014-04-21  Sam Weinig  <sam@webkit.org>
2236
2237         Attempt to fix the tests.
2238
2239         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2240         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2241         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
2242
2243 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
2244
2245         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
2246         being the same as a "quick run", which is meant for genuinely slow tests).
2247
2248         * Scripts/run-jsc-stress-tests:
2249
2250 2014-04-21  Darin Adler  <darin@apple.com>
2251
2252         Add HashSet::takeAny
2253         https://bugs.webkit.org/show_bug.cgi?id=131928
2254
2255         Reviewed by Benjamin Poulain.
2256
2257         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
2258
2259 2014-04-20  Dan Bernstein  <mitz@apple.com>
2260
2261         Fixed a test timing out after r167572.
2262
2263         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2264         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
2265         -webView:didFinishLoadingNavigation:.
2266
2267 2014-04-20  Commit Queue  <commit-queue@webkit.org>
2268
2269         Unreviewed, rolling out r167510.
2270         https://bugs.webkit.org/show_bug.cgi?id=131915
2271
2272         broke GTK Debug bot (Requested by philn on #webkit).
2273
2274         Reverted changeset:
2275
2276         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
2277         it when running layout tests"
2278         https://bugs.webkit.org/show_bug.cgi?id=131472
2279         http://trac.webkit.org/changeset/167510
2280
2281 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
2282
2283         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
2284         https://bugs.webkit.org/show_bug.cgi?id=131472
2285
2286         Reviewed by Philippe Normand.
2287
2288         * Scripts/webkitpy/port/gtk.py:
2289         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
2290         when running WebKitTestRunner with run-webkit-tests.
2291         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
2292         installed.
2293         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
2294         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
2295         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
2296         deal.
2297
2298 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
2299
2300         DownloadDecideDestinationCrash API test uses an incorrect value for path
2301         https://bugs.webkit.org/show_bug.cgi?id=131845
2302         <rdar://problem/15925560>
2303
2304         Reviewed by Enrica Casucci.
2305
2306         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2307         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
2308
2309 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
2310
2311         [Mac] AttributedStringTest API tests fail with async text input
2312         https://bugs.webkit.org/show_bug.cgi?id=131833
2313
2314         Reviewed by Enrica Casucci.
2315
2316         Don't run sync NSTextInputClient tests where we don't implement these calls.
2317
2318         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2319         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
2320         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
2321         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
2322         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
2323         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
2324         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
2325
2326 2014-04-18  Philippe Normand  <pnormand@igalia.com>
2327
2328         Remove NETWORK_INFO support
2329         https://bugs.webkit.org/show_bug.cgi?id=131841
2330
2331         Reviewed by Gyuyoung Kim.
2332
2333         * Scripts/webkitperl/FeatureList.pm:
2334
2335 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
2336
2337         [GTK] YouCompleteMe doesn't work for cmake build system.
2338         https://bugs.webkit.org/show_bug.cgi?id=131591
2339
2340         Reviewed by Martin Robinson.
2341
2342         Add cmake build system support for YouCompleteMe. It should work regardless of
2343         using make or ninja. In addition, autotools related code is removed since it's
2344         not used anymore in WebKit.
2345
2346         * Scripts/webkitdirs.pm:
2347         (generateBuildSystemFromCMakeProject):
2348         * gtk/ycm_extra_conf.py:
2349         (transform_relative_paths_to_absolute_paths):
2350         (FlagsForFile):
2351
2352 2014-04-17  Anders Carlsson  <andersca@apple.com>
2353
2354         Fix build.
2355
2356         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2357         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2358         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2359
2360 2014-04-17  Anders Carlsson  <andersca@apple.com>
2361
2362         Remove unused API enums
2363         https://bugs.webkit.org/show_bug.cgi?id=131836
2364
2365         Reviewed by Tim Horton.
2366
2367         * MiniBrowser/mac/WK2BrowserWindowController.m:
2368         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2369
2370 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
2371
2372         [Win] A few final cleanups to the DataObject classes.
2373         https://bugs.webkit.org/show_bug.cgi?id=131784
2374
2375         Reviewed by Anders Carlsson.
2376
2377         * DumpRenderTree/win/DRTDataObject.cpp:
2378         (DRTDataObject::clearData): Use 'last()' method.
2379         * DumpRenderTree/win/UIDelegate.cpp:
2380         (DRTUndoStack::pop): Use 'takeLast()' method.
2381
2382 2014-04-17  Andres Gomez  <agomez@igalia.com>
2383
2384         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
2385         https://bugs.webkit.org/show_bug.cgi?id=131365
2386
2387         Reviewed by Brent Fulgham.
2388
2389         The cygwin installer is now downloading the wanted versions for
2390         the local installation given to the setup wizard.
2391
2392         * CygwinDownloader/cygwin-downloader.py:
2393         * CygwinDownloader/cygwin-downloader.zip:
2394
2395 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
2396
2397         [GTK] Make run-webkit-tests always use WKTR
2398         https://bugs.webkit.org/show_bug.cgi?id=131737
2399
2400         Reviewed by Darin Adler.
2401
2402         Now that the GTK+ port only has support for WebKit2, instruct
2403         run-webkit-tests to always use WKTR. This avoids needing to pass
2404         flag "-2" every time.
2405
2406         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
2407         (_set_up_derived_options): Always set webkit_test_runner when
2408         the platform is GTK+.
2409
2410 2014-04-17  Brendan Long  <b.long@cablelabs.com>
2411
2412         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
2413         https://bugs.webkit.org/show_bug.cgi?id=131760
2414
2415         Reviewed by Philippe Normand.
2416
2417         * gtk/install-dependencies: Install ninja-build when it's available.
2418
2419 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
2420
2421         [Win] run-javascriptcore-tests fails to run.
2422         https://bugs.webkit.org/show_bug.cgi?id=131761
2423
2424         Reviewed by Brent Fulgham.
2425
2426         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
2427
2428 2014-04-16  Andres Gomez  <agomez@igalia.com>
2429
2430         [Win] Pass default parameters to cygwin setup wizard
2431         https://bugs.webkit.org/show_bug.cgi?id=131361
2432
2433         Reviewed by Brent Fulgham.
2434
2435         Added some parameters to the cygwin setup wizard so the user
2436         doesn't really have to do any interaction.
2437
2438         * CygwinDownloader/cygwin-downloader.py:
2439         * CygwinDownloader/cygwin-downloader.zip:
2440
2441 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
2442
2443         [Win] Eliminate use of deleteAllValues in Windows Files
2444         https://bugs.webkit.org/show_bug.cgi?id=131631
2445
2446         Reviewed by Darin Adler.
2447
2448         Switch to std::unique_ptr for memory lifetime. Get rid of
2449         deleteAllValues now that it is no longer needed. Use ranged
2450         for loops where possible.
2451
2452         * DumpRenderTree/win/DRTDataObject.cpp:
2453         (WCEnumFormatEtc::WCEnumFormatEtc):
2454         (DRTDataObject::~DRTDataObject):
2455         (DRTDataObject::GetData):
2456         (DRTDataObject::QueryGetData):
2457         (DRTDataObject::SetData):
2458         (DRTDataObject::clearData):
2459         * DumpRenderTree/win/DRTDataObject.h:
2460         * DumpRenderTree/win/UIDelegate.cpp:
2461         (DRTUndoObject::DRTUndoObject):
2462         (DRTUndoObject::~DRTUndoObject):
2463         (DRTUndoStack::~DRTUndoStack):
2464         (DRTUndoStack::clear):
2465         (DRTUndoStack::pop):
2466         (DRTUndoManager::DRTUndoManager):
2467         (DRTUndoManager::redo):
2468         (DRTUndoManager::undo):
2469         (UIDelegate::UIDelegate):
2470         (UIDelegate::resetUndoManager):
2471         * DumpRenderTree/win/UIDelegate.h:
2472
2473 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2474
2475         [GTK] Unreviewed GTK gardening.
2476
2477         Update list of skipped unit tests:
2478
2479           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
2480
2481           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
2482           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
2483
2484         * Scripts/run-gtk-tests:
2485         (TestRunner):
2486
2487 2014-04-16  Tim Horton  <timothy_horton@apple.com>
2488
2489         check-webkit-style doesn't check code style in .mm or .m files
2490         https://bugs.webkit.org/show_bug.cgi?id=131708
2491
2492         Reviewed by Darin Adler.
2493
2494         * Scripts/webkitpy/style/checker.py:
2495         * Scripts/webkitpy/style/checker_unittest.py:
2496         (CheckerDispatcherDispatchTest.test_cpp_paths):
2497         (CheckerDispatcherDispatchTest.test_text_paths):
2498         Check .mm and .m files as C++.
2499
2500         * Scripts/webkitpy/style/checkers/cpp.py:
2501         (check_spacing):
2502         Add an override for our ordinary "missing spaces around =" for @synthesize,
2503         which should look like "@synthesize propertyName=_varName;"
2504
2505         Add an override for "missing space before {" for blocks' "^{".
2506
2507         Don't follow the "extra space before [" rule for Objective-C, because
2508         it breaks this rule in a multitude of ways because of method calls.
2509
2510         (check_braces):
2511         Don't complain about { not being on the end of the previous line if
2512         the previous line starts with "- (" or "+ (", which would indicate a
2513         Objective-C method definition.
2514
2515 2014-04-16  Darin Adler  <darin@apple.com>
2516
2517         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
2518         https://bugs.webkit.org/show_bug.cgi?id=131735
2519
2520         Reviewed by Alexey Proskuryakov.
2521
2522         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
2523         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
2524         is on the right. This can be confusing since our JavaScript test framework does it the opposite
2525         way, but gtest works better this way.
2526
2527 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
2528
2529         [EFL] Fix problems with the pixel dump.
2530         https://bugs.webkit.org/show_bug.cgi?id=131265
2531
2532         Reviewed by Gyuyoung Kim.
2533
2534         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
2535         However pixel dump codes still call deprecated functions like ewk_view_paint(),
2536         which causes that nothing is drawn.
2537
2538         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
2539         One of new functions is AcceleratedCompositingContext::extractImageData(),
2540         which replaces deprecated function calls. Besides the extractImageData() is invoked by
2541         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
2542
2543         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2544         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
2545
2546 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
2547
2548         Update LLVM export scrpt to handle the build directory being different from the
2549         source directory.
2550
2551         Rubber stamped by Geoffrey Garen.
2552
2553         * Scripts/export-llvm-build:
2554
2555 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
2556
2557         Update the hyperlink to waterfall views of perf bots on build.webkit.org
2558         https://bugs.webkit.org/show_bug.cgi?id=131695
2559
2560         Reviewed by Antti Koivisto.
2561
2562         Updated.
2563
2564         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2565
2566 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2567
2568         [GTK] Reduce the binary size by compressing the text based web inspector resources
2569         https://bugs.webkit.org/show_bug.cgi?id=121545
2570
2571         Reviewed by Gustavo Noronha Silva.
2572
2573         Compress text based files when compiling inspector resources. It
2574         reduces the binary size in 3MB.
2575
2576         * gtk/generate-inspector-gresource-manifest.py:
2577         (find_all_files_in_directory):
2578         (is_compressible):
2579
2580 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2581
2582         Remove Gtk WebKit1 tester.
2583
2584         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
2585         results over and over as fast as it could.
2586
2587         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2588         (WebKitBuildbot):
2589
2590 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2591
2592         Wrong link for webkitpy tests results in dashboard popover
2593         https://bugs.webkit.org/show_bug.cgi?id=131664
2594
2595         Reviewed by Timothy Hatcher.
2596
2597         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2598         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2599         Use a correct link.
2600
2601 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2602
2603         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
2604
2605         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
2606
2607         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2608         (CommitMessageForThisCommitTest):
2609
2610 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2611
2612         Fix commit-log-editor bug revealed by r165447
2613         https://bugs.webkit.org/show_bug.cgi?id=130676
2614
2615         Reviewed by Csaba Osztrogonác.
2616
2617         * Scripts/commit-log-editor:
2618         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
2619         Add \n before the first block too, because the longest common prefix now ends with only one newline.
2620         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
2621         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
2622
2623 2014-04-13  Darin Adler  <darin@apple.com>
2624
2625         userVisibleString should not try to "encode" host names
2626         https://bugs.webkit.org/show_bug.cgi?id=131587
2627         rdar://problem/14686849
2628
2629         Reviewed by Alexey Proskuryakov.
2630
2631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
2632
2633         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
2634         Coverage is tiny at this point; we could add a lot more cases!
2635
2636 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
2637
2638         Use #include instead of #import
2639         https://bugs.webkit.org/show_bug.cgi?id=131604
2640
2641         Reviewed by Darin Adler.
2642
2643         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
2644
2645         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2646
2647 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
2648
2649         Make slow-stress tests run faster by running fewer VM variants.
2650
2651         Rubber stamped by Geoffrey Garen.
2652
2653         * Scripts/run-javascriptcore-tests:
2654         * Scripts/run-jsc-stress-tests:
2655
2656 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
2657
2658         [CMake] Add missing WTF unit tests
2659         https://bugs.webkit.org/show_bug.cgi?id=131459
2660
2661         Reviewed by Martin Robinson.
2662
2663         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
2664         that should be compiled into the TestWTF binary.
2665
2666 2014-04-10  Brendan Long  <b.long@cablelabs.com>
2667
2668         [Gtk] run-launcher doesn't work by default
2669         https://bugs.webkit.org/show_bug.cgi?id=131494
2670
2671         Reviewed by Philippe Normand.
2672
2673         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
2674         * Scripts/webkitdirs.pm:
2675         (launcherName): Same.
2676         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
2677         * gtk/common.py:
2678         (get_build_path.is_valid_build_directory): Same.
2679         * gtk/manifest.txt: Same.
2680
2681 2014-04-09  Commit Queue  <commit-queue@webkit.org>
2682
2683         Unreviewed, rolling out r167046.
2684         https://bugs.webkit.org/show_bug.cgi?id=131479
2685
2686         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
2687         on #webkit).
2688
2689         Reverted changeset:
2690
2691         "Remove "System Font" from whitelisted DRT fonts and char
2692         width calculations"
2693         https://bugs.webkit.org/show_bug.cgi?id=131411
2694         http://trac.webkit.org/changeset/167046
2695
2696 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2697
2698         Remove "System Font" from whitelisted DRT fonts and char width calculations
2699         https://bugs.webkit.org/show_bug.cgi?id=131411
2700
2701         Reviewed by Tim Horton.
2702
2703         Covered by existing tests.
2704
2705         * DumpRenderTree/mac/DumpRenderTree.mm:
2706         (allowedFontFamilySet):
2707
2708 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2709
2710         systemHiddenFontFamilySet in DRT is unnecessary
2711         https://bugs.webkit.org/show_bug.cgi?id=131414
2712
2713         Reviewed by Tim Horton.
2714
2715         It doesn't seem to affect test results on my machine.
2716
2717         * DumpRenderTree/mac/DumpRenderTree.mm:
2718         (drt_NSFontManager_availableFonts):
2719         (systemHiddenFontFamilySet): Deleted.
2720
2721 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
2722
2723         [Win] Unreviewed test fix: Don't double-release BSTR.
2724
2725         * DumpRenderTree/win/DumpRenderTree.cpp:
2726         (dump): Remove unneeded call to SysFreeString now that we are
2727         using _bstr_t for this variable.
2728
2729 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
2730
2731         [Win] Various DumpRenderTree Fixes.
2732         https://bugs.webkit.org/show_bug.cgi?id=131446.
2733
2734         Reviewed by Tim Horton.
2735
2736         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2737         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2738         (AccessibilityUIElement::description): Ditto.
2739         (AccessibilityUIElement::helpText): Ditto.
2740         (AccessibilityUIElement::intValue): Ditto.
2741         (AccessibilityUIElement::isPressActionSupported): Ditto.
2742         (AccessibilityUIElement::accessibilityValue): Ditto.
2743         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2744         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2745         (DRTDesktopNotificationPresenter::AddRef): Ditto.
2746         (DRTDesktopNotificationPresenter::Release): Ditto.
2747         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2748         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
2749         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
2750         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
2751         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
2752         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2753         * DumpRenderTree/win/DumpRenderTree.cpp:
2754         (dumpFrameScrollPosition): Ditto.
2755         (dumpFramesAsText): Ditto.
2756         (compareHistoryItems): Ditto.
2757         (dumpHistoryItem): Ditto.
2758         (dump): Ditto.
2759         (resetDefaultsToConsistentValues): Ditto.
2760         (resetWebViewToConsistentStateBeforeTesting): Ditto.
2761         (runTest): Ditto.
2762         (createWebViewAndOffscreenWindow): Ditto.
2763         * DumpRenderTree/win/EditingDelegate.cpp:
2764         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2765         (EditingDelegate::AddRef): Ditto.
2766         (EditingDelegate::Release): Ditto.
2767         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
2768         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
2769         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2770         (EditingDelegate::shouldInsertNode): Ditto.
2771         (EditingDelegate::shouldInsertText): Ditto.
2772         (EditingDelegate::shouldDeleteDOMRange): Ditto.
2773         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2774         (EditingDelegate::shouldApplyStyle): Ditto.
2775         (EditingDelegate::shouldChangeTypingStyle): Ditto.
2776         (EditingDelegate::doPlatformCommand): Ditto.
2777         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2778         (EditingDelegate::webViewDidChange): Ditto.
2779         (EditingDelegate::webViewDidEndEditing): Ditto.
2780         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
2781         (EditingDelegate::webViewDidChangeSelection): Ditto.
2782         (EditingDelegate::checkSpellingOfString): Ditto.
2783         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2784         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2785         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
2786         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2787         (FrameLoadDelegate::AddRef): Ditto.
2788         (FrameLoadDelegate::Release): Ditto.
2789         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2790         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
2791         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
2792         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
2793         (FrameLoadDelegate::didReceiveTitle): Ditto.
2794         (FrameLoadDelegate::didChangeIcons): Ditto.
2795         (delegatesWithDelayedWork): Ditto.
2796         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
2797         (FrameLoadDelegate::didFailLoadWithError): Ditto.
2798         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
2799         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
2800         (FrameLoadDelegate::willCloseFrame): Ditto.
2801         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
2802         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
2803         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2804         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
2805         (FrameLoadDelegate::didRunInsecureContent): Ditto.
2806         * DumpRenderTree/win/FrameLoadDelegate.h:
2807         * DumpRenderTree/win/HistoryDelegate.cpp:
2808         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2809         (HistoryDelegate::updateHistoryTitle): Ditto.
2810         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
2811         * DumpRenderTree/win/PolicyDelegate.cpp:
2812         (dumpPath):
2813         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2814         (PolicyDelegate::AddRef): Ditto.
2815         (PolicyDelegate::Release): Ditto.
2816         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2817         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
2818         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2819         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2820         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2821         (ResourceLoadDelegate::AddRef): Ditto.
2822         (ResourceLoadDelegate::Release): Ditto.
2823         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2824         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
2825         (ResourceLoadDelegate::willSendRequest): Ditto.
2826         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
2827         (ResourceLoadDelegate::didReceiveResponse): Ditto.
2828         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
2829         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
2830         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2831         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2832         (TestRunner::setUserStyleSheetLocation): Ditto.
2833         (TestRunner::execCommand): Ditto.
2834         (TestRunner::overridePreference): Ditto.
2835         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
2836         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
2837         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2838         (TextInputController::insertText): Ditto.
2839         * DumpRenderTree/win/UIDelegate.cpp:
2840         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2841         (UIDelegate::AddRef): Ditto.
2842         (UIDelegate::Release): Ditto.
2843         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2844         (UIDelegate::trackCustomPopupMenu): Ditto.
2845         (UIDelegate::registerUndoWithTarget): Ditto.
2846         (UIDelegate::removeAllActionsWithTarget): Ditto.
2847         (UIDelegate::setActionTitle): Ditto.
2848         (UIDelegate::undo): Ditto.
2849         (UIDelegate::redo): Ditto.
2850         (UIDelegate::canUndo): Ditto.
2851         (UIDelegate::canRedo): Ditto.
2852         (UIDelegate::printFrame): Ditto.
2853         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
2854         (UIDelegate::webViewHeaderHeight): Ditto.
2855         (UIDelegate::webViewFooterHeight): Ditto.
2856         (UIDelegate::drawHeaderInRect): Ditto.
2857         (UIDelegate::drawFooterInRect): Ditto.
2858         (UIDelegate::webViewPrintingMarginRect): Ditto.
2859         (UIDelegate::canRunModal): Ditto.
2860         (UIDelegate::createModalDialog): Ditto.
2861         (UIDelegate::runModal): Ditto.
2862         (UIDelegate::isMenuBarVisible): Ditto.
2863         (UIDelegate::setMenuBarVisible): Ditto.
2864         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
2865         (UIDelegate::paintCustomScrollbar): Ditto.
2866         (UIDelegate::paintCustomScrollCorner): Ditto.
2867         (UIDelegate::setFrame): Ditto.
2868         (UIDelegate::webViewFrame): Ditto.
2869         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
2870         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2871         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2872         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2873         (UIDelegate::webViewAddMessageToConsole): Ditto.
2874         (UIDelegate::doDragDrop): Ditto.
2875         (UIDelegate::webViewGetDlgCode): Ditto.
2876         (UIDelegate::createWebViewWithRequest): Ditto.
2877         (UIDelegate::webViewClose): Ditto.
2878         (UIDelegate::webViewFocus): Ditto.
2879         (UIDelegate::webViewUnfocus): Ditto.
2880         (UIDelegate::webViewPainted): Ditto.
2881         (UIDelegate::exceededDatabaseQuota): Ditto.
2882         (UIDelegate::embeddedViewWithArguments): Ditto.
2883         (UIDelegate::webViewClosing): Ditto.
2884         (UIDelegate::webViewSetCursor): Ditto.
2885         (UIDelegate::webViewDidInvalidate): Ditto.
2886         (UIDelegate::setStatusText): Ditto.
2887         (UIDelegate::desktopNotificationsDelegate): Ditto.
2888         (UIDelegate::drawBackground): Ditto.
2889         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
2890         (UIDelegate::didPressMissingPluginButton): Ditto.
2891         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
2892         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
2893         (LoadHTMLStringItem::invoke): Ditto.
2894         (ScriptItem::invoke): Ditto.
2895
2896 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
2897
2898         Stylechecker: False positive on inline asm code.
2899         https://bugs.webkit.org/show_bug.cgi?id=130570
2900
2901         Reviewed by Csaba Osztrogonác.
2902
2903         Disable stylechecking in asm blocks.
2904
2905         * Scripts/webkitpy/style/checkers/cpp.py:
2906         (process_line):
2907         (_InlineASMState):
2908         (_InlineASMState.__init__):
2909         (_InlineASMState.process_line):
2910         (_InlineASMState.isInside):
2911         (_process_lines):
2912         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2913         (WebKitStyleTest.test_member_initialization_list):
2914
2915 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2916
2917         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
2918         https://bugs.webkit.org/show_bug.cgi?id=131029
2919
2920         Reviewed by Philippe Normand.
2921
2922         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
2923         tests and remove the getWebKit1TestResoucesDir() method.
2924
2925         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2926         (testDownloadLocalFile): Use Test::getResourcesDir().
2927         (testDownloadLocalFileError): Ditto.
2928         (serverCallback): Ditto.
2929         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2930         (serverCallback): Ditto.
2931         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2932         (httpServerCallback): Ditto.
2933         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2934         (serverCallback): Ditto.
2935         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
2936         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
2937         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2938         (Test::getWebKit1TestResoucesDir): Deleted.
2939
2940 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
2941
2942         [WK2] HTTP authentication regression tests fail
2943         https://bugs.webkit.org/show_bug.cgi?id=81627
2944         <rdar://problem/11079296>
2945
2946         Reviewed by Anders Carlsson.
2947
2948         * WebKitTestRunner/TestController.h:
2949         * WebKitTestRunner/TestController.cpp:
2950         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
2951         to pageLoaderClient structure.
2952         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
2953         for password based authentication (we do get server trust challenges on some tests,
2954         which WKTR can't handle).
2955         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
2956         calls won't be made, at least on CFNetwork based platforms.
2957         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
2958         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
2959         make sense to associate auth requests with individual resources - there can be
2960         multiple resources loading at once from the same protection space, so WebKit1 API
2961         that had a resource identifier was inherently racy.
2962
2963 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
2964
2965         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
2966         https://bugs.webkit.org/show_bug.cgi?id=131427
2967
2968         Reviewed by Gyuyoung Kim.
2969
2970         Since r166973, font path was changed.
2971
2972         * DumpRenderTree/PlatformEfl.cmake:
2973         * WebKitTestRunner/PlatformEfl.cmake:
2974
2975 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
2976
2977         Fix the build-jsc build
2978         https://bugs.webkit.org/show_bug.cgi?id=131410
2979
2980         Reviewed by Michael Saboff.
2981
2982         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
2983         WTF depends on it.
2984
2985 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
2986
2987         [GTK] Remove WebKit1 unit tests
2988         https://bugs.webkit.org/show_bug.cgi?id=131359
2989
2990         Reviewed by Anders Carlsson.
2991
2992         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
2993         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
2994         they were inadvertently left in http://trac.webkit.org/changeset/166504.
2995
2996         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
2997         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
2998         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
2999         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
3000         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
3001         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
3002         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
3003         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
3004         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
3005         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
3006         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
3007         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
3008         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
3009         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
3010         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
3011         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
3012         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
3013         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
3014         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
3015         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
3016         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
3017         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
3018         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
3019         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
3020         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
3021         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
3022         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
3023         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
3024         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
3025         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
3026         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
3027         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
3028         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
3029         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
3030         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
3031         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
3032         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
3033         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
3034
3035 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3036
3037         Unreviewed gardening (Take 2): Prevent users from attempting
3038         to build with known invalid cURL. 
3039
3040         * Scripts/webkitdirs.pm:
3041         (checkInstalledTools): Check for 7.34.0 (the broken version), not
3042         7.33.0 (the known good version).
3043
3044 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3045
3046         [GTK] Remove DumpRenderTree and GtkLauncher
3047         https://bugs.webkit.org/show_bug.cgi?id=131373
3048
3049         Reviewed by Andreas Kling.
3050
3051         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
3052         no longer necessary now that WebKit1 GTK+ will be removed.
3053
3054         * CMakeLists.txt:
3055         * DumpRenderTree/PlatformGTK.cmake: Removed.
3056         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
3057         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
3058         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
3059         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
3060         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
3061         * DumpRenderTree/gtk/EventSender.cpp: Removed.
3062         * DumpRenderTree/gtk/EventSender.h: Removed.
3063         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
3064         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
3065         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
3066         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
3067         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
3068         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
3069         * DumpRenderTree/gtk/TextInputController.h: Removed.
3070         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
3071         * GtkLauncher/CMakeLists.txt: Removed.
3072         * GtkLauncher/LauncherInspectorWindow.c: Removed.
3073         * GtkLauncher/LauncherInspectorWindow.h: Removed.
3074         * GtkLauncher/main.c: Removed.
3075         * GtkLauncher/simple.svg: Removed.
3076         * GtkLauncher/text.html: Removed.
3077         * WebKitTestRunner/PlatformGTK.cmake:
3078         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
3079         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
3080         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
3081
3082 2014-04-08  Mark Rowe  <mrowe@apple.com>
3083
3084         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
3085         <https://webkit.org/b/131388> / <rdar://problem/16291687>
3086
3087         Reviewed by Alexey Proskuryakov.
3088
3089         * Scripts/webkitdirs.pm:
3090         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
3091         (execMacWebKitAppForDebugging): Ditto.
3092
3093 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3094
3095         Build bmalloc on iOS too
3096         https://bugs.webkit.org/show_bug.cgi?id=131381
3097
3098         Reviewed by Andreas Kling.
3099
3100         * Scripts/build-webkit:
3101
3102 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3103
3104         Unreviewed gardening: Prevent users from attempting
3105         to build with known invalid cURL.
3106
3107         * Scripts/webkitdirs.pm:
3108         (checkInstalledTools): Block build attempts with bad
3109         Cygwin tool set.
3110
3111 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
3112
3113         Build bmalloc on Mac
3114         https://bugs.webkit.org/show_bug.cgi?id=131333
3115
3116         Reviewed by Mark Rowe.
3117
3118         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
3119         (Note: Just testing Mac is not good enough because in this
3120         script 'Mac' means 'Mac or iOS'.)
3121
3122 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
3123
3124         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
3125         https://bugs.webkit.org/show_bug.cgi?id=130951
3126
3127         Reviewed by Geoffrey Garen.
3128
3129         * Scripts/run-javascriptcore-tests:
3130
3131 2014-04-06  Darin Adler  <darin@apple.com>
3132
3133         Rework CSS calc logic, fixing some reference count mistakes in Length
3134         https://bugs.webkit.org/show_bug.cgi?id=131280
3135
3136         Reviewed by Andreas Kling.
3137
3138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
3139         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
3140
3141 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
3142
3143         Enable WEB_REPLAY for PLATFORM(MAC)
3144         https://bugs.webkit.org/show_bug.cgi?id=130700
3145
3146         Reviewed by Timothy Hatcher.
3147
3148         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
3149
3150 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3151
3152         [CMake] Include X11's include dirs in TestNetscapePlugin
3153         https://bugs.webkit.org/show_bug.cgi?id=131270
3154
3155         Reviewed by Martin Robinson.
3156
3157         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
3158         TestNetscapePlugin includes WebCore code that includes X headers.
3159
3160 2014-04-05  David Kilzer  <ddkilzer@apple.com>
3161
3162         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
3163         <http://webkit.org/b/130986>
3164
3165         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
3166         prefix to TileCache class names in exception list.
3167
3168 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3169
3170         [GTK] kill-old-processes should kill dbus-daemon processes
3171         https://bugs.webkit.org/show_bug.cgi?id=127352
3172
3173         Reviewed by Martin Robinson.
3174
3175         * BuildSlaveSupport/kill-old-processes:
3176         (main):
3177
3178 2014-04-04  Andres Gomez  <agomez@igalia.com>
3179
3180         [Win] Update obsolete packages in cygwin
3181         https://bugs.webkit.org/show_bug.cgi?id=126264
3182
3183         Reviewed by Brent Fulgham.
3184
3185         Removed "apache" and "minires" as the first has been replaced by
3186         "lighttpd" and the second is now integrated into
3187         "cygwin". Replaced the transitional and now obsolete "gcc" package
3188         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
3189         since the newer version available is "2.7.3" which breaks the
3190         build due to some funniness with environment variable handling.
3191
3192         * CygwinDownloader/cygwin-downloader.py:
3193         * CygwinDownloader/cygwin-downloader.zip:
3194
3195 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
3196
3197         check-webkit-style: Improve warnings on Objective-C @property syntax
3198         https://bugs.webkit.org/show_bug.cgi?id=131200
3199
3200         Reviewed by Dan Bernstein.
3201
3202         * Scripts/webkitpy/style/checkers/cpp.py:
3203         (check_spacing):
3204         (CppChecker):
3205         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3206         (CppStyleTest.test_spacing_in_objective_c_properties):
3207
3208 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3209
3210         Unreviewed. Moving my name to commiter section
3211
3212         * Scripts/webkitpy/common/config/contributors.json:
3213
3214 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3215
3216         Unreviewed. Add myself as a committer.
3217
3218         * Scripts/webkitpy/common/config/contributors.json:
3219
3220 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
3221
3222         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
3223         https://bugs.webkit.org/show_bug.cgi?id=130391
3224
3225         Reviewed by Gyuyoung Kim.
3226
3227         Change the implementation of the zoom functionality from ewk_view_scale_set
3228         to ewk_view_page_zoom_set.
3229
3230         * MiniBrowser/efl/main.c:
3231
3232 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
3233
3234         [webkitpy] perf profiler does not understand --call-graph argument
3235         https://bugs.webkit.org/show_bug.cgi?id=131132
3236
3237         Reviewed by Ryosuke Niwa.
3238
3239         New versions of perf profiler have changed the argument from --call-graph to -g.
3240
3241         * Scripts/webkitpy/common/system/profiler.py:
3242         (Perf.wrapper_arguments): Use -g instead of --call-graph.
3243         * Scripts/webkitpy/port/driver_unittest.py:
3244         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
3245
3246 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3247
3248         Add EFL WK2 performance bot to build.webkit.org
3249         https://bugs.webkit.org/show_bug.cgi?id=131034
3250
3251         Fix after r166707, use "Perf" instead of "perf" for consistency.
3252
3253         Reviewed by Csaba Osztrogonác.
3254
3255         * BuildSlaveSupport/build.webkit.org-config/config.json:
3256
3257 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3258
3259         Add EFL WK2 performance bot to build.webkit.org
3260         https://bugs.webkit.org/show_bug.cgi?id=131034
3261
3262         Reviewed by Csaba Osztrogonác.
3263
3264         * BuildSlaveSupport/build.webkit.org-config/config.json:
3265
3266 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
3267
3268         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
3269         https://bugs.webkit.org/show_bug.cgi?id=131151
3270
3271         Reviewed by Gyuyoung Kim.
3272
3273         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
3274         (TouchEventInfo::TouchEventInfo):
3275         (sendTouchEvent):
3276         (addTouchPointCallback):
3277         (updateTouchPointCallback):
3278         (cancelTouchPointCallback):
3279         (releaseTouchPointCallback):
3280
3281 2014-04-02  David Kilzer  <ddkilzer@apple.com>
3282
3283         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
3284         <http://webkit.org/b/131045>
3285
3286         Reviewed by Daniel Bates.
3287
3288         * Scripts/filter-build-webkit:
3289         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
3290         of clang, plus debug data for all DVTAssertions.
3291
3292 2014-04-01  Dean Jackson  <dino@apple.com>
3293
3294         Load Media Controls js/css from bundle
3295         https://bugs.webkit.org/show_bug.cgi?id=131086
3296
3297         Reviewed by Eric Carlson.
3298
3299         We're now putting CSS files into the bundle, so remove the test for them.
3300
3301         * Scripts/check-for-inappropriate-files-in-framework:
3302
3303 2014-04-02  Martin Hock  <mhock@apple.com>
3304
3305         Unify private browsing with sessions.
3306         https://bugs.webkit.org/show_bug.cgi?id=130099
3307
3308         Reviewed by Alexey Proskuryakov.
3309
3310         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
3311         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3312         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
3313         (TestWebKitAPI::didNavigateWithNavigationData):
3314         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3315         (TestWebKitAPI::TEST):
3316
3317         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
3318         (TestWebKitAPI::didNavigateWithoutNavigationData):
3319         (TestWebKitAPI::didNavigateWithNavigationData):
3320         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3321         (TestWebKitAPI::TEST):
3322
3323 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
3324
3325         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
3326         https://bugs.webkit.org/show_bug.cgi?id=130343
3327
3328         Reviewed by Gustavo Noronha Silva.
3329
3330         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
3331         of directories on the command line and look for all appropriate files in those directories for the
3332         GResource archive. Also make archive paths relative to those directories.
3333         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
3334         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
3335
3336 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3337
3338         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
3339         https://bugs.webkit.org/show_bug.cgi?id=131106
3340
3341         Reviewed by Csaba Osztrogonác.
3342
3343         * Scripts/webkitpy/tool/commands/download.py:
3344         (AbstractRolloutPrepCommand._prepare_state):
3345         * Scripts/webkitpy/tool/commands/download_unittest.py:
3346         (test_prepare_rollout):
3347         (test_create_rollout):
3348         (test_create_rollout_resolved):
3349         (test_rollout):
3350
3351 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
3352
3353         [EFL] Add option to use separate web process for new window in MiniBrowser
3354         https://bugs.webkit.org/show_bug.cgi?id=130190
3355
3356         Reviewed by Gyuyoung Kim.
3357
3358         New created window (CTRL + n) will be open in separated web process.
3359         This option is enabled by adding a flag (S/separate-process) with launching
3360         MiniBrowser.
3361
3362         * MiniBrowser/efl/main.c:
3363         (elm_main):
3364
3365 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3366
3367         [GTK] Move NEWS file to a new location
3368         https://bugs.webkit.org/show_bug.cgi?id=130901
3369
3370         Reviewed by Brent Fulgham.
3371
3372         * gtk/manifest.txt: Update the NEWS file path.
3373
3374 2014-04-01  Anders Carlsson  <andersca@apple.com>
3375
3376         Fix build.
3377
3378         * MiniBrowser/mac/WK2BrowserWindowController.m:
3379         (-[WK2BrowserWindowController awakeFromNib]):
3380         (-[WK2BrowserWindowController dealloc]):
3381         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3382
3383 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
3384
3385         Unreviewed test gardening.
3386
3387         * Scripts/webkitpy/port/base_unittest.py:
3388         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
3389
3390 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
3391
3392         [CSS Exclusions] Remove exclusions parsing support
3393         https://bugs.webkit.org/show_bug.cgi?id=131046
3394
3395         Reviewed by David Hyatt.
3396
3397         * Scripts/webkitperl/FeatureList.pm:
3398
3399 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
3400
3401         [GTK] Remove last reference to GTK+ WK1 EWS
3402         https://bugs.webkit.org/show_bug.cgi?id=131058
3403
3404         Reviewed by Martin Robinson.
3405
3406         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
3407
3408         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
3409
3410 2014-04-01  Lucas Forschler  <lforschler@apple.com>
3411
3412         Add a 32bit JSC builder/tester.
3413         https://bugs.webkit.org/show_bug.cgi?id=131054
3414         
3415         Reviewed by Michael Saboff.
3416
3417         * BuildSlaveSupport/build.webkit.org-config/config.json:
3418         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3419         (Compile32bitJSC):
3420         (Run32bitJSCTests):
3421         (Run32bitJSCTests.countFailures):
3422         (BuildAndTest32bitJSCFactory):
3423         (BuildAndTest32bitJSCFactory.__init__):
3424
3425 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
3426
3427         [GTK] No longer build WebKit1 gtkdoc
3428         https://bugs.webkit.org/show_bug.cgi?id=130970
3429
3430         Reviewed by Anders Carlsson.
3431
3432         * gtk/common.py:
3433         (gtk_version_of_pkg_config_file): Deleted.
3434         * gtk/generate-gtkdoc:
3435         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
3436         was only applicable for WebKit1.
3437         (get_generator_for_config): No longer look for the WebKit1 configuration file.
3438
3439 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
3440
3441         [GTK] Running minibrowser with url crashes in debug build
3442         https://bugs.webkit.org/show_bug.cgi?id=130492
3443
3444         Reviewed by Martin Robinson.
3445
3446         Update "uri-scheme" test not to use invalid URIs in it, so we
3447         don't get a mistmatch when comparing the original URI stored in
3448         the test class with the one returned by the WebKitWebView.
3449
3450         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3451         (testWebContextURIScheme): Update the test.
3452
3453 2014-04-01  Mihai Tica  <mitica@adobe.com>
3454
3455         Unreviewed: Add myself as a commiter to the contributors list.
3456
3457         * Scripts/webkitpy/common/config/contributors.json:
3458
3459 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3460
3461         [EFL][WK2] Extract the control of page background out of color_set
3462         https://bugs.webkit.org/show_bug.cgi?id=127539
3463
3464         Reviewed by Gyuyoung Kim.
3465
3466         Added an option(C) to change background color.
3467
3468         * MiniBrowser/efl/main.c:
3469         (window_create):
3470         (elm_main):
3471
3472 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3473
3474         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
3475
3476         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
3477
3478 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3479
3480         Unreviewed test correction after r166530.
3481
3482         * DumpRenderTree/mac/DumpRenderTree.mm:
3483         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
3484         fine-grained setting for swipe tests. This prevents existing tests from breaking.
3485
3486 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3487
3488         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
3489         https://bugs.webkit.org/show_bug.cgi?id=130987
3490
3491         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
3492         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
3493
3494         Reviewed by Martin Robinson.
3495
3496         * BuildSlaveSupport/build.webkit.org-config/config.json:
3497
3498 2014-03-31  Dean Jackson  <dino@apple.com>
3499
3500         Remove WEB_ANIMATIONS
3501         https://bugs.webkit.org/show_bug.cgi?id=130989
3502
3503         Reviewed by Simon Fraser.
3504
3505         Remove this feature flag until we plan to implement.
3506
3507         * Scripts/webkitperl/FeatureList.pm:
3508
3509 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3510
3511         Reduced Latched Scroll Test Flakiness
3512         https://bugs.webkit.org/show_bug.cgi?id=130983
3513
3514         Reviewed by Darin Adler.
3515
3516         * DumpRenderTree/mac/DumpRenderTree.mm:
3517         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
3518         * DumpRenderTree/mac/EventSendingController.mm:
3519         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
3520         with high resolution flags turned on.
3521         * WebKitTestRunner/mac/EventSenderProxy.mm:
3522         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
3523
3524 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3525
3526         run-webkit-tests should have a --no-timeout option
3527         https://bugs.webkit.org/show_bug.cgi?id=128286
3528
3529         Reviewed by Joseph Pecoraro.
3530
3531         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3532         (Worker._run_test): Renaming _run_test_with_timeout()
3533         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
3534         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
3535         (Worker._run_test_in_this_thread):
3536         (Worker._run_test_with_timeout): Deleted.
3537         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3538         (parse_args): Added the --no-timeout option
3539
3540 2014-03-31  Samuel White  <samuel_white@apple.com>
3541
3542         AX: Need ability to get line range for text marker.
3543         https://bugs.webkit.org/show_bug.cgi?id=130906
3544
3545         Reviewed by Chris Fleizach.
3546
3547         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
3548
3549         * DumpRenderTree/AccessibilityUIElement.cpp:
3550         (lineTextMarkerRangeForTextMarkerCallback):
3551         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3552         (AccessibilityUIElement::getJSClass):
3553         * DumpRenderTree/AccessibilityUIElement.h:
3554         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3555         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3556         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3557         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3558         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3559         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3560         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3561         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3562         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3563         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3564         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3565         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3566
3567 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
3568
3569         More validation for FTL inline caches
3570         https://bugs.webkit.org/show_bug.cgi?id=130948
3571
3572         Reviewed by Geoffrey Garen.
3573
3574         * Scripts/run-jsc-stress-tests:
3575
3576 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3577
3578         [GTK] Do not run WebKit1 unit tests by default
3579         https://bugs.webkit.org/show_bug.cgi?id=130968
3580
3581         Reviewed by Martin Robinson.
3582
3583         * Scripts/run-gtk-tests:
3584         (TestRunner):
3585
3586 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
3587
3588         [GTK] Remove scripts code only applicable to autotools
3589         https://bugs.webkit.org/show_bug.cgi?id=130841
3590
3591         Reviewed by Anders Carlsson.
3592
3593         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3594         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
3595         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
3596         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
3597         * gtk/find-make-dist-errors: Removed.
3598         * gtk/generate-feature-defines-files: Removed.
3599         * gtk/manifest.txt: No longer need to consider autotools files.
3600
3601 2014-03-30  Andy Estes  <aestes@apple.com>
3602
3603         Fix two failing layout tests on Mountain Lion after r166466.
3604
3605         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3606         (-[DownloadDelegate _downloadDidStart:]):
3607
3608 2014-03-30  Andy Estes  <aestes@apple.com>
3609
3610         [Cocoa] Add an originatingWebView property to _WKDownload
3611         https://bugs.webkit.org/show_bug.cgi?id=130945
3612
3613         Reviewed by Anders Carlsson.
3614
3615         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3616         (-[DownloadDelegate _downloadDidStart:]):
3617         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
3618         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3619         (TEST):
3620
3621 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
3622
3623         Land the stackmap register liveness glue with the uses of the liveness disabled
3624         https://bugs.webkit.org/show_bug.cgi?id=130924
3625
3626         Reviewed by Oliver Hunt.
3627
3628         * Scripts/run-jsc-stress-tests:
3629
3630 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
3631
3632         Update WebKit1.StringTruncator for Mountain Lion.
3633
3634         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
3635         due to different font metrics on 10.8.
3636
3637 2014-03-28  Darin Adler  <darin@apple.com>
3638
3639         Fix recently-introduced off-by-one error in centerTruncateToBuffer
3640         https://bugs.webkit.org/show_bug.cgi?id=130889
3641
3642         Reviewed by Alexey Proskuryakov.
3643
3644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
3645         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
3646         WebStringTruncator methods; should be good for a start. These are dependent on the
3647         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
3648
3649 2014-03-28  Martin Hock  <mhock@apple.com>
3650
3651         Unreviewed. Add myself as a committer.
3652
3653         * Scripts/webkitpy/common/config/contributors.json:
3654
3655 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
3656
3657         Remove WebKit1 GTK+ bots
3658         https://bugs.webkit.org/show_bug.cgi?id=130904
3659
3660         Reviewed by Anders Carlsson.
3661
3662         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
3663         all bots are testing WebKit2 only.
3664         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
3665         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
3666         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
3667         * Scripts/webkitpy/port/builders.py: Ditto.
3668         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
3669         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
3670
3671 2014-03-28  Timothy Hatcher  <timothy@apple.com>
3672
3673         Remove Brian Burg's apple.com email address.
3674
3675         * Scripts/webkitpy/common/config/contributors.json:
3676
3677 2014-03-28  David Kilzer  <ddkilzer@apple.com>
3678
3679         bisect-builds should print Trac 'changeset' URL if only one build is detected
3680         <http://webkit.org/b/130903>
3681
3682         Reviewed by Dan Bernstein.
3683
3684         * Scripts/bisect-builds:
3685         (printTracLink): Print a direct link to the Trac 'changeset'
3686         URL if there is only one revision in the range.
3687
3688 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3689
3690         [EFL] Bump glib version from 2.36 to 2.38 
3691         https://bugs.webkit.org/show_bug.cgi?id=130886
3692
3693         Reviewed by Csaba Osztrogonác.
3694
3695         There is a build break on EFL port when using glib 2.36 ver. To fix it,
3696         we need to bump glib version up to 2.38 as gtk port.
3697
3698         * efl/jhbuild.modules:
3699
3700 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3701
3702         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
3703
3704         Provide an implementation of WKContextHistoryClient that logs when called for tests in
3705         the globalhistory directory.
3706
3707         Reviewed by Sam Weinig.
3708
3709         * WebKitTestRunner/TestController.cpp:
3710         (WTR::TestController::TestController):
3711         (WTR::TestController::initialize): Set the history client.
3712         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
3713         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
3714         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
3715         and we don't yet have API to access the data in question.
3716         (WTR::TestController::didPerformClientRedirect):
3717         (WTR::TestController::didPerformServerRedirect):
3718         (WTR::TestController::didUpdateHistoryTitle):
3719         * WebKitTestRunner/TestController.h:
3720         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3721         * WebKitTestRunner/TestInvocation.cpp:
3722         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
3723         (WTR::TestInvocation::invoke):
3724
3725 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
3726
3727         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
3728
3729         * Scripts/build-webkit:
3730         * Scripts/copy-webkitlibraries-to-product-directory:
3731
3732 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
3733
3734         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
3735         https://bugs.webkit.org/show_bug.cgi?id=130867
3736         <rdar://problem/16432456> 
3737
3738         Reviewed by Mark Hahnenberg.
3739
3740         * Scripts/build-webkit:
3741         * Scripts/copy-webkitlibraries-to-product-directory:
3742
3743 2014-03-26  Andy Estes  <aestes@apple.com>
3744
3745         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
3746         https://bugs.webkit.org/show_bug.cgi?id=130805
3747
3748         Reviewed by Dan Bernstein.
3749
3750         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3751         (-[DownloadDelegate _download:didReceiveResponse:]):
3752         (-[DownloadDelegate _downloadDidFinish:]):
3753         (runTest):
3754         (TEST):
3755         (-[FailingDownloadDelegate _downloadDidFinish:]):
3756         (-[FailingDownloadDelegate _download:didFailWithError:]):
3757         (-[FailingDownloadDelegate _downloadDidCancel:]):
3758         (-[CancelledDownloadDelegate _downloadDidStart:]):
3759         (-[CancelledDownloadDelegate _downloadDidFinish:]):
3760         (-[CancelledDownloadDelegate _download:didFailWithError:]):
3761         (-[CancelledDownloadDelegate _downloadDidCancel:]):
3762         (-[DownloadDelegate initWithSourceURL:]): Deleted.
3763         (-[DownloadDelegate sourceURL]): Deleted.
3764         (runTestWithNavigationDelegate): Deleted.
3765
3766 2014-03-26  Anders Carlsson  <andersca@apple.com>
3767
3768         Change MiniBrowser to hold on to window controllers instead of windows
3769         https://bugs.webkit.org/show_bug.cgi?id=130797
3770
3771         Reviewed by Oliver Hunt.
3772
3773         * MiniBrowser/mac/AppDelegate.h:
3774         * MiniBrowser/mac/AppDelegate.m:
3775         (-[BrowserAppDelegate init]):
3776         (-[BrowserAppDelegate newWindow:]):
3777         (-[BrowserAppDelegate browserWindowWillClose:]):
3778         (-[BrowserAppDelegate applicationWillTerminate:]):
3779         (-[BrowserAppDelegate frontmostBrowserWindowController]):
3780
3781 2014-03-26  Commit Queue  <commit-queue@webkit.org>
3782
3783         Unreviewed, rolling out r166264.
3784         https://bugs.webkit.org/show_bug.cgi?id=130785
3785
3786         Broke some window.opener tests for WK2 Mavericks (Requested by
3787         brrian__ on #webkit).
3788
3789         Reverted changeset:
3790
3791         "Web Replay: resource unique identifiers should be unique-per-
3792         frame, not globally"
3793         https://bugs.webkit.org/show_bug.cgi?id=130632
3794         http://trac.webkit.org/changeset/166264
3795
3796 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
3797
3798         [CSS Shapes] Remove shape-inside support
3799         https://bugs.webkit.org/show_bug.cgi?id=130698
3800
3801         Reviewed by David Hyatt.
3802
3803         * Scripts/webkitperl/FeatureList.pm:
3804
3805 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
3806
3807         Unreviewed. Add myself as a committer.
3808
3809         * Scripts/webkitpy/common/config/contributors.json:
3810
3811 2014-03-26  Tomas Popela  <tpopela@redhat.com>
3812
3813         run-launcher is Perl script so use elsif and not elif
3814         https://bugs.webkit.org/show_bug.cgi?id=130771
3815
3816         Reviewed by Carlos Garcia Campos.
3817
3818         * Scripts/run-launcher:
3819
3820 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
3821
3822         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
3823         https://bugs.webkit.org/show_bug.cgi?id=130575
3824
3825         Reviewed by Mario Sanchez Prada.
3826
3827         Change ATK version to 2.11.92. Adjust current implementation.
3828
3829         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3830         (AccessibilityUIElement::intValue):
3831         (AccessibilityUIElement::minValue):
3832         (AccessibilityUIElement::maxValue):
3833         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3834         (WTR::AccessibilityUIElement::intValue):
3835         (WTR::AccessibilityUIElement::minValue):
3836         (WTR::AccessibilityUIElement::maxValue):
3837         * efl/jhbuild.modules:
3838         * gtk/jhbuild.modules:
3839
3840 2014-03-12  Philippe Normand  <pnormand@igalia.com>
3841
3842         [GTK] The gnumake package is no longer needed in jhbuild
3843         https://bugs.webkit.org/show_bug.cgi?id=130121
3844
3845         Reviewed by Martin Robinson.
3846
3847         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
3848         for a debug build cmake/system-gnumake worked just fine for me.
3849
3850         * gtk/jhbuild.modules: Removed gnumake.
3851         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
3852         * gtk/patches/make-3.82-parallel-build.patch: Removed.
3853
3854 2014-03-25  Andy Estes  <aestes@apple.com>
3855
3856         Fix a failing API test on Mountain Lion and remove temporary debug logging.
3857
3858         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3859         (-[DownloadDelegate _download:didReceiveData:]):
3860         (-[DownloadDelegate _downloadDidFinish:]):
3861
3862 2014-03-25  Brian Burg  <bburg@apple.com>
3863
3864         Web Replay: resource unique identifiers should be unique-per-frame, not globally
3865         https://bugs.webkit.org/show_bug.cgi?id=130623
3866
3867         Reviewed by Timothy Hatcher.
3868
3869         The resource loader callback dumping routines assumed that resource identifiers
3870         were globally unique. Its map of resource identifiers to URLs must also track the
3871         frame associated with the resource.
3872
3873         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3874         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
3875         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
3876         stable as long as the frame is valid.
3877         (WTR::InjectedBundlePage::didInitiateLoadForResource):
3878         (WTR::InjectedBundlePage::willSendRequestForFrame):
3879         (WTR::InjectedBundlePage::didReceiveResponseForResource):
3880         (WTR::InjectedBundlePage::didFinishLoadForResource):
3881         (WTR::InjectedBundlePage::didFailLoadForResource):
3882
3883 2014-03-25  Andy Estes  <aestes@apple.com>
3884
3885         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
3886
3887         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3888         (-[DownloadDelegate _download:didReceiveResponse:]):
3889         (-[DownloadDelegate _download:didReceiveData:]):
3890
3891 2014-03-25  Andy Estes  <aestes@apple.com>
3892
3893         Add some debug logging to an API test that's failing on Mountain Lion.
3894
3895         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3896         (-[DownloadDelegate _download:didReceiveResponse:]):
3897         (-[DownloadDelegate _downloadDidFinish:]):
3898
3899 2014-03-25  Anders Carlsson  <andersca@apple.com>
3900
3901         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
3902         https://bugs.webkit.org/show_bug.cgi?id=130732
3903
3904         Reviewed by Tim Horton.
3905
3906         * MiniBrowser/mac/WK2BrowserWindowController.m:
3907         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3908
3909 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
3910
3911         [GTK] Remove the autotools build
3912         https://bugs.webkit.org/show_bug.cgi?id=130717
3913
3914         Reviewed by Anders Carlsson.
3915
3916         * DumpRenderTree/config.h: Remove references to the autotools configure file.
3917         * GNUmakefile.am: Removed.
3918         * GtkLauncher/GNUmakefile.am: Removed.
3919         * GtkLauncher/main.c: Remove references to the autotools configure file.
3920         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
3921         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
3922         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
3923         * MiniBrowser/gtk/GNUmakefile.am: Removed.
3924         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
3925         * Scripts/build-webkit: No longer handle autotools.
3926         * Scripts/run-gtk-tests: Ditto.
3927         (TestRunner._setup_testing_environment):
3928         * Scripts/run-launcher: Ditto.
3929         * Scripts/webkitdirs.pm: Ditto.
3930         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
3931         * Scripts/webkitpy/common/config/contributors.json: Ditto.
3932         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
3933         * Scripts/webkitpy/style/checker.py:
3934         * TestWebKitAPI/GNUmakefile.am: Removed.
3935         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
3936         * WebKitTestRunner/GNUmakefile.am: Removed.
3937         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
3938         * gtk/GNUmakefile.am: Removed.
3939         * gtk/common.py: Remove checks for the autotools build.
3940         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
3941
3942 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
3943
3944         prepare-ChangeLog throws false positive warnings for modified files.
3945         https://bugs.webkit.org/show_bug.cgi?id=130687
3946
3947         Reviewed by Darin Adler.
3948
3949         * Scripts/prepare-ChangeLog:
3950         (originalFile): Ignore git commit paremeter.
3951         We don't need this to get the unmodified file.
3952         (extractLineRangeBeforeChange):
3953         Simplify the if statement. Follow-up after r166189.
3954
3955 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
3956
3957         [EFL] Add ARM64 build support
3958         https://bugs.webkit.org/show_bug.cgi?id=130506
3959
3960         Rubber stamped by Gyuyoung Kim.
3961
3962         * Scripts/webkitdirs.pm:
3963         (isARM): Detect aarch64 as ARM.
3964
3965 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3966
3967         [webkitpy] Improve _parse_bug_description to recognize more descriptions
3968         https://bugs.webkit.org/show_bug.cgi?id=130137
3969
3970         Reviewed by Csaba Osztrogonác.
3971
3972         * Scripts/webkitpy/common/checkout/changelog.py:
3973         (ChangeLogEntry._parse_bug_description):
3974         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3975         (test_parse_log_entries_from_changelog):
3976         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3977         (CheckoutTest.test_commit_info_for_revision):
3978
3979 2014-03-24  Andy Estes  <aestes@apple.com>
3980
3981         Fix the iOS build of TestWebKitAPI.
3982
3983         * TestWebKitAPI/Configurations/Base.xcconfig:
3984         * TestWebKitAPI/PlatformUtilities.h:
3985
3986 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
3987
3988         Fix prepare-ChangeLog after r166156.
3989         https://bugs.webkit.org/show_bug.cgi?id=130674
3990
3991         Reviewed by Darin Adler.
3992
3993         * Scripts/prepare-ChangeLog:
3994         (generateFunctionLists):
3995         (extractLineRangeBeforeChange):
3996
3997 2014-03-24  Andy Estes  <aestes@apple.com>
3998
3999         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
4000         https://bugs.webkit.org/show_bug.cgi?id=129322
4001
4002         Reviewed by Anders Carlsson.
4003
4004         Add an API test suite for _WKDownload.
4005
4006         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4007         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
4008         (-[DownloadDelegate initWithSourceURL:]):
4009         (-[DownloadDelegate sourceURL]):
4010         (-[DownloadDelegate _downloadDidStart:]):
4011         (-[DownloadDelegate _download:didReceiveResponse:]):
4012         (-[DownloadDelegate _download:didReceiveData:]):
4013         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
4014         (-[DownloadDelegate _downloadDidFinish:]):
4015         (TEST):
4016         (runTestWithNavigationDelegate):
4017         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4018         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4019
4020 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
4021
4022         filter-build-webkit: reduce unfiltered output
4023         https://bugs.webkit.org/show_bug.cgi?id=130485
4024
4025         Reviewed by Brent Fulgham.
4026
4027         * Scripts/filter-build-webkit:
4028         (shouldIgnoreLine):
4029
4030 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
4031
4032         prepare-ChangeLog should list functions that have been removed too.
4033         https://bugs.webkit.org/show_bug.cgi?id=130508
4034
4035         Reviewed by Darin Adler.
4036
4037         The prepare-ChangeLog does not list the deleted functions in the Changelog.
4038         We have to read the functions and the line ranges of them from the source
4039         before the change, then search for overlaps between them and the changed
4040         line ranges from diff.
4041
4042         * Scripts/prepare-ChangeLog:
4043         (originalFile): Get original source command.
4044         (generateFunctionLists): Collect deleted functions too.
4045         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
4046         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
4047         deleted functions ranges too.
4048         (extractLineRange): Renamed to extractLineRangeAfterChange.
4049
4050 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
4051
4052         Move all EFL typedefs into EflTypedefs.h.
4053         https://bugs.webkit.org/show_bug.cgi?id=130511
4054
4055         Reviewed by Gyuyoung Kim.
4056
4057         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
4058         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
4059         * WebKitTestRunner/PlatformWebView.h: Ditto.
4060
4061 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
4062
4063         Don't flush compositing layers within FrameView::willPaintContents()
4064         https://bugs.webkit.org/show_bug.cgi?id=130627
4065         <rdar://problem/16368869>
4066
4067         Reviewed by Sam Weinig.
4068         
4069         Fix DRT to correctly render tests with layers now that FrameView::paintContents
4070         does not flush.
4071         
4072         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
4073         into an explicit function called before dumping. 
4074         
4075         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
4076         are flushed to CA. They will be pushed to the window by snapshotting.
4077
4078         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4079         Fix weird path to IOKit.framework.
4080         * DumpRenderTree/mac/DumpRenderTree.mm:
4081         (updateDisplay):
4082         (dump):
4083         * DumpRenderTree/mac/FrameLoadDelegate.mm:
4084         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
4085         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
4086
4087 2014-03-21  David Kilzer  <ddkilzer@apple.com>
4088
4089         fix-blink-patch: tool to fix up renamed directory paths in Blink
4090         <http://webkit.org/b/130609>
4091
4092         Reviewed by Ryosuke Niwa.
4093
4094         Usage: cat blink.patch | fix-blink-patch | svn-apply
4095
4096         * Scripts/fix-blink-patch: Added.
4097
4098 2014-03-21  Darin Adler  <darin@apple.com>
4099
4100         Remove use of deprecatedCharacters in WebKit API tests
4101         https://bugs.webkit.org/show_bug.cgi?id=130602
4102
4103         Reviewed by Antti Koivisto.
4104
4105         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
4106         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
4107         (TestWebKitAPI::expectEmpty): Use characters8.
4108         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
4109
4110         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4111         Removed the test that is entirely about 16-bit conversion since that's basically a test of
4112         the deprecatedCharacters function itself, which we are about to delete.
4113
4114 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4115
4116         [webkitpy] Fix has_valid_reviewer()
4117         https://bugs.webkit.org/show_bug.cgi?id=130589
4118
4119         Reviewed by Csaba Osztrogonác.
4120
4121         * Scripts/webkitpy/common/checkout/changelog.py:
4122         (ChangeLogEntry.has_valid_reviewer):
4123         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4124         (test_has_valid_reviewer):
4125         * Scripts/webkitpy/common/config/committers.py:
4126         (CommitterList._reviewer_only):
4127         (CommitterList.committer_by_name):
4128         (CommitterList.reviewer_by_email):
4129         (CommitterList):
4130         (CommitterList.reviewer_by_name):
4131
4132 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
4133
4134         Add cache support for jhbuild
4135         https://bugs.webkit.org/show_bug.cgi?id=130588
4136
4137         Reviewed by Csaba Osztrogonác.
4138
4139         * jhbuild/jhbuildrc_common.py:
4140         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
4141
4142 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
4143
4144         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
4145         https://bugs.webkit.org/show_bug.cgi?id=130504
4146
4147         Reviewed by Martin Robinson.
4148
4149         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
4150         CMake if not specified.
4151         * Scripts/webkitdirs.pm:
4152         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
4153         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
4154
4155 2014-03-21  Andreas Kling  <akling@apple.com>
4156
4157         RetainPtr API test should use CFArray instead of CFString for testing.
4158         <rdar://problem/16384899>
4159
4160         Unreviewed bot fix.
4161
4162         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
4163         (TestWebKitAPI::TEST):
4164         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
4165         (TestWebKitAPI::TEST):
4166
4167 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
4168
4169         Move to using std::unique_ptr for EFL objects.
4170         https://bugs.webkit.org/show_bug.cgi?id=129853
4171
4172         Reviewed by Gyuyoung Kim.
4173
4174         EflUniquePtr is a template alias of std::unique_ptr
4175         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
4176         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
4177
4178         * DumpRenderTree/efl/DumpRenderTree.cpp:
4179         (main):
4180         * ImageDiff/efl/ImageDiff.cpp:
4181         (initEfl):
4182         (main):
4183
4184 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
4185
4186         Unreviewed buildfix after r165983 for non Cocoa platforms
4187
4188         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
4189
4190         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
4191         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
4192         * WebKitTestRunner/TestController.cpp:
4193
4194 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
4195
4196         [GTK][CMake] Add support for building with Clang
4197         https://bugs.webkit.org/show_bug.cgi?id=130260
4198
4199         Reviewed by Martin Robinson.
4200
4201         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
4202         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
4203         included GTest framework headers.
4204         * gtk/generate-gtkdoc:
4205         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
4206         in case of using Clang since that is now set by the CMake rule.
4207
4208 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
4209
4210         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
4211         https://bugs.webkit.org/show_bug.cgi?id=130476
4212
4213         Reviewed by Anders Carlsson.
4214         
4215         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
4216
4217         * MiniBrowser/mac/WK1BrowserWindowController.m:
4218         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
4219         Remove log.
4220         * MiniBrowser/mac/WK2BrowserWindowController.m:
4221         (-[WK2BrowserWindowController awakeFromNib]):
4222         (-[WK2BrowserWindowController validateMenuItem:]):
4223         (-[WK2BrowserWindowController reload:]):
4224         Hook up reload.
4225         (-[WK2BrowserWindowController toggleZoomMode:]):
4226         (-[WK2BrowserWindowController resetZoom:]):
4227         (-[WK2BrowserWindowController canResetZoom]):
4228         (-[WK2BrowserWindowController currentZoomFactor]):
4229         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
4230         (-[WK2BrowserWindowController canZoomIn]):
4231         (-[WK2BrowserWindowController canZoomOut]):
4232
4233 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
4234
4235         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
4236         https://bugs.webkit.org/show_bug.cgi?id=130463
4237
4238         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
4239
4240 2014-03-18  Samuel White  <samuel_white@apple.com>
4241
4242         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
4243         https://bugs.webkit.org/show_bug.cgi?id=130250
4244
4245         Reviewed by Chris Fleizach.
4246
4247         Added ability to toggle enhanced accessibility on and off to support tests that require it.
4248
4249         * DumpRenderTree/AccessibilityController.cpp:
4250         (enableEnhancedAccessibilityCallback):
4251         (getEnhancedAccessibilityEnabledCallback):
4252         (AccessibilityController::getJSClass):
4253         * DumpRenderTree/AccessibilityController.h:
4254         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
4255         (AccessibilityController::enableEnhancedAccessibility):
4256         (AccessibilityController::enhancedAccessibilityEnabled):
4257         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
4258         (AccessibilityController::enableEnhancedAccessibility):
4259         (AccessibilityController::enhancedAccessibilityEnabled):
4260         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4261         (AccessibilityController::enableEnhancedAccessibility):
4262         (AccessibilityController::enhancedAccessibilityEnabled):
4263         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4264         (AccessibilityController::enableEnhancedAccessibility):
4265         (AccessibilityController::enhancedAccessibilityEnabled):
4266         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
4267         (WTR::AccessibilityController::enableEnhancedAccessibility):
4268         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
4269         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
4270         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
4271
4272 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
4273
4274         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
4275         yet).
4276
4277         * Scripts/webkitpy/common/config/contributors.json:
4278
4279 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
4280
4281         Web Inspector: Remove stale ReportMemoryUsagePlugin
4282         https://bugs.webkit.org/show_bug.cgi?id=130405
4283
4284         Reviewed by Andreas Kling.
4285
4286         This clang plugin looks like it was used for the old Inspector memory
4287         instrumentation that was removed. So the tool can be removed.
4288
4289         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
4290         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
4291         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
4292         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
4293
4294 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4295
4296         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
4297         https://bugs.webkit.org/show_bug.cgi?id=130220
4298
4299         Reviewed by Csaba Osztrogonác.
4300
4301         * Scripts/webkitpy/common/checkout/changelog.py:
4302         (ChangeLog.set_reviewer):
4303         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4304         (test_set_reviewer):
4305
4306 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
4307
4308         More FTL enabling.
4309