Speed up compile times by not including wtf/Variant.h so much
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-15  Sam Weinig  <sam@webkit.org>
2
3         Speed up compile times by not including wtf/Variant.h so much
4         https://bugs.webkit.org/show_bug.cgi?id=160847
5
6         Reviewed by Alex Christensen and Saam Barati.
7
8         * TestWebKitAPI/Tests/WTF/Variant.cpp:
9         (TestWebKitAPI::TEST):
10         Explicitly use std::experimental::variant.
11
12 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
13
14         Allow a port to run tests with a custom device setup
15         https://bugs.webkit.org/show_bug.cgi?id=160833
16
17         Reviewed by Daniel Bates.
18
19         These changes allow the IOSSimulator port to run tests in iPad mode.
20
21         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
22         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
23         a custom device will be collected into a set, and run in that device's environment after
24         the other tests have run.
25
26         * Scripts/webkitpy/layout_tests/controllers/manager.py:
27         (Manager._custom_device_for_test): If the test contains a directory matching a
28         custom device suffix, return that custom device.
29         (Manager._set_up_run): Push the custom device class, if any, into options so
30         that the Worker can get to it.
31         (Manager.run): Go through the list of tests, and break it down into device-generic
32         tests, and tests for each device class. _run_test_subset is then called for
33         each collection of tests, and the results merged.
34         (Manager._run_test_subset): Some lines unwrapped.
35         (Manager._end_test_run):
36         (Manager._run_tests):
37         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
38         (SingleTestRunner.__init__): Unwrapped a line.
39         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
40         (TestRunResults.merge): Add this function to merge TestRunResults
41         * Scripts/webkitpy/layout_tests/views/printing.py:
42         (Printer.print_workers_and_shards): Print the custom device, if any.
43         * Scripts/webkitpy/port/base.py:
44         (Port): Base port has empty array of custom devices.
45         (Port.setup_test_run): Add device_class argument.
46         * Scripts/webkitpy/port/driver.py:
47         (DriverInput.__repr__):
48         (Driver.check_driver.implementation):
49         * Scripts/webkitpy/port/efl.py:
50         (EflPort.setup_test_run):
51         * Scripts/webkitpy/port/gtk.py:
52         (GtkPort.setup_test_run):
53         * Scripts/webkitpy/port/ios.py:
54         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
55         (IOSSimulatorPort.__init__):
56         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
57         based on the custom device class.
58         (IOSSimulatorPort._set_device_class):
59         (IOSSimulatorPort._create_simulators): Factor some code into this function.
60         (IOSSimulatorPort.setup_test_run):
61         (IOSSimulatorPort.testing_device):
62         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
63         seemed wrong for this function. That was moved to setup_test_run().
64         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
65         but this happened too early, before we knew which kind of devices to create. Devices
66         are now created in setup_test_run().
67         * Scripts/webkitpy/port/win.py:
68         (WinPort.setup_test_run):
69
70 2016-08-15  Daniel Bates  <dabates@apple.com>
71
72         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
73         private frameworks and libraries
74         https://bugs.webkit.org/show_bug.cgi?id=155931
75         <rdar://problem/25807989>
76
77         Reviewed by Dan Bernstein.
78
79         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
80         where X is the major version of the active iOS SDK.
81
82         * DumpRenderTree/mac/Configurations/Base.xcconfig:
83         * WebKitTestRunner/Configurations/Base.xcconfig:
84
85 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
86
87         Add a setting and preferences to enable visual viewport mode
88         https://bugs.webkit.org/show_bug.cgi?id=160843
89
90         Reviewed by Sam Weinig.
91         
92         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
93
94         * MiniBrowser/mac/SettingsController.h:
95         * MiniBrowser/mac/SettingsController.m:
96         (-[SettingsController _populateMenu]):
97         (-[SettingsController validateMenuItem:]):
98         (-[SettingsController visualViewportEnabled]):
99         (-[SettingsController toggleVisualViewportEnabled:]):
100         * MiniBrowser/mac/WK1BrowserWindowController.m:
101         (-[WK1BrowserWindowController didChangeSettings]):
102         * MiniBrowser/mac/WK2BrowserWindowController.m:
103         (-[WK2BrowserWindowController didChangeSettings]):
104
105 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
106
107         Allow using make-dist with non-GTK ports
108         https://bugs.webkit.org/show_bug.cgi?id=160842
109
110         Reviewed by Michael Catanzaro.
111
112         This patch adds support for setting base name of tarball and argument
113         passed to cmake's -DPORT= via command line arguments.
114
115         * gtk/make-dist.py:
116         (Distcheck.configure):
117         (Distcheck.check):
118         (get_tarball_root_and_output_filename_from_arguments):
119
120 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
121
122         [GTK] Install script lacks gstreamer related dependencies
123         https://bugs.webkit.org/show_bug.cgi?id=160814
124
125         Reviewed by Carlos Garcia Campos.
126
127         * gtk/install-dependencies: Fedora case had already listed this dependencies,
128         but both Arch and Debian/Ubuntu were missing them.
129
130 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
131
132         make-dist.py should not allow unknown rules in manifest
133         https://bugs.webkit.org/show_bug.cgi?id=160841
134
135         Reviewed by Carlos Garcia Campos.
136
137         * gtk/make-dist.py:
138         (Manifest.process_line):
139
140 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
141
142         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
143         https://bugs.webkit.org/show_bug.cgi?id=160809
144
145         Reviewed by Carlos Garcia Campos.
146
147         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
148         case, and use it also for the new package names of libpng and libgeoclue.
149         * gtk/install-dependencies: Ditto.
150
151 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
152
153         Skip to check directories existence in build-webkit
154         https://bugs.webkit.org/show_bug.cgi?id=160691
155
156         Reviewed by Alex Christensen.
157
158         CMake checks if directories are there itself. So CMake ports
159         don't need to check it in the build-webkit script.
160
161         * Scripts/build-webkit:
162         * Scripts/webkitdirs.pm:
163         (determineSourceDir):
164         (isCMakeBuild):
165
166 2016-08-12  Alex Christensen  <achristensen@webkit.org>
167
168         Make URLParser work with URLs missing URL parts
169         https://bugs.webkit.org/show_bug.cgi?id=160824
170
171         Reviewed by Brady Eidson.
172
173         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
174         (TestWebKitAPI::s):
175         (TestWebKitAPI::checkURL):
176         (TestWebKitAPI::TEST_F):
177         (TestWebKitAPI::eq): Deleted.
178
179 2016-08-12  John Wilander  <wilander@apple.com>
180
181         Add HashCountedSet API tests to TestWTFLibrary target
182         https://bugs.webkit.org/show_bug.cgi?id=160815
183
184         Reviewed by Alex Christensen.
185
186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
187             Added HashCountedSet.cpp and sorted the file reference section
188             according to UNIX sort.
189
190 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
191
192         run-benchmark should run JetStream 1.1 instead of 1.0.1
193         https://bugs.webkit.org/show_bug.cgi?id=160816
194
195         Reviewed by Filip Pizlo.
196
197         Use the latest JetStream 1.1 in run-benchmark.
198
199         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
200         (BenchmarkBuilder.__exit__):
201         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
202         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
203         change to JetStream directory.
204
205 2016-08-12  Alex Christensen  <achristensen@webkit.org>
206
207         Initial URLParser implementation
208         https://bugs.webkit.org/show_bug.cgi?id=160811
209
210         Reviewed by Brady Eidson.
211
212         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
213         (TestWebKitAPI::eq):
214         (TestWebKitAPI::checkURL):
215         (TestWebKitAPI::TEST_F):
216
217 2016-08-12  Brady Eidson  <beidson@apple.com>
218
219         Fix the 32-bit Mac build after:
220         Add WK2 ExperimentalFeature support to MiniBrowser
221         https://bugs.webkit.org/show_bug.cgi?id=160788
222
223         Unreviewed.
224
225         Sprinkle "#if WK_API_ENABLED"s liberally.
226         
227         * MiniBrowser/mac/AppDelegate.m:
228         (defaultConfiguration):
229         * MiniBrowser/mac/SettingsController.m:
230         (-[SettingsController _populateMenu]):
231         (-[SettingsController validateMenuItem:]):
232
233 2016-08-12  Philippe Normand  <pnormand@igalia.com>
234
235         [GStreamer][OWR] Video rendering fixes
236         https://bugs.webkit.org/show_bug.cgi?id=160764
237
238         Reviewed by Xabier Rodriguez-Calvar.
239
240         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
241
242 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
243
244         Add missing return statement in convertFast function added in r204376.
245
246         Unreviewed.
247
248         * Scripts/webkitpy/common/system/path.py:
249         (_CygPath.convertFast):
250
251 2016-08-11  Brady Eidson  <beidson@apple.com>
252
253         Add WK2 ExperimentalFeature support to MiniBrowser.
254         https://bugs.webkit.org/show_bug.cgi?id=160788
255
256         Reviewed by Alex Christensen.
257
258         * MiniBrowser/mac/AppDelegate.h:
259         * MiniBrowser/mac/AppDelegate.m:
260         (defaultConfiguration):
261         (defaultPreferences):
262         
263         * MiniBrowser/mac/SettingsController.m:
264         (-[SettingsController _populateMenu]):
265         (-[SettingsController validateMenuItem:]):
266         (-[SettingsController toggleExperimentalFeature:]):
267
268 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
269
270         Keep EWS logs for longer
271         https://bugs.webkit.org/show_bug.cgi?id=160776
272
273         Reviewed by Daniel Bates.
274
275         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
276
277 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
278
279         iOS DRT/WTR project cleanup
280         https://bugs.webkit.org/show_bug.cgi?id=160778
281
282         Reviewed by Tim Horton.
283
284         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
285
286         Remove AppDelegate.* which were unused.
287
288         Exclude ios/Launch.storyboard on more platforms.
289
290         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
291         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
292         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
293         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
294         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
295         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
296         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
297
298 2016-08-11  Alex Christensen  <achristensen@webkit.org>
299
300         Fix Yosemite bots' cookie accept policies after r204365.
301         https://bugs.webkit.org/show_bug.cgi?id=160758
302
303         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
304         (TEST):
305         This makes the test fully clean up after itself.
306
307 2016-08-11  Alex Christensen  <achristensen@webkit.org>
308
309         Fix Yosemite bots' cookie accept policies after r204365.
310         https://bugs.webkit.org/show_bug.cgi?id=160758
311
312         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
313         (TEST):
314         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
315         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
316         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
317         causing any problems because there are no other API tests that do anything with cookies.
318         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
319         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
320         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
321
322 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
323
324         EWS should check if the patch is still valid before executing every major step
325         https://bugs.webkit.org/show_bug.cgi?id=160739
326         rdar://problem/27768813
327
328         Reviewed by Alexey Proskuryakov.
329
330         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
331         (CommitQueueTask.run): validate method is now executed in base class.
332         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
333         (EarlyWarningSystemTask.run): validate method is now executed in base class.
334         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
335         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
336         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
337         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
338         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
339         * Scripts/webkitpy/tool/commands/perfalizer.py:
340         (PerfalizerTask.validate): Added.
341         * Scripts/webkitpy/tool/commands/queues_unittest.py:
342         (test_manual_reject_during_processing): Updated test case.
343
344 2016-08-11  Alex Christensen  <achristensen@webkit.org>
345
346         Add URLParser stub
347         https://bugs.webkit.org/show_bug.cgi?id=160770
348
349         Reviewed by Sam Weinig.
350
351         * TestWebKitAPI/PlatformGTK.cmake:
352         * TestWebKitAPI/PlatformWin.cmake:
353         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
354         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
355         (TestWebKitAPI::TEST_F):
356
357 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
358
359         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
360         https://bugs.webkit.org/show_bug.cgi?id=160761
361
362         Reviewed by Tim Horton.
363
364         Give iOS DRT a Launch storyboard.
365
366         Have it use a UIViewController so future forms testing works correctly.
367
368         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
369         can run in iPad mode.
370
371         Remove empty InfoPlist.strings files.
372
373         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
374         * DumpRenderTree/ios/Info.plist:
375         * DumpRenderTree/ios/Launch.storyboard: Added.
376         * DumpRenderTree/mac/DumpRenderTree.mm:
377         (createWebViewAndOffscreenWindow):
378         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
379         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
380         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
381         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
382
383 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
384
385         [Win] Unable to reliably run tests in parallel
386         https://bugs.webkit.org/show_bug.cgi?id=140914
387
388         Reviewed by Brent Fulgham.
389
390         The cygpath utility function can fail badly when running with multiple DumpRenderTree
391         processes. We can use string replacement to convert the Cygwin path to a Windows path
392         instead.
393
394         * Scripts/webkitpy/common/system/path.py:
395         (cygpathFast):
396         * Scripts/webkitpy/port/driver.py:
397         (Driver._command_from_driver_input):
398
399 2016-08-10  Alex Christensen  <achristensen@webkit.org>
400
401         Fix crash when changing cookie accept policy after r204327
402         https://bugs.webkit.org/show_bug.cgi?id=160758
403
404         Reviewed by Simon Fraser.
405
406         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
407         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
408         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
409         (TEST):
410         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
411
412 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
413
414         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
415         https://bugs.webkit.org/show_bug.cgi?id=160757
416
417         Reviewed by Tim Horton.
418
419         When programmatically creating the test UIWindow, make a root UIViewController and parent
420         the WKWebView in its view. This makes the app more like a normal UIKit application.
421         
422         Move the WKWebView down 20px to avoid the status bar.
423         
424         Give the UIWindow a gray background so it's obvious where the window and view positioned.
425
426         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
427         
428         Remove duplicate references to Launch.storyboard.
429
430         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
431         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
432         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
433         (-[AppDelegate applicationWillResignActive:]): Deleted.
434         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
435         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
436         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
437         (-[AppDelegate applicationWillTerminate:]): Deleted.
438         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
439         (WTR::viewRectForWindowRect):
440         (WTR::PlatformWebView::PlatformWebView):
441         (WTR::PlatformWebView::setWindowFrame):
442
443 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
444
445         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
446         https://bugs.webkit.org/show_bug.cgi?id=160748
447
448         Reviewed by Tim Horton.
449         
450         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
451         opens the door for tests using other device sizes.
452
453         * WebKitTestRunner/ios/TestControllerIOS.mm:
454         (WTR::TestController::platformConfigureViewForTest):
455
456 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
457
458         Sort the feature flags in the FEATURE_DEFINES lines
459         https://bugs.webkit.org/show_bug.cgi?id=160742
460
461         Reviewed by Anders Carlsson.
462         
463         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
464
465 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
466
467         Logging and other minor improvements to iOS webkitpy
468         https://bugs.webkit.org/show_bug.cgi?id=160722
469
470         Reviewed by Dan Bates.
471
472         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
473         to make it easier to debug launching issues.
474
475         Have reset_preferences() reset the device, rather than just nuking the data
476         directory (which broke some versions of the simulator).
477
478         Make the Simulator.app launch in the background with open -g.
479
480         Wait for the simulator device to be in a known state in some more places.
481
482         * Scripts/webkitpy/port/ios.py:
483         (IOSSimulatorPort.setup_test_run):
484         (IOSSimulatorPort._quit_ios_simulator):
485         (IOSSimulatorPort.clean_up_test_run):
486         (IOSSimulatorPort.setup_environ_for_server):
487         (IOSSimulatorPort.reset_preferences):
488         * Scripts/webkitpy/xcode/simulator.py:
489         (Device.create):
490         (Device.delete):
491         (Device):
492         (Device.reset):
493         (Simulator.wait_until_device_is_booted):
494         (Simulator.wait_until_device_is_in_state):
495         (Simulator):
496         (Simulator.delete_device):
497         (Simulator.reset_device):
498         (Simulator.lookup_or_create_device):
499
500 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
501
502         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
503         https://bugs.webkit.org/show_bug.cgi?id=160697
504
505         Reviewed by Antonio Gomes.
506
507         * Scripts/webkitpy/port/base.py:
508         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
509         list of environment variables to copy.
510
511 2016-08-09  George Ruan  <gruan@apple.com>
512
513         Implement functionality of media capture on iOS
514         https://bugs.webkit.org/show_bug.cgi?id=158945
515         <rdar://problem/26893343>
516
517         Reviewed by Tim Horton.
518
519         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
520         Capture feature on iOS.
521
522 2016-08-09  Saam Barati  <sbarati@apple.com>
523
524         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
525         https://bugs.webkit.org/show_bug.cgi?id=160671
526         <rdar://problem/27756112>
527
528         Reviewed by Mark Lam.
529
530         * Scripts/run-jsc-stress-tests:
531
532 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
533
534         Make directory reading code in iOSSimulatorDevices() more strict
535         https://bugs.webkit.org/show_bug.cgi?id=160702
536
537         Reviewed by Tim Horton.
538
539         * Scripts/webkitdirs.pm:
540         (iOSSimulatorDevices):
541
542 2016-08-06  Sam Weinig  <sam@webkit.org>
543
544         Replace NodeOrString with std::variant<RefPtr<Node>, String>
545         https://bugs.webkit.org/show_bug.cgi?id=160638
546
547         Reviewed by Anders Carlsson.
548
549         * TestWebKitAPI/CMakeLists.txt:
550         * TestWebKitAPI/Tests/WTF/Variant.cpp:
551         Add additional tests for the initial state of std::variant and using
552         makeVisitor for visiting.
553
554 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
555
556         EWS logging should ensure the logging to file is stopped on queue termination
557         https://bugs.webkit.org/show_bug.cgi?id=160698
558         rdar://problem/24464570
559
560         Reviewed by Daniel Bates.
561
562         * Scripts/webkitpy/tool/bot/queueengine.py:
563         (QueueEngine._stopping): Stop logging to file on queue termination.
564         (QueueEngine._begin_logging): Configure the Python logger to log to file.
565         * Scripts/webkitpy/common/system/logutils.py:
566         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
567         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
568         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
569         * Scripts/webkitpy/tool/commands/queues.py:
570         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
571         (AbstractQueue.queue_log_path): Same.
572         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
573         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
574         which moved to QueueEngine now.
575         (PatchProcessingQueue.__init__): Same.
576         (CommitQueue.__init__): Same.
577         (AbstractReviewQueue.__init__): Same.
578         (StyleQueue.__init__): Same.
579         * Scripts/webkitpy/tool/commands/queues_unittest.py:
580         (TestCommitQueue): Removed host parameter.
581         (TestCommitQueue.__init__): Same.
582         (AbstractPatchQueueTest.test_next_patch): Same.
583         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
584         (test_commit_queue_failure): Same.
585         (mock_run_webkit_patch):
586         (MockCommitQueueTask.results_from_patch_test_run): Same.
587         (test_rollout_lands): Same.
588         (test_non_valid_patch): Same.
589         (test_auto_retry): Same.
590         (test_style_queue_with_watch_list_exception): Same.
591         (TestQueue.__init__): Deleted.
592         (TestReviewQueue.__init__): Deleted.
593         (TestFeederQueue.__init__): Deleted.
594
595 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
596
597         webkit-gtk tarball fails to build due to missing files
598         https://bugs.webkit.org/show_bug.cgi?id=160684
599
600         Reviewed by Alex Christensen.
601
602         * gtk/manifest.txt.in: Added back spi directories.
603
604 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
605
606         [GTK] Build the jhbuild with -O2 optimization level by default
607         https://bugs.webkit.org/show_bug.cgi?id=160544
608
609         Reviewed by Michael Catanzaro.
610
611         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
612         which don't increases the required disk space significatively and
613         provides better debug information than no passing it.
614
615 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
616
617         Allow more --cmakeargs option in build-jsc and build-webkit
618         https://bugs.webkit.org/show_bug.cgi?id=160340
619
620         Reviewed by Michael Catanzaro.
621
622         * Scripts/build-jsc:
623         * Scripts/build-webkit:
624
625 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
626
627         Do not check if WebKitLibraries folder exists on EFL and GTK
628         https://bugs.webkit.org/show_bug.cgi?id=160659
629
630         Reviewed by Csaba Osztrogonác.
631
632         Though WebKitLibraries is only needed by mac and win ports,
633         EFL and GTK ports have checked whether it exists.
634
635         * Scripts/build-webkit:
636
637 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
638
639         Some EWS console logs doesn't go to log file
640         https://bugs.webkit.org/show_bug.cgi?id=160585
641         rdar://problem/24464570
642
643         Reviewed by Daniel Bates.
644
645         * Scripts/webkitpy/common/system/logutils.py:
646         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
647         any possible overwriting.
648         * Scripts/webkitpy/common/system/filesystem.py:
649         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
650         * Scripts/webkitpy/common/system/filesystem_mock.py:
651         (MockFileSystem.open_text_file_for_writing): Same.
652         * Scripts/webkitpy/common/system/filesystem_unittest.py:
653         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
654         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
655         * Scripts/webkitpy/tool/commands/queues.py:
656         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
657         This will ensure that all the sub-modules inside webkitpy will log to file.
658
659 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
660
661         Have the iOS platform interit from the Apple platform in webkitpy
662         https://bugs.webkit.org/show_bug.cgi?id=160672
663
664         Reviewed by Dan Bates.
665         
666         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
667         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
668         ApplePort.
669         
670         Since WinPort also inherits from ApplePort, it needs to stub out some things
671         that are unavailable on Windows (leaks, sampling).
672         
673         Some SnowLeopard-related code and the associated test were removed.
674
675         * Scripts/webkitpy/port/apple.py:
676         (ApplePort.__init__):
677         (ApplePort):
678         (ApplePort._make_leak_detector):
679         (ApplePort.default_timeout_ms):
680         (ApplePort.supports_per_test_timeout):
681         (ApplePort.should_retry_crashes):
682         (ApplePort._generate_all_test_configurations):
683         (ApplePort.check_for_leaks):
684         (ApplePort.print_leaks_summary):
685         (ApplePort._path_to_webcore_library):
686         (ApplePort.show_results_html_file):
687         (ApplePort._merge_crash_logs):
688         (ApplePort._look_for_all_crash_logs_in_log_dir):
689         (ApplePort._get_crash_log):
690         (ApplePort.look_for_new_crash_logs):
691         (ApplePort.sample_process):
692         (ApplePort.sample_file_path):
693         (ApplePort.look_for_new_samples):
694         (ApplePort._path_to_helper):
695         (ApplePort.determine_full_port_name): Deleted.
696         * Scripts/webkitpy/port/ios.py:
697         (IOSSimulatorPort):
698         (IOSSimulatorPort.__init__):
699         (IOSSimulatorPort.default_timeout_ms): Deleted.
700         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
701         (IOSSimulatorPort.should_retry_crashes): Deleted.
702         (IOSSimulatorPort.check_for_leaks): Deleted.
703         (IOSSimulatorPort.print_leaks_summary): Deleted.
704         (IOSSimulatorPort._path_to_webcore_library): Deleted.
705         (IOSSimulatorPort.show_results_html_file): Deleted.
706         (IOSSimulatorPort.sample_file_path): Deleted.
707         (IOSSimulatorPort._merge_crash_logs): Deleted.
708         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
709         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
710         (IOSSimulatorPort.look_for_new_samples): Deleted.
711         (IOSSimulatorPort.sample_process): Deleted.
712         (IOSSimulatorPort._path_to_helper): Deleted.
713         (IOSSimulatorPort.make_command): Deleted.
714         * Scripts/webkitpy/port/mac.py:
715         (MacPort.__init__):
716         (MacPort.make_command):
717         (MacPort._build_java_test_support):
718         (MacPort): Deleted.
719         (MacPort.default_timeout_ms): Deleted.
720         (MacPort.supports_per_test_timeout): Deleted.
721         (MacPort.should_retry_crashes): Deleted.
722         (MacPort.default_child_processes): Deleted.
723         (MacPort.check_for_leaks): Deleted.
724         (MacPort.print_leaks_summary): Deleted.
725         (MacPort._path_to_webcore_library): Deleted.
726         (MacPort.show_results_html_file): Deleted.
727         (MacPort.sample_file_path): Deleted.
728         (MacPort._merge_crash_logs): Deleted.
729         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
730         (MacPort.look_for_new_crash_logs): Deleted.
731         (MacPort.look_for_new_samples): Deleted.
732         (MacPort.sample_process): Deleted.
733         (MacPort._path_to_helper): Deleted.
734         * Scripts/webkitpy/port/mac_unittest.py:
735         (MacTest.test_default_child_processes): Deleted.
736         * Scripts/webkitpy/port/win.py:
737         (WinPort.look_for_new_samples):
738         (WinPort):
739         (WinPort.sample_process):
740         (WinPort._make_leak_detector):
741         (WinPort.check_for_leaks):
742         (WinPort.print_leaks_summary):
743         (WinPort._path_to_webcore_library):
744
745 2016-08-08  Matt Baker  <mattbaker@apple.com>
746
747         Unreviewed: moved myself to the reviewers list.
748
749         * Scripts/webkitpy/common/config/contributors.json:
750
751 2016-08-08  Chris Dumez  <cdumez@apple.com>
752
753         Update API tests in mac/SetDocumentURI.mm after r204247
754         https://bugs.webkit.org/show_bug.cgi?id=160660
755
756         Reviewed by Alex Christensen.
757
758         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
759         (TestWebKitAPI::TEST):
760
761 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
762
763         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
764         https://bugs.webkit.org/show_bug.cgi?id=159827
765
766         Reviewed by Daniel Bates.
767
768         This change was spurred by a process hang which occurred between tests and did
769         not produce a meaningful crashlog.
770
771         * Scripts/webkitpy/port/driver.py:
772         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
773
774          * Scripts/webkitpy/port/ios.py:
775         (IOSSimulatorPort):
776         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
777         * Scripts/webkitpy/port/mac.py:
778         (MacPort):
779         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
780
781         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
782         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
783
784         * WebKitTestRunner/TestController.h:
785         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
786         * WebKitTestRunner/TestInvocation.cpp:
787         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
788
789 2016-08-07  Dan Bernstein  <mitz@apple.com>
790
791         [Cocoa] Reply block leaks if the remote object doesn’t call it
792         https://bugs.webkit.org/show_bug.cgi?id=160642
793
794         Reviewed by Sam Weinig.
795
796         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
797         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
798         (TEST): Added a test case that checks that the reply block is released even when it’s not
799           called.
800         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
801         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
802           calling the completion handler.
803
804 2016-08-07  Chris Dumez  <cdumez@apple.com>
805
806         Write API test to cover crash fix in r204135
807         https://bugs.webkit.org/show_bug.cgi?id=160587
808
809         Reviewed by Darin Adler.
810
811         Add API test to cover crash fix in r204135. This reproduces the crash
812         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
813         callback.
814
815         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
816         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
817         (TEST):
818
819 2016-08-06  Chris Dumez  <cdumez@apple.com>
820
821         Unreviewed, rolling out r204226.
822
823         Broke some API tests
824
825         Reverted changeset:
826
827         "Write API test to cover crash fix in r204135"
828         https://bugs.webkit.org/show_bug.cgi?id=160587
829         http://trac.webkit.org/changeset/204226
830
831 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
832
833         EWS Style Queue fails to process patches which fails validation
834         https://bugs.webkit.org/show_bug.cgi?id=160632
835
836         Reviewed by Alexey Proskuryakov.
837
838         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
839         (StyleQueueTask.validate): Add more information about validation failure.
840         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
841         * Scripts/webkitpy/tool/commands/queues_unittest.py:
842         (test_non_valid_patch): Add a unit test to test the above code path.
843
844 2016-08-06  Sam Weinig  <sam@webkit.org>
845
846         WTF needs a variant implementation
847         https://bugs.webkit.org/show_bug.cgi?id=160618
848
849         Reviewed by Darin Adler.
850
851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
852         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
853         Add tests for the variant implementation.
854
855 2016-08-06  Chris Dumez  <cdumez@apple.com>
856
857         Write API test to cover crash fix in r204135
858         https://bugs.webkit.org/show_bug.cgi?id=160587
859
860         Reviewed by Darin Adler.
861
862         Add API test to cover crash fix in r204135. This reproduces the crash
863         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
864         callback.
865
866         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
867         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
868         (TEST):
869
870 2016-08-05  Tim Horton  <timothy_horton@apple.com>
871
872         run-api-tests should use a headed simulator
873         https://bugs.webkit.org/show_bug.cgi?id=160611
874
875         Reviewed by Sam Weinig.
876
877         CADisplayLink doesn't work in a headless simulator, but is
878         vital for the proper functioning of WebKit2 painting on iOS.
879         So, we should not use a headless simulator.
880
881         * Scripts/run-api-tests:
882         Launch a simulator app, don't just boot the simulator.
883
884         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
885         Re-enable a test that works now.
886
887 2016-08-05  Dan Bernstein  <mitz@apple.com>
888
889         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
890         https://bugs.webkit.org/show_bug.cgi?id=160589
891
892         Reviewed by Tim Horton.
893
894         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
895         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
896           blocks, which wasn’t caught because the test wasn’t run correctly.
897         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
898         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
899           added a test that sends over an NSRange.
900         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
901         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
902           handler with the range‘s location and length.
903
904 2016-08-05  Enrica Casucci  <enrica@apple.com>
905
906         Fixing tests failing after r204175.
907
908         Unreviewed.
909
910         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
911
912 2016-08-05  Enrica Casucci  <enrica@apple.com>
913
914         Build fix after 204053.
915
916         Unreviewed.
917
918         * TestWebKitAPI/Configurations/Base.xcconfig:
919         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
920         (-[MockContentFilterEnabler initWithCoder:]):
921         (-[MockContentFilterEnabler dealloc]):
922
923 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
924
925         Print test name in "Last character read from DRT..." error message.
926         https://bugs.webkit.org/show_bug.cgi?id=160559
927
928         Reviewed by Michael Catanzaro.
929
930         * Scripts/webkitpy/port/driver.py:
931         (Driver.run_test):
932         (Driver._read_first_block):
933         (Driver._read_optional_image_block):
934         (Driver._read_block):
935         * Scripts/webkitpy/port/driver_unittest.py:
936         (DriverTest.test_read_block):
937         (DriverTest.test_read_binary_block):
938         (DriverTest.test_read_base64_block):
939
940 2016-08-05  Commit Queue  <commit-queue@webkit.org>
941
942         Unreviewed, rolling out r204123.
943         https://bugs.webkit.org/show_bug.cgi?id=160597
944
945         Caused layout test timeouts on Windows. (Requested by perarne
946         on #webkit).
947
948         Reverted changeset:
949
950         "[Win] Unable to reliably run tests in parallel"
951         https://bugs.webkit.org/show_bug.cgi?id=140914
952         http://trac.webkit.org/changeset/204123
953
954 2016-08-04  Saam Barati  <sbarati@apple.com>
955
956         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
957         https://bugs.webkit.org/show_bug.cgi?id=151241
958
959         Reviewed by Benjamin Poulain.
960
961         * Scripts/run-jsc-stress-tests:
962
963 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
964
965         UI improvements to Flakiness Dashboard.
966         https://bugs.webkit.org/show_bug.cgi?id=153295
967
968         Reviewed by Alexey Proskuryakov.
969
970         * TestResultServer/static-dashboards/flakiness_dashboard.css:
971         (td.options-container): Center text in most fields.
972         * TestResultServer/static-dashboards/flakiness_dashboard.js:
973         (createBugHTML): Text/Grammar updates.
974         (tableHeaders): Ditto.
975         (htmlForSingleTestRow): Ditto.
976         (headerForTestTableHtml): Ditto.
977         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
978         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
979
980 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
981
982         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
983         https://bugs.webkit.org/show_bug.cgi?id=160518
984
985         Reviewed by Michael Catanzaro.
986
987         * Scripts/webkitpy/thirdparty/__init__.py:
988         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
989         * gtk/install-dependencies:
990
991 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
992
993         Optimize bot watcher's dashboard a little
994         https://bugs.webkit.org/show_bug.cgi?id=160515
995         rdar://problem/26096900
996
997         Reviewed by Lucas Forschler.
998
999         Made re-sorting after loading an iteration more efficient.
1000
1001         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1002         (BuildbotIteration.prototype._updateWithData):
1003         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1004         (BuildbotQueue.prototype.updateIterationPosition):
1005
1006 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1007
1008         [Win] Unable to reliably run tests in parallel
1009         https://bugs.webkit.org/show_bug.cgi?id=140914
1010
1011         Reviewed by Brent Fulgham.
1012
1013         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1014         processes. We can use string replacement to convert the Cygwin path to a Windows path
1015         instead.
1016  
1017         * Scripts/webkitpy/common/system/path.py:
1018         (cygpathFast):
1019         * Scripts/webkitpy/port/driver.py:
1020         (Driver._command_from_driver_input):
1021
1022 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1023
1024         Document instructions for increasing process and file limits
1025         https://bugs.webkit.org/show_bug.cgi?id=160528
1026         rdar://problem/24777576
1027
1028         Reviewed by Alexey Proskuryakov.
1029
1030         * Scripts/webkitpy/port/ios.py:
1031         (IOSSimulatorPort.default_child_processes):
1032
1033 2016-08-03  Anders Carlsson  <andersca@apple.com>
1034
1035         Remove the Objective-C bindings generator
1036         https://bugs.webkit.org/show_bug.cgi?id=160526
1037
1038         Reviewed by Sam Weinig.
1039
1040         * Scripts/run-bindings-tests:
1041         Update test.
1042
1043 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1044
1045         Revise a TestWebKitAPI comment to mention the actual underlying problem
1046
1047         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1048         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1049
1050 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1051
1052         Benchmark test content-animation timeouts always
1053         https://bugs.webkit.org/show_bug.cgi?id=160057
1054
1055         Reviewed by Simon Fraser.
1056
1057         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1058         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1059         (start):
1060
1061 2016-08-02  Nan Wang  <n_wang@apple.com>
1062
1063         AX: Simulated touch events are not working on iOS
1064         https://bugs.webkit.org/show_bug.cgi?id=160395
1065         <rdar://problem/27633597>
1066
1067         Reviewed by Chris Fleizach.
1068
1069         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1070         (WTR::AccessibilityUIElement::press):
1071         (WTR::AccessibilityUIElement::setSelectedChild):
1072
1073 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1074
1075         run-javascriptcore-tests should accept multiple --extra-tests
1076         https://bugs.webkit.org/show_bug.cgi?id=160486
1077
1078         Reviewed by Saam Barati.
1079         
1080         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1081         test suites. This does it by using GetOpt::Long's array support.
1082
1083         * Scripts/run-javascriptcore-tests:
1084         (runJSCStressTests):
1085
1086 2016-08-02  Enrica Casucci  <enrica@apple.com>
1087
1088         Allow building with content filtering disabled.
1089         https://bugs.webkit.org/show_bug.cgi?id=160454
1090
1091         Reviewed by Simon Fraser.
1092
1093         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1094
1095 2016-08-02  Brady Eidson  <beidson@apple.com>
1096
1097         Removing IndexedDB WebsiteData can fail for some users.
1098         https://bugs.webkit.org/show_bug.cgi?id=160463
1099
1100         Reviewed by Alex Christensen.
1101
1102         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1103
1104 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1105
1106         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1107         https://bugs.webkit.org/show_bug.cgi?id=160437
1108         <rdar://problem/27578272>
1109
1110         Reviewed by Brady Eidson.
1111
1112         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1113         (-[DownloadDelegate _download:didReceiveResponse:]):
1114         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1115         (runTest):
1116         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1117
1118 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1119
1120         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1121         https://bugs.webkit.org/show_bug.cgi?id=160414
1122
1123         Reviewed by Michael Catanzaro.
1124
1125         * Scripts/webkitpy/port/linux_get_crash_log.py:
1126         (GDBCrashLogGenerator._wait_for_corefile):
1127
1128 2016-08-01  Youenn Fablet  <youenn@apple.com>
1129
1130         Make wpt server generate its certificates in layout test results folder
1131         https://bugs.webkit.org/show_bug.cgi?id=160422
1132
1133         Reviewed by Chris Dumez.
1134
1135         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1136         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1137
1138 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1139
1140         Function Call on NULL Object
1141         https://bugs.webkit.org/show_bug.cgi?id=160325
1142
1143         Reviewed by Darin Adler.
1144
1145         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1146         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1147         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1148
1149 2016-08-01  Keith Miller  <keith_miller@apple.com>
1150
1151         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1152         https://bugs.webkit.org/show_bug.cgi?id=160372
1153
1154         Rubber stamped by Geoffrey Garen.
1155
1156         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1157         a new top level directory, JSTests. Having the tests in the Source directory
1158         was both confusing an inconvenient for people that just want to checkout the
1159         source code of WebKit. Since there is no other obvious place to put all the
1160         JavaScript tests a new top level directory seemed the most sensible.
1161
1162         * Scripts/import-test262-tests:
1163         * Scripts/run-javascriptcore-tests:
1164         * Scripts/update-javascriptcore-test-res:
1165
1166 2016-07-31  Nan Wang  <n_wang@apple.com>
1167
1168         AX: Add a check for touch event listener on iOS accessibility object
1169         https://bugs.webkit.org/show_bug.cgi?id=160388
1170
1171         Reviewed by Chris Fleizach.
1172
1173         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1174         (AccessibilityUIElement::boolAttributeValue):
1175         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1176         (WTR::AccessibilityUIElement::boolAttributeValue):
1177
1178 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1179
1180         Unreviewed: add myself to the reviewers list.
1181
1182         * Scripts/webkitpy/common/config/contributors.json:
1183
1184 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1185
1186         Undo r203939, and copy over a rule that clips the logos.
1187
1188         Sierra wasn't the only logo without transparency.
1189
1190         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1192         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1193
1194 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1195
1196         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1197         https://bugs.webkit.org/show_bug.cgi?id=160377
1198
1199         Reviewed by Brian Weinstein.
1200
1201         Update assets to remove the white background and use a transparent background instead.
1202
1203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1205
1206 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1207
1208         Ignore most check-webkit-style checks for ANGLE project
1209         <https://webkit.org/b/160333>
1210
1211         Reviewed by Daniel Bates.
1212
1213         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1214         - No tabs.
1215         - No spaces at the end of lines.
1216         - No carriage returns (DOS line endings).
1217
1218 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1219
1220         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1221         https://bugs.webkit.org/show_bug.cgi?id=160360
1222         <rdar://problem/27179484>
1223
1224         Reviewed by Myles C. Maxfield.
1225
1226         Adds two tests verifying that videos may be considered main content as long as they
1227         are large enough and cover a majority of the mainframe's viewport.
1228
1229         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1230         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1231         (TestWebKitAPI::TEST):
1232         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1233         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1234
1235 2016-07-29  Mark Lam  <mark.lam@apple.com>
1236
1237         Gardening: removed unused variable.
1238
1239         Not reviewed.
1240
1241         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1242         (TestWebKitAPI::TEST):
1243
1244 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1245
1246         Add TestWebKitAPI support for interacting with media controls
1247         https://bugs.webkit.org/show_bug.cgi?id=160342
1248         <rdar://problem/27610246>
1249
1250         Reviewed by Beth Dakin.
1251
1252         Adds support for testing interaction with some media controls, as well as a basic test
1253         verifying that media control teardown after interaction does not result in a crash.
1254
1255         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1256         (-[WKWebView mouseDownAtPoint:]):
1257         (-[WKWebView performAfterLoading:]):
1258         (TestWebKitAPI::TEST):
1259
1260 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1261
1262         Crash Log Clobbering on Unbound Crashes
1263         https://bugs.webkit.org/show_bug.cgi?id=160198
1264         <rdar://problem/27472618>
1265
1266         Reviewed by Alexey Proskuryakov.
1267
1268         * Scripts/webkitpy/common/system/crashlogs.py:
1269         (CrashLogs): Fix header order.
1270         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1271         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1272
1273 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1274
1275         Update for contributors.json
1276         https://bugs.webkit.org/show_bug.cgi?id=160294
1277
1278         * Scripts/webkitpy/common/config/contributors.json:
1279
1280 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1281
1282         Remove deprecated SPI for video inline / fullscreen controls
1283         https://bugs.webkit.org/show_bug.cgi?id=160318
1284
1285         Reviewed by Tim Horton.
1286
1287         * DumpRenderTree/mac/DumpRenderTree.mm:
1288         (setDefaultsToConsistentValuesForTesting): Deleted.
1289         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1290         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1291         * WebKitTestRunner/TestController.cpp:
1292         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1293         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1294         (WTR::initializeWebViewConfiguration): Deleted.
1295
1296 2016-07-28  Daniel Bates  <dabates@apple.com>
1297
1298         [iOS] TestWebKitAPI bundle targets are not code signed
1299         https://bugs.webkit.org/show_bug.cgi?id=160328
1300         <rdar://problem/27409246>
1301
1302         Reviewed by Andy Estes.
1303
1304         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1305         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1306         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1307
1308         * TestWebKitAPI/Configurations/Base.xcconfig:
1309
1310 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1311
1312         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1313
1314         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1315         (animatedResizeWebView):
1316         (TEST):
1317         This test times out only when run in the WebKit Testing simulator environment,
1318         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1319
1320 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1321
1322         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1323         https://bugs.webkit.org/show_bug.cgi?id=160289
1324         <rdar://problem/27553464>
1325
1326         Reviewed by Simon Fraser.
1327
1328         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1329         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1330         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1331         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1332         (-[AnimatedResizeWebView _endAnimatedResize]):
1333         (animatedResizeWebView):
1334         (TEST):
1335         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1336         Add two tests that ensure that hidden-content and animated resizes
1337         don't cause unnecessary synchronous waits. Only the hidden-content
1338         one fails before my patch, but it seemed reasonable to add both anyway.
1339
1340 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1341
1342         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1343         <https://webkit.org/b/83342>
1344
1345         Reviewed by Ryosuke Niwa.
1346
1347         * Scripts/webkitpy/common/checkout/scm/git.py:
1348         (Git.revisions_changing_file): Remove code to raise an exception
1349         when the file doesn't exist.  If a file was moved or renamed,
1350         then this caused the script to terminate, which was very
1351         frustrating when you wanted a list of reviewers.
1352         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1353         (SCMTest._shared_test_revisions_changing_file): Update test
1354         expectation to return an empty list of revisions.
1355         (test_create_patch_is_full_patch): Drive-by fix when running all
1356         webkitpy tests (including scm tests).
1357         * Scripts/webkitpy/common/checkout/scm/svn.py:
1358         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1359         return an empty array of revisions if this occurs.
1360
1361 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1362
1363         EWS error message "Error: * did not process patch" should include explanation
1364         https://bugs.webkit.org/show_bug.cgi?id=159903
1365         <rdar://problem/27410788>
1366
1367         Reviewed by Alexey Proskuryakov.
1368
1369         * QueueStatusServer/handlers/statusbubble.py:
1370         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1371         is not processed.
1372         * QueueStatusServer/handlers/processingtimesjson.py:
1373         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1374         of the code.
1375         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1376         (CommitQueueTask.validate): Add more information about validation failure.
1377         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1378         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1379         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1380         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1381         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1382         (PatchIsNotValid.__init__): Add the failure_message argument.
1383         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1384         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1385         failure details.
1386         * Scripts/webkitpy/tool/commands/queues.py:
1387         (CommitQueue.process_work_item): Same.
1388         (StyleQueue.review_patch): Same.
1389         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1390         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1391
1392 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1393
1394         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1395         https://bugs.webkit.org/show_bug.cgi?id=160262
1396
1397         Reviewed by Daniel Bates.
1398
1399         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1400         (-[LTRelayController installApp]):
1401
1402 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1403
1404         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1405         https://bugs.webkit.org/show_bug.cgi?id=160225
1406
1407         Reviewed by Alexey Proskuryakov.
1408
1409         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1410
1411 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1412
1413         [GTK] Fix some video/canvas tests that should be passing
1414         https://bugs.webkit.org/show_bug.cgi?id=160023
1415
1416         Reviewed by Carlos Garcia Campos.
1417
1418         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1419         EFL or GTK platforms.
1420
1421         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1422         (WTR::TestController::platformConfigureViewForTest):
1423         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1424         (WTR::TestController::platformConfigureViewForTest):
1425
1426 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1427
1428         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1429         https://bugs.webkit.org/show_bug.cgi?id=160247
1430
1431         Reviewed by Michael Catanzaro.
1432
1433         * BuildSlaveSupport/built-product-archive:
1434         (createZip):
1435         (dirContainsdwo):
1436         (archiveBuiltProduct):
1437
1438 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1439
1440         Fix tests after r203743.
1441         https://bugs.webkit.org/show_bug.cgi?id=156947
1442
1443         * WebKitTestRunner/TestController.cpp:
1444         (WTR::TestController::resetStateToConsistentValues):
1445         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1446
1447 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1448
1449         [iPhone] Playing a video on tudou.com plays only sound, no video
1450         https://bugs.webkit.org/show_bug.cgi?id=160178
1451         <rdar://problem/27535468>
1452
1453         Reviewed by Dan Bernstein.
1454
1455         * DumpRenderTree/mac/DumpRenderTree.mm:
1456         (setDefaultsToConsistentValuesForTesting):
1457         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1458         (RequiresUserActionForPlaybackTest::SetUp):
1459         * WebKitTestRunner/TestController.cpp:
1460         (WTR::TestController::resetPreferencesToConsistentValues):
1461         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1462         (WTR::initializeWebViewConfiguration):
1463
1464 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1465
1466         Allow LOG macros to be used outside the namespace, and other logging cleanup
1467         https://bugs.webkit.org/show_bug.cgi?id=160216
1468
1469         Reviewed by Anders Carlsson.
1470         
1471         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1472
1473         * DumpRenderTree/TestRunner.cpp:
1474         * DumpRenderTree/mac/DumpRenderTree.mm:
1475         (resetWebViewToConsistentStateBeforeTesting):
1476
1477 2016-07-26  David Kilzer <ddkilzer@apple.com>
1478
1479         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1480         https://bugs.webkit.org/show_bug.cgi?id=156947
1481         <rdar://problem/23325160>
1482
1483         Reviewed by Alex Christensen.
1484
1485         * DumpRenderTree/TestRunner.cpp:
1486         (TestRunner::TestRunner):
1487         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1488         * DumpRenderTree/TestRunner.h:
1489         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1490         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1491         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1492         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1493         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1494         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1495         (WTR::TestRunner::queueNonLoadingScript):
1496         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1497         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1498         * WebKitTestRunner/TestController.cpp:
1499         (WTR::TestController::didReceiveAuthenticationChallenge):
1500         * WebKitTestRunner/TestController.h:
1501         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1502         * WebKitTestRunner/TestInvocation.cpp:
1503         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1504         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1505
1506 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1507
1508         check-for-exit-time-destructors should be usable outside Xcode
1509         <https://webkit.org/b/160195>
1510
1511         Reviewed by Darin Adler.
1512
1513         * Scripts/check-for-exit-time-destructors: Update to parse
1514         -h|--help switch, or to take one argument to a binary to check
1515         for exit time destructors on the command-line.  The clang
1516         compiler will find these at compile-time with the
1517         -Wexit-time-destructors switch, but this script will check for
1518         them after-the-fact.
1519
1520 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1521
1522         Test svn.webkit.org functionality after maintenance.
1523
1524 2016-07-25  Brady Eidson  <beidson@apple.com>
1525
1526         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1527         https://bugs.webkit.org/show_bug.cgi?id=153783
1528
1529         Reviewed by Alex Christensen.
1530
1531         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
1532         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1533         
1534         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1535         
1536         Change the relevant API tests to make sure this continues to be no longer required.
1537
1538         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1539         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1540         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1541         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1542         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1543         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1544
1545 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1546
1547         Media controls should not be displayed for a video until it starts playing
1548         https://bugs.webkit.org/show_bug.cgi?id=160092
1549         <rdar://problem/26986673>
1550
1551         Reviewed by Beth Dakin.
1552
1553         Verify that multiple videos do or don't show the media controller depending on whether videos
1554         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1555         passing because we were always showing media controls for large videos with audio, even if they
1556         had not played back yet. This change ensures that large videos with audio show media controls
1557         only after they begin to play back, and not by virtue of being large enough for main content.
1558
1559         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1560         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1561         (TestWebKitAPI::TEST):
1562         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1563         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1564         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1565
1566 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1567
1568         Media controls on apple.com don't disappear when movie finishes playing
1569         https://bugs.webkit.org/show_bug.cgi?id=160068
1570         <rdar://problem/26668526>
1571
1572         Reviewed by Darin Adler.
1573
1574         Adds new API tests. Please see WebCore ChangeLog for more details.
1575
1576         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1577         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1578         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1579         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1580         (TestWebKitAPI::TEST):
1581         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1582         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1583         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1584         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1585         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1586
1587 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1588
1589         Unreviewed, fix test-webkitpy after r203674.
1590
1591         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1592         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1593
1594 2016-07-24  Philippe Normand  <pnormand@igalia.com>
1595
1596         Unreviewed, forgot to commit this file in r203674.
1597
1598         * Scripts/process-linux-coredump: Added.
1599         (main):
1600
1601 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1602
1603         Improve GDB backtrace generation for GTK/EFL
1604         https://bugs.webkit.org/show_bug.cgi?id=128928
1605
1606         Reviewed by Carlos Garcia Campos.
1607
1608         The PID of the crashed process is now correctly supplied to the
1609         crash log reporter. The kernel core_pattern needs to be updated
1610         after this change to something like:
1611
1612         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1613
1614         * Scripts/process-linux-coredump: Added.
1615         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1616         * Scripts/webkitpy/port/efl.py:
1617         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1618         * Scripts/webkitpy/port/gtk.py:
1619         (GtkPort._get_crash_log): Ditto.
1620         * Scripts/webkitpy/port/linux_get_crash_log.py:
1621         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1622         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1623         (GDBCrashLogGenerator): Deleted.
1624         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1625         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
1626         * WebKitTestRunner/TestController.cpp:
1627         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
1628         (WTR::TestController::databaseProcessDidCrash): Ditto.
1629         (WTR::TestController::processDidCrash): Ditto.
1630
1631 2016-07-23  Youenn Fablet  <youenn@apple.com>
1632
1633         WPT stash server should be kept running when launching wpt server
1634         https://bugs.webkit.org/show_bug.cgi?id=160052
1635
1636         Reviewed by Sam Weinig.
1637
1638         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1639         (main): waiting to read stdin while stash server is started.
1640
1641 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1642
1643         Media controls should be displayed for media in media documents
1644         https://bugs.webkit.org/show_bug.cgi?id=160104
1645         <rdar://problem/27438936>
1646
1647         Reviewed by Myles C. Maxfield.
1648
1649         Verifies that even a small video with audio in a media document gets media controls.
1650
1651         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1652         (TestWebKitAPI::TEST):
1653
1654 2016-07-22  Michael Saboff  <msaboff@apple.com>
1655
1656         REGRESSION(203616): no FTL testing was inadvertently removed
1657         https://bugs.webkit.org/show_bug.cgi?id=160100
1658
1659         Rubber-stamped by Filip Pizlo.
1660
1661         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
1662         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
1663         logic for the runLayout and runNoisy variants to match the run test logic,
1664         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
1665         enabled platforms.
1666
1667         * Scripts/run-jsc-stress-tests:
1668
1669 2016-07-22  Brady Eidson  <beidson@apple.com>
1670
1671         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
1672         https://bugs.webkit.org/show_bug.cgi?id=160089
1673
1674         Reviewed by Darin Adler.
1675
1676         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1677         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
1678         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
1679
1680 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
1681
1682         [GTK] Improved exclusion patterns in make-dist.py manifest.
1683         https://bugs.webkit.org/show_bug.cgi?id=160094
1684
1685         Reviewed by Michael Catanzaro.
1686
1687         * gtk/manifest.txt.in:
1688         Exclude Platform*.cmake files for more ports.
1689         Removed obsolete .gyp and .pro.user patterns.
1690         Exclude 'Configurations' and 'spi' directories.
1691         Exclude CMakeLists.txt.user (Qt Creator IDE).
1692
1693 2016-07-22  Michael Saboff  <msaboff@apple.com>
1694
1695         Don't run FTL related JSC stress tests on non-FTL platforms
1696         https://bugs.webkit.org/show_bug.cgi?id=160033
1697
1698         Reviewed by Mark Lam.
1699
1700         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
1701         Refactored several of the runXXX test methods to always runXXXDefault and made those
1702         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
1703         doesn't cause a problem.
1704
1705         * Scripts/run-jsc-stress-tests:
1706
1707 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
1708
1709         IWebView::mainFrame crashes if called after IWebView::close
1710         https://bugs.webkit.org/show_bug.cgi?id=32868
1711
1712         Reviewed by Brent Fulgham.
1713
1714         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1715         (TestWebKitAPI::TEST_F): Added test.
1716
1717 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1718
1719         [GTK] Enable threaded compositor by default
1720         https://bugs.webkit.org/show_bug.cgi?id=160079
1721
1722         Reviewed by Žan Doberšek.
1723
1724         * Scripts/webkitperl/FeatureList.pm:
1725
1726 2016-07-22  Youenn Fablet  <youenn@apple.com>
1727
1728         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
1729         https://bugs.webkit.org/show_bug.cgi?id=159921
1730
1731         Reviewed by Brian Burg.
1732
1733         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
1734
1735         * Scripts/webkitpy/codegen/main.py:
1736         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
1737         (BuiltinsGeneratorTests):
1738         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
1739         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
1740         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
1741         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
1742
1743 2016-07-21  Dan Bernstein  <mitz@apple.com>
1744
1745         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
1746         https://bugs.webkit.org/show_bug.cgi?id=160072
1747
1748         Reviewed by Andy Estes.
1749
1750         * Scripts/webkitdirs.pm:
1751         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
1752           for old Xcode versions.
1753         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
1754           to readXcodeUserDefault.
1755         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
1756           debugger.
1757         (determineDebugger): Ditto.
1758         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
1759           7.0.
1760         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
1761           switches.
1762         (execMacWebKitAppForDebugging): Removed support for GDB.
1763
1764 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1765
1766         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
1767         https://bugs.webkit.org/show_bug.cgi?id=160066
1768
1769         Reviewed by Dean Jackson.
1770
1771         * DumpRenderTree/mac/DumpRenderTree.mm:
1772         (setDefaultsToConsistentValuesForTesting): Deleted.
1773         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1774         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1775         * WebKitTestRunner/TestController.cpp:
1776         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1777         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1778         (WTR::initializeWebViewConfiguration): Deleted.
1779
1780 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
1781
1782         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
1783         https://bugs.webkit.org/show_bug.cgi?id=159980
1784         rdar://problem/27450825
1785
1786         Reviewed by Dan Bernstein.
1787
1788         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1789         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
1790         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
1791         when our delegate has hit -dealloc.
1792         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
1793         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
1794         will not be messaged.
1795
1796 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1797
1798         Follow-up patch to r203520
1799         https://bugs.webkit.org/show_bug.cgi?id=159967
1800         <rdar://problem/26964090>
1801
1802         Unreviewed.
1803
1804         * DumpRenderTree/mac/DumpRenderTree.mm:
1805         (setDefaultsToConsistentValuesForTesting):
1806         * WebKitTestRunner/TestController.cpp:
1807         (WTR::TestController::resetPreferencesToConsistentValues):
1808
1809 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1810
1811         [iPhone] Playing a video on tudou.com plays only sound, no video
1812         https://bugs.webkit.org/show_bug.cgi?id=159967
1813         <rdar://problem/26964090>
1814
1815         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
1816
1817         Migrate tests to use new SPI.
1818
1819         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1820         (RequiresUserActionForPlaybackTest::SetUp):
1821         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1822         (WTR::initializeWebViewConfiguration):
1823
1824 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
1825
1826         Clarify testing mode names in run-jsc-stress-tests
1827         https://bugs.webkit.org/show_bug.cgi?id=160021
1828
1829         Reviewed by Mark Lam.
1830
1831         Default should mean really default, not default with disabled FTL, renamed
1832         - runMozillaTestDefault to runMozillaTestNoFTL
1833         - runMozillaTestDefaultFTL to runMozillaTestDefault
1834         - runDefault to runNoFTL
1835         - runDefaultFTL to runDefault
1836         - runLayoutTestDefault to runLayoutTestNoFTL
1837         - runLayoutTestDefaultFTL to runLayoutTestDefault
1838         - runNoisyTestDefault to runNoisyTestNoFTL
1839         - runNoisyTestDefaultFTL to runNoisyTestDefault
1840
1841         * Scripts/run-jsc-stress-tests:
1842
1843 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
1844
1845         WebBackForwardList's currentIndex could get out of bounds when filtering items.
1846         https://bugs.webkit.org/show_bug.cgi?id=159986
1847
1848         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
1849         to 0.
1850
1851         Reviewed by Dan Bernstein.
1852
1853         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1854         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
1855         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
1856         (TEST):
1857
1858 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1859
1860         [GTK] Web view background colors don't work in accelerated compositing mode
1861         https://bugs.webkit.org/show_bug.cgi?id=159455
1862
1863         Reviewed by Michael Catanzaro.
1864
1865         Set always RGBA visual to the view widget when setting a background color.
1866
1867         * MiniBrowser/gtk/BrowserWindow.c:
1868         (browser_window_set_background_color):
1869
1870 2016-07-20  Youenn Fablet  <youenn@apple.com>
1871
1872         Bots should run built-ins generator tests
1873         https://bugs.webkit.org/show_bug.cgi?id=159971
1874
1875         Reviewed by Alexey Proskuryakov.
1876
1877         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1878         (RunBuiltinsTests): New step to run built-in generator tests.
1879         (TestFactory.__init__): Adding an additional step for bultin generator tests.
1880         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
1881         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
1882
1883 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1884
1885         Revert temporary fix r203417
1886         https://bugs.webkit.org/show_bug.cgi?id=160001
1887
1888         Reviewed by Alexey Proskuryakov.
1889
1890         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
1891
1892 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1893
1894         REGRESSION(r148588): ews classes might get garbage collected
1895         https://bugs.webkit.org/show_bug.cgi?id=159990
1896
1897         Reviewed by Ryosuke Niwa.
1898
1899         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
1900         in a variable so that they do not get garbage collected.
1901
1902 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
1903
1904         Add API test for layout constraints after exit fullscreen
1905         https://bugs.webkit.org/show_bug.cgi?id=159900
1906
1907         Reviewed by Jon Lee.
1908
1909         Added Fullscreen.LaytoutConstraints API test. 
1910         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
1911
1912         This test compares layout constraints on the web view before and after fullscreen to make sure 
1913         they are preserved.
1914
1915         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
1916         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
1917         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1918         (TestWebKitAPI::TEST):
1919
1920 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
1921
1922         Disable two failing API tests.
1923
1924         Unreviewed test gardening.
1925
1926         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
1927         (TestWebKitAPI::TEST):
1928
1929 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1930
1931         Unreviewed iOS build fix.
1932
1933         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
1934
1935 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1936
1937         Media controls don't appear when pausing a small autoplaying video
1938         https://bugs.webkit.org/show_bug.cgi?id=159972
1939         <rdar://problem/27180657>
1940
1941         Reviewed by Beth Dakin.
1942
1943         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
1944         for simulating basic user interaction in VideoControlsManager.
1945
1946         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1947         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1948         (-[WKWebView mouseDownAtPoint:]):
1949         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
1950         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
1951         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
1952         (TestWebKitAPI::TEST):
1953         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
1954
1955 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
1956
1957         [Win] MathML fonts are not found.
1958         https://bugs.webkit.org/show_bug.cgi?id=159920
1959
1960         Reviewed by Alex Christensen.
1961
1962         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
1963         for a specific registry key value.
1964
1965         * Scripts/webkitdirs.pm:
1966         (fontExists):
1967
1968 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
1969
1970         Improve prepare-ChangeLog for @media blocks
1971         https://bugs.webkit.org/show_bug.cgi?id=159907
1972
1973         Reviewed by Timothy Hatcher.
1974
1975         * Scripts/prepare-ChangeLog:
1976         (get_selector_line_ranges_for_css):
1977         Get a range for @media blocks just like a selector.
1978             Start Line = line with '{'
1979             End line = line with '}'
1980             Name = "@media ..."
1981
1982         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
1983         Improved error messages for unbalanced portions.
1984
1985         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
1986         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
1987         (.media-query::before):
1988         (@media only screen and (max-width: 980px)):
1989         (.media-query a):
1990         (@media (-webkit-min-device-pixel-ratio: 2)):
1991         (.both a):
1992         (.both b):
1993         (.media-query b):
1994         (.media-query::after):
1995
1996 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
1997
1998         Fix expectedFailErrorHandler in run-jsc-stress-tests
1999         https://bugs.webkit.org/show_bug.cgi?id=159811
2000
2001         Reviewed by Yusuke Suzuki.
2002
2003         * Scripts/run-jsc-stress-tests:
2004
2005 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2006
2007         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2008
2009         * TestWebKitAPI/PlatformMac.cmake:
2010
2011 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2012
2013         The default testing mode should not involve disabling the FTL JIT
2014         https://bugs.webkit.org/show_bug.cgi?id=159929
2015
2016         Rubber stamped by Mark Lam and Saam Barati.
2017         
2018         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2019         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2020         FTL was not the default. You had to enable it with an option.
2021         
2022         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2023         all of the major ports. This has become a serious pain. For example, it's useful to be able
2024         to say that a test should only run in the default config that is representative of what a
2025         normal user would see if they ran JSC. Clearly, this would be a config that does not
2026         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2027         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2028         
2029         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2030         try to fix it, because:
2031         
2032         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2033           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2034           doesn't do anything. The code is not really structured to allow this.
2035         
2036         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2037           disabled in testing. On the other hand there are already build bots that do FTL tests
2038           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2039           preserving this broken feature, we should create something that (a) acknowledges the fact
2040           that the FTL is the default on those platforms that support it and (b) avoids running
2041           no-ftl tests on precisely those platforms that don't have FTL.
2042         
2043         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2044           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2045           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2046           pretending that the FTL JIT is not the default just because some bots used that as an
2047           optimization.
2048         
2049         This change allows me to speed up some debug tests and paint some bots green.
2050
2051         * Scripts/run-javascriptcore-tests:
2052         (runJSCStressTests):
2053         * Scripts/run-jsc-stress-tests:
2054
2055 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2056
2057         Fix API test after r203426.
2058         https://bugs.webkit.org/show_bug.cgi?id=159949
2059
2060         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2061         (TEST):
2062         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2063         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2064
2065 2016-07-19  Andy Estes  <aestes@apple.com>
2066
2067         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2068         https://bugs.webkit.org/show_bug.cgi?id=159956
2069
2070         Reviewed by Dan Bernstein.
2071
2072         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2073         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2074         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2075         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2076
2077 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2078
2079         Add regression test for r203392
2080         https://bugs.webkit.org/show_bug.cgi?id=159949
2081
2082         Reviewed by Brady Eidson.
2083
2084         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2085         (fileSize):
2086         (swizzledBundleIdentifierWebBookmarksD):
2087         (defaultApplicationCacheDirectory):
2088         (TEST):
2089         (swizzledBundleIdentifierMobileSafari): Deleted.
2090         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2091         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2092         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2093
2094 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2095
2096         Add regression test for r203392
2097         https://bugs.webkit.org/show_bug.cgi?id=159949
2098
2099         Reviewed by Brady Eidson.
2100
2101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2102         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2103         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2104         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2105         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2106         (TEST):
2107         (fileSize):
2108         (swizzledBundleIdentifierMobileSafari):
2109         (swizzledBundleIdentifierWebBookmarksD):
2110         (defaultApplicationCacheDirectory):
2111         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2112         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2113         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2114         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2115
2116 2016-07-19  Keith Miller  <keith_miller@apple.com>
2117
2118         Test262 should have a file with the revision and url
2119         https://bugs.webkit.org/show_bug.cgi?id=159937
2120
2121         Reviewed by Mark Lam.
2122
2123         The import script should update the information from
2124         the path to the test262 repository it gets.
2125
2126         * Scripts/import-test262-tests:
2127
2128 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2129
2130         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2131         To be deleted once the root cause is found and addressed.
2132
2133         * EWSTools/start-queue-mac.sh:
2134
2135 2016-07-19  Frederic Wang  <fwang@igalia.com>
2136
2137         [win] Fixup the register name for STIX Math and Latin Modern Math
2138
2139         Unreviewed follow-up of r203406
2140
2141         * Scripts/webkitdirs.pm:
2142         (checkInstalledTools):
2143
2144 2016-07-19  Frederic Wang  <fwang@igalia.com>
2145
2146         [win] Update the list of MathML fonts
2147         https://bugs.webkit.org/show_bug.cgi?id=156838
2148
2149         The set of recommended math fonts is now described at
2150         https://trac.webkit.org/wiki/MathML/Fonts
2151         We update the Perl script to use the latest list of fonts.
2152
2153         Reviewed by Brent Fulgham.
2154
2155         * Scripts/webkitdirs.pm:
2156         (checkInstalledTools):
2157
2158 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2159
2160         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2161         https://bugs.webkit.org/show_bug.cgi?id=159342
2162
2163         Reviewed by Darin Adler.
2164
2165         Implement required functions in event sender.
2166
2167         * DumpRenderTree/PlatformWin.cmake:
2168         * DumpRenderTree/win/EventSender.cpp:
2169         (monitorWheelEvents): Added.
2170         (callAfterScrollingCompletes): Added.
2171
2172 2016-07-19  Youenn Fablet  <youenn@apple.com>
2173
2174         Add new aliases to http test server
2175         https://bugs.webkit.org/show_bug.cgi?id=159878
2176
2177         Reviewed by Darin Adler.
2178
2179         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2180         Adding explicitly these links to perl script.
2181         Extracting default alias in an aliases.json file.
2182         Reading that file from python scripts to initialize aliases from that file.
2183
2184         Python script changes covered by unit tests and changed layout test.
2185
2186         * Scripts/webkitperl/httpd.pm:
2187         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2188         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2189         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2190         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2191         Adding -c directives for each alias.
2192         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2193         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2194         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2195         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2196         Adding alias directive for each alias.
2197         (Lighttpd._prepare_config):
2198         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2199         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2200         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2201         layout tests directory.
2202         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2203         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2204         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2205
2206 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2207
2208         EWS console logs doesn't go to log file
2209         https://bugs.webkit.org/show_bug.cgi?id=159539
2210         <rdar://problem/24464570>
2211
2212         Reviewed by David Kilzer.
2213
2214         * Scripts/webkitpy/common/system/logutils.py:
2215         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2216         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2217         to filesystem. It also supports passing MockFilesystem.
2218         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2219         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2220         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2221         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2222         (_test_ews): Same.
2223         * Scripts/webkitpy/tool/commands/queues.py:
2224         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2225         (AbstractQueue._log_directory): Using filesystem object instead of os.
2226         (AbstractQueue.queue_log_path): Same.
2227         (AbstractQueue.__init__): Passed host parameter.
2228         (PatchProcessingQueue.__init__): Same.
2229         (CommitQueue.__init__): Same.
2230         (AbstractReviewQueue.__init__): Same.
2231         (StyleQueue.__init__): Same.
2232         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2233         (TestCommitQueue): Passed MockHost() as host.
2234         (TestCommitQueue.__init__): Same.
2235         (TestQueue.__init__): Same.
2236         (TestReviewQueue.__init__): Same.
2237         (TestFeederQueue.__init__): Same.
2238         (AbstractPatchQueueTest.test_next_patch): Same.
2239         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2240         (test_commit_queue_failure): Same.
2241         (MockCommitQueueTask.results_from_patch_test_run): Same.
2242         (test_rollout_lands): Same.
2243         (test_non_valid_patch): Same.
2244         (test_auto_retry): Same.
2245         (test_style_queue_with_watch_list_exception): Same.
2246
2247 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2248
2249         WTF::Lock should be fair eventually
2250         https://bugs.webkit.org/show_bug.cgi?id=159384
2251
2252         Reviewed by Geoffrey Garen.
2253
2254         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2255
2256 2016-07-17  Sam Weinig  <sam@webkit.org>
2257
2258         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2259         <rdar://problem/26554137>
2260         https://bugs.webkit.org/show_bug.cgi?id=159856
2261
2262         Reviewed by Dan Bernstein.
2263
2264         * MiniBrowser/mac/WK2BrowserWindowController.m:
2265         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2266         Add basic window.open implementation.
2267
2268         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2269         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2270         to open a single non-web URL, all others are dropped.
2271
2272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2273         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2274         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2275         Add API for the new SPI.
2276
2277 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2278
2279         [JSC] Enable test262 module tests
2280         https://bugs.webkit.org/show_bug.cgi?id=159854
2281
2282         Reviewed by Saam Barati.
2283
2284         Use --module-file instead.
2285
2286         * Scripts/run-jsc-stress-tests:
2287
2288 2016-07-16  Chris Dumez  <cdumez@apple.com>
2289
2290         Unreviewed, rolling out r203318.
2291
2292         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2293         SunSpider)
2294
2295         Reverted changeset:
2296
2297         "[JSC] Change some parameters based on a random search"
2298         https://bugs.webkit.org/show_bug.cgi?id=158514
2299         http://trac.webkit.org/changeset/203318
2300
2301 2016-07-16  Chris Dumez  <cdumez@apple.com>
2302
2303         Add move constructor / assignment operator to ListHashSet
2304         https://bugs.webkit.org/show_bug.cgi?id=159837
2305
2306         Reviewed by Darin Adler.
2307
2308         Add API tests.
2309
2310         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2311         (TestWebKitAPI::TEST):
2312
2313 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2314
2315         [JSC] Change some parameters based on a random search
2316         https://bugs.webkit.org/show_bug.cgi?id=158514
2317
2318         Reviewed by Saam Barati.
2319
2320         * Scripts/run-jsc-stress-tests:
2321
2322 2016-07-15  Jon Davis  <jond@apple.com>
2323
2324         Changed the start page URL for WebKit Nightly builds.
2325         https://bugs.webkit.org/show_bug.cgi?id=159816
2326
2327         Reviewed by Timothy Hatcher.
2328
2329         * WebKitLauncher/start.html:
2330
2331 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2332
2333         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2334         https://bugs.webkit.org/show_bug.cgi?id=159414
2335
2336         Reviewed by Brent Fulgham.
2337
2338         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2339         when the HDC parameter is invalid.
2340
2341         * TestWebKitAPI/PlatformWin.cmake:
2342         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2343         (TestWebKitAPI::TEST):
2344
2345 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2346
2347         [GTK] Add basic tabs support to MiniBrowser
2348         https://bugs.webkit.org/show_bug.cgi?id=159803
2349
2350         Reviewed by Sergio Villar Senin.
2351
2352         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2353         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2354
2355         * MiniBrowser/gtk/BrowserTab.c: Added.
2356         (titleChanged):
2357         (isLoadingChanged):
2358         (decidePolicy):
2359         (removeChildIfInfoBar):
2360         (loadChanged):
2361         (createInfoBarQuestionMessage):
2362         (tlsErrorsDialogResponse):
2363         (loadFailedWithTLSerrors):
2364         (permissionRequestDialogResponse):
2365         (decidePermissionRequest):
2366         (colorChooserRGBAChanged):
2367         (popoverColorClosed):
2368         (colorChooserRequestFinished):
2369         (runColorChooserCallback):
2370         (inspectorOpenedInWindow):
2371         (inspectorClosed):
2372         (browserTabSetProperty):
2373         (browserTabFinalize):
2374         (browser_tab_init):
2375         (browserTabConstructed):
2376         (browser_tab_class_init):
2377         (getInternalURI):
2378         (browser_tab_new):
2379         (browser_tab_get_web_view):
2380         (browser_tab_load_uri):
2381         (browser_tab_get_title_widget):
2382         (browser_tab_set_status_text):
2383         (browser_tab_toggle_inspector):
2384         (browser_tab_start_search):
2385         (browser_tab_stop_search):
2386         (browser_tab_add_accelerators):
2387         (fullScreenMessageTimeoutCallback):
2388         (browser_tab_enter_fullscreen):
2389         (browser_tab_leave_fullscreen):
2390         * MiniBrowser/gtk/BrowserTab.h: Added.
2391         * MiniBrowser/gtk/BrowserWindow.c:
2392         (getExternalURI):
2393         (browserWindowSetStatusText):
2394         (reloadOrStopCallback):
2395         (goBackCallback):
2396         (goForwardCallback):
2397         (settingsCallback):
2398         (webViewURIChanged):
2399         (browserWindowHistoryItemActivated):
2400         (browserWindowUpdateNavigationActions):
2401         (webViewCreate):
2402         (webViewEnterFullScreen):
2403         (webViewLeaveFullScreen):
2404         (webViewDecidePolicy):
2405         (browserWindowCanZoomIn):
2406         (browserWindowCanZoomOut):
2407         (browserWindowZoomIn):
2408         (browserWindowZoomOut):
2409         (scrollEventCallback):
2410         (faviconChanged):
2411         (webViewIsLoadingChanged):
2412         (defaultZoomCallback):
2413         (searchCallback):
2414         (newTabCallback):
2415         (toggleWebInspector):
2416         (reloadPage):
2417         (reloadPageIgnoringCache):
2418         (stopPageLoad):
2419         (loadHomePage):
2420         (editingCommandCallback):
2421         (insertImageCommandCallback):
2422         (insertLinkCommandCallback):
2423         (browserWindowSetupEditorToolbar):
2424         (browserWindowSwitchTab):
2425         (browserWindowTabAddedOrRemoved):
2426         (browser_window_init):
2427         (browserWindowConstructed):
2428         (browserWindowSaveSession):
2429         (browserWindowDeleteEvent):
2430         (browser_window_new):
2431         (browser_window_append_view):
2432         (browser_window_load_uri):
2433         (browser_window_load_session):
2434         (browser_window_set_background_color):
2435         (resetStatusText): Deleted.
2436         (activateUriEntryCallback): Deleted.
2437         (webViewTitleChanged): Deleted.
2438         (resetEntryProgress): Deleted.
2439         (browserWindowCreateBackForwardMenu): Deleted.
2440         (webViewReadyToShow): Deleted.
2441         (webViewLoadFailed): Deleted.
2442         (webViewMouseTargetChanged): Deleted.
2443         (browserWindowUpdateZoomActions): Deleted.
2444         (webViewZoomLevelChanged): Deleted.
2445         (updateUriEntryIcon): Deleted.
2446         (zoomInCallback): Deleted.
2447         (zoomOutCallback): Deleted.
2448         (toggleFullScreen): Deleted.
2449         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2450         (browserWindowFinalize): Deleted.
2451         (browser_window_class_init): Deleted.
2452         * MiniBrowser/gtk/BrowserWindow.h:
2453         * MiniBrowser/gtk/CMakeLists.txt:
2454         * MiniBrowser/gtk/main.c:
2455         (createBrowserTab):
2456         (aboutURISchemeRequestCallback):
2457         (main):
2458         (parseBackgroundColor): Deleted.
2459
2460 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2461
2462         Allow RefPtrs of const RefCounted types
2463         https://bugs.webkit.org/show_bug.cgi?id=158269
2464
2465         Reviewed by Anders Carlsson.
2466
2467         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2468         (TestWebKitAPI::TEST):
2469         (TestWebKitAPI::ConstRefCounted::create):
2470         (TestWebKitAPI::returnConstRefCountedRef):
2471         (TestWebKitAPI::returnRefCountedRef):
2472
2473 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2474
2475         Test WTF.StringViewIterators is crashing since r203119
2476         https://bugs.webkit.org/show_bug.cgi?id=159710
2477
2478         Reviewed by Darin Adler.
2479
2480         There are two problems in the test case added in r203119. First is that it's testing
2481         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2482         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2483         const reference to the string view member of the deleted CodePoints object.
2484
2485         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2486         (TestWebKitAPI::TEST):
2487
2488 2016-07-13  Daniel Bates  <dabates@apple.com>
2489
2490         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2491         https://bugs.webkit.org/show_bug.cgi?id=159738
2492         <rdar://problem/27304649>
2493
2494         Reviewed by Dan Bernstein.
2495
2496         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2497         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2498         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2499         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2500
2501         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2502         * WebKitTestRunner/ios/TestControllerIOS.mm:
2503         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2504         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2505
2506 2016-07-13  Beth Dakin  <bdakin@apple.com>
2507
2508         Attempted build fix.
2509
2510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2511
2512 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2513
2514         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2515         https://bugs.webkit.org/show_bug.cgi?id=159686
2516
2517         Reviewed by Chris Dumez.
2518
2519         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2520
2521         * WebKitTestRunner/TestController.cpp:
2522         (WTR::runOpenPanel):
2523         (WTR::TestController::createOtherPage):
2524         (WTR::TestController::createWebViewWithOptions):
2525
2526 2016-07-13  Beth Dakin  <bdakin@apple.com>
2527
2528         Add more candidate tests
2529         https://bugs.webkit.org/show_bug.cgi?id=159730
2530
2531         Reviewed by Tim Horton.
2532
2533         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
2534         two new tests to that file.
2535         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2536         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2537         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2538         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2539         (TestWebKitAPI::TEST):
2540         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2541
2542 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2543
2544         AX: [ATK] spinbutton-crash.html fails
2545         https://bugs.webkit.org/show_bug.cgi?id=159723
2546
2547         Reviewed by Chris Fleizach.
2548
2549         Implement support for AXDecrementButton and AXIncrementButton in
2550         ATK's AccessibilityUIElement::uiElementAttributeValue().
2551
2552         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2553         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2554
2555 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2556
2557         [EFL] [GTK] Enable back crypto subtle on development builds.
2558         https://bugs.webkit.org/show_bug.cgi?id=159260
2559
2560         Reviewed by Carlos Garcia Campos.
2561
2562         * Scripts/webkitperl/FeatureList.pm:
2563
2564 2016-07-12  Mark Lam  <mark.lam@apple.com>
2565
2566         We should use different stack limits for stack checks from JS and host code.
2567         https://bugs.webkit.org/show_bug.cgi?id=159442
2568         <rdar://problem/26889188>
2569
2570         Reviewed by Geoffrey Garen.
2571
2572         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2573         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
2574         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
2575         order to keep the js/regress-139548.html test happy with this patch.
2576
2577         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2578         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
2579
2580         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2581         (-[LTRelayController _environmentVariables]):
2582         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2583         (main):
2584
2585 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
2586
2587         platformUserPreferredLanguages on Mac should not try to put the region into the language
2588         https://bugs.webkit.org/show_bug.cgi?id=159693
2589
2590         Rubber stamped by Alexey Proskuryakov.
2591         
2592         Revert the test change in r200105.
2593
2594         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2595         (TestWebKitAPI::languageForSystemLanguage):
2596
2597 2016-07-12  Chris Dumez  <cdumez@apple.com>
2598
2599         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2600         https://bugs.webkit.org/show_bug.cgi?id=159663
2601         <rdar://problem/18995873>
2602
2603         Reviewed by Benjamin Poulain.
2604
2605         Add API test coverage.
2606
2607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2608         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2609         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2610         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2611         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2612         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2613         (TEST):
2614
2615 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
2616
2617         Relax ordering requirements on StringView::CodePoints iterator
2618         https://bugs.webkit.org/show_bug.cgi?id=159609
2619
2620         Reviewed by Darin Adler.
2621
2622         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2623         (TestWebKitAPI::TEST):
2624
2625 2016-07-12  Youenn Fablet  <youenn@apple.com>
2626
2627         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
2628         https://bugs.webkit.org/show_bug.cgi?id=159564
2629
2630         Reviewed by Brian Burg.
2631
2632         * Scripts/webkitpy/codegen/main.py:
2633         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
2634
2635 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2636
2637         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2638         https://bugs.webkit.org/show_bug.cgi?id=159671
2639
2640         Reviewed by Csaba Osztrogonác.
2641
2642         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2643         https://bugs.webkit.org/show_bug.cgi?id=89235
2644
2645         So this guard can be removed in build scripts.
2646
2647         * Scripts/webkitperl/FeatureList.pm:
2648         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2649
2650 2016-07-11  Jason Marcell  <jmarcell@apple.com>
2651
2652         SVN.create_patch should find svn-create-patch relative to the WebKit root.
2653         https://bugs.webkit.org/show_bug.cgi?id=159652
2654
2655         Reviewed by Daniel Bates.
2656
2657         * Scripts/webkitpy/common/checkout/scm/svn.py:
2658         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
2659
2660 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2661
2662         Implement grapheme cluster iterator on StringView
2663         https://bugs.webkit.org/show_bug.cgi?id=159598
2664
2665         Reviewed by Anders Carlsson.
2666
2667         This is in preparation for honoring the second argument to FontFaceSet.load().
2668
2669         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2670         (TestWebKitAPI::compareLoopIterations):
2671         (TestWebKitAPI::TEST):
2672
2673 2016-07-11  Nan Wang  <n_wang@apple.com>
2674
2675         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
2676         https://bugs.webkit.org/show_bug.cgi?id=158364
2677
2678         Reviewed by Anders Carlsson.
2679
2680         Added a function in TestRunner so that we can toggle the ignoring viewport
2681         scale limits setting. Also added a test option for that in order to change the 
2682         configuration of the webview in test.
2683
2684         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2685         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2686         (WTR::TestRunner::setNavigationGesturesEnabled):
2687         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2688         (WTR::nextUIScriptCallbackID):
2689         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2690         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2691         * WebKitTestRunner/TestController.cpp:
2692         (WTR::TestController::resetStateToConsistentValues):
2693         (WTR::updateTestOptionsFromTestHeader):
2694         (WTR::TestController::setNavigationGesturesEnabled):
2695         (WTR::TestController::setIgnoresViewportScaleLimits):
2696         (WTR::TestController::platformWillRunTest):
2697         * WebKitTestRunner/TestController.h:
2698         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2699         * WebKitTestRunner/TestInvocation.cpp:
2700         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2701         * WebKitTestRunner/TestOptions.h:
2702         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2703         (WTR::TestController::platformCreateWebView):
2704
2705 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
2706
2707         [GTK] install-dependencies should not install packages built by jhbuild.
2708         https://bugs.webkit.org/show_bug.cgi?id=159628
2709
2710         Reviewed by Michael Catanzaro.
2711
2712         * gtk/install-dependencies:
2713         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
2714
2715 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
2716
2717         System proxy settings not used when building deps with jhbuild
2718         https://bugs.webkit.org/show_bug.cgi?id=159567
2719
2720         Reviewed by Michael Catanzaro.
2721
2722         This adds the gsettings-desktop-schemas-devel build dep to enable
2723         the libgiognomeproxy.so gio module in glib-networking, which uses
2724         GSettings on org.gnome.system.proxy.
2725         This is needed to query system proxy settings for Gnome desktops.
2726
2727         dconf can be manually added to jhbuild to build the
2728         libdconfsettings.so gio module for GSettings, so that
2729         libgiognomeproxy.so can access system settings.
2730           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
2731
2732         As an alternative to dconf settings, this commit also adds the
2733         libproxy-devel build dep to enable the libgiolibproxy.so module in
2734         glib-networking (suggested by Fujii Hironori).
2735
2736         It is useful to read proxy settings from environment variables.
2737         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
2738         environment variable to force using the envvar module in libproxy.
2739
2740         * gtk/install-dependencies:
2741
2742 2016-07-11  Mark Lam  <mark.lam@apple.com>
2743
2744         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
2745         https://bugs.webkit.org/show_bug.cgi?id=159524
2746
2747         Reviewed by Michael Saboff.
2748
2749         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
2750         Also fixed up some tests to behave better to work with this new limit.  This
2751         should make stack overflow tests complete sooner.
2752
2753         * Scripts/run-jsc-stress-tests:
2754         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2755         (main):
2756
2757 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2758
2759         [GTK] Whitespace fixes in install-dependencies script
2760
2761         Unreviewed.
2762
2763         * gtk/install-dependencies:
2764
2765 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2766
2767         [GTK] Install missing Fedora dependencies
2768
2769         Unreviewed.
2770
2771         * gtk/install-dependencies:
2772
2773 2016-07-09  Dan Bernstein  <mitz@apple.com>
2774
2775         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
2776         https://bugs.webkit.org/show_bug.cgi?id=159600
2777
2778         Reviewed by Daniel Bates.
2779
2780         * Scripts/git-add-reviewer:
2781         Added the -s|--rubber-stamp option.
2782         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
2783           new option.
2784
2785 2016-07-08  Andy Estes  <aestes@apple.com>
2786
2787         [Content Filtering] Load blocked pages more like other error pages are loaded
2788         https://bugs.webkit.org/show_bug.cgi?id=159485
2789         <rdar://problem/26014076>
2790
2791         Reviewed by Brady Eidson.
2792
2793         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2794         to a content filtering provisional navigation failure is ignored in preference of
2795         ContentFilter's own error page.
2796
2797         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2799         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2800         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2801         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2802         (loadAlternateTest):
2803         (TEST):
2804         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2805         (-[MockContentFilterEnabler initWithCoder:]):
2806         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2807         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2808         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2809         (TestWebKitAPI::loadAlternateTest):
2810         (TestWebKitAPI::TEST):
2811
2812 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2813
2814         Unreviewed, rolling out r202944.
2815         https://bugs.webkit.org/show_bug.cgi?id=159570
2816
2817         caused some tests to crash under GuardMalloc (Requested by
2818         estes on #webkit).
2819
2820         Reverted changeset:
2821
2822         "[Content Filtering] Load blocked pages more like other error
2823         pages are loaded"
2824         https://bugs.webkit.org/show_bug.cgi?id=159485
2825         http://trac.webkit.org/changeset/202944
2826
2827 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
2828
2829         Remove mrobinson from the MathML watchlist
2830         https://bugs.webkit.org/show_bug.cgi?id=159559
2831
2832         Reviewed by Philippe Normand.
2833
2834         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
2835
2836 2016-07-08  Brady Eidson  <beidson@apple.com>
2837
2838         Clearing LocalStorage doesn't also delete -wal and -shm files.
2839         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
2840
2841         Reviewed by Brent Fulgham.
2842         Also helpfully picked over by Andy "Never Forgets" Estes.
2843
2844         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2845         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
2846         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
2847
2848 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
2849
2850         Removed Qt leftovers from Tools.
2851         https://bugs.webkit.org/show_bug.cgi?id=159557
2852
2853         Reviewed by Csaba Osztrogonác.
2854
2855         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2856         Removed 'qt' platform config.
2857         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2858         Deleted non-functional e-mail address.
2859
2860 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2861
2862         Unreviewed, rolling out r202967.
2863         https://bugs.webkit.org/show_bug.cgi?id=159556
2864
2865         This patch caused crashes in https tests on Windows (Requested
2866         by perarne on #webkit).
2867
2868         Reverted changeset:
2869
2870         "[Win] The test http/tests/security/contentSecurityPolicy
2871         /upgrade-insecure-requests/basic-upgrade.https.html is
2872         failing."
2873         https://bugs.webkit.org/show_bug.cgi?id=159510
2874         http://trac.webkit.org/changeset/202967
2875
2876 2016-07-08  Youenn Fablet  <youenn@apple.com>
2877
2878         Generate WebCore builtin wrapper files
2879         https://bugs.webkit.org/show_bug.cgi?id=159461
2880
2881         Reviewed by Brian Burg.
2882
2883         * Scripts/webkitpy/codegen/main.py:
2884         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
2885         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
2886
2887 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
2888
2889         [EFL] Fix build when media-stream is enabled.
2890         https://bugs.webkit.org/show_bug.cgi?id=159206
2891
2892         Bump up the openwebrtc to find the correct package.
2893
2894         Reviewed by Gyuyoung Kim.
2895
2896         * efl/jhbuild.modules:
2897         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
2898
2899 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2900
2901         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
2902         https://bugs.webkit.org/show_bug.cgi?id=159510
2903
2904         Reviewed by Brent Fulgham.
2905
2906         Allow any https certificate when running tests.
2907
2908         * DumpRenderTree/win/DumpRenderTree.cpp:
2909         (runTest):
2910
2911 2016-07-07  Beth Dakin  <bdakin@apple.com>
2912
2913         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
2914         https://bugs.webkit.org/show_bug.cgi?id=159532
2915         -and corresponding-
2916         rdar://problem/27177179
2917
2918         Reviewed by Tim Horton.
2919
2920         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
2921         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
2922
2923 2016-07-07  Andy Estes  <aestes@apple.com>
2924
2925         [Content Filtering] Load blocked pages more like other error pages are loaded
2926         https://bugs.webkit.org/show_bug.cgi?id=159485
2927         <rdar://problem/26014076>
2928
2929         Reviewed by Brady Eidson.
2930
2931         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2932         to a content filtering provisional navigation failure is ignored in preference of
2933         ContentFilter's own error page.
2934
2935         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2936         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2937         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2938         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2939         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2940         (loadAlternateTest):
2941         (TEST):
2942         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2943         (-[MockContentFilterEnabler initWithCoder:]):
2944         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2945         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2946         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2947         (TestWebKitAPI::loadAlternateTest):
2948         (TestWebKitAPI::TEST):
2949
2950 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2951
2952         Unreviewed: add myself to the reviewers list.
2953
2954         * Scripts/webkitpy/common/config/contributors.json:
2955
2956 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2957
2958         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
2959         https://bugs.webkit.org/show_bug.cgi?id=159509
2960
2961         Reviewed by Alex Christensen.
2962
2963         We should always insert the url in the url map when identifierForInitialRequest
2964         is called. Otherwise we can end up with identifiers not having an entry in the
2965         url map when urls are written to the test output file. 
2966
2967         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2968         (ResourceLoadDelegate::identifierForInitialRequest):
2969
2970 2016-07-06  Tim Horton  <timothy_horton@apple.com>
2971
2972         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
2973         https://bugs.webkit.org/show_bug.cgi?id=159498
2974         <rdar://problem/26719903>
2975
2976         Reviewed by Sam Weinig.
2977
2978         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2979         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
2980         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
2981         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
2982         (expectLinkCount):
2983         (TEST):
2984         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
2985         when deciding what to linkify.
2986
2987 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
2988
2989         Build fix - work around rdar://problem/27196668.
2990
2991         * LayoutTestRelay/Configurations/Base.xcconfig:
2992
2993 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
2994
2995         Enhance Windows DRT implementation to support platform scroll wheel events.
2996         https://bugs.webkit.org/show_bug.cgi?id=36002
2997
2998         Reviewed by Brent Fulgham.
2999
3000         Implement function continuousMouseScrollBy in Windows event sender.
3001
3002         * DumpRenderTree/win/EventSender.cpp:
3003         (mouseScrollBy):
3004         (continuousMouseScrollBy):
3005
3006 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3007
3008         [Sierra] Rebaseline tests to use un-mocked system font metrics
3009         https://bugs.webkit.org/show_bug.cgi?id=159311
3010         <rdar://problem/24138411>
3011
3012         Reviewed in person by Alexey Proskuryakov.
3013
3014         Stop mocking the system font on Sierra.
3015
3016         * DumpRenderTree/mac/DumpRenderTree.mm:
3017         (setDefaultsToConsistentValuesForTesting):
3018         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3019         (WTR::InjectedBundle::platformInitialize):
3020
3021 2016-07-05  Brady Eidson  <beidson@apple.com>
3022
3023         Database process crashes deleting a corrupt SQLite database file (null deref).
3024         https://bugs.webkit.org/show_bug.cgi?id=155506.
3025
3026         Reviewed by Alex Christensen.
3027
3028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3029         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3030         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3031         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3032         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3033         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3034
3035 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3036
3037         run-webkit-tests should print more complete baseline search paths
3038         https://bugs.webkit.org/show_bug.cgi?id=159354
3039
3040         Reviewed by Daniel Bates.
3041
3042         run-webkit-tests used to only print directory names in baseline search paths.
3043         This was ok in basic usage, but quickly got confusing when using
3044         --additional-platform-directory flags.
3045
3046         * Scripts/webkitpy/layout_tests/views/printing.py:
3047         (Printer.print_config):
3048         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3049         (Testprinter.test_print_config):
3050         (Testprinter.test_print_one_line_summary):
3051
3052 2016-07-04  Brady Eidson  <beidson@apple.com>
3053
3054         WebProcesses don't handle DatabaseProcess going away uncleanly..
3055         https://bugs.webkit.org/show_bug.cgi?id=159371
3056
3057         Reviewed by Alex Christensen.
3058
3059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3060         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3061         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3062         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3063         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3064
3065 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3066
3067         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3068         https://bugs.webkit.org/show_bug.cgi?id=158141
3069
3070         Rubber-stamped by Michael Catanzaro.
3071
3072         Instead of checking for an specific Ubuntu version, query the apt
3073         database to see which version of PHP is available.
3074
3075         * efl/install-dependencies:
3076         * gtk/install-dependencies:
3077
3078 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3079
3080         webkit-patch failure-reason always raises TypeError
3081         https://bugs.webkit.org/show_bug.cgi?id=159394
3082
3083         Reviewed by Benjamin Poulain.
3084
3085         In r170637 (Bug 133067), the first and second arguments of
3086         pluralize were swapped.
3087
3088         * Scripts/webkitpy/tool/commands/queries.py:
3089         (FailureReason._builder_to_explain): Swap the first and second
3090         arguments of pluralize.
3091
3092 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3093
3094         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3095         https://bugs.webkit.org/show_bug.cgi?id=152486
3096
3097         Reviewed by Daniel Bates.
3098
3099         Add launch of web-platform-tests server by run-webkit-httpd.
3100         Add two options to disable starting httpd and web-platform-tests servers.
3101
3102         * Scripts/run-webkit-httpd:
3103         (parse_args):
3104         (main):
3105
3106 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3107
3108         REGRESSION(r189668): Notification tests are flakey
3109         https://bugs.webkit.org/show_bug.cgi?id=159375
3110         <rdar://problem/22760990>
3111
3112         Reviewed by Alexey Proskuryakov.
3113
3114         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3115         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3116         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3117         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3118
3119         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3120         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3121         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3122         global notification ID mapping, causing the wrong notification to be investigated.
3123
3124         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3125         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3126         notification is created or destroyed. However, because this object is implemented outside WebKit,
3127         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3128         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3129         WebNotificationProvider can properly map between the different IDs.
3130
3131         * WebKitTestRunner/TestController.cpp:
3132         (WTR::TestController::runTestingServerLoop):
3133         (WTR::TestController::simulateWebNotificationClick):
3134         * WebKitTestRunner/WebNotificationProvider.cpp:
3135         (WTR::WebNotificationProvider::showWebNotification):
3136         (WTR::removeGlobalIDFromIDMap):
3137         (WTR::WebNotificationProvider::closeWebNotification):
3138         (WTR::WebNotificationProvider::removeNotificationManager):
3139         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3140         (WTR::WebNotificationProvider::reset):
3141         * WebKitTestRunner/WebNotificationProvider.h:
3142
3143 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3144
3145         Simplify LayoutTestRelay
3146         https://bugs.webkit.org/show_bug.cgi?id=159353
3147
3148         Reviewed by Daniel Bates.
3149
3150         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3151         by name and runtime makes no sense.
3152         2. Removed code to create devices, webkitpy always does this in advance.
3153         3. Don't create copies of testing apps - we can install the same one into
3154         each simulator, now that we don't run multiple tester processes in a single simulator.
3155         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3156         5. Removed code that kept testing apps alive in the background.
3157         6. Slightly updated coding style in functions that I touched.
3158
3159         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3160         Updated for what we acually use at this point.
3161
3162         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3163         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3164         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3165         (-[LTRelayController ipcIdentifier]):
3166         (-[LTRelayController processName]):
3167         (-[LTRelayController didReceiveStdoutData:]):
3168         (-[LTRelayController didCrashWithMessage:]):
3169         (-[LTRelayController installApp]):
3170         (-[LTRelayController _environmentVariables]):
3171         (-[LTRelayController launchApp]):
3172         (-[LTRelayController start]):
3173         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3174         (-[LTRelayController uniqueAppPath]): Deleted.
3175         (-[LTRelayController uniqueAppURL]): Deleted.
3176         (-[LTRelayController uniqueAppIdentifier]): Deleted.
3177         (-[LTRelayController createUniqueApp]): Deleted.
3178         * LayoutTestRelay/LayoutTestRelay/main.m:
3179         (usage):
3180         (getRequiredStringArgument):
3181         (main):
3182         (getTestingSimDevice): Deleted.
3183         * Scripts/webkitpy/port/driver.py:
3184         (IOSSimulatorDriver.cmd_line):
3185         * WebKitTestRunner/ios/TestControllerIOS.mm:
3186         (WTR::TestController::platformInitialize):
3187         * WebKitTestRunner/ios/mainIOS.mm:
3188         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3189         * DumpRenderTree/mac/DumpRenderTree.mm:
3190         (dumpRenderTree):
3191         (-[DumpRenderTree applicationDidEnterBackground:]):
3192
3193 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
3194
3195         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3196         https://bugs.webkit.org/show_bug.cgi?id=159344
3197
3198         Reviewed by Alex Christensen.
3199
3200         * DumpRenderTree/CMakeLists.txt:
3201
3202 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3203
3204         Add a runtime flag for DOM iterators
3205         https://bugs.webkit.org/show_bug.cgi?id=159300
3206
3207         Reviewed by Alex Christensen.
3208
3209         * DumpRenderTree/mac/DumpRenderTree.mm:
3210         (resetWebPreferencesToConsistentValues):
3211         * DumpRenderTree/win/DumpRenderTree.cpp:
3212         (resetWebPreferencesToConsistentValues):
3213         * Scripts/webkitperl/FeatureList.pm:
3214         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3215         (WTR::InjectedBundle::beginTesting):
3216         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3217         (WTR::TestRunner::setDOMIteratorEnabled):
3218         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3219
3220 2016-06-30  Tina Liu  <iting_liu@apple.com>
3221
3222         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3223         https://bugs.webkit.org/show_bug.cgi?id=159326
3224
3225         Reviewed by Brady Eidson.
3226
3227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3228         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3229         (TestWebKitAPI::didFinishLoadForFrame):
3230         (TestWebKitAPI::didChangeBackForwardListForPage):
3231         (TestWebKitAPI::setPageLoaderClient):
3232         Set the page loader client and register for didFinishLoadForFrame and
3233         didChangeBackForwardList callbacks.
3234         (TestWebKitAPI::createSessionStateData):
3235         Load a webpage ("simple.html") and return the session state for this page.
3236         (TestWebKitAPI::TEST):
3237         Restore the page session state with that of "simple.html" without navigation.
3238         Verify that the committed URL is NULL since there's no navigation involved.
3239         Verify that the current item in the back forward list, which should be what
3240         we restored from the session state, has the expected URL.
3241
3242 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
3243
3244         Generators violate bytecode liveness validation
3245         https://bugs.webkit.org/show_bug.cgi?id=159279
3246
3247         Reviewed by Yusuke Suzuki.
3248         
3249         Add Basic to our test harness.
3250
3251         * Scripts/run-javascriptcore-tests:
3252         (runJSCStressTests):
3253
3254 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
3255
3256         [Win][Debug] Assertion fails in TestWTF.
3257         https://bugs.webkit.org/show_bug.cgi?id=159299
3258
3259         Reviewed by Alex Christensen.
3260
3261         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3262         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3263         the assertion failure. Since the variable is actually used, there is no need to use the
3264         UNUSED_PARAM macro.
3265
3266         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3267         (TestWebKitAPI::TEST):
3268
3269 2016-06-30  Youenn Fablet  <youennf@gmail.com>
3270
3271         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
3272         https://bugs.webkit.org/show_bug.cgi?id=159166
3273         <rdar://problem/27051759>
3274
3275         Reviewed by Alexey Proskuryakov.
3276
3277         Setting the certificate directory to the copied config.json.
3278
3279         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3280         (WebPlatformTestServer._copy_webkit_test_files):
3281
3282 2016-06-29  Mark Lam  <mark.lam@apple.com>
3283
3284         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
3285         https://bugs.webkit.org/show_bug.cgi?id=159274
3286
3287         Reviewed by Keith Miller.
3288
3289         * DumpRenderTree/mac/DumpRenderTree.mm:
3290         (DumpRenderTreeMain):
3291
3292 2016-06-29  Alex Christensen  <achristensen@webkit.org>
3293
3294         WKWebView should ask WKNavigationDelegate about bad ssl certificates
3295         https://bugs.webkit.org/show_bug.cgi?id=159176
3296
3297         Reviewed by Sam Weinig.
3298
3299         * MiniBrowser/mac/WK2BrowserWindowController.m:
3300         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3301         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3302         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3303
3304 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3305
3306         [GTK] Add missing install dependency after r202619
3307         https://bugs.webkit.org/show_bug.cgi?id=156716
3308
3309         Unreviewed.
3310
3311         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3312
3313 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3314
3315         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3316         https://bugs.webkit.org/show_bug.cgi?id=156716
3317
3318         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3319
3320         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3321         (parse_args):
3322         * Scripts/webkitpy/port/gtk.py:
3323         (GtkPort.__init__):
3324         (GtkPort._driver_class):
3325         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3326         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3327         platform directory for storing the wayland specific layout test results and expectations for ${port}.
3328         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3329         test expectations file on the GTK port when running the tests with the --wayland command line switch.
3330         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3331         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3332         (WestonDriver.check_driver):
3333         (WestonDriver.__init__):
3334         (WestonDriver._start):
3335         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3336         (WestonXvfbDriverDisplayTest):
3337         (WestonXvfbDriverDisplayTest.__init__):
3338         (WestonXvfbDriverDisplayTest._xvfb_run):
3339         (WestonDriverTest.make_driver):
3340         (WestonDriverTest.test_start):
3341         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3342         or to satisfy the pkg-config check of the new added modules in JHBuild.
3343         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3344         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3345         provided by the system are already new enough.
3346         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3347         It was the only way to get the software EGL rasterizer working without depending on user drivers.
3348         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3349         feature to avoid building libdrm when the one provided by the system is new enough.
3350         * gtk/jhbuildrc:
3351         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
3352         Xorg had no support for searching the DRI drivers on a custom path at runtime.
3353         This patch implements support for that reusing the same variable that we use with Mesa to set the
3354         custom path for the DRI drivers path.
3355
3356 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
3357
3358         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
3359         https://bugs.webkit.org/show_bug.cgi?id=159256
3360
3361         Reviewed by Philippe Normand.
3362
3363         We need the last fixes in the repository to make the scream queue
3364         work with apprtc.
3365
3366         * gtk/jhbuild.modules:
3367
3368 2016-06-28  Commit Queue  <commit-queue@webkit.org>
3369
3370         Unreviewed, rolling out r202580.
3371         https://bugs.webkit.org/show_bug.cgi?id=159245
3372
3373         Caused all WKTR tests to fail on GuardMalloc and Production
3374         only for unknown reasons, investigating offline. (Requested by
3375         brrian on #webkit).
3376
3377         Reverted changeset:
3378
3379         "RunLoop::Timer should use constructor templates instead of
3380         class templates"
3381         https://bugs.webkit.org/show_bug.cgi?id=159153
3382         http://trac.webkit.org/changeset/202580
3383
3384 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3385
3386         Use a regex to check if a test step is for JavaScriptCore
3387         https://bugs.webkit.org/show_bug.cgi?id=159224
3388
3389         Reviewed by Geoffrey Garen.
3390
3391         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3392         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
3393         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3394         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
3395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3396         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
3397
3398 2016-06-28  Michael Saboff  <msaboff@apple.com>
3399
3400         btjs no longer accepts optional frame count argument
3401         https://bugs.webkit.org/show_bug.cgi?id=159235
3402
3403         Reviewed by Saam Barati.
3404
3405         Fix the detection of optional backtrace-depth parameter to use the length
3406         of the command.
3407
3408         * lldb/lldb_webkit.py:
3409         (btjs):
3410
3411 2016-06-28  Jon Lee  <jonlee@apple.com>
3412
3413         Update animometer.plan
3414
3415         Rubber-stamped by Said Abou-Hallawa.
3416
3417         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
3418
3419 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
3420
3421         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
3422
3423         * Scripts/run-javascriptcore-tests:
3424         (runJSCStressTests):
3425
3426 2016-06-28  Brian Burg  <bburg@apple.com>
3427
3428         RunLoop::Timer should use constructor templates instead of class templates
3429         https://bugs.webkit.org/show_bug.cgi?id=159153
3430
3431         Reviewed by Alex Christensen.
3432
3433         Remove the RunLoop::Timer class template argument, and pass its constructor
3434         a reference to `this` instead of a pointer to `this`.
3435
3436         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3437         (WTR::TestRunner::TestRunner):
3438         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3439         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3440         (TestWebKitAPI::TEST):
3441
3442 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3443
3444         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3445         https://bugs.webkit.org/show_bug.cgi?id=159199
3446
3447         Reviewed by Alexey Proskuryakov.
3448
3449         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
3450
3451         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3452         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3453         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
3454         an input element getting automatically focused on Mac.
3455
3456 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
3457
3458         [Win] Custom elements tests are failing.
3459         https://bugs.webkit.org/show_bug.cgi?id=159139
3460
3461         Reviewed by Alex Christensen.
3462
3463         Enable custom element API when running tests.
3464
3465         * DumpRenderTree/win/DumpRenderTree.cpp:
3466         (resetWebPreferencesToConsistentValues):
3467
3468 2016-06-27  Lucas Forschler  <lforschler@apple.com>
3469
3470         Test commit. Please ignore.
3471         
3472 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3473
3474         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
3475         https://bugs.webkit.org/show_bug.cgi?id=155073
3476
3477         Reviewed by Daniel Bates.
3478
3479         * Scripts/webkitperl/FeatureList.pm:
3480
3481 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
3482
3483         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3484         https://bugs.webkit.org/show_bug.cgi?id=159077
3485
3486         Reviewed by Tim Horton.
3487
3488         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
3489
3490         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
3491         which is necessary for UI-side compositing.
3492
3493         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
3494         seems to happen for some tests that call window.resizeTo().
3495
3496         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3497         (WTR::InjectedBundlePage::dump): Deleted.
3498         * WebKitTestRunner/TestInvocation.cpp:
3499         (WTR::TestInvocation::dumpResults):
3500         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3501         (WTR::createCGContextFromImage):
3502         (WTR::computeMD5HashStringForContext):
3503         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3504         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3505         (WTR::PlatformWebView::windowSnapshotImage):
3506
3507 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3508
3509         [EFL] Support to build on Debian linux
3510         https://bugs.webkit.org/show_bug.cgi?id=159123
3511
3512         Reviewed by Antonio Gomes.
3513
3514         * efl/install-dependencies: Install libgnutls28-dev.
3515
3516 2016-06-27  Alex Christensen  <achristensen@webkit.org>
3517
3518         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
3519         https://bugs.webkit.org/show_bug.cgi?id=159071
3520
3521         Reviewed by Brady Eidson.
3522
3523         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3524         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3525         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3526         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3527         (WTR::TestRunner::setAuthenticationUsername):
3528         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3529         * WebKitTestRunner/TestController.cpp:
3530         (WTR::TestController::TestController):
3531         (WTR::TestController::resetStateToConsistentValues):
3532         (WTR::TestController::didFinishNavigation):
3533         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3534         (WTR::TestController::didReceiveAuthenticationChallenge):
3535         (WTR::TestController::didCommitNavigation):
3536         * WebKitTestRunner/TestController.h:
3537         (WTR::TestController::setBlockAllPlugins):
3538         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3539         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
3540         (WTR::TestController::isCurrentInvocation):
3541         * WebKitTestRunner/TestInvocation.cpp:
3542         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3543         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
3544
3545 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
3546
3547         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
3548         https://bugs.webkit.org/show_bug.cgi?id=159129
3549
3550         Reviewed by Alex Christensen.
3551
3552         Implement the function mouseScrollBy in the Windows event sender.
3553
3554         * DumpRenderTree/win/EventSender.cpp:
3555         (mouseScrollBy):
3556         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3557
3558 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
3559
3560         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3561         https://bugs.webkit.org/show_bug.cgi?id=159104
3562
3563         Reviewed by Dan Bernstein.
3564         
3565         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
3566         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
3567
3568         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3569         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3570         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
3571
3572 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
3573
3574         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
3575         https://bugs.webkit.org/show_bug.cgi?id=159086
3576
3577         Reviewed by Alex Christensen.
3578
3579         Implement required wheel event function in event sender.
3580  
3581         * DumpRenderTree/win/EventSender.cpp:
3582         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3583
3584 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
3585
3586         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3587         https://bugs.webkit.org/show_bug.cgi?id=159104
3588
3589         Reviewed by Mark Lam.
3590         
3591         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
3592         WK.
3593
3594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3595
3596 2016-06-24  David Kilzer  <ddkilzer@apple.com>
3597
3598         parser_unittests.pl should not hardcode list of tests
3599         <https://webkit.org/b/159074>
3600
3601         Reviewed by Daniel Bates.
3602
3603         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3604         Update to read the list of tests from the 'resources' directory,
3605         and instead map file extensions to subroutine names.  Switch to
3606         use File::Basename::fileparse() to get basename and file
3607         extension for each test.
3608         (readTestFiles): Added.  Reads files from the directory passed
3609         in and ignores: hidden files, anything that isn't a plain file,
3610         and expected test results files.
3611
3612 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3613
3614         Fix Windows build.
3615
3616         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3617         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3618
3619 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3620
3621         [EFL] Change download path of libxslt
3622
3623         Unreviewed EFL build fix.
3624
3625         In Korea current download path can't be accessed. Change it.
3626
3627         * efl/jhbuild.modules:
3628
3629 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3630
3631         https://bugs.webkit.org/show_bug.cgi?id=159077
3632
3633         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
3634         snapshot the final state of the test in release builds. 
3635
3636         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3637         (WTR::InjectedBundlePage::dump):
3638
3639 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3640
3641         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
3642
3643         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3644         (createBitmapContextFromWebView):
3645         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3646         (WTR::PlatformWebView::windowSnapshotImage):
3647
3648 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3649
3650         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3651         https://bugs.webkit.org/show_bug.cgi?id=159077
3652
3653         Reviewed by Tim Horton.
3654
3655         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
3656         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
3657         thus enabling testing of more things.
3658
3659         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3660         (createBitmapContext): Moved to this file to share it.
3661         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3662         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3663         (createBitmapContextFromWebView):
3664         (BitmapContext::createFromUIImage): Deleted.
3665         (BitmapContext::pixelData): Deleted.
3666         (BitmapContext::BitmapContext): Deleted.
3667         (computeMD5HashStringForBitmapContext): Deleted.
3668         (dumpBitmap): Deleted.
3669         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
3670         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3671         (createPagedBitmapContext):
3672         (createBitmapContext): Deleted.
3673         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
3674         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3675         (WTR::InjectedBundlePage::dump): Deleted.
3676         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3677         (WTR::PlatformWebView::windowSnapshotImage):
3678
3679 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3680
3681         [jhbuild] Added libxslt module.
3682         https://bugs.webkit.org/show_bug.cgi?id=159034
3683
3684         Unreviewed, followup for r202373.
3685
3686         * efl/install-dependencies: Removed libxslt 
3687         * gtk/install-dependencies: Ditto.
3688
3689 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3690
3691         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
3692         https://bugs.webkit.org/show_bug.cgi?id=159050
3693
3694         Reviewed by Antonio Gomes.
3695
3696         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
3697
3698         * efl/jhbuild.modules:
3699         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3700         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3701
3702 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3703
3704         [jhbuild] Added libxslt module.
3705         https://bugs.webkit.org/show_bug.cgi?id=159034
3706
3707         Reviewed by Michael Catanzaro.
3708
3709         * efl/jhbuild.modules:
3710         * gtk/jhbuild.modules:
3711
3712 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3713
3714         [Win] Use Windows api function to find top level parent.
3715         https://bugs.webkit.org/show_bug.cgi?id=159021
3716
3717         Reviewed by Brent Fulgham.
3718
3719         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
3720  
3721         * DumpRenderTree/win/UIDelegate.cpp:
3722         (UIDelegate::runModal):
3723         (findTopLevelParent): Deleted.
3724         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3725         (PrintWebUIDelegate::runModal):
3726         (findTopLevelParent): Deleted.
3727
3728 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3729
3730         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
3731         https://bugs.webkit.org/show_bug.cgi?id=158934
3732
3733         Reviewed by Brent Fulgham.
3734
3735         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
3736
3737         * DumpRenderTree/win/TestRunnerWin.cpp:
3738         (TestRunner::clearAllDatabases):
3739
3740 2016-06-22  Saam Barati  <sbarati@apple.com>
3741
3742         run-javascriptcore-tests should have some environment variables for commonly used settings
3743         https://bugs.webkit.org/show_bug.cgi?id=159047
3744
3745         Reviewed by Keith Miller.
3746
3747         This patch adds three environment variables that run-javascriptcore-tests
3748         consults:
3749         - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
3750           determines if we should run the api tests or not.
3751         - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
3752           determines if we will perform a build or not before running the tests.
3753           to set the default should-build setting.
3754         - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
3755           a yaml file. If set, we will run the extra tests it refers to.
3756
3757         All the values in these environment variables will be overridden if an
3758         option is explicitly passed in. For example, the following will run
3759         the api tests:
3760         `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
3761
3762         * Scripts/run-javascriptcore-tests:
3763
3764 2016-06-22  Saam barati  <sbarati@apple.com>
3765
3766         TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
3767         https://bugs.webkit.org/show_bug.cgi?id=159037
3768         <rdar://problem/26935349>
3769
3770         Reviewed by Benjamin Poulain.
3771
3772         Run typeProfiler.yaml tests under an additional CJIT enabled mode.
3773
3774         * Scripts/run-jsc-stress-tests:
3775
3776 2016-06-22  Aakash Jain  <aakash_jain@apple.com>
3777
3778         Fix style issues in webkitpy
3779         https://bugs.webkit.org/show_bug.cgi?id=159019
3780
3781         Reviewed by Daniel Bates.
3782
3783         Fixed the formatting issues as reported by check-webkit-style in webkitpy.
3784         There is no functionality change.
3785         Only affected file names retained below for brevity.
3786
3787         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3788         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3789         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3790         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3791         * Scripts/webkitpy/benchmark_runner/utils.py:
3792         * Scripts/webkitpy/common/checkout/changelog.py:
3793         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3794         * Scripts/webkitpy/common/checkout/checkout.py:
3795         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3796         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3797         * Scripts/webkitpy/common/checkout/commitinfo.py:
3798         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3799         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3800         * Scripts/webkitpy/common/checkout/scm/scm.py:
3801         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3802         * Scripts/webkitpy/common/config/committers_unittest.py:
3803         * Scripts/webkitpy/common/config/irc.py:
3804         * Scripts/webkitpy/common/config/ports.py:
3805         * Scripts/webkitpy/common/config/ports_unittest.py:
3806         * Scripts/webkitpy/common/config/urls.py:
3807         * Scripts/webkitpy/common/host_mock.py:
3808         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3809         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3810         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3811         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3812         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3813         * Scripts/webkitpy/common/net/credentials_unittest.py:
3814         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
3815         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3816         * Scripts/webkitpy/common/net/statusserver.py:
3817         * Scripts/webkitpy/common/system/autoinstall.py:
3818         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3819         * Scripts/webkitpy/common/system/executive.py:
3820         * Scripts/webkitpy/common/system/executive_mock.py:
3821         * Scripts/webkitpy/common/system/executive_unittest.py:
3822         * Scripts/webkitpy/common/system/filesystem_mock.py:
3823         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3824         * Scripts/webkitpy/common/system/logutils_unittest.py:
3825         * Scripts/webkitpy/common/system/path.py:
3826         * Scripts/webkitpy/common/system/path_unittest.py:
3827         * Scripts/webkitpy/common/system/platforminfo.py:
3828         * Scripts/webkitpy/common/system/user.py:
3829         * Scripts/webkitpy/common/system/user_unittest.py:
3830         * Scripts/webkitpy/common/system/workspace_unittest.py:
3831         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
3832         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
3833         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3834         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3835         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3836         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3837         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3838         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3839         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3840         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3841         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3842         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3843         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3844         * Scripts/webkitpy/layout_tests/views/printing.py:
3845         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3846         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3847         * Scripts/webkitpy/port/base_unittest.py:
3848         * Scripts/webkitpy/port/driver.py:
3849         * Scripts/webkitpy/port/driver_unittest.py:
3850         * Scripts/webkitpy/port/factory.py:
3851         * Scripts/webkitpy/port/gtk.py:
3852         * Scripts/webkitpy/port/server_process_unittest.py:
3853         * Scripts/webkitpy/port/test.py:
3854         * Scripts/webkitpy/port/win.py:
3855         * Scripts/webkitpy/style/checker.py:
3856         * Scripts/webkitpy/style/checkers/common_unittest.py:
3857         * Scripts/webkitpy/style/checkers/cpp.py:
3858         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3859         * Scripts/webkitpy/style/checkers/js.py:
3860         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3861         * Scripts/webkitpy/style/checkers/png.py:
3862         * Scripts/webkitpy/style/checkers/text.py:
3863         * Scripts/webkitpy/style/checkers/text_unittest.py:
3864         * Scripts/webkitpy/style/error_handlers.py:
3865         * Scripts/webkitpy/style/filter.py:
3866         * Scripts/webkitpy/style/filter_unittest.py:
3867         * Scripts/webkitpy/style/optparser.py:
3868         * Scripts/webkitpy/style/optparser_unittest.py:
3869         * Scripts/webkitpy/test/main.py:
3870         * Scripts/webkitpy/w3c/test_converter.py:
3871         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3872         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3873         * Scripts/webkitpy/xcode/simulator.py:
3874
3875 2016-06-22  Brady Eidson  <beidson@apple.com>
3876
3877         DatabaseProcess doesn't handle WebProcesses going away uncleanly.
3878         https://bugs.webkit.org/show_bug.cgi?id=158894
3879
3880         Reviewed by Alex Christensen.
3881
3882         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3883         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
3884         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
3885         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3886
3887 2016-06-22  Jon Lee  <jonlee@apple.com>
3888
3889         Update animometer.plan
3890         https://bugs.webkit.org/show_bug.cgi?id=159012
3891
3892         Reviewed by Ryosuke Niwa.
3893
3894         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
3895
3896 2016-06-22  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3897
3898         W3C test importer should generate files to ignore by WebKit SCM
3899         https://bugs.webkit.org/show_bug.cgi?id=142743
3900
3901         Reviewed by Darin Adler.
3902
3903         TestDownloader generates the .gitignore file according submodules git repository information.
3904         TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.
3905
3906         * Scripts/webkitpy/w3c/test_downloader.py:
3907         (TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
3908         * Scripts/webkitpy/w3c/test_importer.py:
3909         (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
3910         (TestImporter):
3911         (TestImporter.write_init_py): Writing not empty __init__.py files.
3912         (TestImporter.import_tests): Using  of write_init_py. 
3913         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3914         (TestImporterTest.test_git_ignore_generation): Added .gitignore test.
3915         (TestImporterTest):
3916         (TestImporterTest.test_initpy_generation): Added __init__.py test.
3917
3918 2016-06-21  Sam Weinig  <sam@webkit.org>
3919
3920         WKWebView with no WKNavigationDelegate does not follow universal links
3921         <rdar://problem/24374110>
3922         https://bugs.webkit.org/show_bug.cgi?id=158997
3923
3924         Reviewed by Dan Bernstein.
3925
3926         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3927         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
3928         Add a new test that shows that we have a default navigation delegate by swizzling
3929         -[NSWorkspace openURL:]. This will only be called if there is a default client.
3930
3931 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3932
3933         [Win] Implement modal dialog support in MiniBrowser.
3934         https://bugs.webkit.org/show_bug.cgi?id=158976
3935
3936         Reviewed by Brent Fulgham.
3937
3938         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3939         (PrintWebUIDelegate::createWebViewWithRequest):
3940         (getHandleFromWebView):
3941         (PrintWebUIDelegate::webViewClose):
3942         (PrintWebUIDelegate::setFrame):
3943         (PrintWebUIDelegate::webViewFrame):
3944         (PrintWebUIDelegate::canRunModal):
3945         (findTopLevelParent):
3946         (PrintWebUIDelegate::runModal):
3947         (PrintWebUIDelegate::createModalDialog):
3948         * MiniBrowser/win/PrintWebUIDelegate.h:
3949         (PrintWebUIDelegate::webViewClose):
3950         (PrintWebUIDelegate::setFrame):
3951         (PrintWebUIDelegate::webViewFrame):
3952         (PrintWebUIDelegate::canRunModal):
3953         (PrintWebUIDelegate::runModal):
3954
3955 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3956
3957         window.showModalDialog doesn't work in DumpRenderTree on Windows
3958         https://bugs.webkit.org/show_bug.cgi?id=53675
3959
3960         Reviewed by Brent Fulgham.
3961
3962         Implement modal dialog support in DumpRenderTree.
3963
3964         * DumpRenderTree/win/UIDelegate.cpp:
3965         (UIDelegate::canRunModal):
3966         (getHandleFromWebView):
3967         (UIDelegate::createModalDialog):
3968         (findTopLevelParent):
3969         (UIDelegate::runModal):
3970         (UIDelegate::webViewClose):
3971         * DumpRenderTree/win/UIDelegate.h:
3972
3973 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
3974
3975         Fix formatting issues reported by check-webkit-style
3976         https://bugs.webkit.org/show_bug.cgi?id=159008
3977
3978         Reviewed by Alexey Proskuryakov.
3979
3980         Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
3981         There is no functionality change.
3982
3983         * Scripts/webkitpy/tool/bot/irc_command.py:
3984         (Restart.execute):
3985         (Rollout):
3986         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3987         (IRCBotTest.test_exception_during_command):
3988         (IRCBotTest.test_exception_during_command.CommandWithException):
3989         (IRCBotTest.test_exception_during_command.CommandWithException.execute):
3990         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3991         (test_missing_unit_test_results_path):
3992         (test_layout_test_results):
3993         * Scripts/webkitpy/tool/bot/queueengine.py:
3994         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3995         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3996         (AbstractSequencedCommand):
3997         (AbstractSequencedCommand.__init__):
3998         * Scripts/webkitpy/tool/commands/download.py:
3999         (Land):
4000         * Scripts/webkitpy/tool/commands/openbugs.py:
4001         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
4002         (OpenBugsTest):
4003         * Scripts/webkitpy/tool/commands/queries.py:
4004         (PatchesToCommitQueue):
4005         (PatchesToCommitQueue.__init__):
4006         (PatchesToCommitQueue._needs_commit_queue):
4007         * Scripts/webkitpy/tool/commands/queries_unittest.py:
4008         (PrintExpectationsTest.test_platform):
4009         (PrintBaselinesTest):
4010         (PrintBaselinesTest.setUp):
4011         * Scripts/webkitpy/tool/commands/queues.py:
4012         (AbstractQueue):
4013         (AbstractQueue.__init__):
4014         (AbstractQueue.execute):
4015         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4016         (test_auto_retry):
4017         * Scripts/webkitpy/tool/commands/rebaseline.py:
4018         (AbstractParallelRebaselineCommand._files_to_add):
4019         (AbstractParallelRebaselineCommand):
4020         (AbstractParallelRebaselineCommand._rebaseline):
4021         * Scripts/webkitpy/tool/commands/setupgitclone.py:
4022         (SetupGitClone):
4023         * Scripts/webkitpy/tool/commands/sheriffbot.py:
4024         * Scripts/webkitpy/tool/commands/stepsequence.py:
4025         * Scripts/webkitpy/tool/commands/upload.py:
4026         (PostCommits._comment_text_for_commit):
4027         (PostCommits):
4028         (PostCommits.execute):
4029         (MarkBugFixed):
4030         (MarkBugFixed.__init__):
4031         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4032         (UploadCommandsTest):
4033         (UploadCommandsTest.test_commit_message_for_current_diff):
4034         * Scripts/webkitpy/tool/grammar_unittest.py:
4035         (GrammarTest):
4036         (GrammarTest.test_join_with_separators):
4037         * Scripts/webkitpy/tool/multicommandtool.py:
4038         (HelpCommand.__init__):
4039         (HelpCommand):
4040         (HelpCommand._help_epilog):
4041         (HelpCommand._remove_help_options):
4042         (MultiCommandTool):
4043         (MultiCommandTool.__init__):
4044         (MultiCommandTool.main):
4045         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
4046         (TrivialCommand):
4047         (TrivialCommand.__init__):
4048         (MultiCommandToolTest):
4049         (MultiCommandToolTest._assert_tool_main_outputs):
4050         (MultiCommandToolTest.test_retry):
4051         (test_command_help):
4052         * Scripts/webkitpy/tool/steps/__init__.py:
4053         * Scripts/webkitpy/tool/steps/abstractstep.py:
4054         * Scripts/webkitpy/tool/steps/applypatch.py:
4055         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
4056         (ApplyPatchWithLocalCommit):
4057         (ApplyPatchWithLocalCommit.options):
4058         * Scripts/webkitpy/tool/steps/build.py:
4059         * Scripts/webkitpy/tool/steps/checkstyle.py:
4060         (CheckStyle):
4061         (CheckStyle.options):
4062         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4063         * Scripts/webkitpy/tool/steps/closebug.py:
4064         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
4065         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
4066         (CloseBugForLandDiffTest):
4067         (CloseBugForLandDiffTest.test_empty_state):
4068         * Scripts/webkitpy/tool/steps/closepatch.py:
4069         * Scripts/webkitpy/tool/steps/commit.py:
4070         (Commit.run):
4071         * Scripts/webkitpy/tool/steps/confirmdiff.py:
4072         * Scripts/webkitpy/tool/steps/editchangelog.py:
4073         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
4074         * Scripts/webkitpy/tool/steps/metastep.py:
4075         (MetaStep):
4076         (MetaStep.__init__):
4077         (MetaStep.run):
4078         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
4079         * Scripts/webkitpy/tool/steps/options.py:
4080         (Options):
4081         * Scripts/webkitpy/tool/steps/postdiff.py:
4082         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
4083         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
4084         * Scripts/webkitpy/tool/steps/preparechangelog.py:
4085         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
4086         (PrepareChangeLogTest):
4087         (PrepareChangeLogTest.test_resolve_existing_entry):
4088         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4089         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
4090         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
4091         * Scripts/webkitpy/tool/steps/revertrevision.py:
4092         * Scripts/webkitpy/tool/steps/runtests.py:
4093         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4094         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4095         (StepsTest):
4096         (StepsTest._step_options):
4097         * Scripts/webkitpy/tool/steps/update.py:
4098         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
4099         (UpdateChangeLogsWithReviewerTest):
4100         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
4101         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
4102         * Scripts/webkitpy/tool/steps/validatereviewer.py:
4103
4104 2016-06-21  Chris Dumez  <cdumez@apple.com>
4105
4106         Unreviewed, rolling out r202296.
4107
4108         Broke basic browsing in Safari
4109
4110         Reverted changeset:
4111
4112         "WKWebView with no WKNavigationDelegate does not follow
4113         universal links"
4114         https://bugs.webkit.org/show_bug.cgi?id=158997
4115         http://trac.webkit.org/changeset/202296
4116
4117 2016-06-21  Anders Carlsson  <andersca@apple.com>
4118
4119         Fix build.
4120
4121         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4122
4123 2016-06-21  Anders Carlsson  <andersca@apple.com>
4124
4125         Begin moving the Apple Pay code to the open source repository
4126         https://bugs.webkit.org/show_bug.cgi?id=158998
4127
4128         Reviewed by Tim Horton.
4129
4130         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4131         Add ENABLE_APPLE_PAY.
4132
4133 2016-06-21  Said Abou-Hallawa  <sabouhallawa@apple,com>
4134
4135         Add system tracing points for requestAnimationFrame() workflow
4136         https://bugs.webkit.org/show_bug.cgi?id=158723
4137
4138         Reviewed by Simon Fraser.
4139
4140         Add new plist entries to be used by kdebug_trace() viewing tools.
4141
4142         * Tracing/SystemTracePoints.plist:
4143
4144 2016-06-21  Sam Weinig  <sam@webkit.org>
4145
4146         WKWebView with no WKNavigationDelegate does not follow universal links
4147         <rdar://problem/24374110>
4148         https://bugs.webkit.org/show_bug.cgi?id=158997
4149
4150         Reviewed by Dan Bernstein.
4151
4152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4153         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
4154         Add a new test that shows that we have a default navigation delegate by swizzling
4155         -[NSWorkspace openURL:]. This will only be called if there is a default client.
4156
4157 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
4158
4159         run-javascriptcore-tests should have flag to skip mozilla tests
4160         https://bugs.webkit.org/show_bug.cgi?id=158963
4161         rdar://problem/25838924
4162
4163         Reviewed by Alexey Proskuryakov.
4164
4165         * Scripts/run-javascriptcore-tests:
4166         (runJSCStressTests): Added flag to skip mozilla tests.
4167
4168 2016-06-20  Commit Queue  <commit-queue@webkit.org>
4169
4170         Unreviewed, rolling out r202136.
4171         https://bugs.webkit.org/show_bug.cgi?id=158932
4172
4173         JSBench wasn't regressed by r202002 and r202111 on iOS after
4174         all (Requested by rniwa_ on #webkit).
4175
4176         Reverted changeset:
4177
4178         "Unreviewed, rolling out r202002 and r202111."
4179         https://bugs.webkit.org/show_bug.cgi?id=158638
4180         http://trac.webkit.org/changeset/202136
4181
4182 2016-06-20  Keith Rollin  <krollin@apple.com>
4183
4184         Remove RefPtr::release() and change calls sites to use WTFMove()
4185         https://bugs.webkit.org/show_bug.cgi?id=158369
4186
4187         Reviewed by Chris Dumez.
4188
4189         RefPtr::release() releases its managed pointer awkwardly. It's more
4190         direct and clearer to use WTFMove to transfer ownership of the managed
4191         pointer.
4192
4193         As part of this cleanup, also change a lot of explicit data types to
4194         'auto'.
4195
4196         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
4197         (createBitmapContextFromWebView):
4198         (createPagedBitmapContext):
4199         * DumpRenderTree/mac/TestRunnerMac.mm:
4200         (TestRunner::setMockGeolocationPosition):
4201         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
4202         (TestWebKitAPI::TEST):
4203         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4204         (TestWebKitAPI::TEST):
4205
4206 2016-06-20  Tim Horton  <timothy_horton@apple.com>
4207
4208         Add a API test for *DeferringViewInWindowChanges as fixed in r202230
4209         https://bugs.webkit.org/show_bug.cgi?id=158947
4210
4211         Reviewed by Simon Fraser.
4212
4213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4214         * TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Added.
4215         (TestWebKitAPI::didFinishLoadForFrame):
4216         (TestWebKitAPI::setPageLoaderClient):
4217         (TestWebKitAPI::TEST):
4218         Add a test ensuring that in-window state changes are deferred when using
4219         the SPI for deferring them, as fixed in r202230.
4220
4221 2016-06-20  Fujii Hironori  <Hironori.Fujii@sony.com>
4222
4223         WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE"
4224         https://bugs.webkit.org/show_bug.cgi?id=158931
4225
4226         Reviewed by Alexey Proskuryakov.
4227
4228         * WebKitTestRunner/TestInvocation.cpp:
4229         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Appended missing \n at the end of line.
4230
4231 2016-06-17  Alexey Proskuryakov  <ap@apple.com>
4232
4233         Add test expectations for macOS Sierra
4234         https://bugs.webkit.org/show_bug.cgi?id=158903
4235
4236         Reviewed by Alex Christensen.
4237
4238         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png: Added.
4239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png: Added.
4240         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4242         Added dashboard support.
4243
4244         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
4245         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
4246         Trigger the right build queues on check-in.
4247
4248         * Scripts/webkitpy/common/system/platforminfo.py:
4249         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
4250         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4251         * Scripts/webkitpy/port/mac.py:
4252         * Scripts/webkitpy/port/mac_unittest.py:
4253         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4254         Added cases for Sierra, and updated tests for new baseline search paths.
4255
4256 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
4257
4258         Another buid fix for master.cfg.
4259
4260         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4261         (CompileWebKit.start):
4262
4263 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
4264
4265         Another buid fix for master.cfg.
4266
4267         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4268         (CompileWebKit.start):
4269
4270 2016-06-19  Lucas Forschler  <lforschler@apple.com>
4271
4272         Fix master.cfg
4273         
4274         Unreviewed build fix.
4275
4276         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4277         (CompileWebKit.start):
4278
4279 2016-06-19  Lucas Forschler  <lforschler@apple.com>
4280
4281