CodeCache should check that the UnlinkedCodeBlock was successfully created before...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2
3         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
4         https://bugs.webkit.org/show_bug.cgi?id=196880
5
6         Reviewed by Yusuke Suzuki.
7
8         Add a new function for bytecode cache tests that does not forceDiskCache
9         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
10         test added in this patch, since the code is invalid and therefore won't be
11         cached. It should also be useful for tests that evaluate dynamically
12         generated code.
13
14         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
15         * Scripts/run-jsc-stress-tests:
16
17 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
18
19         Update AudioSession route sharing policy
20         https://bugs.webkit.org/show_bug.cgi?id=196776
21         <rdar://problem/46501611>
22
23         Reviewed by Jer Noble.
24
25         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
26         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
27         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
28         (TestWebKitAPI::TEST):
29
30 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
31
32         [iOS] Software keyboard is shown too frequently on some websites
33         https://bugs.webkit.org/show_bug.cgi?id=195856
34         <rdar://problem/49191395>
35
36         Reviewed by Darin Adler.
37
38         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
39
40         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
41         (WTR::UIScriptController::setHardwareKeyboardAttached):
42         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
43         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
44         (WTR::UIScriptController::setHardwareKeyboardAttached):
45         * TestRunnerShared/UIScriptContext/UIScriptController.h:
46         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
47
48         Additionally link against GraphicsServices in WebKitTestRunner.
49
50         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
51         (WTR::TestController::platformResetStateToConsistentValues):
52         (WTR::UIScriptController::setHardwareKeyboardAttached):
53
54 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
55
56         [GTK][WPE] Fix pacman install-dependencies packages
57         https://bugs.webkit.org/show_bug.cgi?id=196817
58
59         Reviewed by Žan Doberšek.
60         
61         python3-setuptools is called python-setuptools
62         ruby-highline is only available on AUR
63         libv4l-devel is incorporated in v4l-utils
64
65         * gtk/install-dependencies:
66         * wpe/install-dependencies:
67
68 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
69
70         [GTK] REGRESSION(r243860): Many tests failing
71         https://bugs.webkit.org/show_bug.cgi?id=196791
72
73         Reviewed by Joanmarie Diggs.
74
75         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
76         multiple documents and check that accessibility hierarchy is updated after a navigation.
77
78         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
79         (loadChangedCallback):
80         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
81         (AccessibilityTest::AccessibilityTest):
82         (AccessibilityTest::~AccessibilityTest):
83         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
84         (AccessibilityTest::findTestServerApplication):
85         (AccessibilityTest::findDocumentWeb):
86         (AccessibilityTest::findRootObject):
87         (AccessibilityTest::waitUntilChildrenRemoved):
88         (AccessibilityTest::ensureProxy):
89         (testAtspiBasicHierarchy):
90         (beforeAll):
91         (afterAll):
92
93 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
94
95         [ews-build] Handle bug titles with unicode characters
96         https://bugs.webkit.org/show_bug.cgi?id=196802
97
98         Reviewed by Dewei Zhu.
99
100         * BuildSlaveSupport/ews-build/steps.py:
101         (ValidatePatch._is_bug_closed):
102
103 2019-04-11  Michael Saboff  <msaboff@apple.com>
104
105         Improve the Inline Cache Stats code
106         https://bugs.webkit.org/show_bug.cgi?id=196836
107
108         Reviewed by Saam Barati.
109
110         Added a new script to consolidate and arrange the output of --useICStats option.
111
112         This script merges the output from every group into one large table and sorts it from most common to
113         least common.  It also counts the slow path GetById and PutById variants and then calculates the
114         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
115         Put together, this is useful to see what property accesses are not getting cached.
116
117         * Scripts/ic-stats.py: Added.
118         (ICStats):
119         (ICStats.__init__):
120         (ICStats.parse):
121         (ICStats.dumpStats):
122         (usage):
123
124 2019-04-10  Alex Christensen  <achristensen@webkit.org>
125
126         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
127         https://bugs.webkit.org/show_bug.cgi?id=196809
128         <rdar://49800762>
129
130         Reviewed by Brady Eidson.
131
132         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
133         (TEST):
134
135 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
136
137         requestAnimationFrame should execute before the next frame
138         https://bugs.webkit.org/show_bug.cgi?id=177484
139
140         Reviewed by Simon Fraser.
141
142         Add trace points for the page RenderingUpdate.
143
144         * Tracing/SystemTracePoints.plist:
145
146 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
147
148         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
149         https://bugs.webkit.org/show_bug.cgi?id=196760
150
151         Reviewed by Don Olmstead.
152
153         vswhere.exe has been bundled since Visual Studio 2017 version
154         15.2. We shouldn't download vswhere.exe.
155
156         * Scripts/build-jsc: Do not call update-vswhere.py.
157         * Scripts/build-webkit: Ditto.
158         * Scripts/update-vswhere.py: Removed.
159         * Scripts/webkitdirs.pm:
160         (requireModulesForVSWhere): Deleted.
161         (pickCurrentVisualStudioInstallation): Deleted.
162         (visualStudioInstallDirVSWhere): Return the latest installed VS
163         installation path by using the bundled vswhere.exe.
164         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
165         (visualStudioInstallDirFallback): Removed.
166
167 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
168
169         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
170         https://bugs.webkit.org/show_bug.cgi?id=196780
171
172         Reviewed by Alexey Proskuryakov.
173
174         * BuildSlaveSupport/ews-build/steps.py:
175         * BuildSlaveSupport/ews-build/steps_unittest.py:
176
177 2019-04-10  Alex Christensen  <achristensen@webkit.org>
178
179         Add SPI WKNavigationResponse._downloadAttribute
180         https://bugs.webkit.org/show_bug.cgi?id=196755
181         <rdar://49587365>
182
183         Reviewed by Brady Eidson.
184
185         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
186         (-[NavigationResponseTestDelegate navigationResponse]):
187         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
188         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
189         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
190         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
191         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
192         (readRequest):
193         (writeResponse):
194         (TEST):
195
196 2019-04-10  Tim Horton  <timothy_horton@apple.com>
197
198         Add modern API for overriding the page's specified viewport configuration
199         https://bugs.webkit.org/show_bug.cgi?id=167734
200         <rdar://problem/30331795>
201
202         Reviewed by Simon Fraser.
203
204         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
205         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
206
207 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
208
209         Add support for incremental bytecode cache updates
210         https://bugs.webkit.org/show_bug.cgi?id=195000
211
212         Reviewed by Filip Pizlo.
213
214         Exit when the initial run to generate bytecode fails.
215
216         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
217
218 2019-04-10  Alex Christensen  <achristensen@webkit.org>
219
220         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
221         https://bugs.webkit.org/show_bug.cgi?id=196744
222         <rdar://49415309>
223
224         Reviewed by Chris Dumez.
225
226         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
227         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
228
229 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
230
231         Add a way to opt into modern compatibility mode in layout tests
232         https://bugs.webkit.org/show_bug.cgi?id=196770
233         <rdar://problem/49777550>
234
235         Reviewed by Antoine Quint.
236
237         Add a new test option to enable modern compatibility mode in layout tests.
238
239         * WebKitTestRunner/TestController.cpp:
240         (WTR::updateTestOptionsFromTestHeader):
241         * WebKitTestRunner/TestController.h:
242         * WebKitTestRunner/TestOptions.h:
243         (WTR::TestOptions::hasSameInitializationOptions const):
244         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
245         (WTR::TestController::platformCreateWebView):
246         (WTR::TestController::enableModernCompatibilityMode):
247
248 2019-04-10  Andy Estes  <aestes@apple.com>
249
250         Try to fix the 32-bit watchOS build.
251
252         * TestWebKitAPI/cocoa/TestWKWebView.mm:
253         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
254
255 2019-04-10  Antoine Quint  <graouts@apple.com>
256
257         Enable Pointer Events on watchOS
258         https://bugs.webkit.org/show_bug.cgi?id=196771
259         <rdar://problem/49040909>
260
261         Reviewed by Dean Jackson.
262
263         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
264
265 2019-04-10  Philippe Normand  <pnormand@igalia.com>
266
267         Unreviewed. Fix WPE accessibility tests after r244059.
268
269         We are failing to load the injected bundle due to undefined symbol
270         AccessibilityUIElement::replaceTextInRange().
271
272         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
273         (WTR::AccessibilityUIElement::replaceTextInRange):
274
275 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
276
277         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
278         https://bugs.webkit.org/show_bug.cgi?id=196727
279
280         Reviewed by Fujii Hironori.
281
282         * MiniBrowser/win/WebKitBrowserWindow.cpp:
283         (WebKitBrowserWindow::create):
284
285 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
286
287         [ews-build] Add unit tests for PrintConfiguration
288         https://bugs.webkit.org/show_bug.cgi?id=196752
289
290         Reviewed by Dewei Zhu.
291
292         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
293
294 2019-04-09  Keith Rollin  <krollin@apple.com>
295
296         Unreviewed build maintenance -- update .xcfilelists.
297
298         * DumpRenderTree/DerivedSources-input.xcfilelist:
299         * DumpRenderTree/DerivedSources-output.xcfilelist:
300
301 2019-04-09  Zalan Bujtas  <zalan@apple.com>
302
303         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
304         https://bugs.webkit.org/show_bug.cgi?id=196743
305         <rdar://problem/43897551>
306
307         Reviewed by Tim Horton.
308
309         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
310         (TEST):
311
312 2019-04-09  Youenn Fablet  <youenn@apple.com>
313
314         Close service worker database on network process suspension
315         https://bugs.webkit.org/show_bug.cgi?id=196623
316         <rdar://problem/48930869>
317
318         Reviewed by Alex Christensen.
319
320         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
321
322 2019-04-09  Daniel Bates  <dabates@apple.com>
323
324         [iPad] Should open popover when the spacebar is pressed
325         https://bugs.webkit.org/show_bug.cgi?id=196360
326         <rdar://problem/49389129>
327
328         Reviewed by Brent Fulgham.
329
330         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
331
332         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
333         (WTR::UIScriptController::isShowingPopover const): Added.
334         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
335         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
336         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
337         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
338         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
339         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
340         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
341         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
342         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
343         (WTR::UIScriptController::isShowingPopover const): Added.
344         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
345         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
346         * TestRunnerShared/UIScriptContext/UIScriptController.h:
347         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
348         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
349         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
350         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
351         (-[TestRunnerWKWebView _willPresentPopover]): Added.
352         (-[TestRunnerWKWebView _didDismissPopover]): Added.
353         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
354         (WTR::UIScriptController::isShowingPopover const): Added.
355         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
356         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
357
358 2019-04-09  Alex Christensen  <achristensen@webkit.org>
359
360         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
361         https://bugs.webkit.org/show_bug.cgi?id=196665
362         <rdar://45115669>
363
364         Reviewed by Geoff Garen.
365
366         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
367         (goBack):
368         (+[SimpleLookupContext sharedLookupContext]):
369         (-[SimpleLookupContext lookUpURL:completionHandler:]):
370         (TEST):
371         (+[Simple3LookupContext sharedLookupContext]): Deleted.
372         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
373
374 2019-04-09  John Wilander  <wilander@apple.com>
375
376         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
377         https://bugs.webkit.org/show_bug.cgi?id=196558
378         <rdar://problem/47650245>
379
380         Reviewed by Youenn Fablet.
381
382         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
383         (TestWebKitAPI::TEST):
384             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
385
386 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
387
388         [CMake] Apple builds should use ICU_INCLUDE_DIRS
389         https://bugs.webkit.org/show_bug.cgi?id=196720
390
391         Reviewed by Konstantin Tokarev.
392
393         * TestWebKitAPI/PlatformMac.cmake:
394
395 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
396
397         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
398         https://bugs.webkit.org/show_bug.cgi?id=196694
399         <rdar://problem/48388734>
400
401         Rubber-stamped by Aakash Jain.
402
403         * Scripts/webkitpy/port/image_diff.py:
404         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
405         * Scripts/webkitpy/port/server_process.py:
406         (ServerProcess.has_available_stdout): Check if stdout has data in it.
407         (ServerProcess._wait_for_data_and_update_buffers_using_select):
408         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
409         * Scripts/webkitpy/port/server_process_mock.py:
410         (MockServerProcess.has_available_stdout):
411         * Scripts/webkitpy/port/server_process_unittest.py:
412         (TestServerProcess.serial_test_basic):
413
414 2019-04-09  Jer Noble  <jer.noble@apple.com>
415
416         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
417         https://bugs.webkit.org/show_bug.cgi?id=196097
418
419         Reviewed by Eric Carlson.
420
421         Drive-by bug fix: allow tests to play audio without a user gesture by default.
422
423         * DumpRenderTree/mac/DumpRenderTree.mm:
424         (resetWebPreferencesToConsistentValues):
425         * WebKitTestRunner/TestController.cpp:
426         (WTR::TestController::resetPreferencesToConsistentValues):
427
428 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
429
430         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
431         https://bugs.webkit.org/show_bug.cgi?id=196690
432
433         Reviewed by Michael Catanzaro.
434
435         * QueueStatusServer/config/queues.py:
436         * Scripts/webkitpy/common/config/ews.json:
437         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
438         (test_ews_name):
439
440 2019-04-09  Chris Dumez  <cdumez@apple.com>
441
442         Loads using loadHTMLString() cause flashing when process-swapping
443         https://bugs.webkit.org/show_bug.cgi?id=196714
444         <rdar://problem/49637354>
445
446         Reviewed by Antti Koivisto.
447
448         Add API test coverage.
449
450         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
451
452 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
453
454         Unreviewed. Fix ATK accessibility tests after r244059.
455
456         We are failing to load the injected bundle due to undefined symbol
457         AccessibilityUIElement::replaceTextInRange().
458
459         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
460         (WTR::AccessibilityUIElement::replaceTextInRange):
461
462 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
463
464         AX: Support API: accessibilityReplaceRange:withText
465         https://bugs.webkit.org/show_bug.cgi?id=196636
466
467         Unreviewed build fix for Windows port.
468
469         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
470         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
471
472 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
473
474         [CMake][WinCairo] Separate copied headers into different directories
475         https://bugs.webkit.org/show_bug.cgi?id=196655
476
477         Reviewed by Michael Catanzaro.
478
479         * DumpRenderTree/CMakeLists.txt:
480         * MiniBrowser/win/CMakeLists.txt:
481         * TestWebKitAPI/CMakeLists.txt:
482         * TestWebKitAPI/PlatformWin.cmake:
483
484 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
485
486         Log stack-trace for run-webkit-tests when interrupted
487         https://bugs.webkit.org/show_bug.cgi?id=176393
488         <rdar://problem/34262310>
489
490         Reviewed by Lucas Forschler.
491
492         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
493         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
494         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
495         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
496         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
497         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
498         (main): Set handlers to log stack trace on interruption.
499
500 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
501
502         AX: Support API: accessibilityReplaceRange:withText
503         https://bugs.webkit.org/show_bug.cgi?id=196636
504
505         Unreviewed build fix for Windows port.
506
507         * DumpRenderTree/AccessibilityUIElement.cpp:
508         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
509
510 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
511
512         [ews-build] Scripts using Buildbot API have CORS error
513         https://bugs.webkit.org/show_bug.cgi?id=196709
514
515         Reviewed by Alexey Proskuryakov.
516
517         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
518
519 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
520
521         AX: Support API: accessibilityReplaceRange:withText
522         https://bugs.webkit.org/show_bug.cgi?id=196636
523
524         Reviewed by Daniel Bates.
525
526         * DumpRenderTree/AccessibilityUIElement.cpp:
527         (replaceTextInRangeCallback):
528         (AccessibilityUIElement::replaceTextInRange):
529         (AccessibilityUIElement::getJSClass):
530         * DumpRenderTree/AccessibilityUIElement.h:
531         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
532         (AccessibilityUIElement::replaceTextInRange):
533         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
534         (AccessibilityUIElement::replaceTextInRange):
535         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
536         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
537         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
538         (WTR::AccessibilityUIElement::replaceTextInRange):
539         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
540         (WTR::AccessibilityUIElement::replaceTextInRange):
541
542 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
543
544         [iOS] Do not allow starting selection drags when selection views are not visible
545         https://bugs.webkit.org/show_bug.cgi?id=196686
546         <rdar://problem/49399192>
547
548         Reviewed by Tim Horton.
549
550         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
551         also add some new API tests to cover scenarios where the web view is not first responder.
552
553         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
554         (TestWebKitAPI::TEST):
555         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
556
557         Add a switch to optionally make the web view first responder when starting the simulated drag.
558
559         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
560         (-[DragAndDropSimulator initWithWebView:]):
561         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
562
563 2019-04-08  Justin Fan  <justin_fan@apple.com>
564
565         [Web GPU] Fix Web GPU experimental feature on iOS
566         https://bugs.webkit.org/show_bug.cgi?id=196632
567
568         Reviewed by Myles C. Maxfield.
569
570         Properly make Web GPU available on iOS 11+.
571
572         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
573
574 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
575
576         [ews-build] Do not upload archive when Compile Fails
577         https://bugs.webkit.org/show_bug.cgi?id=196674
578
579         Reviewed by Alexey Proskuryakov.
580
581         * BuildSlaveSupport/ews-build/factories.py:
582         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
583         * BuildSlaveSupport/ews-build/steps.py:
584         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
585         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
586         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
587
588 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
589
590         Enable DFG on MIPS
591         https://bugs.webkit.org/show_bug.cgi?id=196689
592
593         Reviewed by Žan Doberšek.
594
595         Since the bytecode change, we enabled the baseline JIT on mips in
596         r240432, but DFG is still missing. With this change, all tests are
597         passing on a ci20 board.
598
599         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
600
601 2019-04-08  Philippe Normand  <pnormand@igalia.com>
602
603         [Flatpak] Second run update-webkitwpe-flatpak fails
604         https://bugs.webkit.org/show_bug.cgi?id=192702
605
606         Reviewed by Carlos Garcia Campos.
607
608         * flatpak/flatpakutils.py:
609         (FlatpakObject.flatpak): Fix typo.
610         (FlatpakPackage.install): When installing, also update to the configured remote commit.
611         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
612
613 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
614
615         [GTK][WPE] outlook.live.com displays old-fashioned UI
616         https://bugs.webkit.org/show_bug.cgi?id=196642
617
618         Reviewed by Carlos Garcia Campos.
619
620         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
621         (TestWebKitAPI::TEST): New Mac platform quirk test.
622
623 2019-04-07  Commit Queue  <commit-queue@webkit.org>
624
625         Unreviewed, rolling out r243956.
626         https://bugs.webkit.org/show_bug.cgi?id=196688
627
628         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
629         by aakashjain on #webkit).
630
631         Reverted changeset:
632
633         "Clicking "Go Back" from a safe browsing warning from an
634         iframe should navigate the WKWebView back to the previous
635         page"
636         https://bugs.webkit.org/show_bug.cgi?id=196665
637         https://trac.webkit.org/changeset/243956
638
639 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
640
641         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
642         https://bugs.webkit.org/show_bug.cgi?id=196669
643
644         Reviewed by Geoffrey Garen.
645
646         Added three new unit tests for WeakHashSet.
647
648         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
649         (WTF_WeakPtr.WeakHashSetConstObjects):
650         (WTF_WeakPtr.WeakHashSetComputesEmpty):
651         (WTF_WeakPtr.WeakHashSetComputeSize):
652
653 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
654
655         Hide next and previous form control buttons when WKWebView is editable
656         https://bugs.webkit.org/show_bug.cgi?id=196672
657         <rdar://problem/35625321>
658
659         Reviewed by Tim Horton.
660
661         Add a new API test.
662
663         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
664         (-[TestWKWebView lastTrailingBarButtonGroup]):
665         (TestWebKitAPI::TEST):
666         * TestWebKitAPI/ios/UIKitSPI.h:
667
668 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
669
670         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
671         https://bugs.webkit.org/show_bug.cgi?id=196077
672         <rdar://problem/49108202>
673
674         Reviewed by Chris Dumez.
675
676         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
677         on new web view.
678
679         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
680
681 2019-04-05  Saam Barati  <sbarati@apple.com>
682
683         Make compare-results understand MotionMark
684         https://bugs.webkit.org/show_bug.cgi?id=196666
685
686         Reviewed by Yusuke Suzuki.
687
688         * Scripts/compare-results:
689         (PLT5Results):
690         (detectMotionMark):
691         (detectMotionMark1_1):
692         (motionMarkResults):
693         (motionMark1_1Results):
694         (detectBenchmark):
695         (biggerIsBetter):
696         (main):
697
698 2019-04-05  Alex Christensen  <achristensen@webkit.org>
699
700         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
701         https://bugs.webkit.org/show_bug.cgi?id=196665
702         <rdar://45115669>
703
704         Reviewed by Geoff Garen.
705
706         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
707         (goBack):
708         (+[SimpleLookupContext sharedLookupContext]):
709         (-[SimpleLookupContext lookUpURL:completionHandler:]):
710         (TEST):
711         (+[Simple3LookupContext sharedLookupContext]): Deleted.
712         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
713
714 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
715
716         [ews-build] Add configuration and architecture for windows builders
717         https://bugs.webkit.org/show_bug.cgi?id=196660
718
719         Reviewed by Lucas Forschler.
720
721         * BuildSlaveSupport/ews-build/config.json:
722
723 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
724
725         webkitpy: Don't run subsequent rounds if interrupted
726         https://bugs.webkit.org/show_bug.cgi?id=196646
727
728         Reviewed by Aakash Jain.
729
730         * Scripts/webkitpy/layout_tests/controllers/manager.py:
731         (Manager.run): Bail out if interrupted.
732
733 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
734
735         Test sessionStorage in PSON private browsing mode
736         https://bugs.webkit.org/show_bug.cgi?id=196561
737
738         Reviewed by Alex Christensen.
739
740         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
741
742 2019-04-05  Commit Queue  <commit-queue@webkit.org>
743
744         Unreviewed, rolling out r243833.
745         https://bugs.webkit.org/show_bug.cgi?id=196645
746
747         This change breaks build of WPE and GTK ports (Requested by
748         annulen on #webkit).
749
750         Reverted changeset:
751
752         "[CMake][WTF] Mirror XCode header directories"
753         https://bugs.webkit.org/show_bug.cgi?id=191662
754         https://trac.webkit.org/changeset/243833
755
756 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
757
758         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
759         https://bugs.webkit.org/show_bug.cgi?id=196635
760
761         Reviewed by Antti Koivisto.
762         
763         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
764         for a test to enable async frame scrolling via:
765             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
766         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
767         
768         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
769
770         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
771         (WTR::InjectedBundle::beginTesting):
772         * WebKitTestRunner/TestController.cpp:
773         (WTR::TestController::resetPreferencesToConsistentValues):
774
775 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
776
777         Use a correct LC_RPATH when building with ASan
778         https://bugs.webkit.org/show_bug.cgi?id=196576
779
780         Reviewed by David Kilzer.
781
782         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
783         so that ../Frameworks is checked. This is simpler and more reliable than updating
784         each SPC service xcconfig.
785
786 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
787
788         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
789         https://bugs.webkit.org/show_bug.cgi?id=196629
790
791         Reviewed by Lucas Forschler.
792
793         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
794
795 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
796
797         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
798         https://bugs.webkit.org/show_bug.cgi?id=196618
799
800         Reviewed by Lucas Forschler.
801
802         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
803         (StatusBubble): Added QUEUE_TRIGGERS.
804         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
805         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
806         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
807         its parent(builder).
808
809 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
810
811         [ews-app] Status-bubble steps are sometimes displayed in reverse order
812         https://bugs.webkit.org/show_bug.cgi?id=196625
813
814         Reviewed by Lucas Forschler.
815
816         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
817         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
818
819 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
820
821         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
822         https://bugs.webkit.org/show_bug.cgi?id=196630
823
824         Reviewed by Wenson Hsieh.
825
826         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
827
828 2019-04-04  Youenn Fablet  <youenn@apple.com>
829
830         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
831         https://bugs.webkit.org/show_bug.cgi?id=196543
832
833         Reviewed by Alex Christensen.
834
835         * WebKitTestRunner/TestController.cpp:
836         (WTR::TestController::generatePageConfiguration):
837
838 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
839
840         [ews-app] Status bubble should not display skipped buildbot steps
841         https://bugs.webkit.org/show_bug.cgi?id=196584
842
843         Reviewed by Lucas Forschler.
844
845         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
846
847 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
848
849         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
850         https://bugs.webkit.org/show_bug.cgi?id=196620
851
852         Reviewed by Lucas Forschler.
853
854         * BuildSlaveSupport/ews-app/ews/config.py:
855
856 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
857
858         [Win] DumpRenderTreeWatchDog.py is not checked into source
859         https://bugs.webkit.org/show_bug.cgi?id=196567
860         <rdar://problem/49525901>
861
862         Reviewed by Lucas Forschler.
863
864         This script is used on Win EWS bots to terminate hanging DRT processes.
865
866         * EWSTools/dumprendertreewatchdog.py: Added.
867
868 2019-04-04  Chris Dumez  <cdumez@apple.com>
869
870         Unreviewed, roll out r243858 which made tests time out.
871
872         Disable new API tests on Windows instead.
873
874         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
875         (TestWebKitAPI::TEST):
876
877 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
878
879         [ATK] Cleanup WebPageAccessibilityObjectAtk
880         https://bugs.webkit.org/show_bug.cgi?id=196537
881
882         Reviewed by Michael Catanzaro.
883
884         Also consider files under atk directories as exceptions for GObject conventions.
885
886         * Scripts/webkitpy/style/checkers/cpp.py:
887         (check_identifier_name_in_declaration):
888
889 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
890
891         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
892         https://bugs.webkit.org/show_bug.cgi?id=196588
893         <rdar://problem/49365787>
894
895         Unreviewed build fix for Windows port.
896
897         error C3861: 'kill': identifier not found
898
899         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
900         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
901
902 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
903
904         [ews-build] Cancel build and similar operations should have authentication
905         https://bugs.webkit.org/show_bug.cgi?id=196520
906
907         Reviewed by Dewei Zhu.
908
909         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
910         environment variables.
911
912 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
913
914         [ews-build] Do not trigger queues which are not in production yet
915         https://bugs.webkit.org/show_bug.cgi?id=196581
916
917         Reviewed by Dewei Zhu.
918
919         * BuildSlaveSupport/ews-build/config.json:
920
921 2019-04-03  Chris Dumez  <cdumez@apple.com>
922
923         Unreviewed, fix typo in the name of API test added in r243848.
924
925         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
926         (TestWebKitAPI::TEST):
927
928 2019-04-03  Chris Dumez  <cdumez@apple.com>
929
930         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
931         https://bugs.webkit.org/show_bug.cgi?id=196588
932         <rdar://problem/49365787>
933
934         Reviewed by Ryosuke Niwa.
935
936         Add API test coverage.
937
938         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
939         (TestWebKitAPI::nullJavaScriptCallback):
940         (TestWebKitAPI::didCrashCheckFrames):
941         (TestWebKitAPI::TEST):
942
943 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
944
945         run-webkit-tests: Upload test results (new results database)
946         https://bugs.webkit.org/show_bug.cgi?id=196577
947         <rdar://problem/34841155>
948
949         Reviewed by Lucas Forschler.
950
951         * Scripts/webkitpy/layout_tests/controllers/manager.py:
952         (Manager.run): Upload results after each device shard, since the configuration will be
953         different for each device.
954         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
955         uploaded to a results database.
956         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
957         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
958
959 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
960
961         -apple-trailing-word is needed for browser detection
962         https://bugs.webkit.org/show_bug.cgi?id=196575
963
964         Unreviewed.
965
966         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
967
968 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
969
970         [CMake][WTF] Mirror XCode header directories
971         https://bugs.webkit.org/show_bug.cgi?id=191662
972
973         Reviewed by Konstantin Tokarev.
974
975         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
976         builds.
977
978         * CMakeLists.txt:
979         * DumpRenderTree/CMakeLists.txt:
980         * DumpRenderTree/PlatformWin.cmake:
981         * MiniBrowser/win/CMakeLists.txt:
982         * TestWebKitAPI/CMakeLists.txt:
983         * TestWebKitAPI/PlatformWin.cmake:
984         * WebKitTestRunner/PlatformGTK.cmake:
985         * WebKitTestRunner/PlatformWin.cmake:
986
987 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
988
989         [ews-app] Status bubble should not display certain infrastructure status messages
990         https://bugs.webkit.org/show_bug.cgi?id=196550
991
992         Reviewed by Lucas Forschler.
993
994         Do not display the steps which are un-needed for end-user. This information is still avaiable
995         if the user click on the bubble and look at the Buildbot build.
996         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
997         (StatusBubble._steps_messages):
998         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
999
1000 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1001
1002         [ews-build] Use https for sending data to ews-app
1003         https://bugs.webkit.org/show_bug.cgi?id=196492
1004
1005         Reviewed by Lucas Forschler.
1006
1007         * BuildSlaveSupport/ews-build/events.py:
1008
1009 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1010
1011         Remove support for -apple-trailing-word
1012         https://bugs.webkit.org/show_bug.cgi?id=196525
1013
1014         Reviewed by Zalan Bujtas.
1015
1016         This CSS property is nonstandard and not used.
1017
1018         * Scripts/webkitperl/FeatureList.pm:
1019         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1020
1021 2019-04-03  Youenn Fablet  <youenn@apple.com>
1022
1023         Add a test for DOMCache on multiple browsing in case of private browsing
1024         https://bugs.webkit.org/show_bug.cgi?id=196524
1025
1026         Reviewed by Alex Christensen.
1027
1028         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1029         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1030
1031 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1032
1033         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1034         https://bugs.webkit.org/show_bug.cgi?id=196540
1035
1036         Reviewed by Aakash Jain.
1037
1038         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1039
1040 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1041
1042         Add plumbing for a compatibility mode preference in WebKit
1043         https://bugs.webkit.org/show_bug.cgi?id=196005
1044
1045         Reviewed by Tim Horton.
1046
1047         Add new API tests.
1048
1049         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1050         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1051
1052 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1053
1054         [WPE][GTK] Update libsrtp dependency package for Debian
1055         https://bugs.webkit.org/show_bug.cgi?id=196528
1056
1057         Reviewed by Frédéric Wang.
1058
1059         * gtk/install-dependencies:
1060         * wpe/install-dependencies:
1061
1062 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1063
1064         [WK2] Add support for Window's beforeprint / afterprint events
1065         https://bugs.webkit.org/show_bug.cgi?id=196478
1066         <rdar://problem/49535124>
1067
1068         Unreviewed build fix for MSVC.
1069
1070         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1071
1072         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1073
1074         * WebKitTestRunner/TestController.cpp:
1075         (WTR::printFrame): Use int and float literals.
1076
1077 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1078
1079         [ews-build] Reassign bots to queues
1080
1081         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1082
1083 2019-04-02  Chris Dumez  <cdumez@apple.com>
1084
1085         [WK2] Add support for Window's beforeprint / afterprint events
1086         https://bugs.webkit.org/show_bug.cgi?id=196478
1087
1088         Reviewed by Alex Christensen.
1089
1090         Add minimal implementation for printFrame in WebKitTestRunner.
1091
1092         * WebKitTestRunner/TestController.cpp:
1093         (WTR::printFrame):
1094         (WTR::TestController::createOtherPage):
1095         (WTR::TestController::createWebViewWithOptions):
1096
1097 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1098
1099         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1100         https://bugs.webkit.org/show_bug.cgi?id=196491
1101
1102         Reviewed by Lucas Forschler.
1103
1104         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1105
1106 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1107
1108         [ews-build] Configure buildbot try credentials in environment variables
1109         https://bugs.webkit.org/show_bug.cgi?id=196501
1110
1111         Reviewed by Lucas Forschler.
1112
1113         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1114         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1115         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1116
1117 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1118
1119         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1120         https://bugs.webkit.org/show_bug.cgi?id=196496
1121         <rdar://problem/49521634>
1122
1123         Reviewed by Chris Dumez.
1124
1125         Add new API tests (see WebKit ChangeLog for more detail).
1126
1127         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1128         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1129         (TEST):
1130
1131 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1132
1133         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1134         <https://webkit.org/b/196499>
1135
1136         Reviewed by Alexey Proskuryakov.
1137
1138         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1139         ENABLE_ADDRESS_SANITIZER.
1140
1141 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1142
1143         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1144         https://bugs.webkit.org/show_bug.cgi?id=182757
1145
1146         Reviewed by Don Olmstead.
1147
1148         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1149         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1150
1151 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1152
1153         run-api-tests: Upload test results
1154         https://bugs.webkit.org/show_bug.cgi?id=196323
1155         <rdar://problem/49356714>
1156
1157         Reviewed by Lucas Forschler.
1158
1159         * Scripts/webkitpy/api_tests/manager.py:
1160         (Manager):
1161         (Manager.run): Upload results to a results database.
1162         * Scripts/webkitpy/api_tests/run_api_tests.py:
1163         (parse_args): Add upload arguments.
1164         * Scripts/webkitpy/port/base.py:
1165         (Port):
1166         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1167         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1168         with commits from any other associated repositories.
1169         * Scripts/webkitpy/port/device.py:
1170         (Device):
1171         (Device.build_version): Access build_versoin of underlying platform device.
1172         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1173         (IOSSimulatorTest):
1174         (IOSSimulatorTest.test_configuration_for_upload):
1175         * Scripts/webkitpy/port/device_port.py:
1176         (DevicePort):
1177         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1178         the same as the machine uploading results.
1179         * Scripts/webkitpy/port/mac.py:
1180         (MacPort):
1181         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1182         * Scripts/webkitpy/port/mac_unittest.py:
1183         (MacTest):
1184         (MacTest.test_configuration_for_upload):
1185         * Scripts/webkitpy/xcode/simulated_device.py:
1186         (SimulatedDeviceManager._create_device_with_runtime):
1187         (SimulatedDevice.__init__): Create simulated device with a build_version.
1188         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1189         (test_existing_simulator):
1190
1191 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1192
1193         Remove extra newline characters (Follow-up fix to r243707)
1194
1195         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1196
1197 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1198
1199         [ews-app] Use API_KEY to accept results data
1200         https://bugs.webkit.org/show_bug.cgi?id=196461
1201
1202         Reviewed by Dewei Zhu.
1203
1204         * BuildSlaveSupport/ews-app/ews/views/results.py:
1205         (Results.post): Validate EWS_API_KEY before accepting any data.
1206         * BuildSlaveSupport/ews-build/events.py:
1207         (Events.sendData): Send EWS_API_KEY if available along with event data.
1208
1209 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1210
1211         Unable to copy and paste a PDF from Notes into Mail compose body
1212         https://bugs.webkit.org/show_bug.cgi?id=196442
1213         <rdar://problem/48573098>
1214
1215         Reviewed by Tim Horton.
1216
1217         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1218         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1219         to be specified on the item providers.
1220
1221         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1222         (TestWebKitAPI::mapItemForTesting):
1223         (TestWebKitAPI::contactItemForTesting):
1224
1225 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1226
1227         Make UIWKDocumentContext rects per-character instead of per-word
1228         https://bugs.webkit.org/show_bug.cgi?id=196459
1229
1230         Reviewed by Wenson Hsieh.
1231
1232         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1233         (TEST):
1234         Adjust test results due to switching to per-character rects.
1235
1236 2019-04-01  Chris Dumez  <cdumez@apple.com>
1237
1238         UIProcess crash when a prewarmed process is terminated
1239         https://bugs.webkit.org/show_bug.cgi?id=196451
1240         <rdar://problem/49245471>
1241
1242         Reviewed by Geoffrey Garen.
1243
1244         Add API test coverage.
1245
1246         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1247         (TEST):
1248
1249 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1250
1251         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1252         https://bugs.webkit.org/show_bug.cgi?id=196449
1253
1254         Reviewed by Lucas Forschler.
1255
1256         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1257         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1258         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1259         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1260
1261 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1262
1263         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1264         https://bugs.webkit.org/show_bug.cgi?id=196444
1265
1266         Reviewed by Lucas Forschler.
1267
1268         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1269
1270 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1271
1272         Add SPI to canonicalize NSURLs with WTF::URL
1273         https://bugs.webkit.org/show_bug.cgi?id=196415
1274         <rdar://problem/44980271>
1275
1276         Reviewed by Darin Adler.
1277
1278         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1279         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1280         (TestWebKitAPI::TEST):
1281
1282 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1283
1284         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1285         https://bugs.webkit.org/show_bug.cgi?id=196441
1286
1287         Reviewed by Carlos Garcia Campos.
1288
1289         Don't cache the wpe_view_backend object that might not exist yet at the
1290         time of EventSenderProxy constructor invocation, but instead retrieve
1291         that object whenever it's required for event dispatching. This should
1292         avoid crashes in this constructor now that it's invoked before any
1293         PlatformWindow has been set up (as changed in r243496).
1294
1295         * WebKitTestRunner/EventSenderProxy.h:
1296         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1297         (WTR::viewBackend):
1298         (WTR::EventSenderProxy::EventSenderProxy):
1299         (WTR::EventSenderProxy::mouseDown):
1300         (WTR::EventSenderProxy::mouseUp):
1301         (WTR::EventSenderProxy::mouseMoveTo):
1302         (WTR::EventSenderProxy::mouseScrollBy):
1303         (WTR::EventSenderProxy::keyDown):
1304         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1305
1306 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1307
1308         [Win][WebKit] MiniBrowser should support high DPI display
1309         https://bugs.webkit.org/show_bug.cgi?id=196391
1310
1311         Reviewed by Alex Christensen.
1312
1313         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1314         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1315         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1316         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1317
1318 2019-03-31  Sam Weinig  <weinig@apple.com>
1319
1320         Remove more i386 specific configurations
1321         https://bugs.webkit.org/show_bug.cgi?id=196430
1322
1323         Reviewed by Alexey Proskuryakov.
1324
1325         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1326         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1327
1328 2019-03-31  Andy Estes  <aestes@apple.com>
1329
1330         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1331         https://bugs.webkit.org/show_bug.cgi?id=196433
1332         <rdar://problem/49293305>
1333
1334         Reviewed by Tim Horton.
1335
1336         Enhanced API test coverage to include all navigation response policy decisions in both
1337         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1338
1339         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1340         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1341         (TestWebKitAPI::TEST):
1342         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1343         (readFile):
1344         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1345         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1346         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1347         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1348         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1349         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1350         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1351         (-[QuickLookDelegate _downloadDidStart:]):
1352         (-[QuickLookDelegate _download:didReceiveResponse:]):
1353         (-[QuickLookDelegate _download:didReceiveData:]):
1354         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1355         (-[QuickLookDelegate _downloadDidFinish:]):
1356         (-[QuickLookDelegate _download:didFailWithError:]):
1357         (-[QuickLookDelegate _downloadDidCancel:]):
1358         (-[QuickLookDelegate verifyDownload]):
1359         (runTest):
1360         (runTestDecideBeforeLoading):
1361         (runTestDecideAfterLoading):
1362         (TEST):
1363         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1364         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1365         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1366         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1367         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1368         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1369         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1370         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1371         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1372         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1373         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1374         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1375         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1376         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1377
1378 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1379
1380         [CMake] add testdfg as target with build-jsc
1381         https://bugs.webkit.org/show_bug.cgi?id=196393
1382
1383         Reviewed by Saam Barati.
1384
1385         Added testdfg as one of the targets to build when
1386         using CMake.
1387
1388         * Scripts/build-jsc:
1389
1390 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1391
1392         Delete WebMetal implementation in favor of WebGPU
1393         https://bugs.webkit.org/show_bug.cgi?id=195418
1394
1395         Reviewed by Dean Jackson.
1396
1397         * DumpRenderTree/mac/DumpRenderTree.mm:
1398         (enableExperimentalFeatures):
1399         (resetWebPreferencesToConsistentValues):
1400         * Scripts/webkitperl/FeatureList.pm:
1401         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1403         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1404         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1405         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1406         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1407         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1408         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1409         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1410         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1411         (WTR::InjectedBundle::beginTesting):
1412         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1413         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1414         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1415
1416 2019-03-29  Chris Dumez  <cdumez@apple.com>
1417
1418         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1419         https://bugs.webkit.org/show_bug.cgi?id=196405
1420         <rdar://problem/49428130>
1421
1422         Reviewed by Wenson Hsieh.
1423
1424         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1425         the popover presentation methods to be no-ops. Use this in the new test added in
1426         r243523 so that we do not swizzle those methods for all tests. This is needed because
1427         those WatchOS tests rely on the popover getting presented and interactive.
1428
1429         * WebKitTestRunner/TestController.cpp:
1430         (WTR::updateTestOptionsFromTestHeader):
1431         * WebKitTestRunner/TestController.h:
1432         * WebKitTestRunner/TestOptions.h:
1433         (WTR::TestOptions::hasSameInitializationOptions const):
1434         * WebKitTestRunner/ios/TestControllerIOS.mm:
1435         (WTR::TestController::platformInitialize):
1436         (WTR::TestController::platformResetStateToConsistentValues):
1437
1438 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1439
1440         [Curl] Add Server Trust Evaluation Support.
1441         https://bugs.webkit.org/show_bug.cgi?id=191646
1442
1443         Reviewed by Fujii Hironori.
1444
1445         Implemented MiniBrowser UI for asking if user trusts the server.
1446
1447         * MiniBrowser/win/Common.cpp:
1448         (askServerTrustEvaluation):
1449         (replaceString):
1450         * MiniBrowser/win/Common.h:
1451         * MiniBrowser/win/MiniBrowserLib.rc:
1452         * MiniBrowser/win/MiniBrowserLibResource.h:
1453         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1454         (createPEMString):
1455         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1456         (WebKitBrowserWindow::canTrustServerCertificate):
1457         * MiniBrowser/win/WebKitBrowserWindow.h:
1458
1459 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1460
1461         Implement ResizeObserver.
1462         https://bugs.webkit.org/show_bug.cgi?id=157743
1463
1464         Reviewed by Simon Fraser.
1465
1466         Support resizeObserverEnabled webPreferences.
1467
1468         * DumpRenderTree/TestOptions.cpp:
1469         (TestOptions::TestOptions):
1470         * DumpRenderTree/TestOptions.h:
1471         * DumpRenderTree/mac/DumpRenderTree.mm:
1472         (setWebPreferencesForTestOptions):
1473         * DumpRenderTree/win/DumpRenderTree.cpp:
1474         (enableExperimentalFeatures):
1475         * Scripts/webkitperl/FeatureList.pm:
1476         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1477
1478 2019-03-28  John Wilander  <wilander@apple.com>
1479
1480         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1481         https://bugs.webkit.org/show_bug.cgi?id=196281
1482         <rdar://problem/48938748>
1483
1484         Reviewed by Alex Christensen.
1485
1486         This patch adds the function isStatisticsHasLocalStorage() to the
1487         TestRunner. With it, the page can query the WebsiteDataStore in the
1488         UI process to make sure that it sees LocalStorage.
1489
1490         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1491         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1492         (WTR::TestRunner::isStatisticsHasLocalStorage):
1493         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1494         * WebKitTestRunner/TestController.cpp:
1495         (WTR::TestController::isStatisticsHasLocalStorage):
1496         * WebKitTestRunner/TestController.h:
1497         * WebKitTestRunner/TestInvocation.cpp:
1498         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1499
1500 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1501
1502         API::Data::createWithoutCopying should do a null check before calling CFRelease
1503         https://bugs.webkit.org/show_bug.cgi?id=196276
1504         <rdar://problem/48059859>
1505
1506         Reviewed by Alex Christensen.
1507
1508         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1509
1510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1511         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1512         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1513         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1514         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1515         (TestWebKitAPI::TEST):
1516
1517 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1518
1519         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1520         https://bugs.webkit.org/show_bug.cgi?id=186276
1521
1522         Reviewed by Carlos Garcia Campos.
1523
1524         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1525         (webViewLoadChanged):
1526         (testWebResourceGetDataError):
1527         (testWebResourceGetDataEmpty):
1528         (beforeAll):
1529         (webViewloadChanged): Deleted.
1530
1531 2019-03-27  Andy Estes  <aestes@apple.com>
1532
1533         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1534         https://bugs.webkit.org/show_bug.cgi?id=196317
1535
1536         Reviewed by Dan Bernstein.
1537
1538         package-root copies built products into a staging directory using ditto(1), which does not
1539         follow symbolic links as it traverses a directory. Now that the files in
1540         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1541         itself, these become broken links when ditto'd into the staging directory.
1542
1543         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1544
1545         * Scripts/package-root:
1546
1547 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1548
1549         [ews-app] Update display text of Submit for ews analysis
1550         https://bugs.webkit.org/show_bug.cgi?id=196309
1551
1552         Reviewed by Dewei Zhu.
1553
1554         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1555
1556 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1557
1558         run-webkit-tests should check for leaks in WebKit processes
1559         <https://webkit.org/b/193772>
1560         <rdar://problem/46526680>
1561
1562         Reviewed by Ryosuke Niwa.
1563
1564         This works by doing the following:
1565         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1566           The list of child processes are returned one per line:
1567           process.name: pid
1568         - Run the "#LIST CHILD PROCESSES" command just before the
1569           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1570           processes on the ServerProcess object.
1571         - When the `--leaks` switch is handled, run check_for_leaks() on
1572           each child process after the main test harness.
1573
1574         * DumpRenderTree/mac/DumpRenderTree.mm:
1575         (handleControlCommand):
1576         - Use strncmp() instead of strcmp().
1577         - Add support for handling "#LIST CHILD PROCESSES" command.
1578
1579         * Scripts/webkitpy/port/base.py:
1580         (Port.check_for_leaks):
1581         * Scripts/webkitpy/port/darwin.py:
1582         (DarwinPort.check_for_leaks):
1583         - Rename redundant 'process_pid' argument to 'process_id'.
1584
1585         * Scripts/webkitpy/port/driver.py:
1586         (Driver.do_post_tests_work):
1587         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1588           longer the only command this sends to WebKitTestRunner.
1589         - If the `--leaks` switch is present, send the
1590           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1591           result using Port.set_webkit_processes().
1592         (Driver._parse_child_processes_output):
1593         - Add helper method to parse list of child process names and
1594           process IDs returned from WebKitTestRunner.
1595
1596         * Scripts/webkitpy/port/ios_device.py:
1597         (IOSDevicePort.check_for_leaks):
1598         - Rename redundant 'process_pid' argument to 'process_id'.
1599
1600         * Scripts/webkitpy/port/leakdetector.py:
1601         (LeakDetector._parse_leaks_output):
1602         - Return early if there is no leaks_output.
1603         (LeakDetector.check_for_leaks):
1604         - Rename redundant 'process_pid' argument to 'process_id'.
1605
1606         * Scripts/webkitpy/port/server_process.py:
1607         (ServerProcess.__init__):
1608         (ServerProcess.child_processes):
1609         (ServerProcess.set_child_processes):
1610         - Add instance variable to Port to store list of child process
1611           names and process IDs returned from WebKitTestRunner.
1612         (ServerProcess._start):
1613         - Clear self._child_processes.
1614         (ServerProcess.stop):
1615         - If self._child_processes is set, call
1616           self._port.check_for_leaks() for each child process.
1617
1618         * Scripts/webkitpy/port/server_process_unittest.py:
1619         (TrivialMockPort.check_for_leaks):
1620         - Rename redundant 'process_pid' argument to 'process_id'.
1621
1622         * Scripts/webkitpy/port/simulator_process.py:
1623         (SimulatorProcess.stop):
1624         - If self._child_processes is set, call
1625           self._port.check_for_leaks() for each child process.
1626
1627         * Scripts/webkitpy/port/watch_device.py:
1628         (WatchDevicePort.check_for_leaks):
1629         - Rename redundant 'process_pid' argument to 'process_id'.
1630
1631         * WebKitTestRunner/TestController.cpp:
1632         (WTR::TestController::dumpResponse):
1633         - Extract method from findAndDumpWorldLeaks() so that it may be
1634           reused by findAndDumpWebKitProcessIdentifiers().
1635         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1636         - Add method to output process name and process ID of both the
1637           WebContent and Networking processes.
1638         (WTR::TestController::findAndDumpWorldLeaks):
1639         - Fix missing newline in output when there were no abandoned
1640           documents.
1641         - Call dumpResponse() for extracted code.
1642         (WTR::TestController::handleControlCommand):
1643         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1644         - Use strncmp() instead of strcmp().
1645         - Call findAndDumpWebKitProcessIdentifiers() when
1646           "#LIST CHILD PROCESSES" command is sent.
1647         * WebKitTestRunner/TestController.h:
1648         (WTR::TestController::dumpResponse):
1649         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1650         - Declare methods.
1651
1652 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1653
1654         Unreviewed. Add GLib API test cases after r243434.
1655
1656         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1657         (testWebViewActiveURI):
1658         (serverCallback):
1659         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1660         (sendRequestCallback):
1661
1662 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1663
1664         Geolocation request not complete when watch request was started in a different web process
1665         https://bugs.webkit.org/show_bug.cgi?id=195996
1666
1667         Reviewed by Alex Christensen.
1668
1669         Add a test case.
1670
1671         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1672         (TestWebKitAPI::runJavaScriptAlert):
1673         (TestWebKitAPI::TEST):
1674
1675 2019-03-26  Keith Rollin  <krollin@apple.com>
1676
1677         Update the way generate-xcfilelists returns strings from functions
1678         https://bugs.webkit.org/show_bug.cgi?id=195975
1679         <rdar://problem/49040807>
1680
1681         Reviewed by Dean Jackson.
1682
1683         There are places where generate-xcfilelists executes assignments with
1684         statements like:
1685
1686             FOO=$(some_function)
1687
1688         where "some_function" return a string by echoing it. E.g.
1689
1690             some_function()
1691             {
1692                 echo "Hello, World"
1693             }
1694
1695         This is a common idiom, but it has a problem if "some_function" needs
1696         to call "exit" in an attempt to halt the entire script right then and
1697         there. Since "some_function" is called inside of $(), it's being
1698         executed in a sub-shell. Calling exit in that sub-shell simply exits
1699         that shell; it doesn't not exit the outer shell in which the main part
1700         of the script is still running. As such, the main script keeps
1701         executing when the intent was for the script to halt.
1702
1703         The solution to this is to use a different idiom for returning
1704         strings. The one we now is to pass in the name of the variable to
1705         receive the string result:
1706
1707             some_function()
1708             {
1709                 variable_name=$1
1710                 eval $variable_name ="Hello, World"
1711             }
1712
1713         The call site now looks like
1714
1715             some_function FOO
1716
1717         Because there's no invocation of a sub-shell, some_function can now
1718         call "exit" if it wants to, and the entire script will exit at that
1719         point.
1720
1721         * Scripts/generate-xcfilelists:
1722
1723 2019-03-26  Chris Dumez  <cdumez@apple.com>
1724
1725         Add basic layout test coverage for File Picker on iOS
1726         https://bugs.webkit.org/show_bug.cgi?id=196265
1727
1728         Reviewed by Wenson Hsieh.
1729
1730         Add layout test infrastructure to test the file picker on iOS.
1731
1732         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1733         (WTR::UIScriptController::dismissFilePicker):
1734         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1735         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1736         (WTR::UIScriptController::dismissFilePicker):
1737         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1738         * WebKitTestRunner/TestController.cpp:
1739         (WTR::TestController::createWebViewWithOptions):
1740         (WTR::updateTestOptionsFromTestHeader):
1741         * WebKitTestRunner/TestOptions.h:
1742         (WTR::TestOptions::hasSameInitializationOptions const):
1743         * WebKitTestRunner/ios/TestControllerIOS.mm:
1744         (overridePresentViewController):
1745         (WTR::TestController::platformInitialize):
1746         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1747         (WTR::UIScriptController::dismissFilePicker):
1748
1749 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1750
1751         Implement async paste method on UIWKInteractionViewProtocol
1752         https://bugs.webkit.org/show_bug.cgi?id=196267
1753         <rdar://problem/49236346>
1754
1755         Reviewed by Tim Horton.
1756
1757         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1758         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1759         are now a part of all iOS 12 internal SDKs.
1760
1761         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1762
1763         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1764         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1765
1766         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1767         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1768         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1769         * TestWebKitAPI/ios/UIKitSPI.h:
1770
1771 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1772
1773         [ews-build] Use PostgreSQL for ews.webkit.org database
1774         https://bugs.webkit.org/show_bug.cgi?id=196270
1775
1776         Reviewed by Lucas Forschler.
1777
1778         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1779
1780 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1781
1782         [ews] Reset simctl states on reboot
1783         https://bugs.webkit.org/show_bug.cgi?id=196260
1784
1785         Rubber-stamped by Aakash Jain.
1786
1787         * EWSTools/start-queue-mac.sh:
1788
1789 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1790
1791         [ews-build] Use PostgreSQL for ews-build database
1792         https://bugs.webkit.org/show_bug.cgi?id=196229
1793
1794         Reviewed by Lucas Forschler.
1795
1796         * BuildSlaveSupport/ews-build/master.cfg:
1797
1798 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1799
1800         [ews-build] Get master_hostname dynamically in master.cfg
1801         https://bugs.webkit.org/show_bug.cgi?id=196255
1802
1803         Reviewed by Lucas Forschler.
1804
1805         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1806         send events data in test mode.
1807
1808 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1809
1810         [ews-app] Set db_constraint to False for Foreign Keys
1811         https://bugs.webkit.org/show_bug.cgi?id=196252
1812
1813         Reviewed by Lucas Forschler.
1814
1815         * BuildSlaveSupport/ews-app/ews/models/build.py:
1816         * BuildSlaveSupport/ews-app/ews/models/step.py:
1817
1818 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1819
1820         [ews-build] is_test_mode_enabled should default to True
1821         https://bugs.webkit.org/show_bug.cgi?id=196248
1822
1823         Reviewed by Lucas Forschler.
1824
1825         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1826
1827 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1828
1829         [ews-app] Add webkitperl to ENABLED_QUEUES
1830         https://bugs.webkit.org/show_bug.cgi?id=196253
1831
1832         Reviewed by Lucas Forschler.
1833
1834         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1835
1836 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1837
1838         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1839         https://bugs.webkit.org/show_bug.cgi?id=196211
1840         rdar://problem/49110552
1841
1842         Reviewed by Tim Horton.
1843
1844         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1845         Make sure that EventSenderProxy always exists when running tests. We used to create
1846         it when resetting before the first test, which is a bit too late.
1847
1848         * WebKitTestRunner/TestController.h:
1849         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1850         (WTR::TestController::platformCreateWebView):
1851         (WTR::TestController::platformCreateOtherPage):
1852         (WTR::TestController::finishCreatingPlatformWebView):
1853         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1854         (WTR::PlatformWebView::PlatformWebView):
1855         Moved some code that made NSWindow use NSEvent during web view creation. We may
1856         need to move more if some other case us found, but this is enough for now.
1857
1858 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1859
1860         Unreviewed. Fix typo in GLib geolocation API after r243285.
1861
1862         gelocation -> geolocation.
1863
1864         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1865         (testGeolocationManagerWatchPosition):
1866
1867 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1868
1869         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1870         https://bugs.webkit.org/show_bug.cgi?id=196213
1871
1872         Reviewed by Geoff Garen.
1873
1874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1875         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1876         (credentialWithIdentityAndKeychainPath):
1877         (-[ChallengeDelegate webView:didFinishNavigation:]):
1878         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1879         (TestWebKitAPI::TEST):
1880
1881 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1882
1883         Expected shouldn't assume its contained types are copyable
1884         https://bugs.webkit.org/show_bug.cgi?id=195986
1885
1886         Reviewed by JF Bastien.
1887
1888         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1889         (TestWebKitAPI::NonCopyable::operator== const):
1890         (TestWebKitAPI::NonCopyable::operator!= const):
1891         (TestWebKitAPI::TEST):
1892
1893 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1894
1895         Remove some now-unnecessary dynamic class lookup
1896         https://bugs.webkit.org/show_bug.cgi?id=196237
1897
1898         Reviewed by Simon Fraser.
1899
1900         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1901         (makeRequest):
1902         (TEST):
1903
1904 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1905
1906         Unreviewed, rolling out r243450.
1907
1908         AppleWin and WinCairo port builds get broken.
1909
1910         Reverted changeset:
1911
1912         "Add test for fix of #196095"
1913         https://bugs.webkit.org/show_bug.cgi?id=196097
1914         https://trac.webkit.org/changeset/243450
1915
1916 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1917
1918         Unreviewed, rolling out r243465.
1919         https://bugs.webkit.org/show_bug.cgi?id=196226
1920
1921         the test doesn't build (Requested by thorton on #webkit).
1922
1923         Reverted changeset:
1924
1925         "Do not terminate the NetworkProcess if a third party
1926         application sends a NSCredential with a SecIdentityRef"
1927         https://bugs.webkit.org/show_bug.cgi?id=196213
1928         https://trac.webkit.org/changeset/243465
1929
1930 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1931
1932         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1933         https://bugs.webkit.org/show_bug.cgi?id=196213
1934
1935         Reviewed by Geoff Garen.
1936
1937         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1938         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1939         (credentialWithIdentityAndKeychainPath):
1940         (-[ChallengeDelegate webView:didFinishNavigation:]):
1941         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1942         (TestWebKitAPI::TEST):
1943
1944 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1945
1946         [ews-build] Gracefully handle missing patch_id in events
1947         https://bugs.webkit.org/show_bug.cgi?id=196216
1948
1949         Reviewed by Lucas Forschler.
1950
1951         * BuildSlaveSupport/ews-build/events.py:
1952
1953 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1954
1955         [ews-build] use lz4 compression for improving buildbot performance
1956         https://bugs.webkit.org/show_bug.cgi?id=196155
1957
1958         Reviewed by Lucas Forschler.
1959
1960         * BuildSlaveSupport/ews-build/master.cfg:
1961
1962 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1963
1964         Pull some API testing helper methods out of TestWKWebView
1965         https://bugs.webkit.org/show_bug.cgi?id=196212
1966
1967         Reviewed by Tim Horton.
1968
1969         Refactor some more API testing utility methods, so that they can be used in
1970         tests that do not use TestWKWebView.
1971
1972         * TestWebKitAPI/cocoa/TestWKWebView.h:
1973         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1974         (-[WKWebView loadTestPageNamed:]):
1975         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1976         (-[WKWebView synchronouslyLoadHTMLString:]):
1977         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1978         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1979         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1980         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1981         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1982
1983 2019-03-25  Jer Noble  <jer.noble@apple.com>
1984
1985         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1986         https://bugs.webkit.org/show_bug.cgi?id=196097
1987
1988         Reviewed by Eric Carlson.
1989
1990         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1991
1992         * DumpRenderTree/mac/DumpRenderTree.mm:
1993         (resetWebPreferencesToConsistentValues):
1994         * WebKitTestRunner/TestController.cpp:
1995         (WTR::TestController::resetPreferencesToConsistentValues):
1996
1997 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1998
1999         Pull IPadUserInterfaceSwizzler out into a separate header file
2000         https://bugs.webkit.org/show_bug.cgi?id=196193
2001
2002         Reviewed by Anders Carlsson.
2003
2004         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2005         be used in other API tests.
2006
2007         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2008         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2009         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2010         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2011         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2012         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2013         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2014
2015 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2016
2017         Remove NavigatorContentUtils in WebCore/Modules
2018         https://bugs.webkit.org/show_bug.cgi?id=196070
2019
2020         Reviewed by Alex Christensen.
2021
2022         NavigatorContentUtils was to support the custom scheme spec [1].
2023         However, in WebKit side, no port has supported the feature in
2024         WebKit layer after EFL port was removed. So there has been the
2025         only IDL implementation of the NavigatorContentUtils in WebCore.
2026         So we don't need to keep the implementation in WebCore anymore.
2027
2028         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2029
2030         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2031
2032 2019-03-24  Andy Estes  <aestes@apple.com>
2033
2034         [watchOS] Remove unused Proximity Networking code
2035         https://bugs.webkit.org/show_bug.cgi?id=196188
2036
2037         Reviewed by Tim Horton.
2038
2039         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2040         (TEST):
2041
2042 2019-03-23  Keith Miller  <keith_miller@apple.com>
2043
2044         Refactor clz/ctz and fix getLSBSet.
2045         https://bugs.webkit.org/show_bug.cgi?id=196162
2046
2047         Reviewed by Saam Barati.
2048
2049         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2050
2051         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2052         (TestWebKitAPI::TEST):
2053
2054 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2055
2056         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2057         https://bugs.webkit.org/show_bug.cgi?id=196143
2058
2059         Reviewed by Michael Catanzaro.
2060
2061         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2062         directories.
2063
2064         * Scripts/webkitpy/style/checkers/cpp.py:
2065         (check_identifier_name_in_declaration):
2066         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2067         (WebKitStyleTest.test_names):
2068
2069 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2070
2071         [Flatpak] Manifest expanding fails for qt WPE extension
2072         https://bugs.webkit.org/show_bug.cgi?id=196148
2073
2074         Reviewed by Alex Christensen.
2075
2076         * flatpak/flatpakutils.py:
2077         (expand_submodules_recurse): The last recurse manifest expand
2078         iteration might lead to a single module so take it into account
2079         and don't try to recurse further.
2080
2081 2019-03-22  Chris Dumez  <cdumez@apple.com>
2082
2083         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2084         https://bugs.webkit.org/show_bug.cgi?id=195348
2085         <rdar://problem/48622090>
2086
2087         Reviewed by Alex Christensen.
2088
2089         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2090         to NO when test.options().shouldIgnoreMetaViewport is false.
2091
2092         * WebKitTestRunner/ios/TestControllerIOS.mm:
2093         (WTR::TestController::platformConfigureViewForTest):
2094
2095 2019-03-22  Chris Dumez  <cdumez@apple.com>
2096
2097         Prewarmed processes should be usable with any website data store
2098         https://bugs.webkit.org/show_bug.cgi?id=196104
2099
2100         Reviewed by Alex Christensen.
2101
2102         Add API test coverage.
2103
2104         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2105         (runInitialWarmedProcessUsedTest):
2106         (TEST):
2107
2108 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2109
2110         Back out local changes to Alex's Subversion working directory
2111
2112         They were accidentally committed.
2113
2114         * Scripts/webkitpy/common/system/abstractexecutive.py:
2115         (AbstractExecutive.wait_newest):
2116         * Scripts/webkitpy/common/system/executive.py:
2117         (Executive.running_pids):
2118         * Scripts/webkitpy/common/system/executive_mock.py:
2119         (MockExecutive.running_pids):
2120         * Scripts/webkitpy/common/system/executive_unittest.py:
2121         (ExecutiveTest.serial_test_running_pids):
2122         * Scripts/webkitpy/port/darwin.py:
2123         (DarwinPort.check_for_leaks):
2124         * Scripts/webkitpy/port/leakdetector.py:
2125         (LeakDetector.check_for_leaks):
2126         - This was the hack attached to Bug 193772.
2127
2128         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2129         (+[WebKitTestRunnerEvent mouseLocation]):
2130         - This works around a crash on an internal build.
2131
2132 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2133
2134         Fix the build after r243354
2135         https://bugs.webkit.org/show_bug.cgi?id=196138
2136         <rdar://problem/49145951>
2137
2138         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2139         (TEST):
2140         * TestWebKitAPI/ios/UIKitSPI.h:
2141
2142 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2143
2144         Adopt UIWKDocumentContext
2145         https://bugs.webkit.org/show_bug.cgi?id=196040
2146         <rdar://problem/48642440>
2147
2148         Reviewed by Ryosuke Niwa.
2149
2150         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2151         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2152         (makeRequest):
2153         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2154         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2155         (applyStyle):
2156         (TEST):
2157         Add tests for UIWKDocumentContext.
2158
2159         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2160         (TEST):
2161         (recursiveFindWKContentView): Deleted.
2162         * TestWebKitAPI/cocoa/TestWKWebView.h:
2163         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2164         (recursiveFindWKContentView):
2165         (-[TestWKWebView wkContentView]):
2166         * TestWebKitAPI/ios/UIKitSPI.h:
2167         Share the WKContentView finding code between tests.
2168
2169 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2170
2171         [iOS WK2] Turn on async overflow scrolling by default
2172         https://bugs.webkit.org/show_bug.cgi?id=196011
2173         rdar://problem/48453859
2174
2175         Reviewed by Antti Koivisto.
2176         
2177         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2178         since so many basic layout tests have different results when compositing is triggered for
2179         overflow.
2180         
2181         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2182
2183         * WebKitTestRunner/TestController.cpp:
2184         (WTR::TestController::resetPreferencesToConsistentValues):
2185
2186 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2187
2188         [ews-build] Retry API test in case of failures
2189         https://bugs.webkit.org/show_bug.cgi?id=196004
2190
2191         Reviewed by Lucas Forschler.
2192
2193         * BuildSlaveSupport/ews-build/steps.py:
2194         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2195         (CompileWebKitToT.doStepIf): Ditto.
2196         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2197         (ReRunAPITests): Re-run API tests.
2198         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2199         (RunAPITestsWithoutPatch): Run API tests without patch.
2200         (RunAPITestsWithoutPatch.doStepIf):
2201         (RunAPITestsWithoutPatch.hideStepIf):
2202         (RunAPITestsWithoutPatch.evaluateCommand):
2203         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2204         (AnalyzeAPITestsResults.start):
2205         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2206         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2207         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2208         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2209
2210 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2211
2212         [ews-build] Update queues configurations
2213         https://bugs.webkit.org/show_bug.cgi?id=196074
2214
2215         Reviewed by Dewei Zhu.
2216
2217         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2218         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2219
2220 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2221
2222         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2223         https://bugs.webkit.org/show_bug.cgi?id=195680
2224         <rdar://problem/48903534>
2225
2226         Unreviewed infrastructure fix.
2227
2228         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2229         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2230
2231 2019-03-21  Andy Estes  <aestes@apple.com>
2232
2233         [iOS] Apple Pay should be available in documents with no user agent scripts
2234         https://bugs.webkit.org/show_bug.cgi?id=196061
2235         <rdar://problem/48649391>
2236
2237         Reviewed by Brady Eidson.
2238
2239         Added API tests and related infrastructure.
2240
2241         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2242         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2243         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2244         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2245         (TestWebKitAPI::TEST):
2246         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2247         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2248         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2249         * TestWebKitAPI/cocoa/TestProtocol.mm:
2250         (-[TestProtocol startLoading]):
2251         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2252         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2253         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2254         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2255
2256 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2257
2258         REGRESSSION (r243297): webkitpy tests broken
2259         https://bugs.webkit.org/show_bug.cgi?id=196108
2260
2261         Reviewed by Aakash Jain.
2262
2263         r243297 updated contributors.json, which broke a few unit tests.
2264
2265         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2266         (IRCCommandTest.test_whois):
2267         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2268
2269 2019-03-21  Chris Dumez  <cdumez@apple.com>
2270
2271         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2272         https://bugs.webkit.org/show_bug.cgi?id=196041
2273         <rdar://problem/49083230>
2274
2275         Reviewed by Alex Christensen.
2276
2277         Add API test coverage.
2278
2279         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2280         (TEST):
2281
2282 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2283
2284         Add SPI to inform applications of WKContentRuleList actions
2285         https://bugs.webkit.org/show_bug.cgi?id=195965
2286         <rdar://problem/42664365>
2287
2288         Reviewed by Geoff Garen.
2289
2290         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2291         (TestWebKitAPI::allActionsForResourceLoad):
2292         (TestWebKitAPI::testRequest):
2293         (TestWebKitAPI::TEST_F):
2294         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2295         (Notification::description):
2296         (Notification::operator== const):
2297         (toVector):
2298         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2299         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2300         (makeContentRuleList):
2301         (TEST):
2302         (makeWarnContentRuleList): Deleted.
2303
2304 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2305
2306         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2307         https://bugs.webkit.org/show_bug.cgi?id=196088
2308
2309         Reviewed by Brian Burg.
2310
2311         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2312         Support checks when only one platform is specified. Also deprecate macosx() and
2313         force the use of macos() instead.
2314
2315         * Scripts/webkitpy/style/checkers/cpp.py:
2316         (check_min_versions_of_wk_api_available):
2317         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2318         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2319
2320 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2321
2322         Update status inactive committers' status to 'contributor'.
2323
2324         * Scripts/webkitpy/common/config/contributors.json:
2325
2326 2019-03-21  Xan Lopez  <xan@igalia.com>
2327
2328         [JSC][x86] Drop support for x87 floating point
2329         https://bugs.webkit.org/show_bug.cgi?id=194853
2330
2331         Reviewed by Don Olmstead.
2332
2333         Force SSE2 on x86/32bit builds.
2334
2335         * Scripts/webkitdirs.pm:
2336         (generateBuildSystemFromCMakeProject):
2337
2338 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2339
2340         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2341         https://bugs.webkit.org/show_bug.cgi?id=196073
2342
2343         Reviewed by Michael Catanzaro.
2344
2345         Add test cases to check functions and constructors with no arguments but receiving user data.
2346
2347         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2348         (checkUserData):
2349         (testJSCFunction):
2350         (fooCreateWithUserData):
2351         (testJSCClass):
2352
2353 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2354
2355         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2356
2357         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2358
2359         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2360
2361 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2362
2363         [GTK][WPE] Add API to provide geolocation information
2364         https://bugs.webkit.org/show_bug.cgi?id=195940
2365
2366         Reviewed by Michael Catanzaro.
2367
2368         Add a new test to check the new API.
2369
2370         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2371         (testGeolocationManagerCurrentPosition):
2372         (testGeolocationManagerWatchPosition):
2373         (beforeAll):
2374         (afterAll):
2375         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2376         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2377         (beforeAll): Ditto.
2378         * TestWebKitAPI/glib/CMakeLists.txt:
2379
2380 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2381
2382         [GLib] Returning G_TYPE_OBJECT from a method does not work
2383         https://bugs.webkit.org/show_bug.cgi?id=195574
2384
2385         Reviewed by Michael Catanzaro.
2386
2387         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2388
2389         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2390         (getGFile):
2391         (getParent):
2392         (createGString):
2393         (getGString):
2394         (getGStringCopyWillRaise):
2395         (getGStringCopy):
2396         (getGStringStr):
2397         (getGStringLen):
2398         (freeGString):
2399         (testJSCClass):
2400
2401 2019-03-20  Saam Barati  <sbarati@apple.com>
2402
2403         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2404         https://bugs.webkit.org/show_bug.cgi?id=195721
2405
2406         Reviewed by Filip Pizlo.
2407
2408         * Scripts/run-javascriptcore-tests:
2409
2410 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2411
2412         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2413         https://bugs.webkit.org/show_bug.cgi?id=196049
2414
2415         Reviewed by Tim Horton.
2416
2417         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2418         overflow scrolling in general, so rename it.
2419
2420         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2421
2422 2019-03-20  Daniel Bates  <dabates@apple.com>
2423
2424         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2425         https://bugs.webkit.org/show_bug.cgi?id=196031
2426         <rdar://problem/49078172>
2427
2428         Reviewed by Tim Horton.
2429
2430         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2431         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2432         same code path used when the Done button is pressed to dismiss the <select> picker.
2433
2434         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2435         (TestWebKitAPI::TEST):
2436
2437 2019-03-20  Chris Dumez  <cdumez@apple.com>
2438
2439         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2440         https://bugs.webkit.org/show_bug.cgi?id=196029
2441         <rdar://problem/48954651>
2442
2443         Reviewed by Tim Horton.
2444
2445         Add API test coverage.
2446
2447         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2448
2449 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2450
2451         [ews-build] Improve failure summary string for ApplyPatch step
2452         https://bugs.webkit.org/show_bug.cgi?id=195995
2453
2454         Reviewed by Alexey Proskuryakov.
2455
2456         * BuildSlaveSupport/ews-build/steps.py:
2457         (ApplyPatch.getResultSummary): Override getResultSummary.
2458
2459 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2460
2461         AX: Implement support for new meter ARIA role
2462         https://bugs.webkit.org/show_bug.cgi?id=195966
2463
2464         Reviewed by Chris Fleizach.
2465
2466         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2467         to AXLevelIndicator.
2468
2469         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2470
2471 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2472
2473         [WebAuthN] Implement FIDO AppID extension
2474         https://bugs.webkit.org/show_bug.cgi?id=143491
2475         <rdar://problem/48298273>
2476
2477         Reviewed by Brent Fulgham.
2478
2479         Add a test that covers the new flag of convertToU2fSignCommand.
2480
2481         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2482         (TestWebKitAPI::TEST):
2483         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2484         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2485         (TestWebKitAPI::TEST):
2486
2487 2019-03-19  Keith Rollin  <krollin@apple.com>
2488
2489         Add support for more platforms to generate-xcfilelists
2490         https://bugs.webkit.org/show_bug.cgi?id=195977
2491
2492         Reviewed by Alexey Proskuryakov.
2493
2494         generate-xcfilelists incorrectly complains when involved with building
2495         WebKit for iphonesimulator:
2496
2497             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2498             …
2499             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2500
2501         Address this by teaching generate-xcfilelists about more platforms.
2502
2503         * Scripts/generate-xcfilelists:
2504
2505 2019-03-19  John Wilander  <wilander@apple.com>
2506
2507         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2508         https://bugs.webkit.org/show_bug.cgi?id=195923
2509         <rdar://problem/49001272>
2510
2511         Reviewed by Alex Christensen.
2512
2513         This patch does the following to the TestRunner:
2514         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2515         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2516         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2517
2518         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2519         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2520         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2521         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2522         * WebKitTestRunner/TestController.cpp:
2523         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2524         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2525         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2526         * WebKitTestRunner/TestController.h:
2527         * WebKitTestRunner/TestInvocation.cpp:
2528         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2529
2530 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2531
2532         [CMake] Support more clang and gcc sanitizers
2533         https://bugs.webkit.org/show_bug.cgi?id=195956
2534
2535         Reviewed by Michael Catanzaro.
2536
2537         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2538
2539 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2540
2541         [ews-build] Improve summary for PrintConfiguration step
2542         https://bugs.webkit.org/show_bug.cgi?id=195945
2543
2544         Reviewed by Lucas Forschler.
2545
2546         * BuildSlaveSupport/ews-build/steps.py:
2547         (PrintConfiguration.getResultSummary): Override getResultSummary.
2548
2549 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2550
2551         [ews-build] Improve summary for CheckOutSource step
2552         https://bugs.webkit.org/show_bug.cgi?id=195963
2553
2554         Reviewed by Lucas Forschler.
2555
2556         * BuildSlaveSupport/ews-build/steps.py:
2557         (CheckOutSource.getResultSummary):
2558
2559 2019-03-19  Daniel Bates  <dabates@apple.com>
2560
2561         [iOS] Focus not preserved when switching between tabs
2562         https://bugs.webkit.org/show_bug.cgi?id=195820
2563         <rdar://problem/43614450>
2564
2565         Reviewed by Brent Fulgham.
2566
2567         Add tests to ensure that we restore focus when resigning and becoming first responder.
2568
2569         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2570         (TestWebKitAPI::TEST):
2571
2572 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2573
2574         Make WTFLogChannelState and WTFLogLevel enum classes
2575         https://bugs.webkit.org/show_bug.cgi?id=195904
2576
2577         Reviewed by Eric Carlson.
2578
2579         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2580         (TestWebKitAPI::TEST_F):
2581
2582 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2583
2584         [GStreamer][EME] Backported mssdemux protection data crash fix
2585         https://bugs.webkit.org/show_bug.cgi?id=195918
2586
2587         Reviewed by Philippe Normand.
2588
2589         * gstreamer/jhbuild.modules:
2590         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2591
2592 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2593
2594         Unreviewed, rolling out r243132.
2595
2596         Broke GTK build
2597
2598         Reverted changeset:
2599
2600         "Make WTFLogChannelState and WTFLogLevel enum classes"
2601         https://bugs.webkit.org/show_bug.cgi?id=195904
2602         https://trac.webkit.org/changeset/243132
2603
2604 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2605
2606         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2607
2608         * Scripts/webkitdirs.pm:
2609         (builtDylibPathForName): Adjust the shared library name that's changed
2610         with the API version bump in r243073.
2611
2612 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2613
2614         Make WTFLogChannelState and WTFLogLevel enum classes
2615         https://bugs.webkit.org/show_bug.cgi?id=195904
2616
2617         Reviewed by Eric Carlson.
2618
2619         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2620         (TestWebKitAPI::TEST_F):
2621
2622 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2623
2624         Disable flaky test added in r2431100
2625         https://webkit.org/b/195785
2626
2627         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2628         (TestWebKitAPI::TEST):
2629         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2630
2631 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2632
2633         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2634         https://bugs.webkit.org/show_bug.cgi?id=195916
2635
2636         Reviewed by Tim Horton.
2637
2638         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2639         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2640
2641 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2642
2643         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2644
2645         * Scripts/webkitpy/common/config/contributors.json:
2646
2647 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2648
2649         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2650         https://bugs.webkit.org/show_bug.cgi?id=195785
2651
2652         Reviewed by Geoffrey Garen.
2653
2654         * TestWebKitAPI/TCPServer.cpp: Added.
2655         (TestWebKitAPI::TCPServer::TCPServer):
2656         (TestWebKitAPI::TCPServer::~TCPServer):
2657         (TestWebKitAPI::TCPServer::socketBindListen):
2658         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2659         * TestWebKitAPI/TCPServer.h: Added.
2660         (TestWebKitAPI::TCPServer::port const):
2661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2662         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2663         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2664         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2665         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2666         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2667         (TestWebKitAPI::respondSlowly):
2668         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2669         (TestWebKitAPI::downloadAtRate):
2670         (TestWebKitAPI::TEST):
2671
2672 2019-03-18  Saam Barati  <sbarati@apple.com>
2673
2674         Add a plan file for JetStream 2
2675         https://bugs.webkit.org/show_bug.cgi?id=190734
2676
2677         Reviewed by Mark Lam.
2678
2679         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2680
2681 2019-03-18  Chris Dumez  <cdumez@apple.com>
2682
2683         Delay WebProcess launch until a load is triggered in a Web view
2684         https://bugs.webkit.org/show_bug.cgi?id=195758
2685         <rdar://problem/48126013>
2686
2687         Reviewed by Geoff Garen.
2688
2689         Add API test coverage. Also update some existing API tests to not expect
2690         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2691
2692         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2693         (TestWebKitAPI::TEST):
2694         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2695         (TestWebKitAPI::TEST):
2696         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2697         (TEST):
2698         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2699         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2700         (TEST):
2701         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2702         (TEST):
2703         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2704
2705 2019-03-18  Xan Lopez  <xan@igalia.com>
2706
2707         [CMake] Prevent potential warning when determining $architecture
2708         https://bugs.webkit.org/show_bug.cgi?id=195891
2709
2710         Reviewed by Michael Catanzaro.
2711
2712         It's possible for generateBuildSystemForCMakeProject to be called
2713         before determineArchitecture() is ever called. This will make the
2714         first eq check with $architecture to be bogus (and print a
2715         warning). Change that to an eq check with architecture(), which
2716         implicitly calls determineArchitecture() if needed, and change all
2717         the other similar cases in the method in the same way to prevent
2718         future bugs like this one.
2719
2720         * Scripts/webkitdirs.pm:
2721         (generateBuildSystemFromCMakeProject):
2722
2723 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2724
2725         [WPE] Tarballs generated with “make dist” cannot build documentation
2726         https://bugs.webkit.org/show_bug.cgi?id=195885
2727
2728         Reviewed by Carlos Garcia Campos.
2729
2730         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2731
2732 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2733
2734         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2735         https://bugs.webkit.org/show_bug.cgi?id=195883
2736
2737         Reviewed by Carlos Garcia Campos.
2738
2739         * gtkdoc/gtkdoc.py:
2740         (GTKDoc._run_command): When commands fail to run, include the full command line for
2741         the program invocation and the output it has generated on the standard error stream.
2742
2743 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2744
2745         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2746         https://bugs.webkit.org/show_bug.cgi?id=195786
2747
2748         Reviewed by Philippe Normand.
2749
2750         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2751         * wpe/jhbuild.modules: Ditto.
2752
2753 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2754
2755         [ews-build] Don't run clean builds on EWS builders
2756         https://bugs.webkit.org/show_bug.cgi?id=195851
2757
2758         Reviewed by Geoffrey Garen.
2759
2760         * BuildSlaveSupport/ews-build/factories.py:
2761
2762 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2763
2764         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2765         https://bugs.webkit.org/show_bug.cgi?id=195849
2766
2767         Reviewed by Chris Dumez.
2768
2769         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2770
2771         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2772         (runWebsiteDataStoreCustomPaths):
2773
2774 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2775
2776         webkitpy: Upload test results
2777         https://bugs.webkit.org/show_bug.cgi?id=195755
2778         <rdar://problem/48896182>
2779
2780         Reviewed by Aakash Jain.
2781
2782         Establish a new format for uploading results that is not tied to layout tests, apply
2783         that format to webkitpy tests.
2784
2785         * Scripts/webkitpy/common/checkout/scm/git.py:
2786         (Git.native_branch): Return what branch the current checkout is on.
2787         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2788         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2789         * Scripts/webkitpy/common/checkout/scm/svn.py:
2790         (SVN.native_branch): Ditto.
2791         * Scripts/webkitpy/common/system/platforminfo.py:
2792         (PlatformInfo.build_version): Return a build version for Mac.
2793         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2794         (MockPlatformInfo.__init__):
2795         (MockPlatformInfo.build_version):
2796         * Scripts/webkitpy/results: Added.
2797         * Scripts/webkitpy/results/__init__.py: Added.
2798         * Scripts/webkitpy/results/options.py: Added.
2799         (upload_options): OptParse list for upload options.
2800         * Scripts/webkitpy/results/upload.py: Added.
2801         (Upload): Class which enforces the upload format expected by the results server.
2802         (Upload.Expectations):
2803         (Upload.create_configuration):
2804         (Upload.create_commit):
2805         (Upload.create_details):
2806         (Upload.create_run_stats):
2807         (Upload.create_test_result):
2808         (Upload.__init__):
2809         (Upload.Encoder): Encode Upload object as json.
2810         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2811         * Scripts/webkitpy/results/upload_unittest.py: Added.
2812         * Scripts/webkitpy/test/main.py:
2813         (Tester._parse_args): Add upload arguments.
2814         (Tester._run_tests): Allow results to be uploaded.
2815         * Scripts/webkitpy/test/runner.py:
2816         (Runner.__init__): Record which tests were run, rather than just counting them.
2817         (Runner.handle):
2818         * Scripts/webkitpy/test/runner_unittest.py:
2819         (RunnerTest.test_run):
2820         * Scripts/webkitpy/thirdparty/__init__.py:
2821         (AutoinstallImportHook.find_module): Add requests auto-install.
2822         (AutoinstallImportHook._install_requests):
2823         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2824         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2825
2826 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2827
2828         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2829         https://bugs.webkit.org/show_bug.cgi?id=195810
2830
2831         Reviewed by Tim Horton.
2832
2833         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2834         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2835         ending certain layout tests.
2836
2837         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2838         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2839         (-[TestRunnerWKWebView dealloc]):
2840         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2841
2842         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2843         helper method when destroying the web view, and when resetting state between tests.
2844
2845         * WebKitTestRunner/ios/TestControllerIOS.mm:
2846         (WTR::TestController::platformResetStateToConsistentValues):
2847
2848         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2849
2850 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2851
2852         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2853         https://bugs.webkit.org/show_bug.cgi?id=190350
2854         <rdar://problem/45089503>
2855
2856         Reviewed by Geoffrey Garen.
2857
2858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2859         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2860         (TEST):
2861         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2862         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2863         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2864         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2865         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2866         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2867         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2868         (runTest):
2869         (createDirectories):
2870         (TEST):
2871         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2872         (TEST):
2873         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2874         (TEST):
2875
2876 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2877
2878         Add support to WebPage for getting the contents as an attributed string.
2879         https://bugs.webkit.org/show_bug.cgi?id=195636
2880         rdar://problem/45055697
2881
2882         Reviewed by Tim Horton.
2883
2884         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2885         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2886
2887 2019-03-15  Chris Dumez  <cdumez@apple.com>
2888
2889         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2890         https://bugs.webkit.org/show_bug.cgi?id=195747
2891
2892         Reviewed by Geoff Garen.
2893
2894         Add API test coverage.
2895
2896         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2897
2898 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2899
2900         Unreviewed, rolling out r242952.
2901
2902         Causing API failures on iOS Simulator
2903
2904         Reverted changeset:
2905
2906         "[PSON] Make sure the WebProcessCache is leverage when
2907         relaunching a process after termination"
2908         https://bugs.webkit.org/show_bug.cgi?id=195747
2909         https://trac.webkit.org/changeset/242952
2910
2911 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2912
2913         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2914         https://bugs.webkit.org/show_bug.cgi?id=195740
2915
2916         Reviewed by Ross Kirsling.
2917
2918         window.open doesn't work for WebKitBrowserWindow because it is not
2919         implemented yet.
2920
2921         1. Implemented createNewPage callback of WKPageUIClient.
2922         2. Changed MainWindow to take a BrowserWindow factory function
2923           instead of BrowserWindowType to be flexible to create
2924           BrowserWindow with extra settings.
2925         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2926           because it is not relevant with MainWindow anymore.
2927
2928         * MiniBrowser/win/Common.cpp:
2929         (parseCommandLine):
2930         * MiniBrowser/win/Common.h:
2931         (CommandLineOptions::CommandLineOptions):
2932         * MiniBrowser/win/MainWindow.cpp:
2933         (MainWindow::MainWindow):
2934         (MainWindow::create):
2935         (MainWindow::init):
2936         (MainWindow::WndProc):
2937         * MiniBrowser/win/MainWindow.h:
2938         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2939         (PrintWebUIDelegate::createWebViewWithRequest):
2940         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2941         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2942         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2943         (WebKitBrowserWindow::updateProxySettings):
2944         (WebKitBrowserWindow::createNewPage):
2945         * MiniBrowser/win/WebKitBrowserWindow.h:
2946         * MiniBrowser/win/WinMain.cpp:
2947         (wWinMain):
2948
2949 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2950
2951         Make it possible to test scrolling tree layer manipulation more easily
2952         https://bugs.webkit.org/show_bug.cgi?id=195780
2953
2954         Reviewed by Tim Horton.
2955         
2956         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2957         cuts off communication of scrolling tree scrolls back to the web process
2958         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2959         allows tests to trigger scrolls which run the scrolling tree layer positioning
2960         logic, but never get another commit from the web process that might mask
2961         scrolling tree bugs.
2962         
2963         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2964         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2965         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2966
2967         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2968         (WTR::UIScriptController::scrollUpdatesDisabled const):
2969         (WTR::UIScriptController::setScrollUpdatesDisabled):
2970         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2971         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2972         (WTR::UIScriptController::scrollUpdatesDisabled const):
2973         (WTR::UIScriptController::setScrollUpdatesDisabled):
2974         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2975         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2976         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2977         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2978         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2979         * WebKitTestRunner/ios/TestControllerIOS.mm:
2980         (WTR::TestController::platformResetStateToConsistentValues):
2981         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2982         (WTR::UIScriptController::scrollUpdatesDisabled const):
2983         (WTR::UIScriptController::setScrollUpdatesDisabled):
2984
2985 2019-03-14  Youenn Fablet  <youenn@apple.com>
2986
2987         Move IDB storage in private browsing mode to NetworkProcess
2988         https://bugs.webkit.org/show_bug.cgi?id=195602
2989
2990         Reviewed by Brady Eidson.
2991
2992         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2993         (TEST):
2994
2995 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2996
2997         [ews-build] Make descriptionDone messages more readable
2998         https://bugs.webkit.org/show_bug.cgi?id=195760
2999
3000         Reviewed by Lucas Forschler.
3001
3002         * BuildSlaveSupport/ews-build/steps.py:
3003         * BuildSlaveSupport/ews-build/steps_unittest.py:
3004
3005 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3006
3007         [ews-build] Generate status-bubble hover-over messages
3008         https://bugs.webkit.org/show_bug.cgi?id=195680
3009
3010         Reviewed by Lucas Forschler.
3011
3012         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3013         (StatusBubble):
3014         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3015         on hover-over.
3016         (StatusBubble._iso_time):
3017         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3018         hover-over message.
3019         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3020
3021 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3022
3023         [ews-app] Gracefully handle the case when state_string is None
3024         https://bugs.webkit.org/show_bug.cgi?id=195753
3025
3026         Reviewed by Lucas Forschler.
3027
3028         * BuildSlaveSupport/ews-app/ews/models/build.py:
3029         * BuildSlaveSupport/ews-app/ews/models/step.py:
3030
3031 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3032
3033         [ews-app] Status bubble display pending for currently running build step
3034         https://bugs.webkit.org/show_bug.cgi?id=195744
3035
3036         Reviewed by Lucas Forschler.
3037
3038         * BuildSlaveSupport/ews-build/events.py:
3039         (Events.stepStarted): If state_string is pending, replace it with step name.
3040
3041 2019-03-14  Chris Dumez  <cdumez@apple.com>
3042
3043         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3044         https://bugs.webkit.org/show_bug.cgi?id=195750
3045
3046         Reviewed by Geoffrey Garen.
3047
3048         Add API test coverage.
3049
3050         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3051         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3052         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3053         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3054
3055 2019-03-14  Chris Dumez  <cdumez@apple.com>
3056
3057         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3058         https://bugs.webkit.org/show_bug.cgi?id=195747
3059
3060         Reviewed by Geoff Garen.
3061
3062         Add API test coverage.
3063
3064         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3065
3066 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3067
3068         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3069         https://bugs.webkit.org/show_bug.cgi?id=195725
3070         <rdar://problem/48545062>
3071
3072         Reviewed by Tim Horton.
3073
3074         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3075         handler is nil.
3076
3077         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3078         (TestWebKitAPI::TEST):
3079
3080 2019-03-13  Sam Weinig  <sam@webkit.org>
3081
3082         Add utility function to allow easy reverse range-based iteration of a container
3083         https://bugs.webkit.org/show_bug.cgi?id=195542
3084
3085         Reviewed by Antti Koivisto.
3086
3087         * TestWebKitAPI/CMakeLists.txt:
3088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3089         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3090         (TestWebKitAPI::TEST):
3091         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3092
3093 2019-03-13  Chris Dumez  <cdumez@apple.com>
3094
3095         Use a ServiceWorker process per registrable domain
3096         https://bugs.webkit.org/show_bug.cgi?id=195649
3097
3098         Reviewed by Youenn Fablet.
3099
3100         Update API test coverage.
3101
3102         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3103
3104 2019-03-13  Chris Dumez  <cdumez@apple.com>
3105
3106         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3107         https://bugs.webkit.org/show_bug.cgi?id=195684
3108         <rdar://problem/48294714>
3109
3110         Reviewed by Antti Koivisto.
3111
3112         Add API test coverage.
3113
3114         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3115
3116 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3117
3118         [ews-app] Remove unused patch view
3119         https://bugs.webkit.org/show_bug.cgi?id=195669
3120
3121         Reviewed by Lucas Forschler.
3122
3123         * BuildSlaveSupport/ews-app/ews/urls.py:
3124         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3125
3126 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3127
3128         [ews-app] Use Buildbot result code variables
3129         https://bugs.webkit.org/show_bug.cgi?id=195668
3130
3131         Reviewed by Alexey Proskuryakov.
3132
3133         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3134         (Buildbot): Added Buildbot result code variables.
3135         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3136         (StatusBubble._build_bubble): Used Buildbot result code variables.
3137
3138 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3139
3140         [Flatpak] Expand submodule recursively
3141         https://bugs.webkit.org/show_bug.cgi?id=195672
3142
3143         Building WPE with flatpak was impossible without that as it was raising an exception.
3144         Also update wpebackend-fdo to match what is built in jhbuild
3145
3146         Reviewed by Philippe Normand.
3147
3148         * flatpak/flatpakutils.py:
3149         (expand_submodules_recurse):
3150         (expand_manifest):
3151         * flatpak/org.webkit.WPEModules.yaml:
3152
3153 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3154
3155         [ews-app] status bubble should be hidden for certain builds
3156         https://bugs.webkit.org/show_bug.cgi?id=194597
3157
3158         Reviewed by Dewei Zhu.
3159
3160         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3161         (StatusBubble._build_bubble):
3162         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3163         because the patch didn't have relevant changes.
3164         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3165         in production yet.
3166
3167 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3168
3169         [Win] Fix a slew of simple clang-cl warnings.
3170         https://bugs.webkit.org/show_bug.cgi?id=195652
3171
3172         Reviewed by Don Olmstead.
3173
3174         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3175         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3176
3177 2019-03-12  Justin Fan  <justin_fan@apple.com>
3178
3179         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3180         https://bugs.webkit.org/show_bug.cgi?id=195518
3181         <rdar://problem/46322356>
3182
3183         Reviewed by Myles C. Maxfield.
3184
3185         * DumpRenderTree/DerivedSources-input.xcfilelist:
3186         * DumpRenderTree/DerivedSources-output.xcfilelist:
3187
3188 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3189
3190         Unreviewed, rolling out r242825.
3191         https://bugs.webkit.org/show_bug.cgi?id=195648
3192
3193         "Broke webkitpy tests with my change to
3194         lldb_dump_class_layout.py" (Requested by rmorisset on
3195         #webkit).
3196
3197         Reverted changeset:
3198
3199         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3200         classes with suspicious padding"
3201         https://bugs.webkit.org/show_bug.cgi?id=195573
3202         https://trac.webkit.org/changeset/242825
3203
3204 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3205
3206         [ews-build] Show status bubbles while the patch is waiting in queue
3207         https://bugs.webkit.org/show_bug.cgi?id=195618
3208
3209         Reviewed by Lucas Forschler.
3210
3211         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3212         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3213         enabled in initial deployment.
3214         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3215         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3216         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3217         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3218         (StatusBubble._build_bubbles_for_patch):
3219
3220 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3221
3222         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3223         https://bugs.webkit.org/show_bug.cgi?id=195573
3224
3225         Reviewed by Simon Fraser.
3226
3227         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3228
3229         * Scripts/dump-class-layout:
3230         (main):
3231         * lldb/lldb_dump_class_layout.py:
3232         (ClassLayout.__init__):
3233         (ClassLayout._compute_padding_recursive):
3234         (LLDBDebuggerInstance.dump_layout_for_classname):
3235         (LLDBDebuggerInstance):
3236         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3237         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3238
3239 2019-03-12  Chris Dumez  <cdumez@apple.com>
3240
3241         Device Orientation access permission should be denied unless explicitly granted by the client
3242         https://bugs.webkit.org/show_bug.cgi?id=195625
3243
3244         Reviewed by Youenn Fablet.
3245
3246         add API test coverage.
3247
3248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3249         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3250         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3251         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3252         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3253         (runDeviceOrientationTest):
3254         (TEST):
3255         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3256         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3257
3258 2019-03-12  Jer Noble  <jer.noble@apple.com>
3259
3260         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3261         https://bugs.webkit.org/show_bug.cgi?id=195137
3262         <rdar://problem/48810307>
3263
3264         Reviewed by Eric Carlson.
3265
3266         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3267         (TestWebKitAPI::TEST):
3268
3269 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3270
3271         [ews-build] Change urls from uat to production
3272         https://bugs.webkit.org/show_bug.cgi?id=195566
3273
3274         Reviewed by Lucas Forschler.
3275
3276         * BuildSlaveSupport/ews-app/ews/config.py:
3277         * BuildSlaveSupport/ews-build/events.py:
3278         * BuildSlaveSupport/ews-build/steps.py:
3279
3280 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3281
3282         [ews-build] change max_builds for local-worker to 1
3283         https://bugs.webkit.org/show_bug.cgi?id=195568
3284
3285         Reviewed by Lucas Forschler.
3286
3287         * BuildSlaveSupport/ews-build/loadConfig.py:
3288
3289 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3290
3291         Fix the build
3292
3293         * TestRunnerShared/spi/PencilKitTestSPI.h:
3294         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3295
3296 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3297
3298         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3299         https://bugs.webkit.org/show_bug.cgi?id=194131
3300
3301         Reviewed by Michael Catanzaro.
3302
3303         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3304         (uriChanged):
3305         (testUnfinishedSubresourceLoad):
3306         (serverCallback):
3307         (beforeAll):
3308
3309 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3310
3311         WTF::Expected should use std::addressof instead of operator&
3312         https://bugs.webkit.org/show_bug.cgi?id=195604
3313
3314         Reviewed by Myles Maxfield.
3315
3316         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3317         (TestWebKitAPI::Unique::Unique):
3318         (TestWebKitAPI::Unique::operator&):
3319         (TestWebKitAPI::TEST):
3320
3321 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3322
3323         Add Optional to Forward.h.
3324         https://bugs.webkit.org/show_bug.cgi?id=195586
3325
3326         Reviewed by Darin Adler.
3327
3328         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3329         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3330         Remove unnecessary includes from headers.
3331
3332 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3333
3334         Add testing API to hit-test and scroll overflow scrollers
3335         https://bugs.webkit.org/show_bug.cgi?id=195278
3336
3337         Reviewed by Antti Koivisto.
3338         
3339         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3340         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3341         
3342         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3343
3344         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3345         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3346         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3347         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3348         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3349         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3350         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3351         (WTR::enclosingScrollViewIncludingSelf):
3352         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3353
3354 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3355
3356         API test WebKit.RequestTextInputContext fails on iOS
3357         https://bugs.webkit.org/show_bug.cgi?id=195585
3358
3359         Reviewed by Wenson Hsieh and Simon Fraser.
3360
3361         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3362         (applyStyle):
3363         (TEST):
3364         Add a viewport, so that the coordinates match up on iOS.
3365         Scroll by moving the UIScrollView's contentOffset.
3366
3367 2019-03-11  Chris Dumez  <cdumez@apple.com>
3368
3369         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3370         https://bugs.webkit.org/show_bug.cgi?id=195506
3371         <rdar://problem/48733477>
3372
3373         Reviewed by Alex Christensen.
3374
3375         Add API test coverage.
3376
3377         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3378
3379 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3380
3381         Adding myself to contributors.json
3382
3383         Unreviewed, addming myself to contributors.json .
3384
3385         * Scripts/webkitpy/common/config/contributors.json:
3386
3387 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3388
3389         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3390         https://bugs.webkit.org/show_bug.cgi?id=195511
3391         <rdar://problem/44873269>
3392
3393         Reviewed by Darin Adler.
3394
3395         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3396         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3397         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3398         (TEST_F):
3399
3400 2019-03-11  Chris Dumez  <cdumez@apple.com>
3401
3402         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3403         https://bugs.webkit.org/show_bug.cgi?id=195561
3404
3405         Reviewed by Youenn Fablet.
3406
3407         Make sure the JS in the test requests for permission to receive device orientation events.
3408
3409         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3410
3411 2019-03-11  Youenn Fablet  <youenn@apple.com>
3412
3413         Allow storage quota increase by default in WTR
3414         https://bugs.webkit.org/show_bug.cgi?id=195541
3415
3416         Reviewed by Geoffrey Garen.
3417
3418         Allow storage quota increase by default in WTR.
3419         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3420         Use this for tests that explicitly need cache increase.
3421
3422         Instead of increasing quota by 2, make sure the next request is
3423         granted by adding all given parameters.
3424
3425         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3426         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3427         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3428         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3429         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3430         * WebKitTestRunner/TestController.cpp:
3431         (WTR::TestController::setAllowStorageQuotaIncrease):
3432         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3433         * WebKitTestRunner/TestController.h:
3434         * WebKitTestRunner/TestInvocation.cpp:
3435         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3436         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3437         (WTR::TestController::cocoaResetStateToConsistentValues):
3438         (WTR::TestController::setAllowStorageQuotaIncrease):
3439         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3440         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3441         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3442
3443 2019-03-11  Xan Lopez  <xan@igalia.com>
3444
3445         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3446         https://bugs.webkit.org/show_bug.cgi?id=194147
3447
3448         Reviewed by Michael Saboff.
3449
3450         To make --32-bit work correctly on Linux/64bit we need to:
3451
3452         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3453         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3454         unfortunately CMake only allows us to do this during
3455         crosscompilation, which is overkill here.
3456         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3457         pkg-config detection module uses the x86 .pc files instead of the
3458         x86_64 ones.
3459         - Set the -m32 flags for the compiler.
3460
3461         * Scripts/webkitdirs.pm:
3462         (generateBuildSystemFromCMakeProject):
3463
3464 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3465
3466         Add MotionMark-1.1 plan file for run-benchmark script.
3467         https://bugs.webkit.org/show_bug.cgi?id=195481
3468
3469         Rubber-stamped by Darin Adler.
3470
3471         Run-benchmark script should support MontionMark-1.1.
3472
3473         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3474
3475 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3476
3477         [ews-app] Add support for submit-to-ews url
3478         https://bugs.webkit.org/show_bug.cgi?id=195477
3479
3480         Reviewed by Lucas Forschler.
3481
3482         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3483         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3484         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3485         * BuildSlaveSupport/ews-app/ews/urls.py:
3486         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3487
3488 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3489
3490         Unreviewed, rolling out r242688, r242643, r242624.
3491
3492         Caused multiple layout test failures and crashes on iOS and macOS.
3493
3494         Reverted changeset:
3495
3496         "requestAnimationFrame should execute before the next frame"
3497         https://bugs.webkit.org/show_bug.cgi?id=177484
3498         https://trac.webkit.org/changeset/242624/webkit
3499
3500         * Tracing/SystemTracePoints.plist:
3501
3502 2019-03-11  John Wilander  <wilander@apple.com>
3503
3504         Resource Load Statistics: Make it possible exclude localhost from classification
3505         https://bugs.webkit.org/show_bug.cgi?id=195474
3506         <rdar://problem/47520577>
3507
3508         Reviewed by Brent Fulgham.
3509
3510         This patch allows for localhost to be excluded from classification and
3511         treatment as a prevalent resource.
3512
3513         The WebKit Tools change adds a new function called
3514         testRunner.setStatisticsIsRunningTest() which can be used to control this
3515         behavior.
3516
3517         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3518         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3519         (WTR::TestRunner::setStatisticsIsRunningTest):
3520         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3521         * WebKitTestRunner/TestController.cpp:
3522         (WTR::TestController::setStatisticsIsRunningTest):
3523         * WebKitTestRunner/TestController.h:
3524         * WebKitTestRunner/TestInvocation.cpp:
3525         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3526
3527 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3528
3529         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3530         https://bugs.webkit.org/show_bug.cgi?id=195560
3531
3532         Reviewed by Lucas Forschler.
3533
3534         * BuildSlaveSupport/ews-build/master.cfg:
3535
3536 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3537
3538         Unreviewed, rolling out r242698.
3539
3540         API test crashes on bots.
3541
3542         Reverted changeset:
3543
3544         "Add a WKContentRuleList variant that uses copied memory
3545         instead of mmap'd shared memory for class A containerized
3546         apps"
3547         https://bugs.webkit.org/show_bug.cgi?id=195511
3548         https://trac.webkit.org/changeset/242698
3549
3550 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3551
3552         [WPE] Enable web process sandbox
3553         https://bugs.webkit.org/show_bug.cgi?id=195169
3554
3555         Reviewed by Daniel Bates.
3556
3557         * wpe/install-dependencies:
3558         * wpe/jhbuild.modules:
3559
3560 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3561
3562         [ews-app] Use port 17000 for worker communication
3563         https://bugs.webkit.org/show_bug.cgi?id=195558
3564
3565         Reviewed by Lucas Forschler.
3566
3567         * BuildSlaveSupport/ews-build/master.cfg:
3568
3569 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3570
3571         [ews-build] unit-tests fail when passwords.json is missing
3572         https://bugs.webkit.org/show_bug.cgi?id=195557
3573
3574         Reviewed by Lucas Forschler.
3575
3576         * BuildSlaveSupport/ews-build/loadConfig.py:
3577         (loadBuilderConfig):
3578         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3579         (ConfigDotJSONTest.test_configuration):
3580         * BuildSlaveSupport/ews-build/master.cfg:
3581
3582 2019-03-11  Truitt Savell  <tsavell@apple.com>
3583
3584         Unreviewed, rolling out r242702.
3585
3586         Broke High Sierra builders.
3587
3588         Reverted changeset:
3589
3590         "Add utility function to allow easy reverse range-based
3591         iteration of a container"
3592         https://bugs.webkit.org/show_bug.cgi?id=195542
3593         https://trac.webkit.org/changeset/242702
3594
3595 2019-03-11  Sam Weinig  <sam@webkit.org>
3596
3597         Add utility function to allow easy reverse range-based iteration of a container
3598         https://bugs.webkit.org/show_bug.cgi?id=195542
3599
3600         Reviewed by Antti Koivisto.
3601
3602         * TestWebKitAPI/CMakeLists.txt:
3603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3604         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3605         (TestWebKitAPI::TEST):
3606         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3607
3608 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3609
3610         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3611         https://bugs.webkit.org/show_bug.cgi?id=195511
3612         <rdar://problem/44873269>
3613
3614         Reviewed by Darin Adler.
3615
3616         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3617         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3618         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3619         (TEST_F):
3620
3621 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3622
3623         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3624         https://bugs.webkit.org/show_bug.cgi?id=195499
3625
3626         Reviewed by Darin Adler.
3627
3628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3629         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3630         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3631         (-[WKWebView synchronouslyFocusTextInputContext:]):
3632         (applyStyle):
3633         (applyIframe):
3634         (TEST):
3635         Add some tests for this SPI.
3636
3637 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3638
3639         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3640         https://bugs.webkit.org/show_bug.cgi?id=181151
3641
3642         Reviewed by Don Olmstead.
3643
3644         * TestWebKitAPI/CMakeLists.txt:
3645         * TestWebKitAPI/PlatformWin.cmake:
3646         Enable TestWTF RunLoop tests in all platforms.
3647
3648         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3649         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3650         (TestWebKitAPI::DerivedOneShotTimer::fired):
3651         (TestWebKitAPI::TEST):
3652         Only a few platforms support nested RunLoop.
3653
3654         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3655         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3656
3657 2019-03-10  David Quesada  <david_quesada@apple.com>
3658
3659         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3660         https://bugs.webkit.org/show_bug.cgi?id=152480
3661
3662         Reviewed by Chris Dumez.
3663
3664         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3665         there are no additional references to the process pool besides the one held by
3666         the download, waits for the download to finish (in the sense that the
3667         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3668         measure, also check that the process pool has been deallocated at the end of the
3669         test. The test wouldn't be meaningful if the process pool were still alive.
3670
3671         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3672         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3673         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3674             The download will be canceled because the delegate does not implement the
3675             method to decide the download's destination, so this is where we know the
3676             DownloadProxyMap is done with the DownloadProxy.
3677         (TEST):
3678
3679 2019-03-08  Chris Dumez  <cdumez@apple.com>
3680
3681         Add support for Device Orientation / Motion permission API
3682         https://bugs.webkit.org/show_bug.cgi?id=195329
3683         <rdar://problem/47645367>
3684
3685         Reviewed by Geoffrey Garen.
3686
3687         Add test infrastructure to help test the Device Orientation / Motion permission API.
3688
3689         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3690         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3691         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3692         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3693         * WebKitTestRunner/TestController.cpp:
3694         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3695         (WTR::TestController::createWebViewWithOptions):
3696         (WTR::TestController::resetStateToConsistentValues):
3697         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3698         * WebKitTestRunner/TestController.h:
3699         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3700         * WebKitTestRunner/TestInvocation.cpp:
3701         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3702
3703 2019-03-08  Saam barati  <sbarati@apple.com>
3704
3705         Add a compare-results script to compare benchmark results
3706         https://bugs.webkit.org/show_bug.cgi?id=195486
3707         <rdar://problem/48723397>
3708
3709         Reviewed by Geoffrey Garen.
3710
3711         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3712         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3713         to extend it to learn about our other benchmarks.
3714
3715         * Scripts/compare-results: Added.
3716         (readJSONFile):
3717         (detectJetStream2):
3718         (JetStream2Results):
3719         (detectSpeedometer2):
3720         (Speedometer2Results):
3721         (detectPLT5):
3722         (PLT5Results):
3723         (detectBenchmark):
3724         (biggerIsBetter):
3725         (ttest):
3726         (getOptions):
3727         (main):
3728
3729 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3730
3731         Ensure old tab state is cleared between iterations of run-benchmark
3732         https://bugs.webkit.org/show_bug.cgi?id=195393
3733         <rdar://problem/46885583>
3734
3735         Reviewed by Dewei Zhu.
3736
3737         a) ensure the default to restore state is not set
3738         b) terminate Safari correctly
3739         c) Set the system default to ignore Persistent State in Safari
3740
3741         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3742         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3743         (OSXBrowserDriver.prepare_env): 
3744         (OSXBrowserDriver.restore_env):
3745         (OSXBrowserDriver.close_browsers):
3746         (OSXBrowserDriver._terminate_processes):
3747         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3748         (OSXChromeDriver):
3749         (OSXChromeCanaryDriver):
3750         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3751         (OSXFirefoxDriver):
3752         (OSXFirefoxNightlyDriver):
3753         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3754         (OSXSafariDriver):
3755         (OSXSafariDriver.prepare_env):
3756
3757 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3758
3759         [GTK] Several InputMethodFilter tests are failing
3760         https://bugs.webkit.org/show_bug.cgi?id=195408
3761
3762         Reviewed by Carlos Garcia Campos.
3763
3764         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3765         Regressed in r241751.
3766         Hexadecimal values of keycodes are expressed now in upper letters.
3767         Composited characters should be cast to UTF8 strings.
3768
3769         (TestWebKitAPI::TEST):
3770
3771 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3772
3773         [GTK] Make Tools/gtkdoc python3 compatible
3774         https://bugs.webkit.org/show_bug.cgi?id=195359
3775
3776         Reviewed by Carlos Garcia Campos.
3777
3778         * gtkdoc/generate-gtkdoc:
3779         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3780         work with Python 2 and 3.
3781         (get_gtkdoc_module_paths):
3782         The iteritems() was removed in Python 3, so let's use items() that's
3783         available in Python 2 and 3.
3784         (get_generator_for_config):
3785         * gtkdoc/gtkdoc.py:
3786         (GTKDoc._run_command):
3787         The sys.stdout.write() is expecting str in Python 3 and not bytes
3788         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3789         for passing the bytes there.
3790
3791 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3792
3793         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3794         https://bugs.webkit.org/show_bug.cgi?id=195346
3795         <rdar://problem/48667048>
3796
3797         Unreviewed build fix for clang-cl.
3798
3799         * DumpRenderTree/win/DumpRenderTree.cpp:
3800         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3801
3802 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3803
3804         requestAnimationFrame should execute before the next frame
3805         https://bugs.webkit.org/show_bug.cgi?id=177484
3806
3807         Reviewed by Simon Fraser.
3808
3809         Add trace points for the page RenderingUpdate.
3810
3811         * Tracing/SystemTracePoints.plist:
3812
3813 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3814
3815         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3816         https://bugs.webkit.org/show_bug.cgi?id=195353
3817         <rdar://problem/48626394>
3818
3819         Reviewed by Simon Fraser.
3820
3821         * WebKitTestRunner/ios/TestControllerIOS.mm:
3822         (WTR::TestController::platformResetPreferencesToConsistentValues):
3823
3824 2019-03-07  John Wilander  <wilander@apple.com>
3825
3826         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3827         https://bugs.webkit.org/show_bug.cgi?id=195383
3828         <rdar://problem/48570136>
3829
3830         Reviewed by Brent Fulgham.
3831
3832         This patch adds test infrastructure to purge only script-accessible cookies,
3833         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3834
3835         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3836         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3837         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3838         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3839         * WebKitTestRunner/TestController.cpp:
3840         (WTR::TestController::statisticsDeleteCookiesForHost):
3841         * WebKitTestRunner/TestController.h:
3842         * WebKitTestRunner/TestInvocation.cpp:
3843         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3844
3845 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3846
3847         Unreviewed, rolling out r242354.
3848         https://bugs.webkit.org/show_bug.cgi?id=195402
3849
3850         breaks layout tests in all configurations (Requested by
3851         zdobersek on #webkit).
3852
3853         Reverted changeset:
3854
3855         "[WPE] Enable web process sandbox"
3856         https://bugs.webkit.org/show_bug.cgi?id=195169
3857         https://trac.webkit.org/changeset/242354
3858
3859 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3860
3861         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3862         https://bugs.webkit.org/show_bug.cgi?id=195346
3863
3864         Reviewed by Fujii Hironori.
3865
3866         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3867         (TestWebKitAPI::TEST):
3868         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3869
3870         * DumpRenderTree/win/DumpRenderTree.cpp:
3871         (findFontFallback):
3872         (addFontFallbackIfPresent):
3873         (removeFontFallbackIfPresent):
3874         (main):
3875         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3876         (TestWebKitAPI::Util::moduleDirectory):
3877         (TestWebKitAPI::Util::createInjectedBundlePath):
3878         Use wchar helpers as needed.
3879
3880 2019-03-06  Rob Buis  <rbuis@igalia.com>
3881
3882         Consider supporting the `referrerpolicy` attribute.
3883         https://bugs.webkit.org/show_bug.cgi?id=179053
3884
3885         Reviewed by Darin Adler.
3886
3887         Add a runtime flag for referrerpolicy attribute.
3888
3889         * DumpRenderTree/mac/DumpRenderTree.mm:
3890         (enableExperimentalFeatures):
3891
3892 2019-03-05  Daniel Bates  <dabates@apple.com>
3893
3894         Update expected API test result following r242379
3895         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3896
3897         Update expected x-coordinate of selection rect now that the left padding of
3898         a textarea is sized in ems (so dependent on the font size) just like the left
3899         padding of a text field.
3900
3901         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3902         (TestWebKitAPI::TEST):
3903
3904 2019-03-05  David Quesada  <david_quesada@apple.com>
3905
3906         [WK2] It should be possible to follow links with 'download' attributes
3907         https://bugs.webkit.org/show_bug.cgi?id=195145
3908         rdar://problem/48462642
3909
3910         Reviewed by Alex Christensen.
3911
3912         Add a unit test to verify that activating links with 'download' attributes now
3913         navigates to the linked resource, rather than starts downloading it. Add another
3914         to verify that it is still possible to explicitly download the link via the
3915         'Download' navigation action policy.
3916
3917         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3918         (-[DownloadAttributeTestDelegate init]):
3919         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3920         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3921         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3922         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3923         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3924         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3925         (TEST):
3926         * WebKitTestRunner/TestController.cpp:
3927         (WTR::TestController::decidePolicyForNavigationAction):
3928         * WebKitTestRunner/TestController.h:
3929
3930 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3931
3932         [Curl] Implement Cookie Accept Policy.
3933         https://bugs.webkit.org/show_bug.cgi?id=191645
3934
3935         Reviewed by Fujii Hironori.
3936
3937         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3938         (TestWebKitAPI::Curl::TEST_F):
3939
3940 2019-03-05  Youenn Fablet  <youenn@apple.com>
3941
3942         Rename requestCacheStorageSpace to requestStorageSpace
3943         https://bugs.webkit.org/show_bug.cgi?id=195282
3944
3945         Reviewed by Chris Dumez.
3946
3947         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3948         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3949         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3950
3951 2019-03-05  Brady Eidson  <beidson@apple.com>
3952
3953         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3954         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3955
3956         Reviewed by Tim Horton.
3957
3958         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3959         different directory into that same WKWebView should work.
3960
3961         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3962         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3963
3964 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3965
3966         Add WeakHashSet
3967         https://bugs.webkit.org/show_bug.cgi?id=195152
3968
3969         Reviewed by Antti Koivisto.
3970
3971         Added tests for WeakHashSet.
3972
3973         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3974         (TestWebKitAPI::Base::Base): Moved.
3975         (TestWebKitAPI::Derived::foo): Moved.
3976         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3977         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3978         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3979         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3980
3981 2019-03-04  Chris Dumez  <cdumez@apple.com>
3982
3983         Do not share WebProcesses between private and regular sessions
3984         https://bugs.webkit.org/show_bug.cgi?id=195189
3985         <rdar://problem/48421064>
3986
3987         Reviewed by Alex Christensen.
3988
3989         Add API test coverage.
3990
3991         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3992         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3993
3994 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3995
3996         [WPE] Enable web process sandbox
3997         https://bugs.webkit.org/show_bug.cgi?id=195169
3998
3999         Reviewed by Daniel Bates.
4000
4001         * wpe/install-dependencies:
4002         * wpe/jhbuild.modules:
4003
4004 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4005
4006         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
4007         https://bugs.webkit.org/show_bug.cgi?id=195206
4008
4009         Reviewed by Žan Doberšek.
4010
4011         Add a new test case.
4012
4013         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4014         (testJSCClass):
4015
4016 2019-03-04  Charlie Turner  <cturner@igalia.com>
4017
4018         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
4019         https://bugs.webkit.org/show_bug.cgi?id=194898
4020
4021         Reviewed by Žan Doberšek.
4022
4023         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
4024         a GCC extension that permits arithmetic on void* pointer. Inline
4025         the macro until this issue is fixed upstream.
4026
4027 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4028
4029         Rid the world of WK_API_ENABLED
4030         https://bugs.webkit.org/show_bug.cgi?id=195263
4031
4032         Reviewed by Dan Bernstein.
4033
4034         List of changed files elided because it's useless.
4035
4036 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4037
4038         Unreviewed follow-up to r242292.
4039
4040         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4041
4042         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4043         (TestWebKitAPI::testStrip): Renamed from strip.
4044         (TestWebKitAPI::TEST):
4045
4046 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4047
4048         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4049
4050         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4051         and bug #194272 for details.
4052
4053         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4054
4055 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4056
4057         Remove some more unused 32-bit code
4058         https://bugs.webkit.org/show_bug.cgi?id=195255
4059
4060         Reviewed by Darin Adler.
4061
4062         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4063         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4064         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4065         (NPP_New):
4066         (NPP_HandleEvent):
4067         (handleEventCarbon): Deleted.
4068
4069 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4070
4071         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4072
4073         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4074         (TestWebKitAPI::TEST):
4075
4076 2019-03-01  Darin Adler  <darin@apple.com>
4077
4078         Finish removing String::format
4079         https://bugs.webkit.org/show_bug.cgi?id=194893
4080
4081         Reviewed by Daniel Bates.
4082 '
4083         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4084
4085 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4086
4087         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4088         https://bugs.webkit.org/show_bug.cgi?id=195229
4089         <rdar://problem/48520362>
4090
4091         Reviewed by Chris Dumez.
4092
4093         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4094         (TEST):
4095
4096 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4097
4098         Add a system trace scope for event region building
4099         https://bugs.webkit.org/show_bug.cgi?id=195226
4100
4101         Reviewed by Jon Lee.
4102
4103         This trace scope measures the time spend converting element rects into Region objects,
4104         which can be large on some pages.
4105
4106         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4107
4108         * Tracing/SystemTracePoints.plist:
4109
4110 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4111
4112         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4113         https://bugs.webkit.org/show_bug.cgi?id=194612
4114
4115         Reviewed by Alex Christensen.
4116
4117         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4118         Just test the new string-processing function and don't touch the actual environment.
4119         (Test cases are all as before, but based on operator== instead of strcmp.)
4120
4121 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4122
4123         [ews-app] Update primary keys for handling multiple Buildbot instances
4124         https://bugs.webkit.org/show_bug.cgi?id=195120
4125
4126         Reviewed by Stephanie Lewis.
4127
4128         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4129         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4130         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4131
4132         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4133         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4134         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4135         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4136         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4137         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4138
4139 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4140
4141         [WinCairo] Enable service worker
4142         https://bugs.webkit.org/show_bug.cgi?id=188318
4143
4144         Reviewed by Youenn Fablet.
4145
4146         * DumpRenderTree/DumpRenderTreePrefix.h:
4147         * TestWebKitAPI/PlatformWin.cmake:
4148         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4149         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4150         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4151
4152 2019-03-01  Justin Fan  <justin_fan@apple.com>
4153
4154         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4155         https://bugs.webkit.org/show_bug.cgi?id=195191
4156
4157         Rubber-stamped by Dean Jackson.
4158
4159         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4160
4161         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4162
4163 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4164
4165         Unreviewed, fix lldb webkitpy tests
4166         https://bugs.webkit.org/show_bug.cgi?id=194375
4167
4168         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4169
4170         * lldb/lldb_webkit.py:
4171         (WTFStringImplProvider.is_8bit):
4172
4173 2019-02-28  David Quesada  <david_quesada@apple.com>
4174
4175         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4176         https://bugs.webkit.org/show_bug.cgi?id=195121
4177         rdar://problem/48450302
4178
4179         Reviewed by Alex Christensen.
4180
4181         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4182         configurations where the 'download' attribute is absent, blank, or populated
4183         with a filename, and where the anchor element is same-origin or cross-origin
4184         (meaning the 'download' attribute shouldn't be honored).
4185
4186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4187         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4188         (-[NavigationActionTestDelegate init]):
4189         (-[NavigationActionTestDelegate navigationAction]):
4190         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4191         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4192         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4193         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4194         (TEST):
4195
4196 2019-02-28  Antoine Quint  <graouts@apple.com>
4197
4198         Enable the Pointer Events runtime flag by default
4199         https://bugs.webkit.org/show_bug.cgi?id=195156
4200
4201         Reviewed by Dean Jackson.
4202
4203         * DumpRenderTree/mac/DumpRenderTree.mm:
4204         (enableExperimentalFeatures):
4205
4206 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4207
4208         Several PasteImage API tests are flaky
4209         https://bugs.webkit.org/show_bug.cgi?id=195160
4210
4211         Reviewed by Tim Horton.
4212
4213         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4214         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4215         listening for a "load" event after image load is already complete.
4216
4217         To address this, make these tests first register a "load" event handler, then run script to insert an image
4218         element into the document, and finally wait until the load event is observed before checking image size.
4219
4220         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4221
4222 2019-02-28  Chris Dumez  <cdumez@apple.com>
4223
4224         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4225         https://bugs.webkit.org/show_bug.cgi?id=195107
4226
4227         Reviewed by Alex Christensen.
4228
4229         Give some time for the zoom level to get restored.
4230
4231         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4232
4233 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4234
4235         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4236         https://bugs.webkit.org/show_bug.cgi?id=194958
4237
4238         Reviewed by Geoffrey Garen.
4239
4240         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4241         (TEST):
4242
4243 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4244
4245         [ews-app] Update method to save build to handle builder_display_name
4246         https://bugs.webkit.org/show_bug.cgi?id=195047
4247
4248         Reviewed by Dewei Zhu.
4249
4250         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4251         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4252
4253 2019-02-28  Justin Fan  <justin_fan@apple.com>
4254
4255         [Web GPU] Enable Web GPU only on 64-bit
4256         https://bugs.webkit.org/show_bug.cgi?id=195139
4257
4258         Because Metal is only supported on 64 bit apps.
4259
4260         Unreviewed build fix.
4261
4262         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4263
4264 2019-02-27  Youenn Fablet  <youenn@apple.com>
4265
4266         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4267         https://bugs.webkit.org/show_bug.cgi?id=194959
4268
4269         Reviewed by Chris Dumez.
4270
4271         Spin loop until getting the condition to remove flakiness.
4272
4273         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4274
4275 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4276
4277         [ews-build] Buildbot should include builder_display_name in the build events
4278         https://bugs.webkit.org/show_bug.cgi?id=195045
4279
4280         Reviewed by Dewei Zhu.
4281
4282         * BuildSlaveSupport/ews-build/events.py:
4283         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4284         buildername to builder_name to be consistent in naming style.
4285         (Events.buildFinished): Ditto.
4286
4287 2019-02-27  Chris Dumez  <cdumez@apple.com>
4288
4289         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4290         https://bugs.webkit.org/show_bug.cgi?id=194480
4291
4292         Reviewed by Brady Eidson.
4293
4294         Update existing API test to make it more likely to reproduce the issue.
4295
4296         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4297
4298 2019-02-27  Brady Eidson  <beidson@apple.com>
4299
4300         Universal links from Google search results pages don't open the app.
4301         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4302
4303         Reviewed by Geoffrey Garen.
4304
4305         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4306         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4307         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4308         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4309
4310 2019-02-27  Chris Dumez  <cdumez@apple.com>
4311
4312         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4313         https://bugs.webkit.org/show_bug.cgi?id=195102
4314
4315         Reviewed by Geoffrey Garen.
4316
4317         If the number of processes is not yet what we expect, wait a bit and check again to give
4318         processes some time to exit.
4319
4320         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4321
4322 2019-02-27  Chris Dumez  <cdumez@apple.com>
4323
4324         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4325         https://bugs.webkit.org/show_bug.cgi?id=194545
4326
4327         Reviewed by Brady Eidson.
4328
4329         Make sure the test navigates forward and then back only once. Previously, navigating
4330         back would trigger a navigation again in a timer.
4331
4332         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4333
4334 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4335
4336         High Sierra Debug JSC test queue should use faster hardware
4337         https://bugs.webkit.org/show_bug.cgi?id=194603
4338
4339         Rubber-stamped by Alexey Proskuryakov.
4340
4341         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4342
4343         * BuildSlaveSupport/build.webkit.org-config/config.json:
4344         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4345         (BubbleQueueServer):
4346         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4347         (WebKitBuildbot):
4348         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4349         * QueueStatusServer/config/queues.py:
4350         * Scripts/webkitpy/common/config/ews.json:
4351         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4352         (test_ews_name):
4353
4354 2019-02-27  John Wilander  <wilander@apple.com>
4355
4356         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4357         https://bugs.webkit.org/show_bug.cgi?id=195071
4358         <rdar://problem/48417690>
4359
4360         Reviewed by Alex Christensen and Brent Fulgham.
4361
4362         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4363         (TestWebKitAPI::createURL):
4364             Convenience function.
4365         (TestWebKitAPI::TEST):
4366             WebCore::AdClickAttribution now takes a URL when creating Source and
4367             Destination.
4368         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4369         (TestWebKitAPI::TEST):
4370             WebCore::AdClickAttribution now takes a URL when