[chromium] Enable more clang warnings
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-20  Tony Chang  <tony@chromium.org>
2
3         [chromium] Enable more clang warnings
4         https://bugs.webkit.org/show_bug.cgi?id=97257
5
6         Reviewed by James Robinson.
7
8         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add -Wunused-parameter. Don't add -Wglobal-constructors because
9         there are lots of violations in these files.
10
11 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
12
13         run-perf-tests should record individual value instead of statistics
14         https://bugs.webkit.org/show_bug.cgi?id=97155
15
16         Reviewed by Hajime Morita.
17
18         Parse the list of individual value reported by tests and include them as "values".
19         We strip "values" from the output JSON when uploading it to the perf-o-matic
20         since it doesn't know how to parse "values" or ignore it.
21
22         * Scripts/webkitpy/performance_tests/perftest.py:
23         (PerfTest):
24         (PerfTest.parse_output): Parse and report "values".
25         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
26         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
27         (MainTest.test_parse_output):
28         (MainTest.test_parse_output_with_failing_line):
29         (TestPageLoadingPerfTest.test_run):
30         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
31         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
32         until we update perf-o-matic.
33         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
34         (test_run_memory_test):
35         (test_run_with_json_output):
36         (test_run_with_description):
37         (test_run_with_slave_config_json):
38         (test_run_with_multiple_repositories):
39
40 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
41
42         [Qt] Fix production builds
43
44         Unreviewed trivial fix: Follow up r129119 and avoid clobbering LIBS through the use of LIBS_PRIVATE.
45
46         Otherwise the libQtWebKit.prl file for example contains -lWebKit1 -lWebCore, etc.
47
48         * qmake/mkspecs/features/functions.prf:
49
50 2012-09-20  Dirk Pranke  <dpranke@chromium.org>
51
52         REGRESSION: layout test results doesn't show diffs
53         https://bugs.webkit.org/show_bug.cgi?id=97182
54
55         Reviewed by Ojan Vafai.
56
57         Go back to storing TEXT, AUDIO, and IMAGE+TEXT in results.json
58         so that results.html (and hopefully garden-o-matic) can
59         determine which things actually failed. However, we keep mapping
60         these results to Failure so that we still only have a single
61         expectation type for them.
62
63         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
64         (JSONLayoutResultsGenerator):
65         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
66         (TestExpectationParser):
67         (TestExpectations):
68         (TestExpectations.result_was_expected):
69         * Scripts/webkitpy/layout_tests/models/test_failures.py:
70         (determine_result_type):
71         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
72         (MainTest.test_missing_and_unexpected_results):
73         (MainTest.test_retrying_and_flaky_tests):
74
75 2012-09-20  Tommy Widenflycht  <tommyw@google.com>
76
77         MediaStream API: Extend UserMediaRequest with a ownerDocument method
78         https://bugs.webkit.org/show_bug.cgi?id=97095
79
80         Reviewed by Adam Barth.
81
82         Extending WebUserMediaClientMock to check that the owning document is valid,
83         and that the document has a frame.
84
85         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
86         (WebKit::WebUserMediaClientMock::requestUserMedia):
87
88 2012-09-20  Stephen Chenney  <schenney@chromium.org>
89
90         [Chromium] DRT does not support --dump-all-pixels flag
91         https://bugs.webkit.org/show_bug.cgi?id=95098
92
93         Reviewed by Dirk Pranke.
94
95         Add support for the --pixel-tests and shorthand -p option in Chromium DumpRenderTree. Use
96         of this flag causes pixel results to be created for all tests, regardless of
97         individual test options. If an individual test provides a pixel hash it will be used,
98         otherwise the hash will be empty. This replaces a previously defined but unused option
99         --dump-all-pixels, and is useful primarily when debugging DRT instances.
100
101         * DumpRenderTree/chromium/DumpRenderTree.cpp:
102         (runTest): Add a parameter and code to force pixel results for the test.
103         (main): Add parameter handling for --pixels-test and -p, and remove --dump-all-pixels.
104
105 2012-09-20  Carlos Garcia Campos  <cgarcia@igalia.com>
106
107         [GTK] run-api-tests should not buffer test stdout
108         https://bugs.webkit.org/show_bug.cgi?id=88474
109
110         Reviewed by Philippe Normand.
111
112         * Scripts/run-gtk-tests:
113         (TestRunner._run_test_command): Use os.forkpty() instead of
114         subprocess.Popen() so that gtest sends the output with colors to
115         stdout. Use common.parse_output_lines() to parse the output and
116         write it to stdout while it's read.
117         (TestRunner._run_test_command.parse_line): Parse the line to get
118         the test pid and write the line to stdout.
119         (TestRunner._run_test_command.waitpid): Helper function to call
120         waitpid handling EINTR.
121         (TestRunner._run_test_command.return_code_from_exit_status):
122         Helper function to convert exit status of test commands to a
123         return code.
124         * gtk/common.py:
125         (parse_output_lines): Helper function that uses select to read
126         the given file descriptor and call the given callback for every
127         line read.
128
129 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
130
131         [Qt] Fix initial build
132
133         Reviewed by Tor Arne Vestbø.
134
135         When building QtWebKit the first time there is no qt_webkit.pri module pri file, and therefore
136         $$QT.webkit.name isn't set and so creating_module isn't set. That has all sorts of implications
137         causing incorrect linking for Makefile.api, etc.
138
139         Fix the determination by simply checking if MODULE is set, which only happens in api.pri.
140
141         * qmake/mkspecs/features/webkit_modules.prf:
142
143 2012-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
144
145         Unreviewed, rolling out r129091.
146         http://trac.webkit.org/changeset/129091
147         https://bugs.webkit.org/show_bug.cgi?id=97205
148
149         It broke perf tests everywhere (Requested by Ossy on #webkit).
150
151         * Scripts/webkitpy/performance_tests/perftest.py:
152         (PerfTest):
153         (PerfTest.parse_output):
154         (PageLoadingPerfTest.run):
155         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
156         (MainTest.test_parse_output):
157         (MainTest.test_parse_output_with_failing_line):
158         (TestPageLoadingPerfTest.test_run):
159         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
160         (PerfTestsRunner._generate_and_show_results):
161         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
162         (test_run_memory_test):
163         (test_run_with_json_output):
164         (test_run_with_description):
165         (test_run_with_slave_config_json):
166         (test_run_with_multiple_repositories):
167
168 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
169
170         [Qt] QtWebKit module header includes private dependencies
171
172         Reviewed by Tor Arne Vestbø.
173
174         * qmake/mkspecs/features/default_post.prf: Don't try to sanitize LIBS, because we can make sure
175         that LIBS_PRIVATE is set from the beginning. Moved the creating_module and PKGCONFIG/QT(_PRIVATE)
176         sanitization into webkit_modules.prf. creating_module determination requires TARGET to be set, so
177         we can't do it in default_pre.
178         * qmake/mkspecs/features/webkit_modules.prf:
179
180 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
181
182         [Qt] Fix build with MingW
183
184         Reviewed by Tor Arne Vestbø.
185
186         Don't try to compile WebCore, etc. with debug symbols for production
187         builds, it's just too big.
188
189         * qmake/mkspecs/features/production_build.prf:
190
191 2012-09-20  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
192
193         [EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
194         https://bugs.webkit.org/show_bug.cgi?id=97087
195
196         Reviewed by Gyuyoung Kim.
197
198         Add focusing a main frame on settings reset.
199         After editing/undo/undo-iframe-location-change was executed a frame
200         was left in unfocused state. This caused flakiness in two tests results.
201
202         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
203         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
204
205 2012-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
206
207         [Qt] Add eventSender.gestureTap
208         https://bugs.webkit.org/show_bug.cgi?id=66173
209
210         Reviewed by Kenneth Rohde Christiansen.
211
212         Implement support for sending raw QGesture events.
213
214         * DumpRenderTree/qt/EventSenderQt.cpp:
215         (EventSender::EventSender):
216         (EventSender::gestureTap):
217         * DumpRenderTree/qt/EventSenderQt.h:
218         (EventSender):
219
220 2012-09-19  Sheriff Bot  <webkit.review.bot@gmail.com>
221
222         Unreviewed, rolling out r129007.
223         http://trac.webkit.org/changeset/129007
224         https://bugs.webkit.org/show_bug.cgi?id=97172
225
226         It broke the build on the Qt bots (Requested by Ossy on
227         #webkit).
228
229         * qmake/config.tests/gccdepends/empty.cpp:
230         * qmake/config.tests/gccdepends/gccdepends.pro:
231         * qmake/mkspecs/features/default_pre.prf:
232
233 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
234
235         run-perf-tests should record indivisual value instead of statistics
236         https://bugs.webkit.org/show_bug.cgi?id=97155
237
238         Reviewed by Hajime Morita.
239
240         Parse the list of indivisual value reported by tests and include them as "values".
241         We strip "values" from the output JSON when uploading it to the perf-o-matic
242         since it doesn't know how to parse "values" or ignore it.
243
244         * Scripts/webkitpy/performance_tests/perftest.py:
245         (PerfTest):
246         (PerfTest.parse_output): Parse and report "values".
247         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
248         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
249         (MainTest.test_parse_output):
250         (MainTest.test_parse_output_with_failing_line):
251         (TestPageLoadingPerfTest.test_run):
252         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
253         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
254         until we update perf-o-matic.
255         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
256         (test_run_memory_test):
257         (test_run_with_json_output):
258         (test_run_with_description):
259         (test_run_with_slave_config_json):
260         (test_run_with_multiple_repositories):
261
262 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
263
264         Fix regex groups for bug matching in flakiness dashboard.
265         https://bugs.webkit.org/show_bug.cgi?id=97152
266
267         Unreviewed, build fix.
268
269         * TestResultServer/static-dashboards/flakiness_dashboard.js:
270         (htmlForBugs):
271
272 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
273
274         nrwt: print unexpected results using new TestExpectations syntax
275         https://bugs.webkit.org/show_bug.cgi?id=97159
276
277         Unreviewed, build fix.
278
279         Change new-run-webkit-tests to print out failures using the new
280         syntax when there are unexpected results, e.g.:
281
282         52 tests ran as expected, 19 didn't:
283
284
285         Regressions: Unexpected failures : (2)
286           failures/flaky/text.html [ Failure ]
287           failures/unexpected/text-image-checksum.html [ Failure ]
288
289         and so forth
290
291         * Scripts/webkitpy/layout_tests/views/printing.py:
292         (Printer._print_unexpected_results):
293
294 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
295
296         update flakiness dashboard after cutover to new test expectations syntax
297         https://bugs.webkit.org/show_bug.cgi?id=97152
298
299         Unreviewed, build fix.
300
301         Handle (??) the new Bug notations as well. Hopefully we don't
302         still need the old ones.
303
304         * TestResultServer/static-dashboards/flakiness_dashboard.js:
305         (filterBugs):
306         (htmlForBugs):
307         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
308
309 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
310
311         update flakiness dashboard after cutover to new test expectations syntax
312         https://bugs.webkit.org/show_bug.cgi?id=97152
313
314         Reviewed by Ryosuke Niwa.
315
316         This change clones the TestExpectation parsing state machine
317         from python into javascript.
318
319         * TestResultServer/static-dashboards/flakiness_dashboard.js:
320         (parsedExpectations.lines.forEach):
321         (parsedExpectations):
322         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
323
324 2012-09-19  Dana Jansens  <danakj@chromium.org>
325
326         Add backer@chromium.org as contributor
327         https://bugs.webkit.org/show_bug.cgi?id=97150
328
329         * Scripts/webkitpy/common/config/committers.py:
330
331 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
332
333         fix MISSING after TestExpectations conversion
334         https://bugs.webkit.org/show_bug.cgi?id=97148
335
336         Unreviewed, expectations change / build fix.
337
338         * Scripts/convert-test-expectations:
339         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
340         (TestExpectationParser):
341
342 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
343
344         nrwt: convert chromium TestExpectations to the new syntax
345         https://bugs.webkit.org/show_bug.cgi?id=97139
346
347         Reviewed by Ryosuke Niwa.
348     
349         Add in a file temporarily that does the conversion of
350         test expectations formats
351
352         * Tools/Scripts/convert-test-expectations: Added.
353
354 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
355
356         REGRESSION: run-perf-tests no longer reports the total test time
357         https://bugs.webkit.org/show_bug.cgi?id=97138
358
359         Reviewed by Tony Chang.
360
361         Report the finished time as a info-level log as opposed to a debug level log.
362
363         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
364         (PerfTestsRunner._run_single_test):
365         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
366         (MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
367         (test_run_test_pause_before_testing):
368         (test_run_test_set_for_parser_tests):
369         (test_run_memory_test):
370         (_test_run_with_json_output):
371
372 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
373
374         Support new TestExpectations format alongside old one
375         https://bugs.webkit.org/show_bug.cgi?id=96588
376
377         Reviewed by Ojan Vafai.
378
379         This patch adds support for actually reading in lines formatted
380         in the new style, and when we re-serialize/write out the file,
381         all lines will be written in the new style. Note that reading in
382         the old style is still supported, and no updates are being made
383         to the actual TestExpectations files as part of this change.
384
385         This change updates most but not all of the unit tests to use
386         the new syntax. I will update the rest when (or before where
387         possible) I drop support for the old format.
388
389         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
390         (TestExpectationParser):
391         (TestExpectationParser._tokenize_line):
392         (TestExpectationParser._tokenize_line_using_new_format):
393         (TestExpectationLine.to_string):
394         (TestExpectationLine._format_line):
395         (TestExpectations):
396         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
397         (test_parse_warning):
398         (SkippedTests.test_skipped_entry_dont_exist):
399         (NewExpectationSyntaxTests.test_warnings):
400         (RemoveConfigurationsTest.test_remove):
401         (test_remove_line):
402         (RebaseliningTest.test_remove):
403         (RebaseliningTest.test_no_get_rebaselining_failures):
404         (TestExpectationParserTests.test_tokenize_blank):
405         (TestExpectationParserTests.test_tokenize_extra_colon):
406         (TestExpectationParserTests.test_tokenize_missing_equal):
407         (TestExpectationParserTests.test_tokenize_extra_equal):
408         (TestExpectationSerializationTests.test_unparsed_to_string):
409         (TestExpectationSerializationTests.test_unparsed_list_to_string):
410         (TestExpectationSerializationTests.test_parsed_to_string):
411         (TestExpectationSerializationTests.test_format_line):
412         (TestExpectationSerializationTests.test_string_roundtrip):
413         (TestExpectationSerializationTests.test_list_roundtrip):
414         (TestExpectationSerializationTests.test_reconstitute_only_these):
415         (TestExpectationSerializationTests.test_string_whitespace_stripping):
416         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
417         (LintTest.test_lint_test_files__errors):
418         * Scripts/webkitpy/tool/commands/queries_unittest.py:
419         (PrintExpectationsTest.test_basic):
420         (PrintExpectationsTest.test_multiple):
421         (PrintExpectationsTest.test_full):
422         (PrintExpectationsTest.test_exclude):
423         * Scripts/webkitpy/tool/commands/rebaseline.py:
424         (RebaselineExpectations.execute):
425         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
426         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
427         (test_rebaseline_updates_expectations_file):
428         (test_rebaseline_does_not_include_overrides):
429         (test_rebaseline_expectations_noop):
430         (test_overrides_are_included_correctly):
431
432 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
433
434         implement first part of support for the new TestExpectations syntax
435         https://bugs.webkit.org/show_bug.cgi?id=96569
436
437         Reviewed by Ryosuke Niwa.
438
439         This patch implements support for parsing a line of the new
440         format for the TestExpectations file and converting it back into
441         the old format for compatibility. This routine is not yet used
442         by anything.
443
444         The new format is documented at:
445           http://trac.webkit.org/wiki/TestExpectations
446
447         but, in short:
448
449           [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]
450
451         - Comments are indicated with "#" instead of "//"
452         - If no expectations are specified we default to Skip for
453           compatibility with the Skipped files (these two changes make
454           Skipped files a subset of TestExpectations files)
455
456         - All of the tokens are now CamelCase instead of ALLCAPS.
457         - FAIL -> Failure
458         - IMAGE -> ImageOnlyFailure
459         - WONTFIX -> WontFix
460         - modifiers refer to just the platforms and configurations
461           (release/debug) that the line applies to.
462         - WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
463           expectations
464         - expectations will typically be written out in lexicographic order
465         - We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
466           instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.
467
468         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
469         (TestExpectationParser):
470         (TestExpectationParser._tokenize_line_using_new_format):
471         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
472         (NewExpectationSyntaxTests):
473         (NewExpectationSyntaxTests.assert_exp):
474         (NewExpectationSyntaxTests.test_bare_name):
475         (NewExpectationSyntaxTests.test_bare_name_and_bugs):
476         (NewExpectationSyntaxTests.test_comments):
477         (NewExpectationSyntaxTests.test_config_modifiers):
478         (NewExpectationSyntaxTests.test_unknown_config):
479         (NewExpectationSyntaxTests.test_unknown_expectation):
480         (NewExpectationSyntaxTests.test_skip):
481         (NewExpectationSyntaxTests.test_slow):
482         (NewExpectationSyntaxTests.test_wontfix):
483         (NewExpectationSyntaxTests.test_blank_line):
484         (NewExpectationSyntaxTests.test_warnings):
485
486 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
487
488         nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
489         https://bugs.webkit.org/show_bug.cgi?id=96845
490
491         Reviewed by Ojan Vafai.
492
493         In preparation for the new TestExpectations syntax, we replace
494         all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
495         make switching to the new syntax lossless (i.e., we lose
496         information now, not then).
497
498         Note that we can still parse in results.json files that have the
499         old data for backwards compatibility.
500         
501
502         * Scripts/webkitpy/common/net/resultsjsonparser.py:
503         (JSONTestResult._failure_types_from_actual_result):
504         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
505         (ResultsJSONParserTest):
506         (test_basic):
507         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
508         (ResultSummaryTest.test_summarized_results_wontfix):
509         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
510         (JSONLayoutResultsGenerator):
511         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
512         (TestExpectations):
513         (TestExpectations.remove_pixel_failures):
514         (TestExpectations.has_pixel_failures):
515         (TestExpectations.suffixes_for_expectations):
516         (TestExpectations.get_rebaselining_failures):
517         (TestExpectations.remove_configuration_from_test):
518         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
519         (assert_bad_expectations):
520         (BasicTests):
521         (BasicTests.test_basic):
522         (MiscTests):
523         (MiscTests.test_multiple_results):
524         (MiscTests.test_result_was_expected):
525         (MiscTests.test_remove_pixel_failures):
526         (MiscTests.test_suffixes_for_expectations):
527         (test_get_expectations_string):
528         (test_parse_warning):
529         (test_error_on_different_platform):
530         (test_error_on_different_build_type):
531         (test_overrides):
532         (test_overrides__directory):
533         (test_overrides__duplicate):
534         (test_pixel_tests_flag):
535         (test_more_specific_override_resets_skip):
536         (SkippedTests.test_skipped_file_overrides_expectations):
537         (SkippedTests.test_skipped_dir_overrides_expectations):
538         (SkippedTests.test_skipped_file_overrides_overrides):
539         (SkippedTests.test_skipped_dir_overrides_overrides):
540         (ExpectationSyntaxTests.test_missing_colon):
541         (ExpectationSyntaxTests.test_too_many_equals_signs):
542         (SemanticTests.test_bug_format):
543         (SemanticTests.test_bad_bugid):
544         (SemanticTests.test_missing_bugid):
545         (SemanticTests.test_rebaseline):
546         (test_missing_file):
547         (test_more_modifiers):
548         (test_order_in_file):
549         (test_macro_overrides):
550         (RemoveConfigurationsTest.test_remove):
551         (test_remove_line):
552         (RebaseliningTest.test_remove):
553         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
554         * Scripts/webkitpy/layout_tests/models/test_failures.py:
555         (determine_result_type):
556         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
557         (test_test_expectations):
558         * Scripts/webkitpy/layout_tests/port/test.py:
559         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
560         (MainTest.test_missing_and_unexpected_results):
561         (MainTest.test_retrying_and_flaky_tests):
562         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
563         (TestExpectationsTestCase.test_valid_expectations):
564         * Scripts/webkitpy/tool/commands/queries_unittest.py:
565         (PrintExpectationsTest.test_basic):
566         (PrintExpectationsTest.test_multiple):
567         (PrintExpectationsTest.test_full):
568         (PrintExpectationsTest.test_exclude):
569         (PrintExpectationsTest.test_csv):
570         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
571         (test_rebaseline_does_not_include_overrides):
572         (test_overrides_are_included_correctly):
573
574 2012-09-19  Dominic Mazzoni  <dmazzoni@google.com>
575
576         AX: A few control types are returning the wrong answer for isReadOnly
577         https://bugs.webkit.org/show_bug.cgi?id=96735
578
579         Reviewed by Chris Fleizach.
580
581         Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.
582
583         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
584         (AccessibilityUIElement::AccessibilityUIElement):
585         (AccessibilityUIElement::isReadOnlyGetterCallback):
586         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
587         (AccessibilityUIElement):
588
589 2012-09-19  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
590
591         [WTR] Memory leaks in TestRunner::deliverWebIntent()
592         https://bugs.webkit.org/show_bug.cgi?id=97111
593
594         Reviewed by Kenneth Rohde Christiansen.
595
596         Fix memory leaks in deliverWebIntent() by adopting strings
597         created with WKStringCreateWithUTF8CString().
598
599         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
600         (WTR::TestRunner::deliverWebIntent):
601
602 2012-09-19  Simon Hausmann  <simon.hausmann@digia.com>
603
604         [Qt] Fix incremental builds with all-in-one-files and gccdepends
605
606         Reviewed by Tor Arne Vestbø.
607
608         Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
609         are not only created for header files but also for .cpp files. AllInOne.cpp files
610         include other .cpp files, and when those are removed we need those dummy rules to
611         avoid a "No rule to make Foo.cpp required by AllInOne.o" error.
612
613         * qmake/config.tests/gccdepends/empty.cpp:
614         (main):
615         * qmake/config.tests/gccdepends/gccdepends.pro:
616         * qmake/mkspecs/features/default_pre.prf:
617
618 2012-09-19  Rick Byers  <rbyers@chromium.org>
619
620         Do touch adjustment on GestureTapDown
621         https://bugs.webkit.org/show_bug.cgi?id=96677
622
623         Reviewed by Antonio Gomes.
624
625         Allow radius to be set for GestureTapDown events.
626         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
627         (EventSender::gestureEvent):
628
629 2012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
630
631         [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
632         https://bugs.webkit.org/show_bug.cgi?id=97100
633
634         Reviewed by Gyuyoung Kim.
635
636         EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
637         preference, in order to match WebKitTestRunner functionality.
638
639         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
640         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
641         * DumpRenderTree/efl/TestRunnerEfl.cpp:
642         (TestRunner::overridePreference):
643
644 2012-09-18  Kangil Han  <kangil.han@samsung.com>
645
646         [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
647         https://bugs.webkit.org/show_bug.cgi?id=96181
648
649         Reviewed by Daniel Bates.
650
651         This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
652
653         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
654         (new):
655         (_parseLicenseBlock):
656         (_parseLicenseBlockFromFile):
657         (_defaultLicenseBlock):
658         (_licenseBlock):
659         (_generateHeaderFile):
660         (_generateImplementationFile):
661
662 2012-09-18  Byungwoo Lee  <bw80.lee@samsung.com>
663
664         Title string should be changed when document.title is set to ''.
665         https://bugs.webkit.org/show_bug.cgi?id=96793
666
667         Reviewed by Kenneth Rohde Christiansen.
668
669         Change dump format of dumpTitleChanges more understandable.
670         Uses single quotation marks for the title string.
671
672         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
673         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
674         * DumpRenderTree/chromium/WebViewHost.cpp:
675         (WebViewHost::didReceiveTitle):
676         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
677         (DumpRenderTreeChrome::onFrameTitleChanged):
678         * DumpRenderTree/gtk/DumpRenderTree.cpp:
679         (webViewTitleChanged):
680         * DumpRenderTree/mac/FrameLoadDelegate.mm:
681         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
682         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
683         (WebCore::DumpRenderTree::titleChanged):
684         * DumpRenderTree/win/FrameLoadDelegate.cpp:
685         (FrameLoadDelegate::didReceiveTitle):
686         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
687         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
688         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
689         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
690
691 2012-09-18  Szilard Ledan  <szledan@inf.u-szeged.hu>
692
693         EWS shouldn't sleep if there are new patches in its queue
694         https://bugs.webkit.org/show_bug.cgi?id=83038
695
696         Reviewed by Eric Seidel.
697
698         EWS tries to process a security patch. Of course it can't, because the EWS isn't
699         the member of the security group. But the problem is that after it can't process
700         the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
701         and push the security patch to the end of the queue.
702         Now it stays in the loop until it finds a patch or the queue gets empty.
703
704         * Scripts/webkitpy/tool/commands/queues.py:
705         (AbstractPatchQueue._next_patch):
706         * Scripts/webkitpy/tool/commands/queues_unittest.py:
707         (AbstractPatchQueueTest.test_next_patch):
708
709 2012-09-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
710
711         [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
712         https://bugs.webkit.org/show_bug.cgi?id=97014
713
714         Reviewed by Kenneth Rohde Christiansen.
715
716         According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
717         be used for literals rather than WTF::StringBuilder::append().
718
719         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
720         (WTR::InjectedBundle::booleanForKey):
721
722 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
723
724         Update my e-mail address.
725
726         * Scripts/webkitpy/common/config/committers.py:
727
728 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
729
730         Update my e-mail address.
731
732         Unreviewed.
733
734         * Scripts/webkitpy/common/config/committers.py:
735
736 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
737
738         [Qt] qt_webkit.pri should not be listed in Tools.pro
739
740         Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
741
742         Since r128751 the module pri file is auto-generated
743         but it was still listed in OTHER_FILES.
744
745         * Tools.pro: Remove unneeded line.
746
747 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
748
749         [Qt] Fix build with some versions of the gold linker
750
751         Reviewed by Tor Arne Vestbø.
752
753         Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
754         Instead run a compile/link test first to see if it works.
755
756         * qmake/config.tests/gnuld/gnuld.pro: Added.
757         * qmake/config.tests/gnuld/main.cpp: Added.
758         (main):
759         * qmake/mkspecs/features/unix/default_post.prf:
760
761 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
762
763         [Qt] Remove forced use of gold.
764
765         Reviewed by Tor Arne Vestbø.
766
767         The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
768         modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
769         often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
770
771         * qmake/mkspecs/features/unix/default_post.prf:
772
773 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
774
775         [Qt] Prospective Qt/Windows cross-compiling fix
776
777         Reviewed by Tor Arne Vestbø.
778
779         The win32 scope is not set when cross-compiling from Linux to Windows.
780
781         * qmake/mkspecs/features/functions.prf:
782
783 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
784
785         [EFL] Remove background view on EWebLauncher and MiniBrowser
786         https://bugs.webkit.org/show_bug.cgi?id=96905
787
788         Reviewed by Gyuyoung Kim.
789
790         The size of webview was changed after adding url bar.
791         And the background view is not necessary anymore, since it was used for debugging back in the day.
792
793         * EWebLauncher/main.c:
794         (_ELauncher):
795         (on_ecore_evas_resize):
796         (browserCreate):
797         * MiniBrowser/efl/main.c:
798         (_MiniBrowser):
799         (on_ecore_evas_resize):
800         (browserCreate):
801
802 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
803
804         [GTK] run-webkit-tests unable to find TestExpectations for WK2
805         https://bugs.webkit.org/show_bug.cgi?id=96998
806
807         Reviewed by Philippe Normand.
808
809         We should look for TestExpectations files in all the locations where
810         we currently look for Skipped files. This will allow
811         run-webkit-tests to look for TestExpectations files in
812         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
813
814         * Scripts/webkitpy/layout_tests/port/gtk.py:
815         (GtkPort.expectations_files):
816
817 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
818
819         [Qt] Fix build without the QtQuick module
820
821         Reviewed by Simon Hausmann.
822
823         * qmake/mkspecs/features/features.prf:
824
825 2012-09-18  Stephanie Lewis  <slewis@apple.com>
826
827         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
828
829         Unreviewed.
830
831         * DumpRenderTree/mac/DumpRenderTree.mm:
832         (poseAsClass):
833
834 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
835
836         Unreviewed update of email addresses for Berlin QtWebKit office.
837
838         * Scripts/webkitpy/common/config/committers.py:
839
840 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
841
842         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
843         https://bugs.webkit.org/show_bug.cgi?id=96899
844
845         Reviewed by Martin Robinson.
846
847         When overriding the 'WebKitDisplayImageKey' preference, use the
848         'auto-load-images' property of WebKitWebSettings as the property which
849         should be updated with the corresponding preference value.
850
851         * DumpRenderTree/gtk/DumpRenderTree.cpp:
852         (resetDefaultsToConsistentValues):
853         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
854         (TestRunner::overridePreference):
855
856 2012-09-17  Pratik Solanki  <psolanki@apple.com>
857
858         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
859         https://bugs.webkit.org/show_bug.cgi?id=96973
860
861         Reviewed by Dan Bernstein.
862
863         * DumpRenderTree/mac/Configurations/Base.xcconfig:
864         * WebKitTestRunner/Configurations/Base.xcconfig:
865         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
866
867 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
868
869         nrwt: remove "unexpected EOF" warnings
870         https://bugs.webkit.org/show_bug.cgi?id=96970
871
872         Reviewed by Ojan Vafai.
873
874         After debugging this a bit, it looks like there aren't any cases
875         that I can reproduce where a read() of zero indicates something
876         actually wrong; either it is a prelude to a crash, or a false
877         negative. So, I'm removing these warnings and adding a comment.
878
879         * Scripts/webkitpy/layout_tests/port/server_process.py:
880         (ServerProcess._wait_for_data_and_update_buffers_using_select):
881
882 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
883
884         [chromium] ASAN bot is crashing at the end of the run
885         https://bugs.webkit.org/show_bug.cgi?id=96967
886
887         Reviewed by Abhishek Arya.
888
889         The ASAN bot is crashing attempting to decode some output into
890         UTF-8; there's no reason to do this, so let's not do this and
891         see if something else is going on as well.
892
893         * Scripts/webkitpy/layout_tests/port/chromium.py:
894         (ChromiumPort._get_crash_log):
895
896 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
897
898         nrwt: --results-directory isn't getting printed properly
899         https://bugs.webkit.org/show_bug.cgi?id=96965
900
901         Reviewed by Ojan Vafai.
902
903         options.results_directory isn't actually initialized with the
904         default values until after we call print_config(), so this
905         changes things to print the value directly.
906
907         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
908         (run):
909         * Scripts/webkitpy/layout_tests/views/printing.py:
910         (Printer.print_config):
911         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
912         (Testprinter.test_print_config):
913
914 2012-09-17  Rob Buis  <rbuis@rim.com>
915
916         [BlackBerry] Enable VIDEO_TRACK
917         https://bugs.webkit.org/show_bug.cgi?id=96949
918
919         Reviewed by Antonio Gomes.
920
921         * Scripts/webkitperl/FeatureList.pm:
922
923 2012-09-17  Rick Byers  <rbyers@chromium.org>
924
925         Add handling of new GestureTapCancel in DRT
926
927         https://bugs.webkit.org/show_bug.cgi?id=96183
928
929         Reviewed by Antonio Gomes.
930
931         * DumpRenderTree/chromium/TestWebPlugin.cpp:
932         (TestWebPlugin::handleInputEvent):
933         * DumpRenderTree/chromium/EventSender.cpp:
934         (EventSender::gestureTapCancel):
935
936 2012-09-17  Philip Rogers  <pdr@google.com>
937
938         Teach style checker about preprocessor directive indentation rules
939         https://bugs.webkit.org/show_bug.cgi?id=96874
940
941         Reviewed by Adam Barth.
942
943         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
944         This is not explicit in our style guide but is generally followed in our code.
945         Searching for violations in our codebase shows these are rarely indented:
946             #include - indented in 6 files
947             #ifdef - indented in 0 files
948             #ifndef - indented in 1 file
949             #define - indented in 11 files
950             #if - indented in 7 files
951
952         * Scripts/webkitpy/style/checkers/cpp.py:
953         (check_directive_indentation):
954
955             This is the simple test where we look for spaces followed by a #.
956
957         (check_style):
958         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
959
960             A few tests needed to be modified because they had unintentionally indented
961             preprocessor directives.
962
963         (CppStyleTest.test_build_class.Foo):
964         (CppStyleTest.test_build_class):
965         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
966         (WebKitStyleTest.test_line_breaking):
967         (WebKitStyleTest.test_directive_indentation):
968
969 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
970
971         [Qt] Auto-generate the module pri file for QtWebKit
972
973         Reviewed by Simon Hausmann.
974
975         * qmake/qt_webkit.pri: Removed.
976
977 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
978
979         nrwt: --additional-platform-dir is broken on chromium ports
980         https://bugs.webkit.org/show_bug.cgi?id=96840
981
982         Reviewed by Ojan Vafai.
983
984         Looks like I broke this when cleaning things up as part of
985         adding ML support. Fixing and adding a test.
986
987         * Scripts/webkitpy/layout_tests/port/chromium.py:
988         (ChromiumPort.default_baseline_search_path):
989         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
990         (ChromiumAndroidPort.default_baseline_search_path):
991         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
992         (ChromiumLinuxPort.default_baseline_search_path):
993         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
994         (ChromiumMacPort.__init__):
995         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
996         (ChromiumWinPort.setup_environ_for_server):
997         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
998         (test_check_build):
999         (test_additional_platform_directory):
1000
1001 2012-09-13  Stephanie Lewis  <slewis@apple.com>
1002
1003         mac-future ignores previous platform TestExpectations.
1004         https://bugs.webkit.org/show_bug.cgi?id=96718.
1005
1006         Reviewed by Dirk Pranke.
1007
1008         TestExpectations match an expectation's configuraton against a list of configurations that are 
1009         valid for that port.  That list does not contain mac-future so none of the expectations can be
1010         applied.
1011
1012         * Scripts/webkitpy/layout_tests/port/apple.py:
1013         (ApplePort._generate_all_test_configurations):
1014
1015 2012-09-14  Adam Barth  <abarth@webkit.org>
1016
1017         Remove webkitPostMessage
1018         https://bugs.webkit.org/show_bug.cgi?id=96577
1019
1020         Reviewed by Ojan Vafai.
1021
1022         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
1023
1024         * Scripts/webkitperl/FeatureList.pm:
1025         * qmake/mkspecs/features/features.pri:
1026
1027 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
1028
1029         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
1030         https://bugs.webkit.org/show_bug.cgi?id=96817
1031
1032         Reviewed by Kenneth Rohde Christiansen.
1033
1034         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1035         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
1036         got overlooked when adding logging elsewhere.
1037
1038 2012-09-14  Peter Beverloo  <peter@chromium.org>
1039
1040         [Chromium] Build fix for DumpRenderTree following r128628
1041         https://bugs.webkit.org/show_bug.cgi?id=96808
1042
1043         Reviewed by Tony Chang.
1044
1045         When building DumpRenderTree from the Chromium project, a compile error
1046         shows up because including the header ForwardIOStreamsAndroid.h cannot
1047         be located. TestWebKitAPI does this correctly.
1048
1049         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1050
1051 2012-09-14  Dana Jansens  <danakj@chromium.org>
1052
1053         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
1054         https://bugs.webkit.org/show_bug.cgi?id=96805
1055
1056         Reviewed by Dirk Pranke.
1057
1058         * Scripts/webkitpy/common/config/committers.py:
1059         * Scripts/webkitpy/common/config/watchlist:
1060
1061 2012-09-14  Peter Beverloo  <peter@chromium.org>
1062
1063         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
1064         https://bugs.webkit.org/show_bug.cgi?id=96687
1065
1066         Reviewed by Tony Chang.
1067
1068         Android's DumpRenderTree currently supports these arguments, implemented
1069         as part of TestShellAndroid:
1070         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
1071
1072         They're used by the layout test runner to get the STDOUT and STDERR while
1073         a layout test run is in process, which is a safer alternative to parsing
1074         all the logcat output manually. The implementation can be seen here:
1075         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
1076
1077         This patch generalizes parsing of and applying the effects of these arguments
1078         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
1079         After this patch, this will make it possible to pull out the output-reading
1080         code from Android's layout test port and generalize it so it can be re-used
1081         in the new test-runner for the other two test suites.
1082
1083         This has no effect when compiling and running these tests as part of Chromium
1084         code, which has a much more advanced test-runner that does parse complete log
1085         output, but also directly depends on code licensed under Apache 2.
1086
1087         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1088         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1089         (platformInit):
1090         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1091
1092 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
1093
1094         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
1095         https://bugs.webkit.org/show_bug.cgi?id=96656
1096
1097         Reviewed by Adam Barth.
1098
1099         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
1100         macros in 1 line.
1101
1102         * Scripts/webkitpy/style/checkers/cpp.py:
1103         (check_style.definitions):
1104         (check_style): Add rule.
1105         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1106         (WebKitStyleTest.test_line_breaking): Add unittest.
1107
1108 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1109
1110         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
1111         https://bugs.webkit.org/show_bug.cgi?id=57570
1112
1113         Reviewed by Kenneth Rohde Christiansen.
1114
1115         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
1116         and dump the information expected by the test cases.
1117
1118         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1119         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1120         (WTR::InjectedBundle::beginTesting): Explicitly set the default
1121         database quota.
1122         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1123         (WTR::securityOriginToStr): New convenience function to convert
1124         a security origin to the string expected in test results.
1125         (WTR):
1126         (WTR::InjectedBundlePage::InjectedBundlePage):
1127         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
1128         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
1129         refactoring to share code with didExceedDatabaseQuota.
1130         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1131         (InjectedBundlePage):
1132         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1133         (WTR::TestRunner::TestRunner):
1134         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1135         (WTR::TestRunner::dumpDatabaseCallbacks):
1136         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
1137         (TestRunner):
1138
1139 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1140
1141         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
1142
1143         Rubber-stamped by Simon Hausmann.
1144
1145         * qmake/mkspecs/features/default_post.prf:
1146
1147 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1148
1149         [Qt] Remove old cruft from the qmake build system
1150
1151         Rubber-stamped by Simon Hausmann.
1152
1153         * DumpRenderTree/qt/DumpRenderTree.pro:
1154         * qmake/mkspecs/features/default_post.prf:
1155
1156 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1157
1158         [Qt] Enable force_static_libs_as_shared for development
1159
1160         Not enabled for buildbots or production-builds (part of Qt5)
1161
1162         Reviewed by Simon Hausmann.
1163
1164         * qmake/mkspecs/features/default_post.prf:
1165
1166 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1167
1168         [Qt] Make force_static_libs_as_shared work on Mac OS
1169
1170         We had to move a few LIBS += around that were in the wrong place,
1171         and not caught when everything was just linked into the final
1172         QtWebKit library.
1173
1174         Reviewed by Simon Hausmann.
1175
1176         * qmake/mkspecs/features/default_post.prf:
1177         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
1178
1179 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
1180
1181         [Qt] Fix build of WTR on Windows
1182
1183         Reviewed by Tor Arne Vestbø.
1184
1185         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
1186         With qmake's unix makefile generator as well as with the MingW generator,
1187         the directory where the pro file lives (WTR/) is automatically added to
1188         the include search path, but not so with MSVC. Instead of relying on qmake's
1189         implicit feature here, add WTR/ explicitly to the include search path.
1190
1191         * WebKitTestRunner/Target.pri:
1192
1193 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1194
1195         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
1196         https://bugs.webkit.org/show_bug.cgi?id=42691
1197
1198         Reviewed by Kenneth Rohde Christiansen.
1199
1200         Add implementation for testrunner.setStopProvisionalFrameLoads()
1201         in WebKitTestRunner.
1202
1203         Original patch by Alexey Proskuryakov.
1204
1205         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1206         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1207         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1208         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1209         (WTR::TestRunner::TestRunner):
1210         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1211         (TestRunner):
1212         (WTR::TestRunner::setStopProvisionalFrameLoads):
1213         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
1214
1215 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1216
1217         [Qt] Fix handling of debug/release/debug_and_release/build_all
1218
1219         We now pick up the defaults from Qt, in default_pre (CONFIG already
1220         contains the appropriate values for debug and release). We then let
1221         the command line arguments to qmake, or the project files themselves,
1222         override the configuration, and finally we sanitize the configuration
1223         in default_post.
1224
1225         Reviewed by Simon Hausmann.
1226
1227         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1228         * Scripts/webkitdirs.pm:
1229         (buildQMakeProjects):
1230         * qmake/mkspecs/features/default_post.prf:
1231         * qmake/mkspecs/features/default_pre.prf:
1232         * qmake/mkspecs/features/mac/default_pre.prf:
1233
1234 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1235
1236         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
1237         https://bugs.webkit.org/show_bug.cgi?id=42687
1238
1239         Reviewed by Kenneth Rohde Christiansen.
1240
1241         Implement testRunner.setTabKeyCyclesThroughElements for
1242         WebKitTestRunner.
1243
1244         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1245         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1246         (WTR::InjectedBundle::beginTesting):
1247         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1248         (WTR::TestRunner::setTabKeyCyclesThroughElements):
1249         (WTR):
1250         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1251         (TestRunner):
1252
1253 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1254
1255         EventSendingController::keyDown does not support non-array modifier arguments
1256         https://bugs.webkit.org/show_bug.cgi?id=96727
1257
1258         Reviewed by Kenneth Rohde Christiansen.
1259
1260         Add support for handling a string as modifier argument to
1261         EventSendingController::keyDown.
1262
1263         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1264         (WTR::parseModifierArray):
1265
1266 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1267
1268         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
1269         https://bugs.webkit.org/show_bug.cgi?id=42546
1270
1271         Reviewed by Kenneth Rohde Christiansen.
1272
1273         Exported TestRunner::setCustomPolicyDelegate() method.
1274         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
1275
1276         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1277         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1278         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1279
1280 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
1281
1282         [GTK] Clear application cache between tests in DumpRenderTree
1283         https://bugs.webkit.org/show_bug.cgi?id=96543
1284
1285         Reviewed by Philippe Normand.
1286
1287         Call the new DumpRenderTreeSupportGtk method to clear application cache
1288         after each test in DumpRenderTree.
1289
1290         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1291         as well. It's now being set in XvfbDriver._start so that each driver is assigned
1292         a cache directory that's constructed out of the driver's name and its worker
1293         number. These directories are located in the layout tests results directory.
1294         At least on the builders this ensures a driver-specific empty cache directory
1295         with each test run.
1296
1297         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1298         (runTest):
1299         * Scripts/webkitpy/layout_tests/port/gtk.py:
1300         (GtkPort.setup_environ_for_server):
1301         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1302         (XvfbDriver._start):
1303
1304 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
1305
1306         [Qt] Fix linking on Windows
1307
1308         Reviewed by Tor Arne Vestbø.
1309
1310         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
1311         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
1312         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
1313         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
1314
1315         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
1316         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
1317         after the module. Therefore QT did never contain webkit anymore and we always passed
1318         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
1319
1320         This patch introduces a creating_module configuration that is used to
1321         scope the qt/pkgconfig sanitization.
1322
1323         * qmake/mkspecs/features/default_post.prf:
1324
1325 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1326
1327         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
1328         https://bugs.webkit.org/show_bug.cgi?id=96740
1329
1330         Reviewed by Kenneth Rohde Christiansen.
1331
1332         Dump information expected by the test cases about the following
1333         frame load callbacks:
1334         "didDisplayInsecureContentForFrame"
1335         "didRunInsecureContentForFrame"
1336         "didDetectXSSForFrame"
1337
1338         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1339         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
1340         as expected by test results by calling pathSuitableForTestResult() instead
1341         of printing raw URL.
1342         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
1343         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
1344         (WTR::InjectedBundlePage::didDetectXSSForFrame):
1345
1346 2012-09-14  Peter Beverloo  <peter@chromium.org>
1347
1348         The runtime/unsigned category should be valid in the cpp style-checker.
1349         https://bugs.webkit.org/show_bug.cgi?id=96748
1350
1351         Reviewed by Csaba Osztrogonác.
1352
1353         This is causing the webkitpy tests to fail because it's not listed in the
1354         category array. Furthermore, change an "int" to "long" because it's
1355         throwing a double error in one of the earlier asserts.
1356
1357         * Scripts/webkitpy/style/checkers/cpp.py:
1358         (CppChecker):
1359         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1360         (WebKitStyleTest.test_names):
1361
1362 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1363
1364         Evas_Object* is a ref'ed structure, so tread it as such
1365         https://bugs.webkit.org/show_bug.cgi?id=96659
1366
1367         Reviewed by Adam Barth.
1368
1369         Replace OwnPtr<Evas_Object> with RefPtr.
1370
1371         * DumpRenderTree/efl/ImageDiff.cpp:
1372         (calculateDifference):
1373         (printImageDifferences):
1374         (readImageFromStdin):
1375         (main):
1376
1377 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1378
1379         Unreviewed, rolling out r128507.
1380         http://trac.webkit.org/changeset/128507
1381         https://bugs.webkit.org/show_bug.cgi?id=96659
1382
1383         Revert. r128507 makes too many crashes in EFL layout test bots.
1384
1385         * DumpRenderTree/efl/ImageDiff.cpp:
1386         (calculateDifference):
1387         (printImageDifferences):
1388         (readImageFromStdin):
1389         (main):
1390
1391 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
1392
1393         Make compile with both OS(WINCE) and PLATFORM(QT) support
1394         https://bugs.webkit.org/show_bug.cgi?id=95536
1395
1396         Reviewed by Simon Hausmann.
1397
1398         Fix wince support in qmake files
1399
1400         * Tools.pro:
1401         * qmake/mkspecs/features/configure.prf:
1402         * qmake/mkspecs/features/default_post.prf:
1403         * qmake/mkspecs/features/features.prf:
1404         * qmake/mkspecs/features/functions.prf:
1405
1406 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
1407
1408         [WK2] Add color picker API support for WebKit2
1409         https://bugs.webkit.org/show_bug.cgi?id=95058
1410
1411         Reviewed by Gyuyoung Kim.
1412
1413         Initialization code for color picker callbacks in UI client.
1414
1415         * MiniBrowser/mac/BrowserWindowController.m:
1416         (-[BrowserWindowController awakeFromNib]):
1417         * MiniBrowser/win/BrowserView.cpp:
1418         (BrowserView::create):
1419         * WebKitTestRunner/TestController.cpp:
1420         (WTR::TestController::createOtherPage):
1421         (WTR::TestController::initialize):
1422
1423 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
1424
1425         Upgrade yutak to reviewer
1426         https://bugs.webkit.org/show_bug.cgi?id=96721
1427
1428         Reviewed by Kent Tamura.
1429
1430         * Scripts/webkitpy/common/config/committers.py:
1431
1432 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1433
1434         Make the style checker report usage of "unsigned int"
1435         https://bugs.webkit.org/show_bug.cgi?id=96693
1436
1437         Reviewed by Dirk Pranke.
1438
1439         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
1440
1441         * Scripts/webkitpy/style/checkers/cpp.py:
1442         (check_language):
1443
1444 2012-09-13  Philip Rogers  <pdr@google.com>
1445
1446         Add gender-neutral form of webkit-patch land-cowboy
1447         https://bugs.webkit.org/show_bug.cgi?id=96709
1448
1449         Reviewed by Adam Barth.
1450
1451         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
1452
1453         * Scripts/webkitpy/tool/commands/download.py:
1454         (LandCowhand):
1455
1456 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
1457
1458         [EFL] Remove some parameters in browserCreate()
1459         https://bugs.webkit.org/show_bug.cgi?id=96499
1460
1461         Reviewed by Kenneth Rohde Christiansen.
1462
1463         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
1464         And I have moved some parameters into User_Arguments.
1465
1466         * EWebLauncher/main.c:
1467         (_User_Arguments):
1468         (_ELauncher):
1469         (on_key_down):
1470         (browserCreate):
1471         (findThemePath):
1472         (parseUserArguments):
1473         (main):
1474
1475 2012-09-13  Mark Lam  <mark.lam@apple.com>
1476
1477         Unreviewed. Adding myself to the committers list.
1478
1479         * Scripts/webkitpy/common/config/committers.py:
1480
1481 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1482
1483         run-perf-tests output cryptic error when the config file is missing.
1484         https://bugs.webkit.org/show_bug.cgi?id=96453
1485
1486         Reviewed by Tony Chang.
1487
1488         Add a special error message when a configuration file is missing.
1489
1490         Also update the help message of --source-json-path to signify the fact it specifies
1491         the configuration file on performance tests bots.
1492
1493         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1494         (PerfTestsRunner._parse_args):
1495         (PerfTestsRunner._generate_and_show_results):
1496         (PerfTestsRunner._merge_slave_config_json):
1497         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1498         (_test_run_with_json_output): Make upload to fail by default and assert the result
1499         in the function so that we can return logs instead.
1500         (_test_run_with_json_output.mock_upload_json):
1501         (test_run_with_json_output):
1502         (test_run_with_description):
1503         (test_run_respects_no_results):
1504         (test_run_with_slave_config_json):
1505         (test_run_with_bad_slave_config_json):
1506         (test_run_with_multiple_repositories):
1507
1508 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1509
1510         Evas_Object* is a ref'ed structure, so tread it as such
1511         https://bugs.webkit.org/show_bug.cgi?id=96659
1512
1513         Reviewed by Adam Barth.
1514
1515         Replace OwnPtr<Evas_Object> with RefPtr.
1516
1517         * DumpRenderTree/efl/ImageDiff.cpp:
1518         (calculateDifference):
1519         (printImageDifferences):
1520         (readImageFromStdin):
1521         (main):
1522
1523 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1524
1525         One more unreviewed trivial fix after r128399.
1526
1527         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
1528
1529 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1530
1531         Unreviewed trivial fix after r128399.
1532
1533         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
1534         (getLatestSVNRevision):
1535         (waitForSVNRevision):
1536
1537 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1538
1539         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
1540         https://bugs.webkit.org/show_bug.cgi?id=96366
1541
1542         Reviewed by Anders Carlsson.
1543
1544         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
1545         by calling shouldClose() on the FrameLoader.
1546
1547         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1548         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1549         (WTR::TestRunner::callShouldCloseOnWebView):
1550         (WTR):
1551         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1552         (TestRunner):
1553
1554 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1555
1556         Unreviewed, rolling out r128453.
1557         http://trac.webkit.org/changeset/128453
1558         https://bugs.webkit.org/show_bug.cgi?id=96681
1559
1560         Having tests use the same appcache directory leads to timeouts
1561         (Requested by zdobersek on #webkit).
1562
1563         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1564         (runTest):
1565         * Scripts/webkitpy/layout_tests/port/gtk.py:
1566         (GtkPort.setup_environ_for_server):
1567
1568 2012-09-13  James Robinson  <jamesr@chromium.org>
1569
1570         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
1571         https://bugs.webkit.org/show_bug.cgi?id=96678
1572
1573         Reviewed by Dirk Pranke.
1574
1575         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1576         (.):
1577
1578 2012-09-13  Rob Buis  <rbuis@rim.com>
1579
1580         Unreviewed changes to watchlist.
1581
1582         - Add myself to BlackBerry bugs
1583
1584         * Scripts/webkitpy/common/config/watchlist:
1585
1586 2012-09-13  Stephen Chenney  <schenney@chromium.org>
1587
1588         Add an SVG entry to the watchlist
1589
1590         Unreviewed config change.
1591
1592         * Scripts/webkitpy/common/config/watchlist:
1593         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
1594         - Added myself and pdr as watchers
1595
1596 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1597
1598         [Qt] Make WebKit2 work on Windows with Qt 5
1599         https://bugs.webkit.org/show_bug.cgi?id=76776
1600
1601         Reviewed by Tor Arne Vestbø.
1602
1603         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
1604         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
1605         that for the GL TextureMapper (it's only built when that feature is set).
1606
1607         * qmake/mkspecs/features/configure.prf:
1608
1609 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1610
1611         [Qt] Ensure that QT is finalized before loading qt_module.prf
1612
1613         As qt_module.prf does dependency tracking based on the content of the
1614         QT variable. The intermediate WebKit modules modify the variable in
1615         their .pri files, so we have to ensure we've loaded all the modules
1616         before loading qt_module.
1617
1618         Reviewed by Tor Arne Vestbø.
1619         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
1620
1621         * qmake/mkspecs/features/default_post.prf:
1622         * qmake/mkspecs/features/webkit_modules.prf: Added.
1623
1624 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1625
1626         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
1627         https://bugs.webkit.org/show_bug.cgi?id=96633
1628
1629         Reviewed by Csaba Osztrogonác.
1630
1631         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
1632         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
1633         It's the usual problem and the usual solution is to rename one of the conflicting files.
1634         This patch chooses to rename DRT instead of WTR and MBR.
1635
1636         Fixed include order at the same time to match style guide.
1637
1638         * DumpRenderTree/qt/DumpRenderTree.pro:
1639         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
1640         (messageHandler):
1641         (isOption):
1642         (takeOptionValue):
1643         (printUsage):
1644         (main):
1645
1646 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1647
1648         The Script run-launcher should support -2 in combination with --efl
1649         https://bugs.webkit.org/show_bug.cgi?id=96639
1650
1651         Reviewed by Simon Hausmann.
1652
1653         Support running the MiniBrowser then supplied -2 as argument.
1654
1655         * Scripts/run-launcher:
1656
1657 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1658
1659         Unreviewed, add my Intel email address to the list.
1660
1661         * Scripts/webkitpy/common/config/committers.py:
1662
1663 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1664
1665         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
1666
1667         Reviewed by Ossy.
1668
1669         * qmake/mkspecs/features/default_post.prf:
1670
1671 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1672
1673         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
1674         https://bugs.webkit.org/show_bug.cgi?id=82294
1675
1676         Reviewed by Gyuyoung Kim.
1677
1678         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
1679
1680         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1681         (TestRunner::layerTreeAsText):
1682
1683 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1684
1685         [GTK] Clear application cache between tests in DumpRenderTree
1686         https://bugs.webkit.org/show_bug.cgi?id=96543
1687
1688         Reviewed by Philippe Normand.
1689
1690         Call the new DumpRenderTreeSupportGtk method to clear application cache
1691         after each test.
1692
1693         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1694         as well. Currently it points to a subdirectory in the layout tests results
1695         directory. At least on the builders this ensures an empty cache directory
1696         with each test run.
1697
1698         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1699         (runTest):
1700         * Scripts/webkitpy/layout_tests/port/gtk.py:
1701         (GtkPort.setup_environ_for_server):
1702
1703 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1704
1705         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
1706
1707         Unless it's actually a dependency of the public QtWebKit API.
1708
1709         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
1710         files with their _PRIVATE equivivalent, but that's likely to break when
1711         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
1712         clean up the variables in default_post.
1713
1714         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
1715         longer needed, as it was a workaround for the intermediate libraries ending
1716         up in the prl file. And, since CONFIG -= staticlib was there to support
1717         the explicitlib option, we can remove that too (as well as the exception
1718         for gprof, since it would be empty). If gprof needs tweaks to always link
1719         statically they should go in gprof.prf.
1720
1721         Reviewed by Simon Hausmann.
1722
1723         * qmake/mkspecs/features/default_post.prf:
1724         * qmake/mkspecs/features/functions.prf:
1725
1726 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
1727
1728         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
1729         https://bugs.webkit.org/show_bug.cgi?id=96632
1730
1731         Reviewed by Carlos Garcia Campos.
1732
1733         Fix this by using atk_object_get_n_accessible_children instead of
1734         calling getChildren() from childCount.
1735
1736         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
1737         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
1738         loop by using atk_object_get_n_accessible_children().
1739
1740 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1741
1742         [Qt][Win] Enable USE(3D_GRAPHICS)
1743         https://bugs.webkit.org/show_bug.cgi?id=90879
1744
1745         Reviewed by Kenneth Rohde Christiansen.
1746
1747         Enable it on Windows as well as on QNX (bug fixed).
1748
1749         * qmake/mkspecs/features/features.prf:
1750
1751 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1752
1753         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
1754         https://bugs.webkit.org/show_bug.cgi?id=96359
1755
1756         Reviewed by Tor Arne Vestbø.
1757
1758         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
1759         lexer. The only viable alternative I could find on Windows that provides
1760         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
1761         so let's use that one instead.
1762
1763         * Scripts/webkitdirs.pm:
1764         (checkRequiredSystemConfig):
1765         * qmake/mkspecs/features/default_pre.prf:
1766
1767 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1768
1769         [Qt] Add configuration for production builds
1770         https://bugs.webkit.org/show_bug.cgi?id=96607
1771
1772         Reviewed by Kenneth Rohde Christiansen.
1773
1774         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
1775         and enable all-in-one-files optimizations.
1776
1777         * qmake/mkspecs/features/production_build.prf: Added.
1778
1779 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1780
1781         [Qt] GStreamer detection does not work when cross-compiling
1782         https://bugs.webkit.org/show_bug.cgi?id=96608
1783
1784         Reviewed by Kenneth Rohde Christiansen.
1785
1786         When cross-compiling it is not safe to just use system(pkg-config),
1787         because there is a high probability that it will find packages in the
1788         host system instead of in the target one. Instead use qmake's new
1789         packagesExist() function that takes care of this delicate aspect of
1790         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
1791         PKG_CONFIG_LIBDIR accordingly.
1792
1793         * qmake/mkspecs/features/features.prf:
1794
1795 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
1796
1797         [WK2][WTR] More efficient string handling in InjectedBundlePage
1798         https://bugs.webkit.org/show_bug.cgi?id=96609
1799
1800         Reviewed by Kenneth Rohde Christiansen.
1801
1802         Update StringBuilder usage in InjectedBundlePage to follow
1803         the latest recommandations for efficient string handling:
1804         http://trac.webkit.org/wiki/EfficientStrings
1805
1806         This involves using appendLiteral() or appendNumber()
1807         instead of append() whenever possible.
1808
1809         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1810         (WTR::dumpPath):
1811         (WTR::rangeToStr):
1812         (WTR::styleDecToStr):
1813         (WTR::frameToStr):
1814         (WTR::dumpResourceURL):
1815         (WTR):
1816         (WTR::dumpFrameDescriptionSuitableForTestResult):
1817         (WTR::dumpRequestDescriptionSuitableForTestResult):
1818         (WTR::dumpResponseDescriptionSuitableForTestResult):
1819         (WTR::dumpErrorDescriptionSuitableForTestResult):
1820         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1821         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1822         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1823         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1824         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1825         (WTR::InjectedBundlePage::didFinishProgress):
1826         (WTR::dumpFrameScrollPosition):
1827         (WTR::dumpFrameText):
1828         (WTR::dumpDescendantFramesText):
1829         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1830         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1831         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1832         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1833         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1834         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1835         (WTR::InjectedBundlePage::willSendRequestForFrame):
1836         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1837         (WTR::InjectedBundlePage::didFinishLoadForResource):
1838         (WTR::InjectedBundlePage::didFailLoadForResource):
1839         (WTR::InjectedBundlePage::shouldCacheResponse):
1840         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1841         (WTR::InjectedBundlePage::willAddMessageToConsole):
1842         (WTR::InjectedBundlePage::willSetStatusbarText):
1843         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1844         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1845         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1846         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1847         (WTR::InjectedBundlePage::shouldBeginEditing):
1848         (WTR::InjectedBundlePage::shouldEndEditing):
1849         (WTR::InjectedBundlePage::shouldInsertNode):
1850         (WTR::InjectedBundlePage::shouldInsertText):
1851         (WTR::InjectedBundlePage::shouldDeleteRange):
1852         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1853         (WTR::InjectedBundlePage::shouldApplyStyle):
1854         (WTR::InjectedBundlePage::didBeginEditing):
1855         (WTR::InjectedBundlePage::didEndEditing):
1856         (WTR::InjectedBundlePage::didChange):
1857         (WTR::InjectedBundlePage::didChangeSelection):
1858         (WTR::InjectedBundlePage::supportsFullScreen):
1859         (WTR::InjectedBundlePage::enterFullScreenForElement):
1860         (WTR::InjectedBundlePage::exitFullScreenForElement):
1861         (WTR::InjectedBundlePage::beganEnterFullScreen):
1862         (WTR::InjectedBundlePage::beganExitFullScreen):
1863         (WTR::InjectedBundlePage::closeFullScreen):
1864         (WTR::dumpBackForwardListItem):
1865         (WTR::InjectedBundlePage::dumpBackForwardList):
1866
1867 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1868
1869         [Qt][WK2] Memory leaks in Qt's TestRunner
1870         https://bugs.webkit.org/show_bug.cgi?id=96603
1871
1872         Reviewed by Csaba Osztrogonác.
1873
1874         Fix memory leaks in Qt's TestRunner code by adopting WKString
1875         created with WKStringCreateWithUTF8CString().
1876
1877         * WebKitTestRunner/qt/TestControllerQt.cpp:
1878         (WTR::TestController::initializeInjectedBundlePath):
1879         (WTR::TestController::initializeTestPluginDirectory):
1880
1881 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1882
1883         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
1884         https://bugs.webkit.org/show_bug.cgi?id=96506
1885
1886         Reviewed by Dirk Pranke.
1887
1888         Lower the timeout value to 6 seconds for release configuration and 12 seconds
1889         for debug configuration. These are the same values the Chromium port uses.
1890
1891         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
1892         the layout tests under WebKit2 generally) requires more attention and gardening
1893         than what the current effort produces.
1894
1895         The unit test is updated as well to test these changes.
1896
1897         * Scripts/webkitpy/layout_tests/port/gtk.py:
1898         (GtkPort.default_timeout_ms):
1899         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1900         (GtkPortTest.test_default_timeout_ms):
1901         (GtkPortTest.assertLinesEqual):
1902
1903 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
1904
1905         Add SVN mirror handling feature to build.webkit.org
1906         https://bugs.webkit.org/show_bug.cgi?id=85887
1907
1908         Reviewed by Dirk Pranke.
1909
1910         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
1911         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1912         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
1913         (ConfigureBuild.start):
1914         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
1915         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
1916         (Factory.__init__):
1917         (BuildFactory.__init__):
1918         (TestFactory.__init__):
1919         (BuildAndTestFactory.__init__):
1920         (BuildAndPerfTestFactory.__init__):
1921         (BuildAndPerfTestWebKit2Factory.__init__):
1922         (DownloadAndPerfTestFactory.__init__):
1923         (DownloadAndPerfTestWebKit2Factory.__init__):
1924         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
1925         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1926         (SVNMirrorTest):
1927         (SVNMirrorTest.setUp): Load config.json once at startup.
1928         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
1929         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
1930         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
1931         (getLatestSVNRevision): Get the latest SVN revison from the given server.
1932         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
1933                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
1934
1935 2012-09-12  Kangil Han  <kangil.han@samsung.com>
1936
1937         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
1938         https://bugs.webkit.org/show_bug.cgi?id=81606
1939
1940         Reviewed by Tim Horton.
1941
1942         6 seconds is harsh for some jquery test cases.
1943         Therefore, adjust the value to match DumpRenderTree.
1944
1945         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1946         (WTR):
1947
1948 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
1949
1950         [EFL] Support download attribute feature
1951         https://bugs.webkit.org/show_bug.cgi?id=96462
1952
1953         Reviewed by Gyuyoung Kim.
1954
1955         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
1956         and add "download,request" callback to the DumpRenderTree for EFL.
1957
1958         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1959         (DumpRenderTreeChrome::createView):
1960         (DumpRenderTreeChrome::onDownloadRequest):
1961         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1962         (DumpRenderTreeChrome):
1963         * Scripts/webkitperl/FeatureList.pm:
1964
1965 2012-09-12  Stephanie Lewis  <slewis@apple.com>
1966
1967         Reduce parallism on the wk2 testers.
1968         https://bugs.webkit.org/show_bug.cgi?id=95906
1969
1970         Reviewed by Dirk Pranke.
1971
1972         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
1973         resource contention.  Reducing the number of processes alleviates the issue.  
1974
1975         Starting by reducing 25%.
1976
1977         * Scripts/webkitpy/layout_tests/port/mac.py:
1978         (MacPort.default_child_processes):
1979
1980 2012-09-12  Brady Eidson  <beidson@apple.com>
1981
1982         Assert in NetscapePlugin::destroy() with async plugin init
1983         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
1984
1985         Reviewed by Anders Carlsson.
1986
1987         Expose NPN_Invoke to plug-in tests:
1988         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1989         (PluginTest::NPN_Invoke):
1990         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1991         (PluginTest):
1992
1993         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
1994         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
1995         (InvokeDestroysPluginWithinNPP_New):
1996         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
1997         (InvokeDestroysPluginWithinNPP_New::NPP_New):
1998         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1999
2000 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
2001
2002         refactor TestExpectations tokenization slightly in preparation for the new syntax
2003         https://bugs.webkit.org/show_bug.cgi?id=96564
2004
2005         Reviewed by Ojan Vafai.
2006
2007         This change changes how we will tokenize/lex the
2008         TestExpectations files, in preparation for supporting both the
2009         old syntax and the new one. This change by itself should be a
2010         no-op.
2011
2012         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2013         (TestExpectationParser._tokenize_line):
2014         (TestExpectationParser):
2015         (TestExpectationParser._tokenize_line_using_old_format):
2016         (TestExpectationParser._tokenize_line_using_new_format):
2017
2018 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
2019
2020         remove unused testexpectations editing code from webkitpy, garden-o-matic
2021         https://bugs.webkit.org/show_bug.cgi?id=96562
2022
2023         Reviewed by Adam Barth.
2024
2025         This code was prototyped but never fully realized. Removing
2026         until it reanimates :).
2027
2028         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2029         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2030         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
2031         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
2032         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2033         (BuildCoverageExtrapolator.extrapolate_test_configurations):
2034         (GardeningHTTPRequestHandler._run_webkit_patch):
2035         (GardeningHTTPRequestHandler.ping):
2036         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2037         (BuildCoverageExtrapolatorTest.test_extrapolate):
2038         (GardeningServerTest.test_rebaseline_new_port):
2039
2040 2012-09-12  Lucas Forschler  <lforschler@apple.com>
2041
2042         Remove unused bot, apple-xserve-1.
2043         https://bugs.webkit.org/show_bug.cgi?id=96570
2044         
2045         Reviewed by Stephanie Lewis.
2046
2047         * BuildSlaveSupport/build.webkit.org-config/config.json:
2048
2049 2012-09-12  Xan Lopez  <xlopez@igalia.com>
2050
2051         [GTK] We attempt to rebase documentation even if it's not present
2052         https://bugs.webkit.org/show_bug.cgi?id=96553
2053
2054         Reviewed by Martin Robinson.
2055
2056         Do not make the documentation rebase step fatal. This allows make
2057         install to succeed when there's no documentation generated.
2058
2059         * gtk/generate-gtkdoc:
2060
2061 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2062
2063         Respect WEBKITOUTPUTDIR when running EFL tests
2064         https://bugs.webkit.org/show_bug.cgi?id=96528
2065
2066         Reviewed by Dirk Pranke.
2067
2068         Expose user set WEBKITOUTPUTDIR to the web process.
2069
2070         * Scripts/webkitpy/layout_tests/port/driver.py:
2071         (Driver._start): Add WEBKITOUTPUTDIR to the environment
2072         of the web process and its potential jhbuild wrapper.
2073
2074 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
2075
2076         webkitdirs: fix uname version handling for cygwin
2077         https://bugs.webkit.org/show_bug.cgi?id=96436
2078
2079         Reviewed by Jon Honeycutt.
2080
2081         Newer versions of cygwin embed an additional version string
2082         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
2083         Update the code to handle that.
2084
2085         * Scripts/webkitdirs.pm:
2086         (setupAppleWinEnv):
2087
2088 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2089
2090         Regression(r128338): Broke Windows build
2091         https://bugs.webkit.org/show_bug.cgi?id=96537
2092
2093         Unreviewed build fix.
2094
2095         Fix Apple-Win build by allocating array dynamically
2096         since its size is not constant.
2097
2098         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2099         (WTR::stringArrayToJS):
2100
2101 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
2102
2103         [chromium] Add a virtual test suite for fast/hidpi
2104         https://bugs.webkit.org/show_bug.cgi?id=90192
2105
2106         Reviewed by Dirk Pranke.
2107
2108         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
2109         on the hardware accelerated path as the software path.
2110
2111         * DumpRenderTree/chromium/WebPreferences.cpp:
2112         (WebPreferences::applyTo):
2113         * Scripts/webkitpy/layout_tests/port/chromium.py:
2114         (ChromiumPort.virtual_test_suites):
2115
2116 2012-09-12  Adam Klein  <adamk@chromium.org>
2117
2118         [chromium] Add content_browsertests to the flakiness dashboard
2119         https://bugs.webkit.org/show_bug.cgi?id=96535
2120
2121         Reviewed by Ojan Vafai.
2122
2123         * TestResultServer/static-dashboards/dashboard_base.js:
2124
2125 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2126
2127         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
2128         https://bugs.webkit.org/show_bug.cgi?id=96496
2129
2130         Reviewed by Kenneth Rohde Christiansen.
2131
2132         Add implementation for originsWithApplicationCache to
2133         WebKitTestRunner.
2134
2135         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2136         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2137         (WTR::stringArrayToJS):
2138         (WTR):
2139         (WTR::TestRunner::originsWithApplicationCache):
2140         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2141         (TestRunner):
2142
2143 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2144
2145         Fix Qt/Windows build with Python3
2146         https://bugs.webkit.org/show_bug.cgi?id=96473
2147
2148         Reviewed by Csaba Osztrogonác.
2149
2150         In Python 3 print is a real function, so we must use parentheses around
2151         the function parameters. This is backwards compatible with Python 2.
2152
2153         * Scripts/generate-win32-export-forwards:
2154
2155 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2156
2157         Unreviewed trivial build fix for Qt/Windows after bug #96358.
2158
2159         As pointed out by Kevin, we should inject the "set PATH=..." statement
2160         to add the GnuWin32 directory only if that directory actually exists.
2161
2162         * qmake/mkspecs/features/default_post.prf:
2163
2164 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2165
2166         [EFL] [WK2] Memory leaks in TestControllerEfl
2167         https://bugs.webkit.org/show_bug.cgi?id=96525
2168
2169         Reviewed by Kenneth Rohde Christiansen.
2170
2171         Fix memory leaks in EFL's TestRunner code by adopting an allocation
2172         of WKString created with WKStringCreateWithUTF8CString().
2173
2174         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2175         (WTR::TestController::initializeInjectedBundlePath):
2176         (WTR::TestController::initializeTestPluginDirectory):
2177
2178 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2179
2180         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
2181         https://bugs.webkit.org/show_bug.cgi?id=96374
2182
2183         Reviewed by Kenneth Rohde Christiansen.
2184
2185         Implement support for dumpApplicationCacheDelegateCallbacks
2186         and disallowIncreaseForApplicationCacheQuota in
2187         WebKitTestRunner and properly dump the information
2188         expected by the tests.
2189
2190         If the application cache quota is reached for a given
2191         security origin, WebKitTestRunner will reset the quota
2192         to its default value, unless intructed not to via
2193         disallowIncreaseForApplicationCacheQuota().
2194
2195         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2196         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2197         (WTR::InjectedBundlePage::InjectedBundlePage):
2198         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2199         (WTR):
2200         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2201         (InjectedBundlePage):
2202         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2203         (WTR::TestRunner::TestRunner):
2204         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
2205         (WTR):
2206         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2207         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
2208         (TestRunner):
2209         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
2210         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
2211
2212 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
2213
2214         [chromium] remove deprecated and unused sets import from chromium_android driver
2215         https://bugs.webkit.org/show_bug.cgi?id=96485
2216
2217         Reviewed by Dirk Pranke.
2218
2219         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2220
2221 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
2222
2223         Flakiness dashboard doesn't recognize new Chromium Android test builder
2224         https://bugs.webkit.org/show_bug.cgi?id=96523
2225
2226         Reviewed by Ojan Vafai.
2227
2228         Properly return 'ANDROID' as the Chromium platform for Android builders.
2229
2230         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2231         (chromiumPlatform):
2232         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2233         (test):
2234
2235 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2236
2237         [Qt] Build on Windows requires bison/flex in PATH
2238         https://bugs.webkit.org/show_bug.cgi?id=96358
2239
2240         Reviewed by Tor Arne Vestbø.
2241
2242         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
2243         and Linux that is rarely a problem given how easily available the tools are. On Windows however
2244         a separate installation of various GNU tools is required as the operating system doesn't come with
2245         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
2246         the gnuwin32 directory of the qt5.git top-level repository.
2247
2248         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
2249
2250         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
2251         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
2252         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
2253         updated with the new tool.
2254
2255         * Scripts/webkitdirs.pm:
2256         (checkRequiredSystemConfig):
2257         * qmake/mkspecs/features/default_post.prf:
2258
2259 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2260
2261         [Qt] Update build-jsc after r128174
2262
2263         Reviewed by Ossy.
2264
2265         * Scripts/build-jsc:
2266
2267 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2268
2269         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
2270
2271         By hard-coding the names of the targets we defined we ended up just
2272         redefining the previous target when using addStrictSubdirOrderBetween
2273         more than once in a single project file.
2274
2275         We now embed the two base targets into the target names.
2276
2277         Reviewed by Simon Hausmann.
2278
2279         * qmake/mkspecs/features/functions.prf:
2280
2281 2012-09-12  Philippe Liard  <pliard@google.com>
2282
2283         Depend on {base,net} GYP targets rather than {base,net}_java.
2284         https://bugs.webkit.org/show_bug.cgi?id=95690
2285
2286         Reviewed by Adam Barth.
2287
2288         {base,net}_java became 'private' targets on the Chromium side that
2289         clients should not depend on (see
2290         https://chromiumcodereview.appspot.com/10913083/).
2291         This removes a bunch of trailing white spaces additionally in
2292         TestWebkitAPI.gyp (which includes non-trailing white space changes).
2293
2294         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2295         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2296
2297 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2298
2299         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
2300         https://bugs.webkit.org/show_bug.cgi?id=96494
2301
2302         Reviewed by Tor Arne Vestbø.
2303
2304         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
2305         plugin process feature if we don't have NPAPI.
2306
2307         * qmake/mkspecs/features/features.prf:
2308
2309 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2310
2311         Unreviewed, rolling out r128280.
2312         http://trac.webkit.org/changeset/128280
2313         https://bugs.webkit.org/show_bug.cgi?id=96498
2314
2315         it broke compilation on windows debug bot (Requested by loislo
2316         on #webkit).
2317
2318         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2319         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2320         (WTR::InjectedBundlePage::InjectedBundlePage):
2321         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2322         (InjectedBundlePage):
2323         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2324         (WTR::TestRunner::TestRunner):
2325         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2326         (TestRunner):
2327
2328 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2329
2330         [Qt] Make it possible to build with "make release" and "make debug" on Windows
2331         https://bugs.webkit.org/show_bug.cgi?id=96488
2332
2333         Reviewed by Tor Arne Vestbø.
2334
2335         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
2336         because there are no such targets. We want the generated sources to be independent from release
2337         or debug build configurations, so it is sufficient to provide fake debug and release targets that
2338         redirect to the same general-purpose target (first) of creating the derived sources.
2339
2340         * qmake/mkspecs/features/default_post.prf:
2341
2342 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2343
2344         [EFL] Make DumpRenderTree smarter at finding the fonts
2345         http://webkit.org/b/96281
2346
2347         Reviewed by Gyuyoung Kim.
2348
2349         Respect WEBKITOUTPUTDIR and expand the font dir from it.
2350         Use CString consistently.
2351
2352         * DumpRenderTree/efl/FontManagement.cpp:
2353         (buildPath):
2354         (getCoreFontFiles):
2355         (addFontDirectory):
2356         (addFontFiles):
2357         (getCustomBuildDir):
2358         (getPlatformFontsPath):
2359         (addFontsToEnvironment):
2360
2361 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2362
2363         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
2364         https://bugs.webkit.org/show_bug.cgi?id=96374
2365
2366         Reviewed by Kenneth Rohde Christiansen.
2367
2368         Implement support for dumpApplicationCacheDelegateCallbacks
2369         and disallowIncreaseForApplicationCacheQuota in
2370         WebKitTestRunner and properly dump the information
2371         expected by the tests.
2372
2373         If the application cache quota is reached for a given
2374         security origin, WebKitTestRunner will reset the quota
2375         to its default value, unless intructed not to via
2376         disallowIncreaseForApplicationCacheQuota().
2377
2378         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2379         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2380         (WTR::InjectedBundlePage::InjectedBundlePage):
2381         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2382         (WTR):
2383         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2384         (InjectedBundlePage):
2385         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2386         (WTR::TestRunner::TestRunner):
2387         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
2388         (WTR):
2389         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2390         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
2391         (TestRunner):
2392         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
2393         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
2394
2395 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2396
2397         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
2398         https://bugs.webkit.org/show_bug.cgi?id=96388
2399
2400         Reviewed by Kenneth Rohde Christiansen.
2401
2402         Exported TestRunner.workerThreadCount as readonly attribute.
2403
2404         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2405         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
2406         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
2407         (WTR):
2408         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
2409         (TestRunner):
2410
2411 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
2412
2413         [chromium] Consume a user gesture when creating a new view.
2414         https://bugs.webkit.org/show_bug.cgi?id=96373
2415
2416         Reviewed by Adam Barth.
2417
2418         * DumpRenderTree/chromium/WebViewHost.cpp:
2419         (WebViewHost::createView):
2420
2421 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2422
2423         [WK2][WTR] Some of TestRunner special options are not reset before testing
2424         https://bugs.webkit.org/show_bug.cgi?id=96384
2425
2426         Reviewed by Kenneth Rohde Christiansen.
2427
2428         Now values of the following special options are reset:
2429         void setAcceptsEditing(in boolean value);
2430         void setCloseRemainingWindowsWhenComplete(in boolean value);
2431         void setXSSAuditorEnabled(in boolean value);
2432         void setAllowFileAccessFromFileURLs(in boolean value);
2433         void setPluginsEnabled(in boolean value);
2434         void setPopupBlockingEnabled(in boolean value);
2435
2436         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2437         (WTR::InjectedBundle::beginTesting):
2438
2439 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
2440
2441         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
2442         https://bugs.webkit.org/show_bug.cgi?id=96273
2443
2444         Reviewed by Gyuyoung Kim.
2445
2446         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
2447         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
2448
2449         * WebKitTestRunner/CMakeLists.txt:
2450
2451 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
2452
2453         [chromium] rename webkit_resources
2454         https://bugs.webkit.org/show_bug.cgi?id=95874
2455
2456         Reviewed by James Robinson.
2457
2458         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2459
2460 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
2461
2462         [chromium] don't include content shell builders in the garden-o-matic view
2463         https://bugs.webkit.org/show_bug.cgi?id=96418
2464
2465         Reviewed by James Robinson.
2466
2467         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2468
2469 2012-09-11  Adam Klein  <adamk@chromium.org>
2470
2471         Garden-o-matic should ignore a wider variety of warnings in buildbot json
2472         https://bugs.webkit.org/show_bug.cgi?id=96411
2473
2474         Reviewed by Adam Barth.
2475
2476         Previously only the exact string "warning" was treated as a warning
2477         result. This patch treats any string with "warning" as a substring
2478         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
2479
2480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2481         (.):
2482         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2483
2484 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
2485
2486         Restore original value of mock scrollbars enabled in InternalSettings
2487         https://bugs.webkit.org/show_bug.cgi?id=87680
2488
2489         Reviewed by Adam Barth.
2490
2491         Added backup support for mock scrollbars state in
2492         InternalSettings::Backup, and removed support for these
2493         from Qt's DumpRenderTree.
2494
2495         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2496         (WebCore::WebPage::resetSettings):
2497         * DumpRenderTree/qt/TestRunnerQt.cpp:
2498         (TestRunner::setFrameFlatteningEnabled):
2499         * DumpRenderTree/qt/TestRunnerQt.h:
2500         (TestRunner):
2501
2502 2012-09-11  Dan Bernstein  <mitz@apple.com>
2503
2504         Fixed a bug where kill-old-processes failed to kill clang++.
2505
2506         Rubber-stamped by Alexey Proskuryakov.
2507
2508         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
2509         where it is passed as a regular expression to killall.
2510
2511 2012-09-11  Philippe Liard  <pliard@google.com>
2512
2513         Make sure that md5sum is not setup on non-Chromium Android platforms.
2514         https://bugs.webkit.org/show_bug.cgi?id=96393
2515
2516         Reviewed by Adam Barth.
2517
2518         Previously md5sum was setup in ChromiumAndroidDriver's constructor
2519         which is also invoked on non-Chromium Android platforms. The following patch
2520         moves this logic to _startup_test() which is guaranteed to be invoked
2521         only on Android.
2522
2523         This also updates the prompt unit test in chromium_android_unittest.py.
2524
2525         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2526         (ChromiumAndroidDriver.__init__):
2527         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
2528         (ChromiumAndroidDriver._setup_test):
2529
2530 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
2531
2532         [EFL] Rewrite the EFL-related Find modules
2533         https://bugs.webkit.org/show_bug.cgi?id=95237
2534
2535         Reviewed by Kenneth Rohde Christiansen.
2536
2537         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
2538         property and include all the Enlightenment Foundation Libraries
2539         required by the target.
2540         * EWebLauncher/CMakeLists.txt: Ditto.
2541         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2542         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
2543         now that they are not added implicitly.
2544         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
2545         property.
2546         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
2547         property and include all the Enlightenment Foundation Libraries
2548         required by the target.
2549
2550 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2551
2552         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
2553         https://bugs.webkit.org/show_bug.cgi?id=96379
2554
2555         Reviewed by Kenneth Rohde Christiansen.
2556
2557         Add implementation for setApplicationCacheOriginQuota
2558         to WebKitTestRunner.
2559
2560         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2561         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2562         (WTR::TestRunner::setApplicationCacheOriginQuota):
2563         (WTR):
2564         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2565         (TestRunner):
2566
2567 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
2568
2569         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
2570         https://bugs.webkit.org/show_bug.cgi?id=91988
2571
2572         Reviewed by Kenneth Rohde Christiansen.
2573
2574         Regular key events generated by Qt for the tab key fill both
2575         keyCode and keyText, so we should do the same for our fake events.
2576
2577         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2578         (WTR::EventSenderProxy::keyDown):
2579
2580 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2581
2582         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
2583         https://bugs.webkit.org/show_bug.cgi?id=96269
2584
2585         Reviewed by Kenneth Rohde Christiansen.
2586
2587         Exported missing testRunner.setSpatialNavigationEnabled() method.
2588
2589         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2590         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2591         (WTR::InjectedBundle::beginTesting):
2592         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2593         (WTR::TestRunner::setSpatialNavigationEnabled):
2594         (WTR):
2595         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2596         (TestRunner):
2597
2598 2012-09-11  Philippe Liard  <pliard@chromium.org>
2599
2600         Support LayoutTests on non-rooted devices for Chromium Android.
2601         https://bugs.webkit.org/show_bug.cgi?id=95346
2602
2603         Reviewed by Dirk Pranke.
2604
2605         We were requiring root permissions to sync resource files with the
2606         device by comparing host and device files' timestamp after we
2607         synchronized the device and host clocks.
2608         We now rely on md5sum provided by Chromium to handle data files
2609         synchronization.
2610
2611         * Scripts/webkitpy/layout_tests/port/chromium.py:
2612         (ChromiumPort._check_driver_build_up_to_date):
2613         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2614         (ChromiumAndroidDriver.__init__):
2615         (ChromiumAndroidDriver._setup_test):
2616         (ChromiumAndroidDriver._push_executable):
2617         (ChromiumAndroidDriver._push_test_resources):
2618         (ChromiumAndroidDriver._read_prompt):
2619
2620 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2621
2622         [Qt] Fix output paths on Windows
2623
2624         Reviewed by Tor Arne Vestbø.
2625
2626         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
2627         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
2628         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
2629         incorrect here and instead for the calculation we should use forward slashes.
2630
2631         * qmake/mkspecs/features/default_pre.prf:
2632
2633 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2634
2635         [Qt] Fix passing of defines from the build system
2636
2637         We explicitly have to pass -DENABLE_FOO=0 for every single feature
2638         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
2639         will add it's own defaults if the features are not defined.
2640
2641         At some point we might want to run a configure-test to inspect what
2642         Platform.h will do, so we can sync up the build system's view of
2643         the feature-defines with the compile-time situation.
2644
2645         Reviewed by Simon Hausmann.
2646
2647         * qmake/mkspecs/features/functions.prf:
2648
2649 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2650
2651         [Qt] Fix --qt option to build-webkit
2652
2653         Reviewed by Ossy.
2654
2655         * Scripts/webkitdirs.pm:
2656         (buildQMakeProjects):
2657
2658 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2659
2660         [Qt] Add a configure step to the Qt build system
2661
2662         This allows building the Qt port using just 'qmake WebKit.pro'. Using
2663         the build-webkit script is still supported, and will add slightly more
2664         logic to the build, such as detecting the need for clean or incremental
2665         builds.
2666
2667         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
2668         all things related to configuring the build, such as use/have/enable flags,
2669         and these are translated to defines in default_post. Project files should
2670         no longer check contains(DEFINES,...) to detect features, but use the new
2671         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
2672         options have been translated into WEBKIT_CONFIG options as well, and can
2673         be checked using build?().
2674
2675         Reviewed by Simon Hausmann.
2676
2677         * DumpRenderTree/qt/DumpRenderTree.pro:
2678         * MiniBrowser/qt/MiniBrowser.pro:
2679         * QtTestBrowser/QtTestBrowser.pro:
2680         * Scripts/build-webkit:
2681         * Scripts/webkitdirs.pm:
2682         (qtFeatureDefaults):
2683         (buildQMakeProjects):
2684         * Tools.pro:
2685         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2686         * WebKitTestRunner/InjectedBundle/Target.pri:
2687         * WebKitTestRunner/Target.pri:
2688         * qmake/.qmake.cache: Added.
2689         * qmake/configure.pri: Removed.
2690         * qmake/configure.pro: Removed.
2691         * qmake/dump-features: Added.
2692         * qmake/mkspecs/features/configure.prf: Added.
2693         * qmake/mkspecs/features/default_post.prf:
2694         * qmake/mkspecs/features/default_pre.prf:
2695         * qmake/mkspecs/features/features.prf:
2696         * qmake/mkspecs/features/features.pri:
2697         * qmake/mkspecs/features/functions.prf:
2698         * qmake/mkspecs/features/gprof.prf:
2699         * qmake/mkspecs/features/mac/default_pre.prf:
2700         * qmake/mkspecs/features/win32/default_pre.prf:
2701
2702 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2703
2704         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
2705         https://bugs.webkit.org/show_bug.cgi?id=96372
2706
2707         Reviewed by Kenneth Rohde Christiansen.
2708
2709         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
2710
2711         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2712         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2713         (WTR::TestRunner::clearApplicationCacheForOrigin):
2714         (WTR):
2715         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2716         (TestRunner):
2717
2718 2012-09-11  Peter Beverloo  <peter@chromium.org>
2719
2720         Don't ignore .pak files when making an archive for Android
2721         https://bugs.webkit.org/show_bug.cgi?id=96375
2722
2723         Reviewed by Jochen Eisinger.
2724
2725         The .pak files do need to be pushed to the device, which is currently
2726         preventing the layout test runner from correctly pushing all files.
2727
2728         * BuildSlaveSupport/built-product-archive:
2729         (archiveBuiltProduct):
2730
2731 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2732
2733         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
2734         https://bugs.webkit.org/show_bug.cgi?id=96256
2735
2736         Reviewed by Kenneth Rohde Christiansen.
2737
2738         Exported TestRunner::setMinimumTimerInterval() method.
2739
2740         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2741         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2742         (WTR::InjectedBundle::beginTesting):
2743         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2744         (WTR::TestRunner::setMinimumTimerInterval):
2745         (WTR):
2746         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2747         (TestRunner):
2748
2749 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
2750
2751         MediaStream API: add RTCPeerConnection::onnegotiationneeded
2752         https://bugs.webkit.org/show_bug.cgi?id=96097
2753
2754         Reviewed by Adam Barth.
2755
2756         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2757         (MockWebRTCPeerConnectionHandler::addStream):
2758         (MockWebRTCPeerConnectionHandler::removeStream):
2759
2760 2012-09-11  Peter Beverloo  <peter@chromium.org>
2761
2762         Recognize the "--chromium-android" argument in run-webkit-tests
2763         https://bugs.webkit.org/show_bug.cgi?id=96369
2764
2765         Reviewed by Jochen Eisinger.
2766
2767         Chromium for the Android platform cannot determine the platform based on
2768         the host itself, so we'll use the --chromium-android argument as the build
2769         master passes to run-webkit-tests. Make sure the layout test runner
2770         can pick the right port when doing so.
2771
2772         * Scripts/run-webkit-tests:
2773         * Scripts/webkitpy/layout_tests/port/factory.py:
2774         (port_options):
2775
2776 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2777
2778         [QT] Fix build with newer qmake from Qt 5
2779
2780         Rubber-stamped by Tor Arne Vestbø.
2781
2782         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
2783         it with the use of QT_HOST_DATA/mkspecs.
2784         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
2785
2786         * Scripts/webkitdirs.pm:
2787         (builtDylibPathForName):
2788         (qtMakeCommand):
2789
2790 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2791
2792         [Qt] Remove Qt 4 syncqt, no longer needed
2793
2794         Reviewed by Simon Hausmann.
2795
2796         * qmake/syncqt-4.8: Removed.
2797
2798 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
2799
2800         [Qt][WK2] Fix the build with recent Qt5
2801         https://bugs.webkit.org/show_bug.cgi?id=96283
2802
2803         Reviewed by Simon Hausmann.
2804
2805         We should not use deprecated Qt API because doing that results
2806         in build failure since all the deprecated API was disabled
2807         in qtbase (https://codereview.qt-project.org/#change,24890).
2808
2809         * DumpRenderTree/qt/main.cpp:
2810         (main):
2811         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2812         (MiniBrowserApplication::notify):
2813         * MiniBrowser/qt/raw/View.cpp:
2814         (View::exposeEvent):
2815         (main):
2816
2817 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2818
2819         WTR needs an implementation of applicationCacheDiskUsageForOrigin
2820         https://bugs.webkit.org/show_bug.cgi?id=87188
2821
2822         Reviewed by Kenneth Rohde Christiansen.
2823
2824         Add implementation for applicationCacheDiskUsageForOrigin()
2825         in WebKitTestRunner.
2826
2827         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2828         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2829         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
2830         (WTR):
2831         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2832         (TestRunner):
2833
2834 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
2835
2836         Properly expose <legend> elements to ATs
2837         https://bugs.webkit.org/show_bug.cgi?id=84137
2838
2839         Reviewed by Chris Fleizach.
2840
2841         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
2842         the expected platform role, ATK_ROLE_LABEL. Also established the needed
2843         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
2844
2845         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2846         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
2847
2848 2012-09-10  Jer Noble  <jer.noble@apple.com>
2849
2850         Unreviewed; rolling out r128081.
2851         http://trac.webkit.org/changeset/128081
2852         https://bugs.webkit.org/show_bug.cgi?id=96134
2853
2854         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
2855
2856         * DumpRenderTree/TestRunner.cpp:
2857         (TestRunner::TestRunner):
2858         (TestRunner::staticFunctions):
2859         * DumpRenderTree/TestRunner.h:
2860         (TestRunner):
2861         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2862         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2863         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2864         (WTR::InjectedBundlePage::InjectedBundlePage):
2865         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2866         (InjectedBundlePage):
2867         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2868         (WTR::TestRunner::TestRunner):
2869         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2870         (TestRunner):
2871
2872 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2873
2874         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
2875         https://bugs.webkit.org/show_bug.cgi?id=96205
2876
2877         Reviewed by Tony Chang.
2878
2879         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
2880         internally, which means that it would support only 1 TestExpectations file per port. This
2881         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
2882         and efl-wk1 -> efl).
2883
2884         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
2885         instead so that all the ports TestExpectations are recognized. The ports are also
2886         constructed twice, with "webkit_test_runner" option set to True and False so that we
2887         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
2888
2889         * Scripts/webkitpy/style/checkers/test_expectations.py:
2890         (TestExpectationsChecker._determine_port_from_expectations_path):
2891         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
2892         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2893
2894 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
2895
2896         [WTR] Generated source files should include config.h
2897         https://bugs.webkit.org/show_bug.cgi?id=96254
2898
2899         Reviewed by Benjamin Poulain.
2900
2901         Current coding style has encouraged to include config.h at the first position,
2902         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
2903         this rule.
2904         Therefore, this patch added it.
2905
2906         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2907         (_generateImplementationFile):
2908
2909 2012-09-10  Rick Byers  <rbyers@chromium.org>
2910
2911         Add handling of new GestureTapCancel in DRT
2912         
2913         https://bugs.webkit.org/show_bug.cgi?id=96183
2914
2915         Reviewed by Adam Barth.
2916
2917         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2918         (TestWebPlugin::handleInputEvent):
2919
2920 2012-09-10  Brady Eidson  <beidson@apple.com>
2921
2922         Javascript in foreground tabs should not wait synchronously for plug-ins to load
2923         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
2924
2925         Reviewed by Geoff Garen.
2926
2927         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
2928
2929         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
2930         (PluginObject):
2931         (SlowNPPNew::PluginObject::PluginObject):
2932         (SlowNPPNew::PluginObject::~PluginObject):
2933         (SlowNPPNew::PluginObject::hasProperty):
2934         (SlowNPPNew::PluginObject::getProperty):
2935         (SlowNPPNew::NPP_GetValue):
2936         (SlowNPPNew):
2937
2938 2012-09-10  Tim Horton  <timothy_horton@apple.com>
2939
2940         WKTR often reports an unresponsive WebProcess on Mac bots
2941         https://bugs.webkit.org/show_bug.cgi?id=95906
2942
2943         Reviewed by Dan Bernstein.
2944
2945         Attempt to work around resource contention issues by increasing the NRWT
2946         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
2947
2948         * Scripts/webkitpy/layout_tests/port/base.py:
2949         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
2950         * WebKitTestRunner/TestController.cpp:
2951         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
2952
2953 2012-09-07  Jer Noble  <jer.noble@apple.com>
2954
2955         <audio> and <video> should send Do Not Track when appropriate
2956         https://bugs.webkit.org/show_bug.cgi?id=96134
2957
2958         Reviewed by Eric Carlson.
2959
2960         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
2961         WTR. Add FrameLoaderClient client methods for retrieving that value.
2962
2963         * DumpRenderTree/TestRunner.cpp:
2964         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
2965         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
2966         * DumpRenderTree/TestRunner.h:
2967         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
2968         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2969         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2970         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
2971             Pass the question on to the TestRunner.
2972         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2973         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2974         (WTR::InjectedBundlePage::InjectedBundlePage):
2975             Add the setShouldSendDoNotTrackHTTPHeader client function.
2976         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
2977             Pass the question on to the TestRunner.
2978         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2979         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2980         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2981         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2982         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
2983
2984 2012-09-10  Ojan Vafai  <ojan@chromium.org>
2985
2986         Make EFL bots work on the flakiness dashboard
2987         https://bugs.webkit.org/show_bug.cgi?id=96164
2988
2989         Reviewed by Tony Chang.
2990
2991         Also, update outdated unittests that had started failing.
2992
2993         * TestResultServer/static-dashboards/builders.js:
2994         (isWebkitTestRunner):
2995         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2996         (nonChromiumPlatform):
2997         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2998         (test):
2999
3000 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
3001
3002         [chromium] MediaStream API: Remove the Descriptor postfix
3003         https://bugs.webkit.org/show_bug.cgi?id=96268
3004
3005         Reviewed by Adam Barth.
3006
3007         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
3008         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
3009
3010         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3011         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3012         (MockWebRTCPeerConnectionHandler::createOffer):
3013         (MockWebRTCPeerConnectionHandler::createAnswer):
3014         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3015         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3016         (MockWebRTCPeerConnectionHandler::localDescription):
3017         (MockWebRTCPeerConnectionHandler::remoteDescription):
3018         (MockWebRTCPeerConnectionHandler::addICECandidate):
3019         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3020         (MockWebRTCPeerConnectionHandler):
3021
3022 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
3023
3024         [Gtk] failure to build jhbuild dependencies with cups 1.6
3025         https://bugs.webkit.org/show_bug.cgi?id=95991
3026
3027         Reviewed by Gustavo Noronha Silva.
3028
3029         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
3030         building with cups >= 1.6 [GNOME #670373].
3031
3032         * gtk/jhbuild.modules:
3033
3034 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
3035
3036         [EFL][DRT] Encoding issue in printed console messages
3037         https://bugs.webkit.org/show_bug.cgi?id=96263
3038
3039         Reviewed by Kenneth Rohde Christiansen.
3040
3041         Correctly handle CONSOLE messages that contain non-ascii
3042         characters in EFL's DRT. We need to use String::fromUTF8()
3043         to construct a WTF::String from a raw string.
3044
3045         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3046         (onConsoleMessage):
3047
3048 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3049
3050         [WK2][WTR] User style sheet location should be reset before each test
3051         https://bugs.webkit.org/show_bug.cgi?id=96262
3052
3053         Reviewed by Kenneth Rohde Christiansen.
3054
3055         User style sheet location is reset before each test now.
3056
3057         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3058         (WTR::InjectedBundle::beginTesting):
3059
3060 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
3061
3062         Fix build of WTR with Qt on Windows
3063         https://bugs.webkit.org/show_bug.cgi?id=96249
3064
3065         Reviewed by Kenneth Rohde Christiansen.
3066
3067         Windows loves to define min and max as macros, which beautifully
3068         clashes in many places where min and max are used as variable or method
3069         names. It can be convinced not to do this when min and max are already
3070         define as macros (expanding to themselves). We have this kind of
3071         workaround in config.h files all over WebKit and as it turns out when
3072         building WTR with Qt on Windows we do end up with such a clash. Therefore
3073         we need the same workaround.
3074
3075         * WebKitTestRunner/config.h:
3076
3077 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
3078
3079         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
3080         https://bugs.webkit.org/show_bug.cgi?id=95936
3081
3082         Reviewed by Kenneth Rohde Christiansen.
3083
3084         Enable interactive form validation setting in WebKitTestRunner as
3085         we are currently doing in DumpRenderTree. This is needed for some
3086         tests to pass.
3087
3088         * WebKitTestRunner/TestController.cpp:
3089         (WTR::TestController::resetStateToConsistentValues):
3090
3091 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
3092
3093         Clean up the code in XvfbDriver
3094         https://bugs.webkit.org/show_bug.cgi?id=96202
3095
3096         Reviewed by Philippe Normand.
3097
3098         Changes:
3099         - Remove unneeded imports,
3100         - assign the _lock_file member variable when the display number is determined,
3101         - no need for parentheses around a single string format argument,
3102         - use FileSystem.exists method when checking if lock file is present as it
3103         makes the intention much more clearer.
3104
3105         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3106         (XvfbDriver._start):
3107         (XvfbDriver.stop):
3108
3109 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
3110
3111         Make the String initialization on the function side of String::number()
3112         https://bugs.webkit.org/show_bug.cgi?id=95940
3113
3114         Reviewed by Benjamin Poulain.
3115
3116         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
3117         (testBoundaries):
3118         (testNumbers):
3119
3120 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
3121
3122         [WK2] expose element rect for color input type
3123         https://bugs.webkit.org/show_bug.cgi?id=91664
3124
3125         Reviewed by Simon Hausmann.
3126
3127         Update the QML logic in MiniBrowser to take advantage of this.
3128         The picker size is now hardcoded and we try to place it below the
3129         input element if possible.
3130
3131         * MiniBrowser/qt/qml/ColorChooser.qml:
3132
3133 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
3134
3135         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
3136         https://bugs.webkit.org/show_bug.cgi?id=95329
3137
3138         Reviewed by Kenneth Rohde Christiansen.
3139
3140         Explicitely disable TabToLinks setting in WebKitTestRunner.
3141         Tests override the "WebKitTabToLinksPreferenceKey" preference
3142         to enable it.
3143
3144         * WebKitTestRunner/TestController.cpp:
3145         (WTR::TestController::resetStateToConsistentValues):
3146
3147 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
3148
3149         webkit.py gdb pretty printer can't print CString
3150         https://bugs.webkit.org/show_bug.cgi?id=96068
3151
3152         Reviewed by Tony Chang.
3153
3154         Update WTFCStringPrinter to follow r126191.
3155
3156         * gdb/webkit.py:
3157         (WTFCStringPrinter.to_string):
3158
3159 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
3160
3161         Rename the ustring() accessor to string()
3162         https://bugs.webkit.org/show_bug.cgi?id=95919
3163
3164         Reviewed by Geoffrey Garen.
3165
3166         Update EFL's DRT.
3167
3168         Fix some string conversion that have been made useless
3169         with recent changes.
3170
3171         * DumpRenderTree/efl/EventSender.cpp:
3172         (keyPadNameFromJSValue):
3173         (keyNameFromJSValue):
3174         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3175         (TestRunner::queueLoad):
3176         (TestRunner::addOriginAccessWhitelistEntry):
3177         (TestRunner::removeOriginAccessWhitelistEntry):
3178         (TestRunner::setUserStyleSheetLocation):
3179         (TestRunner::setValueForUser):
3180         (TestRunner::elementDoesAutoCompleteForElementWithId):
3181         (TestRunner::execCommand):
3182         (TestRunner::findString):
3183         (TestRunner::isCommandEnabled):
3184         (TestRunner::clearApplicationCacheForOrigin):
3185         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3186         (TestRunner::pauseAnimationAtTimeOnElementWithId):
3187         (TestRunner::pauseTransitionAtTimeOnElementWithId):
3188         (toInt):
3189         (TestRunner::overridePreference):
3190         (TestRunner::addUserScript):
3191         (TestRunner::addUserStyleSheet):
3192         (TestRunner::evaluateInWebInspector):
3193         (TestRunner::evaluateScriptInIsolatedWorld):
3194         (TestRunner::setTextDirection):
3195         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3196         (LoadItem::invoke):
3197         (LoadHTMLStringItem::invoke):
3198         (ScriptItem::invoke):
3199
3200 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
3201
3202         Extend third-party storage blocking API to optionally allow blocking all storage
3203         https://bugs.webkit.org/show_bug.cgi?id=95915
3204
3205         Reviewed by Brady Eidson.
3206
3207         Modified API test to use new revised API.
3208
3209         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3210         (TestWebKitAPI::TEST):
3211
3212 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
3213
3214         AX: WebCore accessibility roles should be cross-platform
3215         https://bugs.webkit.org/show_bug.cgi?id=94870
3216
3217         Reviewed by Chris Fleizach.
3218
3219         Add debug strings to Chromium for new accessibility roles.
3220
3221         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3222         (roleToString):
3223
3224 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
3225
3226         AX: Chromium needs access to canvasHasFallbackContent
3227         https://bugs.webkit.org/show_bug.cgi?id=96124
3228
3229         Reviewed by Chris Fleizach.
3230
3231         Distinguish between canvas roles with and without fallback
3232         content on Chromium.
3233
3234         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3235         (getRole):
3236
3237 2012-09-07  Ojan Vafai  <ojan@chromium.org>
3238
3239         Handle non-existant TestExpectations files gracefully
3240         https://bugs.webkit.org/show_bug.cgi?id=96149
3241
3242         Reviewed by Eric Seidel.
3243
3244         Even when we get rid of Skipped files, we shouldn't have each port
3245         require a TestExpectations file for each platform if it doesn't
3246         need one.
3247
3248         * Scripts/webkitpy/layout_tests/port/base.py:
3249         (Port.expectations_dict):
3250         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3251         (PortTest.test_nonexistant_expectations):
3252
3253 2012-09-07  Tony Chang  <tony@chromium.org>
3254
3255         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
3256         https://bugs.webkit.org/show_bug.cgi?id=96136
3257
3258         Reviewed by Ojan Vafai.
3259
3260         When we renamed the file to TestExpectations, it was no longer considered a text file so
3261         it was no longer being checked. Since then, test_expectations_overrides() has been removed
3262         from the port object, so I've removed that from the check. I'm not sure what it was
3263         supposed to do.
3264
3265         * Scripts/webkitpy/style/checker.py:
3266         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
3267         * Scripts/webkitpy/style/checkers/test_expectations.py:
3268         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
3269         (TestExpectationsChecker.check): Remove overrides param.
3270         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3271         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
3272
3273 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3274
3275         [EFL] Use same default minimum logical font size in DRT and WTR
3276         https://bugs.webkit.org/show_bug.cgi?id=96116
3277
3278         Reviewed by Martin Robinson.
3279
3280         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3281         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
3282         logical font size to 9 to match the value used in WTR.
3283         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3284         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
3285         logical font size to 9 (default value in WK2)
3286
3287 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
3288
3289         MediaStream API: add RTCPeerConnection::createAnswer
3290         https://bugs.webkit.org/show_bug.cgi?id=96092
3291
3292         Reviewed by Adam Barth.
3293
3294         Expanding and enhancing MockWebRTCPeerConnectionHandler.
3295
3296         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3297         (MockWebRTCPeerConnectionHandler::createOffer):
3298         (MockWebRTCPeerConnectionHandler::createAnswer):
3299         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3300         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3301         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3302         (MockWebRTCPeerConnectionHandler):
3303
3304 2012-09-07  Dean Jackson  <dino@apple.com>
3305
3306         Unreviewed changes to watchlist.
3307
3308         - Add new WebGL and Filters definitions
3309         - Add myself to OpenGL bugs
3310
3311         * Scripts/webkitpy/common/config/watchlist:
3312
3313 2012-09-07  Peter Beverloo  <peter@chromium.org>
3314
3315         Actually trigger the Android Tester
3316         https://bugs.webkit.org/show_bug.cgi?id=96118
3317
3318         Reviewed by Adam Barth.
3319
3320         * BuildSlaveSupport/build.webkit.org-config/config.json:
3321
3322 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
3323
3324         New time input needs accessibility
3325         https://bugs.webkit.org/show_bug.cgi?id=96032
3326
3327         Reviewed by Chris Fleizach.
3328
3329         Add support for valueDescription for testing.
3330
3331         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3332         (getValueDescription):
3333         (AccessibilityUIElement::AccessibilityUIElement):
3334         (AccessibilityUIElement::valueDescriptionGetterCallback):
3335         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
3336         (AccessibilityUIElement):
3337
3338 2012-09-07  Peter Beverloo  <peter@chromium.org>
3339
3340         Add the google-android-tests build slave to the master's config
3341         https://bugs.webkit.org/show_bug.cgi?id=96113
3342
3343         Reviewed by Csaba Osztrogonác.
3344
3345         * BuildSlaveSupport/build.webkit.org-config/config.json:
3346
3347 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3348
3349         [WK2] [EFL] Set theme for WebKit2 API test runner
3350         https://bugs.webkit.org/show_bug.cgi?id=96100
3351
3352         Reviewed by Kenneth Rohde Christiansen.
3353
3354         Set the theme generated by the build for the WebKit2 API test runner.
3355
3356         * TestWebKitAPI/PlatformEfl.cmake:
3357         * TestWebKitAPI/efl/PlatformWebView.cpp:
3358         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3359
3360 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
3361
3362         Unreviewed. Add Gábor Ballabás as contributor.
3363
3364         * Scripts/webkitpy/common/config/committers.py:
3365
3366 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
3367
3368         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
3369         https://bugs.webkit.org/show_bug.cgi?id=96078
3370
3371         Reviewed by Tor Arne Vestbø.
3372
3373         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
3374
3375         * qmake/mkspecs/features/default_pre.prf:
3376
3377 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3378
3379         [EFL] Add TestExpectations file for efl-wk1
3380         https://bugs.webkit.org/show_bug.cgi?id=96019
3381
3382         Reviewed by Gyuyoung Kim.
3383
3384         Update TestExpectations cascading for EFL port
3385         so that we use efl-wk1 -> efl search paths
3386         for WebKit1 EFL.
3387
3388         * Scripts/webkitpy/layout_tests/port/efl.py:
3389         (EflPort._search_paths):
3390
3391 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
3392
3393         [NRWT] XvfbDriver should stop the Xvfb more aggressively
3394         https://bugs.webkit.org/show_bug.cgi?id=95097
3395
3396         Reviewed by Dirk Pranke.
3397
3398         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
3399         terminating the process does not always work as expected, leading to timeouts
3400         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
3401         as it's not removed by the killed Xvfb process.
3402
3403         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
3404         is tested in different circumstances - whether pixel tests are enabled or not,
3405         with an arbitrary worker number or with an Xorg process already running on the system.
3406         The stopping of the driver is tested by checking that the Xvfb process is truly killed
3407         and then set to None.
3408
3409         * BuildSlaveSupport/kill-old-processes:
3410         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
3411         is left running, potentially clogging up a display at a certain position.
3412         * Scripts/webkitpy/common/system/executive_mock.py:
3413         (MockExecutive.__init__):
3414         The _running_pids is now a dictionary with process names as keys and pids
3415         as values.
3416         (MockExecutive.check_running_pid):
3417         Check whether the passed-in pid is in the _running_pids dictionary's values.
3418         (MockExecutive):
3419         (MockExecutive.running_pids):
3420         This method returns the list of all the process pids of which the name passes
3421         through the process_name_filter.
3422         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3423         Use the Executive object of the port's host to check for running pids and open
3424         new subprocesses or kill them throughout the class.
3425         (XvfbDriver._start):
3426         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
3427         start the server process after it's created.
3428         (XvfbDriver.stop):
3429         Now kills the Xvfb process instead of terminating it and waiting for it to close.
3430         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
3431         (XvfbDriverTest):
3432         (XvfbDriverTest.make_driver):
3433         (XvfbDriverTest.assertDriverStartSuccessful):
3434         (XvfbDriverTest.test_start_no_pixel_tests):
3435         (XvfbDriverTest.test_start_pixel_tests):
3436         (XvfbDriverTest.test_start_arbitrary_worker_number):
3437         (XvfbDriverTest.test_start_existing_xorg_process):
3438         (XvfbDriverTest.test_stop):
3439         (XvfbDriverTest.test_stop.FakeXvfbProcess):
3440
3441 2012-09-06  Peter Beverloo  <peter@chromium.org>
3442
3443         Introduce the Chromium Android Release (Tests) bot
3444         https://bugs.webkit.org/show_bug.cgi?id=95980
3445
3446         Reviewed by Adam Barth.
3447
3448         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
3449         which will be running layout tests on actual Android devices. Right now,
3450         four Galaxy Nexus phones are attached.
3451
3452         * BuildSlaveSupport/build.webkit.org-config/config.json:
3453
3454 2012-09-06  James Robinson  <jamesr@chromium.org>
3455
3456         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
3457         https://bugs.webkit.org/show_bug.cgi?id=96007
3458
3459         Reviewed by Adrienne Walker.
3460
3461         Fixes initialization / settings code to use WebCompositorSupport.
3462
3463         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3464         (main):
3465         * DumpRenderTree/chromium/TestShell.cpp:
3466         (TestShell::initialize):
3467         (TestShell::setPerTilePaintingEnabled):
3468
3469 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3470
3471         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
3472         https://bugs.webkit.org/show_bug.cgi?id=95995
3473
3474         Reviewed by Kenneth Rohde Christiansen.
3475
3476         Provide proper implementation for PlatformWebView::windowFrame()
3477         in EFL's WebKitTestRunner.
3478
3479         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3480         (WTR::PlatformWebView::windowFrame):
3481
3482 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
3483
3484         Fix WTF.Lrint on 32-bit platforms
3485         https://bugs.webkit.org/show_bug.cgi?id=96003
3486
3487         Reviewed by Benjamin Poulain.
3488
3489         Fixed failing WTF.Lrint test on 32-bit platforms.
3490
3491         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3492         (TestWebKitAPI::TEST):
3493
3494 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
3495
3496         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3497         https://bugs.webkit.org/show_bug.cgi?id=95839
3498
3499         Reviewed by Adam Barth.
3500
3501         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3502         up the task definitions a bit. There was no need to have them in the header file.
3503
3504         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3505         (RTCSessionDescriptionRequestSuccededTask):
3506         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3507         (RTCSessionDescriptionRequestFailedTask):
3508         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3509         (RTCVoidRequestTask):
3510         (RTCVoidRequestTask::RTCVoidRequestTask):
3511         (MockWebRTCPeerConnectionHandler::createOffer):
3512         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3513         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3514         (MockWebRTCPeerConnectionHandler::localDescription):
3515         (MockWebRTCPeerConnectionHandler::remoteDescription):
3516         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3517         (MockWebRTCPeerConnectionHandler):
3518
3519 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3520
3521         [Qt] Fix build on Mac OS X 10.6
3522         https://bugs.webkit.org/show_bug.cgi?id=95200
3523
3524         Reviewed by Tor Arne Vestbø.
3525
3526         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
3527         10.7 and newer.
3528
3529         * qmake/mkspecs/features/features.prf:
3530
3531 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3532
3533         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
3534         https://bugs.webkit.org/show_bug.cgi?id=95973
3535
3536         Reviewed by Kenneth Rohde Christiansen.
3537
3538         Correctly map "addSelectionKey" to "Control" modifier
3539         in WKTR's EventSender on other OSes than Mac OS X,
3540         instead of mapping it to the "Meta" modifier.
3541
3542         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3543         (WTR::parseModifier):
3544
3545 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
3546
3547         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
3548         https://bugs.webkit.org/show_bug.cgi?id=95710
3549
3550         Reviewed by Dirk Pranke.
3551
3552         The stdout / stderr output can be None so make sure
3553         we won't raise an exception in this case.
3554
3555         * Scripts/webkitpy/layout_tests/port/driver.py:
3556         (Driver.run_test):
3557
3558 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3559
3560         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
3561         https://bugs.webkit.org/show_bug.cgi?id=95849
3562
3563         Reviewed by Kenneth Rohde Christiansen.
3564
3565         Sanitize URLs passed by the user as program
3566         argument or typed in the URL bar in order to
3567         be more tolerant.
3568
3569         * EWebLauncher/CMakeLists.txt:
3570         * EWebLauncher/main.c:
3571         (main):
3572         * EWebLauncher/url_bar.c:
3573         (_url_bar_url_get_with_protocol):
3574         (on_urlbar_key_down):
3575         * EWebLauncher/url_utils.c: Added.
3576         (has_scheme):
3577         (url_from_user_input): Add utility function to construct a
3578         URL from user input.
3579         * EWebLauncher/url_utils.h: Added.
3580         * MiniBrowser/efl/CMakeLists.txt:
3581         * MiniBrowser/efl/main.c:
3582         (main):
3583
3584 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3585
3586         [Qt] Various small Windows / MSVC build fixes
3587         https://bugs.webkit.org/show_bug.cgi?id=95934
3588
3589         Reviewed by Kenneth Rohde Christiansen.
3590
3591         setFocus takes a boolean as argument: Don't try to implicitly convert
3592         an enum to a boolean, MSVC doesn't like that. The intent here is to
3593         enable focus, so just pass true.
3594
3595         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3596         (WTR::PlatformWebView::focus):
3597
3598 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3599
3600         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
3601         https://bugs.webkit.org/show_bug.cgi?id=95965
3602
3603         Reviewed by Tor Arne Vestbø.
3604
3605         Add ANGLE as a static library module to the Qt WebKit build system.
3606
3607         * qmake/mkspecs/features/default_post.prf:
3608         * qmake/mkspecs/modules/angle.prf: Added.
3609
3610 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
3611
3612         [WK2] Make [Qt]ViewportHandler cross platform
3613         https://bugs.webkit.org/show_bug.cgi?id=91257
3614
3615         Reviewed by Kenneth Rohde Christiansen.
3616
3617         Remove initial scale from viewport info item since it is
3618         set to -1 after applied thus it does not hold any valuable
3619         information.
3620
3621         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3622
3623 2012-09-05  Tony Chang  <tony@chromium.org>
3624
3625         [chromium] Remove dependency on webkit_user_agent
3626         https://bugs.webkit.org/show_bug.cgi?id=95886
3627
3628         Reviewed by Adam Barth.
3629
3630         The code isn't used by DumpRenderTree.
3631
3632         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3633
3634 2012-09-05  Rick Byers  <rbyers@chromium.org>
3635
3636         Update chromium DumpRenderTree for new WebGestureEvent fields
3637         https://bugs.webkit.org/show_bug.cgi?id=95573
3638
3639         Reviewed by James Robinson.
3640
3641         Update EventSender to write gesture details into the appropriate
3642         type-specific WebGestureEvent fields.
3643         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
3644         (EventSender::gestureEvent):
3645         (EventSender::gestureFlingStart):
3646
3647 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
3648
3649         NRWT lies about the number of tests that it's skipping when used with --repeat-each
3650         https://bugs.webkit.org/show_bug.cgi?id=95789
3651
3652         Reviewed by Ojan Vafai.
3653
3654         Fix miscalculation in log message.
3655
3656         * Scripts/webkitpy/layout_tests/views/printing.py:
3657         (Printer.print_found):
3658
3659 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
3660
3661         Unreviewed, rolling out r127612, r127660, and r127664.
3662         http://trac.webkit.org/changeset/127612
3663         http://trac.webkit.org/changeset/127660
3664         http://trac.webkit.org/changeset/127664
3665         https://bugs.webkit.org/show_bug.cgi?id=95920
3666
3667         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3668         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3669         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3670         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3671         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3672         (MockWebRTCPeerConnectionHandler::createOffer):
3673         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3674         (MockWebRTCPeerConnectionHandler):
3675         (SuccessCallbackTask):
3676         (FailureCallbackTask):
3677
3678 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3679
3680         Ignore-metrics includes scroll offsets.
3681         https://bugs.webkit.org/show_bug.cgi?id=95845
3682
3683         Reviewed by Dirk Pranke.
3684
3685         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
3686
3687         * Scripts/old-run-webkit-tests:
3688         (stripMetrics):
3689         * Scripts/webkitpy/layout_tests/port/driver.py:
3690         (DriverOutput):
3691
3692 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
3693
3694         Unreviewed test fix.
3695
3696         Including a plugin source file into the build that was added in r127595.
3697
3698         * GNUmakefile.am:
3699
3700 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
3701
3702         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3703         https://bugs.webkit.org/show_bug.cgi?id=95839
3704
3705         Reviewed by Adam Barth.
3706
3707         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3708         up the task definitions a bit. There was no need to have them in the header file.
3709
3710         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3711         (RTCSessionDescriptionRequestSuccededTask):
3712         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3713         (RTCSessionDescriptionRequestFailedTask):
3714         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3715         (RTCVoidRequestTask):
3716         (RTCVoidRequestTask::RTCVoidRequestTask):
3717         (MockWebRTCPeerConnectionHandler::createOffer):
3718         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3719         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3720         (MockWebRTCPeerConnectionHandler::localDescription):
3721         (MockWebRTCPeerConnectionHandler::remoteDescription):
3722         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3723         (MockWebRTCPeerConnectionHandler):
3724
3725 2012-09-05  Kangil Han  <kangil.han@samsung.com>
3726
3727         [EFL] Remove '+=' usage in String
3728         https://bugs.webkit.org/show_bug.cgi?id=95808
3729
3730         Reviewed by Benjamin Poulain.
3731
3732         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
3733
3734         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3735         (descriptionSuitableForTestResult):
3736
3737 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3738
3739         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
3740         https://bugs.webkit.org/show_bug.cgi?id=95842
3741
3742         Reviewed by Kenneth Rohde Christiansen.
3743
3744         Provide proper implementation for TestRunner::pathToLocalResource()
3745         in EFL WKTR, identical to the one for DumpRenderTree.
3746
3747         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
3748         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
3749         are found my WebKitTestRunner.
3750
3751         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3752         (WTR::TestRunner::pathToLocalResource):
3753
3754 2012-09-05  Brady Eidson  <beidson@apple.com>
3755
3756         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
3757         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
3758
3759         Reviewed by Andy Estes.
3760
3761         Add a plug-in that always fails to initialize:
3762         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
3763         (NPPNewFails):
3764         (NPPNewFails::NPPNewFails):
3765         (NPPNewFails::NPP_New):
3766
3767         Add it to all the project files:
3768         * DumpRenderTree/DumpRenderTree.gypi:
3769         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3770         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3771         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3772         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3773
3774 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3775
3776         [Qt] Fix makefile race condition between derived sources and target
3777
3778         r121966 removed too much of the old qmake logic, including the rule
3779         that ensured that qmake_all would not trigger dual runs of qmake --
3780         one of the derived sources -qmake-all rule, and one for making the
3781         derived sources.
3782
3783         We now follow a similar pattern as before, by introducing a custom
3784         target that explicitly depends on the derived sources' qmake-all before
3785         doing a manual run of make. That ensures a single qmake run for the derived
3786         sources.
3787
3788         https://bugs.webkit.org/show_bug.cgi?id=93847
3789
3790         Reviewed by Csaba Osztrogonác.
3791
3792         * qmake/mkspecs/features/functions.prf:
3793
3794 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3795
3796         WKTR doesn't implement dumpWillCacheResponse()
3797         https://bugs.webkit.org/show_bug.cgi?id=94607
3798
3799         Reviewed by Kenneth Rohde Christiansen.
3800
3801         Define shouldCacheResponse() callback in resource
3802         load client and provide implementation for
3803         dumpWillCacheResponse() in WebKitTestRunner.
3804
3805         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3806         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3807         (WTR::InjectedBundlePage::InjectedBundlePage):
3808         (WTR::InjectedBundlePage::shouldCacheResponse):
3809         (WTR):
3810         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3811         (InjectedBundlePage):
3812         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3813         (WTR::TestRunner::TestRunner):
3814         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3815         (WTR::TestRunner::dumpWillCacheResponse):
3816         (WTR::TestRunner::shouldDumpWillCacheResponse):
3817         (TestRunner):
3818
3819 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3820
3821         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
3822         https://bugs.webkit.org/show_bug.cgi?id=92735
3823
3824         Reviewed by Hajime Morita.
3825
3826         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
3827
3828         * DumpRenderTree/TestRunner.cpp:
3829         (TestRunner::staticFunctions):
3830         * DumpRenderTree/TestRunner.h:
3831         (TestRunner):
3832         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3833         (TestRunner::addUserStyleSheet):
3834         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3835         (DRTTestRunner::DRTTestRunner):
3836         (DRTTestRunner::hasCustomPageSizeStyle):
3837         * DumpRenderTree/chromium/DRTTestRunner.h:
3838         (DRTTestRunner):
3839         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3840         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3841         * DumpRenderTree/mac/TestRunnerMac.mm:
3842         * DumpRenderTree/qt/TestRunnerQt.cpp:
3843         (TestRunner::evaluateScriptInIsolatedWorld):
3844         * DumpRenderTree/qt/TestRunnerQt.h:
3845         (TestRunner):
3846         * DumpRenderTree/win/TestRunnerWin.cpp:
3847         * DumpRenderTree/wx/TestRunnerWx.cpp:
3848         (TestRunner::abortModal):
3849         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3850         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3851         (WTR):
3852         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3853         (TestRunner):
3854
3855 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
3856
3857         [Qt] Automate the use of AllInOne files in the Qt build
3858         https://bugs.webkit.org/show_bug.cgi?id=95837
3859
3860         Reviewed by Tor Arne Vestbø.
3861
3862         New feature file that implements the all-in-one file automation by
3863         adding the requested all-in-one files to SOURCES and removing the files
3864         it includes from SOURCES.
3865
3866         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
3867
3868 2012-09-04  Tim Horton  <timothy_horton@apple.com>
3869
3870         Have NRWT log more output when crash logs are missing
3871         https://bugs.webkit.org/show_bug.cgi?id=95814
3872
3873         Reviewed by Dan Bernstein.
3874
3875         Log the stderr and stdout of the test, in order to provide slightly more
3876         context when the WebProcess times out while running tests.
3877
3878         * Scripts/webkitpy/layout_tests/port/driver.py:
3879         (Driver.run_test):
3880
3881 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3882
3883         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
3884         https://bugs.webkit.org/show_bug.cgi?id=95770
3885
3886         Reviewed by Adam Barth.
3887
3888         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3889         (ChromiumAndroidDriver.__init__):
3890         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
3891         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
3892         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
3893         (ChromiumAndroidDriver._push_executable):
3894         (ChromiumAndroidDriver._push_fonts):
3895         (ChromiumAndroidDriver._push_test_resources):
3896         (ChromiumAndroidDriver._run_adb_command):
3897         (ChromiumAndroidDriver._get_last_stacktrace):
3898         (ChromiumAndroidDriver._get_crash_log):
3899         (ChromiumAndroidDriver._start):
3900         (ChromiumAndroidDriver._start_once):
3901         (ChromiumAndroidDriver._start_once.deadlock_detector):
3902         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3903         (ChromiumAndroidDriverTest.test_get_crash_log):
3904
3905 2012-09-04  Satish Sampath  <satish@chromium.org>
3906
3907         Run git commands within the checkout directory
3908         https://bugs.webkit.org/show_bug.cgi?id=95742
3909
3910         Reviewed by Eric Seidel.
3911
3912         git commands run from scm/git.py are sometimes run with cwd set to the
3913         checkout_root and other times with whatever directory was the default cwd.
3914         Instead all these should run with the checkout root set as the cwd
3915         (except where we explicitly need a different path)
3916
3917         * Scripts/webkitpy/common/checkout/scm/git.py:
3918         (Git._run_git):
3919         (Git.find_checkout_root):
3920         (Git.discard_local_commits):
3921         (Git.local_commits):
3922         (Git.working_directory_is_clean):
3923         (Git.clean_working_directory):
3924         (Git.add_list):
3925         (Git.delete_list):
3926         (Git.exists):
3927         (Git._current_branch):
3928         (Git._changes_files_for_commit):
3929         (Git.revisions_changing_file):
3930         (Git.svn_revision):
3931         (Git._run_git_svn_find_rev):
3932         (Git.contents_at_revision):
3933         (Git.diff_for_file):
3934         (Git.show_head):
3935         (Git.committer_email_for_revision):
3936         (Git.apply_reverse_diff):
3937         (Git.revert_files):
3938         (Git.commit_with_message):
3939         (Git._commit_on_branch):
3940         (Git.svn_commit_log):
3941         (Git.last_svn_commit_log):
3942         (Git.svn_blame):
3943         (Git._branch_ref_exists):
3944         (Git.delete_branch):
3945         (Git.remote_merge_base):
3946         (Git.commit_locally_with_message):
3947         (Git.push_local_commits_to_server):
3948         (Git.commit_ids_from_commitish_arguments):
3949         (Git.commit_message_for_local_commit):
3950         (Git.files_changed_summary_for_commit):
3951
3952 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3953
3954         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
3955         https://bugs.webkit.org/show_bug.cgi?id=95734
3956
3957         Reviewed by Adam Barth.
3958
3959         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3960         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3961         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3962         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3963         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3964         (MockWebRTCPeerConnectionHandler::createOffer):
3965         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3966         (MockWebRTCPeerConnectionHandler):
3967         (MockWebRTCPeerConnectionHandler::taskList):
3968         (SuccessCallbackTask):
3969         (FailureCallbackTask):
3970
3971 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3972
3973         [Chromium-Android] Output time and thread info in crash log
3974         https://bugs.webkit.org/show_bug.cgi?id=95768
3975
3976         Reviewed by Adam Barth.
3977
3978         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3979         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
3980
3981 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3982
3983         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
3984         https://bugs.webkit.org/show_bug.cgi?id=95721
3985
3986         Reviewed by Adam Barth.
3987
3988         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
3989         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
3990         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
3991         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
3992         (MockWebMediaStreamCenter):
3993
3994 2012-09-04  Tony Chang  <tony@chromium.org>
3995
3996         Elide test names when running new-run-webkit-tests
3997         https://bugs.webkit.org/show_bug.cgi?id=95626
3998
3999         Reviewed by Dirk Pranke.
4000
4001         When the test name exceeds the number of terminal columns, it leaves
4002         text on the screen. Avoid this by eliding the test name when running
4003         tests. This is similar to what ninja does when compiling.
4004
4005         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
4006         (MeteredStream):
4007         (MeteredStream.number_of_columns): Helper method to get number of
4008         terminal columns. Won't work on Win32 python, but meh.
4009         * Scripts/webkitpy/layout_tests/views/printing.py:
4010         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
4011         because stderr appears to be ascii only.
4012         (Printer.print_started_test): Route through _test_status_line.
4013         (Printer.print_finished_test): Route through _test_status_line.
4014         (Printer._print_test_trace): Route through _test_status_line.
4015         (Printer._print_baseline): Route through _test_status_line.
4016         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4017         (test_test_status_line): Test for _test_status_line.
4018
4019 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
4020
4021         [GTK] Print API missing documentation when generating gtkdoc
4022         https://bugs.webkit.org/show_bug.cgi?id=95703
4023
4024         Reviewed by Carlos Garcia Campos.
4025
4026         Print out API missing documentation when generating gtkdoc. This makes it
4027         easier to fix documentation errors.
4028
4029         * gtk/generate-gtkdoc:
4030         (print_missing_api): Added.
4031         (generate_doc): Inline the rebase step, since it now reports an error
4032         when you try to rebase without generating documentation first.
4033         * gtk/gtkdoc.py:
4034         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
4035         generating documentation first to enable a small cleanup at the caller.
4036         (GTKDoc.api_missing_documentation): Added.
4037
4038 2012-09-04  Vincent Scheib  <scheib@chromium.org>
4039
4040         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
4041         https://bugs.webkit.org/show_bug.cgi?id=95628
4042
4043         Reviewed by James Robinson.
4044
4045         Future tests need the ability to respond asynchronously that
4046         pointer lock requests have been accepted or rejected. This patch
4047         adds the following:
4048             testRunner.setPointerLockWillRespondAsynchronously();
4049             testRunner.didAcquirePointerLock();
4050             testRunner.didNotAcquirePointerLock();
4051
4052         Tested in existing test:
4053             pointerlockchange-pointerlockerror-events.html
4054
4055         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4056         (DRTTestRunner::DRTTestRunner):
4057         (DRTTestRunner::didAcquirePointerLock):
4058         (DRTTestRunner::didNotAcquirePointerLock):
4059         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
4060         * DumpRenderTree/chromium/DRTTestRunner.h:
4061         (DRTTestRunner):
4062         * DumpRenderTree/chromium/WebViewHost.cpp:
4063         (WebViewHost::requestPointerLock):
4064         (WebViewHost::didAcquirePointerLock):
4065         (WebViewHost::didNotAcquirePointerLock):
4066         * DumpRenderTree/chromium/WebViewHost.h:
4067         (WebViewHost):
4068         (WebViewHost::setPointerLockWillRespondAsynchronously):
4069
4070 2012-09-04  Ojan Vafai  <ojan@chromium.org>
4071
4072         Move content shell bots to their own builder group
4073         https://bugs.webkit.org/show_bug.cgi?id=95765
4074
4075         Reviewed by Adam Barth.
4076
4077         In their current state of instability, they add too much noise. Once they get more stable,
4078         we can add them back to the regular group or just have them replace the other bots.
4079
4080         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
4081
4082         * TestResultServer/static-dashboards/builders.js:
4083         (isWebkitTestRunner):
4084         (isChromiumContentShellTestRunner):
4085         (isChromiumWebkitTipOfTreeTestRunner):
4086         (loadBuildersList):
4087
4088 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
4089
4090         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
4091         https://bugs.webkit.org/show_bug.cgi?id=95689
4092
4093         Reviewed by Kenneth Rohde Christiansen.
4094
4095         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
4096         So, there are bugs that key events are always generated in url bar although
4097         the user clicked the web view.
4098
4099         This patch recovers the focus of the web view when left button is pressed and
4100         adds for MiniBrowser to toggle the focus when middle button is pressed
4101         like EWebLauncher already did.
4102
4103         * EWebLauncher/main.c:
4104         (on_mouse_down):
4105         * MiniBrowser/efl/main.c:
4106         (on_mouse_down):
4107         (browserCreate):
4108
4109 2012-09-03  Tao Bai  <michaelbai@chromium.org>
4110
4111         Added ANDROID_GDBSERVER definition for Ant
4112         https://bugs.webkit.org/show_bug.cgi?id=95265
4113
4114         Reviewed by Adam Barth.
4115
4116         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
4117         is only used for finding the gdbserver.
4118
4119         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4120         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
4121
4122 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
4123
4124         MediaStream API: Add Ice-related functionality to RTCPeerConnection
4125         https://bugs.webkit.org/show_bug.cgi?id=95565
4126
4127         Reviewed by Adam Barth.
4128
4129         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4130         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
4131         (MockWebRTCPeerConnectionHandler::updateICE):
4132         (MockWebRTCPeerConnectionHandler::addICECandidate):
4133         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
4134         (MockWebRTCPeerConnectionHandler):
4135
4136 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
4137
4138         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
4139         https://bugs.webkit.org/show_bug.cgi?id=95670
4140
4141         Reviewed by Kenneth Rohde Christiansen.
4142
4143         Fix layout issues related to the URL bar in Minibrowser
4144         and EWebLauncher when the window is resized.
4145
4146         The URL bar was not resized accordingly and the Web
4147         page was moved behing the URL bar, hiding part of it.
4148
4149         * EWebLauncher/main.c:
4150         (on_ecore_evas_resize):
4151         (closeWindow):
4152         * EWebLauncher/url_bar.c:
4153         (url_bar_width_set):
4154         (url_bar_add):
4155         * EWebLauncher/url_bar.h:
4156         * MiniBrowser/efl/main.c:
4157         (on_ecore_evas_resize):
4158         (main):
4159
4160 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
4161
4162         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
4163         https://bugs.webkit.org/show_bug.cgi?id=95605
4164
4165         Reviewed by Dirk Pranke.
4166
4167         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
4168
4169         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4170         (ChromiumAndroidPort.check_sys_deps):
4171         (ChromiumAndroidPort.expectations_files):
4172         (ChromiumAndroidPort.clean_up_test_run):
4173
4174 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
4175
4176         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
4177         https://bugs.webkit.org/show_bug.cgi?id=95180
4178
4179         Reviewed by Chris Fleizach.
4180
4181         The bug that was fixed stood in the way of fully implementing stringValue().
4182         Testing that the bug is fixed requires stringValue() to be fully implemented
4183         and object replacement characters to be printable.
4184
4185         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4186         (replaceCharactersForResults): New method which turns object replacement
4187         characters into "<obj>" so that the characters can be properly shown in
4188         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
4189         accessible text of a single object in the accessible tree doesn't mess up
4190         the readibility of the results.
4191         (AccessibilityUIElement::stringValue): Remove the code that immediately
4192         returned upon encountering an object of ATK_ROLE_PANEL and call the new
4193         replaceCharactersForResults() prior to returning the accessible string
4194         value.
4195
4196 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
4197
4198         MediaStream API: Add MediaStream management to RTCPeerConnection
4199         https://bugs.webkit.org/show_bug.cgi?id=95543
4200
4201         Reviewed by Adam Barth.
4202
4203         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
4204
4205         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4206         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
4207         (MockWebRTCPeerConnectionHandler::addStream):
4208         (MockWebRTCPeerConnectionHandler::removeStream):
4209         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
4210         (MockWebRTCPeerConnectionHandler):
4211
4212 2012-08-31  Tony Chang  <tony@chromium.org>
4213
4214         Remove ENABLE_CSS3_FLEXBOX compile time flag
4215         https://bugs.webkit.org/show_bug.cgi?id=95382
4216
4217         Reviewed by Ojan Vafai.
4218
4219         Everyone is already enabling this by default and the spec has stablized.
4220
4221         * Scripts/webkitperl/FeatureList.pm:
4222         * qmake/mkspecs/features/features.pri:
4223
4224 2012-08-31  Pratik Solanki  <psolanki@apple.com>
4225
4226         objc_msgSend and IMP should be cast appropriately before using
4227         https://bugs.webkit.org/show_bug.cgi?id=95242
4228
4229         Reviewed by Benjamin Poulain.
4230
4231         Fix for older compilers. Pass id as the return type to the template
4232         instead of relying on default type.
4233
4234         * DumpRenderTree/mac/DumpRenderTree.mm:
4235         (drt_NSFontManager_availableFontFamilies):
4236         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
4237         (WTR::wtr_NSFontManager_availableFontFamilies):
4238
4239 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
4240
4241         nrwt: use scm instead of calling svn directly to get the revision in json results generator
4242         https://bugs.webkit.org/show_bug.cgi?id=89616
4243
4244         Reviewed by Eric Seidel.
4245
4246         Add the new 'executive' optional function argument to the SCM.in_working_directory
4247         class method. This way we get to reuse an Executive instance which is necessary in testing
4248         when we're operating with a mock version of the object.
4249
4250         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
4251         the SCMDetector with the generator's FileSystem and Executive instances.
4252
4253         * Scripts/webkitpy/common/checkout/scm/detection.py:
4254         (SCMDetector.detect_scm_system):
4255         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
4256         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
4257         Executive output and test it against expected output.
4258         * Scripts/webkitpy/common/checkout/scm/git.py:
4259         (Git.in_working_directory):
4260         * Scripts/webkitpy/common/checkout/scm/scm.py:
4261         (SCM.in_working_directory):
4262         * Scripts/webkitpy/common/checkout/scm/svn.py:
4263         (SVN.in_working_directory):
4264         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4265         (JSONResultsGeneratorBase.__init__):
4266         (JSONResultsGeneratorBase._get_svn_revision):
4267
4268 2012-08-31  Jon Lee  <jonlee@apple.com>
4269
4270         [Tests] Add basic tests to http/tests/notifications
4271         https://bugs.webkit.org/show_bug.cgi?id=95493
4272         <rdar://problem/12209303>
4273
4274         Reviewed by Alexey Proskuryakov.
4275
4276         Add permission request support for WTR.
4277
4278         * WebKitTestRunner/TestController.cpp:
4279         (WTR::TestController::initialize):
4280         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
4281         * WebKitTestRunner/TestController.h:
4282         (TestController):
4283
4284 2012-08-31  Jon Lee  <jonlee@apple.com>
4285
4286         [DRT] Make simulating a web click on a notification a queued task
4287         https://bugs.webkit.org/show_bug.cgi?id=95546
4288         <rdar://problem/12214170>
4289
4290         Reviewed by Alexey Proskuryakov.
4291
4292         Making the web click happen asynchronously better mimics user interaction with the platform.
4293
4294         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
4295         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
4296         not set.
4297         * DumpRenderTree/mac/DumpRenderTree.mm:
4298         (dump): Assert that the flag is not set.
4299         * DumpRenderTree/mac/TestRunnerMac.mm:
4300         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
4301         notification. In the case where the block gets executed after the flag has been unset, we avoid
4302         performing the click.
4303
4304 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
4305
4306         [Qt] ImageDiff output is not in the expected form if image dimensions differ
4307         https://bugs.webkit.org/show_bug.cgi?id=95575
4308
4309         Reviewed by Csaba Osztrogonác.
4310
4311         Output 100% difference in the case of differing image dimensions so
4312         the test harness knows that we won't produce any output further.
4313         This matches the behavior of other ports.
4314
4315         * DumpRenderTree/qt/ImageDiff.cpp:
4316         (main):
4317
4318 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
4319
4320         Unreviewed, rolling out r127261.
4321         http://trac.webkit.org/changeset/127261
4322         https://bugs.webkit.org/show_bug.cgi?id=95572
4323
4324         This patch depends