-[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't...
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
2
3         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
4         https://bugs.webkit.org/show_bug.cgi?id=197510
5
6         Reviewed by Alex Christensen.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
9         (TestWebKitAPI::TEST):
10
11 2019-05-06  Keith Rollin  <krollin@apple.com>
12
13         Temporarily disable generate-xcfilelists
14         https://bugs.webkit.org/show_bug.cgi?id=197619
15         <rdar://problem/50507392>
16
17         Reviewed by Alex Christensen.
18
19         We need to perform a significant update to the generate-xcfilelist
20         scripts. This work involves coordinated work with another facility. If
21         the work does not occur in tandem, the build will be broken. To avoid
22         this, disable the invoking of the scripts during the transition. The
23         checking will be restored once the new scripts are in place.
24
25         * DumpRenderTree/Scripts/check-xcfilelists.sh:
26         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
27
28 2019-05-04  Alex Christensen  <achristensen@webkit.org>
29
30         Revert r244953 and r244954 because they broke internal builds.
31         https://bugs.webkit.org/show_bug.cgi?id=197534
32
33         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
34         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
35         * DumpRenderTree/mac/DumpRenderTree.mm:
36         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
37         * DumpRenderTree/mac/TestRunnerMac.mm:
38         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
39         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
40         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
41         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
42         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
43         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
44         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
45         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
46         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
47         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
48         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
49         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
50         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
51         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
52         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
53         * TestWebKitAPI/cocoa/TestWKWebView.mm:
54         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
55         * TestWebKitAPI/ios/UIKitSPI.h: Added.
56         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
57         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
58         * WebKitTestRunner/ios/HIDEventGenerator.h:
59         * WebKitTestRunner/ios/HIDEventGenerator.mm:
60         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
61         * WebKitTestRunner/ios/TestControllerIOS.mm:
62         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
63         * WebKitTestRunner/ios/mainIOS.mm:
64
65 2019-05-04  Alex Christensen  <achristensen@webkit.org>
66
67         Merge the three UIKitSPI.h files into a single one in PAL
68         https://bugs.webkit.org/show_bug.cgi?id=197534
69
70         Reviewed by Darin Adler.
71
72         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
73         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
74         * DumpRenderTree/mac/DumpRenderTree.mm:
75         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
76         * DumpRenderTree/mac/TestRunnerMac.mm:
77         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
78         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
79         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
80         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
81         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
82         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
83         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
84         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
85         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
86         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
87         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
88         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
89         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
90         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
91         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
92         * TestWebKitAPI/cocoa/TestWKWebView.mm:
93         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
94         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
95         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
96         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
97         * WebKitTestRunner/ios/HIDEventGenerator.h:
98         * WebKitTestRunner/ios/HIDEventGenerator.mm:
99         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
100         * WebKitTestRunner/ios/TestControllerIOS.mm:
101         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
102         * WebKitTestRunner/ios/mainIOS.mm:
103
104 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
105
106         Web Inspector: Provide UIString descriptions to improve localizations
107         https://bugs.webkit.org/show_bug.cgi?id=195132
108         <rdar://problem/48457817>
109
110         Reviewed by Devin Rousso.
111
112         Allow WI.UIString to take:
113         - WI.UIString(string, key, comment)
114         - WI.UIString(string, comment)
115         - WI.UIString(string)
116
117         * Scripts/extract-localizable-js-strings:
118
119 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
120
121         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
122         https://bugs.webkit.org/show_bug.cgi?id=197579
123
124         Reviewed by Tim Horton.
125
126         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
127         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
128         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
129         ensure that the the focused element has been blurred.
130
131         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
132
133 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
134
135         Add a tool to block spammer accounts
136         https://bugs.webkit.org/show_bug.cgi?id=197537
137
138         Reviewed by Darin Adler.
139
140         Usage: block-spammers email1 email2 ...
141
142         The tool finds and hides all bugs and comments from this account. Before any work
143         is done, these bugs and comments are displayed for confirmation.
144
145         * Scripts/block-spammers: Added.
146         (get_bugzilla_token):
147         (invalidate_bugzilla_token):
148         (get_user_info):
149         (get_user_info_self):
150         (can_use_this_tool):
151         (disable_user):
152         (get_bugs_created_by_user):
153         (get_bugs_commented_on_by_user):
154         (get_comments):
155         (hide_bug):
156         (hide_comments):
157         (ask_yes_no):
158         (sanitized_string):
159         (main):
160
161 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
162
163         run-apit-tests: Add --iterations and --repeat-each
164         https://bugs.webkit.org/show_bug.cgi?id=197563
165
166         Reviewed by Aakash Jain.
167
168         * Scripts/webkitpy/api_tests/manager.py:
169         (Manager.run): Add --iterations and --repeat-each/
170         * Scripts/webkitpy/api_tests/run_api_tests.py:
171         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
172
173 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
174
175         New EWS: Clicking on white bubble navigates to page with only bubbles
176         https://bugs.webkit.org/show_bug.cgi?id=197520
177
178         Reviewed by Lucas Forschler.
179
180         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
181
182 2019-05-03  Daniel Bates  <dabates@apple.com>
183
184         [lldb-webkit] Support adding pretty-printing for qualified types
185         https://bugs.webkit.org/show_bug.cgi?id=197518
186
187         Reviewed by Darin Adler.
188
189         Remove all "::"s from the name of the specified type when computing the name for the Python classes
190         that will provide summary and synthetic details as LLDB is not happy about registering such classes
191         when they contain :: in their name.
192
193         * lldb/lldb_webkit.py:
194         (addSummaryAndSyntheticFormattersForRawBitmaskType):
195
196 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
197
198         New EWS: patches on recently added queues listed as #1 for older bugs
199         https://bugs.webkit.org/show_bug.cgi?id=197496
200
201         Reviewed by Lucas Forschler.
202
203         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
204         (StatusBubble._build_bubble):
205         (StatusBubble._queue_position):
206
207 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
208
209         webkit-patch --no-review upload does not submit patch to New EWS
210         https://bugs.webkit.org/show_bug.cgi?id=197519
211         <rdar://problem/50424887>
212
213         Reviewed by Lucas Forschler.
214
215         * Scripts/webkitpy/tool/steps/submittoews.py:
216         (SubmitToEWS.run): Submit to both old and new EWS.
217         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
218         * Scripts/webkitpy/common/net/ewsserver.py: Added.
219         (EWSServer._server_url): Method to return server url.
220         (EWSServer._post_patch_to_ews): Method to post patch to ews.
221         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
222         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
223         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
224         * Scripts/webkitpy/common/net/statusserver_mock.py:
225         (MockStatusServer.submit_to_ews): Updated the log text.
226         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
227         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
228         * Scripts/webkitpy/tool/main.py:
229         (WebKitPatch.__init__): Initialize ews_server. 
230         * Scripts/webkitpy/tool/mocktool.py:
231         (MockTool.__init__): Ditto.
232
233 2019-05-03  Chris Dumez  <cdumez@apple.com>
234
235         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
236         https://bugs.webkit.org/show_bug.cgi?id=197574
237         <rdar://problem/50453181>
238
239         Reviewed by Tim Horton.
240
241         Add API test coverage.
242
243         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
244         (TEST):
245
246 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
247
248         [JSC] Generator CodeBlock generation should be idempotent
249         https://bugs.webkit.org/show_bug.cgi?id=197552
250
251         Reviewed by Keith Miller.
252
253         * Scripts/run-javascriptcore-tests:
254         (runJSCStressTests):
255         * Scripts/run-jsc-stress-tests:
256
257 2019-05-03  Commit Queue  <commit-queue@webkit.org>
258
259         Unreviewed, rolling out r244881.
260         https://bugs.webkit.org/show_bug.cgi?id=197559
261
262         Breaks compilation of jsconly on linux, breaking compilation
263         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
264         guijemont on #webkit).
265
266         Reverted changeset:
267
268         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
269         WEBKIT_COPY_FILES"
270         https://bugs.webkit.org/show_bug.cgi?id=197174
271         https://trac.webkit.org/changeset/244881
272
273 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
274
275         Unreviewed WPE build fix after r244898.
276
277         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
278         (WTR::TestController::abortModal): Add the missing (no-op) definition.
279
280 2019-05-02  Alex Christensen  <achristensen@webkit.org>
281
282         Mark U+01C0 as a homograph of U+006C
283         https://bugs.webkit.org/show_bug.cgi?id=197526
284         <rdar://problem/50301904>
285
286         Reviewed by Tim Horton.
287
288         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
289         (TestWebKitAPI::TEST):
290
291 2019-05-02  Chris Dumez  <cdumez@apple.com>
292
293         Add test coverage for <rdar://problem/49731231>
294         https://bugs.webkit.org/show_bug.cgi?id=196730
295         <rdar://problem/49731231>
296
297         Reviewed by Ryosuke Niwa.
298
299         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
300         to match DumpRenderTree.
301
302         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
303         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
304         (WTR::TestRunner::abortModal):
305         * WebKitTestRunner/InjectedBundle/TestRunner.h:
306         * WebKitTestRunner/TestController.cpp:
307         (WTR::TestController::runModal):
308         * WebKitTestRunner/TestController.h:
309         * WebKitTestRunner/TestInvocation.cpp:
310         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
311         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
312         (WTR::TestController::abortModal):
313         * WebKitTestRunner/ios/TestControllerIOS.mm:
314         (WTR::TestController::abortModal):
315         * WebKitTestRunner/mac/TestControllerMac.mm:
316         (WTR::TestController::abortModal):
317         * WebKitTestRunner/win/TestControllerWin.cpp:
318         (WTR::TestController::abortModal):
319
320 2019-05-02  Christopher Reid  <chris.reid@sony.com>
321
322         [CMake] Add support for LTO builds
323         https://bugs.webkit.org/show_bug.cgi?id=188986
324
325         Reviewed by Don Olmstead.
326
327         Add support to configure --lto-mode with cmake builds.
328
329         * Scripts/build-webkit:
330         * Scripts/webkitdirs.pm:
331         (generateBuildSystemFromCMakeProject):
332
333 2019-05-02  John Wilander  <wilander@apple.com>
334
335         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
336         https://bugs.webkit.org/show_bug.cgi?id=197521
337         <rdar://problem/49651503>
338
339         Reviewed by Brent Fulgham.
340
341         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
342         (TestWebKitAPI::TEST):
343            Added a test for host strings with leading dots since they are
344            often used for the domain attribute in cookies.
345
346 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
347
348         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
349         https://bugs.webkit.org/show_bug.cgi?id=197510
350
351         Reviewed by Alex Christensen.
352
353         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
354         (TestWebKitAPI::TEST):
355
356 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
357
358         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
359         https://bugs.webkit.org/show_bug.cgi?id=197174
360
361         Reviewed by Alex Christensen.
362
363         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
364
365         * TestWebKitAPI/PlatformGTK.cmake:
366         * TestWebKitAPI/PlatformWPE.cmake:
367
368 2019-05-02  Alex Christensen  <achristensen@webkit.org>
369
370         Build fix for internal branch.
371
372         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
373         RetainPtr.h was not explicitly included.
374
375 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
376
377         webkitpy: Ignore errors when shutting down an already shutdown simulator
378         <https://bugs.webkit.org/show_bug.cgi?id=197514>
379         <rdar://problem/50390247>
380
381         Reviewed by Lucas Forschler.
382
383         * Scripts/webkitpy/xcode/simulated_device.py:
384         (SimulatedDevice._shut_down):
385
386 2019-05-02  Frederic Wang  <fwang@igalia.com>
387
388         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
389         https://bugs.webkit.org/show_bug.cgi?id=196142
390
391         This patch introduces some experimental runtime flag to let users
392         disable MathML features that are removed from MathML Core [1]. For now,
393         these features are only disabled on GTK and WPE ports.
394
395         [1] https://mathml-refresh.github.io/mathml-core/
396
397         Reviewed by Rob Buis.
398
399         * DumpRenderTree/TestOptions.cpp:
400         (TestOptions::TestOptions):
401         * DumpRenderTree/TestOptions.h:
402         * DumpRenderTree/mac/DumpRenderTree.mm:
403         (setWebPreferencesForTestOptions):
404
405 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
406
407         TestWebKitAPI config.h should be aware of what suite is being built
408         https://bugs.webkit.org/show_bug.cgi?id=196583
409
410         Reviewed by Konstantin Tokarev.
411
412         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
413         benefit the macro defines BUILDING_* for the executable which allows the includes
414         of the config.h to be tailored to the test suite being built. Because of that the
415         dependencies of the Test* executable are specific to the test suite which may
416         speed up the build.
417
418         Some source files were including "PlatformUtilities.h" which includes WebKit headers
419         when "Utilities.h" is what was needed.
420
421         * TestWebKitAPI/CMakeLists.txt:
422         * TestWebKitAPI/PlatformGTK.cmake:
423         * TestWebKitAPI/PlatformJSCOnly.cmake:
424         * TestWebKitAPI/PlatformMac.cmake:
425         * TestWebKitAPI/PlatformPlayStation.cmake:
426         * TestWebKitAPI/PlatformUtilities.h:
427         * TestWebKitAPI/PlatformWPE.cmake:
428         * TestWebKitAPI/PlatformWin.cmake:
429         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
430         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
431         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
432         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
433         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
434         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
435         * TestWebKitAPI/config.h:
436
437 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
438
439         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
440         https://bugs.webkit.org/show_bug.cgi?id=181950
441         <rdar://problem/43357371>
442
443         Reviewed by Brent Fulgham.
444
445         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
446         (TestWebKitAPI::TEST_F):
447
448 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
449
450         Remove webkitpy and bindings EWS queues from dashboard
451         https://bugs.webkit.org/show_bug.cgi?id=197475
452
453         Reviewed by Alexey Proskuryakov.
454
455         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
456
457 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
458
459         Remove webkitpy and bindings test queues from old EWS
460         https://bugs.webkit.org/show_bug.cgi?id=197468
461
462         Reviewed by Alexey Proskuryakov.
463
464         * QueueStatusServer/config/queues.py:
465
466 2019-04-30  Tim Horton  <timothy_horton@apple.com>
467
468         Fix the WebKitTestRunner build
469         https://bugs.webkit.org/show_bug.cgi?id=197449
470         <rdar://problem/50334169>
471
472         Reviewed by Alexey Proskuryakov.
473
474         * WebKitTestRunner/mac/EventSenderProxy.mm:
475         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
476         (WTR::EventSenderProxy::mouseForceChanged):
477         Use some SPI instead of IPI.
478
479 2019-04-30  Chris Dumez  <cdumez@apple.com>
480
481         Regression(PSON) URL scheme handlers can no longer respond asynchronously
482         https://bugs.webkit.org/show_bug.cgi?id=197426
483         <rdar://problem/50256169>
484
485         Reviewed by Brady Eidson.
486
487         Add API test coverage.
488
489         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
490         (-[PSONScheme setShouldRespondAsynchronously:]):
491         (-[PSONScheme webView:startURLSchemeTask:]):
492         (-[PSONScheme webView:stopURLSchemeTask:]):
493
494 2019-04-30  Chris Dumez  <cdumez@apple.com>
495
496         Unreviewed, rolling out r244802.
497
498         Caused an API test failure
499
500         Reverted changeset:
501
502         "Regression(PSON) URL scheme handlers can no longer respond
503         asynchronously"
504         https://bugs.webkit.org/show_bug.cgi?id=197426
505         https://trac.webkit.org/changeset/244802
506
507 2019-04-30  Chris Dumez  <cdumez@apple.com>
508
509         Regression(PSON) URL scheme handlers can no longer respond asynchronously
510         https://bugs.webkit.org/show_bug.cgi?id=197426
511         <rdar://problem/50256169>
512
513         Reviewed by Brady Eidson.
514
515         Add API test coverage.
516
517         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
518         (-[PSONScheme setShouldRespondAsynchronously:]):
519         (-[PSONScheme webView:startURLSchemeTask:]):
520         (-[PSONScheme webView:stopURLSchemeTask:]):
521
522 2019-04-30  Chris Dumez  <cdumez@apple.com>
523
524         Only use a related page's process if that page has not been closed yet
525         https://bugs.webkit.org/show_bug.cgi?id=197393
526         <rdar://problem/50302423>
527
528         Reviewed by Tim Horton.
529
530         Add API test coverage.
531
532         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
533
534 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
535
536         [ews-build] Enable Bindings tests queue on new EWS
537         https://bugs.webkit.org/show_bug.cgi?id=197424
538
539         Reviewed by Lucas Forschler.
540
541         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
542         (StatusBubble):
543         * BuildSlaveSupport/ews-build/config.json:
544
545 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
546
547         [ews-build] Configure ews151 for running various tests
548         https://bugs.webkit.org/show_bug.cgi?id=197419
549
550         Reviewed by Lucas Forschler.
551
552         * BuildSlaveSupport/ews-build/config.json:
553
554 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
555
556         [ews-build] Parse and display bindings test failures
557         https://bugs.webkit.org/show_bug.cgi?id=197423
558
559         Reviewed by Lucas Forschler.
560
561         * BuildSlaveSupport/ews-build/steps.py:
562         (RunBindingsTests.__init__): Set timeout of 5 minutes.
563         (RunBindingsTests.start): Initialize log_observer for json output.
564         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
565         (RunBindingsTests._addToLog): Method to add message to log.
566         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
567
568 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
569
570         Unreviewed. Add myself as a committer.
571
572         * Scripts/webkitpy/common/config/contributors.json:
573
574 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
575
576         [ews-build] Enable webkitpy queue on new EWS
577         https://bugs.webkit.org/show_bug.cgi?id=197396
578
579         Reviewed by Lucas Forschler.
580
581         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
582         (StatusBubble):
583         * BuildSlaveSupport/ews-build/config.json:
584
585 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
586
587         [ews-build] Parse and display webkitpy failures
588         https://bugs.webkit.org/show_bug.cgi?id=197395
589
590         Reviewed by Lucas Forschler.
591
592         * BuildSlaveSupport/ews-build/steps.py:
593         (RunWebKitPyTests.start): Initialize log_observer for json output.
594         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
595         (RunWebKitPyTests._addToLog): Method to add message to log.
596         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
597
598 2019-04-29  Alex Christensen  <achristensen@webkit.org>
599
600         <rdar://problem/50299396> Fix internal High Sierra build
601         https://bugs.webkit.org/show_bug.cgi?id=197388
602
603         * DumpRenderTree/mac/Configurations/Base.xcconfig:
604         * MiniBrowser/Configurations/Base.xcconfig:
605         * MobileMiniBrowser/Configurations/Base.xcconfig:
606         * TestWebKitAPI/Configurations/Base.xcconfig:
607         * WebKitTestRunner/Configurations/Base.xcconfig:
608
609 2019-04-29  Youenn Fablet  <youenn@apple.com>
610
611         Remove spurious GVA printf logging
612         https://bugs.webkit.org/show_bug.cgi?id=197368
613         <rdar://problem/35975256>
614
615         Reviewed by Alexey Proskuryakov.
616
617         * Scripts/webkitpy/port/mac.py:
618         (MacPort.logging_patterns_to_strip):
619
620 2019-04-29  Youenn Fablet  <youenn@apple.com>
621
622         getDisplayMedia should be called on user gesture
623         https://bugs.webkit.org/show_bug.cgi?id=197356
624         <rdar://problem/50296074>
625
626         Reviewed by Eric Carlson.
627
628         Update test configuration to inject internals
629         so that we can use it to simulate a user click to call getDisplayMedia.
630
631         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
632         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
633         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
634
635 2019-04-26  Stephanie Lewis  <slewis@apple.com>
636
637         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
638         https://bugs.webkit.org/show_bug.cgi?id=197339
639
640         Reviewed by Dewei Zhu.
641
642         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
643         test run for setup steps that are too expensive to do every iteration.
644
645         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
646         (BenchmarkRunner._run_benchmark):
647         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
648         (BrowserDriver):
649         (BrowserDriver.prepare_initial_env):
650         (BrowserDriver.restore_env_after_all_testing):
651         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
652         (LinuxBrowserDriver.prepare_initial_env):
653         (LinuxBrowserDriver.restore_env_after_all_testing):
654         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
655         (OSXBrowserDriver.prepare_initial_env):
656         (OSXBrowserDriver.restore_env_after_all_testing):
657
658 2019-04-28  Andy Estes  <aestes@apple.com>
659
660         Fix the watchOS engineering build.
661
662         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
663         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
664
665 2019-04-27  Chris Dumez  <cdumez@apple.com>
666
667         [WKTR] Move test timeout handling to the UIProcess
668         https://bugs.webkit.org/show_bug.cgi?id=197333
669
670         Reviewed by Darin Adler.
671
672         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
673         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
674         every WebContent process in the case of swapping.
675
676         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
677         would lead to crashes when firing the timer.
678
679         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
680         (WTR::InjectedBundle::didReceiveMessageToPage):
681         (WTR::InjectedBundle::done):
682         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
683         (WTR::InjectedBundle::shouldDumpPixels const):
684         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
685         (WTR::TestRunner::TestRunner):
686         (WTR::TestRunner::waitUntilDone):
687         (WTR::TestRunner::setWaitUntilDone):
688         * WebKitTestRunner/InjectedBundle/TestRunner.h:
689         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
690         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
691         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
692         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
693         * WebKitTestRunner/TestInvocation.cpp:
694         (WTR::TestInvocation::TestInvocation):
695         (WTR::TestInvocation::createTestSettingsDictionary):
696         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
697         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
698         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
699         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
700         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
701         (WTR::TestInvocation::setWaitUntilDone):
702         (WTR::TestInvocation::done):
703         * WebKitTestRunner/TestInvocation.h:
704
705 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
706
707         [JSC] linkPolymorphicCall now does GC
708         https://bugs.webkit.org/show_bug.cgi?id=197306
709
710         Reviewed by Saam Barati.
711
712         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
713         To add this test, we add `runWithoutBaseOption`.
714
715         * Scripts/run-jsc-stress-tests:
716
717 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
718
719         Update inactive reviewers' status to 'contributor'.
720
721         Accidentally skipped one at first.
722
723         * Scripts/webkitpy/common/config/contributors.json:
724
725 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
726
727         Update inactive reviewers' status to 'contributor'.
728
729         * Scripts/webkitpy/common/config/contributors.json: The change.
730
731         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
732         * Scripts/webkitpy/common/checkout/checkout_mock.py:
733         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
734         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
735         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
736         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
737         * Scripts/webkitpy/tool/commands/queries_unittest.py:
738         * Scripts/webkitpy/tool/commands/upload_unittest.py:
739         Sadly, regression tests operate on a crazy mix of mock and live data for
740         contributors.json. It would be a substantial project to mock all code paths,
741         so changing the tests instead.
742
743 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
744
745         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
746         https://bugs.webkit.org/show_bug.cgi?id=197171
747         <rdar://problem/47454979>
748
749         Reviewed by Youenn Fablet.
750
751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
752         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
753         (TestWebKitAPI::TEST):
754
755 2019-04-26  David Kilzer  <ddkilzer@apple.com>
756
757         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
758         <https://webkit.org/b/197314>
759         <rdar://problem/50245252>
760
761         Reviewed by Simon Fraser.
762
763         * WebKitTestRunner/UIScriptControllerCocoa.mm:
764         (WTR::UIScriptController::lastUndoLabel const):
765         (WTR::UIScriptController::firstRedoLabel const):
766         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
767
768         * WebKitTestRunner/ios/HIDEventGenerator.mm:
769         (-[HIDEventGenerator sendEventStream:completionBlock:]):
770         - Call -autorelease to fix leak of NSDictionary.
771
772         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
773         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
774         (WTR::UIScriptController::selectFormPopoverTitle const):
775         (WTR::UIScriptController::textContentType const):
776         (WTR::UIScriptController::formInputLabel const):
777         (WTR::UIScriptController::scrollingTreeAsText const):
778         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
779
780 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
781
782         webkitpy: Running a single test will always use the default device
783         https://bugs.webkit.org/show_bug.cgi?id=195472
784         <rdar://problem/48724825>
785
786         Reviewed by Lucas Forschler.
787
788         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
789         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
790         requested will be run regardless of what shard they are in.
791
792         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
793         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
794         * Scripts/webkitpy/layout_tests/controllers/manager.py:
795         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
796         on the default device type.
797         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
798         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
799         (RunTest.test_run_part): Ditto.
800
801 2019-04-26  Alex Christensen  <achristensen@webkit.org>
802
803         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
804         https://bugs.webkit.org/show_bug.cgi?id=197165
805
806         Reviewed by Youenn Fablet.
807
808         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
809
810 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
811
812         Replace iOS build queue hardware
813         https://bugs.webkit.org/show_bug.cgi?id=197312
814
815         Reviewed by Aakash Jain.
816
817         * BuildSlaveSupport/build.webkit.org-config/config.json:
818         Use newer hardware that supports macOS Mojave.
819
820 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
821
822         check-webkit-style complains the first block in while loop.
823         https://bugs.webkit.org/show_bug.cgi?id=197307
824
825         The style checker shouldn't complain about an open brace on
826         its own line if the last non-whitespace character on the previous
827         non-blank line is another open brace, because it's likely to
828         indicate the begining of a nested code block.
829
830         Reviewed by Alex Christensen.
831
832         * Scripts/webkitpy/style/checkers/cpp.py:
833         (check_braces):
834         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
835         (WebKitStyleTest.test_braces):
836
837 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
838
839         Stop IDB transactions to release locked database files when network process is ready to suspend
840         https://bugs.webkit.org/show_bug.cgi?id=196372
841         <rdar://problem/48930116>
842
843         Reviewed by Brady Eidson.
844
845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
846         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
847         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
848         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
849         (runTestAndCheckResult):
850         (keepNetworkProcessActive):
851         (TEST):
852
853 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
854
855         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
856         https://bugs.webkit.org/show_bug.cgi?id=188357
857         <rdar://problem/42986633>
858
859         Reviewed by Dean Jackson.
860
861         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
862         tests would fall into low memory mode and have different behavior.
863         
864         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
865         to Internals, so it's shared by DRT and WTR.
866         
867         We no longer need the WK2 C SPI glue.
868
869         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
870         (WTR::InjectedBundlePage::prepare):
871
872 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
873
874         webkitpy: Including skipped tests in the final count
875         https://bugs.webkit.org/show_bug.cgi?id=197298
876         <rdar://problem/49705424>
877
878         Reviewed by Lucas Forschler.
879
880         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
881         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
882
883 2019-04-25  Timothy Hatcher  <timothy@apple.com>
884
885         Disable date and time inputs on iOSMac.
886         https://bugs.webkit.org/show_bug.cgi?id=197287
887         rdar://problem/46794376
888
889         Reviewed by Wenson Hsieh.
890
891         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
892
893 2019-04-25  Alex Christensen  <achristensen@webkit.org>
894
895         Fix test-webkitpy after r244653
896         https://bugs.webkit.org/show_bug.cgi?id=197131
897
898         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
899         Also use C++17.
900
901 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
902
903         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
904         https://bugs.webkit.org/show_bug.cgi?id=196991
905         <rdar://problem/45507423>
906
907         Reviewed by Alex Christensen.
908
909         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
910         (-[NavigationTestDelegate init]):
911         (-[NavigationTestDelegate waitForDidFinishNavigation]):
912         (-[NavigationTestDelegate webView:didFinishNavigation:]):
913         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
914         (TestWebKitAPI::TEST):
915         (TEST): Deleted.
916
917 2019-04-25  Alex Christensen  <achristensen@webkit.org>
918
919         Revert some code accidentally committed with r244653
920         https://bugs.webkit.org/show_bug.cgi?id=197131
921
922         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
923         (TestWebKitAPI::TEST):
924
925 2019-04-25  Alex Christensen  <achristensen@webkit.org>
926
927         Start using C++17
928         https://bugs.webkit.org/show_bug.cgi?id=197131
929
930         Reviewed by Darin Adler.
931
932         * DumpRenderTree/mac/Configurations/Base.xcconfig:
933         * MiniBrowser/Configurations/Base.xcconfig:
934         * MobileMiniBrowser/Configurations/Base.xcconfig:
935         * TestWebKitAPI/Configurations/Base.xcconfig:
936         * WebKitTestRunner/Configurations/Base.xcconfig:
937
938 2019-04-25  Commit Queue  <commit-queue@webkit.org>
939
940         Unreviewed, rolling out r244627.
941         https://bugs.webkit.org/show_bug.cgi?id=197282
942
943         Causing internal build failures (Requested by ShawnRoberts on
944         #webkit).
945
946         Reverted changeset:
947
948         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
949         https://bugs.webkit.org/show_bug.cgi?id=197171
950         https://trac.webkit.org/changeset/244627
951
952 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
953
954         [GTK] Hardcoded text color in input fields
955         https://bugs.webkit.org/show_bug.cgi?id=126907
956
957         Reviewed by Michael Catanzaro.
958
959         Add dark-mode command line option to MiniBrowser.
960
961         * MiniBrowser/gtk/main.c:
962         (main):
963
964 2019-04-24  Zalan Bujtas  <zalan@apple.com>
965
966         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
967         https://bugs.webkit.org/show_bug.cgi?id=196948
968         <rdar://problem/49927131>
969
970         Reviewed by Tim Horton.
971
972         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
973         (TEST):
974         The expected order of incoming events is
975         1. didInvalidateIntrinsicContentSize
976         2. didFirstLayout
977         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
978         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
979         (and remember, all we care about is ordering).
980
981 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
982
983         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
984         https://bugs.webkit.org/show_bug.cgi?id=197171
985         <rdar://problem/47454979>
986
987         Reviewed by Youenn Fablet.
988
989         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
990         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
991         (TestWebKitAPI::TEST):
992
993 2019-04-24  Brady Eidson  <beidson@apple.com>
994
995         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
996         https://bugs.webkit.org/show_bug.cgi?id=191362
997
998         Reviewed by Alex Christensen.
999
1000         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
1001           from an XHR to a custom protocol.
1002
1003 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1004
1005         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
1006         https://bugs.webkit.org/show_bug.cgi?id=197273
1007
1008         Reviewed by Dean Jackson.
1009
1010         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
1011         so that WebCoreTestSupport::resetInternalsObject() is always run.
1012
1013         * DumpRenderTree/mac/DumpRenderTree.mm:
1014         (resetWebViewToConsistentStateBeforeTesting):
1015         (runTest):
1016
1017 2019-04-24  John Wilander  <wilander@apple.com>
1018
1019         Age out unconverted Ad Click Attributions after one week.
1020         https://bugs.webkit.org/show_bug.cgi?id=197238
1021         <rdar://problem/50177349>
1022
1023         Reviewed by Chris Dumez.
1024
1025         This patch adds infrastructure to allow tests to expire all unconverted
1026         attributions early.
1027
1028         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1029         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1030         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
1031         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1032         * WebKitTestRunner/TestController.cpp:
1033         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
1034         * WebKitTestRunner/TestController.h:
1035         * WebKitTestRunner/TestInvocation.cpp:
1036         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1037
1038 2019-04-24  Chris Dumez  <cdumez@apple.com>
1039
1040         Fix flaky crashes in a couple of PSON API tests
1041         https://bugs.webkit.org/show_bug.cgi?id=197239
1042
1043         Reviewed by Tim Horton.
1044
1045         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
1046
1047         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1048
1049 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
1050
1051         Make it possible to control the renderTreeAsText output by setting options on testRunner
1052         https://bugs.webkit.org/show_bug.cgi?id=197133
1053
1054         Reviewed by Sam Weinig.
1055
1056         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
1057         that make sense in testing (those that don't dump unstable data like addresses), and plumb
1058         these flags through the various framework layers.
1059
1060         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
1061
1062         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
1063         and hand-code DumpRenderTree bindings.
1064
1065         Some cleanup of the TestRunners, using member initializers.
1066
1067         * DumpRenderTree/TestRunner.cpp:
1068         (TestRunner::TestRunner):
1069         (setRenderTreeDumpOptionsCallback):
1070         (TestRunner::staticFunctions):
1071         (TestRunner::setRenderTreeDumpOptions):
1072         * DumpRenderTree/TestRunner.h:
1073         (TestRunner::renderTreeDumpOptions const):
1074         * DumpRenderTree/mac/DumpRenderTree.mm:
1075         (dump):
1076         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1077         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1078         (WTR::InjectedBundlePage::dump):
1079         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1080         (WTR::TestRunner::TestRunner):
1081         (WTR::TestRunner::setRenderTreeDumpOptions):
1082         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1083         (WTR::TestRunner::renderTreeDumpOptions const):
1084
1085 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1086
1087         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
1088         https://bugs.webkit.org/show_bug.cgi?id=197078
1089         <rdar://problem/49564348>
1090
1091         Reviewed by Geoff Garen.
1092
1093         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1094         (TEST_F):
1095         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
1096         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
1097         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
1098
1099 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1100
1101         Add unit test for r239322
1102         https://bugs.webkit.org/show_bug.cgi?id=197236
1103
1104         Reviewed by Chris Dumez.
1105
1106         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
1107         May as well add the test infrastructure which was needed before and will be needed in the future.
1108
1109         * TestWebKitAPI/TCPServer.cpp:
1110         (TestWebKitAPI::TCPServer::TCPServer):
1111         * TestWebKitAPI/TCPServer.h:
1112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1113         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1114         (TestWebKitAPI::TEST):
1115         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1116         (TestWebKitAPI::downloadAtRate):
1117         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1118         (TEST):
1119         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
1120         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1121         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1122         (TestWebKitAPI::TEST):
1123         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1124         (TEST):
1125
1126 2019-04-24  Chris Dumez  <cdumez@apple.com>
1127
1128         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
1129         https://bugs.webkit.org/show_bug.cgi?id=197214
1130         <rdar://problem/49237544>
1131
1132         Reviewed by Alex Christensen.
1133
1134         Extend API test coverage.
1135
1136         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1137         (TEST):
1138
1139 2019-04-24  Philippe Normand  <pnormand@igalia.com>
1140
1141         [Build][GStreamer] Update to 1.16.0
1142         https://bugs.webkit.org/show_bug.cgi?id=197157
1143
1144         Reviewed by Xabier Rodriguez-Calvar.
1145
1146         The upstreamed patches were removed and a new one was added for a
1147         regression detected in the scaletempo GStreamer element. The GNOME
1148         Flatpak was migrated to 3.32 and I switched a few modules to Meson
1149         on the way, as it is the preferred build system now in GStreamer
1150         1.16.
1151
1152         * flatpak/files/httpd-autogen.sh:
1153         * flatpak/flatpakutils.py:
1154         (FlatpakPackage.install):
1155         (WebkitFlatpak.run_in_sandbox):
1156         * flatpak/org.webkit.CommonModules.yaml:
1157         * flatpak/org.webkit.WebKit.yaml:
1158         * gstreamer/jhbuild.modules:
1159         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
1160         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
1161         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
1162         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
1163         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
1164         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
1165         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
1166         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
1167         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
1168         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1169         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
1170         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1171         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
1172         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
1173         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
1174         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
1175         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
1176         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
1177         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
1178         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
1179         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
1180         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
1181
1182 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1183
1184         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
1185         https://bugs.webkit.org/show_bug.cgi?id=197156
1186
1187         Reviewed by Michael Catanzaro.
1188
1189         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
1190         support was added.
1191
1192         * MiniBrowser/gtk/BrowserTab.c:
1193         (browser_tab_set_background_color): Set the passed in color as web view background color.
1194         * MiniBrowser/gtk/BrowserTab.h:
1195         * MiniBrowser/gtk/BrowserWindow.c:
1196         (browser_window_init): Initialize backgroundColor.
1197         (browser_window_append_view): Call browser_tab_set_background_color().
1198         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
1199         are added.
1200         * MiniBrowser/gtk/main.c:
1201         (main): Call browser_window_set_background_color() before creating the tabs.
1202
1203 2019-04-23  John Wilander  <wilander@apple.com>
1204
1205         Move Ad Click Attribution from internal feature to experimental feature
1206         https://bugs.webkit.org/show_bug.cgi?id=197218
1207         <rdar://problem/47651691>
1208
1209         Reviewed by Brent Fulgham.
1210
1211         * DumpRenderTree/TestOptions.cpp:
1212         (TestOptions::TestOptions):
1213
1214 2019-04-23  Andy Estes  <aestes@apple.com>
1215
1216         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1217         https://bugs.webkit.org/show_bug.cgi?id=196749
1218         <rdar://problem/35773454>
1219
1220         Reviewed by Daniel Bates.
1221
1222         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1223
1224         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1225         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1226         (-[QuickLookDelegate webView:didFinishNavigation:]):
1227         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1228         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1229         (runTest):
1230         (runTestDecideBeforeLoading):
1231         (runTestDecideAfterLoading):
1232         (TEST):
1233
1234 2019-04-23  John Wilander  <wilander@apple.com>
1235
1236         Remove Ad Click Attribution data when removing website data
1237         https://bugs.webkit.org/show_bug.cgi?id=197215
1238         <rdar://problem/47668988>
1239
1240         Reviewed by Chris Dumez.
1241
1242         This patch adds test infrastructure to delete Ad Click Attribution data
1243         through WebsiteDataStore::removeData().
1244
1245         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1246         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1247         (WTR::TestRunner::clearAdClickAttribution):
1248         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1249         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1250         * WebKitTestRunner/TestController.cpp:
1251         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1252         * WebKitTestRunner/TestController.h:
1253         * WebKitTestRunner/TestInvocation.cpp:
1254         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1255
1256 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1257
1258         webkitpy: Kill unresponsive worker processes
1259         https://bugs.webkit.org/show_bug.cgi?id=197205
1260         <rdar://problem/50104388>
1261
1262         Reviewed by Lucas Forschler.
1263
1264         * Scripts/webkitpy/common/message_pool.py:
1265         (_MessagePool.__init__): Add close timeout.
1266         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1267
1268 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1269
1270         Add unit tests for WKWebView.serverTrust
1271         https://bugs.webkit.org/show_bug.cgi?id=197202
1272
1273         Reviewed by Youenn Fablet
1274
1275         * TestWebKitAPI/TCPServer.cpp:
1276         (TestWebKitAPI::deleter<BIO>::operator()):
1277         (TestWebKitAPI::deleter<SSL>::operator()):
1278         (TestWebKitAPI::deleter<X509>::operator()):
1279         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1280         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1281         (TestWebKitAPI::TCPServer::TCPServer):
1282         (TestWebKitAPI::TCPServer::listenForConnections):
1283         * TestWebKitAPI/TCPServer.h:
1284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1285         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1286         (TestWebKitAPI::TEST):
1287         (verifyCertificateAndPublicKey):
1288         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1289         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1290         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1291         (TestWebKitAPI::downloadAtRate):
1292         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1293         (TEST):
1294         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1295         (TEST):
1296
1297 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1298
1299         Unreviewed, rolling out r244556.
1300         https://bugs.webkit.org/show_bug.cgi?id=197212
1301
1302         Causing build failures on multiple builders (Requested by
1303         ShawnRoberts on #webkit).
1304
1305         Reverted changeset:
1306
1307         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1308         https://bugs.webkit.org/show_bug.cgi?id=197171
1309         https://trac.webkit.org/changeset/244556
1310
1311 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1312
1313         Fix iOS build.
1314         https://bugs.webkit.org/show_bug.cgi?id=195537
1315
1316         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1317         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1318         AdoptWK constructor is private now.  Use adoptWK instead.
1319
1320 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
1321
1322         Accessibility text search and selection API enhancements.
1323         https://bugs.webkit.org/show_bug.cgi?id=197095
1324         <rdar://problem/48181791>
1325
1326         Reviewed by Chris Fleizach.
1327
1328         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
1329
1330         * DumpRenderTree/AccessibilityTextMarker.h:
1331         * DumpRenderTree/AccessibilityUIElement.cpp:
1332         (searchTextWithCriteriaCallback):
1333         (AccessibilityUIElement::getJSClass):
1334         * DumpRenderTree/AccessibilityUIElement.h:
1335         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1336         (convertVectorToObjectArray):
1337         (convertNSArrayToVector):
1338         (searchTextParameterizedAttributeForCriteria):
1339         (AccessibilityUIElement::getLinkedUIElements):
1340         (AccessibilityUIElement::getDocumentLinks):
1341         (AccessibilityUIElement::getChildren):
1342         (AccessibilityUIElement::getChildrenWithRange):
1343         (AccessibilityUIElement::rowHeaders const):
1344         (AccessibilityUIElement::columnHeaders const):
1345         (AccessibilityUIElement::uiElementArrayAttributeValue const):
1346         (AccessibilityUIElement::searchTextWithCriteria):
1347         (AccessibilityUIElement::attributesOfColumnHeaders):
1348         (AccessibilityUIElement::attributesOfRowHeaders):
1349         (AccessibilityUIElement::attributesOfColumns):
1350         (AccessibilityUIElement::attributesOfRows):
1351         (AccessibilityUIElement::attributesOfVisibleCells):
1352         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1353         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1354         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1355         (WTR::convertVectorToObjectArray):
1356         (WTR::convertNSArrayToVector):
1357         (WTR::searchTextParameterizedAttributeForCriteria):
1358         (WTR::AccessibilityUIElement::getLinkedUIElements):
1359         (WTR::AccessibilityUIElement::getDocumentLinks):
1360         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1361         (WTR::AccessibilityUIElement::getChildren):
1362         (WTR::AccessibilityUIElement::getChildrenWithRange):
1363         (WTR::AccessibilityUIElement::rowHeaders const):
1364         (WTR::AccessibilityUIElement::columnHeaders const):
1365         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1366         (WTR::AccessibilityUIElement::searchTextWithCriteria):
1367         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1368         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1369         (WTR::AccessibilityUIElement::attributesOfColumns):
1370         (WTR::AccessibilityUIElement::attributesOfRows):
1371         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1372         (WTR::convertElementsToObjectArray): Deleted.
1373
1374 2019-04-23  Guy Lewin  <guy@lewin.co.il>
1375
1376         Multiple File Input Icon Set Regardless of File List
1377         https://bugs.webkit.org/show_bug.cgi?id=195537
1378
1379         Reviewed by Alexey Proskuryakov.
1380
1381         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
1382         display string in iOS file inputs
1383
1384         * DumpRenderTree/TestRunner.cpp:
1385         (SetOpenPanelFilesMediaIconCallback):
1386         (TestRunner::staticFunctions):
1387         (TestRunner::setOpenPanelFilesMediaIcon):
1388         * DumpRenderTree/TestRunner.h:
1389         (TestRunner::openPanelFilesMediaIcon const):
1390         * DumpRenderTree/mac/UIDelegate.mm:
1391         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1392         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1393         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1394         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1395         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1396         * WebKitTestRunner/TestController.cpp:
1397         (WTR::runOpenPanel):
1398         (WTR::TestController::resetStateToConsistentValues):
1399         * WebKitTestRunner/TestController.h:
1400         (WTR::TestController::openPanelFileURLsMediaIcon const):
1401         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
1402         * WebKitTestRunner/TestInvocation.cpp:
1403         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1404
1405 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
1406
1407         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1408         https://bugs.webkit.org/show_bug.cgi?id=197171
1409         <rdar://problem/47454979>
1410
1411         Reviewed by Youenn Fablet.
1412
1413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1414         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1415         (TestWebKitAPI::TEST):
1416
1417 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1418
1419         [ews-build] Add unit tests for UnApplyPatchIfRequired
1420         https://bugs.webkit.org/show_bug.cgi?id=197197
1421
1422         Reviewed by Lucas Forschler.
1423
1424         * BuildSlaveSupport/ews-build/steps_unittest.py:
1425         (TestUnApplyPatchIfRequired):
1426         (TestUnApplyPatchIfRequired.test_success):
1427         (TestUnApplyPatchIfRequired.test_failure):
1428         (TestUnApplyPatchIfRequired.test_skip):
1429
1430 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1431
1432         [ews-build] Add unit tests for CleanWorkingDirectory
1433         https://bugs.webkit.org/show_bug.cgi?id=197195
1434
1435         Reviewed by Lucas Forschler.
1436
1437         * BuildSlaveSupport/ews-build/steps_unittest.py:
1438         (TestCleanWorkingDirectory):
1439         (TestCleanWorkingDirectory.test_success):
1440         (TestCleanWorkingDirectory.test_failure):
1441
1442 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1443
1444         [ews-build] Use explicit imports instead of wildcard imports
1445         https://bugs.webkit.org/show_bug.cgi?id=197194
1446
1447         Reviewed by Lucas Forschler.
1448
1449         * BuildSlaveSupport/ews-build/factories.py:
1450         * BuildSlaveSupport/ews-build/loadConfig.py:
1451         * BuildSlaveSupport/ews-build/steps_unittest.py:
1452
1453 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1454
1455         [ews-build] Add unit tests for DownloadBuiltProduct
1456         https://bugs.webkit.org/show_bug.cgi?id=197193
1457
1458         Reviewed by Lucas Forschler.
1459
1460         * BuildSlaveSupport/ews-build/steps_unittest.py:
1461         (TestDownloadBuiltProduct):
1462         (TestDownloadBuiltProduct.setUp):
1463         (TestDownloadBuiltProduct.tearDown):
1464         (TestDownloadBuiltProduct.test_success):
1465         (TestDownloadBuiltProduct.test_failure):
1466
1467 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1468
1469         [ews-app] Exception while loading status-bubble when no build step has started
1470         https://bugs.webkit.org/show_bug.cgi?id=196676
1471
1472         Reviewed by Lucas Forschler.
1473
1474         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1475         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1476
1477 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1478
1479         [PlayStation] Support running of JSC tests on remote playstation devices
1480         https://bugs.webkit.org/show_bug.cgi?id=197170
1481
1482         Reviewed by Ross Kirsling.
1483
1484         Script changes
1485
1486         * Scripts/run-javascriptcore-tests:
1487         (runJSCStressTests): Pass arguments for playstation to
1488         run-jsc-stress-tests
1489         * Scripts/run-jsc-stress-tests:
1490         Handle $hostOS=="playstation" for determineArchitecture, turning
1491         off $isFTLPlatform and runProfiler and defaulting test writer.
1492         * Scripts/webkitdirs.pm:
1493         (jscPath): PlayStation WebKit executables have .elf extension
1494         (executableProductDir): PlayStation builds on Windows hosts but
1495         uses bin directory rather than bin64/bin32 for executable output
1496         location.
1497         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1498
1499 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1500
1501         [CMake][Win] Use target oriented design for WebKit
1502         https://bugs.webkit.org/show_bug.cgi?id=197173
1503
1504         Reviewed by Alex Christensen.
1505
1506         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1507         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1508
1509 2019-04-23  Chris Dumez  <cdumez@apple.com>
1510
1511         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1512         https://bugs.webkit.org/show_bug.cgi?id=197097
1513         <rdar://problem/50048318>
1514
1515         Reviewed by Alex Christensen.
1516
1517         Add API test coverage.
1518
1519         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1520         (-[PSONScheme webView:startURLSchemeTask:]):
1521
1522 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1523
1524         [ATK] Implement AtkComponentIface scroll_to methods
1525         https://bugs.webkit.org/show_bug.cgi?id=196856
1526
1527         Reviewed by Michael Catanzaro.
1528
1529         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1530         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1531         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1532         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1533
1534 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1535
1536         [ews-build] Improve summary for UploadBuiltProduct step
1537         https://bugs.webkit.org/show_bug.cgi?id=197182
1538
1539         Reviewed by Lucas Forschler.
1540
1541         * BuildSlaveSupport/ews-build/steps.py:
1542         (UploadBuiltProduct): Added descriptionDone.
1543         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1544         * BuildSlaveSupport/ews-build/steps_unittest.py:
1545         (TestUploadBuiltProduct.test_success): Updated unit-test.
1546         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1547
1548 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1549
1550         [ews-build] Trigger queues only after uploading the archive
1551         https://bugs.webkit.org/show_bug.cgi?id=197180
1552
1553         Reviewed by Lucas Forschler.
1554
1555         * BuildSlaveSupport/ews-build/factories.py:
1556         (Factory.__init__):
1557         (BuildFactory.__init__): Remove trigger step from factories.
1558         (BuildFactory.propertiesToPassToTriggers): Deleted.
1559         * BuildSlaveSupport/ews-build/steps.py:
1560         (ConfigureBuild.__init__): Confiure triggers property.
1561         (Trigger): Step to trigger other queues.
1562         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1563         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1564
1565 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1566
1567         Deprecate WKContextCreateWithInjectedBundlePath
1568         https://bugs.webkit.org/show_bug.cgi?id=197169
1569
1570         Reviewed by Youenn Fablet.
1571
1572         * TestWebKitAPI/PlatformUtilities.cpp:
1573         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1574         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1575
1576 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1577
1578         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1579         https://bugs.webkit.org/show_bug.cgi?id=197093
1580         <rdar://problem/49708268>
1581
1582         Reviewed by Chris Dumez.
1583
1584         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1585         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1586         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1587         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1588         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1589
1590         * TestWebKitAPI/TCPServer.cpp:
1591         (TestWebKitAPI::TCPServer::TCPServer):
1592         (TestWebKitAPI::TCPServer::~TCPServer):
1593         (TestWebKitAPI::TCPServer::socketBindListen):
1594         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1595         * TestWebKitAPI/TCPServer.h:
1596         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1597         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1598         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1599         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1600         (respondWithChallengeThenOK):
1601         (TestWebKitAPI::TEST):
1602         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1603         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1604         (TEST):
1605
1606 2019-04-22  Chris Dumez  <cdumez@apple.com>
1607
1608         Delayed WebProcessLaunch may break the _relatedWebView SPI
1609         https://bugs.webkit.org/show_bug.cgi?id=197160
1610
1611         Reviewed by Alex Christensen.
1612
1613         Add API test coverage.
1614
1615         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1616
1617 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1618
1619         Use curl to download packages for webkitpy autoinstaller
1620         https://bugs.webkit.org/show_bug.cgi?id=197164
1621
1622         Reviewed by Darin Adler.
1623
1624         * Scripts/webkitpy/common/system/autoinstall.py:
1625         (AutoInstaller._download): Use curl(1) to download packages necessary for
1626         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1627         errors which are not present when using curl(1).
1628
1629 2019-04-22  Chris Dumez  <cdumez@apple.com>
1630
1631         Unreviewed, rolling out r244502.
1632
1633         Caused crashes on the bots
1634
1635         Reverted changeset:
1636
1637         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1638         https://bugs.webkit.org/show_bug.cgi?id=197160
1639         https://trac.webkit.org/changeset/244502
1640
1641 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1642
1643         Unreviewed, rolling out r244437.
1644
1645         Still breaks internal tests.
1646
1647         Reverted changeset:
1648
1649         "InjectedBundle parameters often need initialization function
1650         called before unarchiving"
1651         https://bugs.webkit.org/show_bug.cgi?id=189709
1652         https://trac.webkit.org/changeset/244437
1653
1654 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1655
1656         [ews-build] Use singular verb in failure description in case of single api test failure
1657         https://bugs.webkit.org/show_bug.cgi?id=197013
1658
1659         Reviewed by Lucas Forschler.
1660
1661         * BuildSlaveSupport/ews-build/steps.py:
1662         (AnalyzeAPITestsResults.analyzeResults):
1663
1664 2019-04-22  Chris Dumez  <cdumez@apple.com>
1665
1666         Delayed WebProcessLaunch may break the _relatedWebView SPI
1667         https://bugs.webkit.org/show_bug.cgi?id=197160
1668
1669         Reviewed by Alex Christensen.
1670
1671         Add API test coverage.
1672
1673         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1674
1675 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1676
1677         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1678         https://bugs.webkit.org/show_bug.cgi?id=194630
1679
1680         Reviewed by Michael Catanzaro.
1681
1682         Return early from getAttributeSet() is passed in accessible is nullptr.
1683
1684         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1685
1686 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1687
1688         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1689         https://bugs.webkit.org/show_bug.cgi?id=197145
1690         <rdar://problem/50078170>
1691
1692         Reviewed by Darin Adler.
1693
1694         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1695         focus, or showing the font manager.
1696
1697         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1698         (TestWebKitAPI::TEST):
1699         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1700         (TEST):
1701         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1702         (TestWebKitAPI::TEST):
1703
1704 2019-04-21  Brian Burg  <bburg@apple.com>
1705
1706         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1707         https://bugs.webkit.org/show_bug.cgi?id=197125
1708         <rdar://problem/50061468>
1709
1710         Reviewed by Darin Adler.
1711
1712         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1713         using this class rather than making our own ./wpt serve invocation.
1714
1715         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1716         (WebDriverW3CWebServer):
1717         (WebDriverW3CWebServer.document_root): Expose this to clients.
1718         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1719
1720         (WebDriverW3CWebServer.__enter__):
1721         (WebDriverW3CWebServer.__exit__):
1722         Make it possible to use the web server with a 'with' statement.
1723
1724 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1725
1726         [CMake][Win] Use target oriented design for WebKitLegacy
1727         https://bugs.webkit.org/show_bug.cgi?id=197112
1728
1729         Reviewed by Konstantin Tokarev.
1730
1731         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1732
1733         * DumpRenderTree/CMakeLists.txt:
1734         * DumpRenderTree/PlatformWin.cmake:
1735         * DumpRenderTree/win/EventSender.cpp:
1736
1737 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1738
1739         Update text for old EWS submit button
1740         https://bugs.webkit.org/show_bug.cgi?id=197140
1741
1742         Reviewed by Alexey Proskuryakov.
1743
1744         * QueueStatusServer/templates/statusbubble.html:
1745
1746 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1747
1748         [ews-app] New EWS should poll bugzilla more frequently
1749         https://bugs.webkit.org/show_bug.cgi?id=197138
1750
1751         Reviewed by Alexey Proskuryakov.
1752
1753         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1754         (FetchLoop.__init__):
1755
1756 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1757
1758         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1759         https://bugs.webkit.org/show_bug.cgi?id=197139
1760
1761         Reviewed by Alexey Proskuryakov.
1762
1763         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1764         * QueueStatusServer/templates/statusbubble.html:
1765
1766 2019-04-20  Chris Dumez  <cdumez@apple.com>
1767
1768         Unreviewed, fix iOS build with recent SDKs.
1769
1770         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1771
1772 2019-04-19  Keith Miller  <keith_miller@apple.com>
1773
1774         Add script to merge run_benchmark jsons
1775         https://bugs.webkit.org/show_bug.cgi?id=197107
1776
1777         Reviewed by Michael Saboff.
1778
1779         The script basically recursively decends through all json objects until it gets
1780         to an array or JSON primitive and concats or takes the first value, respectively.
1781
1782         This patch also adds +x bits to the compare-results script so it
1783         can be run directly from the command line. I had to add a new line so that svn
1784         will accept the change... yay svn!
1785
1786         * Scripts/compare-results:
1787         * Scripts/merge-result-jsons: Added.
1788         (readJSONFile):
1789         (deepAppend):
1790         (mergeJSONs):
1791         (main):
1792
1793 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1794
1795         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1796         https://bugs.webkit.org/show_bug.cgi?id=197079
1797
1798         Reviewed by Darin Adler.
1799
1800         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1801
1802         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1803         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1804
1805 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1806
1807         Unreviewed, rolling out r244434.
1808         https://bugs.webkit.org/show_bug.cgi?id=197089
1809
1810         caused 1 API test failure (Requested by zalan on #webkit).
1811
1812         Reverted changeset:
1813
1814         "Regression (r244291): Broken API Test
1815         AutoLayoutRenderingProgressRelativeOrdering"
1816         https://bugs.webkit.org/show_bug.cgi?id=196948
1817         https://trac.webkit.org/changeset/244434
1818
1819 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1820
1821         Add new compatibility mode API on WKNavigation
1822         https://bugs.webkit.org/show_bug.cgi?id=197069
1823         <rdar://problem/50025800>
1824
1825         Reviewed by Tim Horton.
1826
1827         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1828
1829         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1830         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1831         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1832
1833 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1834
1835         [CMake] Make WebCore headers copies
1836         https://bugs.webkit.org/show_bug.cgi?id=182512
1837         <rdar://problem/37510435>
1838
1839         Reviewed by Alex Christensen.
1840
1841         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1842         ports.
1843
1844         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1845         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1846
1847         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1848         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1849         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1850         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1851         * TestWebKitAPI/CMakeLists.txt:
1852         * TestWebKitAPI/PlatformWin.cmake:
1853         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1854         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1855         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1856
1857 2019-04-18  Jer Noble  <jer.noble@apple.com>
1858
1859         Add support for parsing FairPlayStreaming PSSH boxes.
1860         https://bugs.webkit.org/show_bug.cgi?id=197064
1861
1862         Reviewed by Eric Carlson.
1863
1864         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1865         (TestWebKitAPI::TEST):
1866
1867 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1868
1869         InjectedBundle parameters often need initialization function called before unarchiving
1870         https://bugs.webkit.org/show_bug.cgi?id=189709
1871         <rdar://problem/44573653>
1872
1873         Reviewed by Ryosuke Niwa.
1874
1875         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1876         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1877
1878 2019-04-18  Zalan Bujtas  <zalan@apple.com>
1879
1880         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1881         https://bugs.webkit.org/show_bug.cgi?id=196948
1882         <rdar://problem/49927131>
1883
1884         Reviewed by Tim Horton.
1885
1886         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1887         (TEST): 
1888         The expected order of incoming events is
1889         1. didInvalidateIntrinsicContentSize
1890         2. didFirstLayout
1891         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1892         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1893         (and remember, all we care about is ordering).
1894
1895 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
1896
1897         Unreviewed, rolling out r244299.
1898
1899         Breaks internal tests.
1900
1901         Reverted changeset:
1902
1903         "InjectedBundle parameters often need initialization function
1904         called before unarchiving"
1905         https://bugs.webkit.org/show_bug.cgi?id=189709
1906         https://trac.webkit.org/changeset/244299
1907
1908 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
1909
1910         [WTF] StringBuilder should set correct m_is8Bit flag when merging
1911         https://bugs.webkit.org/show_bug.cgi?id=197053
1912
1913         Reviewed by Saam Barati.
1914
1915         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1916         (TestWebKitAPI::TEST):
1917
1918 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1919
1920         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
1921         https://bugs.webkit.org/show_bug.cgi?id=197028
1922         <rdar://problem/49985290>
1923
1924         Reviewed by Wenson Hsieh.
1925
1926         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1927         (TEST):
1928         Liberal application of waitForNextPresentationUpdate works around a race
1929         where if the page rapidly changes its viewport arguments (or an API client
1930         rapidly changes its viewport arguments), we'd get stuck thinking that the
1931         user had intentionally zoomed the page, and stop resetting the initial scale.
1932         This deserves a separate bug, but no need to keep the test failing while
1933         we think about it.
1934
1935 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1936
1937         REGRESSION (r241988): Switching tabs is slow
1938         https://bugs.webkit.org/show_bug.cgi?id=197037
1939         <rdar://problem/49951473>
1940
1941         Reviewed by Simon Fraser.
1942
1943         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1944         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
1945         (TEST):
1946         * TestWebKitAPI/cocoa/TestWKWebView.h:
1947         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1948         (-[TestWKWebView addToTestWindow]):
1949         Add a test that hangs without this fix.
1950
1951 2019-04-17  Truitt Savell  <tsavell@apple.com>
1952
1953         Unreviewed, rolling out r244400.
1954
1955         Caused testing to exit early with assertionon Debug WK2
1956
1957         Reverted changeset:
1958
1959         "UI↔Web deadlock when printing with a JavaScript alert
1960         visible"
1961         https://bugs.webkit.org/show_bug.cgi?id=196839
1962         https://trac.webkit.org/changeset/244400
1963
1964 2019-04-17  Brady Eidson  <beidson@apple.com>
1965
1966         Link clicks in PDFs shouldn't send referrer headers.
1967         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1968
1969         Reviewed by Tim Horton.
1970
1971         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1972         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1973         (putPDFBytesCallback):
1974         (emptyReleaseInfoCallback):
1975         (createPDFWithLinkToURL):
1976         (TEST):
1977
1978 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1979
1980         UI↔Web deadlock when printing with a JavaScript alert visible
1981         https://bugs.webkit.org/show_bug.cgi?id=196839
1982         <rdar://problem/49157642>
1983
1984         Reviewed by Andy Estes.
1985
1986         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1987         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1988         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1989         (TEST):
1990
1991 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1992
1993         WKRetainPtr's adoption constructor should be private
1994         https://bugs.webkit.org/show_bug.cgi?id=197019
1995
1996         Reviewed by Tim Horton.
1997
1998         * DumpRenderTree/mac/DumpRenderTree.mm:
1999         (dumpFramesAsText):
2000         * TestWebKitAPI/InjectedBundleController.cpp:
2001         (TestWebKitAPI::InjectedBundleController::initialize):
2002         * TestWebKitAPI/PlatformUtilities.cpp:
2003         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2004         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
2005         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2006         (TestWebKitAPI::Util::toWK):
2007         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2008         (TestWebKitAPI::TEST):
2009         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2010         (TestWebKitAPI::TEST):
2011         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2012         (TestWebKitAPI::TEST):
2013         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2014         (TestWebKitAPI::TEST):
2015         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2016         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2017         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
2018         (TestWebKitAPI::TEST):
2019         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
2020         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2021         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2022         (TestWebKitAPI::TEST):
2023         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
2024         (TestWebKitAPI::TEST):
2025         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2026         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2027         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
2028         (TestWebKitAPI::TEST):
2029         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2030         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2031         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2032         (TestWebKitAPI::TEST):
2033         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2034         (TestWebKitAPI::TEST):
2035         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2036         (TestWebKitAPI::TEST):
2037         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2038         (TestWebKitAPI::TEST):
2039         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2040         (TestWebKitAPI::TEST):
2041         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2042         (TestWebKitAPI::TEST):
2043         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2044         (TestWebKitAPI::TEST):
2045         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
2046         (TestWebKitAPI::TEST):
2047         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2048         (TestWebKitAPI::TEST):
2049         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2050         (TestWebKitAPI::TEST):
2051         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2052         (TestWebKitAPI::TEST):
2053         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2054         (TestWebKitAPI::TEST):
2055         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2056         (TestWebKitAPI::TEST):
2057         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
2058         (TestWebKitAPI::TEST):
2059         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
2060         (TestWebKitAPI::TEST):
2061         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
2062         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2063         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
2064         (TestWebKitAPI::TEST):
2065         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
2066         (TestWebKitAPI::TEST):
2067         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
2068         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
2069         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
2070         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
2071         (TestWebKitAPI::TEST):
2072         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
2073         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
2074         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
2075         (TestWebKitAPI::TEST):
2076         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
2077         (TestWebKitAPI::TEST):
2078         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2079         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2080         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2081         (TestWebKitAPI::TEST):
2082         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2083         (TestWebKitAPI::loadAlternateHTMLString):
2084         (TestWebKitAPI::TEST):
2085         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
2086         (TestWebKitAPI::TEST):
2087         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2088         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2089         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2090         (TestWebKitAPI::buildAndPerformTest):
2091         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2092         (TestWebKitAPI::TEST):
2093         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
2094         (TestWebKitAPI::TEST):
2095         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
2096         (TestWebKitAPI::TEST):
2097         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2098         (TestWebKitAPI::TEST):
2099         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2100         (TestWebKitAPI::TEST):
2101         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2102         (TestWebKitAPI::TEST):
2103         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2104         (TestWebKitAPI::TEST):
2105         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2106         (TestWebKitAPI::TEST):
2107         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
2108         (TestWebKitAPI::TEST):
2109         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2110         (TestWebKitAPI::TEST):
2111         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2112         (TestWebKitAPI::TEST):
2113         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2114         (TestWebKitAPI::TEST):
2115         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2116         (TestWebKitAPI::TEST):
2117         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2118         (TestWebKitAPI::TEST):
2119         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2120         (TestWebKitAPI::TEST):
2121         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2122         (TestWebKitAPI::TEST):
2123         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2124         (TestWebKitAPI::TEST):
2125         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2126         (TestWebKitAPI::TEST):
2127         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2128         (TestWebKitAPI::TEST):
2129         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2130         (TestWebKitAPI::TEST):
2131         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
2132         (TestWebKitAPI::TEST):
2133         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
2134         (TestWebKitAPI::TEST):
2135         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2136         (TestWebKitAPI::TEST):
2137         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2138         (TestWebKitAPI::TEST):
2139         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2140         (TestWebKitAPI::TEST):
2141         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2142         (TestWebKitAPI::TEST):
2143         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2144         (TestWebKitAPI::TEST):
2145         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2146         (TestWebKitAPI::TEST):
2147         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2148         (TestWebKitAPI::TEST):
2149         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2150         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2151         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
2152         (TestWebKitAPI::TEST):
2153         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2154         (TestWebKitAPI::TEST):
2155         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
2156         (TestWebKitAPI::TEST):
2157         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
2158         (TestWebKitAPI::TEST):
2159         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2160         (TestWebKitAPI::TEST):
2161         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2162         (TestWebKitAPI::TEST):
2163         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
2164         (TestWebKitAPI::TEST):
2165         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2166         (TestWebKitAPI::TEST):
2167         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2168         (TestWebKitAPI::TEST):
2169         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2170         (TestWebKitAPI::TEST):
2171         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2172         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
2173         (TEST):
2174         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2175         (TEST):
2176         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2177         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2178         (TEST):
2179         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
2180         (TestWebKitAPI::TEST):
2181         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2182         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2183         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2184         (WTR::getMenuItemTitleCallback):
2185         (WTR::createMouseMessageBody):
2186         (WTR::EventSendingController::mouseDown):
2187         (WTR::EventSendingController::mouseUp):
2188         (WTR::EventSendingController::mouseMoveTo):
2189         (WTR::EventSendingController::mouseForceClick):
2190         (WTR::EventSendingController::startAndCancelMouseForceClick):
2191         (WTR::EventSendingController::mouseForceDown):
2192         (WTR::EventSendingController::mouseForceUp):
2193         (WTR::EventSendingController::mouseForceChanged):
2194         (WTR::EventSendingController::leapForward):
2195         (WTR::EventSendingController::scheduleAsynchronousClick):
2196         (WTR::createKeyDownMessageBody):
2197         (WTR::EventSendingController::keyDown):
2198         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2199         (WTR::EventSendingController::mouseScrollBy):
2200         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2201         (WTR::EventSendingController::continuousMouseScrollBy):
2202         (WTR::EventSendingController::addTouchPoint):
2203         (WTR::EventSendingController::updateTouchPoint):
2204         (WTR::EventSendingController::setTouchModifier):
2205         (WTR::EventSendingController::setTouchPointRadius):
2206         (WTR::EventSendingController::touchStart):
2207         (WTR::EventSendingController::touchMove):
2208         (WTR::EventSendingController::touchEnd):
2209         (WTR::EventSendingController::touchCancel):
2210         (WTR::EventSendingController::clearTouchPoints):
2211         (WTR::EventSendingController::releaseTouchPoint):
2212         (WTR::EventSendingController::cancelTouchPoint):
2213         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2214         (WTR::InjectedBundle::didCreatePage):
2215         (WTR::InjectedBundle::didReceiveMessage):
2216         (WTR::InjectedBundle::didReceiveMessageToPage):
2217         (WTR::InjectedBundle::booleanForKey):
2218         (WTR::InjectedBundle::done):
2219         (WTR::InjectedBundle::dumpToStdErr):
2220         (WTR::InjectedBundle::outputText):
2221         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2222         (WTR::InjectedBundle::postAddChromeInputField):
2223         (WTR::InjectedBundle::postRemoveChromeInputField):
2224         (WTR::InjectedBundle::postFocusWebView):
2225         (WTR::InjectedBundle::postSetBackingScaleFactor):
2226         (WTR::InjectedBundle::postSetWindowIsKey):
2227         (WTR::InjectedBundle::postSetViewSize):
2228         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2229         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2230         (WTR::InjectedBundle::setGeolocationPermission):
2231         (WTR::InjectedBundle::setMockGeolocationPosition):
2232         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2233         (WTR::InjectedBundle::isGeolocationProviderActive const):
2234         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2235         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2236         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2237         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2238         (WTR::InjectedBundle::setCustomPolicyDelegate):
2239         (WTR::InjectedBundle::setHidden):
2240         (WTR::InjectedBundle::setCacheModel):
2241         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2242         (WTR::InjectedBundle::processWorkQueue):
2243         (WTR::InjectedBundle::queueBackNavigation):
2244         (WTR::InjectedBundle::queueForwardNavigation):
2245         (WTR::InjectedBundle::queueLoad):
2246         (WTR::InjectedBundle::queueLoadHTMLString):
2247         (WTR::InjectedBundle::queueReload):
2248         (WTR::InjectedBundle::queueLoadingScript):
2249         (WTR::InjectedBundle::queueNonLoadingScript):
2250         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2251         (WTR::frameToStr):
2252         (WTR::InjectedBundlePage::InjectedBundlePage):
2253         (WTR::dumpFrameDescriptionSuitableForTestResult):
2254         (WTR::dumpFrameScrollPosition):
2255         (WTR::dumpDescendantFrameScrollPositions):
2256         (WTR::dumpFrameText):
2257         (WTR::dumpDescendantFramesText):
2258         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2259         (WTR::TestRunner::shouldDumpPixels const):
2260         (WTR::TestRunner::setDumpPixels):
2261         (WTR::TestRunner::whatToDump const):
2262         (WTR::TestRunner::setWhatToDump):
2263         (WTR::TestRunner::setWaitUntilDone):
2264         (WTR::TestRunner::shouldWaitUntilDone const):
2265         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2266         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2267         (WTR::TestRunner::clearAllDatabases):
2268         (WTR::TestRunner::setIDBPerOriginQuota):
2269         (WTR::TestRunner::originsWithApplicationCache):
2270         (WTR::TestRunner::setCanOpenWindows):
2271         (WTR::TestRunner::setXSSAuditorEnabled):
2272         (WTR::TestRunner::setMediaDevicesEnabled):
2273         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2274         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2275         (WTR::TestRunner::setCustomUserAgent):
2276         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2277         (WTR::TestRunner::setModernMediaControlsEnabled):
2278         (WTR::TestRunner::setWebGL2Enabled):
2279         (WTR::TestRunner::setWritableStreamAPIEnabled):
2280         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2281         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2282         (WTR::TestRunner::setAllowsAnySSLCertificate):
2283         (WTR::TestRunner::setPluginsEnabled):
2284         (WTR::TestRunner::setValueForUser):
2285         (WTR::TestRunner::setAudioResult):
2286         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2287         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2288         (WTR::TestRunner::setAlwaysAcceptCookies):
2289         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2290         (WTR::TestRunner::isDoingMediaCapture const):
2291         (WTR::TestRunner::queueLoad):
2292         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2293         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2294         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2295         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2296         (WTR::TestRunner::setAuthenticationUsername):
2297         (WTR::TestRunner::setAuthenticationPassword):
2298         (WTR::TestRunner::secureEventInputIsEnabled const):
2299         (WTR::TestRunner::setBlockAllPlugins):
2300         (WTR::TestRunner::setPluginSupportedMode):
2301         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2302         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2303         (WTR::TestRunner::setNavigationGesturesEnabled):
2304         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2305         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2306         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2307         (WTR::TestRunner::terminateNetworkProcess):
2308         (WTR::TestRunner::terminateServiceWorkerProcess):
2309         (WTR::TestRunner::runUIScript):
2310         (WTR::TestRunner::setStatisticsDebugMode):
2311         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2312         (WTR::TestRunner::setStatisticsLastSeen):
2313         (WTR::TestRunner::setStatisticsPrevalentResource):
2314         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2315         (WTR::TestRunner::dumpResourceLoadStatistics):
2316         (WTR::TestRunner::isStatisticsPrevalentResource):
2317         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
2318         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
2319         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
2320         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
2321         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2322         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2323         (WTR::TestRunner::setStatisticsGrandfathered):
2324         (WTR::TestRunner::isStatisticsGrandfathered):
2325         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2326         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2327         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2328         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
2329         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
2330         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
2331         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2332         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
2333         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2334         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2335         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2336         (WTR::TestRunner::statisticsSubmitTelemetry):
2337         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2338         (WTR::TestRunner::setStatisticsIsRunningTest):
2339         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2340         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2341         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2342         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2343         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2344         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2345         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2346         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2347         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2348         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2349         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
2350         (WTR::TestRunner::statisticsResetToConsistentState):
2351         (WTR::TestRunner::setStorageAccessAPIEnabled):
2352         (WTR::TestRunner::getAllStorageAccessEntries):
2353         (WTR::TestRunner::addMockMediaDevice):
2354         (WTR::TestRunner::clearMockMediaDevices):
2355         (WTR::TestRunner::removeMockMediaDevice):
2356         (WTR::TestRunner::resetMockMediaDevices):
2357         (WTR::TestRunner::connectMockGamepad):
2358         (WTR::TestRunner::disconnectMockGamepad):
2359         (WTR::TestRunner::setMockGamepadDetails):
2360         (WTR::TestRunner::setMockGamepadAxisValue):
2361         (WTR::TestRunner::setMockGamepadButtonValue):
2362         (WTR::TestRunner::removeAllSessionCredentials):
2363         (WTR::TestRunner::clearDOMCache):
2364         (WTR::TestRunner::clearDOMCaches):
2365         (WTR::TestRunner::hasDOMCache):
2366         (WTR::TestRunner::domCacheSize):
2367         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2368         (WTR::TestRunner::getApplicationManifestThen):
2369         (WTR::TestRunner::injectUserScript):
2370         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
2371         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2372         (WTR::TestRunner::addTestKeyToKeychain):
2373         (WTR::TestRunner::cleanUpKeychain):
2374         (WTR::TestRunner::keyExistsInKeychain):
2375         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2376         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2377         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2378         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2379         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2380         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2381         * WebKitTestRunner/TestController.cpp:
2382         (WTR::TestController::initialize):
2383         (WTR::parseStringTestHeaderValueAsRelativePath):
2384         (WTR::updateTestOptionsFromTestHeader):
2385         (WTR::TestController::runTest):
2386         (WTR::TestController::didReceiveLiveDocumentsList):
2387         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2388         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2389         (WTR::TestController::didFinishNavigation):
2390         (WTR::TestController::didReceiveAuthenticationChallenge):
2391         * WebKitTestRunner/TestInvocation.cpp:
2392         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2393         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2394         (WTR::TestInvocation::uiScriptDidComplete):
2395         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
2396         * WebKitTestRunner/WebNotificationProvider.cpp:
2397         (WTR::WebNotificationProvider::closeWebNotification):
2398         * WebKitTestRunner/WorkQueueManager.cpp:
2399         (WTR::ScriptItem::ScriptItem):
2400         (WTR::WorkQueueManager::queueLoad):
2401         (WTR::WorkQueueManager::queueLoadHTMLString):
2402
2403 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2404
2405         Add a comment to make my test from r244139 less mysterious.
2406         https://bugs.webkit.org/show_bug.cgi?id=196744
2407
2408         As suggested by Darin Adler.
2409
2410         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2411         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2412
2413 2019-04-17  Chris Dumez  <cdumez@apple.com>
2414
2415         Remember device orientation permission for the duration of the browsing session
2416         https://bugs.webkit.org/show_bug.cgi?id=196992
2417         <rdar://problem/49946067>
2418
2419         Reviewed by Alex Christensen.
2420
2421         Add API test coverage.
2422
2423         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2424         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2425         (TEST):
2426
2427 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
2428
2429         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
2430         https://bugs.webkit.org/show_bug.cgi?id=196675
2431
2432         Reviewed by Lucas Forschler.
2433
2434         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2435         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
2436
2437 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2438
2439         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
2440         https://bugs.webkit.org/show_bug.cgi?id=196919
2441         <rdar://problem/41630459>
2442
2443         Reviewed by Tim Horton.
2444
2445         Add iOS support for several new testing hooks. See below for more detail.
2446
2447         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2448         (WTR::UIScriptController::isDismissingMenu const):
2449
2450         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
2451         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
2452         by UIKit when dismissing the callout bar (i.e. UIMenuController).
2453
2454         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2455         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2456         (WTR::UIScriptController::isDismissingMenu const):
2457         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2458         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2459         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2460         (WTR::InjectedBundle::didReceiveMessageToPage):
2461         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2462         (WTR::TestRunner::setAllowedMenuActions):
2463
2464         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2465         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2466         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2467         against the name of the custom action.
2468
2469         (WTR::TestRunner::installCustomMenuAction):
2470
2471         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2472         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2473         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2474         triggered.
2475
2476         (WTR::TestRunner::performCustomMenuAction):
2477
2478         Invoked when the custom menu action is triggered.
2479
2480         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2481         * WebKitTestRunner/TestController.cpp:
2482         (WTR::TestController::installCustomMenuAction):
2483         (WTR::TestController::setAllowedMenuActions):
2484         * WebKitTestRunner/TestController.h:
2485         * WebKitTestRunner/TestInvocation.cpp:
2486         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2487         (WTR::TestInvocation::performCustomMenuAction):
2488
2489         Add plumbing to call back into the injected bundle when performing the custom action.
2490
2491         * WebKitTestRunner/TestInvocation.h:
2492         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2493         (WTR::TestController::installCustomMenuAction):
2494         (WTR::TestController::setAllowedMenuActions):
2495         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2496         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2497         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2498         (-[TestRunnerWKWebView becomeFirstResponder]):
2499         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2500
2501         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2502         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2503         in the Mail app on iOS.
2504
2505         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2506         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2507         (-[TestRunnerWKWebView resetCustomMenuAction]):
2508         (-[TestRunnerWKWebView performCustomAction:]):
2509         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2510         (-[TestRunnerWKWebView _willHideMenu]):
2511         (-[TestRunnerWKWebView _didHideMenu]):
2512         * WebKitTestRunner/ios/TestControllerIOS.mm:
2513         (WTR::TestController::platformResetStateToConsistentValues):
2514
2515         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2516         if specified.
2517
2518         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2519         (WTR::UIScriptController::isDismissingMenu const):
2520
2521 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2522
2523         Allow sharing from imageSheet on an image document
2524         https://bugs.webkit.org/show_bug.cgi?id=196891
2525         <rdar://problem/25377386>
2526
2527         Reviewed by Tim Horton.
2528
2529         Test to make sure that the correct imageURL is extracted from an image element.
2530
2531         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2532         (TestWebKitAPI::TEST):
2533
2534 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2535
2536         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2537         https://bugs.webkit.org/show_bug.cgi?id=196995
2538
2539         Reviewed by Brady Eidson.
2540
2541         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2542         (TEST):
2543
2544 2019-04-16  Chris Dumez  <cdumez@apple.com>
2545
2546         URL set by document.open() is not communicated to the UIProcess
2547         https://bugs.webkit.org/show_bug.cgi?id=196941
2548         <rdar://problem/49237544>
2549
2550         Reviewed by Geoff Garen.
2551
2552         Add API test coverage.
2553
2554         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2555         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2556         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2557         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2558         (TEST):
2559
2560 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2561
2562         Unreviewed, rolling out r244321.
2563         https://bugs.webkit.org/show_bug.cgi?id=196968
2564
2565         Causing all WK2 Debug builds to exit early after Assertion
2566         failures. (Requested by ShawnRoberts on #webkit).
2567
2568         Reverted changeset:
2569
2570         "URL set by document.open() is not communicated to the
2571         UIProcess"
2572         https://bugs.webkit.org/show_bug.cgi?id=196941
2573         https://trac.webkit.org/changeset/244321
2574
2575 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2576
2577         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2578         https://bugs.webkit.org/show_bug.cgi?id=196948
2579
2580         Reviewed by Zalan Bujtas.
2581
2582         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2583         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2584
2585 2019-04-15  Chris Dumez  <cdumez@apple.com>
2586
2587         URL set by document.open() is not communicated to the UIProcess
2588         https://bugs.webkit.org/show_bug.cgi?id=196941
2589         <rdar://problem/49237544>
2590
2591         Reviewed by Geoffrey Garen.
2592
2593         Add API test coverage.
2594
2595         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2596         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2597         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2598         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2599         (TEST):
2600
2601 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2602
2603         Using Tools/Scripts/clean-webkit should not install requests
2604         https://bugs.webkit.org/show_bug.cgi?id=196940
2605
2606         Reviewed by Lucas Forschler.
2607
2608         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2609         existing, depending on the path autoinstalled is run through.
2610         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2611         needed.
2612         (Port.configuration_for_upload):
2613         (Port.commits_for_upload):
2614
2615 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2616
2617         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2618         https://bugs.webkit.org/show_bug.cgi?id=196773
2619
2620         Reviewed by Jer Noble.
2621
2622         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2623         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2624         (TEST):
2625
2626 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2627
2628         ews-build should clearly indicate flaky test failures
2629         https://bugs.webkit.org/show_bug.cgi?id=196947
2630
2631         Reviewed by Lucas Forschler.
2632
2633         * BuildSlaveSupport/ews-build/steps.py:
2634         (AnalyzeAPITestsResults.analyzeResults):
2635
2636 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2637
2638         InjectedBundle parameters often need initialization function called before unarchiving
2639         https://bugs.webkit.org/show_bug.cgi?id=189709
2640         <rdar://problem/44573653>
2641
2642         Reviewed by Ryosuke Niwa.
2643
2644         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2645         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2646
2647 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2648
2649         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2650         https://bugs.webkit.org/show_bug.cgi?id=196681
2651
2652         Reviewed by Darin Adler.
2653
2654         Added tests.
2655
2656         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2657         (WTF_HashSet.RemoveIf):
2658         (WTF_HashSet.RemoveIfShrinkToBestSize):
2659
2660 2019-04-15  John Wilander  <wilander@apple.com>
2661
2662         Send delayed Ad Click Attribution conversion requests to the click source
2663         https://bugs.webkit.org/show_bug.cgi?id=196838
2664         <rdar://problem/47650157>
2665
2666         Reviewed by Chris Dumez and Youenn Fablet.
2667
2668         This patch adds test infrastructure to override the default behavior in
2669         WebKit::NetworkAdClickAttribution.
2670
2671         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2672         (TestWebKitAPI::TEST):
2673         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2674         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2675         (WTR::TestRunner::dumpAdClickAttribution):
2676         (WTR::TestRunner::clearAdClickAttribution):
2677         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2678         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2679         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2680         * WebKitTestRunner/TestController.cpp:
2681         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2682         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2683         * WebKitTestRunner/TestController.h:
2684         * WebKitTestRunner/TestInvocation.cpp:
2685         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2686
2687 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2688
2689         [ews-app] status-bubble should display position in queue
2690         https://bugs.webkit.org/show_bug.cgi?id=196607
2691
2692         Reviewed by Lucas Forschler.
2693
2694         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2695         (StatusBubble._build_bubble):
2696         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2697
2698 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2699
2700         [ews-build] Do not run clean build by default on EWS builders
2701         https://bugs.webkit.org/show_bug.cgi?id=196897
2702
2703         Reviewed by Lucas Forschler.
2704
2705         * BuildSlaveSupport/ews-build/steps.py:
2706         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2707         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2708         untracked directories like WebKitBuild).
2709         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2710         untracked files/directories (like WebKitBuild).
2711
2712 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2713
2714         TestRunner::notifyDone() should be safely reentrant
2715         https://bugs.webkit.org/show_bug.cgi?id=196898
2716
2717         Reviewed by Darin Adler.
2718
2719         It is currently possible that TestRunner::notifyDone() will call itself, since
2720         notifyDone() will force a repaint, which can start executing JavaScript, which
2721         may call notifyDone() again. This can lead to test failures and flakiness.
2722         Fix this by setting the m_waitToDump flag before calling the dump() method.
2723
2724         * DumpRenderTree/mac/TestRunnerMac.mm:
2725         (TestRunner::notifyDone):
2726         (TestRunner::forceImmediateCompletion):
2727         * DumpRenderTree/win/TestRunnerWin.cpp:
2728         (TestRunner::notifyDone):
2729         (TestRunner::forceImmediateCompletion):
2730
2731 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2732
2733         [GTK][WPE] Add enable-media websetting
2734         https://bugs.webkit.org/show_bug.cgi?id=196863
2735
2736         Reviewed by Michael Catanzaro.
2737
2738         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2739         (testWebKitSettings): Add test for the enable-media web-setting.
2740
2741 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2742
2743         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2744         https://bugs.webkit.org/show_bug.cgi?id=196905
2745         <rdar://problem/49886096>
2746
2747         Reviewed by Tim Horton.
2748
2749         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2750         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2751         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2752         delay timer, we end up with this sequence of events in the problematic (failure) case:
2753
2754         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2755             ...IPC from UI to web process...
2756         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2757             ...IPC from web to UI process...
2758         (c) [UI]    Invoke completion handler for script #1
2759         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2760             ...IPC from UI to web process...
2761         (e) [Web]   Evaluate script #2 in the web process
2762         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2763
2764         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2765         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2766         #2 is run in step (e).
2767
2768         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2769         the UI process by waiting on a script message posted by the web process, after attachment updates are
2770         dispatched.
2771
2772         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2773         (TestWebKitAPI::TEST):
2774
2775 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2776
2777         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2778         https://bugs.webkit.org/show_bug.cgi?id=196909
2779
2780         Reviewed by Wenson Hsieh.
2781
2782         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2783         (TestWebKitAPI::TEST):
2784
2785 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2786
2787         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2788         https://bugs.webkit.org/show_bug.cgi?id=196880
2789
2790         Reviewed by Yusuke Suzuki.
2791
2792         Add a new function for bytecode cache tests that does not forceDiskCache
2793         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2794         test added in this patch, since the code is invalid and therefore won't be
2795         cached. It should also be useful for tests that evaluate dynamically
2796         generated code.
2797
2798         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2799         * Scripts/run-jsc-stress-tests:
2800
2801 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2802
2803         Update AudioSession route sharing policy
2804         https://bugs.webkit.org/show_bug.cgi?id=196776
2805         <rdar://problem/46501611>
2806
2807         Reviewed by Jer Noble.
2808
2809         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2810         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2811         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2812         (TestWebKitAPI::TEST):
2813
2814 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2815
2816         [iOS] Software keyboard is shown too frequently on some websites
2817         https://bugs.webkit.org/show_bug.cgi?id=195856
2818         <rdar://problem/49191395>
2819
2820         Reviewed by Darin Adler.
2821
2822         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2823
2824         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2825         (WTR::UIScriptController::setHardwareKeyboardAttached):
2826         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2827         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2828         (WTR::UIScriptController::setHardwareKeyboardAttached):
2829         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2830         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2831
2832         Additionally link against GraphicsServices in WebKitTestRunner.
2833
2834         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2835         (WTR::TestController::platformResetStateToConsistentValues):
2836         (WTR::UIScriptController::setHardwareKeyboardAttached):
2837
2838 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2839
2840         [GTK][WPE] Fix pacman install-dependencies packages
2841         https://bugs.webkit.org/show_bug.cgi?id=196817
2842
2843         Reviewed by Žan Doberšek.
2844         
2845         python3-setuptools is called python-setuptools
2846         ruby-highline is only available on AUR
2847         libv4l-devel is incorporated in v4l-utils
2848
2849         * gtk/install-dependencies:
2850         * wpe/install-dependencies:
2851
2852 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2853
2854         [GTK] REGRESSION(r243860): Many tests failing
2855         https://bugs.webkit.org/show_bug.cgi?id=196791
2856
2857         Reviewed by Joanmarie Diggs.
2858
2859         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2860         multiple documents and check that accessibility hierarchy is updated after a navigation.
2861
2862         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2863         (loadChangedCallback):
2864         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2865         (AccessibilityTest::AccessibilityTest):
2866         (AccessibilityTest::~AccessibilityTest):
2867         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2868         (AccessibilityTest::findTestServerApplication):
2869         (AccessibilityTest::findDocumentWeb):
2870         (AccessibilityTest::findRootObject):
2871         (AccessibilityTest::waitUntilChildrenRemoved):
2872         (AccessibilityTest::ensureProxy):
2873         (testAtspiBasicHierarchy):
2874         (beforeAll):
2875         (afterAll):
2876
2877 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2878
2879         [ews-build] Handle bug titles with unicode characters
2880         https://bugs.webkit.org/show_bug.cgi?id=196802
2881
2882         Reviewed by Dewei Zhu.
2883
2884         * BuildSlaveSupport/ews-build/steps.py:
2885         (ValidatePatch._is_bug_closed):
2886
2887 2019-04-11  Michael Saboff  <msaboff@apple.com>
2888
2889         Improve the Inline Cache Stats code
2890         https://bugs.webkit.org/show_bug.cgi?id=196836
2891
2892         Reviewed by Saam Barati.
2893
2894         Added a new script to consolidate and arrange the output of --useICStats option.
2895
2896         This script merges the output from every group into one large table and sorts it from most common to
2897         least common.  It also counts the slow path GetById and PutById variants and then calculates the
2898         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
2899         Put together, this is useful to see what property accesses are not getting cached.
2900
2901         * Scripts/ic-stats.py: Added.
2902         (ICStats):
2903         (ICStats.__init__):
2904         (ICStats.parse):
2905         (ICStats.dumpStats):
2906         (usage):
2907
2908 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2909
2910         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
2911         https://bugs.webkit.org/show_bug.cgi?id=196809
2912         <rdar://49800762>
2913
2914         Reviewed by Brady Eidson.
2915
2916         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2917         (TEST):
2918
2919 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2920
2921         requestAnimationFrame should execute before the next frame
2922         https://bugs.webkit.org/show_bug.cgi?id=177484
2923
2924         Reviewed by Simon Fraser.
2925
2926         Add trace points for the page RenderingUpdate.
2927
2928         * Tracing/SystemTracePoints.plist:
2929
2930 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2931
2932         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
2933         https://bugs.webkit.org/show_bug.cgi?id=196760
2934
2935         Reviewed by Don Olmstead.
2936
2937         vswhere.exe has been bundled since Visual Studio 2017 version
2938         15.2. We shouldn't download vswhere.exe.
2939
2940         * Scripts/build-jsc: Do not call update-vswhere.py.
2941         * Scripts/build-webkit: Ditto.
2942         * Scripts/update-vswhere.py: Removed.
2943         * Scripts/webkitdirs.pm:
2944         (requireModulesForVSWhere): Deleted.
2945         (pickCurrentVisualStudioInstallation): Deleted.
2946         (visualStudioInstallDirVSWhere): Return the latest installed VS
2947         installation path by using the bundled vswhere.exe.
2948         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
2949         (visualStudioInstallDirFallback): Removed.
2950
2951 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2952
2953         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2954         https://bugs.webkit.org/show_bug.cgi?id=196780
2955
2956         Reviewed by Alexey Proskuryakov.
2957
2958         * BuildSlaveSupport/ews-build/steps.py:
2959         * BuildSlaveSupport/ews-build/steps_unittest.py:
2960
2961 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2962
2963         Add SPI WKNavigationResponse._downloadAttribute
2964         https://bugs.webkit.org/show_bug.cgi?id=196755
2965         <rdar://49587365>
2966
2967         Reviewed by Brady Eidson.
2968
2969         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2970         (-[NavigationResponseTestDelegate navigationResponse]):
2971         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2972         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2973         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2974         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2975         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2976         (readRequest):
2977         (writeResponse):
2978         (TEST):
2979
2980 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2981
2982         Add modern API for overriding the page's specified viewport configuration
2983         https://bugs.webkit.org/show_bug.cgi?id=167734
2984         <rdar://problem/30331795>
2985
2986         Reviewed by Simon Fraser.
2987
2988         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2989         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2990
2991 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2992
2993         Add support for incremental bytecode cache updates
2994         https://bugs.webkit.org/show_bug.cgi?id=195000
2995
2996         Reviewed by Filip Pizlo.
2997
2998         Exit when the initial run to generate bytecode fails.
2999
3000         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3001
3002 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3003
3004         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
3005         https://bugs.webkit.org/show_bug.cgi?id=196744
3006         <rdar://49415309>
3007
3008         Reviewed by Chris Dumez.
3009
3010         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3011         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3012
3013 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3014
3015         Add a way to opt into modern compatibility mode in layout tests
3016         https://bugs.webkit.org/show_bug.cgi?id=196770
3017         <rdar://problem/49777550>
3018
3019         Reviewed by Antoine Quint.
3020
3021         Add a new test option to enable modern compatibility mode in layout tests.
3022
3023         * WebKitTestRunner/TestController.cpp:
3024         (WTR::updateTestOptionsFromTestHeader):
3025         * WebKitTestRunner/TestController.h:
3026         * WebKitTestRunner/TestOptions.h:
3027         (WTR::TestOptions::hasSameInitializationOptions const):
3028         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3029         (WTR::TestController::platformCreateWebView):
3030         (WTR::TestController::enableModernCompatibilityMode):
3031
3032 2019-04-10  Andy Estes  <aestes@apple.com>
3033
3034         Try to fix the 32-bit watchOS build.
3035
3036         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3037         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3038
3039 2019-04-10  Antoine Quint  <graouts@apple.com>
3040
3041         Enable Pointer Events on watchOS
3042         https://bugs.webkit.org/show_bug.cgi?id=196771
3043         <rdar://problem/49040909>
3044
3045         Reviewed by Dean Jackson.
3046
3047         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3048
3049 2019-04-10  Philippe Normand  <pnormand@igalia.com>
3050
3051         Unreviewed. Fix WPE accessibility tests after r244059.
3052
3053         We are failing to load the injected bundle due to undefined symbol
3054         AccessibilityUIElement::replaceTextInRange().
3055
3056         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
3057         (WTR::AccessibilityUIElement::replaceTextInRange):
3058
3059 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
3060
3061         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
3062         https://bugs.webkit.org/show_bug.cgi?id=196727
3063
3064         Reviewed by Fujii Hironori.
3065
3066         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3067         (WebKitBrowserWindow::create):
3068
3069 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
3070
3071         [ews-build] Add unit tests for PrintConfiguration
3072         https://bugs.webkit.org/show_bug.cgi?id=196752
3073
3074         Reviewed by Dewei Zhu.
3075
3076         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3077
3078 2019-04-09  Keith Rollin  <krollin@apple.com>
3079
3080         Unreviewed build maintenance -- update .xcfilelists.
3081
3082         * DumpRenderTree/DerivedSources-input.xcfilelist:
3083         * DumpRenderTree/DerivedSources-output.xcfilelist:
3084
3085 2019-04-09  Zalan Bujtas  <zalan@apple.com>
3086
3087         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
3088         https://bugs.webkit.org/show_bug.cgi?id=196743
3089         <rdar://problem/43897551>
3090
3091         Reviewed by Tim Horton.
3092
3093         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
3094         (TEST):
3095
3096 2019-04-09  Youenn Fablet  <youenn@apple.com>
3097
3098         Close service worker database on network process suspension
3099         https://bugs.webkit.org/show_bug.cgi?id=196623
3100         <rdar://problem/48930869>
3101
3102         Reviewed by Alex Christensen.
3103
3104         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3105
3106 2019-04-09  Daniel Bates  <dabates@apple.com>
3107
3108         [iPad] Should open popover when the spacebar is pressed
3109         https://bugs.webkit.org/show_bug.cgi?id=196360
3110         <rdar://problem/49389129>
3111
3112         Reviewed by Brent Fulgham.
3113
3114         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
3115
3116         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3117         (WTR::UIScriptController::isShowingPopover const): Added.
3118         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3119         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3120         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3121         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3122         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3123         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
3124         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
3125         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
3126         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
3127         (WTR::UIScriptController::isShowingPopover const): Added.
3128         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3129         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3130         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3131         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3132         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3133         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
3134         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
3135         (-[TestRunnerWKWebView _willPresentPopover]): Added.
3136         (-[TestRunnerWKWebView _didDismissPopover]): Added.
3137         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3138         (WTR::UIScriptController::isShowingPopover const): Added.
3139         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3140         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3141
3142 2019-04-09  Alex Christensen  <achristensen@webkit.org>
3143
3144         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3145         https://bugs.webkit.org/show_bug.cgi?id=196665
3146         <rdar://45115669>
3147
3148         Reviewed by Geoff Garen.
3149
3150         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3151         (goBack):
3152         (+[SimpleLookupContext sharedLookupContext]):
3153         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3154         (TEST):
3155         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3156         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3157
3158 2019-04-09  John Wilander  <wilander@apple.com>
3159
3160         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
3161         https://bugs.webkit.org/show_bug.cgi?id=196558
3162         <rdar://problem/47650245>
3163
3164         Reviewed by Youenn Fablet.
3165
3166         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3167         (TestWebKitAPI::TEST):
3168             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
3169
3170 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
3171
3172         [CMake] Apple builds should use ICU_INCLUDE_DIRS
3173         https://bugs.webkit.org/show_bug.cgi?id=196720
3174
3175         Reviewed by Konstantin Tokarev.
3176
3177         * TestWebKitAPI/PlatformMac.cmake:
3178
3179 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
3180
3181         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
3182         https://bugs.webkit.org/show_bug.cgi?id=196694
3183         <rdar://problem/48388734>
3184
3185         Rubber-stamped by Aakash Jain.
3186
3187         * Scripts/webkitpy/port/image_diff.py:
3188         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
3189         * Scripts/webkitpy/port/server_process.py:
3190         (ServerProcess.has_available_stdout): Check if stdout has data in it.
3191         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3192         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
3193         * Scripts/webkitpy/port/server_process_mock.py:
3194         (MockServerProcess.has_available_stdout):
3195         * Scripts/webkitpy/port/server_process_unittest.py:
3196         (TestServerProcess.serial_test_basic):
3197
3198 2019-04-09  Jer Noble  <jer.noble@apple.com>
3199
3200         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3201         https://bugs.webkit.org/show_bug.cgi?id=196097
3202
3203         Reviewed by Eric Carlson.
3204
3205         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3206
3207         * DumpRenderTree/mac/DumpRenderTree.mm:
3208         (resetWebPreferencesToConsistentValues):
3209         * WebKitTestRunner/TestController.cpp:
3210         (WTR::TestController::resetPreferencesToConsistentValues):
3211
3212 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
3213
3214         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
3215         https://bugs.webkit.org/show_bug.cgi?id=196690
3216
3217         Reviewed by Michael Catanzaro.
3218
3219         * QueueStatusServer/config/queues.py:
3220         * Scripts/webkitpy/common/config/ews.json:
3221         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3222         (test_ews_name):
3223
3224 2019-04-09  Chris Dumez  <cdumez@apple.com>
3225
3226         Loads using loadHTMLString() cause flashing when process-swapping
3227         https://bugs.webkit.org/show_bug.cgi?id=196714
3228         <rdar://problem/49637354>
3229
3230         Reviewed by Antti Koivisto.
3231
3232         Add API test coverage.
3233
3234         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3235
3236 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3237
3238         Unreviewed. Fix ATK accessibility tests after r244059.
3239
3240         We are failing to load the injected bundle due to undefined symbol
3241         AccessibilityUIElement::replaceTextInRange().
3242
3243         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3244         (WTR::AccessibilityUIElement::replaceTextInRange):
3245
3246 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3247
3248         AX: Support API: accessibilityReplaceRange:withText
3249         https://bugs.webkit.org/show_bug.cgi?id=196636
3250
3251         Unreviewed build fix for Windows port.
3252
3253         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3254         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
3255
3256 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
3257
3258         [CMake][WinCairo] Separate copied headers into different directories
3259         https://bugs.webkit.org/show_bug.cgi?id=196655
3260
3261         Reviewed by Michael Catanzaro.
3262
3263         * DumpRenderTree/CMakeLists.txt:
3264         * MiniBrowser/win/CMakeLists.txt:
3265         * TestWebKitAPI/CMakeLists.txt:
3266         * TestWebKitAPI/PlatformWin.cmake:
3267
3268 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
3269
3270         Log stack-trace for run-webkit-tests when interrupted
3271         https://bugs.webkit.org/show_bug.cgi?id=176393
3272         <rdar://problem/34262310>
3273
3274         Reviewed by Lucas Forschler.
3275
3276         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
3277         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
3278         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
3279         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
3280         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
3281         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3282         (main): Set handlers to log stack trace on interruption.
3283
3284 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3285
3286         AX: Support API: accessibilityReplaceRange:withText
3287         https://bugs.webkit.org/show_bug.cgi?id=196636
3288
3289         Unreviewed build fix for Windows port.
3290
3291         * DumpRenderTree/AccessibilityUIElement.cpp:
3292         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
3293
3294 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3295
3296         [ews-build] Scripts using Buildbot API have CORS error
3297         https://bugs.webkit.org/show_bug.cgi?id=196709
3298
3299         Reviewed by Alexey Proskuryakov.
3300
3301         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
3302
3303 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
3304
3305         AX: Support API: accessibilityReplaceRange:withText
3306         https://bugs.webkit.org/show_bug.cgi?id=196636
3307
3308         Reviewed by Daniel Bates.
3309
3310         * DumpRenderTree/AccessibilityUIElement.cpp:
3311         (replaceTextInRangeCallback):
3312         (AccessibilityUIElement::replaceTextInRange):
3313         (AccessibilityUIElement::getJSClass):
3314         * DumpRenderTree/AccessibilityUIElement.h:
3315         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3316         (AccessibilityUIElement::replaceTextInRange):
3317         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3318         (AccessibilityUIElement::replaceTextInRange):
3319         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3320         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3321         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3322         (WTR::AccessibilityUIElement::replaceTextInRange):
3323         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3324         (WTR::AccessibilityUIElement::replaceTextInRange):
3325
3326 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3327
3328         [iOS] Do not allow starting selection drags when selection views are not visible
3329         https://bugs.webkit.org/show_bug.cgi?id=196686
3330         <rdar://problem/49399192>
3331
3332         Reviewed by Tim Horton.
3333
3334         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
3335         also add some new API tests to cover scenarios where the web view is not first responder.
3336
3337         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3338         (TestWebKitAPI::TEST):
3339         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3340
3341         Add a switch to optionally make the web view first responder when starting the simulated drag.
3342
3343         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3344         (-[DragAndDropSimulator initWithWebView:]):
3345         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
3346
3347 2019-04-08  Justin Fan  <justin_fan@apple.com>
3348
3349         [Web GPU] Fix Web GPU experimental feature on iOS
3350         https://bugs.webkit.org/show_bug.cgi?id=196632
3351
3352         Reviewed by Myles C. Maxfield.
3353
3354         Properly make Web GPU available on iOS 11+.
3355
3356         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3357
3358 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3359
3360         [ews-build] Do not upload archive when Compile Fails
3361         https://bugs.webkit.org/show_bug.cgi?id=196674
3362
3363         Reviewed by Alexey Proskuryakov.
3364
3365         * BuildSlaveSupport/ews-build/factories.py:
3366         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
3367         * BuildSlaveSupport/ews-build/steps.py:
3368         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
3369         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
3370         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
3371
3372 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
3373
3374         Enable DFG on MIPS
3375         https://bugs.webkit.org/show_bug.cgi?id=196689
3376
3377         Reviewed by Žan Doberšek.
3378
3379         Since the bytecode change, we enabled the baseline JIT on mips in
3380         r240432, but DFG is still missing. With this change, all tests are
3381         passing on a ci20 board.
3382
3383         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
3384
3385 2019-04-08  Philippe Normand  <pnormand@igalia.com>
3386
3387         [Flatpak] Second run update-webkitwpe-flatpak fails
3388         https://bugs.webkit.org/show_bug.cgi?id=192702
3389
3390         Reviewed by Carlos Garcia Campos.
3391
3392         * flatpak/flatpakutils.py:
3393         (FlatpakObject.flatpak): Fix typo.
3394         (FlatpakPackage.install): When installing, also update to the configured remote commit.
3395         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
3396
3397 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
3398
3399         [GTK][WPE] outlook.live.com displays old-fashioned UI
3400         https://bugs.webkit.org/show_bug.cgi?id=196642
3401
3402         Reviewed by Carlos Garcia Campos.
3403
3404         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3405         (TestWebKitAPI::TEST): New Mac platform quirk test.
3406
3407 2019-04-07  Commit Queue  <commit-queue@webkit.org>
3408
3409         Unreviewed, rolling out r243956.
3410         https://bugs.webkit.org/show_bug.cgi?id=196688
3411
3412         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
3413         by aakashjain on #webkit).
3414
3415         Reverted changeset:
3416
3417         "Clicking "Go Back" from a safe browsing warning from an
3418         iframe should navigate the WKWebView back to the previous
3419         page"
3420         https://bugs.webkit.org/show_bug.cgi?id=196665
3421         https://trac.webkit.org/changeset/243956
3422
3423 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
3424
3425         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
3426         https://bugs.webkit.org/show_bug.cgi?id=196669
3427
3428         Reviewed by Geoffrey Garen.
3429
3430         Added three new unit tests for WeakHashSet.
3431
3432         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3433         (WTF_WeakPtr.WeakHashSetConstObjects):
3434         (WTF_WeakPtr.WeakHashSetComputesEmpty):
3435         (WTF_WeakPtr.WeakHashSetComputeSize):
3436
3437 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3438
3439         Hide next and previous form control buttons when WKWebView is editable
3440         https://bugs.webkit.org/show_bug.cgi?id=196672
3441         <rdar://problem/35625321>
3442
3443         Reviewed by Tim Horton.
3444
3445         Add a new API test.
3446
3447         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3448         (-[TestWKWebView lastTrailingBarButtonGroup]):
3449         (TestWebKitAPI::TEST):
3450         * TestWebKitAPI/ios/UIKitSPI.h:
3451
3452 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
3453
3454         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
3455         https://bugs.webkit.org/show_bug.cgi?id=196077
3456         <rdar://problem/49108202>
3457
3458         Reviewed by Chris Dumez.
3459
3460         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
3461         on new web view.
3462
3463         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3464
3465 2019-04-05  Saam Barati  <sbarati@apple.com>
3466
3467         Make compare-results understand MotionMark
3468         https://bugs.webkit.org/show_bug.cgi?id=196666
3469
3470         Reviewed by Yusuke Suzuki.
3471
3472         * Scripts/compare-results:
3473         (PLT5Results):
3474         (detectMotionMark):
3475         (detectMotionMark1_1):
3476         (motionMarkResults):
3477         (motionMark1_1Results):
3478         (detectBenchmark):
3479         (biggerIsBetter):
3480         (main):
3481
3482 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3483
3484         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3485         https://bugs.webkit.org/show_bug.cgi?id=196665
3486         <rdar://45115669>
3487
3488         Reviewed by Geoff Garen.
3489
3490         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3491         (goBack):
3492         (+[SimpleLookupContext sharedLookupContext]):
3493         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3494         (TEST):
3495         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3496         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3497
3498 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3499
3500         [ews-build] Add configuration and architecture for windows builders
3501         https://bugs.webkit.org/show_bug.cgi?id=196660
3502
3503         Reviewed by Lucas Forschler.
3504
3505         * BuildSlaveSupport/ews-build/config.json:
3506
3507 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3508
3509         webkitpy: Don't run subsequent rounds if interrupted
3510         https://bugs.webkit.org/show_bug.cgi?id=196646
3511
3512         Reviewed by Aakash Jain.
3513
3514         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3515         (Manager.run): Bail out if interrupted.
3516
3517 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3518
3519         Test sessionStorage in PSON private browsing mode
3520         https://bugs.webkit.org/show_bug.cgi?id=196561
3521
3522         Reviewed by Alex Christensen.
3523
3524         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3525
3526 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3527
3528         Unreviewed, rolling out r243833.
3529         https://bugs.webkit.org/show_bug.cgi?id=196645
3530
3531         This change breaks build of WPE and GTK ports (Requested by
3532         annulen on #webkit).
3533
3534         Reverted changeset:
3535
3536         "[CMake][WTF] Mirror XCode header directories"
3537         https://bugs.webkit.org/show_bug.cgi?id=191662
3538         https://trac.webkit.org/changeset/243833
3539
3540 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3541
3542         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3543         https://bugs.webkit.org/show_bug.cgi?id=196635
3544
3545         Reviewed by Antti Koivisto.
3546         
3547         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3548         for a test to enable async frame scrolling via:
3549             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3550         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3551         
3552         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3553
3554         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3555         (WTR::InjectedBundle::beginTesting):
3556         * WebKitTestRunner/TestController.cpp:
3557         (WTR::TestController::resetPreferencesToConsistentValues):
3558
3559 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3560
3561         Use a correct LC_RPATH when building with ASan
3562         https://bugs.webkit.org/show_bug.cgi?id=196576
3563
3564         Reviewed by David Kilzer.
3565
3566         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3567         so that ../Frameworks is checked. This is simpler and more reliable than updating
3568         each SPC service xcconfig.
3569
3570 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3571
3572         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3573         https://bugs.webkit.org/show_bug.cgi?id=196629
3574
3575         Reviewed by Lucas Forschler.
3576
3577         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3578
3579 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3580
3581         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3582         https://bugs.webkit.org/show_bug.cgi?id=196618
3583
3584         Reviewed by Lucas Forschler.
3585
3586         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3587         (StatusBubble): Added QUEUE_TRIGGERS.
3588         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3589         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3590         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
3591         its parent(builder).
3592
3593 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3594
3595         [ews-app] Status-bubble steps are sometimes displayed in reverse order
3596         https://bugs.webkit.org/show_bug.cgi?id=196625
3597
3598         Reviewed by Lucas Forschler.
3599
3600         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3601         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
3602
3603 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3604
3605         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
3606         https://bugs.webkit.org/show_bug.cgi?id=196630
3607
3608         Reviewed by Wenson Hsieh.
3609
3610         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3611
3612 2019-04-04  Youenn Fablet  <youenn@apple.com>
3613
3614         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
3615         https://bugs.webkit.org/show_bug.cgi?id=196543
3616
3617         Reviewed by Alex Christensen.
3618
3619         * WebKitTestRunner/TestController.cpp:
3620         (WTR::TestController::generatePageConfiguration):
3621
3622 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3623
3624         [ews-app] Status bubble should not display skipped buildbot steps
3625         https://bugs.webkit.org/show_bug.cgi?id=196584
3626
3627         Reviewed by Lucas Forschler.
3628
3629         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3630
3631 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3632
3633         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
3634         https://bugs.webkit.org/show_bug.cgi?id=196620
3635
3636         Reviewed by Lucas Forschler.
3637
3638         * BuildSlaveSupport/ews-app/ews/config.py:
3639
3640 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
3641
3642         [Win] DumpRenderTreeWatchDog.py is not checked into source
3643         https://bugs.webkit.org/show_bug.cgi?id=196567
3644         <rdar://problem/49525901>
3645
3646         Reviewed by Lucas Forschler.
3647
3648         This script is used on Win EWS bots to terminate hanging DRT processes.
3649
3650         * EWSTools/dumprendertreewatchdog.py: Added.
3651
3652 2019-04-04  Chris Dumez  <cdumez@apple.com>
3653
3654         Unreviewed, roll out r243858 which made tests time out.
3655
3656         Disable new API tests on Windows instead.
3657
3658         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3659         (TestWebKitAPI::TEST):
3660
3661 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3662
3663         [ATK] Cleanup WebPageAccessibilityObjectAtk
3664         https://bugs.webkit.org/show_bug.cgi?id=196537
3665
3666         Reviewed by Michael Catanzaro.
3667
3668         Also consider files under atk directories as exceptions for GObject conventions.
3669
3670         * Scripts/webkitpy/style/checkers/cpp.py:
3671         (check_identifier_name_in_declaration):
3672
3673 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3674
3675         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3676         https://bugs.webkit.org/show_bug.cgi?id=196588
3677         <rdar://problem/49365787>
3678
3679         Unreviewed build fix for Windows port.
3680
3681         error C3861: 'kill': identifier not found
3682
3683         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3684         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
3685
3686 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3687
3688         [ews-build] Cancel build and similar operations should have authentication
3689         https://bugs.webkit.org/show_bug.cgi?id=196520
3690
3691         Reviewed by Dewei Zhu.
3692
3693         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
3694         environment variables.
3695
3696 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3697
3698         [ews-build] Do not trigger queues which are not in production yet
3699         https://bugs.webkit.org/show_bug.cgi?id=196581
3700
3701         Reviewed by Dewei Zhu.
3702
3703         * BuildSlaveSupport/ews-build/config.json:
3704
3705 2019-04-03  Chris Dumez  <cdumez@apple.com>
3706
3707         Unreviewed, fix typo in the name of API test added in r243848.
3708
3709         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3710         (TestWebKitAPI::TEST):
3711
3712 2019-04-03  Chris Dumez  <cdumez@apple.com>
3713
3714         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3715         https://bugs.webkit.org/show_bug.cgi?id=196588
3716         <rdar://problem/49365787>
3717
3718         Reviewed by Ryosuke Niwa.
3719
3720         Add API test coverage.
3721
3722         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3723         (TestWebKitAPI::nullJavaScriptCallback):
3724         (TestWebKitAPI::didCrashCheckFrames):
3725         (TestWebKitAPI::TEST):
3726
3727 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3728
3729         run-webkit-tests: Upload test results (new results database)
3730         https://bugs.webkit.org/show_bug.cgi?id=196577
3731         <rdar://problem/34841155>
3732
3733         Reviewed by Lucas Forschler.
3734
3735         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3736         (Manager.run): Upload results after each device shard, since the configuration will be
3737         different for each device.
3738         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3739         uploaded to a results database.
3740         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3741         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3742
3743 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3744
3745         -apple-trailing-word is needed for browser detection
3746         https://bugs.webkit.org/show_bug.cgi?id=196575
3747
3748         Unreviewed.
3749
3750         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3751
3752 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3753
3754         [CMake][WTF] Mirror XCode header directories
3755         https://bugs.webkit.org/show_bug.cgi?id=191662
3756
3757         Reviewed by Konstantin Tokarev.
3758
3759         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3760         builds.
3761
3762         * CMakeLists.txt:
3763         * DumpRenderTree/CMakeLists.txt:
3764         * DumpRenderTree/PlatformWin.cmake:
3765         * MiniBrowser/win/CMakeLists.txt:
3766         * TestWebKitAPI/CMakeLists.txt:
3767         * TestWebKitAPI/PlatformWin.cmake:
3768         * WebKitTestRunner/PlatformGTK.cmake:
3769         * WebKitTestRunner/PlatformWin.cmake:
3770
3771 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3772
3773         [ews-app] Status bubble should not display certain infrastructure status messages
3774         https://bugs.webkit.org/show_bug.cgi?id=196550
3775
3776         Reviewed by Lucas Forschler.
3777
3778         Do not display the steps which are un-needed for end-user. This information is still avaiable
3779         if the user click on the bubble and look at the Buildbot build.
3780         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3781         (StatusBubble._steps_messages):
3782         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
3783
3784 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3785
3786         [ews-build] Use https for sending data to ews-app
3787         https://bugs.webkit.org/show_bug.cgi?id=196492
3788
3789         Reviewed by Lucas Forschler.
3790
3791         * BuildSlaveSupport/ews-build/events.py:
3792
3793 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3794
3795         Remove support for -apple-trailing-word
3796         https://bugs.webkit.org/show_bug.cgi?id=196525
3797
3798         Reviewed by Zalan Bujtas.
3799
3800         This CSS property is nonstandard and not used.
3801
3802         * Scripts/webkitperl/FeatureList.pm:
3803         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3804
3805 2019-04-03  Youenn Fablet  <youenn@apple.com>
3806
3807         Add a test for DOMCache on multiple browsing in case of private browsing
3808         https://bugs.webkit.org/show_bug.cgi?id=196524
3809
3810         Reviewed by Alex Christensen.
3811
3812         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3813         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
3814
3815 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3816
3817         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
3818         https://bugs.webkit.org/show_bug.cgi?id=196540
3819
3820         Reviewed by Aakash Jain.
3821
3822         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
3823
3824 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3825
3826         Add plumbing for a compatibility mode preference in WebKit
3827         https://bugs.webkit.org/show_bug.cgi?id=196005
3828
3829         Reviewed by Tim Horton.
3830
3831         Add new API tests.
3832
3833         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3834         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
3835
3836 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
3837
3838         [WPE][GTK] Update libsrtp dependency package for Debian
3839         https://bugs.webkit.org/show_bug.cgi?id=196528
3840
3841         Reviewed by Frédéric Wang.
3842
3843         * gtk/install-dependencies:
3844         * wpe/install-dependencies:
3845
3846 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3847
3848         [WK2] Add support for Window's beforeprint / afterprint events
3849         https://bugs.webkit.org/show_bug.cgi?id=196478
3850         <rdar://problem/49535124>
3851
3852         Unreviewed build fix for MSVC.
3853
3854         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
3855
3856         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
3857
3858         * WebKitTestRunner/TestController.cpp:
3859         (WTR::printFrame): Use int and float literals.
3860
3861 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3862
3863         [ews-build] Reassign bots to queues
3864
3865         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
3866
3867 2019-04-02  Chris Dumez  <cdumez@apple.com>
3868
3869         [WK2] Add support for Window's beforeprint / afterprint events
3870         https://bugs.webkit.org/show_bug.cgi?id=196478
3871
3872         Reviewed by Alex Christensen.
3873
3874         Add minimal implementation for printFrame in WebKitTestRunner.
3875
3876         * WebKitTestRunner/TestController.cpp:
3877         (WTR::printFrame):
3878         (WTR::TestController::createOtherPage):
3879         (WTR::TestController::createWebViewWithOptions):
3880
3881 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3882
3883         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
3884         https://bugs.webkit.org/show_bug.cgi?id=196491
3885
3886         Reviewed by Lucas Forschler.
3887
3888         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3889
3890 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3891
3892         [ews-build] Configure buildbot try credentials in environment variables
3893         https://bugs.webkit.org/show_bug.cgi?id=196501
3894
3895         Reviewed by Lucas Forschler.
3896
3897         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
3898         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
3899         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
3900
3901 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3902
3903         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
3904         https://bugs.webkit.org/show_bug.cgi?id=196496
3905         <rdar://problem/49521634>
3906
3907         Reviewed by Chris Dumez.
3908
3909         Add new API tests (see WebKit ChangeLog for more detail).
3910
3911         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3912         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3913         (TEST):
3914
3915 2019-04-02  David Kilzer  <ddkilzer@apple.com>
3916
3917         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
3918         <https://webkit.org/b/196499>
3919
3920         Reviewed by Alexey Proskuryakov.
3921
3922         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
3923         ENABLE_ADDRESS_SANITIZER.
3924
3925 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3926
3927         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
3928         https://bugs.webkit.org/show_bug.cgi?id=182757
3929
3930         Reviewed by Don Olmstead.
3931
3932         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
3933         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3934
3935 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
3936
3937         run-api-tests: Upload test results
3938         https://bugs.webkit.org/show_bug.cgi?id=196323
3939         <rdar://problem/49356714>
3940
3941         Reviewed by Lucas Forschler.
3942
3943         * Scripts/webkitpy/api_tests/manager.py:
3944         (Manager):
3945         (Manager.run): Upload results to a results database.
3946         * Scripts/webkitpy/api_tests/run_api_tests.py:
3947         (parse_args): Add upload arguments.
3948         * Scripts/webkitpy/port/base.py:
3949         (Port):
3950         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
3951         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
3952         with commits from any other associated repositories.
3953         * Scripts/webkitpy/port/device.py:
3954         (Device):
3955         (Device.build_version): Access build_versoin of underlying platform device.
3956         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3957         (IOSSimulatorTest):
3958         (IOSSimulatorTest.test_configuration_for_upload):
3959         * Scripts/webkitpy/port/device_port.py:
3960         (DevicePort):
3961         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
3962         the same as the machine uploading results.
3963         * Scripts/webkitpy/port/mac.py:
3964         (MacPort):
3965         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3966         * Scripts/webkitpy/port/mac_unittest.py:
3967         (MacTest):
3968         (MacTest.test_configuration_for_upload):
3969         * Scripts/webkitpy/xcode/simulated_device.py:
3970         (SimulatedDeviceManager._create_device_with_runtime):
3971         (SimulatedDevice.__init__): Create simulated device with a build_version.
3972         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3973         (test_existing_simulator):
3974
3975 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3976
3977         Remove extra newline characters (Follow-up fix to r243707)
3978
3979         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3980
3981 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3982
3983         [ews-app] Use API_KEY to accept results data
3984         https://bugs.webkit.org/show_bug.cgi?id=196461
3985
3986         Reviewed by Dewei Zhu.
3987
3988         * BuildSlaveSupport/ews-app/ews/views/results.py:
3989         (Results.post): Validate EWS_API_KEY before accepting any data.
3990         * BuildSlaveSupport/ews-build/events.py:
3991         (Events.sendData): Send EWS_API_KEY if available along with event data.
3992
3993 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3994
3995         Unable to copy and paste a PDF from Notes into Mail compose body
3996         https://bugs.webkit.org/show_bug.cgi?id=196442
3997         <rdar://problem/48573098>
3998
3999         Reviewed by Tim Horton.
4000
4001         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
4002         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
4003         to be specified on the item providers.
4004
4005         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4006         (TestWebKitAPI::mapItemForTesting):
4007         (TestWebKitAPI::contactItemForTesting):
4008
4009 2019-04-01  Tim Horton  <timothy_horton@apple.com>
4010
4011         Make UIWKDocumentContext rects per-character instead of per-word
4012         https://bugs.webkit.org/show_bug.cgi?id=196459
4013
4014         Reviewed by Wenson Hsieh.
4015
4016         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4017         (TEST):
4018         Adjust test results due to switching to per-character rects.
4019
4020 2019-04-01  Chris Dumez  <cdumez@apple.com>
4021
4022         UIProcess crash when a prewarmed process is terminated
4023         https://bugs.webkit.org/show_bug.cgi?id=196451
4024         <rdar://problem/49245471>
4025
4026         Reviewed by Geoffrey Garen.
4027
4028         Add API test coverage.
4029
4030         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
4031         (TEST):
4032
4033 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
4034
4035         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
4036         https://bugs.webkit.org/show_bug.cgi?id=196449
4037
4038         Reviewed by Lucas Forschler.
4039
4040         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4041         (StatusBubble.get_os_details): Method to get OS and Xcode details.
4042         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
4043         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
4044
4045 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
4046
4047         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
4048         https://bugs.webkit.org/show_bug.cgi?id=196444
4049
4050         Reviewed by Lucas Forschler.
4051
4052         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
4053
4054 2019-04-01  Alex Christensen  <achristensen@webkit.org>
4055
4056         Add SPI to canonicalize NSURLs with WTF::URL
4057         https://bugs.webkit.org/show_bug.cgi?id=196415
4058         <rdar://problem/44980271>
4059
4060         Reviewed by Darin Adler.
4061
4062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4063         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
4064         (TestWebKitAPI::TEST):
4065
4066 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
4067
4068         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
4069         https://bugs.webkit.org/show_bug.cgi?id=196441
4070
4071         Reviewed by Carlos Garcia Campos.
4072
4073         Don't cache the wpe_view_backend object that might not exist yet at the
4074         time of EventSenderProxy constructor invocation, but instead retrieve
4075         that object whenever it's required for event dispatching. This should
4076         avoid crashes in this constructor now that it's invoked before any
4077         PlatformWindow has been set up (as changed in r243496).
4078
4079         * WebKitTestRunner/EventSenderProxy.h:
4080         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
4081         (WTR::viewBackend):
4082         (WTR::EventSenderProxy::EventSenderProxy):
4083         (WTR::EventSenderProxy::mouseDown):
4084         (WTR::EventSenderProxy::mouseUp):
4085         (WTR::EventSenderProxy::mouseMoveTo):
4086         (WTR::EventSenderProxy::mouseScrollBy):
4087         (WTR::EventSenderProxy::keyDown):
4088         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
4089
4090 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
4091
4092         [Win][WebKit] MiniBrowser should support high DPI display
4093         https://bugs.webkit.org/show_bug.cgi?id=196391
4094
4095         Reviewed by Alex Christensen.
4096
4097         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4098         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
4099         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
4100         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
4101
4102 2019-03-31  Sam Weinig  <weinig@apple.com>
4103
4104         Remove more i386 specific configurations
4105         https://bugs.webkit.org/show_bug.cgi?id=196430
4106
4107         Reviewed by Alexey Proskuryakov.
4108
4109         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4110         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
4111
4112 2019-03-31  Andy Estes  <aestes@apple.com>
4113
4114         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
4115         https://bugs.webkit.org/show_bug.cgi?id=196433
4116         <rdar://problem/49293305>
4117
4118         Reviewed by Tim Horton.
4119
4120         Enhanced API test coverage to include all navigation response policy decisions in both
4121         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
4122
4123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4124         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
4125         (TestWebKitAPI::TEST):
4126         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
4127         (readFile):
4128         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
4129         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
4130         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4131         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4132         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4133         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
4134         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
4135         (-[QuickLookDelegate _downloadDidStart:]):
4136         (-[QuickLookDelegate _download:didReceiveResponse:]):
4137         (-[QuickLookDelegate _download:didReceiveData:]):
4138         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4139         (-[QuickLookDelegate _downloadDidFinish:]):
4140         (-[QuickLookDelegate _download:didFailWithError:]):
4141         (-[QuickLookDelegate _downloadDidCancel:]):
4142         (-[QuickLookDelegate verifyDownload]):
4143         (runTest):
4144         (runTestDecideBeforeLoading):
4145         (runTestDecideAfterLoading):
4146         (TEST):
4147         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4148         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4149         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
4150         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
4151         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
4152         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
4153         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
4154         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
4155         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
4156         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
4157         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
4158         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
4159         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
4160         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
4161
4162 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
4163
4164         [CMake] add testdfg as target with build-jsc
4165         https://bugs.webkit.org/show_bug.cgi?id=196393
4166
4167         Reviewed by Saam Barati.
4168
4169         Added testdfg as one of the targets to build when
4170         using CMake.
4171
4172         * Scripts/build-jsc:
4173
4174 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
4175
4176         Delete WebMetal implementation in favor of WebGPU
4177         https://bugs.webkit.org/show_bug.cgi?id=195418
4178
4179         Reviewed by Dean Jackson.
4180
4181         * DumpRenderTree/mac/DumpRenderTree.mm:
4182         (enableExperimentalFeatures):
4183         (resetWebPreferencesToConsistentValues):
4184         * Scripts/webkitperl/FeatureList.pm:
4185         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4187         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
4188         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
4189         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
4190         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
4191         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
4192         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
4193         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
4194         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4195         (WTR::InjectedBundle::beginTesting):
4196         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4197         (WTR::TestRunner::setWebMetalEnabled): Deleted.
4198         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4199
4200 2019-03-29  Chris Dumez  <cdumez@apple.com>
4201
4202         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
4203         https://bugs.webkit.org/show_bug.cgi?id=196405
4204         <rdar://problem/49428130>
4205
4206         Reviewed by Wenson Hsieh.
4207
4208         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
4209         the popover presentation methods to be no-ops. Use this in the new test added in
4210         r243523 so that we do not swizzle those methods for all tests. This is needed because
4211         those WatchOS tests rely on the popover getting presented and interactive.
4212
4213         * WebKitTestRunner/TestController.cpp:
4214         (WTR::updateTestOptionsFromTestHeader):
4215         * WebKitTestRunner/TestController.h:
4216         * WebKitTestRunner/TestOptions.h:
4217         (WTR::TestOptions::hasSameInitializationOptions const):
4218         * WebKitTestRunner/ios/TestControllerIOS.mm:
4219         (WTR::TestController::platformInitialize):
4220         (WTR::TestController::platformResetStateToConsistentValues):
4221
4222 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
4223
4224         [Curl] Add Server Trust Evaluation Support.
4225         https://bugs.webkit.org/show_bug.cgi?id=191646
4226
4227         Reviewed by Fujii Hironori.
4228
4229         Implemented MiniBrowser UI for asking if user trusts the server.
4230
4231         * MiniBrowser/win/Common.cpp:
4232         (askServerTrustEvaluation):
4233         (replaceString):
4234         * MiniBrowser/win/Common.h:
4235         * MiniBrowser/win/MiniBrowserLib.rc:
4236         * MiniBrowser/win/MiniBrowserLibResource.h:
4237         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4238         (createPEMString):
4239         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4240         (WebKitBrowserWindow::canTrustServerCertificate):
4241         * MiniBrowser/win/WebKitBrowserWindow.h:
4242
4243 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
4244
4245         Implement ResizeObserver.
4246         https://bugs.webkit.org/show_bug.cgi?id=157743
4247
4248         Reviewed by Simon Fraser.
4249
4250         Support resizeObserverEnabled webPreferences.
4251
4252         * DumpRenderTree/TestOptions.cpp:
4253         (TestOptions::TestOptions):
4254         * DumpRenderTree/TestOptions.h:
4255         * DumpRenderTree/mac/DumpRenderTree.mm:
4256         (setWebPreferencesForTestOptions):
4257         * DumpRenderTree/win/DumpRenderTree.cpp:
4258         (enableExperimentalFeatures):
4259         * Scripts/webkitperl/FeatureList.pm:
4260         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4261
4262 2019-03-28  John Wilander  <wilander@apple.com>
4263
4264         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
4265         https://bugs.webkit.org/show_bug.cgi?id=196281
4266         <rdar://problem/48938748>
4267
4268         Reviewed by Alex Christensen.
4269
4270         This patch adds the function isStatisticsHasLocalStorage() to the
4271         TestRunner. With it, the page can query the WebsiteDataStore in the
4272         UI process to make sure that it sees LocalStorage.
4273
4274         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4275         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4276         (WTR::TestRunner::isStatisticsHasLocalStorage):
4277         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4278         * WebKitTestRunner/TestController.cpp:
4279         (WTR::TestController::isStatisticsHasLocalStorage):
4280         * WebKitTestRunner/TestController.h:
4281         * WebKitTestRunner/TestInvocation.cpp:
4282         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4283
4284 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
4285
4286         API::Data::createWithoutCopying should do a null check before calling CFRelease
4287         https://bugs.webkit.org/show_bug.cgi?id=196276
4288         <rdar://problem/48059859>
4289
4290         Reviewed by Alex Christensen.
4291
4292         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
4293
4294         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4295         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
4296         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
4297         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
4298         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4299         (TestWebKitAPI::TEST):
4300
4301 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
4302
4303         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
4304         https://bugs.webkit.org/show_bug.cgi?id=186276
4305
4306         Reviewed by Carlos Garcia Campos.
4307
4308         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
4309         (webViewLoadChanged):
4310         (testWebResourceGetDataError):