[Mac] WebInspectorUI.framework does not need to be soft-linked anymore
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-14  Brian Burg  <bburg@apple.com>
2
3         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4         https://bugs.webkit.org/show_bug.cgi?id=194411
5         <rdar://problem/47787614>
6
7         Reviewed by Joseph Pecoraro.
8
9         Remove unnecessary soft linking macro usage.
10
11         * DumpRenderTree/mac/TestRunnerMac.mm:
12         (TestRunner::inspectorTestStubURL):
13         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
14         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
15         (WTR::TestRunner::inspectorTestStubURL):
16
17 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
18
19         [ews-app] status bubble should fetch builder name info from BuilderMapping table
20         https://bugs.webkit.org/show_bug.cgi?id=194599
21
22         Reviewed by Lucas Forschler.
23
24         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
25         (StatusBubble._build_bubble):
26
27 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
28
29         [ews-app] Set Foreign Key in Django build model
30         https://bugs.webkit.org/show_bug.cgi?id=194667
31
32         Reviewed by Lucas Forschler.
33
34         * BuildSlaveSupport/ews-app/ews/models/build.py:
35         (Build):
36
37 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
38
39         [WTF] Add environment variable helpers
40         https://bugs.webkit.org/show_bug.cgi?id=192405
41
42         Reviewed by Michael Catanzaro.
43
44         * DumpRenderTree/mac/DumpRenderTree.mm:
45         (libraryPathForDumpRenderTree):
46         * DumpRenderTree/win/DumpRenderTree.cpp:
47         (libraryPathForDumpRenderTree):
48         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
49         (setUpIOSLayoutTestCommunication):
50         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
51         (TestWebKitAPI::strip):
52         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
53         (beforeAll):
54         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
55         (main):
56         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
57         (WebKitTestBus::run):
58         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
59         (WTR::getOutputDir):
60         (WTR::initializeFontConfigSetting):
61         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
62         (WTR::InjectedBundle::platformInitialize):
63         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
64         (WTR::topLevelPath):
65         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
66         (WTR::topLevelPath):
67         (WTR::getOutputDir):
68         (WTR::activateFonts):
69         * WebKitTestRunner/TestController.cpp:
70         (WTR::TestController::libraryPathForTesting):
71         (WTR::TestController::generateContextConfiguration const):
72         (WTR::TestController::generatePageConfiguration):
73         (WTR::TestController::decideDestinationWithSuggestedFilename):
74         (WTR::TestController::platformAdjustContext):
75         * WebKitTestRunner/TestController.h:
76         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
77         (WTR::TestController::cocoaPlatformInitialize):
78         (WTR::TestController::platformAdjustContext):
79         * WebKitTestRunner/gtk/main.cpp:
80         (main):
81         * WebKitTestRunner/mac/TestControllerMac.mm:
82         (WTR::TestController::configureContentExtensionForTest):
83         * WebKitTestRunner/wpe/main.cpp:
84         (main):
85         Utilize WTF::Environment where possible.
86
87 2019-02-14  Chris Dumez  <cdumez@apple.com>
88
89         [PSON] Introduce a WebContent Process cache
90         https://bugs.webkit.org/show_bug.cgi?id=194594
91         <rdar://problem/46793397>
92
93         Reviewed by Geoff Garen.
94
95         Update API tests to turn on the WebContent Process cache.
96
97         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
98
99 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
100
101         Unreviewed, build fix after r241480
102
103         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
104         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
105         (-[DragAndDropSimulator initWithWebView:]):
106
107 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
108
109         AX: ARIA Reflection was disabled in error
110         https://bugs.webkit.org/show_bug.cgi?id=194647
111         <rdar://problem/48068336>
112
113         Reviewed by Ryosuke Niwa.
114
115         Remove test override now that this feature should be enabled by default.
116
117         * WebKitTestRunner/TestController.cpp:
118         (WTR::TestController::resetPreferencesToConsistentValues):
119
120 2019-02-14  Commit Queue  <commit-queue@webkit.org>
121
122         Unreviewed, rolling out r241486.
123         https://bugs.webkit.org/show_bug.cgi?id=194655
124
125         causing API failures in builds (Requested by ShawnRoberts on
126         #webkit).
127
128         Reverted changeset:
129
130         "[Cocoa] Media elements will restart network buffering just
131         before suspending"
132         https://bugs.webkit.org/show_bug.cgi?id=193691
133         https://trac.webkit.org/changeset/241486
134
135 2019-02-14  Zalan Bujtas  <zalan@apple.com>
136
137         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
138         https://bugs.webkit.org/show_bug.cgi?id=194622
139
140         Reviewed by Antti Koivisto.
141
142         * LayoutReloaded/misc/LFC-passing-tests.txt:
143
144 2019-02-14  Zalan Bujtas  <zalan@apple.com>
145
146         [LFC] Shrink-to-fit-width should be constrained by min/max width
147         https://bugs.webkit.org/show_bug.cgi?id=194653
148
149         Reviewed by Antti Koivisto.
150
151         * LayoutReloaded/misc/LFC-passing-tests.txt:
152
153 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
154
155         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
156         https://bugs.webkit.org/show_bug.cgi?id=194641
157
158         Reviewed by Geoffrey Garen.
159
160         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
161         so that the test would fail without this fix.
162
163         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
164         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
165
166 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
167
168         [ews-app] Change log level for a log statement
169
170         Unreviewed minor fix.
171
172         * BuildSlaveSupport/ews-app/ews/models/patch.py:
173         (Patch.save_patch):
174
175 2019-02-13  Jer Noble  <jer.noble@apple.com>
176
177         [Cocoa] Media elements will restart network buffering just before suspending
178         https://bugs.webkit.org/show_bug.cgi?id=193691
179
180         Reviewed by Eric Carlson.
181
182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
183         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
184         (TEST):
185
186 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
187
188         [ews-app] Fetch builder id to name mapping
189         https://bugs.webkit.org/show_bug.cgi?id=194355
190
191         Reviewed by Lucas Forschler.
192
193         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
194         (Buildbot.get_builder_id_to_name_mapping):
195         (Buildbot._get_display_name_from_builder_name):
196
197 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
198
199         Further restricting webarchive loads
200         https://bugs.webkit.org/show_bug.cgi?id=194567
201         <rdar://problem/47610130>
202
203         Reviewed by Youenn Fablet.
204
205         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
206         navigations on drop.
207
208         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
209         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
210         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
211         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
212         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
213         (TestWebKitAPI::TEST):
214         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
215         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
216         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
217         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
218         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
219         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
220         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
221
222 2019-02-13  John Wilander  <wilander@apple.com>
223
224         Store Ad Click Attribution requests in the network process
225         https://bugs.webkit.org/show_bug.cgi?id=194510
226         <rdar://problem/47650118>
227
228         Reviewed by Alex Christensen and Daniel Bates.
229
230         This patch adds two TestRunner functions:
231         - dumpAdClickAttribution()
232         - clearAdClickAttribution()
233
234         They call into the network process to dump and clear Ad Click
235         Attribution state, respectively.
236
237         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
238         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
239         (WTR::TestRunner::dumpAdClickAttribution):
240         (WTR::TestRunner::clearAdClickAttribution):
241         * WebKitTestRunner/InjectedBundle/TestRunner.h:
242         * WebKitTestRunner/TestController.cpp:
243         (WTR::TestController::resetStateToConsistentValues):
244         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
245         (WTR::adClickAttributionStringResultCallback):
246         (WTR::TestController::dumpAdClickAttribution):
247         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
248         (WTR::adClickAttributionVoidCallback):
249         (WTR::TestController::clearAdClickAttribution):
250         * WebKitTestRunner/TestController.h:
251         * WebKitTestRunner/TestInvocation.cpp:
252         (WTR::TestInvocation::dumpResults):
253         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
254         (WTR::TestInvocation::dumpAdClickAttribution):
255         * WebKitTestRunner/TestInvocation.h:
256
257 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
258
259         [ews-app] Generate status-bubble
260         https://bugs.webkit.org/show_bug.cgi?id=194572
261
262         Reviewed by Lucas Forschler.
263
264         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
265         (StatusBubble._build_bubble):
266         (StatusBubble._should_show_bubble_for):
267         (StatusBubble._build_bubbles_for_patch):
268
269 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
270
271         [ews-app] Add status bubble html template
272         https://bugs.webkit.org/show_bug.cgi?id=194571
273
274         Reviewed by Lucas Forschler.
275
276         * BuildSlaveSupport/ews-app/ews/templates: Added.
277         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
278
279 2019-02-12  Chris Dumez  <cdumez@apple.com>
280
281         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
282         https://bugs.webkit.org/show_bug.cgi?id=194568
283         <rdar://problem/47944490>
284
285         Reviewed by Ryosuke Niwa.
286
287         Add API test coverage.
288
289         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
290         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
291
292 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
293
294         webkitpy: Remove bug_dummy from parsed test expectations
295         https://bugs.webkit.org/show_bug.cgi?id=194562
296         <rdar://problem/47853999>
297
298         Reviewed by Lucas Forschler.
299
300         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
301         (TestExpectationParser):
302         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
303         skipped tests.
304         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
305
306 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
307
308         [ews-app] Add method to fetch patch
309         https://bugs.webkit.org/show_bug.cgi?id=194518
310
311         Reviewed by Lucas Forschler.
312
313         * BuildSlaveSupport/ews-app/ews/models/patch.py:
314         (Patch.get_patch):
315
316 2019-02-12  Zalan Bujtas  <zalan@apple.com>
317
318         [LFC] Expand tests coverage (60 new tests -> 860)
319
320         Unreviewed test gardening (run-singly, --child-processes=1).
321
322         * LayoutReloaded/misc/LFC-passing-tests.txt:
323
324 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
325
326         Allow pages to trigger programmatic paste from script on iOS
327         https://bugs.webkit.org/show_bug.cgi?id=194271
328         <rdar://problem/47808810>
329
330         Reviewed by Tim Horton.
331
332         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
333
334         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
335         (WTR::UIScriptController::platformSetDidShowMenuCallback):
336         (WTR::UIScriptController::platformSetDidHideMenuCallback):
337         (WTR::UIScriptController::rectForMenuAction const):
338
339         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
340         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
341         for when the menu is shown or hidden.
342
343         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
344         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
345         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
346         (WTR::UIScriptController::setDidShowMenuCallback):
347         (WTR::UIScriptController::didShowMenuCallback const):
348         (WTR::UIScriptController::setDidHideMenuCallback):
349         (WTR::UIScriptController::didHideMenuCallback const):
350         (WTR::UIScriptController::platformSetDidShowMenuCallback):
351         (WTR::UIScriptController::platformSetDidHideMenuCallback):
352         (WTR::UIScriptController::rectForMenuAction const):
353         * TestRunnerShared/UIScriptContext/UIScriptController.h:
354         * WebKitTestRunner/TestController.cpp:
355         (WTR::TestController::resetPreferencesToConsistentValues):
356         (WTR::updateTestOptionsFromTestHeader):
357         * WebKitTestRunner/TestOptions.h:
358
359         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
360         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
361
362         (WTR::TestOptions::hasSameInitializationOptions const):
363         * WebKitTestRunner/UIScriptControllerCocoa.mm:
364         (WTR::UIScriptController::calendarType const):
365         (WTR::UIScriptController::platformUndoManager const):
366         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
367         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
368         (-[TestRunnerWKWebView initWithFrame:configuration:]):
369         (-[TestRunnerWKWebView dealloc]):
370         (-[TestRunnerWKWebView _didShowMenu]):
371         (-[TestRunnerWKWebView _didHideMenu]):
372
373         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
374
375         * WebKitTestRunner/ios/TestControllerIOS.mm:
376         (WTR::handleMenuWillHideNotification):
377         (WTR::handleMenuDidHideNotification):
378         (WTR::TestController::platformInitialize):
379         (WTR::TestController::platformDestroy):
380         (WTR::TestController::platformResetStateToConsistentValues):
381
382         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
383         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
384
385         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
386         (WTR::forEachViewInHierarchy):
387         (WTR::findViewInHierarchyOfType):
388
389         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
390         functions that dig through a given view's hierarchy in search of a view of a given class.
391
392         (WTR::UIScriptController::selectionStartGrabberViewRect const):
393         (WTR::UIScriptController::selectionEndGrabberViewRect const):
394         (WTR::UIScriptController::selectionCaretViewRect const):
395         (WTR::UIScriptController::selectionRangeViewRects const):
396         (WTR::UIScriptController::platformSetDidShowMenuCallback):
397         (WTR::UIScriptController::platformSetDidHideMenuCallback):
398
399         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
400
401         (WTR::UIScriptController::rectForMenuAction const):
402
403         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
404         callout bar) whose label matches the given string.
405
406         (WTR::UIScriptController::platformContentView const):
407
408         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
409         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
410         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
411
412         (WTR::UIScriptController::platformUndoManager const): Deleted.
413         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
414         (WTR::UIScriptController::platformContentView const):
415         (WTR::UIScriptController::platformUndoManager const): Deleted.
416
417 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
418
419         webkitpy: No option to only show unexpected failures in results.html for iPad
420         https://bugs.webkit.org/show_bug.cgi?id=194554
421         <rdar://problem/47922442>
422
423         Rubber-stamped by Aakash Jain.
424
425         Just because a TestExpecations file does not exist for a specific platform does not mean that
426         TestExpecations are not being used, given that platforms inherit test expectations.
427
428         * Scripts/webkitpy/port/base.py:
429         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
430         * Scripts/webkitpy/port/base_unittest.py:
431         (PortTest.test_uses_test_expectations_file):
432
433 2019-02-12  Alex Christensen  <achristensen@webkit.org>
434
435         Remove setDefersLoading infrastructure from WebKit2
436         https://bugs.webkit.org/show_bug.cgi?id=194506
437
438         Reviewed by Brady Eidson.
439
440         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
441         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
442         (WTR::TestRunner::setDefersLoading): Deleted.
443         * WebKitTestRunner/InjectedBundle/TestRunner.h:
444
445 2019-02-12  Alex Christensen  <achristensen@webkit.org>
446
447         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
448         https://bugs.webkit.org/show_bug.cgi?id=194522
449         <rdar://problem/47789393>
450
451         Reviewed by Chris Dumez.
452
453         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
454         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
455         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
456         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
457
458 2019-02-12  Andy Estes  <aestes@apple.com>
459
460         [iOSMac] Enable Parental Controls Content Filtering
461         https://bugs.webkit.org/show_bug.cgi?id=194521
462         <rdar://39732376>
463
464         Reviewed by Tim Horton.
465
466         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
467
468 2019-02-12  Zalan Bujtas  <zalan@apple.com>
469
470         [LFC][IFC] Add intrinsic width support for float boxes.
471         https://bugs.webkit.org/show_bug.cgi?id=194528
472
473         Reviewed by Antti Koivisto.
474
475         Expand tests coverage (2 new tests -> 800).
476         (This is the correct test ordering --runs-singly --child-processes=1)
477
478         * LayoutReloaded/misc/LFC-passing-tests.txt:
479
480 2019-02-12  Rob Buis  <rbuis@igalia.com>
481
482         Implement serializing in MIME type parser
483         https://bugs.webkit.org/show_bug.cgi?id=193909
484
485         Reviewed by Darin Adler.
486
487         Add various tests involving upper case, non-ASCII, control/null characters,
488         various HTTP whitespace, single quotes and an unpaired surrogate.
489
490         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
491         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
492         (TestWebKitAPI::serializeIfValid):
493         (TestWebKitAPI::TEST):
494
495 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
496
497         [Cocoa] Ask platform for generic font family mappings
498         https://bugs.webkit.org/show_bug.cgi?id=187723
499         <rdar://problem/41892438>
500
501         Reviewed by Brent Fulgham.
502
503         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
504
505         * DumpRenderTree/mac/DumpRenderTree.mm:
506         (allowedFontFamilySet):
507         * WebKitTestRunner/mac/TestControllerMac.mm:
508         (WTR::allowedFontFamilySet):
509
510 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
511
512         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
513         https://bugs.webkit.org/show_bug.cgi?id=193622
514
515         Reviewed by Michael Catanzaro.
516
517         This adds support for loading content extension rule sets from the JSON files which
518         accompany the corresponding layout test, using the C API. The Cocoa specific parts
519         of WKTR for this could be removed, but that is left for a follow-up patch with
520         cleanups.
521
522         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
523         * WebKitTestRunner/TestController.cpp:
524         (WTR::testPath): Subtract one from the length when constructing the result std::string to
525         avoid having the null-terminator copied into the result.
526         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
527         part of the preparations to run a test.
528         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
529         (WTR::contentExtensionStoreCallback): Added.
530         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
531         used for content extensions test.
532         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
533         extensions and compiling the JSON rule set for tests involving content extensions.
534         (WTR::TestController::resetContentExtensions): Removes the content extension built for
535         testing and disables content extensions.
536         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
537         resetContentExtensions().
538         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
539         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
540         configureContentExtensionForTest(), and userContentController().
541
542 2019-02-11  Daniel Bates  <dabates@apple.com>
543
544         [iOS] Mouse/Touch/Pointer events are missing modifier keys
545         https://bugs.webkit.org/show_bug.cgi?id=191446
546         <rdar://problem/45929460>
547
548         Reviewed by Tim Horton.
549
550         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
551
552         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
553         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
554         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
555         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
556         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
557         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
558         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
559         * TestRunnerShared/UIScriptContext/UIScriptController.h:
560         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
561         (WTR::arrayLength):
562         (WTR::parseModifierArray):
563         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
564         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
565         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
566         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
567
568 2019-02-11  Commit Queue  <commit-queue@webkit.org>
569
570         Unreviewed, rolling out r241272 and r241276.
571         https://bugs.webkit.org/show_bug.cgi?id=194514
572
573         Broke the Apple Internal build and the fix requires human
574         intervention :( (Requested by dydz on #webkit).
575
576         Reverted changesets:
577
578         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
579         https://bugs.webkit.org/show_bug.cgi?id=191446
580         https://trac.webkit.org/changeset/241272
581
582         "Fix internal iOS build after r241272"
583         https://bugs.webkit.org/show_bug.cgi?id=191446
584         https://trac.webkit.org/changeset/241276
585
586 2019-02-11  Truitt Savell  <tsavell@apple.com>
587
588         Unreviewed, rolling out r241269.
589
590         Caused 5 layout tests crashes on Mac WK1
591
592         Reverted changeset:
593
594         "DumpRenderTree should report unknown options"
595         https://bugs.webkit.org/show_bug.cgi?id=191303
596         https://trac.webkit.org/changeset/241269
597
598 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
599
600         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
601         https://bugs.webkit.org/show_bug.cgi?id=194313
602
603         Reviewed by Tim Horton.
604
605         Add a helper to determine whether the web view is presenting modal UI.
606
607         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
608         (WTR::UIScriptController::isPresentingModally const):
609         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
610         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
611         (WTR::UIScriptController::isPresentingModally const):
612         * TestRunnerShared/UIScriptContext/UIScriptController.h:
613         * WebKitTestRunner/UIScriptControllerCocoa.mm:
614         (WTR::UIScriptController::calendarType const): Deleted.
615         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
616         (WTR::UIScriptController::isPresentingModally const):
617         (WTR::UIScriptController::calendarType const):
618         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
619         (WTR::UIScriptController::calendarType const):
620
621 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
622
623         GCHeapInspector: Show the retained sizes in more places
624         https://bugs.webkit.org/show_bug.cgi?id=194464
625
626         Reviewed by Simon Fraser.
627
628         * GCHeapInspector/gc-heap-inspector.html:
629         * GCHeapInspector/script/interface.js:
630         (HeapInspectorUtils.humanReadableSize):
631         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
632         (HeapInspectorUtils.spanForNode.span.span):
633         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
634         (HeapSnapshotInspector.prototype.buildRoots):
635
636 2019-02-11  Daniel Bates  <dabates@apple.com>
637
638         [iOS] Mouse/Touch/Pointer events are missing modifier keys
639         https://bugs.webkit.org/show_bug.cgi?id=191446
640         <rdar://problem/45929460>
641
642         Reviewed by Tim Horton.
643
644         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
645
646         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
647         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
648         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
649         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
650         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
651         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
652         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
653         * TestRunnerShared/UIScriptContext/UIScriptController.h:
654         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
655         (WTR::arrayLength):
656         (WTR::parseModifierArray):
657         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
658         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
659         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
660         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
661
662 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
663
664         DumpRenderTree should report unknown options
665         https://bugs.webkit.org/show_bug.cgi?id=191303
666
667         Reviewed by Frédéric Wang.
668
669         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
670         to report unknown options.
671         Added and assigned test options which are currently used in tests.
672
673         * DumpRenderTree/TestOptions.cpp:
674         (TestOptions::TestOptions):
675
676 2019-02-11  Truitt Savell  <tsavell@apple.com>
677
678         Unreviewed, rolling out r241229.
679
680         Revision broke internal builds for watchOS.
681
682         Reverted changeset:
683
684         "[Cocoa] Ask platform for generic font family mappings"
685         https://bugs.webkit.org/show_bug.cgi?id=187723
686         https://trac.webkit.org/changeset/241229
687
688 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
689
690         [WinCairo][MiniBrowser] Basic authentication always fails.
691         https://bugs.webkit.org/show_bug.cgi?id=194496
692
693         Reviewed by Don Olmstead.
694
695         * MiniBrowser/win/DialogHelper.h:
696         (Dialog::getText):
697
698 2019-02-11  Philippe Normand  <pnormand@igalia.com>
699
700         [GStreamer] GstMappedBuffer testsuite build fails
701         https://bugs.webkit.org/show_bug.cgi?id=194495
702
703         Reviewed by Carlos Garcia Campos.
704
705         Fix the build by explicitely adding the gstreamer1.0-audio include
706         directories to the include path.
707
708         * TestWebKitAPI/PlatformGTK.cmake:
709         * TestWebKitAPI/PlatformWPE.cmake:
710
711 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
712
713         [GTK][WPE] Add enable-javascript-markup setting
714         https://bugs.webkit.org/show_bug.cgi?id=193439
715
716         Reviewed by Michael Catanzaro.
717
718         Add test cases to check the new setting.
719
720         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
721         (testWebKitSettings):
722         (testWebKitSettingsJavaScriptMarkup):
723         (beforeAll):
724
725 2019-02-10  Darin Adler  <darin@apple.com>
726
727         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
728         https://bugs.webkit.org/show_bug.cgi?id=194485
729
730         Reviewed by Daniel Bates.
731
732         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
733
734 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
735
736         Add more tests for clampTo<>()
737         https://bugs.webkit.org/show_bug.cgi?id=194462
738
739         Reviewed by Geoffrey Garen.
740
741         Darin suggested to test the very last floating point number
742         at the boundaries when truncating to integer.
743         I added test for max/min and max-1/min-1.
744
745         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
746         (TestWebKitAPI::TEST):
747
748 2019-02-09  Darin Adler  <darin@apple.com>
749
750         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
751         https://bugs.webkit.org/show_bug.cgi?id=194021
752
753         Reviewed by Geoffrey Garen.
754
755         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
756         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
757         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
758
759 2019-02-09  Zalan Bujtas  <zalan@apple.com>
760
761         [LFC][IFC] Add intrinsic width support for basic inline containers
762         https://bugs.webkit.org/show_bug.cgi?id=194473
763
764         Reviewed by Antti Koivisto.
765
766         Expand tests coverage (11 new tests -> 798)
767
768         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
769
770 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
771
772         Fix MiniBrowser's entitlements
773         https://bugs.webkit.org/show_bug.cgi?id=192431
774
775         Reviewed by Joseph Pecoraro.
776
777         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
778         files, making it impossible to load any extension.
779
780         * MiniBrowser/MiniBrowser.entitlements:
781
782 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
783
784         [Cocoa] Ask platform for generic font family mappings
785         https://bugs.webkit.org/show_bug.cgi?id=187723
786         <rdar://problem/41892438>
787
788         Reviewed by Brent Fulgham.
789
790         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
791
792         * DumpRenderTree/mac/DumpRenderTree.mm:
793         (allowedFontFamilySet):
794         * WebKitTestRunner/mac/TestControllerMac.mm:
795         (WTR::allowedFontFamilySet):
796
797 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
798
799         [GTK] Implement back/forward touchpad gesture
800         https://bugs.webkit.org/show_bug.cgi?id=193919
801
802         Reviewed by Michael Catanzaro.
803
804         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
805         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
806
807 2019-02-08  Alex Christensen  <achristensen@webkit.org>
808
809         Add SPI to use networking daemon instead of XPC service
810         https://bugs.webkit.org/show_bug.cgi?id=194427
811
812         Reviewed by Geoffrey Garen
813
814         * MiniBrowser/MiniBrowser.entitlements:
815
816 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
817
818         [ews-build] Ensure that every builder in config.json has short name
819         https://bugs.webkit.org/show_bug.cgi?id=194461
820
821         Reviewed by Lucas Forschler.
822
823         * BuildSlaveSupport/ews-build/loadConfig.py:
824         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
825
826 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
827
828         [ews-build] Add short name to config.json
829         https://bugs.webkit.org/show_bug.cgi?id=194456
830
831         Reviewed by Lucas Forschler.
832
833         * BuildSlaveSupport/ews-build/config.json: Added short name.
834         * BuildSlaveSupport/ews-build/loadConfig.py:
835         (loadBuilderConfig): Set the short name as the builder description.
836
837 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
838
839         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
840         https://bugs.webkit.org/show_bug.cgi?id=194418
841
842         Reviewed by Lucas Forschler.
843
844         Do not include errors trying when finding crashlogs at the end of
845         a run-webkit-tests run since we don't process those errors.
846
847         * Scripts/webkitpy/port/darwin.py:
848         (DarwinPort._look_for_all_crash_logs_in_log_dir):
849         * Scripts/webkitpy/port/ios_device.py:
850         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
851         * Scripts/webkitpy/port/watch_device.py:
852         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
853
854 2019-02-08  Beth Dakin  <bdakin@apple.com>
855
856         Add afterScreenUpdates to WKSnapshotConfiguration
857         https://bugs.webkit.org/show_bug.cgi?id=194362
858         -and corresponding-
859         <rdar://problem/40655528> Please add an "after screen updates" property to 
860         WKSnapshotConfiguration (to solve blank snapshots)
861
862         Reviewed by Tim Horton.
863
864         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
865         (TEST):
866
867 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
868
869         clampTo(): do not convert the input to double when dealing with integers
870         https://bugs.webkit.org/show_bug.cgi?id=194263
871         <rdar://problem/47692312>
872
873         Reviewed by Darin Adler.
874
875         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
876         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
877         (TestWebKitAPI::testClampFloatingPointToInteger):
878         (TestWebKitAPI::testClampSameSignIntegers):
879         (TestWebKitAPI::testClampUnsignedToSigned):
880         (TestWebKitAPI::testClampSignedToUnsigned):
881
882 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
883
884         webkitpy: Respect --dedicated-simulators flag
885         https://bugs.webkit.org/show_bug.cgi?id=194416
886         <rdar://problem/47894722>
887
888         Reviewed by Lucas Forschler.
889
890         * Scripts/webkitpy/port/device_port.py:
891         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
892         available devices can be safely ignored.
893
894 2019-02-07  Keith Rollin  <krollin@apple.com>
895
896         Remove extra copy of 100x100-red.tga
897         https://bugs.webkit.org/show_bug.cgi?id=194371
898         <rdar://problem/47873465>
899
900         Reviewed by Said Abou-Hallawa.
901
902         In order to help it pass its tests, Bug 194190 added a second copy of
903         the file 100x100-red.tga. However, it turns out that this additional
904         file wasn't actually needed, and that that sole previous copy was
905         sufficient. At the same time, this second copy -- which was copied to
906         the same location in the build output as the first copy -- now caused
907         XCBuild to complain because there were two production rules for the
908         same output file. Address this by removing the newly-added extra copy.
909
910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
911         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
912
913 2019-02-07  Alex Christensen  <achristensen@webkit.org>
914
915         Deprecate WKBundlePageSetDefersLoading
916         https://bugs.webkit.org/show_bug.cgi?id=191394
917
918         Reviewed by Dean Jackson.
919
920         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
921         (WTR::TestRunner::setDefersLoading):
922
923 2019-02-07  Zalan Bujtas  <zalan@apple.com>
924
925         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
926         https://bugs.webkit.org/show_bug.cgi?id=194391
927
928         Reviewed by Antti Koivisto.
929
930         * LayoutReloaded/misc/LFC-passing-tests.txt:
931
932 2019-02-06  Keith Rollin  <krollin@apple.com>
933
934         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
935         https://bugs.webkit.org/show_bug.cgi?id=193975
936         <rdar://problem/47643306>
937
938         Reviewed by Tim Horton.
939
940         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
941         the Info.plist file into the bundle. This step is not necessary as the
942         implicit "bundle up all the build products into a framework" build
943         phase does this already. Having the Copy Bundle Resources phase do
944         this causes a conflict under XCBuild, which objects to two build
945         phases producing the same file (Info.plist). Address this by removing
946         Info.plist from the Copy Bundle Resources phase.
947
948         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
949
950 2019-02-06  Keith Rollin  <krollin@apple.com>
951
952         Really enable the automatic checking and regenerations of .xcfilelists during builds
953         https://bugs.webkit.org/show_bug.cgi?id=194357
954         <rdar://problem/47861231>
955
956         Reviewed by Chris Dumez.
957
958         Bug 194124 was supposed to enable the automatic checking and
959         regenerating of .xcfilelist files during the build. While related
960         changes were included in that patch, the change to actually enable the
961         operation somehow was omitted. This patch actually enables the
962         operation. The check-xcfilelist.sh scripts now check
963         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
964         from the checking.
965
966         * DumpRenderTree/Scripts/check-xcfilelists.sh:
967         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
968
969 2019-02-06  David Kilzer  <ddkilzer@apple.com>
970
971         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
972         <https://webkit.org/b/194286>
973         <rdar://problem/47815558>
974
975         Reviewed by Alexey Proskuryakov.
976
977         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
978         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
979         WKRetainPtr<> to avoid leaking the WKDataRef.
980
981 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
982
983         Unreviewed, fix a typo
984
985         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
986
987 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
988
989         [GTK][WPE] force libpsl build to use ICU in jhbuild
990         https://bugs.webkit.org/show_bug.cgi?id=194288
991
992         Reviewed by Carlos Garcia Campos.
993
994         * gtk/jhbuild.modules:
995         Require ICU for libpsl build in jhbuild, like done in WPE.
996
997 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
998
999         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1000         https://bugs.webkit.org/show_bug.cgi?id=194209
1001
1002         Reviewed by Carlos Garcia Campos.
1003
1004         Enhance TestCookieManager to ensure this doesn't happen again.
1005
1006         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1007         (testCookieManagerPersistentStorage):
1008         (beforeAll):
1009
1010 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1011
1012         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1013         https://bugs.webkit.org/show_bug.cgi?id=194324
1014
1015         Reviewed by Andy Estes.
1016
1017         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1018         part of the name is already implicit, since this is in testing code in TestOptions.
1019
1020         * WebKitTestRunner/TestController.cpp:
1021         (WTR::TestController::generateContextConfiguration const):
1022         (WTR::updateTestOptionsFromTestHeader):
1023         * WebKitTestRunner/TestOptions.h:
1024         (WTR::TestOptions::hasSameInitializationOptions const):
1025
1026 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1027
1028         [ews-build] Allow * as platform for builders and workers
1029         https://bugs.webkit.org/show_bug.cgi?id=188533
1030
1031         Reviewed by Lucas Forschler.
1032
1033         * BuildSlaveSupport/ews-build/loadConfig.py:
1034         (checkWorkersAndBuildersForConsistency):
1035
1036 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1037
1038         [ews-build] Add few bots to config.json
1039         https://bugs.webkit.org/show_bug.cgi?id=194304
1040
1041         Reviewed by Lucas Forschler.
1042
1043         * BuildSlaveSupport/ews-build/config.json:
1044
1045 2019-02-05  Keith Rollin  <krollin@apple.com>
1046
1047         Enable the automatic checking and regenerations of .xcfilelists during builds
1048         https://bugs.webkit.org/show_bug.cgi?id=194124
1049         <rdar://problem/47721277>
1050
1051         Reviewed by Tim Horton.
1052
1053         Bug 193790 add a facility for checking -- during build time -- that
1054         any needed .xcfilelist files are up-to-date and for updating them if
1055         they are not. This facility was initially opt-in by setting
1056         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1057         the process seemed robust. Its now time to enable this facility and
1058         make it opt-out. If there is a need to disable this facility, set and
1059         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1060         running `make` or `build-webkit`, or before running Xcode from the
1061         command line.
1062
1063         Additionally, remove the step that generates a list of source files
1064         going into the UnifiedSources build step. It's only necessarily to
1065         specify Sources.txt and SourcesCocoa.txt as inputs.
1066
1067         * Scripts/generate-xcfilelists:
1068
1069 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1070
1071         [GTK][WPE] force libpsl build to use ICU in jhbuild
1072         https://bugs.webkit.org/show_bug.cgi?id=194288
1073
1074         Reviewed by Philippe Normand.
1075
1076         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1077         This can cause build failures if libidn is detected but libunistring is not available.
1078
1079         Make sure that ICU is used for runtime and builtin PSL data.
1080
1081         * gtk/jhbuild.modules:
1082         * wpe/jhbuild.modules:
1083
1084 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1085
1086         [ews-app] Modified timestamp should be updated on updating data
1087         https://bugs.webkit.org/show_bug.cgi?id=194295
1088
1089         Reviewed by Lucas Forschler.
1090
1091         * BuildSlaveSupport/ews-app/ews/models/build.py:
1092         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1093         * BuildSlaveSupport/ews-app/ews/models/step.py:
1094
1095 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1096
1097         Unreviewed, rolling out r240742.
1098
1099         Causes crashes on iOS simulator.
1100
1101         Reverted changeset:
1102
1103         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1104         not focused in a content-editable element"
1105         https://bugs.webkit.org/show_bug.cgi?id=192824
1106         https://trac.webkit.org/changeset/240742
1107
1108 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1109
1110         run-webkit-tests emits message "...running None" when running tests
1111         https://bugs.webkit.org/show_bug.cgi?id=194133
1112         <rdar://problem/47724738>
1113
1114         Reviewed by Lucas Forschler.
1115
1116         * Scripts/webkitpy/xcode/device_type.py:
1117         (DeviceType.__str__): Use both version mapping tables and use just the variant
1118         name if no version name is available.
1119         * Scripts/webkitpy/xcode/device_type_unittest.py:
1120         (DeviceTypeTest):
1121         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1122         an associated named.
1123
1124 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1125
1126         [WPE] require python3-setuptools for meson build in jhbuild
1127         https://bugs.webkit.org/show_bug.cgi?id=194287
1128
1129         Reviewed by Philippe Normand.
1130
1131         python3-setuptools is needed to build meson in jhbuild.
1132         It is already required by the GTK port.
1133
1134         * wpe/install-dependencies:
1135
1136 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1137
1138         [ews-app] Add method to save BuilderMapping to database
1139         https://bugs.webkit.org/show_bug.cgi?id=194264
1140
1141         Reviewed by Lucas Forschler.
1142
1143         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1144         (BuilderMapping.__str__):
1145         (BuilderMapping):
1146         (BuilderMapping.save_mapping):
1147         (BuilderMapping.update_mapping):
1148         (BuilderMapping.get_existing_mapping):
1149         (BuilderMapping.is_valid_mapping):
1150
1151 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1152
1153         [ews-app] Add timestamp fields for BuilderMappings
1154         https://bugs.webkit.org/show_bug.cgi?id=194266
1155
1156         Reviewed by Lucas Forschler.
1157
1158         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1159         (BuilderMapping):
1160
1161 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1162
1163         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1164         https://bugs.webkit.org/show_bug.cgi?id=174816
1165
1166         Reviewed by Michael Catanzaro.
1167
1168         Add tests for webkit_uri_for_display().
1169
1170         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1171         (testURIForDisplayUnaffected):
1172         (testURIForDisplayAffected):
1173         (beforeAll):
1174         (afterAll):
1175         * TestWebKitAPI/glib/CMakeLists.txt:
1176
1177 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1178
1179         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1180         https://bugs.webkit.org/show_bug.cgi?id=194158
1181         <rdar://problem/47737268>
1182
1183         Rubber-stamped by Aakash Jain.
1184
1185         * Scripts/webkitpy/port/device_port.py:
1186         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1187
1188 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1189
1190         [CG] Enable setAdditionalSupportedImageTypes for WK1
1191         https://bugs.webkit.org/show_bug.cgi?id=194190
1192
1193         Reviewed by Tim Horton.
1194
1195         Add a test similar to the one under WebKit Cocoa but make it create a
1196         WebView instead of a WKWebView.
1197
1198         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1199         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1200         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1201         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1202         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1203         (TestWebKitAPI::runTest):
1204         (TestWebKitAPI::TEST):
1205
1206 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1207
1208         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1209         https://bugs.webkit.org/show_bug.cgi?id=194168
1210
1211         Reviewed by Simon Fraser.
1212
1213         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1214
1215         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1216         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1217         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1218         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1219         (TEST):
1220         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1221         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1222
1223 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1224
1225         REGRESSION (r237269): webkit-patch what-broke is broken 
1226         https://bugs.webkit.org/show_bug.cgi?id=193025
1227
1228         Reviewed by Aakash Jain.
1229
1230         * Scripts/webkitpy/common/host.py:
1231         (Host.buildbot):
1232         (Host.bugzilla): Renamed to 'buildbot'.
1233
1234 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1235
1236         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1237         https://bugs.webkit.org/show_bug.cgi?id=194207
1238
1239         Reviewed by Tim Horton.
1240
1241         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1242         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1243         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1244         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1245         start and delete forwards to remove the original attachment.
1246
1247         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1248         (TestWebKitAPI::TEST):
1249
1250 2019-02-04  Youenn Fablet  <youenn@apple.com>
1251
1252         Capture state should be managed consistently when doing process swapping
1253         https://bugs.webkit.org/show_bug.cgi?id=194122
1254         <rdar://problem/47609293>
1255
1256         Reviewed by Eric Carlson.
1257
1258         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1259         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1260         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1261         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1262         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1263         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1264         (WTR::TestRunner::isDoingMediaCapture const):
1265         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1266         * WebKitTestRunner/TestController.cpp:
1267         (WTR::TestController::isDoingMediaCapture const):
1268         * WebKitTestRunner/TestController.h:
1269         * WebKitTestRunner/TestInvocation.cpp:
1270         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1271         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1272         (WTR::TestController::isDoingMediaCapture const):
1273
1274 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1275
1276         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1277         https://bugs.webkit.org/show_bug.cgi?id=194142
1278
1279         Reviewed by Ross Kirsling.
1280
1281         There three 'separator' variables in TestController.cpp. Renamed
1282         it 'pathSeparator', and unified them.
1283
1284         * WebKitTestRunner/TestController.cpp:
1285         (WTR::TestController::generateContextConfiguration const):
1286         (WTR::createTestURL):
1287         (WTR::TestController::platformAdjustContext):
1288
1289 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1290
1291         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1292         https://bugs.webkit.org/show_bug.cgi?id=194198
1293
1294         Reviewed by Antti Koivisto.
1295
1296         No need to set the banner heights on navigation now, since Page stores them.
1297
1298         * MiniBrowser/mac/WK2BrowserWindowController.m:
1299         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1300
1301 2019-02-03  John Wilander  <wilander@apple.com>
1302
1303         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1304         https://bugs.webkit.org/show_bug.cgi?id=194104
1305         <rdar://problem/47649991>
1306
1307         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1308
1309         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1310         (TestWebKitAPI::TEST):
1311             Changed numeric types from unsigned short to uint32_t.
1312
1313 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1314
1315         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1316         <https://webkit.org/b/194178>
1317         <rdar://problem/47753473>
1318
1319         Reviewed by Alexey Proskuryakov.
1320
1321         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1322         (WTR::uninstallFakeHelvetica): Pass nullptr into
1323         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1324
1325 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1326
1327         [LFC] Initialize ICB's style with fixed width/height.
1328         https://bugs.webkit.org/show_bug.cgi?id=194188
1329
1330         Reviewed by Antti Koivisto.
1331
1332         * LayoutReloaded/misc/LFC-passing-tests.txt:
1333
1334 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1335
1336         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1337         https://bugs.webkit.org/show_bug.cgi?id=194185
1338
1339         Reviewed by Antti Koivisto.
1340
1341         * LayoutReloaded/misc/LFC-passing-tests.txt:
1342
1343 2018-12-16  Darin Adler  <darin@apple.com>
1344
1345         Convert additional String::format clients to alternative approaches
1346         https://bugs.webkit.org/show_bug.cgi?id=192746
1347
1348         Reviewed by Alexey Proskuryakov.
1349
1350         * WebKitTestRunner/TestController.cpp:
1351         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1352         as an intermediate in code that ultimately constructs a WTF::String.
1353         (WTR::userMediaOriginHash): Use makeString.
1354         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1355         (WTR::TestController::didPerformClientRedirect): Ditto.
1356         (WTR::TestController::didPerformServerRedirect): Ditto.
1357         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1358
1359 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1360
1361         [ews-build] Add unit test to verify builder keys
1362         https://bugs.webkit.org/show_bug.cgi?id=194152
1363
1364         Reviewed by Lucas Forschler.
1365
1366         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1367         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1368
1369 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1370
1371         [LFC] Expand tests coverage (12 new tests -> 787)
1372
1373         Unreviewed test gardening.
1374
1375         * LayoutReloaded/misc/LFC-passing-tests.txt:
1376
1377 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1378
1379         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1380         https://bugs.webkit.org/show_bug.cgi?id=194163
1381
1382         Reviewed by Simon Fraser.
1383
1384         775
1385
1386         * LayoutReloaded/misc/LFC-passing-tests.txt:
1387
1388 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1389
1390         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1391         https://bugs.webkit.org/show_bug.cgi?id=194140
1392         <rdar://problem/47728098>
1393
1394         Reviewed by Tim Horton.
1395
1396         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1397         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1398         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1399
1400         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1401         test to induce an IPC deadlock when presenting a modal alert during touch start.
1402
1403         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1404         * WebKitTestRunner/TestController.cpp:
1405         (WTR::runJavaScriptAlert):
1406
1407         Add a client callback function for running JavaScript alerts.
1408
1409         (WTR::TestController::createOtherPage):
1410         (WTR::TestController::generateContextConfiguration const):
1411
1412         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1413         the fix in this patch.
1414
1415         (WTR::TestController::createWebViewWithOptions):
1416
1417         Plumb TestOptions to generateContextConfiguration.
1418
1419         (WTR::TestController::resetPreferencesToConsistentValues):
1420         (WTR::TestController::resetStateToConsistentValues):
1421         (WTR::updateTestOptionsFromTestHeader):
1422         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1423         (WTR::TestController::handleJavaScriptAlert):
1424         * WebKitTestRunner/TestController.h:
1425         * WebKitTestRunner/TestInvocation.cpp:
1426         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1427         * WebKitTestRunner/TestOptions.h:
1428         (WTR::TestOptions::hasSameInitializationOptions const):
1429
1430 2019-02-01  Chris Dumez  <cdumez@apple.com>
1431
1432         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1433         https://bugs.webkit.org/show_bug.cgi?id=193740
1434         <rdar://problem/47527267>
1435
1436         Reviewed by Alex Christensen.
1437
1438         Add API test coverage.
1439
1440         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1441
1442 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1443
1444         [ews-app] Add display name field to BuilderMapping model
1445         https://bugs.webkit.org/show_bug.cgi?id=194153
1446
1447         Reviewed by Lucas Forschler.
1448
1449         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1450         (BuilderMapping):
1451
1452 2019-02-01  Youenn Fablet  <youenn@apple.com>
1453
1454         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1455         https://bugs.webkit.org/show_bug.cgi?id=194155
1456
1457         Reviewed by Eric Carlson.
1458
1459         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1460         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1461         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1462
1463 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1464
1465         [LFC] Adjust replaced element's intrinsic ratio
1466         https://bugs.webkit.org/show_bug.cgi?id=194154
1467
1468         Reviewed by Antti Koivisto.
1469
1470         761
1471
1472         * LayoutReloaded/misc/LFC-passing-tests.txt:
1473
1474 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1475
1476         [WPE] Show test results in minibrowser
1477         https://bugs.webkit.org/show_bug.cgi?id=194150
1478
1479         Reviewed by Žan Doberšek.
1480
1481         * Scripts/webkitpy/port/wpe.py:
1482         (WPEPort.show_results_html_file):
1483
1484 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1485
1486         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1487         https://bugs.webkit.org/show_bug.cgi?id=194151
1488
1489         Reviewed by Žan Doberšek.
1490
1491         ALT + <- go back
1492         ALT + -> go forward
1493
1494         * MiniBrowser/wpe/main.cpp:
1495         (main):
1496
1497 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1498
1499         [LFC] Set intrinsic size on Layout::Replaced
1500         https://bugs.webkit.org/show_bug.cgi?id=194139
1501
1502         Reviewed by Antti Koivisto.
1503
1504         744
1505
1506         * LayoutReloaded/misc/LFC-passing-tests.txt:
1507
1508 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1509
1510         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1511         https://bugs.webkit.org/show_bug.cgi?id=194146
1512
1513         Reviewed by Xabier Rodriguez-Calvar.
1514
1515         It allows to open relative paths.
1516
1517         * MiniBrowser/wpe/main.cpp:
1518         (main):
1519
1520 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1521
1522         Update flakiness dashboard configuration after recent queue changes
1523         https://bugs.webkit.org/show_bug.cgi?id=194127
1524
1525         Rubber-stamped by Aakash Jain.
1526
1527         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1528
1529         * TestResultServer/static-dashboards/builders.jsonp:
1530
1531 2019-01-31  Youenn Fablet  <youenn@apple.com>
1532
1533         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1534         https://bugs.webkit.org/show_bug.cgi?id=194106
1535         <rdar://problem/47676333>
1536
1537         Reviewed by Ryosuke Niwa.
1538
1539         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1540         (TestWebKitAPI::didFinishNavigation):
1541         (TestWebKitAPI::TEST):
1542         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1543
1544 2019-01-31  Chris Dumez  <cdumez@apple.com>
1545
1546         Page zoom level is lost after a process swap or a crash
1547         https://bugs.webkit.org/show_bug.cgi?id=194105
1548         <rdar://problem/47610781>
1549
1550         Reviewed by Alex Christensen.
1551
1552         Add API test coverage.
1553
1554         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1555         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1556
1557 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1558
1559         Revert r238819 which is unneeded and caused a performance regression.
1560         https://bugs.webkit.org/show_bug.cgi?id=192272
1561         <rdar://problem/46664625>
1562
1563         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1564         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1565         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1566
1567 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1568
1569         Formalize WebKitAdditions mechanism of LoadOptimizer
1570         https://bugs.webkit.org/show_bug.cgi?id=193886
1571         <rdar://problem/47696809>
1572
1573         Reviewed by Brent Fulgham.
1574
1575         * MiniBrowser/MiniBrowser.entitlements:
1576         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1577
1578 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1579
1580         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1581         https://bugs.webkit.org/show_bug.cgi?id=194090
1582
1583         Reviewed by Antti Koivisto.
1584
1585         * LayoutReloaded/misc/LFC-passing-tests.txt:
1586
1587 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1588
1589         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1590         https://bugs.webkit.org/show_bug.cgi?id=194074
1591
1592         Reviewed by Antti Koivisto.
1593
1594         * LayoutReloaded/misc/LFC-passing-tests.txt:
1595
1596 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1597
1598         [LFC][BFC] Add support for block level replaced box.
1599         https://bugs.webkit.org/show_bug.cgi?id=194071
1600
1601         Reviewed by Antti Koivisto.
1602
1603         * LayoutReloaded/misc/LFC-passing-tests.txt:
1604
1605 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1606
1607         Fix WebKitTestRunner's testPath with Windows full paths
1608         https://bugs.webkit.org/show_bug.cgi?id=194012
1609
1610         Reviewed by Alex Christensen.
1611
1612         updateTestOptionsFromTestHeader failed to open test files because
1613         testPath returned wrong file paths. It returned a path "/C:/..."
1614         if a URL "file:///C:/..." was given.
1615
1616         * WebKitTestRunner/TestController.cpp:
1617         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1618
1619 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1620
1621         [WPE] Bump font related dependencies to match the GTK+ port
1622         https://bugs.webkit.org/show_bug.cgi?id=194017
1623
1624         Reviewed by Žan Doberšek.
1625
1626         * wpe/jhbuild.modules:
1627         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1628         * wpe/patches/icudata-stdlibs.patch: Added.
1629
1630 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1631
1632         Enable swipe tests on iOS
1633         https://bugs.webkit.org/show_bug.cgi?id=194076
1634
1635         Reviewed by Geoffrey Garen.
1636
1637         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1638         it causes a debug assertion failure in runUIScript.
1639
1640         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1641         (WTR::UIScriptController::beginBackSwipe):
1642         (WTR::UIScriptController::completeBackSwipe):
1643
1644 2019-01-30  Keith Rollin  <krollin@apple.com>
1645
1646         Use correct printf format specifier
1647         https://bugs.webkit.org/show_bug.cgi?id=194062
1648         <rdar://problem/47686167>
1649
1650         Reviewed by Alexey Proskuryakov.
1651
1652         LayoutTestSpellChecker.mm is trying to format a variable of type
1653         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1654         actually an unsigned long long. Fix this by formatting with %llu.
1655
1656         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1657         (-[LayoutTestTextCheckingResult description]):
1658
1659 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1660
1661         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1662         https://bugs.webkit.org/show_bug.cgi?id=193979
1663
1664         Reviewed by Wenson Hsieh.
1665
1666         Fix the test for iOS. Make the test work with iOS UA string.
1667
1668         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1669
1670 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1671
1672         Replace High Sierra LLINT CLoop bot due to hardware failure
1673         https://bugs.webkit.org/show_bug.cgi?id=194066
1674
1675         Reviewed by Aakash Jain.
1676
1677         * BuildSlaveSupport/build.webkit.org-config/config.json:
1678
1679 2019-01-30  Keith Rollin  <krollin@apple.com>
1680
1681         [NSDragItem init] is unavailable
1682         https://bugs.webkit.org/show_bug.cgi?id=194059
1683         <rdar://problem/47685715>
1684
1685         Reviewed by Wenson Hsieh.
1686
1687         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1688         DumpRenderTree and TestWebKitAPI, which both try to create an
1689         NSDragItem in a manner that invokes this method. Address this by using
1690         -initWithPasteboardWriter instead.
1691
1692         Note that the parameter passed to initWithPasteboardWriter is likely
1693         incorrect. In both cases, the object passed does not conform to
1694         NSPasteboardWriting. However, with this fix, we're no worse off than
1695         before, and can now perform builds with newer compilers and SDKs until
1696         a real fix can be crafted. That work is tracked in
1697         https://bugs.webkit.org/show_bug.cgi?id=194060
1698
1699         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1700         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1701         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1702         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1703
1704 2019-01-30  Daniel Bates  <dabates@apple.com>
1705
1706         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1707         https://bugs.webkit.org/show_bug.cgi?id=192824
1708         <rdar://problem/47100332>
1709
1710         Reviewed by Wenson Hsieh.
1711
1712         Fix a bug where the wrong usage code was used for F13 thru F24.
1713
1714         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1715         (keyCodeForDOMFunctionKey):
1716
1717 2019-01-30  Chris Dumez  <cdumez@apple.com>
1718
1719         Regression(PSON) Load hang can occur on history navigation
1720         https://bugs.webkit.org/show_bug.cgi?id=194030
1721         <rdar://problem/47656939>
1722
1723         Reviewed by Antti Koivisto.
1724
1725         Add API test coverage.
1726
1727         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1728
1729 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1730
1731         [LFC] Expand tests coverage.
1732
1733         Unreviewed test gardening.
1734
1735         * LayoutReloaded/misc/LFC-passing-tests.txt:
1736
1737 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1738
1739         [Flatpak] Add openjpeg support
1740         https://bugs.webkit.org/show_bug.cgi?id=194019
1741
1742         Reviewed by Michael Catanzaro.
1743
1744         * flatpak/org.webkit.CommonModules.yaml:
1745
1746 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1747
1748         Unreviewed, rolling out r240708.
1749         https://bugs.webkit.org/show_bug.cgi?id=194022
1750
1751         It broke WPE build (Requested by KaL on #webkit).
1752
1753         Reverted changeset:
1754
1755         "[WPE] Bump font related dependencies to match the GTK+ port"
1756         https://bugs.webkit.org/show_bug.cgi?id=194017
1757         https://trac.webkit.org/changeset/240708
1758
1759 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1760
1761         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1762         https://bugs.webkit.org/show_bug.cgi?id=194001
1763
1764         Reviewed by Antti Koivisto.
1765
1766         * LayoutReloaded/misc/LFC-passing-tests.txt:
1767
1768 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1769
1770         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1771         https://bugs.webkit.org/show_bug.cgi?id=194020
1772
1773         Reviewed by Antti Koivisto.
1774
1775         * LayoutReloaded/misc/LFC-passing-tests.txt:
1776
1777 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1778
1779         AX: Support color well on iOS
1780         https://bugs.webkit.org/show_bug.cgi?id=194010
1781
1782         Reviewed by Joanmarie Diggs.
1783
1784         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1785         (WTR::AccessibilityUIElement::stringAttributeValue):
1786
1787 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1788
1789         [WPE] Bump font related dependencies to match the GTK+ port
1790         https://bugs.webkit.org/show_bug.cgi?id=194017
1791
1792         Reviewed by Žan Doberšek.
1793
1794         * wpe/jhbuild.modules:
1795         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1796         * wpe/patches/icudata-stdlibs.patch: Added.
1797
1798 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1799
1800         [Mac] Update window scale API usage
1801         https://bugs.webkit.org/show_bug.cgi?id=193991
1802         rdar://problem/47614795
1803
1804         Reviewed by Tim Horton.
1805
1806         * DumpRenderTree/mac/DumpRenderTree.mm:
1807         (changeWindowScaleIfNeeded):
1808         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1809         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1810         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1811
1812 2019-01-29  Chris Dumez  <cdumez@apple.com>
1813
1814         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1815         https://bugs.webkit.org/show_bug.cgi?id=193977
1816         <rdar://problem/47643716>
1817
1818         Reviewed by Geoff Garen.
1819
1820         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1821         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1822         to the previous provisional committing *before* we make the last load. 
1823
1824         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1825
1826 2019-01-29  Youenn Fablet  <youenn@apple.com>
1827
1828         Adopt new SPI to evaluate server certificate trust
1829         https://bugs.webkit.org/show_bug.cgi?id=193355
1830
1831         Reviewed by Alex Christensen.
1832
1833         Add infrastructure to handle HTTPS server trust evaluation testing.
1834
1835         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1836         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1837         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1838         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1839         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1840         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1841         * WebKitTestRunner/TestController.cpp:
1842         (WTR::TestController::resetPreferencesToConsistentValues):
1843         (WTR::TestController::didReceiveAuthenticationChallenge):
1844         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1845         * WebKitTestRunner/TestController.h:
1846         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1847         * WebKitTestRunner/TestInvocation.cpp:
1848         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1849         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1850         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1851
1852 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1853
1854         [ews-build] Add build step to print bot Configuration
1855         https://bugs.webkit.org/show_bug.cgi?id=193887
1856
1857         Reviewed by Lucas Forschler.
1858
1859         * BuildSlaveSupport/ews-build/steps.py:
1860         (PrintConfiguration): Build step to print configuration.
1861         * BuildSlaveSupport/ews-build/factories.py:
1862
1863 2019-01-29  Chris Dumez  <cdumez@apple.com>
1864
1865         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1866         https://bugs.webkit.org/show_bug.cgi?id=193967
1867         <rdar://problem/47635348>
1868
1869         Reviewed by Alex Christensen.
1870
1871         Add API test coverage.
1872
1873         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1874         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1875
1876 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1877
1878         [ews-app] Handle incoming results data
1879         https://bugs.webkit.org/show_bug.cgi?id=193973
1880
1881         Reviewed by Lucas Forschler.
1882
1883         * BuildSlaveSupport/ews-app/ews/views/results.py:
1884
1885 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1886
1887         [ews-app] Make the results url generic
1888         https://bugs.webkit.org/show_bug.cgi?id=193928
1889
1890         Reviewed by Lucas Forschler.
1891
1892         * BuildSlaveSupport/ews-app/ews/urls.py:
1893
1894 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1895
1896         [ews-build] Configure buildbot to send events to ews-app
1897         https://bugs.webkit.org/show_bug.cgi?id=193968
1898
1899         Reviewed by Lucas Forschler.
1900
1901         * BuildSlaveSupport/ews-build/events.py: Added.
1902         * BuildSlaveSupport/ews-build/master.cfg:
1903
1904 2019-01-29  Keith Rollin  <krollin@apple.com>
1905
1906         Add .xcfilelists to Run Script build phases
1907         https://bugs.webkit.org/show_bug.cgi?id=193792
1908         <rdar://problem/47201785>
1909
1910         Reviewed by Alex Christensen.
1911
1912         As part of supporting XCBuild, update the necessary Run Script build
1913         phases in their Xcode projects to refer to their associated
1914         .xcfilelist files.
1915
1916         Note that the addition of these files bumps the Xcode project version
1917         number to something that's Xcode 10 compatible. This change means that
1918         older versions of the Xcode IDE can't read these projects. Nor can it
1919         fully load workspaces that refer to these projects (the updated
1920         projects are shown as non-expandable placeholders). `xcodebuild` can
1921         still build these projects; it's just that the IDE can't open them.
1922
1923         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1924         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1925
1926 2019-01-29  John Wilander  <wilander@apple.com>
1927
1928         Add data abstraction and validation for Ad Click Attribution
1929         https://bugs.webkit.org/show_bug.cgi?id=193916
1930         <rdar://problem/47603481>
1931
1932         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1933
1934         Ad click attribution has two steps. First, the storage of an ad
1935         campaign ID for a click that takes the user to a destination
1936         site. Second, a conversion on the destination site that can be
1937         attributed to the ad click.
1938
1939         This patch adds a class that represents a request for ad click
1940         attribution. Validation makes sure that the bits of entropy
1941         reported through this mechanism is limited.
1942
1943         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1944         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1945         (TestWebKitAPI::TEST):
1946
1947 2019-01-29  Chris Dumez  <cdumez@apple.com>
1948
1949         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1950         https://bugs.webkit.org/show_bug.cgi?id=193932
1951         <rdar://problem/47598947>
1952
1953         Reviewed by Brady Eidson.
1954
1955         Add API test coverage.
1956
1957         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1958
1959 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1960
1961         Adding new passing LFC tests.
1962
1963         Unreviewed test gardening.
1964
1965         * LayoutReloaded/misc/LFC-passing-tests.txt:
1966
1967 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1968
1969         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1970         https://bugs.webkit.org/show_bug.cgi?id=193964
1971
1972         Reviewed by Antti Koivisto.
1973
1974         * LayoutReloaded/misc/LFC-passing-tests.txt:
1975
1976 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1977
1978         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1979         https://bugs.webkit.org/show_bug.cgi?id=193954
1980
1981         Reviewed by Antti Koivisto.
1982
1983         * LayoutReloaded/misc/LFC-passing-tests.txt:
1984
1985 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1986
1987         WebDriver: add support for running subtests
1988         https://bugs.webkit.org/show_bug.cgi?id=193904
1989
1990         Reviewed by Michael Catanzaro.
1991
1992         pytest already supports it by passing test.py::subtest, so we can do the same.
1993
1994         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1995         (get_item_name): Made this global.
1996         (CollectRecorder.__init__): Receive the parameter to ignore.
1997         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1998         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1999         (collect): Add parameter to ignore.
2000         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2001         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2002         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2003         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2004         (WebDriverTestRunnerSelenium.run): Ditto.
2005         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2006         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2007         (WebDriverTestRunnerW3C.run): Ditto.
2008
2009 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2010
2011         User agent string override for navigator.userAgent should be site specific quirks
2012         https://bugs.webkit.org/show_bug.cgi?id=193950
2013
2014         Reviewed by Brent Fulgham.
2015
2016         Updated per the _WKWebsitePolicies rename.
2017
2018         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2019         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2020
2021 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2022
2023         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2024         https://bugs.webkit.org/show_bug.cgi?id=193941
2025
2026         Reviewed by Alex Christensen.
2027
2028         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2029         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2030         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2031         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2032         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2033         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2034         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2035         * TestWebKitAPI/Tests/WTF/Time.cpp:
2036         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2037         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2038         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2039         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2040
2041 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2042
2043         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2044
2045         * Scripts/webkitpy/common/config/contributors.json:
2046
2047 2019-01-28  Andy Estes  <aestes@apple.com>
2048
2049         [watchOS] Enable Parental Controls content filtering
2050         https://bugs.webkit.org/show_bug.cgi?id=193939
2051         <rdar://problem/46641912>
2052
2053         Reviewed by Ryosuke Niwa.
2054
2055         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2056
2057 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2058
2059         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2060         <https://webkit.org/b/193884>
2061
2062         Reviewed by Jiewen Tan.
2063
2064         * Scripts/webkitpy/style/checkers/cpp.py:
2065         (check_language): Add LocalAuthentication to
2066         `frameworks_with_soft_links`.
2067
2068 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2069
2070         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2071         https://bugs.webkit.org/show_bug.cgi?id=193891
2072
2073         Reviewed by Ross Kirsling.
2074
2075         There were three problems in window sizes of WebView and the host window.
2076         1. The sizes of pixel image output were incorrect.
2077         2. The host window is going to appear after window.resize was invoked.
2078         3. window.resize resized only the host window, not WebView.
2079
2080         This change solves them with a following approach.
2081         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2082         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2083            as well as DumpRenderTree in order to match the client area and the window area.
2084         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2085         d. PlatformWebView::setWindowFrame changes both window sizes.
2086         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2087
2088         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2089         (WTR::PlatformWebView::PlatformWebView): Create the host window
2090         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2091         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2092         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2093
2094 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2095
2096         [ews-app] Add method to save Step data to database
2097         https://bugs.webkit.org/show_bug.cgi?id=193890
2098
2099         Reviewed by Lucas Forschler.
2100
2101         * BuildSlaveSupport/ews-app/ews/models/step.py:
2102         (Step.save_step): Method to save step data.
2103         (Step.update_step): Method to update step data.
2104         (Step.get_existing_step): Method to fetch existing step from database.
2105         (Step.is_valid_result): Method to validate valid step result.
2106
2107 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2108
2109         [ews-app] Add method to save Build data to database
2110         https://bugs.webkit.org/show_bug.cgi?id=193735
2111
2112         Reviewed by Lucas Forschler.
2113
2114         * BuildSlaveSupport/ews-app/ews/models/build.py:
2115         (Build.save_build): Method to save build information to database.
2116         (Build.get_existing_build): Method to fetch existing build from database.
2117         (Build.is_valid_result): Method to validate build result.
2118         * BuildSlaveSupport/ews-app/ews/common/util.py:
2119         (is_valid_int_id): Method to validate valid id.
2120
2121 2019-01-28  Chris Dumez  <cdumez@apple.com>
2122
2123         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2124         https://bugs.webkit.org/show_bug.cgi?id=193915
2125         <rdar://problem/47560907>
2126
2127         Reviewed by Alex Christensen.
2128
2129         Add API test coverage.
2130
2131         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2132
2133 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2134
2135         [ews-app] Rename id variables
2136         https://bugs.webkit.org/show_bug.cgi?id=193883
2137
2138         Reviewed by Lucas Forschler.
2139
2140         * BuildSlaveSupport/ews-app/ews/models/build.py:
2141         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2142         * BuildSlaveSupport/ews-app/ews/models/step.py:
2143         * BuildSlaveSupport/ews-app/ews/urls.py:
2144         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2145         * BuildSlaveSupport/ews-app/ews/views/results.py:
2146         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2147
2148 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2149
2150         [ews-app] Allow certain fields to be empty
2151         https://bugs.webkit.org/show_bug.cgi?id=193892
2152
2153         Reviewed by Lucas Forschler.
2154
2155         * BuildSlaveSupport/ews-app/ews/models/build.py:
2156         * BuildSlaveSupport/ews-app/ews/models/step.py:
2157
2158 2019-01-28  Rob Buis  <rbuis@igalia.com>
2159
2160         Update MIME type parser
2161         https://bugs.webkit.org/show_bug.cgi?id=180526
2162
2163         Reviewed by Frédéric Wang.
2164
2165         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2166         (TestWebKitAPI::TEST):
2167
2168 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2169
2170         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2171         https://bugs.webkit.org/show_bug.cgi?id=193896
2172
2173         Reviewed by Antti Koivisto.
2174
2175         * LayoutReloaded/misc/LFC-passing-tests.txt:
2176
2177 2018-12-15  Darin Adler  <darin@apple.com>
2178
2179         Replace many uses of String::format with more type-safe alternatives
2180         https://bugs.webkit.org/show_bug.cgi?id=192742
2181
2182         Reviewed by Mark Lam.
2183
2184         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2185         (WTR::cacheTestRunnerCallback): Use makeString.
2186         * WebKitTestRunner/TestController.cpp:
2187         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2188         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2189
2190 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2191
2192         Use a load optimizer for some sites
2193         https://bugs.webkit.org/show_bug.cgi?id=193881
2194         <rdar://problem/46325455>
2195
2196         Reviewed by Brent Fulgham.
2197
2198         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2199         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2200
2201 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2202
2203         AX: Introduce a static accessibility tree
2204         https://bugs.webkit.org/show_bug.cgi?id=193348
2205         <rdar://problem/47203295>
2206
2207         Reviewed by Ryosuke Niwa.
2208
2209         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2210
2211 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2212
2213         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2214         https://bugs.webkit.org/show_bug.cgi?id=193867
2215
2216         Reviewed by Antti Koivisto.
2217
2218         * LayoutReloaded/misc/LFC-passing-tests.txt:
2219
2220 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2221
2222         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2223         https://bugs.webkit.org/show_bug.cgi?id=193865
2224
2225         Reviewed by Antti Koivisto.
2226
2227         * LayoutReloaded/misc/LFC-passing-tests.txt:
2228
2229 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2230
2231         Need a mechanism to override navigator.userAgent
2232         https://bugs.webkit.org/show_bug.cgi?id=193762
2233         <rdar://problem/47504939>
2234
2235         Reviewed by Brent Fulgham.
2236
2237         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2238
2239         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2240         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2241         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2242
2243 2019-01-25  Dean Jackson  <dino@apple.com>
2244
2245         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2246         https://bugs.webkit.org/show_bug.cgi?id=193831
2247         <rdar://problem/47399263>
2248
2249         Reviewed by Chris Dumez.
2250
2251         Two new tests that exercise cross-origin and same-origin System
2252         Previews.
2253
2254         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2255
2256 2019-01-25  Keith Rollin  <krollin@apple.com>
2257
2258         Update Xcode projects with "Check .xcfilelists" build phase
2259         https://bugs.webkit.org/show_bug.cgi?id=193790
2260         <rdar://problem/47201374>
2261
2262         Reviewed by Alex Christensen.
2263
2264         Support for XCBuild includes specifying inputs and outputs to various
2265         Run Script build phases. These inputs and outputs are specified as
2266         .xcfilelist files. Once created, these .xcfilelist files need to be
2267         kept up-to-date. In order to check that they are up-to-date or not,
2268         add an Xcode build step that invokes an external script that performs
2269         the checking. If the .xcfilelists are found to be out-of-date, update
2270         them, halt the build, and instruct the developer to restart the build
2271         with up-to-date files.
2272
2273         At this time, the checking and regenerating is performed only if the
2274         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2275         who want to use this facility can set this variable and test out the
2276         checking/regenerating. Once it seems like there are no egregious
2277         issues that upset a developer's workflow, we'll unconditionally enable
2278         this facility.
2279
2280         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2281         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2282         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2283         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2284
2285 2019-01-25  Keith Rollin  <krollin@apple.com>
2286
2287         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2288         https://bugs.webkit.org/show_bug.cgi?id=193781
2289         <rdar://problem/47201153>
2290
2291         Reviewed by Alex Christensen.
2292
2293         Part of generating the .xcfilelists used as part of adopting XCBuild
2294         includes running `make DerivedSources.make` from a standalone script.
2295         It’s important for this invocation to have the same environment as
2296         when the actual build invokes `make DerivedSources.make`. If the
2297         environments are different, then the two invocations will provide
2298         different results. In order to get the same environment in the
2299         standalone script, have the script launch xcodebuild targeting the
2300         "Apply Configuration to XCFileLists" build target, which will then
2301         re-invoke our standalone script. The script is now running again, this
2302         time in an environment with all workspace, project, target, xcconfig
2303         and other environment variables established.
2304
2305         The "Apply Configuration to XCFileLists" build target accomplishes
2306         this task via a small embedded shell script that consists only of:
2307
2308             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2309
2310         The process that invokes "Apply Configuration to XCFileLists" first
2311         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2312         evaluated and exports it into the shell environment. When xcodebuild
2313         is invoked, it inherits the value of this variable and can `eval` the
2314         contents of that variable. Our external standalone script can then set
2315         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2316         of command-line parameters needed to restart itself in the appropriate
2317         state.
2318
2319         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2320         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2321
2322 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2323
2324         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2325         https://bugs.webkit.org/show_bug.cgi?id=193802
2326         <rdar://problem/46010580>
2327
2328         Reviewed by Andy Estes.
2329
2330         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2331         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2332         (TEST):
2333
2334 2019-01-25  Daniel Bates  <dabates@apple.com>
2335
2336         [iOS] uiController.keyDown() does not translate Control modified key
2337         https://bugs.webkit.org/show_bug.cgi?id=192898
2338
2339         Reviewed by Wenson Hsieh.
2340
2341         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2342         key translation, as applicable. Among other cases, key translation occurs when performing
2343         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2344         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2345         human pressing down and releasing key(s) using a hardware keyboard.
2346
2347         * WebKitTestRunner/ios/HIDEventGenerator.h:
2348         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2349         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2350
2351         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2352         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2353         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2354         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2355         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2356         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2357         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2358         (-[HIDEventGenerator longPress:completionBlock:]):
2359         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2360         Update code for above renaming.
2361
2362         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2363         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2364
2365         (-[HIDEventGenerator keyDown:]): Added.
2366         (-[HIDEventGenerator keyUp:]): Added.
2367         (-[HIDEventGenerator keyPress:completionBlock:]):
2368         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2369         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2370         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2371         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2372         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2373         (WTR::parseModifier): Deleted.
2374
2375 2019-01-25  Keith Rollin  <krollin@apple.com>
2376
2377         Complete the implementation of generate-xcfilelists
2378         https://bugs.webkit.org/show_bug.cgi?id=193782
2379
2380         Reviewed by Alex Christensen.
2381
2382         A preliminary version of generate-xcfilelists was added in r238008.
2383         This patch updates that script in order to:
2384
2385         - Support checking of .xcfilelists
2386         - Perform better execution of `make DerivedSources.make` by
2387           relaunching generate-xcfilelists under xcodebuild
2388         - Support incremental generation and checking of .xcfilelists
2389         - Support supplementary .xcfilelists files from WebKitAdditions
2390         - Support being wrapped by parallel version of generate-xcfilelists in
2391           Internal that adds support for (re)generating WebKit projects in
2392           that repo.
2393         - Support builds that have been performed in WebKitBuild as well as
2394           ~/Library/Developer/code/DerivedData
2395         - Increase robustness and debugging facilities.
2396
2397         * Scripts/generate-xcfilelists:
2398
2399 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2400
2401         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2402         https://bugs.webkit.org/show_bug.cgi?id=193297
2403         <rdar://problem/47158841>
2404
2405         Unreviewed test case fix.
2406
2407         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2408         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2409
2410         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2411         (TEST):
2412
2413 2019-01-25  Keith Rollin  <krollin@apple.com>
2414
2415         Update existing .xcfilelists
2416         https://bugs.webkit.org/show_bug.cgi?id=193791
2417         <rdar://problem/47201706>
2418
2419         Reviewed by Alex Christensen.
2420
2421         Many .xcfilelist files were added in r238824 in order to support
2422         XCBuild. Update these with recent changes to the set of build files
2423         and with the current generate-xcfilelist script.
2424
2425         * DumpRenderTree/DerivedSources-input.xcfilelist:
2426         * DumpRenderTree/DerivedSources-output.xcfilelist:
2427         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2428         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2429
2430 2019-01-25  Keith Rollin  <krollin@apple.com>
2431
2432         Fix missing dependencies in extract-dependencies-from-makefile
2433         https://bugs.webkit.org/show_bug.cgi?id=193783
2434         <rdar://problem/47201571>
2435
2436         Reviewed by Alex Christensen.
2437
2438         The extract-dependencies-from-makefile script generates .xcfilelists
2439         for XCBuild by invoking a makefile in --debug mode, parsing the
2440         dependency information in the output, and extracting information
2441         regarding targets and dependents. However, the way `make` emits this
2442         dependency information is not rigorous, and so we need to determine
2443         what lines to look for and parse by trial and error. This approach
2444         didn't coriginally atch all the information we needed to collect, so
2445         update the script to look for the additional lines we now know to look
2446         for.
2447
2448         * Scripts/extract-dependencies-from-makefile:
2449         (Parser):
2450         (Parser.addTarget):
2451         (Parser.addPrereq):
2452         (Parser.doParse):
2453
2454 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2455
2456         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2457         https://bugs.webkit.org/show_bug.cgi?id=193297
2458         <rdar://problem/47158841>
2459
2460         Reviewed by Alex Christensen.
2461
2462         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2463             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2464         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2465         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2466         activating the message used to trigger the callback when it is set.
2467
2468 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2469
2470         WKWebView.goBack should reload if there is a safe browsing warning
2471         https://bugs.webkit.org/show_bug.cgi?id=193805
2472         <rdar://problem/46908216>
2473
2474         Reviewed by Geoff Garen.
2475
2476         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2477         (+[Simple3LookupContext sharedLookupContext]):
2478         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2479         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2480         (TEST):
2481
2482 2019-01-25  Chris Dumez  <cdumez@apple.com>
2483
2484         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2485         https://bugs.webkit.org/show_bug.cgi?id=193788
2486         <rdar://problem/47531231>
2487
2488         Reviewed by Alex Christensen.
2489
2490         Add API test coverage.
2491
2492         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2493         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2494
2495 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2496
2497         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2498         https://bugs.webkit.org/show_bug.cgi?id=193771
2499
2500         Unreviewed infrastructure fix.
2501
2502         * Scripts/webkitpy/port/darwin.py:
2503         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2504
2505 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2506
2507         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2508
2509 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2510
2511         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2512
2513         * Scripts/webkitpy/common/config/contributors.json:
2514
2515 2019-01-25  Chris Dumez  <cdumez@apple.com>
2516
2517         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2518         https://bugs.webkit.org/show_bug.cgi?id=193779
2519         <rdar://problem/46170903>
2520
2521         Reviewed by Antti Koivisto.
2522
2523         Add API test that quickly navigates forward to a previous process without waiting for it to
2524         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2525         the process' previous page when reconnecting the it for the forward navigation.
2526
2527         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2528
2529 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2530
2531         Need a way for JavaScript (or bundle) code to participate in undo
2532         https://bugs.webkit.org/show_bug.cgi?id=190009
2533         <rdar://problem/44807048>
2534
2535         Reviewed by Ryosuke Niwa.
2536
2537         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2538         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2539
2540         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2541         (WTR::UIScriptController::lastUndoLabel const):
2542         (WTR::UIScriptController::firstRedoLabel const):
2543         (WTR::UIScriptController::platformUndoManager const):
2544         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2545         (WTR::UIScriptController::lastUndoLabel const):
2546         (WTR::UIScriptController::firstRedoLabel const):
2547         (WTR::UIScriptController::platformUndoManager const):
2548         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2549         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2550         (WTR::UIScriptController::lastUndoLabel const):
2551         (WTR::UIScriptController::firstRedoLabel const):
2552         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2553         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2554         (WTR::UIScriptController::lastUndoLabel const):
2555         (WTR::UIScriptController::firstRedoLabel const):
2556         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2557         (WTR::UIScriptController::platformUndoManager const):
2558         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2559         (WTR::UIScriptController::platformUndoManager const):
2560
2561 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2562
2563         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2564         https://bugs.webkit.org/show_bug.cgi?id=193824
2565
2566         Reviewed by Antti Koivisto.
2567
2568         * LayoutReloaded/misc/LFC-passing-tests.txt:
2569
2570 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2571
2572         Update macOS JSC bot configurations
2573         https://bugs.webkit.org/show_bug.cgi?id=193739
2574
2575         Reviewed by Alexey Proskuryakov.
2576
2577         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2578         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2579         (BubbleQueueServer): Move JSC EWS to Mojave section.
2580         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2581         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2582         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2583
2584 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2585
2586         [Win][WebKitTestRunner] Implement EventSenderProxy
2587         https://bugs.webkit.org/show_bug.cgi?id=193755
2588
2589         Reviewed by Don Olmstead.
2590
2591         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2592         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2593         (WTR::EventSenderProxy::dispatchMessage):
2594         (WTR::EventSenderProxy::EventSenderProxy):
2595         (WTR::EventSenderProxy::mouseDown):
2596         (WTR::EventSenderProxy::mouseUp):
2597         (WTR::EventSenderProxy::mouseMoveTo):
2598         (WTR::EventSenderProxy::mouseScrollBy):
2599         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2600
2601 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2602
2603         Unreviewed fix for API test failure after r240437.
2604
2605         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2606
2607         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2608
2609 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2610
2611         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2612         https://bugs.webkit.org/show_bug.cgi?id=193787
2613         <rdar://problem/47497634>
2614
2615         Reviewed by Alexey Proskuryakov.
2616
2617         * Scripts/webkitdirs.pm:
2618         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2619
2620 2019-01-24  Truitt Savell  <tsavell@apple.com>
2621
2622         Unreviewed, rolling out r240446.
2623
2624         Casued 5 API failures
2625
2626         Reverted changeset:
2627
2628         "Activate the WebResourceLoadStatisticsStore in the
2629         NetworkProcess and deactivate it in the UIProcess."
2630         https://bugs.webkit.org/show_bug.cgi?id=193297
2631         https://trac.webkit.org/changeset/240446
2632
2633 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2634
2635         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2636         https://bugs.webkit.org/show_bug.cgi?id=193741
2637         <rdar://problem/47135030>
2638
2639         Reviewed by Antti Koivisto and Simon Fraser.
2640
2641         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2642         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2643         (TestWebKitAPI::TEST):
2644
2645 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2646
2647         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2648         https://bugs.webkit.org/show_bug.cgi?id=193297
2649         <rdar://problem/47158841>
2650
2651         Reviewed by Alex Christensen.
2652
2653         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2654         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2655         activating the message used to trigger the callback when it is set.
2656
2657 2019-01-24  John Wilander  <wilander@apple.com>
2658
2659         Add Ad Click Attribution as an internal/experimental feature
2660         https://bugs.webkit.org/show_bug.cgi?id=193685
2661         <rdar://problem/47450399>
2662
2663         Reviewed by Brent Fulgham.
2664
2665         Added test option adClickAttributionEnabled.
2666
2667         * DumpRenderTree/TestOptions.cpp:
2668         (TestOptions::TestOptions):
2669         * DumpRenderTree/TestOptions.h:
2670         * DumpRenderTree/mac/DumpRenderTree.mm:
2671         (setWebPreferencesForTestOptions):
2672
2673 2019-01-24  Antti Koivisto  <antti@apple.com>
2674
2675         [PSON] Flash on back navigation on Mac
2676         https://bugs.webkit.org/show_bug.cgi?id=193716
2677         <rdar://problem/47148458>
2678
2679         Reviewed by Chris Dumez.
2680
2681         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2682
2683         Closing of the previous page is delayed so waiting for didFinishNavigation is
2684         not sufficient to guarantee we have received all the messages. Wait for them.
2685
2686 2019-01-24  Chris Dumez  <cdumez@apple.com>
2687
2688         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2689         https://bugs.webkit.org/show_bug.cgi?id=193761
2690         <rdar://problem/47456405>
2691
2692         Reviewed by Alex Christensen.
2693
2694         Add API test coverage.
2695
2696         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2697
2698 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2699
2700         webkitpy: Missing PID in crashlog name should not be fatal
2701         https://bugs.webkit.org/show_bug.cgi?id=193771
2702
2703         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2704         of raising an exception.
2705
2706         Reviewed by Lucas Forschler.
2707
2708         * Scripts/webkitpy/port/darwin.py:
2709         (DarwinPort._merge_crash_logs):
2710
2711 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2712
2713         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2714         https://bugs.webkit.org/show_bug.cgi?id=193746
2715
2716         Reviewed by Youenn Fablet.
2717
2718         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2719         so we'd best just not call it.
2720
2721         * Scripts/webkitpy/w3c/test_exporter.py:
2722         (WebPlatformTestExporter.create_branch_with_patch):
2723
2724 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2725
2726         Move FileSystem to WTF
2727         https://bugs.webkit.org/show_bug.cgi?id=193602
2728
2729         Reviewed by Yusuke Suzuki.
2730
2731         * DumpRenderTree/win/DumpRenderTree.cpp:
2732         * TestWebKitAPI/CMakeLists.txt:
2733         * TestWebKitAPI/PlatformGTK.cmake:
2734         * TestWebKitAPI/PlatformJSCOnly.cmake:
2735         * TestWebKitAPI/PlatformPlayStation.cmake:
2736         * TestWebKitAPI/PlatformWPE.cmake:
2737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2738         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2739         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2740         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2741         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2742         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2743         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2744         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2745         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2746         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2747
2748 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2749
2750         [WPE] Remove hard dependency on subprocess32 for the API tests
2751
2752         Rubber-stamped by Carlos Garcia Campos.
2753
2754         * glib/api_test_runner.py:
2755         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2756         its presence only when running WPEQt tests.
2757
2758 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2759
2760         [GLIB] Expose JavaScriptCore options in GLib public API
2761         https://bugs.webkit.org/show_bug.cgi?id=188742
2762
2763         Reviewed by Michael Catanzaro.
2764
2765         Add a test for the new API.
2766
2767         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2768         (testsJSCOptions):
2769         (main):
2770
2771 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2772
2773         [GTK][WPE] Support JPEG 2000 images
2774         https://bugs.webkit.org/show_bug.cgi?id=186272
2775
2776         Reviewed by Žan Doberšek.
2777
2778         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2779
2780         * gtk/jhbuild.modules:
2781         * wpe/jhbuild.modules:
2782
2783 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2784
2785         check-webkit-style should warn when using soft-linking macros in a header
2786         <https://webkit.org/b/193750>
2787
2788         Reviewed by Darin Adler.
2789
2790         * Scripts/webkitpy/style/checkers/cpp.py:
2791         (check_language): Add softlink/header check by refactoring the
2792         softlink/framework check.
2793         (CppChecker): Enable softlink/header check by default.
2794         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2795         (CppStyleTest.test_softlink_framework): Rename from
2796         CppStyleTest.test_softlink() and change test framework name in
2797         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2798         files. Set file_name for macros that only appear in headers.
2799         (CppStyleTest.test_softlink_header): Add tests for using
2800         soft-link macros in headers.
2801
2802 2019-01-23  Chris Dumez  <cdumez@apple.com>
2803
2804         Deprecate API to limit the maximum number of WebProcesses
2805         https://bugs.webkit.org/show_bug.cgi?id=193725
2806         <rdar://problem/47464879>
2807
2808         Reviewed by Geoff Garen.
2809
2810         Update existing API tests to stop using deprecated API.
2811
2812         * MiniBrowser/mac/AppDelegate.m:
2813         (defaultConfiguration):
2814         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2815         (TestWebKitAPI::TEST):
2816         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2817         (TestWebKitAPI::TEST):
2818         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2819         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2820         (TEST):
2821         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2822         (TEST):
2823
2824 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2825
2826         [ews-app] Rename ews model buildermappings to buildermapping
2827         https://bugs.webkit.org/show_bug.cgi?id=193729
2828
2829         Reviewed by Lucas Forschler.
2830
2831         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2832         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2833         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2834
2835 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2836
2837         [ews-app] Rename ews model steps to step
2838         https://bugs.webkit.org/show_bug.cgi?id=193697
2839
2840         Reviewed by Lucas Forschler.
2841
2842         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2843         (Step): Renamed Steps to Step.
2844
2845 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2846
2847         Clean up IndexedDB files between tests
2848         https://bugs.webkit.org/show_bug.cgi?id=192796
2849         <rdar://problem/46824999>
2850
2851         Reviewed by Geoffrey Garen.
2852
2853         * DumpRenderTree/mac/DumpRenderTree.mm:
2854         (runTest):
2855         * WebKitTestRunner/TestController.cpp:
2856         (WTR::TestController::resetStateToConsistentValues):
2857         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2858         (WTR::RemoveAllIndexedDatabasesCallback):
2859         (WTR::TestController::ClearIndexedDatabases):
2860         * WebKitTestRunner/TestController.h:
2861         * WebKitTestRunner/TestInvocation.cpp:
2862         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2863
2864 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2865
2866         [ews-app] Rename ews model Builds to Build
2867         https://bugs.webkit.org/show_bug.cgi?id=193695
2868
2869         Reviewed by Lucas Forschler.
2870
2871         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2872         (Build): Renamed Builds to Build.
2873
2874 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2875
2876         webkitpy: Wait longer when launching WebKitTestRunner
2877         https://bugs.webkit.org/show_bug.cgi?id=193734
2878
2879         Reviewed by Aakash Jain.
2880
2881         * Scripts/webkitpy/port/simulator_process.py:
2882         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2883
2884 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2885
2886         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2887         https://bugs.webkit.org/show_bug.cgi?id=193182
2888         <rdar://problem/47452154>
2889
2890         Reviewed by Tim Horton.
2891
2892         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2893         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2894         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2895
2896         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2897         preventing later tests from recognizing gestures.
2898
2899         * WebKitTestRunner/ios/TestControllerIOS.mm:
2900         (WTR::TestController::platformResetStateToConsistentValues):
2901
2902         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2903
2904 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2905
2906         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2907         https://bugs.webkit.org/show_bug.cgi?id=193722
2908         <rdar://problem/47481475>
2909
2910         Reviewed by Lucas Forschler.
2911
2912         iPhone and iPad ports should both use the iOS config.
2913
2914         * Scripts/webkitpy/port/ios_simulator.py:
2915         (IPhoneSimulatorPort.__init__):
2916         (IPadSimulatorPort.__init__):
2917
2918 2019-01-23  Rob Buis  <rbuis@igalia.com>
2919
2920         Update MIME type parser
2921         https://bugs.webkit.org/show_bug.cgi?id=180526
2922
2923         Reviewed by Frédéric Wang.
2924
2925         Add unit tests for both parse modes of ParsedContentType.
2926
2927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2928         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2929         (TestWebKitAPI::TEST):
2930
2931 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2932
2933         [ews-app] fetch loop should not stop on network issues
2934         https://bugs.webkit.org/show_bug.cgi?id=193666
2935
2936         Reviewed by Lucas Forschler.
2937
2938         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2939         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2940
2941 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2942
2943         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2944         https://bugs.webkit.org/show_bug.cgi?id=189165
2945         <rdar://problem/47433765>
2946
2947         Reviewed by Tim Horton.
2948
2949         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2950         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2951         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2952         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2953         would make its way to the UI process by the time the layer tree commit is finished.
2954
2955         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2956         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2957         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2958         will fail because it asks for -_autofillContext too early.
2959
2960         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2961         is handled in the UI process.
2962
2963         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2964
2965         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2966         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2967         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2968         input session.
2969
2970         (-[AutofillTestView textInputHasAutofillContext]):
2971
2972         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2973
2974         * TestWebKitAPI/cocoa/TestWKWebView.h:
2975         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2976         (nextInputSessionChangeCount):
2977
2978         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2979         This includes changing the focused element from one to another.
2980
2981         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2982         (-[TestWKWebView didStartFormControlInteraction]):
2983         (-[TestWKWebView didEndFormControlInteraction]):
2984         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2985
2986         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2987         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2988         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2989         that doesn't require an input session to one that doesn't.
2990
2991 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2992
2993         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2994         <https://webkit.org/b/193676>
2995
2996         Reviewed by Alexey Proskuryakov.
2997
2998         * Scripts/webkitpy/style/checkers/cpp.py:
2999         (check_member_initialization_list):
3000         - Don't report missing whitespace around colon if the colon at
3001           the start of the line is formatted correctly.
3002         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3003         (WebKitStyleTest.test_member_initialization_list):
3004         - Add a test for a missing permutation of existing tests.
3005         - Add a test this false-positive.
3006         - Add blank lines between subtests to make them easier to read.
3007
3008 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3009
3010         [build.webkit.org] Unit-test failure after r237113
3011         https://bugs.webkit.org/show_bug.cgi?id=193669
3012
3013         Reviewed by Michael Catanzaro.
3014
3015         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3016         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3017         multiple or zero flags.
3018
3019 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3020
3021         Cache bytecode to disk
3022         https://bugs.webkit.org/show_bug.cgi?id=192782
3023         <rdar://problem/46084932>
3024
3025         Reviewed by Keith Miller.
3026
3027         Add test helper to execute bytecode-cache tests: it executes each test
3028         twice, the first with JSC_diskCachePath set to a temporary directory
3029         and second with JSC_forceDiskCache=true (in addition to the cache path)
3030         to guarantee that only the disk cache is being used and no new
3031         UnlinkedCodeBlocks are being created.
3032
3033         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3034         * Scripts/run-jsc-stress-tests:
3035
3036 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3037
3038         [css-logical] Implement flow-relative margin, padding and border shorthands
3039         https://bugs.webkit.org/show_bug.cgi?id=188697
3040
3041         Reviewed by Simon Fraser and Antti Koivisto.
3042
3043         * DumpRenderTree/TestOptions.cpp:
3044         (TestOptions::TestOptions):
3045         * DumpRenderTree/TestOptions.h:
3046         * DumpRenderTree/mac/DumpRenderTree.mm:
3047         (setWebPreferencesForTestOptions):
3048         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3049
3050         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3051         (JSONCSSPropertiesChecker.check_codegen_properties):
3052         Allow CSS property definitions to have a 'runtime-flag' parameter which
3053         disables the property when the specified runtime flag is disabled.
3054
3055 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3056
3057         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3058         https://bugs.webkit.org/show_bug.cgi?id=193643
3059
3060         Reviewed by Michael Catanzaro.
3061
3062         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3063         * wpe/jhbuild.modules: Ditto.
3064
3065 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3066
3067         [LFC][Floats] Take float top position into account when computing containing block height.
3068         https://bugs.webkit.org/show_bug.cgi?id=193655
3069
3070         Reviewed by Antti Koivisto.
3071
3072         * LayoutReloaded/misc/LFC-passing-tests.txt:
3073
3074 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3075
3076         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3077         <https://webkit.org/b/193645>
3078         <rdar://problem/47421574>
3079
3080         Reviewed by Alex Christensen.
3081
3082         - Now checks for local soft-linking of all frameworks that have
3083           their own *SoftLinking.{cpp,h,mm} files.
3084         - Changes softlink/uikit warning to softlink/framework.
3085
3086         * Scripts/webkitpy/style/checkers/cpp.py:
3087         (check_language):
3088         (CppChecker):
3089         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3090         (CppStyleTest):
3091
3092 2019-01-20  Saam Barati  <sbarati@apple.com>
3093
3094         Rollout r240210: It broke tests on iOS
3095         https://bugs.webkit.org/show_bug.cgi?id=193640
3096
3097         Unreviewed.
3098
3099         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3100         * Scripts/run-jsc-stress-tests:
3101
3102 2019-01-20  chris fleizach  <cfleizach@apple.com>
3103
3104         AX: Support returning relative frames for accessibility
3105         https://bugs.webkit.org/show_bug.cgi?id=193414
3106         <rdar://problem/47268501>
3107
3108         Reviewed by Zalan Bujtas.
3109
3110         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3111         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3112         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3113         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3114         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3115         (WTR::attributesOfElement):
3116         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3117
3118 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3119
3120         Unreviewed, add my new email address
3121
3122         * Scripts/webkitpy/common/config/contributors.json:
3123
3124 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3125
3126         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3127         https://bugs.webkit.org/show_bug.cgi?id=193617
3128
3129         Reviewed by Antti Koivisto.
3130
3131         * LayoutReloaded/misc/LFC-passing-tests.txt:
3132
3133 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3134
3135         Unreviewed, rolling out r240209.
3136
3137         Broke GTK/WPE injected bundle
3138
3139         Reverted changeset:
3140
3141         "AX: Support returning relative frames for accessibility"
3142         https://bugs.webkit.org/show_bug.cgi?id=193414
3143         https://trac.webkit.org/changeset/240209
3144
3145 2019-01-12  Dan Bernstein  <mitz@apple.com>
3146
3147         [Cocoa] Avoid importing directly from subumbrella frameworks
3148         https://bugs.webkit.org/show_bug.cgi?id=186016
3149         <rdar://problem/40591038>
3150
3151         Reviewed by Sam Weinig.
3152
3153         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3154           LaunchServices header.
3155         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3156           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3157         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3158           when using SDKs earlier than 10.13.
3159         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3160           and OTHER_CPLUSPLUSFLAGS.
3161         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3162           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3163         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3164           LaunchServices header.
3165
3166 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3167
3168         Cache bytecode to disk
3169         https://bugs.webkit.org/show_bug.cgi?id=192782
3170         <rdar://problem/46084932>
3171
3172         Reviewed by Keith Miller.
3173
3174         Add test helper to execute bytecode-cache tests: it executes each test
3175         twice, the first with JSC_diskCachePath set to a temporary directory
3176         and second with JSC_forceDiskCache=true (in addition to the cache path)
3177         to guarantee that only the disk cache is being used and no new
3178         UnlinkedCodeBlocks are being created.
3179
3180         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3181         * Scripts/run-jsc-stress-tests:
3182
3183 2019-01-20  chris fleizach  <cfleizach@apple.com>
3184
3185         AX: Support returning relative frames for accessibility
3186         https://bugs.webkit.org/show_bug.cgi?id=193414
3187         <rdar://problem/47268501>
3188
3189         Reviewed by Zalan Bujtas.
3190
3191         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3192         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3193         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3194         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3195         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3196         (WTR::attributesOfElement):
3197         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3198
3199 2019-01-20  Antoine Quint  <graouts@apple.com>
3200
3201         Add a POINTER_EVENTS feature flag
3202         https://bugs.webkit.org/show_bug.cgi?id=193577
3203         <rdar://problem/47408511>
3204
3205         Unreviewed. Also enable Pointer Events for iosmac.
3206
3207         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3208
3209 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3210
3211         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3212         https://bugs.webkit.org/show_bug.cgi?id=193613
3213
3214         Reviewed by Antti Koivisto.
3215
3216         * LayoutReloaded/misc/LFC-passing-tests.txt:
3217
3218 2019-01-19  Antoine Quint  <graouts@apple.com>
3219
3220         Add a POINTER_EVENTS feature flag
3221         https://bugs.webkit.org/show_bug.cgi?id=193577
3222
3223         Reviewed by Dean Jackson.
3224
3225         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3226
3227 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3228
3229         Disable the run-jsc-stress-test remote host key check [second round].
3230         https://bugs.webkit.org/show_bug.cgi?id=192988
3231
3232         Reviewed by Dewei Zhu.
3233
3234         * Scripts/run-jsc-stress-tests:
3235
3236 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3237
3238         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3239         https://bugs.webkit.org/show_bug.cgi?id=193597
3240
3241         Reviewed by Lucas Forschler.
3242
3243         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3244
3245 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3246
3247         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3248         https://bugs.webkit.org/show_bug.cgi?id=193595
3249
3250         Reviewed by Lucas Forschler.
3251
3252         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3253         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3254         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3255
3256 2019-01-18  Chris Dumez  <cdumez@apple.com>
3257
3258         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3259         https://bugs.webkit.org/show_bug.cgi?id=193588
3260         <rdar://problem/47131566>
3261
3262         Reviewed by Alex Christensen.
3263
3264         Add layout test coverage.
3265
3266         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3267
3268 2019-01-18  Jer Noble  <jer.noble@apple.com>
3269
3270         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3271         https://bugs.webkit.org/show_bug.cgi?id=189553
3272
3273         Reviewed by Tim Horton.
3274
3275         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3276
3277         * ContentExtensionTester/Configurations/Base.xcconfig:
3278         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3279         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3280         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3281         * ImageDiff/cg/Configurations/Base.xcconfig:
3282         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3283         * MiniBrowser/Configurations/Base.xcconfig:
3284         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3285         * MobileMiniBrowser/Configurations/Base.xcconfig:
3286         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3287         * Scripts/webkitpy/style/checker.py:
3288         (_all_categories):
3289         (FileType):
3290         (CheckerDispatcher._file_type):
3291         (CheckerDispatcher._create_checker):
3292         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3293         (SDKVariantChecker):
3294         (SDKVariantChecker.__init__):
3295         (SDKVariantChecker.check):
3296         * TestWebKitAPI/Configurations/Base.xcconfig:
3297         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3298         * WebEditingTester/Configurations/Base.xcconfig:
3299         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3300         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3301         * WebKitTestRunner/Configurations/Base.xcconfig:
3302         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3303         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3304         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3305
3306 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3307
3308         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3309         <https://webkit.org/b/193568>
3310         <rdar://problem/47381130>
3311
3312         Reviewed by Alex Christensen.
3313
3314         Make sure no one re-introduces UIKit soft-linking by adding a
3315         style rule.
3316
3317         * Scripts/webkitpy/style/checkers/cpp.py:
3318         (check_language): Add softlink/uikit check.
3319         (CppChecker): Enable softlink/uikit check.
3320         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3321         (CppStyleTest): Add test for softlink/uikit.
3322
3323 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3324
3325         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3326         https://bugs.webkit.org/show_bug.cgi?id=193584
3327
3328         Change "-dev" to "-devel".
3329
3330         Reviewed by Michael Catanzaro.
3331
3332         * gtk/install-dependencies:
3333
3334 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3335
3336         webkitpy: Add iPhone and iPad ports
3337         https://bugs.webkit.org/show_bug.cgi?id=193537
3338         <rdar://problem/47353390>
3339
3340         Reviewed by Lucas Forschler.
3341
3342         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3343         ports. Note that this separation is optional, the --ios-simulator command remains.
3344
3345         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3346         (RunTest.test_device_type_test_division): Drive-by fix.
3347         (RunTest.test_device_type_specific_listing): Ditto.
3348         (RunTest.test_ipad_test_division):
3349         (RunTest):
3350         (RunTest.test_ipad_listing):
3351         * Scripts/webkitpy/port/factory.py:
3352         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3353         (PortFactory):
3354         * Scripts/webkitpy/port/ios_simulator.py:
3355         (IPhoneSimulatorPort):
3356         (IPadSimulatorPort):
3357
3358 2019-01-18  Chris Dumez  <cdumez@apple.com>
3359
3360         Regression(PSON) Scroll position is not always restored properly when navigating back
3361         https://bugs.webkit.org/show_bug.cgi?id=193578
3362         <rdar://problem/47386331>
3363
3364         Reviewed by Tim Horton.
3365
3366         Add API test coverage.
3367
3368         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3369
3370 2019-01-18  Youenn Fablet  <youenn@apple.com>
3371
3372         Add a new SPI to request for cache storage quota increase
3373         https://bugs.webkit.org/show_bug.cgi?id=193323
3374
3375         Reviewed by Alex Christensen.
3376
3377         Implement WebsiteDataStore quota delegate to handle quota requests.
3378         By default, do not update quota.
3379         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3380
3381         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3382         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3383         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3384         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3385         * WebKitTestRunner/TestController.cpp:
3386         (WTR::TestController::allowCacheStorageQuotaIncrease):
3387         * WebKitTestRunner/TestController.h:
3388         * WebKitTestRunner/TestInvocation.cpp:
3389         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3390         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3391         (-[CacheStorageQuotaManager init]):
3392         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3393         (WTR::initializeWebViewConfiguration):
3394         (WTR::TestController::cocoaResetStateToConsistentValues):
3395         (WTR::TestController::allowCacheStorageQuotaIncrease):
3396
3397 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3398
3399         [ews-build] Pass owner to the triggered builds
3400         https://bugs.webkit.org/show_bug.cgi?id=193574
3401
3402         Reviewed by Lucas Forschler.
3403
3404         * BuildSlaveSupport/ews-build/factories.py:
3405         (BuildFactory.propertiesToPassToTriggers):
3406
3407 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3408
3409         [ews-app] Send patch author as a build property
3410         https://bugs.webkit.org/show_bug.cgi?id=193560
3411
3412         Reviewed by Lucas Forschler.
3413
3414         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3415         (BugzillaPatchFetcher.fetch):
3416
3417 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3418
3419         webkitpy: Implement device type specific expected results (Follow-up fix)
3420         https://bugs.webkit.org/show_bug.cgi?id=192162
3421         <rdar://problem/46345449>
3422
3423         Unreviewed infrastructure fix.
3424
3425         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3426         (Manager.run): Don't boot a device if no tests are available to run on it.
3427
3428 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3429
3430         webkitpy: Implement device type specific expected results (Follow-up fix)
3431         https://bugs.webkit.org/show_bug.cgi?id=192162
3432         <rdar://problem/46345449>
3433
3434         Unreviewed infrastructure fix.
3435
3436         * Scripts/webkitpy/api_tests/manager.py:
3437         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3438
3439 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3440
3441         webkitpy: Implement device type specific expected results (Part 2)
3442         https://bugs.webkit.org/show_bug.cgi?id=192162
3443         <rdar://problem/46345449>
3444
3445         Rubber-stamped by Aakash Jain.
3446
3447         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3448         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3449         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3450
3451         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3452         (LayoutTestFinder.find_tests): Pass device_type through.
3453         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3454         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3455         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3456         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3457         (Manager._collect_tests): Pass device type to test finder.
3458         (Manager._needs_web_platform_test):
3459         (Manager._prepare_lists): Index _expectations by device type.
3460         (Manager._test_input_for_file):
3461         (Manager._test_is_slow): Ditto.
3462         (Manager._test_should_dump_jsconsolelog_in_stderr):
3463         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3464         (Manager._get_test_inputs):
3465         (Manager._update_worker_count):
3466         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3467         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3468         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3469         the one which runs the test.
3470         (Manager._run_test_subset):
3471         (Manager._run_tests): Index _expectations by current_device_type.
3472         (Manager._print_expectation_line_for_test): Ditto.
3473         (Manager._print_expectations_for_subset): Ditto.
3474         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3475         Unlike run, this function will behave the same regardless of what devices are available.
3476         (Manager._custom_device_for_test): Deleted.
3477         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3478         (ManagerTest.test_uses_custom_device): Deleted.
3479         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3480         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3481         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3482         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3483         all of the expectations.
3484         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3485         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3486         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3487         (TestExpectations.__init__): Allow device_type to be passed through.
3488         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3489         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3490         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3491         (summarize_results):
3492         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3493         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3494         a test ran with, one must check all expectations to find the first non-skip expectation.
3495         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3496         (RunTest.test_device_type_test_division):
3497         (RunTest):
3498         (RunTest.test_device_type_specific_listing):
3499         * Scripts/webkitpy/port/base.py:
3500         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3501         (Port.supported_device_types): The result of this function will change based on what devices are available.
3502         * Scripts/webkitpy/port/device_port.py:
3503         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3504         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3505         can be used.
3506         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3507         any, or the DEFAULT_DEVICE_TYPES of the port.
3508         * Scripts/webkitpy/port/ios.py:
3509         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3510         * Scripts/webkitpy/port/ios_simulator.py:
3511         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3512         * Scripts/webkitpy/port/watch.py:
3513         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3514         * Scripts/webkitpy/port/watch_simulator.py:
3515         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3516         * Scripts/webkitpy/xcode/device_type.py:
3517         (DeviceType):
3518         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3519
3520 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3521
3522         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3523         https://bugs.webkit.org/show_bug.cgi?id=193575
3524
3525         Reviewed by Michael Catanzaro.
3526
3527         Allow the script to run without explicit port argument because
3528         it's specific to the WPE port anyway.
3529
3530         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3531         and simplify the rest of the code accordingly.
3532
3533 2019-01-18  Charlie Turner  <cturner@igalia.com>
3534
3535         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3536         https://bugs.webkit.org/show_bug.cgi?id=192229
3537
3538         Reviewed by Xabier Rodriguez-Calvar.
3539
3540         * MiniBrowser/wpe/main.cpp:
3541         (main): Enable encrypted-media by default.
3542
3543 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3544
3545         [Flatpak] Missing KeyboardInterrupt exception handler
3546         https://bugs.webkit.org/show_bug.cgi?id=193570
3547
3548         Reviewed by Michael Catanzaro.
3549
3550         * flatpak/flatpakutils.py:
3551         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3552
3553 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3554
3555         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3556         https://bugs.webkit.org/show_bug.cgi?id=193564
3557
3558         Reviewed by Antti Koivisto.
3559
3560         * LayoutReloaded/misc/LFC-passing-tests.txt:
3561
3562 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3563
3564         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3565         https://bugs.webkit.org/show_bug.cgi?id=193562
3566
3567         Reviewed by Antti Koivisto.
3568
3569         * LayoutReloaded/misc/LFC-passing-tests.txt:
3570
3571 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3572
3573         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3574         https://bugs.webkit.org/show_bug.cgi?id=193555
3575
3576         Reviewed by Antti Koivisto.
3577
3578         * LayoutReloaded/misc/LFC-passing-tests.txt:
3579
3580 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3581
3582         [WPE] Add Qt extension
3583         https://bugs.webkit.org/show_bug.cgi?id=191464
3584
3585         Reviewed by Carlos Garcia Campos.
3586
3587         MiniBrowser and API tests for the WPE Qt API. To run the
3588         MiniBrowser a new script is introduced. Example invocation:
3589
3590         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3591
3592         Also note-worthy is the introduction of the python2-subprocess32
3593         dependency to run the GLib API tests.
3594
3595         * MiniBrowser/wpe/CMakeLists.txt:
3596         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3597         * MiniBrowser/wpe/qt/main.cpp: Added.
3598         (main):
3599         * MiniBrowser/wpe/qt/main.qml: Added.
3600         * MiniBrowser/wpe/qt/qml.qrc: Added.
3601         * Scripts/run-gtk-tests:
3602         (GtkTestRunner.is_google_test):
3603         (GtkTestRunner):
3604         (GtkTestRunner.is_qt_test):
3605         * Scripts/run-qt-wpe-minibrowser: Added.
3606         * Scripts/run-wpe-tests:
3607         (WPETestRunner):
3608         (WPETestRunner.is_google_test):
3609         (WPETestRunner.is_qt_test):
3610         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3611         (TestLoad::main):
3612         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3613         (TestLoadHtml::main):
3614         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3615         (TestLoadRequest::main):
3616         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3617         (TestRunJavaScript::main):
3618         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3619         (waitForSignal):
3620         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3621         (LoadSpy::LoadSpy):
3622         (LoadSpy::~LoadSpy):
3623         (LoadSpy::onLoadingChanged):
3624         (LoadStartedCatcher::LoadStartedCatcher):
3625         (LoadStartedCatcher::~LoadStartedCatcher):
3626         (LoadStartedCatcher::onLoadingChanged):
3627         (waitForLoadSucceeded):
3628         (waitForLoadFailed):
3629         * TestWebKitAPI/glib/CMakeLists.txt:
3630         * flatpak/flatpakutils.py:
3631         (WebkitFlatpak.load_from_args):
3632         (WebkitFlatpak.__init__):
3633         (WebkitFlatpak.clean_args):
3634         (WebkitFlatpak.run_in_sandbox):
3635         * flatpak/org.webkit.CommonModules.yaml:
3636         * flatpak/org.webkit.WPE.yaml:
3637         * flatpak/org.webkit.WPEModules.yaml:
3638         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3639         * flatpak/org.webkit.WebKit.yaml:
3640         * glib/api_test_runner.py:
3641         (TestRunner._run_test_qt):
3642         (TestRunner.is_qt_test):
3643         (TestRunner._run_test):
3644
3645 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3646
3647         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3648         https://bugs.webkit.org/show_bug.cgi?id=193494
3649         <rdar://problem/46859627>
3650
3651         Reviewed by Simon Fraser and Tim Horton.
3652
3653         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3654         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3655
3656         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3657         (WTR::UIScriptController::contentOffsetX const):
3658         (WTR::UIScriptController::contentOffsetY const):
3659         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3660         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3661         (WTR::UIScriptController::contentOffsetX const):
3662         (WTR::UIScriptController::contentOffsetY const):
3663         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3664
3665         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3666
3667         * WebKitTestRunner/TestController.cpp:
3668         (WTR::updateTestOptionsFromTestHeader):
3669         * WebKitTestRunner/TestOptions.h:
3670         (WTR::TestOptions::hasSameInitializationOptions const):
3671         * WebKitTestRunner/ios/TestControllerIOS.mm:
3672         (WTR::TestController::platformResetStateToConsistentValues):
3673         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3674         (WTR::UIScriptController::contentOffsetX const):
3675         (WTR::UIScriptController::contentOffsetY const):
3676
3677 2019-01-17  Truitt Savell  <tsavell@apple.com>
3678
3679         Unreviewed, rolling out r240124.
3680
3681         This commit broke an internal build.
3682
3683         Reverted changeset:
3684
3685         "SDK_VARIANT build destinations should be separate from non-
3686         SDK_VARIANT builds"
3687         https://bugs.webkit.org/show_bug.cgi?id=189553
3688         https://trac.webkit.org/changeset/240124
3689
3690 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3691
3692         Fix string concatenation API test after r239920
3693         https://bugs.webkit.org/show_bug.cgi?id=193551
3694         <rdar://problem/47359304>
3695
3696         Reviewed by Youenn Fablet.
3697
3698         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3699         (TestWebKitAPI::TEST):
3700         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3701         in WebKit's build configuration like it apparently is on Linux.
3702
3703 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3704
3705         [ews-build] validate-patch should handle the case when bug_id is None
3706         https://bugs.webkit.org/show_bug.cgi?id=193547
3707
3708         Reviewed by Lucas Forschler.
3709
3710         * BuildSlaveSupport/ews-build/steps.py:
3711         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3712         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3713
3714 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3715
3716         [ews-build] Add patch author information in build
3717         https://bugs.webkit.org/show_bug.cgi?id=193465
3718
3719         Reviewed by Lucas Forschler.
3720
3721         * BuildSlaveSupport/ews-build/steps.py:
3722         (ValidatePatch._is_patch_obsolete):
3723
3724 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3725
3726         [ews-build] Pass bug_id to the triggered builds
3727         https://bugs.webkit.org/show_bug.cgi?id=193548
3728
3729         Reviewed by Lucas Forschler.
3730
3731         * BuildSlaveSupport/ews-build/factories.py:
3732         (BuildFactory.propertiesToPassToTriggers):
3733
3734 2019-01-17  Jer Noble  <jer.noble@apple.com>
3735
3736         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3737         https://bugs.webkit.org/show_bug.cgi?id=189553
3738
3739         Reviewed by Tim Horton.
3740
3741         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3742
3743         * ContentExtensionTester/Configurations/Base.xcconfig:
3744         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3745         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3746         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3747         * ImageDiff/cg/Configurations/Base.xcconfig:
3748         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3749         * MiniBrowser/Configurations/Base.xcconfig:
3750         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3751         * MobileMiniBrowser/Configurations/Base.xcconfig:
3752         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3753         * Scripts/webkitpy/style/checker.py:
3754         (_all_categories):
3755         (FileType):
3756         (CheckerDispatcher._file_type):
3757         (CheckerDispatcher._create_checker):
3758         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3759         (SDKVariantChecker):
3760         (SDKVariantChecker.__init__):
3761         (SDKVariantChecker.check):
3762         * TestWebKitAPI/Configurations/Base.xcconfig:
3763         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3764         * WebEditingTester/Configurations/Base.xcconfig:
3765         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3766         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3767         * WebKitTestRunner/Configurations/Base.xcconfig:
3768         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3769         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3770         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3771
3772 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3773
3774         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3775         https://bugs.webkit.org/show_bug.cgi?id=193534
3776
3777         Reviewed by Antti Koivisto.
3778
3779         * LayoutReloaded/misc/LFC-passing-tests.txt:
3780
3781 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3782
3783         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3784         https://bugs.webkit.org/show_bug.cgi?id=193528
3785
3786         Reviewed by Antti Koivisto.
3787
3788         * LayoutReloaded/misc/LFC-passing-tests.txt:
3789
3790 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3791
3792         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3793         https://bugs.webkit.org/show_bug.cgi?id=193520
3794
3795         Reviewed by Antti Koivisto.
3796
3797         * LayoutReloaded/misc/LFC-passing-tests.txt:
3798
3799 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3800
3801         [ews-build] unapply-patch step should not update source
3802         https://bugs.webkit.org/show_bug.cgi?id=193234
3803
3804         Reviewed by Lucas Forschler.
3805
3806         * BuildSlaveSupport/ews-build/steps.py:
3807         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3808         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3809
3810 2019-01-16  Youenn Fablet  <youenn@apple.com>
3811
3812         Add a new SPI for controlling getUserMedia
3813         https://bugs.webkit.org/show_bug.cgi?id=192793
3814
3815         Reviewed by Eric Carlson.
3816
3817         * MiniBrowser/mac/WK2BrowserWindowController.m:
3818         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3819         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3820         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3821         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3822         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3823         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3824         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3825         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3826         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3827         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3828         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3829         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3830         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3831         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3832
3833 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3834
3835         [LFC][BFC] Inflow non-replaced used width should not be negative.
3836         https://bugs.webkit.org/show_bug.cgi?id=193495
3837
3838         Reviewed by Antti Koivisto.
3839
3840         * LayoutReloaded/misc/LFC-passing-tests.txt:
3841
3842 2019-01-16  Chris Dumez  <cdumez@apple.com>
3843
3844         Regression(PSON) View becomes blank after click a cross-site download link
3845         https://bugs.webkit.org/show_bug.cgi?id=193361
3846         <rdar://problem/47099573>
3847
3848         Reviewed by Geoffrey Garen.
3849
3850         Add API test coverage.
3851
3852         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3853         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3854
3855 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3856
3857         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3858         https://bugs.webkit.org/show_bug.cgi?id=193470
3859
3860         Reviewed by Antti Koivisto.
3861
3862         * LayoutReloaded/misc/LFC-passing-tests.txt:
3863
3864 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3865
3866         [LFC] Adjust margin box verification.
3867         https://bugs.webkit.org/show_bug.cgi?id=193482
3868
3869         Reviewed by Antti Koivisto.
3870
3871         * LayoutReloaded/misc/LFC-passing-tests.txt:
3872
3873 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3874
3875         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3876         https://bugs.webkit.org/show_bug.cgi?id=193451
3877
3878         Reviewed by Geoffrey Garen.
3879
3880         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3881         (TEST):
3882         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3883         (runWebsiteDataStoreCustomPaths):
3884
3885 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3886
3887         webkitpy: Support boolean simctl isAvailable
3888         https://bugs.webkit.org/show_bug.cgi?id=193472
3889         <rdar://problem/47296150>
3890
3891         Reviewed by Ryosuke Niwa.
3892
3893         * Scripts/webkitpy/xcode/simulated_device.py:
3894         (SimulatedDeviceManager._create_runtimes):
3895         (SimulatedDeviceManager._create_device_with_runtime):
3896
3897 2019-01-15  Chris Dumez  <cdumez@apple.com>
3898
3899         Unreviewed, rolling out r239993, r239995, r239997, and
3900         r239999.
3901
3902         Caused assertions under
3903         ViewGestureController::disconnectFromProcess()
3904
3905         Reverted changesets:
3906
3907         "Regression(PSON) View becomes blank after click a cross-site
3908         download link"
3909         https://bugs.webkit.org/show_bug.cgi?id=193361
3910         https://trac.webkit.org/changeset/239993
3911
3912         "Unreviewed iOS build fix after r239993."
3913         https://trac.webkit.org/changeset/239995
3914
3915         "Fix iOS build after r239993"
3916         https://bugs.webkit.org/show_bug.cgi?id=193361
3917         https://trac.webkit.org/changeset/239997
3918
3919         "Unreviewed, revert part of r239997 as it is not needed to fix
3920         the build."
3921         https://trac.webkit.org/changeset/239999
3922
3923 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3924
3925         Cannot tab out of WKWebView on macOS
3926         https://bugs.webkit.org/show_bug.cgi?id=161448
3927         <rdar://problem/28100085>
3928
3929         Reviewed by Dean Jackson.
3930
3931         Add a test that tabbing into and out of WKWebView works correctly.
3932
3933         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3934         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3935         (WebKit2_CommandBackForwardTest::SetUp):
3936         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3937         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3938         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3939         (-[FocusableView canBecomeKeyView]):
3940         (TEST):
3941         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3942         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3943         (-[OffscreenWindow initWithSize:]):
3944         (-[OffscreenWindow isKeyWindow]):
3945         (-[OffscreenWindow isVisible]):
3946         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3947         (TestWebKitAPI::PlatformWebView::initialize):
3948         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3949         (-[ActiveOffscreenWindow isVisible]): Deleted.
3950         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3951
3952 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3953
3954         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3955         https://bugs.webkit.org/show_bug.cgi?id=193459
3956
3957         Reviewed by Mark Lam.
3958
3959         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3960         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3961
3962 2019-01-15  Chris Dumez  <cdumez@apple.com>
3963
3964         Regression(PSON) View becomes blank after click a cross-site download link
3965         https://bugs.webkit.org/show_bug.cgi?id=193361
3966         <rdar://problem/47099573>
3967
3968         Reviewed by Geoff Garen.
3969
3970         Add API test coverage.
3971
3972         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3973         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3974
3975 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3976
3977         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3978         https://bugs.webkit.org/show_bug.cgi?id=193448
3979
3980         Reviewed by Antti Koivisto.
3981
3982         * LayoutReloaded/misc/LFC-passing-tests.txt:
3983
3984 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3985
3986         webkitpy: Implement device type specific expected results (Part 1)
3987         https://bugs.webkit.org/show_bug.cgi?id=192162
3988
3989         Reviewed by Lucas Forschler.
3990
3991         Device type specific expected results covers two related ideas. The first (covered by this change)
3992         is where to search for -expected.* files. The second is which tests to run based on the
3993         TestExpectations.txt file.
3994
3995         After this change, the baseline search path will be determined by the type of device running a
3996         test. Device type will be passed into any function which picks a file based on the baseline search
3997         path.
3998
3999         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4000         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
4001         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4002         (Manager.run): Print baseline search path for each round of devices.
4003         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
4004         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
4005         (SingleTestRunner._expected_driver_output): Ditto.
4006         (SingleTestRunner._driver_input): Ditto.
4007         * Scripts/webkitpy/layout_tests/views/printing.py:
4008         (Printer.print_config): Move printing of baseline search path to a separate function.
4009         (Printer.print_baseline_search_path): Moved from Printer.print_config.
4010         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4011         (Testprinter.test_print_config):
4012         (Testprinter.test_print_baseline_search_path):
4013         * Scripts/webkitpy/port/base.py:
4014         (Port.baseline_search_path): Pass device_type through.
4015         (Port._expected_baselines_for_suffixes): Ditto.
4016         (Port.expected_baselines): Ditto.
4017         (Port.expected_filename): Ditto.
4018         (Port.expected_checksum): Ditto.
4019         (Port.expected_image): Ditto.
4020         (Port.expected_audio): Ditto.
4021         (Port.expected_text): Ditto.
4022         (Port.reference_files): Ditto.
4023         (Port.tests): Ditto.
4024         (Port._expanded_paths): Ditto.
4025         (Port.skipped_layout_tests): Ditto.
4026         (Port.expectations_dict): Ditto.
4027         (Port._port_specific_expectations_files): Ditto.
4028         (Port.expectations_files): Ditto.
4029         (Port.test_search_path): Ditto.
4030         (Port._tests_for_other_platforms): Ditto.
4031         * Scripts/webkitpy/port/base_unittest.py:
4032         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
4033         (PortTest.test_nonexistant_expectations): Ditto.
4034         (test_ref_tests_platform_directory): Ditto.
4035         * Scripts/webkitpy/port/darwin.py:
4036         (DarwinPort._port_specific_expectations_files): Accept device_type.
4037         * Scripts/webkitpy/port/driver.py:
4038         (DriverProxy):
4039         (DriverProxy.host): Expose _target_host for device_type information.
4040         * Scripts/webkitpy/port/gtk.py:
4041         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
4042         * Scripts/webkitpy/port/ios.py:
4043         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4044         * Scripts/webkitpy/port/mac.py:
4045         (MacPort. default_baseline_search_path): Ditto.
4046         * Scripts/webkitpy/port/port_testcase.py:
4047         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
4048         * Scripts/webkitpy/port/test.py:
4049         * Scripts/webkitpy/port/watch.py:
4050         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4051         * Scripts/webkitpy/port/win.py:
4052         (WinPort.test_search_path): Accept, but do not use, device_type.
4053         * Scripts/webkitpy/port/wpe.py:
4054         (WPEPort._port_specific_expectations_files): Ditto.
4055         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
4056         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
4057
4058 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4059
4060         [LFC] Use the containing block's padding box to position out-of-flow elements.
4061         https://bugs.webkit.org/show_bug.cgi?id=193431
4062
4063         Reviewed by Antti Koivisto.
4064
4065         * LayoutReloaded/misc/LFC-passing-tests.txt:
4066
4067 2019-01-14  Tim Horton  <timothy_horton@apple.com>
4068
4069         Move a test implementation file that got misplaced in the Xcode project
4070
4071         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4072
4073 2019-01-14  Commit Queue  <commit-queue@webkit.org>
4074
4075         Unreviewed, rolling out r239901, r239909, r239910, r239912,
4076         r239913, and r239914.
4077         https://bugs.webkit.org/show_bug.cgi?id=193407
4078
4079         These revisions caused an internal failure (Requested by
4080         Truitt on #webkit).
4081
4082         Reverted changesets:
4083
4084         "[Cocoa] Avoid importing directly from subumbrella frameworks"
4085         https://bugs.webkit.org/show_bug.cgi?id=186016
4086         https://trac.webkit.org/changeset/239901
4087
4088         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
4089         https://trac.webkit.org/changeset/239909
4090
4091         "Tried to fix the build."
4092         https://trac.webkit.org/changeset/239910
4093
4094         "Fixed iOS builds after r239910."
4095         https://trac.webkit.org/changeset/239912
4096
4097         "More build fixing."
4098         https://trac.webkit.org/changeset/239913
4099
4100         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
4101         https://trac.webkit.org/changeset/239914
4102
4103 2019-01-14  Mark Lam  <mark.lam@apple.com>
4104
4105         Re-enable ability to build --cloop builds.
4106         https://bugs.webkit.org/show_bug.cgi?id=192955
4107         <rdar://problem/46882363>
4108
4109         Reviewed by Saam barati and Keith Miller.
4110
4111         The --cloop build option was being ignored this whole time since r236381.
4112         This patch makes it possible to build CLoop builds again.
4113
4114         * Scripts/build-jsc:
4115         * Scripts/webkitperl/FeatureList.pm:
4116         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4117
4118 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4119
4120         webkitpy: Expose device_type from host-like objects
4121         https://bugs.webkit.org/show_bug.cgi?id=193406
4122         <rdar://problem/47262305>
4123
4124         Reviewed by Lucas Forschler.
4125
4126         Devices should expose device_type. As a result, all host objects should
4127         provide a device_type property, even if they do not yet define a device_type.
4128
4129         * Scripts/webkitpy/common/system/systemhost.py:
4130         (SystemHost):
4131         (SystemHost.device_type):
4132         * Scripts/webkitpy/common/system/systemhost_mock.py:
4133         (MockSystemHost):
4134         (MockSystemHost.device_type):
4135         * Scripts/webkitpy/port/device.py:
4136         (Device):
4137         (Device.device_type):
4138         * Scripts/webkitpy/xcode/simulated_device.py:
4139         (SimulatedDeviceManager._find_exisiting_device_for_request):
4140         (SimulatedDeviceManager._disambiguate_device_type):
4141         (SimulatedDeviceManager._does_fulfill_request):
4142         (SimulatedDeviceManager.device_count_for_type):
4143         (SimulatedDeviceManager.initialize_devices):
4144         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
4145         (test_available_devices):
4146         (test_swapping_devices):
4147
4148 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4149
4150         webkitpy: Support alternate simctl device list output (Follow-up fix)
4151         https://bugs.webkit.org/show_bug.cgi?id=193362
4152         <rdar://problem/47122965>
4153
4154         Rubber-stamped by Lucas Forschler.
4155
4156         * Scripts/webkitpy/xcode/simulated_device.py:
4157         (SimulatedDeviceManager.populate_available_devices):
4158
4159 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
4160
4161         [iOS] Expose SPI to access the current sentence boundary and selection state
4162         https://bugs.webkit.org/show_bug.cgi?id=193398
4163         <rdar://problem/45893108>
4164
4165         Reviewed by Dean Jackson.
4166
4167         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
4168         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
4169         expected.
4170
4171         * TestWebKitAPI/EditingTestHarness.h:
4172         * TestWebKitAPI/EditingTestHarness.mm:
4173         (-[EditingTestHarness moveBackward]):
4174         (-[EditingTestHarness moveForward]):
4175         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
4176
4177         Add a couple of new helper methods on EditingTestHarness.
4178
4179         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
4180         (-[SelectionChangeObserver initWithWebView:]):
4181         (-[SelectionChangeObserver webView]):
4182         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
4183         (-[SelectionChangeObserver currentSelectionAttributes]):
4184
4185 2019-01-14  Zalan Bujtas  <zalan@apple.com>
4186
4187         [LFC][BFC] Add basic box-sizing support.
4188         https://bugs.webkit.org/show_bug.cgi?id=193392
4189
4190         Reviewed by Antti Koivisto.
4191
4192         * LayoutReloaded/misc/LFC-passing-tests.txt:
4193
4194 2019-01-14  Charlie Turner  <cturner@igalia.com>
4195
4196         [WPE] API test gardening
4197         https://bugs.webkit.org/show_bug.cgi?id=193319
4198
4199         Reviewed by Michael Catanzaro.
4200
4201         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
4202         passing tests.
4203
4204 2019-01-14  Charlie Turner  <cturner@igalia.com>
4205
4206         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
4207         https://bugs.webkit.org/show_bug.cgi?id=192977
4208
4209         Reviewed by Carlos Garcia Campos.
4210
4211         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
4212         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
4213         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
4214         (TestWebKitAPI::GStreamerTest::SetUp):
4215         (TestWebKitAPI::GStreamerTest::TearDown):
4216         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
4217         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
4218         (TestWebKitAPI::TEST_F):
4219
4220 2019-01-14  Charlie Turner  <cturner@igalia.com>
4221
4222         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
4223         https://bugs.webkit.org/show_bug.cgi?id=193332
4224
4225         Reviewed by Michael Catanzaro.
4226
4227         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
4228         defined as a char16_t, which changed in ICU 59, the
4229         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
4230         unsigned short. This test is relying on the behaviour that
4231         UChar=unsigned short, which doesn't hold across platforms and ICU
4232         library versions. The full fix would be a special syntax for
4233         literal characters so that these ambiguities do not arise. That
4234         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
4235         (TestWebKitAPI::TEST):
4236
4237 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4238
4239         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
4240
4241         * Scripts/make-dist:
4242         (Distcheck.configure):
4243
4244 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
4245
4246         [ews-build] Update macOS queue configurations
4247         https://bugs.webkit.org/show_bug.cgi?id=193365
4248         <rdar://problem/47221073>
4249
4250         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
4251
4252         * BuildSlaveSupport/ews-build/config.json:
4253
4254 2019-01-13  Zalan Bujtas  <zalan@apple.com>
4255
4256         [LFC] Adjust assert for statically positioned fixed elements
4257         https://bugs.webkit.org/show_bug.cgi?id=193385
4258
4259         Reviewed by Antti Koivisto.
4260
4261         * LayoutReloaded/misc/LFC-passing-tests.txt:
4262
4263 2019-01-13  Philippe Normand  <pnormand@igalia.com>
4264
4265         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
4266         https://bugs.webkit.org/show_bug.cgi?id=193387
4267
4268         Reviewed by Carlos Garcia Campos.
4269
4270         * MiniBrowser/wpe/main.cpp:
4271         (main):
4272
4273 2019-01-12  Timothy Hatcher  <timothy@apple.com>
4274
4275         Have prefers-color-scheme: light always match on macOS versions before Mojave.
4276         https://bugs.webkit.org/show_bug.cgi?id=191655
4277         rdar://problem/46074680
4278
4279         Reviewed by Megan Gardner.
4280
4281         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
4282         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
4283
4284 2019-01-12  Dan Bernstein  <mitz@apple.com>
4285
4286         [Cocoa] Avoid importing directly from subumbrella frameworks
4287         https://bugs.webkit.org/show_bug.cgi?id=186016
4288         <rdar://problem/40591038>
4289
4290         Reviewed by Sam Weinig.
4291
4292         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4293           LaunchServices header.
4294         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4295           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4296         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4297           when using SDKs earlier than 10.13.
4298         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4299           and OTHER_CPLUSPLUSFLAGS.
4300         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4301           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4302         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4303           LaunchServices header.
4304
4305 2019-01-11  John Wilander  <wilander@apple.com>
4306
4307         Compile out Web API Statistics Collection
4308         https://bugs.webkit.org/show_bug.cgi?id=193370
4309         <rdar://problem/45388584>
4310
4311         Reviewed by Brent Fulgham.
4312
4313         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4314             Defined ENABLE_WEB_API_STATISTICS, off by default.
4315
4316 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4317
4318         [WPE] Add gtk-doc
4319         https://bugs.webkit.org/show_bug.cgi?id=178900
4320
4321         Reviewed by Michael Catanzaro.
4322
4323         Add Tools/gtkdoc to manifest.txt.in files.
4324         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
4325
4326         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
4327         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
4328
4329 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4330
4331         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element