Implement async paste method on UIWKInteractionViewProtocol
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Implement async paste method on UIWKInteractionViewProtocol
4         https://bugs.webkit.org/show_bug.cgi?id=196267
5         <rdar://problem/49236346>
6
7         Reviewed by Tim Horton.
8
9         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
10         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
11         are now a part of all iOS 12 internal SDKs.
12
13         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
14
15         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
16         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
17
18         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
19         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
20         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
21         * TestWebKitAPI/ios/UIKitSPI.h:
22
23 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
24
25         [ews-build] Use PostgreSQL for ews.webkit.org database
26         https://bugs.webkit.org/show_bug.cgi?id=196270
27
28         Reviewed by Lucas Forschler.
29
30         * BuildSlaveSupport/ews-app/ews-app/settings.py:
31
32 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
33
34         [ews] Reset simctl states on reboot
35         https://bugs.webkit.org/show_bug.cgi?id=196260
36
37         Rubber-stamped by Aakash Jain.
38
39         * EWSTools/start-queue-mac.sh:
40
41 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
42
43         [ews-build] Use PostgreSQL for ews-build database
44         https://bugs.webkit.org/show_bug.cgi?id=196229
45
46         Reviewed by Lucas Forschler.
47
48         * BuildSlaveSupport/ews-build/master.cfg:
49
50 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
51
52         [ews-build] Get master_hostname dynamically in master.cfg
53         https://bugs.webkit.org/show_bug.cgi?id=196255
54
55         Reviewed by Lucas Forschler.
56
57         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
58         send events data in test mode.
59
60 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
61
62         [ews-app] Set db_constraint to False for Foreign Keys
63         https://bugs.webkit.org/show_bug.cgi?id=196252
64
65         Reviewed by Lucas Forschler.
66
67         * BuildSlaveSupport/ews-app/ews/models/build.py:
68         * BuildSlaveSupport/ews-app/ews/models/step.py:
69
70 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
71
72         [ews-build] is_test_mode_enabled should default to True
73         https://bugs.webkit.org/show_bug.cgi?id=196248
74
75         Reviewed by Lucas Forschler.
76
77         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
78
79 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
80
81         [ews-app] Add webkitperl to ENABLED_QUEUES
82         https://bugs.webkit.org/show_bug.cgi?id=196253
83
84         Reviewed by Lucas Forschler.
85
86         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
87
88 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
89
90         Address NSWindow sometimes using WebKitTestRunnerEvent too early
91         https://bugs.webkit.org/show_bug.cgi?id=196211
92         rdar://problem/49110552
93
94         Reviewed by Tim Horton.
95
96         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
97         Make sure that EventSenderProxy always exists when running tests. We used to create
98         it when resetting before the first test, which is a bit too late.
99
100         * WebKitTestRunner/TestController.h:
101         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
102         (WTR::TestController::platformCreateWebView):
103         (WTR::TestController::platformCreateOtherPage):
104         (WTR::TestController::finishCreatingPlatformWebView):
105         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
106         (WTR::PlatformWebView::PlatformWebView):
107         Moved some code that made NSWindow use NSEvent during web view creation. We may
108         need to move more if some other case us found, but this is enough for now.
109
110 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
111
112         Unreviewed. Fix typo in GLib geolocation API after r243285.
113
114         gelocation -> geolocation.
115
116         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
117         (testGeolocationManagerWatchPosition):
118
119 2019-03-25  Alex Christensen  <achristensen@webkit.org>
120
121         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
122         https://bugs.webkit.org/show_bug.cgi?id=196213
123
124         Reviewed by Geoff Garen.
125
126         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
127         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
128         (credentialWithIdentityAndKeychainPath):
129         (-[ChallengeDelegate webView:didFinishNavigation:]):
130         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
131         (TestWebKitAPI::TEST):
132
133 2019-03-25  Alex Christensen  <achristensen@webkit.org>
134
135         Expected shouldn't assume its contained types are copyable
136         https://bugs.webkit.org/show_bug.cgi?id=195986
137
138         Reviewed by JF Bastien.
139
140         * TestWebKitAPI/Tests/WTF/Expected.cpp:
141         (TestWebKitAPI::NonCopyable::operator== const):
142         (TestWebKitAPI::NonCopyable::operator!= const):
143         (TestWebKitAPI::TEST):
144
145 2019-03-25  Tim Horton  <timothy_horton@apple.com>
146
147         Remove some now-unnecessary dynamic class lookup
148         https://bugs.webkit.org/show_bug.cgi?id=196237
149
150         Reviewed by Simon Fraser.
151
152         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
153         (makeRequest):
154         (TEST):
155
156 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
157
158         Unreviewed, rolling out r243450.
159
160         AppleWin and WinCairo port builds get broken.
161
162         Reverted changeset:
163
164         "Add test for fix of #196095"
165         https://bugs.webkit.org/show_bug.cgi?id=196097
166         https://trac.webkit.org/changeset/243450
167
168 2019-03-25  Commit Queue  <commit-queue@webkit.org>
169
170         Unreviewed, rolling out r243465.
171         https://bugs.webkit.org/show_bug.cgi?id=196226
172
173         the test doesn't build (Requested by thorton on #webkit).
174
175         Reverted changeset:
176
177         "Do not terminate the NetworkProcess if a third party
178         application sends a NSCredential with a SecIdentityRef"
179         https://bugs.webkit.org/show_bug.cgi?id=196213
180         https://trac.webkit.org/changeset/243465
181
182 2019-03-25  Alex Christensen  <achristensen@webkit.org>
183
184         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
185         https://bugs.webkit.org/show_bug.cgi?id=196213
186
187         Reviewed by Geoff Garen.
188
189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
190         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
191         (credentialWithIdentityAndKeychainPath):
192         (-[ChallengeDelegate webView:didFinishNavigation:]):
193         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
194         (TestWebKitAPI::TEST):
195
196 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
197
198         [ews-build] Gracefully handle missing patch_id in events
199         https://bugs.webkit.org/show_bug.cgi?id=196216
200
201         Reviewed by Lucas Forschler.
202
203         * BuildSlaveSupport/ews-build/events.py:
204
205 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
206
207         [ews-build] use lz4 compression for improving buildbot performance
208         https://bugs.webkit.org/show_bug.cgi?id=196155
209
210         Reviewed by Lucas Forschler.
211
212         * BuildSlaveSupport/ews-build/master.cfg:
213
214 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
215
216         Pull some API testing helper methods out of TestWKWebView
217         https://bugs.webkit.org/show_bug.cgi?id=196212
218
219         Reviewed by Tim Horton.
220
221         Refactor some more API testing utility methods, so that they can be used in
222         tests that do not use TestWKWebView.
223
224         * TestWebKitAPI/cocoa/TestWKWebView.h:
225         * TestWebKitAPI/cocoa/TestWKWebView.mm:
226         (-[WKWebView loadTestPageNamed:]):
227         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
228         (-[WKWebView synchronouslyLoadHTMLString:]):
229         (-[WKWebView synchronouslyLoadTestPageNamed:]):
230         (-[TestWKWebView loadTestPageNamed:]): Deleted.
231         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
232         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
233         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
234
235 2019-03-25  Jer Noble  <jer.noble@apple.com>
236
237         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
238         https://bugs.webkit.org/show_bug.cgi?id=196097
239
240         Reviewed by Eric Carlson.
241
242         Drive-by bug fix: allow tests to play audio without a user gesture by default.
243
244         * DumpRenderTree/mac/DumpRenderTree.mm:
245         (resetWebPreferencesToConsistentValues):
246         * WebKitTestRunner/TestController.cpp:
247         (WTR::TestController::resetPreferencesToConsistentValues):
248
249 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
250
251         Pull IPadUserInterfaceSwizzler out into a separate header file
252         https://bugs.webkit.org/show_bug.cgi?id=196193
253
254         Reviewed by Anders Carlsson.
255
256         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
257         be used in other API tests.
258
259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
260         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
261         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
262         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
263         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
264         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
265         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
266
267 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
268
269         Remove NavigatorContentUtils in WebCore/Modules
270         https://bugs.webkit.org/show_bug.cgi?id=196070
271
272         Reviewed by Alex Christensen.
273
274         NavigatorContentUtils was to support the custom scheme spec [1].
275         However, in WebKit side, no port has supported the feature in
276         WebKit layer after EFL port was removed. So there has been the
277         only IDL implementation of the NavigatorContentUtils in WebCore.
278         So we don't need to keep the implementation in WebCore anymore.
279
280         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
281
282         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
283
284 2019-03-24  Andy Estes  <aestes@apple.com>
285
286         [watchOS] Remove unused Proximity Networking code
287         https://bugs.webkit.org/show_bug.cgi?id=196188
288
289         Reviewed by Tim Horton.
290
291         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
292         (TEST):
293
294 2019-03-23  Keith Miller  <keith_miller@apple.com>
295
296         Refactor clz/ctz and fix getLSBSet.
297         https://bugs.webkit.org/show_bug.cgi?id=196162
298
299         Reviewed by Saam Barati.
300
301         Add tests for clz, ctz, getLSBSet, and getMSBSet.
302
303         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
304         (TestWebKitAPI::TEST):
305
306 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
307
308         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
309         https://bugs.webkit.org/show_bug.cgi?id=196143
310
311         Reviewed by Michael Catanzaro.
312
313         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
314         directories.
315
316         * Scripts/webkitpy/style/checkers/cpp.py:
317         (check_identifier_name_in_declaration):
318         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
319         (WebKitStyleTest.test_names):
320
321 2019-03-22  Philippe Normand  <pnormand@igalia.com>
322
323         [Flatpak] Manifest expanding fails for qt WPE extension
324         https://bugs.webkit.org/show_bug.cgi?id=196148
325
326         Reviewed by Alex Christensen.
327
328         * flatpak/flatpakutils.py:
329         (expand_submodules_recurse): The last recurse manifest expand
330         iteration might lead to a single module so take it into account
331         and don't try to recurse further.
332
333 2019-03-22  Chris Dumez  <cdumez@apple.com>
334
335         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
336         https://bugs.webkit.org/show_bug.cgi?id=195348
337         <rdar://problem/48622090>
338
339         Reviewed by Alex Christensen.
340
341         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
342         to NO when test.options().shouldIgnoreMetaViewport is false.
343
344         * WebKitTestRunner/ios/TestControllerIOS.mm:
345         (WTR::TestController::platformConfigureViewForTest):
346
347 2019-03-22  Chris Dumez  <cdumez@apple.com>
348
349         Prewarmed processes should be usable with any website data store
350         https://bugs.webkit.org/show_bug.cgi?id=196104
351
352         Reviewed by Alex Christensen.
353
354         Add API test coverage.
355
356         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
357         (runInitialWarmedProcessUsedTest):
358         (TEST):
359
360 2019-03-22  David Kilzer  <ddkilzer@apple.com>
361
362         Back out local changes to Alex's Subversion working directory
363
364         They were accidentally committed.
365
366         * Scripts/webkitpy/common/system/abstractexecutive.py:
367         (AbstractExecutive.wait_newest):
368         * Scripts/webkitpy/common/system/executive.py:
369         (Executive.running_pids):
370         * Scripts/webkitpy/common/system/executive_mock.py:
371         (MockExecutive.running_pids):
372         * Scripts/webkitpy/common/system/executive_unittest.py:
373         (ExecutiveTest.serial_test_running_pids):
374         * Scripts/webkitpy/port/darwin.py:
375         (DarwinPort.check_for_leaks):
376         * Scripts/webkitpy/port/leakdetector.py:
377         (LeakDetector.check_for_leaks):
378         - This was the hack attached to Bug 193772.
379
380         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
381         (+[WebKitTestRunnerEvent mouseLocation]):
382         - This works around a crash on an internal build.
383
384 2019-03-22  Tim Horton  <timothy_horton@apple.com>
385
386         Fix the build after r243354
387         https://bugs.webkit.org/show_bug.cgi?id=196138
388         <rdar://problem/49145951>
389
390         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
391         (TEST):
392         * TestWebKitAPI/ios/UIKitSPI.h:
393
394 2019-03-21  Tim Horton  <timothy_horton@apple.com>
395
396         Adopt UIWKDocumentContext
397         https://bugs.webkit.org/show_bug.cgi?id=196040
398         <rdar://problem/48642440>
399
400         Reviewed by Ryosuke Niwa.
401
402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
403         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
404         (makeRequest):
405         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
406         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
407         (applyStyle):
408         (TEST):
409         Add tests for UIWKDocumentContext.
410
411         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
412         (TEST):
413         (recursiveFindWKContentView): Deleted.
414         * TestWebKitAPI/cocoa/TestWKWebView.h:
415         * TestWebKitAPI/cocoa/TestWKWebView.mm:
416         (recursiveFindWKContentView):
417         (-[TestWKWebView wkContentView]):
418         * TestWebKitAPI/ios/UIKitSPI.h:
419         Share the WKContentView finding code between tests.
420
421 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
422
423         [iOS WK2] Turn on async overflow scrolling by default
424         https://bugs.webkit.org/show_bug.cgi?id=196011
425         rdar://problem/48453859
426
427         Reviewed by Antti Koivisto.
428         
429         Explicitly turn off the async overflow scrolling internal feature for tests by default,
430         since so many basic layout tests have different results when compositing is triggered for
431         overflow.
432         
433         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
434
435         * WebKitTestRunner/TestController.cpp:
436         (WTR::TestController::resetPreferencesToConsistentValues):
437
438 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
439
440         [ews-build] Retry API test in case of failures
441         https://bugs.webkit.org/show_bug.cgi?id=196004
442
443         Reviewed by Lucas Forschler.
444
445         * BuildSlaveSupport/ews-build/steps.py:
446         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
447         (CompileWebKitToT.doStepIf): Ditto.
448         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
449         (ReRunAPITests): Re-run API tests.
450         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
451         (RunAPITestsWithoutPatch): Run API tests without patch.
452         (RunAPITestsWithoutPatch.doStepIf):
453         (RunAPITestsWithoutPatch.hideStepIf):
454         (RunAPITestsWithoutPatch.evaluateCommand):
455         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
456         (AnalyzeAPITestsResults.start):
457         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
458         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
459         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
460         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
461
462 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
463
464         [ews-build] Update queues configurations
465         https://bugs.webkit.org/show_bug.cgi?id=196074
466
467         Reviewed by Dewei Zhu.
468
469         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
470         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
471
472 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
473
474         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
475         https://bugs.webkit.org/show_bug.cgi?id=195680
476         <rdar://problem/48903534>
477
478         Unreviewed infrastructure fix.
479
480         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
481         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
482
483 2019-03-21  Andy Estes  <aestes@apple.com>
484
485         [iOS] Apple Pay should be available in documents with no user agent scripts
486         https://bugs.webkit.org/show_bug.cgi?id=196061
487         <rdar://problem/48649391>
488
489         Reviewed by Brady Eidson.
490
491         Added API tests and related infrastructure.
492
493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
494         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
495         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
496         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
497         (TestWebKitAPI::TEST):
498         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
499         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
500         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
501         * TestWebKitAPI/cocoa/TestProtocol.mm:
502         (-[TestProtocol startLoading]):
503         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
504         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
505         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
506         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
507
508 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
509
510         REGRESSSION (r243297): webkitpy tests broken
511         https://bugs.webkit.org/show_bug.cgi?id=196108
512
513         Reviewed by Aakash Jain.
514
515         r243297 updated contributors.json, which broke a few unit tests.
516
517         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
518         (IRCCommandTest.test_whois):
519         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
520
521 2019-03-21  Chris Dumez  <cdumez@apple.com>
522
523         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
524         https://bugs.webkit.org/show_bug.cgi?id=196041
525         <rdar://problem/49083230>
526
527         Reviewed by Alex Christensen.
528
529         Add API test coverage.
530
531         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
532         (TEST):
533
534 2019-03-21  Alex Christensen  <achristensen@webkit.org>
535
536         Add SPI to inform applications of WKContentRuleList actions
537         https://bugs.webkit.org/show_bug.cgi?id=195965
538         <rdar://problem/42664365>
539
540         Reviewed by Geoff Garen.
541
542         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
543         (TestWebKitAPI::allActionsForResourceLoad):
544         (TestWebKitAPI::testRequest):
545         (TestWebKitAPI::TEST_F):
546         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
547         (Notification::description):
548         (Notification::operator== const):
549         (toVector):
550         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
551         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
552         (makeContentRuleList):
553         (TEST):
554         (makeWarnContentRuleList): Deleted.
555
556 2019-03-21  Timothy Hatcher  <timothy@apple.com>
557
558         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
559         https://bugs.webkit.org/show_bug.cgi?id=196088
560
561         Reviewed by Brian Burg.
562
563         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
564         Support checks when only one platform is specified. Also deprecate macosx() and
565         force the use of macos() instead.
566
567         * Scripts/webkitpy/style/checkers/cpp.py:
568         (check_min_versions_of_wk_api_available):
569         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
570         (WebKitStyleTest.test_min_versions_of_wk_api_available):
571
572 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
573
574         Update status inactive committers' status to 'contributor'.
575
576         * Scripts/webkitpy/common/config/contributors.json:
577
578 2019-03-21  Xan Lopez  <xan@igalia.com>
579
580         [JSC][x86] Drop support for x87 floating point
581         https://bugs.webkit.org/show_bug.cgi?id=194853
582
583         Reviewed by Don Olmstead.
584
585         Force SSE2 on x86/32bit builds.
586
587         * Scripts/webkitdirs.pm:
588         (generateBuildSystemFromCMakeProject):
589
590 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
591
592         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
593         https://bugs.webkit.org/show_bug.cgi?id=196073
594
595         Reviewed by Michael Catanzaro.
596
597         Add test cases to check functions and constructors with no arguments but receiving user data.
598
599         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
600         (checkUserData):
601         (testJSCFunction):
602         (fooCreateWithUserData):
603         (testJSCClass):
604
605 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
606
607         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
608
609         Add g_assert_cmpfloat_with_epsilon macro if not defined.
610
611         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
612
613 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
614
615         [GTK][WPE] Add API to provide geolocation information
616         https://bugs.webkit.org/show_bug.cgi?id=195940
617
618         Reviewed by Michael Catanzaro.
619
620         Add a new test to check the new API.
621
622         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
623         (testGeolocationManagerCurrentPosition):
624         (testGeolocationManagerWatchPosition):
625         (beforeAll):
626         (afterAll):
627         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
628         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
629         (beforeAll): Ditto.
630         * TestWebKitAPI/glib/CMakeLists.txt:
631
632 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
633
634         [GLib] Returning G_TYPE_OBJECT from a method does not work
635         https://bugs.webkit.org/show_bug.cgi?id=195574
636
637         Reviewed by Michael Catanzaro.
638
639         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
640
641         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
642         (getGFile):
643         (getParent):
644         (createGString):
645         (getGString):
646         (getGStringCopyWillRaise):
647         (getGStringCopy):
648         (getGStringStr):
649         (getGStringLen):
650         (freeGString):
651         (testJSCClass):
652
653 2019-03-20  Saam Barati  <sbarati@apple.com>
654
655         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
656         https://bugs.webkit.org/show_bug.cgi?id=195721
657
658         Reviewed by Filip Pizlo.
659
660         * Scripts/run-javascriptcore-tests:
661
662 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
663
664         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
665         https://bugs.webkit.org/show_bug.cgi?id=196049
666
667         Reviewed by Tim Horton.
668
669         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
670         overflow scrolling in general, so rename it.
671
672         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
673
674 2019-03-20  Daniel Bates  <dabates@apple.com>
675
676         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
677         https://bugs.webkit.org/show_bug.cgi?id=196031
678         <rdar://problem/49078172>
679
680         Reviewed by Tim Horton.
681
682         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
683         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
684         same code path used when the Done button is pressed to dismiss the <select> picker.
685
686         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
687         (TestWebKitAPI::TEST):
688
689 2019-03-20  Chris Dumez  <cdumez@apple.com>
690
691         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
692         https://bugs.webkit.org/show_bug.cgi?id=196029
693         <rdar://problem/48954651>
694
695         Reviewed by Tim Horton.
696
697         Add API test coverage.
698
699         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
700
701 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
702
703         [ews-build] Improve failure summary string for ApplyPatch step
704         https://bugs.webkit.org/show_bug.cgi?id=195995
705
706         Reviewed by Alexey Proskuryakov.
707
708         * BuildSlaveSupport/ews-build/steps.py:
709         (ApplyPatch.getResultSummary): Override getResultSummary.
710
711 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
712
713         AX: Implement support for new meter ARIA role
714         https://bugs.webkit.org/show_bug.cgi?id=195966
715
716         Reviewed by Chris Fleizach.
717
718         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
719         to AXLevelIndicator.
720
721         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
722
723 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
724
725         [WebAuthN] Implement FIDO AppID extension
726         https://bugs.webkit.org/show_bug.cgi?id=143491
727         <rdar://problem/48298273>
728
729         Reviewed by Brent Fulgham.
730
731         Add a test that covers the new flag of convertToU2fSignCommand.
732
733         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
734         (TestWebKitAPI::TEST):
735         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
736         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
737         (TestWebKitAPI::TEST):
738
739 2019-03-19  Keith Rollin  <krollin@apple.com>
740
741         Add support for more platforms to generate-xcfilelists
742         https://bugs.webkit.org/show_bug.cgi?id=195977
743
744         Reviewed by Alexey Proskuryakov.
745
746         generate-xcfilelists incorrectly complains when involved with building
747         WebKit for iphonesimulator:
748
749             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
750             …
751             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
752
753         Address this by teaching generate-xcfilelists about more platforms.
754
755         * Scripts/generate-xcfilelists:
756
757 2019-03-19  John Wilander  <wilander@apple.com>
758
759         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
760         https://bugs.webkit.org/show_bug.cgi?id=195923
761         <rdar://problem/49001272>
762
763         Reviewed by Alex Christensen.
764
765         This patch does the following to the TestRunner:
766         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
767         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
768         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
769
770         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
771         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
772         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
773         * WebKitTestRunner/InjectedBundle/TestRunner.h:
774         * WebKitTestRunner/TestController.cpp:
775         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
776         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
777         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
778         * WebKitTestRunner/TestController.h:
779         * WebKitTestRunner/TestInvocation.cpp:
780         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
781
782 2019-03-19  Christopher Reid  <chris.reid@sony.com>
783
784         [CMake] Support more clang and gcc sanitizers
785         https://bugs.webkit.org/show_bug.cgi?id=195956
786
787         Reviewed by Michael Catanzaro.
788
789         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
790
791 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
792
793         [ews-build] Improve summary for PrintConfiguration step
794         https://bugs.webkit.org/show_bug.cgi?id=195945
795
796         Reviewed by Lucas Forschler.
797
798         * BuildSlaveSupport/ews-build/steps.py:
799         (PrintConfiguration.getResultSummary): Override getResultSummary.
800
801 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
802
803         [ews-build] Improve summary for CheckOutSource step
804         https://bugs.webkit.org/show_bug.cgi?id=195963
805
806         Reviewed by Lucas Forschler.
807
808         * BuildSlaveSupport/ews-build/steps.py:
809         (CheckOutSource.getResultSummary):
810
811 2019-03-19  Daniel Bates  <dabates@apple.com>
812
813         [iOS] Focus not preserved when switching between tabs
814         https://bugs.webkit.org/show_bug.cgi?id=195820
815         <rdar://problem/43614450>
816
817         Reviewed by Brent Fulgham.
818
819         Add tests to ensure that we restore focus when resigning and becoming first responder.
820
821         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
822         (TestWebKitAPI::TEST):
823
824 2019-03-19  Alex Christensen  <achristensen@webkit.org>
825
826         Make WTFLogChannelState and WTFLogLevel enum classes
827         https://bugs.webkit.org/show_bug.cgi?id=195904
828
829         Reviewed by Eric Carlson.
830
831         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
832         (TestWebKitAPI::TEST_F):
833
834 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
835
836         [GStreamer][EME] Backported mssdemux protection data crash fix
837         https://bugs.webkit.org/show_bug.cgi?id=195918
838
839         Reviewed by Philippe Normand.
840
841         * gstreamer/jhbuild.modules:
842         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
843
844 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
845
846         Unreviewed, rolling out r243132.
847
848         Broke GTK build
849
850         Reverted changeset:
851
852         "Make WTFLogChannelState and WTFLogLevel enum classes"
853         https://bugs.webkit.org/show_bug.cgi?id=195904
854         https://trac.webkit.org/changeset/243132
855
856 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
857
858         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
859
860         * Scripts/webkitdirs.pm:
861         (builtDylibPathForName): Adjust the shared library name that's changed
862         with the API version bump in r243073.
863
864 2019-03-18  Alex Christensen  <achristensen@webkit.org>
865
866         Make WTFLogChannelState and WTFLogLevel enum classes
867         https://bugs.webkit.org/show_bug.cgi?id=195904
868
869         Reviewed by Eric Carlson.
870
871         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
872         (TestWebKitAPI::TEST_F):
873
874 2019-03-18  Alex Christensen  <achristensen@webkit.org>
875
876         Disable flaky test added in r2431100
877         https://webkit.org/b/195785
878
879         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
880         (TestWebKitAPI::TEST):
881         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
882
883 2019-03-18  Timothy Hatcher  <timothy@apple.com>
884
885         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
886         https://bugs.webkit.org/show_bug.cgi?id=195916
887
888         Reviewed by Tim Horton.
889
890         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
891         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
892
893 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
894
895         Add a secondary e-mail address for Fujii Hironori to make tools happier.
896
897         * Scripts/webkitpy/common/config/contributors.json:
898
899 2019-03-18  Alex Christensen  <achristensen@webkit.org>
900
901         Implement DownloadMonitor to prevent long-running slow downloads from background apps
902         https://bugs.webkit.org/show_bug.cgi?id=195785
903
904         Reviewed by Geoffrey Garen.
905
906         * TestWebKitAPI/TCPServer.cpp: Added.
907         (TestWebKitAPI::TCPServer::TCPServer):
908         (TestWebKitAPI::TCPServer::~TCPServer):
909         (TestWebKitAPI::TCPServer::socketBindListen):
910         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
911         * TestWebKitAPI/TCPServer.h: Added.
912         (TestWebKitAPI::TCPServer::port const):
913         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
914         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
915         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
916         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
917         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
918         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
919         (TestWebKitAPI::respondSlowly):
920         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
921         (TestWebKitAPI::downloadAtRate):
922         (TestWebKitAPI::TEST):
923
924 2019-03-18  Saam Barati  <sbarati@apple.com>
925
926         Add a plan file for JetStream 2
927         https://bugs.webkit.org/show_bug.cgi?id=190734
928
929         Reviewed by Mark Lam.
930
931         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
932
933 2019-03-18  Chris Dumez  <cdumez@apple.com>
934
935         Delay WebProcess launch until a load is triggered in a Web view
936         https://bugs.webkit.org/show_bug.cgi?id=195758
937         <rdar://problem/48126013>
938
939         Reviewed by Geoff Garen.
940
941         Add API test coverage. Also update some existing API tests to not expect
942         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
943
944         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
945         (TestWebKitAPI::TEST):
946         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
947         (TestWebKitAPI::TEST):
948         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
949         (TEST):
950         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
951         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
952         (TEST):
953         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
954         (TEST):
955         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
956
957 2019-03-18  Xan Lopez  <xan@igalia.com>
958
959         [CMake] Prevent potential warning when determining $architecture
960         https://bugs.webkit.org/show_bug.cgi?id=195891
961
962         Reviewed by Michael Catanzaro.
963
964         It's possible for generateBuildSystemForCMakeProject to be called
965         before determineArchitecture() is ever called. This will make the
966         first eq check with $architecture to be bogus (and print a
967         warning). Change that to an eq check with architecture(), which
968         implicitly calls determineArchitecture() if needed, and change all
969         the other similar cases in the method in the same way to prevent
970         future bugs like this one.
971
972         * Scripts/webkitdirs.pm:
973         (generateBuildSystemFromCMakeProject):
974
975 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
976
977         [WPE] Tarballs generated with “make dist” cannot build documentation
978         https://bugs.webkit.org/show_bug.cgi?id=195885
979
980         Reviewed by Carlos Garcia Campos.
981
982         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
983
984 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
985
986         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
987         https://bugs.webkit.org/show_bug.cgi?id=195883
988
989         Reviewed by Carlos Garcia Campos.
990
991         * gtkdoc/gtkdoc.py:
992         (GTKDoc._run_command): When commands fail to run, include the full command line for
993         the program invocation and the output it has generated on the standard error stream.
994
995 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
996
997         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
998         https://bugs.webkit.org/show_bug.cgi?id=195786
999
1000         Reviewed by Philippe Normand.
1001
1002         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1003         * wpe/jhbuild.modules: Ditto.
1004
1005 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1006
1007         [ews-build] Don't run clean builds on EWS builders
1008         https://bugs.webkit.org/show_bug.cgi?id=195851
1009
1010         Reviewed by Geoffrey Garen.
1011
1012         * BuildSlaveSupport/ews-build/factories.py:
1013
1014 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1015
1016         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1017         https://bugs.webkit.org/show_bug.cgi?id=195849
1018
1019         Reviewed by Chris Dumez.
1020
1021         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1022
1023         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1024         (runWebsiteDataStoreCustomPaths):
1025
1026 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1027
1028         webkitpy: Upload test results
1029         https://bugs.webkit.org/show_bug.cgi?id=195755
1030         <rdar://problem/48896182>
1031
1032         Reviewed by Aakash Jain.
1033
1034         Establish a new format for uploading results that is not tied to layout tests, apply
1035         that format to webkitpy tests.
1036
1037         * Scripts/webkitpy/common/checkout/scm/git.py:
1038         (Git.native_branch): Return what branch the current checkout is on.
1039         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1040         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1041         * Scripts/webkitpy/common/checkout/scm/svn.py:
1042         (SVN.native_branch): Ditto.
1043         * Scripts/webkitpy/common/system/platforminfo.py:
1044         (PlatformInfo.build_version): Return a build version for Mac.
1045         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1046         (MockPlatformInfo.__init__):
1047         (MockPlatformInfo.build_version):
1048         * Scripts/webkitpy/results: Added.
1049         * Scripts/webkitpy/results/__init__.py: Added.
1050         * Scripts/webkitpy/results/options.py: Added.
1051         (upload_options): OptParse list for upload options.
1052         * Scripts/webkitpy/results/upload.py: Added.
1053         (Upload): Class which enforces the upload format expected by the results server.
1054         (Upload.Expectations):
1055         (Upload.create_configuration):
1056         (Upload.create_commit):
1057         (Upload.create_details):
1058         (Upload.create_run_stats):
1059         (Upload.create_test_result):
1060         (Upload.__init__):
1061         (Upload.Encoder): Encode Upload object as json.
1062         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1063         * Scripts/webkitpy/results/upload_unittest.py: Added.
1064         * Scripts/webkitpy/test/main.py:
1065         (Tester._parse_args): Add upload arguments.
1066         (Tester._run_tests): Allow results to be uploaded.
1067         * Scripts/webkitpy/test/runner.py:
1068         (Runner.__init__): Record which tests were run, rather than just counting them.
1069         (Runner.handle):
1070         * Scripts/webkitpy/test/runner_unittest.py:
1071         (RunnerTest.test_run):
1072         * Scripts/webkitpy/thirdparty/__init__.py:
1073         (AutoinstallImportHook.find_module): Add requests auto-install.
1074         (AutoinstallImportHook._install_requests):
1075         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1076         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1077
1078 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1079
1080         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1081         https://bugs.webkit.org/show_bug.cgi?id=195810
1082
1083         Reviewed by Tim Horton.
1084
1085         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1086         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1087         ending certain layout tests.
1088
1089         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1090         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1091         (-[TestRunnerWKWebView dealloc]):
1092         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1093
1094         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1095         helper method when destroying the web view, and when resetting state between tests.
1096
1097         * WebKitTestRunner/ios/TestControllerIOS.mm:
1098         (WTR::TestController::platformResetStateToConsistentValues):
1099
1100         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1101
1102 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1103
1104         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1105         https://bugs.webkit.org/show_bug.cgi?id=190350
1106         <rdar://problem/45089503>
1107
1108         Reviewed by Geoffrey Garen.
1109
1110         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1111         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1112         (TEST):
1113         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1114         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1115         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1116         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1117         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1118         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1119         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1120         (runTest):
1121         (createDirectories):
1122         (TEST):
1123         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1124         (TEST):
1125         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1126         (TEST):
1127
1128 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1129
1130         Add support to WebPage for getting the contents as an attributed string.
1131         https://bugs.webkit.org/show_bug.cgi?id=195636
1132         rdar://problem/45055697
1133
1134         Reviewed by Tim Horton.
1135
1136         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1137         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1138
1139 2019-03-15  Chris Dumez  <cdumez@apple.com>
1140
1141         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1142         https://bugs.webkit.org/show_bug.cgi?id=195747
1143
1144         Reviewed by Geoff Garen.
1145
1146         Add API test coverage.
1147
1148         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1149
1150 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1151
1152         Unreviewed, rolling out r242952.
1153
1154         Causing API failures on iOS Simulator
1155
1156         Reverted changeset:
1157
1158         "[PSON] Make sure the WebProcessCache is leverage when
1159         relaunching a process after termination"
1160         https://bugs.webkit.org/show_bug.cgi?id=195747
1161         https://trac.webkit.org/changeset/242952
1162
1163 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1164
1165         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1166         https://bugs.webkit.org/show_bug.cgi?id=195740
1167
1168         Reviewed by Ross Kirsling.
1169
1170         window.open doesn't work for WebKitBrowserWindow because it is not
1171         implemented yet.
1172
1173         1. Implemented createNewPage callback of WKPageUIClient.
1174         2. Changed MainWindow to take a BrowserWindow factory function
1175           instead of BrowserWindowType to be flexible to create
1176           BrowserWindow with extra settings.
1177         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1178           because it is not relevant with MainWindow anymore.
1179
1180         * MiniBrowser/win/Common.cpp:
1181         (parseCommandLine):
1182         * MiniBrowser/win/Common.h:
1183         (CommandLineOptions::CommandLineOptions):
1184         * MiniBrowser/win/MainWindow.cpp:
1185         (MainWindow::MainWindow):
1186         (MainWindow::create):
1187         (MainWindow::init):
1188         (MainWindow::WndProc):
1189         * MiniBrowser/win/MainWindow.h:
1190         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1191         (PrintWebUIDelegate::createWebViewWithRequest):
1192         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1193         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1194         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1195         (WebKitBrowserWindow::updateProxySettings):
1196         (WebKitBrowserWindow::createNewPage):
1197         * MiniBrowser/win/WebKitBrowserWindow.h:
1198         * MiniBrowser/win/WinMain.cpp:
1199         (wWinMain):
1200
1201 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1202
1203         Make it possible to test scrolling tree layer manipulation more easily
1204         https://bugs.webkit.org/show_bug.cgi?id=195780
1205
1206         Reviewed by Tim Horton.
1207         
1208         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1209         cuts off communication of scrolling tree scrolls back to the web process
1210         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1211         allows tests to trigger scrolls which run the scrolling tree layer positioning
1212         logic, but never get another commit from the web process that might mask
1213         scrolling tree bugs.
1214         
1215         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1216         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1217         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1218
1219         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1220         (WTR::UIScriptController::scrollUpdatesDisabled const):
1221         (WTR::UIScriptController::setScrollUpdatesDisabled):
1222         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1223         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1224         (WTR::UIScriptController::scrollUpdatesDisabled const):
1225         (WTR::UIScriptController::setScrollUpdatesDisabled):
1226         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1227         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1228         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1229         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1230         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1231         * WebKitTestRunner/ios/TestControllerIOS.mm:
1232         (WTR::TestController::platformResetStateToConsistentValues):
1233         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1234         (WTR::UIScriptController::scrollUpdatesDisabled const):
1235         (WTR::UIScriptController::setScrollUpdatesDisabled):
1236
1237 2019-03-14  Youenn Fablet  <youenn@apple.com>
1238
1239         Move IDB storage in private browsing mode to NetworkProcess
1240         https://bugs.webkit.org/show_bug.cgi?id=195602
1241
1242         Reviewed by Brady Eidson.
1243
1244         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1245         (TEST):
1246
1247 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1248
1249         [ews-build] Make descriptionDone messages more readable
1250         https://bugs.webkit.org/show_bug.cgi?id=195760
1251
1252         Reviewed by Lucas Forschler.
1253
1254         * BuildSlaveSupport/ews-build/steps.py:
1255         * BuildSlaveSupport/ews-build/steps_unittest.py:
1256
1257 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1258
1259         [ews-build] Generate status-bubble hover-over messages
1260         https://bugs.webkit.org/show_bug.cgi?id=195680
1261
1262         Reviewed by Lucas Forschler.
1263
1264         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1265         (StatusBubble):
1266         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1267         on hover-over.
1268         (StatusBubble._iso_time):
1269         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1270         hover-over message.
1271         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1272
1273 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1274
1275         [ews-app] Gracefully handle the case when state_string is None
1276         https://bugs.webkit.org/show_bug.cgi?id=195753
1277
1278         Reviewed by Lucas Forschler.
1279
1280         * BuildSlaveSupport/ews-app/ews/models/build.py:
1281         * BuildSlaveSupport/ews-app/ews/models/step.py:
1282
1283 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1284
1285         [ews-app] Status bubble display pending for currently running build step
1286         https://bugs.webkit.org/show_bug.cgi?id=195744
1287
1288         Reviewed by Lucas Forschler.
1289
1290         * BuildSlaveSupport/ews-build/events.py:
1291         (Events.stepStarted): If state_string is pending, replace it with step name.
1292
1293 2019-03-14  Chris Dumez  <cdumez@apple.com>
1294
1295         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1296         https://bugs.webkit.org/show_bug.cgi?id=195750
1297
1298         Reviewed by Geoffrey Garen.
1299
1300         Add API test coverage.
1301
1302         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1303         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1304         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1305         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1306
1307 2019-03-14  Chris Dumez  <cdumez@apple.com>
1308
1309         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1310         https://bugs.webkit.org/show_bug.cgi?id=195747
1311
1312         Reviewed by Geoff Garen.
1313
1314         Add API test coverage.
1315
1316         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1317
1318 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1319
1320         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1321         https://bugs.webkit.org/show_bug.cgi?id=195725
1322         <rdar://problem/48545062>
1323
1324         Reviewed by Tim Horton.
1325
1326         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1327         handler is nil.
1328
1329         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1330         (TestWebKitAPI::TEST):
1331
1332 2019-03-13  Sam Weinig  <sam@webkit.org>
1333
1334         Add utility function to allow easy reverse range-based iteration of a container
1335         https://bugs.webkit.org/show_bug.cgi?id=195542
1336
1337         Reviewed by Antti Koivisto.
1338
1339         * TestWebKitAPI/CMakeLists.txt:
1340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1341         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1342         (TestWebKitAPI::TEST):
1343         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1344
1345 2019-03-13  Chris Dumez  <cdumez@apple.com>
1346
1347         Use a ServiceWorker process per registrable domain
1348         https://bugs.webkit.org/show_bug.cgi?id=195649
1349
1350         Reviewed by Youenn Fablet.
1351
1352         Update API test coverage.
1353
1354         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1355
1356 2019-03-13  Chris Dumez  <cdumez@apple.com>
1357
1358         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1359         https://bugs.webkit.org/show_bug.cgi?id=195684
1360         <rdar://problem/48294714>
1361
1362         Reviewed by Antti Koivisto.
1363
1364         Add API test coverage.
1365
1366         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1367
1368 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1369
1370         [ews-app] Remove unused patch view
1371         https://bugs.webkit.org/show_bug.cgi?id=195669
1372
1373         Reviewed by Lucas Forschler.
1374
1375         * BuildSlaveSupport/ews-app/ews/urls.py:
1376         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1377
1378 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1379
1380         [ews-app] Use Buildbot result code variables
1381         https://bugs.webkit.org/show_bug.cgi?id=195668
1382
1383         Reviewed by Alexey Proskuryakov.
1384
1385         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1386         (Buildbot): Added Buildbot result code variables.
1387         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1388         (StatusBubble._build_bubble): Used Buildbot result code variables.
1389
1390 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
1391
1392         [Flatpak] Expand submodule recursively
1393         https://bugs.webkit.org/show_bug.cgi?id=195672
1394
1395         Building WPE with flatpak was impossible without that as it was raising an exception.
1396         Also update wpebackend-fdo to match what is built in jhbuild
1397
1398         Reviewed by Philippe Normand.
1399
1400         * flatpak/flatpakutils.py:
1401         (expand_submodules_recurse):
1402         (expand_manifest):
1403         * flatpak/org.webkit.WPEModules.yaml:
1404
1405 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1406
1407         [ews-app] status bubble should be hidden for certain builds
1408         https://bugs.webkit.org/show_bug.cgi?id=194597
1409
1410         Reviewed by Dewei Zhu.
1411
1412         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1413         (StatusBubble._build_bubble):
1414         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
1415         because the patch didn't have relevant changes.
1416         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
1417         in production yet.
1418
1419 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
1420
1421         [Win] Fix a slew of simple clang-cl warnings.
1422         https://bugs.webkit.org/show_bug.cgi?id=195652
1423
1424         Reviewed by Don Olmstead.
1425
1426         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1427         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
1428
1429 2019-03-12  Justin Fan  <justin_fan@apple.com>
1430
1431         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
1432         https://bugs.webkit.org/show_bug.cgi?id=195518
1433         <rdar://problem/46322356>
1434
1435         Reviewed by Myles C. Maxfield.
1436
1437         * DumpRenderTree/DerivedSources-input.xcfilelist:
1438         * DumpRenderTree/DerivedSources-output.xcfilelist:
1439
1440 2019-03-12  Commit Queue  <commit-queue@webkit.org>
1441
1442         Unreviewed, rolling out r242825.
1443         https://bugs.webkit.org/show_bug.cgi?id=195648
1444
1445         "Broke webkitpy tests with my change to
1446         lldb_dump_class_layout.py" (Requested by rmorisset on
1447         #webkit).
1448
1449         Reverted changeset:
1450
1451         "Alter Tools/Scripts/dump-class-layout to be able to dump all
1452         classes with suspicious padding"
1453         https://bugs.webkit.org/show_bug.cgi?id=195573
1454         https://trac.webkit.org/changeset/242825
1455
1456 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1457
1458         [ews-build] Show status bubbles while the patch is waiting in queue
1459         https://bugs.webkit.org/show_bug.cgi?id=195618
1460
1461         Reviewed by Lucas Forschler.
1462
1463         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1464         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
1465         enabled in initial deployment.
1466         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
1467         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
1468         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
1469         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
1470         (StatusBubble._build_bubbles_for_patch):
1471
1472 2019-03-12  Robin Morisset  <rmorisset@apple.com>
1473
1474         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
1475         https://bugs.webkit.org/show_bug.cgi?id=195573
1476
1477         Reviewed by Simon Fraser.
1478
1479         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
1480
1481         * Scripts/dump-class-layout:
1482         (main):
1483         * lldb/lldb_dump_class_layout.py:
1484         (ClassLayout.__init__):
1485         (ClassLayout._compute_padding_recursive):
1486         (LLDBDebuggerInstance.dump_layout_for_classname):
1487         (LLDBDebuggerInstance):
1488         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
1489         (LLDBDebuggerInstance.layout_for_classname): Deleted.
1490
1491 2019-03-12  Chris Dumez  <cdumez@apple.com>
1492
1493         Device Orientation access permission should be denied unless explicitly granted by the client
1494         https://bugs.webkit.org/show_bug.cgi?id=195625
1495
1496         Reviewed by Youenn Fablet.
1497
1498         add API test coverage.
1499
1500         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1501         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
1502         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
1503         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
1504         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1505         (runDeviceOrientationTest):
1506         (TEST):
1507         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1508         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1509
1510 2019-03-12  Jer Noble  <jer.noble@apple.com>
1511
1512         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
1513         https://bugs.webkit.org/show_bug.cgi?id=195137
1514         <rdar://problem/48810307>
1515
1516         Reviewed by Eric Carlson.
1517
1518         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
1519         (TestWebKitAPI::TEST):
1520
1521 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1522
1523         [ews-build] Change urls from uat to production
1524         https://bugs.webkit.org/show_bug.cgi?id=195566
1525
1526         Reviewed by Lucas Forschler.
1527
1528         * BuildSlaveSupport/ews-app/ews/config.py:
1529         * BuildSlaveSupport/ews-build/events.py:
1530         * BuildSlaveSupport/ews-build/steps.py:
1531
1532 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1533
1534         [ews-build] change max_builds for local-worker to 1
1535         https://bugs.webkit.org/show_bug.cgi?id=195568
1536
1537         Reviewed by Lucas Forschler.
1538
1539         * BuildSlaveSupport/ews-build/loadConfig.py:
1540
1541 2019-03-12  Tim Horton  <timothy_horton@apple.com>
1542
1543         Fix the build
1544
1545         * TestRunnerShared/spi/PencilKitTestSPI.h:
1546         * TestWebKitAPI/ios/PencilKitTestSPI.h:
1547
1548 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1549
1550         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
1551         https://bugs.webkit.org/show_bug.cgi?id=194131
1552
1553         Reviewed by Michael Catanzaro.
1554
1555         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1556         (uriChanged):
1557         (testUnfinishedSubresourceLoad):
1558         (serverCallback):
1559         (beforeAll):
1560
1561 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1562
1563         WTF::Expected should use std::addressof instead of operator&
1564         https://bugs.webkit.org/show_bug.cgi?id=195604
1565
1566         Reviewed by Myles Maxfield.
1567
1568         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1569         (TestWebKitAPI::Unique::Unique):
1570         (TestWebKitAPI::Unique::operator&):
1571         (TestWebKitAPI::TEST):
1572
1573 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
1574
1575         Add Optional to Forward.h.
1576         https://bugs.webkit.org/show_bug.cgi?id=195586
1577
1578         Reviewed by Darin Adler.
1579
1580         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
1581         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
1582         Remove unnecessary includes from headers.
1583
1584 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
1585
1586         Add testing API to hit-test and scroll overflow scrollers
1587         https://bugs.webkit.org/show_bug.cgi?id=195278
1588
1589         Reviewed by Antti Koivisto.
1590         
1591         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
1592         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
1593         
1594         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
1595
1596         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1597         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1598         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1599         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1600         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1601         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1602         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1603         (WTR::enclosingScrollViewIncludingSelf):
1604         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1605
1606 2019-03-11  Tim Horton  <timothy_horton@apple.com>
1607
1608         API test WebKit.RequestTextInputContext fails on iOS
1609         https://bugs.webkit.org/show_bug.cgi?id=195585
1610
1611         Reviewed by Wenson Hsieh and Simon Fraser.
1612
1613         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1614         (applyStyle):
1615         (TEST):
1616         Add a viewport, so that the coordinates match up on iOS.
1617         Scroll by moving the UIScrollView's contentOffset.
1618
1619 2019-03-11  Chris Dumez  <cdumez@apple.com>
1620
1621         Assert in WebPageProxy::suspendCurrentPageIfPossible()
1622         https://bugs.webkit.org/show_bug.cgi?id=195506
1623         <rdar://problem/48733477>
1624
1625         Reviewed by Alex Christensen.
1626
1627         Add API test coverage.
1628
1629         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1630
1631 2019-03-11  Shawn Roberts  <sroberts@apple.com>
1632
1633         Adding myself to contributors.json
1634
1635         Unreviewed, addming myself to contributors.json .
1636
1637         * Scripts/webkitpy/common/config/contributors.json:
1638
1639 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1640
1641         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1642         https://bugs.webkit.org/show_bug.cgi?id=195511
1643         <rdar://problem/44873269>
1644
1645         Reviewed by Darin Adler.
1646
1647         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1648         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1649         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1650         (TEST_F):
1651
1652 2019-03-11  Chris Dumez  <cdumez@apple.com>
1653
1654         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
1655         https://bugs.webkit.org/show_bug.cgi?id=195561
1656
1657         Reviewed by Youenn Fablet.
1658
1659         Make sure the JS in the test requests for permission to receive device orientation events.
1660
1661         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1662
1663 2019-03-11  Youenn Fablet  <youenn@apple.com>
1664
1665         Allow storage quota increase by default in WTR
1666         https://bugs.webkit.org/show_bug.cgi?id=195541
1667
1668         Reviewed by Geoffrey Garen.
1669
1670         Allow storage quota increase by default in WTR.
1671         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
1672         Use this for tests that explicitly need cache increase.
1673
1674         Instead of increasing quota by 2, make sure the next request is
1675         granted by adding all given parameters.
1676
1677         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1678         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1679         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1680         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
1681         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1682         * WebKitTestRunner/TestController.cpp:
1683         (WTR::TestController::setAllowStorageQuotaIncrease):
1684         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1685         * WebKitTestRunner/TestController.h:
1686         * WebKitTestRunner/TestInvocation.cpp:
1687         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1688         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1689         (WTR::TestController::cocoaResetStateToConsistentValues):
1690         (WTR::TestController::setAllowStorageQuotaIncrease):
1691         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1692         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1693         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1694
1695 2019-03-11  Xan Lopez  <xan@igalia.com>
1696
1697         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
1698         https://bugs.webkit.org/show_bug.cgi?id=194147
1699
1700         Reviewed by Michael Saboff.
1701
1702         To make --32-bit work correctly on Linux/64bit we need to:
1703
1704         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
1705         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
1706         unfortunately CMake only allows us to do this during
1707         crosscompilation, which is overkill here.
1708         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
1709         pkg-config detection module uses the x86 .pc files instead of the
1710         x86_64 ones.
1711         - Set the -m32 flags for the compiler.
1712
1713         * Scripts/webkitdirs.pm:
1714         (generateBuildSystemFromCMakeProject):
1715
1716 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
1717
1718         Add MotionMark-1.1 plan file for run-benchmark script.
1719         https://bugs.webkit.org/show_bug.cgi?id=195481
1720
1721         Rubber-stamped by Darin Adler.
1722
1723         Run-benchmark script should support MontionMark-1.1.
1724
1725         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
1726
1727 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1728
1729         [ews-app] Add support for submit-to-ews url
1730         https://bugs.webkit.org/show_bug.cgi?id=195477
1731
1732         Reviewed by Lucas Forschler.
1733
1734         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1735         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1736         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
1737         * BuildSlaveSupport/ews-app/ews/urls.py:
1738         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
1739
1740 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
1741
1742         Unreviewed, rolling out r242688, r242643, r242624.
1743
1744         Caused multiple layout test failures and crashes on iOS and macOS.
1745
1746         Reverted changeset:
1747
1748         "requestAnimationFrame should execute before the next frame"
1749         https://bugs.webkit.org/show_bug.cgi?id=177484
1750         https://trac.webkit.org/changeset/242624/webkit
1751
1752         * Tracing/SystemTracePoints.plist:
1753
1754 2019-03-11  John Wilander  <wilander@apple.com>
1755
1756         Resource Load Statistics: Make it possible exclude localhost from classification
1757         https://bugs.webkit.org/show_bug.cgi?id=195474
1758         <rdar://problem/47520577>
1759
1760         Reviewed by Brent Fulgham.
1761
1762         This patch allows for localhost to be excluded from classification and
1763         treatment as a prevalent resource.
1764
1765         The WebKit Tools change adds a new function called
1766         testRunner.setStatisticsIsRunningTest() which can be used to control this
1767         behavior.
1768
1769         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1770         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1771         (WTR::TestRunner::setStatisticsIsRunningTest):
1772         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1773         * WebKitTestRunner/TestController.cpp:
1774         (WTR::TestController::setStatisticsIsRunningTest):
1775         * WebKitTestRunner/TestController.h:
1776         * WebKitTestRunner/TestInvocation.cpp:
1777         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1778
1779 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1780
1781         [ews-build] Disable waterfall and console view for ews-build.webkit.org
1782         https://bugs.webkit.org/show_bug.cgi?id=195560
1783
1784         Reviewed by Lucas Forschler.
1785
1786         * BuildSlaveSupport/ews-build/master.cfg:
1787
1788 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1789
1790         Unreviewed, rolling out r242698.
1791
1792         API test crashes on bots.
1793
1794         Reverted changeset:
1795
1796         "Add a WKContentRuleList variant that uses copied memory
1797         instead of mmap'd shared memory for class A containerized
1798         apps"
1799         https://bugs.webkit.org/show_bug.cgi?id=195511
1800         https://trac.webkit.org/changeset/242698
1801
1802 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1803
1804         [WPE] Enable web process sandbox
1805         https://bugs.webkit.org/show_bug.cgi?id=195169
1806
1807         Reviewed by Daniel Bates.
1808
1809         * wpe/install-dependencies:
1810         * wpe/jhbuild.modules:
1811
1812 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1813
1814         [ews-app] Use port 17000 for worker communication
1815         https://bugs.webkit.org/show_bug.cgi?id=195558
1816
1817         Reviewed by Lucas Forschler.
1818
1819         * BuildSlaveSupport/ews-build/master.cfg:
1820
1821 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1822
1823         [ews-build] unit-tests fail when passwords.json is missing
1824         https://bugs.webkit.org/show_bug.cgi?id=195557
1825
1826         Reviewed by Lucas Forschler.
1827
1828         * BuildSlaveSupport/ews-build/loadConfig.py:
1829         (loadBuilderConfig):
1830         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1831         (ConfigDotJSONTest.test_configuration):
1832         * BuildSlaveSupport/ews-build/master.cfg:
1833
1834 2019-03-11  Truitt Savell  <tsavell@apple.com>
1835
1836         Unreviewed, rolling out r242702.
1837
1838         Broke High Sierra builders.
1839
1840         Reverted changeset:
1841
1842         "Add utility function to allow easy reverse range-based
1843         iteration of a container"
1844         https://bugs.webkit.org/show_bug.cgi?id=195542
1845         https://trac.webkit.org/changeset/242702
1846
1847 2019-03-11  Sam Weinig  <sam@webkit.org>
1848
1849         Add utility function to allow easy reverse range-based iteration of a container
1850         https://bugs.webkit.org/show_bug.cgi?id=195542
1851
1852         Reviewed by Antti Koivisto.
1853
1854         * TestWebKitAPI/CMakeLists.txt:
1855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1856         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1857         (TestWebKitAPI::TEST):
1858         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1859
1860 2019-03-10  Alex Christensen  <achristensen@webkit.org>
1861
1862         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1863         https://bugs.webkit.org/show_bug.cgi?id=195511
1864         <rdar://problem/44873269>
1865
1866         Reviewed by Darin Adler.
1867
1868         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1869         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1870         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1871         (TEST_F):
1872
1873 2019-03-10  Tim Horton  <timothy_horton@apple.com>
1874
1875         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
1876         https://bugs.webkit.org/show_bug.cgi?id=195499
1877
1878         Reviewed by Darin Adler.
1879
1880         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1881         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
1882         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
1883         (-[WKWebView synchronouslyFocusTextInputContext:]):
1884         (applyStyle):
1885         (applyIframe):
1886         (TEST):
1887         Add some tests for this SPI.
1888
1889 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
1890
1891         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
1892         https://bugs.webkit.org/show_bug.cgi?id=181151
1893
1894         Reviewed by Don Olmstead.
1895
1896         * TestWebKitAPI/CMakeLists.txt:
1897         * TestWebKitAPI/PlatformWin.cmake:
1898         Enable TestWTF RunLoop tests in all platforms.
1899
1900         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1901         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
1902         (TestWebKitAPI::DerivedOneShotTimer::fired):
1903         (TestWebKitAPI::TEST):
1904         Only a few platforms support nested RunLoop.
1905
1906         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
1907         (TestWebKitAPI::DerivedRepeatingTimer::fired):
1908
1909 2019-03-10  David Quesada  <david_quesada@apple.com>
1910
1911         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
1912         https://bugs.webkit.org/show_bug.cgi?id=152480
1913
1914         Reviewed by Chris Dumez.
1915
1916         Add a unit test based on Daniel Bates's test case that starts a download, ensures
1917         there are no additional references to the process pool besides the one held by
1918         the download, waits for the download to finish (in the sense that the
1919         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
1920         measure, also check that the process pool has been deallocated at the end of the
1921         test. The test wouldn't be meaningful if the process pool were still alive.
1922
1923         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1924         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1925         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
1926             The download will be canceled because the delegate does not implement the
1927             method to decide the download's destination, so this is where we know the
1928             DownloadProxyMap is done with the DownloadProxy.
1929         (TEST):
1930
1931 2019-03-08  Chris Dumez  <cdumez@apple.com>
1932
1933         Add support for Device Orientation / Motion permission API
1934         https://bugs.webkit.org/show_bug.cgi?id=195329
1935         <rdar://problem/47645367>
1936
1937         Reviewed by Geoffrey Garen.
1938
1939         Add test infrastructure to help test the Device Orientation / Motion permission API.
1940
1941         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1942         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1943         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1944         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1945         * WebKitTestRunner/TestController.cpp:
1946         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
1947         (WTR::TestController::createWebViewWithOptions):
1948         (WTR::TestController::resetStateToConsistentValues):
1949         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
1950         * WebKitTestRunner/TestController.h:
1951         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
1952         * WebKitTestRunner/TestInvocation.cpp:
1953         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1954
1955 2019-03-08  Saam barati  <sbarati@apple.com>
1956
1957         Add a compare-results script to compare benchmark results
1958         https://bugs.webkit.org/show_bug.cgi?id=195486
1959         <rdar://problem/48723397>
1960
1961         Reviewed by Geoffrey Garen.
1962
1963         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
1964         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
1965         to extend it to learn about our other benchmarks.
1966
1967         * Scripts/compare-results: Added.
1968         (readJSONFile):
1969         (detectJetStream2):
1970         (JetStream2Results):
1971         (detectSpeedometer2):
1972         (Speedometer2Results):
1973         (detectPLT5):
1974         (PLT5Results):
1975         (detectBenchmark):
1976         (biggerIsBetter):
1977         (ttest):
1978         (getOptions):
1979         (main):
1980
1981 2019-03-08  Stephanie Lewis  <slewis@apple.com>
1982
1983         Ensure old tab state is cleared between iterations of run-benchmark
1984         https://bugs.webkit.org/show_bug.cgi?id=195393
1985         <rdar://problem/46885583>
1986
1987         Reviewed by Dewei Zhu.
1988
1989         a) ensure the default to restore state is not set
1990         b) terminate Safari correctly
1991         c) Set the system default to ignore Persistent State in Safari
1992
1993         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1994         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
1995         (OSXBrowserDriver.prepare_env): 
1996         (OSXBrowserDriver.restore_env):
1997         (OSXBrowserDriver.close_browsers):
1998         (OSXBrowserDriver._terminate_processes):
1999         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2000         (OSXChromeDriver):
2001         (OSXChromeCanaryDriver):
2002         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2003         (OSXFirefoxDriver):
2004         (OSXFirefoxNightlyDriver):
2005         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2006         (OSXSafariDriver):
2007         (OSXSafariDriver.prepare_env):
2008
2009 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2010
2011         [GTK] Several InputMethodFilter tests are failing
2012         https://bugs.webkit.org/show_bug.cgi?id=195408
2013
2014         Reviewed by Carlos Garcia Campos.
2015
2016         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2017         Regressed in r241751.
2018         Hexadecimal values of keycodes are expressed now in upper letters.
2019         Composited characters should be cast to UTF8 strings.
2020
2021         (TestWebKitAPI::TEST):
2022
2023 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2024
2025         [GTK] Make Tools/gtkdoc python3 compatible
2026         https://bugs.webkit.org/show_bug.cgi?id=195359
2027
2028         Reviewed by Carlos Garcia Campos.
2029
2030         * gtkdoc/generate-gtkdoc:
2031         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2032         work with Python 2 and 3.
2033         (get_gtkdoc_module_paths):
2034         The iteritems() was removed in Python 3, so let's use items() that's
2035         available in Python 2 and 3.
2036         (get_generator_for_config):
2037         * gtkdoc/gtkdoc.py:
2038         (GTKDoc._run_command):
2039         The sys.stdout.write() is expecting str in Python 3 and not bytes
2040         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2041         for passing the bytes there.
2042
2043 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2044
2045         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2046         https://bugs.webkit.org/show_bug.cgi?id=195346
2047         <rdar://problem/48667048>
2048
2049         Unreviewed build fix for clang-cl.
2050
2051         * DumpRenderTree/win/DumpRenderTree.cpp:
2052         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2053
2054 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2055
2056         requestAnimationFrame should execute before the next frame
2057         https://bugs.webkit.org/show_bug.cgi?id=177484
2058
2059         Reviewed by Simon Fraser.
2060
2061         Add trace points for the page RenderingUpdate.
2062
2063         * Tracing/SystemTracePoints.plist:
2064
2065 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2066
2067         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2068         https://bugs.webkit.org/show_bug.cgi?id=195353
2069         <rdar://problem/48626394>
2070
2071         Reviewed by Simon Fraser.
2072
2073         * WebKitTestRunner/ios/TestControllerIOS.mm:
2074         (WTR::TestController::platformResetPreferencesToConsistentValues):
2075
2076 2019-03-07  John Wilander  <wilander@apple.com>
2077
2078         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2079         https://bugs.webkit.org/show_bug.cgi?id=195383
2080         <rdar://problem/48570136>
2081
2082         Reviewed by Brent Fulgham.
2083
2084         This patch adds test infrastructure to purge only script-accessible cookies,
2085         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2086
2087         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2088         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2089         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2090         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2091         * WebKitTestRunner/TestController.cpp:
2092         (WTR::TestController::statisticsDeleteCookiesForHost):
2093         * WebKitTestRunner/TestController.h:
2094         * WebKitTestRunner/TestInvocation.cpp:
2095         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2096
2097 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2098
2099         Unreviewed, rolling out r242354.
2100         https://bugs.webkit.org/show_bug.cgi?id=195402
2101
2102         breaks layout tests in all configurations (Requested by
2103         zdobersek on #webkit).
2104
2105         Reverted changeset:
2106
2107         "[WPE] Enable web process sandbox"
2108         https://bugs.webkit.org/show_bug.cgi?id=195169
2109         https://trac.webkit.org/changeset/242354
2110
2111 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2112
2113         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2114         https://bugs.webkit.org/show_bug.cgi?id=195346
2115
2116         Reviewed by Fujii Hironori.
2117
2118         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2119         (TestWebKitAPI::TEST):
2120         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2121
2122         * DumpRenderTree/win/DumpRenderTree.cpp:
2123         (findFontFallback):
2124         (addFontFallbackIfPresent):
2125         (removeFontFallbackIfPresent):
2126         (main):
2127         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2128         (TestWebKitAPI::Util::moduleDirectory):
2129         (TestWebKitAPI::Util::createInjectedBundlePath):
2130         Use wchar helpers as needed.
2131
2132 2019-03-06  Rob Buis  <rbuis@igalia.com>
2133
2134         Consider supporting the `referrerpolicy` attribute.
2135         https://bugs.webkit.org/show_bug.cgi?id=179053
2136
2137         Reviewed by Darin Adler.
2138
2139         Add a runtime flag for referrerpolicy attribute.
2140
2141         * DumpRenderTree/mac/DumpRenderTree.mm:
2142         (enableExperimentalFeatures):
2143
2144 2019-03-05  Daniel Bates  <dabates@apple.com>
2145
2146         Update expected API test result following r242379
2147         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2148
2149         Update expected x-coordinate of selection rect now that the left padding of
2150         a textarea is sized in ems (so dependent on the font size) just like the left
2151         padding of a text field.
2152
2153         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2154         (TestWebKitAPI::TEST):
2155
2156 2019-03-05  David Quesada  <david_quesada@apple.com>
2157
2158         [WK2] It should be possible to follow links with 'download' attributes
2159         https://bugs.webkit.org/show_bug.cgi?id=195145
2160         rdar://problem/48462642
2161
2162         Reviewed by Alex Christensen.
2163
2164         Add a unit test to verify that activating links with 'download' attributes now
2165         navigates to the linked resource, rather than starts downloading it. Add another
2166         to verify that it is still possible to explicitly download the link via the
2167         'Download' navigation action policy.
2168
2169         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2170         (-[DownloadAttributeTestDelegate init]):
2171         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2172         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2173         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2174         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2175         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2176         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2177         (TEST):
2178         * WebKitTestRunner/TestController.cpp:
2179         (WTR::TestController::decidePolicyForNavigationAction):
2180         * WebKitTestRunner/TestController.h:
2181
2182 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2183
2184         [Curl] Implement Cookie Accept Policy.
2185         https://bugs.webkit.org/show_bug.cgi?id=191645
2186
2187         Reviewed by Fujii Hironori.
2188
2189         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2190         (TestWebKitAPI::Curl::TEST_F):
2191
2192 2019-03-05  Youenn Fablet  <youenn@apple.com>
2193
2194         Rename requestCacheStorageSpace to requestStorageSpace
2195         https://bugs.webkit.org/show_bug.cgi?id=195282
2196
2197         Reviewed by Chris Dumez.
2198
2199         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2200         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2201         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2202
2203 2019-03-05  Brady Eidson  <beidson@apple.com>
2204
2205         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2206         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2207
2208         Reviewed by Tim Horton.
2209
2210         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2211         different directory into that same WKWebView should work.
2212
2213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2214         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2215
2216 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2217
2218         Add WeakHashSet
2219         https://bugs.webkit.org/show_bug.cgi?id=195152
2220
2221         Reviewed by Antti Koivisto.
2222
2223         Added tests for WeakHashSet.
2224
2225         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2226         (TestWebKitAPI::Base::Base): Moved.
2227         (TestWebKitAPI::Derived::foo): Moved.
2228         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2229         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2230         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2231         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2232
2233 2019-03-04  Chris Dumez  <cdumez@apple.com>
2234
2235         Do not share WebProcesses between private and regular sessions
2236         https://bugs.webkit.org/show_bug.cgi?id=195189
2237         <rdar://problem/48421064>
2238
2239         Reviewed by Alex Christensen.
2240
2241         Add API test coverage.
2242
2243         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2244         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2245
2246 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2247
2248         [WPE] Enable web process sandbox
2249         https://bugs.webkit.org/show_bug.cgi?id=195169
2250
2251         Reviewed by Daniel Bates.
2252
2253         * wpe/install-dependencies:
2254         * wpe/jhbuild.modules:
2255
2256 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2257
2258         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2259         https://bugs.webkit.org/show_bug.cgi?id=195206
2260
2261         Reviewed by Žan Doberšek.
2262
2263         Add a new test case.
2264
2265         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2266         (testJSCClass):
2267
2268 2019-03-04  Charlie Turner  <cturner@igalia.com>
2269
2270         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2271         https://bugs.webkit.org/show_bug.cgi?id=194898
2272
2273         Reviewed by Žan Doberšek.
2274
2275         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2276         a GCC extension that permits arithmetic on void* pointer. Inline
2277         the macro until this issue is fixed upstream.
2278
2279 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2280
2281         Rid the world of WK_API_ENABLED
2282         https://bugs.webkit.org/show_bug.cgi?id=195263
2283
2284         Reviewed by Dan Bernstein.
2285
2286         List of changed files elided because it's useless.
2287
2288 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2289
2290         Unreviewed follow-up to r242292.
2291
2292         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2293
2294         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2295         (TestWebKitAPI::testStrip): Renamed from strip.
2296         (TestWebKitAPI::TEST):
2297
2298 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2299
2300         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2301
2302         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2303         and bug #194272 for details.
2304
2305         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2306
2307 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2308
2309         Remove some more unused 32-bit code
2310         https://bugs.webkit.org/show_bug.cgi?id=195255
2311
2312         Reviewed by Darin Adler.
2313
2314         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2315         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2316         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2317         (NPP_New):
2318         (NPP_HandleEvent):
2319         (handleEventCarbon): Deleted.
2320
2321 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2322
2323         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2324
2325         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2326         (TestWebKitAPI::TEST):
2327
2328 2019-03-01  Darin Adler  <darin@apple.com>
2329
2330         Finish removing String::format
2331         https://bugs.webkit.org/show_bug.cgi?id=194893
2332
2333         Reviewed by Daniel Bates.
2334 '
2335         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2336
2337 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2338
2339         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2340         https://bugs.webkit.org/show_bug.cgi?id=195229
2341         <rdar://problem/48520362>
2342
2343         Reviewed by Chris Dumez.
2344
2345         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2346         (TEST):
2347
2348 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2349
2350         Add a system trace scope for event region building
2351         https://bugs.webkit.org/show_bug.cgi?id=195226
2352
2353         Reviewed by Jon Lee.
2354
2355         This trace scope measures the time spend converting element rects into Region objects,
2356         which can be large on some pages.
2357
2358         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2359
2360         * Tracing/SystemTracePoints.plist:
2361
2362 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2363
2364         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2365         https://bugs.webkit.org/show_bug.cgi?id=194612
2366
2367         Reviewed by Alex Christensen.
2368
2369         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2370         Just test the new string-processing function and don't touch the actual environment.
2371         (Test cases are all as before, but based on operator== instead of strcmp.)
2372
2373 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2374
2375         [ews-app] Update primary keys for handling multiple Buildbot instances
2376         https://bugs.webkit.org/show_bug.cgi?id=195120
2377
2378         Reviewed by Stephanie Lewis.
2379
2380         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2381         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
2382         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
2383
2384         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
2385         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
2386         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
2387         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
2388         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
2389         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
2390
2391 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
2392
2393         [WinCairo] Enable service worker
2394         https://bugs.webkit.org/show_bug.cgi?id=188318
2395
2396         Reviewed by Youenn Fablet.
2397
2398         * DumpRenderTree/DumpRenderTreePrefix.h:
2399         * TestWebKitAPI/PlatformWin.cmake:
2400         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
2401         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
2402         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2403
2404 2019-03-01  Justin Fan  <justin_fan@apple.com>
2405
2406         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
2407         https://bugs.webkit.org/show_bug.cgi?id=195191
2408
2409         Rubber-stamped by Dean Jackson.
2410
2411         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
2412
2413         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2414
2415 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
2416
2417         Unreviewed, fix lldb webkitpy tests
2418         https://bugs.webkit.org/show_bug.cgi?id=194375
2419
2420         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
2421
2422         * lldb/lldb_webkit.py:
2423         (WTFStringImplProvider.is_8bit):
2424
2425 2019-02-28  David Quesada  <david_quesada@apple.com>
2426
2427         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
2428         https://bugs.webkit.org/show_bug.cgi?id=195121
2429         rdar://problem/48450302
2430
2431         Reviewed by Alex Christensen.
2432
2433         Add API tests for -WKNavigationAction._shouldPerformDownload in various
2434         configurations where the 'download' attribute is absent, blank, or populated
2435         with a filename, and where the anchor element is same-origin or cross-origin
2436         (meaning the 'download' attribute shouldn't be honored).
2437
2438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2439         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
2440         (-[NavigationActionTestDelegate init]):
2441         (-[NavigationActionTestDelegate navigationAction]):
2442         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
2443         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
2444         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2445         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
2446         (TEST):
2447
2448 2019-02-28  Antoine Quint  <graouts@apple.com>
2449
2450         Enable the Pointer Events runtime flag by default
2451         https://bugs.webkit.org/show_bug.cgi?id=195156
2452
2453         Reviewed by Dean Jackson.
2454
2455         * DumpRenderTree/mac/DumpRenderTree.mm:
2456         (enableExperimentalFeatures):
2457
2458 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2459
2460         Several PasteImage API tests are flaky
2461         https://bugs.webkit.org/show_bug.cgi?id=195160
2462
2463         Reviewed by Tim Horton.
2464
2465         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
2466         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
2467         listening for a "load" event after image load is already complete.
2468
2469         To address this, make these tests first register a "load" event handler, then run script to insert an image
2470         element into the document, and finally wait until the load event is observed before checking image size.
2471
2472         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2473
2474 2019-02-28  Chris Dumez  <cdumez@apple.com>
2475
2476         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
2477         https://bugs.webkit.org/show_bug.cgi?id=195107
2478
2479         Reviewed by Alex Christensen.
2480
2481         Give some time for the zoom level to get restored.
2482
2483         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2484
2485 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
2486
2487         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
2488         https://bugs.webkit.org/show_bug.cgi?id=194958
2489
2490         Reviewed by Geoffrey Garen.
2491
2492         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
2493         (TEST):
2494
2495 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
2496
2497         [ews-app] Update method to save build to handle builder_display_name
2498         https://bugs.webkit.org/show_bug.cgi?id=195047
2499
2500         Reviewed by Dewei Zhu.
2501
2502         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
2503         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
2504
2505 2019-02-28  Justin Fan  <justin_fan@apple.com>
2506
2507         [Web GPU] Enable Web GPU only on 64-bit
2508         https://bugs.webkit.org/show_bug.cgi?id=195139
2509
2510         Because Metal is only supported on 64 bit apps.
2511
2512         Unreviewed build fix.
2513
2514         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2515
2516 2019-02-27  Youenn Fablet  <youenn@apple.com>
2517
2518         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
2519         https://bugs.webkit.org/show_bug.cgi?id=194959
2520
2521         Reviewed by Chris Dumez.
2522
2523         Spin loop until getting the condition to remove flakiness.
2524
2525         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2526
2527 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
2528
2529         [ews-build] Buildbot should include builder_display_name in the build events
2530         https://bugs.webkit.org/show_bug.cgi?id=195045
2531
2532         Reviewed by Dewei Zhu.
2533
2534         * BuildSlaveSupport/ews-build/events.py:
2535         (Events.buildStarted): Included builder_display_name in event data. Also renamed
2536         buildername to builder_name to be consistent in naming style.
2537         (Events.buildFinished): Ditto.
2538
2539 2019-02-27  Chris Dumez  <cdumez@apple.com>
2540
2541         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
2542         https://bugs.webkit.org/show_bug.cgi?id=194480
2543
2544         Reviewed by Brady Eidson.
2545
2546         Update existing API test to make it more likely to reproduce the issue.
2547
2548         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2549
2550 2019-02-27  Brady Eidson  <beidson@apple.com>
2551
2552         Universal links from Google search results pages don't open the app.
2553         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
2554
2555         Reviewed by Geoffrey Garen.
2556
2557         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2558         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2559         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2560         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2561
2562 2019-02-27  Chris Dumez  <cdumez@apple.com>
2563
2564         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
2565         https://bugs.webkit.org/show_bug.cgi?id=195102
2566
2567         Reviewed by Geoffrey Garen.
2568
2569         If the number of processes is not yet what we expect, wait a bit and check again to give
2570         processes some time to exit.
2571
2572         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2573
2574 2019-02-27  Chris Dumez  <cdumez@apple.com>
2575
2576         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
2577         https://bugs.webkit.org/show_bug.cgi?id=194545
2578
2579         Reviewed by Brady Eidson.
2580
2581         Make sure the test navigates forward and then back only once. Previously, navigating
2582         back would trigger a navigation again in a timer.
2583
2584         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2585
2586 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
2587
2588         High Sierra Debug JSC test queue should use faster hardware
2589         https://bugs.webkit.org/show_bug.cgi?id=194603
2590
2591         Rubber-stamped by Alexey Proskuryakov.
2592
2593         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
2594
2595         * BuildSlaveSupport/build.webkit.org-config/config.json:
2596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2597         (BubbleQueueServer):
2598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2599         (WebKitBuildbot):
2600         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2601         * QueueStatusServer/config/queues.py:
2602         * Scripts/webkitpy/common/config/ews.json:
2603         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2604         (test_ews_name):
2605
2606 2019-02-27  John Wilander  <wilander@apple.com>
2607
2608         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
2609         https://bugs.webkit.org/show_bug.cgi?id=195071
2610         <rdar://problem/48417690>
2611
2612         Reviewed by Alex Christensen and Brent Fulgham.
2613
2614         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2615         (TestWebKitAPI::createURL):
2616             Convenience function.
2617         (TestWebKitAPI::TEST):
2618             WebCore::AdClickAttribution now takes a URL when creating Source and
2619             Destination.
2620         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
2621         (TestWebKitAPI::TEST):
2622             WebCore::AdClickAttribution now takes a URL when creating Source and
2623             Destination.
2624
2625 2019-02-27  Antoine Quint  <graouts@apple.com>
2626
2627         Support Pointer Events on macOS
2628         https://bugs.webkit.org/show_bug.cgi?id=195008
2629         <rdar://problem/47454419>
2630
2631         Reviewed by Dean Jackson.
2632
2633         * DumpRenderTree/mac/DumpRenderTree.mm:
2634         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
2635         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2636
2637 2019-02-26  Mark Lam  <mark.lam@apple.com>
2638
2639         Remove remaining poisoning code.
2640         https://bugs.webkit.org/show_bug.cgi?id=194138
2641
2642         Reviewed by Saam Barati.
2643
2644         * TestWebKitAPI/CMakeLists.txt:
2645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2646         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
2647         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
2648         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
2649         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
2650         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
2651         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
2652
2653 2019-02-26  Alex Christensen  <achristensen@webkit.org>
2654
2655         Move ephemeral local storage from WebProcess to UIProcess
2656         https://bugs.webkit.org/show_bug.cgi?id=195074
2657         <rdar://problem/47937975>
2658
2659         Reviewed by Geoff Garen.
2660
2661         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2662
2663 2019-02-20  Jer Noble  <jer.noble@apple.com>
2664
2665         [Cocoa] Media elements will restart network buffering just before suspending
2666         https://bugs.webkit.org/show_bug.cgi?id=193691
2667
2668         Reviewed by Eric Carlson.
2669
2670         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2671         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2672         (TEST):
2673
2674 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
2675
2676         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
2677         https://bugs.webkit.org/show_bug.cgi?id=191652
2678
2679         Reviewed by Alex Christensen.
2680
2681         Fix WinCairo MiniBrowser behavior of authentication dialog.
2682
2683         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2684         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2685
2686 2019-02-26  Youenn Fablet  <youenn@apple.com>
2687
2688         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
2689         https://bugs.webkit.org/show_bug.cgi?id=195028
2690         <rdar://problem/48243733>
2691
2692         Reviewed by Eric Carlson.
2693
2694         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2695
2696 2019-02-26  Philippe Normand  <pnormand@igalia.com>
2697
2698         [WPE] Add API for webview background color configuration
2699         https://bugs.webkit.org/show_bug.cgi?id=192305
2700
2701         Reviewed by Michael Catanzaro.
2702
2703         * MiniBrowser/wpe/main.cpp:
2704         (main): Add a new option to configure the webview background
2705         color. Example: --bg-color=transparent.
2706         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2707         (testWebViewBackgroundColor): Enable background color API tests for WPE.
2708         (beforeAll): Ditto.
2709
2710 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
2711
2712         scalableNativeWebpageParameters() is not preserved on new page navigation.
2713         https://bugs.webkit.org/show_bug.cgi?id=194892
2714         <rdar://problem/47538280>
2715
2716         Reviewed by Wenson Hsieh.
2717         
2718         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
2719
2720         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2721         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2722         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2723         (WTR::UIScriptController::allowsViewportShrinkToFit):
2724         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2725         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2726         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2727         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2728         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2729         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2730
2731 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2732
2733         [ews-app] Add model for handling multiple Buildbot instances
2734         https://bugs.webkit.org/show_bug.cgi?id=194863
2735
2736         Reviewed by Stephanie Lewis.
2737
2738         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
2739
2740 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2741
2742         [ews-app] Remove BuilderMapping table
2743         https://bugs.webkit.org/show_bug.cgi?id=194961
2744
2745         Reviewed by Stephanie Lewis.
2746
2747         Store builder name directly in build table, instead of having a separate
2748         table for it.
2749
2750         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
2751         * BuildSlaveSupport/ews-app/ews/models/build.py:
2752         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
2753         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2754
2755 2019-02-25  John Wilander  <wilander@apple.com>
2756
2757         Introduce and adopt new class RegistrableDomain for eTLD+1
2758         https://bugs.webkit.org/show_bug.cgi?id=194791
2759         <rdar://problem/48179240>
2760
2761         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
2762
2763         This patch adds an API test and replaces two instances of
2764         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
2765
2766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2767         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2768         (TestWebKitAPI::TEST):
2769             Changed two strings to make sure the registrable domains are still considered
2770             invalid and pass the test.
2771         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
2772         (TestWebKitAPI::TEST):
2773         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2774         (WTR::InjectedBundle::didReceiveMessageToPage):
2775
2776 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
2777
2778         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
2779         https://bugs.webkit.org/show_bug.cgi?id=195001
2780
2781         Reviewed by Carlos Garcia Campos.
2782
2783         API version 1.0 always includes the functionality previously guarded with
2784         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
2785         unconditionally.
2786
2787         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2788         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
2789         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
2790         (WebViewTest::showInWindow): Ditto.
2791         (WebViewTest::hideView): Ditto.
2792         * wpe/backends/HeadlessViewBackend.cpp:
2793         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
2794         * wpe/backends/ViewBackend.cpp:
2795         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
2796         * wpe/backends/WindowViewBackend.cpp:
2797         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
2798         WPE_BACKEND_CHECK_VERSION().
2799         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
2800
2801 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
2802
2803         [Flatpak] Add support for flatpak > 1.1.2
2804         https://bugs.webkit.org/show_bug.cgi?id=194088
2805
2806         Flatpak 1.2 is now out so we need to support that
2807         version now.
2808
2809         Reviewed by Michael Catanzaro.
2810
2811         * flatpak/flatpakutils.py:
2812         (check_flatpak):
2813         (FlatpakPackages.__init__):
2814         (FlatpakPackages.__detect_packages):
2815         (FlatpakPackages.__detect_packages.in):
2816         (FlatpakRepos.update):
2817
2818 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
2819
2820         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
2821         https://bugs.webkit.org/show_bug.cgi?id=194998
2822
2823         Reviewed by Carlos Garcia Campos.
2824
2825         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
2826         to a Git checkout and using the latest commit containing various fixes
2827         and improvements.
2828
2829 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2830
2831         [WPE][GTK] Remove user agent quirk for washingtonpost.com
2832         https://bugs.webkit.org/show_bug.cgi?id=194981
2833
2834         Reviewed by Žan Doberšek.
2835
2836         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2837         (TestWebKitAPI::TEST):
2838
2839 2019-02-23  Keith Miller  <keith_miller@apple.com>
2840
2841         Add new mac target numbers
2842         https://bugs.webkit.org/show_bug.cgi?id=194955
2843
2844         Reviewed by Tim Horton.
2845
2846         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2847         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2848         * MiniBrowser/Configurations/Base.xcconfig:
2849         * TestWebKitAPI/Configurations/Base.xcconfig:
2850         * WebKitTestRunner/Configurations/Base.xcconfig:
2851
2852 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
2853
2854         [WinCairo] Enable wk1/wk2 suffix for platform search path.
2855         https://bugs.webkit.org/show_bug.cgi?id=194846
2856
2857         Reviewed by Don Olmstead.
2858
2859         Added _search_paths() and _port_specific_expectations_files() for
2860         WinCairoPort.
2861
2862         * Scripts/webkitpy/port/win.py:
2863         (WinCairoPort.default_baseline_search_path):
2864         (WinCairoPort):
2865         (WinCairoPort._port_specific_expectations_files):
2866         (WinCairoPort._search_paths):
2867
2868 2019-02-22  Tim Horton  <timothy_horton@apple.com>
2869
2870         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
2871         https://bugs.webkit.org/show_bug.cgi?id=194963
2872
2873         Reviewed by Dean Jackson.
2874
2875         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2876         Do a `contains` check instead of `equals`, because in debug builds we
2877         put the GraphicsLayer pointer in a prefix.
2878
2879 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2880
2881         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
2882         https://bugs.webkit.org/show_bug.cgi?id=194873
2883         <rdar://problem/46701974>
2884
2885         Reviewed by Tim Horton.
2886
2887         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
2888
2889         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2890         (WTR::UIScriptController::menuRect const):
2891         (WTR::UIScriptController::isShowingMenu const):
2892         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2893         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2894         (WTR::UIScriptController::menuRect const):
2895
2896         Add a function to query the bounds of the callout menu in content coordinates.
2897
2898         (WTR::UIScriptController::isShowingMenu const):
2899
2900         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
2901
2902         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2903         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2904         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2905         (WTR::UIScriptController::rectForMenuAction const):
2906         (WTR::UIScriptController::menuRect const):
2907         (WTR::UIScriptController::isShowingMenu const):
2908         (WTR::findViewInHierarchyOfType): Deleted.
2909
2910 2019-02-22  Chris Dumez  <cdumez@apple.com>
2911
2912         Regression(PSON) Unable to preview password-protected documents on iCloud.com
2913         https://bugs.webkit.org/show_bug.cgi?id=194954
2914         <rdar://problem/48127957>
2915
2916         Reviewed by Alex Christensen.
2917
2918         Add API test coverage.
2919
2920         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2921         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2922         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2923         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2924
2925 2019-02-22  Chris Dumez  <cdumez@apple.com>
2926
2927         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
2928         https://bugs.webkit.org/show_bug.cgi?id=194924
2929         <rdar://problem/48216125>
2930
2931         Reviewed by Geoffrey Garen.
2932
2933         Add API test coverage.
2934
2935         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2936
2937 2019-02-22  Chris Dumez  <cdumez@apple.com>
2938
2939         Unreviewed, disable API test added in r241928 on iOS.
2940
2941         The cache is not enabled on devices with less than 3GB of RAM.
2942
2943         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2944
2945 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
2946
2947         Hardcode Visual Viewports on everywhere except iOS WK1
2948         https://bugs.webkit.org/show_bug.cgi?id=194928
2949
2950         Reviewed by Zalan Bujtas.
2951
2952         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
2953         change the default value of the Setting to 'true', and hardcode WebView on iOS to
2954         set it to false. The setting has shipped for several years and there's no need to turn
2955         it off now.
2956
2957         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
2958         Visual Viewports are not enabled.
2959         
2960         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
2961         that only runs in WK2
2962
2963         * MiniBrowser/mac/SettingsController.h:
2964         * MiniBrowser/mac/SettingsController.m:
2965         (-[SettingsController init]):
2966         (-[SettingsController _populateMenu]):
2967         (-[SettingsController validateMenuItem:]):
2968         (-[SettingsController visualViewportEnabled]): Deleted.
2969         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
2970         * MiniBrowser/mac/WK1BrowserWindowController.m:
2971         (-[WK1BrowserWindowController didChangeSettings]):
2972         * MiniBrowser/mac/WK2BrowserWindowController.m:
2973         (-[WK2BrowserWindowController didChangeSettings]):
2974
2975 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
2976
2977         Discard cached processes when clearing website data store
2978         https://bugs.webkit.org/show_bug.cgi?id=194894
2979
2980         Reviewed by Chris Dumez.
2981
2982         Added a test case.
2983
2984         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2985         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
2986
2987 2019-02-21  Alex Christensen  <achristensen@webkit.org>
2988
2989         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
2990         https://bugs.webkit.org/show_bug.cgi?id=194914
2991         <rdar://problem/47586889>
2992
2993         Reviewed by Geoffrey Garen.
2994
2995         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2996         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
2997         (TEST):
2998         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
2999
3000 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3001
3002         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3003         <https://webkit.org/b/194761>
3004
3005         Reviewed by Myles Maxfield.
3006
3007         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3008         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3009         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3010         to use ARC-compliant cast.
3011         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3012         ARC-compliant cast.
3013         (WTR::installFakeHelvetica): Log `error` to console if
3014         CTFontManagerRegisterFontsForURL() fails, but only on supported
3015         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3016         Call CFRelease() on `error` to fix the leak.  Update to use
3017         ARC-compliant cast.
3018         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3019         cast.
3020
3021 2019-02-21  Chris Dumez  <cdumez@apple.com>
3022
3023         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3024         https://bugs.webkit.org/show_bug.cgi?id=194481
3025
3026         Reviewed by Alex Christensen.
3027
3028         Give the processes a chance to shutdown and wait until we reached the expected number
3029         of processes.
3030
3031         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3032
3033 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3034
3035         Fix the macOS build
3036
3037         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3038
3039 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3040
3041         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3042
3043         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3044         I am a backwards.
3045
3046 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3047
3048         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3049
3050         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3051         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3052         We could force on UI-side compositing, but I feel like the test might be more
3053         valuable exercising the normal path on each platform (though the original
3054         bug was also UI-side specific). Though we can't validate that the overlay
3055         layer was installed successfully, there are layout tests that do that.
3056
3057 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3058
3059         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3060         https://bugs.webkit.org/show_bug.cgi?id=194845
3061         <rdar://problem/47944579>
3062
3063         Reviewed by Antti Koivisto.
3064
3065         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3066         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3067
3068 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3069
3070         [LFC][Floats] Add support for placing formatting roots in-between floats.
3071         https://bugs.webkit.org/show_bug.cgi?id=194902
3072
3073         Reviewed by Antti Koivisto.
3074
3075         * LayoutReloaded/misc/LFC-passing-tests.txt:
3076
3077 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3078
3079         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3080         https://bugs.webkit.org/show_bug.cgi?id=194901
3081
3082         Unreviewed build fix.
3083
3084         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3085         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3086         WPEBackend-fdo-0.1 as library name.
3087
3088 2019-02-21  Rob Buis  <rbuis@igalia.com>
3089
3090         Update MIME type parser
3091         https://bugs.webkit.org/show_bug.cgi?id=180526
3092
3093         Reviewed by Darin Adler.
3094
3095         Add tests involving leading and trailing whitespace, non-token
3096         characters and quoted strings.
3097
3098         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3099         (TestWebKitAPI::TEST):
3100
3101 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3102
3103         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3104         https://bugs.webkit.org/show_bug.cgi?id=194884
3105
3106         Reviewed by Michael Catanzaro.
3107
3108         * PlatformWin.cmake:
3109
3110 2019-02-20  Chris Dumez  <cdumez@apple.com>
3111
3112         Add API test for <rdar://problem/47471222>
3113         https://bugs.webkit.org/show_bug.cgi?id=194847
3114
3115         Reviewed by Alex Christensen.
3116
3117         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3118
3119 2019-02-20  Chris Dumez  <cdumez@apple.com>
3120
3121         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3122         https://bugs.webkit.org/show_bug.cgi?id=194872
3123         <rdar://problem/47924500>
3124
3125         Reviewed by Alex Christensen.
3126
3127         Add API test coverage.
3128
3129         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3130
3131 2019-02-20  Jer Noble  <jer.noble@apple.com>
3132
3133         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3134         https://bugs.webkit.org/show_bug.cgi?id=191332
3135
3136         Reviewed by Dean Jackson.
3137
3138         * Scripts/git-is-in-range: Added.
3139
3140 2019-02-20  Andy Estes  <aestes@apple.com>
3141
3142         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3143         https://bugs.webkit.org/show_bug.cgi?id=194869
3144
3145         Rubber-stamped by Jer Noble.
3146
3147         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3148         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3149         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3150         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3151         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3152         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3153
3154 2019-02-20  Chris Dumez  <cdumez@apple.com>
3155
3156         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3157         https://bugs.webkit.org/show_bug.cgi?id=194857
3158         <rdar://problem/47759323>
3159
3160         Reviewed by Alex Christensen.
3161
3162         Add API test coverage.
3163
3164         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3165
3166 2019-02-20  Chris Dumez  <cdumez@apple.com>
3167
3168         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3169         https://bugs.webkit.org/show_bug.cgi?id=194829
3170         <rdar://problem/47889906>
3171
3172         Reviewed by Alexey Proskuryakov.
3173
3174         Every time the TestOptions were changing we were creating both a new Web view and
3175         a new WKContext, which would start a new Network process. In most cases, we only
3176         need to contruct a new Web view and we do can keep reusing the same WKContext.
3177         This patch implements this optimization and thus avoids spinning a lot of new
3178         Network processes while running the layout tests.
3179
3180         * WebKitTestRunner/TestController.cpp:
3181         (WTR::TestController::generateContextConfiguration const):
3182         (WTR::TestController::generatePageConfiguration):
3183         (WTR::TestController::createWebViewWithOptions):
3184         (WTR::TestController::resetPreferencesToConsistentValues):
3185         (WTR::updateTestOptionsFromTestHeader):
3186         * WebKitTestRunner/TestController.h:
3187         * WebKitTestRunner/TestOptions.h:
3188         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3189         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3190         (WTR::TestOptions::hasSameInitializationOptions const):
3191         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3192         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3193         (WTR::TestController::platformAddTestOptions const):
3194
3195 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3196
3197         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3198         https://bugs.webkit.org/show_bug.cgi?id=167941
3199
3200         Reviewed by Carlos Garcia Campos.
3201
3202         * MiniBrowser/gtk/main.c:
3203         (filterSavedCallback): Added.
3204         (main): Support loading a JSON rule set file for content filtering.
3205         * MiniBrowser/wpe/main.cpp:
3206         (filterSavedCallback): Added.
3207         (main): Support loading a JSON rule set file for content filtering.
3208         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3209         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3210         (WTF::derefGPtr): Ditto.
3211         (testEmptyStore):
3212         (testSaveInvalidFilter):
3213         (testSaveLoadFilter):
3214         (testSavedFilterIdentifierMatch):
3215         (testRemoveFilter):
3216         (testSaveMultipleFilters):
3217         (testSaveFilterFromFile):
3218         (testFilterPersistence):
3219         (beforeAll):
3220         (afterAll):
3221         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3222         (removeOldInjectedContentAndResetLists): Also reset content filters.
3223         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3224         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3225         the element affected by the style sheet.
3226         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3227         and returns it to be used by tests.
3228         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3229         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3230         (serverCallback): Add support for serving a CSS style sheet for testing.
3231         (beforeAll): Add call to testUserContentManagerContentFilter().
3232         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3233
3234 2019-02-19  Keith Rollin  <krollin@apple.com>
3235
3236         Add timing information to build output
3237         https://bugs.webkit.org/show_bug.cgi?id=194839
3238         <rdar://problem/48219609>
3239
3240         Reviewed by Alexey Proskuryakov.
3241
3242         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3243         emit each project's build time to its output. E.g.,
3244
3245             ** BUILD SUCCEEDED ** [0.132 sec]
3246
3247         * Scripts/webkitdirs.pm:
3248         (XcodeOptions):
3249
3250 2019-02-19  Truitt Savell  <tsavell@apple.com>
3251
3252         Unreviewed, rolling out r241784.
3253
3254         Broke all OpenSource builds.
3255
3256         Reverted changeset:
3257
3258         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3259         instances view"
3260         https://bugs.webkit.org/show_bug.cgi?id=172848
3261         https://trac.webkit.org/changeset/241784
3262
3263 2019-02-19  Zalan Bujtas  <zalan@apple.com>
3264
3265         [LFC][Floats] Remove redundant intersecting logic
3266         https://bugs.webkit.org/show_bug.cgi?id=194804
3267
3268         Reviewed by Antti Koivisto.
3269
3270         * LayoutReloaded/misc/LFC-passing-tests.txt:
3271
3272 2019-02-19  Dean Jackson  <dino@apple.com>
3273
3274         Clean-up output from generate-xcfilelists so it can be filtered
3275         https://bugs.webkit.org/show_bug.cgi?id=194795
3276
3277         Reviewed by Joseph Pecoraro (and Keith Rollin).
3278
3279         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
3280         make a slight tweak to filter-build-webkit so such lines are marked
3281         as plain.
3282
3283         * Scripts/filter-build-webkit:
3284         * Scripts/generate-xcfilelists:
3285
3286 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3287
3288         pytest is not correctly auto-installed
3289         https://bugs.webkit.org/show_bug.cgi?id=194707
3290
3291         Reviewed by Carlos Garcia Campos.
3292
3293         * Scripts/webkitpy/thirdparty/__init__.py:
3294         (AutoinstallImportHook._install_pytest):
3295
3296 2019-02-18  Chris Dumez  <cdumez@apple.com>
3297
3298         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
3299         https://bugs.webkit.org/show_bug.cgi?id=194797
3300         <rdar://problem/48055151>
3301
3302         Reviewed by Geoffrey Garen.
3303
3304         Add API test coverage.
3305
3306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3307
3308 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3309
3310         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
3311         https://bugs.webkit.org/show_bug.cgi?id=194670
3312         <rdar://problem/39066529>
3313
3314         Reviewed by Tim Horton.
3315
3316         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
3317         pasted in an editable area as attachment elements.
3318
3319         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3320         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3321         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
3322         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3323         (TestWebKitAPI::TEST):
3324         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3325         (WTR::InjectedBundlePage::InjectedBundlePage):
3326
3327 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3328
3329         Fix API test after r241728
3330        ​https://bugs.webkit.org/show_bug.cgi?id=194723
3331
3332         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3333         (TEST):
3334         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
3335
3336 2019-02-18  Daniel Bates  <dabates@apple.com>
3337
3338         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3339         https://bugs.webkit.org/show_bug.cgi?id=192824
3340         <rdar://problem/47100332>
3341
3342         Reviewed by Wenson Hsieh.
3343
3344         Fix a bug where the wrong usage code was used for F13 thru F24.
3345
3346         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3347         (keyCodeForDOMFunctionKey):
3348
3349 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
3350
3351         Bytecode cache should a have a boot-specific validation
3352         https://bugs.webkit.org/show_bug.cgi?id=194769
3353         <rdar://problem/48149509>
3354
3355         Reviewed by Keith Miller.
3356
3357         Add test for WTF::bootSessionUUIDString()
3358
3359         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3360         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
3361         (TEST):
3362
3363 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3364
3365         Disable safe browsing in WKWebView and remove its WKPreferences API
3366         https://bugs.webkit.org/show_bug.cgi?id=194723
3367         <rdar://problem/48122993>
3368
3369         Reviewed by Geoffrey Garen.
3370
3371         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3372         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3373         (TEST):
3374         (safeBrowsingView):
3375         Make tests use SPI instead of API.
3376
3377 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3378
3379         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
3380         https://bugs.webkit.org/show_bug.cgi?id=194586
3381
3382         Reviewed by Ross Kirsling.
3383
3384         * DumpRenderTree/win/DumpRenderTree.cpp:
3385         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
3386         * Scripts/webkitpy/port/driver.py:
3387         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
3388
3389 2019-02-17  David Kilzer  <ddkilzer@apple.com>
3390
3391         Unreviewed, rolling out r241620.
3392
3393         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
3394         (Requested by ddkilzer on #webkit.)
3395
3396         Reverted changeset:
3397
3398         "[WTF] Add environment variable helpers"
3399         https://bugs.webkit.org/show_bug.cgi?id=192405
3400         https://trac.webkit.org/changeset/241620
3401
3402 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3403
3404         [LFC] RenderImage's default intrinsic size is 0.
3405         https://bugs.webkit.org/show_bug.cgi?id=194745
3406
3407         Reviewed by Antti Koivisto.
3408
3409         * LayoutReloaded/misc/LFC-passing-tests.txt:
3410
3411 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3412
3413         [LFC][BFC] Add support for block replaced intrinsic width.
3414         https://bugs.webkit.org/show_bug.cgi?id=194705
3415
3416         Reviewed by Simon Fraser.
3417
3418         * LayoutReloaded/misc/LFC-passing-tests.txt:
3419
3420 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3421
3422         [LFC] Apply min/max width constraints to preferred width computation
3423         https://bugs.webkit.org/show_bug.cgi?id=194739
3424
3425         Reviewed by Simon Fraser.
3426
3427         * LayoutReloaded/misc/LFC-passing-tests.txt:
3428
3429 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
3430
3431         [WTF] Add environment variable helpers
3432         https://bugs.webkit.org/show_bug.cgi?id=192405
3433
3434         Reviewed by Michael Catanzaro.
3435
3436         * DumpRenderTree/mac/DumpRenderTree.mm:
3437         (libraryPathForDumpRenderTree):
3438         * DumpRenderTree/win/DumpRenderTree.cpp:
3439         (libraryPathForDumpRenderTree):
3440         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3441         (setUpIOSLayoutTestCommunication):
3442         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3443         (beforeAll):
3444         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3445         (main):
3446         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3447         (WebKitTestBus::run):
3448         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3449         (WTR::getOutputDir):
3450         (WTR::initializeFontConfigSetting):
3451         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3452         (WTR::InjectedBundle::platformInitialize):
3453         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3454         (WTR::topLevelPath):
3455         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3456         (WTR::topLevelPath):
3457         (WTR::getOutputDir):
3458         (WTR::activateFonts):
3459         * WebKitTestRunner/TestController.cpp:
3460         (WTR::TestController::libraryPathForTesting):
3461         (WTR::TestController::generateContextConfiguration const):
3462         (WTR::TestController::generatePageConfiguration):
3463         (WTR::TestController::decideDestinationWithSuggestedFilename):
3464         (WTR::TestController::platformAdjustContext):
3465         * WebKitTestRunner/TestController.h:
3466         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3467         (WTR::TestController::cocoaPlatformInitialize):
3468         (WTR::TestController::platformAdjustContext):
3469         * WebKitTestRunner/gtk/main.cpp:
3470         (main):
3471         * WebKitTestRunner/mac/TestControllerMac.mm:
3472         (WTR::TestController::configureContentExtensionForTest):
3473         * WebKitTestRunner/wpe/main.cpp:
3474         (main):
3475         Utilize WTF::Environment where possible.
3476
3477 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3478
3479         [iOS] WKWebView callout bar is missing Change Writing Direction item
3480         https://bugs.webkit.org/show_bug.cgi?id=190015
3481         <rdar://problem/44810366>
3482
3483         Reviewed by Tim Horton.
3484
3485         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
3486         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
3487
3488         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
3489         (TestWebKitAPI::TEST):
3490
3491 2019-02-15  Chris Dumez  <cdumez@apple.com>
3492
3493         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
3494         https://bugs.webkit.org/show_bug.cgi?id=194717
3495         <rdar://problem/47884404>
3496
3497         Reviewed by Brady Eidson.
3498
3499         Add API test coverage.
3500
3501         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3502
3503 2019-02-15  Youenn Fablet  <youenn@apple.com>
3504
3505         Make navigator.mediaDevices SecureContext
3506         https://bugs.webkit.org/show_bug.cgi?id=194666
3507
3508         Reviewed by Eric Carlson.
3509
3510         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3511         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
3512         (TEST_F):
3513
3514 2019-02-15  Brian Burg  <bburg@apple.com>
3515
3516         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3517         https://bugs.webkit.org/show_bug.cgi?id=194411
3518         <rdar://problem/47787614>
3519
3520         Reviewed by Joseph Pecoraro.
3521
3522         Remove unnecessary soft linking macro usage.
3523
3524         * DumpRenderTree/mac/TestRunnerMac.mm:
3525         (TestRunner::inspectorTestStubURL):
3526         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3527         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3528         (WTR::TestRunner::inspectorTestStubURL):
3529
3530 2019-02-15  Commit Queue  <commit-queue@webkit.org>
3531
3532         Unreviewed, rolling out r241559 and r241566.
3533         https://bugs.webkit.org/show_bug.cgi?id=194710
3534
3535         Causes layout test crashes under GuardMalloc (Requested by
3536         ryanhaddad on #webkit).
3537
3538         Reverted changesets:
3539
3540         "[WTF] Add environment variable helpers"
3541         https://bugs.webkit.org/show_bug.cgi?id=192405
3542         https://trac.webkit.org/changeset/241559
3543
3544         "Unreviewed build fix for WinCairo Debug after r241559."
3545         https://trac.webkit.org/changeset/241566
3546
3547 2019-02-15  Zalan Bujtas  <zalan@apple.com>
3548
3549         [LFC] Out-of-flow box is never a float box
3550         https://bugs.webkit.org/show_bug.cgi?id=194704
3551
3552         Reviewed by Antti Koivisto.
3553
3554         * LayoutReloaded/misc/LFC-passing-tests.txt:
3555
3556 2019-02-10  Darin Adler  <darin@apple.com>
3557
3558         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
3559         https://bugs.webkit.org/show_bug.cgi?id=194487
3560
3561         Reviewed by Daniel Bates.
3562
3563         * DumpRenderTree/win/DumpRenderTree.cpp:
3564         (applicationId): Use makeString instead of String::format.
3565         (main): Ditto.
3566         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3567         (TestWebKitAPI::Util::createURLForResource): Ditto.
3568         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3569         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
3570
3571         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3572         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
3573         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
3574         (WTR::createStringWithAttributes): Use appendLiteral.
3575         (WTR::AccessibilityUIElement::helpText const): Ditto.
3576         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
3577         directly instead of using String::format.
3578         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
3579         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
3580
3581 2019-02-15  Truitt Savell  <tsavell@apple.com>
3582
3583         Unreviewed, rolling out r241564.
3584
3585         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
3586
3587         Reverted changeset:
3588
3589         "[Mac] WebInspectorUI.framework does not need to be soft-
3590         linked anymore"
3591         https://bugs.webkit.org/show_bug.cgi?id=194411
3592         https://trac.webkit.org/changeset/241564
3593
3594 2019-02-15  Saam barati  <sbarati@apple.com>
3595
3596         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
3597         https://bugs.webkit.org/show_bug.cgi?id=194036
3598
3599         Reviewed by Yusuke Suzuki.
3600
3601         * Scripts/run-jsc-stress-tests:
3602
3603 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3604
3605         Fix the build.
3606
3607         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3608         (WTR::UIScriptController::drawSquareInEditableImage):
3609         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3610         (TestWebKitAPI::drawSquareInEditableImage):
3611
3612 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3613
3614         Fix the build.
3615
3616         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3617         (WTR::UIScriptController::drawSquareInEditableImage):
3618         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3619         (TestWebKitAPI::drawSquareInEditableImage):
3620
3621 2019-02-14  Brian Burg  <bburg@apple.com>
3622
3623         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3624         https://bugs.webkit.org/show_bug.cgi?id=194411
3625         <rdar://problem/47787614>
3626
3627         Reviewed by Joseph Pecoraro.
3628
3629         Remove unnecessary soft linking macro usage.
3630
3631         * DumpRenderTree/mac/TestRunnerMac.mm:
3632         (TestRunner::inspectorTestStubURL):
3633         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3634         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3635         (WTR::TestRunner::inspectorTestStubURL):
3636
3637 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3638
3639         [ews-app] status bubble should fetch builder name info from BuilderMapping table
3640         https://bugs.webkit.org/show_bug.cgi?id=194599
3641
3642         Reviewed by Lucas Forschler.
3643
3644         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3645         (StatusBubble._build_bubble):
3646
3647 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3648
3649         [ews-app] Set Foreign Key in Django build model
3650         https://bugs.webkit.org/show_bug.cgi?id=194667
3651
3652         Reviewed by Lucas Forschler.
3653
3654         * BuildSlaveSupport/ews-app/ews/models/build.py:
3655         (Build):
3656
3657 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
3658
3659         [WTF] Add environment variable helpers
3660         https://bugs.webkit.org/show_bug.cgi?id=192405
3661
3662         Reviewed by Michael Catanzaro.
3663
3664         * DumpRenderTree/mac/DumpRenderTree.mm:
3665         (libraryPathForDumpRenderTree):
3666         * DumpRenderTree/win/DumpRenderTree.cpp:
3667         (libraryPathForDumpRenderTree):
3668         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3669         (setUpIOSLayoutTestCommunication):
3670         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3671         (TestWebKitAPI::strip):
3672         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3673         (beforeAll):
3674         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3675         (main):
3676         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3677         (WebKitTestBus::run):
3678         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3679         (WTR::getOutputDir):
3680         (WTR::initializeFontConfigSetting):
3681         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3682         (WTR::InjectedBundle::platformInitialize):
3683         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3684         (WTR::topLevelPath):
3685         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3686         (WTR::topLevelPath):
3687         (WTR::getOutputDir):
3688         (WTR::activateFonts):
3689         * WebKitTestRunner/TestController.cpp:
3690         (WTR::TestController::libraryPathForTesting):
3691         (WTR::TestController::generateContextConfiguration const):
3692         (WTR::TestController::generatePageConfiguration):
3693         (WTR::TestController::decideDestinationWithSuggestedFilename):
3694         (WTR::TestController::platformAdjustContext):
3695         * WebKitTestRunner/TestController.h:
3696         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3697         (WTR::TestController::cocoaPlatformInitialize):
3698         (WTR::TestController::platformAdjustContext):
3699         * WebKitTestRunner/gtk/main.cpp:
3700         (main):
3701         * WebKitTestRunner/mac/TestControllerMac.mm:
3702         (WTR::TestController::configureContentExtensionForTest):
3703         * WebKitTestRunner/wpe/main.cpp:
3704         (main):
3705         Utilize WTF::Environment where possible.
3706
3707 2019-02-14  Chris Dumez  <cdumez@apple.com>
3708
3709         [PSON] Introduce a WebContent Process cache
3710         https://bugs.webkit.org/show_bug.cgi?id=194594
3711         <rdar://problem/46793397>
3712
3713         Reviewed by Geoff Garen.
3714
3715         Update API tests to turn on the WebContent Process cache.
3716
3717         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3718
3719 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
3720
3721         Unreviewed, build fix after r241480
3722
3723         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3724         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3725         (-[DragAndDropSimulator initWithWebView:]):
3726
3727 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
3728
3729         AX: ARIA Reflection was disabled in error
3730         https://bugs.webkit.org/show_bug.cgi?id=194647
3731         <rdar://problem/48068336>
3732
3733         Reviewed by Ryosuke Niwa.
3734
3735         Remove test override now that this feature should be enabled by default.
3736
3737         * WebKitTestRunner/TestController.cpp:
3738         (WTR::TestController::resetPreferencesToConsistentValues):
3739
3740 2019-02-14  Commit Queue  <commit-queue@webkit.org>
3741
3742         Unreviewed, rolling out r241486.
3743         https://bugs.webkit.org/show_bug.cgi?id=194655
3744
3745         causing API failures in builds (Requested by ShawnRoberts on
3746         #webkit).
3747
3748         Reverted changeset:
3749
3750         "[Cocoa] Media elements will restart network buffering just
3751         before suspending"
3752         https://bugs.webkit.org/show_bug.cgi?id=193691
3753         https://trac.webkit.org/changeset/241486
3754
3755 2019-02-14  Zalan Bujtas  <zalan@apple.com>
3756
3757         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
3758         https://bugs.webkit.org/show_bug.cgi?id=194622
3759
3760         Reviewed by Antti Koivisto.
3761
3762         * LayoutReloaded/misc/LFC-passing-tests.txt:
3763
3764 2019-02-14  Zalan Bujtas  <zalan@apple.com>
3765
3766         [LFC] Shrink-to-fit-width should be constrained by min/max width
3767         https://bugs.webkit.org/show_bug.cgi?id=194653
3768
3769         Reviewed by Antti Koivisto.
3770
3771         * LayoutReloaded/misc/LFC-passing-tests.txt:
3772
3773 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
3774
3775         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
3776         https://bugs.webkit.org/show_bug.cgi?id=194641
3777
3778         Reviewed by Geoffrey Garen.
3779
3780         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
3781         so that the test would fail without this fix.
3782
3783         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
3784         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
3785
3786 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3787
3788         [ews-app] Change log level for a log statement
3789
3790         Unreviewed minor fix.
3791
3792         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3793         (Patch.save_patch):
3794
3795 2019-02-13  Jer Noble  <jer.noble@apple.com>
3796
3797         [Cocoa] Media elements will restart network buffering just before suspending
3798         https://bugs.webkit.org/show_bug.cgi?id=193691
3799
3800         Reviewed by Eric Carlson.
3801
3802         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3803         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3804         (TEST):
3805
3806 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3807
3808         [ews-app] Fetch builder id to name mapping
3809         https://bugs.webkit.org/show_bug.cgi?id=194355
3810
3811         Reviewed by Lucas Forschler.
3812
3813         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3814         (Buildbot.get_builder_id_to_name_mapping):
3815         (Buildbot._get_display_name_from_builder_name):
3816
3817 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
3818
3819         Further restricting webarchive loads
3820         https://bugs.webkit.org/show_bug.cgi?id=194567
3821         <rdar://problem/47610130>
3822
3823         Reviewed by Youenn Fablet.
3824
3825         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
3826         navigations on drop.
3827
3828         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3829         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
3830         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
3831         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3832         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3833         (TestWebKitAPI::TEST):
3834         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
3835         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
3836         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
3837         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3838         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3839         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3840         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
3841
3842 2019-02-13  John Wilander  <wilander@apple.com>
3843
3844         Store Ad Click Attribution requests in the network process
3845         https://bugs.webkit.org/show_bug.cgi?id=194510
3846         <rdar://problem/47650118>
3847
3848         Reviewed by Alex Christensen and Daniel Bates.
3849
3850         This patch adds two TestRunner functions:
3851         - dumpAdClickAttribution()
3852         - clearAdClickAttribution()
3853
3854         They call into the network process to dump and clear Ad Click
3855         Attribution state, respectively.
3856
3857         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3858         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3859         (WTR::TestRunner::dumpAdClickAttribution):
3860         (WTR::TestRunner::clearAdClickAttribution):
3861         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3862         * WebKitTestRunner/TestController.cpp:
3863         (WTR::TestController::resetStateToConsistentValues):
3864         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
3865         (WTR::adClickAttributionStringResultCallback):
3866         (WTR::TestController::dumpAdClickAttribution):
3867         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
3868         (WTR::adClickAttributionVoidCallback):
3869         (WTR::TestController::clearAdClickAttribution):
3870         * WebKitTestRunner/TestController.h:
3871         * WebKitTestRunner/TestInvocation.cpp:
3872         (WTR::TestInvocation::dumpResults):
3873         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3874         (WTR::TestInvocation::dumpAdClickAttribution):
3875         * WebKitTestRunner/TestInvocation.h:
3876
3877 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3878
3879         [ews-app] Generate status-bubble
3880         https://bugs.webkit.org/show_bug.cgi?id=194572
3881
3882         Reviewed by Lucas Forschler.
3883
3884         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3885         (StatusBubble._build_bubble):
3886         (StatusBubble._should_show_bubble_for):
3887         (StatusBubble._build_bubbles_for_patch):
3888
3889 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3890
3891         [ews-app] Add status bubble html template
3892         https://bugs.webkit.org/show_bug.cgi?id=194571
3893
3894         Reviewed by Lucas Forschler.
3895
3896         * BuildSlaveSupport/ews-app/ews/templates: Added.
3897         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
3898
3899 2019-02-12  Chris Dumez  <cdumez@apple.com>
3900
3901         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
3902         https://bugs.webkit.org/show_bug.cgi?id=194568
3903         <rdar://problem/47944490>
3904
3905         Reviewed by Ryosuke Niwa.
3906
3907         Add API test coverage.
3908
3909         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3910         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3911
3912 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
3913
3914         webkitpy: Remove bug_dummy from parsed test expectations
3915         https://bugs.webkit.org/show_bug.cgi?id=194562
3916         <rdar://problem/47853999>
3917
3918         Reviewed by Lucas Forschler.
3919
3920         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3921         (TestExpectationParser):
3922         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
3923         skipped tests.
3924         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3925
3926 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
3927
3928         [ews-app] Add method to fetch patch
3929         https://bugs.webkit.org/show_bug.cgi?id=194518
3930
3931         Reviewed by Lucas Forschler.
3932
3933         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3934         (Patch.get_patch):
3935
3936 2019-02-12  Zalan Bujtas  <zalan@apple.com>
3937
3938         [LFC] Expand tests coverage (60 new tests -> 860)
3939
3940         Unreviewed test gardening (run-singly, --child-processes=1).
3941
3942         * LayoutReloaded/misc/LFC-passing-tests.txt:
3943
3944 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3945
3946         Allow pages to trigger programmatic paste from script on iOS
3947         https://bugs.webkit.org/show_bug.cgi?id=194271
3948         <rdar://problem/47808810>
3949
3950         Reviewed by Tim Horton.
3951
3952         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
3953
3954         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3955         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3956         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3957         (WTR::UIScriptController::rectForMenuAction const):
3958
3959         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
3960         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
3961         for when the menu is shown or hidden.
3962
3963         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3964         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3965         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3966         (WTR::UIScriptController::setDidShowMenuCallback):
3967         (WTR::UIScriptController::didShowMenuCallback const):
3968         (WTR::UIScriptController::setDidHideMenuCallback):
3969         (WTR::UIScriptController::didHideMenuCallback const):
3970         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3971         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3972         (WTR::UIScriptController::rectForMenuAction const):
3973         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3974         * WebKitTestRunner/TestController.cpp:
3975         (WTR::TestController::resetPreferencesToConsistentValues):
3976         (WTR::updateTestOptionsFromTestHeader):
3977         * WebKitTestRunner/TestOptions.h:
3978
3979         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
3980         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
3981
3982         (WTR::TestOptions::hasSameInitializationOptions const):
3983         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3984         (WTR::UIScriptController::calendarType const):
3985         (WTR::UIScriptController::platformUndoManager const):
3986         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3987         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3988         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3989         (-[TestRunnerWKWebView dealloc]):
3990         (-[TestRunnerWKWebView _didShowMenu]):
3991         (-[TestRunnerWKWebView _didHideMenu]):
3992
3993         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
3994
3995         * WebKitTestRunner/ios/TestControllerIOS.mm:
3996         (WTR::handleMenuWillHideNotification):
3997         (WTR::handleMenuDidHideNotification):
3998         (WTR::TestController::platformInitialize):
3999         (WTR::TestController::platformDestroy):
4000         (WTR::TestController::platformResetStateToConsistentValues):
4001
4002         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
4003         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
4004
4005         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4006         (WTR::forEachViewInHierarchy):
4007         (WTR::findViewInHierarchyOfType):
4008
4009         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
4010         functions that dig through a given view's hierarchy in search of a view of a given class.
4011
4012         (WTR::UIScriptController::selectionStartGrabberViewRect const):
4013         (WTR::UIScriptController::selectionEndGrabberViewRect const):
4014         (WTR::UIScriptController::selectionCaretViewRect const):
4015         (WTR::UIScriptController::selectionRangeViewRects const):
4016         (WTR::UIScriptController::platformSetDidShowMenuCallback):
4017         (WTR::UIScriptController::platformSetDidHideMenuCallback):
4018
4019         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
4020
4021         (WTR::UIScriptController::rectForMenuAction const):
4022
4023         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
4024         callout bar) whose label matches the given string.
4025
4026         (WTR::UIScriptController::platformContentView const):
4027
4028         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
4029         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
4030         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
4031
4032         (WTR::UIScriptController::platformUndoManager const): Deleted.
4033         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4034         (WTR::UIScriptController::platformContentView const):
4035         (WTR::UIScriptController::platformUndoManager const): Deleted.
4036
4037 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
4038
4039         webkitpy: No option to only show unexpected failures in results.html for iPad
4040         https://bugs.webkit.org/show_bug.cgi?id=194554
4041         <rdar://problem/47922442>
4042
4043         Rubber-stamped by Aakash Jain.
4044
4045         Just because a TestExpecations file does not exist for a specific platform does not mean that
4046         TestExpecations are not being used, given that platforms inherit test expectations.
4047
4048         * Scripts/webkitpy/port/base.py:
4049         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
4050         * Scripts/webkitpy/port/base_unittest.py:
4051         (PortTest.test_uses_test_expectations_file):
4052
4053 2019-02-12  Alex Christensen  <achristensen@webkit.org>
4054
4055         Remove setDefersLoading infrastructure from WebKit2
4056         https://bugs.webkit.org/show_bug.cgi?id=194506
4057
4058         Reviewed by Brady Eidson.
4059
4060         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4061         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4062         (WTR::TestRunner::setDefersLoading): Deleted.
4063         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4064
4065 2019-02-12  Alex Christensen  <achristensen@webkit.org>
4066
4067         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
4068         https://bugs.webkit.org/show_bug.cgi?id=194522
4069         <rdar://problem/47789393>
4070
4071         Reviewed by Chris Dumez.
4072
4073         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4074         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
4075         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4076         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4077
4078 2019-02-12  Andy Estes  <aestes@apple.com>
4079
4080         [iOSMac] Enable Parental Controls Content Filtering
4081         https://bugs.webkit.org/show_bug.cgi?id=194521
4082         <rdar://39732376>
4083
4084         Reviewed by Tim Horton.
4085
4086         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4087
4088 2019-02-12  Zalan Bujtas  <zalan@apple.com>
4089
4090         [LFC][IFC] Add intrinsic width support for float boxes.
4091         https://bugs.webkit.org/show_bug.cgi?id=194528
4092
4093         Reviewed by Antti Koivisto.
4094
4095         Expand tests coverage (2 new tests -> 800).
4096         (This is the correct test ordering --runs-singly --child-processes=1)
4097
4098         * LayoutReloaded/misc/LFC-passing-tests.txt:
4099
4100 2019-02-12  Rob Buis  <rbuis@igalia.com>
4101
4102         Implement serializing in MIME type parser
4103         https://bugs.webkit.org/show_bug.cgi?id=193909
4104
4105         Reviewed by Darin Adler.
4106
4107         Add various tests involving upper case, non-ASCII, control/null characters,
4108         various HTTP whitespace, single quotes and an unpaired surrogate.
4109
4110         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4111         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
4112         (TestWebKitAPI::serializeIfValid):
4113         (TestWebKitAPI::TEST):
4114
4115 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
4116
4117         [Cocoa] Ask platform for generic font family mappings
4118         https://bugs.webkit.org/show_bug.cgi?id=187723
4119         <rdar://problem/41892438>
4120
4121         Reviewed by Brent Fulgham.
4122
4123         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
4124
4125         * DumpRenderTree/mac/DumpRenderTree.mm:
4126         (allowedFontFamilySet):
4127         * WebKitTestRunner/mac/TestControllerMac.mm:
4128         (WTR::allowedFontFamilySet):
4129
4130 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
4131
4132         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
4133         https://bugs.webkit.org/show_bug.cgi?id=193622
4134
4135         Reviewed by Michael Catanzaro.
4136
4137         This adds support for loading content extension rule sets from the JSON files which
4138         accompany the corresponding layout test, using the C API. The Cocoa specific parts
4139         of WKTR for this could be removed, but that is left for a follow-up patch with
4140         cleanups.
4141
4142         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
4143         * WebKitTestRunner/TestController.cpp:
4144         (WTR::testPath): Subtract one from the length when constructing the result std::string to
4145         avoid having the null-terminator copied into the result.
4146         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
4147         part of the preparations to run a test.
4148         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
4149         (WTR::contentExtensionStoreCallback): Added.
4150         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
4151         used for content extensions test.
4152         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
4153         extensions and compiling the JSON rule set for tests involving content extensions.
4154         (WTR::TestController::resetContentExtensions): Removes the content extension built for
4155         testing and disables content extensions.
4156         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
4157         resetContentExtensions().
4158         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
4159         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
4160         configureContentExtensionForTest(), and userContentController().
4161
4162 2019-02-11  Daniel Bates  <dabates@apple.com>
4163
4164         [iOS] Mouse/Touch/Pointer events are missing modifier keys
4165         https://bugs.webkit.org/show_bug.cgi?id=191446
4166         <rdar://problem/45929460>
4167
4168         Reviewed by Tim Horton.
4169
4170         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
4171
4172         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4173         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4174         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4175         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4176         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4177         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4178         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4179         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4180         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4181         (WTR::arrayLength):
4182         (WTR::parseModifierArray):
4183         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
4184         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4185         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
4186         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4187
4188 2019-02-11  Commit Queue  <commit-queue@webkit.org>
4189
4190         Unreviewed, rolling out r241272 and r241276.
4191         https://bugs.webkit.org/show_bug.cgi?id=194514
4192
4193         Broke the Apple Internal build and the fix requires human
4194         intervention :( (Requested by dydz on #webkit).
4195
4196         Reverted changesets:
4197
4198         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
4199         https://bugs.webkit.org/show_bug.cgi?id=191446
4200         https://trac.webkit.org/changeset/241272
4201
4202         "Fix internal iOS build after r241272"
4203         https://bugs.webkit.org/show_bug.cgi?id=191446
4204         https://trac.webkit.org/changeset/241276
4205
4206 2019-02-11  Truitt Savell  <tsavell@apple.com>
4207
4208         Unreviewed, rolling out r241269.
4209
4210         Caused 5 layout tests crashes on Mac WK1
4211
4212         Reverted changeset:
4213
4214         "DumpRenderTree should report unknown options"
4215         https://bugs.webkit.org/show_bug.cgi?id=191303
4216         https://trac.webkit.org/changeset/241269
4217
4218 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4219
4220         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
4221         https://bugs.webkit.org/show_bug.cgi?id=194313
4222
4223         Reviewed by Tim Horton.
4224
4225         Add a helper to determine whether the web view is presenting modal UI.
4226
4227         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4228         (WTR::UIScriptController::isPresentingModally const):
4229         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4230         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4231         (WTR::UIScriptController::isPresentingModally const):
4232         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4233         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4234         (WTR::UIScriptController::calendarType const): Deleted.
4235         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4236         (WTR::UIScriptController::isPresentingModally const):
4237         (WTR::UIScriptController::calendarType const):
4238         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4239         (WTR::UIScriptController::calendarType const):
4240
4241 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
4242
4243         GCHeapInspector: Show the retained sizes in more places
4244         https://bugs.webkit.org/show_bug.cgi?id=194464
4245
4246         Reviewed by Simon Fraser.
4247
4248         * GCHeapInspector/gc-heap-inspector.html:
4249         * GCHeapInspector/script/interface.js:
4250         (HeapInspectorUtils.humanReadableSize):
4251         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
4252         (HeapInspectorUtils.spanForNode.span.span):
4253         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
4254         (HeapSnapshotInspector.prototype.buildRoots):
4255
4256 2019-02-11  Daniel Bates  <dabates@apple.com>
4257
4258         [iOS] Mouse/Touch/Pointer events are missing modifier keys
4259         https://bugs.webkit.org/show_bug.cgi?id=191446
4260         <rdar://problem/45929460>
4261
4262         Reviewed by Tim Horton.
4263
4264         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
4265
4266         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4267         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4268         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4269         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4270         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4271         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4272         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4273         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4274         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4275         (WTR::arrayLength):
4276         (WTR::parseModifierArray):
4277         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
4278         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
4279         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
4280         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
4281
4282 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
4283
4284         DumpRenderTree should report unknown options
4285         https://bugs.webkit.org/show_bug.cgi?id=191303
4286
4287         Reviewed by Frédéric Wang.
4288
4289         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
4290         to report unknown options.
4291         Added and assigned test options which are currently used in tests.
4292
4293         * DumpRenderTree/TestOptions.cpp:
4294         (TestOptions::TestOptions):
4295
4296 2019-02-11  Truitt Savell  <tsavell@apple.com>
4297
4298         Unreviewed, rolling out r241229.
4299
4300         Revision broke internal builds for watchOS.
4301
4302         Reverted changeset:
4303
4304         "[Cocoa] Ask platform for generic font family mappings"
4305         https://bugs.webkit.org/show_bug.cgi?id=187723
4306         https://trac.webkit.org/changeset/241229
4307
4308 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
4309
4310         [WinCairo][MiniBrowser] Basic authentication always fails.
4311         https://bugs.webkit.org/show_bug.cgi?id=194496
4312
4313         Reviewed by Don Olmstead.
4314
4315         * MiniBrowser/win/DialogHelper.h:
4316         (Dialog::getText):
4317
4318 2019-02-11  Philippe Normand  <pnormand@igalia.com>
4319
4320         [GStreamer] GstMappedBuffer testsuite build fails
4321         https://bugs.webkit.org/show_bug.cgi?id=194495
4322
4323         Reviewed by Carlos Garcia Campos.
4324
4325         Fix the build by explicitely adding the gstreamer1.0-audio include
4326         directories to the include path.
4327
4328         * TestWebKitAPI/PlatformGTK.cmake:
4329         * TestWebKitAPI/PlatformWPE.cmake:
4330
4331 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4332
4333         [GTK][WPE] Add enable-javascript-markup setting
4334         https://bugs.webkit.org/show_bug.cgi?id=193439
4335
4336         Reviewed by Michael Catanzaro.
4337
4338         Add test cases to check the new setting.
4339
4340         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
4341         (testWebKitSettings):
4342         (testWebKitSettingsJavaScriptMarkup):
4343         (beforeAll):
4344
4345 2019-02-10  Darin Adler  <darin@apple.com>
4346
4347         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
4348         https://bugs.webkit.org/show_bug.cgi?id=194485
4349
4350         Reviewed by Daniel Bates.
4351
4352         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
4353
4354 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
4355
4356         Add more tests for clampTo<>()
4357         https://bugs.webkit.org/show_bug.cgi?id=194462
4358
4359         Reviewed by Geoffrey Garen.
4360
4361         Darin suggested to test the very last floating point number
4362         at the boundaries when truncating to integer.
4363         I added test for max/min and max-1/min-1.
4364
4365         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
4366         (TestWebKitAPI::TEST):
4367
4368 2019-02-09  Darin Adler  <darin@apple.com>
4369
4370         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
4371         https://bugs.webkit.org/show_bug.cgi?id=194021
4372
4373