Build libwebrtc on bots without using it yet
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-09  Alex Christensen  <achristensen@webkit.org>
2
3         Build libwebrtc on bots without using it yet
4         https://bugs.webkit.org/show_bug.cgi?id=168062
5
6         Reviewed by Brent Fulgham.
7
8         * Scripts/build-webkit:
9
10 2017-02-09  Alex Christensen  <achristensen@webkit.org>
11
12         Don't build libwebrtc.
13
14         * Scripts/build-webkit:
15         Not ready yet.  It broke El Capitan and iOS.
16
17 2017-02-09  Alex Christensen  <achristensen@webkit.org>
18
19         Build libwebrtc on bots without using it yet
20         https://bugs.webkit.org/show_bug.cgi?id=168062
21
22         Reviewed by Brent Fulgham.
23
24         * Scripts/build-webkit:
25
26 2017-02-09  Alex Christensen  <achristensen@webkit.org>
27
28         Rename isAppleMacWebKit to isAppleCocoaWebKit
29         https://bugs.webkit.org/show_bug.cgi?id=168075
30
31         Reviewed by Geoffrey Garen.
32
33         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
34
35         * Scripts/build-api-tests:
36         * Scripts/build-dumprendertree:
37         * Scripts/build-jsc:
38         (buildMyProject):
39         * Scripts/build-layouttestrelay:
40         * Scripts/build-webkit:
41         * Scripts/build-webkittestrunner:
42         * Scripts/run-api-tests:
43         (isSupportedPlatform):
44         (runTest):
45         (listAllTests):
46         (prepareEnvironmentForRunningTestTool):
47         * Scripts/run-content-extension-tester:
48         * Scripts/run-javascriptcore-tests:
49         * Scripts/run-minibrowser:
50         * Scripts/show-pretty-diff:
51         * Scripts/webkitdirs.pm:
52         (determineBaseProductDir):
53         (determineArchitecture):
54         (determinePassedArchitecture):
55         (safariPath):
56         (builtDylibPathForName):
57         (checkFrameworks):
58         (isAppleWebKit):
59         (isAppleCocoaWebKit):
60         (determineNmPath):
61         (launcherName):
62         (wrapperPrefixIfNeeded):
63         (isCMakeBuild):
64         (mobileSafariBundle):
65         (debugSafari):
66         (runSafari):
67         (runMiniBrowser):
68         (debugMiniBrowser):
69         (runWebKitTestRunner):
70         (debugWebKitTestRunner):
71         (isAppleMacWebKit): Deleted.
72         * Scripts/webkitperl/FeatureList.pm:
73
74 2017-02-09  Alex Christensen  <achristensen@webkit.org>
75
76         Revert r211991
77         https://bugs.webkit.org/show_bug.cgi?id=168062
78
79         * Scripts/build-webkit:
80         Not quite ready yet.
81
82 2017-02-09  Alex Christensen  <achristensen@webkit.org>
83
84         Build libwebrtc on bots without using it yet
85         https://bugs.webkit.org/show_bug.cgi?id=168062
86
87         Reviewed by Brent Fulgham.
88
89         * Scripts/build-webkit:
90         Build libwebrtc on Mac when we build ANGLE.
91
92 2017-02-09  Youenn Fablet  <youenn@apple.com>
93
94         Improve W3C importer command line options
95         https://bugs.webkit.org/show_bug.cgi?id=167448
96
97         Reviewed by Ryosuke Niwa.
98
99         Making the list of test paths to import the main arguments of the script.
100         Allow passing the source directory to import as a -s option.
101         Adding a warning when given test paths are skipped by default in ImportExpectations.
102
103         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
104         Link conversion rules do not change when imported tests are downloaded by the script.
105
106         * Scripts/webkitpy/w3c/test_importer.py:
107         (main):
108         (parse_args):
109         (TestImporter.__init__):
110         (TestImporter.do_import):
111         (TestImporter):
112         (TestImporter.check_imported_expectations):
113
114 2017-02-08  Chris Dumez  <cdumez@apple.com>
115
116         Update web-platform-tests resources
117         https://bugs.webkit.org/show_bug.cgi?id=168026
118
119         Reviewed by Youenn Fablet.
120
121         Stop copying testharness.js from resources/ to web-platform-tests/resources.
122
123         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
124         (WebPlatformTestServer._copy_webkit_test_files):
125
126 2017-02-08  Andy Estes  <aestes@apple.com>
127
128         Custom protocols should not continue loading after a network process crash
129         https://bugs.webkit.org/show_bug.cgi?id=168028
130         <rdar://problem/27607520>
131
132         Reviewed by Brady Eidson.
133
134         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
135         (processGroup):
136         (-[CloseWhileStartingProtocol startLoading]):
137         (-[CloseWhileStartingProtocol stopLoading]):
138         (TestWebKitAPI::runTest):
139         (TestWebKitAPI::TEST):
140
141 2017-02-08  Dan Bernstein  <mitz@apple.com>
142
143         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
144         https://bugs.webkit.org/show_bug.cgi?id=168031
145
146         Reviewed by Tim Horton.
147
148         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
149         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
150         (TEST):
151         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
152         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
153
154 2017-02-08  Chris Dumez  <cdumez@apple.com>
155
156         Use smaller tiles in windows that are not active to facilitate App Napping
157         https://bugs.webkit.org/show_bug.cgi?id=167997
158         <rdar://problem/30358835>
159
160         Reviewed by Simon Fraser.
161
162         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
163         (WTR::PlatformWebView::setWindowIsKey):
164         Actually update windowIsKey state of NSWindow so the WebView
165         properly updates its activity state.
166
167 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
168
169         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
170         https://bugs.webkit.org/show_bug.cgi?id=167942
171         <rdar://problem/30315079>
172
173         Reviewed by Tim Horton.
174
175         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
176         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
177         contenteditable in these cases.
178
179         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
180         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
181         performDragOperation:) directly.
182
183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
184         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
185         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
186         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
187         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
188         (-[DragSource draggingSourceOperationMaskForLocal:]):
189         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
190         (-[DragInfo lastMousePosition]):
191         (-[DragInfo setLastMousePosition:]):
192         (-[DragInfo draggingDestinationWindow]):
193         (-[DragInfo draggingSourceOperationMask]):
194         (-[DragInfo draggingLocation]):
195         (-[DragInfo draggedImageLocation]):
196         (-[DragInfo draggedImage]):
197         (-[DragInfo draggingPasteboard]):
198         (-[DragInfo draggingSource]):
199         (-[DragInfo draggingSequenceNumber]):
200         (-[DragInfo slideDraggedImageTo:]):
201         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
202         (-[DragInfo draggingFormation]):
203         (-[DragInfo setDraggingFormation:]):
204         (-[DragInfo animatesToDestination]):
205         (-[DragInfo setAnimatesToDestination:]):
206         (-[DragInfo numberOfValidItemsForDrop]):
207         (-[DragInfo setNumberOfValidItemsForDrop:]):
208         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
209         (-[DragInfo springLoadingHighlight]):
210         (-[DragInfo resetSpringLoading]):
211         (TestWebKitAPI::getTestImage):
212         (TestWebKitAPI::webViewAfterPerformingDragOperation):
213         (TestWebKitAPI::TEST):
214         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
215
216 2017-02-08  Jer Noble  <jer.noble@apple.com>
217
218         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
219         https://bugs.webkit.org/show_bug.cgi?id=168007
220
221         Reviewed by Alex Christensen.
222
223         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
224         (didFinishLoadForFrame):
225         (TestWebKitAPI::TEST):
226
227 2017-02-08  Commit Queue  <commit-queue@webkit.org>
228
229         Unreviewed, rolling out r211873.
230         https://bugs.webkit.org/show_bug.cgi?id=168001
231
232         It's in jhbuild for consistent layout tests (Requested by
233         mcatanzaro on #webkit).
234
235         Reverted changeset:
236
237         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
238         https://bugs.webkit.org/show_bug.cgi?id=167993
239         http://trac.webkit.org/changeset/211873
240
241 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
242
243         [GTK] Add icu packages to Tools/gtk/install-dependencies
244         https://bugs.webkit.org/show_bug.cgi?id=167993
245
246         Reviewed by Michael Catanzaro.
247
248         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
249         depending in the GNU/Linux distribution)
250
251 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
252
253         Update flakiness dashboard configuration.
254         https://bugs.webkit.org/show_bug.cgi?id=167957
255
256         Reviewed by Alexey Proskuryakov.
257
258         * TestResultServer/static-dashboards/builders.jsonp:
259
260 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
261
262         Replace a bot that has an incorrect configuration.
263         https://bugs.webkit.org/show_bug.cgi?id=167747
264
265         Rubber-stamped by Alexey Proskuryakov.
266
267         * BuildSlaveSupport/build.webkit.org-config/config.json:
268
269 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
270
271         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
272         https://bugs.webkit.org/show_bug.cgi?id=167927
273
274         Reviewed by Brent Fulgham.
275
276         Enable ComplexTextController API tests on the Win and GTK ports.
277
278         * TestWebKitAPI/PlatformGTK.cmake:
279         * TestWebKitAPI/PlatformWin.cmake:
280
281 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
282
283         File index appended to previous file in svn-create-patch with SVN 1.9
284         https://bugs.webkit.org/show_bug.cgi?id=167903
285         <rdar://problem/30387395>
286
287         Reviewed by Daniel Bates.
288
289         * Scripts/VCSUtils.pm:
290         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
291         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
292         trailing newline character from the expected result before comparing it to the actual result.
293
294 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
295
296         [webkitdirs] remove unused host_processor variable in determineArchitecture()
297         https://bugs.webkit.org/show_bug.cgi?id=167936
298
299         Reviewed by Michael Catanzaro.
300
301         * Scripts/webkitdirs.pm:
302         (determineArchitecture):
303         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
304         since r195083.
305
306 2017-02-07  Youenn Fablet  <youenn@apple.com>
307
308         Use a JSON file to define which WPT files/folders to import
309         https://bugs.webkit.org/show_bug.cgi?id=167923
310
311         Reviewed by Alex Christensen.
312
313         * Scripts/webkitpy/w3c/test_downloader.py:
314         (TestDownloader.__init__):
315         (TestDownloader._init_paths_from_expectations):
316         * Scripts/webkitpy/w3c/test_importer.py:
317         (parse_args):
318         * Scripts/webkitpy/w3c/test_importer_unittest.py:
319
320 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
321
322         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
323         https://bugs.webkit.org/show_bug.cgi?id=167916
324
325         Reviewed by Carlos Garcia Campos.
326
327         URL of mesa-11.0.6.tar.xz has been moved.
328
329         * gtk/jhbuild.modules: Fix the module path.
330
331 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
332
333         Static Analyzer: Address some leaks in MiniBrowser
334         https://bugs.webkit.org/show_bug.cgi?id=167897
335
336         Reviewed by Alexey Proskuryakov.
337
338         * MiniBrowser/mac/BrowserWindowController.m:
339         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
340         * MiniBrowser/mac/ExtensionManagerWindowController.m:
341         (-[ExtensionManagerWindowController add:]):
342         (-[ExtensionManagerWindowController remove:]):
343         * MiniBrowser/mac/SettingsController.m:
344         (-[SettingsController _populateMenu]):
345         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
346         Address obvious leaks caught by the static analyzer.
347
348 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
349
350         Migrate ComplexTextController to use platform-independent types
351         https://bugs.webkit.org/show_bug.cgi?id=167833
352
353         Reviewed by Brent Fulgham.
354
355         Migrate tests away from platform-dependent types.
356
357         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
358         (TestWebKitAPI::TEST_F):
359
360 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
361
362         Correct File Path Handling in SecurityOrigin and FileSystem
363         https://bugs.webkit.org/show_bug.cgi?id=167894
364         <rdar://problem/30380080>
365
366         Reviewed by Alexey Proskuryakov.
367
368         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
369         and perform same-volume checks using filesystem-compatible paths.        
370         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
371         filesystem paths, and perform validation of same-volume checks.
372         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
373         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
374         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
375         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
376
377 2017-02-06  Jer Noble  <jer.noble@apple.com>
378
379         Playback stalls when a SourceBuffer append causes frame eviction
380         https://bugs.webkit.org/show_bug.cgi?id=167834
381
382         Reviewed by Eric Carlson.
383
384         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
385         for the WTF::MediaTime class.
386
387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
388         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
389         (TestWebKitAPI::TEST):
390         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
391         (WTF::operator<<):
392         (TestWebKitAPI::TestSample::create):
393         (TestWebKitAPI::TestSample::TestSample):
394         (TestWebKitAPI::TEST_F):
395
396 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
397
398         Change capitalization in platform name after r211735.
399
400         Unreviewed dashboard fix.
401
402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
403         (WebKitBuildbot):
404
405 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
406
407         Move the Leaks bot to Sierra
408         https://bugs.webkit.org/show_bug.cgi?id=167886
409
410         Reviewed by Daniel Bates.
411
412         * BuildSlaveSupport/build.webkit.org-config/config.json:
413         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
414         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
415         (LeaksViewer._displayURLPrompt):
416         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
417         (WebKitBuildbot):
418
419 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
420
421         Prevent app crash on launch during simctl install workaround
422         https://bugs.webkit.org/show_bug.cgi?id=167685
423
424         Reviewed by Daniel Bates.
425
426         * Scripts/webkitpy/port/simulator_process.py:
427         (SimulatorProcess.__init__): Pass environment to install.
428         * Scripts/webkitpy/xcode/simulator.py:
429         (Device.install_app): Accept environment, pass environment to launch.
430
431 2017-02-06  Alex Christensen  <achristensen@webkit.org>
432
433         Rebase API tests after r211638
434         https://bugs.webkit.org/show_bug.cgi?id=167779
435
436         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
437         (TestWebKitAPI::TEST_F):
438         URLs with non-special schemes and characters like % in the host now fail to parse,
439         more like their special counterparts and according to spec.
440
441 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
442
443         Unreviewed trivial fix after r211697.
444         https://bugs.webkit.org/show_bug.cgi?id=167863
445
446         * Scripts/run-javascriptcore-tests:
447         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
448
449 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
450
451         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
452         https://bugs.webkit.org/show_bug.cgi?id=167850
453
454         Reviewed by Tim Horton.
455
456         * DumpRenderTree/TestRunner.cpp:
457         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
458
459 2017-02-04  Andreas Kling  <akling@apple.com>
460
461         Plug some leaks in TestController and UIScriptContext.
462         <https://webkit.org/b/167839>
463
464         Reviewed by Alexey Proskuryakov.
465
466         Fix a couple of the leaks seen on the leaks bot.
467
468         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
469         (UIScriptContext::runUIScript):
470         * WebKitTestRunner/TestController.cpp:
471         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
472         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
473
474 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
475
476         WK1 mouse events are missing movementX and movementY for pointerlock.
477         https://bugs.webkit.org/show_bug.cgi?id=167775
478         rdar://problem/30343810
479
480         Reviewed by Alexey Proskuryakov.
481
482         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
483
484         * DumpRenderTree/mac/EventSendingController.mm:
485         (-[EventSendingController mouseMoveToX:Y:]):
486         * WebKitTestRunner/mac/EventSenderProxy.mm:
487         (WTR::EventSenderProxy::mouseMoveTo):
488
489 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
490
491         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
492         https://bugs.webkit.org/show_bug.cgi?id=167774
493
494         Reviewed by Tim Horton.
495
496         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
497         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
498         web process are async, so the callback fires after the web process gets the new state.
499
500         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
501         (WTR::UIScriptController::removeViewFromWindow):
502         (WTR::UIScriptController::addViewToWindow):
503         * DumpRenderTree/mac/DumpRenderTree.mm:
504         (createWebViewAndOffscreenWindow):
505         (resetWebViewToConsistentStateBeforeTesting):
506         * DumpRenderTree/mac/DumpRenderTreeMac.h:
507         * DumpRenderTree/mac/UIScriptControllerMac.mm:
508         (WTR::UIScriptController::removeViewFromWindow):
509         (WTR::UIScriptController::addViewToWindow):
510         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
511         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
512         (WTR::UIScriptController::removeViewFromWindow):
513         (WTR::UIScriptController::addViewToWindow):
514         * TestRunnerShared/UIScriptContext/UIScriptController.h:
515         * WebKitTestRunner/PlatformWebView.h:
516         * WebKitTestRunner/TestController.cpp:
517         (WTR::TestController::resetStateToConsistentValues):
518         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
519         (WTR::PlatformWebView::removeFromWindow):
520         (WTR::PlatformWebView::addToWindow):
521         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
522         (WTR::UIScriptController::removeViewFromWindow):
523         (WTR::UIScriptController::addViewToWindow):
524         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
525         (WTR::PlatformWebView::removeFromWindow):
526         (WTR::PlatformWebView::addToWindow):
527         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
528         (WTR::UIScriptController::removeViewFromWindow):
529         (WTR::UIScriptController::addViewToWindow):
530
531 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
532
533         Remove check for SkipSafariExecutableEntitlementChecks
534         https://bugs.webkit.org/show_bug.cgi?id=167762
535
536         Reviewed by Dan Bernstein.
537
538         Follow-up fix: don't break internal behavior.
539
540         * Scripts/webkitdirs.pm:
541         (safariPath):
542         (executableHasEntitlements): Deleted.
543         (safariPathFromSafariBundle): Deleted.
544         (installedSafariPath): Deleted.
545
546 2017-02-03  Daniel Bates  <dabates@apple.com>
547
548         [Mac][WK2] Add SPI to override the Content Security Policy of a page
549         https://bugs.webkit.org/show_bug.cgi?id=167810
550         <rdar://problem/30102568>
551
552         Reviewed by Anders Carlsson.
553
554         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
555
556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
557         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
558         (TEST):
559         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
560         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
561         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
562         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
563
564 2017-02-02  Alex Christensen  <achristensen@webkit.org>
565
566         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
567         https://bugs.webkit.org/show_bug.cgi?id=167773
568         <rdar://problem/30221102>
569
570         Reviewed by Ryosuke Niwa.
571
572         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
573         (TestWebKitAPI::TEST_F):
574
575 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
576
577         Remove check for SkipSafariExecutableEntitlementChecks
578         https://bugs.webkit.org/show_bug.cgi?id=167762
579         rdar://problem/22480673
580
581         Reviewed by Dan Bernstein.
582
583         * Scripts/webkitdirs.pm:
584         (safariPathFromSafariBundle):
585         (skipSafariExecutableEntitlementChecks): Deleted.
586
587 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
588
589         Undefined subroutine in svn-create-patch
590         https://bugs.webkit.org/show_bug.cgi?id=167742
591
592         Unreviewed build-fix after r211543.
593
594         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
595
596 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
597
598         Unreviewed. Fix jhbuild dependencies build.
599
600         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
601         Patch updated.
602
603 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
604
605         [EME][GStreamer] Fixed decryptor selection
606         https://bugs.webkit.org/show_bug.cgi?id=167588
607
608         Reviewed by Žan Doberšek.
609
610         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
611
612         * gtk/jhbuild.modules: Added patches to gstreamer and
613         gst-plugins-good packages.
614         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
615         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
616
617 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
618
619         Make run-benchmark script supports 'config' key in test plan.
620         https://bugs.webkit.org/show_bug.cgi?id=167715
621
622         Reviewed by Ryosuke Niwa.
623
624         Add support for 'config' key in test paln.
625         'config' key is a dictionary that specifies environment configurations while test is running.
626         Specifies orientation to be portrait in MotionMark benchmark.
627
628         * Scripts/webkitpy/benchmark_runner/README.md:
629         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
630         (BenchmarkRunner.__init__):
631         (BenchmarkRunner._run_benchmark):
632         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
633         (BrowserDriver.prepare_env):
634         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
635         (LinuxBrowserDriver.prepare_env):
636         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
637         (OSXBrowserDriver.prepare_env):
638         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
639         (OSXSafariDriver.prepare_env):
640         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
641
642 2017-02-01  Daniel Bates  <dabates@apple.com>
643
644         REGRESSION (r210820): svn-create-patch does not emit property change only diff
645         https://bugs.webkit.org/show_bug.cgi?id=167169
646
647         Reviewed by David Kilzer.
648
649         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
650         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
651         header from the output of "svn diff" on a file that was copied or moved.
652
653         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
654         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
655         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
656         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
657         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
658         of a file with only a property change also does not contain any chunk range lines. Therefore
659         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
660         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
661         we should directly test for the presence of a leading SVN diff header with an empty body and
662         remove such lines from the diff.
663
664         * Scripts/VCSUtils.pm:
665         (fixSVNPatchForAdditionWithHistory): Added.
666         * Scripts/svn-create-patch:
667         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
668         we have a non empty patch for an added file with history (i.e. a copied or moved file).
669         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
670
671 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
672
673         [Mac] Update CARingBuffer class
674         https://bugs.webkit.org/show_bug.cgi?id=167656
675
676         Reviewed by Jer Noble.
677
678         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
679         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
680         (TestWebKitAPI::CARingBufferTest::SetUp):
681         (TestWebKitAPI::CARingBufferTest::setup):
682         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
683         (TestWebKitAPI::CARingBufferTest::description):
684         (TestWebKitAPI::CARingBufferTest::bufferList):
685         (TestWebKitAPI::CARingBufferTest::ringBuffer):
686         (TestWebKitAPI::CARingBufferTest::capacity):
687         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
688         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
689         (TestWebKitAPI::TEST_F):
690         (TestWebKitAPI::MixingTest::run):
691
692 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
693
694         [Mac] TestWebKitAPI includes system frameworks incorrectly
695         https://bugs.webkit.org/show_bug.cgi?id=167703
696         rdar://problem/30301498
697
698         Reviewed by Ryosuke Niwa.
699
700         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
701         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
702
703         Also, reduced the number of subframework search paths, looks like we only need one now.
704
705         * TestWebKitAPI/Configurations/Base.xcconfig:
706
707 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
708
709         Correct "filesHaveSameVolume" predicate
710         https://bugs.webkit.org/show_bug.cgi?id=167696
711         <rdar://problem/30298722>
712
713         Reviewed by David Kilzer.
714
715         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
716         percent-escaped path inputs.
717
718         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
719         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
720         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
721         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
722         (TestWebKitAPI::TEST_F):
723
724 2017-02-01  Tomas Popela  <tpopela@redhat.com>
725
726         Unreviewed. Fix coding style in MiniBrowser
727
728         * MiniBrowser/gtk/BrowserWindow.c:
729         (editingCommandCallback):
730         (insertImageCommandCallback):
731         (insertLinkCommandCallback):
732
733 2017-02-01  Tomas Popela  <tpopela@redhat.com>
734
735         [GTK] Add an API to add a custom tab into the print dialog
736         https://bugs.webkit.org/show_bug.cgi?id=151998
737
738         Reviewed by Carlos Garcia Campos.
739
740         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
741         that is testing a newly added API.
742
743         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
744         (testPrintCustomWidget):
745         (beforeAll):
746
747 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
748
749         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
750         https://bugs.webkit.org/show_bug.cgi?id=166529
751
752         Reviewed by Xabier Rodriguez-Calvar.
753
754         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
755         New patch version accepted in GStreamer upstream.
756
757 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
758
759         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
760         https://bugs.webkit.org/show_bug.cgi?id=167498
761
762         Reviewed by Carlos Garcia Campos.
763
764         Depending on the distro version you can need either libxfont1-dev
765         or libfont-dev to build with jhbuild.
766
767         * gtk/install-dependencies:
768
769 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
770
771         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
772         https://bugs.webkit.org/show_bug.cgi?id=167594
773
774         Unreviewed test gardening.
775
776         Disabling this test while we investigate the cause of a timeout on ios-simulator.
777
778         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
779         (TEST):
780
781 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
782
783         Move slow-running microbenchmarks out of JSTests/microbenchmarks
784         https://bugs.webkit.org/show_bug.cgi?id=167676
785
786         Reviewed by Saam Barati.
787
788         * Scripts/run-javascriptcore-tests:
789         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
790
791 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
792
793         Make Dump Render Tree not crash
794         https://bugs.webkit.org/show_bug.cgi?id=167667
795
796         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
797         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
798         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
799         This does not fix any tests, it just fixes the crash.
800         
801         Reviewed by Simon Fraser.
802
803         * DumpRenderTree/TestRunner.cpp:
804         (TestRunner::callUIScriptCallback):
805
806 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
807
808         Workaround for simctl install failing to report install failure
809         https://bugs.webkit.org/show_bug.cgi?id=167654
810
811         Reviewed by Daniel Bates.
812
813         simctl install will sometimes report success even though install has failed.
814         To workaround this bug, we attempt an app launch after install to ensure
815         install has succeeded.
816
817         * Scripts/webkitpy/xcode/simulator.py:
818         (Device.install_app): Attempt app launch after install, retry install if launch fails.
819         (Device.launch_app): Correct comment.
820
821 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
822
823         Unreviewed webkitpy fix after r211405.
824
825         * Scripts/webkitpy/xcode/simulator.py:
826         (Device.launch_app): Remove @staticmethod on _log_debug_error.
827
828 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
829
830         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
831
832         * gtk/manifest.txt.in:
833
834 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
835
836         AX: enable search predication for iOS
837         https://bugs.webkit.org/show_bug.cgi?id=167558
838         <rdar://problem/30251367>
839
840         Reviewed by Joanmarie Diggs.
841
842         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
843         (AccessibilityUIElement::uiElementForSearchPredicate):
844         * DumpRenderTree/mac/AccessibilityCommonMac.h:
845         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
846         (searchPredicateParameterizedAttributeForSearchCriteria):
847         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
848         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
849         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
850         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
851         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
852         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
853         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
854         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
855         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
856         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
857         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
858
859 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
860
861         Workaround for simctl launch bug
862         https://bugs.webkit.org/show_bug.cgi?id=167613
863
864         Reviewed by Daniel Bates.
865
866         simctl launch will sometimes fail because of a race condition when many
867         simulators are being run simultaneously. These failures will always have
868         an exit code of 1. This change attempts to launch an app multiple times
869         before reporting a failure to workaround this bug.
870
871         * Scripts/webkitpy/xcode/simulator.py:
872         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
873
874 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
875
876         Commit queue fails to look at real name aliases for the reviewer
877         https://bugs.webkit.org/show_bug.cgi?id=167422
878
879         Reviewed by Joseph Pecoraro.
880
881         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
882         (test_has_valid_reviewer): Added tests.
883
884         * Scripts/webkitpy/common/config/committers.py:
885         (CommitterList._name_to_contributor_map):
886         Made _name_to_contributor_map include alias names.
887
888         * Scripts/webkitpy/common/config/committers_unittest.py:
889         (CommittersTest.test_contributors_by_fuzzy_match):
890         Removed subtests that are now obsolete, as these matches are strict. It is not
891         obvious if distance based fuzzy matching for names is useful at all, but we can
892         look into that some other time.
893
894 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
895
896         QueueStatusServer should have an explicit timeout for _fetch_url
897         https://bugs.webkit.org/show_bug.cgi?id=167467
898
899         Reviewed by Alexey Proskuryakov.
900
901         * Scripts/webkitpy/common/net/statusserver.py:
902         (StatusServer._fetch_url): Add an explicit timeout of 300s.
903
904 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
905
906         Add support for Trac instances that host multiple projects.
907         https://bugs.webkit.org/show_bug.cgi?id=167524
908
909         Reviewed by Alexey Proskuryakov.
910
911         When multiple projects are hosted on a single Trac instance, the current
912         behavior will retrieve changesets from all tracked projects.
913         This patch teaches Trac.js to get project-specific changesets from Trac.
914         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
915         when querying the Trac timeline.
916
917         To tell Trac to be aware of multi-project instances we leverage the 
918         `options` parameter when creating a new instance: 
919
920             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
921
922         If this option is not provided, the original behaviour will prevail.
923         Additionally, add corresponding tests.
924
925         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
926         (Trac): Reason about new optional parameter 'projectIdentifier'.
927         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
928         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
929         replace default parameter `changeset=on` with `repo-projectname=on`.
930         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
931         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
932         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
933         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
934         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
935         Add the following tests:
936             test("revisionURL")
937             test("revisionURL with Trac Identifier")
938             test("_xmlTimelineURL")
939             test("_xmlTimelineURL with Trac Identifier")
940         (this.view._latestProductiveIteration): Fix missing ';'.
941
942 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
943
944         Correct spacing regression on inter-element complex path shaping on some fonts
945         https://bugs.webkit.org/show_bug.cgi?id=166013
946
947         Reviewed by Simon Fraser.
948
949         Unskip existing tests and make some new tests:
950         - Testing complex text with no origins
951         - Testing initial expansions
952         - Testing the sign of vertical advances
953
954         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
955         (TestWebKitAPI::TEST_F):
956
957 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
958
959         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
960         https://bugs.webkit.org/show_bug.cgi?id=167596
961
962         Reviewed by Daniel Bates.
963
964         We avoid needing a thin directory by invoking the zip program with
965         the list of directories from the build directory to be zipped,
966         and by using the zip feature to exclude files matching a pattern.
967
968         * BuildSlaveSupport/built-product-archive:
969         (copyBuildFiles):
970         (createZipFromList):
971         (archiveBuiltProduct):
972
973 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
974
975         Use simctl instead of LayoutTestRelay
976         https://bugs.webkit.org/show_bug.cgi?id=165927
977
978         Reviewed by Daniel Bates.
979
980         Part 1
981
982         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
983         simulators through simctl (iOS 10 and later), use this functionality instead.
984
985         * Scripts/webkitpy/port/base.py:
986         (Port.__init__): Added _test_runner_process_constructor.
987         * Scripts/webkitpy/port/darwin.py:
988         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
989         * Scripts/webkitpy/port/driver.py:
990         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
991         (IOSSimulatorDriver): Deleted.
992         * Scripts/webkitpy/port/driver_unittest.py:
993         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
994         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
995         (DriverTest.test_start_actually_starts): Ditto.
996         * Scripts/webkitpy/port/ios.py:
997         (IOSSimulatorPort): Remove relay_name.
998         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
999         (IOSSimulatorPort._create_simulators): Formatting change.
1000         (IOSSimulatorPort.relay_path): Deleted.
1001         (IOSSimulatorPort._check_relay): Deleted.
1002         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1003         (IOSSimulatorPort._build_relay): Deleted.
1004         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1005         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1006         * Scripts/webkitpy/port/ios_unittest.py:
1007         (iosTest.test_32bit): Update test.
1008         (iosTest.test_64bit): Update test.
1009         * Scripts/webkitpy/port/server_process.py:
1010         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1011         (ServerProcess._set_file_nonblocking): Added to share common code.
1012         * Scripts/webkitpy/port/server_process_mock.py:
1013         (MockServerProcess.__init__): Added argument worker_number.
1014         * Scripts/webkitpy/port/simulator_process.py: Added.
1015         (SimulatorProcess): Added.
1016         (SimulatorProcess.Popen): Added.
1017         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1018         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1019         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1020         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1021         (SimulatorProcess._reset): Added. Unlink fifos.
1022         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1023         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1024         * Scripts/webkitpy/xcode/simulator.py:
1025         (Device.__init__): Accept host to run install/launch/terminate.
1026         (Device.install_app): Install app to target Device.
1027         (Device.launch_app): Launch app on target Device.
1028         (Device.terminate_app): Shutdown app on target Device.
1029         (Simulator._parse_devices): Pass host to Device.
1030
1031 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1032
1033         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1034         https://bugs.webkit.org/show_bug.cgi?id=167411
1035
1036         Reviewed by Michael Catanzaro.
1037
1038         Disable the ARM iwMMXt fast path for pixman, because it triggers
1039         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1040
1041         * gtk/jhbuild.modules:
1042
1043 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1044
1045         [GTK] Add API to handle the accelerated compositing policy
1046         https://bugs.webkit.org/show_bug.cgi?id=167509
1047
1048         Reviewed by Michael Catanzaro.
1049
1050         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1051         as a special case. Also add test cases to the get/set API.
1052
1053         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1054         (hardwareAccelerationPolicyToString):
1055         (stringToHardwareAccelerationPolicy):
1056         (cellRendererChanged):
1057         (browserSettingsDialogConstructed):
1058         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1059         (testWebKitSettings):
1060
1061 2017-01-29  Andy Estes  <aestes@apple.com>
1062
1063         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1064         https://bugs.webkit.org/show_bug.cgi?id=167563
1065         <rdar://problem/30253207>
1066
1067         Reviewed by Andreas Kling.
1068
1069         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1070         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1071         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1072         (runTest):
1073         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1074         (TEST):
1075
1076 2017-01-29  Dan Bernstein  <mitz@apple.com>
1077
1078         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
1079         https://bugs.webkit.org/show_bug.cgi?id=167565
1080
1081         Reviewed by Sam Weinig.
1082
1083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1084         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
1085         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
1086         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
1087         (TEST):
1088         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
1089         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1090         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1091         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
1092
1093 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1094
1095         Add Link Preload as an off-by-default experimental feature menu item.
1096         https://bugs.webkit.org/show_bug.cgi?id=167201
1097
1098         Reviewed by Ryosuke Niwa.
1099
1100         * DumpRenderTree/mac/DumpRenderTree.mm:
1101         (resetWebPreferencesToConsistentValues):
1102         * DumpRenderTree/win/DumpRenderTree.cpp:
1103         (resetWebPreferencesToConsistentValues):
1104
1105 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1106
1107         Add User Timing Experimental Feature
1108         https://bugs.webkit.org/show_bug.cgi?id=167542
1109         <rdar://problem/22746307>
1110
1111         Reviewed by Ryosuke Niwa.
1112
1113         * DumpRenderTree/mac/DumpRenderTree.mm:
1114         (enableExperimentalFeatures):
1115         (resetWebPreferencesToConsistentValues):
1116         * DumpRenderTree/win/DumpRenderTree.cpp:
1117         (enableExperimentalFeatures):
1118
1119 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1120
1121         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
1122         https://bugs.webkit.org/show_bug.cgi?id=167519
1123
1124         Reviewed by Ryosuke Niwa.
1125
1126         * QueueStatusServer/templates/statusbubble.html:
1127         To measure the bubbleContainer's width, it must not be wrapping based
1128         on its parent container. So when measuring the width temporarily set
1129         the parent to a very large width so as to not artificially wrap us.
1130         Restore the parent's width after measuring.
1131
1132 2017-01-27  Andy Estes  <aestes@apple.com>
1133
1134         [iOS] Add a test for _WKNSFileManagerExtras
1135         https://bugs.webkit.org/show_bug.cgi?id=167478
1136
1137         Reviewed by Andreas Kling.
1138
1139         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1140         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
1141         (expectAttributes):
1142         (TEST):
1143
1144 2017-01-27  Keith Miller  <keith_miller@apple.com>
1145
1146         run-benchmarks should make sure it passes the test url to the right application
1147         https://bugs.webkit.org/show_bug.cgi?id=167533
1148
1149         Reviewed by Joseph Pecoraro.
1150
1151         This fixes an issue when trying to run-benchmark script with the
1152         system default browser set to STP. Previously, it would run
1153         the test in STP rather than the provided build. Now, it should run
1154         in the provided build.
1155
1156         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1157         (OSXSafariDriver.launch_url):
1158
1159 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1160
1161         [Cocoa] Prepare ComplexTextController for unit testing
1162         https://bugs.webkit.org/show_bug.cgi?id=167493
1163
1164         Reviewed by Simon Fraser.
1165
1166         Addressing post-review comments from Simon Fraser.
1167
1168         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1169         (TestWebKitAPI::TEST_F):
1170
1171 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1172
1173         [Cocoa] Prepare ComplexTextController for unit testing
1174         https://bugs.webkit.org/show_bug.cgi?id=167493
1175
1176         Reviewed by Dean Jackson.
1177
1178         Create four unit tests.
1179
1180         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1181         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
1182         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
1183         (TestWebKitAPI::TEST_F):
1184
1185 2017-01-26  Chris Dumez  <cdumez@apple.com>
1186
1187         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1188         https://bugs.webkit.org/show_bug.cgi?id=167421
1189         <rdar://problem/30188490>
1190
1191         Reviewed by Darin Adler.
1192
1193         Add a new setting allowing layout tests to enable PageCache in a window
1194         that has an opener, for convenience.
1195
1196         * DumpRenderTree/mac/DumpRenderTree.mm:
1197         (resetWebPreferencesToConsistentValues):
1198         * DumpRenderTree/win/DumpRenderTree.cpp:
1199         (resetWebPreferencesToConsistentValues):
1200         * WebKitTestRunner/TestController.cpp:
1201         (WTR::TestController::resetPreferencesToConsistentValues):
1202
1203 2017-01-26  Keith Miller  <keith_miller@apple.com>
1204
1205         classInfo should take a VM so it is not materialized from the object on each call
1206         https://bugs.webkit.org/show_bug.cgi?id=167424
1207
1208         Rubber Stamped by Michael Saboff.
1209
1210         Previously, classInfo() would get the VM from the target's
1211         MarkedBlock.  Most callers already have a VM on hand, so it is
1212         wasteful to compute the VM from the marked block every time. This
1213         patch refactors some of the most common callers of classInfo(),
1214         jsDynamicCast and inherits to take a VM as well.
1215
1216         * DumpRenderTree/TestRunner.cpp:
1217         (setAudioResultCallback):
1218
1219 2017-01-26  Jer Noble  <jer.noble@apple.com>
1220
1221         Autoplay muted videos stop playback of any streaming app in the background
1222         https://bugs.webkit.org/show_bug.cgi?id=163993
1223         <rdar://problem/29020431>
1224
1225         Reviewed by Eric Carlson.
1226
1227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1228         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1229         (TestWebKitAPI::TEST):
1230         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
1231
1232 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
1233
1234         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
1235         https://bugs.webkit.org/show_bug.cgi?id=167466
1236
1237         Unreviewed test gardening.
1238
1239         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1240         (TEST):
1241
1242 2017-01-26  Matt Rajca  <mrajca@apple.com>
1243
1244         Notify clients when the user plays media otherwise prevented from autoplaying
1245         https://bugs.webkit.org/show_bug.cgi?id=167390
1246
1247         Reviewed by Alex Christensen.
1248
1249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1250         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1251         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1252         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1253         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1254         (TEST):
1255         * TestWebKitAPI/cocoa/TestWKWebView.h:
1256         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1257         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1258         (-[TestWKWebView waitForLoad]):
1259         (-[TestWKWebView mouseUpAtPoint:]):
1260         * WebKitTestRunner/TestController.cpp:
1261         (WTR::TestController::createOtherPage):
1262         (WTR::TestController::createWebViewWithOptions):
1263
1264 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1265
1266         Crash when setting custom scale factor.
1267         https://bugs.webkit.org/show_bug.cgi?id=167369
1268
1269         Reviewed by Sam Weinig.
1270
1271         Added API test.
1272
1273         * TestWebKitAPI/PlatformWin.cmake:
1274         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1275         (TestWebKitAPI::WebKitCreateInstance):
1276         (TestWebKitAPI::ScaleWebView::SetUp):
1277         (TestWebKitAPI::ScaleWebView::TearDown):
1278         (TestWebKitAPI::TEST_F):
1279
1280 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1281
1282         run-benchmark nests MotionMark results by the suite name twice
1283         https://bugs.webkit.org/show_bug.cgi?id=164948
1284
1285         Reviewed by Said Abou-Hallawa.
1286
1287         Use a single level MotionMark now that this is the name of the benchmark,
1288         and we no longer have tests that aren't part of the MotionMark suite.
1289
1290         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1291
1292 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1293
1294         Unreviewed, rolling out r211193.
1295
1296         This change broke internal builds.
1297
1298         Reverted changeset:
1299
1300         "Notify clients when the user plays media otherwise prevented
1301         from autoplaying"
1302         https://bugs.webkit.org/show_bug.cgi?id=167390
1303         http://trac.webkit.org/changeset/211193
1304
1305 2017-01-25  Matt Rajca  <mrajca@apple.com>
1306
1307         Notify clients when the user plays media otherwise prevented from autoplaying
1308         https://bugs.webkit.org/show_bug.cgi?id=167390
1309
1310         Reviewed by Alex Christensen.
1311
1312         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1313         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1314         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1315         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1316         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1317         (TEST):
1318         * TestWebKitAPI/cocoa/TestWKWebView.h:
1319         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1320         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1321         (-[TestWKWebView waitForLoad]):
1322         (-[TestWKWebView mouseUpAtPoint:]):
1323         * WebKitTestRunner/TestController.cpp:
1324         (WTR::TestController::createOtherPage):
1325         (WTR::TestController::createWebViewWithOptions):
1326
1327 2017-01-25  Matt Rajca  <mrajca@apple.com>
1328
1329         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1330         https://bugs.webkit.org/show_bug.cgi?id=167385
1331
1332         Reviewed by Alex Christensen.
1333
1334         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1335         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1336         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1337         (TEST): Allow inline (rather than full screen) media playback on iOS.
1338
1339 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1340
1341         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1342         https://bugs.webkit.org/show_bug.cgi?id=167414
1343
1344         Reviewed by Michael Catanzaro.
1345
1346         Add a test case to check ephemeral web views don't write favicons to the database.
1347
1348         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1349         (ephemeralViewLoadChanged):
1350         (testPrivateBrowsing):
1351         (testFaviconDatabase):
1352
1353 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1354
1355         [GTK] Add a private browsing mode to MiniBrowser
1356         https://bugs.webkit.org/show_bug.cgi?id=167413
1357
1358         Reviewed by Michael Catanzaro.
1359
1360         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1361         private windows, even on non-private instances.
1362
1363         * MiniBrowser/gtk/BrowserWindow.c:
1364         (webViewTitleChanged): Add [Private] to title window for private windows.
1365         (webViewCreate): Pass web context to browser_window_new.
1366         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1367         (browserWindowFinalize): Disconnect web context signal handlers.
1368         (browser_window_init): Add shortcut for opening private window.
1369         (browser_window_new): It now receives the context and connect to download-started here.
1370         (browser_window_get_web_context): Return the context.
1371         * MiniBrowser/gtk/BrowserWindow.h:
1372         * MiniBrowser/gtk/main.c:
1373         (createBrowserTab): Create the web view for the window web context.
1374         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1375         (aboutDataHandleRequest): Ditto.
1376         (aboutURISchemeRequestCallback): Ditto.
1377         (main): Create ephemeral web context if private command line option is used.
1378
1379 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1380
1381         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1382         https://bugs.webkit.org/show_bug.cgi?id=167409
1383
1384         Reviewed by Antti Koivisto.
1385
1386         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1387         as well as tests for the newly added matchingElementInFlatTree.
1388
1389         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1390         (TestWebKitAPI::runJavaScriptAlert):
1391         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1392         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1393         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1394
1395 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1396
1397         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1398         https://bugs.webkit.org/show_bug.cgi?id=167370
1399
1400         Reviewed by Michael Catanzaro.
1401
1402         Add several test cases of ephemeral web views.
1403
1404         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1405         (testWebViewAuthenticationStorage):
1406         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1407         (ephemeralViewloadChanged):
1408         (testCookieManagerEphemeral):
1409         (beforeAll):
1410         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1411         (testWebKitSettings):
1412         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1413         (testWebContextEphemeral):
1414         (ephemeralViewloadChanged):
1415         (testWebContextProxySettings):
1416         (beforeAll):
1417         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1418         (ephemeralViewloadChanged):
1419         (testWebViewEphemeral):
1420         (beforeAll):
1421         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1422         (ephemeralViewloadChanged):
1423         (testWebsiteDataEphemeral):
1424         (beforeAll):
1425
1426 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1427
1428         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1429         https://bugs.webkit.org/show_bug.cgi?id=167402
1430
1431         Reviewed by Ryosuke Niwa.
1432
1433         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1434         (TestWebKitAPI::TEST):
1435
1436 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1437
1438         Add simple line layout toggle to MiniBrowser
1439         https://bugs.webkit.org/show_bug.cgi?id=167405
1440
1441         Reviewed by Andreas Kling.
1442
1443         * MiniBrowser/mac/SettingsController.h:
1444         * MiniBrowser/mac/SettingsController.m:
1445         (-[SettingsController _populateMenu]):
1446         (-[SettingsController validateMenuItem:]):
1447         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1448         (-[SettingsController simpleLineLayoutEnabled]):
1449         * MiniBrowser/mac/WK1BrowserWindowController.m:
1450         (-[WK1BrowserWindowController didChangeSettings]):
1451         * MiniBrowser/mac/WK2BrowserWindowController.m:
1452         (-[WK2BrowserWindowController didChangeSettings]):
1453
1454 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1455
1456         WKR does not include my nick when commit-queue lands my patch
1457         https://bugs.webkit.org/show_bug.cgi?id=167388
1458
1459         Reviewed by Ryosuke Niwa.
1460
1461         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1462         (NewCommitBot._summarize_commit_log):
1463         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1464         Perform nickname insertion before grabbing "Patch by" details.
1465         This way we can include the nickname with the full name.
1466
1467 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1468
1469         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1470         https://bugs.webkit.org/show_bug.cgi?id=167394
1471
1472         Reviewed by Ryosuke Niwa.
1473
1474         * Scripts/webkitperl/FeatureList.pm:
1475         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1476
1477 2017-01-24  Youenn Fablet  <youenn@apple.com>
1478
1479         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1480         https://bugs.webkit.org/show_bug.cgi?id=167353
1481
1482         Reviewed by Alex Christensen.
1483
1484         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1485         (CMakeGenerator.initialize_targets):
1486
1487 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1488
1489         WKR should not confuse Miguel Gomez with Andres Gomez
1490         https://bugs.webkit.org/show_bug.cgi?id=167389
1491
1492         Reviewed by Lucas Forschler.
1493
1494         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1495         "mAndres Gomez". Fix this.
1496
1497         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1498         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1499         space on each side of the email address, so expect both spaces to be there before
1500         considering the email for replacement.
1501         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1502
1503 2017-01-24  Matt Rajca  <mrajca@apple.com>
1504
1505         Pass down website autoplay policies to media elements
1506         https://bugs.webkit.org/show_bug.cgi?id=167355
1507
1508         Reviewed by Alex Christensen.
1509
1510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1511         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1512         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1513         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1514         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1515         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1516         (TEST):
1517
1518 2017-01-24  Nan Wang  <n_wang@apple.com>
1519
1520         AX: Speak Selection does not work in an iframe
1521         https://bugs.webkit.org/show_bug.cgi?id=166794
1522         <rdar://problem/29913013>
1523
1524         Reviewed by Chris Fleizach.
1525
1526         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1527         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1528         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1529         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1530         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1531         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1532         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1533         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1534         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1535         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1536         (-[TestRunnerWKWebView dealloc]):
1537         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1538         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1539         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1540         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1541         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1542
1543 2017-01-24  Daniel Bates  <dabates@apple.com>
1544
1545         StringView.split() should use an iterator design pattern instead of allocating a Vector
1546         https://bugs.webkit.org/show_bug.cgi?id=163225
1547
1548         Reviewed by Darin Adler.
1549
1550         Add unit tests for StringView.split().
1551
1552         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1553         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1554         used in the StringView.split() unit tests.
1555         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1556         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1557         object to a Vector of String objects.
1558         (TestWebKitAPI::TEST): Added the following tests:
1559             - WTF.StringViewSplitEmptyAndNullStrings
1560             - WTF.StringViewSplitBasic
1561             - WTF.StringViewSplitWithConsecutiveSeparators
1562
1563 2017-01-23  Anders Carlsson  <andersca@apple.com>
1564
1565         The Score Esports crashes on launch
1566         https://bugs.webkit.org/show_bug.cgi?id=167338
1567         rdar://problem/29948645
1568
1569         Reviewed by Dan Bernstein.
1570
1571         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1572         (TestWebKitAPI::TEST):
1573         Add a test.
1574
1575 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1576
1577         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1578         https://bugs.webkit.org/show_bug.cgi?id=146589
1579
1580         Reviewed by Michael Catanzaro.
1581
1582         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1583         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1584
1585         * MiniBrowser/gtk/BrowserWindow.c:
1586         (webViewDecidePolicy):
1587         (newTabCallback):
1588         * MiniBrowser/gtk/main.c:
1589         (createBrowserTab):
1590         (aboutDataRequestFree):
1591         (aboutDataRequestNew):
1592         (aboutDataRequestForView):
1593         (websiteDataRemovedCallback):
1594         (websiteDataClearedCallback):
1595         (aboutDataScriptMessageReceivedCallback):
1596         (domainListFree):
1597         (aboutDataFillTable):
1598         (gotWebsiteDataCallback):
1599         (aboutDataHandleRequest):
1600         (aboutURISchemeRequestCallback):
1601         (main):
1602         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1603         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1604         (serverCallback):
1605         (beforeAll):
1606         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
1607         (serverCallback):
1608         (WebsiteDataTest::WebsiteDataTest):
1609         (WebsiteDataTest::~WebsiteDataTest):
1610         (WebsiteDataTest::fetch):
1611         (WebsiteDataTest::remove):
1612         (WebsiteDataTest::clear):
1613         (testWebsiteDataConfiguration):
1614         (testWebsiteDataCache):
1615         (testWebsiteDataStorage):
1616         (testWebsiteDataDatabases):
1617         (testWebsiteDataAppcache):
1618         (beforeAll):
1619         (afterAll):
1620
1621 2017-01-23  Commit Queue  <commit-queue@webkit.org>
1622
1623         Unreviewed, rolling out r211062.
1624         https://bugs.webkit.org/show_bug.cgi?id=167354
1625
1626         broke API tests (Requested by alexchristensen on #webkit).
1627
1628         Reverted changeset:
1629
1630         "Pass down website autoplay policies to media elements"
1631         https://bugs.webkit.org/show_bug.cgi?id=167132
1632         http://trac.webkit.org/changeset/211062
1633
1634 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1635
1636         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
1637         https://bugs.webkit.org/show_bug.cgi?id=167330
1638
1639         Reviewed by Tim Horton.
1640
1641         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1642         (TestWebKitAPI::TEST_F):
1643
1644 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1645
1646         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
1647         https://bugs.webkit.org/show_bug.cgi?id=167317
1648
1649         Reviewed by Sam Weinig.
1650
1651         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1652         (TestWebKitAPI::TEST_F):
1653
1654 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
1655
1656         svn-create-patch should emit properties when files are moved or copied
1657         https://bugs.webkit.org/show_bug.cgi?id=167264
1658
1659         Reviewed by Daniel Bates.
1660
1661         * Scripts/svn-create-patch:
1662         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
1663
1664 2017-01-23  Youenn Fablet  <youenn@apple.com>
1665
1666         [WebRTC] Filter libwebrtc link flags
1667         https://bugs.webkit.org/show_bug.cgi?id=167287
1668
1669         Reviewed by Alex Christensen.
1670
1671         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1672         (CMakeGenerator._compute_link_flags):
1673         (CMakeGenerator._compute_link_flags.keep_flag):
1674         (CMakeGenerator._generate_compile_target_options):
1675
1676 2017-01-23  Youenn Fablet  <youennf@gmail.com>
1677
1678         [WebRTC] Make VP8 optional in libwebrtc
1679         https://bugs.webkit.org/show_bug.cgi?id=167257
1680
1681         Reviewed by Darin Adler.
1682
1683         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1684         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
1685
1686 2017-01-23  Jer Noble  <jer.noble@apple.com>
1687
1688         Video details does not apear and missing scrubber in Control Center
1689         https://bugs.webkit.org/show_bug.cgi?id=167233
1690
1691         Reviewed by Alex Christensen.
1692
1693         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
1694         NowPlayingControlTests for iOS.
1695
1696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1697         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1698         (-[NowPlayingTestWebView setWindowVisible:]):
1699         (TestWebKitAPI::TEST):
1700         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1701         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1702         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1703         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
1704         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
1705         (SOFT_LINK_CLASS):
1706         (-[TestMessageHandler addMessage:withHandler:]):
1707         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1708         (__simulated_forceClickAssociatedEventsMask):
1709         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1710         (-[TestWKWebViewHostWindow isKeyWindow]):
1711         (-[TestWKWebViewHostWindow makeKeyWindow]):
1712         (-[TestWKWebViewHostWindow resignKeyWindow]):
1713         (-[TestWKWebView initWithFrame:]):
1714         (-[TestWKWebView initWithFrame:configuration:]):
1715         (-[TestWKWebView _setUpTestWindow:]):
1716         (-[TestWKWebView performAfterReceivingMessage:action:]):
1717         (-[TestWKWebView loadTestPageNamed:]):
1718         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1719         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1720         (-[TestWKWebView waitForMessage:]):
1721         (-[TestWKWebView performAfterLoading:]):
1722         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1723         (-[TestWKWebView typeCharacter:]):
1724
1725 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1726
1727         Unreviewed. Bring back gtk-doc error messages after r209981.
1728
1729         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
1730         impossible to know what's wrong.
1731
1732         * gtk/gtkdoc.py:
1733         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
1734
1735 2017-01-20  Youenn Fablet  <youennf@gmail.com>
1736
1737         [WebRTC] Update build system to make G711 optional in libwebrtc
1738         https://bugs.webkit.org/show_bug.cgi?id=167256
1739
1740         Reviewed by Alex Christensen.
1741
1742         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1743         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
1744
1745 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1746
1747         Cleanup RuntimeEnabledFeatures
1748         https://bugs.webkit.org/show_bug.cgi?id=167228
1749
1750         Reviewed by Simon Fraser.
1751
1752         * DumpRenderTree/mac/DumpRenderTree.mm:
1753         (enableExperimentalFeatures):
1754         (resetWebPreferencesToConsistentValues):
1755         (setWebPreferencesForTestOptions):
1756         (resetWebViewToConsistentStateBeforeTesting):
1757         * DumpRenderTree/win/DumpRenderTree.cpp:
1758         (enableExperimentalFeatures):
1759         (resetWebPreferencesToConsistentValues):
1760         More closely match WebKitTestRunner initialization of preferences
1761         for experimental features.
1762
1763 2017-01-20  Alex Christensen  <achristensen@webkit.org>
1764
1765         Build Fix for Windows DumpRenderTree after r210976
1766         https://bugs.webkit.org/show_bug.cgi?id=167115
1767
1768         * DumpRenderTree/win/DumpRenderTree.cpp:
1769         (resetWebPreferencesToConsistentValues):
1770
1771 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1772
1773         Remove outdated ENABLE(CSP_NEXT) build flag
1774         https://bugs.webkit.org/show_bug.cgi?id=167252
1775
1776         Reviewed by Brent Fulgham.
1777
1778         * Scripts/webkitperl/FeatureList.pm:
1779         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1780
1781 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1782
1783         Build Fix for Windows DumpRenderTree after r210976
1784
1785         * DumpRenderTree/win/DumpRenderTree.cpp:
1786         (resetWebPreferencesToConsistentValues):
1787
1788 2017-01-20  Antoine Quint  <graouts@apple.com>
1789
1790         Web Animations should be off by default and enabled as an experimental feature
1791         https://bugs.webkit.org/show_bug.cgi?id=167115
1792         <rdar://problem/30048963>
1793
1794         Reviewed by Joseph Pecoraro.
1795
1796         Turn Web Animations on in DRT.
1797
1798         * DumpRenderTree/mac/DumpRenderTree.mm:
1799         (resetWebPreferencesToConsistentValues):
1800         * DumpRenderTree/win/DumpRenderTree.cpp:
1801         (resetWebPreferencesToConsistentValues):
1802
1803 2017-01-20  Youenn Fablet  <youenn@apple.com>
1804
1805         [WebRTC] Add libwebrtc build infrastructure
1806         https://bugs.webkit.org/show_bug.cgi?id=167207
1807
1808         Reviewed by Alex Christensen.
1809
1810         Adding a script doing the libwebrtc project json to CMake file conversion.
1811
1812         * Scripts/generate-libwebrtc-cmake: Added.
1813         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
1814         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
1815
1816 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1817
1818         Mini Browser: Show tooltip for Experimental Features
1819         https://bugs.webkit.org/show_bug.cgi?id=167225
1820
1821         Reviewed by Alex Christensen.
1822
1823         * MiniBrowser/mac/SettingsController.m:
1824         (-[SettingsController _populateMenu]):
1825         Include the full details string as a tooltip.
1826
1827 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
1828
1829         [Win] Test output results should not be written twice.
1830         https://bugs.webkit.org/show_bug.cgi?id=167197
1831
1832         Reviewed by Brent Fulgham.
1833
1834         Prevent test output from being written twice by returning early from
1835         the dump() function, if it already has been called.
1836         This patch also adds a missing newline to a test output line. 
1837         
1838         * DumpRenderTree/win/DumpRenderTree.cpp:
1839         (dump):
1840
1841 2017-01-20  Antoine Quint  <graouts@apple.com>
1842
1843         [Modern Media Controls] Turn modern media controls on by default
1844         https://bugs.webkit.org/show_bug.cgi?id=165668
1845
1846         Reviewed by Dean Jackson.
1847
1848         Enabled modern media controls by default in test runners.
1849
1850         * DumpRenderTree/TestOptions.h:
1851         * WebKitTestRunner/TestOptions.h:
1852
1853 2017-01-19  Chris Dumez  <cdumez@apple.com>
1854
1855         iterable<> should be enabled on WK1
1856         https://bugs.webkit.org/show_bug.cgi?id=167221
1857         <rdar://problem/30108531>
1858
1859         Reviewed by Youenn Fablet.
1860
1861         * DumpRenderTree/mac/DumpRenderTree.mm:
1862         (resetWebPreferencesToConsistentValues):
1863         * DumpRenderTree/win/DumpRenderTree.cpp:
1864         (resetWebPreferencesToConsistentValues):
1865         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1866         (WTR::InjectedBundle::beginTesting):
1867         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1868         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
1869         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1870
1871 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
1872
1873         Ensure status server logs go to log file
1874         https://bugs.webkit.org/show_bug.cgi?id=167210
1875
1876         Reviewed by Alexey Proskuryakov.
1877
1878         * Scripts/webkitpy/common/net/statusserver.py:
1879         (StatusServer.next_work_item): Change log level from debug to info in
1880         order to facilitate deubgging issues.
1881         (StatusServer.update_work_items): Same.
1882
1883 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
1884
1885         Additional selection tests and interpolation fix
1886         https://bugs.webkit.org/show_bug.cgi?id=167171
1887
1888         Reviewed by Simon Fraser.
1889
1890         We weren't adding the final event when interpolating event streams.
1891
1892         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1893         (-[HIDEventGenerator interpolatedEvents:]):
1894
1895 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1896
1897         [Cocoa] Variation fonts are erroneously disabled on iOS
1898         https://bugs.webkit.org/show_bug.cgi?id=167172
1899
1900         Reviewed by Simon Fraser.
1901
1902         OpenSource builders don't seem to understand sdk=embedded*.
1903
1904         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1905
1906 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1907
1908         Unreviewed. Fix GTK+ unit tests failing since r210531.
1909
1910         Avoid using paths to files that don't actually exist.
1911
1912         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
1913         (testWebKitConsoleMessageNetworkError):
1914         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1915         (testContextMenuDefaultMenu):
1916         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
1917         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
1918         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
1919
1920 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1921
1922         [GTK] Provide API to set proxy settings
1923         https://bugs.webkit.org/show_bug.cgi?id=128674
1924
1925         Reviewed by Michael Catanzaro.
1926
1927         Add tests for new proxy settings API.
1928
1929         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1930         (serverCallback):
1931         (ProxyTest::ProxyTest):
1932         (ProxyTest::~ProxyTest):
1933         (ProxyTest::loadURIAndGetMainResourceData):
1934         (ProxyTest::proxyServerPortAsString):
1935         (testWebContextProxySettings):
1936         (beforeAll):
1937
1938 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1939
1940         Add back my old email address so old commits will still match it.
1941
1942         * Scripts/webkitpy/common/config/contributors.json:
1943
1944 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1945
1946         Remove my old email address from contributors.json and watchlist.
1947
1948         * Scripts/validate-committer-lists:
1949         (CommitterListFromGit): Change the mapping to the correct email.
1950         * Scripts/webkitpy/common/config/contributors.json:
1951         * Scripts/webkitpy/common/config/watchlist:
1952
1953 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1954
1955         Unreviewed, rolling out r210848.
1956
1957         This change introduced media-related LayoutTest failures and
1958         crashes on macOS.
1959
1960         Reverted changeset:
1961
1962         "[Modern Media Controls] Turn modern media controls on by
1963         default"
1964         https://bugs.webkit.org/show_bug.cgi?id=165668
1965         http://trac.webkit.org/changeset/210848
1966
1967 2017-01-18  Andreas Kling  <akling@apple.com>
1968
1969         Document::securityOrigin() should return a reference.
1970         <https://webkit.org/b/167124>
1971
1972         Reviewed by Sam Weinig.
1973
1974         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1975         (TestWebKitAPI::TEST_F):
1976
1977 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
1978
1979         [Win] Clipboard tests are flaky.
1980         https://bugs.webkit.org/show_bug.cgi?id=167088
1981
1982         Reviewed by Brent Fulgham.
1983
1984         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
1985         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
1986
1987         * DumpRenderTree/win/DumpRenderTree.cpp:
1988         (main):
1989
1990 2017-01-18  Antoine Quint  <graouts@apple.com>
1991
1992         [Modern Media Controls] Turn modern media controls on by default
1993         https://bugs.webkit.org/show_bug.cgi?id=165668
1994
1995         Reviewed by Dean Jackson.
1996
1997         Enabled modern media controls by default in test runners. 
1998
1999         * DumpRenderTree/TestOptions.h:
2000         * WebKitTestRunner/TestOptions.h:
2001
2002 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2003
2004         Unreviewed, rolling out r210834
2005         https://bugs.webkit.org/show_bug.cgi?id=165668
2006
2007         It introduced dozens of test timeouts.
2008
2009         Reverted changeset:
2010         "[Modern Media Controls] Turn modern media controls on by default"
2011         https://bugs.webkit.org/show_bug.cgi?id=165668
2012         http://trac.webkit.org/changeset/210834
2013
2014 2017-01-17  Antoine Quint  <graouts@apple.com>
2015
2016         [Modern Media Controls] Turn modern media controls on by default
2017         https://bugs.webkit.org/show_bug.cgi?id=165668
2018
2019         Reviewed by Dean Jackson.
2020
2021         Enabled modern media controls by default in test runners. 
2022
2023         * DumpRenderTree/TestOptions.h:
2024         * WebKitTestRunner/TestOptions.h:
2025
2026 2017-01-17  Chris Dumez  <cdumez@apple.com>
2027
2028         Document title changed twice when setting document.title
2029         https://bugs.webkit.org/show_bug.cgi?id=167065
2030
2031         Reviewed by Darin Adler.
2032
2033         Add WebKit2GTK API test that was written by Michael Catanzaro.
2034
2035         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2036         (testWebViewTitleChange):
2037         (beforeAll):
2038
2039 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2040
2041         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2042         https://bugs.webkit.org/show_bug.cgi?id=116551
2043         <rdar://problem/13949830>
2044
2045         Reviewed by Alex Christensen.
2046
2047         * Scripts/webkitperl/FeatureList.pm:
2048         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2049         that is part of the existing WEB_TIMING feature.
2050
2051         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2052
2053 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
2054
2055         'webkit-patch post' no longer works with moved/copied files
2056         https://bugs.webkit.org/show_bug.cgi?id=166914
2057         <rdar://problem/29979707>
2058
2059         Reviewed by Daniel Bates.
2060
2061         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
2062         file outputs only the "Index:" line with an empty body.  This workaround
2063         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
2064         public email list tracking this bug is below.
2065         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
2066         
2067
2068         * Scripts/svn-create-patch:
2069         (generateDiff): Ignore an "Index:" line with an empty body.
2070
2071 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2072
2073         Remove the REQUEST_ANIMATION_FRAME flag
2074         https://bugs.webkit.org/show_bug.cgi?id=156980
2075         <rdar://problem/25906849>
2076
2077         Reviewed by Simon Fraser.
2078
2079         * Scripts/webkitperl/FeatureList.pm:
2080         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2081
2082 2017-01-15  Sam Weinig  <sam@webkit.org>
2083
2084         Add the ability to use numbers in makeString()
2085         https://bugs.webkit.org/show_bug.cgi?id=167087
2086
2087         Reviewed by Darin Adler.
2088
2089         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2090         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
2091         Add tests for StringConcatenate, focusing on new numeric additions.
2092
2093 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2094
2095         Unreviewed, remove stale comment.
2096
2097         This test was fixed by r163173.
2098
2099         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2100
2101 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2102
2103         Annotate large string tests with largeHeap
2104         https://bugs.webkit.org/show_bug.cgi?id=167054
2105
2106         Reviewed by Filip Pizlo.
2107
2108         * Scripts/run-javascriptcore-tests:
2109         * Scripts/run-jsc-stress-tests:
2110
2111 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
2112
2113         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
2114         https://bugs.webkit.org/show_bug.cgi?id=167043
2115
2116         Reviewed by Darin Adler.
2117
2118         * Scripts/webkitperl/FeatureList.pm:
2119
2120 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2121
2122         Remove ENABLE(DETAILS_ELEMENT) guards
2123         https://bugs.webkit.org/show_bug.cgi?id=167042
2124
2125         Reviewed by Alex Christensen.
2126
2127         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2128
2129 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
2130
2131         26 MotionMark performance tests failing
2132         https://bugs.webkit.org/show_bug.cgi?id=166854
2133
2134         Reviewed by Ryosuke Niwa.
2135
2136         Unrelated change. This is the last place that we need to rename Animometer
2137         to MotionMark.
2138
2139         * Scripts/webkitpy/common/config/watchlist:
2140
2141 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2142
2143         run-jsc-benchmarks' echo should have -e option
2144         https://bugs.webkit.org/show_bug.cgi?id=167009
2145
2146         Reviewed by Sam Weinig.
2147
2148         echo requires `-e` option to use escape sequence.
2149         Without it, in some environment (in my Fedora 25), the escape sequence is not
2150         recognized and just dumped as `\c` etc.
2151
2152         * Scripts/run-jsc-benchmarks:
2153
2154 2017-01-12  Chris Dumez  <cdumez@apple.com>
2155
2156         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2157         https://bugs.webkit.org/show_bug.cgi?id=166995
2158
2159         Reviewed by Jer Noble.
2160
2161         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2162         as some people are having trouble building without it.
2163
2164         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2165
2166 2017-01-12  Sam Weinig  <sam@webkit.org>
2167
2168         Add the ability to filter the set of bindings tests you want to run
2169         https://bugs.webkit.org/show_bug.cgi?id=166977
2170
2171         Reviewed by Tim Horton.
2172
2173         Allows doing things like:
2174             run-bindings-tests TestObj* TestCEReactions*
2175         
2176         to run only those tests that match the patterns.
2177
2178         * Scripts/run-bindings-tests:
2179         (main):
2180         Switch to using optparse and pass the remaining args as the filters.
2181
2182         * Scripts/webkitpy/bindings/main.py:
2183         (BindingsTests.__init__):
2184         Store the pattens.
2185
2186         (BindingsTests.test_matches_patterns):
2187         Add helper predicate to determine if a test should be run. When no
2188         patterns are present, all tests should run.
2189
2190         (BindingsTests.run_tests):
2191         Filter tests using the passed in patterns.
2192
2193 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
2194
2195         Followup fix after r210503.
2196         https://bugs.webkit.org/show_bug.cgi?id=166887
2197
2198         Reviewed by Alex Christensen.
2199
2200         After <http://trac.webkit.org/changeset/210503>, test results are written to a
2201         duplicated file handle on Windows. This patch fixes the remaining call sites.
2202
2203         * DumpRenderTree/PixelDumpSupport.cpp:
2204         * DumpRenderTree/TestRunner.cpp:
2205         (TestRunner::waitToDumpWatchdogTimerFired):
2206         * DumpRenderTree/TestRunner.h:
2207         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2208         * DumpRenderTree/win/DumpRenderTree.cpp:
2209         * DumpRenderTree/win/DumpRenderTreeWin.h:
2210         * DumpRenderTree/win/TestRunnerWin.cpp:
2211         (TestRunner::setSpellCheckerLoggingEnabled):
2212
2213 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
2214
2215         Add committer status for Megan
2216         https://bugs.webkit.org/show_bug.cgi?id=166954
2217
2218         Reviewed by Tim Horton.
2219
2220         Add committer status for Megan Gardner
2221
2222         * Scripts/webkitpy/common/config/contributors.json:
2223
2224 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2225
2226         Unreviewed test fix after r210599.
2227
2228         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2229         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
2230
2231 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2232
2233         Unreviewed build fix after r210599.
2234
2235         Add missing files.
2236
2237         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2238         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2239
2240 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2241
2242         File scheme should not allow access of a resource on a different volume.
2243         https://bugs.webkit.org/show_bug.cgi?id=158552
2244         <rdar://problem/15307582>
2245
2246         Reviewed by Alex Christensen.
2247
2248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2249         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2250         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2251
2252 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2253
2254         Unreviewed, rolling out r210571.
2255
2256         This change broke the 32-bit macOS build and caused LayoutTest
2257         failures.
2258
2259         Reverted changeset:
2260
2261         "File scheme should not allow access of a resource on a
2262         different volume."
2263         https://bugs.webkit.org/show_bug.cgi?id=158552
2264         http://trac.webkit.org/changeset/210571
2265
2266 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2267
2268         [GTK] install-dependencies script misses gdb
2269         https://bugs.webkit.org/show_bug.cgi?id=166917
2270
2271         Reviewed by Michael Catanzaro.
2272
2273         gdb is needed for generating the crash logs.
2274
2275         * gtk/install-dependencies:
2276
2277 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2278
2279         [GTK] No way for applications to set notification permissions without waiting for permission request
2280         https://bugs.webkit.org/show_bug.cgi?id=163366
2281
2282         Reviewed by Carlos Garcia Campos.
2283
2284         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2285         (testWebViewNotification):
2286         (setInitialNotificationPermissionsAllowedCallback):
2287         (setInitialNotificationPermissionsDisallowedCallback):
2288         (testWebViewNotificationInitialPermissionAllowed):
2289         (testWebViewNotificationInitialPermissionDisallowed):
2290         (beforeAll):
2291         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2292         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2293         (WebViewTest::WebViewTest):
2294         (WebViewTest::initializeWebView):
2295         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2296
2297 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2298
2299         MobileMiniBrowser tests don't work by default
2300         https://bugs.webkit.org/show_bug.cgi?id=166910
2301
2302         Reviewed by Alex Christensen.
2303
2304         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2305         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2306
2307 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2308
2309         File scheme should not allow access of a resource on a different volume.
2310         https://bugs.webkit.org/show_bug.cgi?id=158552
2311         <rdar://problem/15307582>
2312
2313         Reviewed by Alex Christensen.
2314
2315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2316         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2317         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2318
2319 2017-01-10  Mark Lam  <mark.lam@apple.com>
2320
2321         Reverting run-jsc-stress-tests' $buildType to use string values.
2322         https://bugs.webkit.org/show_bug.cgi?id=166912
2323
2324         Rubber stamped by Filip Pizlo.
2325
2326         This is so that we can test for it in the tests e.g.
2327         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2328
2329         * Scripts/run-jsc-stress-tests:
2330
2331 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2332
2333         Temporarily add back the file removed in r210463 to unbreak internal bots.
2334
2335         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2336
2337 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2338
2339         svn-apply failed to apply a patch (deleting file with svn property)
2340         https://bugs.webkit.org/show_bug.cgi?id=165953
2341
2342         Reviewed by Daniel Bates.
2343
2344         * Scripts/VCSUtils.pm:
2345         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2346         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2347
2348 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2349
2350         Update flakiness dashboard configuration.
2351         https://bugs.webkit.org/show_bug.cgi?id=166869
2352
2353         Reviewed by Alexey Proskuryakov.
2354
2355         * TestResultServer/static-dashboards/builders.jsonp:
2356         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2357
2358 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2359
2360         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2361         https://bugs.webkit.org/show_bug.cgi?id=165232
2362
2363         Unreviewed follow-up patch after r210539 and r210523.
2364
2365         Instead of using that environment variable, the argument
2366         --display-server=xorg should be passed now.
2367
2368         The GTK+ performance bot was the only bot using this, and is
2369         already passing --display-server=xorg after r210539.
2370
2371         * Scripts/webkitpy/port/gtk.py:
2372         (GtkPort._driver_class):
2373
2374 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2375
2376         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2377         https://bugs.webkit.org/show_bug.cgi?id=166872
2378
2379         Reviewed by Michael Catanzaro.
2380
2381         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2382         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2383         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2384         The step RunWebKitTests already has support for it.
2385
2386         * BuildSlaveSupport/build.webkit.org-config/config.json:
2387         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2388         (RunGtkAPITests.start):
2389         (RunAndUploadPerfTests.start):
2390         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2391
2392 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2393
2394         Unreviewed, rolling out r210531.
2395
2396         This change broke the 32-bit macOS build and caused LayoutTest
2397         failures.
2398
2399         Reverted changeset:
2400
2401         "File scheme should not allow access of a resource on a
2402         different volume."
2403         https://bugs.webkit.org/show_bug.cgi?id=158552
2404         http://trac.webkit.org/changeset/210531
2405
2406 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2407
2408         File scheme should not allow access of a resource on a different volume.
2409         https://bugs.webkit.org/show_bug.cgi?id=158552
2410         <rdar://problem/15307582>
2411
2412         Reviewed by Alex Christensen.
2413
2414         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2415         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2416         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2417
2418 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2419
2420         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2421         https://bugs.webkit.org/show_bug.cgi?id=165232
2422
2423         Reviewed by Michael Catanzaro.
2424
2425         Add a new WaylandDriver to run the tests in the user current wayland session.
2426
2427         Also merge all the configuration options for selecting the display server inside one
2428         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2429
2430         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2431
2432         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2433         (TestRunner._create_driver):
2434         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2435         (parse_args):
2436         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2437         (PerfTestsRunner._parse_args):
2438         * Scripts/webkitpy/port/gtk.py:
2439         (GtkPort.__init__):
2440         (GtkPort._driver_class):
2441         (GtkPort._search_paths):
2442         * Scripts/webkitpy/port/waylanddriver.py: Added.
2443         (WaylandDriver):
2444         (WaylandDriver.check_driver):
2445         (WaylandDriver._setup_environ_for_test):
2446         (WaylandDriver._start):
2447
2448 2017-01-09  Andy Estes  <aestes@apple.com>
2449
2450         [QuickLook] Add a layout test for webkit.org/b/135651
2451         https://bugs.webkit.org/show_bug.cgi?id=166855
2452
2453         Reviewed by Andreas Kling.
2454
2455         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2456         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2457         errors with code WebKitErrorCannotShowURL.
2458         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2459         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2460         not specific to WebKit2 error codes.
2461
2462 2017-01-09  Antoine Quint  <graouts@apple.com>
2463
2464         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2465         https://bugs.webkit.org/show_bug.cgi?id=166837
2466
2467         Reviewed by Alex Christensen.
2468
2469         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2470         the provided value when trying to determine the path to the test file. Failing
2471         that, we use the computed URL or the raw path provided to cover all cases.
2472         
2473         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2474         by applying this patch and seeing the number test failures dramatically reduced
2475         with WK1 due to the option to turn modern media controls off for older media controls
2476         tests.
2477
2478         * DumpRenderTree/DumpRenderTree.h:
2479         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2480         (parseInputLine):
2481         * DumpRenderTree/TestOptions.h:
2482         * DumpRenderTree/TestOptions.mm:
2483         (TestOptions::TestOptions):
2484         * DumpRenderTree/mac/DumpRenderTree.mm:
2485         (runTest):
2486
2487 2017-01-09  Milan Crha  <mcrha@redhat.com>
2488
2489         prepare-ChangeLog: Correct help string for --style option
2490         https://bugs.webkit.org/show_bug.cgi?id=166725
2491
2492         Reviewed by Alexey Proskuryakov.
2493
2494         * Scripts/prepare-ChangeLog:
2495         (main):
2496
2497 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2498
2499         https://bugs.webkit.org/show_bug.cgi?id=166839
2500         Add php7 support for macOS.
2501         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2502
2503         Reviewed by Alexey Proskuryakov.
2504
2505         * Scripts/webkitpy/port/base.py:
2506         (Port._is_darwin_php_version_7):
2507         (Port._debian_php_version):
2508         (Port):
2509         (Port._darwin_php_version):
2510         (Port._apache_config_file_name_for_platform):
2511
2512 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2513
2514         [GTK] Should support key and code properties on keyboard events
2515         https://bugs.webkit.org/show_bug.cgi?id=166759
2516
2517         Reviewed by Carlos Garcia Campos.
2518
2519         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2520         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2521         on tests.
2522
2523 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2524
2525         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2526         https://bugs.webkit.org/show_bug.cgi?id=166760
2527
2528         Reviewed by Darin Adler.
2529
2530         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2531         We can work around that by duplicating and redirecting stdout.
2532
2533         * DumpRenderTree/PixelDumpSupport.cpp:
2534         (dumpWebViewAsPixelsAndCompareWithExpected):
2535         (printPNG):
2536         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2537         (logEventProc):
2538         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2539         (DRTDesktopNotificationPresenter::showDesktopNotification):
2540         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2541         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2542         * DumpRenderTree/win/DumpRenderTree.cpp:
2543         (dumpFrameScrollPosition):
2544         (dumpHistoryItem):
2545         (dumpBackForwardList):
2546         (dump):
2547         (runTest):
2548         (main):
2549         * DumpRenderTree/win/DumpRenderTreeWin.h:
2550         * DumpRenderTree/win/EditingDelegate.cpp:
2551         (EditingDelegate::shouldBeginEditingInDOMRange):
2552         (EditingDelegate::shouldEndEditingInDOMRange):
2553         (EditingDelegate::shouldInsertNode):
2554         (EditingDelegate::shouldInsertText):
2555         (EditingDelegate::shouldDeleteDOMRange):
2556         (EditingDelegate::shouldChangeSelectedDOMRange):
2557         (EditingDelegate::shouldApplyStyle):
2558         (EditingDelegate::shouldChangeTypingStyle):
2559         (EditingDelegate::doPlatformCommand):
2560         (EditingDelegate::webViewDidBeginEditing):
2561         (EditingDelegate::webViewDidChange):
2562         (EditingDelegate::webViewDidEndEditing):
2563         (EditingDelegate::webViewDidChangeTypingStyle):
2564         (EditingDelegate::webViewDidChangeSelection):
2565         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2566         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2567         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2568         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2569         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2570         (FrameLoadDelegate::didCommitLoadForFrame):
2571         (FrameLoadDelegate::didReceiveTitle):
2572         (FrameLoadDelegate::didFinishLoadForFrame):
2573         (FrameLoadDelegate::didFailLoadWithError):
2574         (FrameLoadDelegate::willPerformClientRedirectToURL):
2575         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2576         (FrameLoadDelegate::windowScriptObjectAvailable):
2577         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2578         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2579         (FrameLoadDelegate::didDisplayInsecureContent):
2580         (FrameLoadDelegate::didRunInsecureContent):
2581         (FrameLoadDelegate::webViewProgressFinishedNotification):
2582         * DumpRenderTree/win/HistoryDelegate.cpp:
2583         (HistoryDelegate::didNavigateWithNavigationData):
2584         (HistoryDelegate::didPerformClientRedirectFromURL):
2585         (HistoryDelegate::didPerformServerRedirectFromURL):
2586         (HistoryDelegate::updateHistoryTitle):
2587         (HistoryDelegate::populateVisitedLinksForWebView):
2588         * DumpRenderTree/win/PolicyDelegate.cpp:
2589         (PolicyDelegate::decidePolicyForNavigationAction):
2590         (PolicyDelegate::unableToImplementPolicyWithError):
2591         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2592         (ResourceLoadDelegate::willSendRequest):
2593         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2594         (ResourceLoadDelegate::didReceiveResponse):
2595         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2596         (ResourceLoadDelegate::didFailLoadingWithError):
2597         * DumpRenderTree/win/TestRunnerWin.cpp:
2598         (TestRunner::addDisallowedURL):
2599         (TestRunner::originsWithApplicationCache):
2600         (TestRunner::setStorageDatabaseIdleInterval):
2601         (TestRunner::closeIdleLocalStorageDatabases):
2602         (TestRunner::copyDecodedHostName):
2603         (TestRunner::copyEncodedHostName):
2604         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2605         (TestRunner::isGeolocationProviderActive):
2606         (TestRunner::pathToLocalResource):
2607         (TestRunner::setMockDeviceOrientation):
2608         (TestRunner::setMockGeolocationPosition):
2609         (TestRunner::setMockGeolocationPositionUnavailableError):
2610         (TestRunner::setSpatialNavigationEnabled):
2611         (TestRunner::setAutomaticLinkDetectionEnabled):
2612         (TestRunner::isCommandEnabled):
2613         (TestRunner::authenticateSession):
2614         (TestRunner::addChromeInputField):
2615         (TestRunner::removeChromeInputField):
2616         (TestRunner::focusWebView):
2617         (TestRunner::grantWebNotificationPermission):
2618         (TestRunner::denyWebNotificationPermission):
2619         (TestRunner::removeAllWebNotificationPermissions):
2620         (TestRunner::simulateWebNotificationClick):
2621         (TestRunner::imageCountInGeneralPasteboard):
2622         * DumpRenderTree/win/UIDelegate.cpp:
2623         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2624         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2625         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2626         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2627         (UIDelegate::webViewAddMessageToConsole):
2628         (UIDelegate::exceededDatabaseQuota):
2629         (UIDelegate::setStatusText):
2630         (UIDelegate::didPressMissingPluginButton):
2631
2632 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2633
2634         Add a setting to create editable MiniBrowser windows by default
2635         https://bugs.webkit.org/show_bug.cgi?id=166806
2636
2637         Reviewed by Beth Dakin.
2638
2639         * MiniBrowser/mac/AppDelegate.m:
2640         (-[BrowserAppDelegate createBrowserWindowController:]):
2641         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2642         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2643         * MiniBrowser/mac/SettingsController.h:
2644         * MiniBrowser/mac/SettingsController.m:
2645         (-[SettingsController _populateMenu]):
2646         (-[SettingsController validateMenuItem:]):
2647         (-[SettingsController toggleCreateEditorByDefault:]):
2648         (-[SettingsController createEditorByDefault]):
2649         Add a setting and update the key equivalents accordingly.
2650         Also make sure to make the right kind of window on launch.
2651
2652 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2653
2654         Fix the 32-bit build.
2655
2656         * MiniBrowser/mac/BrowserWindowController.h:
2657         * MiniBrowser/mac/BrowserWindowController.m:
2658
2659 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2660
2661         Fix the 32-bit build.
2662
2663         * MiniBrowser/mac/BrowserWindowController.m:
2664
2665 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2666
2667         Make it possible to drop HTML files on the MiniBrowser icon
2668         https://bugs.webkit.org/show_bug.cgi?id=166802
2669
2670         Reviewed by Simon Fraser.
2671
2672         * MiniBrowser/mac/AppDelegate.m:
2673         (-[BrowserAppDelegate application:openFile:]):
2674         * MiniBrowser/mac/Info.plist:
2675         If you're using an editable window, the usual trick of dropping on the
2676         window doesn't work anymore (it makes an <attachment> instead).
2677
2678 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2679
2680         MiniBrowser window gets smaller each time it is instantiated
2681         https://bugs.webkit.org/show_bug.cgi?id=166807
2682
2683         Reviewed by Andy Estes.
2684
2685         * MiniBrowser/mac/BrowserWindowController.m:
2686         (-[BrowserWindowController windowDidLoad]):
2687         * MiniBrowser/mac/BrowserWindow.xib:
2688         Turn on full-window content view support with IB, instead of waiting
2689         until after the views have been loaded. This seems to resolve the
2690         longstanding ever-shrinking-window problem.
2691
2692 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2693
2694         Add indent/outdent items to MiniBrowser's new format menu
2695         https://bugs.webkit.org/show_bug.cgi?id=166805
2696
2697         Reviewed by Dan Bernstein.
2698
2699         * MiniBrowser/mac/MainMenu.xib:
2700
2701 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2702
2703         Add a stock Format menu to MiniBrowser
2704         https://bugs.webkit.org/show_bug.cgi?id=166804
2705
2706         Reviewed by Andy Estes.
2707
2708         * MiniBrowser/mac/MainMenu.xib:
2709         Many of the features automatically work with editable web views.
2710         However, this seems to expose a bug where none of the font-related features
2711         (Cmd-B, for example) work until the first time the font panel is shown,
2712         per process, which will need to be investigated separately.
2713
2714 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2715
2716         Remove unused applicationWillTerminate methods from MiniBrowser
2717         https://bugs.webkit.org/show_bug.cgi?id=166803
2718
2719         Reviewed by Andy Estes.
2720
2721         * MiniBrowser/mac/AppDelegate.m:
2722         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
2723         * MiniBrowser/mac/BrowserWindowController.h:
2724         * MiniBrowser/mac/BrowserWindowController.m:
2725         (-[BrowserWindowController applicationTerminating]): Deleted.
2726         * MiniBrowser/mac/WK1BrowserWindowController.m:
2727         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
2728         * MiniBrowser/mac/WK2BrowserWindowController.m:
2729         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
2730
2731 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2732
2733         Add the ability to create empty contentEditable windows in MiniBrowser
2734         https://bugs.webkit.org/show_bug.cgi?id=166801
2735
2736         Reviewed by Wenson Hsieh.
2737
2738         * MiniBrowser/mac/AppDelegate.h:
2739         * MiniBrowser/mac/AppDelegate.m:
2740         (-[BrowserAppDelegate createBrowserWindowController:]):
2741         (-[BrowserAppDelegate newWindow:]):
2742         (-[BrowserAppDelegate newEditorWindow:]):
2743         (-[BrowserAppDelegate openDocument:]):
2744         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2745         * MiniBrowser/mac/BrowserWindowController.h:
2746         * MiniBrowser/mac/BrowserWindowController.m:
2747         (-[BrowserWindowController loadHTMLString:]):
2748         (-[BrowserWindowController toggleEditable:]):
2749         * MiniBrowser/mac/MainMenu.xib:
2750         * MiniBrowser/mac/WK1BrowserWindowController.m:
2751         (-[WK1BrowserWindowController awakeFromNib]):
2752         (-[WK1BrowserWindowController loadHTMLString:]):
2753         (-[WK1BrowserWindowController validateMenuItem:]):
2754         (-[WK1BrowserWindowController setEditable:]):
2755         (-[WK1BrowserWindowController updateTitle:]):
2756         * MiniBrowser/mac/WK2BrowserWindowController.m:
2757         (-[WK2BrowserWindowController awakeFromNib]):
2758         (-[WK2BrowserWindowController validateMenuItem:]):
2759         (-[WK2BrowserWindowController setEditable:]):
2760         (-[WK2BrowserWindowController updateTitle:]):
2761         (-[WK2BrowserWindowController loadHTMLString:]):
2762         Merge more functionality from WebEditingTester.
2763         Add two menu items for creating empty editable WebKit1/2 windows.
2764         Add a menu item to the Edit menu to toggle editability on any window.
2765
2766 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2767
2768         Implement find-in-page in MiniBrowser
2769         https://bugs.webkit.org/show_bug.cgi?id=166799
2770
2771         Reviewed by Andy Estes.
2772
2773         * MiniBrowser/mac/BrowserWindow.xib:
2774         * MiniBrowser/mac/BrowserWindowController.h:
2775         * MiniBrowser/mac/BrowserWindowController.m:
2776         (-[BrowserWindowController find:]): Deleted.
2777         * MiniBrowser/mac/MainMenu.xib:
2778         * MiniBrowser/mac/WK1BrowserWindowController.m:
2779         (-[WK1BrowserWindowController toggleShrinkToFit:]):
2780         (-[WK1BrowserWindowController find:]): Deleted.
2781         * MiniBrowser/mac/WK2BrowserWindowController.m:
2782         (-[WK2BrowserWindowController awakeFromNib]):
2783         (-[WK2BrowserWindowController dealloc]):
2784         (-[WK2BrowserWindowController validateMenuItem:]):
2785         (-[WK2BrowserWindowController performTextFinderAction:]):
2786         (-[WK2BrowserWindowController findBarView]):
2787         (-[WK2BrowserWindowController setFindBarView:]):
2788         (-[WK2BrowserWindowController isFindBarVisible]):
2789         (-[WK2BrowserWindowController setFindBarVisible:]):
2790         (-[WK2BrowserWindowController contentView]):
2791         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
2792         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
2793         (-[WK2BrowserWindowController find:]): Deleted.
2794         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
2795         protocol. At first glance, it's pretty broken, but vaguely works.
2796
2797 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2798
2799         Share the implementation of MiniBrowser view hiding functionality
2800         https://bugs.webkit.org/show_bug.cgi?id=166800
2801
2802         Reviewed by Andy Estes.
2803
2804         * MiniBrowser/mac/BrowserWindowController.m:
2805         (-[BrowserWindowController showHideWebView:]):
2806         (-[BrowserWindowController removeReinsertWebView:]):
2807         * MiniBrowser/mac/WK1BrowserWindowController.m:
2808         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
2809         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
2810         * MiniBrowser/mac/WK2BrowserWindowController.m:
2811         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
2812         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
2813         Move the implementation of these two things to the shared superclass,
2814         since they don't depend on WebKit-specific things.
2815         Also, there was no reason to retain the (WK)WebView while it was unparented,
2816         as the BrowserWindowController maintains a reference the entire time.
2817
2818 2017-01-06  Andy Estes  <aestes@apple.com>
2819
2820         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
2821         https://bugs.webkit.org/show_bug.cgi?id=166789
2822
2823         Reviewed by Alex Christensen.
2824
2825         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2826         * DumpRenderTree/PlatformMac.cmake:
2827         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
2828         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
2829         * DumpRenderTree/mac/DumpRenderTree.mm:
2830         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2831         createXMLStringFromWebArchiveData().
2832         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
2833         * WebKitTestRunner/Configurations/Base.xcconfig:
2834         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
2835         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2836         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2837         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2838         createXMLStringFromWebArchiveData().
2839         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
2840         * WebKitTestRunner/PlatformMac.cmake:
2841         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2842         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
2843
2844 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2845
2846         Minor cleanups to IndentOutdentCommand and related code
2847         https://bugs.webkit.org/show_bug.cgi?id=166791
2848
2849         Reviewed by Simon Fraser.
2850
2851         * WebEditingTester/EditingOperations.m:
2852         (editingOperations):
2853         Add the outdent operation to WebEditingTester.
2854
2855 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
2856
2857         Create a plan and a patch files for MotionMark and delete the Animometer's ones
2858         https://bugs.webkit.org/show_bug.cgi?id=166785
2859
2860         Reviewed by Ryosuke Niwa.
2861
2862         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2863         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
2864
2865 2017-01-06  Antoine Quint  <graouts@apple.com>
2866
2867         Support webkit-test-runner key-value pairs in http tests
2868         https://bugs.webkit.org/show_bug.cgi?id=149812
2869
2870         Reviewed by Alex Christensen.
2871
2872         We pass the absolute path for a test through to WKTR so that we can parse
2873         tests that are running as URLs for webkit-test-runner options.
2874
2875         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2876         (parseInputLine):
2877
2878         Explicitly skip the --absolute-path option in DRT or else we'd crash.
2879
2880         * Scripts/webkitpy/port/driver.py:
2881         (Driver._command_from_driver_input):
2882
2883         Pass the absolute path to the file through the CLI.
2884
2885         * WebKitTestRunner/TestController.cpp:
2886         (WTR::updateTestOptionsFromTestHeader):
2887         (WTR::TestController::testOptionsForTest):
2888         (WTR::parseInputLine):
2889         (WTR::TestController::runTest):
2890         * WebKitTestRunner/TestController.h:
2891
2892 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2893
2894         Warning about unconnectable outlets when opening a MiniBrowser window
2895         https://bugs.webkit.org/show_bug.cgi?id=166756
2896
2897         Reviewed by Dan Bernstein.
2898
2899         * MiniBrowser/mac/BrowserWindow.xib:
2900         When launching MiniBrowser, it says:
2901         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
2902             (MBToolbarItem): missing setter or instance variable
2903         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
2904             (NSButtonCell): missing setter or instance variable.
2905
2906         It looks like someone added the connection from the share button
2907         to the BrowserWindowController three times; only one of the connections
2908         is valid. Remove the other two.
2909
2910 2017-01-05  Keith Rollin  <krollin@apple.com>
2911
2912         Add WebCore::URL::protocolHostAndPort
2913         https://bugs.webkit.org/show_bug.cgi?id=166426
2914
2915         Reviewed by Alex Christensen.
2916
2917         Add test for protocolHostAndPort.
2918
2919         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2920         (TestWebKitAPI::TEST_F):
2921
2922 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
2923
2924         [Win] Archive test result is failing.
2925         https://bugs.webkit.org/show_bug.cgi?id=166720
2926
2927         Reviewed by Alex Christensen.
2928
2929         Deleting the layout test result folder is sometimes failing
2930         on Windows. This is not a critical error.
2931
2932         * BuildSlaveSupport/test-result-archive:
2933         (archiveTestResults):
2934
2935 2017-01-04  Tomas Popela  <tpopela@redhat.com>
2936
2937         [GTK] Minibrowser: Add printing support
2938         https://bugs.webkit.org/show_bug.cgi?id=165298
2939
2940         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
2941         an error during the print, it's printed on the console.
2942
2943         Reviewed by Michael Catanzaro.
2944
2945         * MiniBrowser/gtk/BrowserWindow.c:
2946         (webKitPrintOperationFailedCallback):
2947         (printPage):
2948         (browser_window_init):
2949
2950 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
2951
2952         [css-grid] Fix crash clamping grid lines
2953         https://bugs.webkit.org/show_bug.cgi?id=166637
2954
2955         Reviewed by Darin Adler.
2956
2957         Creates new unit test to verify that the maximum tracks limit
2958         is used in GridPosition too.
2959
2960         * TestWebKitAPI/PlatformEfl.cmake:
2961         * TestWebKitAPI/PlatformGTK.cmake:
2962         * TestWebKitAPI/PlatformWin.cmake:
2963         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2964         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
2965         (TestWebKitAPI::TEST):
2966
2967 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2968
2969         Move editing history scripts to WebCore PrivateHeaders
2970         https://bugs.webkit.org/show_bug.cgi?id=166709
2971         <rdar://problem/29876612>
2972
2973         Reviewed by Dan Bernstein.
2974
2975         Update references to editing script files in WebCore that were moved.
2976
2977         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
2978
2979 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2980
2981         Unreviewed, build fix after r210313 part 2
2982         https://bugs.webkit.org/show_bug.cgi?id=166676
2983
2984         Add 'U' suffix.
2985
2986         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2987         (TestWebKitAPI::TEST):
2988         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2989         (TestWebKitAPI::TEST):
2990
2991 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2992
2993         Limit thread name appropriately
2994         https://bugs.webkit.org/show_bug.cgi?id=166676
2995
2996         Reviewed by Sam Weinig.
2997
2998         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2999         (TestWebKitAPI::TEST):
3000         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3001         (TestWebKitAPI::TEST):
3002
3003 2017-01-04  Andy Estes  <aestes@apple.com>
3004
3005         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
3006         https://bugs.webkit.org/show_bug.cgi?id=166696
3007
3008         Reviewed by Tim Horton.
3009
3010         * TestWebKitAPI/PlatformGTK.cmake:
3011         * TestWebKitAPI/PlatformWin.cmake:
3012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3013         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
3014         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
3015         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
3016         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
3017         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
3018         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
3019
3020 2017-01-03  Brian Burg  <bburg@apple.com>
3021
3022         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
3023         https://bugs.webkit.org/show_bug.cgi?id=166003
3024         <rdar://problem/28718990>
3025
3026         Reviewed by Joseph Pecoraro.
3027
3028         Teach run-inspector-generator-tests to generate test output using the platform name
3029         derived from the directory that the test is in. For example, tests in the /generic/
3030         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
3031
3032         * Scripts/webkitpy/inspector/main.py:
3033         (InspectorGeneratorTests.generate_from_json):
3034         (InspectorGeneratorTests.run_tests):
3035         (InspectorGeneratorTests.main):
3036
3037 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3038
3039         Unreviewed cmake buildfix after r210266.
3040
3041         * DumpRenderTree/PlatformMac.cmake:
3042
3043 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3044
3045         Provide a setting for clients to always prefer low-power WebGL
3046         https://bugs.webkit.org/show_bug.cgi?id=166675
3047         <rdar://problem/29834093>
3048
3049         Reviewed by Dan Bernstein.
3050
3051         * MiniBrowser/mac/Info.plist:
3052         Have MiniBrowser claim to be a modern app that supports
3053         automatic graphics switching. WebKit needs to support automatic
3054         graphics switching, so our test app might as well. Without this
3055         Info.plist parameter, this change has no effect, and bringing up
3056         a WebGL context still brings up the discrete GPU (also true of the
3057         existing web-exposed preferLowPowerToHighPerformance API).
3058
3059 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3060
3061         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
3062         https://bugs.webkit.org/show_bug.cgi?id=166645
3063
3064         Reviewed by Carlos Garcia Campos.
3065
3066         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3067         (TestWebKitAPI::TEST):
3068
3069 2017-01-03  Andy Estes  <aestes@apple.com>
3070
3071         Place all the Cocoa WebCore API tests in the same directory
3072         https://bugs.webkit.org/show_bug.cgi?id=166673
3073
3074         Reviewed by Michael Catanzaro.
3075
3076         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3077         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
3078         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
3079         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
3080
3081 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3082
3083         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3084         https://bugs.webkit.org/show_bug.cgi?id=166450
3085         <rdar://problem/29447824>
3086
3087         Reviewed by Darin Adler.
3088
3089         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3090         * DumpRenderTree/TestRunner.cpp:
3091         (TestRunner::staticFunctions):
3092         * DumpRenderTree/mac/TestRunnerMac.mm:
3093         (setSpellCheckerLoggingEnabledCallback):
3094         * DumpRenderTree/win/TestRunnerWin.cpp:
3095         (setSpellCheckerLoggingEnabledCallback):
3096         * DumpRenderTree/mac/DumpRenderTree.mm:
3097         (resetWebViewToConsistentStateBeforeTesting):
3098         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
3099         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
3100         (stringForCorrectionResponse):
3101         (drt_NSSpellChecker_recordResponseToCorrection):
3102         (swizzleNSSpellCheckerMethodsIfNeeded):
3103         (setSpellCheckerLoggingEnabled):
3104         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
3105         set to true, logs to stdout (which ends up in the test result) whenever
3106         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3107         is called, and then calls the original method. It is reset to false between tests.
3108
3109 2017-01-03  Sam Weinig  <sam@webkit.org>
3110
3111         Make WTF::Expected support Ref template parameters
3112         https://bugs.webkit.org/show_bug.cgi?id=166662
3113
3114         Reviewed by Alex Christensen.
3115
3116         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3117         (TestWebKitAPI::TEST):
3118         Add tests for using Ref with Expected.
3119
3120 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3121
3122         [GTK] Expose WebKitSecurityOrigin API
3123         https://bugs.webkit.org/show_bug.cgi?id=166632
3124
3125         Reviewed by Carlos Garcia Campos.
3126
3127         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3128         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
3129         (testSecurityOriginBasicConstructor):
3130         (testSecurityOriginURIConstructor):
3131         (testSecurityOriginDefaultPort):
3132         (testSecurityOriginFileURI):
3133         (testSecurityOriginDataURI):
3134         (beforeAll):
3135         (afterAll):
3136
3137 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3138
3139         [GTK] HTTP auth layout tests are flaky
3140         https://bugs.webkit.org/show_bug.cgi?id=158919
3141
3142         Reviewed by Michael Catanzaro.
3143
3144         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
3145         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
3146         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
3147         missing valac in the bots.
3148
3149 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3150
3151         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
3152         https://bugs.webkit.org/show_bug.cgi?id=165797
3153
3154         Reviewed by Michael Catanzaro.
3155
3156         Move directory ruleset after all exclude rules of Source rulset.
3157
3158         * gtk/manifest.txt.in:
3159
3160 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3161
3162         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
3163         https://bugs.webkit.org/show_bug.cgi?id=166636
3164
3165         Reviewed by Darin Adler.
3166
3167         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3168         (TestWebKitAPI::TEST):
3169
3170 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
3171
3172         [GTK] WebCore/CSSParser unit test is not being built
3173         https://bugs.webkit.org/show_bug.cgi?id=166492
3174
3175         Reviewed by Michael Catanzaro.
3176
3177         This test was introduced in r175930, but we were not building
3178         it on GTK+ port since r176015.
3179         This patch marks the test to be built again on GTK+.
3180         JFTR, the test is passing right now.
3181
3182         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
3183         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
3184
3185 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
3186
3187         AX: Expose block quote level to iOS API
3188         https://bugs.webkit.org/show_bug.cgi?id=166629
3189         <rdar://problem/29834793>
3190
3191         Reviewed by Darin Adler.
3192
3193         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3194         (AccessibilityUIElement::numberAttributeValue):
3195         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3196         (WTR::AccessibilityUIElement::numberAttributeValue):
3197
3198 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
3199
3200         SecurityOrigin::create triplet constructor does not canonicalize port
3201         https://bugs.webkit.org/show_bug.cgi?id=166624
3202
3203         Reviewed by Daniel Bates.
3204
3205         * TestWebKitAPI/PlatformGTK.cmake:
3206         * TestWebKitAPI/PlatformWin.cmake:
3207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3208         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
3209         (TestWebKitAPI::SecurityOriginTest::SetUp):
3210         (TestWebKitAPI::TEST_F):
3211
3212 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3213
3214         [GTK] Improve user agent construction
3215         https://bugs.webkit.org/show_bug.cgi?id=142074
3216
3217         Reviewed by Carlos Garcia Campos.
3218
3219         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3220         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3221         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3222         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3223         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3224         (TestWebKitAPI::TEST):
3225
3226 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3227
3228         [GTK] Improve user agent construction
3229         https://bugs.webkit.org/show_bug.cgi?id=142074
3230
3231         Reviewed by Carlos Garcia Campos.
3232
3233         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3234         (TestWebKitAPI::TEST):
3235
3236 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
3237
3238         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
3239         https://bugs.webkit.org/show_bug.cgi?id=166472
3240         rdar://problem/29675551
3241
3242         Reviewed by Tim Horton.
3243
3244         These changes are necessary to allow the mouse to leave the WTR window while
3245         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
3246         (which DRT does); we'd always go through mouseMoved, which hits an early return
3247         in WebViewImpl::mouseMoved() when the point is outside the view.
3248
3249         * WebKitTestRunner/mac/EventSenderProxy.mm:
3250         (WTR::EventSenderProxy::mouseMoveTo):
3251
3252 2016-12-23  Andy Estes  <aestes@apple.com>
3253
3254         [iOS] Fix some crashing webarchive tests
3255         https://bugs.webkit.org/show_bug.cgi?id=166470
3256
3257         Reviewed by Andreas Kling.
3258
3259         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
3260         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
3261         so this change uses that on both platforms.
3262
3263         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
3264         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
3265         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
3266         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
3267         * WebKitTestRunner/PlatformMac.cmake:
3268         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3269         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3270
3271 2016-12-22  Saam Barati  <sbarati@apple.com>
3272
3273         WebAssembly: Silence the output of the spec-tests
3274         https://bugs.webkit.org/show_bug.cgi?id=166417
3275
3276         Reviewed by Mark Lam.
3277
3278         * Scripts/run-jsc-stress-tests:
3279
3280 2016-12-22  Zhuo Li  <zachli@apple.com>
3281
3282         [Cocoa] SPI for setloadsImagesAutomatically.
3283         https://bugs.webkit.org/show_bug.cgi?id=166401.
3284
3285         Reviewed by Darin Adler.
3286
3287         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3288         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3289         _loadsImagesAutomatically returns YES.
3290
3291 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3292
3293         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3294         https://bugs.webkit.org/show_bug.cgi?id=161328
3295         <rdar://problem/28475977>
3296
3297         Reviewed by Darin Adler.
3298
3299         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3300         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3301         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3302         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3303         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3304         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3305         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3306         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3307         we finish running a test and before we load the next test.
3308
3309         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3310         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3311         previous test started zooming and then finished before zooming completed. Since this happens before the next
3312         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3313
3314         * WebKitTestRunner/ios/TestControllerIOS.mm:
3315         (WTR::TestController::platformResetStateToConsistentValues):
3316
3317 2016-12-22  Jer Noble  <jer.noble@apple.com>
3318
3319         Muted media element playback should not interrupt other audio playback
3320         https://bugs.webkit.org/show_bug.cgi?id=166347
3321
3322         Reviewed by Eric Carlson.
3323
3324         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3325         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3326         (TestWebKitAPI::TEST):
3327         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3328
3329 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3330
3331         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3332         https://bugs.webkit.org/show_bug.cgi?id=166346
3333
3334         Reviewed by Carlos Garcia Campos.
3335
3336         Enable WebRTC by default to simplify testing.
3337
3338         * MiniBrowser/gtk/main.c:
3339         (main):
3340
3341 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3342
3343         REGRESSION: API test failure: WKWebView.LocalStorageClear
3344         https://bugs.webkit.org/show_bug.cgi?id=166032
3345         <rdar://problem/29758423>
3346
3347         Reviewed by Simon Fraser.
3348
3349         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3350         to ensure that the view is destroyed before the callback fires.
3351
3352         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3353         (TEST):
3354
3355 2016-12-21  Saam Barati  <sbarati@apple.com>
3356
3357         WebAssembly: Import spec tests
3358         https://bugs.webkit.org/show_bug.cgi?id=166395
3359
3360         Rubber stamped by Keith Miller.
3361
3362         * Scripts/run-jsc-stress-tests:
3363
3364 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3365
3366         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3367         https://bugs.webkit.org/show_bug.cgi?id=166033
3368         <rdar://problem/29758428>
3369
3370         Reviewed by Simon Fraser.
3371
3372         Add an @autoreleasepool around the code that allocates the WKWebView, 
3373         so that it can be destroyed by removing the last reference in _downloadDidStart.
3374
3375         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3376         (TEST):
3377
3378 2016-12-21  Daniel Bates  <dabates@apple.com>
3379
3380         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3381         https://bugs.webkit.org/show_bug.cgi?id=166356
3382
3383         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3384         as a means to allow a test to explicit allow an embedding client to open a new windows
3385         such that the default behavior is for the embedding client to forbid such an action.
3386         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3387         it is currently skipped on WebKit2 because questions were raised in the patch for
3388         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3389         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3390         this test.
3391
3392         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3393         (WTR::TestRunner::setCanOpenWindows):
3394
3395 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3396
3397         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3398         https://bugs.webkit.org/show_bug.cgi?id=166031
3399
3400         Reviewed by Tim Horton.
3401         
3402         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3403         to ensure that the view is destroyed before the callback fires.
3404
3405         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3406
3407 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3408
3409         Throw Exception when test doesn't clean up HID Events properly
3410         https://bugs.webkit.org/show_bug.cgi?id=166271
3411
3412         Reviewed by Simon Fraser.
3413
3414         Add in a check when UIScriptController is deleted to make sure that the HID event
3415         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3416         the program to crash without any good information. Crashes are race-y, and will still
3417         happen with malformed test, but the information will be much more helpful. 
3418
3419         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3420         (WTR::UIScriptController::checkForClean):
3421         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3422         (UIScriptContext::~UIScriptContext):
3423         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3424         (WTR::UIScriptController::checkForClean):
3425         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3426         * WebKitTestRunner/ios/HIDEventGenerator.h:
3427         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3428         (-[HIDEventGenerator checkHIDCallbacksClear]):
3429         * WebKitTestRunner/ios/TestControllerIOS.mm:
3430         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3431         (WTR::UIScriptController::checkForClean):
3432
3433 2016-12-20  Andy Estes  <aestes@apple.com>
3434
3435         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3436         https://bugs.webkit.org/show_bug.cgi?id=165992
3437
3438         Reviewed by Brady Eidson.
3439
3440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3441         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3442         (expectException):
3443         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3444         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3445         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3446         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3447         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3448         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3449         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3450         (TEST):
3451         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3452
3453 2016-12-20  Dean Jackson  <dino@apple.com>
3454
3455         Remove INDIE_UI
3456         https://bugs.webkit.org/show_bug.cgi?id=165881
3457         <rdar://problem/29672532>
3458
3459         Reviewed by Simon Fraser.
3460
3461         The Indie UI work has been discontinued.
3462
3463         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3464
3465 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3466
3467         [ES6] Enable ES6 Modules
3468         https://bugs.webkit.org/show_bug.cgi?id=165849
3469
3470         Reviewed by Geoffrey Garen.
3471
3472         * DumpRenderTree/mac/DumpRenderTree.mm:
3473         (resetWebPreferencesToConsistentValues):
3474         * DumpRenderTree/win/DumpRenderTree.cpp:
3475         (resetWebPreferencesToConsistentValues):
3476         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3477         (WTR::InjectedBundle::beginTesting):
3478         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3479         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3480         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3481
3482 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3483
3484         Repurpose bots and clean up dashboard.
3485         https://bugs.webkit.org/show_bug.cgi?id=166045
3486
3487         Reviewed by Lucas Forschler.
3488
3489         * BuildSlaveSupport/build.webkit.org-config/config.json:
3490         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3491         (BubbleQueueServer):
3492         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3493         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3494         (WebKitBuildbot):
3495         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3496         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3497
3498 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3499
3500         [CMake] TestWebKitAPIBase links to itself
3501         https://bugs.webkit.org/show_bug.cgi?id=165985
3502
3503         Reviewed by Alex Christensen.
3504
3505         Fix CMake warning about a target linking to itself, which makes no sense.
3506
3507         * TestWebKitAPI/CMakeLists.txt:
3508
3509 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3510
3511         [GTK] GtkDoc build should be quieter
3512         https://bugs.webkit.org/show_bug.cgi?id=165994
3513
3514         Reviewed by Carlos Garcia Campos.
3515
3516         Make it not print by default.
3517
3518         * gtk/generate-gtkdoc:
3519         (get_generator_for_config):
3520         (generate_doc):
3521         * gtk/gtkdoc.py:
3522         (GTKDoc._run_command):
3523         (GTKDoc._copy_doc_files_to_output_dir):
3524
3525 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3526
3527         Expose a way for MiniBrowser to simulate header and footer banners
3528         https://bugs.webkit.org/show_bug.cgi?id=166005
3529
3530         Reviewed by Wenson Hsieh.
3531         
3532         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3533         banners. This only works in WebKit2.
3534         
3535         We need to reset these on each navigation, since newly created FrameViews
3536         don't re-fetch the header and footer height stored on Page.
3537         
3538         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3539         as well as fixing webViewWebContentProcessDidTerminate:
3540
3541         * MiniBrowser/mac/SettingsController.h:
3542         * MiniBrowser/mac/SettingsController.m:
3543         (-[SettingsController _populateMenu]):
3544         (-[SettingsController validateMenuItem:]):
3545         (-[SettingsController toggleReserveSpaceForBanners:]):
3546         (-[SettingsController isSpaceReservedForBanners]):
3547         * MiniBrowser/mac/WK2BrowserWindowController.m:
3548         (-[WK2BrowserWindowController didChangeSettings]):
3549         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3550         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3551         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3552         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3553
3554 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3555
3556         Fix iOS test results after r209967.
3557         
3558         Subtracting out the status bar height was erroneously happening for all tests,
3559         not just for flexible viewport tests.
3560         
3561         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3562
3563         * WebKitTestRunner/PlatformWebView.h:
3564         * WebKitTestRunner/TestController.cpp:
3565         (WTR::TestController::resetStateToConsistentValues):
3566         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3567         (WTR::PlatformWebView::resizeTo):
3568         (WTR::PlatformWebView::setWindowFrame):
3569         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3570         (WTR::PlatformWebView::resizeTo):
3571         (WTR::PlatformWebView::setWindowFrame):
3572         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3573         (WTR::PlatformWebView::resizeTo):
3574         (WTR::PlatformWebView::setWindowFrame):
3575         * WebKitTestRunner/ios/TestControllerIOS.mm:
3576         (WTR::TestController::platformConfigureViewForTest):
3577         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3578         (WTR::PlatformWebView::resizeTo):
3579         (WTR::PlatformWebView::setWindowFrame):
3580
3581 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3582
3583         [EFL] bump EFL version to 1.18.4
3584         https://bugs.webkit.org/show_bug.cgi?id=166004
3585
3586         Reviewed by Gyuyoung Kim.
3587
3588         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3589
3590 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3591
3592         Visual viewports: bottom fixed elements disappear behind the keyboard
3593         https://bugs.webkit.org/show_bug.cgi?id=165983
3594         <rdar://problem/29409852>
3595
3596         Reviewed by Simon Fraser.
3597
3598         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
3599         the keyboard when it is up.
3600
3601         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3602         (WTR::UIScriptController::inputViewBounds):
3603         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3604         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3605         (WTR::UIScriptController::inputViewBounds):
3606         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3607         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3608         (WTR::viewRectForWindowRect):
3609
3610         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
3611         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
3612         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
3613
3614         (WTR::PlatformWebView::PlatformWebView):
3615         (WTR::PlatformWebView::setWindowFrame):
3616         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3617         (WTR::UIScriptController::inputViewBounds):
3618
3619 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3620
3621         Deleting a character converted from pinyin after an image causes a Safari crash
3622         https://bugs.webkit.org/show_bug.cgi?id=165839
3623         <rdar://problem/27951933>
3624
3625         Reviewed by Wenson Hsieh.
3626
3627         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
3628         while the proposed range contains an image. This should not cause a WebProcess to crash
3629         or send an invalid message to the UIProcess.
3630
3631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3632         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
3633         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
3634         (TestWebKitAPI::didFinishLoadForFrame):
3635         (TestWebKitAPI::processDidCrash):
3636         (TestWebKitAPI::invalidMessageFunction):
3637         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
3638
3639 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3640
3641         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
3642         https://bugs.webkit.org/show_bug.cgi?id=165767
3643         <rdar://problem/29602382>
3644
3645         Reviewed by Simon Fraser.
3646
3647         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
3648         WebKit2 ChangeLog for more details.
3649
3650         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3651         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3652         (WTR::UIScriptController::textSelectionCaretRect):
3653         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3654         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3655         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3656         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3657         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3658         (WTR::UIScriptController::textSelectionCaretRect):
3659         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3660         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3661         (-[TestRunnerWKWebView _setStableStateOverride:]):
3662
3663         Force the WKWebView to update its visible content rects when changing the stable state override.
3664
3665         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3666         (WTR::toNSDictionary):
3667         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3668         (WTR::UIScriptController::selectionRangeViewRects):
3669         (WTR::UIScriptController::textSelectionCaretRect):
3670         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3671         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3672
3673 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
3674
3675         Arguments called in wrong order
3676         https://bugs.webkit.org/show_bug.cgi?id=165923
3677
3678         Reviewed by Simon Fraser.
3679
3680         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
3681         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
3682
3683         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3684         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
3685         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
3686
3687 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
3688
3689         [EFL] Disable non-srcdir builds for failing libraries
3690         https://bugs.webkit.org/show_bug.cgi?id=165896
3691
3692         Reviewed by Gyuyoung Kim.
3693
3694         * efl/jhbuild.modules: Set non srcdir builds to no
3695
3696 2016-12-15  Daniel Bates  <dabates@apple.com>
3697
3698         check-style should not complain about code in icu directories
3699         https://bugs.webkit.org/show_bug.cgi?id=53929
3700
3701         Reviewed by Darin Adler.
3702
3703         Skip style checking of imported ICU headers to avoid a deluge of style issues
3704         as they do not conform to the WebKit Code Style guideline. We want to preserve
3705         the formatting of these headers so as to make it straightforward to merge
3706         changes to them, if necessary.
3707
3708         * Scripts/webkitpy/style/checker.py:
3709
3710 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
3711
3712         Move JSC testers from Yosemite to Sierra
3713         https://bugs.webkit.org/show_bug.cgi?id=165925
3714
3715         Reviewed by Lucas Forschler.
3716
3717         * BuildSlaveSupport/build.webkit.org-config/config.json:
3718         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3719         (WebKitBuildbot):
3720
3721 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
3722
3723         Add coordinate space to event streams and streamline tests
3724         https://bugs.webkit.org/show_bug.cgi?id=165119
3725
3726         Reviewed by Simon Fraser.
3727
3728         Update event streams to allow for both content and global coordinate space.
3729         Update example script to more accurately show all the available options.
3730
3731         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3732         * WebKitTestRunner/ios/HIDEventGenerator.h:
3733         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3734         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3735         (WTR::convertCoordinates):
3736         (WTR::UIScriptController::sendEventStream):
3737
3738 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
3739
3740         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
3741         https://bugs.webkit.org/show_bug.cgi?id=165855
3742
3743         Reviewed by Philippe Normand.
3744
3745         GStreamer's autogen.sh enables gtk-doc always so we end up building
3746         docs even if we disable them. Use the configure script instead, since
3747         we build from packages and these include it already.
3748
3749         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
3750         upstream gstreamer packages.
3751
3752 2016-12-15  Alex Christensen  <achristensen@webkit.org>
3753
3754         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
3755         https://bugs.webkit.org/show_bug.cgi?id=165885
3756         <rdar://problem/29476917>
3757
3758         Reviewed by Darin Adler.
3759
3760         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3761         (TestWebKitAPI::utf16String): Deleted.
3762         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
3763         (TestWebKitAPI::TEST_F):
3764         * TestWebKitAPI/WTFStringUtilities.h:
3765         (utf16String):
3766         Moved from URLParser to share with other tests.
3767
3768 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3769
3770         iOS: An element with tabindex is not focusable unless there is no mouse event handler
3771         https://bugs.webkit.org/show_bug.cgi?id=165843
3772
3773         Reviewed by Antti Koivisto.
3774
3775         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
3776         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
3777         and DumpRenderTree's runUIScript would hit an assertion :(
3778
3779         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3780         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3781         (WTR::TestRunner::isWebKit2):
3782
3783 2016-12-14  Brady Eidson  <beidson@apple.com>
3784
3785         IndexedDB 2.0: Massively speedup IDBIndex.get().
3786         https://bugs.webkit.org/show_bug.cgi?id=165802
3787
3788         Reviewed by Alex Christensen.
3789
3790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3791         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
3792         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
3793         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
3794         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
3795
3796 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3797
3798         [GTK][EFL] Update the JHBuild version.
3799         https://bugs.webkit.org/show_bug.cgi?id=165838
3800
3801         Reviewed by Michael Catanzaro.
3802
3803         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
3804         usage of the JHBUILD_MIRROR feature with git repositories.
3805
3806 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3807
3808         [GTK] Yasm is needed for building the JHBuild after r208940
3809         https://bugs.webkit.org/show_bug.cgi?id=165837
3810
3811         Reviewed by Alejandro G. Castro.
3812
3813         * gtk/install-dependencies: Yasm is needed for building libvpx.
3814
3815 2016-12-14  Youenn Fablet  <youenn@apple.com>
3816
3817         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
3818         https://bugs.webkit.org/show_bug.cgi?id=161310
3819
3820         Reviewed by Ryosuke Niwa.
3821
3822         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
3823         When set, WTR and DRT output JS console log in the stderr and not the test output.
3824         This allows removing potentially flaky information while still being able to read it for investigation.
3825
3826         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
3827
3828         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
3829         This test should have this option when fetch API will start logging resource loader errors.
3830
3831         * DumpRenderTree/DumpRenderTree.h:
3832         (TestCommand::TestCommand): Deleted.
3833         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3834         (parseInputLine):
3835         * DumpRenderTree/TestRunner.h:
3836         (TestRunner::setDumpJSConsoleLogInStdErr):
3837         (TestRunner::dumpJSConsoleLogInStdErr):
3838         * DumpRenderTree/mac/DumpRenderTree.mm:
3839         (runTest):
3840         * DumpRenderTree/mac/UIDelegate.mm:
3841         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3842         * DumpRenderTree/win/DumpRenderTree.cpp:
3843         (runTest):
3844         * DumpRenderTree/win/UIDelegate.cpp:
3845         (UIDelegate::webViewAddMessageToConsole):
3846         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3847         (TestExpectationParser._tokenize_line):
3848         * Scripts/webkitpy/port/driver.py:
3849         (Driver._command_from_driver_input):
3850         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3851         (WTR::InjectedBundle::didReceiveMessageToPage):
3852         (WTR::InjectedBundle::dumpToStdErr):
3853         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3854         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
3855         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3856         (WTR::InjectedBundlePage::willAddMessageToConsole):
3857         * WebKitTestRunner/TestController.cpp:
3858         (WTR::parseInputLine):
3859         (WTR::TestController::runTest):
3860         (WTR::TestCommand::TestCommand): Deleted.
3861         * WebKitTestRunner/TestInvocation.cpp:
3862         (WTR::TestInvocation::invoke):
3863         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3864         * WebKitTestRunner/TestInvocation.h:
3865         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
3866
3867
3868 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
3869
3870         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
3871         https://bugs.webkit.org/show_bug.cgi?id=164022
3872
3873         Reviewed by Xabier Rodriguez-Calvar.
3874
3875         * Scripts/webkitperl/FeatureList.pm:
3876           Re-enable MEDIA_SOURCE for the GTK+ port.
3877
3878 2016-12-13  Alex Christensen  <achristensen@webkit.org>
3879
3880         Fix CMake build.
3881
3882         * DumpRenderTree/PlatformMac.cmake:
3883         Define NS_RETURNS_RETAINED as nothing for now.
3884
3885 2016-12-13  Jer Noble  <jer.noble@apple.com>
3886
3887         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
3888         https://bugs.webkit.org/show_bug.cgi?id=165697
3889
3890         Reviewed by Tim Horton.
3891
3892         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
3893         (TestWebKitAPI::TEST):
3894
3895 2016-12-13  Andy Estes  <aestes@apple.com>
3896
3897         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
3898         https://bugs.webkit.org/show_bug.cgi?id=165785
3899         <rdar://problem/26929398>
3900
3901         Reviewed by Darin Adler.
3902
3903         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3904         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
3905         expectations for the text, range, and action.
3906         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
3907         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
3908         plain-text string to the pasteboard, executed a paste action, and verified that the selected
3909         text in the web view did not change.
3910         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
3911         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
3912         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
3913         parameter.
3914         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
3915         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
3916         and returned the value of _editingDelegateShouldInsertText.
3917         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
3918         -shouldInsertText:replacingRange:givenAction:.
3919
3920 2016-12-13  Chris Dumez  <cdumez@apple.com>
3921
3922         Unreviewed, rolling out r209544.
3923
3924         Looks like r209489 did not cause the performance regression
3925         after all
3926
3927         Reverted changeset:
3928
3929         "Unreviewed, rolling out r209489."
3930         https://bugs.webkit.org/show_bug.cgi?id=165550
3931         http://trac.webkit.org/changeset/209544
3932
3933 2016-12-12  Sam Weinig  <sam@webkit.org>
3934
3935         [WebIDL] Remove use of Dictionary in ApplePaySession
3936         https://bugs.webkit.org/show_bug.cgi?id=165787
3937
3938         Reviewed by Anders Carlsson.
3939
3940         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3941         (WTR::initializeWebViewConfiguration):
3942         (WTR::TestController::platformCreateWebView):
3943         Enable ApplePay for the tests (where supported).
3944
3945 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
3946
3947         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3948         https://bugs.webkit.org/show_bug.cgi?id=165251
3949
3950         Reviewed by Youenn Fablet.
3951
3952         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
3953         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
3954         the preferences have been set.
3955
3956 2016-12-08  Antti Koivisto  <antti@apple.com>
3957
3958         Enable network cache speculative revalidation in MiniBrowser
3959         https://bugs.webkit.org/show_bug.cgi?id=165616
3960
3961         Reviewed by Darin Adler.
3962
3963         Match Safari. Also add a menu item to disable it.
3964
3965         * MiniBrowser/mac/AppDelegate.m:
3966         (defaultConfiguration):
3967         * MiniBrowser/mac/SettingsController.h:
3968         * MiniBrowser/mac/SettingsController.m:
3969         (-[SettingsController _populateMenu]):
3970         (-[SettingsController validateMenuItem:]):
3971         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
3972         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
3973
3974 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
3975
3976         ChangeLogs become readonly after resolving a conflict
3977         https://bugs.webkit.org/show_bug.cgi?id=165440
3978         rdar://problem/29491002
3979
3980         Reviewed by Darin Adler.
3981
3982         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
3983         moving the file.
3984
3985 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
3986
3987         Re-enable collectContinuously since it doesn't crash anymore
3988
3989         Rubber stamped by Michael Saboff.
3990
3991         * Scripts/run-jsc-stress-tests:
3992
3993 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
3994
3995         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
3996         https://bugs.webkit.org/show_bug.cgi?id=165686
3997
3998         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
3999         so that right config.h comes first in include path.
4000
4001 2016-12-11  Dave Hyatt  <hyatt@apple.com>
4002
4003         [CSS Parser] Make sure content extensions initialize AtomicString
4004         https://bugs.webkit.org/show_bug.cgi?id=165737
4005
4006         Reviewed by Darin Adler.
4007
4008         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4009         (TestWebKitAPI::makeBackend):
4010
4011 2016-12-08  Dave Hyatt  <hyatt@apple.com>
4012
4013         [CSS Parser] Remove the old CSS Parser
4014         https://bugs.webkit.org/show_bug.cgi?id=165645
4015
4016         Reviewed by Daniel Bates.
4017
4018         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
4019         (TestWebKitAPI::TEST):
4020
4021 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
4022
4023         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
4024         https://bugs.webkit.org/show_bug.cgi?id=165686
4025
4026         Reviewed by Michael Catanzaro.
4027
4028         This change reduces duplication of include path lists between modules,
4029         and reduces future need for fixes like r209605 (broken build because of
4030         WebCore header suddenly becoming used in WebKit2).
4031
4032         * DumpRenderTree/CMakeLists.txt:
4033         * DumpRenderTree/PlatformMac.cmake:
4034         * ImageDiff/CMakeLists.txt:
4035         * MiniBrowser/gtk/CMakeLists.txt:
4036         * MiniBrowser/mac/CMakeLists.txt:
4037         * MiniBrowser/win/CMakeLists.txt:
4038         * TestWebKitAPI/CMakeLists.txt:
4039         * TestWebKitAPI/PlatformEfl.cmake:
4040         * TestWebKitAPI/PlatformJSCOnly.cmake:
4041         * TestWebKitAPI/PlatformMac.cmake:
4042         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
4043         * WebKitTestRunner/CMakeLists.txt:
4044         * WebKitTestRunner/PlatformGTK.cmake:
4045         * WebKitTestRunner/PlatformMac.cmake:
4046
4047 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
4048
4049         Unreviewed buildfix after r209630.
4050
4051         * Scripts/build-jsc: Remove building the non-existing testWASM.
4052
4053 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
4054
4055         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
4056         https://bugs.webkit.org/show_bug.cgi?id=165251
4057
4058         Reviewed by Dean Jackson.
4059
4060         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
4061
4062         * DumpRenderTree/mac/DumpRenderTree.mm:
4063         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
4064
4065         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4066         (WTR::InjectedBundle::beginTesting): Ditto.
4067
4068         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4069         (WTR::TestRunner::setMediaStreamEnabled): New.
4070         (WTR::TestRunner::setPeerConnectionEnabled): New.
4071         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4072
4073 2016-12-09  Brady Eidson  <beidson@apple.com> 
4074  
4075         Re-landing:
4076         Add _WKIconLoadingDelegate SPI. 
4077         https://bugs.webkit.org/show_bug.cgi?id=164894 
4078  
4079         Reviewed by Alex Christensen. 
4080         
4081         Add MiniBrowser support for this new SPI, configurable with a setting. 
4082  
4083         * MiniBrowser/mac/SettingsController.h: 
4084         * MiniBrowser/mac/SettingsController.m: 
4085         (-[SettingsController _populateMenu]): 
4086         (-[SettingsController validateMenuItem:]): 
4087         (-[SettingsController loadsAllSiteIcons]): 
4088         (-[SettingsController toggleLoadsAllSiteIcons:]): 
4089         * MiniBrowser/mac/WK2BrowserWindowController.m: 
4090         (-[WK2BrowserWindowController awakeFromNib]): 
4091         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
4092
4093 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
4094
4095         Fix the 32-bit build.
4096
4097         Unreviewed build fix.
4098
4099         * MiniBrowser/mac/SettingsController.h:
4100
4101 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4102
4103         Fedora also needs a PHP7 config file alternative
4104         https://bugs.webkit.org/show_bug.cgi?id=165606
4105
4106         Reviewed by Michael Catanzaro.
4107
4108         * Scripts/webkitpy/port/base.py:
4109         (Port._is_fedora_php_version_7): check for the php7 library.
4110         (Port._fedora_php_version): get the appropriate filename for Fedora.
4111         (Port._apache_config_file_name_for_platform):
4112
4113 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
4114
4115         Complete the revert of r208865.
4116         https://bugs.webkit.org/show_bug.cgi?id=164894
4117
4118         Unreviewed build fix.
4119
4120         * MiniBrowser/mac/SettingsController.h:
4121         * MiniBrowser/mac/SettingsController.m:
4122         (-[SettingsController _populateMenu]):
4123         (-[SettingsController validateMenuItem:]):
4124         (-[SettingsController loadsAllSiteIcons]): Deleted.
4125         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
4126         * MiniBrowser/mac/WK2BrowserWindowController.m:
4127         (-[WK2BrowserWindowController awakeFromNib]):
4128         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
4129
4130 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4131
4132         [GTK] Force GDK backend to x11 when running with XvfbDriver
4133         https://bugs.webkit.org/show_bug.cgi?id=165612
4134
4135         Reviewed by Michael Catanzaro.
4136
4137         When the developer is running a Wayland session, GDK may get confused
4138         and try to use its Wayland backend (which is higher priority) instead.
4139         This ensures it will use the appropriate backend when running under
4140         Xvfb.
4141
4142         * Scripts/webkitpy/port/gtk.py:
4143         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
4144         force GDK_BACKEND to x11.
4145
4146 2016-12-08  Keith Miller  <keith_miller@apple.com>
4147
4148         Add 64-bit signed LEB decode method
4149         https://bugs.webkit.org/show_bug.cgi?id=165630
4150
4151         Reviewed by Ryosuke Niwa.
4152
4153         Add tests for LEB int64 and uint64 decode since I guess
4154         I forgot to add tests before.
4155
4156         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
4157         (TestWebKitAPI::testUInt32LEBDecode):
4158         (TestWebKitAPI::TEST):
4159         (TestWebKitAPI::testUInt64LEBDecode):
4160         (TestWebKitAPI::testInt32LEBDecode):
4161         (TestWebKitAPI::testInt64LEBDecode):
4162         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
4163
4164 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
4165
4166         Make it easy to enable --force-collectContinuously
4167         https://bugs.webkit.org/show_bug.cgi?id=165638
4168
4169         Reviewed by Keith Miller.
4170
4171         * Scripts/run-javascriptcore-tests:
4172         (runJSCStressTests):
4173
4174 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
4175
4176         Disable the collectContinuously mode until I investigate failures.
4177
4178         Rubber stamped by Keith Miller.
4179         
4180         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
4181         while I investigate.
4182
4183         * Scripts/run-jsc-stress-tests:
4184
4185 2016-12-08  Alex Christensen  <achristensen@webkit.org>
4186
4187         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
4188         https://bugs.webkit.org/show_bug.cgi?id=165621
4189
4190         Reviewed by Dan Bernstein.
4191
4192         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4193         (TestWebKitAPI::TEST_F):
4194
4195 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
4196
4197         Concurrent GC should be stable enough to land enabled
4198         https://bugs.webkit.org/show_bug.cgi?id=164990
4199
4200         Reviewed by Geoffrey Garen.
4201         
4202         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
4203         
4204         It's clear that this works just fine in release, but I'm still trying to figure out if it's
4205         safe for debug. It might be too slow for debug.
4206
4207         * Scripts/run-jsc-stress-tests:
4208
4209 2016-12-08  Alex Christensen  <achristensen@webkit.org>
4210
4211         Add SPI for sending WebsiteSettings to WebProcess during navigation
4212         https://bugs.webkit.org/show_bug.cgi?id=165517
4213         <rdar://29341068>
4214
4215         Reviewed by Anders Carlsson.
4216
4217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4218         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
4219         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
4220         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4221         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
4222         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4223         (TEST):
4224
4225 2016-12-08  Chris Dumez  <cdumez@apple.com>
4226
4227         Unreviewed, rolling out r209489.
4228
4229         Likely caused large regressions on JetStream, Sunspider and
4230         Speedometer
4231
4232         Reverted changeset:
4233
4234         "Add system trace points for JavaScript VM entry/exit"
4235         https://bugs.webkit.org/show_bug.cgi?id=165550
4236         http://trac.webkit.org/changeset/209489
4237
4238 2016-12-08  Keith Miller  <keith_miller@apple.com>
4239
4240         Move LEB tests to API tests
4241         https://bugs.webkit.org/show_bug.cgi?id=165586
4242
4243         Reviewed by Saam Barati.
4244
4245         Move the tests from testWasm.cpp and make them functions
4246         rather than macros.
4247
4248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4249         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
4250         (TestWebKitAPI::testUnsignedLEBDecode):
4251         (TestWebKitAPI::TEST):
4252         (TestWebKitAPI::testInt32LEBDecode):
4253
4254 2016-12-08  Chris Dumez  <cdumez@apple.com>
4255
4256         Support running the layout tests offline
4257         https://bugs.webkit.org/show_bug.cgi?id=165534
4258
4259         Reviewed by Ryosuke Niwa.
4260
4261         * Scripts/webkitpy/common/system/autoinstall.py:
4262         (AutoInstaller._download_to_stream):
4263         getcode() returns None for file URLs so handle this.
4264
4265         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
4266         (WebPlatformTestServer._install_modules):
4267         Deal with local path in the json file and resolve them into file URLs
4268         before using AutoInstall.
4269
4270 2016-12-08  Alex Christensen  <achristensen@webkit.org>
4271
4272         Fix CMake build.
4273
4274         * DumpRenderTree/PlatformMac.cmake:
4275         Remove CheckedMalloc.cpp after r209516.
4276
4277 2016-12-07  Mark Lam  <mark.lam@apple.com>
4278
4279         DumpRenderTree should stop using CheckedMalloc.
4280         https://bugs.webkit.org/show_bug.cgi?id=165563
4281         <rdar://problem/28945820>
4282
4283         Reviewed by Geoffrey Garen.
4284
4285         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
4286            in CheckedMalloc.
4287         2. bmalloc does not honor the settings of CheckedMalloc.
4288
4289         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
4290         malloc.  As a result, DRT exhibits different behavior from the normal way we run
4291         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
4292         with WKTR.
4293
4294         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4295         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
4296         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
4297         * DumpRenderTree/mac/DumpRenderTree.mm:
4298         (prepareConsistentTestingEnvironment):
4299
4300 2016-12-07  Dean Jackson  <dino@apple.com>
4301
4302         Remove runtime toggle for pointer-lock
4303         https://bugs.webkit.org/show_bug.cgi?id=165577
4304         <rdar://problems/29566996>
4305
4306         Reviewed by Jon Lee.
4307
4308         Remove any runtime calls to check if pointer-lock is enabled. It's
4309         either compiled in or out.
4310
4311         * DumpRenderTree/mac/DumpRenderTree.mm:
4312         (resetWebPreferencesToConsistentValues):
4313         * WebKitTestRunner/TestController.cpp:
4314         (WTR::TestController::resetPreferencesToConsistentValues):
4315
4316 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
4317
4318         [MediaStream][Mac] Revoke sandbox extensions when capture ends
4319         https://bugs.webkit.org/show_bug.cgi?id=165476
4320
4321         Reviewed by Brady Eidson.
4322         
4323         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
4324         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
4325         is reset and recreated when a web page exits and is reloaded.
4326