Implement basic authentication in MiniBrowser
[WebKit-https.git] / Tools / ChangeLog
1 2017-06-16  Alex Christensen  <achristensen@webkit.org>
2
3         Implement basic authentication in MiniBrowser
4         https://bugs.webkit.org/show_bug.cgi?id=173443
5
6         Reviewed by Tim Horton.
7
8         * MiniBrowser/mac/WK2BrowserWindowController.m:
9         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
10
11 2017-06-16  Jer Noble  <jer.noble@apple.com>
12
13         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
14         https://bugs.webkit.org/show_bug.cgi?id=173398
15         <rdar://problem/32592961>
16
17         Reviewed by Eric Carlson.
18
19         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
21         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
22         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
23         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
24         (TestWebKitAPI::TEST):
25         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
26
27 2017-06-16  Matt Lewis  <jlewis3@apple.com>
28
29         Unreviewed, rolling out r218375.
30
31         The API test MediaStreamTrackDetached is still timing out
32         after the patch
33
34         Reverted changeset:
35
36         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
37         reports no recording to WebKit clients"
38         https://bugs.webkit.org/show_bug.cgi?id=173398
39         http://trac.webkit.org/changeset/218375
40
41 2017-06-15  Jer Noble  <jer.noble@apple.com>
42
43         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
44         https://bugs.webkit.org/show_bug.cgi?id=173398
45         <rdar://problem/32592961>
46
47         Reviewed by Eric Carlson.
48
49         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
50         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
51         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
52         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
53         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
54         (TestWebKitAPI::TEST):
55         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
56
57 2017-06-15  Matt Lewis  <jlewis3@apple.com>
58
59         Unreviewed, rolling out r218365.
60
61         The revision caused API timeouts on all builds.
62
63         Reverted changeset:
64
65         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
66         reports no recording to WebKit clients"
67         https://bugs.webkit.org/show_bug.cgi?id=173398
68         http://trac.webkit.org/changeset/218365
69
70 2017-06-15  Jer Noble  <jer.noble@apple.com>
71
72         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
73         https://bugs.webkit.org/show_bug.cgi?id=173398
74         <rdar://problem/32592961>
75
76         Reviewed by Eric Carlson.
77
78         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
79         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
80         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
81         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
82         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
83         (TestWebKitAPI::TEST):
84         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
85
86 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
87
88         REGRESSION(r218344): [WPE] Thousands of layout test crashes
89         https://bugs.webkit.org/show_bug.cgi?id=173433
90
91         Unreviewed.
92
93         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
94
95 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
96
97         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
98         https://bugs.webkit.org/show_bug.cgi?id=173061
99
100         Reviewed by Žan Doberšek.
101
102         Launch dyz <https://github.com/Igalia/dyz> with the script
103         run-minibrowser for the wpe port. It is now built as part of the
104         WPE dependencies with JHBuild.
105
106         * Scripts/run-minibrowser:
107         * Scripts/webkitdirs.pm:
108         (launcherPath):
109         (launcherName):
110         * wpe/install-dependencies: Luajit is needed for building dyz.
111         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
112
113 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
114
115         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
116         https://bugs.webkit.org/show_bug.cgi?id=173338
117         <rdar://problem/32777720>
118
119         Reviewed by Tim Horton.
120
121         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
122         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
123         these remaining items on drop.
124
125         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
126         (TestWebKitAPI::TEST):
127         * TestWebKitAPI/ios/DataInteractionSimulator.h:
128         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
129
130         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
131
132         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
133
134 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
135
136         [Win] Crash in accessibility layout test.
137         https://bugs.webkit.org/show_bug.cgi?id=173401
138
139         Reviewed by Brent Fulgham.
140
141         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
142         member will be automatically released when the _variant_t object goes out of scope if the vt member
143         does not equal VT_UNKNOWN | VT_BYREF.
144         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
145
146         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
147         (AccessibilityUIElement::titleUIElement):
148
149 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
150
151         [GTK] Add API to allow overriding popup menus
152         https://bugs.webkit.org/show_bug.cgi?id=172905
153
154         Reviewed by Michael Catanzaro.
155
156         Add a unit test to check the new API.
157
158         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
159         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
160         (OptionMenuTest::OptionMenuTest):
161         (OptionMenuTest::~OptionMenuTest):
162         (OptionMenuTest::destroyMenu):
163         (OptionMenuTest::showOptionMenuCallback):
164         (OptionMenuTest::menuCloseCallback):
165         (OptionMenuTest::showOptionMenu):
166         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
167         (OptionMenuTest::close):
168         (OptionMenuTest::activateItem):
169         (OptionMenuTest::selectItem):
170         (testOptionMenuSimple):
171         (testOptionMenuGroups):
172         (testOptionMenuActivate):
173         (testOptionMenuSelect):
174         (beforeAll):
175         (afterAll):
176
177 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
178
179         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
180         https://bugs.webkit.org/show_bug.cgi?id=173399
181
182         Reviewed by Per Arne Vollan.
183
184         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
185         Curl port needs to do nothing because libcurl doesn't have disk cache.
186
187         * DumpRenderTree/win/DumpRenderTree.cpp:
188         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
189         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
190
191 2017-06-14  Tomas Popela  <tpopela@redhat.com>
192
193         [GTK] integer expression expected if running Tools/gtk/install-dependencies
194         https://bugs.webkit.org/show_bug.cgi?id=173356
195
196         Reviewed by Michael Catanzaro.
197
198         Use the correct operator to compare the strings.
199
200         * gtk/install-dependencies:
201
202 2017-06-14  Commit Queue  <commit-queue@webkit.org>
203
204         Unreviewed, rolling out r218285.
205         https://bugs.webkit.org/show_bug.cgi?id=173391
206
207         API test fails on iOS (Requested by alexchristensen on
208         #webkit).
209
210         Reverted changeset:
211
212         "Add SPI for immediate injection of user scripts"
213         https://bugs.webkit.org/show_bug.cgi?id=173342
214         http://trac.webkit.org/changeset/218285
215
216 2017-06-14  Chris Dumez  <cdumez@apple.com>
217
218         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
219         https://bugs.webkit.org/show_bug.cgi?id=173384
220         <rdar://problem/32723779>
221
222         Reviewed by Dan Bernstein.
223
224         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
225         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
226         Add API test coverage.
227
228         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
229         (TestWebKitAPI::Util::sleep):
230         Update implementation of Util::sleep() so that we actually run the run loop.
231         Otherwise, we don't process events while sleeping.
232
233 2017-06-14  Alex Christensen  <achristensen@webkit.org>
234
235         Add SPI for immediate injection of user scripts
236         https://bugs.webkit.org/show_bug.cgi?id=173342
237         <rdar://problem/29202285>
238
239         Reviewed by Brady Eidson.
240
241         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
242         (waitForMessage):
243         (TEST):
244
245 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
246
247         Add WPE to the flakiness dashboard
248         https://bugs.webkit.org/show_bug.cgi?id=173365
249
250         Reviewed by Carlos Alberto Lopez Perez.
251
252         * TestResultServer/static-dashboards/builders.jsonp:
253         * TestResultServer/static-dashboards/flakiness_dashboard.js:
254         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
255         (resetGlobals):
256         * TestResultServer/static-dashboards/loader_unittests.js:
257
258 2017-06-14  Brady Eidson  <beidson@apple.com>
259
260         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
261         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
262
263         Reviewed by Alex Christensen.
264
265         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
266         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
267         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
268         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
269         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
270         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
271         (TEST):
272
273 2017-06-14  Tim Horton  <timothy_horton@apple.com>
274
275         WKContentViewEditingActions API test always fails
276         https://bugs.webkit.org/show_bug.cgi?id=173374
277
278         Reviewed by Wenson Hsieh.
279
280         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
281         (TEST):
282         selectAll isn't working, because canPerformAction for selectAll returns NO
283         if selectionIsNone (which is true in the non-contenteditable case).
284         Instead, make use of r218180's test page, which knows how to select itself.
285         Also, reset the pasteboard at the beginning of the test to reduce confusion
286         (I landed the test broken because my simulator had the correct text
287         stuck in its pasteboard).
288
289 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
290
291         Configure screen scale for running layout tests on plus devices
292         https://bugs.webkit.org/show_bug.cgi?id=173319
293
294         Reviewed by Tim Horton.
295
296         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
297         * DumpRenderTree/mac/DumpRenderTree.mm:
298         (dumpRenderTree): Set screen scale to 2.0.
299         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
300         add _setScale for UIScreen.
301         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
302         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
303         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
304         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
305         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
306         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
307         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
308         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
309         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
310         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
311
312 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
313
314         Add iOS 11 support to the bot watcher's dashboard
315         https://bugs.webkit.org/show_bug.cgi?id=173369
316
317         Reviewed by Lucas Forschler.
318
319         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
320         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
321         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
322         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
323         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
324         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
325
326 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
327
328         [GTK][WPE] Raise the timeout values for layout tests
329         https://bugs.webkit.org/show_bug.cgi?id=173368
330
331         Reviewed by Carlos Garcia Campos.
332
333         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
334         When running under valgrind a 10x multiplier is applied.
335
336         * Scripts/webkitpy/port/gtk.py:
337         (GtkPort.default_timeout_ms):
338         * Scripts/webkitpy/port/gtk_unittest.py:
339         (GtkPortTest.test_default_timeout_ms):
340         * Scripts/webkitpy/port/wpe.py:
341         (WPEPort.default_timeout_ms):
342         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
343         (WPEPortTest):
344         (WPEPortTest.make_port):
345         (WPEPortTest.test_default_timeout_ms):
346         (WPEPortTest.test_get_crash_log):
347
348 2017-06-14  Alex Christensen  <achristensen@webkit.org>
349
350         Test persistent WKHTTPCookieStorages on iOS.
351         https://bugs.webkit.org/show_bug.cgi?id=173284
352
353         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
354         (TEST):
355         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
356
357 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
358
359         [Win] DRT should not use disk cache.
360         https://bugs.webkit.org/show_bug.cgi?id=173361
361
362         Reviewed by Darin Adler.
363
364         Like on macOS/iOS, DRT on Windows should only use memory cache.
365
366         * DumpRenderTree/win/DumpRenderTree.cpp:
367         (setDefaultsToConsistentValuesForTesting):
368         (prepareConsistentTestingEnvironment):
369
370 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
371
372         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
373         https://bugs.webkit.org/show_bug.cgi?id=171668
374
375         Reviewed by Jer Noble.
376
377         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
378         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
379         Infinity when the double value passed as argument is greater than 2^64.
380
381         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
382         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
383         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
384         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
385         method. No behavior change for rational MediaTime.
386
387         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
388         (TestWebKitAPI::TEST):
389
390 2017-06-13  Alex Christensen  <achristensen@webkit.org>
391
392         Test persistent WKHTTPCookieStorages on iOS
393         https://bugs.webkit.org/show_bug.cgi?id=173284
394         <rdar://problem/32260156>
395
396         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
397         (TEST):
398
399 2017-06-13  Matt Rajca  <mrajca@apple.com>
400
401         WebsitePolicies: let clients select specific autoplay quirks
402         https://bugs.webkit.org/show_bug.cgi?id=173343
403
404         Reviewed by Alex Christensen.
405
406         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
407         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
408         (TEST): Updated tests.
409
410 2017-06-13  Daniel Bates  <dabates@apple.com>
411
412         Implement W3C Secure Contexts Draft Specification
413         https://bugs.webkit.org/show_bug.cgi?id=158121
414         <rdar://problem/26012994>
415
416         Reviewed by Brent Fulgham.
417
418         Part 4
419
420         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
421         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
422         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
423
424         * DumpRenderTree/TestOptions.h:
425         * DumpRenderTree/TestOptions.mm:
426         (TestOptions::TestOptions):
427         * DumpRenderTree/mac/DumpRenderTree.mm:
428         (setWebPreferencesForTestOptions):
429         * DumpRenderTree/win/DumpRenderTree.cpp:
430         (enableExperimentalFeatures):
431         * WebKitTestRunner/TestController.cpp:
432         (WTR::TestController::resetPreferencesToConsistentValues):
433         (WTR::updateTestOptionsFromTestHeader):
434         * WebKitTestRunner/TestOptions.h:
435         (WTR::TestOptions::hasSameInitializationOptions):
436
437 2017-06-13  Alex Christensen  <achristensen@webkit.org>
438
439         Test persistent WKHTTPCookieStorages on iOS
440         https://bugs.webkit.org/show_bug.cgi?id=173284
441         <rdar://problem/32260156>
442
443         Reviewed by Alexey Proskuryakov.
444
445         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
446         (TEST):
447
448 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
449
450         [GTK] Blob download doesn't work
451         https://bugs.webkit.org/show_bug.cgi?id=172442
452
453         Reviewed by Carlos Alberto Lopez Perez.
454
455         Add a unit test to check blob downloads.
456
457         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
458         (testBlobDownload):
459         (beforeAll):
460
461 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
462
463         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
464         https://bugs.webkit.org/show_bug.cgi?id=173316
465
466         Reviewed by Alex Christensen.
467
468         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
469
470         * gtk/manifest.txt.in:
471
472 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
473
474         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
475         https://bugs.webkit.org/show_bug.cgi?id=173315
476
477         Reviewed by Darin Adler.
478
479         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
480         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
481         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
482         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
483         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
484         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
485         WKGeolocationManagerRef is not destroyed.
486
487         * WebKitTestRunner/GeolocationProviderMock.cpp:
488         (WTR::GeolocationProviderMock::GeolocationProviderMock):
489         * WebKitTestRunner/GeolocationProviderMock.h:
490
491 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
492
493         Unable to paste text that was copied from a page into the universal search field
494         https://bugs.webkit.org/show_bug.cgi?id=173293
495         <rdar://problem/32440918>
496
497         Reviewed by Ryosuke Niwa.
498
499         Adds 2 new unit tests for copying plain and rich selected web content.
500         See WebCore and WebKit ChangeLogs for more detail.
501
502         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
503         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
504         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
505         (TestWebKitAPI::dataForPasteboardType):
506         (TestWebKitAPI::setUpWebViewForPasteboardTests):
507         (TestWebKitAPI::TEST):
508
509 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
510
511         AX: [ATK] Implement missing AtkRelation types
512         https://bugs.webkit.org/show_bug.cgi?id=155494
513
514         Reviewed by Darin Adler.
515
516         Add additional methods to test ARIA properties which are exposed via
517         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
518
519         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
520         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
521         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
522         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
523         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
524         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
525         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
526         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
527         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
528         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
529         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
530         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
531         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
532         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
533         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
534         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
535         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
536         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
537
538 2017-06-12  Daniel Bates  <dabates@apple.com>
539
540         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
541         https://bugs.webkit.org/show_bug.cgi?id=173286
542         <rdar://problem/32726102>
543
544         Reviewed by Brent Fulgham.
545
546         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
547         (TestWebKitAPI::TEST_F):
548
549 2017-06-12  Lucas Forschler  <lforschler@apple.com>
550
551         <rdar://problem/32683422>
552         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
553
554         Reviewed by Conrad Schultz.
555
556         * Scripts/copy-webkitlibraries-to-product-directory:
557
558 2017-06-12  Tim Horton  <timothy_horton@apple.com>
559
560         [iOS] Cmd-C doesn't copy text from WKWebView
561         https://bugs.webkit.org/show_bug.cgi?id=173277
562         <rdar://problem/32396742>
563
564         Reviewed by Dan Bernstein.
565
566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
567         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
568         Add a test ensuring that -copy on WKContentView will cause text to be copied.
569
570 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
571
572         [WebCrypto] Remove experimental feature flag of SubtleCrypto
573         https://bugs.webkit.org/show_bug.cgi?id=173197
574         <rdar://problem/32688148>
575
576         Reviewed by Brent Fulgham.
577
578         * DumpRenderTree/mac/DumpRenderTree.mm:
579         (enableExperimentalFeatures):
580         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
581         (WTR::InjectedBundle::beginTesting):
582         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
583         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
584         * WebKitTestRunner/InjectedBundle/TestRunner.h:
585
586 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
587
588         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
589         https://bugs.webkit.org/show_bug.cgi?id=173238
590         <rdar://problem/31943370>
591
592         Reviewed by Ryosuke Niwa and Tim Horton.
593
594         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
595         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
596         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
597
598         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
599         (TestWebKitAPI::TEST):
600         * TestWebKitAPI/ios/DataInteractionSimulator.h:
601         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
602         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
603         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
604
605 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
606
607         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
608         https://bugs.webkit.org/show_bug.cgi?id=173225
609         <rdar://problem/32713144>
610
611         Reviewed by Tim Horton.
612
613         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
614         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
615
616         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
617         (TestWebKitAPI::TEST):
618
619 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
620
621         Return correct process names for iOS on-device testing
622         https://bugs.webkit.org/show_bug.cgi?id=173263
623
624         Reviewed by Alex Christensen.
625
626         When running tests on iOS devices, process names do not end with '.Development'
627         as they do on Mac and iOS simulator.
628
629         * WebKitTestRunner/TestController.cpp:
630         (WTR::TestController::webProcessName): Return correct process name without '.Development'
631         for iOS on-device testing.
632         (WTR::TestController::networkProcessName): Ditto.
633         (WTR::TestController::databaseProcessName): Ditto.
634
635 2017-06-12  Chris Dumez  <cdumez@apple.com>
636
637         Regression(r217867): Legacy SessionHistoryEntryData format should not change
638         https://bugs.webkit.org/show_bug.cgi?id=173267
639         <rdar://problem/32701257>
640
641         Reviewed by Simon Fraser.
642
643         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
644         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
645         though as this covers the crash that r217867 was fixing.
646
647         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
648         (TestWebKitAPI::createSessionStateData):
649         (TestWebKitAPI::TEST):
650         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
651
652 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
653
654         [GTK] Stop dismissing menus attached to the web view for every injected event
655         https://bugs.webkit.org/show_bug.cgi?id=172708
656
657         Reviewed by Alex Christensen.
658
659         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
660         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
661         events while the menu is open.
662
663         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
664         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
665         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
666         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
667
668 2017-06-12  Miguel Gomez  <magomez@igalia.com>
669
670         [GTK][WPE] Enable GStreamer GL on development builds
671         https://bugs.webkit.org/show_bug.cgi?id=173248
672
673         Enable GStreamer GL for GTK and WPE.
674
675         Reviewed by Carlos Garcia Campos.
676
677         * Scripts/webkitperl/FeatureList.pm:
678
679 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
680
681         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
682
683         Notifications are no longer cleared on page navigation.
684
685         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
686         (testWebViewNotification):
687
688 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
689
690         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
691
692         DBus interface and object path names were updated in r217831.
693
694         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
695
696 2017-06-10  Dan Bernstein  <mitz@apple.com>
697
698         Reverted r218056 because it made the IDE reindex constantly.
699
700         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
701         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
702         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
703         * MiniBrowser/Configurations/DebugRelease.xcconfig:
704         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
705         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
706         * WebEditingTester/Configurations/DebugRelease.xcconfig:
707         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
708
709 2017-06-10  Dan Bernstein  <mitz@apple.com>
710
711         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
712         https://bugs.webkit.org/show_bug.cgi?id=173223
713
714         Reviewed by Sam Weinig.
715
716         The rebuilds were happening due to a difference in the compiler options that the IDE and
717         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
718         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
719         specify an appropriate path in CLANG_INDEX_STORE_PATH.
720
721         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
722         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
723         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
724         * MiniBrowser/Configurations/DebugRelease.xcconfig:
725         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
726         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
727         * WebEditingTester/Configurations/DebugRelease.xcconfig:
728         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
729
730 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
731
732         webkitpy: Reduce polling in ServerProcess
733         https://bugs.webkit.org/show_bug.cgi?id=173116
734
735         Reviewed by Ryosuke Niwa.
736
737         We should be smarter about polling. We do not need to poll every time a line is read from
738         stdout and stderr since lines are usually read from cached data. We should only poll
739         when extracting that cached data from stdout and stderr.
740
741         * Scripts/webkitpy/port/driver.py:
742         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
743         and on ServerProcess to poll the process if not data is available in stdout and stderr.
744         * Scripts/webkitpy/port/driver_unittest.py:
745         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
746         ServerProcess.
747         * Scripts/webkitpy/port/server_process.py:
748         (ServerProcess._read): Allow for data to be read from _output even if the process has
749         crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
750         * Scripts/webkitpy/port/server_process_mock.py:
751         (MockServerProcess): Add number_of_times_polled.
752         (MockServerProcess.poll): Increment number_of_times_polled.
753         (MockServerProcess.has_crashed): Poll before returning crash state.
754         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
755         just like a ServerProcess would.
756         (MockServerProcess.read_stdout): Ditto.
757         * Scripts/webkitpy/port/server_process_unittest.py:
758         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
759         process from ending before stdout and stderr are read. This is the reason this test was flakey.
760         (TestServerProcess):
761         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
762         the processes is polled.
763         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
764         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
765
766 2017-06-10  Andy Estes  <aestes@apple.com>
767
768         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
769         https://bugs.webkit.org/show_bug.cgi?id=173190
770         <rdar://problem/31360659>
771
772         Reviewed by Brady Eidson.
773         
774         Added a release assert that tries to create a proper test failure if the web process crashes.
775
776         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
777         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
778
779 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
780
781         [iOS DnD] Add a hook to perform two-step drops in editable content
782         https://bugs.webkit.org/show_bug.cgi?id=172992
783         <rdar://problem/32590174>
784
785         Reviewed by Tim Horton.
786
787         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
788         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
789                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
790
791         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
792         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
793         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
794
795         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
796         be overridden. Currently, this is overridden to just return true.
797
798         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
799         (TestWebKitAPI::TEST):
800         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
801         (WTR::InjectedBundlePage::InjectedBundlePage):
802
803 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
804
805         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
806         https://bugs.webkit.org/show_bug.cgi?id=173103
807
808         Reviewed by Xabier Rodriguez-Calvar.
809
810         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
811         when building the WPE port through build-webkit.
812
813 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
814
815         [WPE] Enable MEDIA_SOURCE for build-webkit builds
816         https://bugs.webkit.org/show_bug.cgi?id=173136
817
818         Reviewed by Xabier Rodriguez-Calvar.
819
820         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
821
822 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
823
824         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
825         https://bugs.webkit.org/show_bug.cgi?id=173098
826
827         Reviewed by Žan Doberšek.
828
829         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
830         assuming that all tests containing forms define ids for the form elements like
831         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
832
833         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
834         (formControlsAssociatedCallback):
835
836 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
837
838         webkitpy: Run sample/spindump on iOS devices
839         https://bugs.webkit.org/show_bug.cgi?id=171881
840         <rdar://problem/32084602>
841
842         Reviewed by Daniel Bates.
843
844         * Scripts/webkitpy/port/darwin.py:
845         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
846         requires sudo to run spindump.
847         * Scripts/webkitpy/port/ios_device.py:
848         (IOSDevicePort.look_for_new_samples): Deleted.
849         (IOSDevicePort.sample_process): Deleted.
850         * Scripts/webkitpy/port/ios_device_unittest.py:
851         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
852         (IOSDeviceTest.test_spindump):
853         (IOSDeviceTest.test_sample_process):
854         (IOSDeviceTest.test_sample_process_exception):
855         * Scripts/webkitpy/port/ios_simulator_unittest.py:
856         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
857
858 2017-06-08  Keith Miller  <keith_miller@apple.com>
859
860         WebAssembly: We should only create wrappers for functions that can be exported
861         https://bugs.webkit.org/show_bug.cgi?id=173088
862
863         Reviewed by Saam Barati.
864
865         Add quick mode for wasm tests.
866
867         * Scripts/run-jsc-stress-tests:
868
869 2017-06-08  Darin Adler  <darin@apple.com>
870
871         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
872         https://bugs.webkit.org/show_bug.cgi?id=173106
873
874         Reviewed by Sam Weinig.
875
876         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
877         destroyed last.
878         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
879         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
880
881 2017-06-07  Dan Bernstein  <mitz@apple.com>
882
883         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
884         https://bugs.webkit.org/show_bug.cgi?id=173086
885
886         Reviewed by Andy Estes.
887
888         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
889         (TEST):
890
891 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
892
893         Add High Sierra support to WebKit tools
894         https://bugs.webkit.org/show_bug.cgi?id=173080
895
896         Rubber-stamped by Daniel Bates.
897
898         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
899         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
900         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
901         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
902         Added dashboard support.
903
904         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
905         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
906         Trigger the right build queues on check-in.
907
908         * Scripts/webkitpy/common/system/platforminfo.py:
909         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
910         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
911         * Scripts/webkitpy/port/mac.py:
912         * Scripts/webkitpy/port/mac_unittest.py:
913         * TestResultServer/static-dashboards/flakiness_dashboard.js:
914         Added cases for Sierra, and updated tests for new baseline search paths.
915
916 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
917
918         Unreviewed, rolling out r217902.
919
920         This change appears to have caused imported/w3c/web-platform-
921         tests/fetch/api/cors tests to fail on El Capitan.
922
923         Reverted changeset:
924
925         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
926         https://bugs.webkit.org/show_bug.cgi?id=172930
927         http://trac.webkit.org/changeset/217902
928
929 2017-06-07  Daniel Bates  <dabates@apple.com>
930
931         Teach run-webkit-tests how to run HTTPS Web Platform Tests
932         https://bugs.webkit.org/show_bug.cgi?id=172930
933         <rdar://problem/32570201>
934
935         Reviewed by Youenn Fablet.
936
937         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
938         that is conditioned on the page being delivered over a secure protocol. One example of such
939         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
940
941         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
942         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
943         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
944
945         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
946         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
947         to the Web Platform Tests HTTPS server.
948         * Scripts/webkitpy/port/base.py:
949         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
950         * Scripts/webkitpy/port/driver.py:
951         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
952         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
953         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
954         indicate that they should be considered private instance variables.
955         (Driver.is_web_platform_test): Update code for renamed instance variables.
956         (Driver):
957         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
958         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
959         determine the base URL to use to access the test.
960         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
961         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
962
963 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
964
965         Support removal of authentication data through the Website data store API.
966         https://bugs.webkit.org/show_bug.cgi?id=171217
967
968         Reviewed by Brady Eidson.
969
970         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
971         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
972         (WTR::InjectedBundle::didReceiveMessageToPage):
973         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
974         (WTR::TestRunner::removeAllSessionCredentials):
975         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
976         * WebKitTestRunner/InjectedBundle/TestRunner.h:
977         * WebKitTestRunner/TestController.h:
978         * WebKitTestRunner/TestInvocation.cpp:
979         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
980         (WTR::TestInvocation::didRemoveAllSessionCredentials):
981         * WebKitTestRunner/TestInvocation.h:
982         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
983         (WTR::TestController::removeAllSessionCredentials):
984
985 2017-06-07  Charlie Turner  <cturner@igalia.com>
986
987         Add Charlie Turner as contributor
988         https://bugs.webkit.org/show_bug.cgi?id=173055
989
990         Reviewed by Carlos Alberto Lopez Perez.
991
992         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
993         of webkit-patch upload, which reordered some fields and removed a newline.
994
995         * Scripts/webkitpy/common/config/contributors.json:
996
997 2017-06-06  Chris Dumez  <cdumez@apple.com>
998
999         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
1000         https://bugs.webkit.org/show_bug.cgi?id=173033
1001         <rdar://problem/32591099>
1002
1003         Reviewed by Simon Fraser.
1004
1005         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
1006         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
1007
1008         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1009         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
1010         (TestWebKitAPI::didFinishLoadForFrame):
1011         (TestWebKitAPI::setPageLoaderClient):
1012         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
1013         (TestWebKitAPI::TEST):
1014
1015 2017-06-06  Andy Estes  <aestes@apple.com>
1016
1017         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
1018         https://bugs.webkit.org/show_bug.cgi?id=172849
1019         <rdar://problem/32567454>
1020
1021         Reviewed by Darin Adler.
1022
1023         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1024         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
1025         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1026         (TestWebKitAPI::TEST):
1027
1028 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
1029
1030         [preload] Conditional support for media preloading and align media `as` values.
1031         https://bugs.webkit.org/show_bug.cgi?id=172501
1032
1033         Reviewed by Dean Jackson.
1034
1035         Turn on media preloading preference for tests.
1036
1037         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
1038         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
1039         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
1040
1041 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
1042
1043         webkitpy: Return correct process names from SimulatorProcess
1044         https://bugs.webkit.org/show_bug.cgi?id=172940
1045
1046         Reviewed by Aakash Jain.
1047
1048         * Scripts/webkitpy/port/darwin.py:
1049         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
1050         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
1051         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
1052         * Scripts/webkitpy/port/driver.py:
1053         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
1054         _server_process.name() will not return the correct process name for iOS.
1055         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
1056         (Driver._read_block): Ditto.
1057         * Scripts/webkitpy/port/driver_unittest.py:
1058         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
1059         process_name() instead of name().
1060         * Scripts/webkitpy/port/server_process.py:
1061         (ServerProcess._start): Use process_name() instead of name().
1062         (ServerProcess.stop): Ditto.
1063         (ServerProcess.name): Deleted.
1064         * Scripts/webkitpy/port/simulator_process.py:
1065         (SimulatorProcess.process_name): Check the provided bundle for the process name.
1066
1067 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
1068
1069         test-webkitpy: stop forking unsafely from within a spawned process
1070         https://bugs.webkit.org/show_bug.cgi?id=172774
1071
1072         Reviewed by Darin Adler.
1073
1074         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1075         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
1076         it's going to be used.
1077         (Builder.force_build):
1078
1079 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
1080
1081         webkitpy: Process crash-logs for iOS devices
1082         https://bugs.webkit.org/show_bug.cgi?id=171976
1083         <rdar://problem/32134551>
1084
1085         Reviewed by David Kilzer.
1086
1087         When running layout tests on an iOS device, crash logs should be processed.
1088         Implement crash log searching and parsing for iOS devices.
1089
1090         * Scripts/webkitpy/common/system/crashlogs.py:
1091         (CrashLogs): Moved process regular expression for Darwin to class variable.
1092         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
1093         (CrashLogs.find_newest_log): Add iOS as a potential platform.
1094         (CrashLogs.find_all_logs): Ditto.
1095         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
1096         Do not assume that a Darwin crash log starts with the process.
1097         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
1098         shared code for parsing Darwin crash logs.
1099         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
1100         object so that crash logs already on the system before testing are not parsed.
1101         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
1102         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
1103         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
1104         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1105         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
1106         * Scripts/webkitpy/common/system/systemhost.py:
1107         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
1108         systems is just the crashlog, use this behavior by default.
1109         * Scripts/webkitpy/common/system/systemhost_mock.py:
1110         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
1111         systems is just the crashlog, use this behavior by default.
1112         * Scripts/webkitpy/port/apple.py:
1113         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
1114         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
1115         the system before testing begins
1116         * Scripts/webkitpy/port/base.py:
1117         (Port._get_crash_log): Pass optional target host when getting crash logs.
1118         * Scripts/webkitpy/port/darwin.py:
1119         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
1120         CrashLogs object.
1121         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
1122         logs to be skipped to CrashLogs object.
1123         * Scripts/webkitpy/port/darwin_testcase.py:
1124         (DarwinTest.test_get_crash_log): Removed unused local function.
1125         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
1126         * Scripts/webkitpy/port/device.py:
1127         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
1128         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
1129         * Scripts/webkitpy/port/driver.py:
1130         (Driver._get_crash_log): Pass optional target host when getting crash logs.
1131         * Scripts/webkitpy/port/gtk.py:
1132         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
1133         * Scripts/webkitpy/port/ios.py: Ditto.
1134         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
1135         to be skipped for each host.
1136         * Scripts/webkitpy/port/ios_device.py:
1137         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
1138         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
1139         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
1140         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
1141         host is specified. Else, search all connected devices for the specified crash-log.
1142         (IOSDevicePort.look_for_new_crash_logs): Deleted.
1143         * Scripts/webkitpy/port/ios_device_unittest.py:
1144         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
1145         (IOSDeviceTest.test_get_crash_log): Ditto.
1146         * Scripts/webkitpy/port/simulator_process.py:
1147         (SimulatorProcess.process_name): Check the provided bundle for the process name.
1148         * Scripts/webkitpy/port/win.py:
1149         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
1150         logs to be skipped to CrashLogs object.
1151         * Scripts/webkitpy/port/wpe.py:
1152         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
1153
1154 2017-06-06  David Kilzer  <ddkilzer@apple.com>
1155
1156         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
1157         <https://webkit.org/b/172804>
1158
1159         Reviewed by Darin Adler.
1160
1161         WTF_ATTRIBUTE_PRINTF() only works outside the current
1162         compilation unit if it's on the declaration, not the
1163         implementation, of a function or class method.
1164
1165         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1166         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1167         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1168         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1169         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
1170         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1171         - Remove redundant CRASH() macro definition.  Use the one from
1172           <wtf/Assertions.h> instead.
1173
1174 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
1175
1176         Move Resource Timing / User Timing from experimental features into main preferences
1177         https://bugs.webkit.org/show_bug.cgi?id=172950
1178
1179         Reviewed by Darin Adler.
1180
1181         * DumpRenderTree/mac/DumpRenderTree.mm:
1182         (enableExperimentalFeatures):
1183         (resetWebPreferencesToConsistentValues):
1184         * DumpRenderTree/win/DumpRenderTree.cpp:
1185         (enableExperimentalFeatures):
1186         (resetWebPreferencesToConsistentValues):
1187         * WebKitTestRunner/TestController.cpp:
1188         (WTR::TestController::resetPreferencesToConsistentValues):
1189         Move out no longer experimental features to the main list.
1190
1191 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1192
1193         [WPE] Add an install-dependencies script
1194         https://bugs.webkit.org/show_bug.cgi?id=172948
1195
1196         Reviewed by Žan Doberšek.
1197
1198         It is based on the gtk/install-dependencies script.
1199         Includes support for Debian based distrubutions, Fedora and Arch.
1200         It has been tested on a minimal Debian 9 chroot.
1201
1202         * wpe/install-dependencies: Added.
1203
1204 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1205
1206         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
1207         https://bugs.webkit.org/show_bug.cgi?id=172891
1208         <rdar://problem/32204540>
1209
1210         Reviewed by Darin Adler.
1211
1212         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
1213         contenteditable. See WebCore ChangeLog for more details.
1214
1215         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1216         (TestWebKitAPI::TEST):
1217
1218 2017-06-05  Daniel Bates  <dabates@apple.com>
1219
1220         webkitpy: Abstract Executive class
1221         https://bugs.webkit.org/show_bug.cgi?id=172928
1222         <rdar://problem/32569531>
1223
1224         Reviewed by Ryosuke Niwa.
1225
1226         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
1227         This will make it straightforward to create additional derived classes that
1228         adhere to the same interface, say for iOS on-device testing.
1229
1230         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
1231         (AbstractExecutive):
1232         (AbstractExecutive.run_and_throw_if_fail):
1233         (AbstractExecutive.cpu_count):
1234         (AbstractExecutive.interpreter_for_script):
1235         (AbstractExecutive.shell_command_for_script):
1236         (AbstractExecutive.kill_process):
1237         (AbstractExecutive.check_running_pid):
1238         (AbstractExecutive.running_pids):
1239         (AbstractExecutive.wait_newest):
1240         (AbstractExecutive.wait_limited):
1241         (AbstractExecutive.interrupt):
1242         (AbstractExecutive.default_error_handler):
1243         (AbstractExecutive.ignore_error):
1244         (AbstractExecutive._stringify_args):
1245         (AbstractExecutive.command_for_printing):
1246         (AbstractExecutive.run_command):
1247         (AbstractExecutive.popen):
1248         (AbstractExecutive.run_in_parallel):
1249         * Scripts/webkitpy/common/system/executive.py:
1250         (Executive):
1251         (Executive.cpu_count):
1252         (Executive.running_pids):
1253         (Executive.kill_all):
1254         (Executive._compute_stdin):
1255         (Executive.interpreter_for_script): Deleted.
1256         (Executive.shell_command_for_script): Deleted.
1257         (Executive.wait_newest): Deleted.
1258         (Executive.wait_limited): Deleted.
1259         (Executive.default_error_handler): Deleted.
1260         (Executive.ignore_error): Deleted.
1261         (Executive.command_for_printing): Deleted.
1262
1263 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
1264
1265         webkitpy: Add iOS to platform
1266         https://bugs.webkit.org/show_bug.cgi?id=172931
1267
1268         Reviewed by Daniel Bates.
1269
1270         * Scripts/webkitpy/common/system/platforminfo.py:
1271         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
1272         (PlatformInfo.is_ios): Added.
1273         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
1274         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1275         (MockPlatformInfo.is_ios): Added.
1276
1277 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1278
1279         [WPE][JHBuild] Switch github repository from git:// to https://
1280         https://bugs.webkit.org/show_bug.cgi?id=172921
1281
1282         Reviewed by Alex Christensen.
1283
1284         * wpe/jhbuild.modules:
1285
1286 2017-06-05  Tim Horton  <timothy_horton@apple.com>
1287
1288         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
1289         https://bugs.webkit.org/show_bug.cgi?id=172887
1290         <rdar://problem/32546061>
1291
1292         Reviewed by Sam Weinig.
1293
1294         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1295         (WTR::UIScriptController::applyAutocorrection):
1296         applyAutocorrection can call its completion handler synchronously,
1297         which makes UIScriptController unhappy (see bug 172884).
1298
1299 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
1300
1301         webkitpy: Add contextmanager to disable logging for a block
1302         https://bugs.webkit.org/show_bug.cgi?id=172876
1303
1304         Reviewed by Daniel Bates.
1305
1306         Add a context manager which will use an OutputCapture object to capture logging
1307         in a block and hold it in a variable.
1308
1309         * Scripts/webkitpy/common/system/outputcapture.py:
1310         (OutputCaptureScope):
1311         (OutputCaptureScope.__init__): Construct with OutputCapture object.
1312         (OutputCaptureScope.__enter__): Begin capturing output. 
1313         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
1314         output and retain the resulting log.
1315         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
1316         (OutputCaptureTest.test_output_capture_scope): Added.
1317
1318 2017-06-02  Zalan Bujtas  <zalan@apple.com>
1319
1320         Cleanup FrameView::autoSizeIfEnabled.
1321         https://bugs.webkit.org/show_bug.cgi?id=172889
1322         <rdar://problem/32550783>
1323
1324         Reviewed by Tim Horton.
1325
1326         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1327         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
1328         (TEST):
1329
1330 2017-06-02  Chris Dumez  <cdumez@apple.com>
1331
1332         ResourceLoadStatistics are not using unique paths during test runs
1333         https://bugs.webkit.org/show_bug.cgi?id=172861
1334         <rdar://problem/32442251>
1335
1336         Reviewed by Darin Adler.
1337
1338         Make sure WebKitTestRunner sets a temporary path for saving resource
1339         load statistics.
1340
1341         * WebKitTestRunner/TestController.cpp:
1342         (WTR::TestController::generateContextConfiguration):
1343
1344 2017-06-02  Brady Eidson  <beidson@apple.com>
1345
1346         Prevent scheme handlers from handling all built-in URL schemes.
1347         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
1348
1349         Reviewed by Andy Estes.
1350
1351         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1352
1353 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
1354
1355         [JSCOnly] Build static jsc.exe on Windows
1356         https://bugs.webkit.org/show_bug.cgi?id=172833
1357
1358         Reviewed by Konstantin Tokarev.
1359
1360         * CMakeLists.txt:
1361         * Scripts/build-jsc:
1362
1363 2017-06-02  Zalan Bujtas  <zalan@apple.com>
1364
1365         Disable ViewportSizeForViewportUnits tests on iOS.
1366         https://bugs.webkit.org/show_bug.cgi?id=172872
1367
1368         Reviewed by Tim Horton.
1369
1370         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
1371
1372 2017-06-02  Zalan Bujtas  <zalan@apple.com>
1373
1374         Allow clients to override viewport size for CSS viewport units.
1375         https://bugs.webkit.org/show_bug.cgi?id=172838
1376         <rdar://problem/32523441>
1377
1378         Reviewed by Tim Horton.
1379
1380         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1381         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
1382         (TEST):
1383
1384 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
1385
1386         Get <chrono> out of StdLibExtras.h
1387         https://bugs.webkit.org/show_bug.cgi?id=172744
1388
1389         Reviewed by Zalan Bujtas.
1390
1391         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1392
1393 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
1394
1395         [WPE] Enable SUBTLE_CRYPTO
1396         https://bugs.webkit.org/show_bug.cgi?id=172756
1397
1398         Reviewed by Michael Catanzaro.
1399
1400         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
1401         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
1402         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
1403         exhausting entropy when running the crypto layout tests.
1404
1405 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1406
1407         [GTK] Bump GTK+ and its dependencies in jhbuild
1408         https://bugs.webkit.org/show_bug.cgi?id=171918
1409
1410         Reviewed by Carlos Alberto Lopez Perez.
1411
1412         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1413         (WTR::initializeGtkSettings):
1414         * gtk/jhbuild.modules:
1415         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
1416         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
1417
1418 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1419
1420         [GTK] Bump wayland and weston in jhbuild
1421         https://bugs.webkit.org/show_bug.cgi?id=171921
1422
1423         Reviewed by Carlos Alberto Lopez Perez.
1424
1425         * gtk/jhbuild.modules:
1426         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
1427
1428 2017-06-01  Andy Estes  <aestes@apple.com>
1429
1430         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
1431         https://bugs.webkit.org/show_bug.cgi?id=172828
1432
1433         Reviewed by Beth Dakin.
1434
1435         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1436
1437 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
1438
1439         webkitpy: Remove unneeded simulator teardown
1440         https://bugs.webkit.org/show_bug.cgi?id=171891
1441
1442         Reviewed by Aakash Jain.
1443
1444         * Scripts/webkitpy/port/ios_simulator.py:
1445         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
1446         for communication between Python and WebKitTestRunner/DumpRenderTree.
1447
1448 2017-06-01  Keith Miller  <keith_miller@apple.com>
1449
1450         Undo rollout in r217638 with bug fix
1451         https://bugs.webkit.org/show_bug.cgi?id=172824
1452
1453         Unreviewed, reland patch with unused set_state code removed.
1454
1455         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1456         (runThreadMessageTest):
1457         (TEST):
1458
1459 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
1460
1461         webkitpy: Do not send 0 or -1 as a pid to kill_process
1462         https://bugs.webkit.org/show_bug.cgi?id=172818
1463
1464         Reviewed by Darin Adler.
1465
1466         Sending a signal to process 0 will result in all processes in the group receiving 
1467         the signal. Sending a signal to process -1 will result in all non-system processes
1468         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
1469         should consider these cases
1470
1471         * Scripts/webkitpy/common/system/executive.py:
1472         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
1473         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
1474         never be running, although os.kill may succeed.
1475         * Scripts/webkitpy/port/simulator_process.py:
1476         (SimulatorProcess.stop): Do not kill process if it is undefined.
1477
1478 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
1479
1480         JSC EWS bot does not run on WTF only patches
1481         https://bugs.webkit.org/show_bug.cgi?id=172777
1482         rdar://problem/32495975
1483
1484         Reviewed by Aakash Jain.
1485
1486         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1487         (CheckPatchRelevance): Add a missing comma.
1488
1489 2017-05-31  Commit Queue  <commit-queue@webkit.org>
1490
1491         Unreviewed, rolling out r217611 and r217631.
1492         https://bugs.webkit.org/show_bug.cgi?id=172785
1493
1494         "caused wasm-hashset-many.html to become flaky." (Requested by
1495         keith_miller on #webkit).
1496
1497         Reverted changesets:
1498
1499         "Reland r216808, underlying lldb bug has been fixed."
1500         https://bugs.webkit.org/show_bug.cgi?id=172759
1501         http://trac.webkit.org/changeset/217611
1502
1503         "Use dispatch queues for mach exceptions"
1504         https://bugs.webkit.org/show_bug.cgi?id=172775
1505         http://trac.webkit.org/changeset/217631
1506
1507 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
1508
1509         EWS bots should reboot themselves more frequently
1510         https://bugs.webkit.org/show_bug.cgi?id=172402
1511
1512         Reviewed by Alexey Proskuryakov.
1513
1514         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
1515
1516         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
1517
1518 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
1519
1520         Reallocate hardware for iOS bots.
1521         https://bugs.webkit.org/show_bug.cgi?id=172657
1522
1523         Reviewed by Alexey Proskuryakov.
1524
1525         * BuildSlaveSupport/build.webkit.org-config/config.json:
1526
1527 2017-05-31  Andy Estes  <aestes@apple.com>
1528
1529         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
1530         https://bugs.webkit.org/show_bug.cgi?id=172366
1531
1532         Reviewed by Daniel Bates.
1533
1534         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1535
1536 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
1537
1538         Unreviewed, add Jiewen Tan as a reviewer
1539
1540         * Scripts/webkitpy/common/config/contributors.json:
1541
1542 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
1543
1544         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
1545         https://bugs.webkit.org/show_bug.cgi?id=172770
1546
1547         Reviewed by Michael Catanzaro.
1548
1549         * MiniBrowser/gtk/BrowserWindow.c:
1550         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
1551         which caused the body of the if-clause to be accidentally empty.
1552
1553 2017-05-31  Keith Miller  <keith_miller@apple.com>
1554
1555         Reland r216808, underlying lldb bug has been fixed.
1556         https://bugs.webkit.org/show_bug.cgi?id=172759
1557
1558         Unreviewed, relanding old patch. See: rdar://problem/31183352
1559
1560         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1561         (runThreadMessageTest):
1562         (TEST):
1563
1564 2017-05-31  Matt Lewis  <jlewis3@apple.com>
1565
1566         Unreviewed, rolling out r217603.
1567
1568         This patch broke the internal builds.
1569
1570         Reverted changeset:
1571
1572         "Get <chrono> out of StdLibExtras.h"
1573         https://bugs.webkit.org/show_bug.cgi?id=172744
1574         http://trac.webkit.org/changeset/217603
1575
1576 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
1577
1578         Make ResourceLoadStatistics testing more reliable
1579         https://bugs.webkit.org/show_bug.cgi?id=172730
1580         <rdar://problem/32028373>
1581
1582         Reviewed by Andy Estes.
1583
1584         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
1585         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
1586
1587         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1588         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1589
1590 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1591
1592         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
1593         https://bugs.webkit.org/show_bug.cgi?id=172757
1594
1595         Reviewed by Xabier Rodriguez-Calvar.
1596
1597         When needed, add the jhbuild wrapper at the beginning of the array
1598         that will be invoked to execute the run-jsc-stress-test or testapi
1599         commands.
1600
1601         * Scripts/run-javascriptcore-tests:
1602         (runJSCStressTests):
1603         * Scripts/webkitdirs.pm:
1604         (shouldUseJhbuild):
1605
1606 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
1607
1608         Get <chrono> out of StdLibExtras.h
1609         https://bugs.webkit.org/show_bug.cgi?id=172744
1610
1611         Reviewed by Saam Barati.
1612
1613         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1614
1615 2017-05-30  Tim Horton  <timothy_horton@apple.com>
1616
1617         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
1618         https://bugs.webkit.org/show_bug.cgi?id=172735
1619         <rdar://problem/32015977>
1620
1621         Reviewed by Enrica Casucci.
1622
1623         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1624         (WTR::UIScriptController::applyAutocorrection):
1625         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1626         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1627         (WTR::UIScriptController::applyAutocorrection):
1628         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1629         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1630         (WTR::UIScriptController::applyAutocorrection):
1631         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
1632         because I don't know how to tap the button in the autocorrection bar from a test.
1633
1634 2017-05-30  Daniel Bates  <dabates@apple.com>
1635
1636         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
1637         https://bugs.webkit.org/show_bug.cgi?id=172671
1638
1639         Reviewed by Alex Christensen.
1640
1641         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
1642         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
1643
1644         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
1645         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
1646         to trigger a navigation to test it.
1647         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
1648         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
1649
1650 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
1651
1652         webkitpy: Start servers before setting-up for testing
1653         https://bugs.webkit.org/show_bug.cgi?id=172176
1654         <rdar://problem/32225538>
1655
1656         Reviewed by Alexey Proskuryakov.
1657
1658         On-device testing requires that servers are started before ports set-up their
1659         test environments.
1660
1661         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1662         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
1663         Servers are unconditionally stopped on exit.
1664         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
1665         Manager now stops servers.
1666         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
1667         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
1668         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1669         (Manager.__init__): Delay construction of the test runner until we can determine
1670         if servers need to be started.
1671         (Manager.run): Determine if servers need to be started and construct the test runner.
1672         Shut servers down when the test run is finished.
1673         (Manager._run_tests): Move the determination of servers to run into Manager.run.
1674         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1675         (is_wpt_server_running): Server is not running if no config is found.
1676         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1677         (PyWebSocket.is_running): Check if this WebSocket server is running.
1678         * Scripts/webkitpy/port/base.py:
1679         (Port.__init__): Define secure WebSocket server.
1680         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
1681
1682 2017-05-30  Daniel Bates  <dabates@apple.com>
1683
1684         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
1685         https://bugs.webkit.org/show_bug.cgi?id=172603
1686         <rdar://problem/32471306>
1687
1688         Reviewed by Brady Eidson.
1689
1690         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
1691         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
1692         unloading is initiated for a page that registered a onbeforeunload handler.
1693
1694         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
1695         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
1696         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
1697
1698         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
1699         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
1700         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
1701         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
1702
1703         * MiniBrowser/mac/WK2BrowserWindowController.m:
1704         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1705         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
1706         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
1707         (sawDialog):
1708         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1709         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1710         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1711
1712 2017-05-30  Alex Christensen  <achristensen@webkit.org>
1713
1714         Update libwebrtc configuration
1715         https://bugs.webkit.org/show_bug.cgi?id=172727
1716
1717         Reviewed by Geoffrey Garen.
1718
1719         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1720
1721 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1722
1723         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
1724         https://bugs.webkit.org/show_bug.cgi?id=172702
1725
1726         Reviewed by Alex Christensen.
1727
1728         EGL PlatformDisplay needs to be shut down before existing a
1729         program on Windows.
1730
1731         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
1732         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
1733         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1734         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
1735
1736 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
1737
1738         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
1739         https://bugs.webkit.org/show_bug.cgi?id=172709
1740
1741         Reviewed by Brent Fulgham.
1742
1743         Exit fullscreen mode after a fullscreen test.
1744
1745         * DumpRenderTree/win/DumpRenderTree.cpp:
1746         (resetWebViewToConsistentStateBeforeTesting):
1747
1748 2017-05-30  Antti Koivisto  <antti@apple.com>
1749
1750         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
1751         https://bugs.webkit.org/show_bug.cgi?id=172713
1752
1753         Reviewed by Zalan Bujtas.
1754
1755         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1756         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
1757
1758             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
1759             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
1760             because on Mac WK1 it may get invoked from middle of a layout.
1761
1762             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
1763
1764 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1765
1766         Add a WPE EWS queue
1767         https://bugs.webkit.org/show_bug.cgi?id=172693
1768
1769         Reviewed by Carlos Garcia Campos.
1770
1771         * QueueStatusServer/config/queues.py:
1772         * QueueStatusServer/model/queues.py: Capitalize the name of the
1773         port on the tooltip of the bubbles. Do the same for the GTK port.
1774         (Queue.display_name):
1775         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
1776         for the GTK+ EWS also. Set for both ports as watcher the alias
1777         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
1778         * Scripts/webkitpy/common/config/ports.py:
1779         (DeprecatedPort.port):
1780         (WpePort):
1781         (WpePort.build_webkit_command):
1782         (WpePort.run_webkit_tests_command):
1783         * Scripts/webkitpy/common/config/ports_unittest.py:
1784         (DeprecatedPortTest):
1785         (DeprecatedPortTest.test_wpe_port):
1786         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1787         (test_ews_name):
1788
1789 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
1790
1791         Unreviewed. Bumping the WPEBackend-mesa dependency version.
1792
1793         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
1794         priorities for IPC communication.
1795
1796 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
1797
1798         [JSC] Map and Set constructors should have fast path for cloning
1799         https://bugs.webkit.org/show_bug.cgi?id=172413
1800
1801         Reviewed by Saam Barati.
1802
1803         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1804         (TestWebKitAPI::TEST):
1805
1806 2017-05-27  Zalan Bujtas  <zalan@apple.com>
1807
1808         enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
1809         https://bugs.webkit.org/show_bug.cgi?id=172676
1810
1811         Reviewed by Simon Fraser.
1812
1813         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
1814         (TestWebKitAPI::TEST):
1815
1816 2017-05-26  Zalan Bujtas  <zalan@apple.com>
1817
1818         TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
1819         https://bugs.webkit.org/show_bug.cgi?id=172674
1820
1821         Reviewed by Simon Fraser.
1822
1823         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
1824         (TestWebKitAPI::TEST):
1825
1826 2017-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1827
1828         Add test resources back into TestWebKitAPI Copy Resources phase
1829
1830         Rubber-stamped by Beth Dakin.
1831
1832         Add two files back into the Copy Resources phase after they were unintentionally
1833         removed in r217447 and r217496.
1834
1835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1836
1837 2017-05-26  Beth Dakin  <bdakin@apple.com>
1838
1839         Media documents inside iframes should not get controls in the TouchBar unless the 
1840         video is playing
1841         https://bugs.webkit.org/show_bug.cgi?id=172620
1842         -and corresponding-
1843         rdar://problem/32165477
1844
1845         Reviewed by Jon Lee.
1846
1847         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1848         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1849         (TestWebKitAPI::TEST):
1850         * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.
1851
1852 2017-05-25  Joseph Pecoraro  <pecoraro@apple.com>
1853
1854         _WKUserStyleSheet and WKUserScript leak string data
1855         https://bugs.webkit.org/show_bug.cgi?id=172583
1856         <rdar://problem/32395209>
1857
1858         Reviewed by Sam Weinig.
1859
1860         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1861         We should not have been adopting an autoreleased object.
1862
1863 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
1864
1865         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
1866         https://bugs.webkit.org/show_bug.cgi?id=172554
1867         <rdar://problem/31247133>
1868
1869         Reviewed by Simon Fraser.
1870
1871         Previously, there was no way to make DumpRenderTree's views layer-backed. Unfortunately,
1872         simply setting [WebView setWantsLayer:] is insufficient; turning it on and then off again
1873         leaves some state around inside the NSWindow which isn't easily cleaned up. Instead,
1874         we should just tear down and rebuild the window whenever we need a layer-backed WebView.
1875         We can also use the "webkit-test-runner" header comment to trigger this new layer-backed
1876         codepath.
1877
1878         * DumpRenderTree/TestOptions.h:
1879         * DumpRenderTree/TestOptions.mm:
1880         (TestOptions::TestOptions):
1881         (TestOptions::webViewIsCompatibleWithOptions):
1882         * DumpRenderTree/mac/DumpRenderTree.mm:
1883         (shouldIgnoreWebCoreNodeLeaks):
1884         (allowedFontFamilySet):
1885         (-[DRTMockScroller rectForPart:]):
1886         (-[DRTMockScroller drawKnob]):
1887         (-[DRTMockScroller drawRect:]):
1888         (createWebViewAndOffscreenWindow):
1889         (initializeGlobalsFromCommandLineOptions):
1890         (prepareConsistentTestingEnvironment):
1891         (dumpRenderTree):
1892         (dumpAudio):
1893         (dumpHistoryItem):
1894         (dumpBackForwardListForWebView):
1895         (resetWebViewToConsistentStateBeforeTesting):
1896         (WebThreadLockAfterDelegateCallbacksHaveCompleted):
1897         (runTest):
1898
1899 2017-05-25  Sam Weinig  <sam@webkit.org>
1900
1901         [WebIDL] Use the term 'operation' more consistently
1902         https://bugs.webkit.org/show_bug.cgi?id=172601
1903
1904         Reviewed by Chris Dumez.
1905
1906         We were using the term 'operation', a WebIDL term for function-like
1907         constructs, inconsistently in the code generator. Now, when we use
1908         'operation' when referring to the IDL concept (usually the object the
1909         parser produces) and 'function' when referring to code being generated.
1910
1911         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1912         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1913
1914 2017-05-25  Jer Noble  <jer.noble@apple.com>
1915
1916         Unreviewed build fix after r217447; only run test where JSC's ObjC API is available.
1917
1918         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
1919
1920 2017-05-25  Jer Noble  <jer.noble@apple.com>
1921
1922         System sleeps while playing to wireless target, ending stream.
1923         https://bugs.webkit.org/show_bug.cgi?id=172541
1924
1925         Reviewed by Eric Carlson.
1926
1927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1928         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.html: Added.
1929         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Added.
1930         (-[MediaPlaybackSleepAssertionLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
1931         (-[MediaPlaybackSleepAssertionPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1932         (TestWebKitAPI::simulateKeyDown):
1933         (TestWebKitAPI::hasAssertionType):
1934         (TestWebKitAPI::TEST):
1935
1936 2017-05-25  Commit Queue  <commit-queue@webkit.org>
1937
1938         Unreviewed, rolling out r217423 and r217424.
1939         https://bugs.webkit.org/show_bug.cgi?id=172607
1940
1941         These caused an api failure on all testers. (Requested by
1942         mlewis13 on #webkit).
1943
1944         Reverted changesets:
1945
1946         "REGRESSION (r216977): 4 leaks introduced in new
1947         WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test"
1948         https://bugs.webkit.org/show_bug.cgi?id=172558
1949         http://trac.webkit.org/changeset/217423
1950
1951         "REGRESSION (r217423): Fix last-second typo in 'auto'"
1952         http://trac.webkit.org/changeset/217424
1953
1954 2017-05-25  Joanmarie Diggs  <jdiggs@igalia.com>
1955
1956         [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
1957         https://bugs.webkit.org/show_bug.cgi?id=172355
1958
1959         Reviewed by Chris Fleizach.
1960
1961         Add map ATK_ROLE_FOOTNOTE to "AXFootnote" and bump jhbuild minimum
1962         versions of atk, at-spi2-core, and at-spi2-atk to 2.25.2 (the earliest
1963         releases which support the new platform footnote accessibility role.
1964
1965         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1966         * gtk/jhbuild.modules:
1967
1968 2017-05-25  David Kilzer  <ddkilzer@apple.com>
1969
1970         REGRESSION (r217423): Fix last-second typo in 'auto'
1971
1972         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1973         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix typo.
1974
1975 2017-05-24  David Kilzer  <ddkilzer@apple.com>
1976
1977         REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
1978         <https://webkit.org/b/172558>
1979
1980         Reviewed by Sam Weinig.
1981
1982         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1983         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix the leaks.
1984
1985 2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>
1986
1987         [CMake] Consolidate CMake code related to Cairo
1988         https://bugs.webkit.org/show_bug.cgi?id=172568
1989
1990         Reviewed by Alex Christensen.
1991
1992         * DumpRenderTree/config.h:
1993         * TestWebKitAPI/config.h:
1994
1995 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1996
1997         Plumb additional image metadata to item providers when beginning data interaction on an image
1998         https://bugs.webkit.org/show_bug.cgi?id=172536
1999         <rdar://problem/32371300>
2000
2001         Reviewed by Beth Dakin.
2002
2003         Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
2004         source item providers.
2005
2006         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2007         (checkSuggestedNameAndEstimatedSize):
2008         (TestWebKitAPI::TEST):
2009
2010 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
2011
2012         [Win] Create unique network storage session for each DRT.
2013         https://bugs.webkit.org/show_bug.cgi?id=172540
2014
2015         Reviewed by Brent Fulgham.
2016
2017         During layout testing, each DRT instance should have its own network storage session.
2018
2019         * DumpRenderTree/win/DumpRenderTree.cpp:
2020         (prepareConsistentTestingEnvironment):
2021
2022 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2023
2024         Respect image UTIs when writing to item providers when beginning data interaction on an image
2025         https://bugs.webkit.org/show_bug.cgi?id=172436
2026         <rdar://problem/31786569>
2027
2028         Reviewed by Beth Dakin.
2029
2030         Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
2031         details.
2032
2033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2034         * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
2035         * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.
2036
2037         Create a new test page containing a GIF and a file input.
2038
2039         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2040         (checkTypeIdentifierIsRegisteredAtIndex):
2041         (TestWebKitAPI::TEST):
2042
2043 2017-05-23  Per Arne Vollan  <pvollan@apple.com>
2044
2045         [Win] Increase test timeout for slow tests.
2046         https://bugs.webkit.org/show_bug.cgi?id=172449
2047
2048         Reviewed by Alexey Proskuryakov.
2049
2050         Instead of using a fixed timeout of 30 seconds for all tests, we should use the
2051         timeout member in the TestRunner class.
2052
2053         * DumpRenderTree/win/TestRunnerWin.cpp:
2054         (TestRunner::setWaitToDump):
2055
2056 2017-05-15  Matt Rajca  <mrajca@apple.com>
2057
2058         Replace autoplay events that fire at navigation with a DidAutoplayMediaPastThreshold event.
2059         https://bugs.webkit.org/show_bug.cgi?id=172138
2060
2061         Reviewed by Alex Christensen.
2062
2063         Added API tests.
2064
2065         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2066         * TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Added.
2067         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2068         (TEST):
2069         * TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Added.
2070
2071 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
2072
2073         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
2074         https://bugs.webkit.org/show_bug.cgi?id=172522
2075         rdar://problem/31071812
2076
2077         Reviewed by Sam Weinig.
2078
2079         Remove NSWindowStyleMaskFullSizeContentView which is no longer referenced in code.
2080         We set this in the .xib file now.
2081
2082         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2083
2084 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
2085
2086         Snapshotting via -renderInContext: should do synchronous image decodes
2087         https://bugs.webkit.org/show_bug.cgi?id=172485
2088         rdar://problem/32276146
2089
2090         Reviewed by Tim Horton.
2091
2092         New API test.
2093
2094         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2095         * TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Added.
2096         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
2097         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
2098         (TestWebKitAPI::getPixelIndex):
2099         (TestWebKitAPI::TEST):
2100
2101 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
2102
2103         Remove dead ENABLE(FONT_LOAD_EVENTS) code
2104         https://bugs.webkit.org/show_bug.cgi?id=172517
2105
2106         Rubber-stamped by Simon Fraser.
2107
2108         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2109
2110 2017-05-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2111
2112         Multiple links should be inserted separately when performing data interaction
2113         https://bugs.webkit.org/show_bug.cgi?id=172489
2114         <rdar://problem/31510832>
2115
2116         Reviewed by Dan Bernstein.
2117
2118         Adds a new test that performs data interaction in a contenteditable with multiple items containing URLs.
2119
2120         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2121         (TestWebKitAPI::TEST):
2122
2123 2017-05-23  Tim Horton  <timothy_horton@apple.com>
2124
2125         REGRESSION: API test WebKit2.WKObject is failing
2126         https://bugs.webkit.org/show_bug.cgi?id=172497
2127         <rdar://problem/31694641>
2128
2129         Reviewed by Geoff Garen.
2130
2131         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2132         (TestWebKitAPI::TEST):
2133         Add a test that ensures that we pretend to at least be *some* kind of
2134         NSString, which my first fix would not have passed.
2135
2136 2017-05-23  youenn fablet  <youenn@apple.com>
2137
2138         There should be an easy way to run HTTP/WPT served tests on a browser
2139         https://bugs.webkit.org/show_bug.cgi?id=172068
2140
2141         Reviewed by Sam Weinig.
2142
2143         Adding a new script open-layout-test to open a layout-test in a
2144         browser and making sure it is served as done through run-webkit-tests.
2145         In case tests should be run using a server, detecting whether the
2146         server are running. If not, calling run-webkit-httpd to run the
2147         servers and open the URL in a browser.
2148         Otherwise, open directly the URL.
2149
2150         Adding an option in run-webkit-httpd to open an URL after having
2151         started the servers.
2152
2153         Adding the --no-http-servers option in run-webkit-tests to not start any HTTP server.
2154         This allows running run-webkit-httpd once and not having to restart
2155         servers everytime a test should be served.
2156
2157         Moving most of run-webkit-httpd logic in its own python file to reuse
2158         it in open-layout-test script.
2159
2160         Adding routines to check whether HTTP and WPT servers are running.
2161
2162         * Scripts/open-layout-test: Added.
2163         (parse_args):
2164         (main):
2165         * Scripts/run-webkit-httpd:
2166         (main):
2167         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2168         (LayoutTestFinder.find_tests):
2169         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2170         (LayoutTestRunner.run_tests):
2171         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2172         (parse_args):
2173         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2174         (HttpServerBase._is_server_running_on_all_ports):
2175         (HttpServerBase):
2176         (HttpServerBase._is_running_on_port):
2177         (HttpServerBase._check_that_all_ports_are_available):
2178         (is_http_server_running):
2179         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Copied from Tools/Scripts/run-webkit-httpd.
2180         (parse_args):
2181         (main):
2182         (run_server):
2183         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2184         (is_wpt_server_running):
2185         * Scripts/webkitpy/port/base.py:
2186         (Port.to.is_http_server_running):
2187         (Port.to):
2188         (Port.to.is_wpt_server_running):
2189         (Port.to.start_web_platform_test_server):
2190         * Scripts/webkitpy/port/driver.py:
2191         (DriverProxy.is_web_platform_test):
2192         (DriverProxy):
2193         (DriverProxy.is_webkit_specific_web_platform_test):
2194
2195 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
2196
2197         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
2198         https://bugs.webkit.org/show_bug.cgi?id=171984
2199
2200         Reviewed by Antti Koivisto.
2201
2202         * DumpRenderTree/mac/DumpRenderTree.mm:
2203         (enableExperimentalFeatures):
2204         * WebKitTestRunner/TestController.cpp:
2205         (WTR::TestController::resetPreferencesToConsistentValues):
2206
2207 2017-05-20  Alex Christensen  <achristensen@webkit.org>
2208
2209         REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
2210         https://bugs.webkit.org/show_bug.cgi?id=172406
2211         <rdar://32109532>
2212
2213         Reviewed by Brady Eidson.
2214
2215         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
2216         (TestWebKitAPI::checkBuffer):
2217         (TestWebKitAPI::TEST_F):
2218
2219 2017-05-22  Jason Marcell  <jmarcell@apple.com>
2220
2221         Do not enter Subversion-specific logic when parsing Git-based Trac data.
2222         https://bugs.webkit.org/show_bug.cgi?id=172433
2223         <rdar://problem/32234188>
2224
2225         Reviewed by Alexey Proskuryakov.
2226
2227         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2228         (Trac.prototype._convertCommitInfoElementToObject):
2229
2230 2017-05-22  Tim Horton  <timothy_horton@apple.com>
2231
2232         ExplicitSnapshotsChangeUponNavigation API test often fails
2233         https://bugs.webkit.org/show_bug.cgi?id=172475
2234         <rdar://problem/31688322>
2235
2236         Reviewed by Simon Fraser.
2237
2238         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2239         (-[TestWKWebView _setUpTestWindow:]):
2240         Make TestWKWebView's window layer-backed. This is now the default,
2241         and it's also easy to accidentally write a test that depends on it
2242         (for example, ExplicitSnapshotsChangeUponNavigation adds an NSBox,
2243         which becomes layer backed, just like the WKWebView, but with no
2244         common layer-backed ancestor).
2245
2246 2017-05-22  youenn fablet  <youenn@apple.com>
2247
2248         Resync web-platform-tests up to 8df7c9c215678328212f232ce0b5270c505a8563
2249         https://bugs.webkit.org/show_bug.cgi?id=172426
2250
2251         Reviewed by Chris Dumez.
2252
2253         * Scripts/webkitpy/w3c/test_importer.py:
2254         (TestImporter.remove_deleted_files): Outputting warning when trying to delete a file that no longer exists.
2255
2256 2017-05-22  Konstantin Tokarev  <annulen@yandex.ru>
2257
2258         Unreviewed, change my status to reviewer and fill "expertise" field
2259
2260         * Scripts/webkitpy/common/config/contributors.json:
2261
2262 2017-05-22  Tomas Popela  <tpopela@redhat.com>
2263
2264         Remove some of the EFL port leftovers
2265         https://bugs.webkit.org/show_bug.cgi?id=172440
2266
2267         Reviewed by Carlos Garcia Campos.
2268
2269         * BuildSlaveSupport/built-product-archive:
2270         (archiveBuiltProduct):
2271         (extractBuiltProduct):
2272         * BuildSlaveSupport/test-result-archive:
2273         (archiveTestResults):
2274         * ImageDiff/PlatformEfl.cmake: Removed.
2275         * Scripts/run-efl-tests: Removed.
2276         * Scripts/webkit-build-directory:
2277         * Scripts/webkitpy/common/config/contributionareas.py:
2278         * Scripts/webkitpy/common/config/watchlist:
2279         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2280         (parse_args):
2281         (_set_up_derived_options):
2282         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2283         (PerfTestsRunner.__init__):
2284         * Scripts/webkitpy/style/checker.py:
2285         * Scripts/webkitpy/style/checker_unittest.py:
2286         (GlobalVariablesTest.test_path_rules_specifier):
2287         * gtk/manifest.txt.in:
2288         * jhbuild/jhbuild-wrapper:
2289
2290 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2291
2292         Unreviewed. Do not include WPE files in GTK+ tarballs.
2293
2294         * gtk/manifest.txt.in:
2295
2296 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2297
2298         [GTK] Add webkit_context_menu_item_new_from_gaction
2299         https://bugs.webkit.org/show_bug.cgi?id=159631
2300
2301         Reviewed by Michael Catanzaro.
2302
2303         Update context menu tests to check the new GAction API.
2304
2305         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2306         (testContextMenuPopulateMenu):
2307
2308 2017-05-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2309
2310         [GTK] Remove Firefox user agent quirk for Google domains
2311         https://bugs.webkit.org/show_bug.cgi?id=171941
2312
2313         Reviewed by Carlos Garcia Campos.
2314
2315         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2316         (TestWebKitAPI::TEST):
2317         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted.
2318
2319 2017-05-20  Ting-Wei Lan  <lantw44@gmail.com>
2320
2321         [GTK] gtkdoc-fixxref needs --module argument to work
2322         https://bugs.webkit.org/show_bug.cgi?id=172415
2323
2324         Reviewed by Michael Catanzaro.
2325
2326         * gtk/gtkdoc.py:
2327         (GTKDoc._run_gtkdoc_fixxref):
2328
2329 2017-05-20  Alexey Proskuryakov  <ap@apple.com>
2330
2331         make-new-script-test should create tests that use js-test.js, not js-test-pre.js
2332         https://bugs.webkit.org/show_bug.cgi?id=172416
2333
2334         Reviewed by Daniel Bates.
2335
2336         * Scripts/make-new-script-test:
2337
2338 2017-05-19  Fujii Hironori  <Hironori.Fujii@sony.com>
2339
2340         [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
2341         https://bugs.webkit.org/show_bug.cgi?id=172267
2342
2343         Reviewed by Per Arne Vollan.
2344
2345         TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
2346         TestWebCoreLib should link only with WebCore. And, TestWebKitLib
2347         should link only with WebKit.
2348
2349         Unfortunately, there is a layer violation at the moment.
2350         WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
2351         in WebKit. This change contains a stub of loadResourceIntoBuffer
2352         in TestWebCoreLib for the workaround.
2353
2354         * TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
2355         TestWebCoreLib. Do not link WebCore to TestWebKitLib.
2356         * TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
2357         (loadResourceIntoBuffer): Added a stub.
2358
2359 2017-05-19  Simon Fraser  <simon.fraser@apple.com>
2360
2361         Fix dump-class-layout to handle different file architectures
2362         https://bugs.webkit.org/show_bug.cgi?id=172392
2363
2364         Reviewed by Zalan Bujtas.
2365
2366         Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
2367         and use the first architecture reported. Also add a "--architecture" argument
2368         to allow the user to specify an architecture.
2369
2370         * Scripts/dump-class-layout:
2371         (import_lldb):
2372         (verify_type_recursive):
2373         (get_first_file_architecture):
2374         (dump_class):
2375         (main):
2376         (find_build_directory): Deleted.
2377
2378 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
2379
2380         Unreviewed infrastructure fix.
2381
2382         * Scripts/webkitpy/port/ios_simulator.py:
2383         (IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.
2384
2385 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
2386
2387         webkitpy: Use simctl boot to run multiple simulators at once
2388         https://bugs.webkit.org/show_bug.cgi?id=172374
2389
2390         Reviewed by Alexey Proskuryakov.
2391
2392         * Scripts/webkitpy/common/system/platforminfo.py:
2393         (PlatformInfo.xcode_version): Return the current version of Xcode.
2394         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2395         (MockPlatformInfo.xcode_version): Return version 8.0 for testing.
2396         * Scripts/webkitpy/port/ios_simulator.py:
2397         (IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
2398         run multiple Simulator.app instances.
2399         (IOSSimulatorPort._create_simulators): Only copy the simulator app for older
2400         versions of Xcode.
2401         (IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
2402         an older version of Xcode.
2403
2404 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2405
2406         Unreviewed, fix the build on the latest internal SDK.
2407
2408         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2409         (TestWebKitAPI::TEST):
2410
2411 2017-05-19  Filip Pizlo  <fpizlo@apple.com>
2412
2413         arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
2414         https://bugs.webkit.org/show_bug.cgi?id=172369
2415
2416         Reviewed by Mark Lam.
2417         
2418         Because I wrote a test that relies on the NoCJIT config scribbling free cells, I thought it
2419         would be a good idea to write this down.
2420
2421         * Scripts/run-jsc-stress-tests:
2422
2423 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
2424
2425         webkitpy: Layout tests which have no output will succeed
2426         https://bugs.webkit.org/show_bug.cgi?id=172322
2427         <rdar://problem/32258350>
2428
2429         Reviewed by David Kilzer.
2430
2431         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2432         (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.
2433         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2434         (determine_result_type): FailureNotTested means that the test could not be loaded. This
2435         is classified as a MISSING failure.
2436         (FailureNotTested): Added.
2437         (FailureNotTested.message):
2438
2439 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2440
2441         Add SixSpeed benchmark to PerformanceTests
2442         https://bugs.webkit.org/show_bug.cgi?id=172326
2443
2444         Reviewed by Sam Weinig.
2445
2446         * Scripts/run-jsc-benchmarks:
2447
2448 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2449
2450         [WK1] MiniBrowser should navigate when handling a dropped URL
2451         https://bugs.webkit.org/show_bug.cgi?id=172350
2452
2453         Reviewed by Tim Horton.
2454
2455         Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.
2456
2457         * MiniBrowser/mac/WK1BrowserWindowController.m:
2458         (-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
2459
2460 2017-05-18  Ryosuke Niwa  <rniwa@webkit.org>
2461
2462         REGRESSION (r216694 - 216712): Performance test Speedometer/Full.html is failing
2463         https://bugs.webkit.org/show_bug.cgi?id=172077
2464
2465         Reviewed by Chris Dumez.
2466
2467         Fixed perftest.py by updating the lines to ignore in Speedometer.
2468
2469         Also start report the results as "Speedometer" instead of "DoYouEvenBench/Full.html" to perf.webkit.org.
2470
2471         * Scripts/webkitpy/performance_tests/perftest.py:
2472         (PerfTest._lines_to_ignore_in_parser_result): Updated for Speedometer 2.0.
2473         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2474         (PerfTestsRunner._collect_tests): Use "Speedometer" instead of "Speedometer/index.html" as the test name.
2475         (_generate_results_dict): Removed the workaround to keep reporting Speedometer as DoYouEvenBench.
2476         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2477         (MainTest.test_collect_tests_with_index_html_and_resources): Added.
2478
2479 2017-05-18  Andy Estes  <aestes@apple.com>
2480
2481         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
2482         https://bugs.webkit.org/show_bug.cgi?id=172305
2483
2484         Reviewed by Anders Carlsson.
2485
2486         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2487
2488 2017-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2489
2490         Selection around attachment elements should not persist when beginning a drag
2491         https://bugs.webkit.org/show_bug.cgi?id=172319
2492         <rdar://problem/32283008>
2493
2494         Reviewed by Tim Horton.
2495
2496         Tests that temporary selection around an attachment does not persist longer than it needs to.
2497
2498         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2499         (TestWebKitAPI::TEST):
2500
2501 2017-05-18  John Wilander  <wilander@apple.com>
2502
2503         Resource Load Statistics: Grandfather domains for existing data records
2504         https://bugs.webkit.org/show_bug.cgi?id=172155
2505         <rdar://problem/24913532>
2506
2507         Reviewed by Alex Christensen.
2508
2509         Adds test infrastructure needed for the added functionality.
2510
2511         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2512         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2513         (WTR::InjectedBundle::didReceiveMessageToPage):
2514         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2515         (WTR::TestRunner::setStatisticsGrandfathered):
2516         (WTR::TestRunner::isStatisticsGrandfathered):
2517         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2518         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
2519         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2520         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2521         * WebKitTestRunner/TestController.cpp:
2522         (WTR::TestController::setStatisticsGrandfathered):
2523         (WTR::TestController::isStatisticsGrandfathered):
2524         (WTR::TestController::setStatisticsGrandfatheringTime):
2525         * WebKitTestRunner/TestController.h:
2526         * WebKitTestRunner/TestInvocation.cpp:
2527         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2528
2529 2017-05-18  Saam Barati  <sbarati@apple.com>
2530
2531         WebAssembly: perform stack checks
2532         https://bugs.webkit.org/show_bug.cgi?id=165546
2533         <rdar://problem/29760307>
2534
2535         Reviewed by Filip Pizlo.
2536
2537         Add some new testing modes for using and not using fast TLS wasm contexts.
2538
2539         * Scripts/run-jsc-stress-tests:
2540
2541 2017-05-18  Daniel Bates  <dabates@apple.com>
2542
2543         REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
2544         window CSP when object-src 'none' is set
2545         https://bugs.webkit.org/show_bug.cgi?id=172038
2546         <rdar://problem/32258262>
2547
2548         Reviewed by Andy Estes.
2549
2550         Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl.
2551         When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone().
2552
2553         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2554         (NPP_New):
2555
2556 2017-05-18  Per Arne Vollan  <pvollan@apple.com>
2557
2558         [Win] Many layout tests are failing.
2559         https://bugs.webkit.org/show_bug.cgi?id=172286
2560
2561         Reviewed by Brent Fulgham.
2562
2563         Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
2564  
2565         * DumpRenderTree/win/TestRunnerWin.cpp:
2566         (TestRunner::grantWebNotificationPermission):
2567         (TestRunner::denyWebNotificationPermission):
2568         (TestRunner::removeAllWebNotificationPermissions):
2569         (TestRunner::simulateWebNotificationClick):
2570
2571 2017-05-18  Don Olmstead  <don.olmstead@am.sony.com>
2572
2573         [Win] Remove usage of _snprintf
2574         https://bugs.webkit.org/show_bug.cgi?id=172251
2575
2576         Reviewed by Per Arne Vollan.
2577
2578         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2579         * MiniBrowser/win/PageLoadTestClient.cpp:
2580         (PageLoadTestClient::dumpRunStatistics):
2581
2582 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
2583
2584         Unreviewed, rolling out r217014.
2585
2586         This change caused mac-wk2 LayoutTests to exit early due to
2587         crashes.
2588
2589         Reverted changeset:
2590
2591         "Resource Load Statistics: Grandfather domains for existing
2592         data records"
2593         https://bugs.webkit.org/show_bug.cgi?id=172155
2594         http://trac.webkit.org/changeset/217014
2595
2596 2017-05-17  John Wilander  <wilander@apple.com>
2597
2598         Resource Load Statistics: Grandfather domains for existing data records
2599         https://bugs.webkit.org/show_bug.cgi?id=172155
2600         <rdar://problem/24913532>
2601
2602         Reviewed by Alex Christensen.
2603
2604         Adds test infrastructure needed for the added functionality.
2605
2606         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2607         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2608         (WTR::InjectedBundle::didReceiveMessageToPage):
2609         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2610         (WTR::TestRunner::setStatisticsGrandfathered):
2611         (WTR::TestRunner::isStatisticsGrandfathered):
2612         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2613         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
2614         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2615         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2616         * WebKitTestRunner/TestController.cpp:
2617         (WTR::TestController::setStatisticsGrandfathered):
2618         (WTR::TestController::isStatisticsGrandfathered):
2619         (WTR::TestController::setStatisticsGrandfatheringTime):
2620         * WebKitTestRunner/TestController.h:
2621         * WebKitTestRunner/TestInvocation.cpp:
2622         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2623
2624 2017-05-17  Alex Christensen  <achristensen@webkit.org>
2625
2626         Fix ios-simulator API test after r216977
2627         https://bugs.webkit.org/show_bug.cgi?id=171987
2628
2629         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2630         (TEST):
2631         <rdar://problem/32260156> covers the investigation of this, but fixing it is 
2632         not as urgent as having the rest of this working. Notably the ephemeral part of the
2633         test works, so something is just wrong with the persistent part.
2634
2635 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
2636
2637         Unreviewed, rolling out r216955.
2638
2639         This change caused strange behavior with web-platform-tests
2640         locally and on EWS.
2641
2642         Reverted changeset:
2643
2644         "webkitpy: Start servers before setting-up for testing"
2645         https://bugs.webkit.org/show_bug.cgi?id=172176
2646         http://trac.webkit.org/changeset/216955
2647
2648 2017-05-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2649
2650         A URL type is vended for a non-URL plain text string when starting data interaction
2651         https://bugs.webkit.org/show_bug.cgi?id=172228
2652         <rdar://problem/32166729>
2653
2654         Reviewed by Andy Estes.
2655
2656         Adds two new data interaction tests, SinglePlainTextWordTypeIdentifiers and SinglePlainTextURLTypeIdentifiers,
2657         to verify that a URL UTI is not vended when beginning a data interaction on a single word, but that a URL is
2658         still vended when beginning data interaction on something that resembles a link.
2659
2660         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2661
2662 2017-05-17  David Kilzer  <ddkilzer@apple.com>
2663
2664         BlobDataFileReference::generateReplacementFile() should use mkstemp()
2665         <https://webkit.org/b/172192>
2666
2667         Reviewed by Brent Fulgham.
2668
2669         * Scripts/webkitpy/style/checkers/cpp.py:
2670         (check_language): Add check for mktemp.
2671         (CppChecker): Add 'security/temp_file' category.
2672         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2673         (CppStyleTest.test_insecure_temp_file): Add test.
2674
2675 2017-05-17  Devin Rousso  <drousso@apple.com>
2676
2677         Unreviewed, change my email.
2678
2679         * Scripts/webkitpy/common/config/contributors.json:
2680
2681 2017-05-17  Matt Lewis  <jlewis3@apple.com>
2682
2683         Unreviewed, rolling out r216974.
2684
2685         Revision caused consistent timeouts on all platforms.
2686
2687         Reverted changeset:
2688
2689         "Add a RuntimeEnabledFeature for display: contents, defaulted
2690         to false."
2691         https://bugs.webkit.org/show_bug.cgi?id=171984
2692         http://trac.webkit.org/changeset/216974
2693
2694 2017-05-17  Alex Christensen  <achristensen@webkit.org>
2695
2696         Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should affect cookies used
2697         https://bugs.webkit.org/show_bug.cgi?id=171987
2698
2699         Reviewed by Brady Eidson.
2700
2701         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2702         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2703         (TEST):
2704
2705 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
2706
2707         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
2708         https://bugs.webkit.org/show_bug.cgi?id=171984
2709
2710         Reviewed by Antti Koivisto.
2711
2712         * DumpRenderTree/mac/DumpRenderTree.mm:
2713         (enableExperimentalFeatures):
2714         * WebKitTestRunner/TestController.cpp:
2715         (WTR::TestController::resetPreferencesToConsistentValues):
2716
2717 2017-05-16  Timothy Horton  <timothy_horton@apple.com>
2718
2719         Fix the build
2720
2721         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2722         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2723
2724 2017-05-16  Tim Horton  <timothy_horton@apple.com>
2725
2726         PageVisibilityStateWithWindowChanges tests sometimes time out
2727         https://bugs.webkit.org/show_bug.cgi?id=172202
2728         <rdar://problem/29653266>
2729
2730         Reviewed by Dean Jackson.
2731
2732         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2733         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2734         Make sure the window is miniaturizable, otherwise, in some cases, miniaturize: will not work.
2735
2736 2017-05-16  Jonathan Bedard  <jbedard@apple.com>
2737
2738         webkitpy: Start servers before setting-up for testing
2739         https://bugs.webkit.org/show_bug.cgi?id=172176
2740         <rdar://problem/32225538>
2741
2742         Reviewed by Alexey Proskuryakov.
2743
2744         On-device testing requires that servers are started before ports set-up their
2745         test environments.
2746
2747         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2748         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
2749         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer.
2750         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2751         (Manager.__init__): Delay construction of the test runner until we can determine
2752         if servers need to be started.
2753         (Manager.run): Determine if servers need to be started and construct the test runner.
2754         (Manager._run_tests): Move the determination of servers to run into Manager.run.
2755
2756 2017-05-16  Adrian Perez de Castro  <aperez@igalia.com>
2757
2758         Unreviewed, adding myself to contributors.json
2759
2760         * Scripts/webkitpy/common/config/contributors.json:
2761
2762 2017-05-16  Claudio Saavedra  <csaavedra@igalia.com>
2763
2764         [GTK] Tests that always pass when run alone, but fail in the bots
2765         https://bugs.webkit.org/show_bug.cgi?id=168572
2766
2767         Reviewed by Michael Catanzaro.
2768
2769         PlatformWebView::viewSupportsOptions() is basically a comparison
2770         that checks that the passed options are the ones supported by the
2771         web view. There is no reason for them to be implemented for each
2772         platform differently. In fact doing so causes issues each time a
2773         new option is added, if the corresponding platform implementation
2774         is not updated accordingly.
2775
2776         A consequence of not updating the viewSupportOptions()
2777         implementations when new options are added is that tests that need
2778         these options might fail if they are executed after a test that
2779         didn't need the option, as the webview will be reused even if the
2780         option is not supported. This cannot be spotted when running the
2781         tests individually. See bug #165133 for other example of the same
2782         problem.
2783
2784         Remove the platform implementations and make the comparison a
2785         method of the TestOptions structure, so that the check is in one
2786         place. For the time being, only include in the comparison the
2787         options that were checked in the mac platform, which seem to be
2788         the only ones relevant this far (unless newer ones have also been
2789         forgotten).
2790
2791         * WebKitTestRunner/PlatformWebView.h:
2792         (WTR::PlatformWebView::viewSupportsOptions): Use the method
2793         defined below.
2794         * WebKitTestRunner/TestOptions.h:
2795         (WTR::TestOptions::hasSameInitializationOptions): Added.
2796         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2797         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2798         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2799         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2800         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2801         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2802         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
2803         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2804
2805 2017-05-15  Yusuke Suzuki  <utatane.tea@gmail.com>
2806
2807         [JSC] Build testapi in non Apple ports
2808         https://bugs.webkit.org/show_bug.cgi?id=172103
2809
2810         Reviewed by Filip Pizlo.
2811
2812         Now testapi is drived in JSCOnly, GTK and WPE ports too.
2813
2814         * Scripts/build-jsc:
2815         * Scripts/run-javascriptcore-tests:
2816
2817 2017-05-15  Youenn Fablet  <youenn@apple.com>
2818
2819         WPT test importer should not account for slow manual tests
2820         https://bugs.webkit.org/show_bug.cgi?id=172127
2821
2822         Reviewed by Ryosuke Niwa.
2823
2824         Making sure manual tests are not triggering updating tests-options.json file.
2825
2826         * Scripts/webkitpy/w3c/test_importer.py:
2827         (TestImporter.find_importable_tests):
2828         (TestImporter._already_identified_as_resource_file):
2829         (TestImporter.update_tests_options):
2830         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2831         (test_manual_slow_test):
2832
2833 2017-05-15  Jonathan Bedard  <jbedard@apple.com>
2834
2835         webkitpy: Some versions of simctl do not place parenthesis around runtime identifiers
2836         https://bugs.webkit.org/show_bug.cgi?id=172142
2837
2838         Reviewed by Tim Horton.
2839
2840         * Scripts/webkitpy/xcode/simulator.py:
2841         (Simulator._parse_runtimes): Newer versions of simctl output do not put parenthesis
2842         around runtime identifiers.
2843         * Scripts/webkitpy/xcode/simulator_unittest.py: Add tests for new simctl output.
2844
2845 2017-05-15  Ryosuke Niwa  <rniwa@webkit.org>
2846
2847         Update ARES-6 plan file to use the latest version
2848         https://bugs.webkit.org/show_bug.cgi?id=172139
2849
2850         Reviewed by Keith Miller.
2851
2852         Include r216538.
2853
2854         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2855
2856 2017-05-15  Jeremy Jones  <jeremyj@apple.com>
2857
2858         Disable Picture In Picture API tests on unsupported platforms.
2859         https://bugs.webkit.org/show_bug.cgi?id=172125
2860         rdar://problem/32199477
2861
2862         Reviewed by Simon Fraser.
2863
2864         The callbacks and allowing picture-in-picture require new SPI.
2865
2866         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
2867
2868 2017-05-15  Brady Eidson  <beidson@apple.com>
2869
2870         [ios-simulator] API test WKWebView.ClearAppCache is failing.
2871         https://bugs.webkit.org/show_bug.cgi?id=172120
2872
2873         Unreviewed test gardening.
2874
2875         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2876         (TEST): ios-sim needs explicit deleting of the app cache paths that I'd removed in 216805.
2877           Restoring that code fixes this.
2878
2879 2017-05-15  Timothy Horton  <timothy_horton@apple.com>
2880
2881         Null deref under WebContentReader::readURL when interacting with a file URL
2882         https://bugs.webkit.org/show_bug.cgi?id=172045
2883         <rdar://problem/25880647>
2884
2885         Reviewed by Wenson Hsieh.
2886
2887         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2888         (TestWebKitAPI::TEST):
2889         The text of the file URL is pasted because a textual version of it gets
2890         onto the pasteboard. However, this test would have crashed before. Also
2891         tests that we don't make an <a>.
2892
2893 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
2894
2895         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
2896         https://bugs.webkit.org/show_bug.cgi?id=172071
2897
2898         Reviewed by Alexey Proskuryakov.
2899
2900         * DumpRenderTree/win/DumpRenderTree.cpp:
2901         (resetWebPreferencesToConsistentValues):
2902
2903 2017-05-14  Chris Dumez  <cdumez@apple.com>
2904
2905         Drop PassRefPtr class from WTF
2906         https://bugs.webkit.org/show_bug.cgi?id=172091
2907
2908         Reviewed by Alex Christensen.
2909
2910         Drop API test coverage.
2911
2912         * TestWebKitAPI/Tests/WTF/Ref.cpp:
2913         (TestWebKitAPI::TEST):
2914         (TestWebKitAPI::passWithPassRefPtr): Deleted.
2915
2916 2017-05-13  Eric Carlson  <eric.carlson@apple.com>
2917
2918         [MediaStream] deviceId constraint doesn't work with getUserMedia
2919         https://bugs.webkit.org/show_bug.cgi?id=171877
2920         <rdar://problem/31899730>
2921
2922         Reviewed by Jer Noble.
2923
2924         The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
2925         implement the "checkUserMediaPermission" callback.
2926         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2927         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
2928         (TestWebKitAPI::checkUserMediaPermissionCallback):
2929         (TestWebKitAPI::TEST):
2930
2931         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:
2932         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2933
2934 2017-05-13  Chris Dumez  <cdumez@apple.com>
2935
2936         Stop using RefPtr::release()
2937         https://bugs.webkit.org/show_bug.cgi?id=172074
2938
2939         Reviewed by Geoffrey Garen.
2940
2941         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2942         (TestWebKitAPI::TEST):
2943
2944 2017-05-13  Commit Queue  <commit-queue@webkit.org>
2945
2946         Unreviewed, rolling out r216808.
2947         https://bugs.webkit.org/show_bug.cgi?id=172075
2948
2949         caused lldb to hang when debugging (Requested by smfr on
2950         #webkit).
2951
2952         Reverted changeset:
2953
2954         "Use Mach exceptions instead of signals where possible"
2955         https://bugs.webkit.org/show_bug.cgi?id=171865
2956         http://trac.webkit.org/changeset/216808
2957
2958 2017-05-12  Alex Christensen  <achristensen@webkit.org>
2959
2960         Rename WKContentExtension to WKContentRuleList
2961         https://bugs.webkit.org/show_bug.cgi?id=172053
2962         <rdar://problem/32141005>
2963
2964         Reviewed by Geoffrey Garen.
2965
2966         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:
2967         (WKContentRuleListStoreTest::SetUp):
2968         (TEST_F):
2969         (-[ContentRuleListDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2970         (WKContentExtensionStoreTest::SetUp): Deleted.
2971         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
2972
2973 2017-05-12  Keith Miller  <keith_miller@apple.com>
2974
2975         Use Mach exceptions instead of signals where possible
2976         https://bugs.webkit.org/show_bug.cgi?id=171865
2977
2978         Reviewed by Mark Lam.
2979
2980         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2981         (runThreadMessageTest):
2982         (TEST):
2983
2984 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
2985
2986         Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
2987         https://bugs.webkit.org/show_bug.cgi?id=172048
2988         rdar://problem/32163054
2989
2990         Reviewed by Simon Fraser.
2991
2992         Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.
2993
2994         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
2995         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
2996         (hasVideoInPictureInPictureDidChange):
2997         (-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
2998         (-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
2999         (TestWebKitAPI::TEST):
3000
3001 2017-05-12  Brady Eidson  <beidson@apple.com>
3002
3003         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
3004         https://bugs.webkit.org/show_bug.cgi?id=172030
3005
3006         Unreviewed - Test gardening
3007
3008         Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
3009         before the test starts.
3010
3011         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3012         (defaultWebsiteCacheDirectory):
3013         (defaultApplicationCacheDirectory):
3014         (TEST):
3015         (defaultWebsiteDataDirectory): Deleted.
3016
3017 2017-05-12  David Quesada  <david_quesada@apple.com>
3018
3019         Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
3020         https://bugs.webkit.org/show_bug.cgi?id=172000
3021         rdar://problem/32144756
3022
3023         Reviewed by Simon Fraser.
3024
3025         Added API tests to verify that WKWebView provides the expected value for
3026         _visibleContentRect in various configurations. (i.e. not inside a scrollview,
3027         inside a scrollview but not clipped, clipped by an ancestor scrollview,
3028         clipped by the webview's _enclosingViewForExposedRectComputation)
3029
3030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3031         * TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.
3032         (-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
3033         (TestWebKitAPI::TEST):
3034
3035 2017-05-12  Brady Eidson  <beidson@apple.com>
3036
3037         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
3038         https://bugs.webkit.org/show_bug.cgi?id=172030
3039
3040         Unreviewed - Test gardening, in effect...
3041
3042         More exploration as to why this continues to fail on the bots.
3043         
3044         This change should give us a smoking gun.
3045         
3046         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3047         (TEST):
3048
3049 2017-05-12  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3050
3051         [GTK] Fix compile warnings in PlatformImageCairo.cpp
3052         https://bugs.webkit.org/show_bug.cgi?id=171850
3053
3054         Reviewed by Michael Catanzaro.
3055
3056         * ImageDiff/cairo/PlatformImageCairo.cpp:
3057         (ImageDiff::PlatformImage::createFromStdin):
3058         (ImageDiff::PlatformImage::writeAsPNGToStdout):
3059
3060 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
3061
3062         Add UIClient callback for when picture-in-picture is activated.
3063         https://bugs.webkit.org/show_bug.cgi?id=172023
3064
3065         Reviewed by Simon Fraser.
3066
3067         Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.
3068
3069         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3070         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
3071         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.
3072         (onLoadedCompletedCallback):
3073         (waitUntilOnLoadIsCompleted):
3074         (didFinishLoadForFrame):
3075         (setHasVideoInPictureInPicture):
3076         (TestWebKitAPI::TEST):
3077
3078 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
3079
3080         Unreviewed follow-up to r216776.
3081
3082         * Scripts/webkitpy/port/base.py:
3083         (Port.path_to_crash_logs): Raise not implemented.
3084         * Scripts/webkitpy/port/test.py:
3085         (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
3086         * Scripts/webkitpy/port/win.py:
3087         (WinPort.path_to_crash_logs): Ditto.
3088
3089 2017-05-12  Alexey Proskuryakov  <ap@apple.com>
3090
3091         Bot watcher's dashboard shows results links twice sometimes
3092         https://bugs.webkit.org/show_bug.cgi?id=172043
3093
3094         Reviewed by Tim Horton.
3095
3096         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3097         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
3098
3099 2017-05-12  Brady Eidson  <beidson@apple.com>
3100
3101         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
3102         https://bugs.webkit.org/show_bug.cgi?id=172030
3103
3104         Unreviewed - Test gardening, in effect...
3105
3106         This failure is only being seen by the bots.
3107         
3108         I believe this test is utterly broken in the first place; when it checks the .wal file's
3109         size that is not actually an indicator that the records were deleted.
3110         
3111         But that isn't what's coming up as failure on the bots.
3112         
3113         This patch is an attempt to:
3114         1 - More forcefully clear the Website data directory of leftovers before the test starts.
3115         2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.
3116
3117         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3118         (defaultWebsiteDataDirectory):
3119         (defaultApplicationCacheDirectory):
3120         (TEST):
3121
3122 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
3123
3124         webkitpy: Pass directory with crash logs into CrashLogs
3125         https://bugs.webkit.org/show_bug.cgi?id=172033
3126         <rdar://problem/32157616>
3127
3128         Reviewed by Daniel Bates.
3129
3130         Refactor CrashLogs and the callers of CrashLogs so that the port object owns
3131         the location of crash logs.
3132
3133         * Scripts/webkitpy/common/system/crashlogs.py:
3134         (CrashLogs.__init__): Pass mandatory crash_log_directory when constructing.
3135         (CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of
3136         generating one.
3137         (CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of
3138         self._results_directory.
3139         (CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of
3140         generating one.
3141         (CrashLogs._log_directory_darwin): Moved to port.
3142         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path
3143         to the crash log is no longer owned by CrashLogs.
3144         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general
3145         directory for uploading crash logs. Note that crash logs are only supported on Mac
3146         and Windows.
3147         * Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import.
3148         * Scripts/webkitpy/port/base.py:
3149         (Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed
3150         to be in the results directory.
3151         * Scripts/webkitpy/port/darwin.py:
3152         (DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin.
3153         (DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path.
3154         (DarwinPort._get_crash_log): Ditto.
3155         * Scripts/webkitpy/port/darwin_testcase.py:
3156         (DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating
3157         the path to crash logs.
3158         * Scripts/webkitpy/port/ios_device.py:
3159         (IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS.
3160         * Scripts/webkitpy/port/ios_device_unittest.py:
3161         (IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS.
3162         * Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import.
3163         * Scripts/webkitpy/port/mac.py: Ditto.
3164         * Scripts/webkitpy/port/test.py:
3165         (TestDriver.run_test): Use port specific crash log path when retrieving crash logs.
3166         * Scripts/webkitpy/port/win.py:
3167         (WinPort._get_crash_log): Ditto.
3168         * Scripts/webkitpy/tool/commands/queries.py:
3169         (execute): Construct a port object since this is the object which owns the path to crash logs.
3170
3171 2017-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3172
3173         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.
3174
3175         In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
3176         URL parameter using the default value "about:blank" when not provided.
3177
3178         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3179         (testWebViewCreateNavigationData):
3180
3181 2017-05-11  Youenn Fablet  <youenn@apple.com>
3182
3183         Allow WPT server to serve specific WebKit test
3184         https://bugs.webkit.org/show_bug.cgi?id=171479
3185
3186         Reviewed by Ryosuke Niwa.
3187
3188         Adding a new mount point to WPT server.
3189         It points to LayoutTests/http/wpt folder and is triggered on "/WebKit" urls.
3190
3191         Updating the webkitpy infrastructure to launch WPT server and do test url mapping for LayoutTests/wpt tests.
3192
3193         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3194         (Manager.__init__):
3195         (Manager._is_http_test):
3196         (Manager._needs_web_platform_test):
3197         (Manager._run_tests):
3198         (Manager._is_web_platform_test): Deleted.
3199         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3200         (build_routes):
3201         (main):
3202         * Scripts/webkitpy/port/driver.py:
3203         (Driver):
3204         (Driver.is_webkit_specific_web_platform_test):
3205         (Driver.test_to_uri):
3206         (Driver._command_from_driver_input):
3207
3208 2017-05-11  Brady Eidson  <beidson@apple.com>
3209
3210         [WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path.
3211         <rdar://problem/30612463> and https://bugs.webkit.org/show_bug.cgi?id=171994
3212
3213         Reviewed by Andy Estes.
3214         Informal review by Maureen Daum.
3215
3216         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3217         (TEST):
3218
3219 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
3220
3221         REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
3222         https://bugs.webkit.org/show_bug.cgi?id=171989
3223
3224         Reviewed by Brian Burg.
3225
3226         * lldb/lldb_webkit.py:
3227         (WTFStringImplProvider.get_data8):
3228         (WTFStringImplProvider.get_data16):
3229         m_data8 and m_data16 are now part of the superclass StringImplShape
3230         instead of directly in StringImpl. So first get the shape by getting
3231         index 0, and the data properties are the same offset within that.
3232
3233 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
3234
3235         Remove Vibration API
3236         https://bugs.webkit.org/show_bug.cgi?id=171766
3237
3238         Rubber-stamped by Alexey Proskuryakov.
3239
3240         * Scripts/webkitperl/FeatureList.pm:
3241
3242 2017-05-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3243
3244         Add WPE release bots
3245         https://bugs.webkit.org/show_bug.cgi?id=171973
3246
3247         Reviewed by Žan Doberšek.
3248
3249         This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
3250         It also adds a new WPE buildbot category.
3251
3252         * BuildSlaveSupport/build.webkit.org-config/config.json:
3253         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3254         (InstallWpeDependencies):
3255         (appendCustomBuildFlags):
3256         (Factory.__init__):
3257         (loadBuilderConfig):
3258         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3259         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3260
3261 2017-05-09  Sam Weinig  <sam@webkit.org>
3262
3263         Remove support for legacy Notifications
3264         https://bugs.webkit.org/show_bug.cgi?id=171487
3265
3266         Reviewed by Jon Lee.
3267
3268         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3269         (DRTDesktopNotificationPresenter::checkNotificationPermission):
3270         * Scripts/webkitperl/FeatureList.pm:
3271         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3272         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
3273
3274 2017-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3275
3276         Remove user agent quirk for Slack
3277         https://bugs.webkit.org/show_bug.cgi?id=171869
3278
3279         Reviewed by Carlos Garcia Campos.
3280
3281         Remove the corresponding test.
3282
3283         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3284         (TestWebKitAPI::TEST):
3285
3286 2017-05-10  Commit Queue  <commit-queue@webkit.org>
3287
3288         Unreviewed, rolling out r216578.
3289         https://bugs.webkit.org/show_bug.cgi?id=171920
3290
3291         Broke the GTK+ build with Wayland enabled (Requested by KaL on
3292         #webkit).
3293
3294         Reverted changeset:
3295
3296         "[GTK] Bump GTK+ and its dependencies in jhbuild"
3297         https://bugs.webkit.org/show_bug.cgi?id=171918
3298         http://trac.webkit.org/changeset/216578
3299
3300 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3301
3302         [GTK] Bump GTK+ and its dependencies in jhbuild
3303         https://bugs.webkit.org/show_bug.cgi?id=171918
3304
3305         Reviewed by Carlos Alberto Lopez Perez.
3306
3307         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3308         (WTR::initializeGtkSettings):
3309         * gtk/jhbuild.modules:
3310         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
3311         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
3312
3313 2017-05-10  Don Olmstead  <don.olmstead@am.sony.com>
3314
3315         [Win] Set CMake args in build-webkit
3316         https://bugs.webkit.org/show_bug.cgi?id=171436
3317
3318         Reviewed by Per Arne Vollan.
3319
3320         * Scripts/build-webkit:
3321
3322 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3323
3324         ImageDiff: Add CG implementation for new ImageDiff
3325         https://bugs.webkit.org/show_bug.cgi?id=170608
3326
3327         Reviewed Alex Christensen.
3328
3329         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3330         * DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
3331         * DumpRenderTree/win/ImageDiffWin.cpp: Removed.
3332         * ImageDiff/CMakeLists.txt:
3333         * ImageDiff/Cairo.cmake:
3334         * ImageDiff/ImageDiff.cpp:
3335         (main):
3336         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3337         * ImageDiff/PlatformImage.cpp:
3338         * ImageDiff/PlatformImage.h:
3339         * ImageDiff/cairo/PlatformImageCairo.cpp:
3340         * ImageDiff/cg/ImageDiff.cpp: Removed.
3341         * ImageDiff/cg/PlatformImageCG.cpp: Added.
3342         (ImageDiff::PlatformImage::createFromStdin):
3343         (ImageDiff::PlatformImage::createFromDiffData):
3344         (ImageDiff::PlatformImage::PlatformImage):
3345         (ImageDiff::PlatformImage::~PlatformImage):
3346         (ImageDiff::PlatformImage::width):
3347         (ImageDiff::PlatformImage::height):
3348         (ImageDiff::PlatformImage::rowBytes):
3349         (ImageDiff::PlatformImage::hasAlpha):
3350         (ImageDiff::PlatformImage::pixels):
3351         (ImageDiff::PlatformImage::writeAsPNGToStdout):
3352
3353 2017-05-10  Zan Dobersek  <zdobersek@igalia.com>
3354
3355         Enable FTL JIT by default on AArch64
3356         https://bugs.webkit.org/show_bug.cgi?id=144039
3357
3358         Reviewed by Yusuke Suzuki.
3359
3360         * Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
3361         * Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination
3362         as an unsupported FTL platform.
3363         * Scripts/webkitdirs.pm:
3364         (isARM64): Returns 1 if the determined architecture is 'arm64'.
3365         * Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.
3366
3367 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
3368
3369         webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
3370         https://bugs.webkit.org/show_bug.cgi?id=170857
3371         <rdar://problem/31635373>
3372
3373         Reviewed by Aakash Jain.
3374
3375         Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
3376         code to search for crash logs.
3377
3378         * Scripts/webkitpy/port/darwin.py:
3379         (DarwinPort._get_crash_log): Moved from MacPort.
3380         * Scripts/webkitpy/port/darwin_testcase.py:
3381         (DarwinTest.test_get_crash_log): Moved from MacTest.
3382         * Scripts/webkitpy/port/ios_device.py:
3383         (IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
3384         devices must search for crash-logs remotely.
3385         * Scripts/webkitpy/port/ios_simulator.py:
3386         (IOSSimulatorPort._get_crash_log): Deleted.
3387         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3388         (IOSSimulatorTest.test_get_crash_log): Deleted.
3389         * Scripts/webkitpy/port/mac.py:
3390         (MacPort._get_crash_log): Moved to DarwinPort
3391         * Scripts/webkitpy/port/mac_unittest.py:
3392         (MacTest.test_get_crash_log): Moved to DarwinTest.
3393
3394 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
3395
3396         build ImageDiff with host SDK from Make
3397         https://bugs.webkit.org/show_bug.cgi?id=171835
3398
3399         Reviewed by Alexey Proskuryakov.
3400
3401         ImageDiff should be built for the default SDK and default architecture when
3402         the SDKROOT is set to either iOS device or iOS simulator. Check the
3403         DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.
3404
3405         * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
3406         * Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.
3407
3408 2017-05-09  Matt Lewis  <jlewis3@apple.com>
3409
3410         Unreviewed, adding myself to contributors.json
3411
3412         * Scripts/webkitpy/common/config/contributors.json:
3413
3414 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
3415
3416         REGRESSION: ImageDiff not building with make
3417         https://bugs.webkit.org/show_bug.cgi?id=171788
3418
3419         Reviewed by Alex Christensen.
3420
3421         * Makefile: Build ImageDiff for all platforms.
3422
3423 2017-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3424
3425         [Win] ImageDiff isn't built since Bug 168945
3426         https://bugs.webkit.org/show_bug.cgi?id=171847
3427
3428         Reviewed by Alex Christensen.
3429
3430         * CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
3431         * ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
3432         * ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.
3433
3434 2017-05-09  Zan Dobersek  <zdobersek@igalia.com>
3435
3436         Upstream the WPE port
3437         https://bugs.webkit.org/show_bug.cgi?id=171110
3438
3439         Reviewed by Alex Christensen.
3440
3441         webkit-dev thread:
3442         https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html
3443
3444         Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
3445         In-file changes removed from this ChangeLog entry for brevity.
3446
3447         * BuildSlaveSupport/built-product-archive:
3448         * BuildSlaveSupport/test-result-archive:
3449         * CMakeLists.txt:
3450         * ImageDiff/PlatformWPE.cmake: Added.
3451         * Scripts/build-dumprendertree:
3452         * Scripts/build-webkit:
3453         * Scripts/build-webkittestrunner:
3454         * Scripts/update-webkit-libs-jhbuild:
3455         * Scripts/update-webkitwpe-libs: Added.
3456         * Scripts/webkitdirs.pm:
3457         * Scripts/webkitperl/FeatureList.pm:
3458         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3459         * Scripts/webkitpy/port/factory.py:
3460         * Scripts/webkitpy/port/wpe.py: Added.
3461         * TestWebKitAPI/PlatformWPE.cmake: Added.
3462         * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
3463         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
3464         * TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
3465         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3466         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3467         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3468         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3469         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3470         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3471         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
3472         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
3473         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
3474         * WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
3475         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
3476         * WebKitTestRunner/PlatformWPE.cmake: Added.
3477         * WebKitTestRunner/PlatformWebView.h:
3478         * WebKitTestRunner/TestController.cpp:
3479         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
3480         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
3481         * WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
3482         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
3483         * WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
3484         * WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
3485         * jhbuild/jhbuild-wrapper:
3486         * wpe/generate-inspector-gresource-manifest.py: Added.
3487         * wpe/jhbuild.modules: Added.
3488         * wpe/jhbuildrc: Added.
3489         * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
3490         * wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
3491         * wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
3492         * wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
3493         * wpe/patches/glib-warning-fix.patch: Added.
3494         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
3495         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
3496         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3497         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3498         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.
3499
3500 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
3501
3502         Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
3503         https://bugs.webkit.org/show_bug.cgi?id=169421
3504         <rdar://problem/30950171>
3505
3506         Reviewed by Tim Horton.
3507
3508         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3509         (createBitmapContextFromWebView): Implement for IOSurface.
3510         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3511         (WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.
3512
3513 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
3514
3515         buildbot: Cleanup simulators after running tests
3516         https://bugs.webkit.org/show_bug.cgi?id=171679
3517
3518         Reviewed by Aakash Jain.
3519
3520         simctl is partitioned for each user. Since kill-old-processes
3521         is run as root, we need to specify the buildbot user when tearing
3522         down simulators between steps.
3523
3524         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3525         (KillOldProcesses): Pass buildbot user to kill-old-processes.
3526         * BuildSlaveSupport/kill-old-processes:
3527         (main): Specify the user for simctl if one has been provided.
3528
3529 2017-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3530
3531         REGRESSION(r216179): [GTK] Script install-dependencies misses liborc
3532         https://bugs.webkit.org/show_bug.cgi?id=171681
3533
3534         Reviewed by Carlos Garcia Campos.
3535
3536         * gtk/install-dependencies:
3537
3538 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3539
3540         Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.
3541
3542         Glib uses now Unicode quotes in error messages.
3543
3544         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
3545         (testWebKitConsoleMessageNetworkError):
3546
3547 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3548
3549         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r215404.
3550
3551         Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
3552         should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
3553         characters to the input. Also fix typo in the function name.
3554
3555         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3556         (testWebViewJavaScriptDialogs):
3557
3558 2017-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3559
3560         [GTK] Cannot sign in with new Google sign-in page
3561         https://bugs.webkit.org/show_bug.cgi?id=171770
3562
3563         Unreviewed. This just adds a test.
3564
3565         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3566         (TestWebKitAPI::TEST):
3567
3568 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
3569
3570         [iOS WK2] Make rotation tests more reliable
3571         https://bugs.webkit.org/show_bug.cgi?id=171778
3572
3573         Reviewed by Tim Horton.
3574
3575         Switching between "safari-style" rotation and normal rotation left state on the WKWebView
3576         that would cause later viewport-sensitive tests to fail. The WKWebView would be left
3577         with override layout parameters, and an override orientation, and these caused viewport
3578         size to leak into later tests, and WebCore orientation to not get reset correctly.
3579
3580         Also, WKWebView was unregistering for UIWindowDidRotateNotification notifications when
3581         an override orientation was set, and would never re-register, causing lost orientationchanged
3582         events.
3583
3584         Fix by exposing WKWebView SPI to clear the various bits of overide state. Also don't unregister
3585         from the UIWindowDidRotateNotification notification; it's already ignored anyway if it fires.
3586
3587         Also wait for a visible content rect update after resizing the WKWebVeiw between tests, to make sure
3588         the WebProcess is caught up before proceeding with the test.
3589
3590         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3591         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
3592         * WebKitTestRunner/ios/TestControllerIOS.mm:
3593         (WTR::TestController::platformResetStateToConsistentValues):
3594         (WTR::TestController::platformConfigureViewForTest):
3595
3596 2017-05-06  Csaba Osztrogonác  <ossy@webkit.org>
3597
3598         [Mac][cmake] Buildfix after r216047
3599         https://bugs.webkit.org/show_bug.cgi?id=171769
3600
3601         Unreviewed buildfix.
3602
3603         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3604
3605 2017-05-05  Brady Eidson  <beidson@apple.com>
3606
3607         API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
3608         <rdar://problem/31977294> and https://bugs.webkit.org/show_bug.cgi?id=171513
3609
3610         Reviewed by Andy Estes.
3611
3612         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3613         (TEST):
3614
3615 2017-05-05  Brian Burg  <bburg@apple.com>
3616
3617         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
3618         https://bugs.webkit.org/show_bug.cgi?id=171748
3619         <rdar://problem/32027327>
3620
3621         Reviewed by Michael Catanzaro.
3622
3623         Remove temporary workaround now that the assertion failure is fixed.
3624
3625         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3626         (TEST):
3627
3628 2017-05-05  Simon Fraser  <simon.fraser@apple.com>
3629
3630         Make it possible to test rotation in iOS WebKitTestRunner
3631         https://bugs.webkit.org/show_bug.cgi?id=171755
3632
3633         Reviewed by Tim Horton.
3634
3635         Add to UIScriptController:
3636             void simulateRotation(DeviceOrientation orientation, object callback);
3637             void simulateRotationLikeSafari(DeviceOrientation orientation, object callback);
3638
3639         The former just does a view resize, as a simple WKWebView app would do. The second does
3640         animation more like MobileSafari, using _begin/_endAnimatedResize. and associated override
3641         layout size and interface orientation. The two behaviors produce different resize and
3642         orientationchange events and sizes, and both need to be tested.
3643
3644         Rotation is initiated by a call on UIDevice, and responded to by the root view controller,
3645         which is now a custom subclass (PlatformWebViewController).
3646
3647         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3648         (WTR::UIScriptController::simulateRotation):
3649         (WTR::UIScriptController::simulateRotationLikeSafari):
3650         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3651         (WTR::UIScriptController::simulateRotation):
3652         (WTR::UIScriptController::simulateRotationLikeSafari):
3653         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3654         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3655         (WTR::toDeviceOrientation):
3656         (WTR::UIScriptController::simulateRotation):
3657         (WTR::UIScriptController::simulateRotationLikeSafari):
3658         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3659         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3660         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3661         (-[TestRunnerWKWebView dealloc]):
3662         (-[TestRunnerWKWebView _didEndRotation]):
3663         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3664         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
3665         (WTR::PlatformWebView::PlatformWebView):
3666         * WebKitTestRunner/ios/TestControllerIOS.mm:
3667         (WTR::TestController::platformResetStateToConsistentValues):
3668         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3669         (WTR::toUIDeviceOrientation):
3670         (WTR::UIScriptController::simulateRotation):
3671         (WTR::UIScriptController::simulateRotationLikeSafari):
3672         (WTR::UIScriptController::platformClearAllCallbacks):
3673         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3674         (WTR::UIScriptController::simulateRotation):
3675         (WTR::UIScriptController::simulateRotationLikeSafari):
3676
3677 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
3678
3679         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
3680         https://bugs.webkit.org/show_bug.cgi?id=168945
3681         <rdar://problem/30745695>
3682
3683         Reviewed by David Kilzer.
3684
3685         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
3686         target SDK. These two changes must happen simultaneously because some archives will
3687         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
3688
3689         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
3690         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
3691         tools directory still includes ImageDiff.
3692         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
3693         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
3694         * Scripts/webkitpy/port/darwin.py: 
3695         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
3696         locally or when running archives.
3697         * Scripts/webkitpy/port/image_diff.py:
3698         (IOSSimulatorImageDiffer): Deleted.
3699         * Scripts/webkitpy/port/ios_simulator.py:
3700         (IOSSimulatorPort.diff_image): Deleted.
3701
3702 2017-05-05  Brian Burg  <bburg@apple.com>
3703
3704         API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies
3705         https://bugs.webkit.org/show_bug.cgi?id=171748
3706
3707         Unreviewed test gardening.
3708
3709         The assertion failure will be investigated separately in order to avoid rolling out
3710         the fix for "secure" cookies. This assertion fails even without r216258 applied.
3711
3712         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3713         (TEST):
3714
3715 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
3716
3717         Unreviewed, rolling out r216260.
3718
3719         Breaks internal iOS testers
3720
3721         Reverted changeset:
3722
3723         "Use ImageDiff built by host SDK and remove ImageDiff from
3724         DumpRenderTree"
3725         https://bugs.webkit.org/show_bug.cgi?id=168945
3726         http://trac.webkit.org/changeset/216260
3727
3728 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
3729
3730         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
3731         https://bugs.webkit.org/show_bug.cgi?id=168945
3732         <rdar://problem/30745695>
3733
3734         Reviewed by David Kilzer.
3735
3736         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
3737         target SDK. These two changes must happen simultaneously because some archives will
3738         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
3739
3740         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
3741         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
3742         tools directory still includes ImageDiff.
3743         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
3744         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
3745         * Scripts/webkitpy/port/darwin.py: 
3746         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
3747         locally or when running archives.
3748         * Scripts/webkitpy/port/image_diff.py:
3749         (IOSSimulatorImageDiffer): Deleted.
3750         * Scripts/webkitpy/port/ios_simulator.py:
3751         (IOSSimulatorPort.diff_image): Deleted.
3752
3753 2017-05-05  Brian Burg  <bburg@apple.com>
3754
3755         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
3756         https://bugs.webkit.org/show_bug.cgi?id=171700
3757         <rdar://problem/32017975>
3758
3759         Reviewed by Brady Eidson.
3760
3761         Fix a mistake in the test that should have caught this bug.
3762
3763         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3764         (TEST):
3765         The assertions that were meant to check round-tripping were actually checking
3766         the properties of the original cookie objects, not the round-tripped ones.
3767         This test now fails without the bugfix and passes when it is applied.
3768
3769 2017-05-05  Daniel Bates  <dabates@apple.com>
3770
3771         Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests
3772         https://bugs.webkit.org/show_bug.cgi?id=171698
3773
3774         Reviewed by Darin Adler.
3775
3776         We should use EXPECT_EQ() instead of EXPECT_TRUE() to compare WTF::String() objects
3777         so that we get pretty diff output when the actual string differs from the expected
3778         string as opposed to seeing a boolean result. The former makes makes it straightforward
3779         to diagnose a regression without reading the code for the test or instrumenting it to
3780         determine the actual string that was compared.
3781
3782         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3783         (TestWebKitAPI::TEST):
3784         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
3785         (TestWebKitAPI::TEST_F):
3786         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
3787         (TestWebKitAPI::TEST_F):
3788
3789 2017-05-05  Chris Dumez  <cdumez@apple.com>
3790
3791         Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
3792         https://bugs.webkit.org/show_bug.cgi?id=171624
3793
3794         Reviewed by Dan Bernstein.
3795
3796         Extend API test coverage to cover crashes in addition to terminations requested by the client.
3797
3798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3799         * TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp.
3800         (TestWebKitAPI::webProcessWasTerminatedByClient):
3801         (TestWebKitAPI::webProcessCrashed):
3802         (TestWebKitAPI::TEST):
3803
3804 2017-05-04  Mark Lam  <mark.lam@apple.com>
3805
3806         DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
3807         https://bugs.webkit.org/show_bug.cgi?id=171716
3808         <rdar://problem/30878027>
3809
3810         Reviewed by Saam Barati.
3811
3812         setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which
3813         does JS conversion and therefore, potentially JS allocations) and accessing
3814         methods of internal JS data structures (which may do JS invocation, etc).
3815
3816         * DumpRenderTree/TestRunner.cpp:
3817         (setAudioResultCallback):
3818
3819 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
3820
3821         buildbot: Cleanup simulators after running tests
3822         https://bugs.webkit.org/show_bug.cgi?id=171679
3823         <rdar://problem/31994361>
3824
3825         Reviewed by Aakash Jain.
3826
3827         We shutdown the simulator process between tests, but in some cases, this is not
3828         sufficient. Explicitly shutdown every booted simulator.
3829
3830         * BuildSlaveSupport/kill-old-processes:
3831         (main): Shutdown all booted simulators.
3832
3833 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3834
3835         [GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext
3836         https://bugs.webkit.org/show_bug.cgi?id=171644
3837
3838         Reviewed by Michael Catanzaro.
3839
3840         Check that only one WebKitWebContext can have automation enabled.
3841
3842         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
3843         (testAutomationSessionRequestSession):
3844
3845 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3846
3847         [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
3848         https://bugs.webkit.org/show_bug.cgi?id=171724
3849
3850         Reviewed by Michael Catanzaro.
3851
3852         It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
3853
3854         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3855         (WTR::timeoutSource):
3856
3857 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3858
3859         Unreviewed. Fix wrong assert after r215176.
3860
3861         Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it
3862         could also be RGB24 when created from a web view snapshot.
3863
3864         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3865         (WTR::computeMD5HashStringForCairoSurface):
3866
3867 2017-05-04  Brian Burg  <bburg@apple.com>
3868
3869         lldb_webkit.py should provide a type summary for WebCore::URL
3870         https://bugs.webkit.org/show_bug.cgi?id=171670
3871
3872         Reviewed by Jer Noble.
3873
3874         Just print out the underlying string using the WTFString provider.
3875
3876         * lldb/lldb_webkit.py:
3877         (__lldb_init_module):
3878         (WebCoreURL_SummaryProvider):
3879         (WebCoreURLProvider):
3880         (WebCoreURLProvider.__init__):
3881         (WebCoreURLProvider.to_string):
3882
3883 2017-05-04  Commit Queue  <commit-queue@webkit.org>
3884
3885         Unreviewed, rolling out r216206.
3886         https://bugs.webkit.org/show_bug.cgi?id=171714
3887
3888         Multiple LayoutTests crashing in Document::page() (Requested
3889         by ap on #webkit).
3890
3891         Reverted changeset:
3892
3893         "Remove support for legacy Notifications"
3894         https://bugs.webkit.org/show_bug.cgi?id=171487
3895         http://trac.webkit.org/changeset/216206
3896
3897 2017-05-04  Mark Lam  <mark.lam@apple.com>
3898
3899         API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
3900         https://bugs.webkit.org/show_bug.cgi?id=171702
3901
3902         Reviewed by Filip Pizlo.
3903
3904         The test was supposed to use the MAKE_STATIC_STRING_IMPL macro.  I had previously
3905         changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
3906         confirm that the test will detect a regression.  Unfortunately, I forgot to
3907         change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
3908         This patch fixes that.
3909
3910         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3911         (TestWebKitAPI::neverDestroyedString):
3912
3913 2017-05-04  Ryan Haddad  <ryanhaddad@apple.com>
3914
3915         Disable failing API test WebKit2.ResizeWithHiddenContentDoesNotHang.
3916         https://bugs.webkit.org/show_bug.cgi?id=170195
3917
3918         Unreviewed test gardening.
3919
3920         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
3921         (TEST):
3922
3923 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
3924
3925         [Win] Remove redundant macros that are set in the CMake config
3926         https://bugs.webkit.org/show_bug.cgi?id=171571
3927
3928         Reviewed by Brent Fulgham.
3929
3930         * DumpRenderTree/config.h:
3931         * MiniBrowser/win/stdafx.h:
3932         * TestWebKitAPI/config.h:
3933
3934 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
3935
3936         Add testRunner.display() to force displaying the web page for testing
3937         https://bugs.webkit.org/show_bug.cgi?id=171694
3938
3939         Reviewed by Simon Fraser.
3940
3941         Unlike testRunner.displayAndTrackRepaints(), this new function forces 
3942         drawing the web page but without track repaints.
3943
3944         * DumpRenderTree/TestRunner.cpp:
3945         (displayCallback):
3946         (TestRunner::staticFunctions):
3947         * DumpRenderTree/TestRunner.h:
3948         * DumpRenderTree/mac/TestRunnerMac.mm:
3949         (TestRunner::display):
3950         * DumpRenderTree/win/TestRunnerWin.cpp:
3951         (TestRunner::display):
3952         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3953         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3954         (WTR::TestRunner::display):
3955         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3956
3957 2017-05-04  Mark Lam  <mark.lam@apple.com>
3958
3959         NeverDestroyed<String>(ASCIILiteral(...)) is not thread safe.
3960         https://bugs.webkit.org/show_bug.cgi?id=171586
3961         <rdar://problem/31873190>
3962
3963         Reviewed by Yusuke Suzuki.
3964
3965         API test for exercising StaticStringImpl and the MAKE_STATIC_STRING_IMPL macro.
3966
3967         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3968         (TestWebKitAPI::neverDestroyedString):
3969         (TestWebKitAPI::getNeverDestroyedStringAtStackDepth):
3970         (TestWebKitAPI::TEST):
3971
3972 2017-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3973
3974         [WK2] Add support for keeping the selection in a focused editable element when dragging begins
3975         https://bugs.webkit.org/show_bug.cgi?id=171585
3976         <rdar://problem/31544320>
3977
3978         Reviewed by Beth Dakin and Zalan Bujtas.
3979
3980         Adds 1 new unit test and tweaks existing tests to check that when first responder status is lost after beginning
3981         a drag while editing, content is still moved (and not copied) when performing data interaction on a different
3982         element. ContentEditableMoveParagraphs checks that content can be shifted within a single element via a move
3983         operation rather than a copy.
3984
3985         See WebCore ChangeLog for more details.
3986
3987         Tests:  DataInteractionSimulator.ContentEditableToContentEditable
3988                 DataInteractionSimulator.ContentEditableToTextarea
3989                 DataInteractionSimulator.ContentEditableMoveParagraphs
3990                 DataInteractionSimulator.TextAreaToInput
3991
3992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3993         * TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Added.
3994         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3995         (TestWebKitAPI::TEST):
3996         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3997         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3998         (-[DataInteractionSimulator initWithWebView:]):
3999         (-[DataInteractionSimulator dealloc]):
4000         (-[DataInteractionSimulator _advanceProgress]):
4001         (-[DataInteractionSimulator waitForInputSession]):
4002         (-[DataInteractionSimulator _webView:focusShouldStartInputSession:]):
4003         (-[DataInteractionSimulator _webView:didStartInputSession:]):
4004
4005 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
4006
4007         Rename TestRunner.display() to TestRunner::displayAndTrackRepaints()
4008         https://bugs.webkit.org/show_bug.cgi?id=171641
4009
4010         Reviewed by Simon Fraser.
4011
4012         The plan is to add back the TestRunner.display() which does the display
4013         only without track repaints.
4014
4015         * DumpRenderTree/DumpRenderTree.h:
4016         * DumpRenderTree/TestRunner.cpp:
4017         (displayAndTrackRepaintsCallback):
4018         (TestRunner::staticFunctions):
4019         (displayCallback): Deleted.
4020         (displayInvalidatedRegionCallback): Deleted.
4021         * DumpRenderTree/TestRunner.h:
4022         * DumpRenderTree/mac/DumpRenderTree.mm:
4023         (displayWebView):
4024         (displayAndTrackRepaintsWebView):
4025         * DumpRenderTree/mac/TestRunnerMac.mm:
4026         (TestRunner::displayAndTrackRepaints):
4027         (TestRunner::display): Deleted.
4028         * DumpRenderTree/win/TestRunnerWin.cpp:
4029         (TestRunner::displayAndTrackRepaints):
4030         (TestRunner::display): Deleted.
4031         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4032         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4033         (WTR::TestRunner::displayAndTrackRepaints):
4034         (WTR::TestRunner::display): Deleted.
4035         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4036
4037 2017-05-04  Brady Eidson  <beidson@apple.com>
4038
4039         [ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing.
4040         https://bugs.webkit.org/show_bug.cgi?id=171513
4041
4042         Unreviewed gardening.
4043
4044         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
4045         (TEST): Skip the failing parts of the test on iOS for now.
4046
4047 2017-05-03  Jonathan Bedard  <jbedard@apple.com>
4048
4049         Make ImageDiff stand-alone
4050         https://bugs.webkit.org/show_bug.cgi?id=168939
4051
4052         Reviewed by David Kilzer.
4053
4054         Create ImageDiff without dependencies on bmalloc and WTF so that it exists as a
4055         stand-alone project. Note that this change does not eliminate the ImageDiff inside
4056         the DumpRenderTree project.
4057
4058         * ImageDiff/ImageDiff.xcodeproj: Added.
4059         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj: Added.
4060         * ImageDiff/Makefile: Use ImageDiff project.
4061         * ImageDiff/PlatformMac.cmake: Added.
4062         * ImageDiff/PlatformWin.cmake: Added.
4063         * ImageDiff/cg: Added.
4064         * ImageDiff/cg/Configurations: Added.
4065         * ImageDiff/cg/Configurations/Base.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/Base.xcconfig.
4066         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig.
4067         * ImageDiff/cg/Configurations/ImageDiff.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig.
4068         * ImageDiff/cg/ImageDiff.cpp: Copied from Tools/DumpRenderTree/cg/ImageDiffCG.cpp.
4069         (createImageFromStdin): Stop using RetainPtr.
4070         (createDifferenceImage): Ditto.
4071         (main): Ditto.
4072         * Scripts/build-imagediff: Stop building WTF and bmalloc.
4073
4074 2017-05-04  Sam Weinig  <sam@webkit.org>
4075
4076         Remove support for legacy Notifications
4077         https://bugs.webkit.org/show_bug.cgi?id=171487
4078
4079         Reviewed by Jon Lee.
4080
4081         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
4082         (DRTDesktopNotificationPresenter::checkNotificationPermission):
4083         * Scripts/webkitperl/FeatureList.pm:
4084         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4085         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
4086
4087 2017-05-04  Andy Estes  <aestes@apple.com>
4088
4089         Give +testwebkitapi_configurationWithTestPlugInClassName: a shorter name
4090         https://bugs.webkit.org/show_bug.cgi?id=171673
4091
4092         Reviewed by Dan Bernstein.
4093
4094         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
4095         (TEST):
4096         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4097         (TEST):
4098         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
4099         (TEST):
4100         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
4101         (TEST):
4102         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
4103         (TEST):
4104         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
4105         (configurationWithContentFilterSettings):
4106         (-[LazilyLoadPlatformFrameworksController init]):
4107         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
4108         (TEST):
4109         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
4110         (runTestWithWidth):
4111         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
4112         (TEST):
4113         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4114         (TestWebKitAPI::TEST):
4115         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
4116         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
4117         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
4118         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Renamed to
4119         +_test_configurationWithTestPlugInClassName:
4120
4121 2017-05-04  Eric Carlson  <eric.carlson@apple.com>
4122
4123         [MediaStream] Allow host application to enable/disable media capture
4124         https://bugs.webkit.org/show_bug.cgi?id=171292
4125         <rdar://problem/31821492>
4126
4127         Reviewed by Jer Noble.
4128
4129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4130         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
4131         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
4132         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
4133         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4134         (MediaCaptureDisabledTest::SetUp):
4135         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4136         (TEST_F):
4137         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
4138
4139 2017-05-04  Caio Lima  <ticaiolima@gmail.com>
4140
4141         Unreviewed, Adding self to contributors.json
4142
4143         * Scripts/webkitpy/common/config/contributors.json: Added name.
4144
4145 2017-05-04  Konstantin Tokarev  <annulen@yandex.ru>
4146
4147         Fix compilation with ICU 59.1
4148         https://bugs.webkit.org/show_bug.cgi?id=171612
4149
4150         Reviewed by Mark Lam.
4151
4152         ICU 59.1 has broken source compatibility. Now it defines UChar as
4153         char16_t, which does not allow automatic type conversion from unsigned
4154         short in C++ code.
4155
4156         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
4157         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
4158
4159 2017-05-04  Andy Estes  <aestes@apple.com>
4160
4161         [Cocoa] Add an optional width parameter to -[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]
4162         https://bugs.webkit.org/show_bug.cgi?id=171646
4163         <rdar://problem/30306321>
4164
4165         Reviewed by Tim Horton.
4166
4167         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
4168         (runTestWithWidth):
4169         (TEST):
4170         (-[RenderedImageWithOptionsObject didRenderImageWithSize:]): Deleted.
4171         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm:
4172         (-[RenderedImageWithOptionsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4173         (-[RenderedImageWithOptionsPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
4174         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
4175         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h:
4176
4177 2017-05-04  Adrian Perez de Castro  <aperez@igalia.com>
4178
4179         [GTK] Fontconfig 2.11.2 in JHBuild does not build with glibc 2.25+ or gperf 3.1+
4180         https://bugs.webkit.org/show_bug.cgi?id=171649
4181
4182         Reviewed by Carlos Garcia Campos.
4183
4184         Add two patches picked from the upstream repository to fix building of
4185         the Fontconfig module in JHBuild. Additionally, this needed a patch to
4186         add "autogen.sh" as it is not included in release tarballs. Also:
4187         building the module with srcdir!=builddir prevents "fcobjshash.gperf"
4188         being regenerated (which is needed) so this is disabled for the
4189         Fontconfig module.
4190
4191         * gtk/jhbuild.modules:
4192         * gtk/patches/fontconfig-2.11.1-add-autogen.patch: Added.
4193         * gtk/patches/fontconfig-Avoid-conflicts-with-integer-width-macros-from-TS-18661-1-2014.patch: Added.
4194         * gtk/patches/fontconfig-Fix-the-build-issue-with-gperf-3.1.patch: Added.
4195
4196 2017-05-04  Commit Queue  <commit-queue@webkit.org>
4197
4198         Unreviewed, rolling out r216172.
4199         https://bugs.webkit.org/show_bug.cgi?id=171654
4200
4201         FTBFS for iOS due to missing WebPageProxy::stopMediaCapture()
4202         implementation. (Requested by ddkilzer on #webkit).
4203
4204         Reverted changeset:
4205
4206         "[MediaStream] Allow host application to enable/disable media
4207         capture"
4208         https://bugs.webkit.org/show_bug.cgi?id=171292
4209         http://trac.webkit.org/changeset/216172
4210
4211 2017-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4212
4213         [GTK] Bump GStreamer version to 1.10.4 in jhbuild
4214         https://bugs.webkit.org/show_bug.cgi?id=171595
4215
4216         Reviewed by Xabier Rodriguez-Calvar.
4217
4218         * gtk/jhbuild.modules:
4219         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
4220         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
4221         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Removed.
4222         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Removed.
4223         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
4224         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
4225         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
4226
4227 2017-05-03  Saam Barati  <sbarati@apple.com>
4228
4229         How we build polymorphic cases is wrong when making a call from Wasm
4230         https://bugs.webkit.org/show_bug.cgi?id=171527
4231
4232         Reviewed by JF Bastien.
4233
4234         * Scripts/run-jsc-stress-tests:
4235
4236 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
4237
4238         [MediaStream] Allow host application to enable/disable media capture
4239         https://bugs.webkit.org/show_bug.cgi?id=171292
4240         <rdar://problem/31821492>
4241
4242         Reviewed by Jer Noble.
4243
4244         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4245         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
4246         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
4247         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
4248         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4249         (MediaCaptureDisabledTest::SetUp):
4250         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4251         (TEST_F):
4252         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
4253
4254 2017-05-03  John Wilander  <wilander@apple.com>
4255
4256         Resource Load Statistics: Remove all statistics for modifiedSince website data removals
4257         https://bugs.webkit.org/show_bug.cgi?id=171584
4258         <rdar://problem/24702576>
4259
4260         Reviewed by Brent Fulgham.
4261
4262         New function to call the clear function that takes a modifiedSince parameter.
4263
4264         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4265         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4266         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
4267         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4268         * WebKitTestRunner/TestController.cpp:
4269         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
4270         * WebKitTestRunner/TestController.h:
4271         * WebKitTestRunner/TestInvocation.cpp:
4272         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4273